{"action":"created","comment":{"url":"https://api.github.com/repos/bbc/psammead/pulls/comments/269530886","pull_request_review_id":219420902,"id":269530886,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTUzMDg4Ng==","diff_hunk":"@@ -0,0 +1,38 @@\n+# Components to use utility function to get CSS for type groups\n+## ADR-0002\n+\n+Status: Proposed\n+* Deciders:\n+  * Articles Team\n+  * WS Team\n+* Date: 2019-03-18\n+\n+Technical Story:\n+\n+World Service has a UX requirement that GEL Type Styles (Canon, Long Primer, Double Pica, etc) should allow for mutable values of font size and line height across services. The possible permutations of such values were grouped into eight different 'scripts': arabic, burmese, cjk_thai, hindi_nepali_bengali, latin, mundo, sinhala, and tamil, as shown in the tabs of [this spreadsheet](https://docs.google.com/spreadsheets/d/1WMY-rlSbekhB4pV3ojMuYoWDC71Qs93CB2wTfDwAsJg/edit#gid=1458344872)\n+\n+Additionally, a ninth script that contains the default values GEL for all type groups is also required.\n+\n+## Context and Problem Statement\n+\n+Currently, Psammead uses a hard-coded set of constants that express the Type Sizes for each Type Style as defined by GEL. We need a way to make these type sizes mutable and mappable to different services.\n+\n+## Decision Drivers\n+\n+* Type Styles (Canon, Trafalgar, etc) must allow for different values across services\n+* Mappings for each style must be easily editable and updateable\n+* A component should be able to fetch the required CSS for a Type Style by invoking its name (Canon, Trafalgar) and its current script (arabic, mundo, etc)\n+\n+## Considered Options","path":"documentation/architecture-decision-records/ADR0002-type_groups.md","position":26,"original_position":26,"commit_id":"9a78abc2cb40823755e7e8c63a5c957d920d970b","original_commit_id":"9a78abc2cb40823755e7e8c63a5c957d920d970b","user":{"login":"dr3","id":11341355,"node_id":"MDQ6VXNlcjExMzQxMzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11341355?v=4","gravatar_id":"","url":"https://api.github.com/users/dr3","html_url":"https://github.com/dr3","followers_url":"https://api.github.com/users/dr3/followers","following_url":"https://api.github.com/users/dr3/following{/other_user}","gists_url":"https://api.github.com/users/dr3/gists{/gist_id}","starred_url":"https://api.github.com/users/dr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr3/subscriptions","organizations_url":"https://api.github.com/users/dr3/orgs","repos_url":"https://api.github.com/users/dr3/repos","events_url":"https://api.github.com/users/dr3/events{/privacy}","received_events_url":"https://api.github.com/users/dr3/received_events","type":"User","site_admin":false},"body":"Can you please talk about weight and tree shaking here","created_at":"2019-03-27T12:15:47Z","updated_at":"2019-03-27T12:15:50Z","html_url":"https://github.com/bbc/psammead/pull/364#discussion_r269530886","pull_request_url":"https://api.github.com/repos/bbc/psammead/pulls/364","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bbc/psammead/pulls/comments/269530886"},"html":{"href":"https://github.com/bbc/psammead/pull/364#discussion_r269530886"},"pull_request":{"href":"https://api.github.com/repos/bbc/psammead/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/bbc/psammead/pulls/364","id":262078107,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyMDc4MTA3","html_url":"https://github.com/bbc/psammead/pull/364","diff_url":"https://github.com/bbc/psammead/pull/364.diff","patch_url":"https://github.com/bbc/psammead/pull/364.patch","issue_url":"https://api.github.com/repos/bbc/psammead/issues/364","number":364,"state":"open","locked":false,"title":"React i18n library ADR","user":{"login":"mgurgel","id":115609,"node_id":"MDQ6VXNlcjExNTYwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/115609?v=4","gravatar_id":"","url":"https://api.github.com/users/mgurgel","html_url":"https://github.com/mgurgel","followers_url":"https://api.github.com/users/mgurgel/followers","following_url":"https://api.github.com/users/mgurgel/following{/other_user}","gists_url":"https://api.github.com/users/mgurgel/gists{/gist_id}","starred_url":"https://api.github.com/users/mgurgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgurgel/subscriptions","organizations_url":"https://api.github.com/users/mgurgel/orgs","repos_url":"https://api.github.com/users/mgurgel/repos","events_url":"https://api.github.com/users/mgurgel/events{/privacy}","received_events_url":"https://api.github.com/users/mgurgel/received_events","type":"User","site_admin":false},"body":"Resolves #357 and resolves #355\r\n\r\n**Overall change:** This PR introduces a folder for collecting ADRs and adds two existing ones to it\r\n\r\n**Code changes:**\r\n\r\n- Two new text files in `/documentation/architecture-decision-records`\r\n- _No code changes_\r\n\r\n---\r\n\r\n- [x] I have assigned myself to this PR and the corresponding issues\r\n- [ ] Tests added for new features\r\n- [ ] Test engineer approval","created_at":"2019-03-18T14:25:06Z","updated_at":"2019-03-27T12:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55a87b1f5c1e65e6a0eb6cc3425be9b5c9ad03dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"briankabiro","id":22860561,"node_id":"MDQ6VXNlcjIyODYwNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/22860561?v=4","gravatar_id":"","url":"https://api.github.com/users/briankabiro","html_url":"https://github.com/briankabiro","followers_url":"https://api.github.com/users/briankabiro/followers","following_url":"https://api.github.com/users/briankabiro/following{/other_user}","gists_url":"https://api.github.com/users/briankabiro/gists{/gist_id}","starred_url":"https://api.github.com/users/briankabiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briankabiro/subscriptions","organizations_url":"https://api.github.com/users/briankabiro/orgs","repos_url":"https://api.github.com/users/briankabiro/repos","events_url":"https://api.github.com/users/briankabiro/events{/privacy}","received_events_url":"https://api.github.com/users/briankabiro/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1258036916,"node_id":"MDU6TGFiZWwxMjU4MDM2OTE2","url":"https://api.github.com/repos/bbc/psammead/labels/WS%20Component%20Library","name":"WS Component Library","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bbc/psammead/pulls/364/commits","review_comments_url":"https://api.github.com/repos/bbc/psammead/pulls/364/comments","review_comment_url":"https://api.github.com/repos/bbc/psammead/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbc/psammead/issues/364/comments","statuses_url":"https://api.github.com/repos/bbc/psammead/statuses/9a78abc2cb40823755e7e8c63a5c957d920d970b","head":{"label":"bbc:adr","ref":"adr","sha":"9a78abc2cb40823755e7e8c63a5c957d920d970b","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":148457207,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0NTcyMDc=","name":"psammead","full_name":"bbc/psammead","private":false,"owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bbc/psammead","description":"React component library for BBC Articles and more","fork":false,"url":"https://api.github.com/repos/bbc/psammead","forks_url":"https://api.github.com/repos/bbc/psammead/forks","keys_url":"https://api.github.com/repos/bbc/psammead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/psammead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/psammead/teams","hooks_url":"https://api.github.com/repos/bbc/psammead/hooks","issue_events_url":"https://api.github.com/repos/bbc/psammead/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/psammead/events","assignees_url":"https://api.github.com/repos/bbc/psammead/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/psammead/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/psammead/tags","blobs_url":"https://api.github.com/repos/bbc/psammead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/psammead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/psammead/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/psammead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/psammead/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/psammead/languages","stargazers_url":"https://api.github.com/repos/bbc/psammead/stargazers","contributors_url":"https://api.github.com/repos/bbc/psammead/contributors","subscribers_url":"https://api.github.com/repos/bbc/psammead/subscribers","subscription_url":"https://api.github.com/repos/bbc/psammead/subscription","commits_url":"https://api.github.com/repos/bbc/psammead/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/psammead/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/psammead/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/psammead/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/psammead/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/psammead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/psammead/merges","archive_url":"https://api.github.com/repos/bbc/psammead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/psammead/downloads","issues_url":"https://api.github.com/repos/bbc/psammead/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/psammead/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/psammead/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/psammead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/psammead/labels{/name}","releases_url":"https://api.github.com/repos/bbc/psammead/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/psammead/deployments","created_at":"2018-09-12T09:41:04Z","updated_at":"2019-03-26T15:59:58Z","pushed_at":"2019-03-27T11:37:13Z","git_url":"git://github.com/bbc/psammead.git","ssh_url":"git@github.com:bbc/psammead.git","clone_url":"https://github.com/bbc/psammead.git","svn_url":"https://github.com/bbc/psammead","homepage":"https://bbc.github.io/psammead/","size":9962,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":74,"watchers":65,"default_branch":"latest"}},"base":{"label":"bbc:latest","ref":"latest","sha":"e89b097b86750c2d1e5dc64bc228265621c2d68a","user":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":148457207,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0NTcyMDc=","name":"psammead","full_name":"bbc/psammead","private":false,"owner":{"login":"bbc","id":828722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyODcyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bbc/psammead","description":"React component library for BBC Articles and more","fork":false,"url":"https://api.github.com/repos/bbc/psammead","forks_url":"https://api.github.com/repos/bbc/psammead/forks","keys_url":"https://api.github.com/repos/bbc/psammead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/psammead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/psammead/teams","hooks_url":"https://api.github.com/repos/bbc/psammead/hooks","issue_events_url":"https://api.github.com/repos/bbc/psammead/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/psammead/events","assignees_url":"https://api.github.com/repos/bbc/psammead/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/psammead/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/psammead/tags","blobs_url":"https://api.github.com/repos/bbc/psammead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/psammead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/psammead/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/psammead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/psammead/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/psammead/languages","stargazers_url":"https://api.github.com/repos/bbc/psammead/stargazers","contributors_url":"https://api.github.com/repos/bbc/psammead/contributors","subscribers_url":"https://api.github.com/repos/bbc/psammead/subscribers","subscription_url":"https://api.github.com/repos/bbc/psammead/subscription","commits_url":"https://api.github.com/repos/bbc/psammead/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/psammead/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/psammead/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/psammead/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/psammead/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/psammead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/psammead/merges","archive_url":"https://api.github.com/repos/bbc/psammead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/psammead/downloads","issues_url":"https://api.github.com/repos/bbc/psammead/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/psammead/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/psammead/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/psammead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/psammead/labels{/name}","releases_url":"https://api.github.com/repos/bbc/psammead/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/psammead/deployments","created_at":"2018-09-12T09:41:04Z","updated_at":"2019-03-26T15:59:58Z","pushed_at":"2019-03-27T11:37:13Z","git_url":"git://github.com/bbc/psammead.git","ssh_url":"git@github.com:bbc/psammead.git","clone_url":"https://github.com/bbc/psammead.git","svn_url":"https://github.com/bbc/psammead","homepage":"https://bbc.github.io/psammead/","size":9962,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":74,"watchers":65,"default_branch":"latest"}},"_links":{"self":{"href":"https://api.github.com/repos/bbc/psammead/pulls/364"},"html":{"href":"https://github.com/bbc/psammead/pull/364"},"issue":{"href":"https://api.github.com/repos/bbc/psammead/issues/364"},"comments":{"href":"https://api.github.com/repos/bbc/psammead/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/bbc/psammead/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/bbc/psammead/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbc/psammead/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/bbc/psammead/statuses/9a78abc2cb40823755e7e8c63a5c957d920d970b"}},"author_association":"NONE"}}
{"actor":{"display_login":"dr3"}}