{"action":"created","issue":{"url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/issues/211","repository_url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix","labels_url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/issues/211/comments","events_url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/issues/211/events","html_url":"https://github.com/CastagnaIT/plugin.video.netflix/pull/211","id":493541393,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NTAyODM3","number":211,"title":"Porting of PR \"Fix known Python 3 issues\"","user":{"login":"CastagnaIT","id":3257156,"node_id":"MDQ6VXNlcjMyNTcxNTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3257156?v=4","gravatar_id":"","url":"https://api.github.com/users/CastagnaIT","html_url":"https://github.com/CastagnaIT","followers_url":"https://api.github.com/users/CastagnaIT/followers","following_url":"https://api.github.com/users/CastagnaIT/following{/other_user}","gists_url":"https://api.github.com/users/CastagnaIT/gists{/gist_id}","starred_url":"https://api.github.com/users/CastagnaIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CastagnaIT/subscriptions","organizations_url":"https://api.github.com/users/CastagnaIT/orgs","repos_url":"https://api.github.com/users/CastagnaIT/repos","events_url":"https://api.github.com/users/CastagnaIT/events{/privacy}","received_events_url":"https://api.github.com/users/CastagnaIT/received_events","type":"User","site_admin":false},"labels":[{"id":1461728489,"node_id":"MDU6TGFiZWwxNDYxNzI4NDg5","url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/labels/WIP","name":"WIP","color":"4008ce","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2019-09-13T22:34:01Z","updated_at":"2019-09-16T18:30:01Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/pulls/211","html_url":"https://github.com/CastagnaIT/plugin.video.netflix/pull/211","diff_url":"https://github.com/CastagnaIT/plugin.video.netflix/pull/211.diff","patch_url":"https://github.com/CastagnaIT/plugin.video.netflix/pull/211.patch"},"body":"### Check if this PR fulfills these requirements:\r\n* [X] My changes respect the [Kodi add-on development rules](https://kodi.wiki/view/Add-on_rules)\r\n* [X] I have read the [**CONTRIBUTING**](Contributing.md) document.\r\n* [X] I made sure there wasn't another one [Pull Requests](../../pulls) opened for the same update/change\r\n* [X] I have successfully tested my changes locally\r\n\r\n#### Types of changes\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Feature change (non-breaking change which change behaviour of an existing functionality)\r\n- [X] Improvement (non-breaking change which improve functionality)\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Description\r\n<!--- Motivation and a possible detailed explanation of the changes -->\r\n<!--- Put your text below this line -->\r\nPorting of the PR #198 \r\nCorrections of the remaining errors and testing\r\n\r\n### In case of Feature change / Breaking change:\r\n#### Describe the current behavior\r\n<!--- Put your text below this line -->\r\n\r\n#### Describe the new behavior\r\n<!--- Put your text below this line -->\r\n\r\n### Screenshots (if appropriate):\r\n<!--- Add some screenshots if they can be useful to show the differences between before and after the changes -->\r\n"},"comment":{"url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/issues/comments/531900348","html_url":"https://github.com/CastagnaIT/plugin.video.netflix/pull/211#issuecomment-531900348","issue_url":"https://api.github.com/repos/CastagnaIT/plugin.video.netflix/issues/211","id":531900348,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMTkwMDM0OA==","user":{"login":"dagwieers","id":388198,"node_id":"MDQ6VXNlcjM4ODE5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/388198?v=4","gravatar_id":"","url":"https://api.github.com/users/dagwieers","html_url":"https://github.com/dagwieers","followers_url":"https://api.github.com/users/dagwieers/followers","following_url":"https://api.github.com/users/dagwieers/following{/other_user}","gists_url":"https://api.github.com/users/dagwieers/gists{/gist_id}","starred_url":"https://api.github.com/users/dagwieers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagwieers/subscriptions","organizations_url":"https://api.github.com/users/dagwieers/orgs","repos_url":"https://api.github.com/users/dagwieers/repos","events_url":"https://api.github.com/users/dagwieers/events{/privacy}","received_events_url":"https://api.github.com/users/dagwieers/received_events","type":"User","site_admin":false},"created_at":"2019-09-16T18:30:01Z","updated_at":"2019-09-16T18:30:01Z","author_association":"NONE","body":"Using `text()` was just a hack, I think we need to move to dedicated functions. Elsewhere we use this:\r\n```python\r\ndef to_unicode(text, encoding='utf-8'):\r\n    ''' Force text to unicode '''\r\n    return text.decode(encoding) if isinstance(text, bytes) else text\r\n\r\n\r\ndef from_unicode(text, encoding='utf-8'):\r\n    ''' Force unicode to text '''\r\n    import sys\r\n    if sys.version_info.major == 2 and isinstance(text, unicode):  # noqa: F821; pylint: disable=undefined-variable\r\n        return text.encode(encoding)\r\n    return text\r\n```\r\n\r\nI was planning to implement this, before my branch was hijacked ;-)"}}
{"actor":{"display_login":"dagwieers"}}