{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/312165385","pull_request_review_id":272736619,"id":312165385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjE2NTM4NQ==","diff_hunk":"@@ -16,9 +16,47 @@ limitations under the License.\n \n package mako\n \n+import (\n+\t\"context\"\n+\t\"fmt\"\n+\n+\t\"knative.dev/pkg/changeset\"\n+\t\"knative.dev/pkg/injection/clients/kubeclient\"\n+\t\"github.com/golang/protobuf/proto\"\n+        \"github.com/google/mako/helpers/go/quickstore\"\n+        qpb \"github.com/google/mako/helpers/proto/quickstore/quickstore_go_proto\"\n+)\n+\n const (\n \t// SidecarAddress is the address of the Mako sidecar to which we locally\n \t// write results, and it authenticates and publishes them to Mako after\n \t// assorted preprocessing.\n-\tSidecarAddress = \"localhost:9813\"\n+\tsidecarAddress = \"localhost:9813\"\n )\n+\n+// SetupMako sets up the mako client for the provided benchmarkKey.\n+// It will add a few common tags and allows each benchmark to add custm tags as well.\n+// It returns the mako client handle to sotre metrics, a method to close the connection\n+// to mako server once done and error if case of failures.\n+func SetupMako(ctx context.Context, benchmarkKey string, extraTags []string)(*quickstore.Quickstore, func(context.Context), error) {","path":"test/performance/mako/sidecar.go","position":27,"original_position":27,"commit_id":"61faa5dc182cfd8b32d12cfbcc8c8f1dd18ed65e","original_commit_id":"61faa5dc182cfd8b32d12cfbcc8c8f1dd18ed65e","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"body":"If you make extra tags variadic, then the callsites get simpler\r\n```suggestion\r\nfunc SetupMako(ctx context.Context, benchmarkKey string, extraTags ...string)(*quickstore.Quickstore, func(context.Context), error) {\r\n```","created_at":"2019-08-08T17:51:55Z","updated_at":"2019-08-08T17:55:55Z","html_url":"https://github.com/knative/serving/pull/5073#discussion_r312165385","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/5073","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/312165385"},"html":{"href":"https://github.com/knative/serving/pull/5073#discussion_r312165385"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/5073"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/5073","id":304799317,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0Nzk5MzE3","html_url":"https://github.com/knative/serving/pull/5073","diff_url":"https://github.com/knative/serving/pull/5073.diff","patch_url":"https://github.com/knative/serving/pull/5073.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/5073","number":5073,"state":"open","locked":false,"title":"Add a HEAD link to dataplane-prober kodata to get commitId","user":{"login":"srinivashegde86","id":2238582,"node_id":"MDQ6VXNlcjIyMzg1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2238582?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivashegde86","html_url":"https://github.com/srinivashegde86","followers_url":"https://api.github.com/users/srinivashegde86/followers","following_url":"https://api.github.com/users/srinivashegde86/following{/other_user}","gists_url":"https://api.github.com/users/srinivashegde86/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivashegde86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivashegde86/subscriptions","organizations_url":"https://api.github.com/users/srinivashegde86/orgs","repos_url":"https://api.github.com/users/srinivashegde86/repos","events_url":"https://api.github.com/users/srinivashegde86/events{/privacy}","received_events_url":"https://api.github.com/users/srinivashegde86/received_events","type":"User","site_admin":false},"body":"Also, update the dataplane -prober to add the latest commitId to the tags list for each run.","created_at":"2019-08-06T16:36:37Z","updated_at":"2019-08-08T17:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c20e14cbef460bff0f8bc9c7b1452c165977e73","assignee":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dgerd","id":43425586,"node_id":"MDQ6VXNlcjQzNDI1NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/43425586?v=4","gravatar_id":"","url":"https://api.github.com/users/dgerd","html_url":"https://github.com/dgerd","followers_url":"https://api.github.com/users/dgerd/followers","following_url":"https://api.github.com/users/dgerd/following{/other_user}","gists_url":"https://api.github.com/users/dgerd/gists{/gist_id}","starred_url":"https://api.github.com/users/dgerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgerd/subscriptions","organizations_url":"https://api.github.com/users/dgerd/orgs","repos_url":"https://api.github.com/users/dgerd/repos","events_url":"https://api.github.com/users/dgerd/events{/privacy}","received_events_url":"https://api.github.com/users/dgerd/received_events","type":"User","site_admin":false},{"login":"chaodaiG","id":45011425,"node_id":"MDQ6VXNlcjQ1MDExNDI1","avatar_url":"https://avatars0.githubusercontent.com/u/45011425?v=4","gravatar_id":"","url":"https://api.github.com/users/chaodaiG","html_url":"https://github.com/chaodaiG","followers_url":"https://api.github.com/users/chaodaiG/followers","following_url":"https://api.github.com/users/chaodaiG/following{/other_user}","gists_url":"https://api.github.com/users/chaodaiG/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodaiG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodaiG/subscriptions","organizations_url":"https://api.github.com/users/chaodaiG/orgs","repos_url":"https://api.github.com/users/chaodaiG/repos","events_url":"https://api.github.com/users/chaodaiG/events{/privacy}","received_events_url":"https://api.github.com/users/chaodaiG/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":874441804,"node_id":"MDU6TGFiZWw4NzQ0NDE4MDQ=","url":"https://api.github.com/repos/knative/serving/labels/area/test-and-release","name":"area/test-and-release","color":"daef5f","default":false},{"id":1294350338,"node_id":"MDU6TGFiZWwxMjk0MzUwMzM4","url":"https://api.github.com/repos/knative/serving/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":867084768,"node_id":"MDU6TGFiZWw4NjcwODQ3Njg=","url":"https://api.github.com/repos/knative/serving/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"b60205","default":false},{"id":859767870,"node_id":"MDU6TGFiZWw4NTk3Njc4NzA=","url":"https://api.github.com/repos/knative/serving/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/5073/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/5073/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/5073/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/61faa5dc182cfd8b32d12cfbcc8c8f1dd18ed65e","head":{"label":"srinivashegde86:get-commitId","ref":"get-commitId","sha":"61faa5dc182cfd8b32d12cfbcc8c8f1dd18ed65e","user":{"login":"srinivashegde86","id":2238582,"node_id":"MDQ6VXNlcjIyMzg1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2238582?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivashegde86","html_url":"https://github.com/srinivashegde86","followers_url":"https://api.github.com/users/srinivashegde86/followers","following_url":"https://api.github.com/users/srinivashegde86/following{/other_user}","gists_url":"https://api.github.com/users/srinivashegde86/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivashegde86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivashegde86/subscriptions","organizations_url":"https://api.github.com/users/srinivashegde86/orgs","repos_url":"https://api.github.com/users/srinivashegde86/repos","events_url":"https://api.github.com/users/srinivashegde86/events{/privacy}","received_events_url":"https://api.github.com/users/srinivashegde86/received_events","type":"User","site_admin":false},"repo":{"id":142191521,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxOTE1MjE=","name":"serving","full_name":"srinivashegde86/serving","private":false,"owner":{"login":"srinivashegde86","id":2238582,"node_id":"MDQ6VXNlcjIyMzg1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2238582?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivashegde86","html_url":"https://github.com/srinivashegde86","followers_url":"https://api.github.com/users/srinivashegde86/followers","following_url":"https://api.github.com/users/srinivashegde86/following{/other_user}","gists_url":"https://api.github.com/users/srinivashegde86/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivashegde86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivashegde86/subscriptions","organizations_url":"https://api.github.com/users/srinivashegde86/orgs","repos_url":"https://api.github.com/users/srinivashegde86/repos","events_url":"https://api.github.com/users/srinivashegde86/events{/privacy}","received_events_url":"https://api.github.com/users/srinivashegde86/received_events","type":"User","site_admin":false},"html_url":"https://github.com/srinivashegde86/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/srinivashegde86/serving","forks_url":"https://api.github.com/repos/srinivashegde86/serving/forks","keys_url":"https://api.github.com/repos/srinivashegde86/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srinivashegde86/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srinivashegde86/serving/teams","hooks_url":"https://api.github.com/repos/srinivashegde86/serving/hooks","issue_events_url":"https://api.github.com/repos/srinivashegde86/serving/issues/events{/number}","events_url":"https://api.github.com/repos/srinivashegde86/serving/events","assignees_url":"https://api.github.com/repos/srinivashegde86/serving/assignees{/user}","branches_url":"https://api.github.com/repos/srinivashegde86/serving/branches{/branch}","tags_url":"https://api.github.com/repos/srinivashegde86/serving/tags","blobs_url":"https://api.github.com/repos/srinivashegde86/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srinivashegde86/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srinivashegde86/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/srinivashegde86/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srinivashegde86/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/srinivashegde86/serving/languages","stargazers_url":"https://api.github.com/repos/srinivashegde86/serving/stargazers","contributors_url":"https://api.github.com/repos/srinivashegde86/serving/contributors","subscribers_url":"https://api.github.com/repos/srinivashegde86/serving/subscribers","subscription_url":"https://api.github.com/repos/srinivashegde86/serving/subscription","commits_url":"https://api.github.com/repos/srinivashegde86/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/srinivashegde86/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/srinivashegde86/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/srinivashegde86/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/srinivashegde86/serving/contents/{+path}","compare_url":"https://api.github.com/repos/srinivashegde86/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srinivashegde86/serving/merges","archive_url":"https://api.github.com/repos/srinivashegde86/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srinivashegde86/serving/downloads","issues_url":"https://api.github.com/repos/srinivashegde86/serving/issues{/number}","pulls_url":"https://api.github.com/repos/srinivashegde86/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/srinivashegde86/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/srinivashegde86/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srinivashegde86/serving/labels{/name}","releases_url":"https://api.github.com/repos/srinivashegde86/serving/releases{/id}","deployments_url":"https://api.github.com/repos/srinivashegde86/serving/deployments","created_at":"2018-07-24T17:29:56Z","updated_at":"2019-08-08T17:10:30Z","pushed_at":"2019-08-08T17:37:16Z","git_url":"git://github.com/srinivashegde86/serving.git","ssh_url":"git@github.com:srinivashegde86/serving.git","clone_url":"https://github.com/srinivashegde86/serving.git","svn_url":"https://github.com/srinivashegde86/serving","homepage":"","size":38789,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"1259d2bb9c2185d602386b893c16a19c159ca7b9","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2019-08-08T17:30:07Z","pushed_at":"2019-08-08T17:54:27Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"https://knative.dev/docs/serving/","size":38871,"stargazers_count":2137,"watchers_count":2137,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":276,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":411,"open_issues":276,"watchers":2137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/5073"},"html":{"href":"https://github.com/knative/serving/pull/5073"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/5073"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/5073/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/5073/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/5073/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/61faa5dc182cfd8b32d12cfbcc8c8f1dd18ed65e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattmoor"}}