{"action":"opened","issue":{"url":"https://api.github.com/repos/tc39/test262/issues/2392","repository_url":"https://api.github.com/repos/tc39/test262","labels_url":"https://api.github.com/repos/tc39/test262/issues/2392/labels{/name}","comments_url":"https://api.github.com/repos/tc39/test262/issues/2392/comments","events_url":"https://api.github.com/repos/tc39/test262/issues/2392/events","html_url":"https://github.com/tc39/test262/issues/2392","id":503019239,"node_id":"MDU6SXNzdWU1MDMwMTkyMzk=","number":2392,"title":"test/built-ins/FinalizationGroup/prototype/cleanupSome/poisoned-callback-throws.js issues","user":{"login":"mhofman","id":86499,"node_id":"MDQ6VXNlcjg2NDk5","avatar_url":"https://avatars3.githubusercontent.com/u/86499?v=4","gravatar_id":"","url":"https://api.github.com/users/mhofman","html_url":"https://github.com/mhofman","followers_url":"https://api.github.com/users/mhofman/followers","following_url":"https://api.github.com/users/mhofman/following{/other_user}","gists_url":"https://api.github.com/users/mhofman/gists{/gist_id}","starred_url":"https://api.github.com/users/mhofman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhofman/subscriptions","organizations_url":"https://api.github.com/users/mhofman/orgs","repos_url":"https://api.github.com/users/mhofman/repos","events_url":"https://api.github.com/users/mhofman/events{/privacy}","received_events_url":"https://api.github.com/users/mhofman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-10-05T21:35:47Z","updated_at":"2019-10-05T21:35:47Z","closed_at":null,"author_association":"NONE","body":"There 2 problems with [poisoned-callback-throws.js](https://github.com/tc39/test262/blob/08844700fe701dc4ef204ca14e140667ceb32ad4/test/built-ins/FinalizationGroup/prototype/cleanupSome/poisoned-callback-throws.js)\r\n- Line 58 has a typo [`iteraror`](https://github.com/tc39/test262/blob/08844700fe701dc4ef204ca14e140667ceb32ad4/test/built-ins/FinalizationGroup/prototype/cleanupSome/poisoned-callback-throws.js#L58). @leobalter mentioned in https://github.com/tc39/test262/pull/2353#issuecomment-533639401 that the typo was fixed in a followup commit, but the change doesn't seem to have made it.\r\n- I would argue that the whole section ([L57-L61](https://github.com/tc39/test262/blob/08844700fe701dc4ef204ca14e140667ceb32ad4/test/built-ins/FinalizationGroup/prototype/cleanupSome/poisoned-callback-throws.js#L57-L61)) about checking the iterator is superfluous for this test as it's already tested in [built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-job-not-active-throws](https://github.com/tc39/test262/blob/08844700fe701dc4ef204ca14e140667ceb32ad4/test/built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-job-not-active-throws.js). In particular v8 now passes the base test about bubbling the error, but fails the iterator part."}}
{"actor":{"display_login":"mhofman"}}