{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1490","repository_url":"https://api.github.com/repos/aws/aws-sdk-java-v2","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1490/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1490/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1490/events","html_url":"https://github.com/aws/aws-sdk-java-v2/issues/1490","id":513549979,"node_id":"MDU6SXNzdWU1MTM1NDk5Nzk=","number":1490,"title":"ProcessCredentialsProvider default processOutputLimit is too low","user":{"login":"RhodesBrownAmazon","id":57114139,"node_id":"MDQ6VXNlcjU3MTE0MTM5","avatar_url":"https://avatars3.githubusercontent.com/u/57114139?v=4","gravatar_id":"","url":"https://api.github.com/users/RhodesBrownAmazon","html_url":"https://github.com/RhodesBrownAmazon","followers_url":"https://api.github.com/users/RhodesBrownAmazon/followers","following_url":"https://api.github.com/users/RhodesBrownAmazon/following{/other_user}","gists_url":"https://api.github.com/users/RhodesBrownAmazon/gists{/gist_id}","starred_url":"https://api.github.com/users/RhodesBrownAmazon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RhodesBrownAmazon/subscriptions","organizations_url":"https://api.github.com/users/RhodesBrownAmazon/orgs","repos_url":"https://api.github.com/users/RhodesBrownAmazon/repos","events_url":"https://api.github.com/users/RhodesBrownAmazon/events{/privacy}","received_events_url":"https://api.github.com/users/RhodesBrownAmazon/received_events","type":"User","site_admin":false},"labels":[{"id":1326721000,"node_id":"MDU6TGFiZWwxMzI2NzIxMDAw","url":"https://api.github.com/repos/aws/aws-sdk-java-v2/labels/feature-request","name":"feature-request","color":"008672","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-10-28T20:49:29Z","updated_at":"2019-10-30T20:43:05Z","closed_at":null,"author_association":"NONE","body":"<!--- Provide a general summary of the issue in the Title above -->\r\nProcessCredentialsProvider.Builder uses a default value for processOutputLimit that is too restrictive when the command generates session credentials with a long session token.\r\nBecause the default is too small, uses in, for example aws-toolkit-jetbrains won't work.\r\n\r\n## Expected Behavior\r\n<!--- If you're describing a bug, tell us what should happen -->\r\n<!--- If you're suggesting a change/improvement, tell us how it should work -->\r\nBy default, allow at least 2048 bytes of output from a credentials generating command.\r\n\r\n## Current Behavior\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- Include full errors, uncaught exceptions, stack traces, and relevant logs -->\r\n<!--- To turn on SDK logging, follow instructions here: http://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/java-dg-logging.html -->\r\n<!--- If service responses are relevant, please include wirelogs -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\nWhen using builder default, ProcessCredentialsProvider.resolveCredentials() throws an exception for command input with, say, 1200b of JSON including the session token.\r\n\r\n## Possible Solution\r\n<!--- Not required, but suggest a fix/reason for the bug, -->\r\n<!--- or ideas how to implement the addition or change -->\r\nJust raise the default value to, say, 2048 bytes. Or, whatever would be a reasonable limit for credentials JSON that include session tokens as per https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#sourcing-credentials-from-external-processes\r\n\r\n## Steps to Reproduce (for bugs)\r\n<!--- Provide a self-contained, concise snippet of code that can be inserted into a -->\r\n<!--- For more complex issues provide a repo with the smallest sample that reproduces the bug -->\r\n<!--- Including business logic or unrelated code makes diagnosis more difficult -->\r\ndef provider = ProcessCredentialsProvider.builder()\r\n  .command('<generate JSON with more than 1024b of JSON, including session token>')\r\n  .build()\r\n  .resolveCredentials()\r\n\r\n## Context\r\n<!--- How has this issue affected you? What are you trying to accomplish? -->\r\n<!--- Providing context helps us come up with a solution that is most useful in the real world -->\r\nI cannot use the JetBrains AWS Toolkit plugin for IntelliJ with command-generated credentials that include a long session token.\r\n\r\nNote that the session credentials are coming from Amazon's Conduit system, if that provides any useful insight as to why the session tokens are large enough to break the default.\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment where the bug was discovered -->\r\n* AWS Java SDK version: The limit is clearly apparent in the source for 2.10.3-SNAPSHOT (https://github.com/aws/aws-sdk-java-v2/blob/master/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ProcessCredentialsProvider.java#L225)"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments/548103829","html_url":"https://github.com/aws/aws-sdk-java-v2/issues/1490#issuecomment-548103829","issue_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/1490","id":548103829,"node_id":"MDEyOklzc3VlQ29tbWVudDU0ODEwMzgyOQ==","user":{"login":"zoewangg","id":33073555,"node_id":"MDQ6VXNlcjMzMDczNTU1","avatar_url":"https://avatars3.githubusercontent.com/u/33073555?v=4","gravatar_id":"","url":"https://api.github.com/users/zoewangg","html_url":"https://github.com/zoewangg","followers_url":"https://api.github.com/users/zoewangg/followers","following_url":"https://api.github.com/users/zoewangg/following{/other_user}","gists_url":"https://api.github.com/users/zoewangg/gists{/gist_id}","starred_url":"https://api.github.com/users/zoewangg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoewangg/subscriptions","organizations_url":"https://api.github.com/users/zoewangg/orgs","repos_url":"https://api.github.com/users/zoewangg/repos","events_url":"https://api.github.com/users/zoewangg/events{/privacy}","received_events_url":"https://api.github.com/users/zoewangg/received_events","type":"User","site_admin":false},"created_at":"2019-10-30T20:43:05Z","updated_at":"2019-10-30T20:43:05Z","author_association":"CONTRIBUTOR","body":"Seems reasonable. Would you like to create a PR? :)"}}
{"actor":{"display_login":"zoewangg"}}