{"action":"created","comment":{"url":"https://api.github.com/repos/google/kf/pulls/comments/313001841","pull_request_review_id":273792309,"id":313001841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzAwMTg0MQ==","diff_hunk":"@@ -261,3 +269,58 @@ jobs:\n       run:\n         dir: kf-master\n         path: hack/upload-release.sh\n+\n+# Cut a new release of kf\n+# TODO: Consider semantic versioning resource:\n+# https://github.com/concourse/semver-resource#gcs-driver\n+# ATM, it seems like overkill and we should consider it when we are\n+# releasing in a more automated way.\n+- name: kf-release\n+  plan:\n+  - aggregate:\n+    - get: kf-master\n+      trigger: false\n+  - task: create-release\n+    config:\n+      platform: linux\n+      image_resource:\n+        type: docker-image\n+        source: *ci-image-source\n+      params:\n+        SERVICE_ACCOUNT_JSON: *release_service_account_json\n+        GCP_PROJECT_ID: *gcp_project_id\n+        KO_DOCKER_REPO: *ko_docker_release_repo\n+        RELEASE_BUCKET: *release_bucket\n+        CLI_RELEASE_BUCKET: *cli_release_bucket\n+        VERSION_MAJOR: 0\n+        VERSION_MINOR: 100","path":"ci/concourse/pipelines/kf-pipeline.yml","position":43,"original_position":43,"commit_id":"179e604127d1cb68104d8952c72c34d91d2a99db","original_commit_id":"179e604127d1cb68104d8952c72c34d91d2a99db","user":{"login":"poy","id":6554782,"node_id":"MDQ6VXNlcjY1NTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/6554782?v=4","gravatar_id":"","url":"https://api.github.com/users/poy","html_url":"https://github.com/poy","followers_url":"https://api.github.com/users/poy/followers","following_url":"https://api.github.com/users/poy/following{/other_user}","gists_url":"https://api.github.com/users/poy/gists{/gist_id}","starred_url":"https://api.github.com/users/poy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poy/subscriptions","organizations_url":"https://api.github.com/users/poy/orgs","repos_url":"https://api.github.com/users/poy/repos","events_url":"https://api.github.com/users/poy/events{/privacy}","received_events_url":"https://api.github.com/users/poy/received_events","type":"User","site_admin":false},"body":"Meaning the value is stored in credhub?","created_at":"2019-08-12T16:02:09Z","updated_at":"2019-08-12T16:02:09Z","html_url":"https://github.com/google/kf/pull/506#discussion_r313001841","pull_request_url":"https://api.github.com/repos/google/kf/pulls/506","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/kf/pulls/comments/313001841"},"html":{"href":"https://github.com/google/kf/pull/506#discussion_r313001841"},"pull_request":{"href":"https://api.github.com/repos/google/kf/pulls/506"}},"in_reply_to_id":312753991},"pull_request":{"url":"https://api.github.com/repos/google/kf/pulls/506","id":306261873,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2MjYxODcz","html_url":"https://github.com/google/kf/pull/506","diff_url":"https://github.com/google/kf/pull/506.diff","patch_url":"https://github.com/google/kf/pull/506.patch","issue_url":"https://api.github.com/repos/google/kf/issues/506","number":506,"state":"open","locked":false,"title":"ci/concourse/pipeline: adds release job","user":{"login":"poy","id":6554782,"node_id":"MDQ6VXNlcjY1NTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/6554782?v=4","gravatar_id":"","url":"https://api.github.com/users/poy","html_url":"https://github.com/poy","followers_url":"https://api.github.com/users/poy/followers","following_url":"https://api.github.com/users/poy/following{/other_user}","gists_url":"https://api.github.com/users/poy/gists{/gist_id}","starred_url":"https://api.github.com/users/poy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poy/subscriptions","organizations_url":"https://api.github.com/users/poy/orgs","repos_url":"https://api.github.com/users/poy/repos","events_url":"https://api.github.com/users/poy/events{/privacy}","received_events_url":"https://api.github.com/users/poy/received_events","type":"User","site_admin":false},"body":"This pipeline allows kf to deliver versions (e.g., 0.1). It will upload\r\na tag and release artifacts to github.\r\n\r\nrelated to #168 \r\n\r\n## Proposed Changes\r\n\r\n* Adds release job to concourse pipeline\r\n*\r\n*\r\n\r\n## Release Notes\r\n\r\n<!-- kf follows the Keep A Changelog standard for release notes.\r\n\r\nhttps://keepachangelog.com/en/1.0.0/\r\n\r\nChangelog entries should be one per line and start with one of the following\r\nwords:\r\n\r\n`Added` for new features.\r\n`Changed` for changes in existing functionality.\r\n`Deprecated` for soon-to-be removed features.\r\n`Removed` for now removed features.\r\n`Fixed` for any bug fixes.\r\n`Security` in case of vulnerabilities.\r\n\r\nIf one of the changes is breaking include that as a second word e.g.\r\n\r\n  Removed BREAKING support for manifests v1\r\n-->\r\n\r\n```release-note\r\nAdded new job in pipeline\r\n```\r\n","created_at":"2019-08-11T07:16:57Z","updated_at":"2019-08-12T16:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e04cd2061abeb6995d1dbf992b861a6e3aae3b91","assignee":{"login":"poy","id":6554782,"node_id":"MDQ6VXNlcjY1NTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/6554782?v=4","gravatar_id":"","url":"https://api.github.com/users/poy","html_url":"https://github.com/poy","followers_url":"https://api.github.com/users/poy/followers","following_url":"https://api.github.com/users/poy/following{/other_user}","gists_url":"https://api.github.com/users/poy/gists{/gist_id}","starred_url":"https://api.github.com/users/poy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poy/subscriptions","organizations_url":"https://api.github.com/users/poy/orgs","repos_url":"https://api.github.com/users/poy/repos","events_url":"https://api.github.com/users/poy/events{/privacy}","received_events_url":"https://api.github.com/users/poy/received_events","type":"User","site_admin":false},"assignees":[{"login":"poy","id":6554782,"node_id":"MDQ6VXNlcjY1NTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/6554782?v=4","gravatar_id":"","url":"https://api.github.com/users/poy","html_url":"https://github.com/poy","followers_url":"https://api.github.com/users/poy/followers","following_url":"https://api.github.com/users/poy/following{/other_user}","gists_url":"https://api.github.com/users/poy/gists{/gist_id}","starred_url":"https://api.github.com/users/poy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poy/subscriptions","organizations_url":"https://api.github.com/users/poy/orgs","repos_url":"https://api.github.com/users/poy/repos","events_url":"https://api.github.com/users/poy/events{/privacy}","received_events_url":"https://api.github.com/users/poy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"josephlewis42","id":696193,"node_id":"MDQ6VXNlcjY5NjE5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/696193?v=4","gravatar_id":"","url":"https://api.github.com/users/josephlewis42","html_url":"https://github.com/josephlewis42","followers_url":"https://api.github.com/users/josephlewis42/followers","following_url":"https://api.github.com/users/josephlewis42/following{/other_user}","gists_url":"https://api.github.com/users/josephlewis42/gists{/gist_id}","starred_url":"https://api.github.com/users/josephlewis42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephlewis42/subscriptions","organizations_url":"https://api.github.com/users/josephlewis42/orgs","repos_url":"https://api.github.com/users/josephlewis42/repos","events_url":"https://api.github.com/users/josephlewis42/events{/privacy}","received_events_url":"https://api.github.com/users/josephlewis42/received_events","type":"User","site_admin":false},{"login":"mattysweeps","id":3052324,"node_id":"MDQ6VXNlcjMwNTIzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3052324?v=4","gravatar_id":"","url":"https://api.github.com/users/mattysweeps","html_url":"https://github.com/mattysweeps","followers_url":"https://api.github.com/users/mattysweeps/followers","following_url":"https://api.github.com/users/mattysweeps/following{/other_user}","gists_url":"https://api.github.com/users/mattysweeps/gists{/gist_id}","starred_url":"https://api.github.com/users/mattysweeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattysweeps/subscriptions","organizations_url":"https://api.github.com/users/mattysweeps/orgs","repos_url":"https://api.github.com/users/mattysweeps/repos","events_url":"https://api.github.com/users/mattysweeps/events{/privacy}","received_events_url":"https://api.github.com/users/mattysweeps/received_events","type":"User","site_admin":false},{"login":"juliaguo","id":6687054,"node_id":"MDQ6VXNlcjY2ODcwNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6687054?v=4","gravatar_id":"","url":"https://api.github.com/users/juliaguo","html_url":"https://github.com/juliaguo","followers_url":"https://api.github.com/users/juliaguo/followers","following_url":"https://api.github.com/users/juliaguo/following{/other_user}","gists_url":"https://api.github.com/users/juliaguo/gists{/gist_id}","starred_url":"https://api.github.com/users/juliaguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliaguo/subscriptions","organizations_url":"https://api.github.com/users/juliaguo/orgs","repos_url":"https://api.github.com/users/juliaguo/repos","events_url":"https://api.github.com/users/juliaguo/events{/privacy}","received_events_url":"https://api.github.com/users/juliaguo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1380772264,"node_id":"MDU6TGFiZWwxMzgwNzcyMjY0","url":"https://api.github.com/repos/google/kf/labels/cla:%20yes","name":"cla: yes","color":"63dd94","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/kf/pulls/506/commits","review_comments_url":"https://api.github.com/repos/google/kf/pulls/506/comments","review_comment_url":"https://api.github.com/repos/google/kf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/kf/issues/506/comments","statuses_url":"https://api.github.com/repos/google/kf/statuses/179e604127d1cb68104d8952c72c34d91d2a99db","head":{"label":"google:feature/168","ref":"feature/168","sha":"179e604127d1cb68104d8952c72c34d91d2a99db","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":184312842,"node_id":"MDEwOlJlcG9zaXRvcnkxODQzMTI4NDI=","name":"kf","full_name":"google/kf","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/kf","description":"`kf` provides `cf` users a familiar workflow experience on top of Knative.","fork":false,"url":"https://api.github.com/repos/google/kf","forks_url":"https://api.github.com/repos/google/kf/forks","keys_url":"https://api.github.com/repos/google/kf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/kf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/kf/teams","hooks_url":"https://api.github.com/repos/google/kf/hooks","issue_events_url":"https://api.github.com/repos/google/kf/issues/events{/number}","events_url":"https://api.github.com/repos/google/kf/events","assignees_url":"https://api.github.com/repos/google/kf/assignees{/user}","branches_url":"https://api.github.com/repos/google/kf/branches{/branch}","tags_url":"https://api.github.com/repos/google/kf/tags","blobs_url":"https://api.github.com/repos/google/kf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/kf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/kf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/kf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/kf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/kf/languages","stargazers_url":"https://api.github.com/repos/google/kf/stargazers","contributors_url":"https://api.github.com/repos/google/kf/contributors","subscribers_url":"https://api.github.com/repos/google/kf/subscribers","subscription_url":"https://api.github.com/repos/google/kf/subscription","commits_url":"https://api.github.com/repos/google/kf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/kf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/kf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/kf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/kf/contents/{+path}","compare_url":"https://api.github.com/repos/google/kf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/kf/merges","archive_url":"https://api.github.com/repos/google/kf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/kf/downloads","issues_url":"https://api.github.com/repos/google/kf/issues{/number}","pulls_url":"https://api.github.com/repos/google/kf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/kf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/kf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/kf/labels{/name}","releases_url":"https://api.github.com/repos/google/kf/releases{/id}","deployments_url":"https://api.github.com/repos/google/kf/deployments","created_at":"2019-04-30T18:34:38Z","updated_at":"2019-08-12T16:00:41Z","pushed_at":"2019-08-12T16:00:38Z","git_url":"git://github.com/google/kf.git","ssh_url":"git@github.com:google/kf.git","clone_url":"https://github.com/google/kf.git","svn_url":"https://github.com/google/kf","homepage":"","size":18155,"stargazers_count":80,"watchers_count":80,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":130,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":130,"watchers":80,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"80942000715c66f05a53065c3c4e255ae0d36fb5","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":184312842,"node_id":"MDEwOlJlcG9zaXRvcnkxODQzMTI4NDI=","name":"kf","full_name":"google/kf","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/kf","description":"`kf` provides `cf` users a familiar workflow experience on top of Knative.","fork":false,"url":"https://api.github.com/repos/google/kf","forks_url":"https://api.github.com/repos/google/kf/forks","keys_url":"https://api.github.com/repos/google/kf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/kf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/kf/teams","hooks_url":"https://api.github.com/repos/google/kf/hooks","issue_events_url":"https://api.github.com/repos/google/kf/issues/events{/number}","events_url":"https://api.github.com/repos/google/kf/events","assignees_url":"https://api.github.com/repos/google/kf/assignees{/user}","branches_url":"https://api.github.com/repos/google/kf/branches{/branch}","tags_url":"https://api.github.com/repos/google/kf/tags","blobs_url":"https://api.github.com/repos/google/kf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/kf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/kf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/kf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/kf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/kf/languages","stargazers_url":"https://api.github.com/repos/google/kf/stargazers","contributors_url":"https://api.github.com/repos/google/kf/contributors","subscribers_url":"https://api.github.com/repos/google/kf/subscribers","subscription_url":"https://api.github.com/repos/google/kf/subscription","commits_url":"https://api.github.com/repos/google/kf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/kf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/kf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/kf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/kf/contents/{+path}","compare_url":"https://api.github.com/repos/google/kf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/kf/merges","archive_url":"https://api.github.com/repos/google/kf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/kf/downloads","issues_url":"https://api.github.com/repos/google/kf/issues{/number}","pulls_url":"https://api.github.com/repos/google/kf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/kf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/kf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/kf/labels{/name}","releases_url":"https://api.github.com/repos/google/kf/releases{/id}","deployments_url":"https://api.github.com/repos/google/kf/deployments","created_at":"2019-04-30T18:34:38Z","updated_at":"2019-08-12T16:00:41Z","pushed_at":"2019-08-12T16:00:38Z","git_url":"git://github.com/google/kf.git","ssh_url":"git@github.com:google/kf.git","clone_url":"https://github.com/google/kf.git","svn_url":"https://github.com/google/kf","homepage":"","size":18155,"stargazers_count":80,"watchers_count":80,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":130,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":130,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/kf/pulls/506"},"html":{"href":"https://github.com/google/kf/pull/506"},"issue":{"href":"https://api.github.com/repos/google/kf/issues/506"},"comments":{"href":"https://api.github.com/repos/google/kf/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/google/kf/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/google/kf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/kf/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/google/kf/statuses/179e604127d1cb68104d8952c72c34d91d2a99db"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"poy"}}