{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/256080384","pull_request_review_id":202825345,"id":256080384,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjA4MDM4NA==","diff_hunk":"@@ -5,9 +5,25 @@\n \n   &Wrapper {\n     width: 640px;\n+\n+    @include internetExplorerOnly() {\n+      min-height: 1px;\n+    }\n   }\n \n   &Actions {\n     padding-top: $euiSizeM;\n   }\n+\n+  &ImagePreview > img {","path":"src/legacy/core_plugins/kibana/public/management/sections/settings/advanced_settings.scss","position":14,"original_position":14,"commit_id":"a2cd5efd4803e4cf4c475a5961935e0e943aff12","original_commit_id":"a2cd5efd4803e4cf4c475a5961935e0e943aff12","user":{"login":"cchaos","id":549577,"node_id":"MDQ6VXNlcjU0OTU3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/549577?v=4","gravatar_id":"","url":"https://api.github.com/users/cchaos","html_url":"https://github.com/cchaos","followers_url":"https://api.github.com/users/cchaos/followers","following_url":"https://api.github.com/users/cchaos/following{/other_user}","gists_url":"https://api.github.com/users/cchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/cchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cchaos/subscriptions","organizations_url":"https://api.github.com/users/cchaos/orgs","repos_url":"https://api.github.com/users/cchaos/repos","events_url":"https://api.github.com/users/cchaos/events{/privacy}","received_events_url":"https://api.github.com/users/cchaos/received_events","type":"User","site_admin":false},"body":"I would just err on not overriding EUI, and this will be updated automatically when that issue is addressed. It's quite an edge case that I don't think we need to worrry about at the moment.","created_at":"2019-02-12T18:11:43Z","updated_at":"2019-02-12T18:11:44Z","html_url":"https://github.com/elastic/kibana/pull/30654#discussion_r256080384","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/30654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/256080384"},"html":{"href":"https://github.com/elastic/kibana/pull/30654#discussion_r256080384"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/30654"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/30654","id":251959978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxOTU5OTc4","html_url":"https://github.com/elastic/kibana/pull/30654","diff_url":"https://github.com/elastic/kibana/pull/30654.diff","patch_url":"https://github.com/elastic/kibana/pull/30654.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/30654","number":30654,"state":"open","locked":false,"title":"Fix management footer logo spacing bug","user":{"login":"flash1293","id":1508364,"node_id":"MDQ6VXNlcjE1MDgzNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1508364?v=4","gravatar_id":"","url":"https://api.github.com/users/flash1293","html_url":"https://github.com/flash1293","followers_url":"https://api.github.com/users/flash1293/followers","following_url":"https://api.github.com/users/flash1293/following{/other_user}","gists_url":"https://api.github.com/users/flash1293/gists{/gist_id}","starred_url":"https://api.github.com/users/flash1293/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flash1293/subscriptions","organizations_url":"https://api.github.com/users/flash1293/orgs","repos_url":"https://api.github.com/users/flash1293/repos","events_url":"https://api.github.com/users/flash1293/events{/privacy}","received_events_url":"https://api.github.com/users/flash1293/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/22222\r\n\r\nThis PR fixes the problem of the above issue by setting a fixed value to the height of the preview image.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)\r\n~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~\r\n~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~\r\n~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~\r\n~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~\r\n\r\n### For maintainers\r\n\r\n~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~\r\n~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~\r\n\r\n","created_at":"2019-02-11T15:40:10Z","updated_at":"2019-02-12T18:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cd6b53e18faaa0efd79b90695aec2574dc310cd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},{"login":"lizozom","id":3016806,"node_id":"MDQ6VXNlcjMwMTY4MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/3016806?v=4","gravatar_id":"","url":"https://api.github.com/users/lizozom","html_url":"https://github.com/lizozom","followers_url":"https://api.github.com/users/lizozom/followers","following_url":"https://api.github.com/users/lizozom/following{/other_user}","gists_url":"https://api.github.com/users/lizozom/gists{/gist_id}","starred_url":"https://api.github.com/users/lizozom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizozom/subscriptions","organizations_url":"https://api.github.com/users/lizozom/orgs","repos_url":"https://api.github.com/users/lizozom/repos","events_url":"https://api.github.com/users/lizozom/events{/privacy}","received_events_url":"https://api.github.com/users/lizozom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1135234582,"node_id":"MDU6TGFiZWwxMTM1MjM0NTgy","url":"https://api.github.com/repos/elastic/kibana/labels/:Kibana%20Management","name":":Kibana Management","color":"0e8a16","default":false},{"id":1055842724,"node_id":"MDU6TGFiZWwxMDU1ODQyNzI0","url":"https://api.github.com/repos/elastic/kibana/labels/:KibanaApp","name":":KibanaApp","color":"fef2c0","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false},{"id":1212928780,"node_id":"MDU6TGFiZWwxMjEyOTI4Nzgw","url":"https://api.github.com/repos/elastic/kibana/labels/v7.1.0","name":"v7.1.0","color":"ffffff","default":false},{"id":1124458249,"node_id":"MDU6TGFiZWwxMTI0NDU4MjQ5","url":"https://api.github.com/repos/elastic/kibana/labels/v8.0.0","name":"v8.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/30654/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/30654/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/30654/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/a2cd5efd4803e4cf4c475a5961935e0e943aff12","head":{"label":"flash1293:fix/custom-logo-ie","ref":"fix/custom-logo-ie","sha":"a2cd5efd4803e4cf4c475a5961935e0e943aff12","user":{"login":"flash1293","id":1508364,"node_id":"MDQ6VXNlcjE1MDgzNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1508364?v=4","gravatar_id":"","url":"https://api.github.com/users/flash1293","html_url":"https://github.com/flash1293","followers_url":"https://api.github.com/users/flash1293/followers","following_url":"https://api.github.com/users/flash1293/following{/other_user}","gists_url":"https://api.github.com/users/flash1293/gists{/gist_id}","starred_url":"https://api.github.com/users/flash1293/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flash1293/subscriptions","organizations_url":"https://api.github.com/users/flash1293/orgs","repos_url":"https://api.github.com/users/flash1293/repos","events_url":"https://api.github.com/users/flash1293/events{/privacy}","received_events_url":"https://api.github.com/users/flash1293/received_events","type":"User","site_admin":false},"repo":{"id":168713660,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg3MTM2NjA=","name":"kibana","full_name":"flash1293/kibana","private":false,"owner":{"login":"flash1293","id":1508364,"node_id":"MDQ6VXNlcjE1MDgzNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1508364?v=4","gravatar_id":"","url":"https://api.github.com/users/flash1293","html_url":"https://github.com/flash1293","followers_url":"https://api.github.com/users/flash1293/followers","following_url":"https://api.github.com/users/flash1293/following{/other_user}","gists_url":"https://api.github.com/users/flash1293/gists{/gist_id}","starred_url":"https://api.github.com/users/flash1293/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flash1293/subscriptions","organizations_url":"https://api.github.com/users/flash1293/orgs","repos_url":"https://api.github.com/users/flash1293/repos","events_url":"https://api.github.com/users/flash1293/events{/privacy}","received_events_url":"https://api.github.com/users/flash1293/received_events","type":"User","site_admin":false},"html_url":"https://github.com/flash1293/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/flash1293/kibana","forks_url":"https://api.github.com/repos/flash1293/kibana/forks","keys_url":"https://api.github.com/repos/flash1293/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flash1293/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flash1293/kibana/teams","hooks_url":"https://api.github.com/repos/flash1293/kibana/hooks","issue_events_url":"https://api.github.com/repos/flash1293/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/flash1293/kibana/events","assignees_url":"https://api.github.com/repos/flash1293/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/flash1293/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/flash1293/kibana/tags","blobs_url":"https://api.github.com/repos/flash1293/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flash1293/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flash1293/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/flash1293/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flash1293/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/flash1293/kibana/languages","stargazers_url":"https://api.github.com/repos/flash1293/kibana/stargazers","contributors_url":"https://api.github.com/repos/flash1293/kibana/contributors","subscribers_url":"https://api.github.com/repos/flash1293/kibana/subscribers","subscription_url":"https://api.github.com/repos/flash1293/kibana/subscription","commits_url":"https://api.github.com/repos/flash1293/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/flash1293/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/flash1293/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/flash1293/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/flash1293/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/flash1293/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flash1293/kibana/merges","archive_url":"https://api.github.com/repos/flash1293/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flash1293/kibana/downloads","issues_url":"https://api.github.com/repos/flash1293/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/flash1293/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/flash1293/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/flash1293/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flash1293/kibana/labels{/name}","releases_url":"https://api.github.com/repos/flash1293/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/flash1293/kibana/deployments","created_at":"2019-02-01T14:58:33Z","updated_at":"2019-02-11T15:50:28Z","pushed_at":"2019-02-12T16:45:29Z","git_url":"git://github.com/flash1293/kibana.git","ssh_url":"git@github.com:flash1293/kibana.git","clone_url":"https://github.com/flash1293/kibana.git","svn_url":"https://github.com/flash1293/kibana","homepage":"https://www.elastic.co/products/kibana","size":680790,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7d5d59e7443bdebcc550fa739bece344cdb4967c","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-02-12T16:56:57Z","pushed_at":"2019-02-12T18:11:37Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":681980,"stargazers_count":11074,"watchers_count":11074,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4340,"mirror_url":null,"archived":false,"open_issues_count":4216,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4340,"open_issues":4216,"watchers":11074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/30654"},"html":{"href":"https://github.com/elastic/kibana/pull/30654"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/30654"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/30654/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/30654/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/30654/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/a2cd5efd4803e4cf4c475a5961935e0e943aff12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cchaos"}}