{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments/267597494","pull_request_review_id":217044811,"id":267597494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzU5NzQ5NA==","diff_hunk":"@@ -177,34 +177,37 @@ template <typename T, size_t N>\n constexpr size_t countof(T (&)[N]) { return N; }\n \n struct MyCustomKernel {\n-  MyCustomKernel(OrtKernelInfo& /*info*/) {\n+  MyCustomKernel(const OrtCustomOpApi& api, OrtKernelInfo& /*info*/) : api_(api) {\n   }\n \n   void GetOutputShape(OrtValue** inputs, size_t /*input_count*/, size_t /*output_index*/, OrtTensorTypeAndShapeInfo* info) {\n-    OrtTensorDimensions dimensions(inputs[0]);\n-    ORT_THROW_ON_ERROR(OrtSetDims(info, dimensions.data(), dimensions.size()));\n+    OrtTensorDimensions dimensions(api_, inputs[0]);\n+    ORT_THROW_ON_ERROR(api_.OrtSetDims(info, dimensions.data(), dimensions.size()));\n   }\n \n   void Compute(OrtValue** inputs, size_t /*input_count*/, OrtValue** outputs, size_t /*output_count*/) {\n     const float* X;\n     const float* Y;\n-    ORT_THROW_ON_ERROR(OrtGetTensorMutableData(inputs[0], reinterpret_cast<void**>(const_cast<float**>(&X))));\n-    ORT_THROW_ON_ERROR(OrtGetTensorMutableData(inputs[1], reinterpret_cast<void**>(const_cast<float**>(&Y))));\n+    ORT_THROW_ON_ERROR(api_.OrtGetTensorMutableData(inputs[0], reinterpret_cast<void**>(const_cast<float**>(&X))));","path":"onnxruntime/test/shared_lib/test_inference.cc","position":null,"original_position":39,"commit_id":"b42ff0875eee901931d0679a4788e1fba654e590","original_commit_id":"6e1e088d855f4457fe5231ab7fb7265fb56d3d63","user":{"login":"RyanUnderhill","id":38674843,"node_id":"MDQ6VXNlcjM4Njc0ODQz","avatar_url":"https://avatars0.githubusercontent.com/u/38674843?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanUnderhill","html_url":"https://github.com/RyanUnderhill","followers_url":"https://api.github.com/users/RyanUnderhill/followers","following_url":"https://api.github.com/users/RyanUnderhill/following{/other_user}","gists_url":"https://api.github.com/users/RyanUnderhill/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanUnderhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanUnderhill/subscriptions","organizations_url":"https://api.github.com/users/RyanUnderhill/orgs","repos_url":"https://api.github.com/users/RyanUnderhill/repos","events_url":"https://api.github.com/users/RyanUnderhill/events{/privacy}","received_events_url":"https://api.github.com/users/RyanUnderhill/received_events","type":"User","site_admin":false},"body":"I made a small renaming change to help a bit.","created_at":"2019-03-21T00:36:55Z","updated_at":"2019-03-21T00:36:55Z","html_url":"https://github.com/Microsoft/onnxruntime/pull/668#discussion_r267597494","pull_request_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments/267597494"},"html":{"href":"https://github.com/Microsoft/onnxruntime/pull/668#discussion_r267597494"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668"}},"in_reply_to_id":267594009},"pull_request":{"url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668","id":263077638,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMDc3NjM4","html_url":"https://github.com/Microsoft/onnxruntime/pull/668","diff_url":"https://github.com/Microsoft/onnxruntime/pull/668.diff","patch_url":"https://github.com/Microsoft/onnxruntime/pull/668.patch","issue_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/668","number":668,"state":"open","locked":false,"title":"Custom op interface to the C API to remove shared library dependency","user":{"login":"RyanUnderhill","id":38674843,"node_id":"MDQ6VXNlcjM4Njc0ODQz","avatar_url":"https://avatars0.githubusercontent.com/u/38674843?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanUnderhill","html_url":"https://github.com/RyanUnderhill","followers_url":"https://api.github.com/users/RyanUnderhill/followers","following_url":"https://api.github.com/users/RyanUnderhill/following{/other_user}","gists_url":"https://api.github.com/users/RyanUnderhill/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanUnderhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanUnderhill/subscriptions","organizations_url":"https://api.github.com/users/RyanUnderhill/orgs","repos_url":"https://api.github.com/users/RyanUnderhill/repos","events_url":"https://api.github.com/users/RyanUnderhill/events{/privacy}","received_events_url":"https://api.github.com/users/RyanUnderhill/received_events","type":"User","site_admin":false},"body":"It's not complete yet but this is to get feedback before going further","created_at":"2019-03-20T23:52:46Z","updated_at":"2019-03-21T00:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90feab6d570b7c5b2fc01173cbc78562dd547d79","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yuanbyu","id":2342391,"node_id":"MDQ6VXNlcjIzNDIzOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2342391?v=4","gravatar_id":"","url":"https://api.github.com/users/yuanbyu","html_url":"https://github.com/yuanbyu","followers_url":"https://api.github.com/users/yuanbyu/followers","following_url":"https://api.github.com/users/yuanbyu/following{/other_user}","gists_url":"https://api.github.com/users/yuanbyu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuanbyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuanbyu/subscriptions","organizations_url":"https://api.github.com/users/yuanbyu/orgs","repos_url":"https://api.github.com/users/yuanbyu/repos","events_url":"https://api.github.com/users/yuanbyu/events{/privacy}","received_events_url":"https://api.github.com/users/yuanbyu/received_events","type":"User","site_admin":false},{"login":"pranavsharma","id":2732907,"node_id":"MDQ6VXNlcjI3MzI5MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/2732907?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavsharma","html_url":"https://github.com/pranavsharma","followers_url":"https://api.github.com/users/pranavsharma/followers","following_url":"https://api.github.com/users/pranavsharma/following{/other_user}","gists_url":"https://api.github.com/users/pranavsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavsharma/subscriptions","organizations_url":"https://api.github.com/users/pranavsharma/orgs","repos_url":"https://api.github.com/users/pranavsharma/repos","events_url":"https://api.github.com/users/pranavsharma/events{/privacy}","received_events_url":"https://api.github.com/users/pranavsharma/received_events","type":"User","site_admin":false},{"login":"linkerzhang","id":5194557,"node_id":"MDQ6VXNlcjUxOTQ1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5194557?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerzhang","html_url":"https://github.com/linkerzhang","followers_url":"https://api.github.com/users/linkerzhang/followers","following_url":"https://api.github.com/users/linkerzhang/following{/other_user}","gists_url":"https://api.github.com/users/linkerzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerzhang/subscriptions","organizations_url":"https://api.github.com/users/linkerzhang/orgs","repos_url":"https://api.github.com/users/linkerzhang/repos","events_url":"https://api.github.com/users/linkerzhang/events{/privacy}","received_events_url":"https://api.github.com/users/linkerzhang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668/commits","review_comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668/comments","review_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/668/comments","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/b42ff0875eee901931d0679a4788e1fba654e590","head":{"label":"Microsoft:ryanunderhill/custom_op3","ref":"ryanunderhill/custom_op3","sha":"b42ff0875eee901931d0679a4788e1fba654e590","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":156939672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5Mzk2NzI=","name":"onnxruntime","full_name":"Microsoft/onnxruntime","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/onnxruntime","description":"ONNX Runtime: cross-platform, high performance scoring engine for ML models","fork":false,"url":"https://api.github.com/repos/Microsoft/onnxruntime","forks_url":"https://api.github.com/repos/Microsoft/onnxruntime/forks","keys_url":"https://api.github.com/repos/Microsoft/onnxruntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/onnxruntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/onnxruntime/teams","hooks_url":"https://api.github.com/repos/Microsoft/onnxruntime/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/onnxruntime/events","assignees_url":"https://api.github.com/repos/Microsoft/onnxruntime/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/onnxruntime/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/tags","blobs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/onnxruntime/languages","stargazers_url":"https://api.github.com/repos/Microsoft/onnxruntime/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/onnxruntime/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscription","commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/onnxruntime/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/onnxruntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/onnxruntime/merges","archive_url":"https://api.github.com/repos/Microsoft/onnxruntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/onnxruntime/downloads","issues_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/onnxruntime/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/onnxruntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/onnxruntime/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/onnxruntime/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/onnxruntime/deployments","created_at":"2018-11-10T02:22:53Z","updated_at":"2019-03-21T00:14:53Z","pushed_at":"2019-03-21T00:36:53Z","git_url":"git://github.com/Microsoft/onnxruntime.git","ssh_url":"git@github.com:Microsoft/onnxruntime.git","clone_url":"https://github.com/Microsoft/onnxruntime.git","svn_url":"https://github.com/Microsoft/onnxruntime","homepage":"","size":31616,"stargazers_count":609,"watchers_count":609,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":52,"watchers":609,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"819457dd45976a39e26b6f564d104fa9790cd9c5","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":156939672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5Mzk2NzI=","name":"onnxruntime","full_name":"Microsoft/onnxruntime","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/onnxruntime","description":"ONNX Runtime: cross-platform, high performance scoring engine for ML models","fork":false,"url":"https://api.github.com/repos/Microsoft/onnxruntime","forks_url":"https://api.github.com/repos/Microsoft/onnxruntime/forks","keys_url":"https://api.github.com/repos/Microsoft/onnxruntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/onnxruntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/onnxruntime/teams","hooks_url":"https://api.github.com/repos/Microsoft/onnxruntime/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/onnxruntime/events","assignees_url":"https://api.github.com/repos/Microsoft/onnxruntime/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/onnxruntime/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/tags","blobs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/onnxruntime/languages","stargazers_url":"https://api.github.com/repos/Microsoft/onnxruntime/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/onnxruntime/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/onnxruntime/subscription","commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/onnxruntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/onnxruntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/onnxruntime/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/onnxruntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/onnxruntime/merges","archive_url":"https://api.github.com/repos/Microsoft/onnxruntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/onnxruntime/downloads","issues_url":"https://api.github.com/repos/Microsoft/onnxruntime/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/onnxruntime/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/onnxruntime/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/onnxruntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/onnxruntime/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/onnxruntime/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/onnxruntime/deployments","created_at":"2018-11-10T02:22:53Z","updated_at":"2019-03-21T00:14:53Z","pushed_at":"2019-03-21T00:36:53Z","git_url":"git://github.com/Microsoft/onnxruntime.git","ssh_url":"git@github.com:Microsoft/onnxruntime.git","clone_url":"https://github.com/Microsoft/onnxruntime.git","svn_url":"https://github.com/Microsoft/onnxruntime","homepage":"","size":31616,"stargazers_count":609,"watchers_count":609,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":52,"watchers":609,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668"},"html":{"href":"https://github.com/Microsoft/onnxruntime/pull/668"},"issue":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/issues/668"},"comments":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/onnxruntime/statuses/b42ff0875eee901931d0679a4788e1fba654e590"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RyanUnderhill"}}