{"action":"created","issue":{"url":"https://api.github.com/repos/jonas-schievink/rubble/issues/38","repository_url":"https://api.github.com/repos/jonas-schievink/rubble","labels_url":"https://api.github.com/repos/jonas-schievink/rubble/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/jonas-schievink/rubble/issues/38/comments","events_url":"https://api.github.com/repos/jonas-schievink/rubble/issues/38/events","html_url":"https://github.com/jonas-schievink/rubble/issues/38","id":428938525,"node_id":"MDU6SXNzdWU0Mjg5Mzg1MjU=","number":38,"title":"Use company identifiers in LL_VERSION_IND","user":{"login":"chocol4te","id":8290136,"node_id":"MDQ6VXNlcjgyOTAxMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8290136?v=4","gravatar_id":"","url":"https://api.github.com/users/chocol4te","html_url":"https://github.com/chocol4te","followers_url":"https://api.github.com/users/chocol4te/followers","following_url":"https://api.github.com/users/chocol4te/following{/other_user}","gists_url":"https://api.github.com/users/chocol4te/gists{/gist_id}","starred_url":"https://api.github.com/users/chocol4te/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocol4te/subscriptions","organizations_url":"https://api.github.com/users/chocol4te/orgs","repos_url":"https://api.github.com/users/chocol4te/repos","events_url":"https://api.github.com/users/chocol4te/events{/privacy}","received_events_url":"https://api.github.com/users/chocol4te/received_events","type":"User","site_admin":false},"labels":[{"id":1299663950,"node_id":"MDU6TGFiZWwxMjk5NjYzOTUw","url":"https://api.github.com/repos/jonas-schievink/rubble/labels/area:%20link%20layer","name":"area: link layer","color":"4e6ea0","default":false},{"id":1299661131,"node_id":"MDU6TGFiZWwxMjk5NjYxMTMx","url":"https://api.github.com/repos/jonas-schievink/rubble/labels/status:%20needs%20code","name":"status: needs code","color":"ab6420","default":false},{"id":1299648584,"node_id":"MDU6TGFiZWwxMjk5NjQ4NTg0","url":"https://api.github.com/repos/jonas-schievink/rubble/labels/type:%20enhancement","name":"type: enhancement","color":"f5f1fd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-04-03T19:34:30Z","updated_at":"2019-04-03T22:01:31Z","closed_at":null,"author_association":"COLLABORATOR","body":"Currently a `Hex<u16>` is used to represent `CompId`, this should be an enum of company identifiers which implements `.as_u16()`.\r\n\r\nThe full list can be found here:\r\nhttps://www.bluetooth.com/specifications/assigned-numbers/company-identifiers"},"comment":{"url":"https://api.github.com/repos/jonas-schievink/rubble/issues/comments/479674859","html_url":"https://github.com/jonas-schievink/rubble/issues/38#issuecomment-479674859","issue_url":"https://api.github.com/repos/jonas-schievink/rubble/issues/38","id":479674859,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3OTY3NDg1OQ==","user":{"login":"jonas-schievink","id":1786438,"node_id":"MDQ6VXNlcjE3ODY0Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1786438?v=4","gravatar_id":"","url":"https://api.github.com/users/jonas-schievink","html_url":"https://github.com/jonas-schievink","followers_url":"https://api.github.com/users/jonas-schievink/followers","following_url":"https://api.github.com/users/jonas-schievink/following{/other_user}","gists_url":"https://api.github.com/users/jonas-schievink/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas-schievink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas-schievink/subscriptions","organizations_url":"https://api.github.com/users/jonas-schievink/orgs","repos_url":"https://api.github.com/users/jonas-schievink/repos","events_url":"https://api.github.com/users/jonas-schievink/events{/privacy}","received_events_url":"https://api.github.com/users/jonas-schievink/received_events","type":"User","site_admin":false},"created_at":"2019-04-03T22:01:31Z","updated_at":"2019-04-03T22:01:31Z","author_association":"OWNER","body":"Alternatively it could also be a `struct CompanyId(u16);` with associated constants for the companies. I'm not sure which is better yet (the enum would need an additional `Unknown` variant carrying the raw `u16`, and also a `#[doc(hidden)]` variant for extensibility since `#[non_exhaustive]` is not yet stable).\r\n\r\nIn any case it should also get a `.name()` function that returns the exact company identifier from the bluetooth.com list above.\r\n\r\nA `fmt::Display` implementation would also be neat."}}
{"actor":{"display_login":"jonas-schievink"}}