{"action":"created","issue":{"url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form/issues/223","repository_url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form","labels_url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form/issues/223/comments","events_url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form/issues/223/events","html_url":"https://github.com/guillotinaweb/ngx-schema-form/issues/223","id":339371889,"node_id":"MDU6SXNzdWUzMzkzNzE4ODk=","number":223,"title":"Support of prefixed schema extensions","user":{"login":"WhileTrueEndWhile","id":33146321,"node_id":"MDQ6VXNlcjMzMTQ2MzIx","avatar_url":"https://avatars2.githubusercontent.com/u/33146321?v=4","gravatar_id":"","url":"https://api.github.com/users/WhileTrueEndWhile","html_url":"https://github.com/WhileTrueEndWhile","followers_url":"https://api.github.com/users/WhileTrueEndWhile/followers","following_url":"https://api.github.com/users/WhileTrueEndWhile/following{/other_user}","gists_url":"https://api.github.com/users/WhileTrueEndWhile/gists{/gist_id}","starred_url":"https://api.github.com/users/WhileTrueEndWhile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhileTrueEndWhile/subscriptions","organizations_url":"https://api.github.com/users/WhileTrueEndWhile/orgs","repos_url":"https://api.github.com/users/WhileTrueEndWhile/repos","events_url":"https://api.github.com/users/WhileTrueEndWhile/events{/privacy}","received_events_url":"https://api.github.com/users/WhileTrueEndWhile/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-07-09T09:27:27Z","updated_at":"2019-02-05T21:00:23Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi there,\r\n\r\nin order to better distinguish schema extensions from standardized keywords, I think it would make sense to **add** compliant alternative names. Thus, no old code needs to be changed and new code can clearly distinguish between schema and extension.\r\n\r\nLooks like three key words are involved:\r\n\r\n| Name | Prefixed Name | \r\n| ---- | ---- |\r\n| fieldsets  | x-field-sets\r\n| widget | x-widget\r\n| visibleIf | x-visible-if\r\n\r\n(I hope the list is complete...)\r\n\r\nThe reason why I write this is that I want to create the schemas from Java POJOs (at first only out of curiosity). There it would be very unclean, in my opinion, to define such properties without a prefix there. If there is any interest in this topic, I will gladly report on it.\r\n\r\nMoreover, I have unfortunately not found the code, which e.g. makes a `{ \"widget\": { \"id\": \"string\" }` from `{ \"widget\": \"string\" }`. I don't know if I could do an implementation without help. Alternatively I could of course run a crappy recursive algorithm over the schema ;-)\r\n\r\nThanks in advance!"},"comment":{"url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form/issues/comments/460801575","html_url":"https://github.com/guillotinaweb/ngx-schema-form/issues/223#issuecomment-460801575","issue_url":"https://api.github.com/repos/guillotinaweb/ngx-schema-form/issues/223","id":460801575,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MDgwMTU3NQ==","user":{"login":"WhileTrueEndWhile","id":33146321,"node_id":"MDQ6VXNlcjMzMTQ2MzIx","avatar_url":"https://avatars2.githubusercontent.com/u/33146321?v=4","gravatar_id":"","url":"https://api.github.com/users/WhileTrueEndWhile","html_url":"https://github.com/WhileTrueEndWhile","followers_url":"https://api.github.com/users/WhileTrueEndWhile/followers","following_url":"https://api.github.com/users/WhileTrueEndWhile/following{/other_user}","gists_url":"https://api.github.com/users/WhileTrueEndWhile/gists{/gist_id}","starred_url":"https://api.github.com/users/WhileTrueEndWhile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhileTrueEndWhile/subscriptions","organizations_url":"https://api.github.com/users/WhileTrueEndWhile/orgs","repos_url":"https://api.github.com/users/WhileTrueEndWhile/repos","events_url":"https://api.github.com/users/WhileTrueEndWhile/events{/privacy}","received_events_url":"https://api.github.com/users/WhileTrueEndWhile/received_events","type":"User","site_admin":false},"created_at":"2019-02-05T21:00:23Z","updated_at":"2019-02-05T21:00:23Z","author_association":"CONTRIBUTOR","body":"**Thank you very much for the great work!**\r\n\r\nI have two more additions:\r\nhttps://github.com/guillotinaweb/ngx-schema-form/compare/master...WhileTrueEndWhile:master#files_bucket\r\n\r\n*formelement.component.ts*: With your own widget registry, setting the validation state CSS classes at this level is more than superfluous. In order not to break legacy code, it would be useful to define an optional property that deactivates it. **Is there a way to access the global schema at this point?**\r\n\r\n*schemapreprocessor.ts*: The stupid copying of the \"dependencies\" property as \"visibleIf\" has already been discussed and is probably not priority 1 ;-)"}}
{"actor":{"display_login":"WhileTrueEndWhile"}}