{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/awx/pulls/comments/295909031","pull_request_review_id":252421786,"id":295909031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTkwOTAzMQ==","diff_hunk":"@@ -59,12 +59,15 @@ export default ['Wait', 'GetBasePath', 'ProcessErrors', 'Rest', 'GetChoices',\n                     callback: 'choicesReadyNotifierList'\n                 });\n \n-                _.map(columns, function(column){\n-                    var notifier_url = url + id + column;\n+            _.map(columns, function(column){\n+                var notifier_url = url + id + column;\n                     Rest.setUrl(notifier_url);\n                     Rest.get()\n                         .then(function(response) {\n-                            var type = (response.config.url.indexOf('success')>0) ? \"notification_templates_success\" : \"notification_templates_error\";\n+                            let checkForSuccessOrError = response.config.url.indexOf('success')>0 ? \"notification_templates_success\" : \"notification_templates_error\";\n+\n+                            let type = response.config.url.indexOf('started')>0? \"notification_templates_started\" : checkForSuccessOrError","path":"awx/ui/client/src/notifications/shared/notification-list-init.factory.js","position":23,"original_position":23,"commit_id":"a7c787af0274bb6bda57b687cc208fc7ff30e295","original_commit_id":"a7c787af0274bb6bda57b687cc208fc7ff30e295","user":{"login":"jlmitch5","id":1342624,"node_id":"MDQ6VXNlcjEzNDI2MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1342624?v=4","gravatar_id":"","url":"https://api.github.com/users/jlmitch5","html_url":"https://github.com/jlmitch5","followers_url":"https://api.github.com/users/jlmitch5/followers","following_url":"https://api.github.com/users/jlmitch5/following{/other_user}","gists_url":"https://api.github.com/users/jlmitch5/gists{/gist_id}","starred_url":"https://api.github.com/users/jlmitch5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlmitch5/subscriptions","organizations_url":"https://api.github.com/users/jlmitch5/orgs","repos_url":"https://api.github.com/users/jlmitch5/repos","events_url":"https://api.github.com/users/jlmitch5/events{/privacy}","received_events_url":"https://api.github.com/users/jlmitch5/received_events","type":"User","site_admin":false},"body":"this line is also missing a semicolon","created_at":"2019-06-20T17:13:43Z","updated_at":"2019-06-20T17:15:30Z","html_url":"https://github.com/ansible/awx/pull/4103#discussion_r295909031","pull_request_url":"https://api.github.com/repos/ansible/awx/pulls/4103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/awx/pulls/comments/295909031"},"html":{"href":"https://github.com/ansible/awx/pull/4103#discussion_r295909031"},"pull_request":{"href":"https://api.github.com/repos/ansible/awx/pulls/4103"}},"in_reply_to_id":295908767},"pull_request":{"url":"https://api.github.com/repos/ansible/awx/pulls/4103","id":289457072,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5NDU3MDcy","html_url":"https://github.com/ansible/awx/pull/4103","diff_url":"https://github.com/ansible/awx/pull/4103.diff","patch_url":"https://github.com/ansible/awx/pull/4103.patch","issue_url":"https://api.github.com/repos/ansible/awx/issues/4103","number":4103,"state":"open","locked":false,"title":"Adds notify on start toggle","user":{"login":"AlexSCorey","id":39280967,"node_id":"MDQ6VXNlcjM5MjgwOTY3","avatar_url":"https://avatars2.githubusercontent.com/u/39280967?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSCorey","html_url":"https://github.com/AlexSCorey","followers_url":"https://api.github.com/users/AlexSCorey/followers","following_url":"https://api.github.com/users/AlexSCorey/following{/other_user}","gists_url":"https://api.github.com/users/AlexSCorey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSCorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSCorey/subscriptions","organizations_url":"https://api.github.com/users/AlexSCorey/orgs","repos_url":"https://api.github.com/users/AlexSCorey/repos","events_url":"https://api.github.com/users/AlexSCorey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSCorey/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nThis addresses https://github.com/ansible/awx/issues/79.  It adds a toggle to the notifications list that allows the user to receive notification when their job starts.  \r\n\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n - UI\r\n\r\n##### AWX VERSION\r\n```\r\n4.0.0\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\n<img width=\"1510\" alt=\"Screen Shot 2019-06-18 at 5 14 46 PM\" src=\"https://user-images.githubusercontent.com/39280967/59720507-0fced280-91ed-11e9-82ef-29a9acbb6dba.png\">\r\n<img width=\"1490\" alt=\"Screen Shot 2019-06-18 at 5 14 53 PM\" src=\"https://user-images.githubusercontent.com/39280967/59720510-10ffff80-91ed-11e9-8069-c0226c05a4d7.png\">\r\n\r\n","created_at":"2019-06-18T21:18:48Z","updated_at":"2019-06-20T17:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ef484cfeda494b7ca0a96537beb6d9f5836d704","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":687169295,"node_id":"MDU6TGFiZWw2ODcxNjkyOTU=","url":"https://api.github.com/repos/ansible/awx/labels/component:ui","name":"component:ui","color":"009800","default":false},{"id":686203630,"node_id":"MDU6TGFiZWw2ODYyMDM2MzA=","url":"https://api.github.com/repos/ansible/awx/labels/state:in_progress","name":"state:in_progress","color":"BCF5A9","default":false},{"id":607283750,"node_id":"MDU6TGFiZWw2MDcyODM3NTA=","url":"https://api.github.com/repos/ansible/awx/labels/type:enhancement","name":"type:enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/awx/pulls/4103/commits","review_comments_url":"https://api.github.com/repos/ansible/awx/pulls/4103/comments","review_comment_url":"https://api.github.com/repos/ansible/awx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/awx/issues/4103/comments","statuses_url":"https://api.github.com/repos/ansible/awx/statuses/a7c787af0274bb6bda57b687cc208fc7ff30e295","head":{"label":"AlexSCorey:79-NotifyOnJobStart","ref":"79-NotifyOnJobStart","sha":"a7c787af0274bb6bda57b687cc208fc7ff30e295","user":{"login":"AlexSCorey","id":39280967,"node_id":"MDQ6VXNlcjM5MjgwOTY3","avatar_url":"https://avatars2.githubusercontent.com/u/39280967?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSCorey","html_url":"https://github.com/AlexSCorey","followers_url":"https://api.github.com/users/AlexSCorey/followers","following_url":"https://api.github.com/users/AlexSCorey/following{/other_user}","gists_url":"https://api.github.com/users/AlexSCorey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSCorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSCorey/subscriptions","organizations_url":"https://api.github.com/users/AlexSCorey/orgs","repos_url":"https://api.github.com/users/AlexSCorey/repos","events_url":"https://api.github.com/users/AlexSCorey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSCorey/received_events","type":"User","site_admin":false},"repo":{"id":171529429,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE1Mjk0Mjk=","name":"awx","full_name":"AlexSCorey/awx","private":false,"owner":{"login":"AlexSCorey","id":39280967,"node_id":"MDQ6VXNlcjM5MjgwOTY3","avatar_url":"https://avatars2.githubusercontent.com/u/39280967?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSCorey","html_url":"https://github.com/AlexSCorey","followers_url":"https://api.github.com/users/AlexSCorey/followers","following_url":"https://api.github.com/users/AlexSCorey/following{/other_user}","gists_url":"https://api.github.com/users/AlexSCorey/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSCorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSCorey/subscriptions","organizations_url":"https://api.github.com/users/AlexSCorey/orgs","repos_url":"https://api.github.com/users/AlexSCorey/repos","events_url":"https://api.github.com/users/AlexSCorey/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSCorey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlexSCorey/awx","description":"AWX Project","fork":true,"url":"https://api.github.com/repos/AlexSCorey/awx","forks_url":"https://api.github.com/repos/AlexSCorey/awx/forks","keys_url":"https://api.github.com/repos/AlexSCorey/awx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexSCorey/awx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexSCorey/awx/teams","hooks_url":"https://api.github.com/repos/AlexSCorey/awx/hooks","issue_events_url":"https://api.github.com/repos/AlexSCorey/awx/issues/events{/number}","events_url":"https://api.github.com/repos/AlexSCorey/awx/events","assignees_url":"https://api.github.com/repos/AlexSCorey/awx/assignees{/user}","branches_url":"https://api.github.com/repos/AlexSCorey/awx/branches{/branch}","tags_url":"https://api.github.com/repos/AlexSCorey/awx/tags","blobs_url":"https://api.github.com/repos/AlexSCorey/awx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexSCorey/awx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexSCorey/awx/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexSCorey/awx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexSCorey/awx/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexSCorey/awx/languages","stargazers_url":"https://api.github.com/repos/AlexSCorey/awx/stargazers","contributors_url":"https://api.github.com/repos/AlexSCorey/awx/contributors","subscribers_url":"https://api.github.com/repos/AlexSCorey/awx/subscribers","subscription_url":"https://api.github.com/repos/AlexSCorey/awx/subscription","commits_url":"https://api.github.com/repos/AlexSCorey/awx/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexSCorey/awx/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexSCorey/awx/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexSCorey/awx/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexSCorey/awx/contents/{+path}","compare_url":"https://api.github.com/repos/AlexSCorey/awx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexSCorey/awx/merges","archive_url":"https://api.github.com/repos/AlexSCorey/awx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexSCorey/awx/downloads","issues_url":"https://api.github.com/repos/AlexSCorey/awx/issues{/number}","pulls_url":"https://api.github.com/repos/AlexSCorey/awx/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexSCorey/awx/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexSCorey/awx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexSCorey/awx/labels{/name}","releases_url":"https://api.github.com/repos/AlexSCorey/awx/releases{/id}","deployments_url":"https://api.github.com/repos/AlexSCorey/awx/deployments","created_at":"2019-02-19T18:43:37Z","updated_at":"2019-03-14T11:56:43Z","pushed_at":"2019-06-20T17:07:30Z","git_url":"git://github.com/AlexSCorey/awx.git","ssh_url":"git@github.com:AlexSCorey/awx.git","clone_url":"https://github.com/AlexSCorey/awx.git","svn_url":"https://github.com/AlexSCorey/awx","homepage":"","size":215052,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"e269634afc9386807ceaf56a61f7f0fad6671bf0","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":91594105,"node_id":"MDEwOlJlcG9zaXRvcnk5MTU5NDEwNQ==","name":"awx","full_name":"ansible/awx","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/awx","description":"AWX Project","fork":false,"url":"https://api.github.com/repos/ansible/awx","forks_url":"https://api.github.com/repos/ansible/awx/forks","keys_url":"https://api.github.com/repos/ansible/awx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/awx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/awx/teams","hooks_url":"https://api.github.com/repos/ansible/awx/hooks","issue_events_url":"https://api.github.com/repos/ansible/awx/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/awx/events","assignees_url":"https://api.github.com/repos/ansible/awx/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/awx/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/awx/tags","blobs_url":"https://api.github.com/repos/ansible/awx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/awx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/awx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/awx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/awx/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/awx/languages","stargazers_url":"https://api.github.com/repos/ansible/awx/stargazers","contributors_url":"https://api.github.com/repos/ansible/awx/contributors","subscribers_url":"https://api.github.com/repos/ansible/awx/subscribers","subscription_url":"https://api.github.com/repos/ansible/awx/subscription","commits_url":"https://api.github.com/repos/ansible/awx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/awx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/awx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/awx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/awx/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/awx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/awx/merges","archive_url":"https://api.github.com/repos/ansible/awx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/awx/downloads","issues_url":"https://api.github.com/repos/ansible/awx/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/awx/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/awx/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/awx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/awx/labels{/name}","releases_url":"https://api.github.com/repos/ansible/awx/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/awx/deployments","created_at":"2017-05-17T15:50:14Z","updated_at":"2019-06-20T15:23:53Z","pushed_at":"2019-06-20T17:07:35Z","git_url":"git://github.com/ansible/awx.git","ssh_url":"git@github.com:ansible/awx.git","clone_url":"https://github.com/ansible/awx.git","svn_url":"https://github.com/ansible/awx","homepage":"","size":214940,"stargazers_count":6060,"watchers_count":6060,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1361,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":669,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1361,"open_issues":669,"watchers":6060,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/awx/pulls/4103"},"html":{"href":"https://github.com/ansible/awx/pull/4103"},"issue":{"href":"https://api.github.com/repos/ansible/awx/issues/4103"},"comments":{"href":"https://api.github.com/repos/ansible/awx/issues/4103/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/awx/pulls/4103/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/awx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/awx/pulls/4103/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/awx/statuses/a7c787af0274bb6bda57b687cc208fc7ff30e295"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlmitch5"}}