{"action":"created","comment":{"url":"https://api.github.com/repos/Tomm0017/rsmod/pulls/comments/269686616","pull_request_review_id":219620936,"id":269686616,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTY4NjYxNg==","diff_hunk":"@@ -0,0 +1,462 @@\n+package gg.rsmod.plugins.content.skills.thieving.pickpocket\n+\n+import gg.rsmod.game.model.weight.impl.WeightItem\n+import gg.rsmod.game.model.weight.impl.WeightItemSet\n+import gg.rsmod.plugins.api.cfg.Items\n+import gg.rsmod.plugins.api.cfg.Npcs\n+\n+//Rarity weighting\n+private const val ALWAYS = 0\n+private const val COMMON = 256\n+private const val UNCOMMON = 32\n+private const val RARE = 8\n+private const val VERY_RARE = 1","path":"game/plugins/src/main/kotlin/gg/rsmod/plugins/content/skills/thieving/pickpocket/PickpocketNpc.kt","position":13,"original_position":13,"commit_id":"ac2cff5eb223c1cdcf4956dc64210ec2002cadc5","original_commit_id":"ac2cff5eb223c1cdcf4956dc64210ec2002cadc5","user":{"login":"Tomm0017","id":48779133,"node_id":"MDQ6VXNlcjQ4Nzc5MTMz","avatar_url":"https://avatars3.githubusercontent.com/u/48779133?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomm0017","html_url":"https://github.com/Tomm0017","followers_url":"https://api.github.com/users/Tomm0017/followers","following_url":"https://api.github.com/users/Tomm0017/following{/other_user}","gists_url":"https://api.github.com/users/Tomm0017/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomm0017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomm0017/subscriptions","organizations_url":"https://api.github.com/users/Tomm0017/orgs","repos_url":"https://api.github.com/users/Tomm0017/repos","events_url":"https://api.github.com/users/Tomm0017/events{/privacy}","received_events_url":"https://api.github.com/users/Tomm0017/received_events","type":"User","site_admin":false},"body":"These should be inside the PickpocketNpcs enum class, otherwise they will be globally exposed to other files. Should be defined inside the companion object as they are constants","created_at":"2019-03-27T17:36:04Z","updated_at":"2019-03-27T17:36:04Z","html_url":"https://github.com/Tomm0017/rsmod/pull/59#discussion_r269686616","pull_request_url":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Tomm0017/rsmod/pulls/comments/269686616"},"html":{"href":"https://github.com/Tomm0017/rsmod/pull/59#discussion_r269686616"},"pull_request":{"href":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59","id":264664472,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NjY0NDcy","html_url":"https://github.com/Tomm0017/rsmod/pull/59","diff_url":"https://github.com/Tomm0017/rsmod/pull/59.diff","patch_url":"https://github.com/Tomm0017/rsmod/pull/59.patch","issue_url":"https://api.github.com/repos/Tomm0017/rsmod/issues/59","number":59,"state":"open","locked":false,"title":"Pickpocketing","user":{"login":"LethalLeonard","id":31856462,"node_id":"MDQ6VXNlcjMxODU2NDYy","avatar_url":"https://avatars2.githubusercontent.com/u/31856462?v=4","gravatar_id":"","url":"https://api.github.com/users/LethalLeonard","html_url":"https://github.com/LethalLeonard","followers_url":"https://api.github.com/users/LethalLeonard/followers","following_url":"https://api.github.com/users/LethalLeonard/following{/other_user}","gists_url":"https://api.github.com/users/LethalLeonard/gists{/gist_id}","starred_url":"https://api.github.com/users/LethalLeonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LethalLeonard/subscriptions","organizations_url":"https://api.github.com/users/LethalLeonard/orgs","repos_url":"https://api.github.com/users/LethalLeonard/repos","events_url":"https://api.github.com/users/LethalLeonard/events{/privacy}","received_events_url":"https://api.github.com/users/LethalLeonard/received_events","type":"User","site_admin":false},"body":"## What has been done?\r\nAdded the pickpocketing part of the Thieving skill. All normal pickpocket-able NPCs are included, but not quest NPCs. \r\n\r\nEdit: Item tables are done to the best accuracy I could. All that may be wrong is the exact amounts that the weighting should be done by. ","created_at":"2019-03-26T19:31:49Z","updated_at":"2019-03-27T17:36:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794e3505c3afecf1de288fc7a0a389a24af65de9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59/commits","review_comments_url":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59/comments","review_comment_url":"https://api.github.com/repos/Tomm0017/rsmod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tomm0017/rsmod/issues/59/comments","statuses_url":"https://api.github.com/repos/Tomm0017/rsmod/statuses/ac2cff5eb223c1cdcf4956dc64210ec2002cadc5","head":{"label":"LethalLeonard:Pickpocketing","ref":"Pickpocketing","sha":"ac2cff5eb223c1cdcf4956dc64210ec2002cadc5","user":{"login":"LethalLeonard","id":31856462,"node_id":"MDQ6VXNlcjMxODU2NDYy","avatar_url":"https://avatars2.githubusercontent.com/u/31856462?v=4","gravatar_id":"","url":"https://api.github.com/users/LethalLeonard","html_url":"https://github.com/LethalLeonard","followers_url":"https://api.github.com/users/LethalLeonard/followers","following_url":"https://api.github.com/users/LethalLeonard/following{/other_user}","gists_url":"https://api.github.com/users/LethalLeonard/gists{/gist_id}","starred_url":"https://api.github.com/users/LethalLeonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LethalLeonard/subscriptions","organizations_url":"https://api.github.com/users/LethalLeonard/orgs","repos_url":"https://api.github.com/users/LethalLeonard/repos","events_url":"https://api.github.com/users/LethalLeonard/events{/privacy}","received_events_url":"https://api.github.com/users/LethalLeonard/received_events","type":"User","site_admin":false},"repo":{"id":177475202,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc0NzUyMDI=","name":"rsmod","full_name":"LethalLeonard/rsmod","private":false,"owner":{"login":"LethalLeonard","id":31856462,"node_id":"MDQ6VXNlcjMxODU2NDYy","avatar_url":"https://avatars2.githubusercontent.com/u/31856462?v=4","gravatar_id":"","url":"https://api.github.com/users/LethalLeonard","html_url":"https://github.com/LethalLeonard","followers_url":"https://api.github.com/users/LethalLeonard/followers","following_url":"https://api.github.com/users/LethalLeonard/following{/other_user}","gists_url":"https://api.github.com/users/LethalLeonard/gists{/gist_id}","starred_url":"https://api.github.com/users/LethalLeonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LethalLeonard/subscriptions","organizations_url":"https://api.github.com/users/LethalLeonard/orgs","repos_url":"https://api.github.com/users/LethalLeonard/repos","events_url":"https://api.github.com/users/LethalLeonard/events{/privacy}","received_events_url":"https://api.github.com/users/LethalLeonard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LethalLeonard/rsmod","description":"RSMod is a server made for eductional-purposes","fork":true,"url":"https://api.github.com/repos/LethalLeonard/rsmod","forks_url":"https://api.github.com/repos/LethalLeonard/rsmod/forks","keys_url":"https://api.github.com/repos/LethalLeonard/rsmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LethalLeonard/rsmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LethalLeonard/rsmod/teams","hooks_url":"https://api.github.com/repos/LethalLeonard/rsmod/hooks","issue_events_url":"https://api.github.com/repos/LethalLeonard/rsmod/issues/events{/number}","events_url":"https://api.github.com/repos/LethalLeonard/rsmod/events","assignees_url":"https://api.github.com/repos/LethalLeonard/rsmod/assignees{/user}","branches_url":"https://api.github.com/repos/LethalLeonard/rsmod/branches{/branch}","tags_url":"https://api.github.com/repos/LethalLeonard/rsmod/tags","blobs_url":"https://api.github.com/repos/LethalLeonard/rsmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LethalLeonard/rsmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LethalLeonard/rsmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/LethalLeonard/rsmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LethalLeonard/rsmod/statuses/{sha}","languages_url":"https://api.github.com/repos/LethalLeonard/rsmod/languages","stargazers_url":"https://api.github.com/repos/LethalLeonard/rsmod/stargazers","contributors_url":"https://api.github.com/repos/LethalLeonard/rsmod/contributors","subscribers_url":"https://api.github.com/repos/LethalLeonard/rsmod/subscribers","subscription_url":"https://api.github.com/repos/LethalLeonard/rsmod/subscription","commits_url":"https://api.github.com/repos/LethalLeonard/rsmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/LethalLeonard/rsmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/LethalLeonard/rsmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/LethalLeonard/rsmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/LethalLeonard/rsmod/contents/{+path}","compare_url":"https://api.github.com/repos/LethalLeonard/rsmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LethalLeonard/rsmod/merges","archive_url":"https://api.github.com/repos/LethalLeonard/rsmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LethalLeonard/rsmod/downloads","issues_url":"https://api.github.com/repos/LethalLeonard/rsmod/issues{/number}","pulls_url":"https://api.github.com/repos/LethalLeonard/rsmod/pulls{/number}","milestones_url":"https://api.github.com/repos/LethalLeonard/rsmod/milestones{/number}","notifications_url":"https://api.github.com/repos/LethalLeonard/rsmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LethalLeonard/rsmod/labels{/name}","releases_url":"https://api.github.com/repos/LethalLeonard/rsmod/releases{/id}","deployments_url":"https://api.github.com/repos/LethalLeonard/rsmod/deployments","created_at":"2019-03-24T22:08:47Z","updated_at":"2019-03-27T16:35:55Z","pushed_at":"2019-03-27T17:21:13Z","git_url":"git://github.com/LethalLeonard/rsmod.git","ssh_url":"git@github.com:LethalLeonard/rsmod.git","clone_url":"https://github.com/LethalLeonard/rsmod.git","svn_url":"https://github.com/LethalLeonard/rsmod","homepage":"http://rspsmods.com","size":3010,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Tomm0017:master","ref":"master","sha":"8bd18677881beafe63ac551caccbcbacfbfede0d","user":{"login":"Tomm0017","id":48779133,"node_id":"MDQ6VXNlcjQ4Nzc5MTMz","avatar_url":"https://avatars3.githubusercontent.com/u/48779133?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomm0017","html_url":"https://github.com/Tomm0017","followers_url":"https://api.github.com/users/Tomm0017/followers","following_url":"https://api.github.com/users/Tomm0017/following{/other_user}","gists_url":"https://api.github.com/users/Tomm0017/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomm0017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomm0017/subscriptions","organizations_url":"https://api.github.com/users/Tomm0017/orgs","repos_url":"https://api.github.com/users/Tomm0017/repos","events_url":"https://api.github.com/users/Tomm0017/events{/privacy}","received_events_url":"https://api.github.com/users/Tomm0017/received_events","type":"User","site_admin":false},"repo":{"id":176852452,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY4NTI0NTI=","name":"rsmod","full_name":"Tomm0017/rsmod","private":false,"owner":{"login":"Tomm0017","id":48779133,"node_id":"MDQ6VXNlcjQ4Nzc5MTMz","avatar_url":"https://avatars3.githubusercontent.com/u/48779133?v=4","gravatar_id":"","url":"https://api.github.com/users/Tomm0017","html_url":"https://github.com/Tomm0017","followers_url":"https://api.github.com/users/Tomm0017/followers","following_url":"https://api.github.com/users/Tomm0017/following{/other_user}","gists_url":"https://api.github.com/users/Tomm0017/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomm0017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomm0017/subscriptions","organizations_url":"https://api.github.com/users/Tomm0017/orgs","repos_url":"https://api.github.com/users/Tomm0017/repos","events_url":"https://api.github.com/users/Tomm0017/events{/privacy}","received_events_url":"https://api.github.com/users/Tomm0017/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Tomm0017/rsmod","description":"RSMod is a server made for eductional-purposes","fork":false,"url":"https://api.github.com/repos/Tomm0017/rsmod","forks_url":"https://api.github.com/repos/Tomm0017/rsmod/forks","keys_url":"https://api.github.com/repos/Tomm0017/rsmod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tomm0017/rsmod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tomm0017/rsmod/teams","hooks_url":"https://api.github.com/repos/Tomm0017/rsmod/hooks","issue_events_url":"https://api.github.com/repos/Tomm0017/rsmod/issues/events{/number}","events_url":"https://api.github.com/repos/Tomm0017/rsmod/events","assignees_url":"https://api.github.com/repos/Tomm0017/rsmod/assignees{/user}","branches_url":"https://api.github.com/repos/Tomm0017/rsmod/branches{/branch}","tags_url":"https://api.github.com/repos/Tomm0017/rsmod/tags","blobs_url":"https://api.github.com/repos/Tomm0017/rsmod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tomm0017/rsmod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tomm0017/rsmod/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tomm0017/rsmod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tomm0017/rsmod/statuses/{sha}","languages_url":"https://api.github.com/repos/Tomm0017/rsmod/languages","stargazers_url":"https://api.github.com/repos/Tomm0017/rsmod/stargazers","contributors_url":"https://api.github.com/repos/Tomm0017/rsmod/contributors","subscribers_url":"https://api.github.com/repos/Tomm0017/rsmod/subscribers","subscription_url":"https://api.github.com/repos/Tomm0017/rsmod/subscription","commits_url":"https://api.github.com/repos/Tomm0017/rsmod/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tomm0017/rsmod/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tomm0017/rsmod/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tomm0017/rsmod/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tomm0017/rsmod/contents/{+path}","compare_url":"https://api.github.com/repos/Tomm0017/rsmod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tomm0017/rsmod/merges","archive_url":"https://api.github.com/repos/Tomm0017/rsmod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tomm0017/rsmod/downloads","issues_url":"https://api.github.com/repos/Tomm0017/rsmod/issues{/number}","pulls_url":"https://api.github.com/repos/Tomm0017/rsmod/pulls{/number}","milestones_url":"https://api.github.com/repos/Tomm0017/rsmod/milestones{/number}","notifications_url":"https://api.github.com/repos/Tomm0017/rsmod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tomm0017/rsmod/labels{/name}","releases_url":"https://api.github.com/repos/Tomm0017/rsmod/releases{/id}","deployments_url":"https://api.github.com/repos/Tomm0017/rsmod/deployments","created_at":"2019-03-21T02:15:47Z","updated_at":"2019-03-27T17:27:02Z","pushed_at":"2019-03-27T17:21:15Z","git_url":"git://github.com/Tomm0017/rsmod.git","ssh_url":"git@github.com:Tomm0017/rsmod.git","clone_url":"https://github.com/Tomm0017/rsmod.git","svn_url":"https://github.com/Tomm0017/rsmod","homepage":"http://rspsmods.com","size":2966,"stargazers_count":29,"watchers_count":29,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":17,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59"},"html":{"href":"https://github.com/Tomm0017/rsmod/pull/59"},"issue":{"href":"https://api.github.com/repos/Tomm0017/rsmod/issues/59"},"comments":{"href":"https://api.github.com/repos/Tomm0017/rsmod/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/Tomm0017/rsmod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tomm0017/rsmod/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/Tomm0017/rsmod/statuses/ac2cff5eb223c1cdcf4956dc64210ec2002cadc5"}},"author_association":"NONE"}}
{"actor":{"display_login":"Tomm0017"}}