{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/365577195","pull_request_review_id":341570088,"id":365577195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTU3NzE5NQ==","diff_hunk":"@@ -63,8 +63,7 @@ file\n \n     callbacks.close++;\n     console.error('write after end should not be allowed');\n-    file.write('should not work anymore');\n-    file.on('error', common.expectsError({","path":"test/parallel/test-file-write-stream.js","position":5,"original_position":5,"commit_id":"9af1969baadfb3691b00da343767499e2a7f9684","original_commit_id":"9af1969baadfb3691b00da343767499e2a7f9684","user":{"login":"ronag","id":3065230,"node_id":"MDQ6VXNlcjMwNjUyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/3065230?v=4","gravatar_id":"","url":"https://api.github.com/users/ronag","html_url":"https://github.com/ronag","followers_url":"https://api.github.com/users/ronag/followers","following_url":"https://api.github.com/users/ronag/following{/other_user}","gists_url":"https://api.github.com/users/ronag/gists{/gist_id}","starred_url":"https://api.github.com/users/ronag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronag/subscriptions","organizations_url":"https://api.github.com/users/ronag/orgs","repos_url":"https://api.github.com/users/ronag/repos","events_url":"https://api.github.com/users/ronag/events{/privacy}","received_events_url":"https://api.github.com/users/ronag/received_events","type":"User","site_admin":false},"body":"This is after `'close'`, thus no `'error'`","created_at":"2020-01-12T11:45:45Z","updated_at":"2020-01-12T11:45:45Z","html_url":"https://github.com/nodejs/node/pull/29197#discussion_r365577195","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/29197","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/365577195"},"html":{"href":"https://github.com/nodejs/node/pull/29197#discussion_r365577195"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/29197"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/29197","id":308395951,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4Mzk1OTUx","html_url":"https://github.com/nodejs/node/pull/29197","diff_url":"https://github.com/nodejs/node/pull/29197.diff","patch_url":"https://github.com/nodejs/node/pull/29197.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/29197","number":29197,"state":"open","locked":false,"title":"stream: first `destroy` wins","user":{"login":"ronag","id":3065230,"node_id":"MDQ6VXNlcjMwNjUyMzA=","avatar_url":"https://avatars3.githubusercontent.com/u/3065230?v=4","gravatar_id":"","url":"https://api.github.com/users/ronag","html_url":"https://github.com/ronag","followers_url":"https://api.github.com/users/ronag/followers","following_url":"https://api.github.com/users/ronag/following{/other_user}","gists_url":"https://api.github.com/users/ronag/gists{/gist_id}","starred_url":"https://api.github.com/users/ronag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronag/subscriptions","organizations_url":"https://api.github.com/users/ronag/orgs","repos_url":"https://api.github.com/users/ronag/repos","events_url":"https://api.github.com/users/ronag/events{/privacy}","received_events_url":"https://api.github.com/users/ronag/received_events","type":"User","site_admin":false},"body":"**Update**: This PR has changed (again), see https://github.com/nodejs/node/pull/29197#issuecomment-569037445.\r\n\r\n~~**Update** _(via `@Fishrock123`)_: This PR has changed, see https://github.com/nodejs/node/pull/29197#issuecomment-530549797~~\r\n\r\n------\r\n\r\nEmitting `'error'` after `destroy()` can surprise the user and lead to unexpected crashes.\r\n\r\nIn https://github.com/nodejs/node/pull/20077 we concluded that we should not emit any errors after `abort()` and then in https://github.com/nodejs/node/pull/28683 we agreed that `abort()` is `destroy()`. Hence, streams should not emit `'error'` after `destroy()` for the same reasons as in https://github.com/nodejs/node/pull/20077.\r\n\r\n\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2019-08-18T21:41:53Z","updated_at":"2020-01-12T11:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdfec0566e15282439ead185a2695acbba321136","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mcollina","id":52195,"node_id":"MDQ6VXNlcjUyMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},{"login":"Fishrock123","id":1093990,"node_id":"MDQ6VXNlcjEwOTM5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1093990?v=4","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":169485514,"node_id":"MDU6TGFiZWwxNjk0ODU1MTQ=","url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false,"description":"PRs that contain breaking changes and should be released in the next major version."},{"id":155435883,"node_id":"MDU6TGFiZWwxNTU0MzU4ODM=","url":"https://api.github.com/repos/nodejs/node/labels/stream","name":"stream","color":"c7def8","default":false,"description":"Issues and PRs related to the built-in stream module."}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/29197/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/29197/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/29197/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/9af1969baadfb3691b00da343767499e2a7f9684","head":{"label":"nxtedition:stream-no-error-after-destroy","ref":"stream-no-error-after-destroy","sha":"9af1969baadfb3691b00da343767499e2a7f9684","user":{"login":"nxtedition","id":16840296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQwMjk2","avatar_url":"https://avatars1.githubusercontent.com/u/16840296?v=4","gravatar_id":"","url":"https://api.github.com/users/nxtedition","html_url":"https://github.com/nxtedition","followers_url":"https://api.github.com/users/nxtedition/followers","following_url":"https://api.github.com/users/nxtedition/following{/other_user}","gists_url":"https://api.github.com/users/nxtedition/gists{/gist_id}","starred_url":"https://api.github.com/users/nxtedition/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxtedition/subscriptions","organizations_url":"https://api.github.com/users/nxtedition/orgs","repos_url":"https://api.github.com/users/nxtedition/repos","events_url":"https://api.github.com/users/nxtedition/events{/privacy}","received_events_url":"https://api.github.com/users/nxtedition/received_events","type":"Organization","site_admin":false},"repo":{"id":129755885,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NTU4ODU=","name":"node","full_name":"nxtedition/node","private":false,"owner":{"login":"nxtedition","id":16840296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQwMjk2","avatar_url":"https://avatars1.githubusercontent.com/u/16840296?v=4","gravatar_id":"","url":"https://api.github.com/users/nxtedition","html_url":"https://github.com/nxtedition","followers_url":"https://api.github.com/users/nxtedition/followers","following_url":"https://api.github.com/users/nxtedition/following{/other_user}","gists_url":"https://api.github.com/users/nxtedition/gists{/gist_id}","starred_url":"https://api.github.com/users/nxtedition/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nxtedition/subscriptions","organizations_url":"https://api.github.com/users/nxtedition/orgs","repos_url":"https://api.github.com/users/nxtedition/repos","events_url":"https://api.github.com/users/nxtedition/events{/privacy}","received_events_url":"https://api.github.com/users/nxtedition/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nxtedition/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/nxtedition/node","forks_url":"https://api.github.com/repos/nxtedition/node/forks","keys_url":"https://api.github.com/repos/nxtedition/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nxtedition/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nxtedition/node/teams","hooks_url":"https://api.github.com/repos/nxtedition/node/hooks","issue_events_url":"https://api.github.com/repos/nxtedition/node/issues/events{/number}","events_url":"https://api.github.com/repos/nxtedition/node/events","assignees_url":"https://api.github.com/repos/nxtedition/node/assignees{/user}","branches_url":"https://api.github.com/repos/nxtedition/node/branches{/branch}","tags_url":"https://api.github.com/repos/nxtedition/node/tags","blobs_url":"https://api.github.com/repos/nxtedition/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nxtedition/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nxtedition/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nxtedition/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nxtedition/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nxtedition/node/languages","stargazers_url":"https://api.github.com/repos/nxtedition/node/stargazers","contributors_url":"https://api.github.com/repos/nxtedition/node/contributors","subscribers_url":"https://api.github.com/repos/nxtedition/node/subscribers","subscription_url":"https://api.github.com/repos/nxtedition/node/subscription","commits_url":"https://api.github.com/repos/nxtedition/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nxtedition/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nxtedition/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nxtedition/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nxtedition/node/contents/{+path}","compare_url":"https://api.github.com/repos/nxtedition/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nxtedition/node/merges","archive_url":"https://api.github.com/repos/nxtedition/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nxtedition/node/downloads","issues_url":"https://api.github.com/repos/nxtedition/node/issues{/number}","pulls_url":"https://api.github.com/repos/nxtedition/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nxtedition/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nxtedition/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nxtedition/node/labels{/name}","releases_url":"https://api.github.com/repos/nxtedition/node/releases{/id}","deployments_url":"https://api.github.com/repos/nxtedition/node/deployments","created_at":"2018-04-16T14:26:05Z","updated_at":"2019-12-29T20:52:51Z","pushed_at":"2020-01-12T11:44:30Z","git_url":"git://github.com/nxtedition/node.git","ssh_url":"git@github.com:nxtedition/node.git","clone_url":"https://github.com/nxtedition/node.git","svn_url":"https://github.com/nxtedition/node","homepage":"https://nodejs.org","size":513507,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"f9c16b87eff60858efa0b6977fa1d253be538589","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2020-01-12T11:43:11Z","pushed_at":"2020-01-12T11:44:33Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org/","size":539013,"stargazers_count":67071,"watchers_count":67071,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15878,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1134,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15878,"open_issues":1134,"watchers":67071,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/29197"},"html":{"href":"https://github.com/nodejs/node/pull/29197"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/29197"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/29197/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/29197/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/29197/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/9af1969baadfb3691b00da343767499e2a7f9684"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ronag"}}