{"action":"closed","number":36690,"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/36690","id":299926390,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5OTI2Mzkw","html_url":"https://github.com/flutter/flutter/pull/36690","diff_url":"https://github.com/flutter/flutter/pull/36690.diff","patch_url":"https://github.com/flutter/flutter/pull/36690.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/36690","number":36690,"state":"closed","locked":false,"title":"Updating cirrus fingerprint script to include goldens version","user":{"login":"Piinks","id":16964204,"node_id":"MDQ6VXNlcjE2OTY0MjA0","avatar_url":"https://avatars3.githubusercontent.com/u/16964204?v=4","gravatar_id":"","url":"https://api.github.com/users/Piinks","html_url":"https://github.com/Piinks","followers_url":"https://api.github.com/users/Piinks/followers","following_url":"https://api.github.com/users/Piinks/following{/other_user}","gists_url":"https://api.github.com/users/Piinks/gists{/gist_id}","starred_url":"https://api.github.com/users/Piinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piinks/subscriptions","organizations_url":"https://api.github.com/users/Piinks/orgs","repos_url":"https://api.github.com/users/Piinks/repos","events_url":"https://api.github.com/users/Piinks/events{/privacy}","received_events_url":"https://api.github.com/users/Piinks/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nLocal golden file changes should not exist on Cirrus, but were introduced in the reverted PR #33688. This removes those local changes that are creating a sync error for the goldens repository on cirrus, and maintains a safe guard against further errant local changes, thereby preserving the testing environment.\r\n\r\nThe fingerprint script for cirrus has been updated to incorporate the goldens version when deciding to invalidate the cache or not. \r\n\r\n## Related Issues\r\n\r\nThis blocks #36087 and any further updates to the goldens repository.\r\n\r\n\r\n## Checklist\r\n\r\nBefore you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I signed the [CLA].\r\n- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] All existing and new tests are passing.\r\n- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.\r\n- [x] I am willing to follow-up on review comments in a timely manner.\r\n\r\n## Breaking Change\r\n\r\nDoes your PR require Flutter developers to manually update their apps to accommodate your change?\r\n\r\n- [x] No, this is *not* a breaking change.\r\n\r\n<!-- Links -->\r\n[issue database]: https://github.com/flutter/flutter/issues\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement\r\n[CLA]: https://cla.developers.google.com/\r\n[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n","created_at":"2019-07-22T15:14:27Z","updated_at":"2019-07-23T16:30:42Z","closed_at":"2019-07-23T16:30:42Z","merged_at":"2019-07-23T16:30:41Z","merge_commit_sha":"0379dd1c26f14801882c780329598fef165cfddc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":283479128,"node_id":"MDU6TGFiZWwyODM0NzkxMjg=","url":"https://api.github.com/repos/flutter/flutter/labels/a:%20tests","name":"a: tests","color":"38d8c8","default":false},{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":284437560,"node_id":"MDU6TGFiZWwyODQ0Mzc1NjA=","url":"https://api.github.com/repos/flutter/flutter/labels/framework","name":"framework","color":"207de5","default":false},{"id":1160366842,"node_id":"MDU6TGFiZWwxMTYwMzY2ODQy","url":"https://api.github.com/repos/flutter/flutter/labels/waiting%20for%20tree%20to%20go%20green","name":"waiting for tree to go green","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/36690/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/36690/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/36690/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/d8290e8ac7c9307e5f5b5cdc3aca2e4b80899def","head":{"label":"Piinks:cirrusGoldens","ref":"cirrusGoldens","sha":"d8290e8ac7c9307e5f5b5cdc3aca2e4b80899def","user":{"login":"Piinks","id":16964204,"node_id":"MDQ6VXNlcjE2OTY0MjA0","avatar_url":"https://avatars3.githubusercontent.com/u/16964204?v=4","gravatar_id":"","url":"https://api.github.com/users/Piinks","html_url":"https://github.com/Piinks","followers_url":"https://api.github.com/users/Piinks/followers","following_url":"https://api.github.com/users/Piinks/following{/other_user}","gists_url":"https://api.github.com/users/Piinks/gists{/gist_id}","starred_url":"https://api.github.com/users/Piinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piinks/subscriptions","organizations_url":"https://api.github.com/users/Piinks/orgs","repos_url":"https://api.github.com/users/Piinks/repos","events_url":"https://api.github.com/users/Piinks/events{/privacy}","received_events_url":"https://api.github.com/users/Piinks/received_events","type":"User","site_admin":false},"repo":{"id":169131199,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkxMzExOTk=","name":"flutter","full_name":"Piinks/flutter","private":false,"owner":{"login":"Piinks","id":16964204,"node_id":"MDQ6VXNlcjE2OTY0MjA0","avatar_url":"https://avatars3.githubusercontent.com/u/16964204?v=4","gravatar_id":"","url":"https://api.github.com/users/Piinks","html_url":"https://github.com/Piinks","followers_url":"https://api.github.com/users/Piinks/followers","following_url":"https://api.github.com/users/Piinks/following{/other_user}","gists_url":"https://api.github.com/users/Piinks/gists{/gist_id}","starred_url":"https://api.github.com/users/Piinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piinks/subscriptions","organizations_url":"https://api.github.com/users/Piinks/orgs","repos_url":"https://api.github.com/users/Piinks/repos","events_url":"https://api.github.com/users/Piinks/events{/privacy}","received_events_url":"https://api.github.com/users/Piinks/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Piinks/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/Piinks/flutter","forks_url":"https://api.github.com/repos/Piinks/flutter/forks","keys_url":"https://api.github.com/repos/Piinks/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Piinks/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Piinks/flutter/teams","hooks_url":"https://api.github.com/repos/Piinks/flutter/hooks","issue_events_url":"https://api.github.com/repos/Piinks/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/Piinks/flutter/events","assignees_url":"https://api.github.com/repos/Piinks/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/Piinks/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/Piinks/flutter/tags","blobs_url":"https://api.github.com/repos/Piinks/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Piinks/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Piinks/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Piinks/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Piinks/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/Piinks/flutter/languages","stargazers_url":"https://api.github.com/repos/Piinks/flutter/stargazers","contributors_url":"https://api.github.com/repos/Piinks/flutter/contributors","subscribers_url":"https://api.github.com/repos/Piinks/flutter/subscribers","subscription_url":"https://api.github.com/repos/Piinks/flutter/subscription","commits_url":"https://api.github.com/repos/Piinks/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Piinks/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Piinks/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Piinks/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Piinks/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/Piinks/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Piinks/flutter/merges","archive_url":"https://api.github.com/repos/Piinks/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Piinks/flutter/downloads","issues_url":"https://api.github.com/repos/Piinks/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/Piinks/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/Piinks/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/Piinks/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Piinks/flutter/labels{/name}","releases_url":"https://api.github.com/repos/Piinks/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/Piinks/flutter/deployments","created_at":"2019-02-04T18:59:50Z","updated_at":"2019-05-10T22:20:30Z","pushed_at":"2019-07-23T15:59:55Z","git_url":"git://github.com/Piinks/flutter.git","ssh_url":"git@github.com:Piinks/flutter.git","clone_url":"https://github.com/Piinks/flutter.git","svn_url":"https://github.com/Piinks/flutter","homepage":"https://flutter.io","size":67852,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"b99e46eec390355fda00a6c05bf25a57155808e7","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2019-07-23T16:28:15Z","pushed_at":"2019-07-23T16:30:41Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.dev","size":67689,"stargazers_count":70945,"watchers_count":70945,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8377,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6948,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8377,"open_issues":6948,"watchers":70945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/36690"},"html":{"href":"https://github.com/flutter/flutter/pull/36690"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/36690"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/36690/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/36690/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/36690/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/d8290e8ac7c9307e5f5b5cdc3aca2e4b80899def"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Piinks","id":16964204,"node_id":"MDQ6VXNlcjE2OTY0MjA0","avatar_url":"https://avatars3.githubusercontent.com/u/16964204?v=4","gravatar_id":"","url":"https://api.github.com/users/Piinks","html_url":"https://github.com/Piinks","followers_url":"https://api.github.com/users/Piinks/followers","following_url":"https://api.github.com/users/Piinks/following{/other_user}","gists_url":"https://api.github.com/users/Piinks/gists{/gist_id}","starred_url":"https://api.github.com/users/Piinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piinks/subscriptions","organizations_url":"https://api.github.com/users/Piinks/orgs","repos_url":"https://api.github.com/users/Piinks/repos","events_url":"https://api.github.com/users/Piinks/events{/privacy}","received_events_url":"https://api.github.com/users/Piinks/received_events","type":"User","site_admin":false},"comments":2,"review_comments":5,"maintainer_can_modify":false,"commits":4,"additions":7,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"Piinks"}}