{"action":"closed","number":60954,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/60954","id":309119945,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MTE5OTQ1","html_url":"https://github.com/ansible/ansible/pull/60954","diff_url":"https://github.com/ansible/ansible/pull/60954.diff","patch_url":"https://github.com/ansible/ansible/pull/60954.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/60954","number":60954,"state":"closed","locked":false,"title":"Fortinet's new module for fortios_system_sit_tunnel","user":{"login":"mamunozgonzalez","id":29597798,"node_id":"MDQ6VXNlcjI5NTk3Nzk4","avatar_url":"https://avatars3.githubusercontent.com/u/29597798?v=4","gravatar_id":"","url":"https://api.github.com/users/mamunozgonzalez","html_url":"https://github.com/mamunozgonzalez","followers_url":"https://api.github.com/users/mamunozgonzalez/followers","following_url":"https://api.github.com/users/mamunozgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/mamunozgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/mamunozgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamunozgonzalez/subscriptions","organizations_url":"https://api.github.com/users/mamunozgonzalez/orgs","repos_url":"https://api.github.com/users/mamunozgonzalez/repos","events_url":"https://api.github.com/users/mamunozgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/mamunozgonzalez/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n \r\nFortinet is adding Ansible support for FortiOS and FortiGate products. This module follows the same structure, guidelines and ideas given in previous approved module for a parallel feature of FortiGate (user device): https://github.com/ansible/ansible/pull/56447\r\nIn this case we are providing a different functionality: \"Fortios System SIT tunnel\".\r\n \r\nPlease note that this will be part of other modules to come for FortiGate, including different functionalities: system, wireless-controller, firewall, webfilter, ips, web-proxy, wanopt, application, dlp spamfilter, log, vpn, certificate, user, dnsfilter, antivirus, report, waf, authentication, switch controller, endpoint-control and router. We plan to follow the same style, structure and usage as in the previous module in order to make it easier to comply with Ansible guidelines.\r\n \r\nThis PR has been updated according to suggestions and code reviews given in previous submissions of Fortinet modules.\r\n\r\n##### ISSUE TYPE\r\n\r\n- New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\n\r\nfortios_system_sit_tunnel\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible 2.8.2\r\npython version = 3.7.3 (default, Apr  3 2019, 05:39:12) [GCC 8.3.0]\r\n```","created_at":"2019-08-20T15:54:22Z","updated_at":"2019-08-22T13:08:03Z","closed_at":"2019-08-22T13:08:03Z","merged_at":"2019-08-22T13:08:03Z","merge_commit_sha":"4bd296c6fe91a31338c38683da2181832684932c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1316917295,"node_id":"MDU6TGFiZWwxMzE2OTE3Mjk1","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.9","name":"affects_2.9","color":"ededed","default":false},{"id":513652538,"node_id":"MDU6TGFiZWw1MTM2NTI1Mzg=","url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":1243593377,"node_id":"MDU6TGFiZWwxMjQzNTkzMzc3","url":"https://api.github.com/repos/ansible/ansible/labels/fortios","name":"fortios","color":"c7def8","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":503572087,"node_id":"MDU6TGFiZWw1MDM1NzIwODc=","url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":339653091,"node_id":"MDU6TGFiZWwzMzk2NTMwOTE=","url":"https://api.github.com/repos/ansible/ansible/labels/networking","name":"networking","color":"4071a5","default":false},{"id":473225334,"node_id":"MDU6TGFiZWw0NzMyMjUzMzQ=","url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"c2e0c6","default":false},{"id":153577825,"node_id":"MDU6TGFiZWwxNTM1Nzc4MjU=","url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":468273802,"node_id":"MDU6TGFiZWw0NjgyNzM4MDI=","url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/60954/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/60954/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/60954/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/2360f323f3c7fedea0478cdf9c7cdb15d8ca518b","head":{"label":"fortinet-solutions-cse:fortios_system_sit_tunnel","ref":"fortios_system_sit_tunnel","sha":"2360f323f3c7fedea0478cdf9c7cdb15d8ca518b","user":{"login":"fortinet-solutions-cse","id":27803665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODAzNjY1","avatar_url":"https://avatars0.githubusercontent.com/u/27803665?v=4","gravatar_id":"","url":"https://api.github.com/users/fortinet-solutions-cse","html_url":"https://github.com/fortinet-solutions-cse","followers_url":"https://api.github.com/users/fortinet-solutions-cse/followers","following_url":"https://api.github.com/users/fortinet-solutions-cse/following{/other_user}","gists_url":"https://api.github.com/users/fortinet-solutions-cse/gists{/gist_id}","starred_url":"https://api.github.com/users/fortinet-solutions-cse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortinet-solutions-cse/subscriptions","organizations_url":"https://api.github.com/users/fortinet-solutions-cse/orgs","repos_url":"https://api.github.com/users/fortinet-solutions-cse/repos","events_url":"https://api.github.com/users/fortinet-solutions-cse/events{/privacy}","received_events_url":"https://api.github.com/users/fortinet-solutions-cse/received_events","type":"Organization","site_admin":false},"repo":{"id":202118192,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIxMTgxOTI=","name":"ansible","full_name":"fortinet-solutions-cse/ansible","private":false,"owner":{"login":"fortinet-solutions-cse","id":27803665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3ODAzNjY1","avatar_url":"https://avatars0.githubusercontent.com/u/27803665?v=4","gravatar_id":"","url":"https://api.github.com/users/fortinet-solutions-cse","html_url":"https://github.com/fortinet-solutions-cse","followers_url":"https://api.github.com/users/fortinet-solutions-cse/followers","following_url":"https://api.github.com/users/fortinet-solutions-cse/following{/other_user}","gists_url":"https://api.github.com/users/fortinet-solutions-cse/gists{/gist_id}","starred_url":"https://api.github.com/users/fortinet-solutions-cse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortinet-solutions-cse/subscriptions","organizations_url":"https://api.github.com/users/fortinet-solutions-cse/orgs","repos_url":"https://api.github.com/users/fortinet-solutions-cse/repos","events_url":"https://api.github.com/users/fortinet-solutions-cse/events{/privacy}","received_events_url":"https://api.github.com/users/fortinet-solutions-cse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fortinet-solutions-cse/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/fortinet-solutions-cse/ansible","forks_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/forks","keys_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/teams","hooks_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/hooks","issue_events_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/events","assignees_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/tags","blobs_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/languages","stargazers_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/stargazers","contributors_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/contributors","subscribers_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/subscribers","subscription_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/subscription","commits_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/merges","archive_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/downloads","issues_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/labels{/name}","releases_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/fortinet-solutions-cse/ansible/deployments","created_at":"2019-08-13T10:13:21Z","updated_at":"2019-08-16T15:21:23Z","pushed_at":"2019-08-22T12:50:28Z","git_url":"git://github.com/fortinet-solutions-cse/ansible.git","ssh_url":"git@github.com:fortinet-solutions-cse/ansible.git","clone_url":"https://github.com/fortinet-solutions-cse/ansible.git","svn_url":"https://github.com/fortinet-solutions-cse/ansible","homepage":"https://www.ansible.com/","size":170315,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"3247626ac7a3e22739e4e343ebf5919b33784c8e","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2019-08-22T13:06:47Z","pushed_at":"2019-08-22T13:08:03Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":178406,"stargazers_count":38968,"watchers_count":38968,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16488,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6165,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16488,"open_issues":6165,"watchers":38968,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/60954"},"html":{"href":"https://github.com/ansible/ansible/pull/60954"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/60954"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/60954/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/60954/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/60954/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/2360f323f3c7fedea0478cdf9c7cdb15d8ca518b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"NilashishC","id":15523883,"node_id":"MDQ6VXNlcjE1NTIzODgz","avatar_url":"https://avatars2.githubusercontent.com/u/15523883?v=4","gravatar_id":"","url":"https://api.github.com/users/NilashishC","html_url":"https://github.com/NilashishC","followers_url":"https://api.github.com/users/NilashishC/followers","following_url":"https://api.github.com/users/NilashishC/following{/other_user}","gists_url":"https://api.github.com/users/NilashishC/gists{/gist_id}","starred_url":"https://api.github.com/users/NilashishC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NilashishC/subscriptions","organizations_url":"https://api.github.com/users/NilashishC/orgs","repos_url":"https://api.github.com/users/NilashishC/repos","events_url":"https://api.github.com/users/NilashishC/events{/privacy}","received_events_url":"https://api.github.com/users/NilashishC/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":573,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"NilashishC"}}