{"action":"created","issue":{"url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/1751","repository_url":"https://api.github.com/repos/18F/e-QIP-prototype","labels_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/1751/labels{/name}","comments_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/1751/comments","events_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/1751/events","html_url":"https://github.com/18F/e-QIP-prototype/pull/1751","id":463305961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzODExODkw","number":1751,"title":"[EN-3037] Fix error messages showing up too early in Relatives","user":{"login":"christopherhuii","id":8367504,"node_id":"MDQ6VXNlcjgzNjc1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8367504?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherhuii","html_url":"https://github.com/christopherhuii","followers_url":"https://api.github.com/users/christopherhuii/followers","following_url":"https://api.github.com/users/christopherhuii/following{/other_user}","gists_url":"https://api.github.com/users/christopherhuii/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherhuii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherhuii/subscriptions","organizations_url":"https://api.github.com/users/christopherhuii/orgs","repos_url":"https://api.github.com/users/christopherhuii/repos","events_url":"https://api.github.com/users/christopherhuii/events{/privacy}","received_events_url":"https://api.github.com/users/christopherhuii/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-07-02T15:48:59Z","updated_at":"2019-07-31T23:48:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/18F/e-QIP-prototype/pulls/1751","html_url":"https://github.com/18F/e-QIP-prototype/pull/1751","diff_url":"https://github.com/18F/e-QIP-prototype/pull/1751.diff","patch_url":"https://github.com/18F/e-QIP-prototype/pull/1751.patch"},"body":"## Description\r\nThis PR fixes the errors messages that appear too early. The errors messages would be saying that \"Mother And Father are required\" as well as \"Mother-in-law and Father-in-law are required\".\r\n\r\nIn this PR:\r\n- The errors aren't displayed until AFTER `Do you have an additional relative to enter?` is answered with `No.\r\n- There was uncaught bug where eApp asked for the mother and father in law in all cases. Mother and father in law are only required for applicants who are married or separated.\r\n\r\n## Checklist for Reviewer\r\n\r\n- [ ] Review code changes\r\n- [ ] Review changes for Database effects\r\n- [ ] Verify change works in IE browser\r\n\r\nMore details about this can be found in [docs/review.md](docs/review.md)\r\n"},"comment":{"url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/comments/517063545","html_url":"https://github.com/18F/e-QIP-prototype/pull/1751#issuecomment-517063545","issue_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/1751","id":517063545,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNzA2MzU0NQ==","user":{"login":"ryanhofdotgov","id":37100189,"node_id":"MDQ6VXNlcjM3MTAwMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/37100189?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanhofdotgov","html_url":"https://github.com/ryanhofdotgov","followers_url":"https://api.github.com/users/ryanhofdotgov/followers","following_url":"https://api.github.com/users/ryanhofdotgov/following{/other_user}","gists_url":"https://api.github.com/users/ryanhofdotgov/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanhofdotgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanhofdotgov/subscriptions","organizations_url":"https://api.github.com/users/ryanhofdotgov/orgs","repos_url":"https://api.github.com/users/ryanhofdotgov/repos","events_url":"https://api.github.com/users/ryanhofdotgov/events{/privacy}","received_events_url":"https://api.github.com/users/ryanhofdotgov/received_events","type":"User","site_admin":false},"created_at":"2019-07-31T23:48:38Z","updated_at":"2019-07-31T23:48:38Z","author_association":"MEMBER","body":"EN-3819, which Chris points out this is dependent on, is in PR https://github.com/18F/e-QIP-prototype/pull/1772"}}
{"actor":{"display_login":"ryanhofdotgov"}}