{"action":"created","comment":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments/277364143","pull_request_review_id":229153626,"id":277364143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzM2NDE0Mw==","diff_hunk":"@@ -0,0 +1,16 @@\n+const assert = require('assert');\n+    describe('table check', function() {\n+    it('should check the page for proper table structure', () => {\n+        browser.url('http://127.0.0.1:7777/daemonsets');\n+        browser.waitUntil(() => {return $('table').isExisting();\n+          }, 10000, 'expected table to exist');\n+        http_headers=[\"Namespace\", \"Daemon Set\",\"Meshed\", \"Success Rate\", \"RPS\", \"P50 Latency\", \n+        \"P95 Latency\", \"P99 Latency\", \"Grafana\"];\n+        tcp_headers=[\"Namespace\",\"Daemon Set\",\"Meshed\",\"Connections\", \"Read Bytes / sec\",\"Write Bytes / sec\", \n+\"Grafana\"];\n+        const http=$$(\"table\")[0].$(\"thead\").$$(\"th\").map(item=>item.getText());\n+        assert(http.join('')==http_headers.join(''));\n+        const tcp=$$(\"table\")[1].$(\"thead\").$$(\"th\").map(item=>item.getText());\n+        assert(tcp.join('')==tcp_headers.join(''));","path":"web/app/integration/specs/daemonset/daemonset-table.js","position":14,"original_position":14,"commit_id":"d261df4e996399e4cb5dd64a0b8dab6a115ab155","original_commit_id":"d261df4e996399e4cb5dd64a0b8dab6a115ab155","user":{"login":"dadjeibaah","id":2197104,"node_id":"MDQ6VXNlcjIxOTcxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2197104?v=4","gravatar_id":"","url":"https://api.github.com/users/dadjeibaah","html_url":"https://github.com/dadjeibaah","followers_url":"https://api.github.com/users/dadjeibaah/followers","following_url":"https://api.github.com/users/dadjeibaah/following{/other_user}","gists_url":"https://api.github.com/users/dadjeibaah/gists{/gist_id}","starred_url":"https://api.github.com/users/dadjeibaah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadjeibaah/subscriptions","organizations_url":"https://api.github.com/users/dadjeibaah/orgs","repos_url":"https://api.github.com/users/dadjeibaah/repos","events_url":"https://api.github.com/users/dadjeibaah/events{/privacy}","received_events_url":"https://api.github.com/users/dadjeibaah/received_events","type":"User","site_admin":false},"body":"in JS the preferred comparison operator is `===` as opposed to `==`. Check out [this](https://stackoverflow.com/questions/359494/which-equals-operator-vs-should-be-used-in-javascript-comparisons) stackoverflow post on the reason's why.","created_at":"2019-04-22T17:29:28Z","updated_at":"2019-04-22T17:55:46Z","html_url":"https://github.com/linkerd/linkerd2/pull/2720#discussion_r277364143","pull_request_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments/277364143"},"html":{"href":"https://github.com/linkerd/linkerd2/pull/2720#discussion_r277364143"},"pull_request":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720"}}},"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720","id":272034845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMDM0ODQ1","html_url":"https://github.com/linkerd/linkerd2/pull/2720","diff_url":"https://github.com/linkerd/linkerd2/pull/2720.diff","patch_url":"https://github.com/linkerd/linkerd2/pull/2720.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd2/issues/2720","number":2720,"state":"open","locked":false,"title":"Introduce basic UI testing for Linkerd dashboard: Daemonset (#2475) #2698","user":{"login":"drholmie","id":19522710,"node_id":"MDQ6VXNlcjE5NTIyNzEw","avatar_url":"https://avatars2.githubusercontent.com/u/19522710?v=4","gravatar_id":"","url":"https://api.github.com/users/drholmie","html_url":"https://github.com/drholmie","followers_url":"https://api.github.com/users/drholmie/followers","following_url":"https://api.github.com/users/drholmie/following{/other_user}","gists_url":"https://api.github.com/users/drholmie/gists{/gist_id}","starred_url":"https://api.github.com/users/drholmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drholmie/subscriptions","organizations_url":"https://api.github.com/users/drholmie/orgs","repos_url":"https://api.github.com/users/drholmie/repos","events_url":"https://api.github.com/users/drholmie/events{/privacy}","received_events_url":"https://api.github.com/users/drholmie/received_events","type":"User","site_admin":false},"body":"Made simple UI test to make sure table headers of daemonset page are correct and in order\r\nIncreased timeouts in wdio*.conf.js files to allow for longer running tests (>1 minute) and handle slow connections\r\nAdded sauce-service to wdio-sauce.conf.js for webdriverio commands to run correctly on sauce labs\r\nTested locally and on cloud","created_at":"2019-04-19T16:17:19Z","updated_at":"2019-04-22T17:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"644bf6af07a4e7b15c912b4bd6eb2b8ccc90231c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/issues/2720/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/d261df4e996399e4cb5dd64a0b8dab6a115ab155","head":{"label":"drholmie:daemonset-test","ref":"daemonset-test","sha":"d261df4e996399e4cb5dd64a0b8dab6a115ab155","user":{"login":"drholmie","id":19522710,"node_id":"MDQ6VXNlcjE5NTIyNzEw","avatar_url":"https://avatars2.githubusercontent.com/u/19522710?v=4","gravatar_id":"","url":"https://api.github.com/users/drholmie","html_url":"https://github.com/drholmie","followers_url":"https://api.github.com/users/drholmie/followers","following_url":"https://api.github.com/users/drholmie/following{/other_user}","gists_url":"https://api.github.com/users/drholmie/gists{/gist_id}","starred_url":"https://api.github.com/users/drholmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drholmie/subscriptions","organizations_url":"https://api.github.com/users/drholmie/orgs","repos_url":"https://api.github.com/users/drholmie/repos","events_url":"https://api.github.com/users/drholmie/events{/privacy}","received_events_url":"https://api.github.com/users/drholmie/received_events","type":"User","site_admin":false},"repo":{"id":179697336,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk2OTczMzY=","name":"linkerd2","full_name":"drholmie/linkerd2","private":false,"owner":{"login":"drholmie","id":19522710,"node_id":"MDQ6VXNlcjE5NTIyNzEw","avatar_url":"https://avatars2.githubusercontent.com/u/19522710?v=4","gravatar_id":"","url":"https://api.github.com/users/drholmie","html_url":"https://github.com/drholmie","followers_url":"https://api.github.com/users/drholmie/followers","following_url":"https://api.github.com/users/drholmie/following{/other_user}","gists_url":"https://api.github.com/users/drholmie/gists{/gist_id}","starred_url":"https://api.github.com/users/drholmie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drholmie/subscriptions","organizations_url":"https://api.github.com/users/drholmie/orgs","repos_url":"https://api.github.com/users/drholmie/repos","events_url":"https://api.github.com/users/drholmie/events{/privacy}","received_events_url":"https://api.github.com/users/drholmie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drholmie/linkerd2","description":"A service mesh for Kubernetes and beyond. Main repo for Linkerd 2.x.","fork":true,"url":"https://api.github.com/repos/drholmie/linkerd2","forks_url":"https://api.github.com/repos/drholmie/linkerd2/forks","keys_url":"https://api.github.com/repos/drholmie/linkerd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drholmie/linkerd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drholmie/linkerd2/teams","hooks_url":"https://api.github.com/repos/drholmie/linkerd2/hooks","issue_events_url":"https://api.github.com/repos/drholmie/linkerd2/issues/events{/number}","events_url":"https://api.github.com/repos/drholmie/linkerd2/events","assignees_url":"https://api.github.com/repos/drholmie/linkerd2/assignees{/user}","branches_url":"https://api.github.com/repos/drholmie/linkerd2/branches{/branch}","tags_url":"https://api.github.com/repos/drholmie/linkerd2/tags","blobs_url":"https://api.github.com/repos/drholmie/linkerd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drholmie/linkerd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drholmie/linkerd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/drholmie/linkerd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drholmie/linkerd2/statuses/{sha}","languages_url":"https://api.github.com/repos/drholmie/linkerd2/languages","stargazers_url":"https://api.github.com/repos/drholmie/linkerd2/stargazers","contributors_url":"https://api.github.com/repos/drholmie/linkerd2/contributors","subscribers_url":"https://api.github.com/repos/drholmie/linkerd2/subscribers","subscription_url":"https://api.github.com/repos/drholmie/linkerd2/subscription","commits_url":"https://api.github.com/repos/drholmie/linkerd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/drholmie/linkerd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/drholmie/linkerd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/drholmie/linkerd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/drholmie/linkerd2/contents/{+path}","compare_url":"https://api.github.com/repos/drholmie/linkerd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drholmie/linkerd2/merges","archive_url":"https://api.github.com/repos/drholmie/linkerd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drholmie/linkerd2/downloads","issues_url":"https://api.github.com/repos/drholmie/linkerd2/issues{/number}","pulls_url":"https://api.github.com/repos/drholmie/linkerd2/pulls{/number}","milestones_url":"https://api.github.com/repos/drholmie/linkerd2/milestones{/number}","notifications_url":"https://api.github.com/repos/drholmie/linkerd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drholmie/linkerd2/labels{/name}","releases_url":"https://api.github.com/repos/drholmie/linkerd2/releases{/id}","deployments_url":"https://api.github.com/repos/drholmie/linkerd2/deployments","created_at":"2019-04-05T14:28:09Z","updated_at":"2019-04-05T17:47:50Z","pushed_at":"2019-04-19T16:07:46Z","git_url":"git://github.com/drholmie/linkerd2.git","ssh_url":"git@github.com:drholmie/linkerd2.git","clone_url":"https://github.com/drholmie/linkerd2.git","svn_url":"https://github.com/drholmie/linkerd2","homepage":"https://linkerd.io","size":25486,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkerd:master","ref":"master","sha":"be614656bbed77d2546008522af6a09e701e4321","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"linkerd2","full_name":"linkerd/linkerd2","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd2","description":"A service mesh for Kubernetes and beyond. Main repo for Linkerd 2.x.","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd2","forks_url":"https://api.github.com/repos/linkerd/linkerd2/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd2/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd2/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd2/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd2/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd2/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd2/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd2/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd2/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd2/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd2/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd2/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd2/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd2/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd2/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd2/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd2/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd2/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd2/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd2/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd2/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2019-04-22T17:15:27Z","pushed_at":"2019-04-22T17:49:24Z","git_url":"git://github.com/linkerd/linkerd2.git","ssh_url":"git@github.com:linkerd/linkerd2.git","clone_url":"https://github.com/linkerd/linkerd2.git","svn_url":"https://github.com/linkerd/linkerd2","homepage":"https://linkerd.io","size":25506,"stargazers_count":3699,"watchers_count":3699,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":268,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":289,"open_issues":268,"watchers":3699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720"},"html":{"href":"https://github.com/linkerd/linkerd2/pull/2720"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd2/issues/2720"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd2/issues/2720/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2720/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd2/statuses/d261df4e996399e4cb5dd64a0b8dab6a115ab155"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dadjeibaah"}}