{"action":"created","issue":{"url":"https://api.github.com/repos/libglui/glui/issues/96","repository_url":"https://api.github.com/repos/libglui/glui","labels_url":"https://api.github.com/repos/libglui/glui/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/libglui/glui/issues/96/comments","events_url":"https://api.github.com/repos/libglui/glui/issues/96/events","html_url":"https://github.com/libglui/glui/pull/96","id":424479670,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzODE5ODk4","number":96,"title":"Issue #90: Adding support for windows 10 SDK","user":{"login":"T-Jin","id":10686380,"node_id":"MDQ6VXNlcjEwNjg2Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/10686380?v=4","gravatar_id":"","url":"https://api.github.com/users/T-Jin","html_url":"https://github.com/T-Jin","followers_url":"https://api.github.com/users/T-Jin/followers","following_url":"https://api.github.com/users/T-Jin/following{/other_user}","gists_url":"https://api.github.com/users/T-Jin/gists{/gist_id}","starred_url":"https://api.github.com/users/T-Jin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T-Jin/subscriptions","organizations_url":"https://api.github.com/users/T-Jin/orgs","repos_url":"https://api.github.com/users/T-Jin/repos","events_url":"https://api.github.com/users/T-Jin/events{/privacy}","received_events_url":"https://api.github.com/users/T-Jin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-23T08:55:49Z","updated_at":"2019-06-16T04:21:53Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/libglui/glui/pulls/96","html_url":"https://github.com/libglui/glui/pull/96","diff_url":"https://github.com/libglui/glui/pull/96.diff","patch_url":"https://github.com/libglui/glui/pull/96.patch"},"body":"I ran into some issues with building glui on windows 10. Made a quick fix.\r\nI later saw the exact same issue was previously reported in issue #90, but no PR yet. So here it is.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/libglui/glui/issues/comments/502418766","html_url":"https://github.com/libglui/glui/pull/96#issuecomment-502418766","issue_url":"https://api.github.com/repos/libglui/glui/issues/96","id":502418766,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMjQxODc2Ng==","user":{"login":"T-Jin","id":10686380,"node_id":"MDQ6VXNlcjEwNjg2Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/10686380?v=4","gravatar_id":"","url":"https://api.github.com/users/T-Jin","html_url":"https://github.com/T-Jin","followers_url":"https://api.github.com/users/T-Jin/followers","following_url":"https://api.github.com/users/T-Jin/following{/other_user}","gists_url":"https://api.github.com/users/T-Jin/gists{/gist_id}","starred_url":"https://api.github.com/users/T-Jin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T-Jin/subscriptions","organizations_url":"https://api.github.com/users/T-Jin/orgs","repos_url":"https://api.github.com/users/T-Jin/repos","events_url":"https://api.github.com/users/T-Jin/events{/privacy}","received_events_url":"https://api.github.com/users/T-Jin/received_events","type":"User","site_admin":false},"created_at":"2019-06-16T04:21:53Z","updated_at":"2019-06-16T04:21:53Z","author_association":"NONE","body":"> Ah there is more to this story.\r\n> \r\n> There was a change in 2017 to remove the GLUT dependency from the GLUI header.\r\n> A side-effect of that is that now Windows builds break because GLUT is/was including `windows.h`\r\n> \r\n> #76\r\n\r\nI think it was the right move to remove GLUT dependency from GLUI header. I noticed that GLUI Windows build with FreeGLUT also breaks because FreeGLUT is/was including `windows.h`.\r\n\r\nNow knowing that, the original changes I made in this PR is not a good solution, with all that windows namespace pollution."}}
{"actor":{"display_login":"T-Jin"}}