{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/awx/issues/4041","repository_url":"https://api.github.com/repos/ansible/awx","labels_url":"https://api.github.com/repos/ansible/awx/issues/4041/labels{/name}","comments_url":"https://api.github.com/repos/ansible/awx/issues/4041/comments","events_url":"https://api.github.com/repos/ansible/awx/issues/4041/events","html_url":"https://github.com/ansible/awx/pull/4041","id":454750291,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3MTM4MjI4","number":4041,"title":"Fixes bug where save changes modal was shown to user with execute permissions","user":{"login":"mabashian","id":9889020,"node_id":"MDQ6VXNlcjk4ODkwMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/9889020?v=4","gravatar_id":"","url":"https://api.github.com/users/mabashian","html_url":"https://github.com/mabashian","followers_url":"https://api.github.com/users/mabashian/followers","following_url":"https://api.github.com/users/mabashian/following{/other_user}","gists_url":"https://api.github.com/users/mabashian/gists{/gist_id}","starred_url":"https://api.github.com/users/mabashian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mabashian/subscriptions","organizations_url":"https://api.github.com/users/mabashian/orgs","repos_url":"https://api.github.com/users/mabashian/repos","events_url":"https://api.github.com/users/mabashian/events{/privacy}","received_events_url":"https://api.github.com/users/mabashian/received_events","type":"User","site_admin":false},"labels":[{"id":687169295,"node_id":"MDU6TGFiZWw2ODcxNjkyOTU=","url":"https://api.github.com/repos/ansible/awx/labels/component:ui","name":"component:ui","color":"009800","default":false},{"id":1080816370,"node_id":"MDU6TGFiZWwxMDgwODE2Mzcw","url":"https://api.github.com/repos/ansible/awx/labels/mergeit","name":"mergeit","color":"b345d8","default":false},{"id":687172858,"node_id":"MDU6TGFiZWw2ODcxNzI4NTg=","url":"https://api.github.com/repos/ansible/awx/labels/state:needs_triage","name":"state:needs_triage","color":"A0522D","default":false},{"id":607283748,"node_id":"MDU6TGFiZWw2MDcyODM3NDg=","url":"https://api.github.com/repos/ansible/awx/labels/type:bug","name":"type:bug","color":"F79F81","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-06-11T15:13:21Z","updated_at":"2019-06-13T21:15:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/awx/pulls/4041","html_url":"https://github.com/ansible/awx/pull/4041","diff_url":"https://github.com/ansible/awx/pull/4041.diff","patch_url":"https://github.com/ansible/awx/pull/4041.patch"},"body":"##### SUMMARY\r\nlink https://github.com/ansible/awx/issues/3378\r\n\r\ntldr; of these changes are that we now ignore the saved changes modal if the user cannot add/edit the wfjt in question.\r\n\r\nUser with execute permissions:\r\n![execute_user](https://user-images.githubusercontent.com/9889020/59283998-7f671f80-8c39-11e9-8e48-a2d911b79ec5.gif)\r\n\r\nUser with admin permissions:\r\n![admin_user](https://user-images.githubusercontent.com/9889020/59283982-7a09d500-8c39-11e9-9f69-9d994ca03c27.gif)\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n - UI\r\n\r\n##### ADDITIONAL INFORMATION\r\nLocally tested the original use case listed in the bug but these changes could impact permissions around adding/editing the visualizer in general so I went ahead and tested the basic use cases (adding/editing WF graph with a superuser/user with admin permissions and viewing the WF graph with a user with the execute role).\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/awx/issues/comments/501881656","html_url":"https://github.com/ansible/awx/pull/4041#issuecomment-501881656","issue_url":"https://api.github.com/repos/ansible/awx/issues/4041","id":501881656,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMTg4MTY1Ng==","user":{"login":"softwarefactory-project-zuul[bot]","id":33884098,"node_id":"MDM6Qm90MzM4ODQwOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/26543671?v=4","gravatar_id":"","url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D","html_url":"https://github.com/apps/softwarefactory-project-zuul","followers_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/followers","following_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/repos","events_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/softwarefactory-project-zuul%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-06-13T21:15:34Z","updated_at":"2019-06-13T21:15:34Z","author_association":"CONTRIBUTOR","body":"Build failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- [awx-api-lint ](https://ansible.softwarefactory-project.io/logs/41/4041/148f513d9afee2c4577c027c2d53708158a799be/gate/awx-api-lint/5d0960b/) : SUCCESS in 9m 13s\n- [awx-ui-lint ](https://ansible.softwarefactory-project.io/logs/41/4041/148f513d9afee2c4577c027c2d53708158a799be/gate/awx-ui-lint/a934a3f/) : SUCCESS in 9m 01s\n- [awx-api ](https://ansible.softwarefactory-project.io/logs/41/4041/148f513d9afee2c4577c027c2d53708158a799be/gate/awx-api/a95bf89/) : FAILURE in 13m 01s\n- [awx-ui ](https://ansible.softwarefactory-project.io/logs/41/4041/148f513d9afee2c4577c027c2d53708158a799be/gate/awx-ui/361f703/) : SUCCESS in 10m 51s\n- [awx-swagger ](https://ansible.softwarefactory-project.io/logs/41/4041/148f513d9afee2c4577c027c2d53708158a799be/gate/awx-swagger/3ebea43/) : FAILURE in 13m 15s\n- [awx-detect-schema-change ](https://ansible.softwarefactory-project.io/logs/41/4041/148f513d9afee2c4577c027c2d53708158a799be/gate/awx-detect-schema-change/b723446/) : FAILURE in 12m 55s (non-voting)\n- [awx-push-new-schema ](awx-push-new-schema) : SKIPPED (non-voting)\n"}}
{"actor":{"display_login":"softwarefactory-project-zuul"}}