{"action":"closed","number":1953,"pull_request":{"url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1953","id":343737740,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzNzM3NzQw","html_url":"https://github.com/PrismLibrary/Prism/pull/1953","diff_url":"https://github.com/PrismLibrary/Prism/pull/1953.diff","patch_url":"https://github.com/PrismLibrary/Prism/pull/1953.patch","issue_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/1953","number":1953,"state":"closed","locked":false,"title":"Adding Enum support from QueryStrings","user":{"login":"dansiegel","id":3860573,"node_id":"MDQ6VXNlcjM4NjA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/3860573?v=4","gravatar_id":"","url":"https://api.github.com/users/dansiegel","html_url":"https://github.com/dansiegel","followers_url":"https://api.github.com/users/dansiegel/followers","following_url":"https://api.github.com/users/dansiegel/following{/other_user}","gists_url":"https://api.github.com/users/dansiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/dansiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansiegel/subscriptions","organizations_url":"https://api.github.com/users/dansiegel/orgs","repos_url":"https://api.github.com/users/dansiegel/repos","events_url":"https://api.github.com/users/dansiegel/events{/privacy}","received_events_url":"https://api.github.com/users/dansiegel/received_events","type":"User","site_admin":false},"body":"## Description of Change\r\n\r\nThis is a rebased and fixed version of PR #1916. This adds tests both for ParametersBase and IAutoInitialize specifically. Be sure to note some of the behavior changes.\r\n\r\n### Bugs Fixed\r\n\r\n- no issue was created\r\n\r\n### API Changes\r\n\r\nnone\r\n\r\n### Behavioral Changes\r\n\r\nUpdates GetValue / TryGetValue from the ParametersBase. All Get Value methods now use a single internal TryGet method so that the conversion from the KeyValuePair's Value (which may be a string if it was from the QueryString) to whatever the requested type is will use the same exact logic. We now will be intentional in throwing an InvalidArgumentException when calling GetValue in the event that we could not convert the value to the requested type. \r\n\r\nThis also fixes a very incorrect assumption that at the event you got to the end of our type conversion logic that the value must be convertible. This now ensures that if we get to the point that we want to try `Convert.ChangeType` that we first validate that it implements `IConvertible`\r\n\r\n### PR Checklist\r\n\r\n- [x] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard","created_at":"2019-11-20T21:45:06Z","updated_at":"2019-11-21T00:59:58Z","closed_at":"2019-11-21T00:59:58Z","merged_at":"2019-11-21T00:59:58Z","merge_commit_sha":"a2231bee4a5d7cb41eefc384a871831583eb63f9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brianlagunas","id":835562,"node_id":"MDQ6VXNlcjgzNTU2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/835562?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlagunas","html_url":"https://github.com/brianlagunas","followers_url":"https://api.github.com/users/brianlagunas/followers","following_url":"https://api.github.com/users/brianlagunas/following{/other_user}","gists_url":"https://api.github.com/users/brianlagunas/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlagunas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlagunas/subscriptions","organizations_url":"https://api.github.com/users/brianlagunas/orgs","repos_url":"https://api.github.com/users/brianlagunas/repos","events_url":"https://api.github.com/users/brianlagunas/events{/privacy}","received_events_url":"https://api.github.com/users/brianlagunas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1953/commits","review_comments_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1953/comments","review_comment_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/1953/comments","statuses_url":"https://api.github.com/repos/PrismLibrary/Prism/statuses/053eb30ee58fd0999d049d3c7681d3bc4e1eef61","head":{"label":"PrismLibrary:enum-autoinitialize","ref":"enum-autoinitialize","sha":"053eb30ee58fd0999d049d3c7681d3bc4e1eef61","user":{"login":"PrismLibrary","id":10503161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTAzMTYx","avatar_url":"https://avatars1.githubusercontent.com/u/10503161?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismLibrary","html_url":"https://github.com/PrismLibrary","followers_url":"https://api.github.com/users/PrismLibrary/followers","following_url":"https://api.github.com/users/PrismLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PrismLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismLibrary/subscriptions","organizations_url":"https://api.github.com/users/PrismLibrary/orgs","repos_url":"https://api.github.com/users/PrismLibrary/repos","events_url":"https://api.github.com/users/PrismLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PrismLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":31335300,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMzNTMwMA==","name":"Prism","full_name":"PrismLibrary/Prism","private":false,"owner":{"login":"PrismLibrary","id":10503161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTAzMTYx","avatar_url":"https://avatars1.githubusercontent.com/u/10503161?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismLibrary","html_url":"https://github.com/PrismLibrary","followers_url":"https://api.github.com/users/PrismLibrary/followers","following_url":"https://api.github.com/users/PrismLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PrismLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismLibrary/subscriptions","organizations_url":"https://api.github.com/users/PrismLibrary/orgs","repos_url":"https://api.github.com/users/PrismLibrary/repos","events_url":"https://api.github.com/users/PrismLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PrismLibrary/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrismLibrary/Prism","description":"Prism is a framework for building loosely coupled, maintainable, and testable XAML applications in WPF, Windows 10 UWP, and Xamarin Forms.","fork":false,"url":"https://api.github.com/repos/PrismLibrary/Prism","forks_url":"https://api.github.com/repos/PrismLibrary/Prism/forks","keys_url":"https://api.github.com/repos/PrismLibrary/Prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrismLibrary/Prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrismLibrary/Prism/teams","hooks_url":"https://api.github.com/repos/PrismLibrary/Prism/hooks","issue_events_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/events{/number}","events_url":"https://api.github.com/repos/PrismLibrary/Prism/events","assignees_url":"https://api.github.com/repos/PrismLibrary/Prism/assignees{/user}","branches_url":"https://api.github.com/repos/PrismLibrary/Prism/branches{/branch}","tags_url":"https://api.github.com/repos/PrismLibrary/Prism/tags","blobs_url":"https://api.github.com/repos/PrismLibrary/Prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrismLibrary/Prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrismLibrary/Prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrismLibrary/Prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrismLibrary/Prism/statuses/{sha}","languages_url":"https://api.github.com/repos/PrismLibrary/Prism/languages","stargazers_url":"https://api.github.com/repos/PrismLibrary/Prism/stargazers","contributors_url":"https://api.github.com/repos/PrismLibrary/Prism/contributors","subscribers_url":"https://api.github.com/repos/PrismLibrary/Prism/subscribers","subscription_url":"https://api.github.com/repos/PrismLibrary/Prism/subscription","commits_url":"https://api.github.com/repos/PrismLibrary/Prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrismLibrary/Prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrismLibrary/Prism/contents/{+path}","compare_url":"https://api.github.com/repos/PrismLibrary/Prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrismLibrary/Prism/merges","archive_url":"https://api.github.com/repos/PrismLibrary/Prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrismLibrary/Prism/downloads","issues_url":"https://api.github.com/repos/PrismLibrary/Prism/issues{/number}","pulls_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls{/number}","milestones_url":"https://api.github.com/repos/PrismLibrary/Prism/milestones{/number}","notifications_url":"https://api.github.com/repos/PrismLibrary/Prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrismLibrary/Prism/labels{/name}","releases_url":"https://api.github.com/repos/PrismLibrary/Prism/releases{/id}","deployments_url":"https://api.github.com/repos/PrismLibrary/Prism/deployments","created_at":"2015-02-25T20:54:32Z","updated_at":"2019-11-20T17:25:41Z","pushed_at":"2019-11-21T00:59:58Z","git_url":"git://github.com/PrismLibrary/Prism.git","ssh_url":"git@github.com:PrismLibrary/Prism.git","clone_url":"https://github.com/PrismLibrary/Prism.git","svn_url":"https://github.com/PrismLibrary/Prism","homepage":"","size":14154,"stargazers_count":3309,"watchers_count":3309,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1077,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1077,"open_issues":13,"watchers":3309,"default_branch":"master"}},"base":{"label":"PrismLibrary:master","ref":"master","sha":"ed161966d7d3c5616d09257be0a3e5c259ade8d1","user":{"login":"PrismLibrary","id":10503161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTAzMTYx","avatar_url":"https://avatars1.githubusercontent.com/u/10503161?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismLibrary","html_url":"https://github.com/PrismLibrary","followers_url":"https://api.github.com/users/PrismLibrary/followers","following_url":"https://api.github.com/users/PrismLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PrismLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismLibrary/subscriptions","organizations_url":"https://api.github.com/users/PrismLibrary/orgs","repos_url":"https://api.github.com/users/PrismLibrary/repos","events_url":"https://api.github.com/users/PrismLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PrismLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":31335300,"node_id":"MDEwOlJlcG9zaXRvcnkzMTMzNTMwMA==","name":"Prism","full_name":"PrismLibrary/Prism","private":false,"owner":{"login":"PrismLibrary","id":10503161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTAzMTYx","avatar_url":"https://avatars1.githubusercontent.com/u/10503161?v=4","gravatar_id":"","url":"https://api.github.com/users/PrismLibrary","html_url":"https://github.com/PrismLibrary","followers_url":"https://api.github.com/users/PrismLibrary/followers","following_url":"https://api.github.com/users/PrismLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PrismLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismLibrary/subscriptions","organizations_url":"https://api.github.com/users/PrismLibrary/orgs","repos_url":"https://api.github.com/users/PrismLibrary/repos","events_url":"https://api.github.com/users/PrismLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PrismLibrary/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PrismLibrary/Prism","description":"Prism is a framework for building loosely coupled, maintainable, and testable XAML applications in WPF, Windows 10 UWP, and Xamarin Forms.","fork":false,"url":"https://api.github.com/repos/PrismLibrary/Prism","forks_url":"https://api.github.com/repos/PrismLibrary/Prism/forks","keys_url":"https://api.github.com/repos/PrismLibrary/Prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrismLibrary/Prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrismLibrary/Prism/teams","hooks_url":"https://api.github.com/repos/PrismLibrary/Prism/hooks","issue_events_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/events{/number}","events_url":"https://api.github.com/repos/PrismLibrary/Prism/events","assignees_url":"https://api.github.com/repos/PrismLibrary/Prism/assignees{/user}","branches_url":"https://api.github.com/repos/PrismLibrary/Prism/branches{/branch}","tags_url":"https://api.github.com/repos/PrismLibrary/Prism/tags","blobs_url":"https://api.github.com/repos/PrismLibrary/Prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrismLibrary/Prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrismLibrary/Prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrismLibrary/Prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrismLibrary/Prism/statuses/{sha}","languages_url":"https://api.github.com/repos/PrismLibrary/Prism/languages","stargazers_url":"https://api.github.com/repos/PrismLibrary/Prism/stargazers","contributors_url":"https://api.github.com/repos/PrismLibrary/Prism/contributors","subscribers_url":"https://api.github.com/repos/PrismLibrary/Prism/subscribers","subscription_url":"https://api.github.com/repos/PrismLibrary/Prism/subscription","commits_url":"https://api.github.com/repos/PrismLibrary/Prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrismLibrary/Prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrismLibrary/Prism/contents/{+path}","compare_url":"https://api.github.com/repos/PrismLibrary/Prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrismLibrary/Prism/merges","archive_url":"https://api.github.com/repos/PrismLibrary/Prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrismLibrary/Prism/downloads","issues_url":"https://api.github.com/repos/PrismLibrary/Prism/issues{/number}","pulls_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls{/number}","milestones_url":"https://api.github.com/repos/PrismLibrary/Prism/milestones{/number}","notifications_url":"https://api.github.com/repos/PrismLibrary/Prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrismLibrary/Prism/labels{/name}","releases_url":"https://api.github.com/repos/PrismLibrary/Prism/releases{/id}","deployments_url":"https://api.github.com/repos/PrismLibrary/Prism/deployments","created_at":"2015-02-25T20:54:32Z","updated_at":"2019-11-20T17:25:41Z","pushed_at":"2019-11-21T00:59:58Z","git_url":"git://github.com/PrismLibrary/Prism.git","ssh_url":"git@github.com:PrismLibrary/Prism.git","clone_url":"https://github.com/PrismLibrary/Prism.git","svn_url":"https://github.com/PrismLibrary/Prism","homepage":"","size":14154,"stargazers_count":3309,"watchers_count":3309,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1077,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1077,"open_issues":13,"watchers":3309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1953"},"html":{"href":"https://github.com/PrismLibrary/Prism/pull/1953"},"issue":{"href":"https://api.github.com/repos/PrismLibrary/Prism/issues/1953"},"comments":{"href":"https://api.github.com/repos/PrismLibrary/Prism/issues/1953/comments"},"review_comments":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1953/comments"},"review_comment":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1953/commits"},"statuses":{"href":"https://api.github.com/repos/PrismLibrary/Prism/statuses/053eb30ee58fd0999d049d3c7681d3bc4e1eef61"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dansiegel","id":3860573,"node_id":"MDQ6VXNlcjM4NjA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/3860573?v=4","gravatar_id":"","url":"https://api.github.com/users/dansiegel","html_url":"https://github.com/dansiegel","followers_url":"https://api.github.com/users/dansiegel/followers","following_url":"https://api.github.com/users/dansiegel/following{/other_user}","gists_url":"https://api.github.com/users/dansiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/dansiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansiegel/subscriptions","organizations_url":"https://api.github.com/users/dansiegel/orgs","repos_url":"https://api.github.com/users/dansiegel/repos","events_url":"https://api.github.com/users/dansiegel/events{/privacy}","received_events_url":"https://api.github.com/users/dansiegel/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":230,"deletions":26,"changed_files":7}}
{"actor":{"display_login":"dansiegel"}}