{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/311001485","pull_request_review_id":271266406,"id":311001485,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTAwMTQ4NQ==","diff_hunk":"@@ -120,6 +123,34 @@ func testIfDocsInDir(moduleDir string) bool {\n \treturn true\n }\n \n+// compile and run the seprate go script to generate a list of default metricsets.\n+// This is done so a compile-time issue in metricbeat doesn't break the docs build\n+func getDefaultMetricsets() (map[string][]string, error) {\n+\n+\trunpaths := []string{\n+\t\tmage.OSSBeatDir(\"scripts/msetlists/main.go\"),\n+\t\tmage.XPackBeatDir(\"scripts/msetlists/main.go\"),\n+\t}\n+\n+\tvar masterMap = make(map[string][]string)\n+\tfor _, dir := range runpaths {\n+\t\trawMap, err := sh.OutCmd(\"go\", \"run\", dir)()\n+\t\tif err != nil {\n+\t\t\treturn nil, err\n+\t\t}\n+\t\tvar msetMap = make(map[string][]string)\n+\t\terr = json.Unmarshal([]byte(rawMap), &msetMap)\n+\t\tif err != nil {\n+\t\t\treturn nil, err\n+\t\t}\n+\t\tfor k, v := range msetMap {\n+\t\t\tmasterMap[k] = v\n+\t\t}\n+\t}\n+\n+\treturn masterMap, nil\n+}","path":"metricbeat/scripts/mage/docs_collector.go","position":54,"original_position":54,"commit_id":"4233fc5411de740c368f337c0e5d5d8a6afec918","original_commit_id":"4233fc5411de740c368f337c0e5d5d8a6afec918","user":{"login":"jsoriano","id":15763,"node_id":"MDQ6VXNlcjE1NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/15763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsoriano","html_url":"https://github.com/jsoriano","followers_url":"https://api.github.com/users/jsoriano/followers","following_url":"https://api.github.com/users/jsoriano/following{/other_user}","gists_url":"https://api.github.com/users/jsoriano/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoriano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoriano/subscriptions","organizations_url":"https://api.github.com/users/jsoriano/orgs","repos_url":"https://api.github.com/users/jsoriano/repos","events_url":"https://api.github.com/users/jsoriano/events{/privacy}","received_events_url":"https://api.github.com/users/jsoriano/received_events","type":"User","site_admin":false},"body":"Ok, let's go with this approach, it'd be similar to other x-pack scripts being called from OSS build scripts.","created_at":"2019-08-06T10:55:36Z","updated_at":"2019-08-06T10:56:09Z","html_url":"https://github.com/elastic/beats/pull/12648#discussion_r311001485","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/12648","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/311001485"},"html":{"href":"https://github.com/elastic/beats/pull/12648#discussion_r311001485"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/12648"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/12648","id":291127231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMTI3MjMx","html_url":"https://github.com/elastic/beats/pull/12648","diff_url":"https://github.com/elastic/beats/pull/12648.diff","patch_url":"https://github.com/elastic/beats/pull/12648.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/12648","number":12648,"state":"open","locked":false,"title":"[Metricbeat] Better document default metricsets","user":{"login":"fearful-symmetry","id":8418476,"node_id":"MDQ6VXNlcjg0MTg0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8418476?v=4","gravatar_id":"","url":"https://api.github.com/users/fearful-symmetry","html_url":"https://github.com/fearful-symmetry","followers_url":"https://api.github.com/users/fearful-symmetry/followers","following_url":"https://api.github.com/users/fearful-symmetry/following{/other_user}","gists_url":"https://api.github.com/users/fearful-symmetry/gists{/gist_id}","starred_url":"https://api.github.com/users/fearful-symmetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearful-symmetry/subscriptions","organizations_url":"https://api.github.com/users/fearful-symmetry/orgs","repos_url":"https://api.github.com/users/fearful-symmetry/repos","events_url":"https://api.github.com/users/fearful-symmetry/events{/privacy}","received_events_url":"https://api.github.com/users/fearful-symmetry/received_events","type":"User","site_admin":false},"body":"See elastic/beats#12502 \r\n\r\nThis is a change to better document the idea of 'default metricsets' and to add a section to each module asciidoc saying what the default metricsets are, as the logic is buried in code.\r\n\r\nThe reason this is a draft is, obviously, that there's a doc change for only one module. I figured before I ran this change on _everything_ we should look it over and decide if we're happy with format/everything else.\r\n\r\nI wrote a simple bash script to extract the default modules and add the blurb you see in the draft PR. Is this how we want to do it? Do we want to create some make/mage recipe? ","created_at":"2019-06-24T13:13:25Z","updated_at":"2019-08-06T10:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c40db923e06a90886305c22737caf26563b75bf0","assignee":{"login":"fearful-symmetry","id":8418476,"node_id":"MDQ6VXNlcjg0MTg0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8418476?v=4","gravatar_id":"","url":"https://api.github.com/users/fearful-symmetry","html_url":"https://github.com/fearful-symmetry","followers_url":"https://api.github.com/users/fearful-symmetry/followers","following_url":"https://api.github.com/users/fearful-symmetry/following{/other_user}","gists_url":"https://api.github.com/users/fearful-symmetry/gists{/gist_id}","starred_url":"https://api.github.com/users/fearful-symmetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearful-symmetry/subscriptions","organizations_url":"https://api.github.com/users/fearful-symmetry/orgs","repos_url":"https://api.github.com/users/fearful-symmetry/repos","events_url":"https://api.github.com/users/fearful-symmetry/events{/privacy}","received_events_url":"https://api.github.com/users/fearful-symmetry/received_events","type":"User","site_admin":false},"assignees":[{"login":"fearful-symmetry","id":8418476,"node_id":"MDQ6VXNlcjg0MTg0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8418476?v=4","gravatar_id":"","url":"https://api.github.com/users/fearful-symmetry","html_url":"https://github.com/fearful-symmetry","followers_url":"https://api.github.com/users/fearful-symmetry/followers","following_url":"https://api.github.com/users/fearful-symmetry/following{/other_user}","gists_url":"https://api.github.com/users/fearful-symmetry/gists{/gist_id}","starred_url":"https://api.github.com/users/fearful-symmetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearful-symmetry/subscriptions","organizations_url":"https://api.github.com/users/fearful-symmetry/orgs","repos_url":"https://api.github.com/users/fearful-symmetry/repos","events_url":"https://api.github.com/users/fearful-symmetry/events{/privacy}","received_events_url":"https://api.github.com/users/fearful-symmetry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1135227315,"node_id":"MDU6TGFiZWwxMTM1MjI3MzE1","url":"https://api.github.com/repos/elastic/beats/labels/:infrastructure","name":":infrastructure","color":"47e8a5","default":false},{"id":331378892,"node_id":"MDU6TGFiZWwzMzEzNzg4OTI=","url":"https://api.github.com/repos/elastic/beats/labels/Metricbeat","name":"Metricbeat","color":"008000","default":false},{"id":1135206238,"node_id":"MDU6TGFiZWwxMTM1MjA2MjM4","url":"https://api.github.com/repos/elastic/beats/labels/[zube]:%20In%20Progress","name":"[zube]: In Progress","color":"ffffff","default":false},{"id":196350690,"node_id":"MDU6TGFiZWwxOTYzNTA2OTA=","url":"https://api.github.com/repos/elastic/beats/labels/docs","name":"docs","color":"b3694f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/12648/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/12648/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/12648/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/4233fc5411de740c368f337c0e5d5d8a6afec918","head":{"label":"fearful-symmetry:document-default-metricsets","ref":"document-default-metricsets","sha":"4233fc5411de740c368f337c0e5d5d8a6afec918","user":{"login":"fearful-symmetry","id":8418476,"node_id":"MDQ6VXNlcjg0MTg0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8418476?v=4","gravatar_id":"","url":"https://api.github.com/users/fearful-symmetry","html_url":"https://github.com/fearful-symmetry","followers_url":"https://api.github.com/users/fearful-symmetry/followers","following_url":"https://api.github.com/users/fearful-symmetry/following{/other_user}","gists_url":"https://api.github.com/users/fearful-symmetry/gists{/gist_id}","starred_url":"https://api.github.com/users/fearful-symmetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearful-symmetry/subscriptions","organizations_url":"https://api.github.com/users/fearful-symmetry/orgs","repos_url":"https://api.github.com/users/fearful-symmetry/repos","events_url":"https://api.github.com/users/fearful-symmetry/events{/privacy}","received_events_url":"https://api.github.com/users/fearful-symmetry/received_events","type":"User","site_admin":false},"repo":{"id":173817863,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM4MTc4NjM=","name":"beats","full_name":"fearful-symmetry/beats","private":false,"owner":{"login":"fearful-symmetry","id":8418476,"node_id":"MDQ6VXNlcjg0MTg0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/8418476?v=4","gravatar_id":"","url":"https://api.github.com/users/fearful-symmetry","html_url":"https://github.com/fearful-symmetry","followers_url":"https://api.github.com/users/fearful-symmetry/followers","following_url":"https://api.github.com/users/fearful-symmetry/following{/other_user}","gists_url":"https://api.github.com/users/fearful-symmetry/gists{/gist_id}","starred_url":"https://api.github.com/users/fearful-symmetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fearful-symmetry/subscriptions","organizations_url":"https://api.github.com/users/fearful-symmetry/orgs","repos_url":"https://api.github.com/users/fearful-symmetry/repos","events_url":"https://api.github.com/users/fearful-symmetry/events{/privacy}","received_events_url":"https://api.github.com/users/fearful-symmetry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fearful-symmetry/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/fearful-symmetry/beats","forks_url":"https://api.github.com/repos/fearful-symmetry/beats/forks","keys_url":"https://api.github.com/repos/fearful-symmetry/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fearful-symmetry/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fearful-symmetry/beats/teams","hooks_url":"https://api.github.com/repos/fearful-symmetry/beats/hooks","issue_events_url":"https://api.github.com/repos/fearful-symmetry/beats/issues/events{/number}","events_url":"https://api.github.com/repos/fearful-symmetry/beats/events","assignees_url":"https://api.github.com/repos/fearful-symmetry/beats/assignees{/user}","branches_url":"https://api.github.com/repos/fearful-symmetry/beats/branches{/branch}","tags_url":"https://api.github.com/repos/fearful-symmetry/beats/tags","blobs_url":"https://api.github.com/repos/fearful-symmetry/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fearful-symmetry/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fearful-symmetry/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/fearful-symmetry/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fearful-symmetry/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/fearful-symmetry/beats/languages","stargazers_url":"https://api.github.com/repos/fearful-symmetry/beats/stargazers","contributors_url":"https://api.github.com/repos/fearful-symmetry/beats/contributors","subscribers_url":"https://api.github.com/repos/fearful-symmetry/beats/subscribers","subscription_url":"https://api.github.com/repos/fearful-symmetry/beats/subscription","commits_url":"https://api.github.com/repos/fearful-symmetry/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/fearful-symmetry/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/fearful-symmetry/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/fearful-symmetry/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/fearful-symmetry/beats/contents/{+path}","compare_url":"https://api.github.com/repos/fearful-symmetry/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fearful-symmetry/beats/merges","archive_url":"https://api.github.com/repos/fearful-symmetry/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fearful-symmetry/beats/downloads","issues_url":"https://api.github.com/repos/fearful-symmetry/beats/issues{/number}","pulls_url":"https://api.github.com/repos/fearful-symmetry/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/fearful-symmetry/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/fearful-symmetry/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fearful-symmetry/beats/labels{/name}","releases_url":"https://api.github.com/repos/fearful-symmetry/beats/releases{/id}","deployments_url":"https://api.github.com/repos/fearful-symmetry/beats/deployments","created_at":"2019-03-04T20:40:11Z","updated_at":"2019-07-03T18:13:47Z","pushed_at":"2019-08-06T01:33:57Z","git_url":"git://github.com/fearful-symmetry/beats.git","ssh_url":"git@github.com:fearful-symmetry/beats.git","clone_url":"https://github.com/fearful-symmetry/beats.git","svn_url":"https://github.com/fearful-symmetry/beats","homepage":"https://www.elastic.co/products/beats","size":156839,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"5e3d16e12f5fc74d75b35d6a839ce2850c4c57d8","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU1NDczOQ==","name":"beats","full_name":"elastic/beats","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2019-08-06T10:30:33Z","pushed_at":"2019-08-06T09:08:33Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":161229,"stargazers_count":7649,"watchers_count":7649,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2615,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1442,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2615,"open_issues":1442,"watchers":7649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/12648"},"html":{"href":"https://github.com/elastic/beats/pull/12648"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/12648"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/12648/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/12648/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/12648/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/4233fc5411de740c368f337c0e5d5d8a6afec918"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsoriano"}}