{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/Sentinel/issues/72","repository_url":"https://api.github.com/repos/alibaba/Sentinel","labels_url":"https://api.github.com/repos/alibaba/Sentinel/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/Sentinel/issues/72/comments","events_url":"https://api.github.com/repos/alibaba/Sentinel/issues/72/events","html_url":"https://github.com/alibaba/Sentinel/pull/72","id":351471873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDU2MDQ1","number":72,"title":"增加对properties文件的支持: ali-sentinel.properties","user":{"login":"VanXD","id":9159171,"node_id":"MDQ6VXNlcjkxNTkxNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/9159171?v=4","gravatar_id":"","url":"https://api.github.com/users/VanXD","html_url":"https://github.com/VanXD","followers_url":"https://api.github.com/users/VanXD/followers","following_url":"https://api.github.com/users/VanXD/following{/other_user}","gists_url":"https://api.github.com/users/VanXD/gists{/gist_id}","starred_url":"https://api.github.com/users/VanXD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VanXD/subscriptions","organizations_url":"https://api.github.com/users/VanXD/orgs","repos_url":"https://api.github.com/users/VanXD/repos","events_url":"https://api.github.com/users/VanXD/events{/privacy}","received_events_url":"https://api.github.com/users/VanXD/received_events","type":"User","site_admin":false},"labels":[{"id":1210840061,"node_id":"MDU6TGFiZWwxMjEwODQwMDYx","url":"https://api.github.com/repos/alibaba/Sentinel/labels/area/configuration","name":"area/configuration","color":"e27e4f","default":false},{"id":1198529213,"node_id":"MDU6TGFiZWwxMTk4NTI5MjEz","url":"https://api.github.com/repos/alibaba/Sentinel/labels/merge-conflict","name":"merge-conflict","color":"e11d21","default":false},{"id":1008973333,"node_id":"MDU6TGFiZWwxMDA4OTczMzMz","url":"https://api.github.com/repos/alibaba/Sentinel/labels/to%20review","name":"to review","color":"cfd3d7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-17T06:24:59Z","updated_at":"2019-04-20T14:11:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alibaba/Sentinel/pulls/72","html_url":"https://github.com/alibaba/Sentinel/pull/72","diff_url":"https://github.com/alibaba/Sentinel/pull/72.diff","patch_url":"https://github.com/alibaba/Sentinel/pull/72.patch"},"body":"### Describe what this PR does / why we need it\r\n更方便的对sentinel进行配置.\r\nConvenient to write configuration.\r\n\r\n### Does this pull request fix one issue?\r\nFixes #64 \r\n\r\n### Describe how you did it\r\n1. 兼容了原来的模式, 从JVM上加载相应的参数.\r\n2. 如果JVM上没有配置project.name,则使用默认的文件名\"ali-sentinel.properties\"进行加载.\r\n###\r\n1. Compatible with old version.\r\n2. If project.name is not configured on the JVM, it is loaded with the default filename \"ali-sentinel.properties\".\r\n\r\n### Describe how to verify it\r\n在resources文件夹下创建\"ali-sentinel.properties\"文件.并且在其中书写配置.\r\ncreate file in resources dir, and write your configuration.\r\n\r\n### Special notes for reviews\r\nno"},"comment":{"url":"https://api.github.com/repos/alibaba/Sentinel/issues/comments/485127153","html_url":"https://github.com/alibaba/Sentinel/pull/72#issuecomment-485127153","issue_url":"https://api.github.com/repos/alibaba/Sentinel/issues/72","id":485127153,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NTEyNzE1Mw==","user":{"login":"pouchrobot","id":33292901,"node_id":"MDQ6VXNlcjMzMjkyOTAx","avatar_url":"https://avatars1.githubusercontent.com/u/33292901?v=4","gravatar_id":"","url":"https://api.github.com/users/pouchrobot","html_url":"https://github.com/pouchrobot","followers_url":"https://api.github.com/users/pouchrobot/followers","following_url":"https://api.github.com/users/pouchrobot/following{/other_user}","gists_url":"https://api.github.com/users/pouchrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/pouchrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pouchrobot/subscriptions","organizations_url":"https://api.github.com/users/pouchrobot/orgs","repos_url":"https://api.github.com/users/pouchrobot/repos","events_url":"https://api.github.com/users/pouchrobot/events{/privacy}","received_events_url":"https://api.github.com/users/pouchrobot/received_events","type":"User","site_admin":false},"created_at":"2019-04-20T14:11:22Z","updated_at":"2019-04-20T14:11:22Z","author_association":"NONE","body":"ping @VanXD \nConflict happens after merging a previous commit.\nPlease rebase the branch against master and push it back again. Thanks a lot.\n"}}
{"actor":{"display_login":"pouchrobot"}}