{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/273909467","pull_request_review_id":224908340,"id":273909467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzkwOTQ2Nw==","diff_hunk":"@@ -594,7 +594,7 @@ function sparse!(I::AbstractVector{Ti}, J::AbstractVector{Ti},\n         csccolptr::Vector{Ti}, cscrowval::Vector{Ti}, cscnzval::Vector{Tv}) where {Tv,Ti<:Integer}\n \n     require_one_based_indexing(I, J, V)\n-    sparse_check_Ti(m, n, Ti)\n+    sparse_check_Ti(m, n, length(V), Ti)","path":"stdlib/SparseArrays/src/sparsematrix.jl","position":32,"original_position":32,"commit_id":"ab1c063ed6efc6f32fe902a946cec20bd0ca57ec","original_commit_id":"ab1c063ed6efc6f32fe902a946cec20bd0ca57ec","user":{"login":"KlausC","id":6223854,"node_id":"MDQ6VXNlcjYyMjM4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6223854?v=4","gravatar_id":"","url":"https://api.github.com/users/KlausC","html_url":"https://github.com/KlausC","followers_url":"https://api.github.com/users/KlausC/followers","following_url":"https://api.github.com/users/KlausC/following{/other_user}","gists_url":"https://api.github.com/users/KlausC/gists{/gist_id}","starred_url":"https://api.github.com/users/KlausC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KlausC/subscriptions","organizations_url":"https://api.github.com/users/KlausC/orgs","repos_url":"https://api.github.com/users/KlausC/repos","events_url":"https://api.github.com/users/KlausC/events{/privacy}","received_events_url":"https://api.github.com/users/KlausC/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    sparse_check_Ti(m, n, length(I), Ti)\r\n```","created_at":"2019-04-10T11:23:55Z","updated_at":"2019-04-10T11:23:55Z","html_url":"https://github.com/JuliaLang/julia/pull/31661#discussion_r273909467","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/31661","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/273909467"},"html":{"href":"https://github.com/JuliaLang/julia/pull/31661#discussion_r273909467"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/31661"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/31661","id":268925901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4OTI1OTAx","html_url":"https://github.com/JuliaLang/julia/pull/31661","diff_url":"https://github.com/JuliaLang/julia/pull/31661.diff","patch_url":"https://github.com/JuliaLang/julia/pull/31661.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/31661","number":31661,"state":"open","locked":false,"title":"Loosen SparseMatrixCSC colptr and rowval integer type restriction","user":{"login":"Pbellive","id":6206759,"node_id":"MDQ6VXNlcjYyMDY3NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6206759?v=4","gravatar_id":"","url":"https://api.github.com/users/Pbellive","html_url":"https://github.com/Pbellive","followers_url":"https://api.github.com/users/Pbellive/followers","following_url":"https://api.github.com/users/Pbellive/following{/other_user}","gists_url":"https://api.github.com/users/Pbellive/gists{/gist_id}","starred_url":"https://api.github.com/users/Pbellive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pbellive/subscriptions","organizations_url":"https://api.github.com/users/Pbellive/orgs","repos_url":"https://api.github.com/users/Pbellive/repos","events_url":"https://api.github.com/users/Pbellive/events{/privacy}","received_events_url":"https://api.github.com/users/Pbellive/received_events","type":"User","site_admin":false},"body":"This fixes #31435. Please see that issue for full explanation. @KlausC any objection to this change?","created_at":"2019-04-09T21:08:15Z","updated_at":"2019-04-10T11:23:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a30f265cb8c495a7b8fbd16418c8f528829ff7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":414648058,"node_id":"MDU6TGFiZWw0MTQ2NDgwNTg=","url":"https://api.github.com/repos/JuliaLang/julia/labels/bugfix","name":"bugfix","color":"0e8a16","default":false},{"id":94575532,"node_id":"MDU6TGFiZWw5NDU3NTUzMg==","url":"https://api.github.com/repos/JuliaLang/julia/labels/sparse","name":"sparse","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/30","html_url":"https://github.com/JuliaLang/julia/milestone/30","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/30/labels","id":3695139,"node_id":"MDk6TWlsZXN0b25lMzY5NTEzOQ==","number":30,"title":"1.2","description":"","creator":{"login":"JeffBezanson","id":744556,"node_id":"MDQ6VXNlcjc0NDU1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/744556?v=4","gravatar_id":"","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":17,"state":"open","created_at":"2018-09-27T23:43:23Z","updated_at":"2019-04-09T23:12:29Z","due_on":"2019-03-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/31661/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/31661/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/31661/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/ab1c063ed6efc6f32fe902a946cec20bd0ca57ec","head":{"label":"Pbellive:sparse-matrix-type-checking","ref":"sparse-matrix-type-checking","sha":"ab1c063ed6efc6f32fe902a946cec20bd0ca57ec","user":{"login":"Pbellive","id":6206759,"node_id":"MDQ6VXNlcjYyMDY3NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6206759?v=4","gravatar_id":"","url":"https://api.github.com/users/Pbellive","html_url":"https://github.com/Pbellive","followers_url":"https://api.github.com/users/Pbellive/followers","following_url":"https://api.github.com/users/Pbellive/following{/other_user}","gists_url":"https://api.github.com/users/Pbellive/gists{/gist_id}","starred_url":"https://api.github.com/users/Pbellive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pbellive/subscriptions","organizations_url":"https://api.github.com/users/Pbellive/orgs","repos_url":"https://api.github.com/users/Pbellive/repos","events_url":"https://api.github.com/users/Pbellive/events{/privacy}","received_events_url":"https://api.github.com/users/Pbellive/received_events","type":"User","site_admin":false},"repo":{"id":110062080,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwNjIwODA=","name":"julia","full_name":"Pbellive/julia","private":false,"owner":{"login":"Pbellive","id":6206759,"node_id":"MDQ6VXNlcjYyMDY3NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6206759?v=4","gravatar_id":"","url":"https://api.github.com/users/Pbellive","html_url":"https://github.com/Pbellive","followers_url":"https://api.github.com/users/Pbellive/followers","following_url":"https://api.github.com/users/Pbellive/following{/other_user}","gists_url":"https://api.github.com/users/Pbellive/gists{/gist_id}","starred_url":"https://api.github.com/users/Pbellive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pbellive/subscriptions","organizations_url":"https://api.github.com/users/Pbellive/orgs","repos_url":"https://api.github.com/users/Pbellive/repos","events_url":"https://api.github.com/users/Pbellive/events{/privacy}","received_events_url":"https://api.github.com/users/Pbellive/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Pbellive/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/Pbellive/julia","forks_url":"https://api.github.com/repos/Pbellive/julia/forks","keys_url":"https://api.github.com/repos/Pbellive/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pbellive/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pbellive/julia/teams","hooks_url":"https://api.github.com/repos/Pbellive/julia/hooks","issue_events_url":"https://api.github.com/repos/Pbellive/julia/issues/events{/number}","events_url":"https://api.github.com/repos/Pbellive/julia/events","assignees_url":"https://api.github.com/repos/Pbellive/julia/assignees{/user}","branches_url":"https://api.github.com/repos/Pbellive/julia/branches{/branch}","tags_url":"https://api.github.com/repos/Pbellive/julia/tags","blobs_url":"https://api.github.com/repos/Pbellive/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pbellive/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pbellive/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pbellive/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pbellive/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/Pbellive/julia/languages","stargazers_url":"https://api.github.com/repos/Pbellive/julia/stargazers","contributors_url":"https://api.github.com/repos/Pbellive/julia/contributors","subscribers_url":"https://api.github.com/repos/Pbellive/julia/subscribers","subscription_url":"https://api.github.com/repos/Pbellive/julia/subscription","commits_url":"https://api.github.com/repos/Pbellive/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pbellive/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pbellive/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pbellive/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pbellive/julia/contents/{+path}","compare_url":"https://api.github.com/repos/Pbellive/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pbellive/julia/merges","archive_url":"https://api.github.com/repos/Pbellive/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pbellive/julia/downloads","issues_url":"https://api.github.com/repos/Pbellive/julia/issues{/number}","pulls_url":"https://api.github.com/repos/Pbellive/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/Pbellive/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/Pbellive/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pbellive/julia/labels{/name}","releases_url":"https://api.github.com/repos/Pbellive/julia/releases{/id}","deployments_url":"https://api.github.com/repos/Pbellive/julia/deployments","created_at":"2017-11-09T03:22:08Z","updated_at":"2017-11-09T03:22:20Z","pushed_at":"2019-04-09T21:05:30Z","git_url":"git://github.com/Pbellive/julia.git","ssh_url":"git@github.com:Pbellive/julia.git","clone_url":"https://github.com/Pbellive/julia.git","svn_url":"https://github.com/Pbellive/julia","homepage":"https://julialang.org/","size":322569,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"4671132ee1424b152e567e058e82a11a6591b564","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","private":false,"owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2019-04-10T11:20:28Z","pushed_at":"2019-04-10T10:51:44Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":169066,"stargazers_count":21525,"watchers_count":21525,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3291,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3254,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3291,"open_issues":3254,"watchers":21525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/31661"},"html":{"href":"https://github.com/JuliaLang/julia/pull/31661"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/31661"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/31661/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/31661/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/31661/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/ab1c063ed6efc6f32fe902a946cec20bd0ca57ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KlausC"}}