{"action":"created","comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/361709168","pull_request_review_id":336826893,"id":361709168,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTcwOTE2OA==","diff_hunk":"@@ -170,11 +171,12 @@ QMLManager::QMLManager() : m_locationServiceEnabled(false),\n \t\t\tthis, &QMLManager::uploadProgress);\n \n \t// uploadDiveShare::uploadFinish() is defined with 3 parameters,\n-\t// whereas QMLManager::uploadFinish() is defined with 2 paramters,\n+\t// whereas QMLManager::uploadFinish() is defined with 2 parameters,\n \t// Solution add a slot as landing zone.\n-\tconnect(uploadDiveShare::instance(), SIGNAL(uploadDiveShare::uploadFinish(bool, const QString &, const QByteArray &)),\n-\t\t\tthis, SLOT(uploadFinishSlot(bool, const QString &, const QByteArray &)));\n+\tconnect(uploadDiveShare::instance(), &uploadDiveShare::uploadFinish,\n+\t\t\tthis, &QMLManager::uploadFinishSlot);\n \n+\tvoid uploadFinish(bool success, const QString &text, const QByteArray &html);","path":"mobile-widgets/qmlmanager.cpp","position":20,"original_position":20,"commit_id":"18f8f559fbc12e3f817c2aad8bcd02b9ffaadcdb","original_commit_id":"18f8f559fbc12e3f817c2aad8bcd02b9ffaadcdb","user":{"login":"dirkhh","id":237471,"node_id":"MDQ6VXNlcjIzNzQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/237471?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkhh","html_url":"https://github.com/dirkhh","followers_url":"https://api.github.com/users/dirkhh/followers","following_url":"https://api.github.com/users/dirkhh/following{/other_user}","gists_url":"https://api.github.com/users/dirkhh/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkhh/subscriptions","organizations_url":"https://api.github.com/users/dirkhh/orgs","repos_url":"https://api.github.com/users/dirkhh/repos","events_url":"https://api.github.com/users/dirkhh/events{/privacy}","received_events_url":"https://api.github.com/users/dirkhh/received_events","type":"User","site_admin":false},"body":"I'm surprised by this declaration in the middle of the C++ file. Can you explain the logic here?","created_at":"2019-12-27T17:20:09Z","updated_at":"2019-12-27T17:20:15Z","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/2487#discussion_r361709168","pull_request_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments/361709168"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/2487#discussion_r361709168"},"pull_request":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487"}}},"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487","id":357220365,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3MjIwMzY1","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/2487","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/2487.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/2487.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/2487","number":2487,"state":"open","locked":false,"title":"Bugfix: faulty connect in qmlmanager","user":{"login":"janiversen","id":6185391,"node_id":"MDQ6VXNlcjYxODUzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"body":"<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [x ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\n1) add comment line (signal to signal)\r\n2) correct spelling error in comment\r\n3) correct connect\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n","created_at":"2019-12-27T12:28:07Z","updated_at":"2019-12-27T17:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af0eb4b20349c6f8cbfbd9cf8211005df463f2b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/2487/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/18f8f559fbc12e3f817c2aad8bcd02b9ffaadcdb","head":{"label":"janiversen:bugfix1","ref":"bugfix1","sha":"18f8f559fbc12e3f817c2aad8bcd02b9ffaadcdb","user":{"login":"janiversen","id":6185391,"node_id":"MDQ6VXNlcjYxODUzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"repo":{"id":130397967,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzOTc5Njc=","name":"subsurface-mobile-enhancements","full_name":"janiversen/subsurface-mobile-enhancements","private":false,"owner":{"login":"janiversen","id":6185391,"node_id":"MDQ6VXNlcjYxODUzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/janiversen/subsurface-mobile-enhancements","description":"Fork of Subsurface, focussing on mobile enhancements","fork":true,"url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements","forks_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/forks","keys_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/teams","hooks_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/hooks","issue_events_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/issues/events{/number}","events_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/events","assignees_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/assignees{/user}","branches_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/branches{/branch}","tags_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/tags","blobs_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/git/refs{/sha}","trees_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/statuses/{sha}","languages_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/languages","stargazers_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/stargazers","contributors_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/contributors","subscribers_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/subscribers","subscription_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/subscription","commits_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/commits{/sha}","git_commits_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/git/commits{/sha}","comments_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/comments{/number}","issue_comment_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/issues/comments{/number}","contents_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/contents/{+path}","compare_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/merges","archive_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/downloads","issues_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/issues{/number}","pulls_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/pulls{/number}","milestones_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/milestones{/number}","notifications_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/labels{/name}","releases_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/releases{/id}","deployments_url":"https://api.github.com/repos/janiversen/subsurface-mobile-enhancements/deployments","created_at":"2018-04-20T18:11:15Z","updated_at":"2019-12-26T19:32:01Z","pushed_at":"2019-12-27T13:56:09Z","git_url":"git://github.com/janiversen/subsurface-mobile-enhancements.git","ssh_url":"git@github.com:janiversen/subsurface-mobile-enhancements.git","clone_url":"https://github.com/janiversen/subsurface-mobile-enhancements.git","svn_url":"https://github.com/janiversen/subsurface-mobile-enhancements","homepage":"","size":109405,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"88cbcf5c6ea56a8e31617a426e7ca8221999afe8","user":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"node_id":"MDEwOlJlcG9zaXRvcnkyMzE5NDk4","name":"subsurface","full_name":"Subsurface-divelog/subsurface","private":false,"owner":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2019-12-27T00:16:05Z","pushed_at":"2019-12-27T13:59:18Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":109870,"stargazers_count":1644,"watchers_count":1644,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":156,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":386,"open_issues":156,"watchers":1644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/2487"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/2487"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/2487/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/2487/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/18f8f559fbc12e3f817c2aad8bcd02b9ffaadcdb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dirkhh"}}