{"action":"created","comment":{"url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/comments/270662252","pull_request_review_id":220855902,"id":270662252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDY2MjI1Mg==","diff_hunk":"@@ -386,6 +391,39 @@\n    \"source\": [\n     \"submission.to_csv(os.path.join(data_dir, \\\"submissions\\\", \\\"submission_full_cycles_XGBoost_extened_dataset.csv\\\"), index=False)\"\n    ]\n+  },\n+  {\n+   \"cell_type\": \"markdown\",\n+   \"metadata\": {},\n+   \"source\": [\n+    \"## 4. Compare distributions\\n\",\n+    \"Here we check if the data distributions of the features on the train and test are the same Kolmogorov-Smirnov test.\\n\"\n+   ]","path":"earthquakes/notebooks/source memory.ipynb","position":49,"original_position":49,"commit_id":"2871818909a8ed1775e0e51336e763af4e90c848","original_commit_id":"2871818909a8ed1775e0e51336e763af4e90c848","user":{"login":"joepvdbogaert","id":32506895,"node_id":"MDQ6VXNlcjMyNTA2ODk1","avatar_url":"https://avatars1.githubusercontent.com/u/32506895?v=4","gravatar_id":"","url":"https://api.github.com/users/joepvdbogaert","html_url":"https://github.com/joepvdbogaert","followers_url":"https://api.github.com/users/joepvdbogaert/followers","following_url":"https://api.github.com/users/joepvdbogaert/following{/other_user}","gists_url":"https://api.github.com/users/joepvdbogaert/gists{/gist_id}","starred_url":"https://api.github.com/users/joepvdbogaert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joepvdbogaert/subscriptions","organizations_url":"https://api.github.com/users/joepvdbogaert/orgs","repos_url":"https://api.github.com/users/joepvdbogaert/repos","events_url":"https://api.github.com/users/joepvdbogaert/events{/privacy}","received_events_url":"https://api.github.com/users/joepvdbogaert/received_events","type":"User","site_admin":false},"body":"I checked for some distributions of random features and found that the results are not always what you expect. For example, check the `0_mean` in this figure, which are clearly different distributions, yet the function says \"same dist\".\r\n\r\n![image](https://user-images.githubusercontent.com/32506895/55288462-63810b00-53b8-11e9-9606-c71da06f23b8.png)\r\n\r\nMaybe we should use a higher default value of alpha? Then we will reject the null-hypothesis more often, which is the more conservative options in our case.\r\n","created_at":"2019-03-31T11:35:12Z","updated_at":"2019-03-31T11:41:27Z","html_url":"https://github.com/MLblog/jads_kaggle/pull/136#discussion_r270662252","pull_request_url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/comments/270662252"},"html":{"href":"https://github.com/MLblog/jads_kaggle/pull/136#discussion_r270662252"},"pull_request":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136","id":265718790,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1NzE4Nzkw","html_url":"https://github.com/MLblog/jads_kaggle/pull/136","diff_url":"https://github.com/MLblog/jads_kaggle/pull/136.diff","patch_url":"https://github.com/MLblog/jads_kaggle/pull/136.patch","issue_url":"https://api.github.com/repos/MLblog/jads_kaggle/issues/136","number":136,"state":"open","locked":false,"title":"Compare distributions","user":{"login":"san89","id":7827001,"node_id":"MDQ6VXNlcjc4MjcwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7827001?v=4","gravatar_id":"","url":"https://api.github.com/users/san89","html_url":"https://github.com/san89","followers_url":"https://api.github.com/users/san89/followers","following_url":"https://api.github.com/users/san89/following{/other_user}","gists_url":"https://api.github.com/users/san89/gists{/gist_id}","starred_url":"https://api.github.com/users/san89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san89/subscriptions","organizations_url":"https://api.github.com/users/san89/orgs","repos_url":"https://api.github.com/users/san89/repos","events_url":"https://api.github.com/users/san89/events{/privacy}","received_events_url":"https://api.github.com/users/san89/received_events","type":"User","site_admin":false},"body":"Adding functionalities to compare feature distributions between train and test.\r\n\r\n- `helpers.py`: new function `check_distributions_train_test`  to test if two distributions are similar.\r\n- `source memory.ipynb`: Includes example to use the `check_distributions_train_test`.\r\n\r\n\r\n","created_at":"2019-03-29T13:37:41Z","updated_at":"2019-03-31T11:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1408b36c6494b2bcd3c4a7d83e0c7e3c05f040ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136/commits","review_comments_url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136/comments","review_comment_url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MLblog/jads_kaggle/issues/136/comments","statuses_url":"https://api.github.com/repos/MLblog/jads_kaggle/statuses/2871818909a8ed1775e0e51336e763af4e90c848","head":{"label":"san89:compare-dist","ref":"compare-dist","sha":"2871818909a8ed1775e0e51336e763af4e90c848","user":{"login":"san89","id":7827001,"node_id":"MDQ6VXNlcjc4MjcwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7827001?v=4","gravatar_id":"","url":"https://api.github.com/users/san89","html_url":"https://github.com/san89","followers_url":"https://api.github.com/users/san89/followers","following_url":"https://api.github.com/users/san89/following{/other_user}","gists_url":"https://api.github.com/users/san89/gists{/gist_id}","starred_url":"https://api.github.com/users/san89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san89/subscriptions","organizations_url":"https://api.github.com/users/san89/orgs","repos_url":"https://api.github.com/users/san89/repos","events_url":"https://api.github.com/users/san89/events{/privacy}","received_events_url":"https://api.github.com/users/san89/received_events","type":"User","site_admin":false},"repo":{"id":118319025,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzMTkwMjU=","name":"jads_kaggle","full_name":"san89/jads_kaggle","private":false,"owner":{"login":"san89","id":7827001,"node_id":"MDQ6VXNlcjc4MjcwMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7827001?v=4","gravatar_id":"","url":"https://api.github.com/users/san89","html_url":"https://github.com/san89","followers_url":"https://api.github.com/users/san89/followers","following_url":"https://api.github.com/users/san89/following{/other_user}","gists_url":"https://api.github.com/users/san89/gists{/gist_id}","starred_url":"https://api.github.com/users/san89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san89/subscriptions","organizations_url":"https://api.github.com/users/san89/orgs","repos_url":"https://api.github.com/users/san89/repos","events_url":"https://api.github.com/users/san89/events{/privacy}","received_events_url":"https://api.github.com/users/san89/received_events","type":"User","site_admin":false},"html_url":"https://github.com/san89/jads_kaggle","description":"Contains our group's work in various kaggle competitions","fork":true,"url":"https://api.github.com/repos/san89/jads_kaggle","forks_url":"https://api.github.com/repos/san89/jads_kaggle/forks","keys_url":"https://api.github.com/repos/san89/jads_kaggle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/san89/jads_kaggle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/san89/jads_kaggle/teams","hooks_url":"https://api.github.com/repos/san89/jads_kaggle/hooks","issue_events_url":"https://api.github.com/repos/san89/jads_kaggle/issues/events{/number}","events_url":"https://api.github.com/repos/san89/jads_kaggle/events","assignees_url":"https://api.github.com/repos/san89/jads_kaggle/assignees{/user}","branches_url":"https://api.github.com/repos/san89/jads_kaggle/branches{/branch}","tags_url":"https://api.github.com/repos/san89/jads_kaggle/tags","blobs_url":"https://api.github.com/repos/san89/jads_kaggle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/san89/jads_kaggle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/san89/jads_kaggle/git/refs{/sha}","trees_url":"https://api.github.com/repos/san89/jads_kaggle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/san89/jads_kaggle/statuses/{sha}","languages_url":"https://api.github.com/repos/san89/jads_kaggle/languages","stargazers_url":"https://api.github.com/repos/san89/jads_kaggle/stargazers","contributors_url":"https://api.github.com/repos/san89/jads_kaggle/contributors","subscribers_url":"https://api.github.com/repos/san89/jads_kaggle/subscribers","subscription_url":"https://api.github.com/repos/san89/jads_kaggle/subscription","commits_url":"https://api.github.com/repos/san89/jads_kaggle/commits{/sha}","git_commits_url":"https://api.github.com/repos/san89/jads_kaggle/git/commits{/sha}","comments_url":"https://api.github.com/repos/san89/jads_kaggle/comments{/number}","issue_comment_url":"https://api.github.com/repos/san89/jads_kaggle/issues/comments{/number}","contents_url":"https://api.github.com/repos/san89/jads_kaggle/contents/{+path}","compare_url":"https://api.github.com/repos/san89/jads_kaggle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/san89/jads_kaggle/merges","archive_url":"https://api.github.com/repos/san89/jads_kaggle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/san89/jads_kaggle/downloads","issues_url":"https://api.github.com/repos/san89/jads_kaggle/issues{/number}","pulls_url":"https://api.github.com/repos/san89/jads_kaggle/pulls{/number}","milestones_url":"https://api.github.com/repos/san89/jads_kaggle/milestones{/number}","notifications_url":"https://api.github.com/repos/san89/jads_kaggle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/san89/jads_kaggle/labels{/name}","releases_url":"https://api.github.com/repos/san89/jads_kaggle/releases{/id}","deployments_url":"https://api.github.com/repos/san89/jads_kaggle/deployments","created_at":"2018-01-21T08:54:14Z","updated_at":"2018-09-23T07:45:58Z","pushed_at":"2019-03-29T13:33:50Z","git_url":"git://github.com/san89/jads_kaggle.git","ssh_url":"git@github.com:san89/jads_kaggle.git","clone_url":"https://github.com/san89/jads_kaggle.git","svn_url":"https://github.com/san89/jads_kaggle","homepage":null,"size":52982,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MLblog:master","ref":"master","sha":"1aaa354f54fa2c6e4a87ee05b769708c7ee85e25","user":{"login":"MLblog","id":30596935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTk2OTM1","avatar_url":"https://avatars1.githubusercontent.com/u/30596935?v=4","gravatar_id":"","url":"https://api.github.com/users/MLblog","html_url":"https://github.com/MLblog","followers_url":"https://api.github.com/users/MLblog/followers","following_url":"https://api.github.com/users/MLblog/following{/other_user}","gists_url":"https://api.github.com/users/MLblog/gists{/gist_id}","starred_url":"https://api.github.com/users/MLblog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MLblog/subscriptions","organizations_url":"https://api.github.com/users/MLblog/orgs","repos_url":"https://api.github.com/users/MLblog/repos","events_url":"https://api.github.com/users/MLblog/events{/privacy}","received_events_url":"https://api.github.com/users/MLblog/received_events","type":"Organization","site_admin":false},"repo":{"id":117817326,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4MTczMjY=","name":"jads_kaggle","full_name":"MLblog/jads_kaggle","private":false,"owner":{"login":"MLblog","id":30596935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTk2OTM1","avatar_url":"https://avatars1.githubusercontent.com/u/30596935?v=4","gravatar_id":"","url":"https://api.github.com/users/MLblog","html_url":"https://github.com/MLblog","followers_url":"https://api.github.com/users/MLblog/followers","following_url":"https://api.github.com/users/MLblog/following{/other_user}","gists_url":"https://api.github.com/users/MLblog/gists{/gist_id}","starred_url":"https://api.github.com/users/MLblog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MLblog/subscriptions","organizations_url":"https://api.github.com/users/MLblog/orgs","repos_url":"https://api.github.com/users/MLblog/repos","events_url":"https://api.github.com/users/MLblog/events{/privacy}","received_events_url":"https://api.github.com/users/MLblog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MLblog/jads_kaggle","description":"Contains our group's work in various kaggle competitions","fork":false,"url":"https://api.github.com/repos/MLblog/jads_kaggle","forks_url":"https://api.github.com/repos/MLblog/jads_kaggle/forks","keys_url":"https://api.github.com/repos/MLblog/jads_kaggle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MLblog/jads_kaggle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MLblog/jads_kaggle/teams","hooks_url":"https://api.github.com/repos/MLblog/jads_kaggle/hooks","issue_events_url":"https://api.github.com/repos/MLblog/jads_kaggle/issues/events{/number}","events_url":"https://api.github.com/repos/MLblog/jads_kaggle/events","assignees_url":"https://api.github.com/repos/MLblog/jads_kaggle/assignees{/user}","branches_url":"https://api.github.com/repos/MLblog/jads_kaggle/branches{/branch}","tags_url":"https://api.github.com/repos/MLblog/jads_kaggle/tags","blobs_url":"https://api.github.com/repos/MLblog/jads_kaggle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MLblog/jads_kaggle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MLblog/jads_kaggle/git/refs{/sha}","trees_url":"https://api.github.com/repos/MLblog/jads_kaggle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MLblog/jads_kaggle/statuses/{sha}","languages_url":"https://api.github.com/repos/MLblog/jads_kaggle/languages","stargazers_url":"https://api.github.com/repos/MLblog/jads_kaggle/stargazers","contributors_url":"https://api.github.com/repos/MLblog/jads_kaggle/contributors","subscribers_url":"https://api.github.com/repos/MLblog/jads_kaggle/subscribers","subscription_url":"https://api.github.com/repos/MLblog/jads_kaggle/subscription","commits_url":"https://api.github.com/repos/MLblog/jads_kaggle/commits{/sha}","git_commits_url":"https://api.github.com/repos/MLblog/jads_kaggle/git/commits{/sha}","comments_url":"https://api.github.com/repos/MLblog/jads_kaggle/comments{/number}","issue_comment_url":"https://api.github.com/repos/MLblog/jads_kaggle/issues/comments{/number}","contents_url":"https://api.github.com/repos/MLblog/jads_kaggle/contents/{+path}","compare_url":"https://api.github.com/repos/MLblog/jads_kaggle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MLblog/jads_kaggle/merges","archive_url":"https://api.github.com/repos/MLblog/jads_kaggle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MLblog/jads_kaggle/downloads","issues_url":"https://api.github.com/repos/MLblog/jads_kaggle/issues{/number}","pulls_url":"https://api.github.com/repos/MLblog/jads_kaggle/pulls{/number}","milestones_url":"https://api.github.com/repos/MLblog/jads_kaggle/milestones{/number}","notifications_url":"https://api.github.com/repos/MLblog/jads_kaggle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MLblog/jads_kaggle/labels{/name}","releases_url":"https://api.github.com/repos/MLblog/jads_kaggle/releases{/id}","deployments_url":"https://api.github.com/repos/MLblog/jads_kaggle/deployments","created_at":"2018-01-17T09:52:54Z","updated_at":"2019-03-31T09:16:54Z","pushed_at":"2019-03-31T09:16:53Z","git_url":"git://github.com/MLblog/jads_kaggle.git","ssh_url":"git@github.com:MLblog/jads_kaggle.git","clone_url":"https://github.com/MLblog/jads_kaggle.git","svn_url":"https://github.com/MLblog/jads_kaggle","homepage":null,"size":52928,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136"},"html":{"href":"https://github.com/MLblog/jads_kaggle/pull/136"},"issue":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/issues/136"},"comments":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/MLblog/jads_kaggle/statuses/2871818909a8ed1775e0e51336e763af4e90c848"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"joepvdbogaert"}}