{"action":"closed","number":648,"pull_request":{"url":"https://api.github.com/repos/getsentry/snuba/pulls/648","id":354925383,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0OTI1Mzgz","html_url":"https://github.com/getsentry/snuba/pull/648","diff_url":"https://github.com/getsentry/snuba/pull/648.diff","patch_url":"https://github.com/getsentry/snuba/pull/648.patch","issue_url":"https://api.github.com/repos/getsentry/snuba/issues/648","number":648,"state":"closed","locked":false,"title":"feat: Customize settings when running subscription queries","user":{"login":"wedamija","id":6288560,"node_id":"MDQ6VXNlcjYyODg1NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6288560?v=4","gravatar_id":"","url":"https://api.github.com/users/wedamija","html_url":"https://github.com/wedamija","followers_url":"https://api.github.com/users/wedamija/followers","following_url":"https://api.github.com/users/wedamija/following{/other_user}","gists_url":"https://api.github.com/users/wedamija/gists{/gist_id}","starred_url":"https://api.github.com/users/wedamija/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wedamija/subscriptions","organizations_url":"https://api.github.com/users/wedamija/orgs","repos_url":"https://api.github.com/users/wedamija/repos","events_url":"https://api.github.com/users/wedamija/events{/privacy}","received_events_url":"https://api.github.com/users/wedamija/received_events","type":"User","site_admin":false},"body":"This abstracts settings to all inherit from `RequestSettings`, renames the existing \r\n`RequestSettings` to `HTTPRequestSettings` and introduces `SubscriptionRequestSettings`,\r\nwhich overrides various settings to be hardcoded when running subscription queries. \r\nThis allows us to ignore all rate limits, and force turbo off and consistent on. Just returning \r\nno rate limits is enough to not perform any ratelimiting, and doesn't hit Redis to do so since \r\nwe never make any calls to `rate_limit`.\r\n","created_at":"2019-12-19T03:28:23Z","updated_at":"2020-01-08T00:11:15Z","closed_at":"2020-01-08T00:11:15Z","merged_at":"2020-01-08T00:11:15Z","merge_commit_sha":"a317201ae7e8617b584021fee98a99e611540688","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fpacifici","id":1626430,"node_id":"MDQ6VXNlcjE2MjY0MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1626430?v=4","gravatar_id":"","url":"https://api.github.com/users/fpacifici","html_url":"https://github.com/fpacifici","followers_url":"https://api.github.com/users/fpacifici/followers","following_url":"https://api.github.com/users/fpacifici/following{/other_user}","gists_url":"https://api.github.com/users/fpacifici/gists{/gist_id}","starred_url":"https://api.github.com/users/fpacifici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpacifici/subscriptions","organizations_url":"https://api.github.com/users/fpacifici/orgs","repos_url":"https://api.github.com/users/fpacifici/repos","events_url":"https://api.github.com/users/fpacifici/events{/privacy}","received_events_url":"https://api.github.com/users/fpacifici/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/snuba/pulls/648/commits","review_comments_url":"https://api.github.com/repos/getsentry/snuba/pulls/648/comments","review_comment_url":"https://api.github.com/repos/getsentry/snuba/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/snuba/issues/648/comments","statuses_url":"https://api.github.com/repos/getsentry/snuba/statuses/e4817b29a96ac00266caf7a7f7c954fd6d3d703f","head":{"label":"getsentry:danf/subscriptions_disable_ratelimiting","ref":"danf/subscriptions_disable_ratelimiting","sha":"e4817b29a96ac00266caf7a7f7c954fd6d3d703f","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":123494975,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0OTQ5NzU=","name":"snuba","full_name":"getsentry/snuba","private":false,"owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getsentry/snuba","description":"Search the seas for your lost treasure.","fork":false,"url":"https://api.github.com/repos/getsentry/snuba","forks_url":"https://api.github.com/repos/getsentry/snuba/forks","keys_url":"https://api.github.com/repos/getsentry/snuba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/snuba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/snuba/teams","hooks_url":"https://api.github.com/repos/getsentry/snuba/hooks","issue_events_url":"https://api.github.com/repos/getsentry/snuba/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/snuba/events","assignees_url":"https://api.github.com/repos/getsentry/snuba/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/snuba/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/snuba/tags","blobs_url":"https://api.github.com/repos/getsentry/snuba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/snuba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/snuba/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/snuba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/snuba/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/snuba/languages","stargazers_url":"https://api.github.com/repos/getsentry/snuba/stargazers","contributors_url":"https://api.github.com/repos/getsentry/snuba/contributors","subscribers_url":"https://api.github.com/repos/getsentry/snuba/subscribers","subscription_url":"https://api.github.com/repos/getsentry/snuba/subscription","commits_url":"https://api.github.com/repos/getsentry/snuba/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/snuba/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/snuba/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/snuba/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/snuba/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/snuba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/snuba/merges","archive_url":"https://api.github.com/repos/getsentry/snuba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/snuba/downloads","issues_url":"https://api.github.com/repos/getsentry/snuba/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/snuba/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/snuba/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/snuba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/snuba/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/snuba/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/snuba/deployments","created_at":"2018-03-01T21:34:00Z","updated_at":"2020-01-07T21:50:15Z","pushed_at":"2020-01-08T00:11:15Z","git_url":"git://github.com/getsentry/snuba.git","ssh_url":"git@github.com:getsentry/snuba.git","clone_url":"https://github.com/getsentry/snuba.git","svn_url":"https://github.com/getsentry/snuba","homepage":"","size":2543,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":25,"watchers":82,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"a3b7fc49b08805597114ead5e748ebdde94fb2eb","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":123494975,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0OTQ5NzU=","name":"snuba","full_name":"getsentry/snuba","private":false,"owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getsentry/snuba","description":"Search the seas for your lost treasure.","fork":false,"url":"https://api.github.com/repos/getsentry/snuba","forks_url":"https://api.github.com/repos/getsentry/snuba/forks","keys_url":"https://api.github.com/repos/getsentry/snuba/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/snuba/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/snuba/teams","hooks_url":"https://api.github.com/repos/getsentry/snuba/hooks","issue_events_url":"https://api.github.com/repos/getsentry/snuba/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/snuba/events","assignees_url":"https://api.github.com/repos/getsentry/snuba/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/snuba/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/snuba/tags","blobs_url":"https://api.github.com/repos/getsentry/snuba/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/snuba/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/snuba/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/snuba/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/snuba/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/snuba/languages","stargazers_url":"https://api.github.com/repos/getsentry/snuba/stargazers","contributors_url":"https://api.github.com/repos/getsentry/snuba/contributors","subscribers_url":"https://api.github.com/repos/getsentry/snuba/subscribers","subscription_url":"https://api.github.com/repos/getsentry/snuba/subscription","commits_url":"https://api.github.com/repos/getsentry/snuba/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/snuba/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/snuba/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/snuba/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/snuba/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/snuba/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/snuba/merges","archive_url":"https://api.github.com/repos/getsentry/snuba/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/snuba/downloads","issues_url":"https://api.github.com/repos/getsentry/snuba/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/snuba/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/snuba/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/snuba/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/snuba/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/snuba/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/snuba/deployments","created_at":"2018-03-01T21:34:00Z","updated_at":"2020-01-07T21:50:15Z","pushed_at":"2020-01-08T00:11:15Z","git_url":"git://github.com/getsentry/snuba.git","ssh_url":"git@github.com:getsentry/snuba.git","clone_url":"https://github.com/getsentry/snuba.git","svn_url":"https://github.com/getsentry/snuba","homepage":"","size":2543,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":25,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/snuba/pulls/648"},"html":{"href":"https://github.com/getsentry/snuba/pull/648"},"issue":{"href":"https://api.github.com/repos/getsentry/snuba/issues/648"},"comments":{"href":"https://api.github.com/repos/getsentry/snuba/issues/648/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/snuba/pulls/648/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/snuba/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/snuba/pulls/648/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/snuba/statuses/e4817b29a96ac00266caf7a7f7c954fd6d3d703f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wedamija","id":6288560,"node_id":"MDQ6VXNlcjYyODg1NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6288560?v=4","gravatar_id":"","url":"https://api.github.com/users/wedamija","html_url":"https://github.com/wedamija","followers_url":"https://api.github.com/users/wedamija/followers","following_url":"https://api.github.com/users/wedamija/following{/other_user}","gists_url":"https://api.github.com/users/wedamija/gists{/gist_id}","starred_url":"https://api.github.com/users/wedamija/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wedamija/subscriptions","organizations_url":"https://api.github.com/users/wedamija/orgs","repos_url":"https://api.github.com/users/wedamija/repos","events_url":"https://api.github.com/users/wedamija/events{/privacy}","received_events_url":"https://api.github.com/users/wedamija/received_events","type":"User","site_admin":false},"comments":0,"review_comments":12,"maintainer_can_modify":false,"commits":10,"additions":131,"deletions":64,"changed_files":15}}
{"actor":{"display_login":"wedamija"}}