{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/53295","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/53295/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/53295/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/53295/events","html_url":"https://github.com/saltstack/salt/pull/53295","id":449761095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMjIyODkw","number":53295,"title":"Recurse kwarg of state.directory state shall be a list or None","user":{"login":"DmitryKuzmenko","id":4807387,"node_id":"MDQ6VXNlcjQ4MDczODc=","avatar_url":"https://avatars0.githubusercontent.com/u/4807387?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKuzmenko","html_url":"https://github.com/DmitryKuzmenko","followers_url":"https://api.github.com/users/DmitryKuzmenko/followers","following_url":"https://api.github.com/users/DmitryKuzmenko/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKuzmenko/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKuzmenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKuzmenko/subscriptions","organizations_url":"https://api.github.com/users/DmitryKuzmenko/orgs","repos_url":"https://api.github.com/users/DmitryKuzmenko/repos","events_url":"https://api.github.com/users/DmitryKuzmenko/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKuzmenko/received_events","type":"User","site_admin":false},"labels":[{"id":1411793392,"node_id":"MDU6TGFiZWwxNDExNzkzMzky","url":"https://api.github.com/repos/saltstack/salt/labels/Reviewers%20Assigned","name":"Reviewers Assigned","color":"a459cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-05-29T11:50:23Z","updated_at":"2019-06-25T22:00:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/53295","html_url":"https://github.com/saltstack/salt/pull/53295","diff_url":"https://github.com/saltstack/salt/pull/53295.diff","patch_url":"https://github.com/saltstack/salt/pull/53295.patch"},"body":"### What does this PR do?\r\nFixes the test integration.states.test_file.FileTest.test_directory_broken_symlink\r\n\r\nThe `state.directory` function documentation says it accepts a list of strings but tests pass a set of strings that results to a test failure.\r\n\r\n### What issues does this PR fix or reference?\r\n#53283\r\n\r\n### Previous Behavior\r\n```\r\nTraceback (most recent call last):\r\n  File \"/tmp/kitchen/testing/tests/integration/states/test_file.py\", line 1271, in test_directory_broken_symlink\r\n    file_mode=644, dir_mode=755)\r\n  File \"/tmp/kitchen/testing/tests/support/case.py\", line 840, in run_state\r\n    ret = self.run_function('state.single', [function], **kwargs)\r\n  File \"/tmp/kitchen/testing/tests/support/case.py\", line 814, in run_function\r\n    kwarg=kwargs)\r\n  File \"/tmp/kitchen/testing/salt/client/__init__.py\", line 703, in cmd\r\n    **kwargs)\r\n  File \"/tmp/kitchen/testing/salt/client/__init__.py\", line 349, in run_job\r\n    raise SaltClientError(general_exception)\r\nSaltClientError: can not serialize 'set' object\r\n```\r\n\r\n### New Behavior\r\nTest passes.\r\n\r\n### Tests written?\r\nA test fix.\r\n\r\n### Commits signed with GPG?\r\nYes\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/505639161","html_url":"https://github.com/saltstack/salt/pull/53295#issuecomment-505639161","issue_url":"https://api.github.com/repos/saltstack/salt/issues/53295","id":505639161,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNTYzOTE2MQ==","user":{"login":"twangboy","id":9383935,"node_id":"MDQ6VXNlcjkzODM5MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/9383935?v=4","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"created_at":"2019-06-25T22:00:36Z","updated_at":"2019-06-25T22:00:36Z","author_association":"CONTRIBUTOR","body":"@DmitryKuzmenko I made that comment before I updated the branch. The lint test is passing now."}}
{"actor":{"display_login":"twangboy"}}