{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1745","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1745/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1745/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1745/events","html_url":"https://github.com/openjournals/joss-reviews/issues/1745","id":495125595,"node_id":"MDU6SXNzdWU0OTUxMjU1OTU=","number":1745,"title":"[REVIEW]: ndsplines: A Python Library for Tensor-Product B-Splines of Arbitrary Dimension","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"node_id":"MDU6TGFiZWwzMzA0NjUzMTM=","url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"sarats","id":5324834,"node_id":"MDQ6VXNlcjUzMjQ4MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5324834?v=4","gravatar_id":"","url":"https://api.github.com/users/sarats","html_url":"https://github.com/sarats","followers_url":"https://api.github.com/users/sarats/followers","following_url":"https://api.github.com/users/sarats/following{/other_user}","gists_url":"https://api.github.com/users/sarats/gists{/gist_id}","starred_url":"https://api.github.com/users/sarats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarats/subscriptions","organizations_url":"https://api.github.com/users/sarats/orgs","repos_url":"https://api.github.com/users/sarats/repos","events_url":"https://api.github.com/users/sarats/events{/privacy}","received_events_url":"https://api.github.com/users/sarats/received_events","type":"User","site_admin":false},"assignees":[{"login":"sarats","id":5324834,"node_id":"MDQ6VXNlcjUzMjQ4MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5324834?v=4","gravatar_id":"","url":"https://api.github.com/users/sarats","html_url":"https://github.com/sarats","followers_url":"https://api.github.com/users/sarats/followers","following_url":"https://api.github.com/users/sarats/following{/other_user}","gists_url":"https://api.github.com/users/sarats/gists{/gist_id}","starred_url":"https://api.github.com/users/sarats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarats/subscriptions","organizations_url":"https://api.github.com/users/sarats/orgs","repos_url":"https://api.github.com/users/sarats/repos","events_url":"https://api.github.com/users/sarats/events{/privacy}","received_events_url":"https://api.github.com/users/sarats/received_events","type":"User","site_admin":false},{"login":"mbobra","id":8431057,"node_id":"MDQ6VXNlcjg0MzEwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8431057?v=4","gravatar_id":"","url":"https://api.github.com/users/mbobra","html_url":"https://github.com/mbobra","followers_url":"https://api.github.com/users/mbobra/followers","following_url":"https://api.github.com/users/mbobra/following{/other_user}","gists_url":"https://api.github.com/users/mbobra/gists{/gist_id}","starred_url":"https://api.github.com/users/mbobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbobra/subscriptions","organizations_url":"https://api.github.com/users/mbobra/orgs","repos_url":"https://api.github.com/users/mbobra/repos","events_url":"https://api.github.com/users/mbobra/events{/privacy}","received_events_url":"https://api.github.com/users/mbobra/received_events","type":"User","site_admin":false},{"login":"amritagos","id":32496815,"node_id":"MDQ6VXNlcjMyNDk2ODE1","avatar_url":"https://avatars1.githubusercontent.com/u/32496815?v=4","gravatar_id":"","url":"https://api.github.com/users/amritagos","html_url":"https://github.com/amritagos","followers_url":"https://api.github.com/users/amritagos/followers","following_url":"https://api.github.com/users/amritagos/following{/other_user}","gists_url":"https://api.github.com/users/amritagos/gists{/gist_id}","starred_url":"https://api.github.com/users/amritagos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amritagos/subscriptions","organizations_url":"https://api.github.com/users/amritagos/orgs","repos_url":"https://api.github.com/users/amritagos/repos","events_url":"https://api.github.com/users/amritagos/events{/privacy}","received_events_url":"https://api.github.com/users/amritagos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":43,"created_at":"2019-09-18T10:08:43Z","updated_at":"2019-10-25T16:14:16Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @sixpearls (<a href=\"http://orcid.org/0000-0001-5602-1888\">Benjamin Margolis</a>)\n**Repository:** <a href=\"https://github.com/kb-press/ndsplines/\" target =\"_blank\">https://github.com/kb-press/ndsplines/</a>\n**Version:** 0.1.1\n**Editor:** @mbobra\n**Reviewer:** @amritagos, @sarats\n**Archive:** <a href=\"https://doi.org/10.5281/zenodo.3516465\" target=\"_blank\">10.5281/zenodo.3516465</a>\n\n## Status\n\n[![status](https://joss.theoj.org/papers/2105c9d4cfe04cc994d56f389c273111/status.svg)](https://joss.theoj.org/papers/2105c9d4cfe04cc994d56f389c273111)\n\nStatus badge code:\n\n```\nHTML: <a href=\"https://joss.theoj.org/papers/2105c9d4cfe04cc994d56f389c273111\"><img src=\"https://joss.theoj.org/papers/2105c9d4cfe04cc994d56f389c273111/status.svg\"></a>\nMarkdown: [![status](https://joss.theoj.org/papers/2105c9d4cfe04cc994d56f389c273111/status.svg)](https://joss.theoj.org/papers/2105c9d4cfe04cc994d56f389c273111)\n```\n**Reviewers and authors**:\n\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/kb-press/ndsplines/\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\n\n## Reviewer instructions & questions\n\n@amritagos & @sarats, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\n1. Make sure you're logged in to your GitHub account\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\n\nThe reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mbobra know.\n\n✨ **Please try and complete your review in the next two weeks** ✨ \n\n## Review checklist for @amritagos\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/kb-press/ndsplines/\">repository url</a>?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\n- [x] **Contribution and authorship:** Has the submitting author (@sixpearls) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the functionality of the software can be verified?\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [x] **Summary:** Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **State of the field:** Do the authors describe how this software compares to other commonly-used packages?\n- [x] **Quality of writing:** Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?\n- [x] **References:** Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper [citation syntax]( https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html#citation_syntax)?\n\n## Review checklist for @sarats\n### Conflict of interest\n\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\n\n### Code of Conduct\n\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\n\n### General checks\n\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/kb-press/ndsplines/\">repository url</a>?\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\n- [x] **Contribution and authorship:** Has the submitting author (@sixpearls) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\n\n### Functionality\n\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\n\n### Documentation\n\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the functionality of the software can be verified?\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\n\n### Software paper\n\n- [x] **Summary:** Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\n- [x] **State of the field:** Do the authors describe how this software compares to other commonly-used packages?\n- [x] **Quality of writing:** Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?\n- [x] **References:** Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper [citation syntax]( https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html#citation_syntax)?\n\n"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/546417056","html_url":"https://github.com/openjournals/joss-reviews/issues/1745#issuecomment-546417056","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/1745","id":546417056,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NjQxNzA1Ng==","user":{"login":"whedon","id":18508068,"node_id":"MDQ6VXNlcjE4NTA4MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"created_at":"2019-10-25T16:14:16Z","updated_at":"2019-10-25T16:14:16Z","author_association":"COLLABORATOR","body":"```Reference check summary:\n\nOK DOIs\n\n- 10.21105/joss.00396 is OK\n- 10.1109/mcse.2011.37 is OK\n- 10.1109/mcse.2010.118 is OK\n- 10.1002/zamm.19800600129 is OK\n- 10.2514/6.2019-2901 is OK\n- 10.2514/6.2002-4482 is OK\n\nMISSING DOIs\n\n- None\n\nINVALID DOIs\n\n- None\n```"}}
{"actor":{"display_login":"whedon"}}