{"push_id":4383067536,"size":10,"distinct_size":6,"ref":"refs/heads/th/polkit-root-only","head":"fd8c8ffe0d674beed69c910b7566cabdea8896ad","before":"a3a3287dd596e65d80c497ddc4f1cb454e9150c8","commits":[{"sha":"622eef4882028fa49a1ffd836ffdb6c633863197","author":{"name":"Beniamino Galvani","email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com"},"message":"cli: expose device D-Bus path\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1745574","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/622eef4882028fa49a1ffd836ffdb6c633863197"},{"sha":"53b74bc6148b8001b4dcec700d2fc65de41679aa","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"n-dhcp4/socket: use SO_REUSEADDR on UDP socket\n\nOtherwise, other applications cannot bind to port 0.0.0.0:68 at the same time.\nThis is for example what dhclient wants to do. So even when running\ndhclient on another, unrelated interface, it would fail to bind the UDP\nsocket and quit.\n\nNote that also systemd-networkd's DHCPv4 client sets this socket option.\nPresumably for the same reasons.\n\nSigned-off-by: Thomas Haller <thaller@redhat.com>\n\nhttps://github.com/nettools/n-dhcp4/pull/12","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/53b74bc6148b8001b4dcec700d2fc65de41679aa"},{"sha":"ce1f9e6eb9e4aa72e9954d58d20ca11634f6fd92","author":{"name":"Alexey Kodanev","email":"230f550b09df4d04cb9a8036b198a530acf758d3@oracle.com"},"message":"nm-manager: fix selinux label for dhclient lease file from initramfs\n\nWhen moving a lease file from initramfs directory to NetworkManager\nrun directory, SELinux label for that file retains tmpfs_t type.\n\nFix it by using sendfile() instead of rename(). That way, the\nlease file will have the default type: NetworkManager_var_run_t.\nSince we take ownership of the lease file, also drop it from the\nold location.\n\n* Before the patch:\nls -Z /var/run/NetworkManager/dhclient-*.lease\nsystem_u:object_r:tmpfs_t:s0 dhclient-13162c00-abfb-4e28-bbfb-170187ddd044-ens3.lease\n\n* After:\nls -Z /var/run/NetworkManager/dhclient-*.lease\nsystem_u:object_r:NetworkManager_var_run_t:s0 dhclient-f47d1908-67ae-49c6-bd5e-19a690d85526-ens3.lease\n\nFixes: f2fe6c03ee3f ('manager: don't treat the initramfs-configured DHCP connections as generated')\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/353","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/ce1f9e6eb9e4aa72e9954d58d20ca11634f6fd92"},{"sha":"0c6cd07ec81d1bd5584549bef72c30adc8c79c9f","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"nm-manager: remove lease file if copying dhclient lease fails\n\n- also use nm_auto_close and nm_close().","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/0c6cd07ec81d1bd5584549bef72c30adc8c79c9f"},{"sha":"c21c6bc0be2a4467402bc2d8718859dedb10b676","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build/meson: allow configuring default for main.auth-polkit setting\n\nWe always build PolicyKit support, because it merely depends on some\nD-Bus calls. However, there are two things to configure:\n\n - the default value for main.auth-polkit in NetworkManager.conf. This\n   is now called \"-Dconfig_auth_polkit_default=$VAL\".\n\n - whether to install the policy file. This is called \"-Dpolkit=$VAL\".\n\nThese settings are mostly independent, so add \"config_auth_polkit_default\" to\nmake the default explicitly configurable.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c21c6bc0be2a4467402bc2d8718859dedb10b676"},{"sha":"6d7446e52f5bfe379c2b1f54f9244b33fd236e32","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: add main.auth-polkit option \"root-only\"\n\nWe always build with PolicyKit support enabled, because it has no\nadditional dependencies, beside some D-Bus calls.\n\nHowever, in NetworkManager.conf the user could configure\n\"main.auth-polkit\" to disable PolicyKit. However, previously it would\nonly allow to disable PolicyKit while granting access to all users.\n\nI think it's useful to have an option that disables PolicyKit and grants\naccess only to root. I think we should not go too far in implementing\nour own authorization mechanisms beside PolicyKit (e.g. you cannot\ndisable PolicyKit and grant access based on group membership of the\nuser). However, disabling PolicyKit can be useful sometimes, and it's\nsimple to implement a \"root-only\" setup.\n\nNote one change is that when NetworkManager now runs without a D-Bus\nconnection (in initrd), it would deny all non-root requests. Previously\nit would grant access. I think there should be little difference in\npractice, because if we have no D-Bus we also don't have any requests to\nauthenticate.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/6d7446e52f5bfe379c2b1f54f9244b33fd236e32"},{"sha":"6998c5f129f70d676698de07667d6ee0334839ce","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"config: return GPtrArray with warnings from internal read_entire_config() function\n\nThe underlying GPtrArray that we use to construct the list of warnings\nis more useful than the strv array. For the internal function, don't\nlet it return the strv array but instead take (and fill) the warnings\nas GPtrArray. There is no difference in practice, because also\npreviously we would always create an empty GPtrArray.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/6998c5f129f70d676698de07667d6ee0334839ce"},{"sha":"8d20b9363b4461c7e86f2310a2fbfe88a09d5284","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"config: add nm_config_data_get_warnings() to get additional warnings about wrong configuration\n\nNo additional warnings are implemented yet.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/8d20b9363b4461c7e86f2310a2fbfe88a09d5284"},{"sha":"8f96d3cb0c40ef19ab6524a39eeae9b03da1b4f3","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"config: emit warning about invalid main.auth-polkit setting","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/8f96d3cb0c40ef19ab6524a39eeae9b03da1b4f3"},{"sha":"fd8c8ffe0d674beed69c910b7566cabdea8896ad","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"config: print config warnings during `NetworkManager --print-config`","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/fd8c8ffe0d674beed69c910b7566cabdea8896ad"}]}
{"actor":{"display_login":"lkundrak"}}