{"action":"opened","number":123,"pull_request":{"url":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/123","id":274598128,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NTk4MTI4","html_url":"https://github.com/OpenZeppelin/ethernaut/pull/123","diff_url":"https://github.com/OpenZeppelin/ethernaut/pull/123.diff","patch_url":"https://github.com/OpenZeppelin/ethernaut/pull/123.patch","issue_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues/123","number":123,"state":"open","locked":false,"title":"WIP - Update smart contracts to Solidity 0.5","user":{"login":"paulinablaszk","id":28393784,"node_id":"MDQ6VXNlcjI4MzkzNzg0","avatar_url":"https://avatars2.githubusercontent.com/u/28393784?v=4","gravatar_id":"","url":"https://api.github.com/users/paulinablaszk","html_url":"https://github.com/paulinablaszk","followers_url":"https://api.github.com/users/paulinablaszk/followers","following_url":"https://api.github.com/users/paulinablaszk/following{/other_user}","gists_url":"https://api.github.com/users/paulinablaszk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulinablaszk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulinablaszk/subscriptions","organizations_url":"https://api.github.com/users/paulinablaszk/orgs","repos_url":"https://api.github.com/users/paulinablaszk/repos","events_url":"https://api.github.com/users/paulinablaszk/events{/privacy}","received_events_url":"https://api.github.com/users/paulinablaszk/received_events","type":"User","site_admin":false},"body":"Issue #117 \r\n\r\nThe goal is to make all smart contracts to compile using Solidity 0.5.0. \r\nDue to a large number of changes, I add this as *Work in Progress*. \r\n\r\n### What have been done \r\n\r\n- [x] updated pragma statements \r\n- [x] added constructors\r\n- [x] changed `zeppelin-solidity` to `open zeppelin-solidity`\r\n- [x] changed returned statements  in `createInstance` in levels factories (form `instance` to `address(instance)”`\r\n- [x] added address payable \r\n- [x] added visibility and data location\r\n- [x] converted values of contract type to addresses before using an `address` member \r\n- [x] added empty string as `.call()` and `.delegatecall()` arguments \r\n- [x] changed handling of return statements of `.call()`, .`delegatecall()`\r\n- [x] changed disallowed `sha3` to `keccak256`\r\n- [x] changed `StandardToken` to `DetailedERC20`\r\n\r\nAt the moment the code level Fallback is commented (it won’t work in Solidity 0.5). \r\n\r\n### Next steps\r\n\r\n- [ ] make all the contracts compile corectly\r\n- [ ] update tests","created_at":"2019-04-30T05:01:20Z","updated_at":"2019-04-30T05:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/123/commits","review_comments_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/123/comments","review_comment_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues/123/comments","statuses_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/statuses/994e98cfe6408596ce83a6f0a207ce22671e6736","head":{"label":"paulinablaszk:solidity-0.5-#117","ref":"solidity-0.5-#117","sha":"994e98cfe6408596ce83a6f0a207ce22671e6736","user":{"login":"paulinablaszk","id":28393784,"node_id":"MDQ6VXNlcjI4MzkzNzg0","avatar_url":"https://avatars2.githubusercontent.com/u/28393784?v=4","gravatar_id":"","url":"https://api.github.com/users/paulinablaszk","html_url":"https://github.com/paulinablaszk","followers_url":"https://api.github.com/users/paulinablaszk/followers","following_url":"https://api.github.com/users/paulinablaszk/following{/other_user}","gists_url":"https://api.github.com/users/paulinablaszk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulinablaszk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulinablaszk/subscriptions","organizations_url":"https://api.github.com/users/paulinablaszk/orgs","repos_url":"https://api.github.com/users/paulinablaszk/repos","events_url":"https://api.github.com/users/paulinablaszk/events{/privacy}","received_events_url":"https://api.github.com/users/paulinablaszk/received_events","type":"User","site_admin":false},"repo":{"id":183354210,"node_id":"MDEwOlJlcG9zaXRvcnkxODMzNTQyMTA=","name":"ethernaut","full_name":"paulinablaszk/ethernaut","private":false,"owner":{"login":"paulinablaszk","id":28393784,"node_id":"MDQ6VXNlcjI4MzkzNzg0","avatar_url":"https://avatars2.githubusercontent.com/u/28393784?v=4","gravatar_id":"","url":"https://api.github.com/users/paulinablaszk","html_url":"https://github.com/paulinablaszk","followers_url":"https://api.github.com/users/paulinablaszk/followers","following_url":"https://api.github.com/users/paulinablaszk/following{/other_user}","gists_url":"https://api.github.com/users/paulinablaszk/gists{/gist_id}","starred_url":"https://api.github.com/users/paulinablaszk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulinablaszk/subscriptions","organizations_url":"https://api.github.com/users/paulinablaszk/orgs","repos_url":"https://api.github.com/users/paulinablaszk/repos","events_url":"https://api.github.com/users/paulinablaszk/events{/privacy}","received_events_url":"https://api.github.com/users/paulinablaszk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paulinablaszk/ethernaut","description":"Web3/Solidity based wargame","fork":true,"url":"https://api.github.com/repos/paulinablaszk/ethernaut","forks_url":"https://api.github.com/repos/paulinablaszk/ethernaut/forks","keys_url":"https://api.github.com/repos/paulinablaszk/ethernaut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulinablaszk/ethernaut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulinablaszk/ethernaut/teams","hooks_url":"https://api.github.com/repos/paulinablaszk/ethernaut/hooks","issue_events_url":"https://api.github.com/repos/paulinablaszk/ethernaut/issues/events{/number}","events_url":"https://api.github.com/repos/paulinablaszk/ethernaut/events","assignees_url":"https://api.github.com/repos/paulinablaszk/ethernaut/assignees{/user}","branches_url":"https://api.github.com/repos/paulinablaszk/ethernaut/branches{/branch}","tags_url":"https://api.github.com/repos/paulinablaszk/ethernaut/tags","blobs_url":"https://api.github.com/repos/paulinablaszk/ethernaut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulinablaszk/ethernaut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulinablaszk/ethernaut/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulinablaszk/ethernaut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulinablaszk/ethernaut/statuses/{sha}","languages_url":"https://api.github.com/repos/paulinablaszk/ethernaut/languages","stargazers_url":"https://api.github.com/repos/paulinablaszk/ethernaut/stargazers","contributors_url":"https://api.github.com/repos/paulinablaszk/ethernaut/contributors","subscribers_url":"https://api.github.com/repos/paulinablaszk/ethernaut/subscribers","subscription_url":"https://api.github.com/repos/paulinablaszk/ethernaut/subscription","commits_url":"https://api.github.com/repos/paulinablaszk/ethernaut/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulinablaszk/ethernaut/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulinablaszk/ethernaut/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulinablaszk/ethernaut/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulinablaszk/ethernaut/contents/{+path}","compare_url":"https://api.github.com/repos/paulinablaszk/ethernaut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulinablaszk/ethernaut/merges","archive_url":"https://api.github.com/repos/paulinablaszk/ethernaut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulinablaszk/ethernaut/downloads","issues_url":"https://api.github.com/repos/paulinablaszk/ethernaut/issues{/number}","pulls_url":"https://api.github.com/repos/paulinablaszk/ethernaut/pulls{/number}","milestones_url":"https://api.github.com/repos/paulinablaszk/ethernaut/milestones{/number}","notifications_url":"https://api.github.com/repos/paulinablaszk/ethernaut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulinablaszk/ethernaut/labels{/name}","releases_url":"https://api.github.com/repos/paulinablaszk/ethernaut/releases{/id}","deployments_url":"https://api.github.com/repos/paulinablaszk/ethernaut/deployments","created_at":"2019-04-25T04:08:08Z","updated_at":"2019-04-25T04:08:11Z","pushed_at":"2019-04-30T04:55:04Z","git_url":"git://github.com/paulinablaszk/ethernaut.git","ssh_url":"git@github.com:paulinablaszk/ethernaut.git","clone_url":"https://github.com/paulinablaszk/ethernaut.git","svn_url":"https://github.com/paulinablaszk/ethernaut","homepage":null,"size":4364,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenZeppelin:master","ref":"master","sha":"9f6848141e0383662693b49ec75dfade29f7346a","user":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"repo":{"id":111001784,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEwMDE3ODQ=","name":"ethernaut","full_name":"OpenZeppelin/ethernaut","private":false,"owner":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenZeppelin/ethernaut","description":"Web3/Solidity based wargame","fork":false,"url":"https://api.github.com/repos/OpenZeppelin/ethernaut","forks_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/forks","keys_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/teams","hooks_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/hooks","issue_events_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues/events{/number}","events_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/events","assignees_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/assignees{/user}","branches_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/branches{/branch}","tags_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/tags","blobs_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/languages","stargazers_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/stargazers","contributors_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/contributors","subscribers_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/subscribers","subscription_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/subscription","commits_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/contents/{+path}","compare_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/merges","archive_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/downloads","issues_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues{/number}","pulls_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/labels{/name}","releases_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/releases{/id}","deployments_url":"https://api.github.com/repos/OpenZeppelin/ethernaut/deployments","created_at":"2017-11-16T17:31:13Z","updated_at":"2019-04-29T04:21:05Z","pushed_at":"2019-03-04T06:49:08Z","git_url":"git://github.com/OpenZeppelin/ethernaut.git","ssh_url":"git@github.com:OpenZeppelin/ethernaut.git","clone_url":"https://github.com/OpenZeppelin/ethernaut.git","svn_url":"https://github.com/OpenZeppelin/ethernaut","homepage":null,"size":4364,"stargazers_count":301,"watchers_count":301,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":42,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":90,"open_issues":42,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/123"},"html":{"href":"https://github.com/OpenZeppelin/ethernaut/pull/123"},"issue":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues/123"},"comments":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/OpenZeppelin/ethernaut/statuses/994e98cfe6408596ce83a6f0a207ce22671e6736"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":553,"deletions":272,"changed_files":70}}
{"actor":{"display_login":"paulinablaszk"}}