{"action":"created","comment":{"url":"https://api.github.com/repos/istio/tools/pulls/comments/295859335","pull_request_review_id":252358652,"id":295859335,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTg1OTMzNQ==","diff_hunk":"@@ -0,0 +1,200 @@\n+apiVersion: extensions/v1beta1\n+kind: Deployment\n+metadata:","path":"perf/benchmark/linkerd/fortio.yaml","position":3,"original_position":3,"commit_id":"afbf403a9cde550b406d08438eb3699f18b897c1","original_commit_id":"afbf403a9cde550b406d08438eb3699f18b897c1","user":{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"This file seems identical to the one in benchmarks.\r\nCan we reuse it? If it is different I would like to know how?","created_at":"2019-06-20T15:18:35Z","updated_at":"2019-06-20T15:23:49Z","html_url":"https://github.com/istio/tools/pull/175#discussion_r295859335","pull_request_url":"https://api.github.com/repos/istio/tools/pulls/175","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/tools/pulls/comments/295859335"},"html":{"href":"https://github.com/istio/tools/pull/175#discussion_r295859335"},"pull_request":{"href":"https://api.github.com/repos/istio/tools/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/istio/tools/pulls/175","id":290258958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwMjU4OTU4","html_url":"https://github.com/istio/tools/pull/175","diff_url":"https://github.com/istio/tools/pull/175.diff","patch_url":"https://github.com/istio/tools/pull/175.patch","issue_url":"https://api.github.com/repos/istio/tools/issues/175","number":175,"state":"open","locked":false,"title":" Adds linkerd support, updates cpu/memory query","user":{"login":"askmeegs","id":3137106,"node_id":"MDQ6VXNlcjMxMzcxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3137106?v=4","gravatar_id":"","url":"https://api.github.com/users/askmeegs","html_url":"https://github.com/askmeegs","followers_url":"https://api.github.com/users/askmeegs/followers","following_url":"https://api.github.com/users/askmeegs/following{/other_user}","gists_url":"https://api.github.com/users/askmeegs/gists{/gist_id}","starred_url":"https://api.github.com/users/askmeegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askmeegs/subscriptions","organizations_url":"https://api.github.com/users/askmeegs/orgs","repos_url":"https://api.github.com/users/askmeegs/repos","events_url":"https://api.github.com/users/askmeegs/events{/privacy}","received_events_url":"https://api.github.com/users/askmeegs/received_events","type":"User","site_admin":false},"body":"1. `perf/benchmark/linkerd` provides instructions on how to do the Istio performance with linkerd instead.  (**Note** -- currently, using linkerd with the scripts only works for latency, and for `both` mode.) \r\n\r\n2. Updates `perf/benchmark/runner/prom.py` queries for CPU/Memory to avoid double-counting. (`job=kubernetes-cadvisor`). ","created_at":"2019-06-20T15:07:24Z","updated_at":"2019-06-20T15:23:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e304d8a38592beae799778d2201395abf271fb3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"howardjohn","id":623453,"node_id":"MDQ6VXNlcjYyMzQ1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/623453?v=4","gravatar_id":"","url":"https://api.github.com/users/howardjohn","html_url":"https://github.com/howardjohn","followers_url":"https://api.github.com/users/howardjohn/followers","following_url":"https://api.github.com/users/howardjohn/following{/other_user}","gists_url":"https://api.github.com/users/howardjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/howardjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardjohn/subscriptions","organizations_url":"https://api.github.com/users/howardjohn/orgs","repos_url":"https://api.github.com/users/howardjohn/repos","events_url":"https://api.github.com/users/howardjohn/events{/privacy}","received_events_url":"https://api.github.com/users/howardjohn/received_events","type":"User","site_admin":false},{"login":"utka","id":1302410,"node_id":"MDQ6VXNlcjEzMDI0MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1302410?v=4","gravatar_id":"","url":"https://api.github.com/users/utka","html_url":"https://github.com/utka","followers_url":"https://api.github.com/users/utka/followers","following_url":"https://api.github.com/users/utka/following{/other_user}","gists_url":"https://api.github.com/users/utka/gists{/gist_id}","starred_url":"https://api.github.com/users/utka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utka/subscriptions","organizations_url":"https://api.github.com/users/utka/orgs","repos_url":"https://api.github.com/users/utka/repos","events_url":"https://api.github.com/users/utka/events{/privacy}","received_events_url":"https://api.github.com/users/utka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/tools/pulls/175/commits","review_comments_url":"https://api.github.com/repos/istio/tools/pulls/175/comments","review_comment_url":"https://api.github.com/repos/istio/tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/tools/issues/175/comments","statuses_url":"https://api.github.com/repos/istio/tools/statuses/afbf403a9cde550b406d08438eb3699f18b897c1","head":{"label":"askmeegs:linkerd-install","ref":"linkerd-install","sha":"afbf403a9cde550b406d08438eb3699f18b897c1","user":{"login":"askmeegs","id":3137106,"node_id":"MDQ6VXNlcjMxMzcxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3137106?v=4","gravatar_id":"","url":"https://api.github.com/users/askmeegs","html_url":"https://github.com/askmeegs","followers_url":"https://api.github.com/users/askmeegs/followers","following_url":"https://api.github.com/users/askmeegs/following{/other_user}","gists_url":"https://api.github.com/users/askmeegs/gists{/gist_id}","starred_url":"https://api.github.com/users/askmeegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askmeegs/subscriptions","organizations_url":"https://api.github.com/users/askmeegs/orgs","repos_url":"https://api.github.com/users/askmeegs/repos","events_url":"https://api.github.com/users/askmeegs/events{/privacy}","received_events_url":"https://api.github.com/users/askmeegs/received_events","type":"User","site_admin":false},"repo":{"id":190407735,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA0MDc3MzU=","name":"tools","full_name":"askmeegs/tools","private":false,"owner":{"login":"askmeegs","id":3137106,"node_id":"MDQ6VXNlcjMxMzcxMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3137106?v=4","gravatar_id":"","url":"https://api.github.com/users/askmeegs","html_url":"https://github.com/askmeegs","followers_url":"https://api.github.com/users/askmeegs/followers","following_url":"https://api.github.com/users/askmeegs/following{/other_user}","gists_url":"https://api.github.com/users/askmeegs/gists{/gist_id}","starred_url":"https://api.github.com/users/askmeegs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askmeegs/subscriptions","organizations_url":"https://api.github.com/users/askmeegs/orgs","repos_url":"https://api.github.com/users/askmeegs/repos","events_url":"https://api.github.com/users/askmeegs/events{/privacy}","received_events_url":"https://api.github.com/users/askmeegs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/askmeegs/tools","description":"Tools shared by several Istio repositories","fork":true,"url":"https://api.github.com/repos/askmeegs/tools","forks_url":"https://api.github.com/repos/askmeegs/tools/forks","keys_url":"https://api.github.com/repos/askmeegs/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/askmeegs/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/askmeegs/tools/teams","hooks_url":"https://api.github.com/repos/askmeegs/tools/hooks","issue_events_url":"https://api.github.com/repos/askmeegs/tools/issues/events{/number}","events_url":"https://api.github.com/repos/askmeegs/tools/events","assignees_url":"https://api.github.com/repos/askmeegs/tools/assignees{/user}","branches_url":"https://api.github.com/repos/askmeegs/tools/branches{/branch}","tags_url":"https://api.github.com/repos/askmeegs/tools/tags","blobs_url":"https://api.github.com/repos/askmeegs/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/askmeegs/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/askmeegs/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/askmeegs/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/askmeegs/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/askmeegs/tools/languages","stargazers_url":"https://api.github.com/repos/askmeegs/tools/stargazers","contributors_url":"https://api.github.com/repos/askmeegs/tools/contributors","subscribers_url":"https://api.github.com/repos/askmeegs/tools/subscribers","subscription_url":"https://api.github.com/repos/askmeegs/tools/subscription","commits_url":"https://api.github.com/repos/askmeegs/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/askmeegs/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/askmeegs/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/askmeegs/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/askmeegs/tools/contents/{+path}","compare_url":"https://api.github.com/repos/askmeegs/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/askmeegs/tools/merges","archive_url":"https://api.github.com/repos/askmeegs/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/askmeegs/tools/downloads","issues_url":"https://api.github.com/repos/askmeegs/tools/issues{/number}","pulls_url":"https://api.github.com/repos/askmeegs/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/askmeegs/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/askmeegs/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/askmeegs/tools/labels{/name}","releases_url":"https://api.github.com/repos/askmeegs/tools/releases{/id}","deployments_url":"https://api.github.com/repos/askmeegs/tools/deployments","created_at":"2019-06-05T14:13:41Z","updated_at":"2019-06-05T14:13:44Z","pushed_at":"2019-06-20T15:04:16Z","git_url":"git://github.com/askmeegs/tools.git","ssh_url":"git@github.com:askmeegs/tools.git","clone_url":"https://github.com/askmeegs/tools.git","svn_url":"https://github.com/askmeegs/tools","homepage":null,"size":13905,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"da4c19db832d2cd58b8b13a02ba069c85406e147","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":118514618,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1MTQ2MTg=","name":"tools","full_name":"istio/tools","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/tools","description":"Tools shared by several Istio repositories","fork":false,"url":"https://api.github.com/repos/istio/tools","forks_url":"https://api.github.com/repos/istio/tools/forks","keys_url":"https://api.github.com/repos/istio/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/tools/teams","hooks_url":"https://api.github.com/repos/istio/tools/hooks","issue_events_url":"https://api.github.com/repos/istio/tools/issues/events{/number}","events_url":"https://api.github.com/repos/istio/tools/events","assignees_url":"https://api.github.com/repos/istio/tools/assignees{/user}","branches_url":"https://api.github.com/repos/istio/tools/branches{/branch}","tags_url":"https://api.github.com/repos/istio/tools/tags","blobs_url":"https://api.github.com/repos/istio/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/tools/languages","stargazers_url":"https://api.github.com/repos/istio/tools/stargazers","contributors_url":"https://api.github.com/repos/istio/tools/contributors","subscribers_url":"https://api.github.com/repos/istio/tools/subscribers","subscription_url":"https://api.github.com/repos/istio/tools/subscription","commits_url":"https://api.github.com/repos/istio/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/tools/contents/{+path}","compare_url":"https://api.github.com/repos/istio/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/tools/merges","archive_url":"https://api.github.com/repos/istio/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/tools/downloads","issues_url":"https://api.github.com/repos/istio/tools/issues{/number}","pulls_url":"https://api.github.com/repos/istio/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/tools/labels{/name}","releases_url":"https://api.github.com/repos/istio/tools/releases{/id}","deployments_url":"https://api.github.com/repos/istio/tools/deployments","created_at":"2018-01-22T21:00:21Z","updated_at":"2019-06-20T13:19:50Z","pushed_at":"2019-06-20T15:07:25Z","git_url":"git://github.com/istio/tools.git","ssh_url":"git@github.com:istio/tools.git","clone_url":"https://github.com/istio/tools.git","svn_url":"https://github.com/istio/tools","homepage":null,"size":13073,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":17,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/tools/pulls/175"},"html":{"href":"https://github.com/istio/tools/pull/175"},"issue":{"href":"https://api.github.com/repos/istio/tools/issues/175"},"comments":{"href":"https://api.github.com/repos/istio/tools/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/tools/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/tools/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/istio/tools/statuses/afbf403a9cde550b406d08438eb3699f18b897c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mandarjog"}}