{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/353820554","pull_request_review_id":326946338,"id":353820554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzgyMDU1NA==","diff_hunk":"@@ -619,12 +619,24 @@ const reducer = Container.makeReducer<Actions, Types.State>(initialState, {\n     const unreadMap = new Map<Types.ConversationIDKey, number>()\n     conversations.forEach(({convID, badgeCounts, unreadMessages}) => {\n       const key = Types.conversationIDToKey(convID)\n-      const count = badgeCounts[badgeKey] || 0\n+      // if its big we treat the count as 1 or 0 so additional chats don't redraw us","path":"shared/reducers/chat2.tsx","position":14,"original_position":14,"commit_id":"778db7a7465078a01ecdc70391b1fd95b3286629","original_commit_id":"778db7a7465078a01ecdc70391b1fd95b3286629","user":{"login":"buoyad","id":11968340,"node_id":"MDQ6VXNlcjExOTY4MzQw","avatar_url":"https://avatars1.githubusercontent.com/u/11968340?v=4","gravatar_id":"","url":"https://api.github.com/users/buoyad","html_url":"https://github.com/buoyad","followers_url":"https://api.github.com/users/buoyad/followers","following_url":"https://api.github.com/users/buoyad/following{/other_user}","gists_url":"https://api.github.com/users/buoyad/gists{/gist_id}","starred_url":"https://api.github.com/users/buoyad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buoyad/subscriptions","organizations_url":"https://api.github.com/users/buoyad/orgs","repos_url":"https://api.github.com/users/buoyad/repos","events_url":"https://api.github.com/users/buoyad/events{/privacy}","received_events_url":"https://api.github.com/users/buoyad/received_events","type":"User","site_admin":false},"body":"It excludes badges for the current chat. otherwise I think the badge flickers in as you're looking at the thread","created_at":"2019-12-04T15:44:50Z","updated_at":"2019-12-04T15:44:50Z","html_url":"https://github.com/keybase/client/pull/21342#discussion_r353820554","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/21342","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/353820554"},"html":{"href":"https://github.com/keybase/client/pull/21342#discussion_r353820554"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/21342"}},"in_reply_to_id":353812485},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/21342","id":347999692,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3OTk5Njky","html_url":"https://github.com/keybase/client/pull/21342","diff_url":"https://github.com/keybase/client/pull/21342.diff","patch_url":"https://github.com/keybase/client/pull/21342.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/21342","number":21342,"state":"open","locked":false,"title":"various redux thrash fixes","user":{"login":"chrisnojima","id":516435,"node_id":"MDQ6VXNlcjUxNjQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/516435?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisnojima","html_url":"https://github.com/chrisnojima","followers_url":"https://api.github.com/users/chrisnojima/followers","following_url":"https://api.github.com/users/chrisnojima/following{/other_user}","gists_url":"https://api.github.com/users/chrisnojima/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnojima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnojima/subscriptions","organizations_url":"https://api.github.com/users/chrisnojima/orgs","repos_url":"https://api.github.com/users/chrisnojima/repos","events_url":"https://api.github.com/users/chrisnojima/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnojima/received_events","type":"User","site_admin":false},"body":"Fixes some render thrashing issues when receiving a lot of chat messages\r\n- [x] input area rendered a lot all the time due to `suggestAllChannels` `suggestChannels`. Also some helpers in Constants were only used by this connector and had caching issue\r\n- [x] `syncProps` wasn't throttled at all so if you got hammered with messages your widget would try and update as fast as possible really slowing you down. Instead we only update the remotes every second max\r\n- [x] reduce some unnecessary sends to menubar remote\r\n- [x] treat chats `badgeMap` for big teams badge count as `1` if there's any badge. This doesn't affect the nav count but when we bold a channel we only need to know if its 0/1 so additional typing won't thrash the inbox\r\n- [x] tab-bar thrashed on unused `_fullnames` param\r\n- [x] pulled Tabs out into their own component so only the changed tabs need to render instead of all of them\r\n- [x] unneeded sort of keys in `mapEqual` helper","created_at":"2019-12-02T21:59:11Z","updated_at":"2019-12-04T15:44:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d56607332277ec094cf54d1ce58466118aad4d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/21342/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/21342/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/21342/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/778db7a7465078a01ecdc70391b1fd95b3286629","head":{"label":"keybase:nojima/HOTPOT-1397-typing-indicator","ref":"nojima/HOTPOT-1397-typing-indicator","sha":"778db7a7465078a01ecdc70391b1fd95b3286629","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2019-12-04T15:36:20Z","pushed_at":"2019-12-04T15:36:17Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":536837,"stargazers_count":6220,"watchers_count":6220,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":778,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3306,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":778,"open_issues":3306,"watchers":6220,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"48eefab0ac5c6f5434181de2260f9713e45e2052","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA5OTE4MQ==","name":"client","full_name":"keybase/client","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2019-12-04T15:36:20Z","pushed_at":"2019-12-04T15:36:17Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":536837,"stargazers_count":6220,"watchers_count":6220,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":778,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3306,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":778,"open_issues":3306,"watchers":6220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/21342"},"html":{"href":"https://github.com/keybase/client/pull/21342"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/21342"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/21342/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/21342/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/21342/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/778db7a7465078a01ecdc70391b1fd95b3286629"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"buoyad"}}