{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/comments/286913709","pull_request_review_id":241164165,"id":286913709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjkxMzcwOQ==","diff_hunk":"@@ -2,256 +2,208 @@\n // This software may be modified and distributed under the terms\n // of the Apache-2.0 license. See the LICENSE file for details.\n \n-import FileSaver from 'file-saver';\n+import { Keyring } from '@polkadot/ui-keyring';\n import { mnemonicGenerate, mnemonicToSeed, naclKeypairFromSeed } from '@polkadot/util-crypto';\n-import React from 'react';\n-import { RouteComponentProps } from 'react-router-dom';\n import { AppContext } from '@substrate/ui-common';\n import { AddressSummary, ErrorText, FadedText, Input, Margin, MnemonicSegment, NavButton, Stacked, StyledLinkButton, SubHeader, WrapperDiv, WithSpaceAround } from '@substrate/ui-components';\n+import FileSaver from 'file-saver';\n+import { Either, left, right } from 'fp-ts/lib/Either';\n+import { none, Option, some } from 'fp-ts/lib/Option';\n+import React, { useContext, useState } from 'react';\n+import { RouteComponentProps } from 'react-router-dom';\n \n interface Props extends RouteComponentProps { }","path":"packages/light-apps/src/AddAccount/Create.tsx","position":17,"original_position":17,"commit_id":"69b0ebec742aa683626021e74e26cf990e8af0b6","original_commit_id":"69b0ebec742aa683626021e74e26cf990e8af0b6","user":{"login":"yjkimjunior","id":10432070,"node_id":"MDQ6VXNlcjEwNDMyMDcw","avatar_url":"https://avatars1.githubusercontent.com/u/10432070?v=4","gravatar_id":"","url":"https://api.github.com/users/yjkimjunior","html_url":"https://github.com/yjkimjunior","followers_url":"https://api.github.com/users/yjkimjunior/followers","following_url":"https://api.github.com/users/yjkimjunior/following{/other_user}","gists_url":"https://api.github.com/users/yjkimjunior/gists{/gist_id}","starred_url":"https://api.github.com/users/yjkimjunior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjkimjunior/subscriptions","organizations_url":"https://api.github.com/users/yjkimjunior/orgs","repos_url":"https://api.github.com/users/yjkimjunior/repos","events_url":"https://api.github.com/users/yjkimjunior/events{/privacy}","received_events_url":"https://api.github.com/users/yjkimjunior/received_events","type":"User","site_admin":false},"body":"nit: interface defintions together and type definitions together, each with a line space between them.","created_at":"2019-05-23T12:19:37Z","updated_at":"2019-05-23T12:19:37Z","html_url":"https://github.com/paritytech/substrate-light-ui/pull/355#discussion_r286913709","pull_request_url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/comments/286913709"},"html":{"href":"https://github.com/paritytech/substrate-light-ui/pull/355#discussion_r286913709"},"pull_request":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355","id":280800913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwODAwOTEz","html_url":"https://github.com/paritytech/substrate-light-ui/pull/355","diff_url":"https://github.com/paritytech/substrate-light-ui/pull/355.diff","patch_url":"https://github.com/paritytech/substrate-light-ui/pull/355.patch","issue_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/355","number":355,"state":"open","locked":false,"title":"refactor: Use function components, remove React class","user":{"login":"amaurymartiny","id":1293565,"node_id":"MDQ6VXNlcjEyOTM1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1293565?v=4","gravatar_id":"","url":"https://api.github.com/users/amaurymartiny","html_url":"https://github.com/amaurymartiny","followers_url":"https://api.github.com/users/amaurymartiny/followers","following_url":"https://api.github.com/users/amaurymartiny/following{/other_user}","gists_url":"https://api.github.com/users/amaurymartiny/gists{/gist_id}","starred_url":"https://api.github.com/users/amaurymartiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaurymartiny/subscriptions","organizations_url":"https://api.github.com/users/amaurymartiny/orgs","repos_url":"https://api.github.com/users/amaurymartiny/repos","events_url":"https://api.github.com/users/amaurymartiny/events{/privacy}","received_events_url":"https://api.github.com/users/amaurymartiny/received_events","type":"User","site_admin":false},"body":"I didn't do the ones in Onboarding. We could maybe do them with #67 ","created_at":"2019-05-21T14:07:55Z","updated_at":"2019-05-23T12:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a46b96704d29b0f9693b8cb8fdd041c8b280d275","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1225425638,"node_id":"MDU6TGFiZWwxMjI1NDI1NjM4","url":"https://api.github.com/repos/paritytech/substrate-light-ui/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355/commits","review_comments_url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355/comments","review_comment_url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/355/comments","statuses_url":"https://api.github.com/repos/paritytech/substrate-light-ui/statuses/69b0ebec742aa683626021e74e26cf990e8af0b6","head":{"label":"paritytech:am-remove-class","ref":"am-remove-class","sha":"69b0ebec742aa683626021e74e26cf990e8af0b6","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":159400782,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0MDA3ODI=","name":"substrate-light-ui","full_name":"paritytech/substrate-light-ui","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/substrate-light-ui","description":"Beginner-friendly user interface optimized for the Substrate light client","fork":false,"url":"https://api.github.com/repos/paritytech/substrate-light-ui","forks_url":"https://api.github.com/repos/paritytech/substrate-light-ui/forks","keys_url":"https://api.github.com/repos/paritytech/substrate-light-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/substrate-light-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/substrate-light-ui/teams","hooks_url":"https://api.github.com/repos/paritytech/substrate-light-ui/hooks","issue_events_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/substrate-light-ui/events","assignees_url":"https://api.github.com/repos/paritytech/substrate-light-ui/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/substrate-light-ui/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/substrate-light-ui/tags","blobs_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/substrate-light-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/substrate-light-ui/languages","stargazers_url":"https://api.github.com/repos/paritytech/substrate-light-ui/stargazers","contributors_url":"https://api.github.com/repos/paritytech/substrate-light-ui/contributors","subscribers_url":"https://api.github.com/repos/paritytech/substrate-light-ui/subscribers","subscription_url":"https://api.github.com/repos/paritytech/substrate-light-ui/subscription","commits_url":"https://api.github.com/repos/paritytech/substrate-light-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/substrate-light-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/substrate-light-ui/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/substrate-light-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/substrate-light-ui/merges","archive_url":"https://api.github.com/repos/paritytech/substrate-light-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/substrate-light-ui/downloads","issues_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/substrate-light-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/substrate-light-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/substrate-light-ui/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/substrate-light-ui/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/substrate-light-ui/deployments","created_at":"2018-11-27T21:20:32Z","updated_at":"2019-05-22T09:54:18Z","pushed_at":"2019-05-23T12:19:27Z","git_url":"git://github.com/paritytech/substrate-light-ui.git","ssh_url":"git@github.com:paritytech/substrate-light-ui.git","clone_url":"https://github.com/paritytech/substrate-light-ui.git","svn_url":"https://github.com/paritytech/substrate-light-ui","homepage":"","size":12965,"stargazers_count":17,"watchers_count":17,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":43,"watchers":17,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"94a7c7de79df3a059ae3f3a48f510ddd8472aeb7","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":159400782,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0MDA3ODI=","name":"substrate-light-ui","full_name":"paritytech/substrate-light-ui","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/substrate-light-ui","description":"Beginner-friendly user interface optimized for the Substrate light client","fork":false,"url":"https://api.github.com/repos/paritytech/substrate-light-ui","forks_url":"https://api.github.com/repos/paritytech/substrate-light-ui/forks","keys_url":"https://api.github.com/repos/paritytech/substrate-light-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/substrate-light-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/substrate-light-ui/teams","hooks_url":"https://api.github.com/repos/paritytech/substrate-light-ui/hooks","issue_events_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/substrate-light-ui/events","assignees_url":"https://api.github.com/repos/paritytech/substrate-light-ui/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/substrate-light-ui/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/substrate-light-ui/tags","blobs_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/substrate-light-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/substrate-light-ui/languages","stargazers_url":"https://api.github.com/repos/paritytech/substrate-light-ui/stargazers","contributors_url":"https://api.github.com/repos/paritytech/substrate-light-ui/contributors","subscribers_url":"https://api.github.com/repos/paritytech/substrate-light-ui/subscribers","subscription_url":"https://api.github.com/repos/paritytech/substrate-light-ui/subscription","commits_url":"https://api.github.com/repos/paritytech/substrate-light-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/substrate-light-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/substrate-light-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/substrate-light-ui/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/substrate-light-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/substrate-light-ui/merges","archive_url":"https://api.github.com/repos/paritytech/substrate-light-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/substrate-light-ui/downloads","issues_url":"https://api.github.com/repos/paritytech/substrate-light-ui/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/substrate-light-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/substrate-light-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/substrate-light-ui/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/substrate-light-ui/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/substrate-light-ui/deployments","created_at":"2018-11-27T21:20:32Z","updated_at":"2019-05-22T09:54:18Z","pushed_at":"2019-05-23T12:19:27Z","git_url":"git://github.com/paritytech/substrate-light-ui.git","ssh_url":"git@github.com:paritytech/substrate-light-ui.git","clone_url":"https://github.com/paritytech/substrate-light-ui.git","svn_url":"https://github.com/paritytech/substrate-light-ui","homepage":"","size":12965,"stargazers_count":17,"watchers_count":17,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":43,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355"},"html":{"href":"https://github.com/paritytech/substrate-light-ui/pull/355"},"issue":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/355"},"comments":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/substrate-light-ui/statuses/69b0ebec742aa683626021e74e26cf990e8af0b6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yjkimjunior"}}