{"action":"created","comment":{"url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/comments/307199788","pull_request_review_id":266504165,"id":307199788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzE5OTc4OA==","diff_hunk":"@@ -26,6 +26,10 @@ nightly = []\n \n [dependencies]\n atomig-macro = { version = \"0.1.0\", path = \"atomig-macro\", optional = true }\n+serde = {version = \"1\", default-features = false, optional = true}\n+\n+[dev-dependencies]\n+bincode = {version = \"1\"}","path":"Cargo.toml","position":7,"original_position":7,"commit_id":"b9ad6182239c3ca829ab4eb298c612ea983e9a8b","original_commit_id":"b9ad6182239c3ca829ab4eb298c612ea983e9a8b","user":{"login":"LukasKalbertodt","id":7419664,"node_id":"MDQ6VXNlcjc0MTk2NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7419664?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasKalbertodt","html_url":"https://github.com/LukasKalbertodt","followers_url":"https://api.github.com/users/LukasKalbertodt/followers","following_url":"https://api.github.com/users/LukasKalbertodt/following{/other_user}","gists_url":"https://api.github.com/users/LukasKalbertodt/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasKalbertodt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasKalbertodt/subscriptions","organizations_url":"https://api.github.com/users/LukasKalbertodt/orgs","repos_url":"https://api.github.com/users/LukasKalbertodt/repos","events_url":"https://api.github.com/users/LukasKalbertodt/events{/privacy}","received_events_url":"https://api.github.com/users/LukasKalbertodt/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nbincode = { version = \"1\" }\r\n```","created_at":"2019-07-25T09:25:40Z","updated_at":"2019-07-25T09:43:01Z","html_url":"https://github.com/LukasKalbertodt/atomig/pull/2#discussion_r307199788","pull_request_url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/comments/307199788"},"html":{"href":"https://github.com/LukasKalbertodt/atomig/pull/2#discussion_r307199788"},"pull_request":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2","id":300933908,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwOTMzOTA4","html_url":"https://github.com/LukasKalbertodt/atomig/pull/2","diff_url":"https://github.com/LukasKalbertodt/atomig/pull/2.diff","patch_url":"https://github.com/LukasKalbertodt/atomig/pull/2.patch","issue_url":"https://api.github.com/repos/LukasKalbertodt/atomig/issues/2","number":2,"state":"open","locked":false,"title":"implement serde as a feature","user":{"login":"Roguelazer","id":263424,"node_id":"MDQ6VXNlcjI2MzQyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/263424?v=4","gravatar_id":"","url":"https://api.github.com/users/Roguelazer","html_url":"https://github.com/Roguelazer","followers_url":"https://api.github.com/users/Roguelazer/followers","following_url":"https://api.github.com/users/Roguelazer/following{/other_user}","gists_url":"https://api.github.com/users/Roguelazer/gists{/gist_id}","starred_url":"https://api.github.com/users/Roguelazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roguelazer/subscriptions","organizations_url":"https://api.github.com/users/Roguelazer/orgs","repos_url":"https://api.github.com/users/Roguelazer/repos","events_url":"https://api.github.com/users/Roguelazer/events{/privacy}","received_events_url":"https://api.github.com/users/Roguelazer/received_events","type":"User","site_admin":false},"body":"I just implemented this upstream in Serde 1.0.95 and it seems like it would be useful here.\r\n\r\n`bincode` is just for round-tripping in the tests as a fairly simple serializer.","created_at":"2019-07-24T23:52:33Z","updated_at":"2019-07-25T09:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0781fd5164fdacfc11ab9e94edd98697690cf35a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2/commits","review_comments_url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2/comments","review_comment_url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LukasKalbertodt/atomig/issues/2/comments","statuses_url":"https://api.github.com/repos/LukasKalbertodt/atomig/statuses/b9ad6182239c3ca829ab4eb298c612ea983e9a8b","head":{"label":"Roguelazer:serde","ref":"serde","sha":"b9ad6182239c3ca829ab4eb298c612ea983e9a8b","user":{"login":"Roguelazer","id":263424,"node_id":"MDQ6VXNlcjI2MzQyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/263424?v=4","gravatar_id":"","url":"https://api.github.com/users/Roguelazer","html_url":"https://github.com/Roguelazer","followers_url":"https://api.github.com/users/Roguelazer/followers","following_url":"https://api.github.com/users/Roguelazer/following{/other_user}","gists_url":"https://api.github.com/users/Roguelazer/gists{/gist_id}","starred_url":"https://api.github.com/users/Roguelazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roguelazer/subscriptions","organizations_url":"https://api.github.com/users/Roguelazer/orgs","repos_url":"https://api.github.com/users/Roguelazer/repos","events_url":"https://api.github.com/users/Roguelazer/events{/privacy}","received_events_url":"https://api.github.com/users/Roguelazer/received_events","type":"User","site_admin":false},"repo":{"id":198724051,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg3MjQwNTE=","name":"atomig","full_name":"Roguelazer/atomig","private":false,"owner":{"login":"Roguelazer","id":263424,"node_id":"MDQ6VXNlcjI2MzQyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/263424?v=4","gravatar_id":"","url":"https://api.github.com/users/Roguelazer","html_url":"https://github.com/Roguelazer","followers_url":"https://api.github.com/users/Roguelazer/followers","following_url":"https://api.github.com/users/Roguelazer/following{/other_user}","gists_url":"https://api.github.com/users/Roguelazer/gists{/gist_id}","starred_url":"https://api.github.com/users/Roguelazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roguelazer/subscriptions","organizations_url":"https://api.github.com/users/Roguelazer/orgs","repos_url":"https://api.github.com/users/Roguelazer/repos","events_url":"https://api.github.com/users/Roguelazer/events{/privacy}","received_events_url":"https://api.github.com/users/Roguelazer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Roguelazer/atomig","description":"Generic and convenient `std` atomics via `Atomic<T>`","fork":true,"url":"https://api.github.com/repos/Roguelazer/atomig","forks_url":"https://api.github.com/repos/Roguelazer/atomig/forks","keys_url":"https://api.github.com/repos/Roguelazer/atomig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Roguelazer/atomig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Roguelazer/atomig/teams","hooks_url":"https://api.github.com/repos/Roguelazer/atomig/hooks","issue_events_url":"https://api.github.com/repos/Roguelazer/atomig/issues/events{/number}","events_url":"https://api.github.com/repos/Roguelazer/atomig/events","assignees_url":"https://api.github.com/repos/Roguelazer/atomig/assignees{/user}","branches_url":"https://api.github.com/repos/Roguelazer/atomig/branches{/branch}","tags_url":"https://api.github.com/repos/Roguelazer/atomig/tags","blobs_url":"https://api.github.com/repos/Roguelazer/atomig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Roguelazer/atomig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Roguelazer/atomig/git/refs{/sha}","trees_url":"https://api.github.com/repos/Roguelazer/atomig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Roguelazer/atomig/statuses/{sha}","languages_url":"https://api.github.com/repos/Roguelazer/atomig/languages","stargazers_url":"https://api.github.com/repos/Roguelazer/atomig/stargazers","contributors_url":"https://api.github.com/repos/Roguelazer/atomig/contributors","subscribers_url":"https://api.github.com/repos/Roguelazer/atomig/subscribers","subscription_url":"https://api.github.com/repos/Roguelazer/atomig/subscription","commits_url":"https://api.github.com/repos/Roguelazer/atomig/commits{/sha}","git_commits_url":"https://api.github.com/repos/Roguelazer/atomig/git/commits{/sha}","comments_url":"https://api.github.com/repos/Roguelazer/atomig/comments{/number}","issue_comment_url":"https://api.github.com/repos/Roguelazer/atomig/issues/comments{/number}","contents_url":"https://api.github.com/repos/Roguelazer/atomig/contents/{+path}","compare_url":"https://api.github.com/repos/Roguelazer/atomig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Roguelazer/atomig/merges","archive_url":"https://api.github.com/repos/Roguelazer/atomig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Roguelazer/atomig/downloads","issues_url":"https://api.github.com/repos/Roguelazer/atomig/issues{/number}","pulls_url":"https://api.github.com/repos/Roguelazer/atomig/pulls{/number}","milestones_url":"https://api.github.com/repos/Roguelazer/atomig/milestones{/number}","notifications_url":"https://api.github.com/repos/Roguelazer/atomig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Roguelazer/atomig/labels{/name}","releases_url":"https://api.github.com/repos/Roguelazer/atomig/releases{/id}","deployments_url":"https://api.github.com/repos/Roguelazer/atomig/deployments","created_at":"2019-07-24T23:46:56Z","updated_at":"2019-07-24T23:47:00Z","pushed_at":"2019-07-24T23:50:55Z","git_url":"git://github.com/Roguelazer/atomig.git","ssh_url":"git@github.com:Roguelazer/atomig.git","clone_url":"https://github.com/Roguelazer/atomig.git","svn_url":"https://github.com/Roguelazer/atomig","homepage":"https://docs.rs/atomig","size":80,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LukasKalbertodt:master","ref":"master","sha":"8d55be98fa34f6883c784c3ec4f8bf7927e4d570","user":{"login":"LukasKalbertodt","id":7419664,"node_id":"MDQ6VXNlcjc0MTk2NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7419664?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasKalbertodt","html_url":"https://github.com/LukasKalbertodt","followers_url":"https://api.github.com/users/LukasKalbertodt/followers","following_url":"https://api.github.com/users/LukasKalbertodt/following{/other_user}","gists_url":"https://api.github.com/users/LukasKalbertodt/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasKalbertodt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasKalbertodt/subscriptions","organizations_url":"https://api.github.com/users/LukasKalbertodt/orgs","repos_url":"https://api.github.com/users/LukasKalbertodt/repos","events_url":"https://api.github.com/users/LukasKalbertodt/events{/privacy}","received_events_url":"https://api.github.com/users/LukasKalbertodt/received_events","type":"User","site_admin":false},"repo":{"id":197915350,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5MTUzNTA=","name":"atomig","full_name":"LukasKalbertodt/atomig","private":false,"owner":{"login":"LukasKalbertodt","id":7419664,"node_id":"MDQ6VXNlcjc0MTk2NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7419664?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasKalbertodt","html_url":"https://github.com/LukasKalbertodt","followers_url":"https://api.github.com/users/LukasKalbertodt/followers","following_url":"https://api.github.com/users/LukasKalbertodt/following{/other_user}","gists_url":"https://api.github.com/users/LukasKalbertodt/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasKalbertodt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasKalbertodt/subscriptions","organizations_url":"https://api.github.com/users/LukasKalbertodt/orgs","repos_url":"https://api.github.com/users/LukasKalbertodt/repos","events_url":"https://api.github.com/users/LukasKalbertodt/events{/privacy}","received_events_url":"https://api.github.com/users/LukasKalbertodt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LukasKalbertodt/atomig","description":"Generic and convenient `std` atomics via `Atomic<T>`","fork":false,"url":"https://api.github.com/repos/LukasKalbertodt/atomig","forks_url":"https://api.github.com/repos/LukasKalbertodt/atomig/forks","keys_url":"https://api.github.com/repos/LukasKalbertodt/atomig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LukasKalbertodt/atomig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LukasKalbertodt/atomig/teams","hooks_url":"https://api.github.com/repos/LukasKalbertodt/atomig/hooks","issue_events_url":"https://api.github.com/repos/LukasKalbertodt/atomig/issues/events{/number}","events_url":"https://api.github.com/repos/LukasKalbertodt/atomig/events","assignees_url":"https://api.github.com/repos/LukasKalbertodt/atomig/assignees{/user}","branches_url":"https://api.github.com/repos/LukasKalbertodt/atomig/branches{/branch}","tags_url":"https://api.github.com/repos/LukasKalbertodt/atomig/tags","blobs_url":"https://api.github.com/repos/LukasKalbertodt/atomig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LukasKalbertodt/atomig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LukasKalbertodt/atomig/git/refs{/sha}","trees_url":"https://api.github.com/repos/LukasKalbertodt/atomig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LukasKalbertodt/atomig/statuses/{sha}","languages_url":"https://api.github.com/repos/LukasKalbertodt/atomig/languages","stargazers_url":"https://api.github.com/repos/LukasKalbertodt/atomig/stargazers","contributors_url":"https://api.github.com/repos/LukasKalbertodt/atomig/contributors","subscribers_url":"https://api.github.com/repos/LukasKalbertodt/atomig/subscribers","subscription_url":"https://api.github.com/repos/LukasKalbertodt/atomig/subscription","commits_url":"https://api.github.com/repos/LukasKalbertodt/atomig/commits{/sha}","git_commits_url":"https://api.github.com/repos/LukasKalbertodt/atomig/git/commits{/sha}","comments_url":"https://api.github.com/repos/LukasKalbertodt/atomig/comments{/number}","issue_comment_url":"https://api.github.com/repos/LukasKalbertodt/atomig/issues/comments{/number}","contents_url":"https://api.github.com/repos/LukasKalbertodt/atomig/contents/{+path}","compare_url":"https://api.github.com/repos/LukasKalbertodt/atomig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LukasKalbertodt/atomig/merges","archive_url":"https://api.github.com/repos/LukasKalbertodt/atomig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LukasKalbertodt/atomig/downloads","issues_url":"https://api.github.com/repos/LukasKalbertodt/atomig/issues{/number}","pulls_url":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls{/number}","milestones_url":"https://api.github.com/repos/LukasKalbertodt/atomig/milestones{/number}","notifications_url":"https://api.github.com/repos/LukasKalbertodt/atomig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LukasKalbertodt/atomig/labels{/name}","releases_url":"https://api.github.com/repos/LukasKalbertodt/atomig/releases{/id}","deployments_url":"https://api.github.com/repos/LukasKalbertodt/atomig/deployments","created_at":"2019-07-20T10:30:07Z","updated_at":"2019-07-24T21:27:28Z","pushed_at":"2019-07-24T23:52:34Z","git_url":"git://github.com/LukasKalbertodt/atomig.git","ssh_url":"git@github.com:LukasKalbertodt/atomig.git","clone_url":"https://github.com/LukasKalbertodt/atomig.git","svn_url":"https://github.com/LukasKalbertodt/atomig","homepage":"https://docs.rs/atomig","size":77,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2"},"html":{"href":"https://github.com/LukasKalbertodt/atomig/pull/2"},"issue":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/issues/2"},"comments":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/LukasKalbertodt/atomig/statuses/b9ad6182239c3ca829ab4eb298c612ea983e9a8b"}},"author_association":"NONE"}}
{"actor":{"display_login":"LukasKalbertodt"}}