{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34017","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34017/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34017/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34017/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34017","id":493547563,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NTA3Njky","number":34017,"title":"Martial Arts Rebalance for Medieval Swordsmanship","user":{"login":"Hymore246","id":11396600,"node_id":"MDQ6VXNlcjExMzk2NjAw","avatar_url":"https://avatars2.githubusercontent.com/u/11396600?v=4","gravatar_id":"","url":"https://api.github.com/users/Hymore246","html_url":"https://github.com/Hymore246","followers_url":"https://api.github.com/users/Hymore246/followers","following_url":"https://api.github.com/users/Hymore246/following{/other_user}","gists_url":"https://api.github.com/users/Hymore246/gists{/gist_id}","starred_url":"https://api.github.com/users/Hymore246/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hymore246/subscriptions","organizations_url":"https://api.github.com/users/Hymore246/orgs","repos_url":"https://api.github.com/users/Hymore246/repos","events_url":"https://api.github.com/users/Hymore246/events{/privacy}","received_events_url":"https://api.github.com/users/Hymore246/received_events","type":"User","site_admin":false},"labels":[{"id":41067655,"node_id":"MDU6TGFiZWw0MTA2NzY1NQ==","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Game:%20Balance","name":"Game: Balance","color":"5319e7","default":false},{"id":939519802,"node_id":"MDU6TGFiZWw5Mzk1MTk4MDI=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Melee","name":"Melee","color":"e237e8","default":false},{"id":235869031,"node_id":"MDU6TGFiZWwyMzU4NjkwMzE=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[JSON]","name":"[JSON]","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-09-13T23:04:14Z","updated_at":"2019-09-15T11:45:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/34017","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34017","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34017.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34017.patch"},"body":"<!--\r\n### How to use\r\nLeave the headings unless they don't apply to your PR, replace commented out text (surrounded with <!–– and ––>) with text describing your PR.\r\n-->\r\n\r\n#### Summary\r\n<!--\r\nA one-line description of your change that will be extracted and added to the [project changelog](https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/changelog.txt).\r\n\r\nThe format is (ignore the square brackets): ```SUMMARY: [Category] \"[description]\"```\r\n\r\nThe categories to choose from are:\r\n\r\n* Features\r\n* Content\r\n* Interface\r\n* Mods\r\n* Balance\r\n* Bugfixes\r\n* Performance\r\n* Infrastructure\r\n* Build\r\n* I18N\r\n\r\nExample: ```SUMMARY: Content \"Adds new mutation category 'Mouse'\"```\r\n\r\nSee the [Changelog Guidelines](https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/CHANGELOG_GUIDELINES.md) for explanations of the categories.\r\n-->\r\n```SUMMARY: Balance \"Martial arts rebalance for Medival Swordsmanship\"```\r\n\r\n#### Purpose of change\r\n<!--\r\nIf there's an existing issue describing the problem this PR addresses or the feature it adds, please link it like: ```#1234```\r\nIf it *fully* resolves an issue, link it like: ```Fixes #1234```\r\nEven if the issue describes the problem, please provide a few-sentence summary here.\r\nExample: ```Fixes #1234 - XL mutants cannot wear arm/leg splints due to missing OVERSIZE flag.```\r\nIf there is no related issue, please describe the issue you are addressing, including how to trigger a bug if this is a bugfix.\r\nDon't put the backticks around the `#` and issue or pull request number to allow the GitHub automatically reference to it.\r\n-->\r\nPartially implements #32422\r\nUpdate for the martial art: Medival Swordsmanship\r\n\r\n#### Describe the solution\r\n<!--\r\nHow does the feature work, or how does this fix a bug?\r\nThe easier you make your solution to understand, the faster it can get merged.\r\n-->\r\n`The art of the longsword and sword & shield, preceding the later development of fencing.  Designed for combat both unarmored and in armor, it includes grappling as well as defensive and offensive sword techniques.`\r\n\r\n_Current Buffs, Techniques, and Special Abilities_\r\n\r\nName | Level Available | Type | Effect \r\n--- | --- | --- | --- \r\nPerfect Defense|Unarmed 0|OnAttack Buff|+2 Dodges for 3 turns\r\nDisplacement|Melee 2|OnDodge Buff|Lasts 2 turns\r\ngrab|Melee 3|Melee Tech|Down duration: 1\r\ngrab break|Melee 3|Melee Tech|Grab Break\r\ndisplace and counter|Melee 4|Melee Tech|Requires \"Displacement\", 75% move cost, +10% cut damage\r\nsweeping strike|Melee 5|Melee Crit Tech|Down duration: 2\r\nvicious strike|Melee 6|Melee Crit Tech|+50% Bash, Cut, and Stab damage, stun duration: 1\r\nDeathblow|Melee 6|Melee Crit Tech|200% move cost, +200% Bash damage, 0% Cut and Stab damage, stun duration: 2\r\n\r\n**Weapons:** 2-by-Sword, Arming Sword*, Crude Sword, Estoc*, Flammenschwert*, Jian*, Longsword*, Nord, Zweihander*\r\n*Includes all varations\r\n\r\nMedieval Swordsmanship isn't much to look at. It's moveset is a mixed bag, probably because most of the power comes from the weapons it uses\r\n\r\n_Problems and issues_\r\n- **Perfect Defense is too strong.** \r\nOnAttack buffs are the easiest buffs to activate and keep active. Giving +2 Dodge attempts to a style that isn't focused on defense is usually a bad idea.\r\n\r\n- **displace and counter isn't balanced very well.** \r\nThis attack isn't bad by itself but the problem comes from it's frequency. You can dodge a lot in combat and as a result you might be getting the attack endlessly and the damage can rack up much faster than was intented. Alternatively, if you score a critical hit, the attack doesn't happen at all and the \"displace\" buff is wasted.\r\n\r\n\r\n- **grab shouldn't have cut or stab damage.**\r\nThe \"grab\" technique is described as a pommel strike and hitting with the hilt of your weapon and not the blade shouldn't do any cut or stabbing damage.\r\n\r\n\r\n_Rebalance Goal_\r\nMedival Swordsmanship is tricky to balance due to the sheer power of the weapons the style uses. Directly adding power to the weapons without any restraint will just make the style overpowered but removing that from the equation also removes most of the things a style can provide a martial art.\r\n\r\nThe rebalance will reduce, but not completely, remove the damage boosts from the style. All techniques that have a damage boost will require either some sort of setup or will give up other damage for the boost. The rest of style will focus on providing stun and downed effects with a few defensive options. This may not seem like much but remember, this is the style that lets you use flaming two-handed sword to kill things.\r\n\r\n_New Buffs, Techniques, and Special Abilities_\r\n\r\nName | Level Available | Type | Effect \r\n--- | --- | --- | --- \r\nSwordsman's Stance|Unarmed 0|OnHit Buff|+1 Dodge attempts, blocked damage reduced by 50% of Strength.\r\nDeflection|Melee 1|OnDodge Buff|Enables \"Sweeping Strike\" and \"Deathblow\". Lasts 1 turn\r\nSweeping Strike|Melee 1|Melee Crit Tech|Requires \"Deflection\" buff, Down duration: 2\r\nGrab Break|Melee 3|Melee Tech|Grab Break\r\nDeathblow|Melee 4|Melee Crit Tech|Requires \"Deflection\" buff, 150% move cost, +200% Bash damage, 0% Cut and Stab damage, stun duration: 2\r\nPommel Strike|Melee 4|Melee Dodge Counter|0% Cut and Stab damage, Down duration: 1\r\nManslayer|Melee 5|OnCrit Buff|Enables \"Vicious Strike\". Lasts 1 turn\r\nVicious Strike|Melee 5|Melee Crit Tech|Requires \"Manslayer\" buff, +50% damage, stun duration: 1\r\n\r\n**Weapons:** 2-by-Sword, Arming Sword*, Broadsword*, Crude Sword, Estoc*, Flammenschwert*,  Longsword*, Nord, Zweihander*\r\n*Includes all varations\r\n\r\n\r\n_Important Changes_\r\n- **Pommel Strike is now a Dodge Counter.**\r\nPommel Strike shouldn't have been doing full damage and it's hard to image the player going out of their way to use it instead of just swinging their weapon normally. However, as a dodge counter, it provides a bit of control with very little damage dealt.\r\n\r\n- **Sweeping Strike and Deathblow now requires the Deflection buff.**\r\nSweeping Strike and Deathblow are control techniques that require you to block before triggering them. You also need to crit as well so it isn't too out of line to allow them to stay.\r\n\r\n- **Vicious Strike now requires Manslayer buff.**\r\nVicious Strike is one of the main draws to Medieval Swordsmanship and while it the largest damage increase, I didn't want to remove it since it is be a nice goal to aim for while using the style and everyone likes to see big damage. So instead, you must now crit twice in a row to trigger Vicious Strike. This rewards players that have high Melee skills.\r\n\r\n- **Manslayer and Deflection do nothing but enable new techniques.**\r\nAs I mentioned above, I am very hesitant to add extra power to the style. If the style needs a buff, these will be the first things I change.\r\n\r\n- **Additional style weapons.**\r\n**Broadsword* - This weapon existed in the Middle Ages and is the right size to be included in the style.\r\n\r\n- **Removed style weapons.**\r\n**Jian** - You could argue that it shouldn't be included due to it not being a part of Europe but I'm removing it for a simpler reason: it's a short sword and is too small to be used with the style.\r\n\r\n\r\n_Advantages_\r\n- Provides the player with a decent way control enemies while fighting.\r\n- With the right weapon in hand, Vicious Strike can do 100+ damage.\r\n- Works well against small groups.\r\n\r\n_Disadvantages_\r\n- Weapons make the style. If you can't find a good weapon, the style isn't going to help you very much.\r\n- All the techniques need some sort of set up to trigger.\r\n- Pommel Strike and Deathblow do a lot less damage than a normal attack would.\r\n\r\n\r\n#### Describe alternatives you've considered\r\n<!--\r\nA clear and concise description of any alternative solutions or features you've considered.\r\n-->\r\n_If the style is too strong..._\r\n- Reduce the damage of Vicious Strike from 50% to 25%.\r\n\r\n_If the style is too weak..._\r\n- Add blocked damage reduction to Deflection.\r\n- Add an Accuracy bonus to Manslayer.\r\n- Add an OnHit Buff that grants +1 Dodge attempts.\r\n\r\n#### Additional context\r\n<!--\r\nAdd any other context (such as mock-ups, proof of concepts or screenshots) about the feature or bugfix here.\r\n-->\r\n_References:_\r\n[Historical European martial arts wikipedia page](https://en.wikipedia.org/wiki/Historical_European_martial_arts)\r\n[Unterhau](http://www.learn-sword-fighting.com/en/unterhau.html)\r\n[Mordhau](https://en.wikipedia.org/wiki/Mordhau_(weaponry))\r\n[Zornhau Ort](http://www.learn-sword-fighting.com/en/zornhau-ort.html)\r\n[Knightly Sword](https://en.wikipedia.org/wiki/Knightly_sword)"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/531558802","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34017#issuecomment-531558802","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34017","id":531558802,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMTU1ODgwMg==","user":{"login":"tenmillimaster","id":7764202,"node_id":"MDQ6VXNlcjc3NjQyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/7764202?v=4","gravatar_id":"","url":"https://api.github.com/users/tenmillimaster","html_url":"https://github.com/tenmillimaster","followers_url":"https://api.github.com/users/tenmillimaster/followers","following_url":"https://api.github.com/users/tenmillimaster/following{/other_user}","gists_url":"https://api.github.com/users/tenmillimaster/gists{/gist_id}","starred_url":"https://api.github.com/users/tenmillimaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenmillimaster/subscriptions","organizations_url":"https://api.github.com/users/tenmillimaster/orgs","repos_url":"https://api.github.com/users/tenmillimaster/repos","events_url":"https://api.github.com/users/tenmillimaster/events{/privacy}","received_events_url":"https://api.github.com/users/tenmillimaster/received_events","type":"User","site_admin":false},"created_at":"2019-09-15T11:45:55Z","updated_at":"2019-09-15T11:45:55Z","author_association":"MEMBER","body":"Is there a reason why we're not just calling this HEMA? It seems a far more appropriate name."}}
{"actor":{"display_login":"tenmillimaster"}}