{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/268810856","pull_request_review_id":218534770,"id":268810856,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODgxMDg1Ng==","diff_hunk":"@@ -245,6 +245,13 @@ void TreeLifeUpdater<ForCodeGen>::UpdateLifeVar(GenTree* tree)\n                 }\n #endif // DEBUG\n             }\n+\n+#ifdef USING_VARIABLE_LIVE_RANGE\n+            // For each of the LclVarDsc that are reporting change, variable or fields\n+            VariableLiveKeeper* varLiveKeeper = compiler->getVariableLiveKeeper();\n+            varLiveKeeper->siStartOrCloseVariableLiveRanges(&varDeltaSet, isBorn, isDying);","path":"src/jit/treelifeupdater.cpp","position":8,"original_position":8,"commit_id":"08fad8ae7db8ca9f885969dd0cf49a8005a47ffd","original_commit_id":"2c7d1e2c6bd09d4bb969415f4faa24c5b5dce350","user":{"login":"BrianBohe","id":9440186,"node_id":"MDQ6VXNlcjk0NDAxODY=","avatar_url":"https://avatars1.githubusercontent.com/u/9440186?v=4","gravatar_id":"","url":"https://api.github.com/users/BrianBohe","html_url":"https://github.com/BrianBohe","followers_url":"https://api.github.com/users/BrianBohe/followers","following_url":"https://api.github.com/users/BrianBohe/following{/other_user}","gists_url":"https://api.github.com/users/BrianBohe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianBohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianBohe/subscriptions","organizations_url":"https://api.github.com/users/BrianBohe/orgs","repos_url":"https://api.github.com/users/BrianBohe/repos","events_url":"https://api.github.com/users/BrianBohe/events{/privacy}","received_events_url":"https://api.github.com/users/BrianBohe/received_events","type":"User","site_admin":false},"body":"I agree that it's verbose. We can do this:\r\n> ```\r\n> compiler->siStartOrCloseVariableLiveRanges(&varDeltaSet, isBorn, isDying);\r\n> ```\r\nBut the intention of having just a getter was to avoid adding more methods to Compiler.\r\n\r\nI preffer to do the other way:\r\n> ```\r\n> compiler->getVariableLiveKeeper()->siStartOrCloseVariableLiveRanges(&varDeltaSet, isBorn, isDying);\r\n> ```\r\n\r\nand adding the flag inside the function\r\n> Also, maybe the `#ifdef USING_VARIABLE_LIVE_RANGE` could be put in the function itself, to avoid putting it at every call site?\r\n\r\nThe problem with that is if someone adds/moves a call to this method and the flag \"USING_VARIABLE_LIVE_RANGE\" is disable, it will compile without errors. Is that the expected behavior on changes?","created_at":"2019-03-25T19:18:35Z","updated_at":"2019-03-25T19:18:35Z","html_url":"https://github.com/dotnet/coreclr/pull/23373#discussion_r268810856","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/23373","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/268810856"},"html":{"href":"https://github.com/dotnet/coreclr/pull/23373#discussion_r268810856"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/23373"}},"in_reply_to_id":268371097},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/23373","id":263074433,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMDc0NDMz","html_url":"https://github.com/dotnet/coreclr/pull/23373","diff_url":"https://github.com/dotnet/coreclr/pull/23373.diff","patch_url":"https://github.com/dotnet/coreclr/pull/23373.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/23373","number":23373,"state":"open","locked":false,"title":"A new way of tracking variables","user":{"login":"BrianBohe","id":9440186,"node_id":"MDQ6VXNlcjk0NDAxODY=","avatar_url":"https://avatars1.githubusercontent.com/u/9440186?v=4","gravatar_id":"","url":"https://api.github.com/users/BrianBohe","html_url":"https://github.com/BrianBohe","followers_url":"https://api.github.com/users/BrianBohe/followers","following_url":"https://api.github.com/users/BrianBohe/following{/other_user}","gists_url":"https://api.github.com/users/BrianBohe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianBohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianBohe/subscriptions","organizations_url":"https://api.github.com/users/BrianBohe/orgs","repos_url":"https://api.github.com/users/BrianBohe/repos","events_url":"https://api.github.com/users/BrianBohe/events{/privacy}","received_events_url":"https://api.github.com/users/BrianBohe/received_events","type":"User","site_admin":false},"body":"This is a rephrasing of [other PR](https://github.com/dotnet/coreclr/pull/22770) that is quite huge.\r\n\r\nI have splitted that main PR in different PRs:\r\n\r\n1. [Adding comments](https://github.com/dotnet/coreclr/pull/23327): **not merged** and not included here.\r\n2. [Moving gen stack level to code gen interface](https://github.com/dotnet/coreclr/pull/23328): **merged**.\r\n3. [Adding const to functions that don't change or shouldn't change state](https://github.com/dotnet/coreclr/pull/23329): **merged**\r\n4. [Adding a flag to able/disable scope info](https://github.com/dotnet/coreclr/pull/23298) **merged**\r\n\r\nI am reporting arguments, special arguments and IL local variables. The integration has been checked from VS IDE.\r\n\r\nI am writing a file for the documentation of the repository about reporting variable home.","created_at":"2019-03-20T23:34:15Z","updated_at":"2019-03-25T19:18:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab73659122ce5782e8d9c30e9f6f7c6eb331e75c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/23373/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/23373/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/23373/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/08fad8ae7db8ca9f885969dd0cf49a8005a47ffd","head":{"label":"BrianBohe:brbohe/optimized_debugging_rephrase","ref":"brbohe/optimized_debugging_rephrase","sha":"08fad8ae7db8ca9f885969dd0cf49a8005a47ffd","user":{"login":"BrianBohe","id":9440186,"node_id":"MDQ6VXNlcjk0NDAxODY=","avatar_url":"https://avatars1.githubusercontent.com/u/9440186?v=4","gravatar_id":"","url":"https://api.github.com/users/BrianBohe","html_url":"https://github.com/BrianBohe","followers_url":"https://api.github.com/users/BrianBohe/followers","following_url":"https://api.github.com/users/BrianBohe/following{/other_user}","gists_url":"https://api.github.com/users/BrianBohe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianBohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianBohe/subscriptions","organizations_url":"https://api.github.com/users/BrianBohe/orgs","repos_url":"https://api.github.com/users/BrianBohe/repos","events_url":"https://api.github.com/users/BrianBohe/events{/privacy}","received_events_url":"https://api.github.com/users/BrianBohe/received_events","type":"User","site_admin":false},"repo":{"id":165293767,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyOTM3Njc=","name":"coreclr","full_name":"BrianBohe/coreclr","private":false,"owner":{"login":"BrianBohe","id":9440186,"node_id":"MDQ6VXNlcjk0NDAxODY=","avatar_url":"https://avatars1.githubusercontent.com/u/9440186?v=4","gravatar_id":"","url":"https://api.github.com/users/BrianBohe","html_url":"https://github.com/BrianBohe","followers_url":"https://api.github.com/users/BrianBohe/followers","following_url":"https://api.github.com/users/BrianBohe/following{/other_user}","gists_url":"https://api.github.com/users/BrianBohe/gists{/gist_id}","starred_url":"https://api.github.com/users/BrianBohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrianBohe/subscriptions","organizations_url":"https://api.github.com/users/BrianBohe/orgs","repos_url":"https://api.github.com/users/BrianBohe/repos","events_url":"https://api.github.com/users/BrianBohe/events{/privacy}","received_events_url":"https://api.github.com/users/BrianBohe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BrianBohe/coreclr","description":"CoreCLR is the runtime for .NET Core. It includes the garbage collector, JIT compiler, primitive data types and low-level classes.","fork":true,"url":"https://api.github.com/repos/BrianBohe/coreclr","forks_url":"https://api.github.com/repos/BrianBohe/coreclr/forks","keys_url":"https://api.github.com/repos/BrianBohe/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrianBohe/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrianBohe/coreclr/teams","hooks_url":"https://api.github.com/repos/BrianBohe/coreclr/hooks","issue_events_url":"https://api.github.com/repos/BrianBohe/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/BrianBohe/coreclr/events","assignees_url":"https://api.github.com/repos/BrianBohe/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/BrianBohe/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/BrianBohe/coreclr/tags","blobs_url":"https://api.github.com/repos/BrianBohe/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrianBohe/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrianBohe/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrianBohe/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrianBohe/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/BrianBohe/coreclr/languages","stargazers_url":"https://api.github.com/repos/BrianBohe/coreclr/stargazers","contributors_url":"https://api.github.com/repos/BrianBohe/coreclr/contributors","subscribers_url":"https://api.github.com/repos/BrianBohe/coreclr/subscribers","subscription_url":"https://api.github.com/repos/BrianBohe/coreclr/subscription","commits_url":"https://api.github.com/repos/BrianBohe/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrianBohe/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrianBohe/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrianBohe/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrianBohe/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/BrianBohe/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrianBohe/coreclr/merges","archive_url":"https://api.github.com/repos/BrianBohe/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrianBohe/coreclr/downloads","issues_url":"https://api.github.com/repos/BrianBohe/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/BrianBohe/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/BrianBohe/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/BrianBohe/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrianBohe/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/BrianBohe/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/BrianBohe/coreclr/deployments","created_at":"2019-01-11T18:53:02Z","updated_at":"2019-03-23T01:27:51Z","pushed_at":"2019-03-23T01:32:32Z","git_url":"git://github.com/BrianBohe/coreclr.git","ssh_url":"git@github.com:BrianBohe/coreclr.git","clone_url":"https://github.com/BrianBohe/coreclr.git","svn_url":"https://github.com/BrianBohe/coreclr","homepage":"https://docs.microsoft.com/dotnet/core/","size":317099,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"29dc90c13a5d091c21e21e4ba5d3c4bcd3eab18d","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"CoreCLR is the runtime for .NET Core. It includes the garbage collector, JIT compiler, primitive data types and low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2019-03-25T16:57:34Z","pushed_at":"2019-03-25T19:14:57Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/core/","size":276625,"stargazers_count":11173,"watchers_count":11173,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2651,"mirror_url":null,"archived":false,"open_issues_count":2068,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2651,"open_issues":2068,"watchers":11173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/23373"},"html":{"href":"https://github.com/dotnet/coreclr/pull/23373"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/23373"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/23373/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/23373/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/23373/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/08fad8ae7db8ca9f885969dd0cf49a8005a47ffd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BrianBohe"}}