{"action":"created","comment":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/295862015","pull_request_review_id":252361762,"id":295862015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTg2MjAxNQ==","diff_hunk":"@@ -80,7 +80,8 @@ foam.CLASS({\n         this.stack.push({\n           class: 'foam.comics.v2.DAOCreateView',\n           data: this.data.of.create({}, this),\n-          config$: this.config$\n+          config$: this.config$,\n+          of: this.data.of","path":"src/foam/comics/v2/DAOBrowseControllerView.js","position":6,"original_position":6,"commit_id":"89fb25d57c422ff541d06fe9d33fee3046ea86bc","original_commit_id":"89fb25d57c422ff541d06fe9d33fee3046ea86bc","user":{"login":"mcarcaso","id":8106568,"node_id":"MDQ6VXNlcjgxMDY1Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/8106568?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarcaso","html_url":"https://github.com/mcarcaso","followers_url":"https://api.github.com/users/mcarcaso/followers","following_url":"https://api.github.com/users/mcarcaso/following{/other_user}","gists_url":"https://api.github.com/users/mcarcaso/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarcaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarcaso/subscriptions","organizations_url":"https://api.github.com/users/mcarcaso/orgs","repos_url":"https://api.github.com/users/mcarcaso/repos","events_url":"https://api.github.com/users/mcarcaso/events{/privacy}","received_events_url":"https://api.github.com/users/mcarcaso/received_events","type":"User","site_admin":false},"body":"Do you need both `of` and `data`? It feels redundant to have both. If the DAOCreateView knows the `of`, it could just create the `data` for you. And the `of` can be found from the `config` so you may only need the config and nothing more. What do you think?\r\n","created_at":"2019-06-20T15:24:15Z","updated_at":"2019-06-20T15:33:33Z","html_url":"https://github.com/foam-framework/foam2/pull/2303#discussion_r295862015","pull_request_url":"https://api.github.com/repos/foam-framework/foam2/pulls/2303","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/295862015"},"html":{"href":"https://github.com/foam-framework/foam2/pull/2303#discussion_r295862015"},"pull_request":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2303"}}},"pull_request":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/2303","id":289358247,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MzU4MjQ3","html_url":"https://github.com/foam-framework/foam2/pull/2303","diff_url":"https://github.com/foam-framework/foam2/pull/2303.diff","patch_url":"https://github.com/foam-framework/foam2/pull/2303.patch","issue_url":"https://api.github.com/repos/foam-framework/foam2/issues/2303","number":2303,"state":"open","locked":false,"title":"DAOContCRUDWiringAndRefactors","user":{"login":"tharmaman","id":26717171,"node_id":"MDQ6VXNlcjI2NzE3MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/26717171?v=4","gravatar_id":"","url":"https://api.github.com/users/tharmaman","html_url":"https://github.com/tharmaman","followers_url":"https://api.github.com/users/tharmaman/followers","following_url":"https://api.github.com/users/tharmaman/following{/other_user}","gists_url":"https://api.github.com/users/tharmaman/gists{/gist_id}","starred_url":"https://api.github.com/users/tharmaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharmaman/subscriptions","organizations_url":"https://api.github.com/users/tharmaman/orgs","repos_url":"https://api.github.com/users/tharmaman/repos","events_url":"https://api.github.com/users/tharmaman/events{/privacy}","received_events_url":"https://api.github.com/users/tharmaman/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-18T16:22:00Z","updated_at":"2019-06-20T15:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"079bf089fed8c57f35de5a68228d70069609652a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1019586488,"node_id":"MDU6TGFiZWwxMDE5NTg2NDg4","url":"https://api.github.com/repos/foam-framework/foam2/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/foam-framework/foam2/pulls/2303/commits","review_comments_url":"https://api.github.com/repos/foam-framework/foam2/pulls/2303/comments","review_comment_url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foam-framework/foam2/issues/2303/comments","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/89fb25d57c422ff541d06fe9d33fee3046ea86bc","head":{"label":"tharmaman:CPF-946/DAOContCreateFaceting","ref":"CPF-946/DAOContCreateFaceting","sha":"89fb25d57c422ff541d06fe9d33fee3046ea86bc","user":{"login":"tharmaman","id":26717171,"node_id":"MDQ6VXNlcjI2NzE3MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/26717171?v=4","gravatar_id":"","url":"https://api.github.com/users/tharmaman","html_url":"https://github.com/tharmaman","followers_url":"https://api.github.com/users/tharmaman/followers","following_url":"https://api.github.com/users/tharmaman/following{/other_user}","gists_url":"https://api.github.com/users/tharmaman/gists{/gist_id}","starred_url":"https://api.github.com/users/tharmaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharmaman/subscriptions","organizations_url":"https://api.github.com/users/tharmaman/orgs","repos_url":"https://api.github.com/users/tharmaman/repos","events_url":"https://api.github.com/users/tharmaman/events{/privacy}","received_events_url":"https://api.github.com/users/tharmaman/received_events","type":"User","site_admin":false},"repo":{"id":177822146,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc4MjIxNDY=","name":"foam2","full_name":"tharmaman/foam2","private":false,"owner":{"login":"tharmaman","id":26717171,"node_id":"MDQ6VXNlcjI2NzE3MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/26717171?v=4","gravatar_id":"","url":"https://api.github.com/users/tharmaman","html_url":"https://github.com/tharmaman","followers_url":"https://api.github.com/users/tharmaman/followers","following_url":"https://api.github.com/users/tharmaman/following{/other_user}","gists_url":"https://api.github.com/users/tharmaman/gists{/gist_id}","starred_url":"https://api.github.com/users/tharmaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharmaman/subscriptions","organizations_url":"https://api.github.com/users/tharmaman/orgs","repos_url":"https://api.github.com/users/tharmaman/repos","events_url":"https://api.github.com/users/tharmaman/events{/privacy}","received_events_url":"https://api.github.com/users/tharmaman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tharmaman/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":true,"url":"https://api.github.com/repos/tharmaman/foam2","forks_url":"https://api.github.com/repos/tharmaman/foam2/forks","keys_url":"https://api.github.com/repos/tharmaman/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tharmaman/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tharmaman/foam2/teams","hooks_url":"https://api.github.com/repos/tharmaman/foam2/hooks","issue_events_url":"https://api.github.com/repos/tharmaman/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/tharmaman/foam2/events","assignees_url":"https://api.github.com/repos/tharmaman/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/tharmaman/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/tharmaman/foam2/tags","blobs_url":"https://api.github.com/repos/tharmaman/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tharmaman/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tharmaman/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/tharmaman/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tharmaman/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/tharmaman/foam2/languages","stargazers_url":"https://api.github.com/repos/tharmaman/foam2/stargazers","contributors_url":"https://api.github.com/repos/tharmaman/foam2/contributors","subscribers_url":"https://api.github.com/repos/tharmaman/foam2/subscribers","subscription_url":"https://api.github.com/repos/tharmaman/foam2/subscription","commits_url":"https://api.github.com/repos/tharmaman/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/tharmaman/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/tharmaman/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/tharmaman/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/tharmaman/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/tharmaman/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tharmaman/foam2/merges","archive_url":"https://api.github.com/repos/tharmaman/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tharmaman/foam2/downloads","issues_url":"https://api.github.com/repos/tharmaman/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/tharmaman/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/tharmaman/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/tharmaman/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tharmaman/foam2/labels{/name}","releases_url":"https://api.github.com/repos/tharmaman/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/tharmaman/foam2/deployments","created_at":"2019-03-26T15:56:20Z","updated_at":"2019-06-18T17:21:52Z","pushed_at":"2019-06-19T17:44:43Z","git_url":"git://github.com/tharmaman/foam2.git","ssh_url":"git@github.com:tharmaman/foam2.git","clone_url":"https://github.com/tharmaman/foam2.git","svn_url":"https://github.com/tharmaman/foam2","homepage":"","size":31419,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"foam-framework:master","ref":"master","sha":"28ef8bf74a56f748393ad621a1b0fd1b6f1afd33","user":{"login":"foam-framework","id":7460756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjA3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7460756?v=4","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":50441060,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQ0MTA2MA==","name":"foam2","full_name":"foam-framework/foam2","private":false,"owner":{"login":"foam-framework","id":7460756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjA3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7460756?v=4","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/foam-framework/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":false,"url":"https://api.github.com/repos/foam-framework/foam2","forks_url":"https://api.github.com/repos/foam-framework/foam2/forks","keys_url":"https://api.github.com/repos/foam-framework/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foam-framework/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foam-framework/foam2/teams","hooks_url":"https://api.github.com/repos/foam-framework/foam2/hooks","issue_events_url":"https://api.github.com/repos/foam-framework/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/foam-framework/foam2/events","assignees_url":"https://api.github.com/repos/foam-framework/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/foam-framework/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/foam-framework/foam2/tags","blobs_url":"https://api.github.com/repos/foam-framework/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foam-framework/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foam-framework/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/foam-framework/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/foam-framework/foam2/languages","stargazers_url":"https://api.github.com/repos/foam-framework/foam2/stargazers","contributors_url":"https://api.github.com/repos/foam-framework/foam2/contributors","subscribers_url":"https://api.github.com/repos/foam-framework/foam2/subscribers","subscription_url":"https://api.github.com/repos/foam-framework/foam2/subscription","commits_url":"https://api.github.com/repos/foam-framework/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/foam-framework/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/foam-framework/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/foam-framework/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/foam-framework/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/foam-framework/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foam-framework/foam2/merges","archive_url":"https://api.github.com/repos/foam-framework/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foam-framework/foam2/downloads","issues_url":"https://api.github.com/repos/foam-framework/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/foam-framework/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/foam-framework/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/foam-framework/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foam-framework/foam2/labels{/name}","releases_url":"https://api.github.com/repos/foam-framework/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/foam-framework/foam2/deployments","created_at":"2016-01-26T16:13:38Z","updated_at":"2019-06-20T15:26:58Z","pushed_at":"2019-06-20T15:26:48Z","git_url":"git://github.com/foam-framework/foam2.git","ssh_url":"git@github.com:foam-framework/foam2.git","clone_url":"https://github.com/foam-framework/foam2.git","svn_url":"https://github.com/foam-framework/foam2","homepage":"","size":31450,"stargazers_count":41,"watchers_count":41,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":211,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":211,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2303"},"html":{"href":"https://github.com/foam-framework/foam2/pull/2303"},"issue":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/2303"},"comments":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/2303/comments"},"review_comments":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2303/comments"},"review_comment":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2303/commits"},"statuses":{"href":"https://api.github.com/repos/foam-framework/foam2/statuses/89fb25d57c422ff541d06fe9d33fee3046ea86bc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcarcaso"}}