{"action":"opened","number":2856,"pull_request":{"url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2856","id":292107530,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkyMTA3NTMw","html_url":"https://github.com/googleapis/gapic-generator/pull/2856","diff_url":"https://github.com/googleapis/gapic-generator/pull/2856.diff","patch_url":"https://github.com/googleapis/gapic-generator/pull/2856.patch","issue_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2856","number":2856,"state":"open","locked":false,"title":"Make it possible to pass metadata to the operations client","user":{"login":"samphippen","id":96662,"node_id":"MDQ6VXNlcjk2NjYy","avatar_url":"https://avatars1.githubusercontent.com/u/96662?v=4","gravatar_id":"","url":"https://api.github.com/users/samphippen","html_url":"https://github.com/samphippen","followers_url":"https://api.github.com/users/samphippen/followers","following_url":"https://api.github.com/users/samphippen/following{/other_user}","gists_url":"https://api.github.com/users/samphippen/gists{/gist_id}","starred_url":"https://api.github.com/users/samphippen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samphippen/subscriptions","organizations_url":"https://api.github.com/users/samphippen/orgs","repos_url":"https://api.github.com/users/samphippen/repos","events_url":"https://api.github.com/users/samphippen/events{/privacy}","received_events_url":"https://api.github.com/users/samphippen/received_events","type":"User","site_admin":false},"body":"For googleads we inject `developer-token` and `login-customer-id` to all\r\nReques)ts. Previously to this patch, we had used a [monkey patch](https://git.io/fjrda)\r\nto inject them in to the right place. However, ths patch was built\r\nagainst an old version of both gax and the generated code and no longer\r\nworks for the newly generated google ads v2 protos.\r\n\r\nAt the core of the requirement is that both the main API client and,\r\nwhere generated, the long running operations client, have injecatable\r\nmetadata so that we can provide them for LROs without patches.\r\n\r\nThis patch passes the metadata value passed in to the constructed client\r\nalong to the Long Running Operations client, which was not happening\r\nbefore.","created_at":"2019-06-26T18:27:13Z","updated_at":"2019-06-26T18:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2856/commits","review_comments_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2856/comments","review_comment_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2856/comments","statuses_url":"https://api.github.com/repos/googleapis/gapic-generator/statuses/132fd6dbc3af3d93fd375fdbf4febeba90a8b8a3","head":{"label":"samphippen:pass-metadata-to-operations-client","ref":"pass-metadata-to-operations-client","sha":"132fd6dbc3af3d93fd375fdbf4febeba90a8b8a3","user":{"login":"samphippen","id":96662,"node_id":"MDQ6VXNlcjk2NjYy","avatar_url":"https://avatars1.githubusercontent.com/u/96662?v=4","gravatar_id":"","url":"https://api.github.com/users/samphippen","html_url":"https://github.com/samphippen","followers_url":"https://api.github.com/users/samphippen/followers","following_url":"https://api.github.com/users/samphippen/following{/other_user}","gists_url":"https://api.github.com/users/samphippen/gists{/gist_id}","starred_url":"https://api.github.com/users/samphippen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samphippen/subscriptions","organizations_url":"https://api.github.com/users/samphippen/orgs","repos_url":"https://api.github.com/users/samphippen/repos","events_url":"https://api.github.com/users/samphippen/events{/privacy}","received_events_url":"https://api.github.com/users/samphippen/received_events","type":"User","site_admin":false},"repo":{"id":193957614,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM5NTc2MTQ=","name":"gapic-generator","full_name":"samphippen/gapic-generator","private":false,"owner":{"login":"samphippen","id":96662,"node_id":"MDQ6VXNlcjk2NjYy","avatar_url":"https://avatars1.githubusercontent.com/u/96662?v=4","gravatar_id":"","url":"https://api.github.com/users/samphippen","html_url":"https://github.com/samphippen","followers_url":"https://api.github.com/users/samphippen/followers","following_url":"https://api.github.com/users/samphippen/following{/other_user}","gists_url":"https://api.github.com/users/samphippen/gists{/gist_id}","starred_url":"https://api.github.com/users/samphippen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samphippen/subscriptions","organizations_url":"https://api.github.com/users/samphippen/orgs","repos_url":"https://api.github.com/users/samphippen/repos","events_url":"https://api.github.com/users/samphippen/events{/privacy}","received_events_url":"https://api.github.com/users/samphippen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/samphippen/gapic-generator","description":"Tools for generating API client libraries from API Service Configuration descriptions.","fork":true,"url":"https://api.github.com/repos/samphippen/gapic-generator","forks_url":"https://api.github.com/repos/samphippen/gapic-generator/forks","keys_url":"https://api.github.com/repos/samphippen/gapic-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samphippen/gapic-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samphippen/gapic-generator/teams","hooks_url":"https://api.github.com/repos/samphippen/gapic-generator/hooks","issue_events_url":"https://api.github.com/repos/samphippen/gapic-generator/issues/events{/number}","events_url":"https://api.github.com/repos/samphippen/gapic-generator/events","assignees_url":"https://api.github.com/repos/samphippen/gapic-generator/assignees{/user}","branches_url":"https://api.github.com/repos/samphippen/gapic-generator/branches{/branch}","tags_url":"https://api.github.com/repos/samphippen/gapic-generator/tags","blobs_url":"https://api.github.com/repos/samphippen/gapic-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samphippen/gapic-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samphippen/gapic-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/samphippen/gapic-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samphippen/gapic-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/samphippen/gapic-generator/languages","stargazers_url":"https://api.github.com/repos/samphippen/gapic-generator/stargazers","contributors_url":"https://api.github.com/repos/samphippen/gapic-generator/contributors","subscribers_url":"https://api.github.com/repos/samphippen/gapic-generator/subscribers","subscription_url":"https://api.github.com/repos/samphippen/gapic-generator/subscription","commits_url":"https://api.github.com/repos/samphippen/gapic-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/samphippen/gapic-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/samphippen/gapic-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/samphippen/gapic-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/samphippen/gapic-generator/contents/{+path}","compare_url":"https://api.github.com/repos/samphippen/gapic-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samphippen/gapic-generator/merges","archive_url":"https://api.github.com/repos/samphippen/gapic-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samphippen/gapic-generator/downloads","issues_url":"https://api.github.com/repos/samphippen/gapic-generator/issues{/number}","pulls_url":"https://api.github.com/repos/samphippen/gapic-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/samphippen/gapic-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/samphippen/gapic-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samphippen/gapic-generator/labels{/name}","releases_url":"https://api.github.com/repos/samphippen/gapic-generator/releases{/id}","deployments_url":"https://api.github.com/repos/samphippen/gapic-generator/deployments","created_at":"2019-06-26T18:26:39Z","updated_at":"2019-06-26T18:26:44Z","pushed_at":"2019-06-26T18:27:04Z","git_url":"git://github.com/samphippen/gapic-generator.git","ssh_url":"git@github.com:samphippen/gapic-generator.git","clone_url":"https://github.com/samphippen/gapic-generator.git","svn_url":"https://github.com/samphippen/gapic-generator","homepage":"","size":29136,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"76dab707159b65549e262e504e5305305dbb5695","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":56533838,"node_id":"MDEwOlJlcG9zaXRvcnk1NjUzMzgzOA==","name":"gapic-generator","full_name":"googleapis/gapic-generator","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/gapic-generator","description":"Tools for generating API client libraries from API Service Configuration descriptions.","fork":false,"url":"https://api.github.com/repos/googleapis/gapic-generator","forks_url":"https://api.github.com/repos/googleapis/gapic-generator/forks","keys_url":"https://api.github.com/repos/googleapis/gapic-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gapic-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gapic-generator/teams","hooks_url":"https://api.github.com/repos/googleapis/gapic-generator/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gapic-generator/events","assignees_url":"https://api.github.com/repos/googleapis/gapic-generator/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gapic-generator/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gapic-generator/tags","blobs_url":"https://api.github.com/repos/googleapis/gapic-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gapic-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gapic-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gapic-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gapic-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gapic-generator/languages","stargazers_url":"https://api.github.com/repos/googleapis/gapic-generator/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gapic-generator/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gapic-generator/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gapic-generator/subscription","commits_url":"https://api.github.com/repos/googleapis/gapic-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gapic-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gapic-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gapic-generator/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gapic-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gapic-generator/merges","archive_url":"https://api.github.com/repos/googleapis/gapic-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gapic-generator/downloads","issues_url":"https://api.github.com/repos/googleapis/gapic-generator/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gapic-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gapic-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gapic-generator/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gapic-generator/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gapic-generator/deployments","created_at":"2016-04-18T18:58:04Z","updated_at":"2019-06-24T19:05:32Z","pushed_at":"2019-06-26T17:40:18Z","git_url":"git://github.com/googleapis/gapic-generator.git","ssh_url":"git@github.com:googleapis/gapic-generator.git","clone_url":"https://github.com/googleapis/gapic-generator.git","svn_url":"https://github.com/googleapis/gapic-generator","homepage":"","size":29136,"stargazers_count":117,"watchers_count":117,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":90,"open_issues":200,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2856"},"html":{"href":"https://github.com/googleapis/gapic-generator/pull/2856"},"issue":{"href":"https://api.github.com/repos/googleapis/gapic-generator/issues/2856"},"comments":{"href":"https://api.github.com/repos/googleapis/gapic-generator/issues/2856/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2856/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2856/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gapic-generator/statuses/132fd6dbc3af3d93fd375fdbf4febeba90a8b8a3"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"samphippen"}}