{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/293691195","pull_request_review_id":249749521,"id":293691195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzY5MTE5NQ==","diff_hunk":"@@ -193,8 +230,29 @@ impl Inner {\n             Entry::Vacant(_) => None,\n         }\n     }\n+\n+    fn is_connected(&self, addr0: &SocketAddr, addr1: &SocketAddr) -> bool {\n+        self.find_node(addr0)\n+            .map(|node| node.borrow().is_connected(addr1))\n+            .unwrap_or(false)\n+    }\n+\n+    fn disconnect(&self, addr0: &SocketAddr, addr1: &SocketAddr) {\n+        if let Some(node) = self.find_node(addr0) {\n+            node.borrow_mut().disconnect(*addr1)\n+        }\n+    }\n }\n \n+// The 4-byte tags of `Message::Direct` and `DirectMessage::ParsecRequest`.\n+// A serialised Parsec request message starts with these bytes.\n+#[cfg(not(feature = \"mock_serialise\"))]\n+static PARSEC_REQ_MSG_TAGS: &[u8] = &[0, 0, 0, 0, 9, 0, 0, 0];","path":"src/mock/quic_p2p/network.rs","position":145,"original_position":134,"commit_id":"c2acb4240e05353c7b8b0de285f149efa3a570b7","original_commit_id":"35ea3071491ee20c7f54076318c8a15df0663504","user":{"login":"madadam","id":5271,"node_id":"MDQ6VXNlcjUyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5271?v=4","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"body":"It's duplicated currently, but when crust (and mock_crust) is gone it won't be.","created_at":"2019-06-14T07:36:33Z","updated_at":"2019-06-14T07:36:33Z","html_url":"https://github.com/maidsafe/routing/pull/1692#discussion_r293691195","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/1692","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/293691195"},"html":{"href":"https://github.com/maidsafe/routing/pull/1692#discussion_r293691195"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1692"}},"in_reply_to_id":293411550},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1692","id":287900418,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3OTAwNDE4","html_url":"https://github.com/maidsafe/routing/pull/1692","diff_url":"https://github.com/maidsafe/routing/pull/1692.diff","patch_url":"https://github.com/maidsafe/routing/pull/1692.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1692","number":1692,"state":"open","locked":false,"title":"(WIP) Replace crust with quic-p2p","user":{"login":"madadam","id":5271,"node_id":"MDQ6VXNlcjUyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5271?v=4","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"body":"This is **WIP** because some tests are still failing. Also the crust dependency and the mock_crust module is not removed yet (kept around for reference, but will be removed in the final PR). ","created_at":"2019-06-13T12:22:20Z","updated_at":"2019-06-14T07:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1692/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1692/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1692/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/c2acb4240e05353c7b8b0de285f149efa3a570b7","head":{"label":"madadam:quic","ref":"quic","sha":"c2acb4240e05353c7b8b0de285f149efa3a570b7","user":{"login":"madadam","id":5271,"node_id":"MDQ6VXNlcjUyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5271?v=4","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"repo":{"id":50021619,"node_id":"MDEwOlJlcG9zaXRvcnk1MDAyMTYxOQ==","name":"routing","full_name":"madadam/routing","private":false,"owner":{"login":"madadam","id":5271,"node_id":"MDQ6VXNlcjUyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5271?v=4","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/madadam/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/madadam/routing","forks_url":"https://api.github.com/repos/madadam/routing/forks","keys_url":"https://api.github.com/repos/madadam/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madadam/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madadam/routing/teams","hooks_url":"https://api.github.com/repos/madadam/routing/hooks","issue_events_url":"https://api.github.com/repos/madadam/routing/issues/events{/number}","events_url":"https://api.github.com/repos/madadam/routing/events","assignees_url":"https://api.github.com/repos/madadam/routing/assignees{/user}","branches_url":"https://api.github.com/repos/madadam/routing/branches{/branch}","tags_url":"https://api.github.com/repos/madadam/routing/tags","blobs_url":"https://api.github.com/repos/madadam/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madadam/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madadam/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/madadam/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madadam/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/madadam/routing/languages","stargazers_url":"https://api.github.com/repos/madadam/routing/stargazers","contributors_url":"https://api.github.com/repos/madadam/routing/contributors","subscribers_url":"https://api.github.com/repos/madadam/routing/subscribers","subscription_url":"https://api.github.com/repos/madadam/routing/subscription","commits_url":"https://api.github.com/repos/madadam/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/madadam/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/madadam/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/madadam/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/madadam/routing/contents/{+path}","compare_url":"https://api.github.com/repos/madadam/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madadam/routing/merges","archive_url":"https://api.github.com/repos/madadam/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madadam/routing/downloads","issues_url":"https://api.github.com/repos/madadam/routing/issues{/number}","pulls_url":"https://api.github.com/repos/madadam/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/madadam/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/madadam/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madadam/routing/labels{/name}","releases_url":"https://api.github.com/repos/madadam/routing/releases{/id}","deployments_url":"https://api.github.com/repos/madadam/routing/deployments","created_at":"2016-01-20T10:07:55Z","updated_at":"2016-01-20T10:07:56Z","pushed_at":"2019-06-13T15:13:32Z","git_url":"git://github.com/madadam/routing.git","ssh_url":"git@github.com:madadam/routing.git","clone_url":"https://github.com/madadam/routing.git","svn_url":"https://github.com/madadam/routing","homepage":null,"size":50916,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:fleming","ref":"fleming","sha":"277a99040a95b2abc4bb5baa21e40394bccf5206","user":{"login":"maidsafe","id":536423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/536423?v=4","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"node_id":"MDEwOlJlcG9zaXRvcnkzMTI3MDUxNA==","name":"routing","full_name":"maidsafe/routing","private":false,"owner":{"login":"maidsafe","id":536423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNjQyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/536423?v=4","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2019-06-04T15:08:43Z","pushed_at":"2019-06-13T16:23:05Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":113523,"stargazers_count":195,"watchers_count":195,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":66,"open_issues":35,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1692"},"html":{"href":"https://github.com/maidsafe/routing/pull/1692"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1692"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1692/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1692/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1692/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/c2acb4240e05353c7b8b0de285f149efa3a570b7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"madadam"}}