{"action":"created","comment":{"url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/comments/262135470","pull_request_review_id":210234899,"id":262135470,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjEzNTQ3MA==","diff_hunk":"@@ -0,0 +1,27 @@\n+import _ from 'lodash';\n+\n+export default class RespProcessor {\n+\tconstructor(vis, buildChartData, utils) {\n+\t\tthis.buildChartData = buildChartData;","path":"public/resp_processor.js","position":5,"original_position":5,"commit_id":"0edec76eb89ec97d87ded88987966bd0fabaa538","original_commit_id":"0edec76eb89ec97d87ded88987966bd0fabaa538","user":{"login":"colmose","id":8244036,"node_id":"MDQ6VXNlcjgyNDQwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/8244036?v=4","gravatar_id":"","url":"https://api.github.com/users/colmose","html_url":"https://github.com/colmose","followers_url":"https://api.github.com/users/colmose/followers","following_url":"https://api.github.com/users/colmose/following{/other_user}","gists_url":"https://api.github.com/users/colmose/gists{/gist_id}","starred_url":"https://api.github.com/users/colmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colmose/subscriptions","organizations_url":"https://api.github.com/users/colmose/orgs","repos_url":"https://api.github.com/users/colmose/repos","events_url":"https://api.github.com/users/colmose/events{/privacy}","received_events_url":"https://api.github.com/users/colmose/received_events","type":"User","site_admin":false},"body":"Could do with a happy path unit test for that resp processor class. Make an issue?","created_at":"2019-03-04T16:23:34Z","updated_at":"2019-03-04T16:23:35Z","html_url":"https://github.com/sirensolutions/enhanced_tilemap/pull/23#discussion_r262135470","pull_request_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/comments/262135470"},"html":{"href":"https://github.com/sirensolutions/enhanced_tilemap/pull/23#discussion_r262135470"},"pull_request":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23"}},"in_reply_to_id":262134717},"pull_request":{"url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23","id":257910060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3OTEwMDYw","html_url":"https://github.com/sirensolutions/enhanced_tilemap/pull/23","diff_url":"https://github.com/sirensolutions/enhanced_tilemap/pull/23.diff","patch_url":"https://github.com/sirensolutions/enhanced_tilemap/pull/23.patch","issue_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/23","number":23,"state":"open","locked":false,"title":"prevent exceptions when empty buckets returned","user":{"login":"szydan","id":900118,"node_id":"MDQ6VXNlcjkwMDExOA==","avatar_url":"https://avatars1.githubusercontent.com/u/900118?v=4","gravatar_id":"","url":"https://api.github.com/users/szydan","html_url":"https://github.com/szydan","followers_url":"https://api.github.com/users/szydan/followers","following_url":"https://api.github.com/users/szydan/following{/other_user}","gists_url":"https://api.github.com/users/szydan/gists{/gist_id}","starred_url":"https://api.github.com/users/szydan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szydan/subscriptions","organizations_url":"https://api.github.com/users/szydan/orgs","repos_url":"https://api.github.com/users/szydan/repos","events_url":"https://api.github.com/users/szydan/events{/privacy}","received_events_url":"https://api.github.com/users/szydan/received_events","type":"User","site_admin":false},"body":"Fix for \r\nhttps://github.com/sirensolutions/kibi-internal/issues/8521\r\n\r\nBefore for no data\r\n<img width=\"1075\" alt=\"screenshot 2019-03-04 at 11 37 24\" src=\"https://user-images.githubusercontent.com/900118/53731199-e70b1300-3e71-11e9-95be-97b87e32466f.png\">\r\nAfter \r\n<img width=\"1231\" alt=\"screenshot 2019-03-04 at 11 36 42\" src=\"https://user-images.githubusercontent.com/900118/53731211-f2f6d500-3e71-11e9-9b8b-4215c510534b.png\">\r\n","created_at":"2019-03-04T11:38:14Z","updated_at":"2019-03-04T16:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3baf0a1732897c2f47488bc2d0c1873e9e0a30b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23/commits","review_comments_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23/comments","review_comment_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/23/comments","statuses_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/statuses/0edec76eb89ec97d87ded88987966bd0fabaa538","head":{"label":"sirensolutions:issue_8521_internal","ref":"issue_8521_internal","sha":"0edec76eb89ec97d87ded88987966bd0fabaa538","user":{"login":"sirensolutions","id":12463357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDYzMzU3","avatar_url":"https://avatars3.githubusercontent.com/u/12463357?v=4","gravatar_id":"","url":"https://api.github.com/users/sirensolutions","html_url":"https://github.com/sirensolutions","followers_url":"https://api.github.com/users/sirensolutions/followers","following_url":"https://api.github.com/users/sirensolutions/following{/other_user}","gists_url":"https://api.github.com/users/sirensolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/sirensolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirensolutions/subscriptions","organizations_url":"https://api.github.com/users/sirensolutions/orgs","repos_url":"https://api.github.com/users/sirensolutions/repos","events_url":"https://api.github.com/users/sirensolutions/events{/privacy}","received_events_url":"https://api.github.com/users/sirensolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":129116124,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMTYxMjQ=","name":"enhanced_tilemap","full_name":"sirensolutions/enhanced_tilemap","private":false,"owner":{"login":"sirensolutions","id":12463357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDYzMzU3","avatar_url":"https://avatars3.githubusercontent.com/u/12463357?v=4","gravatar_id":"","url":"https://api.github.com/users/sirensolutions","html_url":"https://github.com/sirensolutions","followers_url":"https://api.github.com/users/sirensolutions/followers","following_url":"https://api.github.com/users/sirensolutions/following{/other_user}","gists_url":"https://api.github.com/users/sirensolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/sirensolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirensolutions/subscriptions","organizations_url":"https://api.github.com/users/sirensolutions/orgs","repos_url":"https://api.github.com/users/sirensolutions/repos","events_url":"https://api.github.com/users/sirensolutions/events{/privacy}","received_events_url":"https://api.github.com/users/sirensolutions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sirensolutions/enhanced_tilemap","description":"Kibana mapping visualization","fork":true,"url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap","forks_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/forks","keys_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/teams","hooks_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/hooks","issue_events_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/events{/number}","events_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/events","assignees_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/assignees{/user}","branches_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/branches{/branch}","tags_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/tags","blobs_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/statuses/{sha}","languages_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/languages","stargazers_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/stargazers","contributors_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/contributors","subscribers_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/subscribers","subscription_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/subscription","commits_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/contents/{+path}","compare_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/merges","archive_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/downloads","issues_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues{/number}","pulls_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls{/number}","milestones_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/milestones{/number}","notifications_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/labels{/name}","releases_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/releases{/id}","deployments_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/deployments","created_at":"2018-04-11T15:36:00Z","updated_at":"2018-12-06T12:34:53Z","pushed_at":"2019-03-04T16:15:29Z","git_url":"git://github.com/sirensolutions/enhanced_tilemap.git","ssh_url":"git@github.com:sirensolutions/enhanced_tilemap.git","clone_url":"https://github.com/sirensolutions/enhanced_tilemap.git","svn_url":"https://github.com/sirensolutions/enhanced_tilemap","homepage":"","size":5673,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sirensolutions:master","ref":"master","sha":"22bb317cd2bec431c1b69fa6e0404bc0a6c7717a","user":{"login":"sirensolutions","id":12463357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDYzMzU3","avatar_url":"https://avatars3.githubusercontent.com/u/12463357?v=4","gravatar_id":"","url":"https://api.github.com/users/sirensolutions","html_url":"https://github.com/sirensolutions","followers_url":"https://api.github.com/users/sirensolutions/followers","following_url":"https://api.github.com/users/sirensolutions/following{/other_user}","gists_url":"https://api.github.com/users/sirensolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/sirensolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirensolutions/subscriptions","organizations_url":"https://api.github.com/users/sirensolutions/orgs","repos_url":"https://api.github.com/users/sirensolutions/repos","events_url":"https://api.github.com/users/sirensolutions/events{/privacy}","received_events_url":"https://api.github.com/users/sirensolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":129116124,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxMTYxMjQ=","name":"enhanced_tilemap","full_name":"sirensolutions/enhanced_tilemap","private":false,"owner":{"login":"sirensolutions","id":12463357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDYzMzU3","avatar_url":"https://avatars3.githubusercontent.com/u/12463357?v=4","gravatar_id":"","url":"https://api.github.com/users/sirensolutions","html_url":"https://github.com/sirensolutions","followers_url":"https://api.github.com/users/sirensolutions/followers","following_url":"https://api.github.com/users/sirensolutions/following{/other_user}","gists_url":"https://api.github.com/users/sirensolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/sirensolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirensolutions/subscriptions","organizations_url":"https://api.github.com/users/sirensolutions/orgs","repos_url":"https://api.github.com/users/sirensolutions/repos","events_url":"https://api.github.com/users/sirensolutions/events{/privacy}","received_events_url":"https://api.github.com/users/sirensolutions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sirensolutions/enhanced_tilemap","description":"Kibana mapping visualization","fork":true,"url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap","forks_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/forks","keys_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/teams","hooks_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/hooks","issue_events_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/events{/number}","events_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/events","assignees_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/assignees{/user}","branches_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/branches{/branch}","tags_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/tags","blobs_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/statuses/{sha}","languages_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/languages","stargazers_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/stargazers","contributors_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/contributors","subscribers_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/subscribers","subscription_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/subscription","commits_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/comments{/number}","contents_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/contents/{+path}","compare_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/merges","archive_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/downloads","issues_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues{/number}","pulls_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls{/number}","milestones_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/milestones{/number}","notifications_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/labels{/name}","releases_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/releases{/id}","deployments_url":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/deployments","created_at":"2018-04-11T15:36:00Z","updated_at":"2018-12-06T12:34:53Z","pushed_at":"2019-03-04T16:15:29Z","git_url":"git://github.com/sirensolutions/enhanced_tilemap.git","ssh_url":"git@github.com:sirensolutions/enhanced_tilemap.git","clone_url":"https://github.com/sirensolutions/enhanced_tilemap.git","svn_url":"https://github.com/sirensolutions/enhanced_tilemap","homepage":"","size":5673,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23"},"html":{"href":"https://github.com/sirensolutions/enhanced_tilemap/pull/23"},"issue":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/23"},"comments":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/sirensolutions/enhanced_tilemap/statuses/0edec76eb89ec97d87ded88987966bd0fabaa538"}},"author_association":"NONE"}}
{"actor":{"display_login":"colmose"}}