{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/293137605","pull_request_review_id":249041843,"id":293137605,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzEzNzYwNQ==","diff_hunk":"@@ -580,13 +614,16 @@ void main() {\n           onPageChanged: (int page) {\n             changeIndex = page;\n           },\n+          pageDidChanged: (int page) {\n+            changeIndex = page;","path":"packages/flutter/test/widgets/page_view_test.dart","position":85,"original_position":85,"commit_id":"3da859db25a5f7ad11028a5ef9de739d9df049f0","original_commit_id":"3da859db25a5f7ad11028a5ef9de739d9df049f0","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"same here. This should set a different variable.","created_at":"2019-06-12T22:07:11Z","updated_at":"2019-06-12T22:07:17Z","html_url":"https://github.com/flutter/flutter/pull/34039#discussion_r293137605","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/34039","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/293137605"},"html":{"href":"https://github.com/flutter/flutter/pull/34039#discussion_r293137605"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/34039"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/34039","id":286156322,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MTU2MzIy","html_url":"https://github.com/flutter/flutter/pull/34039","diff_url":"https://github.com/flutter/flutter/pull/34039.diff","patch_url":"https://github.com/flutter/flutter/pull/34039.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/34039","number":34039,"state":"open","locked":false,"title":"Add a new method to PageView, called when the page changes and scrolling event ends.","user":{"login":"tango5614","id":35095715,"node_id":"MDQ6VXNlcjM1MDk1NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/35095715?v=4","gravatar_id":"","url":"https://api.github.com/users/tango5614","html_url":"https://github.com/tango5614","followers_url":"https://api.github.com/users/tango5614/followers","following_url":"https://api.github.com/users/tango5614/following{/other_user}","gists_url":"https://api.github.com/users/tango5614/gists{/gist_id}","starred_url":"https://api.github.com/users/tango5614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango5614/subscriptions","organizations_url":"https://api.github.com/users/tango5614/orgs","repos_url":"https://api.github.com/users/tango5614/repos","events_url":"https://api.github.com/users/tango5614/events{/privacy}","received_events_url":"https://api.github.com/users/tango5614/received_events","type":"User","site_admin":false},"body":"## Description\r\n<b>What I have done?</b>\r\n\r\nAdd a new method called `pageDidChanged` to PageView which will be called at the end of the page change animation.\r\n\r\n<b>Why did I do it?</b>\r\nThere's always situation where people want to do something after the page changes completely.\r\nFor example, in #28096 he/she wants to make the `pageView` unscrollable after it changes to a specific page. But that is impossible in `onPageChanged`, because it is called in the middle of page changing, which makes the `pageView` die.That's why we need a new method like `pageDidChange`.\r\n## Related Issues\r\n\r\n#28096\r\n\r\n## Tests\r\n\r\nI added the following tests:\r\nPage changes and scroll animation ends\r\nin the file `packages/flutter/lib/src/widgets/page_view.dart`\r\n\r\n## Checklist\r\n\r\nBefore you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I signed the [CLA].\r\n- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].\r\n- [ ] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] All existing and new tests are passing.\r\n- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.\r\n- [x] I am willing to follow-up on review comments in a timely manner.\r\n\r\n## Breaking Change\r\n\r\nDoes your PR require Flutter developers to manually update their apps to accommodate your change?\r\n\r\n- [ ] Yes, this is a breaking change (Please read [Handling breaking changes]). *Replace this with a link to the e-mail where you asked for input on this proposed change.*\r\n- [x] No, this is *not* a breaking change.\r\n\r\n<!-- Links -->\r\n[issue database]: https://github.com/flutter/flutter/issues\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement\r\n[CLA]: https://cla.developers.google.com/\r\n[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n","created_at":"2019-06-07T11:50:48Z","updated_at":"2019-06-12T22:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35e7c62be5146c0f61c0d10fefad8796b4bc6f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false},{"id":284437560,"node_id":"MDU6TGFiZWwyODQ0Mzc1NjA=","url":"https://api.github.com/repos/flutter/flutter/labels/framework","name":"framework","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/34039/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/34039/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/34039/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/3da859db25a5f7ad11028a5ef9de739d9df049f0","head":{"label":"tango5614:fix28096","ref":"fix28096","sha":"3da859db25a5f7ad11028a5ef9de739d9df049f0","user":{"login":"tango5614","id":35095715,"node_id":"MDQ6VXNlcjM1MDk1NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/35095715?v=4","gravatar_id":"","url":"https://api.github.com/users/tango5614","html_url":"https://github.com/tango5614","followers_url":"https://api.github.com/users/tango5614/followers","following_url":"https://api.github.com/users/tango5614/following{/other_user}","gists_url":"https://api.github.com/users/tango5614/gists{/gist_id}","starred_url":"https://api.github.com/users/tango5614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango5614/subscriptions","organizations_url":"https://api.github.com/users/tango5614/orgs","repos_url":"https://api.github.com/users/tango5614/repos","events_url":"https://api.github.com/users/tango5614/events{/privacy}","received_events_url":"https://api.github.com/users/tango5614/received_events","type":"User","site_admin":false},"repo":{"id":190550687,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA1NTA2ODc=","name":"flutter","full_name":"tango5614/flutter","private":false,"owner":{"login":"tango5614","id":35095715,"node_id":"MDQ6VXNlcjM1MDk1NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/35095715?v=4","gravatar_id":"","url":"https://api.github.com/users/tango5614","html_url":"https://github.com/tango5614","followers_url":"https://api.github.com/users/tango5614/followers","following_url":"https://api.github.com/users/tango5614/following{/other_user}","gists_url":"https://api.github.com/users/tango5614/gists{/gist_id}","starred_url":"https://api.github.com/users/tango5614/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango5614/subscriptions","organizations_url":"https://api.github.com/users/tango5614/orgs","repos_url":"https://api.github.com/users/tango5614/repos","events_url":"https://api.github.com/users/tango5614/events{/privacy}","received_events_url":"https://api.github.com/users/tango5614/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tango5614/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/tango5614/flutter","forks_url":"https://api.github.com/repos/tango5614/flutter/forks","keys_url":"https://api.github.com/repos/tango5614/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tango5614/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tango5614/flutter/teams","hooks_url":"https://api.github.com/repos/tango5614/flutter/hooks","issue_events_url":"https://api.github.com/repos/tango5614/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/tango5614/flutter/events","assignees_url":"https://api.github.com/repos/tango5614/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/tango5614/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/tango5614/flutter/tags","blobs_url":"https://api.github.com/repos/tango5614/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tango5614/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tango5614/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/tango5614/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tango5614/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/tango5614/flutter/languages","stargazers_url":"https://api.github.com/repos/tango5614/flutter/stargazers","contributors_url":"https://api.github.com/repos/tango5614/flutter/contributors","subscribers_url":"https://api.github.com/repos/tango5614/flutter/subscribers","subscription_url":"https://api.github.com/repos/tango5614/flutter/subscription","commits_url":"https://api.github.com/repos/tango5614/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/tango5614/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/tango5614/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/tango5614/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/tango5614/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/tango5614/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tango5614/flutter/merges","archive_url":"https://api.github.com/repos/tango5614/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tango5614/flutter/downloads","issues_url":"https://api.github.com/repos/tango5614/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/tango5614/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/tango5614/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/tango5614/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tango5614/flutter/labels{/name}","releases_url":"https://api.github.com/repos/tango5614/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/tango5614/flutter/deployments","created_at":"2019-06-06T09:06:22Z","updated_at":"2019-06-07T11:24:40Z","pushed_at":"2019-06-07T11:24:29Z","git_url":"git://github.com/tango5614/flutter.git","ssh_url":"git@github.com:tango5614/flutter.git","clone_url":"https://github.com/tango5614/flutter.git","svn_url":"https://github.com/tango5614/flutter","homepage":"https://flutter.dev","size":63595,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"d2e6ab69a26078303e8c8395ff569379104ec895","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2019-06-12T20:50:21Z","pushed_at":"2019-06-12T22:04:55Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.dev","size":64377,"stargazers_count":66979,"watchers_count":66979,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7600,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6127,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7600,"open_issues":6127,"watchers":66979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/34039"},"html":{"href":"https://github.com/flutter/flutter/pull/34039"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/34039"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/34039/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/34039/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/34039/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/3da859db25a5f7ad11028a5ef9de739d9df049f0"}},"author_association":"NONE"}}
{"actor":{"display_login":"goderbauer"}}