{"action":"opened","number":360,"pull_request":{"url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/360","id":338055757,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4MDU1NzU3","html_url":"https://github.com/googleapis/gax-dotnet/pull/360","diff_url":"https://github.com/googleapis/gax-dotnet/pull/360.diff","patch_url":"https://github.com/googleapis/gax-dotnet/pull/360.patch","issue_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/360","number":360,"state":"open","locked":false,"title":"Upgrade to gRPC 2.x and move Microsoft.Bcl.AsyncInterfaces","user":{"login":"jskeet","id":17011,"node_id":"MDQ6VXNlcjE3MDEx","avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"body":"This is mostly straightforward, but there are a few points to note:\r\n\r\n- Without updating to .NET Core 3.0 SDK, we can't use async yield return, so we still have significant implementation code\r\n- The AsyncStreamAdapter doesn't handle cancellation in an ideal way right now; that's probably okay for testing code, but we might need to look at it again.\r\n\r\ncc @amanda-tarafa (feel free to review as well, but I suspect only one person needs to look through the async enumerator implementation; there's no *policy* decision here)","created_at":"2019-11-07T14:05:46Z","updated_at":"2019-11-07T14:05:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"chrisdunelm","id":316748,"node_id":"MDQ6VXNlcjMxNjc0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/316748?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisdunelm","id":316748,"node_id":"MDQ6VXNlcjMxNjc0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/316748?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdunelm","html_url":"https://github.com/chrisdunelm","followers_url":"https://api.github.com/users/chrisdunelm/followers","following_url":"https://api.github.com/users/chrisdunelm/following{/other_user}","gists_url":"https://api.github.com/users/chrisdunelm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdunelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdunelm/subscriptions","organizations_url":"https://api.github.com/users/chrisdunelm/orgs","repos_url":"https://api.github.com/users/chrisdunelm/repos","events_url":"https://api.github.com/users/chrisdunelm/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdunelm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/360/commits","review_comments_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/360/comments","review_comment_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/360/comments","statuses_url":"https://api.github.com/repos/googleapis/gax-dotnet/statuses/7db9e35a3e8ac80ca662827e280ea48896c877bf","head":{"label":"jskeet:grpc2","ref":"grpc2","sha":"7db9e35a3e8ac80ca662827e280ea48896c877bf","user":{"login":"jskeet","id":17011,"node_id":"MDQ6VXNlcjE3MDEx","avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"repo":{"id":52385973,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM4NTk3Mw==","name":"gax-dotnet","full_name":"jskeet/gax-dotnet","private":false,"owner":{"login":"jskeet","id":17011,"node_id":"MDQ6VXNlcjE3MDEx","avatar_url":"https://avatars1.githubusercontent.com/u/17011?v=4","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jskeet/gax-dotnet","description":null,"fork":true,"url":"https://api.github.com/repos/jskeet/gax-dotnet","forks_url":"https://api.github.com/repos/jskeet/gax-dotnet/forks","keys_url":"https://api.github.com/repos/jskeet/gax-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jskeet/gax-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jskeet/gax-dotnet/teams","hooks_url":"https://api.github.com/repos/jskeet/gax-dotnet/hooks","issue_events_url":"https://api.github.com/repos/jskeet/gax-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/jskeet/gax-dotnet/events","assignees_url":"https://api.github.com/repos/jskeet/gax-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/jskeet/gax-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/jskeet/gax-dotnet/tags","blobs_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jskeet/gax-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/jskeet/gax-dotnet/languages","stargazers_url":"https://api.github.com/repos/jskeet/gax-dotnet/stargazers","contributors_url":"https://api.github.com/repos/jskeet/gax-dotnet/contributors","subscribers_url":"https://api.github.com/repos/jskeet/gax-dotnet/subscribers","subscription_url":"https://api.github.com/repos/jskeet/gax-dotnet/subscription","commits_url":"https://api.github.com/repos/jskeet/gax-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jskeet/gax-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jskeet/gax-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jskeet/gax-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jskeet/gax-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/jskeet/gax-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jskeet/gax-dotnet/merges","archive_url":"https://api.github.com/repos/jskeet/gax-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jskeet/gax-dotnet/downloads","issues_url":"https://api.github.com/repos/jskeet/gax-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/jskeet/gax-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/jskeet/gax-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/jskeet/gax-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jskeet/gax-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/jskeet/gax-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/jskeet/gax-dotnet/deployments","created_at":"2016-02-23T19:33:42Z","updated_at":"2018-03-20T08:19:12Z","pushed_at":"2019-11-07T14:04:42Z","git_url":"git://github.com/jskeet/gax-dotnet.git","ssh_url":"git@github.com:jskeet/gax-dotnet.git","clone_url":"https://github.com/jskeet/gax-dotnet.git","svn_url":"https://github.com/jskeet/gax-dotnet","homepage":null,"size":1208,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"57884c0ac28ffd099ec886a20c7a1cb739d859da","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50878438,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3ODQzOA==","name":"gax-dotnet","full_name":"googleapis/gax-dotnet","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/gax-dotnet","description":"Google API Extensions for .NET ","fork":false,"url":"https://api.github.com/repos/googleapis/gax-dotnet","forks_url":"https://api.github.com/repos/googleapis/gax-dotnet/forks","keys_url":"https://api.github.com/repos/googleapis/gax-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gax-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gax-dotnet/teams","hooks_url":"https://api.github.com/repos/googleapis/gax-dotnet/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gax-dotnet/events","assignees_url":"https://api.github.com/repos/googleapis/gax-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gax-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gax-dotnet/tags","blobs_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gax-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gax-dotnet/languages","stargazers_url":"https://api.github.com/repos/googleapis/gax-dotnet/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gax-dotnet/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gax-dotnet/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gax-dotnet/subscription","commits_url":"https://api.github.com/repos/googleapis/gax-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gax-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gax-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gax-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gax-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gax-dotnet/merges","archive_url":"https://api.github.com/repos/googleapis/gax-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gax-dotnet/downloads","issues_url":"https://api.github.com/repos/googleapis/gax-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gax-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gax-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gax-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gax-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gax-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gax-dotnet/deployments","created_at":"2016-02-01T23:13:51Z","updated_at":"2019-11-07T13:56:47Z","pushed_at":"2019-11-07T13:56:44Z","git_url":"git://github.com/googleapis/gax-dotnet.git","ssh_url":"git@github.com:googleapis/gax-dotnet.git","clone_url":"https://github.com/googleapis/gax-dotnet.git","svn_url":"https://github.com/googleapis/gax-dotnet","homepage":"","size":1178,"stargazers_count":39,"watchers_count":39,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":8,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/360"},"html":{"href":"https://github.com/googleapis/gax-dotnet/pull/360"},"issue":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/issues/360"},"comments":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gax-dotnet/statuses/7db9e35a3e8ac80ca662827e280ea48896c877bf"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":175,"deletions":45,"changed_files":12}}
{"actor":{"display_login":"jskeet"}}