{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments/293738006","pull_request_review_id":249795391,"id":293738006,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzczODAwNg==","diff_hunk":"@@ -70,3 +75,89 @@ def post(self, **kwargs):\n         )\n         with rest_utils.skip_nested_marshalling():\n             return super(Plugins, self).post(visibility=visibility)\n+\n+\n+class PluginsUpdate(SecuredResource):\n+\n+    @rest_decorators.exceptions_handled\n+    @authorize('plugins_update_create')\n+    @rest_decorators.marshal_with(models.PluginsUpdate)\n+    def post(self, id, phase):\n+        \"\"\"\n+        Supports two stages of a plugin update.\n+        Phases:\n+            1. Creates a temporary blueprint and executes a deployment update\n+            (will update only the plugins) for all the deployments of the\n+            given blueprint.\n+            2. Updates the original blueprint plan and deletes the temp one.\n+\n+        :param id: the blueprint ID to update it's deployments' plugins if\n+        phase == 'initiate', otherwise (phase == 'finalize') the plugin update\n+        ID.\n+        :param phase: either 'initiate' or 'finalize'.\n+        \"\"\"\n+\n+        def get_args():","path":"rest-service/manager_rest/rest/resources_v3_1/plugins.py","position":57,"original_position":57,"commit_id":"3adb287cec517a0b37cb6fa356f87603399a29f9","original_commit_id":"9a00b168dbf89576f5fa0c1872819c894aaa144a","user":{"login":"tyacbovi","id":3802463,"node_id":"MDQ6VXNlcjM4MDI0NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3802463?v=4","gravatar_id":"","url":"https://api.github.com/users/tyacbovi","html_url":"https://github.com/tyacbovi","followers_url":"https://api.github.com/users/tyacbovi/followers","following_url":"https://api.github.com/users/tyacbovi/following{/other_user}","gists_url":"https://api.github.com/users/tyacbovi/gists{/gist_id}","starred_url":"https://api.github.com/users/tyacbovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyacbovi/subscriptions","organizations_url":"https://api.github.com/users/tyacbovi/orgs","repos_url":"https://api.github.com/users/tyacbovi/repos","events_url":"https://api.github.com/users/tyacbovi/events{/privacy}","received_events_url":"https://api.github.com/users/tyacbovi/received_events","type":"User","site_admin":false},"body":"new func not needed","created_at":"2019-06-14T09:48:15Z","updated_at":"2019-06-14T09:50:49Z","html_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/1842#discussion_r293738006","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments/293738006"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager/pull/1842#discussion_r293738006"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842","id":288023623,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4MDIzNjIz","html_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/1842","diff_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/1842.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/1842.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/1842","number":1842,"state":"open","locked":false,"title":"CY-1060 Add a plugins update API","user":{"login":"davidginzbourg","id":3932179,"node_id":"MDQ6VXNlcjM5MzIxNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3932179?v=4","gravatar_id":"","url":"https://api.github.com/users/davidginzbourg","html_url":"https://github.com/davidginzbourg","followers_url":"https://api.github.com/users/davidginzbourg/followers","following_url":"https://api.github.com/users/davidginzbourg/following{/other_user}","gists_url":"https://api.github.com/users/davidginzbourg/gists{/gist_id}","starred_url":"https://api.github.com/users/davidginzbourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidginzbourg/subscriptions","organizations_url":"https://api.github.com/users/davidginzbourg/orgs","repos_url":"https://api.github.com/users/davidginzbourg/repos","events_url":"https://api.github.com/users/davidginzbourg/events{/privacy}","received_events_url":"https://api.github.com/users/davidginzbourg/received_events","type":"User","site_admin":false},"body":"- Fixes the case where deployment update doesn't update  sourced\r\ncentrally deployed plugins\r\n\r\n- Adds an `update_plugins` flag to pass to the update workflow. This flag\r\ncontrols the plugin installation, if set to False - it won't do any\r\nplugin un/installations.","created_at":"2019-06-13T17:24:42Z","updated_at":"2019-06-14T09:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea1077823c69e8db007e0ad9ea20bf511e2813ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/1842/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/3adb287cec517a0b37cb6fa356f87603399a29f9","head":{"label":"cloudify-cosmo:CY-1060-plugin-update","ref":"CY-1060-plugin-update","sha":"3adb287cec517a0b37cb6fa356f87603399a29f9","user":{"login":"cloudify-cosmo","id":6260555,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNjA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18326574,"node_id":"MDEwOlJlcG9zaXRvcnkxODMyNjU3NA==","name":"cloudify-manager","full_name":"cloudify-cosmo/cloudify-manager","private":false,"owner":{"login":"cloudify-cosmo","id":6260555,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNjA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudify-cosmo/cloudify-manager","description":"Cloudify's manager related code","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/deployments","created_at":"2014-04-01T11:06:47Z","updated_at":"2019-06-13T22:43:10Z","pushed_at":"2019-06-14T09:22:59Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-manager.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager","homepage":null,"size":18366,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":24,"watchers":77,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"0aa6b10539f91a51c151ed819046007c748c6633","user":{"login":"cloudify-cosmo","id":6260555,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNjA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18326574,"node_id":"MDEwOlJlcG9zaXRvcnkxODMyNjU3NA==","name":"cloudify-manager","full_name":"cloudify-cosmo/cloudify-manager","private":false,"owner":{"login":"cloudify-cosmo","id":6260555,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNjA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudify-cosmo/cloudify-manager","description":"Cloudify's manager related code","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/deployments","created_at":"2014-04-01T11:06:47Z","updated_at":"2019-06-13T22:43:10Z","pushed_at":"2019-06-14T09:22:59Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-manager.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager","homepage":null,"size":18366,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":53,"open_issues":24,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager/pull/1842"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/1842"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/1842/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/1842/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/3adb287cec517a0b37cb6fa356f87603399a29f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tyacbovi"}}