{"action":"created","issue":{"url":"https://api.github.com/repos/ssbc/ssb-msgs/issues/11","repository_url":"https://api.github.com/repos/ssbc/ssb-msgs","labels_url":"https://api.github.com/repos/ssbc/ssb-msgs/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/ssbc/ssb-msgs/issues/11/comments","events_url":"https://api.github.com/repos/ssbc/ssb-msgs/issues/11/events","html_url":"https://github.com/ssbc/ssb-msgs/pull/11","id":460620461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxNzE1Nzg1","number":11,"title":"fix #10: don't assume obj prop in indexLinks","user":{"login":"soapdog","id":23247,"node_id":"MDQ6VXNlcjIzMjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/23247?v=4","gravatar_id":"","url":"https://api.github.com/users/soapdog","html_url":"https://github.com/soapdog","followers_url":"https://api.github.com/users/soapdog/followers","following_url":"https://api.github.com/users/soapdog/following{/other_user}","gists_url":"https://api.github.com/users/soapdog/gists{/gist_id}","starred_url":"https://api.github.com/users/soapdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soapdog/subscriptions","organizations_url":"https://api.github.com/users/soapdog/orgs","repos_url":"https://api.github.com/users/soapdog/repos","events_url":"https://api.github.com/users/soapdog/events{/privacy}","received_events_url":"https://api.github.com/users/soapdog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-06-25T20:18:50Z","updated_at":"2019-07-02T13:06:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ssbc/ssb-msgs/pulls/11","html_url":"https://github.com/ssbc/ssb-msgs/pull/11","diff_url":"https://github.com/ssbc/ssb-msgs/pull/11.diff","patch_url":"https://github.com/ssbc/ssb-msgs/pull/11.patch"},"body":"After breaking my _sbot_ five times today I came to realize that having a broken _mentions_ array in a post will prevent _sbot_ from starting. This was narrowed down to this module assuming all links in `indexLinks` were either a string or an object with a `link` property. I've added code to ignore items that are not these two cases."},"comment":{"url":"https://api.github.com/repos/ssbc/ssb-msgs/issues/comments/507668220","html_url":"https://github.com/ssbc/ssb-msgs/pull/11#issuecomment-507668220","issue_url":"https://api.github.com/repos/ssbc/ssb-msgs/issues/11","id":507668220,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNzY2ODIyMA==","user":{"login":"HendrikPetertje","id":3583395,"node_id":"MDQ6VXNlcjM1ODMzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3583395?v=4","gravatar_id":"","url":"https://api.github.com/users/HendrikPetertje","html_url":"https://github.com/HendrikPetertje","followers_url":"https://api.github.com/users/HendrikPetertje/followers","following_url":"https://api.github.com/users/HendrikPetertje/following{/other_user}","gists_url":"https://api.github.com/users/HendrikPetertje/gists{/gist_id}","starred_url":"https://api.github.com/users/HendrikPetertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HendrikPetertje/subscriptions","organizations_url":"https://api.github.com/users/HendrikPetertje/orgs","repos_url":"https://api.github.com/users/HendrikPetertje/repos","events_url":"https://api.github.com/users/HendrikPetertje/events{/privacy}","received_events_url":"https://api.github.com/users/HendrikPetertje/received_events","type":"User","site_admin":false},"created_at":"2019-07-02T13:06:09Z","updated_at":"2019-07-02T13:06:09Z","author_association":"NONE","body":"Your last thingy seems to work! I don't really like the fix though. it's basically a guard clause after a type-check. would be nice to do that the other way around. \r\n\r\nThat plus, this is mentions, but this kind of stuff could pretty much happen everywhere right? It would be kind of nice if we could do some kind of check on the \"quality\" in either `ssb-db` or `pull-write`. I probably have not that big of a say here, so feel free to ignore my last comment.\r\n\r\n---\r\nAfter testing, I made sure that the broken message can't be relayed through my pub (I removed the feed and blocked the author) all other pubs would pretty much just stop working when they try to download the message. These 2 steps should for now make sure that the issue doesn't spread to fast (unless people wifi-share and p2p directly with each other), allowing the big clients to update their code-bases before we allow this specific broken message to walk through the network freely."}}
{"actor":{"display_login":"HendrikPetertje"}}