{"action":"created","issue":{"url":"https://api.github.com/repos/toggl/mobileapp/issues/6501","repository_url":"https://api.github.com/repos/toggl/mobileapp","labels_url":"https://api.github.com/repos/toggl/mobileapp/issues/6501/labels{/name}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/6501/comments","events_url":"https://api.github.com/repos/toggl/mobileapp/issues/6501/events","html_url":"https://github.com/toggl/mobileapp/issues/6501","id":519960169,"node_id":"MDU6SXNzdWU1MTk5NjAxNjk=","number":6501,"title":"Null reference in AppDelegate.OpenUrl","user":{"login":"juanlaube","id":8163330,"node_id":"MDQ6VXNlcjgxNjMzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8163330?v=4","gravatar_id":"","url":"https://api.github.com/users/juanlaube","html_url":"https://github.com/juanlaube","followers_url":"https://api.github.com/users/juanlaube/followers","following_url":"https://api.github.com/users/juanlaube/following{/other_user}","gists_url":"https://api.github.com/users/juanlaube/gists{/gist_id}","starred_url":"https://api.github.com/users/juanlaube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanlaube/subscriptions","organizations_url":"https://api.github.com/users/juanlaube/orgs","repos_url":"https://api.github.com/users/juanlaube/repos","events_url":"https://api.github.com/users/juanlaube/events{/privacy}","received_events_url":"https://api.github.com/users/juanlaube/received_events","type":"User","site_admin":false},"labels":[{"id":837460877,"node_id":"MDU6TGFiZWw4Mzc0NjA4Nzc=","url":"https://api.github.com/repos/toggl/mobileapp/labels/crash","name":"crash","color":"ee0701","default":false},{"id":773208974,"node_id":"MDU6TGFiZWw3NzMyMDg5NzQ=","url":"https://api.github.com/repos/toggl/mobileapp/labels/ios","name":"ios","color":"51bdf7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-11-08T11:20:05Z","updated_at":"2019-11-08T11:50:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## 💥 Crash Report\r\nIt's the most common crash in iOS 2.6, based on the stacktrace, it seems to be related with Google login.\r\n\r\n### 👥 Impact\r\nSo far it happened 7 times to 3 users, with these numbers, it's not worth to do a hotfix, but would be awesome some fix it for future releases.\r\n\r\n### 🔗 Context\r\nSimilar to [this](https://github.com/toggl/mobileapp/issues/5620) issue that was closed because the crash didn't happen anymore.\r\n\r\n### 🛰 Link\r\nhttps://appcenter.ms/orgs/Toggl/apps/Toggl-iOS/crashes/errors/3332260094u/overview\r\n\r\n### 📝  Exception & Stack Trace\r\n`AppDelegate.OpenUrl (UIKit.UIApplication app, Foundation.NSUrl url, Foundation.NSDictionary options)\r\nSIGABRT: Value cannot be null. Parameter name: sourceApplication`\r\n```cs\r\nSignIn.HandleUrl (Foundation.NSUrl url, System.String sourceApplication, Foundation.NSObject annotation)\r\nAppDelegate.OpenUrl (UIKit.UIApplication app, Foundation.NSUrl url, Foundation.NSDictionary options)\r\n(wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)\r\nUIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate)\r\nUIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName)\r\nApplication.Main (System.String[] args)\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/toggl/mobileapp/issues/comments/551655637","html_url":"https://github.com/toggl/mobileapp/issues/6501#issuecomment-551655637","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/6501","id":551655637,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MTY1NTYzNw==","user":{"login":"juanlaube","id":8163330,"node_id":"MDQ6VXNlcjgxNjMzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8163330?v=4","gravatar_id":"","url":"https://api.github.com/users/juanlaube","html_url":"https://github.com/juanlaube","followers_url":"https://api.github.com/users/juanlaube/followers","following_url":"https://api.github.com/users/juanlaube/following{/other_user}","gists_url":"https://api.github.com/users/juanlaube/gists{/gist_id}","starred_url":"https://api.github.com/users/juanlaube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanlaube/subscriptions","organizations_url":"https://api.github.com/users/juanlaube/orgs","repos_url":"https://api.github.com/users/juanlaube/repos","events_url":"https://api.github.com/users/juanlaube/events{/privacy}","received_events_url":"https://api.github.com/users/juanlaube/received_events","type":"User","site_admin":false},"created_at":"2019-11-08T11:50:58Z","updated_at":"2019-11-08T11:50:58Z","author_association":"CONTRIBUTOR","body":"Also it looks like the `HandleUrl` method in the Google Sign In SDK dropped all the parameters except for the url, see the reference [here](https://developers.google.com/identity/sign-in/ios/reference/Classes/GIDSignIn#-handleurl:), I'm not sure if that's available in Xamarin yet though."}}
{"actor":{"display_login":"juanlaube"}}