{"action":"created","comment":{"url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/comments/258202353","pull_request_review_id":205417973,"id":258202353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODIwMjM1Mw==","diff_hunk":"@@ -47,31 +47,30 @@ Set $FILECOIN_PARAMETER_CACHE to specify parameter directory. Defaults to '{}'\n \n     if let Some(matches) = matches.subcommand_matches(\"publish\") {\n         let mut new_parameter_map: ParameterMap = HashMap::new();\n-        let parameters = if matches.is_present(\"all\") {\n+        let parameter_ids = if matches.is_present(\"all\") {\n             get_local_parameter_ids()\n         } else {\n             choose_local_parameter_ids()\n         }\n         .expect(ERROR_PARAMETERS_LOCAL);\n \n-        if parameters.len() > 0 {\n+        if parameter_ids.len() > 0 {\n             println!(\"publishing parameters\");\n \n-            for parameter in parameters.iter() {\n-                println!(\"publishing '{}'...\", parameter);\n+            for parameter_id in parameter_ids.iter() {","path":"filecoin-proofs/src/bin/parampublish.rs","position":50,"original_position":18,"commit_id":"bfe7994b364b67a361748118282323e7f803a412","original_commit_id":"bfe7994b364b67a361748118282323e7f803a412","user":{"login":"dignifiedquire","id":790842,"node_id":"MDQ6VXNlcjc5MDg0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/790842?v=4","gravatar_id":"","url":"https://api.github.com/users/dignifiedquire","html_url":"https://github.com/dignifiedquire","followers_url":"https://api.github.com/users/dignifiedquire/followers","following_url":"https://api.github.com/users/dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/dignifiedquire/orgs","repos_url":"https://api.github.com/users/dignifiedquire/repos","events_url":"https://api.github.com/users/dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/dignifiedquire/received_events","type":"User","site_admin":false},"body":"if ypu use into_iter you get an owned string so you can use that to insert into the hashmap below","created_at":"2019-02-19T19:50:36Z","updated_at":"2019-02-19T19:51:45Z","html_url":"https://github.com/filecoin-project/rust-proofs/pull/483#discussion_r258202353","pull_request_url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/comments/258202353"},"html":{"href":"https://github.com/filecoin-project/rust-proofs/pull/483#discussion_r258202353"},"pull_request":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483","id":253538496,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNTM4NDk2","html_url":"https://github.com/filecoin-project/rust-proofs/pull/483","diff_url":"https://github.com/filecoin-project/rust-proofs/pull/483.diff","patch_url":"https://github.com/filecoin-project/rust-proofs/pull/483.patch","issue_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/483","number":483,"state":"open","locked":false,"title":"verify parameter integrity","user":{"login":"sidke","id":385877,"node_id":"MDQ6VXNlcjM4NTg3Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/385877?v=4","gravatar_id":"","url":"https://api.github.com/users/sidke","html_url":"https://github.com/sidke","followers_url":"https://api.github.com/users/sidke/followers","following_url":"https://api.github.com/users/sidke/following{/other_user}","gists_url":"https://api.github.com/users/sidke/gists{/gist_id}","starred_url":"https://api.github.com/users/sidke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidke/subscriptions","organizations_url":"https://api.github.com/users/sidke/orgs","repos_url":"https://api.github.com/users/sidke/repos","events_url":"https://api.github.com/users/sidke/events{/privacy}","received_events_url":"https://api.github.com/users/sidke/received_events","type":"User","site_admin":false},"body":"resolves https://github.com/filecoin-project/go-filecoin/issues/1925\r\n\r\nintroduces two things:\r\n1. less important, but useful is to pass a parameter pointing to the json file to use\r\n2. more important, generate a digest when publishing parameters, and checking fetched parameters against that digest\r\n\r\ncurrently, i opted to just say \"hey the data looks like it's corrupt please delete it and try fetching again\" because i didn't really want to touch/delete any of the parameter files with the tool\r\n\r\nthis approach can be backed out of if we want to use ipfs instead to verify cids and, ideally, also drop curling in favor of the ipfs cli","created_at":"2019-02-15T19:31:27Z","updated_at":"2019-02-19T19:51:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87dc05585c76694feff5f8644c8bbee582d52e5c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"laser","id":884507,"node_id":"MDQ6VXNlcjg4NDUwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/884507?v=4","gravatar_id":"","url":"https://api.github.com/users/laser","html_url":"https://github.com/laser","followers_url":"https://api.github.com/users/laser/followers","following_url":"https://api.github.com/users/laser/following{/other_user}","gists_url":"https://api.github.com/users/laser/gists{/gist_id}","starred_url":"https://api.github.com/users/laser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laser/subscriptions","organizations_url":"https://api.github.com/users/laser/orgs","repos_url":"https://api.github.com/users/laser/repos","events_url":"https://api.github.com/users/laser/events{/privacy}","received_events_url":"https://api.github.com/users/laser/received_events","type":"User","site_admin":false},{"login":"porcuquine","id":1746729,"node_id":"MDQ6VXNlcjE3NDY3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1746729?v=4","gravatar_id":"","url":"https://api.github.com/users/porcuquine","html_url":"https://github.com/porcuquine","followers_url":"https://api.github.com/users/porcuquine/followers","following_url":"https://api.github.com/users/porcuquine/following{/other_user}","gists_url":"https://api.github.com/users/porcuquine/gists{/gist_id}","starred_url":"https://api.github.com/users/porcuquine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porcuquine/subscriptions","organizations_url":"https://api.github.com/users/porcuquine/orgs","repos_url":"https://api.github.com/users/porcuquine/repos","events_url":"https://api.github.com/users/porcuquine/events{/privacy}","received_events_url":"https://api.github.com/users/porcuquine/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483/commits","review_comments_url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483/comments","review_comment_url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/483/comments","statuses_url":"https://api.github.com/repos/filecoin-project/rust-proofs/statuses/bfe7994b364b67a361748118282323e7f803a412","head":{"label":"filecoin-project:feat/paramfetch-verify-1925","ref":"feat/paramfetch-verify-1925","sha":"bfe7994b364b67a361748118282323e7f803a412","user":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"repo":{"id":135468185,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NjgxODU=","name":"rust-proofs","full_name":"filecoin-project/rust-proofs","private":false,"owner":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/filecoin-project/rust-proofs","description":"Proofs for Filecoin in Rust","fork":false,"url":"https://api.github.com/repos/filecoin-project/rust-proofs","forks_url":"https://api.github.com/repos/filecoin-project/rust-proofs/forks","keys_url":"https://api.github.com/repos/filecoin-project/rust-proofs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filecoin-project/rust-proofs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filecoin-project/rust-proofs/teams","hooks_url":"https://api.github.com/repos/filecoin-project/rust-proofs/hooks","issue_events_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/events{/number}","events_url":"https://api.github.com/repos/filecoin-project/rust-proofs/events","assignees_url":"https://api.github.com/repos/filecoin-project/rust-proofs/assignees{/user}","branches_url":"https://api.github.com/repos/filecoin-project/rust-proofs/branches{/branch}","tags_url":"https://api.github.com/repos/filecoin-project/rust-proofs/tags","blobs_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/refs{/sha}","trees_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filecoin-project/rust-proofs/statuses/{sha}","languages_url":"https://api.github.com/repos/filecoin-project/rust-proofs/languages","stargazers_url":"https://api.github.com/repos/filecoin-project/rust-proofs/stargazers","contributors_url":"https://api.github.com/repos/filecoin-project/rust-proofs/contributors","subscribers_url":"https://api.github.com/repos/filecoin-project/rust-proofs/subscribers","subscription_url":"https://api.github.com/repos/filecoin-project/rust-proofs/subscription","commits_url":"https://api.github.com/repos/filecoin-project/rust-proofs/commits{/sha}","git_commits_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/commits{/sha}","comments_url":"https://api.github.com/repos/filecoin-project/rust-proofs/comments{/number}","issue_comment_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/comments{/number}","contents_url":"https://api.github.com/repos/filecoin-project/rust-proofs/contents/{+path}","compare_url":"https://api.github.com/repos/filecoin-project/rust-proofs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filecoin-project/rust-proofs/merges","archive_url":"https://api.github.com/repos/filecoin-project/rust-proofs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filecoin-project/rust-proofs/downloads","issues_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues{/number}","pulls_url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls{/number}","milestones_url":"https://api.github.com/repos/filecoin-project/rust-proofs/milestones{/number}","notifications_url":"https://api.github.com/repos/filecoin-project/rust-proofs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filecoin-project/rust-proofs/labels{/name}","releases_url":"https://api.github.com/repos/filecoin-project/rust-proofs/releases{/id}","deployments_url":"https://api.github.com/repos/filecoin-project/rust-proofs/deployments","created_at":"2018-05-30T16:12:53Z","updated_at":"2019-02-19T13:48:25Z","pushed_at":"2019-02-19T19:46:41Z","git_url":"git://github.com/filecoin-project/rust-proofs.git","ssh_url":"git@github.com:filecoin-project/rust-proofs.git","clone_url":"https://github.com/filecoin-project/rust-proofs.git","svn_url":"https://github.com/filecoin-project/rust-proofs","homepage":"","size":1376,"stargazers_count":73,"watchers_count":73,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":85,"watchers":73,"default_branch":"master"}},"base":{"label":"filecoin-project:master","ref":"master","sha":"90bb0445709a7ac38fefbeb100ed58e86d28f84b","user":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"repo":{"id":135468185,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NjgxODU=","name":"rust-proofs","full_name":"filecoin-project/rust-proofs","private":false,"owner":{"login":"filecoin-project","id":22014611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDE0NjEx","avatar_url":"https://avatars0.githubusercontent.com/u/22014611?v=4","gravatar_id":"","url":"https://api.github.com/users/filecoin-project","html_url":"https://github.com/filecoin-project","followers_url":"https://api.github.com/users/filecoin-project/followers","following_url":"https://api.github.com/users/filecoin-project/following{/other_user}","gists_url":"https://api.github.com/users/filecoin-project/gists{/gist_id}","starred_url":"https://api.github.com/users/filecoin-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filecoin-project/subscriptions","organizations_url":"https://api.github.com/users/filecoin-project/orgs","repos_url":"https://api.github.com/users/filecoin-project/repos","events_url":"https://api.github.com/users/filecoin-project/events{/privacy}","received_events_url":"https://api.github.com/users/filecoin-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/filecoin-project/rust-proofs","description":"Proofs for Filecoin in Rust","fork":false,"url":"https://api.github.com/repos/filecoin-project/rust-proofs","forks_url":"https://api.github.com/repos/filecoin-project/rust-proofs/forks","keys_url":"https://api.github.com/repos/filecoin-project/rust-proofs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filecoin-project/rust-proofs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filecoin-project/rust-proofs/teams","hooks_url":"https://api.github.com/repos/filecoin-project/rust-proofs/hooks","issue_events_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/events{/number}","events_url":"https://api.github.com/repos/filecoin-project/rust-proofs/events","assignees_url":"https://api.github.com/repos/filecoin-project/rust-proofs/assignees{/user}","branches_url":"https://api.github.com/repos/filecoin-project/rust-proofs/branches{/branch}","tags_url":"https://api.github.com/repos/filecoin-project/rust-proofs/tags","blobs_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/refs{/sha}","trees_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filecoin-project/rust-proofs/statuses/{sha}","languages_url":"https://api.github.com/repos/filecoin-project/rust-proofs/languages","stargazers_url":"https://api.github.com/repos/filecoin-project/rust-proofs/stargazers","contributors_url":"https://api.github.com/repos/filecoin-project/rust-proofs/contributors","subscribers_url":"https://api.github.com/repos/filecoin-project/rust-proofs/subscribers","subscription_url":"https://api.github.com/repos/filecoin-project/rust-proofs/subscription","commits_url":"https://api.github.com/repos/filecoin-project/rust-proofs/commits{/sha}","git_commits_url":"https://api.github.com/repos/filecoin-project/rust-proofs/git/commits{/sha}","comments_url":"https://api.github.com/repos/filecoin-project/rust-proofs/comments{/number}","issue_comment_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/comments{/number}","contents_url":"https://api.github.com/repos/filecoin-project/rust-proofs/contents/{+path}","compare_url":"https://api.github.com/repos/filecoin-project/rust-proofs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filecoin-project/rust-proofs/merges","archive_url":"https://api.github.com/repos/filecoin-project/rust-proofs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filecoin-project/rust-proofs/downloads","issues_url":"https://api.github.com/repos/filecoin-project/rust-proofs/issues{/number}","pulls_url":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls{/number}","milestones_url":"https://api.github.com/repos/filecoin-project/rust-proofs/milestones{/number}","notifications_url":"https://api.github.com/repos/filecoin-project/rust-proofs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filecoin-project/rust-proofs/labels{/name}","releases_url":"https://api.github.com/repos/filecoin-project/rust-proofs/releases{/id}","deployments_url":"https://api.github.com/repos/filecoin-project/rust-proofs/deployments","created_at":"2018-05-30T16:12:53Z","updated_at":"2019-02-19T13:48:25Z","pushed_at":"2019-02-19T19:46:41Z","git_url":"git://github.com/filecoin-project/rust-proofs.git","ssh_url":"git@github.com:filecoin-project/rust-proofs.git","clone_url":"https://github.com/filecoin-project/rust-proofs.git","svn_url":"https://github.com/filecoin-project/rust-proofs","homepage":"","size":1376,"stargazers_count":73,"watchers_count":73,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":85,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483"},"html":{"href":"https://github.com/filecoin-project/rust-proofs/pull/483"},"issue":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/483"},"comments":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/filecoin-project/rust-proofs/statuses/bfe7994b364b67a361748118282323e7f803a412"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dignifiedquire"}}