{"action":"created","comment":{"url":"https://api.github.com/repos/Versent/saml2aws/pulls/comments/334039164","pull_request_review_id":300750271,"id":334039164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDAzOTE2NA==","diff_hunk":"@@ -12,7 +12,7 @@ require (\n \tgithub.com/alecthomas/units v0.0.0-20190910110746-680d30ca3117 // indirect\n \tgithub.com/andybalholm/cascadia v1.0.0 // indirect\n \tgithub.com/aulanov/go.dbus v0.0.0-20150729231527-25c3068a42a0 // indirect\n-\tgithub.com/aws/aws-sdk-go v1.14.8\n+\tgithub.com/aws/aws-sdk-go v1.23.15","path":"go.mod","position":5,"original_position":5,"commit_id":"cabeca8522fb287c0ffbe44bd2e170d2e2219349","original_commit_id":"cabeca8522fb287c0ffbe44bd2e170d2e2219349","user":{"login":"kr3cj","id":4855618,"node_id":"MDQ6VXNlcjQ4NTU2MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/4855618?v=4","gravatar_id":"","url":"https://api.github.com/users/kr3cj","html_url":"https://github.com/kr3cj","followers_url":"https://api.github.com/users/kr3cj/followers","following_url":"https://api.github.com/users/kr3cj/following{/other_user}","gists_url":"https://api.github.com/users/kr3cj/gists{/gist_id}","starred_url":"https://api.github.com/users/kr3cj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kr3cj/subscriptions","organizations_url":"https://api.github.com/users/kr3cj/orgs","repos_url":"https://api.github.com/users/kr3cj/repos","events_url":"https://api.github.com/users/kr3cj/events{/privacy}","received_events_url":"https://api.github.com/users/kr3cj/received_events","type":"User","site_admin":false},"body":"For reference, `v1.14.8` was released in June of 2018 and `v1.23.15` was released last month.","created_at":"2019-10-11T15:07:45Z","updated_at":"2019-10-11T15:07:45Z","html_url":"https://github.com/Versent/saml2aws/pull/362#discussion_r334039164","pull_request_url":"https://api.github.com/repos/Versent/saml2aws/pulls/362","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Versent/saml2aws/pulls/comments/334039164"},"html":{"href":"https://github.com/Versent/saml2aws/pull/362#discussion_r334039164"},"pull_request":{"href":"https://api.github.com/repos/Versent/saml2aws/pulls/362"}},"in_reply_to_id":334037764},"pull_request":{"url":"https://api.github.com/repos/Versent/saml2aws/pulls/362","id":327240152,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MjQwMTUy","html_url":"https://github.com/Versent/saml2aws/pull/362","diff_url":"https://github.com/Versent/saml2aws/pull/362.diff","patch_url":"https://github.com/Versent/saml2aws/pull/362.patch","issue_url":"https://api.github.com/repos/Versent/saml2aws/issues/362","number":362,"state":"open","locked":false,"title":"Update exec to perform role assumption from profile.","user":{"login":"elementalvoid","id":156165,"node_id":"MDQ6VXNlcjE1NjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/156165?v=4","gravatar_id":"","url":"https://api.github.com/users/elementalvoid","html_url":"https://github.com/elementalvoid","followers_url":"https://api.github.com/users/elementalvoid/followers","following_url":"https://api.github.com/users/elementalvoid/following{/other_user}","gists_url":"https://api.github.com/users/elementalvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/elementalvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementalvoid/subscriptions","organizations_url":"https://api.github.com/users/elementalvoid/orgs","repos_url":"https://api.github.com/users/elementalvoid/repos","events_url":"https://api.github.com/users/elementalvoid/events{/privacy}","received_events_url":"https://api.github.com/users/elementalvoid/received_events","type":"User","site_admin":false},"body":"The method created by @85matthew worked for a large majority of tools\r\nbut we found that some don't properly utilize the AWS_PROFILE env var.\r\nIn particular the Sops tool has issues.\r\n\r\nThis update makes it such that saml2aws behaves more like some other\r\ntools in this space ([aws-vault](https://github.com/99designs/aws-vault) and [aws-okta](https://github.com/segmentio/aws-okta)). When the `--exec-profile`\r\nflag is specified saml2aws now performs the role assumption via the STS\r\nclient from the AWS SDK. This means it will now do multiple levels of\r\nrole assumption _before_ executing the given command. Because saml2aws\r\nis performing the assumption it no longer exports the AWS_PROFILE env\r\nvars and the credentials that it export are fully fledged credentials\r\nfor the target profile.\r\n\r\nBTW: @85matthew and I work together so this update doesn't break anything he was trying to achieve with #335.","created_at":"2019-10-11T14:56:06Z","updated_at":"2019-10-11T15:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88039f47297a39810a66e7d0a5bbae073214f3ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Versent/saml2aws/pulls/362/commits","review_comments_url":"https://api.github.com/repos/Versent/saml2aws/pulls/362/comments","review_comment_url":"https://api.github.com/repos/Versent/saml2aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Versent/saml2aws/issues/362/comments","statuses_url":"https://api.github.com/repos/Versent/saml2aws/statuses/cabeca8522fb287c0ffbe44bd2e170d2e2219349","head":{"label":"elementalvoid:role-assuption-from-profile","ref":"role-assuption-from-profile","sha":"cabeca8522fb287c0ffbe44bd2e170d2e2219349","user":{"login":"elementalvoid","id":156165,"node_id":"MDQ6VXNlcjE1NjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/156165?v=4","gravatar_id":"","url":"https://api.github.com/users/elementalvoid","html_url":"https://github.com/elementalvoid","followers_url":"https://api.github.com/users/elementalvoid/followers","following_url":"https://api.github.com/users/elementalvoid/following{/other_user}","gists_url":"https://api.github.com/users/elementalvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/elementalvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementalvoid/subscriptions","organizations_url":"https://api.github.com/users/elementalvoid/orgs","repos_url":"https://api.github.com/users/elementalvoid/repos","events_url":"https://api.github.com/users/elementalvoid/events{/privacy}","received_events_url":"https://api.github.com/users/elementalvoid/received_events","type":"User","site_admin":false},"repo":{"id":214261736,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQyNjE3MzY=","name":"saml2aws","full_name":"elementalvoid/saml2aws","private":false,"owner":{"login":"elementalvoid","id":156165,"node_id":"MDQ6VXNlcjE1NjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/156165?v=4","gravatar_id":"","url":"https://api.github.com/users/elementalvoid","html_url":"https://github.com/elementalvoid","followers_url":"https://api.github.com/users/elementalvoid/followers","following_url":"https://api.github.com/users/elementalvoid/following{/other_user}","gists_url":"https://api.github.com/users/elementalvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/elementalvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementalvoid/subscriptions","organizations_url":"https://api.github.com/users/elementalvoid/orgs","repos_url":"https://api.github.com/users/elementalvoid/repos","events_url":"https://api.github.com/users/elementalvoid/events{/privacy}","received_events_url":"https://api.github.com/users/elementalvoid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/elementalvoid/saml2aws","description":"CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP","fork":true,"url":"https://api.github.com/repos/elementalvoid/saml2aws","forks_url":"https://api.github.com/repos/elementalvoid/saml2aws/forks","keys_url":"https://api.github.com/repos/elementalvoid/saml2aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elementalvoid/saml2aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elementalvoid/saml2aws/teams","hooks_url":"https://api.github.com/repos/elementalvoid/saml2aws/hooks","issue_events_url":"https://api.github.com/repos/elementalvoid/saml2aws/issues/events{/number}","events_url":"https://api.github.com/repos/elementalvoid/saml2aws/events","assignees_url":"https://api.github.com/repos/elementalvoid/saml2aws/assignees{/user}","branches_url":"https://api.github.com/repos/elementalvoid/saml2aws/branches{/branch}","tags_url":"https://api.github.com/repos/elementalvoid/saml2aws/tags","blobs_url":"https://api.github.com/repos/elementalvoid/saml2aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elementalvoid/saml2aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elementalvoid/saml2aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/elementalvoid/saml2aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elementalvoid/saml2aws/statuses/{sha}","languages_url":"https://api.github.com/repos/elementalvoid/saml2aws/languages","stargazers_url":"https://api.github.com/repos/elementalvoid/saml2aws/stargazers","contributors_url":"https://api.github.com/repos/elementalvoid/saml2aws/contributors","subscribers_url":"https://api.github.com/repos/elementalvoid/saml2aws/subscribers","subscription_url":"https://api.github.com/repos/elementalvoid/saml2aws/subscription","commits_url":"https://api.github.com/repos/elementalvoid/saml2aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/elementalvoid/saml2aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/elementalvoid/saml2aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/elementalvoid/saml2aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/elementalvoid/saml2aws/contents/{+path}","compare_url":"https://api.github.com/repos/elementalvoid/saml2aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elementalvoid/saml2aws/merges","archive_url":"https://api.github.com/repos/elementalvoid/saml2aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elementalvoid/saml2aws/downloads","issues_url":"https://api.github.com/repos/elementalvoid/saml2aws/issues{/number}","pulls_url":"https://api.github.com/repos/elementalvoid/saml2aws/pulls{/number}","milestones_url":"https://api.github.com/repos/elementalvoid/saml2aws/milestones{/number}","notifications_url":"https://api.github.com/repos/elementalvoid/saml2aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elementalvoid/saml2aws/labels{/name}","releases_url":"https://api.github.com/repos/elementalvoid/saml2aws/releases{/id}","deployments_url":"https://api.github.com/repos/elementalvoid/saml2aws/deployments","created_at":"2019-10-10T18:54:25Z","updated_at":"2019-10-10T18:54:27Z","pushed_at":"2019-10-11T14:54:49Z","git_url":"git://github.com/elementalvoid/saml2aws.git","ssh_url":"git@github.com:elementalvoid/saml2aws.git","clone_url":"https://github.com/elementalvoid/saml2aws.git","svn_url":"https://github.com/elementalvoid/saml2aws","homepage":"https://github.com/Versent/saml2aws","size":8584,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Versent:master","ref":"master","sha":"66327734967befc8a12f668ff037f8b5fbdfb30d","user":{"login":"Versent","id":11023632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDIzNjMy","avatar_url":"https://avatars2.githubusercontent.com/u/11023632?v=4","gravatar_id":"","url":"https://api.github.com/users/Versent","html_url":"https://github.com/Versent","followers_url":"https://api.github.com/users/Versent/followers","following_url":"https://api.github.com/users/Versent/following{/other_user}","gists_url":"https://api.github.com/users/Versent/gists{/gist_id}","starred_url":"https://api.github.com/users/Versent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versent/subscriptions","organizations_url":"https://api.github.com/users/Versent/orgs","repos_url":"https://api.github.com/users/Versent/repos","events_url":"https://api.github.com/users/Versent/events{/privacy}","received_events_url":"https://api.github.com/users/Versent/received_events","type":"Organization","site_admin":false},"repo":{"id":67908757,"node_id":"MDEwOlJlcG9zaXRvcnk2NzkwODc1Nw==","name":"saml2aws","full_name":"Versent/saml2aws","private":false,"owner":{"login":"Versent","id":11023632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDIzNjMy","avatar_url":"https://avatars2.githubusercontent.com/u/11023632?v=4","gravatar_id":"","url":"https://api.github.com/users/Versent","html_url":"https://github.com/Versent","followers_url":"https://api.github.com/users/Versent/followers","following_url":"https://api.github.com/users/Versent/following{/other_user}","gists_url":"https://api.github.com/users/Versent/gists{/gist_id}","starred_url":"https://api.github.com/users/Versent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Versent/subscriptions","organizations_url":"https://api.github.com/users/Versent/orgs","repos_url":"https://api.github.com/users/Versent/repos","events_url":"https://api.github.com/users/Versent/events{/privacy}","received_events_url":"https://api.github.com/users/Versent/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Versent/saml2aws","description":"CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP","fork":false,"url":"https://api.github.com/repos/Versent/saml2aws","forks_url":"https://api.github.com/repos/Versent/saml2aws/forks","keys_url":"https://api.github.com/repos/Versent/saml2aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Versent/saml2aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Versent/saml2aws/teams","hooks_url":"https://api.github.com/repos/Versent/saml2aws/hooks","issue_events_url":"https://api.github.com/repos/Versent/saml2aws/issues/events{/number}","events_url":"https://api.github.com/repos/Versent/saml2aws/events","assignees_url":"https://api.github.com/repos/Versent/saml2aws/assignees{/user}","branches_url":"https://api.github.com/repos/Versent/saml2aws/branches{/branch}","tags_url":"https://api.github.com/repos/Versent/saml2aws/tags","blobs_url":"https://api.github.com/repos/Versent/saml2aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Versent/saml2aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Versent/saml2aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/Versent/saml2aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Versent/saml2aws/statuses/{sha}","languages_url":"https://api.github.com/repos/Versent/saml2aws/languages","stargazers_url":"https://api.github.com/repos/Versent/saml2aws/stargazers","contributors_url":"https://api.github.com/repos/Versent/saml2aws/contributors","subscribers_url":"https://api.github.com/repos/Versent/saml2aws/subscribers","subscription_url":"https://api.github.com/repos/Versent/saml2aws/subscription","commits_url":"https://api.github.com/repos/Versent/saml2aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/Versent/saml2aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/Versent/saml2aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/Versent/saml2aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/Versent/saml2aws/contents/{+path}","compare_url":"https://api.github.com/repos/Versent/saml2aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Versent/saml2aws/merges","archive_url":"https://api.github.com/repos/Versent/saml2aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Versent/saml2aws/downloads","issues_url":"https://api.github.com/repos/Versent/saml2aws/issues{/number}","pulls_url":"https://api.github.com/repos/Versent/saml2aws/pulls{/number}","milestones_url":"https://api.github.com/repos/Versent/saml2aws/milestones{/number}","notifications_url":"https://api.github.com/repos/Versent/saml2aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Versent/saml2aws/labels{/name}","releases_url":"https://api.github.com/repos/Versent/saml2aws/releases{/id}","deployments_url":"https://api.github.com/repos/Versent/saml2aws/deployments","created_at":"2016-09-11T03:53:15Z","updated_at":"2019-10-10T23:29:57Z","pushed_at":"2019-10-11T14:56:07Z","git_url":"git://github.com/Versent/saml2aws.git","ssh_url":"git@github.com:Versent/saml2aws.git","clone_url":"https://github.com/Versent/saml2aws.git","svn_url":"https://github.com/Versent/saml2aws","homepage":"https://github.com/Versent/saml2aws","size":8584,"stargazers_count":501,"watchers_count":501,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":166,"open_issues":112,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Versent/saml2aws/pulls/362"},"html":{"href":"https://github.com/Versent/saml2aws/pull/362"},"issue":{"href":"https://api.github.com/repos/Versent/saml2aws/issues/362"},"comments":{"href":"https://api.github.com/repos/Versent/saml2aws/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/Versent/saml2aws/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/Versent/saml2aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Versent/saml2aws/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/Versent/saml2aws/statuses/cabeca8522fb287c0ffbe44bd2e170d2e2219349"}},"author_association":"NONE"}}
{"actor":{"display_login":"kr3cj"}}