{"action":"closed","number":8468,"pull_request":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8468","id":282543408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyNTQzNDA4","html_url":"https://github.com/bazelbuild/bazel/pull/8468","diff_url":"https://github.com/bazelbuild/bazel/pull/8468.diff","patch_url":"https://github.com/bazelbuild/bazel/pull/8468.patch","issue_url":"https://api.github.com/repos/bazelbuild/bazel/issues/8468","number":8468,"state":"closed","locked":false,"title":"WIP: Windows: rewrite and move path normalization","user":{"login":"laszlocsomor","id":10532244,"node_id":"MDQ6VXNlcjEwNTMyMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"body":"Also move it to the JNI library.\r\n\r\nMotivation: the process creation logic (in the JNI\r\nlibrary) needs to support relative paths, and make\r\nthem absolute. Making a path absolute requires\r\nnormalizing the result.\r\n\r\nThe new implementation is also more efficient than\r\nthe old: the new stores only indices, not\r\nsubstrings, in the segment vector, and only\r\ncreates the substrings when creating the final\r\nstring. This way it creates at most as many\r\nsubstrings as the old code, and fewer when there\r\nare \"..\" segments, because it won't throw away the\r\nstring of the popped segment.\r\n","created_at":"2019-05-27T14:51:57Z","updated_at":"2019-05-28T06:36:34Z","closed_at":"2019-05-28T06:36:34Z","merged_at":null,"merge_commit_sha":"7b0d283774d20532fe8aa441a17f0af820cef107","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":323761238,"node_id":"MDU6TGFiZWwzMjM3NjEyMzg=","url":"https://api.github.com/repos/bazelbuild/bazel/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8468/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8468/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/issues/8468/comments","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/cee06084713ae7d009aeb01585a61c0d77b9db78","head":{"label":"laszlocsomor:norm","ref":"norm","sha":"cee06084713ae7d009aeb01585a61c0d77b9db78","user":{"login":"laszlocsomor","id":10532244,"node_id":"MDQ6VXNlcjEwNTMyMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"repo":{"id":123130698,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMxMzA2OTg=","name":"bazel","full_name":"laszlocsomor/bazel","private":false,"owner":{"login":"laszlocsomor","id":10532244,"node_id":"MDQ6VXNlcjEwNTMyMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/laszlocsomor/bazel","description":"a fast, scalable, multi-language and extensible build system","fork":true,"url":"https://api.github.com/repos/laszlocsomor/bazel","forks_url":"https://api.github.com/repos/laszlocsomor/bazel/forks","keys_url":"https://api.github.com/repos/laszlocsomor/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laszlocsomor/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laszlocsomor/bazel/teams","hooks_url":"https://api.github.com/repos/laszlocsomor/bazel/hooks","issue_events_url":"https://api.github.com/repos/laszlocsomor/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/laszlocsomor/bazel/events","assignees_url":"https://api.github.com/repos/laszlocsomor/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/laszlocsomor/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/laszlocsomor/bazel/tags","blobs_url":"https://api.github.com/repos/laszlocsomor/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laszlocsomor/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laszlocsomor/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/laszlocsomor/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laszlocsomor/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/laszlocsomor/bazel/languages","stargazers_url":"https://api.github.com/repos/laszlocsomor/bazel/stargazers","contributors_url":"https://api.github.com/repos/laszlocsomor/bazel/contributors","subscribers_url":"https://api.github.com/repos/laszlocsomor/bazel/subscribers","subscription_url":"https://api.github.com/repos/laszlocsomor/bazel/subscription","commits_url":"https://api.github.com/repos/laszlocsomor/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/laszlocsomor/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/laszlocsomor/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/laszlocsomor/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/laszlocsomor/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/laszlocsomor/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laszlocsomor/bazel/merges","archive_url":"https://api.github.com/repos/laszlocsomor/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laszlocsomor/bazel/downloads","issues_url":"https://api.github.com/repos/laszlocsomor/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/laszlocsomor/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/laszlocsomor/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/laszlocsomor/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laszlocsomor/bazel/labels{/name}","releases_url":"https://api.github.com/repos/laszlocsomor/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/laszlocsomor/bazel/deployments","created_at":"2018-02-27T13:09:26Z","updated_at":"2019-02-13T07:31:05Z","pushed_at":"2019-05-27T14:50:34Z","git_url":"git://github.com/laszlocsomor/bazel.git","ssh_url":"git@github.com:laszlocsomor/bazel.git","clone_url":"https://github.com/laszlocsomor/bazel.git","svn_url":"https://github.com/laszlocsomor/bazel","homepage":"https://bazel.build","size":655422,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"184ecbf34b9c7ea4d321d9d97b5662343187f431","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":20773773,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3Mzc3Mw==","name":"bazel","full_name":"bazelbuild/bazel","private":false,"owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bazelbuild/bazel","description":"a fast, scalable, multi-language and extensible build system","fork":false,"url":"https://api.github.com/repos/bazelbuild/bazel","forks_url":"https://api.github.com/repos/bazelbuild/bazel/forks","keys_url":"https://api.github.com/repos/bazelbuild/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/bazel/teams","hooks_url":"https://api.github.com/repos/bazelbuild/bazel/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/bazel/events","assignees_url":"https://api.github.com/repos/bazelbuild/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/bazel/tags","blobs_url":"https://api.github.com/repos/bazelbuild/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/bazel/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/bazel/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/bazel/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/bazel/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/bazel/subscription","commits_url":"https://api.github.com/repos/bazelbuild/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/bazel/merges","archive_url":"https://api.github.com/repos/bazelbuild/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/bazel/downloads","issues_url":"https://api.github.com/repos/bazelbuild/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/bazel/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/bazel/deployments","created_at":"2014-06-12T16:00:38Z","updated_at":"2019-05-28T06:01:55Z","pushed_at":"2019-05-27T18:43:31Z","git_url":"git://github.com/bazelbuild/bazel.git","ssh_url":"git@github.com:bazelbuild/bazel.git","clone_url":"https://github.com/bazelbuild/bazel.git","svn_url":"https://github.com/bazelbuild/bazel","homepage":"https://bazel.build","size":659031,"stargazers_count":12037,"watchers_count":12037,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1967,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1865,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1967,"open_issues":1865,"watchers":12037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8468"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/8468"},"issue":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/8468"},"comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/8468/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8468/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8468/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/bazel/statuses/cee06084713ae7d009aeb01585a61c0d77b9db78"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":213,"deletions":239,"changed_files":8}}
{"actor":{"display_login":"laszlocsomor"}}