{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12720","repository_url":"https://api.github.com/repos/mattermost/mattermost-server","labels_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12720/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12720/comments","events_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12720/events","html_url":"https://github.com/mattermost/mattermost-server/pull/12720","id":505351654,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2ODAxNzgx","number":12720,"title":"Migrate tests from mfa_test.go to use testify","user":{"login":"phillipahereza","id":13383422,"node_id":"MDQ6VXNlcjEzMzgzNDIy","avatar_url":"https://avatars2.githubusercontent.com/u/13383422?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipahereza","html_url":"https://github.com/phillipahereza","followers_url":"https://api.github.com/users/phillipahereza/followers","following_url":"https://api.github.com/users/phillipahereza/following{/other_user}","gists_url":"https://api.github.com/users/phillipahereza/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipahereza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipahereza/subscriptions","organizations_url":"https://api.github.com/users/phillipahereza/orgs","repos_url":"https://api.github.com/users/phillipahereza/repos","events_url":"https://api.github.com/users/phillipahereza/events{/privacy}","received_events_url":"https://api.github.com/users/phillipahereza/received_events","type":"User","site_admin":false},"labels":[{"id":250214574,"node_id":"MDU6TGFiZWwyNTAyMTQ1NzQ=","url":"https://api.github.com/repos/mattermost/mattermost-server/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false},{"id":567165656,"node_id":"MDU6TGFiZWw1NjcxNjU2NTY=","url":"https://api.github.com/repos/mattermost/mattermost-server/labels/Tests/Not%20Needed","name":"Tests/Not Needed","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-server/milestones/54","html_url":"https://github.com/mattermost/mattermost-server/milestone/54","labels_url":"https://api.github.com/repos/mattermost/mattermost-server/milestones/54/labels","id":4623842,"node_id":"MDk6TWlsZXN0b25lNDYyMzg0Mg==","number":54,"title":"v5.18.0","description":"","creator":{"login":"hanzei","id":16541325,"node_id":"MDQ6VXNlcjE2NTQxMzI1","avatar_url":"https://avatars0.githubusercontent.com/u/16541325?v=4","gravatar_id":"","url":"https://api.github.com/users/hanzei","html_url":"https://github.com/hanzei","followers_url":"https://api.github.com/users/hanzei/followers","following_url":"https://api.github.com/users/hanzei/following{/other_user}","gists_url":"https://api.github.com/users/hanzei/gists{/gist_id}","starred_url":"https://api.github.com/users/hanzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanzei/subscriptions","organizations_url":"https://api.github.com/users/hanzei/orgs","repos_url":"https://api.github.com/users/hanzei/repos","events_url":"https://api.github.com/users/hanzei/events{/privacy}","received_events_url":"https://api.github.com/users/hanzei/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":89,"state":"open","created_at":"2019-09-03T08:23:59Z","updated_at":"2019-10-11T10:17:23Z","due_on":"2019-12-16T08:00:00Z","closed_at":null},"comments":1,"created_at":"2019-10-10T15:36:06Z","updated_at":"2019-10-11T10:22:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12720","html_url":"https://github.com/mattermost/mattermost-server/pull/12720","diff_url":"https://github.com/mattermost/mattermost-server/pull/12720.diff","patch_url":"https://github.com/mattermost/mattermost-server/pull/12720.patch"},"body":"<!-- Thank you for contributing a pull request! Here are a few tips to help you:\r\n\r\n1. If this is your first contribution, make sure you've read the Contribution Checklist https://developers.mattermost.com/contribute/getting-started/contribution-checklist/\r\n2. Read our blog post about \"Submitting Great PRs\" https://developers.mattermost.com/blog/2019-01-24-submitting-great-prs\r\n3. Take a look at other repository specific documentation at https://developers.mattermost.com/contribute\r\n-->\r\n\r\n#### Summary\r\nMigrate tests from `services/mfa/mfa_test.go` to use testify\r\n<!--\r\nA description of what this pull request does.\r\n-->\r\n\r\n#### Ticket Link\r\n<!--\r\nIf this pull request addresses a Help Wanted ticket, please link the relevant GitHub issue, e.g.\r\n\r\n  Fixes https://github.com/mattermost/mattermost-server/issues/XXXXX\r\n\r\nOtherwise, link the JIRA ticket.\r\n-->\r\n[Jira Ticket](https://mattermost.atlassian.net/browse/MM-19347)\r\n\r\nFixes https://github.com/mattermost/mattermost-server/issues/12414\r\n"},"comment":{"url":"https://api.github.com/repos/mattermost/mattermost-server/issues/comments/541007903","html_url":"https://github.com/mattermost/mattermost-server/pull/12720#issuecomment-541007903","issue_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12720","id":541007903,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MTAwNzkwMw==","user":{"login":"jespino","id":290303,"node_id":"MDQ6VXNlcjI5MDMwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/290303?v=4","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"created_at":"2019-10-11T10:22:19Z","updated_at":"2019-10-11T10:22:19Z","author_association":"MEMBER","body":"@phillipahereza Probably is a flaky test that we need to check, I'm rerunning the tests anyway."}}
{"actor":{"display_login":"jespino"}}