{"action":"created","comment":{"url":"https://api.github.com/repos/teamleadercrm/api/pulls/comments/277644666","pull_request_review_id":229509281,"id":277644666,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzY0NDY2Ng==","diff_hunk":"@@ -51,6 +51,10 @@ Get a list of all users.\n         + filter (object, optional)\n             + ids: `cb8da52a-ce89-4bf6-8f7e-8ee6cb85e3b5`,`f8a57a6f-dd1e-41a3-b8d3-428663f1d09e` (array[string], optional)\n             + term: `John` (string, optional) - Filters on first name, last name and email\n+            + status: `all` (enum[string], optional) - Filters on status\n+                + Members\n+                    + all - Filters on all active and deactivated users","path":"src/01-general/users.apib","position":6,"original_position":6,"commit_id":"0a10ff04cca03c2cfaa5c346837cdb1e9b9c3f25","original_commit_id":"0a10ff04cca03c2cfaa5c346837cdb1e9b9c3f25","user":{"login":"dcsg","id":744921,"node_id":"MDQ6VXNlcjc0NDkyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/744921?v=4","gravatar_id":"","url":"https://api.github.com/users/dcsg","html_url":"https://github.com/dcsg","followers_url":"https://api.github.com/users/dcsg/followers","following_url":"https://api.github.com/users/dcsg/following{/other_user}","gists_url":"https://api.github.com/users/dcsg/gists{/gist_id}","starred_url":"https://api.github.com/users/dcsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcsg/subscriptions","organizations_url":"https://api.github.com/users/dcsg/orgs","repos_url":"https://api.github.com/users/dcsg/repos","events_url":"https://api.github.com/users/dcsg/events{/privacy}","received_events_url":"https://api.github.com/users/dcsg/received_events","type":"User","site_admin":false},"body":"PP: I believe `all` does not make much sense because IMO filtering all is the same as not using this filter at all.","created_at":"2019-04-23T12:10:30Z","updated_at":"2019-04-23T12:10:38Z","html_url":"https://github.com/teamleadercrm/api/pull/367#discussion_r277644666","pull_request_url":"https://api.github.com/repos/teamleadercrm/api/pulls/367","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/comments/277644666"},"html":{"href":"https://github.com/teamleadercrm/api/pull/367#discussion_r277644666"},"pull_request":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/teamleadercrm/api/pulls/367","id":272700097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyNzAwMDk3","html_url":"https://github.com/teamleadercrm/api/pull/367","diff_url":"https://github.com/teamleadercrm/api/pull/367.diff","patch_url":"https://github.com/teamleadercrm/api/pull/367.patch","issue_url":"https://api.github.com/repos/teamleadercrm/api/issues/367","number":367,"state":"open","locked":false,"title":"Add a filter status on users.list","user":{"login":"mrtus","id":8998239,"node_id":"MDQ6VXNlcjg5OTgyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8998239?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtus","html_url":"https://github.com/mrtus","followers_url":"https://api.github.com/users/mrtus/followers","following_url":"https://api.github.com/users/mrtus/following{/other_user}","gists_url":"https://api.github.com/users/mrtus/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtus/subscriptions","organizations_url":"https://api.github.com/users/mrtus/orgs","repos_url":"https://api.github.com/users/mrtus/repos","events_url":"https://api.github.com/users/mrtus/events{/privacy}","received_events_url":"https://api.github.com/users/mrtus/received_events","type":"User","site_admin":false},"body":"To be able to implement the inviting of users and the future of unique email addresses. We first need to be able to filter on all users to find if an email is already used or not. This will be the first step in doing so.\r\n\r\nIn a follow-up a filter `email` will be added.\r\n\r\nNot sure yet how we would show the status in the response though.\r\n\r\nDo we show the status as an enum:\r\n```\r\n{\r\n    \"status\": \"active|deactivated|...inactive\"\r\n}\r\n```\r\nOr do we show it as a boolean:\r\n```\r\n{\r\n    \"active\": true\r\n}\r\n```","created_at":"2019-04-23T11:59:23Z","updated_at":"2019-04-23T12:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"debc3d7723ddc72af3da99e7977e5285329a86ae","assignee":{"login":"mrtus","id":8998239,"node_id":"MDQ6VXNlcjg5OTgyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8998239?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtus","html_url":"https://github.com/mrtus","followers_url":"https://api.github.com/users/mrtus/followers","following_url":"https://api.github.com/users/mrtus/following{/other_user}","gists_url":"https://api.github.com/users/mrtus/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtus/subscriptions","organizations_url":"https://api.github.com/users/mrtus/orgs","repos_url":"https://api.github.com/users/mrtus/repos","events_url":"https://api.github.com/users/mrtus/events{/privacy}","received_events_url":"https://api.github.com/users/mrtus/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrtus","id":8998239,"node_id":"MDQ6VXNlcjg5OTgyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8998239?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtus","html_url":"https://github.com/mrtus","followers_url":"https://api.github.com/users/mrtus/followers","following_url":"https://api.github.com/users/mrtus/following{/other_user}","gists_url":"https://api.github.com/users/mrtus/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtus/subscriptions","organizations_url":"https://api.github.com/users/mrtus/orgs","repos_url":"https://api.github.com/users/mrtus/repos","events_url":"https://api.github.com/users/mrtus/events{/privacy}","received_events_url":"https://api.github.com/users/mrtus/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jenssegers","id":194377,"node_id":"MDQ6VXNlcjE5NDM3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/194377?v=4","gravatar_id":"","url":"https://api.github.com/users/jenssegers","html_url":"https://github.com/jenssegers","followers_url":"https://api.github.com/users/jenssegers/followers","following_url":"https://api.github.com/users/jenssegers/following{/other_user}","gists_url":"https://api.github.com/users/jenssegers/gists{/gist_id}","starred_url":"https://api.github.com/users/jenssegers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenssegers/subscriptions","organizations_url":"https://api.github.com/users/jenssegers/orgs","repos_url":"https://api.github.com/users/jenssegers/repos","events_url":"https://api.github.com/users/jenssegers/events{/privacy}","received_events_url":"https://api.github.com/users/jenssegers/received_events","type":"User","site_admin":false},{"login":"stivni","id":1628429,"node_id":"MDQ6VXNlcjE2Mjg0Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1628429?v=4","gravatar_id":"","url":"https://api.github.com/users/stivni","html_url":"https://github.com/stivni","followers_url":"https://api.github.com/users/stivni/followers","following_url":"https://api.github.com/users/stivni/following{/other_user}","gists_url":"https://api.github.com/users/stivni/gists{/gist_id}","starred_url":"https://api.github.com/users/stivni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stivni/subscriptions","organizations_url":"https://api.github.com/users/stivni/orgs","repos_url":"https://api.github.com/users/stivni/repos","events_url":"https://api.github.com/users/stivni/events{/privacy}","received_events_url":"https://api.github.com/users/stivni/received_events","type":"User","site_admin":false},{"login":"rathesDot","id":6367520,"node_id":"MDQ6VXNlcjYzNjc1MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6367520?v=4","gravatar_id":"","url":"https://api.github.com/users/rathesDot","html_url":"https://github.com/rathesDot","followers_url":"https://api.github.com/users/rathesDot/followers","following_url":"https://api.github.com/users/rathesDot/following{/other_user}","gists_url":"https://api.github.com/users/rathesDot/gists{/gist_id}","starred_url":"https://api.github.com/users/rathesDot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathesDot/subscriptions","organizations_url":"https://api.github.com/users/rathesDot/orgs","repos_url":"https://api.github.com/users/rathesDot/repos","events_url":"https://api.github.com/users/rathesDot/events{/privacy}","received_events_url":"https://api.github.com/users/rathesDot/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":755650047,"node_id":"MDU6TGFiZWw3NTU2NTAwNDc=","url":"https://api.github.com/repos/teamleadercrm/api/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/teamleadercrm/api/pulls/367/commits","review_comments_url":"https://api.github.com/repos/teamleadercrm/api/pulls/367/comments","review_comment_url":"https://api.github.com/repos/teamleadercrm/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamleadercrm/api/issues/367/comments","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/0a10ff04cca03c2cfaa5c346837cdb1e9b9c3f25","head":{"label":"teamleadercrm:feature/users.list-status-filter","ref":"feature/users.list-status-filter","sha":"0a10ff04cca03c2cfaa5c346837cdb1e9b9c3f25","user":{"login":"teamleadercrm","id":19797966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk3OTY2","avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"repo":{"id":111382889,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEzODI4ODk=","name":"api","full_name":"teamleadercrm/api","private":false,"owner":{"login":"teamleadercrm","id":19797966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk3OTY2","avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/teamleadercrm/api","description":"The Teamleader API definition","fork":false,"url":"https://api.github.com/repos/teamleadercrm/api","forks_url":"https://api.github.com/repos/teamleadercrm/api/forks","keys_url":"https://api.github.com/repos/teamleadercrm/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamleadercrm/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamleadercrm/api/teams","hooks_url":"https://api.github.com/repos/teamleadercrm/api/hooks","issue_events_url":"https://api.github.com/repos/teamleadercrm/api/issues/events{/number}","events_url":"https://api.github.com/repos/teamleadercrm/api/events","assignees_url":"https://api.github.com/repos/teamleadercrm/api/assignees{/user}","branches_url":"https://api.github.com/repos/teamleadercrm/api/branches{/branch}","tags_url":"https://api.github.com/repos/teamleadercrm/api/tags","blobs_url":"https://api.github.com/repos/teamleadercrm/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamleadercrm/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamleadercrm/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamleadercrm/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/{sha}","languages_url":"https://api.github.com/repos/teamleadercrm/api/languages","stargazers_url":"https://api.github.com/repos/teamleadercrm/api/stargazers","contributors_url":"https://api.github.com/repos/teamleadercrm/api/contributors","subscribers_url":"https://api.github.com/repos/teamleadercrm/api/subscribers","subscription_url":"https://api.github.com/repos/teamleadercrm/api/subscription","commits_url":"https://api.github.com/repos/teamleadercrm/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamleadercrm/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamleadercrm/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamleadercrm/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamleadercrm/api/contents/{+path}","compare_url":"https://api.github.com/repos/teamleadercrm/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamleadercrm/api/merges","archive_url":"https://api.github.com/repos/teamleadercrm/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamleadercrm/api/downloads","issues_url":"https://api.github.com/repos/teamleadercrm/api/issues{/number}","pulls_url":"https://api.github.com/repos/teamleadercrm/api/pulls{/number}","milestones_url":"https://api.github.com/repos/teamleadercrm/api/milestones{/number}","notifications_url":"https://api.github.com/repos/teamleadercrm/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamleadercrm/api/labels{/name}","releases_url":"https://api.github.com/repos/teamleadercrm/api/releases{/id}","deployments_url":"https://api.github.com/repos/teamleadercrm/api/deployments","created_at":"2017-11-20T08:33:12Z","updated_at":"2019-04-23T10:32:48Z","pushed_at":"2019-04-23T11:59:24Z","git_url":"git://github.com/teamleadercrm/api.git","ssh_url":"git@github.com:teamleadercrm/api.git","clone_url":"https://github.com/teamleadercrm/api.git","svn_url":"https://github.com/teamleadercrm/api","homepage":null,"size":979,"stargazers_count":25,"watchers_count":25,"language":"API Blueprint","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":null,"forks":45,"open_issues":20,"watchers":25,"default_branch":"master"}},"base":{"label":"teamleadercrm:master","ref":"master","sha":"42793078e68a02a45c9a2f1559eae7511635584c","user":{"login":"teamleadercrm","id":19797966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk3OTY2","avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"repo":{"id":111382889,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEzODI4ODk=","name":"api","full_name":"teamleadercrm/api","private":false,"owner":{"login":"teamleadercrm","id":19797966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk3OTY2","avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/teamleadercrm/api","description":"The Teamleader API definition","fork":false,"url":"https://api.github.com/repos/teamleadercrm/api","forks_url":"https://api.github.com/repos/teamleadercrm/api/forks","keys_url":"https://api.github.com/repos/teamleadercrm/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamleadercrm/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamleadercrm/api/teams","hooks_url":"https://api.github.com/repos/teamleadercrm/api/hooks","issue_events_url":"https://api.github.com/repos/teamleadercrm/api/issues/events{/number}","events_url":"https://api.github.com/repos/teamleadercrm/api/events","assignees_url":"https://api.github.com/repos/teamleadercrm/api/assignees{/user}","branches_url":"https://api.github.com/repos/teamleadercrm/api/branches{/branch}","tags_url":"https://api.github.com/repos/teamleadercrm/api/tags","blobs_url":"https://api.github.com/repos/teamleadercrm/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamleadercrm/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamleadercrm/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamleadercrm/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/{sha}","languages_url":"https://api.github.com/repos/teamleadercrm/api/languages","stargazers_url":"https://api.github.com/repos/teamleadercrm/api/stargazers","contributors_url":"https://api.github.com/repos/teamleadercrm/api/contributors","subscribers_url":"https://api.github.com/repos/teamleadercrm/api/subscribers","subscription_url":"https://api.github.com/repos/teamleadercrm/api/subscription","commits_url":"https://api.github.com/repos/teamleadercrm/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamleadercrm/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamleadercrm/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamleadercrm/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamleadercrm/api/contents/{+path}","compare_url":"https://api.github.com/repos/teamleadercrm/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamleadercrm/api/merges","archive_url":"https://api.github.com/repos/teamleadercrm/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamleadercrm/api/downloads","issues_url":"https://api.github.com/repos/teamleadercrm/api/issues{/number}","pulls_url":"https://api.github.com/repos/teamleadercrm/api/pulls{/number}","milestones_url":"https://api.github.com/repos/teamleadercrm/api/milestones{/number}","notifications_url":"https://api.github.com/repos/teamleadercrm/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamleadercrm/api/labels{/name}","releases_url":"https://api.github.com/repos/teamleadercrm/api/releases{/id}","deployments_url":"https://api.github.com/repos/teamleadercrm/api/deployments","created_at":"2017-11-20T08:33:12Z","updated_at":"2019-04-23T10:32:48Z","pushed_at":"2019-04-23T11:59:24Z","git_url":"git://github.com/teamleadercrm/api.git","ssh_url":"git@github.com:teamleadercrm/api.git","clone_url":"https://github.com/teamleadercrm/api.git","svn_url":"https://github.com/teamleadercrm/api","homepage":null,"size":979,"stargazers_count":25,"watchers_count":25,"language":"API Blueprint","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":null,"forks":45,"open_issues":20,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/367"},"html":{"href":"https://github.com/teamleadercrm/api/pull/367"},"issue":{"href":"https://api.github.com/repos/teamleadercrm/api/issues/367"},"comments":{"href":"https://api.github.com/repos/teamleadercrm/api/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/teamleadercrm/api/statuses/0a10ff04cca03c2cfaa5c346837cdb1e9b9c3f25"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dcsg"}}