{"action":"created","issue":{"url":"https://api.github.com/repos/reazen/relude/issues/191","repository_url":"https://api.github.com/repos/reazen/relude","labels_url":"https://api.github.com/repos/reazen/relude/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/reazen/relude/issues/191/comments","events_url":"https://api.github.com/repos/reazen/relude/issues/191/events","html_url":"https://github.com/reazen/relude/pull/191","id":519607994,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4MzE5MTM1","number":191,"title":"Add more Map functions","user":{"login":"mlms13","id":1105543,"node_id":"MDQ6VXNlcjExMDU1NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1105543?v=4","gravatar_id":"","url":"https://api.github.com/users/mlms13","html_url":"https://github.com/mlms13","followers_url":"https://api.github.com/users/mlms13/followers","following_url":"https://api.github.com/users/mlms13/following{/other_user}","gists_url":"https://api.github.com/users/mlms13/gists{/gist_id}","starred_url":"https://api.github.com/users/mlms13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlms13/subscriptions","organizations_url":"https://api.github.com/users/mlms13/orgs","repos_url":"https://api.github.com/users/mlms13/repos","events_url":"https://api.github.com/users/mlms13/events{/privacy}","received_events_url":"https://api.github.com/users/mlms13/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-11-08T01:35:23Z","updated_at":"2019-11-08T15:57:41Z","closed_at":"2019-11-08T01:56:34Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/reazen/relude/pulls/191","html_url":"https://github.com/reazen/relude/pull/191","diff_url":"https://github.com/reazen/relude/pull/191.diff","patch_url":"https://github.com/reazen/relude/pull/191.patch"},"body":"- doc comments for most Map functions (which are worthless, turns out, once you've specialized the Map to a specific key type...)\r\n- add `StringMap` with key fixed to `string`\r\n- add quite a few tests (but still not at 100% coverage)\r\n- `compare` is now `compareBy` and it expects the provided function to return `ordering` instead of `int`\r\n- `keys` and `values` now return a `list` by default (but `keyArray` and `valueArray` have been added)\r\n- `singleton` constructor makes a `Map` with one key/value pair\r\n- `fromValueArray` and `fromValueList` can construct a map from a `list('value)` and function from`'value => key`\r\n\r\ncc @johnhaley81, since you're the most likely one to be using this and there are a couple breaking changes, in the name of consistency.\r\n\r\nI feel ready to merge this, but we could still add more tests someday, and we could add e.g. `FUNCTOR` and `FOLDABLE` implementations for `Map`, which would give us quite a few of these functions for free, so we could delete the `Belt` version (e.g. `any`, `all`, `contains`, `toList`, etc...)."},"comment":{"url":"https://api.github.com/repos/reazen/relude/issues/comments/551883209","html_url":"https://github.com/reazen/relude/pull/191#issuecomment-551883209","issue_url":"https://api.github.com/repos/reazen/relude/issues/191","id":551883209,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MTg4MzIwOQ==","user":{"login":"johnhaley81","id":867780,"node_id":"MDQ6VXNlcjg2Nzc4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/867780?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhaley81","html_url":"https://github.com/johnhaley81","followers_url":"https://api.github.com/users/johnhaley81/followers","following_url":"https://api.github.com/users/johnhaley81/following{/other_user}","gists_url":"https://api.github.com/users/johnhaley81/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaley81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaley81/subscriptions","organizations_url":"https://api.github.com/users/johnhaley81/orgs","repos_url":"https://api.github.com/users/johnhaley81/repos","events_url":"https://api.github.com/users/johnhaley81/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaley81/received_events","type":"User","site_admin":false},"created_at":"2019-11-08T15:57:40Z","updated_at":"2019-11-08T15:57:40Z","author_association":"CONTRIBUTOR","body":"Just commenting after the fact that this all looks 💯 "}}
{"actor":{"display_login":"johnhaley81"}}