{"action":"created","issue":{"url":"https://api.github.com/repos/Juniper/healthbot-rules/issues/198","repository_url":"https://api.github.com/repos/Juniper/healthbot-rules","labels_url":"https://api.github.com/repos/Juniper/healthbot-rules/issues/198/labels{/name}","comments_url":"https://api.github.com/repos/Juniper/healthbot-rules/issues/198/comments","events_url":"https://api.github.com/repos/Juniper/healthbot-rules/issues/198/events","html_url":"https://github.com/Juniper/healthbot-rules/issues/198","id":461314939,"node_id":"MDU6SXNzdWU0NjEzMTQ5Mzk=","number":198,"title":"Fixes in system KPI rule system-processes-memory.rule","user":{"login":"ConstrainedRandomVar","id":39586951,"node_id":"MDQ6VXNlcjM5NTg2OTUx","avatar_url":"https://avatars2.githubusercontent.com/u/39586951?v=4","gravatar_id":"","url":"https://api.github.com/users/ConstrainedRandomVar","html_url":"https://github.com/ConstrainedRandomVar","followers_url":"https://api.github.com/users/ConstrainedRandomVar/followers","following_url":"https://api.github.com/users/ConstrainedRandomVar/following{/other_user}","gists_url":"https://api.github.com/users/ConstrainedRandomVar/gists{/gist_id}","starred_url":"https://api.github.com/users/ConstrainedRandomVar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConstrainedRandomVar/subscriptions","organizations_url":"https://api.github.com/users/ConstrainedRandomVar/orgs","repos_url":"https://api.github.com/users/ConstrainedRandomVar/repos","events_url":"https://api.github.com/users/ConstrainedRandomVar/events{/privacy}","received_events_url":"https://api.github.com/users/ConstrainedRandomVar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gvarao","id":16290772,"node_id":"MDQ6VXNlcjE2MjkwNzcy","avatar_url":"https://avatars0.githubusercontent.com/u/16290772?v=4","gravatar_id":"","url":"https://api.github.com/users/gvarao","html_url":"https://github.com/gvarao","followers_url":"https://api.github.com/users/gvarao/followers","following_url":"https://api.github.com/users/gvarao/following{/other_user}","gists_url":"https://api.github.com/users/gvarao/gists{/gist_id}","starred_url":"https://api.github.com/users/gvarao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvarao/subscriptions","organizations_url":"https://api.github.com/users/gvarao/orgs","repos_url":"https://api.github.com/users/gvarao/repos","events_url":"https://api.github.com/users/gvarao/events{/privacy}","received_events_url":"https://api.github.com/users/gvarao/received_events","type":"User","site_admin":false},"assignees":[{"login":"gvarao","id":16290772,"node_id":"MDQ6VXNlcjE2MjkwNzcy","avatar_url":"https://avatars0.githubusercontent.com/u/16290772?v=4","gravatar_id":"","url":"https://api.github.com/users/gvarao","html_url":"https://github.com/gvarao","followers_url":"https://api.github.com/users/gvarao/followers","following_url":"https://api.github.com/users/gvarao/following{/other_user}","gists_url":"https://api.github.com/users/gvarao/gists{/gist_id}","starred_url":"https://api.github.com/users/gvarao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvarao/subscriptions","organizations_url":"https://api.github.com/users/gvarao/orgs","repos_url":"https://api.github.com/users/gvarao/repos","events_url":"https://api.github.com/users/gvarao/events{/privacy}","received_events_url":"https://api.github.com/users/gvarao/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-06-27T04:59:53Z","updated_at":"2019-07-04T04:35:07Z","closed_at":null,"author_association":"COLLABORATOR","body":"Andrew Duane provided some feedback on our System KPI playbook. \r\n - :%s/reserved/resident/g\r\n - The key needs to also include the PID since the daemon name by itself isn't unambiguous for processes such as mgd, sshd, cli, etc.\r\n - The python function should be extended to handle GB as well (in addition to parsing KB, HB).\r\n\r\nRegards,\r\n\r\nHarsha Lakshmikanth "},"comment":{"url":"https://api.github.com/repos/Juniper/healthbot-rules/issues/comments/508334474","html_url":"https://github.com/Juniper/healthbot-rules/issues/198#issuecomment-508334474","issue_url":"https://api.github.com/repos/Juniper/healthbot-rules/issues/198","id":508334474,"node_id":"MDEyOklzc3VlQ29tbWVudDUwODMzNDQ3NA==","user":{"login":"ssachinbharadwaj","id":10479840,"node_id":"MDQ6VXNlcjEwNDc5ODQw","avatar_url":"https://avatars2.githubusercontent.com/u/10479840?v=4","gravatar_id":"","url":"https://api.github.com/users/ssachinbharadwaj","html_url":"https://github.com/ssachinbharadwaj","followers_url":"https://api.github.com/users/ssachinbharadwaj/followers","following_url":"https://api.github.com/users/ssachinbharadwaj/following{/other_user}","gists_url":"https://api.github.com/users/ssachinbharadwaj/gists{/gist_id}","starred_url":"https://api.github.com/users/ssachinbharadwaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssachinbharadwaj/subscriptions","organizations_url":"https://api.github.com/users/ssachinbharadwaj/orgs","repos_url":"https://api.github.com/users/ssachinbharadwaj/repos","events_url":"https://api.github.com/users/ssachinbharadwaj/events{/privacy}","received_events_url":"https://api.github.com/users/ssachinbharadwaj/received_events","type":"User","site_admin":false},"created_at":"2019-07-04T04:35:07Z","updated_at":"2019-07-04T04:35:07Z","author_association":"NONE","body":"I don't think the below calculation for process memory rule is correct:\r\n\r\n```\r\n        if (res/size)*100 >= threshold :\r\n            return True\r\n        else:\r\n            return False\r\n```\r\n\r\nIt looks like the logic is assuming that SIZE is the max limit and RES is the currently allocated memory.\r\nAFAIK, SIZE is the total current memory of a process and RES is the memory that is in RAM. The maximum limit is defined by RLIMIT\r\n\r\n"}}
{"actor":{"display_login":"ssachinbharadwaj"}}