{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/comments/309881598","pull_request_review_id":269858847,"id":309881598,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTg4MTU5OA==","diff_hunk":"@@ -144,9 +144,10 @@ function main() {\n     # Add transpiled BQ schemas\n     find . -type f -name \"*.schema.json\" | while read -r fname; do\n         bq_out=${fname/schema.json/bq}\n-        # Normalize name of untrustedModules ping for bug 1565074;\n+        # Normalize names of pings for bug 1565074;\n         # the // means \"replace all\".\n         bq_out=${bq_out//untrustedModules/untrusted-modules}\n+        bq_out=${bq_out//disableSHA1rollout/disable-sha1rollout}","path":"bin/schema_generator.sh","position":8,"original_position":8,"commit_id":"94ce3e7bae81e02e40a3212b3814345478e2e10d","original_commit_id":"94ce3e7bae81e02e40a3212b3814345478e2e10d","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"I checked with the Java implementation and indeed there's only the one break.","created_at":"2019-08-01T20:24:34Z","updated_at":"2019-08-01T20:24:34Z","html_url":"https://github.com/mozilla/mozilla-schema-generator/pull/49#discussion_r309881598","pull_request_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/comments/309881598"},"html":{"href":"https://github.com/mozilla/mozilla-schema-generator/pull/49#discussion_r309881598"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49"}},"in_reply_to_id":309879835},"pull_request":{"url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49","id":303538510,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzNTM4NTEw","html_url":"https://github.com/mozilla/mozilla-schema-generator/pull/49","diff_url":"https://github.com/mozilla/mozilla-schema-generator/pull/49.diff","patch_url":"https://github.com/mozilla/mozilla-schema-generator/pull/49.patch","issue_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/49","number":49,"state":"open","locked":false,"title":"Add disableSHA1rollout to specially snake-cased pings","user":{"login":"whd","id":808776,"node_id":"MDQ6VXNlcjgwODc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/808776?v=4","gravatar_id":"","url":"https://api.github.com/users/whd","html_url":"https://github.com/whd","followers_url":"https://api.github.com/users/whd/followers","following_url":"https://api.github.com/users/whd/following{/other_user}","gists_url":"https://api.github.com/users/whd/gists{/gist_id}","starred_url":"https://api.github.com/users/whd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whd/subscriptions","organizations_url":"https://api.github.com/users/whd/orgs","repos_url":"https://api.github.com/users/whd/repos","events_url":"https://api.github.com/users/whd/events{/privacy}","received_events_url":"https://api.github.com/users/whd/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-01T20:18:12Z","updated_at":"2019-08-01T20:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc8359dd9f602621dd86c1acf3d2e3d60dc78695","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49/commits","review_comments_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49/comments","review_comment_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/49/comments","statuses_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/statuses/94ce3e7bae81e02e40a3212b3814345478e2e10d","head":{"label":"mozilla:sha1rollout","ref":"sha1rollout","sha":"94ce3e7bae81e02e40a3212b3814345478e2e10d","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":173782575,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3ODI1NzU=","name":"mozilla-schema-generator","full_name":"mozilla/mozilla-schema-generator","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/mozilla-schema-generator","description":"A library for creating full representations of Mozilla telemetry pings.","fork":false,"url":"https://api.github.com/repos/mozilla/mozilla-schema-generator","forks_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/forks","keys_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/teams","hooks_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/events","assignees_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/tags","blobs_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/languages","stargazers_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/subscription","commits_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/merges","archive_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/downloads","issues_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/deployments","created_at":"2019-03-04T16:38:08Z","updated_at":"2019-07-18T20:50:16Z","pushed_at":"2019-08-01T20:18:12Z","git_url":"git://github.com/mozilla/mozilla-schema-generator.git","ssh_url":"git@github.com:mozilla/mozilla-schema-generator.git","clone_url":"https://github.com/mozilla/mozilla-schema-generator.git","svn_url":"https://github.com/mozilla/mozilla-schema-generator","homepage":null,"size":361,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":4,"open_issues":12,"watchers":4,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"61c8a00c319af749e5033c104fafa9ea50cc6714","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":173782575,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3ODI1NzU=","name":"mozilla-schema-generator","full_name":"mozilla/mozilla-schema-generator","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/mozilla-schema-generator","description":"A library for creating full representations of Mozilla telemetry pings.","fork":false,"url":"https://api.github.com/repos/mozilla/mozilla-schema-generator","forks_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/forks","keys_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/teams","hooks_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/events","assignees_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/tags","blobs_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/languages","stargazers_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/subscription","commits_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/merges","archive_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/downloads","issues_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/mozilla-schema-generator/deployments","created_at":"2019-03-04T16:38:08Z","updated_at":"2019-07-18T20:50:16Z","pushed_at":"2019-08-01T20:18:12Z","git_url":"git://github.com/mozilla/mozilla-schema-generator.git","ssh_url":"git@github.com:mozilla/mozilla-schema-generator.git","clone_url":"https://github.com/mozilla/mozilla-schema-generator.git","svn_url":"https://github.com/mozilla/mozilla-schema-generator","homepage":null,"size":361,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":4,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49"},"html":{"href":"https://github.com/mozilla/mozilla-schema-generator/pull/49"},"issue":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/49"},"comments":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/mozilla-schema-generator/statuses/94ce3e7bae81e02e40a3212b3814345478e2e10d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jklukas"}}