{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/13704","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/13704/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/13704/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/13704/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/13704","id":413724684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NjMxODk5","number":13704,"title":"tests: Mass SMP disablement on non-SMP-safe tests (part 1 of 3)","user":{"login":"andyross","id":300115,"node_id":"MDQ6VXNlcjMwMDExNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/300115?v=4","gravatar_id":"","url":"https://api.github.com/users/andyross","html_url":"https://github.com/andyross","followers_url":"https://api.github.com/users/andyross/followers","following_url":"https://api.github.com/users/andyross/following{/other_user}","gists_url":"https://api.github.com/users/andyross/gists{/gist_id}","starred_url":"https://api.github.com/users/andyross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyross/subscriptions","organizations_url":"https://api.github.com/users/andyross/orgs","repos_url":"https://api.github.com/users/andyross/repos","events_url":"https://api.github.com/users/andyross/events{/privacy}","received_events_url":"https://api.github.com/users/andyross/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-02-23T18:45:40Z","updated_at":"2019-02-23T19:43:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/13704","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/13704","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/13704.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/13704.patch"},"body":"**_This is a workaround to the CI performance trouble #13688\r\n\r\nIt's impossible to change so many tests at once and have a CI run that completes in the 2 hour limit, so I'm splitting the modified tests out into three separate patches and submitting them to be merged before the main pull request.  With master as it stands right now, these changes (to set CONFIG_SMP=n) are noops as no platforms have that set by default._** \r\n\r\n(Chunk 1 of 3 - this patch was split across pull requests to address\r\nCI build time limitations)\r\n\r\nZephyr has always been a uniprocessor system, and its kernel tests are\r\nrife with assumptions and outright dependence on single-CPU operation\r\n(for example: \"low priority threads will never run until this high\r\npriority thread blocks\" -- not true if there's another processor to\r\nrun it!)\r\n\r\nAbout 1/3 of our tests fail right now on x86_64 when dual processor\r\noperation is made default.  Most of those can probably be recovered on\r\na case-by-case basis with simple changes (and a few of them might\r\nrepresent real bugs in SMP!), but for now let's make sure the full\r\ntest suite passes by turning the second CPU off.  There's still plenty\r\nof SMP coverage in the remaining cases.\r\n\r\nSigned-off-by: Andy Ross <andrew.j.ross@intel.com>"},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/466684749","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/13704#issuecomment-466684749","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/13704","id":466684749,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NjY4NDc0OQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2019-02-23T19:43:44Z","updated_at":"2019-02-23T19:43:44Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=h1) Report\n> Merging [#13704](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=desc) into [master](https://codecov.io/gh/zephyrproject-rtos/zephyr/commit/29dac2233e1da32c2ee0b662835edf4424fd5b21?src=pr&el=desc) will **increase** coverage by `0.05%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704/graphs/tree.svg?width=650&token=ftaqgO8OOj&height=150&src=pr)](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master   #13704      +/-   ##\n==========================================\n+ Coverage   52.24%    52.3%   +0.05%     \n==========================================\n  Files         307      307              \n  Lines       45413    45418       +5     \n  Branches    10508    10513       +5     \n==========================================\n+ Hits        23726    23755      +29     \n+ Misses      16898    16873      -25     \n- Partials     4789     4790       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [drivers/clock\\_control/nrf\\_power\\_clock.c](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704/diff?src=pr&el=tree#diff-ZHJpdmVycy9jbG9ja19jb250cm9sL25yZl9wb3dlcl9jbG9jay5j) | `50% <0%> (-2.11%)` | :arrow_down: |\n| [arch/posix/core/posix\\_core.c](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704/diff?src=pr&el=tree#diff-YXJjaC9wb3NpeC9jb3JlL3Bvc2l4X2NvcmUuYw==) | `90.9% <0%> (-1.02%)` | :arrow_down: |\n| [boards/posix/nrf52\\_bsim/time\\_machine.c](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704/diff?src=pr&el=tree#diff-Ym9hcmRzL3Bvc2l4L25yZjUyX2JzaW0vdGltZV9tYWNoaW5lLmM=) | `52.45% <0%> (+4.91%)` | :arrow_up: |\n| [boards/posix/nrf52\\_bsim/irq\\_handler.c](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704/diff?src=pr&el=tree#diff-Ym9hcmRzL3Bvc2l4L25yZjUyX2JzaW0vaXJxX2hhbmRsZXIuYw==) | `78.3% <0%> (+13.2%)` | :arrow_up: |\n| [boards/posix/nrf52\\_bsim/argparse.c](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704/diff?src=pr&el=tree#diff-Ym9hcmRzL3Bvc2l4L25yZjUyX2JzaW0vYXJncGFyc2UuYw==) | `46.98% <0%> (+15.66%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=footer). Last update [29dac22...a708755](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/13704?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}