{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-livy/pulls/comments/315031069","pull_request_review_id":276331864,"id":315031069,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTAzMTA2OQ==","diff_hunk":"@@ -42,8 +46,14 @@ abstract class MetadataOperation(sessionHandle: SessionHandle, opType: Operation\n     assertState(Seq(OperationState.FINISHED))\n     validateFetchOrientation(orientation)\n     if (orientation.equals(FetchOrientation.FETCH_FIRST)) {\n-      rowSet.setRowOffset(0)\n+      offset = 0\n+    }\n+\n+    if (offset >= rowSet.numRows) {","path":"thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/MetadataOperation.scala","position":19,"original_position":19,"commit_id":"1c4a7e93310b7d21f64d5a25222f1f49e936f39f","original_commit_id":"da6311fa9cee0c2ef3c08540c4e6e087cd37cc8b","user":{"login":"jerryshao","id":850797,"node_id":"MDQ6VXNlcjg1MDc5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/850797?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"body":"I see, thanks! IMO I think current solution is OK. Maybe we need to add some comments on the code.","created_at":"2019-08-19T03:54:10Z","updated_at":"2019-08-19T03:54:10Z","html_url":"https://github.com/apache/incubator-livy/pull/197#discussion_r315031069","pull_request_url":"https://api.github.com/repos/apache/incubator-livy/pulls/197","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/comments/315031069"},"html":{"href":"https://github.com/apache/incubator-livy/pull/197#discussion_r315031069"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/197"}},"in_reply_to_id":313297467},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-livy/pulls/197","id":306816941,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2ODE2OTQx","html_url":"https://github.com/apache/incubator-livy/pull/197","diff_url":"https://github.com/apache/incubator-livy/pull/197.diff","patch_url":"https://github.com/apache/incubator-livy/pull/197.patch","issue_url":"https://api.github.com/repos/apache/incubator-livy/issues/197","number":197,"state":"open","locked":false,"title":"[LIVY-574][THRIFT SERVER][TEST] Add tests for metadata operations","user":{"login":"yiheng","id":1297418,"node_id":"MDQ6VXNlcjEyOTc0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1297418?v=4","gravatar_id":"","url":"https://api.github.com/users/yiheng","html_url":"https://github.com/yiheng","followers_url":"https://api.github.com/users/yiheng/followers","following_url":"https://api.github.com/users/yiheng/following{/other_user}","gists_url":"https://api.github.com/users/yiheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yiheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiheng/subscriptions","organizations_url":"https://api.github.com/users/yiheng/orgs","repos_url":"https://api.github.com/users/yiheng/repos","events_url":"https://api.github.com/users/yiheng/events{/privacy}","received_events_url":"https://api.github.com/users/yiheng/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nAdd unit test for existing meta operation: GetCatalogsOperation/GetTableTypesOperation/GetTypeInfoOperation.\r\n\r\nWe also fix issues we met.\r\n\r\n## How was this patch tested?\r\nAdd new unit tests and existing test.\r\n\r\nWe also use SquirrelSQL test relate operations.\r\n![image](https://user-images.githubusercontent.com/1297418/62930007-26a93400-bdee-11e9-9364-259308724db6.png)\r\n\r\n![image](https://user-images.githubusercontent.com/1297418/62930073-42143f00-bdee-11e9-9409-62d07ad0eabd.png)\r\n","created_at":"2019-08-13T09:16:38Z","updated_at":"2019-08-19T03:54:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cd2a5f5074dd11a11457e3724b5de0bf8042ec7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-livy/pulls/197/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-livy/pulls/197/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-livy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-livy/issues/197/comments","statuses_url":"https://api.github.com/repos/apache/incubator-livy/statuses/1c4a7e93310b7d21f64d5a25222f1f49e936f39f","head":{"label":"yiheng:fix_574","ref":"fix_574","sha":"1c4a7e93310b7d21f64d5a25222f1f49e936f39f","user":{"login":"yiheng","id":1297418,"node_id":"MDQ6VXNlcjEyOTc0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1297418?v=4","gravatar_id":"","url":"https://api.github.com/users/yiheng","html_url":"https://github.com/yiheng","followers_url":"https://api.github.com/users/yiheng/followers","following_url":"https://api.github.com/users/yiheng/following{/other_user}","gists_url":"https://api.github.com/users/yiheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yiheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiheng/subscriptions","organizations_url":"https://api.github.com/users/yiheng/orgs","repos_url":"https://api.github.com/users/yiheng/repos","events_url":"https://api.github.com/users/yiheng/events{/privacy}","received_events_url":"https://api.github.com/users/yiheng/received_events","type":"User","site_admin":false},"repo":{"id":195767748,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU3Njc3NDg=","name":"incubator-livy","full_name":"yiheng/incubator-livy","private":false,"owner":{"login":"yiheng","id":1297418,"node_id":"MDQ6VXNlcjEyOTc0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1297418?v=4","gravatar_id":"","url":"https://api.github.com/users/yiheng","html_url":"https://github.com/yiheng","followers_url":"https://api.github.com/users/yiheng/followers","following_url":"https://api.github.com/users/yiheng/following{/other_user}","gists_url":"https://api.github.com/users/yiheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yiheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiheng/subscriptions","organizations_url":"https://api.github.com/users/yiheng/orgs","repos_url":"https://api.github.com/users/yiheng/repos","events_url":"https://api.github.com/users/yiheng/events{/privacy}","received_events_url":"https://api.github.com/users/yiheng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yiheng/incubator-livy","description":"Mirror of Apache livy (Incubating)","fork":true,"url":"https://api.github.com/repos/yiheng/incubator-livy","forks_url":"https://api.github.com/repos/yiheng/incubator-livy/forks","keys_url":"https://api.github.com/repos/yiheng/incubator-livy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiheng/incubator-livy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiheng/incubator-livy/teams","hooks_url":"https://api.github.com/repos/yiheng/incubator-livy/hooks","issue_events_url":"https://api.github.com/repos/yiheng/incubator-livy/issues/events{/number}","events_url":"https://api.github.com/repos/yiheng/incubator-livy/events","assignees_url":"https://api.github.com/repos/yiheng/incubator-livy/assignees{/user}","branches_url":"https://api.github.com/repos/yiheng/incubator-livy/branches{/branch}","tags_url":"https://api.github.com/repos/yiheng/incubator-livy/tags","blobs_url":"https://api.github.com/repos/yiheng/incubator-livy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiheng/incubator-livy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiheng/incubator-livy/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiheng/incubator-livy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiheng/incubator-livy/statuses/{sha}","languages_url":"https://api.github.com/repos/yiheng/incubator-livy/languages","stargazers_url":"https://api.github.com/repos/yiheng/incubator-livy/stargazers","contributors_url":"https://api.github.com/repos/yiheng/incubator-livy/contributors","subscribers_url":"https://api.github.com/repos/yiheng/incubator-livy/subscribers","subscription_url":"https://api.github.com/repos/yiheng/incubator-livy/subscription","commits_url":"https://api.github.com/repos/yiheng/incubator-livy/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiheng/incubator-livy/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiheng/incubator-livy/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiheng/incubator-livy/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiheng/incubator-livy/contents/{+path}","compare_url":"https://api.github.com/repos/yiheng/incubator-livy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiheng/incubator-livy/merges","archive_url":"https://api.github.com/repos/yiheng/incubator-livy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiheng/incubator-livy/downloads","issues_url":"https://api.github.com/repos/yiheng/incubator-livy/issues{/number}","pulls_url":"https://api.github.com/repos/yiheng/incubator-livy/pulls{/number}","milestones_url":"https://api.github.com/repos/yiheng/incubator-livy/milestones{/number}","notifications_url":"https://api.github.com/repos/yiheng/incubator-livy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiheng/incubator-livy/labels{/name}","releases_url":"https://api.github.com/repos/yiheng/incubator-livy/releases{/id}","deployments_url":"https://api.github.com/repos/yiheng/incubator-livy/deployments","created_at":"2019-07-08T08:19:54Z","updated_at":"2019-08-06T04:06:31Z","pushed_at":"2019-08-19T03:45:23Z","git_url":"git://github.com/yiheng/incubator-livy.git","ssh_url":"git@github.com:yiheng/incubator-livy.git","clone_url":"https://github.com/yiheng/incubator-livy.git","svn_url":"https://github.com/yiheng/incubator-livy","homepage":null,"size":3443,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cae9d97185bf371912dcd863dff5babfd9cb704a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":95343930,"node_id":"MDEwOlJlcG9zaXRvcnk5NTM0MzkzMA==","name":"incubator-livy","full_name":"apache/incubator-livy","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-livy","description":"Mirror of Apache livy (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-livy","forks_url":"https://api.github.com/repos/apache/incubator-livy/forks","keys_url":"https://api.github.com/repos/apache/incubator-livy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-livy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-livy/teams","hooks_url":"https://api.github.com/repos/apache/incubator-livy/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-livy/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-livy/events","assignees_url":"https://api.github.com/repos/apache/incubator-livy/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-livy/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-livy/tags","blobs_url":"https://api.github.com/repos/apache/incubator-livy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-livy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-livy/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-livy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-livy/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-livy/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-livy/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-livy/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-livy/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-livy/subscription","commits_url":"https://api.github.com/repos/apache/incubator-livy/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-livy/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-livy/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-livy/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-livy/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-livy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-livy/merges","archive_url":"https://api.github.com/repos/apache/incubator-livy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-livy/downloads","issues_url":"https://api.github.com/repos/apache/incubator-livy/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-livy/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-livy/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-livy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-livy/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-livy/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-livy/deployments","created_at":"2017-06-25T07:00:09Z","updated_at":"2019-08-16T02:32:35Z","pushed_at":"2019-08-19T03:45:25Z","git_url":"git://github.com/apache/incubator-livy.git","ssh_url":"git@github.com:apache/incubator-livy.git","clone_url":"https://github.com/apache/incubator-livy.git","svn_url":"https://github.com/apache/incubator-livy","homepage":null,"size":3406,"stargazers_count":356,"watchers_count":356,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":229,"open_issues":35,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/197"},"html":{"href":"https://github.com/apache/incubator-livy/pull/197"},"issue":{"href":"https://api.github.com/repos/apache/incubator-livy/issues/197"},"comments":{"href":"https://api.github.com/repos/apache/incubator-livy/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-livy/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-livy/statuses/1c4a7e93310b7d21f64d5a25222f1f49e936f39f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jerryshao"}}