{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.io/pulls/comments/294979067","pull_request_review_id":251296302,"id":294979067,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDk3OTA2Nw==","diff_hunk":"@@ -148,10 +142,13 @@ $ kubectl apply -f <(istioctl kube-inject \\\n \n ## Migrating per-service mutual TLS enablement via annotations to authentication policy\n \n-If you use service annotations to override global mutual TLS enablement for a service, you need to replace it with\n-[authentication policy](/docs/concepts/security/#authentication-policies) and [destination rules](/docs/concepts/traffic-management/routing/destination-rules/).\n+If you use service annotations to override global mutual TLS enablement for a","path":"content/docs/setup/kubernetes/upgrade/steps/index.md","position":120,"original_position":120,"commit_id":"3103eba2bb3a201fa9549057ca817fb1942de5c4","original_commit_id":"3103eba2bb3a201fa9549057ca817fb1942de5c4","user":{"login":"howardjohn","id":623453,"node_id":"MDQ6VXNlcjYyMzQ1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/623453?v=4","gravatar_id":"","url":"https://api.github.com/users/howardjohn","html_url":"https://github.com/howardjohn","followers_url":"https://api.github.com/users/howardjohn/followers","following_url":"https://api.github.com/users/howardjohn/following{/other_user}","gists_url":"https://api.github.com/users/howardjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/howardjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardjohn/subscriptions","organizations_url":"https://api.github.com/users/howardjohn/orgs","repos_url":"https://api.github.com/users/howardjohn/repos","events_url":"https://api.github.com/users/howardjohn/events{/privacy}","received_events_url":"https://api.github.com/users/howardjohn/received_events","type":"User","site_admin":false},"body":"@ security experts: is this still relevant today? It seemed to me this was a 1.0 -> 1.1 migration that was required, so it no longer needs to be documented. Is this the case?","created_at":"2019-06-18T19:00:53Z","updated_at":"2019-06-18T19:02:12Z","html_url":"https://github.com/istio/istio.io/pull/4472#discussion_r294979067","pull_request_url":"https://api.github.com/repos/istio/istio.io/pulls/4472","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments/294979067"},"html":{"href":"https://github.com/istio/istio.io/pull/4472#discussion_r294979067"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.io/pulls/4472"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio.io/pulls/4472","id":289299338,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5Mjk5MzM4","html_url":"https://github.com/istio/istio.io/pull/4472","diff_url":"https://github.com/istio/istio.io/pull/4472.diff","patch_url":"https://github.com/istio/istio.io/pull/4472.patch","issue_url":"https://api.github.com/repos/istio/istio.io/issues/4472","number":4472,"state":"open","locked":false,"title":"Refine the upgrade steps.","user":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"body":"These could use a third party validation.  The upgrade instructions\r\nare mostly generic at this point, although the MTLS handling is not\r\nnecessarily generic between releases.  I had thought we removed the\r\nmtls global setting in this release, yet the existing docs state\r\nthis config option should be used.","created_at":"2019-06-18T14:06:28Z","updated_at":"2019-06-18T19:02:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f0dde1fadce7c0a9529120321b31cabbd1162e9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frankbu","id":2752495,"node_id":"MDQ6VXNlcjI3NTI0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false},{"login":"rcaballeromx","id":10066027,"node_id":"MDQ6VXNlcjEwMDY2MDI3","avatar_url":"https://avatars1.githubusercontent.com/u/10066027?v=4","gravatar_id":"","url":"https://api.github.com/users/rcaballeromx","html_url":"https://github.com/rcaballeromx","followers_url":"https://api.github.com/users/rcaballeromx/followers","following_url":"https://api.github.com/users/rcaballeromx/following{/other_user}","gists_url":"https://api.github.com/users/rcaballeromx/gists{/gist_id}","starred_url":"https://api.github.com/users/rcaballeromx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcaballeromx/subscriptions","organizations_url":"https://api.github.com/users/rcaballeromx/orgs","repos_url":"https://api.github.com/users/rcaballeromx/repos","events_url":"https://api.github.com/users/rcaballeromx/events{/privacy}","received_events_url":"https://api.github.com/users/rcaballeromx/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":884247475,"node_id":"MDU6TGFiZWw4ODQyNDc0NzU=","url":"https://api.github.com/repos/istio/istio.io/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.io/pulls/4472/commits","review_comments_url":"https://api.github.com/repos/istio/istio.io/pulls/4472/comments","review_comment_url":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.io/issues/4472/comments","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/3103eba2bb3a201fa9549057ca817fb1942de5c4","head":{"label":"sdake:issues/4260","ref":"issues/4260","sha":"3103eba2bb3a201fa9549057ca817fb1942de5c4","user":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"repo":{"id":118022613,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwMjI2MTM=","name":"istio.github.io","full_name":"sdake/istio.github.io","private":false,"owner":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sdake/istio.github.io","description":"Source for the istio.io site","fork":true,"url":"https://api.github.com/repos/sdake/istio.github.io","forks_url":"https://api.github.com/repos/sdake/istio.github.io/forks","keys_url":"https://api.github.com/repos/sdake/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdake/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdake/istio.github.io/teams","hooks_url":"https://api.github.com/repos/sdake/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/sdake/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/sdake/istio.github.io/events","assignees_url":"https://api.github.com/repos/sdake/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/sdake/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/sdake/istio.github.io/tags","blobs_url":"https://api.github.com/repos/sdake/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdake/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdake/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdake/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdake/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/sdake/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/sdake/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/sdake/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/sdake/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/sdake/istio.github.io/subscription","commits_url":"https://api.github.com/repos/sdake/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdake/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdake/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdake/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdake/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/sdake/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdake/istio.github.io/merges","archive_url":"https://api.github.com/repos/sdake/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdake/istio.github.io/downloads","issues_url":"https://api.github.com/repos/sdake/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/sdake/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/sdake/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/sdake/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdake/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/sdake/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/sdake/istio.github.io/deployments","created_at":"2018-01-18T18:38:29Z","updated_at":"2019-06-18T14:24:11Z","pushed_at":"2019-06-18T18:40:28Z","git_url":"git://github.com/sdake/istio.github.io.git","ssh_url":"git@github.com:sdake/istio.github.io.git","clone_url":"https://github.com/sdake/istio.github.io.git","svn_url":"https://github.com/sdake/istio.github.io","homepage":"https://istio.io/","size":49023,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"011383f0afd8005c0a6d118dd2ea64025d4a8e6f","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwNjk3Ng==","name":"istio.io","full_name":"istio/istio.io","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.io","forks_url":"https://api.github.com/repos/istio/istio.io/forks","keys_url":"https://api.github.com/repos/istio/istio.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.io/events","assignees_url":"https://api.github.com/repos/istio/istio.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.io/merges","archive_url":"https://api.github.com/repos/istio/istio.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2019-06-18T18:16:31Z","pushed_at":"2019-06-18T19:02:10Z","git_url":"git://github.com/istio/istio.io.git","ssh_url":"git@github.com:istio/istio.io.git","clone_url":"https://github.com/istio/istio.io.git","svn_url":"https://github.com/istio/istio.io","homepage":"https://istio.io/","size":51489,"stargazers_count":308,"watchers_count":308,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":568,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":155,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":568,"open_issues":155,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.io/pulls/4472"},"html":{"href":"https://github.com/istio/istio.io/pull/4472"},"issue":{"href":"https://api.github.com/repos/istio/istio.io/issues/4472"},"comments":{"href":"https://api.github.com/repos/istio/istio.io/issues/4472/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.io/pulls/4472/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.io/pulls/4472/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.io/statuses/3103eba2bb3a201fa9549057ca817fb1942de5c4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"howardjohn"}}