{"action":"closed","number":418,"pull_request":{"url":"https://api.github.com/repos/kubeflow/kfserving/pulls/418","id":325179071,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1MTc5MDcx","html_url":"https://github.com/kubeflow/kfserving/pull/418","diff_url":"https://github.com/kubeflow/kfserving/pull/418.diff","patch_url":"https://github.com/kubeflow/kfserving/pull/418.patch","issue_url":"https://api.github.com/repos/kubeflow/kfserving/issues/418","number":418,"state":"closed","locked":false,"title":"Request Logging - Control Plane Spec","user":{"login":"cliveseldon","id":10563075,"node_id":"MDQ6VXNlcjEwNTYzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10563075?v=4","gravatar_id":"","url":"https://api.github.com/users/cliveseldon","html_url":"https://github.com/cliveseldon","followers_url":"https://api.github.com/users/cliveseldon/followers","following_url":"https://api.github.com/users/cliveseldon/following{/other_user}","gists_url":"https://api.github.com/users/cliveseldon/gists{/gist_id}","starred_url":"https://api.github.com/users/cliveseldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliveseldon/subscriptions","organizations_url":"https://api.github.com/users/cliveseldon/orgs","repos_url":"https://api.github.com/users/cliveseldon/repos","events_url":"https://api.github.com/users/cliveseldon/events{/privacy}","received_events_url":"https://api.github.com/users/cliveseldon/received_events","type":"User","site_admin":false},"body":"Proposal for request logging as initial discussed in community call.\r\n\r\nFrom discussion with the Istio team it is suggested that request logging not be an istio addition but part of our application. A simple solution suggested is to add to Transformer. The base Transformer image will if request logging Sink is provided in spec send request and response to the sink. \r\n\r\n * Request Logging is an optional addition to Transformer spec.\r\n * It will be handled automatically by base python Transformer code.\r\n * If user only specifies `requestLogging` and no Transformer Custom container then the base Transformer code is run which will simply call Predictor and send request and response to Sink specified.\r\n\r\nThe Sink Object Reference is an Addressable Duck Type. It could be a Knative channel abstracting over a particular implementation, e.g. Kafka channel. It is the user's responsibility to ensure a valid Sink exists with the given ObjectReference.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kfserving/418)\n<!-- Reviewable:end -->\n","created_at":"2019-10-07T08:15:48Z","updated_at":"2019-10-18T13:23:37Z","closed_at":"2019-10-18T13:23:37Z","merged_at":null,"merge_commit_sha":"0519445f7d8c986983e8495ccb03d9a513ac7f20","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bhupc","id":302338,"node_id":"MDQ6VXNlcjMwMjMzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/302338?v=4","gravatar_id":"","url":"https://api.github.com/users/bhupc","html_url":"https://github.com/bhupc","followers_url":"https://api.github.com/users/bhupc/followers","following_url":"https://api.github.com/users/bhupc/following{/other_user}","gists_url":"https://api.github.com/users/bhupc/gists{/gist_id}","starred_url":"https://api.github.com/users/bhupc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhupc/subscriptions","organizations_url":"https://api.github.com/users/bhupc/orgs","repos_url":"https://api.github.com/users/bhupc/repos","events_url":"https://api.github.com/users/bhupc/events{/privacy}","received_events_url":"https://api.github.com/users/bhupc/received_events","type":"User","site_admin":false},{"login":"gaocegege","id":5100735,"node_id":"MDQ6VXNlcjUxMDA3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1292699362,"node_id":"MDU6TGFiZWwxMjkyNjk5MzYy","url":"https://api.github.com/repos/kubeflow/kfserving/labels/size/XS","name":"size/XS","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/418/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/418/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kfserving/issues/418/comments","statuses_url":"https://api.github.com/repos/kubeflow/kfserving/statuses/33afe9059adedbaa27cf0d6d787fe5b41633bb8a","head":{"label":"cliveseldon:request_logging","ref":"request_logging","sha":"33afe9059adedbaa27cf0d6d787fe5b41633bb8a","user":{"login":"cliveseldon","id":10563075,"node_id":"MDQ6VXNlcjEwNTYzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10563075?v=4","gravatar_id":"","url":"https://api.github.com/users/cliveseldon","html_url":"https://github.com/cliveseldon","followers_url":"https://api.github.com/users/cliveseldon/followers","following_url":"https://api.github.com/users/cliveseldon/following{/other_user}","gists_url":"https://api.github.com/users/cliveseldon/gists{/gist_id}","starred_url":"https://api.github.com/users/cliveseldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliveseldon/subscriptions","organizations_url":"https://api.github.com/users/cliveseldon/orgs","repos_url":"https://api.github.com/users/cliveseldon/repos","events_url":"https://api.github.com/users/cliveseldon/events{/privacy}","received_events_url":"https://api.github.com/users/cliveseldon/received_events","type":"User","site_admin":false},"repo":{"id":180375888,"node_id":"MDEwOlJlcG9zaXRvcnkxODAzNzU4ODg=","name":"kfserving","full_name":"cliveseldon/kfserving","private":false,"owner":{"login":"cliveseldon","id":10563075,"node_id":"MDQ6VXNlcjEwNTYzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10563075?v=4","gravatar_id":"","url":"https://api.github.com/users/cliveseldon","html_url":"https://github.com/cliveseldon","followers_url":"https://api.github.com/users/cliveseldon/followers","following_url":"https://api.github.com/users/cliveseldon/following{/other_user}","gists_url":"https://api.github.com/users/cliveseldon/gists{/gist_id}","starred_url":"https://api.github.com/users/cliveseldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliveseldon/subscriptions","organizations_url":"https://api.github.com/users/cliveseldon/orgs","repos_url":"https://api.github.com/users/cliveseldon/repos","events_url":"https://api.github.com/users/cliveseldon/events{/privacy}","received_events_url":"https://api.github.com/users/cliveseldon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cliveseldon/kfserving","description":"Model serving related infrastructure in Kubeflow","fork":true,"url":"https://api.github.com/repos/cliveseldon/kfserving","forks_url":"https://api.github.com/repos/cliveseldon/kfserving/forks","keys_url":"https://api.github.com/repos/cliveseldon/kfserving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cliveseldon/kfserving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cliveseldon/kfserving/teams","hooks_url":"https://api.github.com/repos/cliveseldon/kfserving/hooks","issue_events_url":"https://api.github.com/repos/cliveseldon/kfserving/issues/events{/number}","events_url":"https://api.github.com/repos/cliveseldon/kfserving/events","assignees_url":"https://api.github.com/repos/cliveseldon/kfserving/assignees{/user}","branches_url":"https://api.github.com/repos/cliveseldon/kfserving/branches{/branch}","tags_url":"https://api.github.com/repos/cliveseldon/kfserving/tags","blobs_url":"https://api.github.com/repos/cliveseldon/kfserving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cliveseldon/kfserving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cliveseldon/kfserving/git/refs{/sha}","trees_url":"https://api.github.com/repos/cliveseldon/kfserving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cliveseldon/kfserving/statuses/{sha}","languages_url":"https://api.github.com/repos/cliveseldon/kfserving/languages","stargazers_url":"https://api.github.com/repos/cliveseldon/kfserving/stargazers","contributors_url":"https://api.github.com/repos/cliveseldon/kfserving/contributors","subscribers_url":"https://api.github.com/repos/cliveseldon/kfserving/subscribers","subscription_url":"https://api.github.com/repos/cliveseldon/kfserving/subscription","commits_url":"https://api.github.com/repos/cliveseldon/kfserving/commits{/sha}","git_commits_url":"https://api.github.com/repos/cliveseldon/kfserving/git/commits{/sha}","comments_url":"https://api.github.com/repos/cliveseldon/kfserving/comments{/number}","issue_comment_url":"https://api.github.com/repos/cliveseldon/kfserving/issues/comments{/number}","contents_url":"https://api.github.com/repos/cliveseldon/kfserving/contents/{+path}","compare_url":"https://api.github.com/repos/cliveseldon/kfserving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cliveseldon/kfserving/merges","archive_url":"https://api.github.com/repos/cliveseldon/kfserving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cliveseldon/kfserving/downloads","issues_url":"https://api.github.com/repos/cliveseldon/kfserving/issues{/number}","pulls_url":"https://api.github.com/repos/cliveseldon/kfserving/pulls{/number}","milestones_url":"https://api.github.com/repos/cliveseldon/kfserving/milestones{/number}","notifications_url":"https://api.github.com/repos/cliveseldon/kfserving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cliveseldon/kfserving/labels{/name}","releases_url":"https://api.github.com/repos/cliveseldon/kfserving/releases{/id}","deployments_url":"https://api.github.com/repos/cliveseldon/kfserving/deployments","created_at":"2019-04-09T13:42:08Z","updated_at":"2019-10-18T13:02:31Z","pushed_at":"2019-10-18T13:02:29Z","git_url":"git://github.com/cliveseldon/kfserving.git","ssh_url":"git@github.com:cliveseldon/kfserving.git","clone_url":"https://github.com/cliveseldon/kfserving.git","svn_url":"https://github.com/cliveseldon/kfserving","homepage":null,"size":81724,"stargazers_count":1,"watchers_count":1,"language":"Jsonnet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"7cf284d074326123f3fc7cd489991a62ae8830c8","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":178075572,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgwNzU1NzI=","name":"kfserving","full_name":"kubeflow/kfserving","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/kfserving","description":"Serverless Inferencing on Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kfserving","forks_url":"https://api.github.com/repos/kubeflow/kfserving/forks","keys_url":"https://api.github.com/repos/kubeflow/kfserving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kfserving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kfserving/teams","hooks_url":"https://api.github.com/repos/kubeflow/kfserving/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kfserving/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kfserving/events","assignees_url":"https://api.github.com/repos/kubeflow/kfserving/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kfserving/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kfserving/tags","blobs_url":"https://api.github.com/repos/kubeflow/kfserving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kfserving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kfserving/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kfserving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kfserving/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kfserving/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kfserving/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kfserving/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kfserving/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kfserving/subscription","commits_url":"https://api.github.com/repos/kubeflow/kfserving/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kfserving/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kfserving/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kfserving/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kfserving/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kfserving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kfserving/merges","archive_url":"https://api.github.com/repos/kubeflow/kfserving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kfserving/downloads","issues_url":"https://api.github.com/repos/kubeflow/kfserving/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kfserving/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kfserving/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kfserving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kfserving/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kfserving/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kfserving/deployments","created_at":"2019-03-27T21:14:14Z","updated_at":"2019-10-18T05:54:00Z","pushed_at":"2019-10-18T05:53:58Z","git_url":"git://github.com/kubeflow/kfserving.git","ssh_url":"git@github.com:kubeflow/kfserving.git","clone_url":"https://github.com/kubeflow/kfserving.git","svn_url":"https://github.com/kubeflow/kfserving","homepage":"","size":249955,"stargazers_count":189,"watchers_count":189,"language":"Jsonnet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":78,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":62,"open_issues":78,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/418"},"html":{"href":"https://github.com/kubeflow/kfserving/pull/418"},"issue":{"href":"https://api.github.com/repos/kubeflow/kfserving/issues/418"},"comments":{"href":"https://api.github.com/repos/kubeflow/kfserving/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kfserving/statuses/33afe9059adedbaa27cf0d6d787fe5b41633bb8a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"cliveseldon"}}