{"action":"closed","number":308,"pull_request":{"url":"https://api.github.com/repos/Availity/availity-react/pulls/308","id":323202477,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMjAyNDc3","html_url":"https://github.com/Availity/availity-react/pull/308","diff_url":"https://github.com/Availity/availity-react/pull/308.diff","patch_url":"https://github.com/Availity/availity-react/pull/308.patch","issue_url":"https://api.github.com/repos/Availity/availity-react/issues/308","number":308,"state":"closed","locked":false,"title":"fix(form): uses inputid attribute or generates uuid #303","user":{"login":"agawish","id":87614,"node_id":"MDQ6VXNlcjg3NjE0","avatar_url":"https://avatars0.githubusercontent.com/u/87614?v=4","gravatar_id":"","url":"https://api.github.com/users/agawish","html_url":"https://github.com/agawish","followers_url":"https://api.github.com/users/agawish/followers","following_url":"https://api.github.com/users/agawish/following{/other_user}","gists_url":"https://api.github.com/users/agawish/gists{/gist_id}","starred_url":"https://api.github.com/users/agawish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agawish/subscriptions","organizations_url":"https://api.github.com/users/agawish/orgs","repos_url":"https://api.github.com/users/agawish/repos","events_url":"https://api.github.com/users/agawish/events{/privacy}","received_events_url":"https://api.github.com/users/agawish/received_events","type":"User","site_admin":false},"body":"# What I did\r\n\r\n- Created a local variable `inputId` from `attributes.inputId` and set it to `uuid` when it is not sat and a label is present\r\n- Created 3 unit tests to check for the different scenarios when `inputId` exists or not and whether a label exists or not\r\n\r\n# How I did it\r\n\r\n1. Checked the logic for `AvSelectField` and saw that it uses `inputId` from the attributes so I followed on the same footpath\r\n2. Followed the logic of unit tests to create my unit tests\r\n3. `yarn test`\r\n4. `yarn start:docs` for good measures!\r\n\r\n# How to verify it\r\n\r\n1. Check the unit tests in `Field.test.js`:\r\n - `should generate generated uuid when id is not provided`\r\n - `label for attribute should point to field id attribute`\r\n - `should generate uuid even when label is not added`\r\n2. Run `yarn start:docs` for good measures\r\n\r\n# A picture of a cute animal\r\n![dog-3029701_640](https://user-images.githubusercontent.com/87614/65955388-e8201500-e43f-11e9-8339-2a9b1ddc9d9d.jpg)\r\n\r\nFixes #303 \r\n\r\n","created_at":"2019-10-01T10:38:14Z","updated_at":"2019-10-01T18:19:14Z","closed_at":"2019-10-01T18:19:13Z","merged_at":"2019-10-01T18:19:13Z","merge_commit_sha":"7544613593bf38d637bcd80a37b12a230f2513fc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TheSharpieOne","id":664714,"node_id":"MDQ6VXNlcjY2NDcxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/664714?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSharpieOne","html_url":"https://github.com/TheSharpieOne","followers_url":"https://api.github.com/users/TheSharpieOne/followers","following_url":"https://api.github.com/users/TheSharpieOne/following{/other_user}","gists_url":"https://api.github.com/users/TheSharpieOne/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSharpieOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSharpieOne/subscriptions","organizations_url":"https://api.github.com/users/TheSharpieOne/orgs","repos_url":"https://api.github.com/users/TheSharpieOne/repos","events_url":"https://api.github.com/users/TheSharpieOne/events{/privacy}","received_events_url":"https://api.github.com/users/TheSharpieOne/received_events","type":"User","site_admin":false},{"login":"nylon22","id":2113576,"node_id":"MDQ6VXNlcjIxMTM1NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2113576?v=4","gravatar_id":"","url":"https://api.github.com/users/nylon22","html_url":"https://github.com/nylon22","followers_url":"https://api.github.com/users/nylon22/followers","following_url":"https://api.github.com/users/nylon22/following{/other_user}","gists_url":"https://api.github.com/users/nylon22/gists{/gist_id}","starred_url":"https://api.github.com/users/nylon22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylon22/subscriptions","organizations_url":"https://api.github.com/users/nylon22/orgs","repos_url":"https://api.github.com/users/nylon22/repos","events_url":"https://api.github.com/users/nylon22/events{/privacy}","received_events_url":"https://api.github.com/users/nylon22/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Availity/availity-react/pulls/308/commits","review_comments_url":"https://api.github.com/repos/Availity/availity-react/pulls/308/comments","review_comment_url":"https://api.github.com/repos/Availity/availity-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Availity/availity-react/issues/308/comments","statuses_url":"https://api.github.com/repos/Availity/availity-react/statuses/0e792d17f996dee86c3d29ccbfeb891a3776f4a6","head":{"label":"agawish:Fix-for-303","ref":"Fix-for-303","sha":"0e792d17f996dee86c3d29ccbfeb891a3776f4a6","user":{"login":"agawish","id":87614,"node_id":"MDQ6VXNlcjg3NjE0","avatar_url":"https://avatars0.githubusercontent.com/u/87614?v=4","gravatar_id":"","url":"https://api.github.com/users/agawish","html_url":"https://github.com/agawish","followers_url":"https://api.github.com/users/agawish/followers","following_url":"https://api.github.com/users/agawish/following{/other_user}","gists_url":"https://api.github.com/users/agawish/gists{/gist_id}","starred_url":"https://api.github.com/users/agawish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agawish/subscriptions","organizations_url":"https://api.github.com/users/agawish/orgs","repos_url":"https://api.github.com/users/agawish/repos","events_url":"https://api.github.com/users/agawish/events{/privacy}","received_events_url":"https://api.github.com/users/agawish/received_events","type":"User","site_admin":false},"repo":{"id":211914942,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE5MTQ5NDI=","name":"availity-react","full_name":"agawish/availity-react","private":false,"owner":{"login":"agawish","id":87614,"node_id":"MDQ6VXNlcjg3NjE0","avatar_url":"https://avatars0.githubusercontent.com/u/87614?v=4","gravatar_id":"","url":"https://api.github.com/users/agawish","html_url":"https://github.com/agawish","followers_url":"https://api.github.com/users/agawish/followers","following_url":"https://api.github.com/users/agawish/following{/other_user}","gists_url":"https://api.github.com/users/agawish/gists{/gist_id}","starred_url":"https://api.github.com/users/agawish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agawish/subscriptions","organizations_url":"https://api.github.com/users/agawish/orgs","repos_url":"https://api.github.com/users/agawish/repos","events_url":"https://api.github.com/users/agawish/events{/privacy}","received_events_url":"https://api.github.com/users/agawish/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agawish/availity-react","description":"React components using Availity UIKit and Bootstrap 4","fork":true,"url":"https://api.github.com/repos/agawish/availity-react","forks_url":"https://api.github.com/repos/agawish/availity-react/forks","keys_url":"https://api.github.com/repos/agawish/availity-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agawish/availity-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agawish/availity-react/teams","hooks_url":"https://api.github.com/repos/agawish/availity-react/hooks","issue_events_url":"https://api.github.com/repos/agawish/availity-react/issues/events{/number}","events_url":"https://api.github.com/repos/agawish/availity-react/events","assignees_url":"https://api.github.com/repos/agawish/availity-react/assignees{/user}","branches_url":"https://api.github.com/repos/agawish/availity-react/branches{/branch}","tags_url":"https://api.github.com/repos/agawish/availity-react/tags","blobs_url":"https://api.github.com/repos/agawish/availity-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agawish/availity-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agawish/availity-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/agawish/availity-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agawish/availity-react/statuses/{sha}","languages_url":"https://api.github.com/repos/agawish/availity-react/languages","stargazers_url":"https://api.github.com/repos/agawish/availity-react/stargazers","contributors_url":"https://api.github.com/repos/agawish/availity-react/contributors","subscribers_url":"https://api.github.com/repos/agawish/availity-react/subscribers","subscription_url":"https://api.github.com/repos/agawish/availity-react/subscription","commits_url":"https://api.github.com/repos/agawish/availity-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/agawish/availity-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/agawish/availity-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/agawish/availity-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/agawish/availity-react/contents/{+path}","compare_url":"https://api.github.com/repos/agawish/availity-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agawish/availity-react/merges","archive_url":"https://api.github.com/repos/agawish/availity-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agawish/availity-react/downloads","issues_url":"https://api.github.com/repos/agawish/availity-react/issues{/number}","pulls_url":"https://api.github.com/repos/agawish/availity-react/pulls{/number}","milestones_url":"https://api.github.com/repos/agawish/availity-react/milestones{/number}","notifications_url":"https://api.github.com/repos/agawish/availity-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agawish/availity-react/labels{/name}","releases_url":"https://api.github.com/repos/agawish/availity-react/releases{/id}","deployments_url":"https://api.github.com/repos/agawish/availity-react/deployments","created_at":"2019-09-30T17:23:13Z","updated_at":"2019-09-30T17:23:15Z","pushed_at":"2019-10-01T17:13:18Z","git_url":"git://github.com/agawish/availity-react.git","ssh_url":"git@github.com:agawish/availity-react.git","clone_url":"https://github.com/agawish/availity-react.git","svn_url":"https://github.com/agawish/availity-react","homepage":"https://availity.github.io/availity-react","size":40863,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Availity:master","ref":"master","sha":"6fe072bb3c04d80dca65fdba8fe9f18aa6a2889a","user":{"login":"Availity","id":329985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTk4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/329985?v=4","gravatar_id":"","url":"https://api.github.com/users/Availity","html_url":"https://github.com/Availity","followers_url":"https://api.github.com/users/Availity/followers","following_url":"https://api.github.com/users/Availity/following{/other_user}","gists_url":"https://api.github.com/users/Availity/gists{/gist_id}","starred_url":"https://api.github.com/users/Availity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Availity/subscriptions","organizations_url":"https://api.github.com/users/Availity/orgs","repos_url":"https://api.github.com/users/Availity/repos","events_url":"https://api.github.com/users/Availity/events{/privacy}","received_events_url":"https://api.github.com/users/Availity/received_events","type":"Organization","site_admin":false},"repo":{"id":113701916,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM3MDE5MTY=","name":"availity-react","full_name":"Availity/availity-react","private":false,"owner":{"login":"Availity","id":329985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTk4NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/329985?v=4","gravatar_id":"","url":"https://api.github.com/users/Availity","html_url":"https://github.com/Availity","followers_url":"https://api.github.com/users/Availity/followers","following_url":"https://api.github.com/users/Availity/following{/other_user}","gists_url":"https://api.github.com/users/Availity/gists{/gist_id}","starred_url":"https://api.github.com/users/Availity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Availity/subscriptions","organizations_url":"https://api.github.com/users/Availity/orgs","repos_url":"https://api.github.com/users/Availity/repos","events_url":"https://api.github.com/users/Availity/events{/privacy}","received_events_url":"https://api.github.com/users/Availity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Availity/availity-react","description":"React components using Availity UIKit and Bootstrap 4","fork":false,"url":"https://api.github.com/repos/Availity/availity-react","forks_url":"https://api.github.com/repos/Availity/availity-react/forks","keys_url":"https://api.github.com/repos/Availity/availity-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Availity/availity-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Availity/availity-react/teams","hooks_url":"https://api.github.com/repos/Availity/availity-react/hooks","issue_events_url":"https://api.github.com/repos/Availity/availity-react/issues/events{/number}","events_url":"https://api.github.com/repos/Availity/availity-react/events","assignees_url":"https://api.github.com/repos/Availity/availity-react/assignees{/user}","branches_url":"https://api.github.com/repos/Availity/availity-react/branches{/branch}","tags_url":"https://api.github.com/repos/Availity/availity-react/tags","blobs_url":"https://api.github.com/repos/Availity/availity-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Availity/availity-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Availity/availity-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Availity/availity-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Availity/availity-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Availity/availity-react/languages","stargazers_url":"https://api.github.com/repos/Availity/availity-react/stargazers","contributors_url":"https://api.github.com/repos/Availity/availity-react/contributors","subscribers_url":"https://api.github.com/repos/Availity/availity-react/subscribers","subscription_url":"https://api.github.com/repos/Availity/availity-react/subscription","commits_url":"https://api.github.com/repos/Availity/availity-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Availity/availity-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Availity/availity-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Availity/availity-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Availity/availity-react/contents/{+path}","compare_url":"https://api.github.com/repos/Availity/availity-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Availity/availity-react/merges","archive_url":"https://api.github.com/repos/Availity/availity-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Availity/availity-react/downloads","issues_url":"https://api.github.com/repos/Availity/availity-react/issues{/number}","pulls_url":"https://api.github.com/repos/Availity/availity-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Availity/availity-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Availity/availity-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Availity/availity-react/labels{/name}","releases_url":"https://api.github.com/repos/Availity/availity-react/releases{/id}","deployments_url":"https://api.github.com/repos/Availity/availity-react/deployments","created_at":"2017-12-09T21:18:07Z","updated_at":"2019-10-01T18:12:06Z","pushed_at":"2019-10-01T18:19:13Z","git_url":"git://github.com/Availity/availity-react.git","ssh_url":"git@github.com:Availity/availity-react.git","clone_url":"https://github.com/Availity/availity-react.git","svn_url":"https://github.com/Availity/availity-react","homepage":"https://availity.github.io/availity-react","size":46243,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":9,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Availity/availity-react/pulls/308"},"html":{"href":"https://github.com/Availity/availity-react/pull/308"},"issue":{"href":"https://api.github.com/repos/Availity/availity-react/issues/308"},"comments":{"href":"https://api.github.com/repos/Availity/availity-react/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/Availity/availity-react/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/Availity/availity-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Availity/availity-react/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/Availity/availity-react/statuses/0e792d17f996dee86c3d29ccbfeb891a3776f4a6"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"GoPro16","id":14143881,"node_id":"MDQ6VXNlcjE0MTQzODgx","avatar_url":"https://avatars2.githubusercontent.com/u/14143881?v=4","gravatar_id":"","url":"https://api.github.com/users/GoPro16","html_url":"https://github.com/GoPro16","followers_url":"https://api.github.com/users/GoPro16/followers","following_url":"https://api.github.com/users/GoPro16/following{/other_user}","gists_url":"https://api.github.com/users/GoPro16/gists{/gist_id}","starred_url":"https://api.github.com/users/GoPro16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoPro16/subscriptions","organizations_url":"https://api.github.com/users/GoPro16/orgs","repos_url":"https://api.github.com/users/GoPro16/repos","events_url":"https://api.github.com/users/GoPro16/events{/privacy}","received_events_url":"https://api.github.com/users/GoPro16/received_events","type":"User","site_admin":false},"comments":1,"review_comments":8,"maintainer_can_modify":false,"commits":4,"additions":44,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"GoPro16"}}