{"action":"created","comment":{"url":"https://api.github.com/repos/nrepl/nrepl/pulls/comments/253307554","pull_request_review_id":199393140,"id":253307554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzMwNzU1NA==","diff_hunk":"@@ -48,3 +53,23 @@\n                                                (-> session meta :id)\n                                                session)}))]\n     (merge basis response)))\n+\n+(defn requiring-resolve","path":"src/clojure/nrepl/misc.clj","position":15,"original_position":19,"commit_id":"6ae730434d0dc1d75ec7dba62419fd5c1e008632","original_commit_id":"528d93947e8fd47b6e9a4d1b0de9002e925758c8","user":{"login":"cichli","id":1759291,"node_id":"MDQ6VXNlcjE3NTkyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1759291?v=4","gravatar_id":"","url":"https://api.github.com/users/cichli","html_url":"https://github.com/cichli","followers_url":"https://api.github.com/users/cichli/followers","following_url":"https://api.github.com/users/cichli/following{/other_user}","gists_url":"https://api.github.com/users/cichli/gists{/gist_id}","starred_url":"https://api.github.com/users/cichli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cichli/subscriptions","organizations_url":"https://api.github.com/users/cichli/orgs","repos_url":"https://api.github.com/users/cichli/repos","events_url":"https://api.github.com/users/cichli/events{/privacy}","received_events_url":"https://api.github.com/users/cichli/received_events","type":"User","site_admin":false},"body":"Will do.","created_at":"2019-02-03T15:54:42Z","updated_at":"2019-02-03T15:54:42Z","html_url":"https://github.com/nrepl/nrepl/pull/128#discussion_r253307554","pull_request_url":"https://api.github.com/repos/nrepl/nrepl/pulls/128","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nrepl/nrepl/pulls/comments/253307554"},"html":{"href":"https://github.com/nrepl/nrepl/pull/128#discussion_r253307554"},"pull_request":{"href":"https://api.github.com/repos/nrepl/nrepl/pulls/128"}},"in_reply_to_id":253298639},"pull_request":{"url":"https://api.github.com/repos/nrepl/nrepl/pulls/128","id":248914305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4OTE0MzA1","html_url":"https://github.com/nrepl/nrepl/pull/128","diff_url":"https://github.com/nrepl/nrepl/pull/128.diff","patch_url":"https://github.com/nrepl/nrepl/pull/128.patch","issue_url":"https://api.github.com/repos/nrepl/nrepl/issues/128","number":128,"state":"open","locked":false,"title":"Add middleware for handling evaluation errors","user":{"login":"cichli","id":1759291,"node_id":"MDQ6VXNlcjE3NTkyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1759291?v=4","gravatar_id":"","url":"https://api.github.com/users/cichli","html_url":"https://github.com/cichli","followers_url":"https://api.github.com/users/cichli/followers","following_url":"https://api.github.com/users/cichli/following{/other_user}","gists_url":"https://api.github.com/users/cichli/gists{/gist_id}","starred_url":"https://api.github.com/users/cichli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cichli/subscriptions","organizations_url":"https://api.github.com/users/cichli/orgs","repos_url":"https://api.github.com/users/cichli/repos","events_url":"https://api.github.com/users/cichli/events{/privacy}","received_events_url":"https://api.github.com/users/cichli/received_events","type":"User","site_admin":false},"body":"Since #101 we only update the session atom in the `:prompt` REPL phase. This means any middlewares using `(get @session #'*e)` during the `:caught` phase to access the thrown error will no longer work (`cider.nrepl.middleware.inspect` is the case that I have found). Arguably that was relying on an implementation detail of nREPL – I think a better way is to simply convey the thrown error as a value in the response, and handle it elsewhere.\r\n\r\nFor now we just call `clojure.main/repl-caught` on the error as before, and still return `ex` / `root-ex` from eval to maintain compatibility. In the future, we can look at making it configurable.","created_at":"2019-01-30T15:15:55Z","updated_at":"2019-02-03T15:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0580d56b1f9bcf31eb223137f4518cebc7188819","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nrepl/nrepl/pulls/128/commits","review_comments_url":"https://api.github.com/repos/nrepl/nrepl/pulls/128/comments","review_comment_url":"https://api.github.com/repos/nrepl/nrepl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nrepl/nrepl/issues/128/comments","statuses_url":"https://api.github.com/repos/nrepl/nrepl/statuses/6ae730434d0dc1d75ec7dba62419fd5c1e008632","head":{"label":"cichli:caught","ref":"caught","sha":"6ae730434d0dc1d75ec7dba62419fd5c1e008632","user":{"login":"cichli","id":1759291,"node_id":"MDQ6VXNlcjE3NTkyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1759291?v=4","gravatar_id":"","url":"https://api.github.com/users/cichli","html_url":"https://github.com/cichli","followers_url":"https://api.github.com/users/cichli/followers","following_url":"https://api.github.com/users/cichli/following{/other_user}","gists_url":"https://api.github.com/users/cichli/gists{/gist_id}","starred_url":"https://api.github.com/users/cichli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cichli/subscriptions","organizations_url":"https://api.github.com/users/cichli/orgs","repos_url":"https://api.github.com/users/cichli/repos","events_url":"https://api.github.com/users/cichli/events{/privacy}","received_events_url":"https://api.github.com/users/cichli/received_events","type":"User","site_admin":false},"repo":{"id":164011651,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwMTE2NTE=","name":"nrepl","full_name":"cichli/nrepl","private":false,"owner":{"login":"cichli","id":1759291,"node_id":"MDQ6VXNlcjE3NTkyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1759291?v=4","gravatar_id":"","url":"https://api.github.com/users/cichli","html_url":"https://github.com/cichli","followers_url":"https://api.github.com/users/cichli/followers","following_url":"https://api.github.com/users/cichli/following{/other_user}","gists_url":"https://api.github.com/users/cichli/gists{/gist_id}","starred_url":"https://api.github.com/users/cichli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cichli/subscriptions","organizations_url":"https://api.github.com/users/cichli/orgs","repos_url":"https://api.github.com/users/cichli/repos","events_url":"https://api.github.com/users/cichli/events{/privacy}","received_events_url":"https://api.github.com/users/cichli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cichli/nrepl","description":"A Clojure network REPL that provides a server and client, along with some common APIs of use to IDEs and other tools that may need to evaluate Clojure code in remote environments.","fork":true,"url":"https://api.github.com/repos/cichli/nrepl","forks_url":"https://api.github.com/repos/cichli/nrepl/forks","keys_url":"https://api.github.com/repos/cichli/nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cichli/nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cichli/nrepl/teams","hooks_url":"https://api.github.com/repos/cichli/nrepl/hooks","issue_events_url":"https://api.github.com/repos/cichli/nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/cichli/nrepl/events","assignees_url":"https://api.github.com/repos/cichli/nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/cichli/nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/cichli/nrepl/tags","blobs_url":"https://api.github.com/repos/cichli/nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cichli/nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cichli/nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cichli/nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cichli/nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/cichli/nrepl/languages","stargazers_url":"https://api.github.com/repos/cichli/nrepl/stargazers","contributors_url":"https://api.github.com/repos/cichli/nrepl/contributors","subscribers_url":"https://api.github.com/repos/cichli/nrepl/subscribers","subscription_url":"https://api.github.com/repos/cichli/nrepl/subscription","commits_url":"https://api.github.com/repos/cichli/nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cichli/nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cichli/nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cichli/nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cichli/nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/cichli/nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cichli/nrepl/merges","archive_url":"https://api.github.com/repos/cichli/nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cichli/nrepl/downloads","issues_url":"https://api.github.com/repos/cichli/nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/cichli/nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/cichli/nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/cichli/nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cichli/nrepl/labels{/name}","releases_url":"https://api.github.com/repos/cichli/nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/cichli/nrepl/deployments","created_at":"2019-01-03T19:00:05Z","updated_at":"2019-01-29T22:31:39Z","pushed_at":"2019-02-03T15:54:12Z","git_url":"git://github.com/cichli/nrepl.git","ssh_url":"git@github.com:cichli/nrepl.git","clone_url":"https://github.com/cichli/nrepl.git","svn_url":"https://github.com/cichli/nrepl","homepage":"https://nrepl.org","size":1707,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nrepl:master","ref":"master","sha":"754a73c1512bf9255769b6dca1dedfa49f69e882","user":{"login":"nrepl","id":39378471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Mzc4NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/39378471?v=4","gravatar_id":"","url":"https://api.github.com/users/nrepl","html_url":"https://github.com/nrepl","followers_url":"https://api.github.com/users/nrepl/followers","following_url":"https://api.github.com/users/nrepl/following{/other_user}","gists_url":"https://api.github.com/users/nrepl/gists{/gist_id}","starred_url":"https://api.github.com/users/nrepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrepl/subscriptions","organizations_url":"https://api.github.com/users/nrepl/orgs","repos_url":"https://api.github.com/users/nrepl/repos","events_url":"https://api.github.com/users/nrepl/events{/privacy}","received_events_url":"https://api.github.com/users/nrepl/received_events","type":"Organization","site_admin":false},"repo":{"id":928777,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjg3Nzc=","name":"nrepl","full_name":"nrepl/nrepl","private":false,"owner":{"login":"nrepl","id":39378471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Mzc4NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/39378471?v=4","gravatar_id":"","url":"https://api.github.com/users/nrepl","html_url":"https://github.com/nrepl","followers_url":"https://api.github.com/users/nrepl/followers","following_url":"https://api.github.com/users/nrepl/following{/other_user}","gists_url":"https://api.github.com/users/nrepl/gists{/gist_id}","starred_url":"https://api.github.com/users/nrepl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrepl/subscriptions","organizations_url":"https://api.github.com/users/nrepl/orgs","repos_url":"https://api.github.com/users/nrepl/repos","events_url":"https://api.github.com/users/nrepl/events{/privacy}","received_events_url":"https://api.github.com/users/nrepl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nrepl/nrepl","description":"A Clojure network REPL that provides a server and client, along with some common APIs of use to IDEs and other tools that may need to evaluate Clojure code in remote environments.","fork":false,"url":"https://api.github.com/repos/nrepl/nrepl","forks_url":"https://api.github.com/repos/nrepl/nrepl/forks","keys_url":"https://api.github.com/repos/nrepl/nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrepl/nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrepl/nrepl/teams","hooks_url":"https://api.github.com/repos/nrepl/nrepl/hooks","issue_events_url":"https://api.github.com/repos/nrepl/nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/nrepl/nrepl/events","assignees_url":"https://api.github.com/repos/nrepl/nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/nrepl/nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/nrepl/nrepl/tags","blobs_url":"https://api.github.com/repos/nrepl/nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrepl/nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrepl/nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrepl/nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrepl/nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/nrepl/nrepl/languages","stargazers_url":"https://api.github.com/repos/nrepl/nrepl/stargazers","contributors_url":"https://api.github.com/repos/nrepl/nrepl/contributors","subscribers_url":"https://api.github.com/repos/nrepl/nrepl/subscribers","subscription_url":"https://api.github.com/repos/nrepl/nrepl/subscription","commits_url":"https://api.github.com/repos/nrepl/nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrepl/nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrepl/nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrepl/nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrepl/nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/nrepl/nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrepl/nrepl/merges","archive_url":"https://api.github.com/repos/nrepl/nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrepl/nrepl/downloads","issues_url":"https://api.github.com/repos/nrepl/nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/nrepl/nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/nrepl/nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/nrepl/nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrepl/nrepl/labels{/name}","releases_url":"https://api.github.com/repos/nrepl/nrepl/releases{/id}","deployments_url":"https://api.github.com/repos/nrepl/nrepl/deployments","created_at":"2010-09-21T20:22:01Z","updated_at":"2019-01-30T11:34:39Z","pushed_at":"2019-02-03T15:54:14Z","git_url":"git://github.com/nrepl/nrepl.git","ssh_url":"git@github.com:nrepl/nrepl.git","clone_url":"https://github.com/nrepl/nrepl.git","svn_url":"https://github.com/nrepl/nrepl","homepage":"https://nrepl.org","size":1706,"stargazers_count":229,"watchers_count":229,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":34,"open_issues":32,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nrepl/nrepl/pulls/128"},"html":{"href":"https://github.com/nrepl/nrepl/pull/128"},"issue":{"href":"https://api.github.com/repos/nrepl/nrepl/issues/128"},"comments":{"href":"https://api.github.com/repos/nrepl/nrepl/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/nrepl/nrepl/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/nrepl/nrepl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nrepl/nrepl/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/nrepl/nrepl/statuses/6ae730434d0dc1d75ec7dba62419fd5c1e008632"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cichli"}}