{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments/321469243","pull_request_review_id":284524630,"id":321469243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMTQ2OTI0Mw==","diff_hunk":"@@ -161,6 +163,23 @@ export class MainPanel extends React.Component<IMainPanelProps, IMainPanelState>\n         );\r\n     }\r\n \r\n+    public scrollDiv = (div: HTMLDivElement) => {\r\n+        if (this.state.isAtBottom) {\r\n+            this.internalScrollCount += 1;\r\n+            div.scrollIntoView({ behavior: 'auto', block: 'start', inline: 'nearest' });\r\n+        }\r\n+    }\r\n+\r\n+    public handleScroll = (e: React.UIEvent<HTMLDivElement>) => {\r\n+        if (this.internalScrollCount > 0) {\r\n+            this.internalScrollCount -= 1;\r\n+        } else {\r\n+            this.setState({\r\n+                isAtBottom: e.currentTarget.scrollHeight - e.currentTarget.scrollTop === e.currentTarget.clientHeight\r","path":"src/datascience-ui/history-react/MainPanel.tsx","position":46,"original_position":43,"commit_id":"9420427efce74459aa7917a47a639263837a28a7","original_commit_id":"64d02028ba375e978207747311d2f7eec7b261aa","user":{"login":"DavidKutu","id":20347396,"node_id":"MDQ6VXNlcjIwMzQ3Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/20347396?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidKutu","html_url":"https://github.com/DavidKutu","followers_url":"https://api.github.com/users/DavidKutu/followers","following_url":"https://api.github.com/users/DavidKutu/following{/other_user}","gists_url":"https://api.github.com/users/DavidKutu/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidKutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidKutu/subscriptions","organizations_url":"https://api.github.com/users/DavidKutu/orgs","repos_url":"https://api.github.com/users/DavidKutu/repos","events_url":"https://api.github.com/users/DavidKutu/events{/privacy}","received_events_url":"https://api.github.com/users/DavidKutu/received_events","type":"User","site_admin":false},"body":"I don't feel its confusing, it sticks if you are all the way on the bottom. If not it stays there.","created_at":"2019-09-05T20:35:17Z","updated_at":"2019-09-05T20:35:17Z","html_url":"https://github.com/microsoft/vscode-python/pull/7198#discussion_r321469243","pull_request_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments/321469243"},"html":{"href":"https://github.com/microsoft/vscode-python/pull/7198#discussion_r321469243"},"pull_request":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198"}},"in_reply_to_id":321468507},"pull_request":{"url":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198","id":314160754,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE0MTYwNzU0","html_url":"https://github.com/microsoft/vscode-python/pull/7198","diff_url":"https://github.com/microsoft/vscode-python/pull/7198.diff","patch_url":"https://github.com/microsoft/vscode-python/pull/7198.patch","issue_url":"https://api.github.com/repos/microsoft/vscode-python/issues/7198","number":7198,"state":"open","locked":false,"title":"check the position of the scroll in the interactive","user":{"login":"DavidKutu","id":20347396,"node_id":"MDQ6VXNlcjIwMzQ3Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/20347396?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidKutu","html_url":"https://github.com/DavidKutu","followers_url":"https://api.github.com/users/DavidKutu/followers","following_url":"https://api.github.com/users/DavidKutu/following{/other_user}","gists_url":"https://api.github.com/users/DavidKutu/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidKutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidKutu/subscriptions","organizations_url":"https://api.github.com/users/DavidKutu/orgs","repos_url":"https://api.github.com/users/DavidKutu/repos","events_url":"https://api.github.com/users/DavidKutu/events{/privacy}","received_events_url":"https://api.github.com/users/DavidKutu/received_events","type":"User","site_admin":false},"body":"window, if it is at the bottom, the screen stays at the\r\nbottom, and if not, the screen stays in place.\r\nThrottling of the scroll was increased to help with\r\nconsistency on rapidly appearing plots.\r\n\r\nFor #6580\r\n\r\n- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)\r\n- [x] Title summarizes what is changing\r\n- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)\r\n- [ ] Appropriate comments and documentation strings in the code\r\n- [ ] Has sufficient logging.\r\n- [ ] Has telemetry for enhancements.\r\n- [ ] Unit tests & system/integration tests are added/updated\r\n- [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate\r\n- [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)\r\n- [ ] The wiki is updated with any design decisions/details.\r\n","created_at":"2019-09-04T18:10:00Z","updated_at":"2019-09-05T20:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad84ded0181b12b08a44e6c4e8101f0a67f68da5","assignee":{"login":"DavidKutu","id":20347396,"node_id":"MDQ6VXNlcjIwMzQ3Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/20347396?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidKutu","html_url":"https://github.com/DavidKutu","followers_url":"https://api.github.com/users/DavidKutu/followers","following_url":"https://api.github.com/users/DavidKutu/following{/other_user}","gists_url":"https://api.github.com/users/DavidKutu/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidKutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidKutu/subscriptions","organizations_url":"https://api.github.com/users/DavidKutu/orgs","repos_url":"https://api.github.com/users/DavidKutu/repos","events_url":"https://api.github.com/users/DavidKutu/events{/privacy}","received_events_url":"https://api.github.com/users/DavidKutu/received_events","type":"User","site_admin":false},"assignees":[{"login":"DavidKutu","id":20347396,"node_id":"MDQ6VXNlcjIwMzQ3Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/20347396?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidKutu","html_url":"https://github.com/DavidKutu","followers_url":"https://api.github.com/users/DavidKutu/followers","following_url":"https://api.github.com/users/DavidKutu/following{/other_user}","gists_url":"https://api.github.com/users/DavidKutu/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidKutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidKutu/subscriptions","organizations_url":"https://api.github.com/users/DavidKutu/orgs","repos_url":"https://api.github.com/users/DavidKutu/repos","events_url":"https://api.github.com/users/DavidKutu/events{/privacy}","received_events_url":"https://api.github.com/users/DavidKutu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198/commits","review_comments_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198/comments","review_comment_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/vscode-python/issues/7198/comments","statuses_url":"https://api.github.com/repos/microsoft/vscode-python/statuses/9420427efce74459aa7917a47a639263837a28a7","head":{"label":"microsoft:davidkutu/prevent_interactive_window_from_snapping_to_bottom","ref":"davidkutu/prevent_interactive_window_from_snapping_to_bottom","sha":"9420427efce74459aa7917a47a639263837a28a7","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"microsoft/vscode-python","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/microsoft/vscode-python","forks_url":"https://api.github.com/repos/microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2019-09-05T18:35:17Z","pushed_at":"2019-09-05T20:33:24Z","git_url":"git://github.com/microsoft/vscode-python.git","ssh_url":"git@github.com:microsoft/vscode-python.git","clone_url":"https://github.com/microsoft/vscode-python.git","svn_url":"https://github.com/microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":75674,"stargazers_count":1676,"watchers_count":1676,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1084,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":336,"open_issues":1084,"watchers":1676,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"4cb8d3305fe00c70090ff14cf94891434b36c419","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"microsoft/vscode-python","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/microsoft/vscode-python","forks_url":"https://api.github.com/repos/microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2019-09-05T18:35:17Z","pushed_at":"2019-09-05T20:33:24Z","git_url":"git://github.com/microsoft/vscode-python.git","ssh_url":"git@github.com:microsoft/vscode-python.git","clone_url":"https://github.com/microsoft/vscode-python.git","svn_url":"https://github.com/microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":75674,"stargazers_count":1676,"watchers_count":1676,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1084,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":336,"open_issues":1084,"watchers":1676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198"},"html":{"href":"https://github.com/microsoft/vscode-python/pull/7198"},"issue":{"href":"https://api.github.com/repos/microsoft/vscode-python/issues/7198"},"comments":{"href":"https://api.github.com/repos/microsoft/vscode-python/issues/7198/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/7198/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/vscode-python/statuses/9420427efce74459aa7917a47a639263837a28a7"}},"author_association":"NONE"}}
{"actor":{"display_login":"DavidKutu"}}