{"action":"closed","number":182,"pull_request":{"url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/182","id":255708817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NzA4ODE3","html_url":"https://github.com/dadhi/FastExpressionCompiler/pull/182","diff_url":"https://github.com/dadhi/FastExpressionCompiler/pull/182.diff","patch_url":"https://github.com/dadhi/FastExpressionCompiler/pull/182.patch","issue_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues/182","number":182,"state":"closed","locked":false,"title":"Added failing test for #181","user":{"login":"LordZoltan","id":1826395,"node_id":"MDQ6VXNlcjE4MjYzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1826395?v=4","gravatar_id":"","url":"https://api.github.com/users/LordZoltan","html_url":"https://github.com/LordZoltan","followers_url":"https://api.github.com/users/LordZoltan/followers","following_url":"https://api.github.com/users/LordZoltan/following{/other_user}","gists_url":"https://api.github.com/users/LordZoltan/gists{/gist_id}","starred_url":"https://api.github.com/users/LordZoltan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LordZoltan/subscriptions","organizations_url":"https://api.github.com/users/LordZoltan/orgs","repos_url":"https://api.github.com/users/LordZoltan/repos","events_url":"https://api.github.com/users/LordZoltan/events{/privacy}","received_events_url":"https://api.github.com/users/LordZoltan/received_events","type":"User","site_admin":false},"body":"Failing test for #181 - fails for both Linq expressions and Light expressions.\r\n\r\nThe problem is that `TryEmitIncDecAssign` only supports targets which have been emitted as local variables in a closure (so, presumably it will also not work for fields).\r\n\r\nWhen the operand is a Property, it would need to get the value via the `get` accessor, increment the result, and then write it back to the property via its set accessor; it should then push the value on the stack so it can be 'returned'.  It's been a while since I last did a lot of IL, but I think this can be done without a local.\r\n\r\nIn fact, as I was writing that, I thought that perhaps you've already done this elsewhere - and I see that `TryEmitAssign` has a strategy for the different types of left-hand targets - and, indeed, it supports Properties, as well as indexers - so it looks like `TryEmitIncDecAssign` needs to be changed to have a similar branching strategy for each potential target.\r\n\r\nI did start having a go at fixing, but I can't squeeze it into the time I have right now, sorry!  If you don't get round to it once I'm done with the stuff I'm on, then perhaps I'll try to get back to it.","created_at":"2019-02-24T20:05:16Z","updated_at":"2019-02-25T12:44:53Z","closed_at":"2019-02-25T12:44:52Z","merged_at":"2019-02-25T12:44:52Z","merge_commit_sha":"f0c8b74d9dcd3027b7d3b4c4c899d47a19ef7128","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/182/commits","review_comments_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/182/comments","review_comment_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues/182/comments","statuses_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/statuses/168a7ca7d176c537e79a45887ef660900190aa71","head":{"label":"ZolutionSoftware:master","ref":"master","sha":"168a7ca7d176c537e79a45887ef660900190aa71","user":{"login":"ZolutionSoftware","id":25297264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjk3MjY0","avatar_url":"https://avatars2.githubusercontent.com/u/25297264?v=4","gravatar_id":"","url":"https://api.github.com/users/ZolutionSoftware","html_url":"https://github.com/ZolutionSoftware","followers_url":"https://api.github.com/users/ZolutionSoftware/followers","following_url":"https://api.github.com/users/ZolutionSoftware/following{/other_user}","gists_url":"https://api.github.com/users/ZolutionSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/ZolutionSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZolutionSoftware/subscriptions","organizations_url":"https://api.github.com/users/ZolutionSoftware/orgs","repos_url":"https://api.github.com/users/ZolutionSoftware/repos","events_url":"https://api.github.com/users/ZolutionSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/ZolutionSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":172371499,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIzNzE0OTk=","name":"FastExpressionCompiler","full_name":"ZolutionSoftware/FastExpressionCompiler","private":false,"owner":{"login":"ZolutionSoftware","id":25297264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjk3MjY0","avatar_url":"https://avatars2.githubusercontent.com/u/25297264?v=4","gravatar_id":"","url":"https://api.github.com/users/ZolutionSoftware","html_url":"https://github.com/ZolutionSoftware","followers_url":"https://api.github.com/users/ZolutionSoftware/followers","following_url":"https://api.github.com/users/ZolutionSoftware/following{/other_user}","gists_url":"https://api.github.com/users/ZolutionSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/ZolutionSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZolutionSoftware/subscriptions","organizations_url":"https://api.github.com/users/ZolutionSoftware/orgs","repos_url":"https://api.github.com/users/ZolutionSoftware/repos","events_url":"https://api.github.com/users/ZolutionSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/ZolutionSoftware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ZolutionSoftware/FastExpressionCompiler","description":"Fast ExpressionTree compiler to delegate","fork":true,"url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler","forks_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/forks","keys_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/teams","hooks_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/hooks","issue_events_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/events","assignees_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/tags","blobs_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/languages","stargazers_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/stargazers","contributors_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/contributors","subscribers_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/subscribers","subscription_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/subscription","commits_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/merges","archive_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/downloads","issues_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/labels{/name}","releases_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/ZolutionSoftware/FastExpressionCompiler/deployments","created_at":"2019-02-24T18:03:27Z","updated_at":"2019-02-24T19:49:47Z","pushed_at":"2019-02-24T19:49:46Z","git_url":"git://github.com/ZolutionSoftware/FastExpressionCompiler.git","ssh_url":"git@github.com:ZolutionSoftware/FastExpressionCompiler.git","clone_url":"https://github.com/ZolutionSoftware/FastExpressionCompiler.git","svn_url":"https://github.com/ZolutionSoftware/FastExpressionCompiler","homepage":null,"size":981,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dadhi:master","ref":"master","sha":"ac9fd8c5c549ed79362c7ad4ca0a9527496b8382","user":{"login":"dadhi","id":39516,"node_id":"MDQ6VXNlcjM5NTE2","avatar_url":"https://avatars2.githubusercontent.com/u/39516?v=4","gravatar_id":"","url":"https://api.github.com/users/dadhi","html_url":"https://github.com/dadhi","followers_url":"https://api.github.com/users/dadhi/followers","following_url":"https://api.github.com/users/dadhi/following{/other_user}","gists_url":"https://api.github.com/users/dadhi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadhi/subscriptions","organizations_url":"https://api.github.com/users/dadhi/orgs","repos_url":"https://api.github.com/users/dadhi/repos","events_url":"https://api.github.com/users/dadhi/events{/privacy}","received_events_url":"https://api.github.com/users/dadhi/received_events","type":"User","site_admin":false},"repo":{"id":63421083,"node_id":"MDEwOlJlcG9zaXRvcnk2MzQyMTA4Mw==","name":"FastExpressionCompiler","full_name":"dadhi/FastExpressionCompiler","private":false,"owner":{"login":"dadhi","id":39516,"node_id":"MDQ6VXNlcjM5NTE2","avatar_url":"https://avatars2.githubusercontent.com/u/39516?v=4","gravatar_id":"","url":"https://api.github.com/users/dadhi","html_url":"https://github.com/dadhi","followers_url":"https://api.github.com/users/dadhi/followers","following_url":"https://api.github.com/users/dadhi/following{/other_user}","gists_url":"https://api.github.com/users/dadhi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadhi/subscriptions","organizations_url":"https://api.github.com/users/dadhi/orgs","repos_url":"https://api.github.com/users/dadhi/repos","events_url":"https://api.github.com/users/dadhi/events{/privacy}","received_events_url":"https://api.github.com/users/dadhi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dadhi/FastExpressionCompiler","description":"Fast ExpressionTree compiler to delegate","fork":false,"url":"https://api.github.com/repos/dadhi/FastExpressionCompiler","forks_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/forks","keys_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/teams","hooks_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/hooks","issue_events_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/events","assignees_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/tags","blobs_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/languages","stargazers_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/stargazers","contributors_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/contributors","subscribers_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/subscribers","subscription_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/subscription","commits_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/merges","archive_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/downloads","issues_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/labels{/name}","releases_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/dadhi/FastExpressionCompiler/deployments","created_at":"2016-07-15T12:44:20Z","updated_at":"2019-02-25T08:00:19Z","pushed_at":"2019-02-25T12:44:52Z","git_url":"git://github.com/dadhi/FastExpressionCompiler.git","ssh_url":"git@github.com:dadhi/FastExpressionCompiler.git","clone_url":"https://github.com/dadhi/FastExpressionCompiler.git","svn_url":"https://github.com/dadhi/FastExpressionCompiler","homepage":null,"size":1106,"stargazers_count":316,"watchers_count":316,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":25,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/182"},"html":{"href":"https://github.com/dadhi/FastExpressionCompiler/pull/182"},"issue":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues/182"},"comments":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/dadhi/FastExpressionCompiler/statuses/168a7ca7d176c537e79a45887ef660900190aa71"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dadhi","id":39516,"node_id":"MDQ6VXNlcjM5NTE2","avatar_url":"https://avatars2.githubusercontent.com/u/39516?v=4","gravatar_id":"","url":"https://api.github.com/users/dadhi","html_url":"https://github.com/dadhi","followers_url":"https://api.github.com/users/dadhi/followers","following_url":"https://api.github.com/users/dadhi/following{/other_user}","gists_url":"https://api.github.com/users/dadhi/gists{/gist_id}","starred_url":"https://api.github.com/users/dadhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadhi/subscriptions","organizations_url":"https://api.github.com/users/dadhi/orgs","repos_url":"https://api.github.com/users/dadhi/repos","events_url":"https://api.github.com/users/dadhi/events{/privacy}","received_events_url":"https://api.github.com/users/dadhi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":35,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"dadhi"}}