{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/46091","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/46091/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/46091/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/46091/events","html_url":"https://github.com/tgstation/tgstation/pull/46091","id":484272492,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwMTg4NDQx","number":46091,"title":"ATHATH finally goes off the deep end and touches   L U N G   C O D E","user":{"login":"ATH1909","id":42606352,"node_id":"MDQ6VXNlcjQyNjA2MzUy","avatar_url":"https://avatars0.githubusercontent.com/u/42606352?v=4","gravatar_id":"","url":"https://api.github.com/users/ATH1909","html_url":"https://github.com/ATH1909","followers_url":"https://api.github.com/users/ATH1909/followers","following_url":"https://api.github.com/users/ATH1909/following{/other_user}","gists_url":"https://api.github.com/users/ATH1909/gists{/gist_id}","starred_url":"https://api.github.com/users/ATH1909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ATH1909/subscriptions","organizations_url":"https://api.github.com/users/ATH1909/orgs","repos_url":"https://api.github.com/users/ATH1909/repos","events_url":"https://api.github.com/users/ATH1909/events{/privacy}","received_events_url":"https://api.github.com/users/ATH1909/received_events","type":"User","site_admin":false},"labels":[{"id":78959966,"node_id":"MDU6TGFiZWw3ODk1OTk2Ng==","url":"https://api.github.com/repos/tgstation/tgstation/labels/Balance/Rebalance","name":"Balance/Rebalance","color":"fbca04","default":false},{"id":149581322,"node_id":"MDU6TGFiZWwxNDk1ODEzMjI=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Feature","name":"Feature","color":"009800","default":false},{"id":157846355,"node_id":"MDU6TGFiZWwxNTc4NDYzNTU=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Fix","name":"Fix","color":"00bbdd","default":false},{"id":373745412,"node_id":"MDU6TGFiZWwzNzM3NDU0MTI=","url":"https://api.github.com/repos/tgstation/tgstation/labels/Tweak","name":"Tweak","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-08-23T00:19:04Z","updated_at":"2019-08-23T02:35:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/46091","html_url":"https://github.com/tgstation/tgstation/pull/46091","diff_url":"https://github.com/tgstation/tgstation/pull/46091.diff","patch_url":"https://github.com/tgstation/tgstation/pull/46091.patch"},"body":"## About The Pull Request\r\n\r\nhttps://www.youtube.com/watch?v=tCpMIe8FjEU\r\n\r\nglubtok discovered that the main intended effect of plasma fixation (standing in plasma gas heals you) didn't actually work in this issue report: https://github.com/tgstation/tgstation/issues/46055. He posted a fix for the issue in his issue report, which I have implemented in this PR. He also lamented in said issue report that plasma fixation doesn't have any interactions with you BREATHING plasma, which led me to try to figure out a way to add said interactions.\r\n\r\nThe result of my efforts is this PR.\r\n\r\nI've added two new variables to lungs. One is the all_you_need_is_plasma variable, which (basically) lets plasma count as other gases for the purposes of determining if you're suffocating from a lack of a certain gas (just setting safe_toxins_max to 0 won't work, since humans and such will still suffocate from a lack of oxygen while breathing a pure plasma mixture). The other variable is the plasma_healing variable, which causes each breath of (enough) plasma you take to heal you for one point in each of the four primary damage types (I would like to point out that you usually only breathe once per 4 ticks; in other words, this regen should be at around 1/4th the speed of the regen that podpeople in light get). The toxin healing part of this healing will heal even toxinlovers, such as jellypeople These variables have been set to TRUE for vacuoles (a.k.a. slime lungs), which means that jellypeople can now breathe plasma without suffocating and can heal while breathing plasma (it should be noted that safe_toxins_max had already been set to 0 by default for their lungs before I made this PR). Because they can now breathe plasma far more safely, the blood regeneration rate that jellypeople receive from breathing plasma has been halved in speed.\r\n\r\nThe plasma fixation virus symptom now has two additional threshold effects. The new resistance 4 threshold effect permanently sets the safe_toxins_max and all_you_need_is_plasma variables of the lungs of hosts of its virus to 0 and TRUE, respectively. The new resistance 10 threshold effect permanently sets the plasma_healing variable of the lungs of hosts of the virus to TRUE.\r\n\r\nAlso, because I was modifying heal.dmm anyway, I gave the regenerative coma symptom the ability to give hosts of its virus the TRAIT_NOCRITDAMAGE trait, which should halt the natural oxygen (or brute, if you have the TRAIT_NOBREATH trait or the like) damage from being in crit while you have the virus (unless you're a monkey or the like, I think, because non-human carbons have weird crit damage code (one part of it even directly checks for the presence epinephrine chem!)).\r\n\r\n## Why It's Good For The Game\r\n\r\nPlasma fixation's main effect literally doesn't work right now. The new threshold effects added to plasma fixation encourage creative usages of atmos and/or the purchase and distribution of plasmaman supply kits from Cargo in order to give the crew a mild healing effect. Plus, the \"ability to breathe plasma\" one is quite flavorful/cool (IMO).\r\n\r\n## Changelog\r\n:cl: ATHATH\r\nadd: The plasma fixation virus symptom now has two additional threshold effects. The new resistance 4 threshold effect gives you the ability to safely breathe even pure plasma mixtures, while the new resistance 10 threshold effect heals you each time you breathe in (a significant amount of) plasma.\r\nfix: The plasma fixation virus symptom now actually heals you while you are standing in plasma gas. Credit goes to glubtok for pointing this bug out and writing the code for this fix for it.\r\nbalance: The regenerative coma symptom now stabilizes you while you're in critical condition.\r\ntweak: Vacuoles (a.k.a. slime lungs (the lungs of jellypeople and their ilk) now allow you to safely breathe even pure plasma mixtures (instead of suffocating you due to a lack of oxygen) with them and heal whenever you breathe in a significant amount of plasma with them.\r\nbalance: Since pure plasma mixtures are no longer as harmful to jellypeople as they were before, the blood gain rate from breathing plasma with a vacuole has been halved.\r\n/:cl:"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/524149317","html_url":"https://github.com/tgstation/tgstation/pull/46091#issuecomment-524149317","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/46091","id":524149317,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNDE0OTMxNw==","user":{"login":"ATH1909","id":42606352,"node_id":"MDQ6VXNlcjQyNjA2MzUy","avatar_url":"https://avatars0.githubusercontent.com/u/42606352?v=4","gravatar_id":"","url":"https://api.github.com/users/ATH1909","html_url":"https://github.com/ATH1909","followers_url":"https://api.github.com/users/ATH1909/followers","following_url":"https://api.github.com/users/ATH1909/following{/other_user}","gists_url":"https://api.github.com/users/ATH1909/gists{/gist_id}","starred_url":"https://api.github.com/users/ATH1909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ATH1909/subscriptions","organizations_url":"https://api.github.com/users/ATH1909/orgs","repos_url":"https://api.github.com/users/ATH1909/repos","events_url":"https://api.github.com/users/ATH1909/events{/privacy}","received_events_url":"https://api.github.com/users/ATH1909/received_events","type":"User","site_admin":false},"created_at":"2019-08-23T02:35:36Z","updated_at":"2019-08-23T02:35:36Z","author_association":"CONTRIBUTOR","body":"> I don't want perma effects coming out of viro, as we already have a mechanism by which people can upgrade their lungs (cybernetics).\r\n\r\nThe hyphema, deafness, and deoxyrybonucleic saboteur symptoms (and maybe the disfiguration and/or skin pigmentation symptoms) can all have permanent effects (even after the removal of the virus); why can't this symptom?\r\n\r\nAlso, it'd be really, really hard to make the effects get reverted upon the removal of the disease without opening up a few \"gaps\" in the coverage of the reversion effect. I could try to reset the variables of the modified lungs to what they were before when the disease is cured, but what happens if the lungs are surgically removed before the disease is cured (and then placed back in the body after the disease is cured)? Basically, I can't stop people from keeping the effects of this symptom after its virus is cured, so I might as well make it a feature."}}
{"actor":{"display_login":"ATH1909"}}