{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/comments/286558094","pull_request_review_id":240716382,"id":286558094,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjU1ODA5NA==","diff_hunk":"@@ -0,0 +1,13 @@\n+class CreateFirmwareBinaries < ActiveRecord::Migration[5.0]\n+  def change\n+    create_table :firmware_binaries do |t|\n+      t.string   :name\n+      t.string   :ems_ref\n+      t.text     :description\n+      t.string   :version\n+      t.string   :type\n+      t.bigint   :firmware_registry_id","path":"db/migrate/20190514124322_create_firmware_binaries.rb","position":9,"original_position":9,"commit_id":"7f55018a70b0c5b75037fd8291f6b4c91710b279","original_commit_id":"7f55018a70b0c5b75037fd8291f6b4c91710b279","user":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"You can use `t.references :firmware_registry` instead of calling out the exact id column.  You might want to also add `:index => true`","created_at":"2019-05-22T15:39:49Z","updated_at":"2019-05-22T15:41:39Z","html_url":"https://github.com/ManageIQ/manageiq-schema/pull/371#discussion_r286558094","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/comments/286558094"},"html":{"href":"https://github.com/ManageIQ/manageiq-schema/pull/371#discussion_r286558094"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371","id":279513076,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5NTEzMDc2","html_url":"https://github.com/ManageIQ/manageiq-schema/pull/371","diff_url":"https://github.com/ManageIQ/manageiq-schema/pull/371.diff","patch_url":"https://github.com/ManageIQ/manageiq-schema/pull/371.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues/371","number":371,"state":"open","locked":false,"title":"Introduce :firmware_registry and :firmware_binary tables","user":{"login":"miha-plesko","id":8102426,"node_id":"MDQ6VXNlcjgxMDI0MjY=","avatar_url":"https://avatars1.githubusercontent.com/u/8102426?v=4","gravatar_id":"","url":"https://api.github.com/users/miha-plesko","html_url":"https://github.com/miha-plesko","followers_url":"https://api.github.com/users/miha-plesko/followers","following_url":"https://api.github.com/users/miha-plesko/following{/other_user}","gists_url":"https://api.github.com/users/miha-plesko/gists{/gist_id}","starred_url":"https://api.github.com/users/miha-plesko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miha-plesko/subscriptions","organizations_url":"https://api.github.com/users/miha-plesko/orgs","repos_url":"https://api.github.com/users/miha-plesko/repos","events_url":"https://api.github.com/users/miha-plesko/events{/privacy}","received_events_url":"https://api.github.com/users/miha-plesko/received_events","type":"User","site_admin":false},"body":"We introduce four new tables that correspond to three new Rails models needed for managing infrastructure firmware:\r\n\r\n```\r\nFirmwareRegistry\r\n  .name             # unique name\r\n  .last_refresh_on  # when relationships were last invoked\r\n  .type             # needed for STI\r\n\r\nFirmwareBinary\r\n  .name        # freeform name\r\n  .description # freeform description\r\n  .version     # firmware version\r\n  .type        # needed for STI\r\n\r\nFirmwareConstraint\r\n      .manufacturer # physical component's manufacturer\r\n      .model        # physical component's model name\r\n```\r\nThe Binary and the Constraint are connected into many-to-many relation.\r\n\r\nNeeded for https://github.com/ManageIQ/manageiq/pull/18774\r\n\r\n@miq-bot add_label schema,enhancement\r\n@miq-bot assign @agrare\r\n\r\n/cc @tadeboro @matejar","created_at":"2019-05-16T13:43:41Z","updated_at":"2019-05-22T15:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d37a62273e85592aaa05b09c41ae2f627e23bf69","assignee":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"assignees":[{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":602426715,"node_id":"MDU6TGFiZWw2MDI0MjY3MTU=","url":"https://api.github.com/repos/ManageIQ/manageiq-schema/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":654725933,"node_id":"MDU6TGFiZWw2NTQ3MjU5MzM=","url":"https://api.github.com/repos/ManageIQ/manageiq-schema/labels/schema","name":"schema","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues/371/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/statuses/7f55018a70b0c5b75037fd8291f6b4c91710b279","head":{"label":"xlab-si:firmware-registry","ref":"firmware-registry","sha":"7f55018a70b0c5b75037fd8291f6b4c91710b279","user":{"login":"xlab-si","id":17640165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQwMTY1","avatar_url":"https://avatars2.githubusercontent.com/u/17640165?v=4","gravatar_id":"","url":"https://api.github.com/users/xlab-si","html_url":"https://github.com/xlab-si","followers_url":"https://api.github.com/users/xlab-si/followers","following_url":"https://api.github.com/users/xlab-si/following{/other_user}","gists_url":"https://api.github.com/users/xlab-si/gists{/gist_id}","starred_url":"https://api.github.com/users/xlab-si/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlab-si/subscriptions","organizations_url":"https://api.github.com/users/xlab-si/orgs","repos_url":"https://api.github.com/users/xlab-si/repos","events_url":"https://api.github.com/users/xlab-si/events{/privacy}","received_events_url":"https://api.github.com/users/xlab-si/received_events","type":"Organization","site_admin":false},"repo":{"id":146556412,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1NTY0MTI=","name":"manageiq-schema","full_name":"xlab-si/manageiq-schema","private":false,"owner":{"login":"xlab-si","id":17640165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQwMTY1","avatar_url":"https://avatars2.githubusercontent.com/u/17640165?v=4","gravatar_id":"","url":"https://api.github.com/users/xlab-si","html_url":"https://github.com/xlab-si","followers_url":"https://api.github.com/users/xlab-si/followers","following_url":"https://api.github.com/users/xlab-si/following{/other_user}","gists_url":"https://api.github.com/users/xlab-si/gists{/gist_id}","starred_url":"https://api.github.com/users/xlab-si/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlab-si/subscriptions","organizations_url":"https://api.github.com/users/xlab-si/orgs","repos_url":"https://api.github.com/users/xlab-si/repos","events_url":"https://api.github.com/users/xlab-si/events{/privacy}","received_events_url":"https://api.github.com/users/xlab-si/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xlab-si/manageiq-schema","description":"SQL schema and database migrations for ManageIQ","fork":true,"url":"https://api.github.com/repos/xlab-si/manageiq-schema","forks_url":"https://api.github.com/repos/xlab-si/manageiq-schema/forks","keys_url":"https://api.github.com/repos/xlab-si/manageiq-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xlab-si/manageiq-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xlab-si/manageiq-schema/teams","hooks_url":"https://api.github.com/repos/xlab-si/manageiq-schema/hooks","issue_events_url":"https://api.github.com/repos/xlab-si/manageiq-schema/issues/events{/number}","events_url":"https://api.github.com/repos/xlab-si/manageiq-schema/events","assignees_url":"https://api.github.com/repos/xlab-si/manageiq-schema/assignees{/user}","branches_url":"https://api.github.com/repos/xlab-si/manageiq-schema/branches{/branch}","tags_url":"https://api.github.com/repos/xlab-si/manageiq-schema/tags","blobs_url":"https://api.github.com/repos/xlab-si/manageiq-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xlab-si/manageiq-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xlab-si/manageiq-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/xlab-si/manageiq-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xlab-si/manageiq-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/xlab-si/manageiq-schema/languages","stargazers_url":"https://api.github.com/repos/xlab-si/manageiq-schema/stargazers","contributors_url":"https://api.github.com/repos/xlab-si/manageiq-schema/contributors","subscribers_url":"https://api.github.com/repos/xlab-si/manageiq-schema/subscribers","subscription_url":"https://api.github.com/repos/xlab-si/manageiq-schema/subscription","commits_url":"https://api.github.com/repos/xlab-si/manageiq-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/xlab-si/manageiq-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/xlab-si/manageiq-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/xlab-si/manageiq-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/xlab-si/manageiq-schema/contents/{+path}","compare_url":"https://api.github.com/repos/xlab-si/manageiq-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xlab-si/manageiq-schema/merges","archive_url":"https://api.github.com/repos/xlab-si/manageiq-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xlab-si/manageiq-schema/downloads","issues_url":"https://api.github.com/repos/xlab-si/manageiq-schema/issues{/number}","pulls_url":"https://api.github.com/repos/xlab-si/manageiq-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/xlab-si/manageiq-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/xlab-si/manageiq-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xlab-si/manageiq-schema/labels{/name}","releases_url":"https://api.github.com/repos/xlab-si/manageiq-schema/releases{/id}","deployments_url":"https://api.github.com/repos/xlab-si/manageiq-schema/deployments","created_at":"2018-08-29T06:38:30Z","updated_at":"2018-08-29T06:38:33Z","pushed_at":"2019-05-22T14:37:40Z","git_url":"git://github.com/xlab-si/manageiq-schema.git","ssh_url":"git@github.com:xlab-si/manageiq-schema.git","clone_url":"https://github.com/xlab-si/manageiq-schema.git","svn_url":"https://github.com/xlab-si/manageiq-schema","homepage":null,"size":3687,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"7bf170e188f58b4786c67e7a2a2c5b7547a72a9b","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":90904181,"node_id":"MDEwOlJlcG9zaXRvcnk5MDkwNDE4MQ==","name":"manageiq-schema","full_name":"ManageIQ/manageiq-schema","private":false,"owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ManageIQ/manageiq-schema","description":"SQL schema and database migrations for ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-schema","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-schema/deployments","created_at":"2017-05-10T20:11:26Z","updated_at":"2019-05-20T18:05:10Z","pushed_at":"2019-05-22T14:37:42Z","git_url":"git://github.com/ManageIQ/manageiq-schema.git","ssh_url":"git@github.com:ManageIQ/manageiq-schema.git","clone_url":"https://github.com/ManageIQ/manageiq-schema.git","svn_url":"https://github.com/ManageIQ/manageiq-schema","homepage":null,"size":3714,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":97,"open_issues":18,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371"},"html":{"href":"https://github.com/ManageIQ/manageiq-schema/pull/371"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues/371"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-schema/statuses/7f55018a70b0c5b75037fd8291f6b4c91710b279"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agrare"}}