{"action":"created","comment":{"url":"https://api.github.com/repos/daostack/test_env/pulls/comments/313320182","pull_request_review_id":274185667,"id":313320182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzMyMDE4Mg==","diff_hunk":"@@ -4,19 +4,19 @@ const path = require('path')\n const options = {\n   quiet: false,\n   disableconfs: false,\n-  force: false,\n+  force: true,\n   provider: 'http://localhost:8545',\n   // this is the private key used by ganache when running with `--deterministic`\n   privateKey: '0x4f3edf983ac636a65a842ce7c78d9aa706d3b113bce9c46f30d7d21715b23b1d',\n-  prevmigration: path.normalize(path.join(__dirname, 'node_modules/@daostack/migration/migration.json')),\n+  // prevmigration: path.normalize(path.join(__dirname, 'node_modules/@daostack/migration/migration.json')),\n+  prevmigration: path.normalize(path.join(__dirname, './migration.json')),\n   output: path.normalize(path.join(__dirname, './migration.json')),\n   params: JSON.parse(fs.readFileSync(path.join(__dirname, 'migration-params.json')))\n }\n \n void async function() {\n   const DAOstackMigration = require('@daostack/migration');\n   const setupTestEnv = require('./setup-test-env')\n-\n-  DAOstackMigration.migrateScript(setupTestEnv)(options)\n+  // await DAOstackMigration.migrateBase(options)","path":"deployEthereum.js","position":20,"original_position":21,"commit_id":"2f162553f7df152c010af8e76a193064dddab25b","original_commit_id":"8b0243514d083fdebd6d7572297ac436be57cfad","user":{"login":"jellegerbrandy","id":1306173,"node_id":"MDQ6VXNlcjEzMDYxNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1306173?v=4","gravatar_id":"","url":"https://api.github.com/users/jellegerbrandy","html_url":"https://github.com/jellegerbrandy","followers_url":"https://api.github.com/users/jellegerbrandy/followers","following_url":"https://api.github.com/users/jellegerbrandy/following{/other_user}","gists_url":"https://api.github.com/users/jellegerbrandy/gists{/gist_id}","starred_url":"https://api.github.com/users/jellegerbrandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jellegerbrandy/subscriptions","organizations_url":"https://api.github.com/users/jellegerbrandy/orgs","repos_url":"https://api.github.com/users/jellegerbrandy/repos","events_url":"https://api.github.com/users/jellegerbrandy/events{/privacy}","received_events_url":"https://api.github.com/users/jellegerbrandy/received_events","type":"User","site_admin":false},"body":"no I'd like to keep this for reference. A problem with the current setup building on top of the ganache image from the mgiration repo makes it very hard to upgrade the ganache version;d build from an empty ganache image and uncomment this line :-)","created_at":"2019-08-13T10:14:24Z","updated_at":"2019-08-13T10:14:24Z","html_url":"https://github.com/daostack/test_env/pull/5#discussion_r313320182","pull_request_url":"https://api.github.com/repos/daostack/test_env/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/daostack/test_env/pulls/comments/313320182"},"html":{"href":"https://github.com/daostack/test_env/pull/5#discussion_r313320182"},"pull_request":{"href":"https://api.github.com/repos/daostack/test_env/pulls/5"}},"in_reply_to_id":312830653},"pull_request":{"url":"https://api.github.com/repos/daostack/test_env/pulls/5","id":306314828,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2MzE0ODI4","html_url":"https://github.com/daostack/test_env/pull/5","diff_url":"https://github.com/daostack/test_env/pull/5.diff","patch_url":"https://github.com/daostack/test_env/pull/5.patch","issue_url":"https://api.github.com/repos/daostack/test_env/issues/5","number":5,"state":"open","locked":false,"title":"clean up deployment scripts","user":{"login":"jellegerbrandy","id":1306173,"node_id":"MDQ6VXNlcjEzMDYxNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1306173?v=4","gravatar_id":"","url":"https://api.github.com/users/jellegerbrandy","html_url":"https://github.com/jellegerbrandy","followers_url":"https://api.github.com/users/jellegerbrandy/followers","following_url":"https://api.github.com/users/jellegerbrandy/following{/other_user}","gists_url":"https://api.github.com/users/jellegerbrandy/gists{/gist_id}","starred_url":"https://api.github.com/users/jellegerbrandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jellegerbrandy/subscriptions","organizations_url":"https://api.github.com/users/jellegerbrandy/orgs","repos_url":"https://api.github.com/users/jellegerbrandy/repos","events_url":"https://api.github.com/users/jellegerbrandy/events{/privacy}","received_events_url":"https://api.github.com/users/jellegerbrandy/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-11T22:02:29Z","updated_at":"2019-08-13T10:14:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c299fefbbf9798824a3f005d9edec6ce6d627480","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/daostack/test_env/pulls/5/commits","review_comments_url":"https://api.github.com/repos/daostack/test_env/pulls/5/comments","review_comment_url":"https://api.github.com/repos/daostack/test_env/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daostack/test_env/issues/5/comments","statuses_url":"https://api.github.com/repos/daostack/test_env/statuses/2f162553f7df152c010af8e76a193064dddab25b","head":{"label":"daostack:cleanupstuff","ref":"cleanupstuff","sha":"2f162553f7df152c010af8e76a193064dddab25b","user":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"repo":{"id":195011120,"node_id":"MDEwOlJlcG9zaXRvcnkxOTUwMTExMjA=","name":"test_env","full_name":"daostack/test_env","private":false,"owner":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/daostack/test_env","description":"test environment setup using 'migration'","fork":false,"url":"https://api.github.com/repos/daostack/test_env","forks_url":"https://api.github.com/repos/daostack/test_env/forks","keys_url":"https://api.github.com/repos/daostack/test_env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daostack/test_env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daostack/test_env/teams","hooks_url":"https://api.github.com/repos/daostack/test_env/hooks","issue_events_url":"https://api.github.com/repos/daostack/test_env/issues/events{/number}","events_url":"https://api.github.com/repos/daostack/test_env/events","assignees_url":"https://api.github.com/repos/daostack/test_env/assignees{/user}","branches_url":"https://api.github.com/repos/daostack/test_env/branches{/branch}","tags_url":"https://api.github.com/repos/daostack/test_env/tags","blobs_url":"https://api.github.com/repos/daostack/test_env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daostack/test_env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daostack/test_env/git/refs{/sha}","trees_url":"https://api.github.com/repos/daostack/test_env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daostack/test_env/statuses/{sha}","languages_url":"https://api.github.com/repos/daostack/test_env/languages","stargazers_url":"https://api.github.com/repos/daostack/test_env/stargazers","contributors_url":"https://api.github.com/repos/daostack/test_env/contributors","subscribers_url":"https://api.github.com/repos/daostack/test_env/subscribers","subscription_url":"https://api.github.com/repos/daostack/test_env/subscription","commits_url":"https://api.github.com/repos/daostack/test_env/commits{/sha}","git_commits_url":"https://api.github.com/repos/daostack/test_env/git/commits{/sha}","comments_url":"https://api.github.com/repos/daostack/test_env/comments{/number}","issue_comment_url":"https://api.github.com/repos/daostack/test_env/issues/comments{/number}","contents_url":"https://api.github.com/repos/daostack/test_env/contents/{+path}","compare_url":"https://api.github.com/repos/daostack/test_env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daostack/test_env/merges","archive_url":"https://api.github.com/repos/daostack/test_env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daostack/test_env/downloads","issues_url":"https://api.github.com/repos/daostack/test_env/issues{/number}","pulls_url":"https://api.github.com/repos/daostack/test_env/pulls{/number}","milestones_url":"https://api.github.com/repos/daostack/test_env/milestones{/number}","notifications_url":"https://api.github.com/repos/daostack/test_env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daostack/test_env/labels{/name}","releases_url":"https://api.github.com/repos/daostack/test_env/releases{/id}","deployments_url":"https://api.github.com/repos/daostack/test_env/deployments","created_at":"2019-07-03T08:23:47Z","updated_at":"2019-08-12T09:01:56Z","pushed_at":"2019-08-12T09:59:23Z","git_url":"git://github.com/daostack/test_env.git","ssh_url":"git@github.com:daostack/test_env.git","clone_url":"https://github.com/daostack/test_env.git","svn_url":"https://github.com/daostack/test_env","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"daostack:master","ref":"master","sha":"e4d0b32ba361599d64059a099c5f478a6b69dba8","user":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"repo":{"id":195011120,"node_id":"MDEwOlJlcG9zaXRvcnkxOTUwMTExMjA=","name":"test_env","full_name":"daostack/test_env","private":false,"owner":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/daostack/test_env","description":"test environment setup using 'migration'","fork":false,"url":"https://api.github.com/repos/daostack/test_env","forks_url":"https://api.github.com/repos/daostack/test_env/forks","keys_url":"https://api.github.com/repos/daostack/test_env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daostack/test_env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daostack/test_env/teams","hooks_url":"https://api.github.com/repos/daostack/test_env/hooks","issue_events_url":"https://api.github.com/repos/daostack/test_env/issues/events{/number}","events_url":"https://api.github.com/repos/daostack/test_env/events","assignees_url":"https://api.github.com/repos/daostack/test_env/assignees{/user}","branches_url":"https://api.github.com/repos/daostack/test_env/branches{/branch}","tags_url":"https://api.github.com/repos/daostack/test_env/tags","blobs_url":"https://api.github.com/repos/daostack/test_env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daostack/test_env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daostack/test_env/git/refs{/sha}","trees_url":"https://api.github.com/repos/daostack/test_env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daostack/test_env/statuses/{sha}","languages_url":"https://api.github.com/repos/daostack/test_env/languages","stargazers_url":"https://api.github.com/repos/daostack/test_env/stargazers","contributors_url":"https://api.github.com/repos/daostack/test_env/contributors","subscribers_url":"https://api.github.com/repos/daostack/test_env/subscribers","subscription_url":"https://api.github.com/repos/daostack/test_env/subscription","commits_url":"https://api.github.com/repos/daostack/test_env/commits{/sha}","git_commits_url":"https://api.github.com/repos/daostack/test_env/git/commits{/sha}","comments_url":"https://api.github.com/repos/daostack/test_env/comments{/number}","issue_comment_url":"https://api.github.com/repos/daostack/test_env/issues/comments{/number}","contents_url":"https://api.github.com/repos/daostack/test_env/contents/{+path}","compare_url":"https://api.github.com/repos/daostack/test_env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daostack/test_env/merges","archive_url":"https://api.github.com/repos/daostack/test_env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daostack/test_env/downloads","issues_url":"https://api.github.com/repos/daostack/test_env/issues{/number}","pulls_url":"https://api.github.com/repos/daostack/test_env/pulls{/number}","milestones_url":"https://api.github.com/repos/daostack/test_env/milestones{/number}","notifications_url":"https://api.github.com/repos/daostack/test_env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daostack/test_env/labels{/name}","releases_url":"https://api.github.com/repos/daostack/test_env/releases{/id}","deployments_url":"https://api.github.com/repos/daostack/test_env/deployments","created_at":"2019-07-03T08:23:47Z","updated_at":"2019-08-12T09:01:56Z","pushed_at":"2019-08-12T09:59:23Z","git_url":"git://github.com/daostack/test_env.git","ssh_url":"git@github.com:daostack/test_env.git","clone_url":"https://github.com/daostack/test_env.git","svn_url":"https://github.com/daostack/test_env","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daostack/test_env/pulls/5"},"html":{"href":"https://github.com/daostack/test_env/pull/5"},"issue":{"href":"https://api.github.com/repos/daostack/test_env/issues/5"},"comments":{"href":"https://api.github.com/repos/daostack/test_env/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/daostack/test_env/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/daostack/test_env/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daostack/test_env/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/daostack/test_env/statuses/2f162553f7df152c010af8e76a193064dddab25b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jellegerbrandy"}}