{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments/265001209","pull_request_review_id":213792641,"id":265001209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTAwMTIwOQ==","diff_hunk":"@@ -779,7 +779,9 @@ MAVLINK_HELPER uint8_t mavlink_frame_char_buffer(mavlink_message_t* rxmsg,\n \t\t\t\t}\n \t\t\t}\n \t\t\tstatus->parse_state = MAVLINK_PARSE_STATE_IDLE;\n-\t\t\tmemcpy(r_message, rxmsg, sizeof(mavlink_message_t));\n+\t\t\tif(NULL != r_message){","path":"generator/C/include_v2.0/mavlink_helpers.h","position":5,"original_position":5,"commit_id":"edc9799adce2c66a4479b96fa3bf45a493be43ea","original_commit_id":"edc9799adce2c66a4479b96fa3bf45a493be43ea","user":{"login":"peterbarker","id":7077857,"node_id":"MDQ6VXNlcjcwNzc4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"body":"Please don't reverse the order of comparisons.\r\n\r\nAlso, a space between the if and opening pren...\r\n\r\n... and between the closing pron and opening brace.\r\n\r\n","created_at":"2019-03-13T07:32:21Z","updated_at":"2019-03-13T07:43:00Z","html_url":"https://github.com/ArduPilot/pymavlink/pull/272#discussion_r265001209","pull_request_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments/265001209"},"html":{"href":"https://github.com/ArduPilot/pymavlink/pull/272#discussion_r265001209"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272","id":254481193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NDgxMTkz","html_url":"https://github.com/ArduPilot/pymavlink/pull/272","diff_url":"https://github.com/ArduPilot/pymavlink/pull/272.diff","patch_url":"https://github.com/ArduPilot/pymavlink/pull/272.patch","issue_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/272","number":272,"state":"open","locked":false,"title":"Null checks on C helper function mavlink_frame_char_buffer","user":{"login":"guyf2010","id":7529670,"node_id":"MDQ6VXNlcjc1Mjk2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7529670?v=4","gravatar_id":"","url":"https://api.github.com/users/guyf2010","html_url":"https://github.com/guyf2010","followers_url":"https://api.github.com/users/guyf2010/followers","following_url":"https://api.github.com/users/guyf2010/following{/other_user}","gists_url":"https://api.github.com/users/guyf2010/gists{/gist_id}","starred_url":"https://api.github.com/users/guyf2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyf2010/subscriptions","organizations_url":"https://api.github.com/users/guyf2010/orgs","repos_url":"https://api.github.com/users/guyf2010/repos","events_url":"https://api.github.com/users/guyf2010/events{/privacy}","received_events_url":"https://api.github.com/users/guyf2010/received_events","type":"User","site_admin":false},"body":"In issue #169 a couple of NULL checks were added preventing a second message or status object from being required when running mavlink_frame_char_buffer in the C library. In two places a memcpy was run with the second message as a destination without checking it exists.","created_at":"2019-02-20T02:45:58Z","updated_at":"2019-03-13T07:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05f05385df0c31e77cd925172cb7cf934ec1b5e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/272/comments","statuses_url":"https://api.github.com/repos/ArduPilot/pymavlink/statuses/edc9799adce2c66a4479b96fa3bf45a493be43ea","head":{"label":"guyf2010:master","ref":"master","sha":"edc9799adce2c66a4479b96fa3bf45a493be43ea","user":{"login":"guyf2010","id":7529670,"node_id":"MDQ6VXNlcjc1Mjk2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7529670?v=4","gravatar_id":"","url":"https://api.github.com/users/guyf2010","html_url":"https://github.com/guyf2010","followers_url":"https://api.github.com/users/guyf2010/followers","following_url":"https://api.github.com/users/guyf2010/following{/other_user}","gists_url":"https://api.github.com/users/guyf2010/gists{/gist_id}","starred_url":"https://api.github.com/users/guyf2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyf2010/subscriptions","organizations_url":"https://api.github.com/users/guyf2010/orgs","repos_url":"https://api.github.com/users/guyf2010/repos","events_url":"https://api.github.com/users/guyf2010/events{/privacy}","received_events_url":"https://api.github.com/users/guyf2010/received_events","type":"User","site_admin":false},"repo":{"id":171580416,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE1ODA0MTY=","name":"pymavlink","full_name":"guyf2010/pymavlink","private":false,"owner":{"login":"guyf2010","id":7529670,"node_id":"MDQ6VXNlcjc1Mjk2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7529670?v=4","gravatar_id":"","url":"https://api.github.com/users/guyf2010","html_url":"https://github.com/guyf2010","followers_url":"https://api.github.com/users/guyf2010/followers","following_url":"https://api.github.com/users/guyf2010/following{/other_user}","gists_url":"https://api.github.com/users/guyf2010/gists{/gist_id}","starred_url":"https://api.github.com/users/guyf2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyf2010/subscriptions","organizations_url":"https://api.github.com/users/guyf2010/orgs","repos_url":"https://api.github.com/users/guyf2010/repos","events_url":"https://api.github.com/users/guyf2010/events{/privacy}","received_events_url":"https://api.github.com/users/guyf2010/received_events","type":"User","site_admin":false},"html_url":"https://github.com/guyf2010/pymavlink","description":"python MAVLink interface and utilities","fork":true,"url":"https://api.github.com/repos/guyf2010/pymavlink","forks_url":"https://api.github.com/repos/guyf2010/pymavlink/forks","keys_url":"https://api.github.com/repos/guyf2010/pymavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guyf2010/pymavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guyf2010/pymavlink/teams","hooks_url":"https://api.github.com/repos/guyf2010/pymavlink/hooks","issue_events_url":"https://api.github.com/repos/guyf2010/pymavlink/issues/events{/number}","events_url":"https://api.github.com/repos/guyf2010/pymavlink/events","assignees_url":"https://api.github.com/repos/guyf2010/pymavlink/assignees{/user}","branches_url":"https://api.github.com/repos/guyf2010/pymavlink/branches{/branch}","tags_url":"https://api.github.com/repos/guyf2010/pymavlink/tags","blobs_url":"https://api.github.com/repos/guyf2010/pymavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guyf2010/pymavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guyf2010/pymavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/guyf2010/pymavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guyf2010/pymavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/guyf2010/pymavlink/languages","stargazers_url":"https://api.github.com/repos/guyf2010/pymavlink/stargazers","contributors_url":"https://api.github.com/repos/guyf2010/pymavlink/contributors","subscribers_url":"https://api.github.com/repos/guyf2010/pymavlink/subscribers","subscription_url":"https://api.github.com/repos/guyf2010/pymavlink/subscription","commits_url":"https://api.github.com/repos/guyf2010/pymavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/guyf2010/pymavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/guyf2010/pymavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/guyf2010/pymavlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/guyf2010/pymavlink/contents/{+path}","compare_url":"https://api.github.com/repos/guyf2010/pymavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guyf2010/pymavlink/merges","archive_url":"https://api.github.com/repos/guyf2010/pymavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guyf2010/pymavlink/downloads","issues_url":"https://api.github.com/repos/guyf2010/pymavlink/issues{/number}","pulls_url":"https://api.github.com/repos/guyf2010/pymavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/guyf2010/pymavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/guyf2010/pymavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guyf2010/pymavlink/labels{/name}","releases_url":"https://api.github.com/repos/guyf2010/pymavlink/releases{/id}","deployments_url":"https://api.github.com/repos/guyf2010/pymavlink/deployments","created_at":"2019-02-20T01:42:31Z","updated_at":"2019-02-20T02:24:30Z","pushed_at":"2019-02-20T02:24:28Z","git_url":"git://github.com/guyf2010/pymavlink.git","ssh_url":"git@github.com:guyf2010/pymavlink.git","clone_url":"https://github.com/guyf2010/pymavlink.git","svn_url":"https://github.com/guyf2010/pymavlink","homepage":null,"size":7018,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"905e49b5e0f19584ce0aa2df6930e898bc36b160","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":67301306,"node_id":"MDEwOlJlcG9zaXRvcnk2NzMwMTMwNg==","name":"pymavlink","full_name":"ArduPilot/pymavlink","private":false,"owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArduPilot/pymavlink","description":"python MAVLink interface and utilities","fork":false,"url":"https://api.github.com/repos/ArduPilot/pymavlink","forks_url":"https://api.github.com/repos/ArduPilot/pymavlink/forks","keys_url":"https://api.github.com/repos/ArduPilot/pymavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/pymavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/pymavlink/teams","hooks_url":"https://api.github.com/repos/ArduPilot/pymavlink/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/pymavlink/events","assignees_url":"https://api.github.com/repos/ArduPilot/pymavlink/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/pymavlink/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/pymavlink/tags","blobs_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/pymavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/pymavlink/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/pymavlink/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/pymavlink/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/pymavlink/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/pymavlink/subscription","commits_url":"https://api.github.com/repos/ArduPilot/pymavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/pymavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/pymavlink/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/pymavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/pymavlink/merges","archive_url":"https://api.github.com/repos/ArduPilot/pymavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/pymavlink/downloads","issues_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/pymavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/pymavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/pymavlink/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/pymavlink/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/pymavlink/deployments","created_at":"2016-09-03T16:54:27Z","updated_at":"2019-03-13T04:57:58Z","pushed_at":"2019-03-13T04:57:54Z","git_url":"git://github.com/ArduPilot/pymavlink.git","ssh_url":"git@github.com:ArduPilot/pymavlink.git","clone_url":"https://github.com/ArduPilot/pymavlink.git","svn_url":"https://github.com/ArduPilot/pymavlink","homepage":null,"size":7057,"stargazers_count":79,"watchers_count":79,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":192,"open_issues":61,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272"},"html":{"href":"https://github.com/ArduPilot/pymavlink/pull/272"},"issue":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/issues/272"},"comments":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/statuses/edc9799adce2c66a4479b96fa3bf45a493be43ea"}},"author_association":"NONE"}}
{"actor":{"display_login":"peterbarker"}}