{"action":"created","issue":{"url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/issues/5240","repository_url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity","labels_url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/issues/5240/labels{/name}","comments_url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/issues/5240/comments","events_url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/issues/5240/events","html_url":"https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5240","id":465651216,"node_id":"MDU6SXNzdWU0NjU2NTEyMTY=","number":5240,"title":"Hand needs to be way too close to grabbable before hand ray disappears","user":{"login":"julenka","id":168492,"node_id":"MDQ6VXNlcjE2ODQ5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/168492?v=4","gravatar_id":"","url":"https://api.github.com/users/julenka","html_url":"https://github.com/julenka","followers_url":"https://api.github.com/users/julenka/followers","following_url":"https://api.github.com/users/julenka/following{/other_user}","gists_url":"https://api.github.com/users/julenka/gists{/gist_id}","starred_url":"https://api.github.com/users/julenka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julenka/subscriptions","organizations_url":"https://api.github.com/users/julenka/orgs","repos_url":"https://api.github.com/users/julenka/repos","events_url":"https://api.github.com/users/julenka/events{/privacy}","received_events_url":"https://api.github.com/users/julenka/received_events","type":"User","site_admin":false},"labels":[{"id":1391307949,"node_id":"MDU6TGFiZWwxMzkxMzA3OTQ5","url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/labels/GA%20Blocker","name":"GA Blocker","color":"bfd4f2","default":false},{"id":936491559,"node_id":"MDU6TGFiZWw5MzY0OTE1NTk=","url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/labels/Input%20System","name":"Input System","color":"5ecae5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-09T08:46:00Z","updated_at":"2019-07-15T16:26:22Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Overview\r\nThe hand ray currently only turns off when the hand is incredibly close to a grabbable, when the hand is ~1cm near a grabbable. The ray should turn off when the hand is ~10cm near a grabbable.\r\n\r\nThis should be implemented by having a separate radius for turning off the line ray, separate from the radius that is used for doing a query for determining what to grab.\r\n\r\nCurrently, SpherePointer.IsNearObject contains the following:\r\n\r\n```\r\nreturn UnityEngine.Physics.CheckSphere(position, SphereCastRadius, ~UnityEngine.Physics.IgnoreRaycastLayer);\r\n```\r\n\r\nInstead of `SphereCastRadius` (used when determining grab start/edn), we should use a different radius `HandRayOffRadius`.\r\n\r\n\r\n## Expected Behavior\r\nThe ray should turn off when hand is ~10cm near a grabbable\r\n![image](https://user-images.githubusercontent.com/168492/60873303-2064ec80-a271-11e9-8c6a-66f69d218f65.png)\r\n\r\n## Actual Behavior\r\nRay is still on, even when hand is very close to grabbable\r\n![image](https://user-images.githubusercontent.com/168492/60873140-d24fe900-a270-11e9-8cb6-0066a3992c7a.png)\r\n\r\n\r\n## Steps to reproduce\r\n_(Links to sample github project preferred)_\r\n\r\n## Unity Editor Version\r\n\r\n## Mixed Reality Toolkit Release Version\r\n"},"comment":{"url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/issues/comments/511472325","html_url":"https://github.com/microsoft/MixedRealityToolkit-Unity/issues/5240#issuecomment-511472325","issue_url":"https://api.github.com/repos/microsoft/MixedRealityToolkit-Unity/issues/5240","id":511472325,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMTQ3MjMyNQ==","user":{"login":"lukastoenneMS","id":47210016,"node_id":"MDQ6VXNlcjQ3MjEwMDE2","avatar_url":"https://avatars3.githubusercontent.com/u/47210016?v=4","gravatar_id":"","url":"https://api.github.com/users/lukastoenneMS","html_url":"https://github.com/lukastoenneMS","followers_url":"https://api.github.com/users/lukastoenneMS/followers","following_url":"https://api.github.com/users/lukastoenneMS/following{/other_user}","gists_url":"https://api.github.com/users/lukastoenneMS/gists{/gist_id}","starred_url":"https://api.github.com/users/lukastoenneMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukastoenneMS/subscriptions","organizations_url":"https://api.github.com/users/lukastoenneMS/orgs","repos_url":"https://api.github.com/users/lukastoenneMS/repos","events_url":"https://api.github.com/users/lukastoenneMS/events{/privacy}","received_events_url":"https://api.github.com/users/lukastoenneMS/received_events","type":"User","site_admin":false},"created_at":"2019-07-15T16:26:22Z","updated_at":"2019-07-15T16:26:22Z","author_association":"CONTRIBUTOR","body":"Should this behavior actually be controlled by grabbables? Because it sounds to me like disabling the far interaction pointer should be a feature of that pointer, instead of relying on a large grabbable radius to disable a different kind of pointer. So\r\n\r\n1. When line pointer hit is closer than X, the pointer is hidden and interaction disabled. Pointer keeps raycasting though, we want to un-hide when moving further away.\r\n1. Grabbable distance is a separate issue, should the previous radius of 0.15 be restored? It does sound a little bit excessive and if it was just to hide the line pointer then the 1st point would take care of that."}}
{"actor":{"display_login":"lukastoenneMS"}}