{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3/issues/757","repository_url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3","labels_url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3/issues/757/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3/issues/757/comments","events_url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3/issues/757/events","html_url":"https://github.com/Azure/azure-cosmos-dotnet-v3/issues/757","id":487778365,"node_id":"MDU6SXNzdWU0ODc3NzgzNjU=","number":757,"title":"When connection mode is direct, protocol can't set to https","user":{"login":"yamatoya","id":2118539,"node_id":"MDQ6VXNlcjIxMTg1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2118539?v=4","gravatar_id":"","url":"https://api.github.com/users/yamatoya","html_url":"https://github.com/yamatoya","followers_url":"https://api.github.com/users/yamatoya/followers","following_url":"https://api.github.com/users/yamatoya/following{/other_user}","gists_url":"https://api.github.com/users/yamatoya/gists{/gist_id}","starred_url":"https://api.github.com/users/yamatoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamatoya/subscriptions","organizations_url":"https://api.github.com/users/yamatoya/orgs","repos_url":"https://api.github.com/users/yamatoya/repos","events_url":"https://api.github.com/users/yamatoya/events{/privacy}","received_events_url":"https://api.github.com/users/yamatoya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-08-31T14:56:47Z","updated_at":"2019-08-31T23:34:27Z","closed_at":null,"author_association":"NONE","body":"**Describe the bug**\r\n[This article](https://docs.microsoft.com/en-us/azure/cosmos-db/performance-tips#use-tcp) says that when connection mode is direct, protocol can select both tcp and https in the .NET SDK.\r\nBut, `CosmosClientOptions` can't set the protocol.\r\n\r\n```\r\n        /// <summary>\r\n        /// Gets or sets the connection protocol when connecting to the Azure Cosmos service.\r\n        /// </summary>\r\n        /// <value>\r\n        /// Default value is <see cref=\"Protocol.Tcp\"/>.\r\n        /// </value>\r\n        /// <remarks>\r\n        /// This setting is not used when <see cref=\"ConnectionMode\"/> is set to <see cref=\"Cosmos.ConnectionMode.Gateway\"/>.\r\n        /// Gateway mode only supports HTTPS.\r\n        /// For more information, see <see href=\"https://docs.microsoft.com/azure/documentdb/documentdb-performance-tips#use-tcp\">Connection policy: Use the TCP protocol</see>.\r\n        /// </remarks>\r\n        internal Protocol ConnectionProtocol\r\n        {\r\n            get => this.connectionProtocol;\r\n            set\r\n            {\r\n                this.ValidateDirectTCPSettings();\r\n                this.connectionProtocol = value;\r\n            }\r\n        }\r\n```\r\n\r\n**Actual behavior**\r\nI imaget that `internal Protocol ConnectionProtocol` is `public Protocol ConnectionProtocol`"},"comment":{"url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3/issues/comments/526873023","html_url":"https://github.com/Azure/azure-cosmos-dotnet-v3/issues/757#issuecomment-526873023","issue_url":"https://api.github.com/repos/Azure/azure-cosmos-dotnet-v3/issues/757","id":526873023,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNjg3MzAyMw==","user":{"login":"bartelink","id":206668,"node_id":"MDQ6VXNlcjIwNjY2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/206668?v=4","gravatar_id":"","url":"https://api.github.com/users/bartelink","html_url":"https://github.com/bartelink","followers_url":"https://api.github.com/users/bartelink/followers","following_url":"https://api.github.com/users/bartelink/following{/other_user}","gists_url":"https://api.github.com/users/bartelink/gists{/gist_id}","starred_url":"https://api.github.com/users/bartelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartelink/subscriptions","organizations_url":"https://api.github.com/users/bartelink/orgs","repos_url":"https://api.github.com/users/bartelink/repos","events_url":"https://api.github.com/users/bartelink/events{/privacy}","received_events_url":"https://api.github.com/users/bartelink/received_events","type":"User","site_admin":false},"created_at":"2019-08-31T23:34:27Z","updated_at":"2019-08-31T23:34:27Z","author_association":"NONE","body":"Your article describes the V1/2 API terms and settings.\r\nV3 flattens 2 settings down into one - I've enumerated [the choices here](https://github.com/jet/equinox/pull/144/files#diff-fe04b21266b70fe92b8c4b350264c0e5L1056) - in V3, you get such an enum out of the box.\r\nSee [this comparison](https://github.com/jet/equinox/pull/144/files#diff-fe04b21266b70fe92b8c4b350264c0e5R1072) for how the changes compare."}}
{"actor":{"display_login":"bartelink"}}