{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/312410284","pull_request_review_id":273048879,"id":312410284,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjQxMDI4NA==","diff_hunk":"@@ -267,11 +267,13 @@ private function findCaches(array $cachesNames = [])\n \n             if ($component instanceof CacheInterface) {\n                 $caches[$name] = get_class($component);\n-            } elseif (is_array($component) && isset($component['class']) && $this->isCacheClass($component['class'])) {\n-                $caches[$name] = $component['class'];\n+            } elseif (is_array($component) && isset($component['class'])) {","path":"framework/console/controllers/CacheController.php","position":6,"original_position":6,"commit_id":"2bcf7354ec92a9219eddfc41ffad636f01082459","original_commit_id":"2bcf7354ec92a9219eddfc41ffad636f01082459","user":{"login":"samdark","id":47294,"node_id":"MDQ6VXNlcjQ3Mjk0","avatar_url":"https://avatars2.githubusercontent.com/u/47294?v=4","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"body":"`&&` already works like that. If condition on the left fails, condition on the right is never executed.","created_at":"2019-08-09T09:57:25Z","updated_at":"2019-08-09T09:57:25Z","html_url":"https://github.com/yiisoft/yii2/pull/17501#discussion_r312410284","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/17501","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/312410284"},"html":{"href":"https://github.com/yiisoft/yii2/pull/17501#discussion_r312410284"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/17501"}},"in_reply_to_id":312401624},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/17501","id":305612101,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NjEyMTAx","html_url":"https://github.com/yiisoft/yii2/pull/17501","diff_url":"https://github.com/yiisoft/yii2/pull/17501.diff","patch_url":"https://github.com/yiisoft/yii2/pull/17501.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/17501","number":17501,"state":"open","locked":false,"title":"fix flushing cache from console","user":{"login":"Spell6inder","id":2795910,"node_id":"MDQ6VXNlcjI3OTU5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2795910?v=4","gravatar_id":"","url":"https://api.github.com/users/Spell6inder","html_url":"https://github.com/Spell6inder","followers_url":"https://api.github.com/users/Spell6inder/followers","following_url":"https://api.github.com/users/Spell6inder/following{/other_user}","gists_url":"https://api.github.com/users/Spell6inder/gists{/gist_id}","starred_url":"https://api.github.com/users/Spell6inder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spell6inder/subscriptions","organizations_url":"https://api.github.com/users/Spell6inder/orgs","repos_url":"https://api.github.com/users/Spell6inder/repos","events_url":"https://api.github.com/users/Spell6inder/events{/privacy}","received_events_url":"https://api.github.com/users/Spell6inder/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Is bugfix?    | ✔️\r\n| New feature?  | ❌\r\n| Breaks BC?    | ❌\r\n| Tests pass?   | ❌\r\n| Fixed issues  | -\r\n\r\nWhen using following application configurations console cache can't find cache component\r\n\r\n```php\r\nreturn [\r\n    //...\r\n    'container' => [\r\n        //...\r\n        'singletons' => [\r\n             //...\r\n            'cache-main' => [\r\n                'class' => \\yii\\caching\\FileCache::class,\r\n            ],\r\n            //...\r\n        ],\r\n        //...\r\n    ],\r\n    //...\r\n    'components' => [\r\n        //...\r\n        'cache' => 'cache-main',\r\n        //...\r\n    ],\r\n    //...\r\n];\r\n```\r\n\r\nBut in this case, `\\yii\\web\\AssetManager` should be configured...","created_at":"2019-08-08T14:43:32Z","updated_at":"2019-08-09T09:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9128ad7ee5c4f6ccf733e13510ccbdf468e21ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":145356565,"node_id":"MDU6TGFiZWwxNDUzNTY1NjU=","url":"https://api.github.com/repos/yiisoft/yii2/labels/status:need%20more%20info","name":"status:need more info","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/17501/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/17501/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/17501/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/2bcf7354ec92a9219eddfc41ffad636f01082459","head":{"label":"Spell6inder:patch-1","ref":"patch-1","sha":"2bcf7354ec92a9219eddfc41ffad636f01082459","user":{"login":"Spell6inder","id":2795910,"node_id":"MDQ6VXNlcjI3OTU5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2795910?v=4","gravatar_id":"","url":"https://api.github.com/users/Spell6inder","html_url":"https://github.com/Spell6inder","followers_url":"https://api.github.com/users/Spell6inder/followers","following_url":"https://api.github.com/users/Spell6inder/following{/other_user}","gists_url":"https://api.github.com/users/Spell6inder/gists{/gist_id}","starred_url":"https://api.github.com/users/Spell6inder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spell6inder/subscriptions","organizations_url":"https://api.github.com/users/Spell6inder/orgs","repos_url":"https://api.github.com/users/Spell6inder/repos","events_url":"https://api.github.com/users/Spell6inder/events{/privacy}","received_events_url":"https://api.github.com/users/Spell6inder/received_events","type":"User","site_admin":false},"repo":{"id":201274879,"node_id":"MDEwOlJlcG9zaXRvcnkyMDEyNzQ4Nzk=","name":"yii2","full_name":"Spell6inder/yii2","private":false,"owner":{"login":"Spell6inder","id":2795910,"node_id":"MDQ6VXNlcjI3OTU5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2795910?v=4","gravatar_id":"","url":"https://api.github.com/users/Spell6inder","html_url":"https://github.com/Spell6inder","followers_url":"https://api.github.com/users/Spell6inder/followers","following_url":"https://api.github.com/users/Spell6inder/following{/other_user}","gists_url":"https://api.github.com/users/Spell6inder/gists{/gist_id}","starred_url":"https://api.github.com/users/Spell6inder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spell6inder/subscriptions","organizations_url":"https://api.github.com/users/Spell6inder/orgs","repos_url":"https://api.github.com/users/Spell6inder/repos","events_url":"https://api.github.com/users/Spell6inder/events{/privacy}","received_events_url":"https://api.github.com/users/Spell6inder/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Spell6inder/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":true,"url":"https://api.github.com/repos/Spell6inder/yii2","forks_url":"https://api.github.com/repos/Spell6inder/yii2/forks","keys_url":"https://api.github.com/repos/Spell6inder/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spell6inder/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spell6inder/yii2/teams","hooks_url":"https://api.github.com/repos/Spell6inder/yii2/hooks","issue_events_url":"https://api.github.com/repos/Spell6inder/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/Spell6inder/yii2/events","assignees_url":"https://api.github.com/repos/Spell6inder/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/Spell6inder/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/Spell6inder/yii2/tags","blobs_url":"https://api.github.com/repos/Spell6inder/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spell6inder/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spell6inder/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spell6inder/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spell6inder/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/Spell6inder/yii2/languages","stargazers_url":"https://api.github.com/repos/Spell6inder/yii2/stargazers","contributors_url":"https://api.github.com/repos/Spell6inder/yii2/contributors","subscribers_url":"https://api.github.com/repos/Spell6inder/yii2/subscribers","subscription_url":"https://api.github.com/repos/Spell6inder/yii2/subscription","commits_url":"https://api.github.com/repos/Spell6inder/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spell6inder/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spell6inder/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spell6inder/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spell6inder/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/Spell6inder/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spell6inder/yii2/merges","archive_url":"https://api.github.com/repos/Spell6inder/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spell6inder/yii2/downloads","issues_url":"https://api.github.com/repos/Spell6inder/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/Spell6inder/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/Spell6inder/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/Spell6inder/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spell6inder/yii2/labels{/name}","releases_url":"https://api.github.com/repos/Spell6inder/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/Spell6inder/yii2/deployments","created_at":"2019-08-08T14:25:18Z","updated_at":"2019-08-08T14:25:22Z","pushed_at":"2019-08-09T07:55:02Z","git_url":"git://github.com/Spell6inder/yii2.git","ssh_url":"git@github.com:Spell6inder/yii2.git","clone_url":"https://github.com/Spell6inder/yii2.git","svn_url":"https://github.com/Spell6inder/yii2","homepage":"http://www.yiiframework.com","size":73416,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"efe8d48f156e9e76994a2322cdd0fb4d68bd8f6a","user":{"login":"yiisoft","id":993323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MzMyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/993323?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"node_id":"MDEwOlJlcG9zaXRvcnkzNDMxMTkz","name":"yii2","full_name":"yiisoft/yii2","private":false,"owner":{"login":"yiisoft","id":993323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MzMyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/993323?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2019-08-09T08:36:56Z","pushed_at":"2019-08-09T07:55:12Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":73404,"stargazers_count":13018,"watchers_count":13018,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6796,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":524,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6796,"open_issues":524,"watchers":13018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/17501"},"html":{"href":"https://github.com/yiisoft/yii2/pull/17501"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/17501"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/17501/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/17501/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/17501/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/2bcf7354ec92a9219eddfc41ffad636f01082459"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samdark"}}