{"action":"closed","number":11198,"pull_request":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/11198","id":288146397,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4MTQ2Mzk3","html_url":"https://github.com/aspnet/AspNetCore/pull/11198","diff_url":"https://github.com/aspnet/AspNetCore/pull/11198.diff","patch_url":"https://github.com/aspnet/AspNetCore/pull/11198.patch","issue_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/11198","number":11198,"state":"closed","locked":false,"title":"Always include ANCM in build output","user":{"login":"jkotalik","id":8302101,"node_id":"MDQ6VXNlcjgzMDIxMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"Note, this is purely a build only change. I'm currently working on verifying this works with separate branches on aspnetci.\r\n\r\n## Impact\r\nAfter we stopped pushing to MyGet, ANCM transfer packages have stopped being uploaded. Builds are now failing with an error saying ANCM could not be found as an artifact dependency as well as the latest version of ANCM being 2.2.2 on myget. This change makes it so ANCM always builds, regardless of if there was a change to ANCM or not.\r\n\r\nThe reason this is fine is:\r\n- ANCM is shipped globally and isn't put in a package.\r\n- We are already doing this in 3.0.\r\n\r\n## Risk\r\nVery low risk. We are rebuilding ANCM every patch version, which will update dll/msi versions. However, the source code being used is the same.","created_at":"2019-06-14T00:57:57Z","updated_at":"2019-06-14T19:50:26Z","closed_at":"2019-06-14T19:50:26Z","merged_at":"2019-06-14T19:50:25Z","merge_commit_sha":"0460bc3ff8590d7eba798d6a377c3a3a607f05c9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anurse","id":7574,"node_id":"MDQ6VXNlcjc1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7574?v=4","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1119602498,"node_id":"MDU6TGFiZWwxMTE5NjAyNDk4","url":"https://api.github.com/repos/aspnet/AspNetCore/labels/area-servers","name":"area-servers","color":"5319e7","default":false},{"id":985473549,"node_id":"MDU6TGFiZWw5ODU0NzM1NDk=","url":"https://api.github.com/repos/aspnet/AspNetCore/labels/servicing-approved","name":"servicing-approved","color":"1e7a34","default":false}],"milestone":{"url":"https://api.github.com/repos/aspnet/AspNetCore/milestones/47","html_url":"https://github.com/aspnet/AspNetCore/milestone/47","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones/47/labels","id":4321850,"node_id":"MDk6TWlsZXN0b25lNDMyMTg1MA==","number":47,"title":"2.2.6","description":null,"creator":{"login":"leecow","id":2212879,"node_id":"MDQ6VXNlcjIyMTI4Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2212879?v=4","gravatar_id":"","url":"https://api.github.com/users/leecow","html_url":"https://github.com/leecow","followers_url":"https://api.github.com/users/leecow/followers","following_url":"https://api.github.com/users/leecow/following{/other_user}","gists_url":"https://api.github.com/users/leecow/gists{/gist_id}","starred_url":"https://api.github.com/users/leecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leecow/subscriptions","organizations_url":"https://api.github.com/users/leecow/orgs","repos_url":"https://api.github.com/users/leecow/repos","events_url":"https://api.github.com/users/leecow/events{/privacy}","received_events_url":"https://api.github.com/users/leecow/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2019-05-16T18:15:19Z","updated_at":"2019-06-14T19:50:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/11198/commits","review_comments_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/11198/comments","review_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/11198/comments","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/3322691f04dbec32ea85d2da4be8d91f46fe77f3","head":{"label":"aspnet:jkotalik/alwaysIncludeANCMInBuildOutput","ref":"jkotalik/alwaysIncludeANCMInBuildOutput","sha":"3322691f04dbec32ea85d2da4be8d91f46fe77f3","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-06-14T18:50:57Z","pushed_at":"2019-06-14T19:50:25Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":284278,"stargazers_count":12118,"watchers_count":12118,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2950,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1911,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2950,"open_issues":1911,"watchers":12118,"default_branch":"master"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"c5b2bc0df2a0027832bf7d01dfb19ca39cd08ae6","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-06-14T18:50:57Z","pushed_at":"2019-06-14T19:50:25Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":284278,"stargazers_count":12118,"watchers_count":12118,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2950,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1911,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2950,"open_issues":1911,"watchers":12118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/11198"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/11198"},"issue":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/11198"},"comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/11198/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/11198/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/11198/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/AspNetCore/statuses/3322691f04dbec32ea85d2da4be8d91f46fe77f3"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"JunTaoLuo","id":2030323,"node_id":"MDQ6VXNlcjIwMzAzMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2030323?v=4","gravatar_id":"","url":"https://api.github.com/users/JunTaoLuo","html_url":"https://github.com/JunTaoLuo","followers_url":"https://api.github.com/users/JunTaoLuo/followers","following_url":"https://api.github.com/users/JunTaoLuo/following{/other_user}","gists_url":"https://api.github.com/users/JunTaoLuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JunTaoLuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunTaoLuo/subscriptions","organizations_url":"https://api.github.com/users/JunTaoLuo/orgs","repos_url":"https://api.github.com/users/JunTaoLuo/repos","events_url":"https://api.github.com/users/JunTaoLuo/events{/privacy}","received_events_url":"https://api.github.com/users/JunTaoLuo/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"JunTaoLuo"}}