{"action":"closed","number":787,"pull_request":{"url":"https://api.github.com/repos/morse-simulator/morse/pulls/787","id":170466794,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcwNDY2Nzk0","html_url":"https://github.com/morse-simulator/morse/pull/787","diff_url":"https://github.com/morse-simulator/morse/pull/787.diff","patch_url":"https://github.com/morse-simulator/morse/pull/787.patch","issue_url":"https://api.github.com/repos/morse-simulator/morse/issues/787","number":787,"state":"closed","locked":false,"title":"Fixed and simplified create_new_material()","user":{"login":"cehberlin","id":327393,"node_id":"MDQ6VXNlcjMyNzM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/327393?v=4","gravatar_id":"","url":"https://api.github.com/users/cehberlin","html_url":"https://github.com/cehberlin","followers_url":"https://api.github.com/users/cehberlin/followers","following_url":"https://api.github.com/users/cehberlin/following{/other_user}","gists_url":"https://api.github.com/users/cehberlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cehberlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cehberlin/subscriptions","organizations_url":"https://api.github.com/users/cehberlin/orgs","repos_url":"https://api.github.com/users/cehberlin/repos","events_url":"https://api.github.com/users/cehberlin/events{/privacy}","received_events_url":"https://api.github.com/users/cehberlin/received_events","type":"User","site_admin":false},"body":"Fixed a problem that occured with some blender environments, the actual reason is unclear.\r\n\r\nHowever, the included simplification of the create_new_material() method solved the problem.\r\n\r\nThe original problem stack trace was the following:\r\n\r\nException ignored in: <bound method Environment.__del__ of <morse.builder.environment.Environment object at 0x7f94cce4a908>>\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python3/dist-packages/morse/builder/environment.py\", line 831, in __del__\r\n    self.create()\r\n  File \"/usr/local/lib/python3/dist-packages/morse/builder/environment.py\", line 300, in create\r\n    component.after_renaming()\r\n  File \"/usr/local/lib/python3/dist-packages/morse/builder/sensors.py\", line 290, in after_renaming\r\n    self.create_laser_arc()\r\n  File \"/usr/local/lib/python3/dist-packages/morse/builder/sensors.py\", line 283, in create_laser_arc\r\n    arc.active_material = self.get_ray_material()\r\n  File \"/usr/local/lib/python3/dist-packages/morse/builder/sensors.py\", line 186, in get_ray_material\r\n    ray_material = bpymorse.create_new_material()\r\n  File \"/usr/local/lib/python3/dist-packages/morse/builder/bpymorse.py\", line 96, in create_new_material\r\n    material_name = [name for name in get_materials().keys() \\\r\nIndexError: pop from empty list","created_at":"2018-02-21T13:16:58Z","updated_at":"2019-06-18T09:07:07Z","closed_at":"2019-06-18T09:07:07Z","merged_at":"2019-06-18T09:07:07Z","merge_commit_sha":"cc3547ae71277aa90baf0c68560263ba097c134b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/morse-simulator/morse/pulls/787/commits","review_comments_url":"https://api.github.com/repos/morse-simulator/morse/pulls/787/comments","review_comment_url":"https://api.github.com/repos/morse-simulator/morse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/morse-simulator/morse/issues/787/comments","statuses_url":"https://api.github.com/repos/morse-simulator/morse/statuses/abf2f5d42312b0950e7a369b472d4a478c62a83c","head":{"label":"cehberlin:fix_new_material","ref":"fix_new_material","sha":"abf2f5d42312b0950e7a369b472d4a478c62a83c","user":{"login":"cehberlin","id":327393,"node_id":"MDQ6VXNlcjMyNzM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/327393?v=4","gravatar_id":"","url":"https://api.github.com/users/cehberlin","html_url":"https://github.com/cehberlin","followers_url":"https://api.github.com/users/cehberlin/followers","following_url":"https://api.github.com/users/cehberlin/following{/other_user}","gists_url":"https://api.github.com/users/cehberlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cehberlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cehberlin/subscriptions","organizations_url":"https://api.github.com/users/cehberlin/orgs","repos_url":"https://api.github.com/users/cehberlin/repos","events_url":"https://api.github.com/users/cehberlin/events{/privacy}","received_events_url":"https://api.github.com/users/cehberlin/received_events","type":"User","site_admin":false},"repo":{"id":28804808,"node_id":"MDEwOlJlcG9zaXRvcnkyODgwNDgwOA==","name":"morse","full_name":"cehberlin/morse","private":false,"owner":{"login":"cehberlin","id":327393,"node_id":"MDQ6VXNlcjMyNzM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/327393?v=4","gravatar_id":"","url":"https://api.github.com/users/cehberlin","html_url":"https://github.com/cehberlin","followers_url":"https://api.github.com/users/cehberlin/followers","following_url":"https://api.github.com/users/cehberlin/following{/other_user}","gists_url":"https://api.github.com/users/cehberlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cehberlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cehberlin/subscriptions","organizations_url":"https://api.github.com/users/cehberlin/orgs","repos_url":"https://api.github.com/users/cehberlin/repos","events_url":"https://api.github.com/users/cehberlin/events{/privacy}","received_events_url":"https://api.github.com/users/cehberlin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cehberlin/morse","description":"The Modular OpenRobots Simulation Engine","fork":true,"url":"https://api.github.com/repos/cehberlin/morse","forks_url":"https://api.github.com/repos/cehberlin/morse/forks","keys_url":"https://api.github.com/repos/cehberlin/morse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cehberlin/morse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cehberlin/morse/teams","hooks_url":"https://api.github.com/repos/cehberlin/morse/hooks","issue_events_url":"https://api.github.com/repos/cehberlin/morse/issues/events{/number}","events_url":"https://api.github.com/repos/cehberlin/morse/events","assignees_url":"https://api.github.com/repos/cehberlin/morse/assignees{/user}","branches_url":"https://api.github.com/repos/cehberlin/morse/branches{/branch}","tags_url":"https://api.github.com/repos/cehberlin/morse/tags","blobs_url":"https://api.github.com/repos/cehberlin/morse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cehberlin/morse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cehberlin/morse/git/refs{/sha}","trees_url":"https://api.github.com/repos/cehberlin/morse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cehberlin/morse/statuses/{sha}","languages_url":"https://api.github.com/repos/cehberlin/morse/languages","stargazers_url":"https://api.github.com/repos/cehberlin/morse/stargazers","contributors_url":"https://api.github.com/repos/cehberlin/morse/contributors","subscribers_url":"https://api.github.com/repos/cehberlin/morse/subscribers","subscription_url":"https://api.github.com/repos/cehberlin/morse/subscription","commits_url":"https://api.github.com/repos/cehberlin/morse/commits{/sha}","git_commits_url":"https://api.github.com/repos/cehberlin/morse/git/commits{/sha}","comments_url":"https://api.github.com/repos/cehberlin/morse/comments{/number}","issue_comment_url":"https://api.github.com/repos/cehberlin/morse/issues/comments{/number}","contents_url":"https://api.github.com/repos/cehberlin/morse/contents/{+path}","compare_url":"https://api.github.com/repos/cehberlin/morse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cehberlin/morse/merges","archive_url":"https://api.github.com/repos/cehberlin/morse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cehberlin/morse/downloads","issues_url":"https://api.github.com/repos/cehberlin/morse/issues{/number}","pulls_url":"https://api.github.com/repos/cehberlin/morse/pulls{/number}","milestones_url":"https://api.github.com/repos/cehberlin/morse/milestones{/number}","notifications_url":"https://api.github.com/repos/cehberlin/morse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cehberlin/morse/labels{/name}","releases_url":"https://api.github.com/repos/cehberlin/morse/releases{/id}","deployments_url":"https://api.github.com/repos/cehberlin/morse/deployments","created_at":"2015-01-05T08:55:03Z","updated_at":"2015-09-14T08:26:48Z","pushed_at":"2018-02-21T13:14:40Z","git_url":"git://github.com/cehberlin/morse.git","ssh_url":"git@github.com:cehberlin/morse.git","clone_url":"https://github.com/cehberlin/morse.git","svn_url":"https://github.com/cehberlin/morse","homepage":"morse.openrobots.org","size":568300,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"morse-simulator:master","ref":"master","sha":"a64dcec89931304c93ac0b18cbe1ec8f211619b7","user":{"login":"morse-simulator","id":4056603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTY2MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4056603?v=4","gravatar_id":"","url":"https://api.github.com/users/morse-simulator","html_url":"https://github.com/morse-simulator","followers_url":"https://api.github.com/users/morse-simulator/followers","following_url":"https://api.github.com/users/morse-simulator/following{/other_user}","gists_url":"https://api.github.com/users/morse-simulator/gists{/gist_id}","starred_url":"https://api.github.com/users/morse-simulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morse-simulator/subscriptions","organizations_url":"https://api.github.com/users/morse-simulator/orgs","repos_url":"https://api.github.com/users/morse-simulator/repos","events_url":"https://api.github.com/users/morse-simulator/events{/privacy}","received_events_url":"https://api.github.com/users/morse-simulator/received_events","type":"Organization","site_admin":false},"repo":{"id":856780,"node_id":"MDEwOlJlcG9zaXRvcnk4NTY3ODA=","name":"morse","full_name":"morse-simulator/morse","private":false,"owner":{"login":"morse-simulator","id":4056603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTY2MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4056603?v=4","gravatar_id":"","url":"https://api.github.com/users/morse-simulator","html_url":"https://github.com/morse-simulator","followers_url":"https://api.github.com/users/morse-simulator/followers","following_url":"https://api.github.com/users/morse-simulator/following{/other_user}","gists_url":"https://api.github.com/users/morse-simulator/gists{/gist_id}","starred_url":"https://api.github.com/users/morse-simulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morse-simulator/subscriptions","organizations_url":"https://api.github.com/users/morse-simulator/orgs","repos_url":"https://api.github.com/users/morse-simulator/repos","events_url":"https://api.github.com/users/morse-simulator/events{/privacy}","received_events_url":"https://api.github.com/users/morse-simulator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/morse-simulator/morse","description":"The Modular OpenRobots Simulation Engine","fork":false,"url":"https://api.github.com/repos/morse-simulator/morse","forks_url":"https://api.github.com/repos/morse-simulator/morse/forks","keys_url":"https://api.github.com/repos/morse-simulator/morse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morse-simulator/morse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morse-simulator/morse/teams","hooks_url":"https://api.github.com/repos/morse-simulator/morse/hooks","issue_events_url":"https://api.github.com/repos/morse-simulator/morse/issues/events{/number}","events_url":"https://api.github.com/repos/morse-simulator/morse/events","assignees_url":"https://api.github.com/repos/morse-simulator/morse/assignees{/user}","branches_url":"https://api.github.com/repos/morse-simulator/morse/branches{/branch}","tags_url":"https://api.github.com/repos/morse-simulator/morse/tags","blobs_url":"https://api.github.com/repos/morse-simulator/morse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morse-simulator/morse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morse-simulator/morse/git/refs{/sha}","trees_url":"https://api.github.com/repos/morse-simulator/morse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morse-simulator/morse/statuses/{sha}","languages_url":"https://api.github.com/repos/morse-simulator/morse/languages","stargazers_url":"https://api.github.com/repos/morse-simulator/morse/stargazers","contributors_url":"https://api.github.com/repos/morse-simulator/morse/contributors","subscribers_url":"https://api.github.com/repos/morse-simulator/morse/subscribers","subscription_url":"https://api.github.com/repos/morse-simulator/morse/subscription","commits_url":"https://api.github.com/repos/morse-simulator/morse/commits{/sha}","git_commits_url":"https://api.github.com/repos/morse-simulator/morse/git/commits{/sha}","comments_url":"https://api.github.com/repos/morse-simulator/morse/comments{/number}","issue_comment_url":"https://api.github.com/repos/morse-simulator/morse/issues/comments{/number}","contents_url":"https://api.github.com/repos/morse-simulator/morse/contents/{+path}","compare_url":"https://api.github.com/repos/morse-simulator/morse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morse-simulator/morse/merges","archive_url":"https://api.github.com/repos/morse-simulator/morse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morse-simulator/morse/downloads","issues_url":"https://api.github.com/repos/morse-simulator/morse/issues{/number}","pulls_url":"https://api.github.com/repos/morse-simulator/morse/pulls{/number}","milestones_url":"https://api.github.com/repos/morse-simulator/morse/milestones{/number}","notifications_url":"https://api.github.com/repos/morse-simulator/morse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morse-simulator/morse/labels{/name}","releases_url":"https://api.github.com/repos/morse-simulator/morse/releases{/id}","deployments_url":"https://api.github.com/repos/morse-simulator/morse/deployments","created_at":"2010-08-23T14:41:06Z","updated_at":"2019-06-07T13:14:51Z","pushed_at":"2019-06-18T09:07:07Z","git_url":"git://github.com/morse-simulator/morse.git","ssh_url":"git@github.com:morse-simulator/morse.git","clone_url":"https://github.com/morse-simulator/morse.git","svn_url":"https://github.com/morse-simulator/morse","homepage":"http://morse-simulator.github.io/","size":573908,"stargazers_count":265,"watchers_count":265,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":124,"open_issues":98,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/morse-simulator/morse/pulls/787"},"html":{"href":"https://github.com/morse-simulator/morse/pull/787"},"issue":{"href":"https://api.github.com/repos/morse-simulator/morse/issues/787"},"comments":{"href":"https://api.github.com/repos/morse-simulator/morse/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/morse-simulator/morse/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/morse-simulator/morse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/morse-simulator/morse/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/morse-simulator/morse/statuses/abf2f5d42312b0950e7a369b472d4a478c62a83c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"severin-lemaignan","id":385379,"node_id":"MDQ6VXNlcjM4NTM3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/385379?v=4","gravatar_id":"","url":"https://api.github.com/users/severin-lemaignan","html_url":"https://github.com/severin-lemaignan","followers_url":"https://api.github.com/users/severin-lemaignan/followers","following_url":"https://api.github.com/users/severin-lemaignan/following{/other_user}","gists_url":"https://api.github.com/users/severin-lemaignan/gists{/gist_id}","starred_url":"https://api.github.com/users/severin-lemaignan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/severin-lemaignan/subscriptions","organizations_url":"https://api.github.com/users/severin-lemaignan/orgs","repos_url":"https://api.github.com/users/severin-lemaignan/repos","events_url":"https://api.github.com/users/severin-lemaignan/events{/privacy}","received_events_url":"https://api.github.com/users/severin-lemaignan/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"severin-lemaignan"}}