{"action":"created","comment":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/comments/341838746","pull_request_review_id":310802835,"id":341838746,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTgzODc0Ng==","diff_hunk":"@@ -313,4 +348,59 @@ extension SCNetworkReachabilityFlags {\n     var isConnectionRequiredAndTransientFlagSet: Bool {\n         return intersection([.connectionRequired, .transientConnection]) == [.connectionRequired, .transientConnection]\n     }\n+\n+    var description: String {\n+        let W = isOnWWANFlagSet ? \"W\" : \"-\"\n+        let R = isReachableFlagSet ? \"R\" : \"-\"\n+        let c = isConnectionRequiredFlagSet ? \"c\" : \"-\"\n+        let t = isTransientConnectionFlagSet ? \"t\" : \"-\"","path":"Pods/ReachabilitySwift/Sources/Reachability.swift","position":282,"original_position":282,"commit_id":"4b5c727296df43552bb29f3ee8f999f671518fee","original_commit_id":"4b5c727296df43552bb29f3ee8f999f671518fee","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Identifier Name Violation: Variable name should be between 3 and 40 characters long: 't' (identifier_name)","created_at":"2019-11-03T07:27:53Z","updated_at":"2019-11-03T07:27:55Z","html_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2781#discussion_r341838746","pull_request_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/comments/341838746"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2781#discussion_r341838746"},"pull_request":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781"}}},"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781","id":336000027,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2MDAwMDI3","html_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2781","diff_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2781.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2781.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2781","number":2781,"state":"open","locked":false,"title":"[WIP] RC Xcode-11 workaround","user":{"login":"bobrenji","id":136671,"node_id":"MDQ6VXNlcjEzNjY3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/136671?v=4","gravatar_id":"","url":"https://api.github.com/users/bobrenji","html_url":"https://github.com/bobrenji","followers_url":"https://api.github.com/users/bobrenji/followers","following_url":"https://api.github.com/users/bobrenji/following{/other_user}","gists_url":"https://api.github.com/users/bobrenji/gists{/gist_id}","starred_url":"https://api.github.com/users/bobrenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobrenji/subscriptions","organizations_url":"https://api.github.com/users/bobrenji/orgs","repos_url":"https://api.github.com/users/bobrenji/repos","events_url":"https://api.github.com/users/bobrenji/events{/privacy}","received_events_url":"https://api.github.com/users/bobrenji/received_events","type":"User","site_admin":false},"body":"@RocketChat/ios\r\n\r\nPlease note this branch is still [WIP]. Please help me to review.\r\n\r\nIssue 1: After successful login, app shows black screen\r\nHow to produce:  Run on Xcode -11  [Fixed as a work around]\r\n\r\nIssue 2: App always shows notification view on top of the screen. [Fixed as a work around]\r\nSoln: NotificationViewController.shared.notificationViewIsHidden = true add as a work around. But not able to figure out what is the root cause.\r\n\r\nIssue 3: SearchBar in SubscriptionsViewController shows navigation bar without background color.\r\nonce search view appears, navigation bar background color become transparent. [No solution yet]","created_at":"2019-11-03T07:25:30Z","updated_at":"2019-11-03T07:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b73888edb382524b61d4d086ed3cb6dd00c2ba8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2781/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/4b5c727296df43552bb29f3ee8f999f671518fee","head":{"label":"bobrenji:rc-xcode-11-wip","ref":"rc-xcode-11-wip","sha":"4b5c727296df43552bb29f3ee8f999f671518fee","user":{"login":"bobrenji","id":136671,"node_id":"MDQ6VXNlcjEzNjY3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/136671?v=4","gravatar_id":"","url":"https://api.github.com/users/bobrenji","html_url":"https://github.com/bobrenji","followers_url":"https://api.github.com/users/bobrenji/followers","following_url":"https://api.github.com/users/bobrenji/following{/other_user}","gists_url":"https://api.github.com/users/bobrenji/gists{/gist_id}","starred_url":"https://api.github.com/users/bobrenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobrenji/subscriptions","organizations_url":"https://api.github.com/users/bobrenji/orgs","repos_url":"https://api.github.com/users/bobrenji/repos","events_url":"https://api.github.com/users/bobrenji/events{/privacy}","received_events_url":"https://api.github.com/users/bobrenji/received_events","type":"User","site_admin":false},"repo":{"id":219239859,"node_id":"MDEwOlJlcG9zaXRvcnkyMTkyMzk4NTk=","name":"Rocket.Chat.iOS","full_name":"bobrenji/Rocket.Chat.iOS","private":false,"owner":{"login":"bobrenji","id":136671,"node_id":"MDQ6VXNlcjEzNjY3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/136671?v=4","gravatar_id":"","url":"https://api.github.com/users/bobrenji","html_url":"https://github.com/bobrenji","followers_url":"https://api.github.com/users/bobrenji/followers","following_url":"https://api.github.com/users/bobrenji/following{/other_user}","gists_url":"https://api.github.com/users/bobrenji/gists{/gist_id}","starred_url":"https://api.github.com/users/bobrenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobrenji/subscriptions","organizations_url":"https://api.github.com/users/bobrenji/orgs","repos_url":"https://api.github.com/users/bobrenji/repos","events_url":"https://api.github.com/users/bobrenji/events{/privacy}","received_events_url":"https://api.github.com/users/bobrenji/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bobrenji/Rocket.Chat.iOS","description":"Rocket.Chat client in Swift for iOS","fork":true,"url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS","forks_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/forks","keys_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/teams","hooks_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/hooks","issue_events_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/issues/events{/number}","events_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/events","assignees_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/assignees{/user}","branches_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/branches{/branch}","tags_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/tags","blobs_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/languages","stargazers_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/stargazers","contributors_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/contributors","subscribers_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/subscribers","subscription_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/subscription","commits_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/contents/{+path}","compare_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/merges","archive_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/downloads","issues_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/issues{/number}","pulls_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/labels{/name}","releases_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/releases{/id}","deployments_url":"https://api.github.com/repos/bobrenji/Rocket.Chat.iOS/deployments","created_at":"2019-11-03T02:13:27Z","updated_at":"2019-11-03T02:13:29Z","pushed_at":"2019-11-03T07:16:23Z","git_url":"git://github.com/bobrenji/Rocket.Chat.iOS.git","ssh_url":"git@github.com:bobrenji/Rocket.Chat.iOS.git","clone_url":"https://github.com/bobrenji/Rocket.Chat.iOS.git","svn_url":"https://github.com/bobrenji/Rocket.Chat.iOS","homepage":"https://rocket.chat","size":186809,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"936f0492f43f78da9f908f98d23c675b11048c0c","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":40144228,"node_id":"MDEwOlJlcG9zaXRvcnk0MDE0NDIyOA==","name":"Rocket.Chat.iOS","full_name":"RocketChat/Rocket.Chat.iOS","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat.iOS","description":"Rocket.Chat client in Swift for iOS","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/deployments","created_at":"2015-08-03T19:37:05Z","updated_at":"2019-10-30T16:25:42Z","pushed_at":"2019-11-03T07:25:31Z","git_url":"git://github.com/RocketChat/Rocket.Chat.iOS.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.iOS.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.iOS.git","svn_url":"https://github.com/RocketChat/Rocket.Chat.iOS","homepage":"https://rocket.chat","size":186809,"stargazers_count":970,"watchers_count":970,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":426,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":211,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":426,"open_issues":211,"watchers":970,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2781"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2781"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2781/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2781/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/4b5c727296df43552bb29f3ee8f999f671518fee"}},"author_association":"NONE"}}
{"actor":{"display_login":"houndci-bot"}}