{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/278966660","pull_request_review_id":231179579,"id":278966660,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODk2NjY2MA==","diff_hunk":"@@ -27,8 +27,8 @@ def check_graph(self, graph, verify, interactive):\n \n     def _handle_recipe(self, node, verify, interactive):\n         ref = node.ref\n-        export = self._cache.export(ref)\n-        exports_sources_folder = self._cache.export_sources(ref)\n+        export = self._cache.package_layout(ref).export()\n+        exports_sources_folder = self._cache.package_layout(ref).export_sources()","path":"conans/client/manifest_manager.py","position":7,"original_position":7,"commit_id":"1159769cc54e18c1469d0cc860e3d0b7575e7c64","original_commit_id":"1159769cc54e18c1469d0cc860e3d0b7575e7c64","user":{"login":"jgsogo","id":1406456,"node_id":"MDQ6VXNlcjE0MDY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1406456?v=4","gravatar_id":"","url":"https://api.github.com/users/jgsogo","html_url":"https://github.com/jgsogo","followers_url":"https://api.github.com/users/jgsogo/followers","following_url":"https://api.github.com/users/jgsogo/following{/other_user}","gists_url":"https://api.github.com/users/jgsogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jgsogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgsogo/subscriptions","organizations_url":"https://api.github.com/users/jgsogo/orgs","repos_url":"https://api.github.com/users/jgsogo/repos","events_url":"https://api.github.com/users/jgsogo/events{/privacy}","received_events_url":"https://api.github.com/users/jgsogo/received_events","type":"User","site_admin":false},"body":"`self._cache.export_sources(ref, short_paths=False)`\r\nvs\r\n`self._cache.package_layout(ref, short_paths=None).export_sources()`","created_at":"2019-04-26T14:13:40Z","updated_at":"2019-04-26T14:29:28Z","html_url":"https://github.com/conan-io/conan/pull/5033#discussion_r278966660","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/5033","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/278966660"},"html":{"href":"https://github.com/conan-io/conan/pull/5033#discussion_r278966660"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/5033"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/5033","id":273602822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNjAyODIy","html_url":"https://github.com/conan-io/conan/pull/5033","diff_url":"https://github.com/conan-io/conan/pull/5033.diff","patch_url":"https://github.com/conan-io/conan/pull/5033.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/5033","number":5033,"state":"open","locked":false,"title":"refactor layouts","user":{"login":"memsharded","id":15367152,"node_id":"MDQ6VXNlcjE1MzY3MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"body":"Changelog: omit\r\nDocs: omit\r\n\r\n\r\nRemove old legacy methods from cache, use the equivalents from package_layout.\r\n\r\n@tags: slow","created_at":"2019-04-25T16:44:18Z","updated_at":"2019-04-26T14:29:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e298b38807ad5a3a991ac2d23d9f24ef7f5963f","assignee":{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"assignees":[{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":821746717,"node_id":"MDU6TGFiZWw4MjE3NDY3MTc=","url":"https://api.github.com/repos/conan-io/conan/labels/stage:%20review","name":"stage: review","color":"6caf57","default":false}],"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/88","html_url":"https://github.com/conan-io/conan/milestone/88","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/88/labels","id":4143541,"node_id":"MDk6TWlsZXN0b25lNDE0MzU0MQ==","number":88,"title":"1.15","description":null,"creator":{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":56,"state":"open","created_at":"2019-03-15T11:40:45Z","updated_at":"2019-04-26T14:03:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/5033/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/5033/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/5033/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/1159769cc54e18c1469d0cc860e3d0b7575e7c64","head":{"label":"memsharded:feature/refactor_layouts","ref":"feature/refactor_layouts","sha":"1159769cc54e18c1469d0cc860e3d0b7575e7c64","user":{"login":"memsharded","id":15367152,"node_id":"MDQ6VXNlcjE1MzY3MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"repo":{"id":47975067,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzk3NTA2Nw==","name":"conan","full_name":"memsharded/conan","private":false,"owner":{"login":"memsharded","id":15367152,"node_id":"MDQ6VXNlcjE1MzY3MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"html_url":"https://github.com/memsharded/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/memsharded/conan","forks_url":"https://api.github.com/repos/memsharded/conan/forks","keys_url":"https://api.github.com/repos/memsharded/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/memsharded/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/memsharded/conan/teams","hooks_url":"https://api.github.com/repos/memsharded/conan/hooks","issue_events_url":"https://api.github.com/repos/memsharded/conan/issues/events{/number}","events_url":"https://api.github.com/repos/memsharded/conan/events","assignees_url":"https://api.github.com/repos/memsharded/conan/assignees{/user}","branches_url":"https://api.github.com/repos/memsharded/conan/branches{/branch}","tags_url":"https://api.github.com/repos/memsharded/conan/tags","blobs_url":"https://api.github.com/repos/memsharded/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/memsharded/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/memsharded/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/memsharded/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/memsharded/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/memsharded/conan/languages","stargazers_url":"https://api.github.com/repos/memsharded/conan/stargazers","contributors_url":"https://api.github.com/repos/memsharded/conan/contributors","subscribers_url":"https://api.github.com/repos/memsharded/conan/subscribers","subscription_url":"https://api.github.com/repos/memsharded/conan/subscription","commits_url":"https://api.github.com/repos/memsharded/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/memsharded/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/memsharded/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/memsharded/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/memsharded/conan/contents/{+path}","compare_url":"https://api.github.com/repos/memsharded/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/memsharded/conan/merges","archive_url":"https://api.github.com/repos/memsharded/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/memsharded/conan/downloads","issues_url":"https://api.github.com/repos/memsharded/conan/issues{/number}","pulls_url":"https://api.github.com/repos/memsharded/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/memsharded/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/memsharded/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/memsharded/conan/labels{/name}","releases_url":"https://api.github.com/repos/memsharded/conan/releases{/id}","deployments_url":"https://api.github.com/repos/memsharded/conan/deployments","created_at":"2015-12-14T12:55:58Z","updated_at":"2016-10-26T08:23:43Z","pushed_at":"2019-04-25T22:36:14Z","git_url":"git://github.com/memsharded/conan.git","ssh_url":"git@github.com:memsharded/conan.git","clone_url":"https://github.com/memsharded/conan.git","svn_url":"https://github.com/memsharded/conan","homepage":"https://conan.io","size":9430,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"0ff305aaf03e008505c10b66decec4cc782ded4e","user":{"login":"conan-io","id":15212165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"node_id":"MDEwOlJlcG9zaXRvcnk0NzE5MDYyNA==","name":"conan","full_name":"conan-io/conan","private":false,"owner":{"login":"conan-io","id":15212165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2019-04-26T14:04:03Z","pushed_at":"2019-04-26T14:05:32Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":8744,"stargazers_count":2741,"watchers_count":2741,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":731,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":358,"open_issues":731,"watchers":2741,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/5033"},"html":{"href":"https://github.com/conan-io/conan/pull/5033"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/5033"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/5033/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/5033/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/5033/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/1159769cc54e18c1469d0cc860e3d0b7575e7c64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jgsogo"}}