{"action":"created","comment":{"url":"https://api.github.com/repos/sciath/sciath/pulls/comments/341194844","pull_request_review_id":309955846,"id":341194844,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTE5NDg0NA==","diff_hunk":"@@ -48,135 +48,268 @@ def formatMPILaunchCommand(mpiLaunch,ranks,corespernode):\n         launch = launch.replace(\"<ranks_per_node>\",str(corespernode))\n         launch = launch.replace(\"<RANKSPERNODE>\",str(corespernode))\n         launch = launch.replace(\"<RANKS_PER_NODE>\",str(corespernode))\n-    return(launch)\n-\n-def generateLaunch_PBS(accountname,queuename,testname,mpiLaunch,executable,ranks,ranks_per_node,walltime,outfile):\n-    if not ranks:\n-        print(\"<generateLaunch_PBS>: Requires the number of MPI-ranks be specified\")\n-    if not walltime:\n-        print(\"<generateLaunch_PBS>: Requires the walltime be specified\")\n-\n-    filename = testname + '-sciath.pbs'\n+    return launch.split()\n+\n+\n+# Returns name lists for error-code file (one per job), stdout, stderr\n+def _getLaunchStandardOutputFileNames(job):\n+    jobnames = []\n+    try:\n+        jobnames = job.createJobOrdering()\n+    except:\n+        jobnames.append(job.name)\n+\n+    errorCodeName = \"sciath.job-\" +  job.name + \".errorcode\"\n+    stdoutName = []\n+    stderrName = []\n+\n+    lc_count = len(jobnames)\n+    for i in range(0,len(jobnames)):\n+        jprefix = \"\".join([\"sciath.depjob-\",str(lc_count),'-',jobnames[i]])\n+        if lc_count == 1: # we do something special for the last job in a sequence/DAG list\n+            jprefix = \"sciath.job-\" + job.name\n+        \n+        stdoutName.append( jprefix + \".stdout\" )\n+        stderrName.append( jprefix + \".stderr\" )\n+\n+        lc_count -= 1\n+\n+    return errorCodeName, stdoutName, stderrName\n+\n+def _removeFile(file2rm):","path":"sciath/launcher.py","position":50,"original_position":50,"commit_id":"b134121cacc4aa8f87ce7776e68676b4d0a4a624","original_commit_id":"ecbe4bd5fda999c8178660bf77908403a4fa166b","user":{"login":"psanan","id":8024239,"node_id":"MDQ6VXNlcjgwMjQyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8024239?v=4","gravatar_id":"","url":"https://api.github.com/users/psanan","html_url":"https://github.com/psanan","followers_url":"https://api.github.com/users/psanan/followers","following_url":"https://api.github.com/users/psanan/following{/other_user}","gists_url":"https://api.github.com/users/psanan/gists{/gist_id}","starred_url":"https://api.github.com/users/psanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psanan/subscriptions","organizations_url":"https://api.github.com/users/psanan/orgs","repos_url":"https://api.github.com/users/psanan/repos","events_url":"https://api.github.com/users/psanan/events{/privacy}","received_events_url":"https://api.github.com/users/psanan/received_events","type":"User","site_admin":false},"body":"(For now, working around this by doing e.g. `yes | ./runTests.py`)","created_at":"2019-10-31T15:10:07Z","updated_at":"2019-10-31T15:10:08Z","html_url":"https://github.com/sciath/sciath/pull/47#discussion_r341194844","pull_request_url":"https://api.github.com/repos/sciath/sciath/pulls/47","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sciath/sciath/pulls/comments/341194844"},"html":{"href":"https://github.com/sciath/sciath/pull/47#discussion_r341194844"},"pull_request":{"href":"https://api.github.com/repos/sciath/sciath/pulls/47"}},"in_reply_to_id":341171291},"pull_request":{"url":"https://api.github.com/repos/sciath/sciath/pulls/47","id":333135842,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzMTM1ODQy","html_url":"https://github.com/sciath/sciath/pull/47","diff_url":"https://github.com/sciath/sciath/pull/47.diff","patch_url":"https://github.com/sciath/sciath/pull/47.patch","issue_url":"https://api.github.com/repos/sciath/sciath/issues/47","number":47,"state":"open","locked":false,"title":"Dmay/job launcher refactor","user":{"login":"psanan","id":8024239,"node_id":"MDQ6VXNlcjgwMjQyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8024239?v=4","gravatar_id":"","url":"https://api.github.com/users/psanan","html_url":"https://github.com/psanan","followers_url":"https://api.github.com/users/psanan/followers","following_url":"https://api.github.com/users/psanan/following{/other_user}","gists_url":"https://api.github.com/users/psanan/gists{/gist_id}","starred_url":"https://api.github.com/users/psanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psanan/subscriptions","organizations_url":"https://api.github.com/users/psanan/orgs","repos_url":"https://api.github.com/users/psanan/repos","events_url":"https://api.github.com/users/psanan/events{/privacy}","received_events_url":"https://api.github.com/users/psanan/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-28T14:09:31Z","updated_at":"2019-10-31T15:10:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e39769d6203b3e76630719e8b9429824cfa6413b","assignee":{"login":"psanan","id":8024239,"node_id":"MDQ6VXNlcjgwMjQyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8024239?v=4","gravatar_id":"","url":"https://api.github.com/users/psanan","html_url":"https://github.com/psanan","followers_url":"https://api.github.com/users/psanan/followers","following_url":"https://api.github.com/users/psanan/following{/other_user}","gists_url":"https://api.github.com/users/psanan/gists{/gist_id}","starred_url":"https://api.github.com/users/psanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psanan/subscriptions","organizations_url":"https://api.github.com/users/psanan/orgs","repos_url":"https://api.github.com/users/psanan/repos","events_url":"https://api.github.com/users/psanan/events{/privacy}","received_events_url":"https://api.github.com/users/psanan/received_events","type":"User","site_admin":false},"assignees":[{"login":"psanan","id":8024239,"node_id":"MDQ6VXNlcjgwMjQyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8024239?v=4","gravatar_id":"","url":"https://api.github.com/users/psanan","html_url":"https://github.com/psanan","followers_url":"https://api.github.com/users/psanan/followers","following_url":"https://api.github.com/users/psanan/following{/other_user}","gists_url":"https://api.github.com/users/psanan/gists{/gist_id}","starred_url":"https://api.github.com/users/psanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psanan/subscriptions","organizations_url":"https://api.github.com/users/psanan/orgs","repos_url":"https://api.github.com/users/psanan/repos","events_url":"https://api.github.com/users/psanan/events{/privacy}","received_events_url":"https://api.github.com/users/psanan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/sciath/sciath/milestones/1","html_url":"https://github.com/sciath/sciath/milestone/1","labels_url":"https://api.github.com/repos/sciath/sciath/milestones/1/labels","id":4479744,"node_id":"MDk6TWlsZXN0b25lNDQ3OTc0NA==","number":1,"title":"Refactor Existing Functionality","description":"","creator":{"login":"psanan","id":8024239,"node_id":"MDQ6VXNlcjgwMjQyMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8024239?v=4","gravatar_id":"","url":"https://api.github.com/users/psanan","html_url":"https://github.com/psanan","followers_url":"https://api.github.com/users/psanan/followers","following_url":"https://api.github.com/users/psanan/following{/other_user}","gists_url":"https://api.github.com/users/psanan/gists{/gist_id}","starred_url":"https://api.github.com/users/psanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psanan/subscriptions","organizations_url":"https://api.github.com/users/psanan/orgs","repos_url":"https://api.github.com/users/psanan/repos","events_url":"https://api.github.com/users/psanan/events{/privacy}","received_events_url":"https://api.github.com/users/psanan/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":2,"state":"open","created_at":"2019-07-10T05:26:19Z","updated_at":"2019-10-28T14:09:49Z","due_on":"2019-07-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sciath/sciath/pulls/47/commits","review_comments_url":"https://api.github.com/repos/sciath/sciath/pulls/47/comments","review_comment_url":"https://api.github.com/repos/sciath/sciath/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sciath/sciath/issues/47/comments","statuses_url":"https://api.github.com/repos/sciath/sciath/statuses/b134121cacc4aa8f87ce7776e68676b4d0a4a624","head":{"label":"sciath:dmay/job-launcher-refactor","ref":"dmay/job-launcher-refactor","sha":"b134121cacc4aa8f87ce7776e68676b4d0a4a624","user":{"login":"sciath","id":52410208,"node_id":"MDQ6VXNlcjUyNDEwMjA4","avatar_url":"https://avatars0.githubusercontent.com/u/52410208?v=4","gravatar_id":"","url":"https://api.github.com/users/sciath","html_url":"https://github.com/sciath","followers_url":"https://api.github.com/users/sciath/followers","following_url":"https://api.github.com/users/sciath/following{/other_user}","gists_url":"https://api.github.com/users/sciath/gists{/gist_id}","starred_url":"https://api.github.com/users/sciath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sciath/subscriptions","organizations_url":"https://api.github.com/users/sciath/orgs","repos_url":"https://api.github.com/users/sciath/repos","events_url":"https://api.github.com/users/sciath/events{/privacy}","received_events_url":"https://api.github.com/users/sciath/received_events","type":"User","site_admin":false},"repo":{"id":194660705,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ2NjA3MDU=","name":"sciath","full_name":"sciath/sciath","private":false,"owner":{"login":"sciath","id":52410208,"node_id":"MDQ6VXNlcjUyNDEwMjA4","avatar_url":"https://avatars0.githubusercontent.com/u/52410208?v=4","gravatar_id":"","url":"https://api.github.com/users/sciath","html_url":"https://github.com/sciath","followers_url":"https://api.github.com/users/sciath/followers","following_url":"https://api.github.com/users/sciath/following{/other_user}","gists_url":"https://api.github.com/users/sciath/gists{/gist_id}","starred_url":"https://api.github.com/users/sciath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sciath/subscriptions","organizations_url":"https://api.github.com/users/sciath/orgs","repos_url":"https://api.github.com/users/sciath/repos","events_url":"https://api.github.com/users/sciath/events{/privacy}","received_events_url":"https://api.github.com/users/sciath/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sciath/sciath","description":"SciATH: Scientific Application Test Harness","fork":false,"url":"https://api.github.com/repos/sciath/sciath","forks_url":"https://api.github.com/repos/sciath/sciath/forks","keys_url":"https://api.github.com/repos/sciath/sciath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sciath/sciath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sciath/sciath/teams","hooks_url":"https://api.github.com/repos/sciath/sciath/hooks","issue_events_url":"https://api.github.com/repos/sciath/sciath/issues/events{/number}","events_url":"https://api.github.com/repos/sciath/sciath/events","assignees_url":"https://api.github.com/repos/sciath/sciath/assignees{/user}","branches_url":"https://api.github.com/repos/sciath/sciath/branches{/branch}","tags_url":"https://api.github.com/repos/sciath/sciath/tags","blobs_url":"https://api.github.com/repos/sciath/sciath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sciath/sciath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sciath/sciath/git/refs{/sha}","trees_url":"https://api.github.com/repos/sciath/sciath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sciath/sciath/statuses/{sha}","languages_url":"https://api.github.com/repos/sciath/sciath/languages","stargazers_url":"https://api.github.com/repos/sciath/sciath/stargazers","contributors_url":"https://api.github.com/repos/sciath/sciath/contributors","subscribers_url":"https://api.github.com/repos/sciath/sciath/subscribers","subscription_url":"https://api.github.com/repos/sciath/sciath/subscription","commits_url":"https://api.github.com/repos/sciath/sciath/commits{/sha}","git_commits_url":"https://api.github.com/repos/sciath/sciath/git/commits{/sha}","comments_url":"https://api.github.com/repos/sciath/sciath/comments{/number}","issue_comment_url":"https://api.github.com/repos/sciath/sciath/issues/comments{/number}","contents_url":"https://api.github.com/repos/sciath/sciath/contents/{+path}","compare_url":"https://api.github.com/repos/sciath/sciath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sciath/sciath/merges","archive_url":"https://api.github.com/repos/sciath/sciath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sciath/sciath/downloads","issues_url":"https://api.github.com/repos/sciath/sciath/issues{/number}","pulls_url":"https://api.github.com/repos/sciath/sciath/pulls{/number}","milestones_url":"https://api.github.com/repos/sciath/sciath/milestones{/number}","notifications_url":"https://api.github.com/repos/sciath/sciath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sciath/sciath/labels{/name}","releases_url":"https://api.github.com/repos/sciath/sciath/releases{/id}","deployments_url":"https://api.github.com/repos/sciath/sciath/deployments","created_at":"2019-07-01T11:34:47Z","updated_at":"2019-10-24T12:37:52Z","pushed_at":"2019-10-31T15:03:09Z","git_url":"git://github.com/sciath/sciath.git","ssh_url":"git@github.com:sciath/sciath.git","clone_url":"https://github.com/sciath/sciath.git","svn_url":"https://github.com/sciath/sciath","homepage":"https://sciath.readthedocs.org","size":376,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":30,"watchers":0,"default_branch":"dev"}},"base":{"label":"sciath:dev","ref":"dev","sha":"15cb9250e9e28a612d2edc812f1c2edc1a0732cb","user":{"login":"sciath","id":52410208,"node_id":"MDQ6VXNlcjUyNDEwMjA4","avatar_url":"https://avatars0.githubusercontent.com/u/52410208?v=4","gravatar_id":"","url":"https://api.github.com/users/sciath","html_url":"https://github.com/sciath","followers_url":"https://api.github.com/users/sciath/followers","following_url":"https://api.github.com/users/sciath/following{/other_user}","gists_url":"https://api.github.com/users/sciath/gists{/gist_id}","starred_url":"https://api.github.com/users/sciath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sciath/subscriptions","organizations_url":"https://api.github.com/users/sciath/orgs","repos_url":"https://api.github.com/users/sciath/repos","events_url":"https://api.github.com/users/sciath/events{/privacy}","received_events_url":"https://api.github.com/users/sciath/received_events","type":"User","site_admin":false},"repo":{"id":194660705,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ2NjA3MDU=","name":"sciath","full_name":"sciath/sciath","private":false,"owner":{"login":"sciath","id":52410208,"node_id":"MDQ6VXNlcjUyNDEwMjA4","avatar_url":"https://avatars0.githubusercontent.com/u/52410208?v=4","gravatar_id":"","url":"https://api.github.com/users/sciath","html_url":"https://github.com/sciath","followers_url":"https://api.github.com/users/sciath/followers","following_url":"https://api.github.com/users/sciath/following{/other_user}","gists_url":"https://api.github.com/users/sciath/gists{/gist_id}","starred_url":"https://api.github.com/users/sciath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sciath/subscriptions","organizations_url":"https://api.github.com/users/sciath/orgs","repos_url":"https://api.github.com/users/sciath/repos","events_url":"https://api.github.com/users/sciath/events{/privacy}","received_events_url":"https://api.github.com/users/sciath/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sciath/sciath","description":"SciATH: Scientific Application Test Harness","fork":false,"url":"https://api.github.com/repos/sciath/sciath","forks_url":"https://api.github.com/repos/sciath/sciath/forks","keys_url":"https://api.github.com/repos/sciath/sciath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sciath/sciath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sciath/sciath/teams","hooks_url":"https://api.github.com/repos/sciath/sciath/hooks","issue_events_url":"https://api.github.com/repos/sciath/sciath/issues/events{/number}","events_url":"https://api.github.com/repos/sciath/sciath/events","assignees_url":"https://api.github.com/repos/sciath/sciath/assignees{/user}","branches_url":"https://api.github.com/repos/sciath/sciath/branches{/branch}","tags_url":"https://api.github.com/repos/sciath/sciath/tags","blobs_url":"https://api.github.com/repos/sciath/sciath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sciath/sciath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sciath/sciath/git/refs{/sha}","trees_url":"https://api.github.com/repos/sciath/sciath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sciath/sciath/statuses/{sha}","languages_url":"https://api.github.com/repos/sciath/sciath/languages","stargazers_url":"https://api.github.com/repos/sciath/sciath/stargazers","contributors_url":"https://api.github.com/repos/sciath/sciath/contributors","subscribers_url":"https://api.github.com/repos/sciath/sciath/subscribers","subscription_url":"https://api.github.com/repos/sciath/sciath/subscription","commits_url":"https://api.github.com/repos/sciath/sciath/commits{/sha}","git_commits_url":"https://api.github.com/repos/sciath/sciath/git/commits{/sha}","comments_url":"https://api.github.com/repos/sciath/sciath/comments{/number}","issue_comment_url":"https://api.github.com/repos/sciath/sciath/issues/comments{/number}","contents_url":"https://api.github.com/repos/sciath/sciath/contents/{+path}","compare_url":"https://api.github.com/repos/sciath/sciath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sciath/sciath/merges","archive_url":"https://api.github.com/repos/sciath/sciath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sciath/sciath/downloads","issues_url":"https://api.github.com/repos/sciath/sciath/issues{/number}","pulls_url":"https://api.github.com/repos/sciath/sciath/pulls{/number}","milestones_url":"https://api.github.com/repos/sciath/sciath/milestones{/number}","notifications_url":"https://api.github.com/repos/sciath/sciath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sciath/sciath/labels{/name}","releases_url":"https://api.github.com/repos/sciath/sciath/releases{/id}","deployments_url":"https://api.github.com/repos/sciath/sciath/deployments","created_at":"2019-07-01T11:34:47Z","updated_at":"2019-10-24T12:37:52Z","pushed_at":"2019-10-31T15:03:09Z","git_url":"git://github.com/sciath/sciath.git","ssh_url":"git@github.com:sciath/sciath.git","clone_url":"https://github.com/sciath/sciath.git","svn_url":"https://github.com/sciath/sciath","homepage":"https://sciath.readthedocs.org","size":376,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":30,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/sciath/sciath/pulls/47"},"html":{"href":"https://github.com/sciath/sciath/pull/47"},"issue":{"href":"https://api.github.com/repos/sciath/sciath/issues/47"},"comments":{"href":"https://api.github.com/repos/sciath/sciath/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/sciath/sciath/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/sciath/sciath/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sciath/sciath/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/sciath/sciath/statuses/b134121cacc4aa8f87ce7776e68676b4d0a4a624"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"psanan"}}