{"action":"created","comment":{"url":"https://api.github.com/repos/scality/metalk8s/pulls/comments/294823952","pull_request_review_id":251099300,"id":294823952,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDgyMzk1Mg==","diff_hunk":"@@ -11,8 +11,8 @@ Mount this ISO file at the specific following path:\n \n .. code-block:: shell\n \n-   root@bootstrap $ mkdir -p /srv/scality/metalk8s-|version|","path":"docs/quickstart/bootstrap.rst","position":4,"original_position":4,"commit_id":"a7bfc451c12325ae4e4b172b103f73b9b0c08e14","original_commit_id":"18d4c4e634ab4620e893fa182cd023e7b5038caa","user":{"login":"TeddyAndrieux","id":41334261,"node_id":"MDQ6VXNlcjQxMzM0MjYx","avatar_url":"https://avatars3.githubusercontent.com/u/41334261?v=4","gravatar_id":"","url":"https://api.github.com/users/TeddyAndrieux","html_url":"https://github.com/TeddyAndrieux","followers_url":"https://api.github.com/users/TeddyAndrieux/followers","following_url":"https://api.github.com/users/TeddyAndrieux/following{/other_user}","gists_url":"https://api.github.com/users/TeddyAndrieux/gists{/gist_id}","starred_url":"https://api.github.com/users/TeddyAndrieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeddyAndrieux/subscriptions","organizations_url":"https://api.github.com/users/TeddyAndrieux/orgs","repos_url":"https://api.github.com/users/TeddyAndrieux/repos","events_url":"https://api.github.com/users/TeddyAndrieux/events{/privacy}","received_events_url":"https://api.github.com/users/TeddyAndrieux/received_events","type":"User","site_admin":false},"body":"Nice, I will do that thanks","created_at":"2019-06-18T13:34:05Z","updated_at":"2019-06-18T13:34:06Z","html_url":"https://github.com/scality/metalk8s/pull/1251#discussion_r294823952","pull_request_url":"https://api.github.com/repos/scality/metalk8s/pulls/1251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scality/metalk8s/pulls/comments/294823952"},"html":{"href":"https://github.com/scality/metalk8s/pull/1251#discussion_r294823952"},"pull_request":{"href":"https://api.github.com/repos/scality/metalk8s/pulls/1251"}},"in_reply_to_id":294802898},"pull_request":{"url":"https://api.github.com/repos/scality/metalk8s/pulls/1251","id":289248678,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MjQ4Njc4","html_url":"https://github.com/scality/metalk8s/pull/1251","diff_url":"https://github.com/scality/metalk8s/pull/1251.diff","patch_url":"https://github.com/scality/metalk8s/pull/1251.patch","issue_url":"https://api.github.com/repos/scality/metalk8s/issues/1251","number":1251,"state":"open","locked":false,"title":"Use version instead of short version","user":{"login":"TeddyAndrieux","id":41334261,"node_id":"MDQ6VXNlcjQxMzM0MjYx","avatar_url":"https://avatars3.githubusercontent.com/u/41334261?v=4","gravatar_id":"","url":"https://api.github.com/users/TeddyAndrieux","html_url":"https://github.com/TeddyAndrieux","followers_url":"https://api.github.com/users/TeddyAndrieux/followers","following_url":"https://api.github.com/users/TeddyAndrieux/following{/other_user}","gists_url":"https://api.github.com/users/TeddyAndrieux/gists{/gist_id}","starred_url":"https://api.github.com/users/TeddyAndrieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeddyAndrieux/subscriptions","organizations_url":"https://api.github.com/users/TeddyAndrieux/orgs","repos_url":"https://api.github.com/users/TeddyAndrieux/repos","events_url":"https://api.github.com/users/TeddyAndrieux/events{/privacy}","received_events_url":"https://api.github.com/users/TeddyAndrieux/received_events","type":"User","site_admin":false},"body":"**Component**:\r\n\r\n'salt', 'kubernetes', 'build'\r\n<!-- E.g. 'salt', 'containers', 'kubernetes', 'build', 'tests'... -->\r\n\r\n**Context**: \r\n\r\nHas we will likely upgrade from minor version we need to use `VERSION` instead of `SHORT_VERSION` everywhere\r\n\r\n**Summary**:\r\n\r\nReplace `SHORT_VERSION` by `VERSION` everywhere\r\n\r\n**Acceptance criteria**: \r\n\r\nHave a working deployment using `metalk8s-<version>` as saltenv\r\n\r\n---\r\n\r\nFixes: #1241 \r\n","created_at":"2019-06-18T12:03:56Z","updated_at":"2019-06-18T13:34:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9af703c2faa035d56f62c12e2d7488723d9b1caf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/metalk8s/pulls/1251/commits","review_comments_url":"https://api.github.com/repos/scality/metalk8s/pulls/1251/comments","review_comment_url":"https://api.github.com/repos/scality/metalk8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/metalk8s/issues/1251/comments","statuses_url":"https://api.github.com/repos/scality/metalk8s/statuses/a7bfc451c12325ae4e4b172b103f73b9b0c08e14","head":{"label":"scality:improvement/1241-use-version-instead-of-short-version","ref":"improvement/1241-use-version-instead-of-short-version","sha":"a7bfc451c12325ae4e4b172b103f73b9b0c08e14","user":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":124905930,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5MDU5MzA=","name":"metalk8s","full_name":"scality/metalk8s","private":false,"owner":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scality/metalk8s","description":"An opinionated Kubernetes distribution with a focus on long-term on-prem deployments","fork":false,"url":"https://api.github.com/repos/scality/metalk8s","forks_url":"https://api.github.com/repos/scality/metalk8s/forks","keys_url":"https://api.github.com/repos/scality/metalk8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/metalk8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/metalk8s/teams","hooks_url":"https://api.github.com/repos/scality/metalk8s/hooks","issue_events_url":"https://api.github.com/repos/scality/metalk8s/issues/events{/number}","events_url":"https://api.github.com/repos/scality/metalk8s/events","assignees_url":"https://api.github.com/repos/scality/metalk8s/assignees{/user}","branches_url":"https://api.github.com/repos/scality/metalk8s/branches{/branch}","tags_url":"https://api.github.com/repos/scality/metalk8s/tags","blobs_url":"https://api.github.com/repos/scality/metalk8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/metalk8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/metalk8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/metalk8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/metalk8s/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/metalk8s/languages","stargazers_url":"https://api.github.com/repos/scality/metalk8s/stargazers","contributors_url":"https://api.github.com/repos/scality/metalk8s/contributors","subscribers_url":"https://api.github.com/repos/scality/metalk8s/subscribers","subscription_url":"https://api.github.com/repos/scality/metalk8s/subscription","commits_url":"https://api.github.com/repos/scality/metalk8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/metalk8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/metalk8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/metalk8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/metalk8s/contents/{+path}","compare_url":"https://api.github.com/repos/scality/metalk8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/metalk8s/merges","archive_url":"https://api.github.com/repos/scality/metalk8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/metalk8s/downloads","issues_url":"https://api.github.com/repos/scality/metalk8s/issues{/number}","pulls_url":"https://api.github.com/repos/scality/metalk8s/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/metalk8s/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/metalk8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/metalk8s/labels{/name}","releases_url":"https://api.github.com/repos/scality/metalk8s/releases{/id}","deployments_url":"https://api.github.com/repos/scality/metalk8s/deployments","created_at":"2018-03-12T14:57:42Z","updated_at":"2019-06-18T13:22:52Z","pushed_at":"2019-06-18T13:31:13Z","git_url":"git://github.com/scality/metalk8s.git","ssh_url":"git@github.com:scality/metalk8s.git","clone_url":"https://github.com/scality/metalk8s.git","svn_url":"https://github.com/scality/metalk8s","homepage":null,"size":27966,"stargazers_count":110,"watchers_count":110,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":263,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":263,"watchers":110,"default_branch":"development/2.0"}},"base":{"label":"scality:development/2.0","ref":"development/2.0","sha":"846ed20d4361954f5dece8b8dfa8368153299a20","user":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":124905930,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5MDU5MzA=","name":"metalk8s","full_name":"scality/metalk8s","private":false,"owner":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scality/metalk8s","description":"An opinionated Kubernetes distribution with a focus on long-term on-prem deployments","fork":false,"url":"https://api.github.com/repos/scality/metalk8s","forks_url":"https://api.github.com/repos/scality/metalk8s/forks","keys_url":"https://api.github.com/repos/scality/metalk8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/metalk8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/metalk8s/teams","hooks_url":"https://api.github.com/repos/scality/metalk8s/hooks","issue_events_url":"https://api.github.com/repos/scality/metalk8s/issues/events{/number}","events_url":"https://api.github.com/repos/scality/metalk8s/events","assignees_url":"https://api.github.com/repos/scality/metalk8s/assignees{/user}","branches_url":"https://api.github.com/repos/scality/metalk8s/branches{/branch}","tags_url":"https://api.github.com/repos/scality/metalk8s/tags","blobs_url":"https://api.github.com/repos/scality/metalk8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/metalk8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/metalk8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/metalk8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/metalk8s/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/metalk8s/languages","stargazers_url":"https://api.github.com/repos/scality/metalk8s/stargazers","contributors_url":"https://api.github.com/repos/scality/metalk8s/contributors","subscribers_url":"https://api.github.com/repos/scality/metalk8s/subscribers","subscription_url":"https://api.github.com/repos/scality/metalk8s/subscription","commits_url":"https://api.github.com/repos/scality/metalk8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/metalk8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/metalk8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/metalk8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/metalk8s/contents/{+path}","compare_url":"https://api.github.com/repos/scality/metalk8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/metalk8s/merges","archive_url":"https://api.github.com/repos/scality/metalk8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/metalk8s/downloads","issues_url":"https://api.github.com/repos/scality/metalk8s/issues{/number}","pulls_url":"https://api.github.com/repos/scality/metalk8s/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/metalk8s/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/metalk8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/metalk8s/labels{/name}","releases_url":"https://api.github.com/repos/scality/metalk8s/releases{/id}","deployments_url":"https://api.github.com/repos/scality/metalk8s/deployments","created_at":"2018-03-12T14:57:42Z","updated_at":"2019-06-18T13:22:52Z","pushed_at":"2019-06-18T13:31:13Z","git_url":"git://github.com/scality/metalk8s.git","ssh_url":"git@github.com:scality/metalk8s.git","clone_url":"https://github.com/scality/metalk8s.git","svn_url":"https://github.com/scality/metalk8s","homepage":null,"size":27966,"stargazers_count":110,"watchers_count":110,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":263,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":263,"watchers":110,"default_branch":"development/2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/metalk8s/pulls/1251"},"html":{"href":"https://github.com/scality/metalk8s/pull/1251"},"issue":{"href":"https://api.github.com/repos/scality/metalk8s/issues/1251"},"comments":{"href":"https://api.github.com/repos/scality/metalk8s/issues/1251/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/metalk8s/pulls/1251/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/metalk8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/metalk8s/pulls/1251/commits"},"statuses":{"href":"https://api.github.com/repos/scality/metalk8s/statuses/a7bfc451c12325ae4e4b172b103f73b9b0c08e14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TeddyAndrieux"}}