{"action":"created","issue":{"url":"https://api.github.com/repos/unmock/unmock-js/issues/57","repository_url":"https://api.github.com/repos/unmock/unmock-js","labels_url":"https://api.github.com/repos/unmock/unmock-js/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/unmock/unmock-js/issues/57/comments","events_url":"https://api.github.com/repos/unmock/unmock-js/issues/57/events","html_url":"https://github.com/unmock/unmock-js/pull/57","id":460941276,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxOTY1MDM4","number":57,"title":"Add Matcher","user":{"login":"ksaaskil","id":11660974,"node_id":"MDQ6VXNlcjExNjYwOTc0","avatar_url":"https://avatars1.githubusercontent.com/u/11660974?v=4","gravatar_id":"","url":"https://api.github.com/users/ksaaskil","html_url":"https://github.com/ksaaskil","followers_url":"https://api.github.com/users/ksaaskil/followers","following_url":"https://api.github.com/users/ksaaskil/following{/other_user}","gists_url":"https://api.github.com/users/ksaaskil/gists{/gist_id}","starred_url":"https://api.github.com/users/ksaaskil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksaaskil/subscriptions","organizations_url":"https://api.github.com/users/ksaaskil/orgs","repos_url":"https://api.github.com/users/ksaaskil/repos","events_url":"https://api.github.com/users/ksaaskil/events{/privacy}","received_events_url":"https://api.github.com/users/ksaaskil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-06-26T12:28:01Z","updated_at":"2019-06-26T12:34:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/unmock/unmock-js/pulls/57","html_url":"https://github.com/unmock/unmock-js/pull/57","diff_url":"https://github.com/unmock/unmock-js/pull/57.diff","patch_url":"https://github.com/unmock/unmock-js/pull/57.patch"},"body":"- Add `Matcher` class taking in the OAS schema\r\n- Create `Matcher` when `Service` is created. It feels like it's easier to be detecting the matches \"inside\" the service instead of from the outside, but still isolating that logic to a separate class to avoid making `Service` too big\r\n- Contains lots of overlap with the matching stuff already in `Service`, but I wouldn't perhaps worry about duplicate code that much yet.\r\n- [ ]  ServiceStore wrappers\r\n- [x]  Changes to `IService`"},"comment":{"url":"https://api.github.com/repos/unmock/unmock-js/issues/comments/505855428","html_url":"https://github.com/unmock/unmock-js/pull/57#issuecomment-505855428","issue_url":"https://api.github.com/repos/unmock/unmock-js/issues/57","id":505855428,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNTg1NTQyOA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2019-06-26T12:34:42Z","updated_at":"2019-06-26T12:34:42Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=h1) Report\n> Merging [#57](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=desc) into [dev](https://codecov.io/gh/unmock/unmock-js/commit/3a8ee2cb94b9c40870fa0b2f3cc36069bcc0df04?src=pr&el=desc) will **decrease** coverage by `0.68%`.\n> The diff coverage is `87.5%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/unmock/unmock-js/pull/57/graphs/tree.svg?width=650&token=obi4YS8TWw&height=150&src=pr)](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             dev      #57      +/-   ##\n=========================================\n- Coverage   93.3%   92.61%   -0.69%     \n=========================================\n  Files         20       20              \n  Lines        478      542      +64     \n  Branches     122      135      +13     \n=========================================\n+ Hits         446      502      +56     \n- Misses        32       40       +8\n```\n\n\n| [Impacted Files](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [packages/unmock-core/src/service/interfaces.ts](https://codecov.io/gh/unmock/unmock-js/pull/57/diff?src=pr&el=tree#diff-cGFja2FnZXMvdW5tb2NrLWNvcmUvc3JjL3NlcnZpY2UvaW50ZXJmYWNlcy50cw==) | `100% <ø> (ø)` | :arrow_up: |\n| [packages/unmock-core/src/service/service.ts](https://codecov.io/gh/unmock/unmock-js/pull/57/diff?src=pr&el=tree#diff-cGFja2FnZXMvdW5tb2NrLWNvcmUvc3JjL3NlcnZpY2Uvc2VydmljZS50cw==) | `95.31% <60%> (-3%)` | :arrow_down: |\n| [packages/unmock-core/src/matcher.ts](https://codecov.io/gh/unmock/unmock-js/pull/57/diff?src=pr&el=tree#diff-cGFja2FnZXMvdW5tb2NrLWNvcmUvc3JjL21hdGNoZXIudHM=) | `92.68% <89.83%> (-7.32%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=footer). Last update [3a8ee2c...46cb333](https://codecov.io/gh/unmock/unmock-js/pull/57?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}