{"action":"created","comment":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/comments/344723650","pull_request_review_id":314913862,"id":344723650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDcyMzY1MA==","diff_hunk":"@@ -31,18 +31,29 @@ function get_arch_sdl2() {\n     echo \"$(dpkg --print-architecture)\"\n }\n \n-function depends_sdl2() {\n+function _list_depends_sdl2() {\n     # Dependencies from the debian package control + additional dependencies for the pi (some are excluded like dpkg-dev as they are\n     # already covered by the build-essential package retropie relies on.\n-    local depends=(devscripts debhelper dh-autoreconf libasound2-dev libudev-dev libibus-1.0-dev libdbus-1-dev fcitx-libs-dev)\n+    local depends=(libasound2-dev libudev-dev libibus-1.0-dev libdbus-1-dev fcitx-libs-dev libsndio-dev)\n     # these were removed by a PR for vero4k support (cannot test). Needed though at least for for RPI and X11\n-    ! isPlatform \"vero4k\" && depends+=(libx11-dev libxcursor-dev libxext-dev libxi-dev libxinerama-dev libxrandr-dev libxss-dev libxt-dev libxxf86vm-dev libgl1-mesa-dev)\n-    isPlatform \"rpi\" && depends+=(libegl1-mesa-dev libgles2-mesa-dev libglu1-mesa-dev libraspberrypi-dev)\n-    isPlatform \"mali\" && depends+=(mali-fbdev)\n+    ! isPlatform \"vero4k\" && depends+=(libx11-dev libxcursor-dev libxext-dev libxi-dev libxinerama-dev libxkbcommon-dev libxrandr-dev libxss-dev libxt-dev libxv-dev libxxf86vm-dev libgl1-mesa-dev)\n+    isPlatform \"gles\" || isPlatform \"gl\" && depends+=(libegl1-mesa-dev libgles2-mesa-dev)\n+    isPlatform \"gl\" || isPlatform \"rpi\" && depends+=(libgl1-mesa-dev libglu1-mesa-dev)\n     isPlatform \"kms\" || isPlatform \"rpi\" && depends+=(libdrm-dev libgbm-dev)\n-    isPlatform \"x11\" && depends+=(libpulse-dev libegl1-mesa-dev libgles2-mesa-dev libglu1-mesa-dev)\n+    isPlatform \"x11\" && depends+=(libpulse-dev libwayland-dev)\n+\n+    echo \"${depends[@]}\"\n+}\n+\n+function depends_sdl2() {\n+    # install additional packages that are needed, but may be unsuitable as debian package dependencies due to distribution oddities\n+    local depends=(devscripts debhelper dh-autoreconf)\n+\n+    isPlatform \"mali\" && depends+=(mali-fbdev)\n+    isPlatform \"rpi\" && depends+=(libraspberrypi-dev)\n     isPlatform \"vero4k\" && depends+=(vero3-userland-dev-osmc)\n-    getDepends \"${depends[@]}\"\n+\n+    getDepends \"$(_list_depends_sdl2) ${depends[@]}\"","path":"scriptmodules/supplementary/sdl2.sh","position":null,"original_position":33,"commit_id":"9538f42db64039d9dd272a60ef6269f41869f34b","original_commit_id":"9622c9a49a28a53bd9d769e27abea780873e42de","user":{"login":"psyke83","id":749000,"node_id":"MDQ6VXNlcjc0OTAwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/749000?v=4","gravatar_id":"","url":"https://api.github.com/users/psyke83","html_url":"https://github.com/psyke83","followers_url":"https://api.github.com/users/psyke83/followers","following_url":"https://api.github.com/users/psyke83/following{/other_user}","gists_url":"https://api.github.com/users/psyke83/gists{/gist_id}","starred_url":"https://api.github.com/users/psyke83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psyke83/subscriptions","organizations_url":"https://api.github.com/users/psyke83/orgs","repos_url":"https://api.github.com/users/psyke83/repos","events_url":"https://api.github.com/users/psyke83/events{/privacy}","received_events_url":"https://api.github.com/users/psyke83/received_events","type":"User","site_admin":false},"body":"Yes (to the latter). I've updated the PR to ensure that `$(_list_depends_sdl2)` is not quoted, thanks.","created_at":"2019-11-11T14:02:04Z","updated_at":"2019-11-11T14:02:04Z","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2898#discussion_r344723650","pull_request_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/comments/344723650"},"html":{"href":"https://github.com/RetroPie/RetroPie-Setup/pull/2898#discussion_r344723650"},"pull_request":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898"}},"in_reply_to_id":344714583},"pull_request":{"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898","id":339410580,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5NDEwNTgw","html_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2898","diff_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2898.diff","patch_url":"https://github.com/RetroPie/RetroPie-Setup/pull/2898.patch","issue_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2898","number":2898,"state":"open","locked":false,"title":"sdl2: add dependencies to debian packages","user":{"login":"psyke83","id":749000,"node_id":"MDQ6VXNlcjc0OTAwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/749000?v=4","gravatar_id":"","url":"https://api.github.com/users/psyke83","html_url":"https://github.com/psyke83","followers_url":"https://api.github.com/users/psyke83/followers","following_url":"https://api.github.com/users/psyke83/following{/other_user}","gists_url":"https://api.github.com/users/psyke83/gists{/gist_id}","starred_url":"https://api.github.com/users/psyke83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psyke83/subscriptions","organizations_url":"https://api.github.com/users/psyke83/orgs","repos_url":"https://api.github.com/users/psyke83/repos","events_url":"https://api.github.com/users/psyke83/events{/privacy}","received_events_url":"https://api.github.com/users/psyke83/received_events","type":"User","site_admin":false},"body":"This should ensure that an installation of SDL2 from binary on a fresh\r\ninstallation should not fail due to missing dependencies not being\r\ninstalled by the debian packages themselves.\r\n\r\nCertain board-specific packages that may cause distribution dependency\r\nresolution issues are deliberately omitted, but they should already be\r\ninstalled (if not, we can do so during script first-time run or basic\r\ninstall).\r\n\r\nSome dependencies have also been reordered to be more consistent with our\r\nboard flags; x11 depends are still a mess, but reordering them may\r\nbreak vero4k.","created_at":"2019-11-11T12:28:33Z","updated_at":"2019-11-11T14:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c862662b88432fbc710ff58a081e916f12500b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898/commits","review_comments_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898/comments","review_comment_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2898/comments","statuses_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/statuses/9538f42db64039d9dd272a60ef6269f41869f34b","head":{"label":"psyke83:sdl2_debdepends","ref":"sdl2_debdepends","sha":"9538f42db64039d9dd272a60ef6269f41869f34b","user":{"login":"psyke83","id":749000,"node_id":"MDQ6VXNlcjc0OTAwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/749000?v=4","gravatar_id":"","url":"https://api.github.com/users/psyke83","html_url":"https://github.com/psyke83","followers_url":"https://api.github.com/users/psyke83/followers","following_url":"https://api.github.com/users/psyke83/following{/other_user}","gists_url":"https://api.github.com/users/psyke83/gists{/gist_id}","starred_url":"https://api.github.com/users/psyke83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psyke83/subscriptions","organizations_url":"https://api.github.com/users/psyke83/orgs","repos_url":"https://api.github.com/users/psyke83/repos","events_url":"https://api.github.com/users/psyke83/events{/privacy}","received_events_url":"https://api.github.com/users/psyke83/received_events","type":"User","site_admin":false},"repo":{"id":92834867,"node_id":"MDEwOlJlcG9zaXRvcnk5MjgzNDg2Nw==","name":"RetroPie-Setup","full_name":"psyke83/RetroPie-Setup","private":false,"owner":{"login":"psyke83","id":749000,"node_id":"MDQ6VXNlcjc0OTAwMA==","avatar_url":"https://avatars1.githubusercontent.com/u/749000?v=4","gravatar_id":"","url":"https://api.github.com/users/psyke83","html_url":"https://github.com/psyke83","followers_url":"https://api.github.com/users/psyke83/followers","following_url":"https://api.github.com/users/psyke83/following{/other_user}","gists_url":"https://api.github.com/users/psyke83/gists{/gist_id}","starred_url":"https://api.github.com/users/psyke83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psyke83/subscriptions","organizations_url":"https://api.github.com/users/psyke83/orgs","repos_url":"https://api.github.com/users/psyke83/repos","events_url":"https://api.github.com/users/psyke83/events{/privacy}","received_events_url":"https://api.github.com/users/psyke83/received_events","type":"User","site_admin":false},"html_url":"https://github.com/psyke83/RetroPie-Setup","description":"Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores","fork":true,"url":"https://api.github.com/repos/psyke83/RetroPie-Setup","forks_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/forks","keys_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/teams","hooks_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/hooks","issue_events_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/issues/events{/number}","events_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/events","assignees_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/assignees{/user}","branches_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/branches{/branch}","tags_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/tags","blobs_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/statuses/{sha}","languages_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/languages","stargazers_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/stargazers","contributors_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/contributors","subscribers_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/subscribers","subscription_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/subscription","commits_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/contents/{+path}","compare_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/merges","archive_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/downloads","issues_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/issues{/number}","pulls_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/pulls{/number}","milestones_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/milestones{/number}","notifications_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/labels{/name}","releases_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/releases{/id}","deployments_url":"https://api.github.com/repos/psyke83/RetroPie-Setup/deployments","created_at":"2017-05-30T13:19:17Z","updated_at":"2018-12-21T03:25:12Z","pushed_at":"2019-11-11T14:00:44Z","git_url":"git://github.com/psyke83/RetroPie-Setup.git","ssh_url":"git@github.com:psyke83/RetroPie-Setup.git","clone_url":"https://github.com/psyke83/RetroPie-Setup.git","svn_url":"https://github.com/psyke83/RetroPie-Setup","homepage":"","size":21637,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RetroPie:fkms_rpi4","ref":"fkms_rpi4","sha":"5bc0f672f201f4f0c73a8c3fff58b2519b5a6f6a","user":{"login":"RetroPie","id":11378204,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzc4MjA0","avatar_url":"https://avatars1.githubusercontent.com/u/11378204?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroPie","html_url":"https://github.com/RetroPie","followers_url":"https://api.github.com/users/RetroPie/followers","following_url":"https://api.github.com/users/RetroPie/following{/other_user}","gists_url":"https://api.github.com/users/RetroPie/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroPie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroPie/subscriptions","organizations_url":"https://api.github.com/users/RetroPie/orgs","repos_url":"https://api.github.com/users/RetroPie/repos","events_url":"https://api.github.com/users/RetroPie/events{/privacy}","received_events_url":"https://api.github.com/users/RetroPie/received_events","type":"Organization","site_admin":false},"repo":{"id":5143809,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQzODA5","name":"RetroPie-Setup","full_name":"RetroPie/RetroPie-Setup","private":false,"owner":{"login":"RetroPie","id":11378204,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzc4MjA0","avatar_url":"https://avatars1.githubusercontent.com/u/11378204?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroPie","html_url":"https://github.com/RetroPie","followers_url":"https://api.github.com/users/RetroPie/followers","following_url":"https://api.github.com/users/RetroPie/following{/other_user}","gists_url":"https://api.github.com/users/RetroPie/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroPie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroPie/subscriptions","organizations_url":"https://api.github.com/users/RetroPie/orgs","repos_url":"https://api.github.com/users/RetroPie/repos","events_url":"https://api.github.com/users/RetroPie/events{/privacy}","received_events_url":"https://api.github.com/users/RetroPie/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RetroPie/RetroPie-Setup","description":"Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores","fork":false,"url":"https://api.github.com/repos/RetroPie/RetroPie-Setup","forks_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/forks","keys_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/teams","hooks_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/hooks","issue_events_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/events{/number}","events_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/events","assignees_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/assignees{/user}","branches_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/branches{/branch}","tags_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/tags","blobs_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/git/refs{/sha}","trees_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/statuses/{sha}","languages_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/languages","stargazers_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/stargazers","contributors_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/contributors","subscribers_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/subscribers","subscription_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/subscription","commits_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/commits{/sha}","git_commits_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/git/commits{/sha}","comments_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/comments{/number}","issue_comment_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/comments{/number}","contents_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/contents/{+path}","compare_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/merges","archive_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/downloads","issues_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues{/number}","pulls_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls{/number}","milestones_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/milestones{/number}","notifications_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/labels{/name}","releases_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/releases{/id}","deployments_url":"https://api.github.com/repos/RetroPie/RetroPie-Setup/deployments","created_at":"2012-07-22T18:49:24Z","updated_at":"2019-11-11T12:28:46Z","pushed_at":"2019-11-11T14:00:47Z","git_url":"git://github.com/RetroPie/RetroPie-Setup.git","ssh_url":"git@github.com:RetroPie/RetroPie-Setup.git","clone_url":"https://github.com/RetroPie/RetroPie-Setup.git","svn_url":"https://github.com/RetroPie/RetroPie-Setup","homepage":"","size":21630,"stargazers_count":7997,"watchers_count":7997,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1121,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1121,"open_issues":74,"watchers":7997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898"},"html":{"href":"https://github.com/RetroPie/RetroPie-Setup/pull/2898"},"issue":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2898"},"comments":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/issues/2898/comments"},"review_comments":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898/comments"},"review_comment":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/pulls/2898/commits"},"statuses":{"href":"https://api.github.com/repos/RetroPie/RetroPie-Setup/statuses/9538f42db64039d9dd272a60ef6269f41869f34b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"psyke83"}}