{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/25885","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25885/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25885/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25885/events","html_url":"https://github.com/cms-sw/cmssw/pull/25885","id":407723605,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMTMyNzQ1","number":25885,"title":"Add label for pixel digitizer in SiPixelQualityESProducer","user":{"login":"tsusa","id":6282215,"node_id":"MDQ6VXNlcjYyODIyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6282215?v=4","gravatar_id":"","url":"https://api.github.com/users/tsusa","html_url":"https://github.com/tsusa","followers_url":"https://api.github.com/users/tsusa/followers","following_url":"https://api.github.com/users/tsusa/following{/other_user}","gists_url":"https://api.github.com/users/tsusa/gists{/gist_id}","starred_url":"https://api.github.com/users/tsusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsusa/subscriptions","organizations_url":"https://api.github.com/users/tsusa/orgs","repos_url":"https://api.github.com/users/tsusa/repos","events_url":"https://api.github.com/users/tsusa/events{/privacy}","received_events_url":"https://api.github.com/users/tsusa/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"node_id":"MDU6TGFiZWw1Mjg4MTQ2Mw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881747,"node_id":"MDU6TGFiZWw1Mjg4MTc0Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/79","html_url":"https://github.com/cms-sw/cmssw/milestone/79","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/79/labels","id":3914873,"node_id":"MDk6TWlsZXN0b25lMzkxNDg3Mw==","number":79,"title":"CMSSW_10_5_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":286,"state":"open","created_at":"2018-12-20T07:56:25Z","updated_at":"2019-02-13T16:17:12Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2019-02-07T14:22:32Z","updated_at":"2019-02-13T16:24:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25885","html_url":"https://github.com/cms-sw/cmssw/pull/25885","diff_url":"https://github.com/cms-sw/cmssw/pull/25885.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25885.patch"},"body":"This PR introduces the label for the `SiPixelQualityRcd` in order to treat the damaged pixels behind broken DCDC converters the same way in data and in simulation. The PR was explained at the RECO meeting https://indico.cern.ch/event/787904/contributions/3288669/subcontributions/273135/attachments/1785559/2906928/tanjaReco_25012019.pdf.\r\nThe feature is switched off by default. In order to switch it on:\r\n - the new GT  containing `SiPixelQuality` with the label \"forDigitizer\" is needed \r\n - the lines L108-109 in SimGeneral/MixingModule/python/SiPixelSimParameters_cfi.py should be uncommented \r\nThe Era mechanism is used to activate the feature only for >= 2018\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/463265110","html_url":"https://github.com/cms-sw/cmssw/pull/25885#issuecomment-463265110","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25885","id":463265110,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MzI2NTExMA==","user":{"login":"tocheng","id":4965339,"node_id":"MDQ6VXNlcjQ5NjUzMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4965339?v=4","gravatar_id":"","url":"https://api.github.com/users/tocheng","html_url":"https://github.com/tocheng","followers_url":"https://api.github.com/users/tocheng/followers","following_url":"https://api.github.com/users/tocheng/following{/other_user}","gists_url":"https://api.github.com/users/tocheng/gists{/gist_id}","starred_url":"https://api.github.com/users/tocheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tocheng/subscriptions","organizations_url":"https://api.github.com/users/tocheng/orgs","repos_url":"https://api.github.com/users/tocheng/repos","events_url":"https://api.github.com/users/tocheng/events{/privacy}","received_events_url":"https://api.github.com/users/tocheng/received_events","type":"User","site_admin":false},"created_at":"2019-02-13T16:24:13Z","updated_at":"2019-02-13T16:24:13Z","author_association":"CONTRIBUTOR","body":"> > DQMHistoTests: Total failures: 1523\r\n> \r\n> given the GT differences reported in [#25885 (comment)](https://github.com/cms-sw/cmssw/pull/25885#issuecomment-462333444), it's not surprising one sees differences in the [comparisons](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_5_X_2019-02-11-1100+25885/30386/validateJR.html).\r\n> Namely one sees changes:\r\n> \r\n>     * in the 2019 workflow [link](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_5_X_2019-02-11-1100+25885/30386/validateJR/all_OldVSNew_TTbar13TeV2019wf11624p0/) due to the change in the Tk Alignment\r\n> \r\n>     * in several miniAOD workflows [1](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_5_X_2019-02-11-1100+25885/30386/validateJR/all_mini_OldVSNew_TTbar13TeV2018wf10824p0), [2](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_5_X_2019-02-11-1100+25885/30386/validateJR/all_mini_OldVSNew_TTbar13TeV2019wf11624p0), [3](https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_5_X_2019-02-11-1100+25885/30386/validateJR/all_mini_OldVSNew_TTbar13TeVPUppmx2018wf250202p181) I suppose due to the changes in JECs and JER.\r\n> \r\n> \r\n> @tocheng is this acceptable or do you wish to get a cleaner comparison by re-making the GTs without spurious differences?\r\n\r\nI will clean the spurious change in the GTs and make a new commit."}}
{"actor":{"display_login":"tocheng"}}