{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments/335712913","pull_request_review_id":302876268,"id":335712913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTcxMjkxMw==","diff_hunk":"@@ -369,13 +375,17 @@ class ClubhouseNotificationBanner extends MessageTray.NotificationBanner {\n     // Override this method because we don't want the button\n     // horizontally expanded:\n     addButton(button, callback) {\n-        if (button.label === '>') {\n+        if (Object.keys(CLUBHOUSE_ICONS).includes(button.label)) {","path":"js/ui/components/clubhouse.js","position":73,"original_position":18,"commit_id":"984a5964a211e4c77ddb041e0b0b715257da080f","original_commit_id":"eb6a8a41184d6e062d32b816fab37cc89e4e3b0f","user":{"login":"ptomato","id":459371,"node_id":"MDQ6VXNlcjQ1OTM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/459371?v=4","gravatar_id":"","url":"https://api.github.com/users/ptomato","html_url":"https://github.com/ptomato","followers_url":"https://api.github.com/users/ptomato/followers","following_url":"https://api.github.com/users/ptomato/following{/other_user}","gists_url":"https://api.github.com/users/ptomato/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomato/subscriptions","organizations_url":"https://api.github.com/users/ptomato/orgs","repos_url":"https://api.github.com/users/ptomato/repos","events_url":"https://api.github.com/users/ptomato/events{/privacy}","received_events_url":"https://api.github.com/users/ptomato/received_events","type":"User","site_admin":false},"body":"I can see the previous code already worked by checking if the button label was a particular string. Now that we have three possibilities for icon buttons, is it now time to find a more robust way of specificing it? I would try to avoid (undocumented?) magic values. In particular this seems sensitive to typos and accidental extra whitespace.","created_at":"2019-10-16T21:16:34Z","updated_at":"2019-10-16T21:23:02Z","html_url":"https://github.com/endlessm/gnome-shell/pull/533#discussion_r335712913","pull_request_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments/335712913"},"html":{"href":"https://github.com/endlessm/gnome-shell/pull/533#discussion_r335712913"},"pull_request":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533","id":323340272,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMzQwMjcy","html_url":"https://github.com/endlessm/gnome-shell/pull/533","diff_url":"https://github.com/endlessm/gnome-shell/pull/533.diff","patch_url":"https://github.com/endlessm/gnome-shell/pull/533.patch","issue_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/533","number":533,"state":"open","locked":false,"title":"T27749 hack new colors","user":{"login":"manuq","id":83944,"node_id":"MDQ6VXNlcjgzOTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/83944?v=4","gravatar_id":"","url":"https://api.github.com/users/manuq","html_url":"https://github.com/manuq","followers_url":"https://api.github.com/users/manuq/followers","following_url":"https://api.github.com/users/manuq/following{/other_user}","gists_url":"https://api.github.com/users/manuq/gists{/gist_id}","starred_url":"https://api.github.com/users/manuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuq/subscriptions","organizations_url":"https://api.github.com/users/manuq/orgs","repos_url":"https://api.github.com/users/manuq/repos","events_url":"https://api.github.com/users/manuq/events{/privacy}","received_events_url":"https://api.github.com/users/manuq/received_events","type":"User","site_admin":false},"body":"https://phabricator.endlessm.com/T27845","created_at":"2019-10-01T15:36:17Z","updated_at":"2019-10-16T21:23:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"066413ca1f732d39cc664e36be0fa4bd876ed94a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533/commits","review_comments_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533/comments","review_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/533/comments","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/984a5964a211e4c77ddb041e0b0b715257da080f","head":{"label":"endlessm:T27749-hack-new-colors-wip-2","ref":"T27749-hack-new-colors-wip-2","sha":"984a5964a211e4c77ddb041e0b0b715257da080f","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84589501,"node_id":"MDEwOlJlcG9zaXRvcnk4NDU4OTUwMQ==","name":"gnome-shell","full_name":"endlessm/gnome-shell","private":false,"owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endlessm/gnome-shell","description":"Fork of https://git.gnome.org/browse/gnome-shell","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-shell","forks_url":"https://api.github.com/repos/endlessm/gnome-shell/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-shell/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-shell/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-shell/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-shell/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-shell/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-shell/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-shell/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-shell/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-shell/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-shell/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-shell/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-shell/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-shell/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-shell/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-shell/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-shell/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-shell/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-shell/deployments","created_at":"2017-03-10T18:30:50Z","updated_at":"2019-10-16T20:54:42Z","pushed_at":"2019-10-16T20:55:07Z","git_url":"git://github.com/endlessm/gnome-shell.git","ssh_url":"git@github.com:endlessm/gnome-shell.git","clone_url":"https://github.com/endlessm/gnome-shell.git","svn_url":"https://github.com/endlessm/gnome-shell","homepage":null,"size":38643,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":5,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"da852d3f95e2ea80b26532372dc81aeaba926106","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84589501,"node_id":"MDEwOlJlcG9zaXRvcnk4NDU4OTUwMQ==","name":"gnome-shell","full_name":"endlessm/gnome-shell","private":false,"owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endlessm/gnome-shell","description":"Fork of https://git.gnome.org/browse/gnome-shell","fork":false,"url":"https://api.github.com/repos/endlessm/gnome-shell","forks_url":"https://api.github.com/repos/endlessm/gnome-shell/forks","keys_url":"https://api.github.com/repos/endlessm/gnome-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/gnome-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/gnome-shell/teams","hooks_url":"https://api.github.com/repos/endlessm/gnome-shell/hooks","issue_events_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/gnome-shell/events","assignees_url":"https://api.github.com/repos/endlessm/gnome-shell/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/gnome-shell/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/gnome-shell/tags","blobs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/gnome-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/gnome-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/gnome-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/gnome-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/gnome-shell/languages","stargazers_url":"https://api.github.com/repos/endlessm/gnome-shell/stargazers","contributors_url":"https://api.github.com/repos/endlessm/gnome-shell/contributors","subscribers_url":"https://api.github.com/repos/endlessm/gnome-shell/subscribers","subscription_url":"https://api.github.com/repos/endlessm/gnome-shell/subscription","commits_url":"https://api.github.com/repos/endlessm/gnome-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/gnome-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/gnome-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/gnome-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/gnome-shell/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/gnome-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/gnome-shell/merges","archive_url":"https://api.github.com/repos/endlessm/gnome-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/gnome-shell/downloads","issues_url":"https://api.github.com/repos/endlessm/gnome-shell/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/gnome-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/gnome-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/gnome-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/gnome-shell/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/gnome-shell/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/gnome-shell/deployments","created_at":"2017-03-10T18:30:50Z","updated_at":"2019-10-16T20:54:42Z","pushed_at":"2019-10-16T20:55:07Z","git_url":"git://github.com/endlessm/gnome-shell.git","ssh_url":"git@github.com:endlessm/gnome-shell.git","clone_url":"https://github.com/endlessm/gnome-shell.git","svn_url":"https://github.com/endlessm/gnome-shell","homepage":null,"size":38643,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":5,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533"},"html":{"href":"https://github.com/endlessm/gnome-shell/pull/533"},"issue":{"href":"https://api.github.com/repos/endlessm/gnome-shell/issues/533"},"comments":{"href":"https://api.github.com/repos/endlessm/gnome-shell/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/gnome-shell/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/gnome-shell/statuses/984a5964a211e4c77ddb041e0b0b715257da080f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ptomato"}}