{"action":"created","issue":{"url":"https://api.github.com/repos/rapidsai/cudf/issues/982","repository_url":"https://api.github.com/repos/rapidsai/cudf","labels_url":"https://api.github.com/repos/rapidsai/cudf/issues/982/labels{/name}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/982/comments","events_url":"https://api.github.com/repos/rapidsai/cudf/issues/982/events","html_url":"https://github.com/rapidsai/cudf/pull/982","id":411658617,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MDUyOTU1","number":982,"title":"[REVIEW] Group by without aggregations  ","user":{"login":"aocsa","id":3615859,"node_id":"MDQ6VXNlcjM2MTU4NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3615859?v=4","gravatar_id":"","url":"https://api.github.com/users/aocsa","html_url":"https://github.com/aocsa","followers_url":"https://api.github.com/users/aocsa/followers","following_url":"https://api.github.com/users/aocsa/following{/other_user}","gists_url":"https://api.github.com/users/aocsa/gists{/gist_id}","starred_url":"https://api.github.com/users/aocsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aocsa/subscriptions","organizations_url":"https://api.github.com/users/aocsa/orgs","repos_url":"https://api.github.com/users/aocsa/repos","events_url":"https://api.github.com/users/aocsa/events{/privacy}","received_events_url":"https://api.github.com/users/aocsa/received_events","type":"User","site_admin":false},"labels":[{"id":1162012597,"node_id":"MDU6TGFiZWwxMTYyMDEyNTk3","url":"https://api.github.com/repos/rapidsai/cudf/labels/4%20-%20Needs%20libcudf%20Reviewer","name":"4 - Needs libcudf Reviewer","color":"d3ff8c","default":false},{"id":1139740666,"node_id":"MDU6TGFiZWwxMTM5NzQwNjY2","url":"https://api.github.com/repos/rapidsai/cudf/labels/libcudf%20(C++/CUDA)","name":"libcudf (C++/CUDA)","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2019-02-18T21:53:35Z","updated_at":"2019-05-03T19:51:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/982","html_url":"https://github.com/rapidsai/cudf/pull/982","diff_url":"https://github.com/rapidsai/cudf/pull/982.diff","patch_url":"https://github.com/rapidsai/cudf/pull/982.patch"},"body":"This PR supersedes PR #571 and  #430 which was created by @williamBlazing . I created a new PR mostly due to local branch git issues for branch 0.6. I will take all the recommendations from that last PR into account. I added extended unit tests for SQL and Pandas Style including the tests for valids.\r\n\r\ncc. @eyalrozm, @jrhemstad \r\n\r\nAll the best.  \r\n<!--\r\n\r\nThank you for contributing to cuDF :)\r\n\r\nHere are some guidelines to help the review process go smoothly.\r\n\r\n1. Please write a description in this text box of the changes that are being\r\n   made.\r\n\r\n2. Please ensure that you have written units tests for the changes made/features\r\n   added.\r\n\r\n3. If you are closing an issue please use one of the automatic closing words as\r\n   noted here: https://help.github.com/articles/closing-issues-using-keywords/\r\n\r\n4. If your pull request is not ready for review but you want to make use of the\r\n   continuous integration testing facilities please label it with `[WIP]`.\r\n\r\n5. If your pull request is ready to be reviewed without requiring additional\r\n   work on top of it, then remove the `[WIP]` label (if present) and replace\r\n   it with `[REVIEW]`. If assistance is required to complete the functionality,\r\n   for example when the C/C++ code of a feature is complete but Python bindings\r\n   are still required, then add the label `[HELP-REQ]` so that others can triage\r\n   and assist. The additional changes then can be implemented on top of the\r\n   same PR. If the assistance is done by members of the rapidsAI team, then no\r\n   additional actions are required by the creator of the original PR for this,\r\n   otherwise the original author of the PR needs to give permission to the\r\n   person(s) assisting to commit to their personal fork of the project. If that\r\n   doesn't happen then a new PR based on the code of the original PR can be\r\n   opened by the person assisting, which then will be the PR that will be\r\n   merged.\r\n\r\n6. Once all work has been done and review has taken place please do not add\r\n   features or make changes out of the scope of those requested by the reviewer\r\n   (doing this just add delays as already reviewed code ends up having to be\r\n   re-reviewed/it is hard to tell what is new etc!). Further, please do not\r\n   rebase your branch on master/force push/rewrite history, doing any of these\r\n   causes the context of any comments made by reviewers to be lost. If\r\n   conflicts occur against master they should be resolved by merging master\r\n   into the branch used for making the pull request.\r\n\r\nMany thanks in advance for your cooperation!\r\n\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/rapidsai/cudf/issues/comments/489219464","html_url":"https://github.com/rapidsai/cudf/pull/982#issuecomment-489219464","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/982","id":489219464,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4OTIxOTQ2NA==","user":{"login":"jrhemstad","id":15221289,"node_id":"MDQ6VXNlcjE1MjIxMjg5","avatar_url":"https://avatars1.githubusercontent.com/u/15221289?v=4","gravatar_id":"","url":"https://api.github.com/users/jrhemstad","html_url":"https://github.com/jrhemstad","followers_url":"https://api.github.com/users/jrhemstad/followers","following_url":"https://api.github.com/users/jrhemstad/following{/other_user}","gists_url":"https://api.github.com/users/jrhemstad/gists{/gist_id}","starred_url":"https://api.github.com/users/jrhemstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrhemstad/subscriptions","organizations_url":"https://api.github.com/users/jrhemstad/orgs","repos_url":"https://api.github.com/users/jrhemstad/repos","events_url":"https://api.github.com/users/jrhemstad/events{/privacy}","received_events_url":"https://api.github.com/users/jrhemstad/received_events","type":"User","site_admin":false},"created_at":"2019-05-03T19:51:40Z","updated_at":"2019-05-03T19:51:40Z","author_association":"CONTRIBUTOR","body":"rerun tests"}}
{"actor":{"display_login":"jrhemstad"}}