{"action":"created","issue":{"url":"https://api.github.com/repos/erikhuda/thor/issues/651","repository_url":"https://api.github.com/repos/erikhuda/thor","labels_url":"https://api.github.com/repos/erikhuda/thor/issues/651/labels{/name}","comments_url":"https://api.github.com/repos/erikhuda/thor/issues/651/comments","events_url":"https://api.github.com/repos/erikhuda/thor/issues/651/events","html_url":"https://github.com/erikhuda/thor/pull/651","id":420499159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNzY1Njc1","number":651,"title":"Abort if the command for `run` fails and `exit_on_failure?` is true","user":{"login":"hibariya","id":43346,"node_id":"MDQ6VXNlcjQzMzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/43346?v=4","gravatar_id":"","url":"https://api.github.com/users/hibariya","html_url":"https://github.com/hibariya","followers_url":"https://api.github.com/users/hibariya/followers","following_url":"https://api.github.com/users/hibariya/following{/other_user}","gists_url":"https://api.github.com/users/hibariya/gists{/gist_id}","starred_url":"https://api.github.com/users/hibariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibariya/subscriptions","organizations_url":"https://api.github.com/users/hibariya/orgs","repos_url":"https://api.github.com/users/hibariya/repos","events_url":"https://api.github.com/users/hibariya/events{/privacy}","received_events_url":"https://api.github.com/users/hibariya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-13T13:27:44Z","updated_at":"2019-09-26T14:22:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/erikhuda/thor/pulls/651","html_url":"https://github.com/erikhuda/thor/pull/651","diff_url":"https://github.com/erikhuda/thor/pull/651.diff","patch_url":"https://github.com/erikhuda/thor/pull/651.patch"},"body":"Hi, there :rainbow:\r\n\r\nI'd like to change the error handling of `Thor::Actions#run` for the following reason. \r\n\r\nAccording to the description of `exit_on_failure?`, the process should exit with status 1 if any error happens. I think that it should be also applied to `run`.\r\n\r\nAlthough we can pass `abort_on_failure` option for `run`, passing it every time seems a little redundant when we call `run` multiple times. This is the other reason for this change.\r\n\r\nFor instance, when an error occres [here](https://github.com/rails/webpacker/blob/e95dd724ea3a385b9cc6935c3a07a34f1d1f9657/lib/install/elm.rb#L27), I want to notice not only by the output but also by the status code."},"comment":{"url":"https://api.github.com/repos/erikhuda/thor/issues/comments/535526552","html_url":"https://github.com/erikhuda/thor/pull/651#issuecomment-535526552","issue_url":"https://api.github.com/repos/erikhuda/thor/issues/651","id":535526552,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNTUyNjU1Mg==","user":{"login":"deivid-rodriguez","id":2887858,"node_id":"MDQ6VXNlcjI4ODc4NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/2887858?v=4","gravatar_id":"","url":"https://api.github.com/users/deivid-rodriguez","html_url":"https://github.com/deivid-rodriguez","followers_url":"https://api.github.com/users/deivid-rodriguez/followers","following_url":"https://api.github.com/users/deivid-rodriguez/following{/other_user}","gists_url":"https://api.github.com/users/deivid-rodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/deivid-rodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deivid-rodriguez/subscriptions","organizations_url":"https://api.github.com/users/deivid-rodriguez/orgs","repos_url":"https://api.github.com/users/deivid-rodriguez/repos","events_url":"https://api.github.com/users/deivid-rodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/deivid-rodriguez/received_events","type":"User","site_admin":false},"created_at":"2019-09-26T14:22:14Z","updated_at":"2019-09-26T14:22:14Z","author_association":"CONTRIBUTOR","body":"Any chance on getting a review here?"}}
{"actor":{"display_login":"deivid-rodriguez"}}