{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/issues/148","repository_url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/issues/148/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/issues/148/events","html_url":"https://github.com/Microsoft/vscode-extension-vscode/pull/148","id":419038339,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NjY4NjQ1","number":148,"title":"Remove dependencies for downloading / unzipping","user":{"login":"octref","id":4033249,"node_id":"MDQ6VXNlcjQwMzMyNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/4033249?v=4","gravatar_id":"","url":"https://api.github.com/users/octref","html_url":"https://github.com/octref","followers_url":"https://api.github.com/users/octref/followers","following_url":"https://api.github.com/users/octref/following{/other_user}","gists_url":"https://api.github.com/users/octref/gists{/gist_id}","starred_url":"https://api.github.com/users/octref/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octref/subscriptions","organizations_url":"https://api.github.com/users/octref/orgs","repos_url":"https://api.github.com/users/octref/repos","events_url":"https://api.github.com/users/octref/events{/privacy}","received_events_url":"https://api.github.com/users/octref/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-03-09T06:01:23Z","updated_at":"2019-03-10T15:50:18Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/pulls/148","html_url":"https://github.com/Microsoft/vscode-extension-vscode/pull/148","diff_url":"https://github.com/Microsoft/vscode-extension-vscode/pull/148.diff","patch_url":"https://github.com/Microsoft/vscode-extension-vscode/pull/148.patch"},"body":"WIP. I plan to allow `downloadAndUnzipVSCode` to take a version too.\r\n\r\n```ts\r\ntype Version = 'Insiders' | '1.32.0' | '1.31.1' | '1.31.0' ...\r\n```\r\n\r\nThe script would download them to:\r\n\r\n```\r\n.vscode-test/\r\n  /insiders\r\n  /stable-1.32.0\r\n  /stable-1.31.1\r\n  /stable-1.31.0\r\n  ...\r\n```\r\n\r\n@bpasero I'm wondering if we can also change the way we run test. Instead of saying users should run `node ./node_modules/bin/test`, maybe export a `runTest` function so it's easier to configure?\r\n\r\nUser's code could look like this:\r\n\r\n```ts\r\nimport { runTests } from 'vscode-test';\r\n\r\nasync function go() {\r\n  const vscodeExecutablePath = await downloadAndUnzipVSCode()\r\n\r\n  const extPath = path.resolve(__dirname, '../../')\r\n  const testPath = path.resolve(__dirname, '../test')\r\n  const testWorkspace = path.resolve(__dirname, '../fixture')\r\n\r\n  runTests(vscodeExecutablePath, extPath, testPath, testWorkspace)\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/issues/comments/471317854","html_url":"https://github.com/Microsoft/vscode-extension-vscode/pull/148#issuecomment-471317854","issue_url":"https://api.github.com/repos/Microsoft/vscode-extension-vscode/issues/148","id":471317854,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTMxNzg1NA==","user":{"login":"bpasero","id":900690,"node_id":"MDQ6VXNlcjkwMDY5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"created_at":"2019-03-10T15:50:18Z","updated_at":"2019-03-10T15:50:18Z","author_association":"MEMBER","body":"@octref btw I am not 100% sure removing the `request` library is wise. Are we certain we can handle things like proxy support properly without it?"}}
{"actor":{"display_login":"bpasero"}}