{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/38601","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/38601/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/38601/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/38601/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38601","id":498450533,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxMzc5NTM2","number":38601,"title":"[@types/eslint]: add missing extends to override config definition","user":{"login":"Hotell","id":1223799,"node_id":"MDQ6VXNlcjEyMjM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1223799?v=4","gravatar_id":"","url":"https://api.github.com/users/Hotell","html_url":"https://github.com/Hotell","followers_url":"https://api.github.com/users/Hotell/followers","following_url":"https://api.github.com/users/Hotell/following{/other_user}","gists_url":"https://api.github.com/users/Hotell/gists{/gist_id}","starred_url":"https://api.github.com/users/Hotell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hotell/subscriptions","organizations_url":"https://api.github.com/users/Hotell/orgs","repos_url":"https://api.github.com/users/Hotell/repos","events_url":"https://api.github.com/users/Hotell/events{/privacy}","received_events_url":"https://api.github.com/users/Hotell/received_events","type":"User","site_admin":false},"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-09-25T18:27:02Z","updated_at":"2019-09-25T20:01:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/38601","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38601","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38601.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38601.patch"},"body":"- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/eslint/eslint/commit/54e6edaa2f881aab530fa14e63d92e5e0e2ca55c\r\n- [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`. If for reason the any rule need to be disabled, disable it for that line using `// tslint:disable-next-line [ruleName]` and not for whole package so that the need for disabling can be reviewed.\r\n\r\ncc @pmdartus @j-f1 @saadq @JasonHK"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/535188243","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38601#issuecomment-535188243","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/38601","id":535188243,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNTE4ODI0Mw==","user":{"login":"typescript-bot","id":23042052,"node_id":"MDQ6VXNlcjIzMDQyMDUy","avatar_url":"https://avatars0.githubusercontent.com/u/23042052?v=4","gravatar_id":"","url":"https://api.github.com/users/typescript-bot","html_url":"https://github.com/typescript-bot","followers_url":"https://api.github.com/users/typescript-bot/followers","following_url":"https://api.github.com/users/typescript-bot/following{/other_user}","gists_url":"https://api.github.com/users/typescript-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/typescript-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typescript-bot/subscriptions","organizations_url":"https://api.github.com/users/typescript-bot/orgs","repos_url":"https://api.github.com/users/typescript-bot/repos","events_url":"https://api.github.com/users/typescript-bot/events{/privacy}","received_events_url":"https://api.github.com/users/typescript-bot/received_events","type":"User","site_admin":false},"created_at":"2019-09-25T20:01:29Z","updated_at":"2019-09-25T20:01:29Z","author_association":"CONTRIBUTOR","body":"<!-- @dt-perf -->\n\nUpdated numbers for you here from 732d6da:\n\n\nBefore we get into it, I need to mention that **the language service crashed** while taking these measurements. This isn’t your fault—on the contrary, you helped us find a probably TypeScript bug! But, be aware that these results may or may not be quite what they should be, depending on how many locations in your tests caused a crash. Paging @andrewbranch to investigate.\n\n<details>\n<summary><strong>Comparison details</strong> 📊</summary>\n\n|                                              | master                                                                                                                     | #38601                                                                                                                   | diff  |\n| -------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------ | ----- |\n| **Batch compilation**                        |                                                                                                                            |                                                                                                                          |       |\n| Memory usage (MiB)                           | 38.8                                                                                                                       | 38.8                                                                                                                     | +0.1% |\n| Type count                                   | 4211                                                                                                                       | 4211                                                                                                                     | 0.0%  |\n| Assignability cache size                     | 1628                                                                                                                       | 1628                                                                                                                     | 0.0%  |\n| Subtype cache size                           | 399                                                                                                                        | 399                                                                                                                      | 0.0%  |\n| Identity cache size                          | 1                                                                                                                          | 1                                                                                                                        | 0.0%  |\n|                                              |                                                                                                                            |                                                                                                                          |       |\n| **Language service**                         |                                                                                                                            |                                                                                                                          |       |\n| Samples taken                                | 1449                                                                                                                       | 1450                                                                                                                     | +0.1% |\n| Identifiers in tests                         | 1450                                                                                                                       | 1451                                                                                                                     | +0.1% |\n| **`getCompletionsAtPosition`**               |                                                                                                                            |                                                                                                                          |       |\n| &nbsp;&nbsp;&nbsp;&nbsp;Mean duration (ms)   | 117.1                                                                                                                      | 120.3                                                                                                                    | +2.7% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Median duration (ms) | 120.6                                                                                                                      | 123.0                                                                                                                    | +1.9% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Mean CV              | 20.7%                                                                                                                      | 20.9%                                                                                                                    | +1.0% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Worst duration (ms)  | 201.1                                                                                                                      | 203.6                                                                                                                    | +1.2% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Worst identifier     | [filter](/DefinitelyTyped/DefinitelyTyped/blob/d84efa69501f6be32b12a7e30639decc244e4c6d/types/eslint/eslint-tests.ts#L186) | [line](/DefinitelyTyped/DefinitelyTyped/blob/732d6da797f9aa1d3b75dbb71f567c730aabd4fd/types/eslint/eslint-tests.ts#L566) |       |\n| **`getQuickInfoAtPosition`**                 |                                                                                                                            |                                                                                                                          |       |\n| &nbsp;&nbsp;&nbsp;&nbsp;Mean duration (ms)   | 110.9                                                                                                                      | 114.7                                                                                                                    | +3.4% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Median duration (ms) | 123.4                                                                                                                      | 125.1                                                                                                                    | +1.4% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Mean CV              | 21.0%                                                                                                                      | 20.7%                                                                                                                    | -1.1% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Worst duration (ms)  | 210.8                                                                                                                      | 201.0                                                                                                                    | -4.7% |\n| &nbsp;&nbsp;&nbsp;&nbsp;Worst identifier     | [AST](/DefinitelyTyped/DefinitelyTyped/blob/d84efa69501f6be32b12a7e30639decc244e4c6d/types/eslint/eslint-tests.ts#L187)    | [code](/DefinitelyTyped/DefinitelyTyped/blob/732d6da797f9aa1d3b75dbb71f567c730aabd4fd/types/eslint/eslint-tests.ts#L565) |       |\n\n\n</details>\n\nIt looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place."}}
{"actor":{"display_login":"typescript-bot"}}