{"action":"closed","number":2456,"pull_request":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/2456","id":305568133,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NTY4MTMz","html_url":"https://github.com/digital-asset/daml/pull/2456","diff_url":"https://github.com/digital-asset/daml/pull/2456.diff","patch_url":"https://github.com/digital-asset/daml/pull/2456.patch","issue_url":"https://api.github.com/repos/digital-asset/daml/issues/2456","number":2456,"state":"closed","locked":false,"title":"Avoid one indirection for dictionary construction","user":{"login":"hurryabit","id":11665611,"node_id":"MDQ6VXNlcjExNjY1NjEx","avatar_url":"https://avatars1.githubusercontent.com/u/11665611?v=4","gravatar_id":"","url":"https://api.github.com/users/hurryabit","html_url":"https://github.com/hurryabit","followers_url":"https://api.github.com/users/hurryabit/followers","following_url":"https://api.github.com/users/hurryabit/following{/other_user}","gists_url":"https://api.github.com/users/hurryabit/gists{/gist_id}","starred_url":"https://api.github.com/users/hurryabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hurryabit/subscriptions","organizations_url":"https://api.github.com/users/hurryabit/orgs","repos_url":"https://api.github.com/users/hurryabit/repos","events_url":"https://api.github.com/users/hurryabit/events{/privacy}","received_events_url":"https://api.github.com/users/hurryabit/received_events","type":"User","site_admin":false},"body":"For every constructor `Foo` we generate a function `$ctor:Foo` which calls\r\nthe DAML-LF constructor for `Foo`. This function is useless since GHC already\r\ncreates a function `$WFoo` for us which does the same. This PR remove the\r\n`$ctor:...` functions for type class dictionaries.\r\n\r\nThis makes a bit of a mess in the `Ctors` data type. This will be cleaned up\r\nwhen all `$ctor:...` functions are finally gone.\r\n\r\n### Pull Request Checklist\r\n\r\n- [ ] Read and understand the [contribution guidelines](https://github.com/digital-asset/daml/blob/master/CONTRIBUTING.md)\r\n- [ ] Include appropriate tests\r\n- [ ] Set a descriptive title and thorough description\r\n- [ ] Add a reference to the [issue this PR will solve](https://github.com/digital-asset/daml/issues), if appropriate\r\n- [ ] Add a line to the [release notes](https://github.com/digital-asset/daml/blob/master/unreleased.rst), if appropriate\r\n- [ ] Normal production system change, include purpose of change in description\r\n\r\nNOTE: CI is not automatically run on non-members pull-requests for security\r\nreasons. The reviewer will have to comment with `/AzurePipelines run` to\r\ntrigger the build.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/digital-asset/daml/2456)\n<!-- Reviewable:end -->\n","created_at":"2019-08-08T13:05:37Z","updated_at":"2019-08-08T17:12:45Z","closed_at":"2019-08-08T17:12:45Z","merged_at":"2019-08-08T17:12:45Z","merge_commit_sha":"8fc5b62bd8035c7616736da0d66a994aff468ad5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"associahedron","id":231829,"node_id":"MDQ6VXNlcjIzMTgyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/231829?v=4","gravatar_id":"","url":"https://api.github.com/users/associahedron","html_url":"https://github.com/associahedron","followers_url":"https://api.github.com/users/associahedron/followers","following_url":"https://api.github.com/users/associahedron/following{/other_user}","gists_url":"https://api.github.com/users/associahedron/gists{/gist_id}","starred_url":"https://api.github.com/users/associahedron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/associahedron/subscriptions","organizations_url":"https://api.github.com/users/associahedron/orgs","repos_url":"https://api.github.com/users/associahedron/repos","events_url":"https://api.github.com/users/associahedron/events{/privacy}","received_events_url":"https://api.github.com/users/associahedron/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/digital-asset/daml/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/digital-asset/daml/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digital-asset/daml/issues/2456/comments","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/12242e77583fc2b2658d2bfe877afa5b49bc4643","head":{"label":"digital-asset:inline-dict-constructors","ref":"inline-dict-constructors","sha":"12242e77583fc2b2658d2bfe877afa5b49bc4643","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-08-08T15:50:27Z","pushed_at":"2019-08-08T17:12:45Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"git@github.com:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":41893,"stargazers_count":231,"watchers_count":231,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":43,"open_issues":344,"watchers":231,"default_branch":"master"}},"base":{"label":"digital-asset:master","ref":"master","sha":"6ccb18be084037780529c0d4e83cd68b4e503225","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-08-08T15:50:27Z","pushed_at":"2019-08-08T17:12:45Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"git@github.com:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":41893,"stargazers_count":231,"watchers_count":231,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":344,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":43,"open_issues":344,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/2456"},"html":{"href":"https://github.com/digital-asset/daml/pull/2456"},"issue":{"href":"https://api.github.com/repos/digital-asset/daml/issues/2456"},"comments":{"href":"https://api.github.com/repos/digital-asset/daml/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/digital-asset/daml/statuses/12242e77583fc2b2658d2bfe877afa5b49bc4643"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hurryabit","id":11665611,"node_id":"MDQ6VXNlcjExNjY1NjEx","avatar_url":"https://avatars1.githubusercontent.com/u/11665611?v=4","gravatar_id":"","url":"https://api.github.com/users/hurryabit","html_url":"https://github.com/hurryabit","followers_url":"https://api.github.com/users/hurryabit/followers","following_url":"https://api.github.com/users/hurryabit/following{/other_user}","gists_url":"https://api.github.com/users/hurryabit/gists{/gist_id}","starred_url":"https://api.github.com/users/hurryabit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hurryabit/subscriptions","organizations_url":"https://api.github.com/users/hurryabit/orgs","repos_url":"https://api.github.com/users/hurryabit/repos","events_url":"https://api.github.com/users/hurryabit/events{/privacy}","received_events_url":"https://api.github.com/users/hurryabit/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":31,"deletions":19,"changed_files":1}}
{"actor":{"display_login":"hurryabit"}}