{"action":"created","comment":{"url":"https://api.github.com/repos/juxt/crux/pulls/comments/362455095","pull_request_review_id":337635573,"id":362455095,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MjQ1NTA5NQ==","diff_hunk":"@@ -21,7 +21,9 @@\n                     (if-let [^Message last-message (reduce (fn [last-message ^Message m]\n                                                              (case (get (.headers m) :crux.tx/sub-topic)\n                                                                :docs\n-                                                               (db/index-doc indexer (.key m) (.body m))\n+                                                               ;; TODO we'll likely be able to make this more efficient","path":"crux-core/src/crux/tx/polling.clj","position":5,"original_position":5,"commit_id":"5a5969fc947f338896d999cf4b5ea9911381fa05","original_commit_id":"5a5969fc947f338896d999cf4b5ea9911381fa05","user":{"login":"jonpither","id":143601,"node_id":"MDQ6VXNlcjE0MzYwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/143601?v=4","gravatar_id":"","url":"https://api.github.com/users/jonpither","html_url":"https://github.com/jonpither","followers_url":"https://api.github.com/users/jonpither/followers","following_url":"https://api.github.com/users/jonpither/following{/other_user}","gists_url":"https://api.github.com/users/jonpither/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpither/subscriptions","organizations_url":"https://api.github.com/users/jonpither/orgs","repos_url":"https://api.github.com/users/jonpither/repos","events_url":"https://api.github.com/users/jonpither/events{/privacy}","received_events_url":"https://api.github.com/users/jonpither/received_events","type":"User","site_admin":false},"body":"This comment still valid?","created_at":"2020-01-02T12:19:56Z","updated_at":"2020-01-02T12:21:14Z","html_url":"https://github.com/juxt/crux/pull/524#discussion_r362455095","pull_request_url":"https://api.github.com/repos/juxt/crux/pulls/524","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juxt/crux/pulls/comments/362455095"},"html":{"href":"https://github.com/juxt/crux/pull/524#discussion_r362455095"},"pull_request":{"href":"https://api.github.com/repos/juxt/crux/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/juxt/crux/pulls/524","id":358630510,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU4NjMwNTEw","html_url":"https://github.com/juxt/crux/pull/524","diff_url":"https://github.com/juxt/crux/pull/524.diff","patch_url":"https://github.com/juxt/crux/pull/524.patch","issue_url":"https://api.github.com/repos/juxt/crux/issues/524","number":524,"state":"open","locked":false,"title":"Batch index docs into the KV store","user":{"login":"jarohen","id":336964,"node_id":"MDQ6VXNlcjMzNjk2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/336964?v=4","gravatar_id":"","url":"https://api.github.com/users/jarohen","html_url":"https://github.com/jarohen","followers_url":"https://api.github.com/users/jarohen/followers","following_url":"https://api.github.com/users/jarohen/following{/other_user}","gists_url":"https://api.github.com/users/jarohen/gists{/gist_id}","starred_url":"https://api.github.com/users/jarohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarohen/subscriptions","organizations_url":"https://api.github.com/users/jarohen/orgs","repos_url":"https://api.github.com/users/jarohen/repos","events_url":"https://api.github.com/users/jarohen/events{/privacy}","received_events_url":"https://api.github.com/users/jarohen/received_events","type":"User","site_admin":false},"body":"Currently, we're indexing docs one-at-a-time into the KVIndexer - RocksDB, in particular, appreciates putting documents in sorted batches (see 'What's the fastest way to load data into RocksDB?' at https://github.com/facebook/rocksdb/wiki/RocksDB-FAQ)\r\n\r\nThe microbench, on my laptop, takes ~11s to load 100k docs individually, but ~6.2s to load 100k docs in batches of 100 (batches of 1000 didn't make a significant difference)\r\n","created_at":"2020-01-02T11:35:11Z","updated_at":"2020-01-02T12:21:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0650fefbe74e2a868ab1910741da5342d60687b9","assignee":{"login":"jarohen","id":336964,"node_id":"MDQ6VXNlcjMzNjk2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/336964?v=4","gravatar_id":"","url":"https://api.github.com/users/jarohen","html_url":"https://github.com/jarohen","followers_url":"https://api.github.com/users/jarohen/followers","following_url":"https://api.github.com/users/jarohen/following{/other_user}","gists_url":"https://api.github.com/users/jarohen/gists{/gist_id}","starred_url":"https://api.github.com/users/jarohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarohen/subscriptions","organizations_url":"https://api.github.com/users/jarohen/orgs","repos_url":"https://api.github.com/users/jarohen/repos","events_url":"https://api.github.com/users/jarohen/events{/privacy}","received_events_url":"https://api.github.com/users/jarohen/received_events","type":"User","site_admin":false},"assignees":[{"login":"jarohen","id":336964,"node_id":"MDQ6VXNlcjMzNjk2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/336964?v=4","gravatar_id":"","url":"https://api.github.com/users/jarohen","html_url":"https://github.com/jarohen","followers_url":"https://api.github.com/users/jarohen/followers","following_url":"https://api.github.com/users/jarohen/following{/other_user}","gists_url":"https://api.github.com/users/jarohen/gists{/gist_id}","starred_url":"https://api.github.com/users/jarohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarohen/subscriptions","organizations_url":"https://api.github.com/users/jarohen/orgs","repos_url":"https://api.github.com/users/jarohen/repos","events_url":"https://api.github.com/users/jarohen/events{/privacy}","received_events_url":"https://api.github.com/users/jarohen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"hraberg","id":232419,"node_id":"MDQ6VXNlcjIzMjQxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/232419?v=4","gravatar_id":"","url":"https://api.github.com/users/hraberg","html_url":"https://github.com/hraberg","followers_url":"https://api.github.com/users/hraberg/followers","following_url":"https://api.github.com/users/hraberg/following{/other_user}","gists_url":"https://api.github.com/users/hraberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hraberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hraberg/subscriptions","organizations_url":"https://api.github.com/users/hraberg/orgs","repos_url":"https://api.github.com/users/hraberg/repos","events_url":"https://api.github.com/users/hraberg/events{/privacy}","received_events_url":"https://api.github.com/users/hraberg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juxt/crux/pulls/524/commits","review_comments_url":"https://api.github.com/repos/juxt/crux/pulls/524/comments","review_comment_url":"https://api.github.com/repos/juxt/crux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juxt/crux/issues/524/comments","statuses_url":"https://api.github.com/repos/juxt/crux/statuses/5a5969fc947f338896d999cf4b5ea9911381fa05","head":{"label":"jarohen:batch-index-docs","ref":"batch-index-docs","sha":"5a5969fc947f338896d999cf4b5ea9911381fa05","user":{"login":"jarohen","id":336964,"node_id":"MDQ6VXNlcjMzNjk2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/336964?v=4","gravatar_id":"","url":"https://api.github.com/users/jarohen","html_url":"https://github.com/jarohen","followers_url":"https://api.github.com/users/jarohen/followers","following_url":"https://api.github.com/users/jarohen/following{/other_user}","gists_url":"https://api.github.com/users/jarohen/gists{/gist_id}","starred_url":"https://api.github.com/users/jarohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarohen/subscriptions","organizations_url":"https://api.github.com/users/jarohen/orgs","repos_url":"https://api.github.com/users/jarohen/repos","events_url":"https://api.github.com/users/jarohen/events{/privacy}","received_events_url":"https://api.github.com/users/jarohen/received_events","type":"User","site_admin":false},"repo":{"id":222501873,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI1MDE4NzM=","name":"crux","full_name":"jarohen/crux","private":false,"owner":{"login":"jarohen","id":336964,"node_id":"MDQ6VXNlcjMzNjk2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/336964?v=4","gravatar_id":"","url":"https://api.github.com/users/jarohen","html_url":"https://github.com/jarohen","followers_url":"https://api.github.com/users/jarohen/followers","following_url":"https://api.github.com/users/jarohen/following{/other_user}","gists_url":"https://api.github.com/users/jarohen/gists{/gist_id}","starred_url":"https://api.github.com/users/jarohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarohen/subscriptions","organizations_url":"https://api.github.com/users/jarohen/orgs","repos_url":"https://api.github.com/users/jarohen/repos","events_url":"https://api.github.com/users/jarohen/events{/privacy}","received_events_url":"https://api.github.com/users/jarohen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jarohen/crux","description":"Open Time Store","fork":true,"url":"https://api.github.com/repos/jarohen/crux","forks_url":"https://api.github.com/repos/jarohen/crux/forks","keys_url":"https://api.github.com/repos/jarohen/crux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarohen/crux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarohen/crux/teams","hooks_url":"https://api.github.com/repos/jarohen/crux/hooks","issue_events_url":"https://api.github.com/repos/jarohen/crux/issues/events{/number}","events_url":"https://api.github.com/repos/jarohen/crux/events","assignees_url":"https://api.github.com/repos/jarohen/crux/assignees{/user}","branches_url":"https://api.github.com/repos/jarohen/crux/branches{/branch}","tags_url":"https://api.github.com/repos/jarohen/crux/tags","blobs_url":"https://api.github.com/repos/jarohen/crux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarohen/crux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarohen/crux/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarohen/crux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarohen/crux/statuses/{sha}","languages_url":"https://api.github.com/repos/jarohen/crux/languages","stargazers_url":"https://api.github.com/repos/jarohen/crux/stargazers","contributors_url":"https://api.github.com/repos/jarohen/crux/contributors","subscribers_url":"https://api.github.com/repos/jarohen/crux/subscribers","subscription_url":"https://api.github.com/repos/jarohen/crux/subscription","commits_url":"https://api.github.com/repos/jarohen/crux/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarohen/crux/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarohen/crux/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarohen/crux/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarohen/crux/contents/{+path}","compare_url":"https://api.github.com/repos/jarohen/crux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarohen/crux/merges","archive_url":"https://api.github.com/repos/jarohen/crux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarohen/crux/downloads","issues_url":"https://api.github.com/repos/jarohen/crux/issues{/number}","pulls_url":"https://api.github.com/repos/jarohen/crux/pulls{/number}","milestones_url":"https://api.github.com/repos/jarohen/crux/milestones{/number}","notifications_url":"https://api.github.com/repos/jarohen/crux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarohen/crux/labels{/name}","releases_url":"https://api.github.com/repos/jarohen/crux/releases{/id}","deployments_url":"https://api.github.com/repos/jarohen/crux/deployments","created_at":"2019-11-18T17:10:19Z","updated_at":"2020-01-02T11:13:18Z","pushed_at":"2020-01-02T11:46:23Z","git_url":"git://github.com/jarohen/crux.git","ssh_url":"git@github.com:jarohen/crux.git","clone_url":"https://github.com/jarohen/crux.git","svn_url":"https://github.com/jarohen/crux","homepage":"https://juxt.pro/crux","size":9959,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juxt:master","ref":"master","sha":"3c7059d5c9052bd44a318276e9d7c431964590e8","user":{"login":"juxt","id":2892228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTIyMjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2892228?v=4","gravatar_id":"","url":"https://api.github.com/users/juxt","html_url":"https://github.com/juxt","followers_url":"https://api.github.com/users/juxt/followers","following_url":"https://api.github.com/users/juxt/following{/other_user}","gists_url":"https://api.github.com/users/juxt/gists{/gist_id}","starred_url":"https://api.github.com/users/juxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juxt/subscriptions","organizations_url":"https://api.github.com/users/juxt/orgs","repos_url":"https://api.github.com/users/juxt/repos","events_url":"https://api.github.com/users/juxt/events{/privacy}","received_events_url":"https://api.github.com/users/juxt/received_events","type":"Organization","site_admin":false},"repo":{"id":125824259,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4MjQyNTk=","name":"crux","full_name":"juxt/crux","private":false,"owner":{"login":"juxt","id":2892228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTIyMjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2892228?v=4","gravatar_id":"","url":"https://api.github.com/users/juxt","html_url":"https://github.com/juxt","followers_url":"https://api.github.com/users/juxt/followers","following_url":"https://api.github.com/users/juxt/following{/other_user}","gists_url":"https://api.github.com/users/juxt/gists{/gist_id}","starred_url":"https://api.github.com/users/juxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juxt/subscriptions","organizations_url":"https://api.github.com/users/juxt/orgs","repos_url":"https://api.github.com/users/juxt/repos","events_url":"https://api.github.com/users/juxt/events{/privacy}","received_events_url":"https://api.github.com/users/juxt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/juxt/crux","description":"Open Time Store","fork":false,"url":"https://api.github.com/repos/juxt/crux","forks_url":"https://api.github.com/repos/juxt/crux/forks","keys_url":"https://api.github.com/repos/juxt/crux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juxt/crux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juxt/crux/teams","hooks_url":"https://api.github.com/repos/juxt/crux/hooks","issue_events_url":"https://api.github.com/repos/juxt/crux/issues/events{/number}","events_url":"https://api.github.com/repos/juxt/crux/events","assignees_url":"https://api.github.com/repos/juxt/crux/assignees{/user}","branches_url":"https://api.github.com/repos/juxt/crux/branches{/branch}","tags_url":"https://api.github.com/repos/juxt/crux/tags","blobs_url":"https://api.github.com/repos/juxt/crux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juxt/crux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juxt/crux/git/refs{/sha}","trees_url":"https://api.github.com/repos/juxt/crux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juxt/crux/statuses/{sha}","languages_url":"https://api.github.com/repos/juxt/crux/languages","stargazers_url":"https://api.github.com/repos/juxt/crux/stargazers","contributors_url":"https://api.github.com/repos/juxt/crux/contributors","subscribers_url":"https://api.github.com/repos/juxt/crux/subscribers","subscription_url":"https://api.github.com/repos/juxt/crux/subscription","commits_url":"https://api.github.com/repos/juxt/crux/commits{/sha}","git_commits_url":"https://api.github.com/repos/juxt/crux/git/commits{/sha}","comments_url":"https://api.github.com/repos/juxt/crux/comments{/number}","issue_comment_url":"https://api.github.com/repos/juxt/crux/issues/comments{/number}","contents_url":"https://api.github.com/repos/juxt/crux/contents/{+path}","compare_url":"https://api.github.com/repos/juxt/crux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juxt/crux/merges","archive_url":"https://api.github.com/repos/juxt/crux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juxt/crux/downloads","issues_url":"https://api.github.com/repos/juxt/crux/issues{/number}","pulls_url":"https://api.github.com/repos/juxt/crux/pulls{/number}","milestones_url":"https://api.github.com/repos/juxt/crux/milestones{/number}","notifications_url":"https://api.github.com/repos/juxt/crux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juxt/crux/labels{/name}","releases_url":"https://api.github.com/repos/juxt/crux/releases{/id}","deployments_url":"https://api.github.com/repos/juxt/crux/deployments","created_at":"2018-03-19T08:19:27Z","updated_at":"2020-01-02T11:13:18Z","pushed_at":"2020-01-02T11:46:25Z","git_url":"git://github.com/juxt/crux.git","ssh_url":"git@github.com:juxt/crux.git","clone_url":"https://github.com/juxt/crux.git","svn_url":"https://github.com/juxt/crux","homepage":"https://opencrux.com","size":18307,"stargazers_count":756,"watchers_count":756,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":54,"open_issues":115,"watchers":756,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juxt/crux/pulls/524"},"html":{"href":"https://github.com/juxt/crux/pull/524"},"issue":{"href":"https://api.github.com/repos/juxt/crux/issues/524"},"comments":{"href":"https://api.github.com/repos/juxt/crux/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/juxt/crux/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/juxt/crux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juxt/crux/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/juxt/crux/statuses/5a5969fc947f338896d999cf4b5ea9911381fa05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonpither"}}