{"action":"created","comment":{"url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments/366499426","pull_request_review_id":342743347,"id":366499426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjQ5OTQyNg==","diff_hunk":"@@ -77,29 +78,42 @@ public boolean validCheckForObject(final AtlasObject object)\n         {\n             return Optional.empty();\n         }\n-        final int allPathsCount = bigNode.allPaths().size();\n+\n         final int junctionEdgesCount = bigNode.junctionEdges().size();\n-        final Set<RestrictedPath> turnRestrictions = bigNode.turnRestrictions();\n-        final int turnRestrictionCount = turnRestrictions.size();\n-        // Get list of restricted path OSM ids\n-        final List<Long> restrictedPathOsmIds = turnRestrictions.stream()\n-                .flatMap(restrictedPath -> Iterables.asList(restrictedPath.getRoute()).stream()\n-                        .map(Edge::getOsmIdentifier))\n-                .collect(Collectors.toList());\n-\n-        if (allPathsCount > maxNumberPathsThreshold\n-                || junctionEdgesCount > maxNumberJunctionEdgesThreshold)\n+        if (junctionEdgesCount > maxNumberJunctionEdgesThreshold)\n         {\n             final CheckFlag flag = createFlag(bigNode,\n-                    this.getLocalizedInstruction(0, allPathsCount, junctionEdgesCount,\n-                            turnRestrictionCount, restrictedPathOsmIds.toString()));\n+                    this.getLocalizedInstruction(0, junctionEdgesCount));\n \n             bigNode.edges().forEach(flag::addObject);\n             // Add map pin at each BigNode Node\n             bigNode.nodes().forEach(b -> flag.addPoint(b.getLocation()));\n \n             return Optional.of(flag);\n         }\n+        else","path":"src/main/java/org/openstreetmap/atlas/checks/validation/intersections/BigNodeBadDataCheck.java","position":44,"original_position":44,"commit_id":"16237ba7887e1ce83a610d8d79460837b90582cf","original_commit_id":"16237ba7887e1ce83a610d8d79460837b90582cf","user":{"login":"smaheshwaram","id":16053580,"node_id":"MDQ6VXNlcjE2MDUzNTgw","avatar_url":"https://avatars2.githubusercontent.com/u/16053580?v=4","gravatar_id":"","url":"https://api.github.com/users/smaheshwaram","html_url":"https://github.com/smaheshwaram","followers_url":"https://api.github.com/users/smaheshwaram/followers","following_url":"https://api.github.com/users/smaheshwaram/following{/other_user}","gists_url":"https://api.github.com/users/smaheshwaram/gists{/gist_id}","starred_url":"https://api.github.com/users/smaheshwaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaheshwaram/subscriptions","organizations_url":"https://api.github.com/users/smaheshwaram/orgs","repos_url":"https://api.github.com/users/smaheshwaram/repos","events_url":"https://api.github.com/users/smaheshwaram/events{/privacy}","received_events_url":"https://api.github.com/users/smaheshwaram/received_events","type":"User","site_admin":false},"body":"@Bentleysb Great improvement on the run time. I only have one doubt. So, here are you trying to get bigNode.allPaths() only if no other flag conditions are met so that you can save run time!!","created_at":"2020-01-14T18:25:14Z","updated_at":"2020-01-14T18:25:15Z","html_url":"https://github.com/osmlab/atlas-checks/pull/241#discussion_r366499426","pull_request_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments/366499426"},"html":{"href":"https://github.com/osmlab/atlas-checks/pull/241#discussion_r366499426"},"pull_request":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241","id":362370353,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyMzcwMzUz","html_url":"https://github.com/osmlab/atlas-checks/pull/241","diff_url":"https://github.com/osmlab/atlas-checks/pull/241.diff","patch_url":"https://github.com/osmlab/atlas-checks/pull/241.patch","issue_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/241","number":241,"state":"open","locked":false,"title":"BigNodeBadDataCheck Run Time Bug","user":{"login":"Bentleysb","id":24948563,"node_id":"MDQ6VXNlcjI0OTQ4NTYz","avatar_url":"https://avatars0.githubusercontent.com/u/24948563?v=4","gravatar_id":"","url":"https://api.github.com/users/Bentleysb","html_url":"https://github.com/Bentleysb","followers_url":"https://api.github.com/users/Bentleysb/followers","following_url":"https://api.github.com/users/Bentleysb/following{/other_user}","gists_url":"https://api.github.com/users/Bentleysb/gists{/gist_id}","starred_url":"https://api.github.com/users/Bentleysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bentleysb/subscriptions","organizations_url":"https://api.github.com/users/Bentleysb/orgs","repos_url":"https://api.github.com/users/Bentleysb/repos","events_url":"https://api.github.com/users/Bentleysb/events{/privacy}","received_events_url":"https://api.github.com/users/Bentleysb/received_events","type":"User","site_admin":false},"body":"### Description:\r\nBigNodeBadDataCheck can often load Edge networks consisting of tens of Edges. In these cases it takes a long time for the AllPathsRouter to execute on the network. In some rare cases the check will even time out before completing due to this.\r\nThe AllPathsRouter is used to calculate the number of paths through a big node. If this number is too high then that is one of the conditions for the big node to be flagged.\r\nTo fix this issue the check has been altered to only run the AllPathsRouter (through `BigNode.allPaths()`) if no other conditions for flagging are met. \r\n\r\n### Potential Impact:\r\n\r\nBigNodeBadDataCheck should run much more quickly. There may be an increase in flags in areas where the check was previously timing out. \r\nIn most cases the flag instructions will no longer include information on the path count or turn restriction count. That will now only occur when the path count is used as the last resort flag condition. \r\n\r\n### Unit Test Approach:\r\nNo unit tests were changed or added. All tests pass. \r\n\r\n### Test Results:\r\n\r\nTested the fix on an atlas that previously timed out when trying to run this check. The timeout occurs when it takes longer than 300 minutes for the check to run. The check now runs in under 18 seconds. \r\nCompared results of an atlas that did complete before and found that the flags were the same, with the exception of the altered instructions. \r\n\r\n","created_at":"2020-01-13T23:22:44Z","updated_at":"2020-01-14T18:25:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"012c552ee50cb7974cfa686ef99379376ef54b96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241/commits","review_comments_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241/comments","review_comment_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/241/comments","statuses_url":"https://api.github.com/repos/osmlab/atlas-checks/statuses/16237ba7887e1ce83a610d8d79460837b90582cf","head":{"label":"Bentleysb:dev-BigNodeBadRunTime","ref":"dev-BigNodeBadRunTime","sha":"16237ba7887e1ce83a610d8d79460837b90582cf","user":{"login":"Bentleysb","id":24948563,"node_id":"MDQ6VXNlcjI0OTQ4NTYz","avatar_url":"https://avatars0.githubusercontent.com/u/24948563?v=4","gravatar_id":"","url":"https://api.github.com/users/Bentleysb","html_url":"https://github.com/Bentleysb","followers_url":"https://api.github.com/users/Bentleysb/followers","following_url":"https://api.github.com/users/Bentleysb/following{/other_user}","gists_url":"https://api.github.com/users/Bentleysb/gists{/gist_id}","starred_url":"https://api.github.com/users/Bentleysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bentleysb/subscriptions","organizations_url":"https://api.github.com/users/Bentleysb/orgs","repos_url":"https://api.github.com/users/Bentleysb/repos","events_url":"https://api.github.com/users/Bentleysb/events{/privacy}","received_events_url":"https://api.github.com/users/Bentleysb/received_events","type":"User","site_admin":false},"repo":{"id":132798041,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3OTgwNDE=","name":"atlas-checks","full_name":"Bentleysb/atlas-checks","private":false,"owner":{"login":"Bentleysb","id":24948563,"node_id":"MDQ6VXNlcjI0OTQ4NTYz","avatar_url":"https://avatars0.githubusercontent.com/u/24948563?v=4","gravatar_id":"","url":"https://api.github.com/users/Bentleysb","html_url":"https://github.com/Bentleysb","followers_url":"https://api.github.com/users/Bentleysb/followers","following_url":"https://api.github.com/users/Bentleysb/following{/other_user}","gists_url":"https://api.github.com/users/Bentleysb/gists{/gist_id}","starred_url":"https://api.github.com/users/Bentleysb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bentleysb/subscriptions","organizations_url":"https://api.github.com/users/Bentleysb/orgs","repos_url":"https://api.github.com/users/Bentleysb/repos","events_url":"https://api.github.com/users/Bentleysb/events{/privacy}","received_events_url":"https://api.github.com/users/Bentleysb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bentleysb/atlas-checks","description":"OSM data integrity checks with Atlas","fork":true,"url":"https://api.github.com/repos/Bentleysb/atlas-checks","forks_url":"https://api.github.com/repos/Bentleysb/atlas-checks/forks","keys_url":"https://api.github.com/repos/Bentleysb/atlas-checks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bentleysb/atlas-checks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bentleysb/atlas-checks/teams","hooks_url":"https://api.github.com/repos/Bentleysb/atlas-checks/hooks","issue_events_url":"https://api.github.com/repos/Bentleysb/atlas-checks/issues/events{/number}","events_url":"https://api.github.com/repos/Bentleysb/atlas-checks/events","assignees_url":"https://api.github.com/repos/Bentleysb/atlas-checks/assignees{/user}","branches_url":"https://api.github.com/repos/Bentleysb/atlas-checks/branches{/branch}","tags_url":"https://api.github.com/repos/Bentleysb/atlas-checks/tags","blobs_url":"https://api.github.com/repos/Bentleysb/atlas-checks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bentleysb/atlas-checks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bentleysb/atlas-checks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bentleysb/atlas-checks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bentleysb/atlas-checks/statuses/{sha}","languages_url":"https://api.github.com/repos/Bentleysb/atlas-checks/languages","stargazers_url":"https://api.github.com/repos/Bentleysb/atlas-checks/stargazers","contributors_url":"https://api.github.com/repos/Bentleysb/atlas-checks/contributors","subscribers_url":"https://api.github.com/repos/Bentleysb/atlas-checks/subscribers","subscription_url":"https://api.github.com/repos/Bentleysb/atlas-checks/subscription","commits_url":"https://api.github.com/repos/Bentleysb/atlas-checks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bentleysb/atlas-checks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bentleysb/atlas-checks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bentleysb/atlas-checks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bentleysb/atlas-checks/contents/{+path}","compare_url":"https://api.github.com/repos/Bentleysb/atlas-checks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bentleysb/atlas-checks/merges","archive_url":"https://api.github.com/repos/Bentleysb/atlas-checks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bentleysb/atlas-checks/downloads","issues_url":"https://api.github.com/repos/Bentleysb/atlas-checks/issues{/number}","pulls_url":"https://api.github.com/repos/Bentleysb/atlas-checks/pulls{/number}","milestones_url":"https://api.github.com/repos/Bentleysb/atlas-checks/milestones{/number}","notifications_url":"https://api.github.com/repos/Bentleysb/atlas-checks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bentleysb/atlas-checks/labels{/name}","releases_url":"https://api.github.com/repos/Bentleysb/atlas-checks/releases{/id}","deployments_url":"https://api.github.com/repos/Bentleysb/atlas-checks/deployments","created_at":"2018-05-09T18:31:15Z","updated_at":"2020-01-08T18:35:50Z","pushed_at":"2020-01-14T17:15:17Z","git_url":"git://github.com/Bentleysb/atlas-checks.git","ssh_url":"git@github.com:Bentleysb/atlas-checks.git","clone_url":"https://github.com/Bentleysb/atlas-checks.git","svn_url":"https://github.com/Bentleysb/atlas-checks","homepage":null,"size":14132,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"osmlab:dev","ref":"dev","sha":"b1796307fe74ac8857c33039c4c3b884c4b75e24","user":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":99742504,"node_id":"MDEwOlJlcG9zaXRvcnk5OTc0MjUwNA==","name":"atlas-checks","full_name":"osmlab/atlas-checks","private":false,"owner":{"login":"osmlab","id":3856374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTYzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3856374?v=4","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osmlab/atlas-checks","description":"OSM data integrity checks with Atlas","fork":false,"url":"https://api.github.com/repos/osmlab/atlas-checks","forks_url":"https://api.github.com/repos/osmlab/atlas-checks/forks","keys_url":"https://api.github.com/repos/osmlab/atlas-checks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/atlas-checks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/atlas-checks/teams","hooks_url":"https://api.github.com/repos/osmlab/atlas-checks/hooks","issue_events_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/atlas-checks/events","assignees_url":"https://api.github.com/repos/osmlab/atlas-checks/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/atlas-checks/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/atlas-checks/tags","blobs_url":"https://api.github.com/repos/osmlab/atlas-checks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/atlas-checks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/atlas-checks/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/atlas-checks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/atlas-checks/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/atlas-checks/languages","stargazers_url":"https://api.github.com/repos/osmlab/atlas-checks/stargazers","contributors_url":"https://api.github.com/repos/osmlab/atlas-checks/contributors","subscribers_url":"https://api.github.com/repos/osmlab/atlas-checks/subscribers","subscription_url":"https://api.github.com/repos/osmlab/atlas-checks/subscription","commits_url":"https://api.github.com/repos/osmlab/atlas-checks/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/atlas-checks/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/atlas-checks/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/atlas-checks/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/atlas-checks/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/atlas-checks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/atlas-checks/merges","archive_url":"https://api.github.com/repos/osmlab/atlas-checks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/atlas-checks/downloads","issues_url":"https://api.github.com/repos/osmlab/atlas-checks/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/atlas-checks/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/atlas-checks/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/atlas-checks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/atlas-checks/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/atlas-checks/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/atlas-checks/deployments","created_at":"2017-08-08T22:46:46Z","updated_at":"2020-01-14T01:04:33Z","pushed_at":"2020-01-14T17:48:59Z","git_url":"git://github.com/osmlab/atlas-checks.git","ssh_url":"git@github.com:osmlab/atlas-checks.git","clone_url":"https://github.com/osmlab/atlas-checks.git","svn_url":"https://github.com/osmlab/atlas-checks","homepage":null,"size":13676,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":35,"open_issues":9,"watchers":28,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241"},"html":{"href":"https://github.com/osmlab/atlas-checks/pull/241"},"issue":{"href":"https://api.github.com/repos/osmlab/atlas-checks/issues/241"},"comments":{"href":"https://api.github.com/repos/osmlab/atlas-checks/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmlab/atlas-checks/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/osmlab/atlas-checks/statuses/16237ba7887e1ce83a610d8d79460837b90582cf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"smaheshwaram"}}