{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/273644469","pull_request_review_id":224584628,"id":273644469,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzY0NDQ2OQ==","diff_hunk":"@@ -252,6 +251,58 @@ The toolset also defines default versions for various tools and dependencies, su\n \n See [DefaultVersions](https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props) for a list of *UsingTool* properties and default versions.\n \n+#### Example: Restoring multiple .NET Core Runtimes for running tests\n+\n+in /global.json, specify a `dotnet-local` section and list the [shared runtime versions](https://dotnet.microsoft.com/download/dotnet-core) you want installed.\n+\n+```json\n+{\n+  \"tools\": {\n+    \"dotnet\": \"3.0.100-preview3-010431\",\n+    \"dotnet-local\": {\n+      \"runtimes\": [ \"2.1.7\" ]\n+    }\n+  },\n+```\n+\n+For an architecture specific runtime, list the runtimes under the architecture moniker.\n+\n+```json\n+{\n+  \"tools\": {\n+    \"dotnet\": \"3.0.100-preview3-010431\",\n+    \"dotnet-local\": {\n+      \"x86\": {\n+        \"runtimes\": [ \"2.1.7\" ]\n+      }\n+    }\n+  },\n+```\n+\n+When the Arcade scripts (`tools.ps1` \\ `tools.sh`) are invoked to restore the Arcade SDK, it will also use these values to generate a file named `/artifacts/toolset/DotNetCoreVersions.Generated.props` which will define additional \"DotNetCoreRuntimeVersion\" item groups.\n+\n+/artifacts/DotNetCoreVersions.Generated.props\n+\n+```xml\n+<Project>\n+  <ItemGroup>\n+    <DotNetCoreRuntimeVersion Include=\"2.1.7\" />","path":"Documentation/ArcadeSdk.md","position":47,"original_position":47,"commit_id":"055c65d9cd5f58f2157de1e1fc2e2cda80dc834b","original_commit_id":"d2e8954a06a6d3b337acf5bae7be0a096b843e41","user":{"login":"tmat","id":41759,"node_id":"MDQ6VXNlcjQxNzU5","avatar_url":"https://avatars0.githubusercontent.com/u/41759?v=4","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"> could we put this info under the \"dotnet\" section? This looks cleaner to me than \"local-runtimes\"\r\n\r\nThere is a distinction between `dotnet` and `dotnet-local`/`local-runtimes`: the former is used for build and can be found globally. The latter is forcing the script to install dotnet locally.","created_at":"2019-04-09T18:36:42Z","updated_at":"2019-04-09T18:36:42Z","html_url":"https://github.com/dotnet/arcade/pull/2343#discussion_r273644469","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/2343","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/273644469"},"html":{"href":"https://github.com/dotnet/arcade/pull/2343#discussion_r273644469"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2343"}},"in_reply_to_id":273290358},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/2343","id":264625326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NjI1MzI2","html_url":"https://github.com/dotnet/arcade/pull/2343","diff_url":"https://github.com/dotnet/arcade/pull/2343.diff","patch_url":"https://github.com/dotnet/arcade/pull/2343.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/2343","number":2343,"state":"open","locked":false,"title":"Multi framework","user":{"login":"chcosta","id":10092143,"node_id":"MDQ6VXNlcjEwMDkyMTQz","avatar_url":"https://avatars3.githubusercontent.com/u/10092143?v=4","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/dotnet/arcade/issues/1441\r\n\r\nThis change ensures the \"dotnet-install\" script is always downloaded to `[repo root]\\.dotnet` so that it is available during toolset restore and then it downloads additional runtimes by default only if you are a CI build.\r\n\r\nValidated in Roslyn builds with https://github.com/dotnet/roslyn/pull/34298/files\r\n\r\nAdditional validation is in progress as I've modified this PR slightly since my last validation build","created_at":"2019-03-26T17:36:02Z","updated_at":"2019-04-09T18:36:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a900e6f42830d2b3d455fd863c42ad73a4c34962","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ericstj","id":8918108,"node_id":"MDQ6VXNlcjg5MTgxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8918108?v=4","gravatar_id":"","url":"https://api.github.com/users/ericstj","html_url":"https://github.com/ericstj","followers_url":"https://api.github.com/users/ericstj/followers","following_url":"https://api.github.com/users/ericstj/following{/other_user}","gists_url":"https://api.github.com/users/ericstj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericstj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericstj/subscriptions","organizations_url":"https://api.github.com/users/ericstj/orgs","repos_url":"https://api.github.com/users/ericstj/repos","events_url":"https://api.github.com/users/ericstj/events{/privacy}","received_events_url":"https://api.github.com/users/ericstj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/2343/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/2343/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/2343/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/055c65d9cd5f58f2157de1e1fc2e2cda80dc834b","head":{"label":"chcosta:multi-framework","ref":"multi-framework","sha":"055c65d9cd5f58f2157de1e1fc2e2cda80dc834b","user":{"login":"chcosta","id":10092143,"node_id":"MDQ6VXNlcjEwMDkyMTQz","avatar_url":"https://avatars3.githubusercontent.com/u/10092143?v=4","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"repo":{"id":125571792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1NzE3OTI=","name":"arcade","full_name":"chcosta/arcade","private":false,"owner":{"login":"chcosta","id":10092143,"node_id":"MDQ6VXNlcjEwMDkyMTQz","avatar_url":"https://avatars3.githubusercontent.com/u/10092143?v=4","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chcosta/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/chcosta/arcade","forks_url":"https://api.github.com/repos/chcosta/arcade/forks","keys_url":"https://api.github.com/repos/chcosta/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chcosta/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chcosta/arcade/teams","hooks_url":"https://api.github.com/repos/chcosta/arcade/hooks","issue_events_url":"https://api.github.com/repos/chcosta/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/chcosta/arcade/events","assignees_url":"https://api.github.com/repos/chcosta/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/chcosta/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/chcosta/arcade/tags","blobs_url":"https://api.github.com/repos/chcosta/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chcosta/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chcosta/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/chcosta/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chcosta/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/chcosta/arcade/languages","stargazers_url":"https://api.github.com/repos/chcosta/arcade/stargazers","contributors_url":"https://api.github.com/repos/chcosta/arcade/contributors","subscribers_url":"https://api.github.com/repos/chcosta/arcade/subscribers","subscription_url":"https://api.github.com/repos/chcosta/arcade/subscription","commits_url":"https://api.github.com/repos/chcosta/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/chcosta/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/chcosta/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/chcosta/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/chcosta/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/chcosta/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chcosta/arcade/merges","archive_url":"https://api.github.com/repos/chcosta/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chcosta/arcade/downloads","issues_url":"https://api.github.com/repos/chcosta/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/chcosta/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/chcosta/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/chcosta/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chcosta/arcade/labels{/name}","releases_url":"https://api.github.com/repos/chcosta/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/chcosta/arcade/deployments","created_at":"2018-03-16T21:28:50Z","updated_at":"2019-04-08T18:07:59Z","pushed_at":"2019-04-09T16:18:18Z","git_url":"git://github.com/chcosta/arcade.git","ssh_url":"git@github.com:chcosta/arcade.git","clone_url":"https://github.com/chcosta/arcade.git","svn_url":"https://github.com/chcosta/arcade","homepage":"","size":13387,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"54458b912bdbcb57b5d14fbfaeb3443056f99595","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2019-04-09T12:20:40Z","pushed_at":"2019-04-09T18:01:04Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"git@github.com:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":21134,"stargazers_count":113,"watchers_count":113,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":340,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":82,"open_issues":340,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2343"},"html":{"href":"https://github.com/dotnet/arcade/pull/2343"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/2343"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/2343/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2343/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2343/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/055c65d9cd5f58f2157de1e1fc2e2cda80dc834b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tmat"}}