{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/338484083","pull_request_review_id":306453141,"id":338484083,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODQ4NDA4Mw==","diff_hunk":"@@ -1057,6 +1057,43 @@ def test_asmt_state_updating_empty_verifiers_with_map_fields(\n     self.assertEqual(assessment.status, all_models.Assessment.PROGRESS_STATE)\n     self.assertEqual(verifiers or [\"\"], [\"\"])\n \n+  def test_import_sox302_assmt_ro_field(self):","path":"test/integration/ggrc/converters/test_import_assessments.py","position":4,"original_position":4,"commit_id":"e22754820005cde470a268a1c13f9f5e89decfb8","original_commit_id":"e22754820005cde470a268a1c13f9f5e89decfb8","user":{"login":"pavelKhat","id":29396213,"node_id":"MDQ6VXNlcjI5Mzk2MjEz","avatar_url":"https://avatars1.githubusercontent.com/u/29396213?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelKhat","html_url":"https://github.com/pavelKhat","followers_url":"https://api.github.com/users/pavelKhat/followers","following_url":"https://api.github.com/users/pavelKhat/following{/other_user}","gists_url":"https://api.github.com/users/pavelKhat/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelKhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelKhat/subscriptions","organizations_url":"https://api.github.com/users/pavelKhat/orgs","repos_url":"https://api.github.com/users/pavelKhat/repos","events_url":"https://api.github.com/users/pavelKhat/events{/privacy}","received_events_url":"https://api.github.com/users/pavelKhat/received_events","type":"User","site_admin":false},"body":"Missing doc string","created_at":"2019-10-24T09:54:34Z","updated_at":"2019-10-24T09:54:35Z","html_url":"https://github.com/google/ggrc-core/pull/10176#discussion_r338484083","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/10176","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/338484083"},"html":{"href":"https://github.com/google/ggrc-core/pull/10176#discussion_r338484083"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10176"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/10176","id":331869225,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxODY5MjI1","html_url":"https://github.com/google/ggrc-core/pull/10176","diff_url":"https://github.com/google/ggrc-core/pull/10176.diff","patch_url":"https://github.com/google/ggrc-core/pull/10176.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/10176","number":10176,"state":"open","locked":false,"title":"[WIP] GGRC-7955:[BE]Add integration tests to cover new functionality:","user":{"login":"MaDITIY","id":37157165,"node_id":"MDQ6VXNlcjM3MTU3MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/37157165?v=4","gravatar_id":"","url":"https://api.github.com/users/MaDITIY","html_url":"https://github.com/MaDITIY","followers_url":"https://api.github.com/users/MaDITIY/followers","following_url":"https://api.github.com/users/MaDITIY/following{/other_user}","gists_url":"https://api.github.com/users/MaDITIY/gists{/gist_id}","starred_url":"https://api.github.com/users/MaDITIY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaDITIY/subscriptions","organizations_url":"https://api.github.com/users/MaDITIY/orgs","repos_url":"https://api.github.com/users/MaDITIY/repos","events_url":"https://api.github.com/users/MaDITIY/events{/privacy}","received_events_url":"https://api.github.com/users/MaDITIY/received_events","type":"User","site_admin":false},"body":"**Should be merged to GGRC-7772**\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] #10164 \r\n- [ ] #10165 \r\n- [ ] #10166 \r\n\r\n# Issue description\r\n\r\n*Needed to implement integration and unit tests for new sox functionality*\r\n\r\n# Steps to test the changes\r\n\r\n*Run tests*\r\n\r\n# Solution description\r\n\r\n*Implemented tests for technic solution*\r\n\r\n# Sanity checklist\r\n\r\n- [ ] I have clicked through the app to make sure my changes work and not break the app.\r\n- [ ] I have applied the correct milestone and labels.\r\n- [ ] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [ ] My changes are covered by tests.\r\n- [ ] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [ ] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [ ] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n- [ ] Upon merging, add 'check migration chain' and 'kokoro:force-run' labels to all open PRs with a label 'migration'\r\n- [ ] Upon merging, update 'table structure changes' in weekly deployment documentation\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2019-10-24T06:00:08Z","updated_at":"2019-10-24T09:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab74562967171d14e80480c7aece9a17821f1331","assignee":{"login":"pavelKhat","id":29396213,"node_id":"MDQ6VXNlcjI5Mzk2MjEz","avatar_url":"https://avatars1.githubusercontent.com/u/29396213?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelKhat","html_url":"https://github.com/pavelKhat","followers_url":"https://api.github.com/users/pavelKhat/followers","following_url":"https://api.github.com/users/pavelKhat/following{/other_user}","gists_url":"https://api.github.com/users/pavelKhat/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelKhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelKhat/subscriptions","organizations_url":"https://api.github.com/users/pavelKhat/orgs","repos_url":"https://api.github.com/users/pavelKhat/repos","events_url":"https://api.github.com/users/pavelKhat/events{/privacy}","received_events_url":"https://api.github.com/users/pavelKhat/received_events","type":"User","site_admin":false},"assignees":[{"login":"pavelKhat","id":29396213,"node_id":"MDQ6VXNlcjI5Mzk2MjEz","avatar_url":"https://avatars1.githubusercontent.com/u/29396213?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelKhat","html_url":"https://github.com/pavelKhat","followers_url":"https://api.github.com/users/pavelKhat/followers","following_url":"https://api.github.com/users/pavelKhat/following{/other_user}","gists_url":"https://api.github.com/users/pavelKhat/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelKhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelKhat/subscriptions","organizations_url":"https://api.github.com/users/pavelKhat/orgs","repos_url":"https://api.github.com/users/pavelKhat/repos","events_url":"https://api.github.com/users/pavelKhat/events{/privacy}","received_events_url":"https://api.github.com/users/pavelKhat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":654605022,"node_id":"MDU6TGFiZWw2NTQ2MDUwMjI=","url":"https://api.github.com/repos/google/ggrc-core/labels/cla:%20no","name":"cla: no","color":"ededed","default":false},{"id":859293985,"node_id":"MDU6TGFiZWw4NTkyOTM5ODU=","url":"https://api.github.com/repos/google/ggrc-core/labels/important","name":"important","color":"db9ffc","default":false},{"id":352278423,"node_id":"MDU6TGFiZWwzNTIyNzg0MjM=","url":"https://api.github.com/repos/google/ggrc-core/labels/on%20hold","name":"on hold","color":"d93f0b","default":false},{"id":35094741,"node_id":"MDU6TGFiZWwzNTA5NDc0MQ==","url":"https://api.github.com/repos/google/ggrc-core/labels/wrong%20branch","name":"wrong branch","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/10176/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/10176/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/10176/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/e22754820005cde470a268a1c13f9f5e89decfb8","head":{"label":"MaDITIY:GGRC-7955","ref":"GGRC-7955","sha":"e22754820005cde470a268a1c13f9f5e89decfb8","user":{"login":"MaDITIY","id":37157165,"node_id":"MDQ6VXNlcjM3MTU3MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/37157165?v=4","gravatar_id":"","url":"https://api.github.com/users/MaDITIY","html_url":"https://github.com/MaDITIY","followers_url":"https://api.github.com/users/MaDITIY/followers","following_url":"https://api.github.com/users/MaDITIY/following{/other_user}","gists_url":"https://api.github.com/users/MaDITIY/gists{/gist_id}","starred_url":"https://api.github.com/users/MaDITIY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaDITIY/subscriptions","organizations_url":"https://api.github.com/users/MaDITIY/orgs","repos_url":"https://api.github.com/users/MaDITIY/repos","events_url":"https://api.github.com/users/MaDITIY/events{/privacy}","received_events_url":"https://api.github.com/users/MaDITIY/received_events","type":"User","site_admin":false},"repo":{"id":202718119,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI3MTgxMTk=","name":"ggrc-core","full_name":"MaDITIY/ggrc-core","private":false,"owner":{"login":"MaDITIY","id":37157165,"node_id":"MDQ6VXNlcjM3MTU3MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/37157165?v=4","gravatar_id":"","url":"https://api.github.com/users/MaDITIY","html_url":"https://github.com/MaDITIY","followers_url":"https://api.github.com/users/MaDITIY/followers","following_url":"https://api.github.com/users/MaDITIY/following{/other_user}","gists_url":"https://api.github.com/users/MaDITIY/gists{/gist_id}","starred_url":"https://api.github.com/users/MaDITIY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaDITIY/subscriptions","organizations_url":"https://api.github.com/users/MaDITIY/orgs","repos_url":"https://api.github.com/users/MaDITIY/repos","events_url":"https://api.github.com/users/MaDITIY/events{/privacy}","received_events_url":"https://api.github.com/users/MaDITIY/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MaDITIY/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/MaDITIY/ggrc-core","forks_url":"https://api.github.com/repos/MaDITIY/ggrc-core/forks","keys_url":"https://api.github.com/repos/MaDITIY/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaDITIY/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaDITIY/ggrc-core/teams","hooks_url":"https://api.github.com/repos/MaDITIY/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/MaDITIY/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/MaDITIY/ggrc-core/events","assignees_url":"https://api.github.com/repos/MaDITIY/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/MaDITIY/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/MaDITIY/ggrc-core/tags","blobs_url":"https://api.github.com/repos/MaDITIY/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaDITIY/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaDITIY/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaDITIY/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaDITIY/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MaDITIY/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/MaDITIY/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/MaDITIY/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/MaDITIY/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/MaDITIY/ggrc-core/subscription","commits_url":"https://api.github.com/repos/MaDITIY/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaDITIY/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaDITIY/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaDITIY/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaDITIY/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/MaDITIY/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaDITIY/ggrc-core/merges","archive_url":"https://api.github.com/repos/MaDITIY/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaDITIY/ggrc-core/downloads","issues_url":"https://api.github.com/repos/MaDITIY/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/MaDITIY/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MaDITIY/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MaDITIY/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaDITIY/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/MaDITIY/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/MaDITIY/ggrc-core/deployments","created_at":"2019-08-16T11:45:47Z","updated_at":"2019-08-16T11:45:50Z","pushed_at":"2019-10-24T07:42:10Z","git_url":"git://github.com/MaDITIY/ggrc-core.git","ssh_url":"git@github.com:MaDITIY/ggrc-core.git","clone_url":"https://github.com/MaDITIY/ggrc-core.git","svn_url":"https://github.com/MaDITIY/ggrc-core","homepage":null,"size":94022,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"main"}},"base":{"label":"google:dev","ref":"dev","sha":"8bc0d98c01106080b12ebfcac7e0096779f89ee8","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NjM3","name":"ggrc-core","full_name":"google/ggrc-core","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2019-10-23T09:45:20Z","pushed_at":"2019-10-24T09:32:00Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":94268,"stargazers_count":469,"watchers_count":469,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":327,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":327,"open_issues":87,"watchers":469,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10176"},"html":{"href":"https://github.com/google/ggrc-core/pull/10176"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/10176"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/10176/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10176/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/10176/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/e22754820005cde470a268a1c13f9f5e89decfb8"}},"author_association":"NONE"}}
{"actor":{"display_login":"pavelKhat"}}