{"action":"created","comment":{"url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments/281304188","pull_request_review_id":234130925,"id":281304188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTMwNDE4OA==","diff_hunk":"@@ -0,0 +1,232 @@\n+// Basic constants\n+const year = new Date().getFullYear();\n+const urlDopplerLegacy = process.env.REACT_APP_DOPPLER_LEGACY_URL;\n+const urlSite = `https://www.fromdoppler.com`;\n+const urlHelp = `https://help.fromdoppler.com/en/`;\n+\n+// Common URLs\n+const urlPrivacy = `${urlSite}/en/legal/privacy-policy`;\n+const urlContact = `${urlSite}/en/contact.html`;\n+const urlControlPanel = `${urlDopplerLegacy}/ControlPanel`;\n+const urlBuyMonthly = `${urlControlPanel}/AccountPreferences/UpgradeAccount?Plan=monthly`;\n+const urlSiteTracking = `${urlControlPanel}/CampaignsPreferences/SiteTrackingSettings`;\n+\n+// Markdown Links\n+const linkPrivacyAndLegals_MD = `[Privacy and Legal Policy](${urlPrivacy})`;\n+\n+// HTML Links\n+const linkSiteTracking_HTML = `<a href=\"${urlSiteTracking}\">On-Site Tracking</a>`;\n+const linkAddYourDomain_HTML = `<a href=\"${urlSiteTracking}\">Add your domain</a>`;\n+// TODO: confirm if utm parameter goes here\n+const linkPrivacy_HTML = `<a target=\"_blank\" href=\"${urlPrivacy}?utm_source=app&utm_medium=landing&utm_campaign=signup\">Privacy Policy</a>`;\n+const linkBuyMonthly_HTML = `<a href=\"${urlBuyMonthly}\">UPGRADE NOW</a>`;\n+const linkContactUs_HTML = `<a target=\"_blank\" href=\"${urlContact}\">contact us</a>`;","path":"src/i18n/en.js","position":23,"original_position":23,"commit_id":"febf773148ceeea2dde1b43794b165cdb36f1948","original_commit_id":"febf773148ceeea2dde1b43794b165cdb36f1948","user":{"login":"lucianaDilizio","id":10213170,"node_id":"MDQ6VXNlcjEwMjEzMTcw","avatar_url":"https://avatars2.githubusercontent.com/u/10213170?v=4","gravatar_id":"","url":"https://api.github.com/users/lucianaDilizio","html_url":"https://github.com/lucianaDilizio","followers_url":"https://api.github.com/users/lucianaDilizio/followers","following_url":"https://api.github.com/users/lucianaDilizio/following{/other_user}","gists_url":"https://api.github.com/users/lucianaDilizio/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianaDilizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianaDilizio/subscriptions","organizations_url":"https://api.github.com/users/lucianaDilizio/orgs","repos_url":"https://api.github.com/users/lucianaDilizio/repos","events_url":"https://api.github.com/users/lucianaDilizio/events{/privacy}","received_events_url":"https://api.github.com/users/lucianaDilizio/received_events","type":"User","site_admin":false},"body":"I'm not sure if this is a good idea. Maybe the contents could be:\r\n\r\n- To know more please **contact as**.\r\n\r\nor\r\n\r\n- For security reasons we've temporarily disabled your account. **Contact Us**.\r\n\r\nWe should have a variable for each different way of the same text. It could be result el little tedious.","created_at":"2019-05-06T18:32:00Z","updated_at":"2019-05-06T18:32:00Z","html_url":"https://github.com/FromDoppler/doppler-webapp/pull/173#discussion_r281304188","pull_request_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments/281304188"},"html":{"href":"https://github.com/FromDoppler/doppler-webapp/pull/173#discussion_r281304188"},"pull_request":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173","id":276229020,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MjI5MDIw","html_url":"https://github.com/FromDoppler/doppler-webapp/pull/173","diff_url":"https://github.com/FromDoppler/doppler-webapp/pull/173.diff","patch_url":"https://github.com/FromDoppler/doppler-webapp/pull/173.patch","issue_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/173","number":173,"state":"open","locked":false,"title":"Better than json","user":{"login":"andresmoschini","id":1157864,"node_id":"MDQ6VXNlcjExNTc4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1157864?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmoschini","html_url":"https://github.com/andresmoschini","followers_url":"https://api.github.com/users/andresmoschini/followers","following_url":"https://api.github.com/users/andresmoschini/following{/other_user}","gists_url":"https://api.github.com/users/andresmoschini/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmoschini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmoschini/subscriptions","organizations_url":"https://api.github.com/users/andresmoschini/orgs","repos_url":"https://api.github.com/users/andresmoschini/repos","events_url":"https://api.github.com/users/andresmoschini/events{/privacy}","received_events_url":"https://api.github.com/users/andresmoschini/received_events","type":"User","site_admin":false},"body":"Hi Team, \r\n\r\nThis is a polemic PR, but I think that it will be very useful for us to review and understand our content files.\r\n\r\nIt is also useful to avoid pass redundant parameters like year or Doppler base URL.\r\n\r\nI think that reviewing first the [README.md file](https://github.com/FromDoppler/doppler-webapp/pull/173/files?short_path=09f437c#diff-09f437c778eec10fbc446e4550b5d308) is useful. There I try to explain the rationale and guidelines of this approach.\r\n","created_at":"2019-05-06T15:22:37Z","updated_at":"2019-05-06T18:32:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a509322ff11366f1a7eb854fcb628ee17d13018b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173/commits","review_comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173/comments","review_comment_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/173/comments","statuses_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/febf773148ceeea2dde1b43794b165cdb36f1948","head":{"label":"andresmoschini:better-than-json","ref":"better-than-json","sha":"febf773148ceeea2dde1b43794b165cdb36f1948","user":{"login":"andresmoschini","id":1157864,"node_id":"MDQ6VXNlcjExNTc4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1157864?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmoschini","html_url":"https://github.com/andresmoschini","followers_url":"https://api.github.com/users/andresmoschini/followers","following_url":"https://api.github.com/users/andresmoschini/following{/other_user}","gists_url":"https://api.github.com/users/andresmoschini/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmoschini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmoschini/subscriptions","organizations_url":"https://api.github.com/users/andresmoschini/orgs","repos_url":"https://api.github.com/users/andresmoschini/repos","events_url":"https://api.github.com/users/andresmoschini/events{/privacy}","received_events_url":"https://api.github.com/users/andresmoschini/received_events","type":"User","site_admin":false},"repo":{"id":167965213,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5NjUyMTM=","name":"doppler-webapp","full_name":"andresmoschini/doppler-webapp","private":false,"owner":{"login":"andresmoschini","id":1157864,"node_id":"MDQ6VXNlcjExNTc4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1157864?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmoschini","html_url":"https://github.com/andresmoschini","followers_url":"https://api.github.com/users/andresmoschini/followers","following_url":"https://api.github.com/users/andresmoschini/following{/other_user}","gists_url":"https://api.github.com/users/andresmoschini/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmoschini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmoschini/subscriptions","organizations_url":"https://api.github.com/users/andresmoschini/orgs","repos_url":"https://api.github.com/users/andresmoschini/repos","events_url":"https://api.github.com/users/andresmoschini/events{/privacy}","received_events_url":"https://api.github.com/users/andresmoschini/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andresmoschini/doppler-webapp","description":null,"fork":true,"url":"https://api.github.com/repos/andresmoschini/doppler-webapp","forks_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/forks","keys_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/teams","hooks_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/hooks","issue_events_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/events","assignees_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/tags","blobs_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/languages","stargazers_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/stargazers","contributors_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/contributors","subscribers_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/subscribers","subscription_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/subscription","commits_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/merges","archive_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/downloads","issues_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/labels{/name}","releases_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/andresmoschini/doppler-webapp/deployments","created_at":"2019-01-28T13:16:43Z","updated_at":"2019-01-28T13:16:45Z","pushed_at":"2019-05-06T18:24:28Z","git_url":"git://github.com/andresmoschini/doppler-webapp.git","ssh_url":"git@github.com:andresmoschini/doppler-webapp.git","clone_url":"https://github.com/andresmoschini/doppler-webapp.git","svn_url":"https://github.com/andresmoschini/doppler-webapp","homepage":null,"size":1144,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FromDoppler:master","ref":"master","sha":"e3581d25a4d70d606d2bff70d5ca000bd3a699d1","user":{"login":"FromDoppler","id":21225122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjI1MTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21225122?v=4","gravatar_id":"","url":"https://api.github.com/users/FromDoppler","html_url":"https://github.com/FromDoppler","followers_url":"https://api.github.com/users/FromDoppler/followers","following_url":"https://api.github.com/users/FromDoppler/following{/other_user}","gists_url":"https://api.github.com/users/FromDoppler/gists{/gist_id}","starred_url":"https://api.github.com/users/FromDoppler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FromDoppler/subscriptions","organizations_url":"https://api.github.com/users/FromDoppler/orgs","repos_url":"https://api.github.com/users/FromDoppler/repos","events_url":"https://api.github.com/users/FromDoppler/events{/privacy}","received_events_url":"https://api.github.com/users/FromDoppler/received_events","type":"Organization","site_admin":false},"repo":{"id":160403660,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDM2NjA=","name":"doppler-webapp","full_name":"FromDoppler/doppler-webapp","private":false,"owner":{"login":"FromDoppler","id":21225122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjI1MTIy","avatar_url":"https://avatars3.githubusercontent.com/u/21225122?v=4","gravatar_id":"","url":"https://api.github.com/users/FromDoppler","html_url":"https://github.com/FromDoppler","followers_url":"https://api.github.com/users/FromDoppler/followers","following_url":"https://api.github.com/users/FromDoppler/following{/other_user}","gists_url":"https://api.github.com/users/FromDoppler/gists{/gist_id}","starred_url":"https://api.github.com/users/FromDoppler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FromDoppler/subscriptions","organizations_url":"https://api.github.com/users/FromDoppler/orgs","repos_url":"https://api.github.com/users/FromDoppler/repos","events_url":"https://api.github.com/users/FromDoppler/events{/privacy}","received_events_url":"https://api.github.com/users/FromDoppler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FromDoppler/doppler-webapp","description":null,"fork":false,"url":"https://api.github.com/repos/FromDoppler/doppler-webapp","forks_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/forks","keys_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/teams","hooks_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/hooks","issue_events_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/events","assignees_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/tags","blobs_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/languages","stargazers_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/stargazers","contributors_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/contributors","subscribers_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/subscribers","subscription_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/subscription","commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/merges","archive_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/downloads","issues_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/labels{/name}","releases_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/FromDoppler/doppler-webapp/deployments","created_at":"2018-12-04T18:47:26Z","updated_at":"2019-05-06T14:31:09Z","pushed_at":"2019-05-06T18:27:07Z","git_url":"git://github.com/FromDoppler/doppler-webapp.git","ssh_url":"git@github.com:FromDoppler/doppler-webapp.git","clone_url":"https://github.com/FromDoppler/doppler-webapp.git","svn_url":"https://github.com/FromDoppler/doppler-webapp","homepage":null,"size":1091,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":11,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173"},"html":{"href":"https://github.com/FromDoppler/doppler-webapp/pull/173"},"issue":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/173"},"comments":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/FromDoppler/doppler-webapp/statuses/febf773148ceeea2dde1b43794b165cdb36f1948"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lucianaDilizio"}}