{"action":"opened","number":186,"pull_request":{"url":"https://api.github.com/repos/cloudsploit/scans/pulls/186","id":281713233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxNzEzMjMz","html_url":"https://github.com/cloudsploit/scans/pull/186","diff_url":"https://github.com/cloudsploit/scans/pull/186.diff","patch_url":"https://github.com/cloudsploit/scans/pull/186.patch","issue_url":"https://api.github.com/repos/cloudsploit/scans/issues/186","number":186,"state":"open","locked":false,"title":"Fix missing dependencies and refactor to really prevent in the future","user":{"login":"garretfick","id":7982379,"node_id":"MDQ6VXNlcjc5ODIzNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7982379?v=4","gravatar_id":"","url":"https://api.github.com/users/garretfick","html_url":"https://github.com/garretfick","followers_url":"https://api.github.com/users/garretfick/followers","following_url":"https://api.github.com/users/garretfick/following{/other_user}","gists_url":"https://api.github.com/users/garretfick/gists{/gist_id}","starred_url":"https://api.github.com/users/garretfick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garretfick/subscriptions","organizations_url":"https://api.github.com/users/garretfick/orgs","repos_url":"https://api.github.com/users/garretfick/repos","events_url":"https://api.github.com/users/garretfick/events{/privacy}","received_events_url":"https://api.github.com/users/garretfick/received_events","type":"User","site_admin":false},"body":"@matthewdfuller \r\n\r\nA recent commit broke dependencies - @octocat/app is now required, but it is not in package.json.\r\n\r\nThis change adds that dependency and moves some code to a function so that nearly everything is callable from a test. I verified that the test fails if the dependency is not defined, so I'm certain that this will substantially reduce the risk in the future.\r\n\r\nThe moved code has no functional changes - it is just moved so that I can call from a unit test. However, this change is useful for the future so that it's possible to write more comprehensive tests.","created_at":"2019-05-23T17:30:42Z","updated_at":"2019-05-23T17:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudsploit/scans/pulls/186/commits","review_comments_url":"https://api.github.com/repos/cloudsploit/scans/pulls/186/comments","review_comment_url":"https://api.github.com/repos/cloudsploit/scans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudsploit/scans/issues/186/comments","statuses_url":"https://api.github.com/repos/cloudsploit/scans/statuses/664795f64e9240b351c684a9b94b4d6217c19d1f","head":{"label":"garretfick:feature/DEPENDENCIES","ref":"feature/DEPENDENCIES","sha":"664795f64e9240b351c684a9b94b4d6217c19d1f","user":{"login":"garretfick","id":7982379,"node_id":"MDQ6VXNlcjc5ODIzNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7982379?v=4","gravatar_id":"","url":"https://api.github.com/users/garretfick","html_url":"https://github.com/garretfick","followers_url":"https://api.github.com/users/garretfick/followers","following_url":"https://api.github.com/users/garretfick/following{/other_user}","gists_url":"https://api.github.com/users/garretfick/gists{/gist_id}","starred_url":"https://api.github.com/users/garretfick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garretfick/subscriptions","organizations_url":"https://api.github.com/users/garretfick/orgs","repos_url":"https://api.github.com/users/garretfick/repos","events_url":"https://api.github.com/users/garretfick/events{/privacy}","received_events_url":"https://api.github.com/users/garretfick/received_events","type":"User","site_admin":false},"repo":{"id":173761286,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3NjEyODY=","name":"scans","full_name":"garretfick/scans","private":false,"owner":{"login":"garretfick","id":7982379,"node_id":"MDQ6VXNlcjc5ODIzNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7982379?v=4","gravatar_id":"","url":"https://api.github.com/users/garretfick","html_url":"https://github.com/garretfick","followers_url":"https://api.github.com/users/garretfick/followers","following_url":"https://api.github.com/users/garretfick/following{/other_user}","gists_url":"https://api.github.com/users/garretfick/gists{/gist_id}","starred_url":"https://api.github.com/users/garretfick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garretfick/subscriptions","organizations_url":"https://api.github.com/users/garretfick/orgs","repos_url":"https://api.github.com/users/garretfick/repos","events_url":"https://api.github.com/users/garretfick/events{/privacy}","received_events_url":"https://api.github.com/users/garretfick/received_events","type":"User","site_admin":false},"html_url":"https://github.com/garretfick/scans","description":"AWS security scanning checks","fork":true,"url":"https://api.github.com/repos/garretfick/scans","forks_url":"https://api.github.com/repos/garretfick/scans/forks","keys_url":"https://api.github.com/repos/garretfick/scans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garretfick/scans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garretfick/scans/teams","hooks_url":"https://api.github.com/repos/garretfick/scans/hooks","issue_events_url":"https://api.github.com/repos/garretfick/scans/issues/events{/number}","events_url":"https://api.github.com/repos/garretfick/scans/events","assignees_url":"https://api.github.com/repos/garretfick/scans/assignees{/user}","branches_url":"https://api.github.com/repos/garretfick/scans/branches{/branch}","tags_url":"https://api.github.com/repos/garretfick/scans/tags","blobs_url":"https://api.github.com/repos/garretfick/scans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garretfick/scans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garretfick/scans/git/refs{/sha}","trees_url":"https://api.github.com/repos/garretfick/scans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garretfick/scans/statuses/{sha}","languages_url":"https://api.github.com/repos/garretfick/scans/languages","stargazers_url":"https://api.github.com/repos/garretfick/scans/stargazers","contributors_url":"https://api.github.com/repos/garretfick/scans/contributors","subscribers_url":"https://api.github.com/repos/garretfick/scans/subscribers","subscription_url":"https://api.github.com/repos/garretfick/scans/subscription","commits_url":"https://api.github.com/repos/garretfick/scans/commits{/sha}","git_commits_url":"https://api.github.com/repos/garretfick/scans/git/commits{/sha}","comments_url":"https://api.github.com/repos/garretfick/scans/comments{/number}","issue_comment_url":"https://api.github.com/repos/garretfick/scans/issues/comments{/number}","contents_url":"https://api.github.com/repos/garretfick/scans/contents/{+path}","compare_url":"https://api.github.com/repos/garretfick/scans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garretfick/scans/merges","archive_url":"https://api.github.com/repos/garretfick/scans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garretfick/scans/downloads","issues_url":"https://api.github.com/repos/garretfick/scans/issues{/number}","pulls_url":"https://api.github.com/repos/garretfick/scans/pulls{/number}","milestones_url":"https://api.github.com/repos/garretfick/scans/milestones{/number}","notifications_url":"https://api.github.com/repos/garretfick/scans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garretfick/scans/labels{/name}","releases_url":"https://api.github.com/repos/garretfick/scans/releases{/id}","deployments_url":"https://api.github.com/repos/garretfick/scans/deployments","created_at":"2019-03-04T14:34:57Z","updated_at":"2019-05-23T14:26:28Z","pushed_at":"2019-05-23T17:26:55Z","git_url":"git://github.com/garretfick/scans.git","ssh_url":"git@github.com:garretfick/scans.git","clone_url":"https://github.com/garretfick/scans.git","svn_url":"https://github.com/garretfick/scans","homepage":"https://cloudsploit.com","size":1275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudsploit:master","ref":"master","sha":"357a56616cafa3b9b47116fe727bd660289ca128","user":{"login":"cloudsploit","id":12823256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIzMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/12823256?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudsploit","html_url":"https://github.com/cloudsploit","followers_url":"https://api.github.com/users/cloudsploit/followers","following_url":"https://api.github.com/users/cloudsploit/following{/other_user}","gists_url":"https://api.github.com/users/cloudsploit/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsploit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsploit/subscriptions","organizations_url":"https://api.github.com/users/cloudsploit/orgs","repos_url":"https://api.github.com/users/cloudsploit/repos","events_url":"https://api.github.com/users/cloudsploit/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsploit/received_events","type":"Organization","site_admin":false},"repo":{"id":38255391,"node_id":"MDEwOlJlcG9zaXRvcnkzODI1NTM5MQ==","name":"scans","full_name":"cloudsploit/scans","private":false,"owner":{"login":"cloudsploit","id":12823256,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODIzMjU2","avatar_url":"https://avatars1.githubusercontent.com/u/12823256?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudsploit","html_url":"https://github.com/cloudsploit","followers_url":"https://api.github.com/users/cloudsploit/followers","following_url":"https://api.github.com/users/cloudsploit/following{/other_user}","gists_url":"https://api.github.com/users/cloudsploit/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudsploit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudsploit/subscriptions","organizations_url":"https://api.github.com/users/cloudsploit/orgs","repos_url":"https://api.github.com/users/cloudsploit/repos","events_url":"https://api.github.com/users/cloudsploit/events{/privacy}","received_events_url":"https://api.github.com/users/cloudsploit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudsploit/scans","description":"Cloud security configuration checks","fork":false,"url":"https://api.github.com/repos/cloudsploit/scans","forks_url":"https://api.github.com/repos/cloudsploit/scans/forks","keys_url":"https://api.github.com/repos/cloudsploit/scans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudsploit/scans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudsploit/scans/teams","hooks_url":"https://api.github.com/repos/cloudsploit/scans/hooks","issue_events_url":"https://api.github.com/repos/cloudsploit/scans/issues/events{/number}","events_url":"https://api.github.com/repos/cloudsploit/scans/events","assignees_url":"https://api.github.com/repos/cloudsploit/scans/assignees{/user}","branches_url":"https://api.github.com/repos/cloudsploit/scans/branches{/branch}","tags_url":"https://api.github.com/repos/cloudsploit/scans/tags","blobs_url":"https://api.github.com/repos/cloudsploit/scans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudsploit/scans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudsploit/scans/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudsploit/scans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudsploit/scans/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudsploit/scans/languages","stargazers_url":"https://api.github.com/repos/cloudsploit/scans/stargazers","contributors_url":"https://api.github.com/repos/cloudsploit/scans/contributors","subscribers_url":"https://api.github.com/repos/cloudsploit/scans/subscribers","subscription_url":"https://api.github.com/repos/cloudsploit/scans/subscription","commits_url":"https://api.github.com/repos/cloudsploit/scans/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudsploit/scans/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudsploit/scans/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudsploit/scans/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudsploit/scans/contents/{+path}","compare_url":"https://api.github.com/repos/cloudsploit/scans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudsploit/scans/merges","archive_url":"https://api.github.com/repos/cloudsploit/scans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudsploit/scans/downloads","issues_url":"https://api.github.com/repos/cloudsploit/scans/issues{/number}","pulls_url":"https://api.github.com/repos/cloudsploit/scans/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudsploit/scans/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudsploit/scans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudsploit/scans/labels{/name}","releases_url":"https://api.github.com/repos/cloudsploit/scans/releases{/id}","deployments_url":"https://api.github.com/repos/cloudsploit/scans/deployments","created_at":"2015-06-29T15:33:40Z","updated_at":"2019-05-23T12:28:34Z","pushed_at":"2019-05-23T17:27:10Z","git_url":"git://github.com/cloudsploit/scans.git","ssh_url":"git@github.com:cloudsploit/scans.git","clone_url":"https://github.com/cloudsploit/scans.git","svn_url":"https://github.com/cloudsploit/scans","homepage":"https://cloudsploit.com","size":1277,"stargazers_count":739,"watchers_count":739,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":158,"open_issues":36,"watchers":739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudsploit/scans/pulls/186"},"html":{"href":"https://github.com/cloudsploit/scans/pull/186"},"issue":{"href":"https://api.github.com/repos/cloudsploit/scans/issues/186"},"comments":{"href":"https://api.github.com/repos/cloudsploit/scans/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudsploit/scans/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudsploit/scans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudsploit/scans/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/cloudsploit/scans/statuses/664795f64e9240b351c684a9b94b4d6217c19d1f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":396,"deletions":182,"changed_files":5}}
{"actor":{"display_login":"garretfick"}}