{"action":"created","issue":{"url":"https://api.github.com/repos/fastai/course-v3/issues/418","repository_url":"https://api.github.com/repos/fastai/course-v3","labels_url":"https://api.github.com/repos/fastai/course-v3/issues/418/labels{/name}","comments_url":"https://api.github.com/repos/fastai/course-v3/issues/418/comments","events_url":"https://api.github.com/repos/fastai/course-v3/issues/418/events","html_url":"https://github.com/fastai/course-v3/pull/418","id":503551285,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1MzgyMzA3","number":418,"title":"Fix logic in Runner __call__ callback loop","user":{"login":"gnoparus","id":17174860,"node_id":"MDQ6VXNlcjE3MTc0ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/17174860?v=4","gravatar_id":"","url":"https://api.github.com/users/gnoparus","html_url":"https://github.com/gnoparus","followers_url":"https://api.github.com/users/gnoparus/followers","following_url":"https://api.github.com/users/gnoparus/following{/other_user}","gists_url":"https://api.github.com/users/gnoparus/gists{/gist_id}","starred_url":"https://api.github.com/users/gnoparus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnoparus/subscriptions","organizations_url":"https://api.github.com/users/gnoparus/orgs","repos_url":"https://api.github.com/users/gnoparus/repos","events_url":"https://api.github.com/users/gnoparus/events{/privacy}","received_events_url":"https://api.github.com/users/gnoparus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-10-07T16:11:15Z","updated_at":"2019-10-09T19:20:11Z","closed_at":"2019-10-09T19:20:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fastai/course-v3/pulls/418","html_url":"https://github.com/fastai/course-v3/pull/418","diff_url":"https://github.com/fastai/course-v3/pull/418.diff","patch_url":"https://github.com/fastai/course-v3/pull/418.patch"},"body":"The logic is at least one callback return true Runner.\\_\\_call\\_\\_ will return true. But using \"and\" the method will always return False.\r\n\r\n    for cb in sorted(self.cbs, key=lambda x: x._order): res = cb(cb_name) and res\r\n\r\nChange to \"or\" to fix the problem.\r\n\r\n    for cb in sorted(self.cbs, key=lambda x: x._order): res = cb(cb_name) or res"},"comment":{"url":"https://api.github.com/repos/fastai/course-v3/issues/comments/540150130","html_url":"https://github.com/fastai/course-v3/pull/418#issuecomment-540150130","issue_url":"https://api.github.com/repos/fastai/course-v3/issues/418","id":540150130,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDE1MDEzMA==","user":{"login":"gnoparus","id":17174860,"node_id":"MDQ6VXNlcjE3MTc0ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/17174860?v=4","gravatar_id":"","url":"https://api.github.com/users/gnoparus","html_url":"https://github.com/gnoparus","followers_url":"https://api.github.com/users/gnoparus/followers","following_url":"https://api.github.com/users/gnoparus/following{/other_user}","gists_url":"https://api.github.com/users/gnoparus/gists{/gist_id}","starred_url":"https://api.github.com/users/gnoparus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnoparus/subscriptions","organizations_url":"https://api.github.com/users/gnoparus/orgs","repos_url":"https://api.github.com/users/gnoparus/repos","events_url":"https://api.github.com/users/gnoparus/events{/privacy}","received_events_url":"https://api.github.com/users/gnoparus/received_events","type":"User","site_admin":false},"created_at":"2019-10-09T19:20:11Z","updated_at":"2019-10-09T19:20:11Z","author_association":"CONTRIBUTOR","body":"Duplicated with https://github.com/fastai/course-v3/pull/372"}}
{"actor":{"display_login":"gnoparus"}}