{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/302495688","pull_request_review_id":260634140,"id":302495688,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjQ5NTY4OA==","diff_hunk":"@@ -61,6 +61,13 @@ tolerations: {}\n ## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/\n affinity: {}\n \n+## Memcached pod Security Context\n+## ref: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/\n+securityContext:\n+  enabled: true\n+  fsGroup: 11211","path":"stable/memcached/values.yaml","position":8,"original_position":8,"commit_id":"f5ac614eafe8219435b3ee565146d08c540c5ed3","original_commit_id":"f5ac614eafe8219435b3ee565146d08c540c5ed3","user":{"login":"olemarkus","id":77034,"node_id":"MDQ6VXNlcjc3MDM0","avatar_url":"https://avatars0.githubusercontent.com/u/77034?v=4","gravatar_id":"","url":"https://api.github.com/users/olemarkus","html_url":"https://github.com/olemarkus","followers_url":"https://api.github.com/users/olemarkus/followers","following_url":"https://api.github.com/users/olemarkus/following{/other_user}","gists_url":"https://api.github.com/users/olemarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/olemarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olemarkus/subscriptions","organizations_url":"https://api.github.com/users/olemarkus/orgs","repos_url":"https://api.github.com/users/olemarkus/repos","events_url":"https://api.github.com/users/olemarkus/events{/privacy}","received_events_url":"https://api.github.com/users/olemarkus/received_events","type":"User","site_admin":false},"body":"Why these uid/guids? E.g 1001 is a more common value here.","created_at":"2019-07-11T11:34:48Z","updated_at":"2019-07-11T11:34:57Z","html_url":"https://github.com/helm/charts/pull/15317#discussion_r302495688","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/15317","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/302495688"},"html":{"href":"https://github.com/helm/charts/pull/15317#discussion_r302495688"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/15317"}}},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/15317","id":295305338,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1MzA1MzM4","html_url":"https://github.com/helm/charts/pull/15317","diff_url":"https://github.com/helm/charts/pull/15317.diff","patch_url":"https://github.com/helm/charts/pull/15317.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/15317","number":15317,"state":"open","locked":false,"title":"[stable/memcached] Add security context to memcached chart","user":{"login":"JorisAndrade","id":796043,"node_id":"MDQ6VXNlcjc5NjA0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/796043?v=4","gravatar_id":"","url":"https://api.github.com/users/JorisAndrade","html_url":"https://github.com/JorisAndrade","followers_url":"https://api.github.com/users/JorisAndrade/followers","following_url":"https://api.github.com/users/JorisAndrade/following{/other_user}","gists_url":"https://api.github.com/users/JorisAndrade/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisAndrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisAndrade/subscriptions","organizations_url":"https://api.github.com/users/JorisAndrade/orgs","repos_url":"https://api.github.com/users/JorisAndrade/repos","events_url":"https://api.github.com/users/JorisAndrade/events{/privacy}","received_events_url":"https://api.github.com/users/JorisAndrade/received_events","type":"User","site_admin":false},"body":"## What this PR does / why we need it:\r\n\r\nThis PR adds the securityContext option to be able to run this container as non-root. \r\nRight now if you have a PSP in your namespace with \r\n\r\n```\r\n  runAsUser:\r\n    rule: MustRunAsNonRoot\r\n```\r\n\r\nmemcached will fail to start with `Error: container has runAsNonRoot and image has non-numeric user (memcache), cannot verify user is non-root`\r\n\r\n#### Special notes for your reviewer:\r\nThis is my first PR to this repo so feel free to ping me if something is missing!\r\nI'm not sure about the `version` for example, should I bump patch or minor?\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n- [x] Title of the PR starts with chart name (e.g. `[stable/chart]`)\r\n","created_at":"2019-07-08T12:06:13Z","updated_at":"2019-07-11T11:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c158ab2e3375887b1e6aeafa67778ac8e7723c65","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kennethaasan","id":1437394,"node_id":"MDQ6VXNlcjE0MzczOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1437394?v=4","gravatar_id":"","url":"https://api.github.com/users/kennethaasan","html_url":"https://github.com/kennethaasan","followers_url":"https://api.github.com/users/kennethaasan/followers","following_url":"https://api.github.com/users/kennethaasan/following{/other_user}","gists_url":"https://api.github.com/users/kennethaasan/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethaasan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethaasan/subscriptions","organizations_url":"https://api.github.com/users/kennethaasan/orgs","repos_url":"https://api.github.com/users/kennethaasan/repos","events_url":"https://api.github.com/users/kennethaasan/events{/privacy}","received_events_url":"https://api.github.com/users/kennethaasan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":1120334296,"node_id":"MDU6TGFiZWwxMTIwMzM0Mjk2","url":"https://api.github.com/repos/helm/charts/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false},{"id":676477477,"node_id":"MDU6TGFiZWw2NzY0Nzc0Nzc=","url":"https://api.github.com/repos/helm/charts/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/15317/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/15317/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/15317/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/f5ac614eafe8219435b3ee565146d08c540c5ed3","head":{"label":"JorisAndrade:memcached_security_context","ref":"memcached_security_context","sha":"f5ac614eafe8219435b3ee565146d08c540c5ed3","user":{"login":"JorisAndrade","id":796043,"node_id":"MDQ6VXNlcjc5NjA0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/796043?v=4","gravatar_id":"","url":"https://api.github.com/users/JorisAndrade","html_url":"https://github.com/JorisAndrade","followers_url":"https://api.github.com/users/JorisAndrade/followers","following_url":"https://api.github.com/users/JorisAndrade/following{/other_user}","gists_url":"https://api.github.com/users/JorisAndrade/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisAndrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisAndrade/subscriptions","organizations_url":"https://api.github.com/users/JorisAndrade/orgs","repos_url":"https://api.github.com/users/JorisAndrade/repos","events_url":"https://api.github.com/users/JorisAndrade/events{/privacy}","received_events_url":"https://api.github.com/users/JorisAndrade/received_events","type":"User","site_admin":false},"repo":{"id":195796611,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU3OTY2MTE=","name":"charts","full_name":"JorisAndrade/charts","private":false,"owner":{"login":"JorisAndrade","id":796043,"node_id":"MDQ6VXNlcjc5NjA0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/796043?v=4","gravatar_id":"","url":"https://api.github.com/users/JorisAndrade","html_url":"https://github.com/JorisAndrade","followers_url":"https://api.github.com/users/JorisAndrade/followers","following_url":"https://api.github.com/users/JorisAndrade/following{/other_user}","gists_url":"https://api.github.com/users/JorisAndrade/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisAndrade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisAndrade/subscriptions","organizations_url":"https://api.github.com/users/JorisAndrade/orgs","repos_url":"https://api.github.com/users/JorisAndrade/repos","events_url":"https://api.github.com/users/JorisAndrade/events{/privacy}","received_events_url":"https://api.github.com/users/JorisAndrade/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JorisAndrade/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/JorisAndrade/charts","forks_url":"https://api.github.com/repos/JorisAndrade/charts/forks","keys_url":"https://api.github.com/repos/JorisAndrade/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JorisAndrade/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JorisAndrade/charts/teams","hooks_url":"https://api.github.com/repos/JorisAndrade/charts/hooks","issue_events_url":"https://api.github.com/repos/JorisAndrade/charts/issues/events{/number}","events_url":"https://api.github.com/repos/JorisAndrade/charts/events","assignees_url":"https://api.github.com/repos/JorisAndrade/charts/assignees{/user}","branches_url":"https://api.github.com/repos/JorisAndrade/charts/branches{/branch}","tags_url":"https://api.github.com/repos/JorisAndrade/charts/tags","blobs_url":"https://api.github.com/repos/JorisAndrade/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JorisAndrade/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JorisAndrade/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/JorisAndrade/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JorisAndrade/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/JorisAndrade/charts/languages","stargazers_url":"https://api.github.com/repos/JorisAndrade/charts/stargazers","contributors_url":"https://api.github.com/repos/JorisAndrade/charts/contributors","subscribers_url":"https://api.github.com/repos/JorisAndrade/charts/subscribers","subscription_url":"https://api.github.com/repos/JorisAndrade/charts/subscription","commits_url":"https://api.github.com/repos/JorisAndrade/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/JorisAndrade/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/JorisAndrade/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/JorisAndrade/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/JorisAndrade/charts/contents/{+path}","compare_url":"https://api.github.com/repos/JorisAndrade/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JorisAndrade/charts/merges","archive_url":"https://api.github.com/repos/JorisAndrade/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JorisAndrade/charts/downloads","issues_url":"https://api.github.com/repos/JorisAndrade/charts/issues{/number}","pulls_url":"https://api.github.com/repos/JorisAndrade/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/JorisAndrade/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/JorisAndrade/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JorisAndrade/charts/labels{/name}","releases_url":"https://api.github.com/repos/JorisAndrade/charts/releases{/id}","deployments_url":"https://api.github.com/repos/JorisAndrade/charts/deployments","created_at":"2019-07-08T11:15:17Z","updated_at":"2019-07-08T11:15:27Z","pushed_at":"2019-07-08T12:11:32Z","git_url":"git://github.com/JorisAndrade/charts.git","ssh_url":"git@github.com:JorisAndrade/charts.git","clone_url":"https://github.com/JorisAndrade/charts.git","svn_url":"https://github.com/JorisAndrade/charts","homepage":"","size":21371,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"567501aecfce4924ebc092ad64e5b895f8a7bfbe","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2019-07-11T11:21:59Z","pushed_at":"2019-07-11T10:16:56Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":21799,"stargazers_count":9119,"watchers_count":9119,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8943,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":582,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8943,"open_issues":582,"watchers":9119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/15317"},"html":{"href":"https://github.com/helm/charts/pull/15317"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/15317"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/15317/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/15317/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/15317/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/f5ac614eafe8219435b3ee565146d08c540c5ed3"}},"author_association":"NONE"}}
{"actor":{"display_login":"olemarkus"}}