{"action":"created","comment":{"url":"https://api.github.com/repos/uber/NullAway/pulls/comments/267945066","pull_request_review_id":217476687,"id":267945066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Nzk0NTA2Ng==","diff_hunk":"@@ -1233,6 +1233,65 @@ public void OptionalEmptinessHandlerTest() {\n         .doTest();\n   }\n \n+  @Test\n+  public void OptionalEmptinessHandlerWithCustomPathTest() {\n+    compilationHelper\n+        .setArgs(\n+            Arrays.asList(\n+                \"-d\",\n+                temporaryFolder.getRoot().getAbsolutePath(),\n+                \"-XepOpt:NullAway:AnnotatedPackages=com.uber\",\n+                \"-XepOpt:NullAway:UnannotatedSubPackages=com.uber.lib.unannotated\",\n+                \"-XepOpt:NullAway:CheckOptionalEmptiness=true\",\n+                \"-XepOpt:NullAway:OptionalClassPath=com.google.common.base.Optional\"))","path":"nullaway/src/test/java/com/uber/nullaway/NullAwayTest.java","position":null,"original_position":14,"commit_id":"89a416bd5cd23ab2a1694c2e4da5ae6a5525689f","original_commit_id":"c366edeffe6d51f2195742cdf795bb5460ba238b","user":{"login":"shas19","id":14147610,"node_id":"MDQ6VXNlcjE0MTQ3NjEw","avatar_url":"https://avatars1.githubusercontent.com/u/14147610?v=4","gravatar_id":"","url":"https://api.github.com/users/shas19","html_url":"https://github.com/shas19","followers_url":"https://api.github.com/users/shas19/followers","following_url":"https://api.github.com/users/shas19/following{/other_user}","gists_url":"https://api.github.com/users/shas19/gists{/gist_id}","starred_url":"https://api.github.com/users/shas19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shas19/subscriptions","organizations_url":"https://api.github.com/users/shas19/orgs","repos_url":"https://api.github.com/users/shas19/repos","events_url":"https://api.github.com/users/shas19/events{/privacy}","received_events_url":"https://api.github.com/users/shas19/received_events","type":"User","site_admin":false},"body":"Added test for zero, one and two custom paths case.","created_at":"2019-03-21T20:32:37Z","updated_at":"2019-03-21T20:32:37Z","html_url":"https://github.com/uber/NullAway/pull/288#discussion_r267945066","pull_request_url":"https://api.github.com/repos/uber/NullAway/pulls/288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/NullAway/pulls/comments/267945066"},"html":{"href":"https://github.com/uber/NullAway/pull/288#discussion_r267945066"},"pull_request":{"href":"https://api.github.com/repos/uber/NullAway/pulls/288"}},"in_reply_to_id":265705385},"pull_request":{"url":"https://api.github.com/repos/uber/NullAway/pulls/288","id":261061131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxMDYxMTMx","html_url":"https://github.com/uber/NullAway/pull/288","diff_url":"https://github.com/uber/NullAway/pull/288.diff","patch_url":"https://github.com/uber/NullAway/pull/288.patch","issue_url":"https://api.github.com/repos/uber/NullAway/issues/288","number":288,"state":"open","locked":false,"title":"Custom path to Optional class for Optional emptiness handler","user":{"login":"shas19","id":14147610,"node_id":"MDQ6VXNlcjE0MTQ3NjEw","avatar_url":"https://avatars1.githubusercontent.com/u/14147610?v=4","gravatar_id":"","url":"https://api.github.com/users/shas19","html_url":"https://github.com/shas19","followers_url":"https://api.github.com/users/shas19/followers","following_url":"https://api.github.com/users/shas19/following{/other_user}","gists_url":"https://api.github.com/users/shas19/gists{/gist_id}","starred_url":"https://api.github.com/users/shas19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shas19/subscriptions","organizations_url":"https://api.github.com/users/shas19/orgs","repos_url":"https://api.github.com/users/shas19/repos","events_url":"https://api.github.com/users/shas19/events{/privacy}","received_events_url":"https://api.github.com/users/shas19/received_events","type":"User","site_admin":false},"body":"Allowing custom path to the Optional class with `-XepOpt:NullAway:OptionalClassPath=` flag.\r\nThis custom path is used by optional emptiness handler.  \r\n\r\nNo option at all passed in the command line => set is (java.utils.Optional)\r\nExplicit option passed => the classes in that set + `java.utils.Optional`\r\n\r\n Added unit test\r\n","created_at":"2019-03-14T08:04:41Z","updated_at":"2019-03-21T20:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86aaf671b95627b207a1c2e1f72a8b4f087bc90e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/NullAway/pulls/288/commits","review_comments_url":"https://api.github.com/repos/uber/NullAway/pulls/288/comments","review_comment_url":"https://api.github.com/repos/uber/NullAway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/NullAway/issues/288/comments","statuses_url":"https://api.github.com/repos/uber/NullAway/statuses/89a416bd5cd23ab2a1694c2e4da5ae6a5525689f","head":{"label":"shas19:optional_class_path","ref":"optional_class_path","sha":"89a416bd5cd23ab2a1694c2e4da5ae6a5525689f","user":{"login":"shas19","id":14147610,"node_id":"MDQ6VXNlcjE0MTQ3NjEw","avatar_url":"https://avatars1.githubusercontent.com/u/14147610?v=4","gravatar_id":"","url":"https://api.github.com/users/shas19","html_url":"https://github.com/shas19","followers_url":"https://api.github.com/users/shas19/followers","following_url":"https://api.github.com/users/shas19/following{/other_user}","gists_url":"https://api.github.com/users/shas19/gists{/gist_id}","starred_url":"https://api.github.com/users/shas19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shas19/subscriptions","organizations_url":"https://api.github.com/users/shas19/orgs","repos_url":"https://api.github.com/users/shas19/repos","events_url":"https://api.github.com/users/shas19/events{/privacy}","received_events_url":"https://api.github.com/users/shas19/received_events","type":"User","site_admin":false},"repo":{"id":152401666,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0MDE2NjY=","name":"NullAway","full_name":"shas19/NullAway","private":false,"owner":{"login":"shas19","id":14147610,"node_id":"MDQ6VXNlcjE0MTQ3NjEw","avatar_url":"https://avatars1.githubusercontent.com/u/14147610?v=4","gravatar_id":"","url":"https://api.github.com/users/shas19","html_url":"https://github.com/shas19","followers_url":"https://api.github.com/users/shas19/followers","following_url":"https://api.github.com/users/shas19/following{/other_user}","gists_url":"https://api.github.com/users/shas19/gists{/gist_id}","starred_url":"https://api.github.com/users/shas19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shas19/subscriptions","organizations_url":"https://api.github.com/users/shas19/orgs","repos_url":"https://api.github.com/users/shas19/repos","events_url":"https://api.github.com/users/shas19/events{/privacy}","received_events_url":"https://api.github.com/users/shas19/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shas19/NullAway","description":"A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead","fork":true,"url":"https://api.github.com/repos/shas19/NullAway","forks_url":"https://api.github.com/repos/shas19/NullAway/forks","keys_url":"https://api.github.com/repos/shas19/NullAway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shas19/NullAway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shas19/NullAway/teams","hooks_url":"https://api.github.com/repos/shas19/NullAway/hooks","issue_events_url":"https://api.github.com/repos/shas19/NullAway/issues/events{/number}","events_url":"https://api.github.com/repos/shas19/NullAway/events","assignees_url":"https://api.github.com/repos/shas19/NullAway/assignees{/user}","branches_url":"https://api.github.com/repos/shas19/NullAway/branches{/branch}","tags_url":"https://api.github.com/repos/shas19/NullAway/tags","blobs_url":"https://api.github.com/repos/shas19/NullAway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shas19/NullAway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shas19/NullAway/git/refs{/sha}","trees_url":"https://api.github.com/repos/shas19/NullAway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shas19/NullAway/statuses/{sha}","languages_url":"https://api.github.com/repos/shas19/NullAway/languages","stargazers_url":"https://api.github.com/repos/shas19/NullAway/stargazers","contributors_url":"https://api.github.com/repos/shas19/NullAway/contributors","subscribers_url":"https://api.github.com/repos/shas19/NullAway/subscribers","subscription_url":"https://api.github.com/repos/shas19/NullAway/subscription","commits_url":"https://api.github.com/repos/shas19/NullAway/commits{/sha}","git_commits_url":"https://api.github.com/repos/shas19/NullAway/git/commits{/sha}","comments_url":"https://api.github.com/repos/shas19/NullAway/comments{/number}","issue_comment_url":"https://api.github.com/repos/shas19/NullAway/issues/comments{/number}","contents_url":"https://api.github.com/repos/shas19/NullAway/contents/{+path}","compare_url":"https://api.github.com/repos/shas19/NullAway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shas19/NullAway/merges","archive_url":"https://api.github.com/repos/shas19/NullAway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shas19/NullAway/downloads","issues_url":"https://api.github.com/repos/shas19/NullAway/issues{/number}","pulls_url":"https://api.github.com/repos/shas19/NullAway/pulls{/number}","milestones_url":"https://api.github.com/repos/shas19/NullAway/milestones{/number}","notifications_url":"https://api.github.com/repos/shas19/NullAway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shas19/NullAway/labels{/name}","releases_url":"https://api.github.com/repos/shas19/NullAway/releases{/id}","deployments_url":"https://api.github.com/repos/shas19/NullAway/deployments","created_at":"2018-10-10T09:58:16Z","updated_at":"2019-03-09T09:10:04Z","pushed_at":"2019-03-21T20:31:10Z","git_url":"git://github.com/shas19/NullAway.git","ssh_url":"git@github.com:shas19/NullAway.git","clone_url":"https://github.com/shas19/NullAway.git","svn_url":"https://github.com/shas19/NullAway","homepage":"","size":1620,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"0b9cdefff7dc3f3587c9572d6e06336c7251469a","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":102137661,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIxMzc2NjE=","name":"NullAway","full_name":"uber/NullAway","private":false,"owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber/NullAway","description":"A tool to help eliminate NullPointerExceptions (NPEs) in your Java code with low build-time overhead","fork":false,"url":"https://api.github.com/repos/uber/NullAway","forks_url":"https://api.github.com/repos/uber/NullAway/forks","keys_url":"https://api.github.com/repos/uber/NullAway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/NullAway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/NullAway/teams","hooks_url":"https://api.github.com/repos/uber/NullAway/hooks","issue_events_url":"https://api.github.com/repos/uber/NullAway/issues/events{/number}","events_url":"https://api.github.com/repos/uber/NullAway/events","assignees_url":"https://api.github.com/repos/uber/NullAway/assignees{/user}","branches_url":"https://api.github.com/repos/uber/NullAway/branches{/branch}","tags_url":"https://api.github.com/repos/uber/NullAway/tags","blobs_url":"https://api.github.com/repos/uber/NullAway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/NullAway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/NullAway/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/NullAway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/NullAway/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/NullAway/languages","stargazers_url":"https://api.github.com/repos/uber/NullAway/stargazers","contributors_url":"https://api.github.com/repos/uber/NullAway/contributors","subscribers_url":"https://api.github.com/repos/uber/NullAway/subscribers","subscription_url":"https://api.github.com/repos/uber/NullAway/subscription","commits_url":"https://api.github.com/repos/uber/NullAway/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/NullAway/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/NullAway/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/NullAway/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/NullAway/contents/{+path}","compare_url":"https://api.github.com/repos/uber/NullAway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/NullAway/merges","archive_url":"https://api.github.com/repos/uber/NullAway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/NullAway/downloads","issues_url":"https://api.github.com/repos/uber/NullAway/issues{/number}","pulls_url":"https://api.github.com/repos/uber/NullAway/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/NullAway/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/NullAway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/NullAway/labels{/name}","releases_url":"https://api.github.com/repos/uber/NullAway/releases{/id}","deployments_url":"https://api.github.com/repos/uber/NullAway/deployments","created_at":"2017-09-01T17:35:57Z","updated_at":"2019-03-18T02:23:21Z","pushed_at":"2019-03-21T20:31:11Z","git_url":"git://github.com/uber/NullAway.git","ssh_url":"git@github.com:uber/NullAway.git","clone_url":"https://github.com/uber/NullAway.git","svn_url":"https://github.com/uber/NullAway","homepage":"","size":1549,"stargazers_count":2453,"watchers_count":2453,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":177,"open_issues":35,"watchers":2453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/NullAway/pulls/288"},"html":{"href":"https://github.com/uber/NullAway/pull/288"},"issue":{"href":"https://api.github.com/repos/uber/NullAway/issues/288"},"comments":{"href":"https://api.github.com/repos/uber/NullAway/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/NullAway/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/NullAway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/NullAway/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/uber/NullAway/statuses/89a416bd5cd23ab2a1694c2e4da5ae6a5525689f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shas19"}}