{"action":"created","comment":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/comments/275137866","pull_request_review_id":226375239,"id":275137866,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTEzNzg2Ng==","diff_hunk":"@@ -111,4 +111,29 @@ def test_parse_with_keep_time_key_without_time_format(data)\n       assert_equal text, record['time']\n     end\n   end\n+\n+  data('yajl' => 'yajl')\n+  def test_yajl_parse_io_with_buffer_smaller_than_input(data)","path":"test/plugin/test_parser_json.rb","position":6,"original_position":6,"commit_id":"e6ef4918556bb946c7330d330f02503437cc6adb","original_commit_id":"e6ef4918556bb946c7330d330f02503437cc6adb","user":{"login":"benwh","id":701323,"node_id":"MDQ6VXNlcjcwMTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/701323?v=4","gravatar_id":"","url":"https://api.github.com/users/benwh","html_url":"https://github.com/benwh","followers_url":"https://api.github.com/users/benwh/followers","following_url":"https://api.github.com/users/benwh/following{/other_user}","gists_url":"https://api.github.com/users/benwh/gists{/gist_id}","starred_url":"https://api.github.com/users/benwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwh/subscriptions","organizations_url":"https://api.github.com/users/benwh/orgs","repos_url":"https://api.github.com/users/benwh/repos","events_url":"https://api.github.com/users/benwh/events{/privacy}","received_events_url":"https://api.github.com/users/benwh/received_events","type":"User","site_admin":false},"body":"I was considering adding a test case for the inverse of this (input smaller than buffer) but didn't do this because it seemed like it would be quite awkward to implement - due to needing to assert on the parser *not* emitting an event - and probably not provide much value.\r\nHappy to reconsider this if anyone has a suggestion on how this could be done neatly though!","created_at":"2019-04-14T01:53:04Z","updated_at":"2019-04-14T01:53:13Z","html_url":"https://github.com/fluent/fluentd/pull/2381#discussion_r275137866","pull_request_url":"https://api.github.com/repos/fluent/fluentd/pulls/2381","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments/275137866"},"html":{"href":"https://github.com/fluent/fluentd/pull/2381#discussion_r275137866"},"pull_request":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/2381"}}},"pull_request":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/2381","id":270264063,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMjY0MDYz","html_url":"https://github.com/fluent/fluentd/pull/2381","diff_url":"https://github.com/fluent/fluentd/pull/2381.diff","patch_url":"https://github.com/fluent/fluentd/pull/2381.patch","issue_url":"https://api.github.com/repos/fluent/fluentd/issues/2381","number":2381,"state":"open","locked":false,"title":"parser_json: Add stream_buffer_size config param","user":{"login":"benwh","id":701323,"node_id":"MDQ6VXNlcjcwMTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/701323?v=4","gravatar_id":"","url":"https://api.github.com/users/benwh","html_url":"https://github.com/benwh","followers_url":"https://api.github.com/users/benwh/followers","following_url":"https://api.github.com/users/benwh/following{/other_user}","gists_url":"https://api.github.com/users/benwh/gists{/gist_id}","starred_url":"https://api.github.com/users/benwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwh/subscriptions","organizations_url":"https://api.github.com/users/benwh/orgs","repos_url":"https://api.github.com/users/benwh/repos","events_url":"https://api.github.com/users/benwh/events{/privacy}","received_events_url":"https://api.github.com/users/benwh/received_events","type":"User","site_admin":false},"body":"**Which issue(s) this PR fixes**: \r\nFixes #609 \r\n\r\n**What this PR does / why we need it**: \r\nAllow configuration of the size of the buffer that Yajl uses when parsing streaming input.\r\n\r\nThe advantage of this is that when using `out_exec_filter`, and parsing\r\nas JSON, it's now possible to configure this plugin to avoid having to\r\nwait for 8092 bytes of data to be parsed before events are emitted.\r\n\r\n**Docs Changes**: fluent/fluentd-docs#631\r\n\r\n**Release Note**: \r\nUse PR title.","created_at":"2019-04-14T01:06:16Z","updated_at":"2019-04-14T01:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a7104232668bcd96b3aea128b3a78e1b94af90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fluent/fluentd/pulls/2381/commits","review_comments_url":"https://api.github.com/repos/fluent/fluentd/pulls/2381/comments","review_comment_url":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluent/fluentd/issues/2381/comments","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/e6ef4918556bb946c7330d330f02503437cc6adb","head":{"label":"benwh:configurable-json-stream-buffer","ref":"configurable-json-stream-buffer","sha":"e6ef4918556bb946c7330d330f02503437cc6adb","user":{"login":"benwh","id":701323,"node_id":"MDQ6VXNlcjcwMTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/701323?v=4","gravatar_id":"","url":"https://api.github.com/users/benwh","html_url":"https://github.com/benwh","followers_url":"https://api.github.com/users/benwh/followers","following_url":"https://api.github.com/users/benwh/following{/other_user}","gists_url":"https://api.github.com/users/benwh/gists{/gist_id}","starred_url":"https://api.github.com/users/benwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwh/subscriptions","organizations_url":"https://api.github.com/users/benwh/orgs","repos_url":"https://api.github.com/users/benwh/repos","events_url":"https://api.github.com/users/benwh/events{/privacy}","received_events_url":"https://api.github.com/users/benwh/received_events","type":"User","site_admin":false},"repo":{"id":181224478,"node_id":"MDEwOlJlcG9zaXRvcnkxODEyMjQ0Nzg=","name":"fluentd","full_name":"benwh/fluentd","private":false,"owner":{"login":"benwh","id":701323,"node_id":"MDQ6VXNlcjcwMTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/701323?v=4","gravatar_id":"","url":"https://api.github.com/users/benwh","html_url":"https://github.com/benwh","followers_url":"https://api.github.com/users/benwh/followers","following_url":"https://api.github.com/users/benwh/following{/other_user}","gists_url":"https://api.github.com/users/benwh/gists{/gist_id}","starred_url":"https://api.github.com/users/benwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwh/subscriptions","organizations_url":"https://api.github.com/users/benwh/orgs","repos_url":"https://api.github.com/users/benwh/repos","events_url":"https://api.github.com/users/benwh/events{/privacy}","received_events_url":"https://api.github.com/users/benwh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/benwh/fluentd","description":"Fluentd: Unified Logging Layer (project under CNCF)","fork":true,"url":"https://api.github.com/repos/benwh/fluentd","forks_url":"https://api.github.com/repos/benwh/fluentd/forks","keys_url":"https://api.github.com/repos/benwh/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benwh/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benwh/fluentd/teams","hooks_url":"https://api.github.com/repos/benwh/fluentd/hooks","issue_events_url":"https://api.github.com/repos/benwh/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/benwh/fluentd/events","assignees_url":"https://api.github.com/repos/benwh/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/benwh/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/benwh/fluentd/tags","blobs_url":"https://api.github.com/repos/benwh/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benwh/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benwh/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/benwh/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benwh/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/benwh/fluentd/languages","stargazers_url":"https://api.github.com/repos/benwh/fluentd/stargazers","contributors_url":"https://api.github.com/repos/benwh/fluentd/contributors","subscribers_url":"https://api.github.com/repos/benwh/fluentd/subscribers","subscription_url":"https://api.github.com/repos/benwh/fluentd/subscription","commits_url":"https://api.github.com/repos/benwh/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/benwh/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/benwh/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/benwh/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/benwh/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/benwh/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benwh/fluentd/merges","archive_url":"https://api.github.com/repos/benwh/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benwh/fluentd/downloads","issues_url":"https://api.github.com/repos/benwh/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/benwh/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/benwh/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/benwh/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benwh/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/benwh/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/benwh/fluentd/deployments","created_at":"2019-04-13T20:20:14Z","updated_at":"2019-04-13T20:20:17Z","pushed_at":"2019-04-14T01:01:27Z","git_url":"git://github.com/benwh/fluentd.git","ssh_url":"git@github.com:benwh/fluentd.git","clone_url":"https://github.com/benwh/fluentd.git","svn_url":"https://github.com/benwh/fluentd","homepage":"https://www.fluentd.org/","size":16064,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluent:master","ref":"master","sha":"fe59adc0ebbb39b50a2365cfd1aa9b5944b0eea7","user":{"login":"fluent","id":859518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/859518?v=4","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":1918677,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE4Njc3","name":"fluentd","full_name":"fluent/fluentd","private":false,"owner":{"login":"fluent","id":859518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTUxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/859518?v=4","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fluent/fluentd","description":"Fluentd: Unified Logging Layer (project under CNCF)","fork":false,"url":"https://api.github.com/repos/fluent/fluentd","forks_url":"https://api.github.com/repos/fluent/fluentd/forks","keys_url":"https://api.github.com/repos/fluent/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd/events","assignees_url":"https://api.github.com/repos/fluent/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluent/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd/merges","archive_url":"https://api.github.com/repos/fluent/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/fluent/fluentd/deployments","created_at":"2011-06-19T08:41:40Z","updated_at":"2019-04-14T01:49:35Z","pushed_at":"2019-04-14T01:06:17Z","git_url":"git://github.com/fluent/fluentd.git","ssh_url":"git@github.com:fluent/fluentd.git","clone_url":"https://github.com/fluent/fluentd.git","svn_url":"https://github.com/fluent/fluentd","homepage":"https://www.fluentd.org/","size":16064,"stargazers_count":7666,"watchers_count":7666,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":897,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":209,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":897,"open_issues":209,"watchers":7666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/2381"},"html":{"href":"https://github.com/fluent/fluentd/pull/2381"},"issue":{"href":"https://api.github.com/repos/fluent/fluentd/issues/2381"},"comments":{"href":"https://api.github.com/repos/fluent/fluentd/issues/2381/comments"},"review_comments":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/2381/comments"},"review_comment":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/2381/commits"},"statuses":{"href":"https://api.github.com/repos/fluent/fluentd/statuses/e6ef4918556bb946c7330d330f02503437cc6adb"}},"author_association":"NONE"}}
{"actor":{"display_login":"benwh"}}