{"action":"created","comment":{"url":"https://api.github.com/repos/pulumi/pulumi/pulls/comments/293038748","pull_request_review_id":248918675,"id":293038748,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzAzODc0OA==","diff_hunk":"@@ -31,13 +32,17 @@ type Analyzer interface {\n \t// Name fetches an analyzer's qualified name.\n \tName() tokens.QName\n \t// Analyze analyzes a single resource object, and returns any errors that it finds.\n-\tAnalyze(t tokens.Type, props resource.PropertyMap) ([]AnalyzeFailure, error)\n+\tAnalyze(t tokens.Type, props resource.PropertyMap) ([]AnalyzeDiagnostic, error)","path":"pkg/resource/plugin/analyzer.go","position":13,"original_position":13,"commit_id":"6b82daa455a399184181258581b66768a536a823","original_commit_id":"6b82daa455a399184181258581b66768a536a823","user":{"login":"hausdorff","id":1409156,"node_id":"MDQ6VXNlcjE0MDkxNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1409156?v=4","gravatar_id":"","url":"https://api.github.com/users/hausdorff","html_url":"https://github.com/hausdorff","followers_url":"https://api.github.com/users/hausdorff/followers","following_url":"https://api.github.com/users/hausdorff/following{/other_user}","gists_url":"https://api.github.com/users/hausdorff/gists{/gist_id}","starred_url":"https://api.github.com/users/hausdorff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hausdorff/subscriptions","organizations_url":"https://api.github.com/users/hausdorff/orgs","repos_url":"https://api.github.com/users/hausdorff/repos","events_url":"https://api.github.com/users/hausdorff/events{/privacy}","received_events_url":"https://api.github.com/users/hausdorff/received_events","type":"User","site_admin":false},"body":"I'm not super enthusiastic about the little type conversion dance we do here. We did it to stay consistent with how we're handling other events, converting `*pulumirpc.AnalyzeDiagnostic` -> `AnalyzeDiagnostic` -> `AnalyzePayload`. This is way more complex than it seems like it needs to be.","created_at":"2019-06-12T17:45:41Z","updated_at":"2019-06-12T17:45:48Z","html_url":"https://github.com/pulumi/pulumi/pull/2772#discussion_r293038748","pull_request_url":"https://api.github.com/repos/pulumi/pulumi/pulls/2772","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pulumi/pulumi/pulls/comments/293038748"},"html":{"href":"https://github.com/pulumi/pulumi/pull/2772#discussion_r293038748"},"pull_request":{"href":"https://api.github.com/repos/pulumi/pulumi/pulls/2772"}}},"pull_request":{"url":"https://api.github.com/repos/pulumi/pulumi/pulls/2772","id":282101331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMTAxMzMx","html_url":"https://github.com/pulumi/pulumi/pull/2772","diff_url":"https://github.com/pulumi/pulumi/pull/2772.diff","patch_url":"https://github.com/pulumi/pulumi/pull/2772.patch","issue_url":"https://api.github.com/repos/pulumi/pulumi/issues/2772","number":2772,"state":"open","locked":false,"title":"Update Analyzer protocol to reflect policy-as-code plan","user":{"login":"hausdorff","id":1409156,"node_id":"MDQ6VXNlcjE0MDkxNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1409156?v=4","gravatar_id":"","url":"https://api.github.com/users/hausdorff","html_url":"https://github.com/hausdorff","followers_url":"https://api.github.com/users/hausdorff/followers","following_url":"https://api.github.com/users/hausdorff/following{/other_user}","gists_url":"https://api.github.com/users/hausdorff/gists{/gist_id}","starred_url":"https://api.github.com/users/hausdorff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hausdorff/subscriptions","organizations_url":"https://api.github.com/users/hausdorff/orgs","repos_url":"https://api.github.com/users/hausdorff/repos","events_url":"https://api.github.com/users/hausdorff/events{/privacy}","received_events_url":"https://api.github.com/users/hausdorff/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-24T17:36:17Z","updated_at":"2019-06-12T17:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e25f689abfd89e242a99d500c902662c61222c11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1224839734,"node_id":"MDU6TGFiZWwxMjI0ODM5NzM0","url":"https://api.github.com/repos/pulumi/pulumi/labels/impact/no-changelog-required","name":"impact/no-changelog-required","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pulumi/pulumi/pulls/2772/commits","review_comments_url":"https://api.github.com/repos/pulumi/pulumi/pulls/2772/comments","review_comment_url":"https://api.github.com/repos/pulumi/pulumi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulumi/pulumi/issues/2772/comments","statuses_url":"https://api.github.com/repos/pulumi/pulumi/statuses/6b82daa455a399184181258581b66768a536a823","head":{"label":"pulumi:hausdorff/analyzers","ref":"hausdorff/analyzers","sha":"6b82daa455a399184181258581b66768a536a823","user":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"repo":{"id":72477752,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3Nzc1Mg==","name":"pulumi","full_name":"pulumi/pulumi","private":false,"owner":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pulumi/pulumi","description":"Define cloud apps and infrastructure in your favorite language and deploy to any cloud","fork":false,"url":"https://api.github.com/repos/pulumi/pulumi","forks_url":"https://api.github.com/repos/pulumi/pulumi/forks","keys_url":"https://api.github.com/repos/pulumi/pulumi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulumi/pulumi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulumi/pulumi/teams","hooks_url":"https://api.github.com/repos/pulumi/pulumi/hooks","issue_events_url":"https://api.github.com/repos/pulumi/pulumi/issues/events{/number}","events_url":"https://api.github.com/repos/pulumi/pulumi/events","assignees_url":"https://api.github.com/repos/pulumi/pulumi/assignees{/user}","branches_url":"https://api.github.com/repos/pulumi/pulumi/branches{/branch}","tags_url":"https://api.github.com/repos/pulumi/pulumi/tags","blobs_url":"https://api.github.com/repos/pulumi/pulumi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulumi/pulumi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulumi/pulumi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulumi/pulumi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulumi/pulumi/statuses/{sha}","languages_url":"https://api.github.com/repos/pulumi/pulumi/languages","stargazers_url":"https://api.github.com/repos/pulumi/pulumi/stargazers","contributors_url":"https://api.github.com/repos/pulumi/pulumi/contributors","subscribers_url":"https://api.github.com/repos/pulumi/pulumi/subscribers","subscription_url":"https://api.github.com/repos/pulumi/pulumi/subscription","commits_url":"https://api.github.com/repos/pulumi/pulumi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulumi/pulumi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulumi/pulumi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulumi/pulumi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulumi/pulumi/contents/{+path}","compare_url":"https://api.github.com/repos/pulumi/pulumi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulumi/pulumi/merges","archive_url":"https://api.github.com/repos/pulumi/pulumi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulumi/pulumi/downloads","issues_url":"https://api.github.com/repos/pulumi/pulumi/issues{/number}","pulls_url":"https://api.github.com/repos/pulumi/pulumi/pulls{/number}","milestones_url":"https://api.github.com/repos/pulumi/pulumi/milestones{/number}","notifications_url":"https://api.github.com/repos/pulumi/pulumi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulumi/pulumi/labels{/name}","releases_url":"https://api.github.com/repos/pulumi/pulumi/releases{/id}","deployments_url":"https://api.github.com/repos/pulumi/pulumi/deployments","created_at":"2016-10-31T21:02:47Z","updated_at":"2019-06-12T16:58:56Z","pushed_at":"2019-06-12T17:31:54Z","git_url":"git://github.com/pulumi/pulumi.git","ssh_url":"git@github.com:pulumi/pulumi.git","clone_url":"https://github.com/pulumi/pulumi.git","svn_url":"https://github.com/pulumi/pulumi","homepage":"https://pulumi.io","size":21480,"stargazers_count":2888,"watchers_count":2888,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":126,"open_issues":321,"watchers":2888,"default_branch":"master"}},"base":{"label":"pulumi:master","ref":"master","sha":"54cbda80c19b499387b07ad7a8856817c3e19c29","user":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"repo":{"id":72477752,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3Nzc1Mg==","name":"pulumi","full_name":"pulumi/pulumi","private":false,"owner":{"login":"pulumi","id":21992475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTkyNDc1","avatar_url":"https://avatars0.githubusercontent.com/u/21992475?v=4","gravatar_id":"","url":"https://api.github.com/users/pulumi","html_url":"https://github.com/pulumi","followers_url":"https://api.github.com/users/pulumi/followers","following_url":"https://api.github.com/users/pulumi/following{/other_user}","gists_url":"https://api.github.com/users/pulumi/gists{/gist_id}","starred_url":"https://api.github.com/users/pulumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulumi/subscriptions","organizations_url":"https://api.github.com/users/pulumi/orgs","repos_url":"https://api.github.com/users/pulumi/repos","events_url":"https://api.github.com/users/pulumi/events{/privacy}","received_events_url":"https://api.github.com/users/pulumi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pulumi/pulumi","description":"Define cloud apps and infrastructure in your favorite language and deploy to any cloud","fork":false,"url":"https://api.github.com/repos/pulumi/pulumi","forks_url":"https://api.github.com/repos/pulumi/pulumi/forks","keys_url":"https://api.github.com/repos/pulumi/pulumi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulumi/pulumi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulumi/pulumi/teams","hooks_url":"https://api.github.com/repos/pulumi/pulumi/hooks","issue_events_url":"https://api.github.com/repos/pulumi/pulumi/issues/events{/number}","events_url":"https://api.github.com/repos/pulumi/pulumi/events","assignees_url":"https://api.github.com/repos/pulumi/pulumi/assignees{/user}","branches_url":"https://api.github.com/repos/pulumi/pulumi/branches{/branch}","tags_url":"https://api.github.com/repos/pulumi/pulumi/tags","blobs_url":"https://api.github.com/repos/pulumi/pulumi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulumi/pulumi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulumi/pulumi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulumi/pulumi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulumi/pulumi/statuses/{sha}","languages_url":"https://api.github.com/repos/pulumi/pulumi/languages","stargazers_url":"https://api.github.com/repos/pulumi/pulumi/stargazers","contributors_url":"https://api.github.com/repos/pulumi/pulumi/contributors","subscribers_url":"https://api.github.com/repos/pulumi/pulumi/subscribers","subscription_url":"https://api.github.com/repos/pulumi/pulumi/subscription","commits_url":"https://api.github.com/repos/pulumi/pulumi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulumi/pulumi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulumi/pulumi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulumi/pulumi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulumi/pulumi/contents/{+path}","compare_url":"https://api.github.com/repos/pulumi/pulumi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulumi/pulumi/merges","archive_url":"https://api.github.com/repos/pulumi/pulumi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulumi/pulumi/downloads","issues_url":"https://api.github.com/repos/pulumi/pulumi/issues{/number}","pulls_url":"https://api.github.com/repos/pulumi/pulumi/pulls{/number}","milestones_url":"https://api.github.com/repos/pulumi/pulumi/milestones{/number}","notifications_url":"https://api.github.com/repos/pulumi/pulumi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulumi/pulumi/labels{/name}","releases_url":"https://api.github.com/repos/pulumi/pulumi/releases{/id}","deployments_url":"https://api.github.com/repos/pulumi/pulumi/deployments","created_at":"2016-10-31T21:02:47Z","updated_at":"2019-06-12T16:58:56Z","pushed_at":"2019-06-12T17:31:54Z","git_url":"git://github.com/pulumi/pulumi.git","ssh_url":"git@github.com:pulumi/pulumi.git","clone_url":"https://github.com/pulumi/pulumi.git","svn_url":"https://github.com/pulumi/pulumi","homepage":"https://pulumi.io","size":21480,"stargazers_count":2888,"watchers_count":2888,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":126,"open_issues":321,"watchers":2888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulumi/pulumi/pulls/2772"},"html":{"href":"https://github.com/pulumi/pulumi/pull/2772"},"issue":{"href":"https://api.github.com/repos/pulumi/pulumi/issues/2772"},"comments":{"href":"https://api.github.com/repos/pulumi/pulumi/issues/2772/comments"},"review_comments":{"href":"https://api.github.com/repos/pulumi/pulumi/pulls/2772/comments"},"review_comment":{"href":"https://api.github.com/repos/pulumi/pulumi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulumi/pulumi/pulls/2772/commits"},"statuses":{"href":"https://api.github.com/repos/pulumi/pulumi/statuses/6b82daa455a399184181258581b66768a536a823"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hausdorff"}}