{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/comments/333306835","pull_request_review_id":299789797,"id":333306835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMzMwNjgzNQ==","diff_hunk":"@@ -172,31 +173,32 @@ def conesearch(center, radius, verb=1, catalog_db=None, pedantic=None,\n         websites referenced by the database still needs internet\n         connection.\n \n-    timeout : number or `None`\n-        Timeout limit in seconds for each service being queries.\n-        If `None`, use default.\n-\n     query_all : bool\n         This is used by :func:`search_all`.\n \n+    return_astropy_table : bool\n+        Returned ``obj`` will be `astropy.table.Table` rather\n+        than `astropy.io.votable.tree.Table`.\n+\n+    use_names_over_ids : bool\n+        When `True` use the ``name`` attributes of columns as the names\n+        of columns in the `~astropy.table.Table` instance.  Since names\n+        are not guaranteed to be unique, this may cause some columns\n+        to be renamed by appending numbers to the end.  Otherwise\n+        (default), use the ID attributes as the column names.\n+\n     Returns\n     -------\n-    obj : `astropy.io.votable.tree.Table`\n+    obj : `astropy.table.Table` or `astropy.io.votable.tree.Table`\n         First table from first successful VO service request.\n+        See ``return_astropy_table`` option for the kind of table returned.","path":"astroquery/vo_conesearch/conesearch.py","position":113,"original_position":113,"commit_id":"89a73ad89948020344d24633094073e744f727fa","original_commit_id":"89a73ad89948020344d24633094073e744f727fa","user":{"login":"bsipocz","id":6788290,"node_id":"MDQ6VXNlcjY3ODgyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n        See ``return_astropy_table`` parameter for the kind of table returned.\r\n```","created_at":"2019-10-10T02:27:56Z","updated_at":"2019-10-10T02:33:55Z","html_url":"https://github.com/astropy/astroquery/pull/1528#discussion_r333306835","pull_request_url":"https://api.github.com/repos/astropy/astroquery/pulls/1528","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments/333306835"},"html":{"href":"https://github.com/astropy/astroquery/pull/1528#discussion_r333306835"},"pull_request":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1528"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/1528","id":305764730,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NzY0NzMw","html_url":"https://github.com/astropy/astroquery/pull/1528","diff_url":"https://github.com/astropy/astroquery/pull/1528.diff","patch_url":"https://github.com/astropy/astroquery/pull/1528.patch","issue_url":"https://api.github.com/repos/astropy/astroquery/issues/1528","number":1528,"state":"open","locked":false,"title":"vo_conesearch API changes","user":{"login":"pllim","id":2090236,"node_id":"MDQ6VXNlcjIwOTAyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"body":"**Please milestone this only for a major release: Contains non-backward compatible API changes!**\r\n\r\n**TODO**\r\n\r\n- [x] Add change logs.\r\n\r\nFix #1523\r\n- [x] Code implementation\r\n- [x] Fixed tests\r\n- [x] Documentation update\r\n\r\nFix #1522 \r\n- [x] Code implementation\r\n- [x] Fixed tests\r\n- [x] Documentation update\r\n\r\nFix #1048 (also see https://github.com/adamginsburg/astroquery-paper/pull/31#issuecomment-367045801)\r\n- [x] Code implementation\r\n- [x] Fixed tests\r\n- [x] Documentation update\r\n\r\ncc @bsipocz and @keflavich ","created_at":"2019-08-08T21:59:08Z","updated_at":"2019-10-10T02:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd7fb8b36d56611b678d00deb3606a14b6be499","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1370850899,"node_id":"MDU6TGFiZWwxMzcwODUwODk5","url":"https://api.github.com/repos/astropy/astroquery/labels/refactor","name":"refactor","color":"d7e102","default":false},{"id":563432478,"node_id":"MDU6TGFiZWw1NjM0MzI0Nzg=","url":"https://api.github.com/repos/astropy/astroquery/labels/vo_conesearch","name":"vo_conesearch","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astroquery/milestones/21","html_url":"https://github.com/astropy/astroquery/milestone/21","labels_url":"https://api.github.com/repos/astropy/astroquery/milestones/21/labels","id":4323365,"node_id":"MDk6TWlsZXN0b25lNDMyMzM2NQ==","number":21,"title":"0.4","description":"","creator":{"login":"bsipocz","id":6788290,"node_id":"MDQ6VXNlcjY3ODgyOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":10,"state":"open","created_at":"2019-05-17T04:44:00Z","updated_at":"2019-10-10T02:18:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astroquery/pulls/1528/commits","review_comments_url":"https://api.github.com/repos/astropy/astroquery/pulls/1528/comments","review_comment_url":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astroquery/issues/1528/comments","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/89a73ad89948020344d24633094073e744f727fa","head":{"label":"pllim:vo-no-results-warn","ref":"vo-no-results-warn","sha":"89a73ad89948020344d24633094073e744f727fa","user":{"login":"pllim","id":2090236,"node_id":"MDQ6VXNlcjIwOTAyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"repo":{"id":83360541,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM2MDU0MQ==","name":"astroquery","full_name":"pllim/astroquery","private":false,"owner":{"login":"pllim","id":2090236,"node_id":"MDQ6VXNlcjIwOTAyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2090236?v=4","gravatar_id":"","url":"https://api.github.com/users/pllim","html_url":"https://github.com/pllim","followers_url":"https://api.github.com/users/pllim/followers","following_url":"https://api.github.com/users/pllim/following{/other_user}","gists_url":"https://api.github.com/users/pllim/gists{/gist_id}","starred_url":"https://api.github.com/users/pllim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pllim/subscriptions","organizations_url":"https://api.github.com/users/pllim/orgs","repos_url":"https://api.github.com/users/pllim/repos","events_url":"https://api.github.com/users/pllim/events{/privacy}","received_events_url":"https://api.github.com/users/pllim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pllim/astroquery","description":"Functions and classes to access online data resources. Maintainer: @keflavich and @bsipocz","fork":true,"url":"https://api.github.com/repos/pllim/astroquery","forks_url":"https://api.github.com/repos/pllim/astroquery/forks","keys_url":"https://api.github.com/repos/pllim/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pllim/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pllim/astroquery/teams","hooks_url":"https://api.github.com/repos/pllim/astroquery/hooks","issue_events_url":"https://api.github.com/repos/pllim/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/pllim/astroquery/events","assignees_url":"https://api.github.com/repos/pllim/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/pllim/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/pllim/astroquery/tags","blobs_url":"https://api.github.com/repos/pllim/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pllim/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pllim/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/pllim/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pllim/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/pllim/astroquery/languages","stargazers_url":"https://api.github.com/repos/pllim/astroquery/stargazers","contributors_url":"https://api.github.com/repos/pllim/astroquery/contributors","subscribers_url":"https://api.github.com/repos/pllim/astroquery/subscribers","subscription_url":"https://api.github.com/repos/pllim/astroquery/subscription","commits_url":"https://api.github.com/repos/pllim/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/pllim/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/pllim/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/pllim/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/pllim/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/pllim/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pllim/astroquery/merges","archive_url":"https://api.github.com/repos/pllim/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pllim/astroquery/downloads","issues_url":"https://api.github.com/repos/pllim/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/pllim/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/pllim/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/pllim/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pllim/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/pllim/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/pllim/astroquery/deployments","created_at":"2017-02-27T21:50:36Z","updated_at":"2019-05-01T03:23:54Z","pushed_at":"2019-10-10T01:24:08Z","git_url":"git://github.com/pllim/astroquery.git","ssh_url":"git@github.com:pllim/astroquery.git","clone_url":"https://github.com/pllim/astroquery.git","svn_url":"https://github.com/pllim/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":62572,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"fca99451f036115a781b3f8f48f31b6249dc07cf","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":4787269,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg3MjY5","name":"astroquery","full_name":"astropy/astroquery","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":false,"url":"https://api.github.com/repos/astropy/astroquery","forks_url":"https://api.github.com/repos/astropy/astroquery/forks","keys_url":"https://api.github.com/repos/astropy/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astroquery/teams","hooks_url":"https://api.github.com/repos/astropy/astroquery/hooks","issue_events_url":"https://api.github.com/repos/astropy/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astroquery/events","assignees_url":"https://api.github.com/repos/astropy/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astroquery/tags","blobs_url":"https://api.github.com/repos/astropy/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astroquery/languages","stargazers_url":"https://api.github.com/repos/astropy/astroquery/stargazers","contributors_url":"https://api.github.com/repos/astropy/astroquery/contributors","subscribers_url":"https://api.github.com/repos/astropy/astroquery/subscribers","subscription_url":"https://api.github.com/repos/astropy/astroquery/subscription","commits_url":"https://api.github.com/repos/astropy/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astroquery/merges","archive_url":"https://api.github.com/repos/astropy/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astroquery/downloads","issues_url":"https://api.github.com/repos/astropy/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astroquery/deployments","created_at":"2012-06-25T20:52:07Z","updated_at":"2019-10-10T00:10:41Z","pushed_at":"2019-10-10T01:25:01Z","git_url":"git://github.com/astropy/astroquery.git","ssh_url":"git@github.com:astropy/astroquery.git","clone_url":"https://github.com/astropy/astroquery.git","svn_url":"https://github.com/astropy/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":62958,"stargazers_count":245,"watchers_count":245,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":212,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":298,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":212,"open_issues":298,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1528"},"html":{"href":"https://github.com/astropy/astroquery/pull/1528"},"issue":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1528"},"comments":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1528/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1528/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1528/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astroquery/statuses/89a73ad89948020344d24633094073e744f727fa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bsipocz"}}