{"action":"created","comment":{"url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/comments/357099935","pull_request_review_id":331171414,"id":357099935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzA5OTkzNQ==","diff_hunk":"@@ -0,0 +1,44 @@\n+/**\n+ * OWASP Enterprise Security API (ESAPI)\n+ * \n+ * This file is part of the Open Web Application Security Project (OWASP)\n+ * Enterprise Security API (ESAPI) project. For details, please see\n+ * <a href=\"http://www.owasp.org/index.php/ESAPI\">http://www.owasp.org/index.php/ESAPI</a>.\n+ *\n+ * Copyright (c) 2007 - The OWASP Foundation\n+ * \n+ * The ESAPI is published by OWASP under the BSD license. You should read and accept the\n+ * LICENSE before you use, modify, and/or redistribute this software.\n+ * \n+ * @created 2018","path":"src/main/java/org/owasp/esapi/logging/java/JavaLogBridge.java","position":13,"original_position":13,"commit_id":"2d895849c35ededc119b9a425f8a671a832f8489","original_commit_id":"2d895849c35ededc119b9a425f8a671a832f8489","user":{"login":"jeremiahjstacey","id":16555944,"node_id":"MDQ6VXNlcjE2NTU1OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16555944?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiahjstacey","html_url":"https://github.com/jeremiahjstacey","followers_url":"https://api.github.com/users/jeremiahjstacey/followers","following_url":"https://api.github.com/users/jeremiahjstacey/following{/other_user}","gists_url":"https://api.github.com/users/jeremiahjstacey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiahjstacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiahjstacey/subscriptions","organizations_url":"https://api.github.com/users/jeremiahjstacey/orgs","repos_url":"https://api.github.com/users/jeremiahjstacey/repos","events_url":"https://api.github.com/users/jeremiahjstacey/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiahjstacey/received_events","type":"User","site_admin":false},"body":"Multiple files have this issue. ","created_at":"2019-12-12T11:42:46Z","updated_at":"2019-12-12T11:42:46Z","html_url":"https://github.com/ESAPI/esapi-java-legacy/pull/533#discussion_r357099935","pull_request_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/comments/357099935"},"html":{"href":"https://github.com/ESAPI/esapi-java-legacy/pull/533#discussion_r357099935"},"pull_request":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533"}},"in_reply_to_id":357090077},"pull_request":{"url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533","id":351684019,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNjg0MDE5","html_url":"https://github.com/ESAPI/esapi-java-legacy/pull/533","diff_url":"https://github.com/ESAPI/esapi-java-legacy/pull/533.diff","patch_url":"https://github.com/ESAPI/esapi-java-legacy/pull/533.patch","issue_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/533","number":533,"state":"open","locked":false,"title":"#532 JUL and Log4J match SLF4J class structure and Workflow","user":{"login":"jeremiahjstacey","id":16555944,"node_id":"MDQ6VXNlcjE2NTU1OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16555944?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiahjstacey","html_url":"https://github.com/jeremiahjstacey","followers_url":"https://api.github.com/users/jeremiahjstacey/followers","following_url":"https://api.github.com/users/jeremiahjstacey/following{/other_user}","gists_url":"https://api.github.com/users/jeremiahjstacey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiahjstacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiahjstacey/subscriptions","organizations_url":"https://api.github.com/users/jeremiahjstacey/orgs","repos_url":"https://api.github.com/users/jeremiahjstacey/repos","events_url":"https://api.github.com/users/jeremiahjstacey/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiahjstacey/received_events","type":"User","site_admin":false},"body":"@kwwall  @xeno6696  - I've run through the updates in test scope by updating test/resources/ESAPI.properties to toggle between the loggers.\r\n- JUL will output to the console/terminal at this point\r\n- Log4J will write to target/unit-tests.log\r\n\r\nSo far as I can tell, everything appears working.\r\n\r\nI did not create tests for the Log4JLoggerFactory (SPI) yet.   I will take a crack at that in the next few days, but I wanted to get the bulk of changes in front of you sooner rather than later. \r\n\r\nI did mark all of the Log4J support classes as Deprecated. \r\n\r\nAll of the Log4J references I could find have been updated to the new paths.\r\n\r\nThanks for the feedback!  (I'll also be going through this content this week)","created_at":"2019-12-11T01:40:14Z","updated_at":"2019-12-12T11:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66005debe2f27d498fbb6b9e6c5f44f0d5bb4912","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533/commits","review_comments_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533/comments","review_comment_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/533/comments","statuses_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/statuses/2d895849c35ededc119b9a425f8a671a832f8489","head":{"label":"jeremiahjstacey:Logger_Consistency","ref":"Logger_Consistency","sha":"2d895849c35ededc119b9a425f8a671a832f8489","user":{"login":"jeremiahjstacey","id":16555944,"node_id":"MDQ6VXNlcjE2NTU1OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16555944?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiahjstacey","html_url":"https://github.com/jeremiahjstacey","followers_url":"https://api.github.com/users/jeremiahjstacey/followers","following_url":"https://api.github.com/users/jeremiahjstacey/following{/other_user}","gists_url":"https://api.github.com/users/jeremiahjstacey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiahjstacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiahjstacey/subscriptions","organizations_url":"https://api.github.com/users/jeremiahjstacey/orgs","repos_url":"https://api.github.com/users/jeremiahjstacey/repos","events_url":"https://api.github.com/users/jeremiahjstacey/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiahjstacey/received_events","type":"User","site_admin":false},"repo":{"id":137679866,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc2Nzk4NjY=","name":"esapi-java-legacy-dev","full_name":"jeremiahjstacey/esapi-java-legacy-dev","private":false,"owner":{"login":"jeremiahjstacey","id":16555944,"node_id":"MDQ6VXNlcjE2NTU1OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16555944?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremiahjstacey","html_url":"https://github.com/jeremiahjstacey","followers_url":"https://api.github.com/users/jeremiahjstacey/followers","following_url":"https://api.github.com/users/jeremiahjstacey/following{/other_user}","gists_url":"https://api.github.com/users/jeremiahjstacey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremiahjstacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremiahjstacey/subscriptions","organizations_url":"https://api.github.com/users/jeremiahjstacey/orgs","repos_url":"https://api.github.com/users/jeremiahjstacey/repos","events_url":"https://api.github.com/users/jeremiahjstacey/events{/privacy}","received_events_url":"https://api.github.com/users/jeremiahjstacey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeremiahjstacey/esapi-java-legacy-dev","description":"ESAPI (The OWASP Enterprise Security API) is a free, open source, web application security control library that makes it easier for programmers to write lower-risk applications.","fork":true,"url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev","forks_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/forks","keys_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/teams","hooks_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/hooks","issue_events_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/issues/events{/number}","events_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/events","assignees_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/assignees{/user}","branches_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/branches{/branch}","tags_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/tags","blobs_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/languages","stargazers_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/stargazers","contributors_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/contributors","subscribers_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/subscribers","subscription_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/subscription","commits_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/contents/{+path}","compare_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/merges","archive_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/downloads","issues_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/issues{/number}","pulls_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/labels{/name}","releases_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/releases{/id}","deployments_url":"https://api.github.com/repos/jeremiahjstacey/esapi-java-legacy-dev/deployments","created_at":"2018-06-17T19:09:37Z","updated_at":"2019-12-10T09:11:01Z","pushed_at":"2019-12-11T01:13:58Z","git_url":"git://github.com/jeremiahjstacey/esapi-java-legacy-dev.git","ssh_url":"git@github.com:jeremiahjstacey/esapi-java-legacy-dev.git","clone_url":"https://github.com/jeremiahjstacey/esapi-java-legacy-dev.git","svn_url":"https://github.com/jeremiahjstacey/esapi-java-legacy-dev","homepage":"https://www.owasp.org/index.php/Category:OWASP_Enterprise_Security_API","size":38290,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ESAPI:develop","ref":"develop","sha":"ddfa6ce8de58920cde63eca10f51e57a1fd61e32","user":{"login":"ESAPI","id":5580725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODA3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/5580725?v=4","gravatar_id":"","url":"https://api.github.com/users/ESAPI","html_url":"https://github.com/ESAPI","followers_url":"https://api.github.com/users/ESAPI/followers","following_url":"https://api.github.com/users/ESAPI/following{/other_user}","gists_url":"https://api.github.com/users/ESAPI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESAPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESAPI/subscriptions","organizations_url":"https://api.github.com/users/ESAPI/orgs","repos_url":"https://api.github.com/users/ESAPI/repos","events_url":"https://api.github.com/users/ESAPI/events{/privacy}","received_events_url":"https://api.github.com/users/ESAPI/received_events","type":"Organization","site_admin":false},"repo":{"id":23857463,"node_id":"MDEwOlJlcG9zaXRvcnkyMzg1NzQ2Mw==","name":"esapi-java-legacy","full_name":"ESAPI/esapi-java-legacy","private":false,"owner":{"login":"ESAPI","id":5580725,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1ODA3MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/5580725?v=4","gravatar_id":"","url":"https://api.github.com/users/ESAPI","html_url":"https://github.com/ESAPI","followers_url":"https://api.github.com/users/ESAPI/followers","following_url":"https://api.github.com/users/ESAPI/following{/other_user}","gists_url":"https://api.github.com/users/ESAPI/gists{/gist_id}","starred_url":"https://api.github.com/users/ESAPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESAPI/subscriptions","organizations_url":"https://api.github.com/users/ESAPI/orgs","repos_url":"https://api.github.com/users/ESAPI/repos","events_url":"https://api.github.com/users/ESAPI/events{/privacy}","received_events_url":"https://api.github.com/users/ESAPI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ESAPI/esapi-java-legacy","description":"ESAPI (The OWASP Enterprise Security API) is a free, open source, web application security control library that makes it easier for programmers to write lower-risk applications.","fork":false,"url":"https://api.github.com/repos/ESAPI/esapi-java-legacy","forks_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/forks","keys_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/teams","hooks_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/hooks","issue_events_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/events","assignees_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/tags","blobs_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/languages","stargazers_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/stargazers","contributors_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/contributors","subscribers_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/subscribers","subscription_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/subscription","commits_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/merges","archive_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/downloads","issues_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/labels{/name}","releases_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/ESAPI/esapi-java-legacy/deployments","created_at":"2014-09-10T02:12:29Z","updated_at":"2019-12-06T10:09:52Z","pushed_at":"2019-12-11T01:40:15Z","git_url":"git://github.com/ESAPI/esapi-java-legacy.git","ssh_url":"git@github.com:ESAPI/esapi-java-legacy.git","clone_url":"https://github.com/ESAPI/esapi-java-legacy.git","svn_url":"https://github.com/ESAPI/esapi-java-legacy","homepage":"https://www.owasp.org/index.php/Category:OWASP_Enterprise_Security_API","size":48164,"stargazers_count":348,"watchers_count":348,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":105,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":230,"open_issues":105,"watchers":348,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533"},"html":{"href":"https://github.com/ESAPI/esapi-java-legacy/pull/533"},"issue":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/533"},"comments":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/ESAPI/esapi-java-legacy/statuses/2d895849c35ededc119b9a425f8a671a832f8489"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jeremiahjstacey"}}