{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/299794951","pull_request_review_id":257282369,"id":299794951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTc5NDk1MQ==","diff_hunk":"@@ -1614,19 +1597,19 @@ public function removeShowFieldDescription($name): void\n         unset($this->showFieldDescriptions[$name]);\n     }\n \n-    public function getListFieldDescriptions()\n+    public function getListFieldDescriptions(): array\n     {\n         $this->buildList();\n \n         return $this->listFieldDescriptions;\n     }\n \n-    public function getListFieldDescription($name)\n+    public function getListFieldDescription($name): FieldDescriptionInterface\n     {\n         return $this->hasListFieldDescription($name) ? $this->listFieldDescriptions[$name] : null;\n     }\n \n-    public function hasListFieldDescription($name)\n+    public function hasListFieldDescription($name): bool","path":"src/Admin/AbstractAdmin.php","position":530,"original_position":530,"commit_id":"b1d3d00971e2a0f1f6206772ca82f499e65f82b2","original_commit_id":"b1d3d00971e2a0f1f6206772ca82f499e65f82b2","user":{"login":"core23","id":3440437,"node_id":"MDQ6VXNlcjM0NDA0Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    public function hasListFieldDescription(string $name): bool\r\n```","created_at":"2019-07-03T06:32:56Z","updated_at":"2019-07-03T06:32:56Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5613#discussion_r299794951","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/299794951"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/5613#discussion_r299794951"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613","id":293433618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNDMzNjE4","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5613","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5613.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/5613.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5613","number":5613,"state":"open","locked":false,"title":"Narrow API","user":{"login":"phansys","id":1231441,"node_id":"MDQ6VXNlcjEyMzE0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1231441?v=4","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n## Subject\r\n\r\n<!-- Describe your Pull Request content here -->\r\nNarrow API by using explicit type declarations.\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataAdminBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targeting this branch, because these changes could break BC, although these cases aren't valid.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n    This will end up on https://github.com/sonata-project/SonataAdminBundle/releases,\r\n    please keep it short and clear and to the point\r\n-->\r\n\r\n<!-- \r\n    If you are updating something that doesn't require\r\n    a release, you can delete the whole Changelog section.\r\n    (eg. update to docs, tests)\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Added\r\n- Added explicit return declarations in methods were they are missing and the return type was declared with docblocks.\r\n```\r\n\r\n## To do\r\n    \r\n- [ ] Check missing occurrences;\r\n- [ ] Try to remove before the methods that should not be present on 4.0 (maybe another PR for that will be the better choice);\r\n- [ ] Check if is possible to perform similar update for method arguments;\r\n- [ ] Validate if getters can throw exceptions (like [`FormInterface::get()`](https://github.com/symfony/symfony/blob/288bc24d0362fe87c4eb5c67f89d08f9b93e5807/src/Symfony/Component/Form/Form.php#L932-L939)) instead of returning `null` for nonexistent values (by instance, `DatagridInterface::getFilter($name)`).","created_at":"2019-07-01T17:33:34Z","updated_at":"2019-07-03T06:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"224b64fcab8ab1c2d2701f1d6b15a7cf0a808292","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":25889442,"node_id":"MDU6TGFiZWwyNTg4OTQ0Mg==","url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels/major","name":"major","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5613/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/b1d3d00971e2a0f1f6206772ca82f499e65f82b2","head":{"label":"phansys:narrow_api","ref":"narrow_api","sha":"b1d3d00971e2a0f1f6206772ca82f499e65f82b2","user":{"login":"phansys","id":1231441,"node_id":"MDQ6VXNlcjEyMzE0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1231441?v=4","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"repo":{"id":5166310,"node_id":"MDEwOlJlcG9zaXRvcnk1MTY2MzEw","name":"SonataAdminBundle","full_name":"phansys/SonataAdminBundle","private":false,"owner":{"login":"phansys","id":1231441,"node_id":"MDQ6VXNlcjEyMzE0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1231441?v=4","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phansys/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/phansys/SonataAdminBundle","forks_url":"https://api.github.com/repos/phansys/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/phansys/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phansys/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phansys/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/phansys/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/phansys/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/phansys/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/phansys/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/phansys/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/phansys/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/phansys/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phansys/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phansys/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/phansys/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phansys/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/phansys/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/phansys/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/phansys/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/phansys/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/phansys/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/phansys/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/phansys/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/phansys/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/phansys/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/phansys/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/phansys/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phansys/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/phansys/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phansys/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/phansys/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/phansys/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/phansys/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/phansys/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phansys/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/phansys/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/phansys/SonataAdminBundle/deployments","created_at":"2012-07-24T14:07:50Z","updated_at":"2014-06-04T10:18:27Z","pushed_at":"2019-07-03T02:03:47Z","git_url":"git://github.com/phansys/SonataAdminBundle.git","ssh_url":"git@github.com:phansys/SonataAdminBundle.git","clone_url":"https://github.com/phansys/SonataAdminBundle.git","svn_url":"https://github.com/phansys/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":23439,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"3.x"}},"base":{"label":"sonata-project:master","ref":"master","sha":"b7655d5094a82a9af0ac7888d326895e8b904045","user":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk1MjI4","name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","private":false,"owner":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2019-07-03T04:34:15Z","pushed_at":"2019-07-03T04:34:07Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"https://sonata-project.org/","size":23273,"stargazers_count":1848,"watchers_count":1848,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1196,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":268,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1196,"open_issues":268,"watchers":1848,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/5613"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5613"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/5613/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/5613/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/b1d3d00971e2a0f1f6206772ca82f499e65f82b2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"core23"}}