{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments/302290626","pull_request_review_id":260380042,"id":302290626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjI5MDYyNg==","diff_hunk":"@@ -140,13 +140,13 @@ export default class SystemUsersDropdown extends React.PureComponent {\n     handleShowDeactivateMemberModal = async (e) => {\n         e.preventDefault();\n         if (this.shouldDisableBotsWhenOwnerIsDeactivated()) {\n-            const {data} = await this.props.actions.loadBots(\n+            await this.props.actions.loadBots(\n                 Constants.Integrations.START_PAGE_NUM,\n-                Constants.Integrations.PAGE_SIZE\n+                Constants.Integrations.PAGE_SIZE,\n             );\n-            if (data) {\n-                this.setState({loading: false, showDeactivateMemberModal: true});\n-            }\n+            this.setState({showDeactivateMemberModal: true});\n+        } else {","path":"components/admin_console/system_users/system_users_dropdown/system_users_dropdown.jsx","position":14,"original_position":14,"commit_id":"e6b46fd6d4373476d5773c6bea106606a1162e46","original_commit_id":"e6b46fd6d4373476d5773c6bea106606a1162e46","user":{"login":"sudheerDev","id":4973621,"node_id":"MDQ6VXNlcjQ5NzM2MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4973621?v=4","gravatar_id":"","url":"https://api.github.com/users/sudheerDev","html_url":"https://github.com/sudheerDev","followers_url":"https://api.github.com/users/sudheerDev/followers","following_url":"https://api.github.com/users/sudheerDev/following{/other_user}","gists_url":"https://api.github.com/users/sudheerDev/gists{/gist_id}","starred_url":"https://api.github.com/users/sudheerDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudheerDev/subscriptions","organizations_url":"https://api.github.com/users/sudheerDev/orgs","repos_url":"https://api.github.com/users/sudheerDev/repos","events_url":"https://api.github.com/users/sudheerDev/events{/privacy}","received_events_url":"https://api.github.com/users/sudheerDev/received_events","type":"User","site_admin":false},"body":"Looks like we could do this at the end of if condition as if and else has the same `this.setState({showDeactivateMemberModal: true});` check\r\n\r\n","created_at":"2019-07-10T22:01:04Z","updated_at":"2019-07-10T22:01:04Z","html_url":"https://github.com/mattermost/mattermost-webapp/pull/3094#discussion_r302290626","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments/302290626"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/3094#discussion_r302290626"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094","id":296362837,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MzYyODM3","html_url":"https://github.com/mattermost/mattermost-webapp/pull/3094","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/3094.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/3094.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/3094","number":3094,"state":"open","locked":false,"title":"[MM-16533] User deactivation does not work when \"Disable bot accounts when owner is deactivated\" is set to False","user":{"login":"cpoile","id":1490756,"node_id":"MDQ6VXNlcjE0OTA3NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1490756?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoile","html_url":"https://github.com/cpoile","followers_url":"https://api.github.com/users/cpoile/followers","following_url":"https://api.github.com/users/cpoile/following{/other_user}","gists_url":"https://api.github.com/users/cpoile/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoile/subscriptions","organizations_url":"https://api.github.com/users/cpoile/orgs","repos_url":"https://api.github.com/users/cpoile/repos","events_url":"https://api.github.com/users/cpoile/events{/privacy}","received_events_url":"https://api.github.com/users/cpoile/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n- Should always display `deactivateMemberModal`, no matter what `DisableBotsWhenOwnerIsDeactivated` is set to.\r\n- Fixed another possible bug -- if there was no data returned from a redux action (or no bots?), the `deactivateMemberModal` wouldn't have opened. There's no reason (that I can see) to make that conditional on the returned data.\r\n- Not sure why the community member introduced the `loading` state variable -- it isn't used in the rest of the file. @sudheerDev?\r\n\r\n#### Ticket Link\r\n- Fixes [MM-16533](https://mattermost.atlassian.net/browse/MM-16533)\r\n\r\n#### Related Pull Requests\r\n#2879 ","created_at":"2019-07-10T21:52:34Z","updated_at":"2019-07-10T22:01:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0804b4988bd38a6d0eb599758feb73d4b3ccdbe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"crspeller","id":3191642,"node_id":"MDQ6VXNlcjMxOTE2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3191642?v=4","gravatar_id":"","url":"https://api.github.com/users/crspeller","html_url":"https://github.com/crspeller","followers_url":"https://api.github.com/users/crspeller/followers","following_url":"https://api.github.com/users/crspeller/following{/other_user}","gists_url":"https://api.github.com/users/crspeller/gists{/gist_id}","starred_url":"https://api.github.com/users/crspeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crspeller/subscriptions","organizations_url":"https://api.github.com/users/crspeller/orgs","repos_url":"https://api.github.com/users/crspeller/repos","events_url":"https://api.github.com/users/crspeller/events{/privacy}","received_events_url":"https://api.github.com/users/crspeller/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":685999255,"node_id":"MDU6TGFiZWw2ODU5OTkyNTU=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false},{"id":1080233157,"node_id":"MDU6TGFiZWwxMDgwMjMzMTU3","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/CherryPick/Candidate","name":"CherryPick/Candidate","color":"efe11a","default":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones/25","html_url":"https://github.com/mattermost/mattermost-webapp/milestone/25","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones/25/labels","id":4323294,"node_id":"MDk6TWlsZXN0b25lNDMyMzI5NA==","number":25,"title":"v5.13.0","description":"","creator":{"login":"hanzei","id":16541325,"node_id":"MDQ6VXNlcjE2NTQxMzI1","avatar_url":"https://avatars0.githubusercontent.com/u/16541325?v=4","gravatar_id":"","url":"https://api.github.com/users/hanzei","html_url":"https://github.com/hanzei","followers_url":"https://api.github.com/users/hanzei/followers","following_url":"https://api.github.com/users/hanzei/following{/other_user}","gists_url":"https://api.github.com/users/hanzei/gists{/gist_id}","starred_url":"https://api.github.com/users/hanzei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanzei/subscriptions","organizations_url":"https://api.github.com/users/hanzei/orgs","repos_url":"https://api.github.com/users/hanzei/repos","events_url":"https://api.github.com/users/hanzei/events{/privacy}","received_events_url":"https://api.github.com/users/hanzei/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":33,"state":"open","created_at":"2019-05-17T03:15:32Z","updated_at":"2019-07-10T21:56:38Z","due_on":"2019-07-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/3094/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/e6b46fd6d4373476d5773c6bea106606a1162e46","head":{"label":"cpoile:MM-16533-user-deactivation-broken","ref":"MM-16533-user-deactivation-broken","sha":"e6b46fd6d4373476d5773c6bea106606a1162e46","user":{"login":"cpoile","id":1490756,"node_id":"MDQ6VXNlcjE0OTA3NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1490756?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoile","html_url":"https://github.com/cpoile","followers_url":"https://api.github.com/users/cpoile/followers","following_url":"https://api.github.com/users/cpoile/following{/other_user}","gists_url":"https://api.github.com/users/cpoile/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoile/subscriptions","organizations_url":"https://api.github.com/users/cpoile/orgs","repos_url":"https://api.github.com/users/cpoile/repos","events_url":"https://api.github.com/users/cpoile/events{/privacy}","received_events_url":"https://api.github.com/users/cpoile/received_events","type":"User","site_admin":false},"repo":{"id":171541912,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE1NDE5MTI=","name":"mattermost-webapp","full_name":"cpoile/mattermost-webapp","private":false,"owner":{"login":"cpoile","id":1490756,"node_id":"MDQ6VXNlcjE0OTA3NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1490756?v=4","gravatar_id":"","url":"https://api.github.com/users/cpoile","html_url":"https://github.com/cpoile","followers_url":"https://api.github.com/users/cpoile/followers","following_url":"https://api.github.com/users/cpoile/following{/other_user}","gists_url":"https://api.github.com/users/cpoile/gists{/gist_id}","starred_url":"https://api.github.com/users/cpoile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpoile/subscriptions","organizations_url":"https://api.github.com/users/cpoile/orgs","repos_url":"https://api.github.com/users/cpoile/repos","events_url":"https://api.github.com/users/cpoile/events{/privacy}","received_events_url":"https://api.github.com/users/cpoile/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cpoile/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":true,"url":"https://api.github.com/repos/cpoile/mattermost-webapp","forks_url":"https://api.github.com/repos/cpoile/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/cpoile/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpoile/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpoile/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/cpoile/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/cpoile/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/cpoile/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/cpoile/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/cpoile/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/cpoile/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/cpoile/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpoile/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpoile/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpoile/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpoile/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/cpoile/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/cpoile/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/cpoile/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/cpoile/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/cpoile/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/cpoile/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpoile/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpoile/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpoile/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpoile/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/cpoile/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpoile/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/cpoile/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpoile/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/cpoile/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/cpoile/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/cpoile/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/cpoile/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpoile/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/cpoile/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/cpoile/mattermost-webapp/deployments","created_at":"2019-02-19T20:10:25Z","updated_at":"2019-02-19T20:10:33Z","pushed_at":"2019-07-10T21:53:24Z","git_url":"git://github.com/cpoile/mattermost-webapp.git","ssh_url":"git@github.com:cpoile/mattermost-webapp.git","clone_url":"https://github.com/cpoile/mattermost-webapp.git","svn_url":"https://github.com/cpoile/mattermost-webapp","homepage":null,"size":123152,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"b32f03d524ee39f7f2fcbf56388aa5ac8707d9e4","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":102689445,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2ODk0NDU=","name":"mattermost-webapp","full_name":"mattermost/mattermost-webapp","private":false,"owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mattermost/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-webapp","forks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/deployments","created_at":"2017-09-07T04:00:02Z","updated_at":"2019-07-10T12:25:51Z","pushed_at":"2019-07-10T21:56:39Z","git_url":"git://github.com/mattermost/mattermost-webapp.git","ssh_url":"git@github.com:mattermost/mattermost-webapp.git","clone_url":"https://github.com/mattermost/mattermost-webapp.git","svn_url":"https://github.com/mattermost/mattermost-webapp","homepage":null,"size":137316,"stargazers_count":485,"watchers_count":485,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":936,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":936,"open_issues":45,"watchers":485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/3094"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/3094"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/3094/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/3094/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/e6b46fd6d4373476d5773c6bea106606a1162e46"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sudheerDev"}}