{"action":"opened","number":95,"pull_request":{"url":"https://api.github.com/repos/rubyforgood/coral/pulls/95","id":328786533,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4Nzg2NTMz","html_url":"https://github.com/rubyforgood/coral/pull/95","diff_url":"https://github.com/rubyforgood/coral/pull/95.diff","patch_url":"https://github.com/rubyforgood/coral/pull/95.patch","issue_url":"https://api.github.com/repos/rubyforgood/coral/issues/95","number":95,"state":"open","locked":false,"title":"start use ffaker and refact some tests","user":{"login":"gabrielbaldao","id":20587352,"node_id":"MDQ6VXNlcjIwNTg3MzUy","avatar_url":"https://avatars0.githubusercontent.com/u/20587352?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielbaldao","html_url":"https://github.com/gabrielbaldao","followers_url":"https://api.github.com/users/gabrielbaldao/followers","following_url":"https://api.github.com/users/gabrielbaldao/following{/other_user}","gists_url":"https://api.github.com/users/gabrielbaldao/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielbaldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielbaldao/subscriptions","organizations_url":"https://api.github.com/users/gabrielbaldao/orgs","repos_url":"https://api.github.com/users/gabrielbaldao/repos","events_url":"https://api.github.com/users/gabrielbaldao/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielbaldao/received_events","type":"User","site_admin":false},"body":"<!--Read comments, before commiting pull request read checklist again\r\n\r\n# Checklist:\r\n\r\n- I have performed a self-review of my own code,\r\n- I have commented my code, particularly in hard-to-understand areas,\r\n- I have made corresponding changes to the documentation,\r\n- I have added tests that prove my fix is effective or that my feature works,\r\n- New and existing unit tests pass locally with my changes (\"bundle exec rake\"),\r\n- Title include \"WIP\" if work is in progress.\r\n\r\n-->\r\n\r\nResolves #001 <!--fill issue number-->\r\n\r\n### Description\r\n<!-- Please include a summary of the change and which issue is fixed. \r\nPlease also include relevant motivation and context.\r\nGuide questions:\r\n  - What motivated this change (if not already described in an issue)?\r\n  - What alternative solutions did you consider?\r\n  - What are the tradeoffs for your solution?\r\n   \r\nList any dependencies that are required for this change. (gems, js libraries, etc.)\r\n\r\nInclude anything else we should know about. -->\r\nI'm trying improve the tests in this project with [best pratices](http://www.betterspecs.org/), we can improve together and write more tests.\r\n### Type of change\r\n\r\n<!-- Please delete options that are not relevant. -->\r\n\r\n* Breaking change (fix or feature that would cause existing functionality to not \r\nwork as expected)\r\n\r\n\r\n\r\n","created_at":"2019-10-16T14:18:45Z","updated_at":"2019-10-16T14:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubyforgood/coral/pulls/95/commits","review_comments_url":"https://api.github.com/repos/rubyforgood/coral/pulls/95/comments","review_comment_url":"https://api.github.com/repos/rubyforgood/coral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyforgood/coral/issues/95/comments","statuses_url":"https://api.github.com/repos/rubyforgood/coral/statuses/6c3444d1c0388b263d2eea16d134a652a7616fbf","head":{"label":"gabrielbaldao:start-use-ffaker-and-refact-some-tests","ref":"start-use-ffaker-and-refact-some-tests","sha":"6c3444d1c0388b263d2eea16d134a652a7616fbf","user":{"login":"gabrielbaldao","id":20587352,"node_id":"MDQ6VXNlcjIwNTg3MzUy","avatar_url":"https://avatars0.githubusercontent.com/u/20587352?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielbaldao","html_url":"https://github.com/gabrielbaldao","followers_url":"https://api.github.com/users/gabrielbaldao/followers","following_url":"https://api.github.com/users/gabrielbaldao/following{/other_user}","gists_url":"https://api.github.com/users/gabrielbaldao/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielbaldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielbaldao/subscriptions","organizations_url":"https://api.github.com/users/gabrielbaldao/orgs","repos_url":"https://api.github.com/users/gabrielbaldao/repos","events_url":"https://api.github.com/users/gabrielbaldao/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielbaldao/received_events","type":"User","site_admin":false},"repo":{"id":215546543,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU1NDY1NDM=","name":"coral","full_name":"gabrielbaldao/coral","private":false,"owner":{"login":"gabrielbaldao","id":20587352,"node_id":"MDQ6VXNlcjIwNTg3MzUy","avatar_url":"https://avatars0.githubusercontent.com/u/20587352?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielbaldao","html_url":"https://github.com/gabrielbaldao","followers_url":"https://api.github.com/users/gabrielbaldao/followers","following_url":"https://api.github.com/users/gabrielbaldao/following{/other_user}","gists_url":"https://api.github.com/users/gabrielbaldao/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielbaldao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielbaldao/subscriptions","organizations_url":"https://api.github.com/users/gabrielbaldao/orgs","repos_url":"https://api.github.com/users/gabrielbaldao/repos","events_url":"https://api.github.com/users/gabrielbaldao/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielbaldao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gabrielbaldao/coral","description":"An upcoming project for Ruby for Good","fork":true,"url":"https://api.github.com/repos/gabrielbaldao/coral","forks_url":"https://api.github.com/repos/gabrielbaldao/coral/forks","keys_url":"https://api.github.com/repos/gabrielbaldao/coral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrielbaldao/coral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrielbaldao/coral/teams","hooks_url":"https://api.github.com/repos/gabrielbaldao/coral/hooks","issue_events_url":"https://api.github.com/repos/gabrielbaldao/coral/issues/events{/number}","events_url":"https://api.github.com/repos/gabrielbaldao/coral/events","assignees_url":"https://api.github.com/repos/gabrielbaldao/coral/assignees{/user}","branches_url":"https://api.github.com/repos/gabrielbaldao/coral/branches{/branch}","tags_url":"https://api.github.com/repos/gabrielbaldao/coral/tags","blobs_url":"https://api.github.com/repos/gabrielbaldao/coral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrielbaldao/coral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrielbaldao/coral/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrielbaldao/coral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrielbaldao/coral/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrielbaldao/coral/languages","stargazers_url":"https://api.github.com/repos/gabrielbaldao/coral/stargazers","contributors_url":"https://api.github.com/repos/gabrielbaldao/coral/contributors","subscribers_url":"https://api.github.com/repos/gabrielbaldao/coral/subscribers","subscription_url":"https://api.github.com/repos/gabrielbaldao/coral/subscription","commits_url":"https://api.github.com/repos/gabrielbaldao/coral/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrielbaldao/coral/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrielbaldao/coral/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrielbaldao/coral/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrielbaldao/coral/contents/{+path}","compare_url":"https://api.github.com/repos/gabrielbaldao/coral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrielbaldao/coral/merges","archive_url":"https://api.github.com/repos/gabrielbaldao/coral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrielbaldao/coral/downloads","issues_url":"https://api.github.com/repos/gabrielbaldao/coral/issues{/number}","pulls_url":"https://api.github.com/repos/gabrielbaldao/coral/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrielbaldao/coral/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrielbaldao/coral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrielbaldao/coral/labels{/name}","releases_url":"https://api.github.com/repos/gabrielbaldao/coral/releases{/id}","deployments_url":"https://api.github.com/repos/gabrielbaldao/coral/deployments","created_at":"2019-10-16T12:47:37Z","updated_at":"2019-10-16T12:47:38Z","pushed_at":"2019-10-16T14:11:22Z","git_url":"git://github.com/gabrielbaldao/coral.git","ssh_url":"git@github.com:gabrielbaldao/coral.git","clone_url":"https://github.com/gabrielbaldao/coral.git","svn_url":"https://github.com/gabrielbaldao/coral","homepage":null,"size":34923,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubyforgood:master","ref":"master","sha":"d5b2b961d8cb3fa7387ec7986296edfc70a22a89","user":{"login":"rubyforgood","id":11573263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTczMjYz","avatar_url":"https://avatars1.githubusercontent.com/u/11573263?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyforgood","html_url":"https://github.com/rubyforgood","followers_url":"https://api.github.com/users/rubyforgood/followers","following_url":"https://api.github.com/users/rubyforgood/following{/other_user}","gists_url":"https://api.github.com/users/rubyforgood/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyforgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyforgood/subscriptions","organizations_url":"https://api.github.com/users/rubyforgood/orgs","repos_url":"https://api.github.com/users/rubyforgood/repos","events_url":"https://api.github.com/users/rubyforgood/events{/privacy}","received_events_url":"https://api.github.com/users/rubyforgood/received_events","type":"Organization","site_admin":false},"repo":{"id":197501148,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1MDExNDg=","name":"coral","full_name":"rubyforgood/coral","private":false,"owner":{"login":"rubyforgood","id":11573263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTczMjYz","avatar_url":"https://avatars1.githubusercontent.com/u/11573263?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyforgood","html_url":"https://github.com/rubyforgood","followers_url":"https://api.github.com/users/rubyforgood/followers","following_url":"https://api.github.com/users/rubyforgood/following{/other_user}","gists_url":"https://api.github.com/users/rubyforgood/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyforgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyforgood/subscriptions","organizations_url":"https://api.github.com/users/rubyforgood/orgs","repos_url":"https://api.github.com/users/rubyforgood/repos","events_url":"https://api.github.com/users/rubyforgood/events{/privacy}","received_events_url":"https://api.github.com/users/rubyforgood/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubyforgood/coral","description":"An upcoming project for Ruby for Good","fork":false,"url":"https://api.github.com/repos/rubyforgood/coral","forks_url":"https://api.github.com/repos/rubyforgood/coral/forks","keys_url":"https://api.github.com/repos/rubyforgood/coral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyforgood/coral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyforgood/coral/teams","hooks_url":"https://api.github.com/repos/rubyforgood/coral/hooks","issue_events_url":"https://api.github.com/repos/rubyforgood/coral/issues/events{/number}","events_url":"https://api.github.com/repos/rubyforgood/coral/events","assignees_url":"https://api.github.com/repos/rubyforgood/coral/assignees{/user}","branches_url":"https://api.github.com/repos/rubyforgood/coral/branches{/branch}","tags_url":"https://api.github.com/repos/rubyforgood/coral/tags","blobs_url":"https://api.github.com/repos/rubyforgood/coral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyforgood/coral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyforgood/coral/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyforgood/coral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyforgood/coral/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyforgood/coral/languages","stargazers_url":"https://api.github.com/repos/rubyforgood/coral/stargazers","contributors_url":"https://api.github.com/repos/rubyforgood/coral/contributors","subscribers_url":"https://api.github.com/repos/rubyforgood/coral/subscribers","subscription_url":"https://api.github.com/repos/rubyforgood/coral/subscription","commits_url":"https://api.github.com/repos/rubyforgood/coral/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyforgood/coral/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyforgood/coral/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyforgood/coral/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyforgood/coral/contents/{+path}","compare_url":"https://api.github.com/repos/rubyforgood/coral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyforgood/coral/merges","archive_url":"https://api.github.com/repos/rubyforgood/coral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyforgood/coral/downloads","issues_url":"https://api.github.com/repos/rubyforgood/coral/issues{/number}","pulls_url":"https://api.github.com/repos/rubyforgood/coral/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyforgood/coral/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyforgood/coral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyforgood/coral/labels{/name}","releases_url":"https://api.github.com/repos/rubyforgood/coral/releases{/id}","deployments_url":"https://api.github.com/repos/rubyforgood/coral/deployments","created_at":"2019-07-18T03:02:46Z","updated_at":"2019-10-15T15:39:13Z","pushed_at":"2019-10-16T14:18:46Z","git_url":"git://github.com/rubyforgood/coral.git","ssh_url":"git@github.com:rubyforgood/coral.git","clone_url":"https://github.com/rubyforgood/coral.git","svn_url":"https://github.com/rubyforgood/coral","homepage":null,"size":34921,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":16,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyforgood/coral/pulls/95"},"html":{"href":"https://github.com/rubyforgood/coral/pull/95"},"issue":{"href":"https://api.github.com/repos/rubyforgood/coral/issues/95"},"comments":{"href":"https://api.github.com/repos/rubyforgood/coral/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyforgood/coral/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyforgood/coral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyforgood/coral/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/rubyforgood/coral/statuses/6c3444d1c0388b263d2eea16d134a652a7616fbf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":52,"deletions":61,"changed_files":9}}
{"actor":{"display_login":"gabrielbaldao"}}