{"action":"closed","number":32259,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/32259","id":257264441,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MjY0NDQx","html_url":"https://github.com/elastic/kibana/pull/32259","diff_url":"https://github.com/elastic/kibana/pull/32259.diff","patch_url":"https://github.com/elastic/kibana/pull/32259.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/32259","number":32259,"state":"closed","locked":false,"title":"fix: Speed up history middleware","user":{"login":"w33ble","id":404731,"node_id":"MDQ6VXNlcjQwNDczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/404731?v=4","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"body":"Comparison of speeds and size:\r\n\r\n### lz-string\r\n\r\nSlowest, but highest compression (our baseline)\r\n\r\n![screenshot 2019-02-28 15 54 07](https://user-images.githubusercontent.com/404731/53604423-b37a7100-3b71-11e9-8868-268fd5cbe89e.png)\r\n\r\n### lzwcompress\r\n\r\nFaster (~3x), slightly larger payload (~1.2x)\r\n\r\nBasically a free performance gain, but the middleware is still slower than we'd like\r\n\r\n![screenshot 2019-02-28 15 52 59](https://user-images.githubusercontent.com/404731/53604434-bbd2ac00-3b71-11e9-8e0a-c72666e6e908.png)\r\n\r\n### only JSON.stringify\r\n\r\nFastest (by 20x or more) but much larger payload (~6x)\r\n\r\nSpeed is not surprising, but we run a real risk of bumping into Firefox's limit of 160k (The YDYW workpad in the kitchen sink has a state of ~102k). \r\n\r\n![screenshot 2019-02-28 15 52 07](https://user-images.githubusercontent.com/404731/53604447-c68d4100-3b71-11e9-8291-767da53b7942.png)\r\n","created_at":"2019-02-28T23:19:07Z","updated_at":"2019-03-11T22:45:07Z","closed_at":"2019-03-11T22:45:07Z","merged_at":null,"merge_commit_sha":"71e2f818979d2c77fb24b3be19c455480dfba8f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"kibana-canvas","id":2777298,"node_id":"MDQ6VGVhbTI3NzcyOTg=","slug":"kibana-canvas","description":"Area team within Kibana focused on the canvas app","privacy":"closed","url":"https://api.github.com/teams/2777298","html_url":"https://github.com/orgs/elastic/teams/kibana-canvas","members_url":"https://api.github.com/teams/2777298/members{/member}","repositories_url":"https://api.github.com/teams/2777298/repos","permission":"pull"}],"labels":[{"id":912981985,"node_id":"MDU6TGFiZWw5MTI5ODE5ODU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Canvas","name":":Canvas","color":"fef2c0","default":false},{"id":409457688,"node_id":"MDU6TGFiZWw0MDk0NTc2ODg=","url":"https://api.github.com/repos/elastic/kibana/labels/WIP","name":"WIP","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/32259/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/32259/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/32259/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/c7a1626ce9c030a89870d6f0629f18308c4e6e83","head":{"label":"w33ble:fix/history-speed","ref":"fix/history-speed","sha":"c7a1626ce9c030a89870d6f0629f18308c4e6e83","user":{"login":"w33ble","id":404731,"node_id":"MDQ6VXNlcjQwNDczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/404731?v=4","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"repo":{"id":21840088,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg0MDA4OA==","name":"kibana","full_name":"w33ble/kibana","private":false,"owner":{"login":"w33ble","id":404731,"node_id":"MDQ6VXNlcjQwNDczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/404731?v=4","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"html_url":"https://github.com/w33ble/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/w33ble/kibana","forks_url":"https://api.github.com/repos/w33ble/kibana/forks","keys_url":"https://api.github.com/repos/w33ble/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w33ble/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w33ble/kibana/teams","hooks_url":"https://api.github.com/repos/w33ble/kibana/hooks","issue_events_url":"https://api.github.com/repos/w33ble/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/w33ble/kibana/events","assignees_url":"https://api.github.com/repos/w33ble/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/w33ble/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/w33ble/kibana/tags","blobs_url":"https://api.github.com/repos/w33ble/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w33ble/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w33ble/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/w33ble/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w33ble/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/w33ble/kibana/languages","stargazers_url":"https://api.github.com/repos/w33ble/kibana/stargazers","contributors_url":"https://api.github.com/repos/w33ble/kibana/contributors","subscribers_url":"https://api.github.com/repos/w33ble/kibana/subscribers","subscription_url":"https://api.github.com/repos/w33ble/kibana/subscription","commits_url":"https://api.github.com/repos/w33ble/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/w33ble/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/w33ble/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/w33ble/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/w33ble/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/w33ble/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w33ble/kibana/merges","archive_url":"https://api.github.com/repos/w33ble/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w33ble/kibana/downloads","issues_url":"https://api.github.com/repos/w33ble/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/w33ble/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/w33ble/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/w33ble/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w33ble/kibana/labels{/name}","releases_url":"https://api.github.com/repos/w33ble/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/w33ble/kibana/deployments","created_at":"2014-07-14T23:59:39Z","updated_at":"2018-11-28T19:43:36Z","pushed_at":"2019-03-08T19:47:52Z","git_url":"git://github.com/w33ble/kibana.git","ssh_url":"git@github.com:w33ble/kibana.git","clone_url":"https://github.com/w33ble/kibana.git","svn_url":"https://github.com/w33ble/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":680283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"aefa169a68861a48859242c37335bb190a0e86f1","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-03-11T22:41:11Z","pushed_at":"2019-03-11T22:44:29Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":698305,"stargazers_count":11281,"watchers_count":11281,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4419,"mirror_url":null,"archived":false,"open_issues_count":4197,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4419,"open_issues":4197,"watchers":11281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/32259"},"html":{"href":"https://github.com/elastic/kibana/pull/32259"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/32259"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/32259/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/32259/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/32259/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/c7a1626ce9c030a89870d6f0629f18308c4e6e83"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"w33ble"}}