{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/comments/334119208","pull_request_review_id":300854985,"id":334119208,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDExOTIwOA==","diff_hunk":"@@ -8,13 +8,28 @@ import { InternalCollider } from '../internal/collider';\n import { CollisionHandler, TriggerHandler } from './physics';\r\n import { ColliderEventType, CollisionEventType, TriggerEventType } from './physics/collisionEventType';\r\n \r\n+/**\r\n+ * Controls what the assigned actors will collide with.\r\n+ * * `default` - Good for most actors. These will collide with all \"physical\" things: other default actors,\r\n+ * navigation actors, and the non-MRE environment. It also blocks the UI cursor and receives press/grab events.\r\n+ * * `navigation` - For actors considered part of the environment. Can move/teleport onto these colliders,\r\n+ * but cannot click or grab them.\r\n+ * * `hologram` - For \"non-physical\" actors. Only interact with the cursor and other holograms.\r\n+ * * `ui` - Actors in this layer do not collide with anything but the UI cursor.\r\n+ */\r\n+export type CollisionLayer\r","path":"packages/sdk/src/types/runtime/collider.ts","position":13,"original_position":13,"commit_id":"01091e13a85e4c607835211f40ec51b26f04daee","original_commit_id":"01091e13a85e4c607835211f40ec51b26f04daee","user":{"login":"tombuMS","id":40439150,"node_id":"MDQ6VXNlcjQwNDM5MTUw","avatar_url":"https://avatars0.githubusercontent.com/u/40439150?v=4","gravatar_id":"","url":"https://api.github.com/users/tombuMS","html_url":"https://github.com/tombuMS","followers_url":"https://api.github.com/users/tombuMS/followers","following_url":"https://api.github.com/users/tombuMS/following{/other_user}","gists_url":"https://api.github.com/users/tombuMS/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuMS/subscriptions","organizations_url":"https://api.github.com/users/tombuMS/orgs","repos_url":"https://api.github.com/users/tombuMS/repos","events_url":"https://api.github.com/users/tombuMS/events{/privacy}","received_events_url":"https://api.github.com/users/tombuMS/received_events","type":"User","site_admin":false},"body":"I though that we were moving away from the type model in favor of enums for this sort of thing.  Is that not the case any longer?","created_at":"2019-10-11T18:25:08Z","updated_at":"2019-10-11T18:27:33Z","html_url":"https://github.com/microsoft/mixed-reality-extension-sdk/pull/455#discussion_r334119208","pull_request_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/comments/334119208"},"html":{"href":"https://github.com/microsoft/mixed-reality-extension-sdk/pull/455#discussion_r334119208"},"pull_request":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455","id":327299685,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3Mjk5Njg1","html_url":"https://github.com/microsoft/mixed-reality-extension-sdk/pull/455","diff_url":"https://github.com/microsoft/mixed-reality-extension-sdk/pull/455.diff","patch_url":"https://github.com/microsoft/mixed-reality-extension-sdk/pull/455.patch","issue_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/455","number":455,"state":"open","locked":false,"title":"Collision layers","user":{"login":"stevenvergenz","id":1882376,"node_id":"MDQ6VXNlcjE4ODIzNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1882376?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenvergenz","html_url":"https://github.com/stevenvergenz","followers_url":"https://api.github.com/users/stevenvergenz/followers","following_url":"https://api.github.com/users/stevenvergenz/following{/other_user}","gists_url":"https://api.github.com/users/stevenvergenz/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenvergenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenvergenz/subscriptions","organizations_url":"https://api.github.com/users/stevenvergenz/orgs","repos_url":"https://api.github.com/users/stevenvergenz/repos","events_url":"https://api.github.com/users/stevenvergenz/events{/privacy}","received_events_url":"https://api.github.com/users/stevenvergenz/received_events","type":"User","site_admin":false},"body":"* Add design doc for collision layers.\r\n* Implement the (minimal) changes needed for layers in the SDK.","created_at":"2019-10-11T17:37:55Z","updated_at":"2019-10-11T18:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faf357ddc4274e27e0179c1f8c490db4e1d550c1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sorenhan","id":11617039,"node_id":"MDQ6VXNlcjExNjE3MDM5","avatar_url":"https://avatars1.githubusercontent.com/u/11617039?v=4","gravatar_id":"","url":"https://api.github.com/users/sorenhan","html_url":"https://github.com/sorenhan","followers_url":"https://api.github.com/users/sorenhan/followers","following_url":"https://api.github.com/users/sorenhan/following{/other_user}","gists_url":"https://api.github.com/users/sorenhan/gists{/gist_id}","starred_url":"https://api.github.com/users/sorenhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorenhan/subscriptions","organizations_url":"https://api.github.com/users/sorenhan/orgs","repos_url":"https://api.github.com/users/sorenhan/repos","events_url":"https://api.github.com/users/sorenhan/events{/privacy}","received_events_url":"https://api.github.com/users/sorenhan/received_events","type":"User","site_admin":false},{"login":"eanders-MS","id":12176807,"node_id":"MDQ6VXNlcjEyMTc2ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/12176807?v=4","gravatar_id":"","url":"https://api.github.com/users/eanders-MS","html_url":"https://github.com/eanders-MS","followers_url":"https://api.github.com/users/eanders-MS/followers","following_url":"https://api.github.com/users/eanders-MS/following{/other_user}","gists_url":"https://api.github.com/users/eanders-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/eanders-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eanders-MS/subscriptions","organizations_url":"https://api.github.com/users/eanders-MS/orgs","repos_url":"https://api.github.com/users/eanders-MS/repos","events_url":"https://api.github.com/users/eanders-MS/events{/privacy}","received_events_url":"https://api.github.com/users/eanders-MS/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455/commits","review_comments_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455/comments","review_comment_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/455/comments","statuses_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/statuses/01091e13a85e4c607835211f40ec51b26f04daee","head":{"label":"microsoft:stvergen/collision-layers","ref":"stvergen/collision-layers","sha":"01091e13a85e4c607835211f40ec51b26f04daee","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":159246839,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyNDY4Mzk=","name":"mixed-reality-extension-sdk","full_name":"microsoft/mixed-reality-extension-sdk","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/mixed-reality-extension-sdk","description":"The Mixed Reality Extension SDK enables developers to build 3D world extensions for AltspaceVR, using Node.JS.","fork":false,"url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk","forks_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/forks","keys_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/teams","hooks_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/hooks","issue_events_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/events","assignees_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/tags","blobs_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/languages","stargazers_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/stargazers","contributors_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/contributors","subscribers_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/subscribers","subscription_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/subscription","commits_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/merges","archive_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/downloads","issues_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/deployments","created_at":"2018-11-26T23:30:26Z","updated_at":"2019-10-10T02:48:12Z","pushed_at":"2019-10-11T17:42:12Z","git_url":"git://github.com/microsoft/mixed-reality-extension-sdk.git","ssh_url":"git@github.com:microsoft/mixed-reality-extension-sdk.git","clone_url":"https://github.com/microsoft/mixed-reality-extension-sdk.git","svn_url":"https://github.com/microsoft/mixed-reality-extension-sdk","homepage":null,"size":7500,"stargazers_count":45,"watchers_count":45,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":97,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":97,"watchers":45,"default_branch":"red"}},"base":{"label":"microsoft:red","ref":"red","sha":"e2d6fd75198a764a070c712a12eb9ef931f665b6","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":159246839,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyNDY4Mzk=","name":"mixed-reality-extension-sdk","full_name":"microsoft/mixed-reality-extension-sdk","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/mixed-reality-extension-sdk","description":"The Mixed Reality Extension SDK enables developers to build 3D world extensions for AltspaceVR, using Node.JS.","fork":false,"url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk","forks_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/forks","keys_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/teams","hooks_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/hooks","issue_events_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/events","assignees_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/tags","blobs_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/languages","stargazers_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/stargazers","contributors_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/contributors","subscribers_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/subscribers","subscription_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/subscription","commits_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/merges","archive_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/downloads","issues_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/deployments","created_at":"2018-11-26T23:30:26Z","updated_at":"2019-10-10T02:48:12Z","pushed_at":"2019-10-11T17:42:12Z","git_url":"git://github.com/microsoft/mixed-reality-extension-sdk.git","ssh_url":"git@github.com:microsoft/mixed-reality-extension-sdk.git","clone_url":"https://github.com/microsoft/mixed-reality-extension-sdk.git","svn_url":"https://github.com/microsoft/mixed-reality-extension-sdk","homepage":null,"size":7500,"stargazers_count":45,"watchers_count":45,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":97,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":97,"watchers":45,"default_branch":"red"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455"},"html":{"href":"https://github.com/microsoft/mixed-reality-extension-sdk/pull/455"},"issue":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/455"},"comments":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/issues/455/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/pulls/455/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/mixed-reality-extension-sdk/statuses/01091e13a85e4c607835211f40ec51b26f04daee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tombuMS"}}