{"action":"created","issue":{"url":"https://api.github.com/repos/Times-0/Timeline/issues/8","repository_url":"https://api.github.com/repos/Times-0/Timeline","labels_url":"https://api.github.com/repos/Times-0/Timeline/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/Times-0/Timeline/issues/8/comments","events_url":"https://api.github.com/repos/Times-0/Timeline/issues/8/events","html_url":"https://github.com/Times-0/Timeline/issues/8","id":416400939,"node_id":"MDU6SXNzdWU0MTY0MDA5Mzk=","number":8,"title":"Small login issue","user":{"login":"metalpython","id":26981796,"node_id":"MDQ6VXNlcjI2OTgxNzk2","avatar_url":"https://avatars2.githubusercontent.com/u/26981796?v=4","gravatar_id":"","url":"https://api.github.com/users/metalpython","html_url":"https://github.com/metalpython","followers_url":"https://api.github.com/users/metalpython/followers","following_url":"https://api.github.com/users/metalpython/following{/other_user}","gists_url":"https://api.github.com/users/metalpython/gists{/gist_id}","starred_url":"https://api.github.com/users/metalpython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metalpython/subscriptions","organizations_url":"https://api.github.com/users/metalpython/orgs","repos_url":"https://api.github.com/users/metalpython/repos","events_url":"https://api.github.com/users/metalpython/events{/privacy}","received_events_url":"https://api.github.com/users/metalpython/received_events","type":"User","site_admin":false},"labels":[{"id":626568549,"node_id":"MDU6TGFiZWw2MjY1Njg1NDk=","url":"https://api.github.com/repos/Times-0/Timeline/labels/bug","name":"bug","color":"ee0701","default":true},{"id":1250345713,"node_id":"MDU6TGFiZWwxMjUwMzQ1NzEz","url":"https://api.github.com/repos/Times-0/Timeline/labels/fixed","name":"fixed","color":"5fe898","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-03-02T14:10:29Z","updated_at":"2019-03-03T16:49:59Z","closed_at":"2019-03-02T15:15:54Z","author_association":"NONE","body":"Hi.\r\nLooks like a small logic error on line 87 of Login.py\r\n\r\n87:  exist = (yield client.db_penguinExists('username', user)) if user != '$fire' and FIREBASE_INIT else True\r\n\r\nThis throws error from DB.py as it stills try to login even with an invalid penguin name.\r\nIf username !='$fire' and FIREBASE_INIT then is firebase is not initialised we will get 0 on this condition and set exist to true.\r\n\r\nCan easily be fixed with:\r\n\r\nexist = (yield client.db_penguinExists('username', user)) if (user != '$fire' and FIREBASE_INIT == 0) else True\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Times-0/Timeline/issues/comments/469040773","html_url":"https://github.com/Times-0/Timeline/issues/8#issuecomment-469040773","issue_url":"https://api.github.com/repos/Times-0/Timeline/issues/8","id":469040773,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2OTA0MDc3Mw==","user":{"login":"metalpython","id":26981796,"node_id":"MDQ6VXNlcjI2OTgxNzk2","avatar_url":"https://avatars2.githubusercontent.com/u/26981796?v=4","gravatar_id":"","url":"https://api.github.com/users/metalpython","html_url":"https://github.com/metalpython","followers_url":"https://api.github.com/users/metalpython/followers","following_url":"https://api.github.com/users/metalpython/following{/other_user}","gists_url":"https://api.github.com/users/metalpython/gists{/gist_id}","starred_url":"https://api.github.com/users/metalpython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metalpython/subscriptions","organizations_url":"https://api.github.com/users/metalpython/orgs","repos_url":"https://api.github.com/users/metalpython/repos","events_url":"https://api.github.com/users/metalpython/events{/privacy}","received_events_url":"https://api.github.com/users/metalpython/received_events","type":"User","site_admin":false},"created_at":"2019-03-03T16:49:59Z","updated_at":"2019-03-03T16:49:59Z","author_association":"NONE","body":"Okay thanks"}}
{"actor":{"display_login":"metalpython"}}