{"action":"created","comment":{"url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/comments/312249624","pull_request_review_id":272845722,"id":312249624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjI0OTYyNA==","diff_hunk":"@@ -62,7 +69,10 @@ def configure_kafka(zk):\n     data_changed('kafka.storage.log_dir', log_dir)\n     kafka = Kafka()\n     zks = zk.zookeepers()\n-    kafka.install(zk_units=zks, log_dir=log_dir)\n+    if log_dir:","path":"charm/kafka/reactive/kafka.py","position":26,"original_position":26,"commit_id":"0da5bdf56029e8795acf40c33ccbc9c284aa00fd","original_commit_id":"0da5bdf56029e8795acf40c33ccbc9c284aa00fd","user":{"login":"cmars","id":23741,"node_id":"MDQ6VXNlcjIzNzQx","avatar_url":"https://avatars3.githubusercontent.com/u/23741?v=4","gravatar_id":"","url":"https://api.github.com/users/cmars","html_url":"https://github.com/cmars","followers_url":"https://api.github.com/users/cmars/followers","following_url":"https://api.github.com/users/cmars/following{/other_user}","gists_url":"https://api.github.com/users/cmars/gists{/gist_id}","starred_url":"https://api.github.com/users/cmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmars/subscriptions","organizations_url":"https://api.github.com/users/cmars/orgs","repos_url":"https://api.github.com/users/cmars/repos","events_url":"https://api.github.com/users/cmars/events{/privacy}","received_events_url":"https://api.github.com/users/cmars/received_events","type":"User","site_admin":false},"body":"`if not log_dir`, something has gone wrong...","created_at":"2019-08-08T21:24:34Z","updated_at":"2019-08-08T21:26:30Z","html_url":"https://github.com/cloud-green/kafka-snap-charm/pull/28#discussion_r312249624","pull_request_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/comments/312249624"},"html":{"href":"https://github.com/cloud-green/kafka-snap-charm/pull/28#discussion_r312249624"},"pull_request":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28","id":304297519,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0Mjk3NTE5","html_url":"https://github.com/cloud-green/kafka-snap-charm/pull/28","diff_url":"https://github.com/cloud-green/kafka-snap-charm/pull/28.diff","patch_url":"https://github.com/cloud-green/kafka-snap-charm/pull/28.patch","issue_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues/28","number":28,"state":"open","locked":false,"title":"Now uses storage id if attached","user":{"login":"kngu9","id":15225357,"node_id":"MDQ6VXNlcjE1MjI1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/15225357?v=4","gravatar_id":"","url":"https://api.github.com/users/kngu9","html_url":"https://github.com/kngu9","followers_url":"https://api.github.com/users/kngu9/followers","following_url":"https://api.github.com/users/kngu9/following{/other_user}","gists_url":"https://api.github.com/users/kngu9/gists{/gist_id}","starred_url":"https://api.github.com/users/kngu9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kngu9/subscriptions","organizations_url":"https://api.github.com/users/kngu9/orgs","repos_url":"https://api.github.com/users/kngu9/repos","events_url":"https://api.github.com/users/kngu9/events{/privacy}","received_events_url":"https://api.github.com/users/kngu9/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-05T13:16:37Z","updated_at":"2019-08-08T21:26:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f1f1d1390a3eec5699b6238098f6b6e31b44cdd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28/commits","review_comments_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28/comments","review_comment_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues/28/comments","statuses_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/statuses/0da5bdf56029e8795acf40c33ccbc9c284aa00fd","head":{"label":"kngu9:use_storage_id","ref":"use_storage_id","sha":"0da5bdf56029e8795acf40c33ccbc9c284aa00fd","user":{"login":"kngu9","id":15225357,"node_id":"MDQ6VXNlcjE1MjI1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/15225357?v=4","gravatar_id":"","url":"https://api.github.com/users/kngu9","html_url":"https://github.com/kngu9","followers_url":"https://api.github.com/users/kngu9/followers","following_url":"https://api.github.com/users/kngu9/following{/other_user}","gists_url":"https://api.github.com/users/kngu9/gists{/gist_id}","starred_url":"https://api.github.com/users/kngu9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kngu9/subscriptions","organizations_url":"https://api.github.com/users/kngu9/orgs","repos_url":"https://api.github.com/users/kngu9/repos","events_url":"https://api.github.com/users/kngu9/events{/privacy}","received_events_url":"https://api.github.com/users/kngu9/received_events","type":"User","site_admin":false},"repo":{"id":172943518,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI5NDM1MTg=","name":"kafka-snap-charm","full_name":"kngu9/kafka-snap-charm","private":false,"owner":{"login":"kngu9","id":15225357,"node_id":"MDQ6VXNlcjE1MjI1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/15225357?v=4","gravatar_id":"","url":"https://api.github.com/users/kngu9","html_url":"https://github.com/kngu9","followers_url":"https://api.github.com/users/kngu9/followers","following_url":"https://api.github.com/users/kngu9/following{/other_user}","gists_url":"https://api.github.com/users/kngu9/gists{/gist_id}","starred_url":"https://api.github.com/users/kngu9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kngu9/subscriptions","organizations_url":"https://api.github.com/users/kngu9/orgs","repos_url":"https://api.github.com/users/kngu9/repos","events_url":"https://api.github.com/users/kngu9/events{/privacy}","received_events_url":"https://api.github.com/users/kngu9/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kngu9/kafka-snap-charm","description":"Kafka snap and charm combined -- a schnapp.","fork":true,"url":"https://api.github.com/repos/kngu9/kafka-snap-charm","forks_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/forks","keys_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/teams","hooks_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/hooks","issue_events_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/issues/events{/number}","events_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/events","assignees_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/assignees{/user}","branches_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/branches{/branch}","tags_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/tags","blobs_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/statuses/{sha}","languages_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/languages","stargazers_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/stargazers","contributors_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/contributors","subscribers_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/subscribers","subscription_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/subscription","commits_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/contents/{+path}","compare_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/merges","archive_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/downloads","issues_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/issues{/number}","pulls_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/pulls{/number}","milestones_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/milestones{/number}","notifications_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/labels{/name}","releases_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/releases{/id}","deployments_url":"https://api.github.com/repos/kngu9/kafka-snap-charm/deployments","created_at":"2019-02-27T15:45:50Z","updated_at":"2019-02-27T15:45:52Z","pushed_at":"2019-08-08T20:49:50Z","git_url":"git://github.com/kngu9/kafka-snap-charm.git","ssh_url":"git@github.com:kngu9/kafka-snap-charm.git","clone_url":"https://github.com/kngu9/kafka-snap-charm.git","svn_url":"https://github.com/kngu9/kafka-snap-charm","homepage":null,"size":113,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloud-green:master","ref":"master","sha":"6d340033dd491cf95860c974a371f96e064ab626","user":{"login":"cloud-green","id":14852315,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODUyMzE1","avatar_url":"https://avatars3.githubusercontent.com/u/14852315?v=4","gravatar_id":"","url":"https://api.github.com/users/cloud-green","html_url":"https://github.com/cloud-green","followers_url":"https://api.github.com/users/cloud-green/followers","following_url":"https://api.github.com/users/cloud-green/following{/other_user}","gists_url":"https://api.github.com/users/cloud-green/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-green/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-green/subscriptions","organizations_url":"https://api.github.com/users/cloud-green/orgs","repos_url":"https://api.github.com/users/cloud-green/repos","events_url":"https://api.github.com/users/cloud-green/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-green/received_events","type":"Organization","site_admin":false},"repo":{"id":171901784,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE5MDE3ODQ=","name":"kafka-snap-charm","full_name":"cloud-green/kafka-snap-charm","private":false,"owner":{"login":"cloud-green","id":14852315,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODUyMzE1","avatar_url":"https://avatars3.githubusercontent.com/u/14852315?v=4","gravatar_id":"","url":"https://api.github.com/users/cloud-green","html_url":"https://github.com/cloud-green","followers_url":"https://api.github.com/users/cloud-green/followers","following_url":"https://api.github.com/users/cloud-green/following{/other_user}","gists_url":"https://api.github.com/users/cloud-green/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-green/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-green/subscriptions","organizations_url":"https://api.github.com/users/cloud-green/orgs","repos_url":"https://api.github.com/users/cloud-green/repos","events_url":"https://api.github.com/users/cloud-green/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-green/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloud-green/kafka-snap-charm","description":"Kafka snap and charm combined -- a schnapp.","fork":true,"url":"https://api.github.com/repos/cloud-green/kafka-snap-charm","forks_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/forks","keys_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/teams","hooks_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/hooks","issue_events_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues/events{/number}","events_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/events","assignees_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/assignees{/user}","branches_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/branches{/branch}","tags_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/tags","blobs_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/statuses/{sha}","languages_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/languages","stargazers_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/stargazers","contributors_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/contributors","subscribers_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/subscribers","subscription_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/subscription","commits_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/contents/{+path}","compare_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/merges","archive_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/downloads","issues_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues{/number}","pulls_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls{/number}","milestones_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/milestones{/number}","notifications_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/labels{/name}","releases_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/releases{/id}","deployments_url":"https://api.github.com/repos/cloud-green/kafka-snap-charm/deployments","created_at":"2019-02-21T15:58:58Z","updated_at":"2019-06-13T15:28:16Z","pushed_at":"2019-08-08T20:49:51Z","git_url":"git://github.com/cloud-green/kafka-snap-charm.git","ssh_url":"git@github.com:cloud-green/kafka-snap-charm.git","clone_url":"https://github.com/cloud-green/kafka-snap-charm.git","svn_url":"https://github.com/cloud-green/kafka-snap-charm","homepage":null,"size":90,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28"},"html":{"href":"https://github.com/cloud-green/kafka-snap-charm/pull/28"},"issue":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues/28"},"comments":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/cloud-green/kafka-snap-charm/statuses/0da5bdf56029e8795acf40c33ccbc9c284aa00fd"}},"author_association":"NONE"}}
{"actor":{"display_login":"cmars"}}