{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments/360965130","pull_request_review_id":335963752,"id":360965130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDk2NTEzMA==","diff_hunk":"@@ -0,0 +1,5 @@\n+package com.mapbox.navigation.base.trip\n+\n+import android.app.Notification\n+\n+data class MapboxNotificationData(val notificationID: Int, val notification: Notification)","path":"libnavigation-base/src/main/java/com/mapbox/navigation/base/trip/MapboxNotificationData.kt","position":5,"original_position":5,"commit_id":"9959a2cb8da4733ab5ff48e50b75acf8d33d7eb9","original_commit_id":"757308d55e73d26bc4966c338c38d87b709bd956","user":{"login":"abhishek1508","id":9770186,"node_id":"MDQ6VXNlcjk3NzAxODY=","avatar_url":"https://avatars3.githubusercontent.com/u/9770186?v=4","gravatar_id":"","url":"https://api.github.com/users/abhishek1508","html_url":"https://github.com/abhishek1508","followers_url":"https://api.github.com/users/abhishek1508/followers","following_url":"https://api.github.com/users/abhishek1508/following{/other_user}","gists_url":"https://api.github.com/users/abhishek1508/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishek1508/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishek1508/subscriptions","organizations_url":"https://api.github.com/users/abhishek1508/orgs","repos_url":"https://api.github.com/users/abhishek1508/repos","events_url":"https://api.github.com/users/abhishek1508/events{/privacy}","received_events_url":"https://api.github.com/users/abhishek1508/received_events","type":"User","site_admin":false},"body":"Already moved to `trip` inside `libnavigation-base`","created_at":"2019-12-23T18:15:43Z","updated_at":"2019-12-23T18:15:43Z","html_url":"https://github.com/mapbox/mapbox-navigation-android/pull/2320#discussion_r360965130","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments/360965130"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-android/pull/2320#discussion_r360965130"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320"}},"in_reply_to_id":360734794},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320","id":353871463,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzODcxNDYz","html_url":"https://github.com/mapbox/mapbox-navigation-android/pull/2320","diff_url":"https://github.com/mapbox/mapbox-navigation-android/pull/2320.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-android/pull/2320.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/2320","number":2320,"state":"open","locked":false,"title":"initial implemintation of TripService and associated classes","user":{"login":"olegzil","id":801296,"node_id":"MDQ6VXNlcjgwMTI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/801296?v=4","gravatar_id":"","url":"https://api.github.com/users/olegzil","html_url":"https://github.com/olegzil","followers_url":"https://api.github.com/users/olegzil/followers","following_url":"https://api.github.com/users/olegzil/following{/other_user}","gists_url":"https://api.github.com/users/olegzil/gists{/gist_id}","starred_url":"https://api.github.com/users/olegzil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegzil/subscriptions","organizations_url":"https://api.github.com/users/olegzil/orgs","repos_url":"https://api.github.com/users/olegzil/repos","events_url":"https://api.github.com/users/olegzil/events{/privacy}","received_events_url":"https://api.github.com/users/olegzil/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is the first attempt at creating the TripService. \r\n\r\nPlease include a brief summary of the change and which issue is fixed (e.g., fixes [#issue](link))\r\n\r\n- [ ] I have added any issue links\r\n- [ ] I have added all related labels (`bug`, `feature`, `new API(s)`, `SEMVER`, etc.)\r\n- [ ] I have added the appropriate milestone and project boards\r\n\r\n### Goal\r\n\r\nPlease describe the PR goals. Just the stuff needed to implement the fix / feature and a simple rationale. It could contain many check points if needed\r\n\r\n### Implementation\r\n\r\nPlease include all the relevant things implemented and also rationale, clarifications / disclaimers etc. related to the approach used. It could be as self code companion comments\r\n\r\n## Screenshots or Gifs\r\n\r\nPlease include all the media files to give some context about what's being implemented or fixed. It's not mandatory to upload screenshots or gifs, but for most of the cases it becomes really handy to get into the scope of the feature / bug being fixed and also it's REALLY useful for UI related PRs ![screenshot gif](link)\r\n\r\n## Testing\r\n\r\nPlease describe the manual tests that you ran to verify your changes\r\n\r\n- [ ] I have tested locally (including `SNAPSHOT` upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions\r\n- [ ] I have tested via a test drive, or a simulation/mock location app\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] New and existing unit tests pass locally with my changes\r\n\r\n## Checklist\r\n\r\n- [ ] My code follows the style guidelines of this project\r\n- [ ] I have performed a self-review of my own code\r\n- [ ] I have updated the `CHANGELOG` including this PR\r\n<!-- - [ ] I have added an `Activity` example in the test app showing the new feature implemented (where applicable) -->\r\n<!-- - [ ] I have made corresponding changes to the documentation (where applicable) -->\r\n<!-- - [ ] Any changes to strings have been published to our translation tool (where applicable) -->\r\n<!-- - [ ] Publish `testapp` in Google Play `internal` test track (where applicable) -->","created_at":"2019-12-17T01:40:20Z","updated_at":"2019-12-23T18:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f646f6da3df8193ef95e81f2820edd6c5b2d70b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/2320/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/9959a2cb8da4733ab5ff48e50b75acf8d33d7eb9","head":{"label":"mapbox:oz-navigation-service","ref":"oz-navigation-service","sha":"9959a2cb8da4733ab5ff48e50b75acf8d33d7eb9","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":87455763,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ1NTc2Mw==","name":"mapbox-navigation-android","full_name":"mapbox/mapbox-navigation-android","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-navigation-android","description":"Mapbox Navigation SDK for Android","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/deployments","created_at":"2017-04-06T17:18:23Z","updated_at":"2019-12-23T12:52:42Z","pushed_at":"2019-12-23T18:11:22Z","git_url":"git://github.com/mapbox/mapbox-navigation-android.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-android.git","clone_url":"https://github.com/mapbox/mapbox-navigation-android.git","svn_url":"https://github.com/mapbox/mapbox-navigation-android","homepage":"https://www.mapbox.com/android-docs/navigation/overview/","size":10938,"stargazers_count":291,"watchers_count":291,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":147,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":184,"open_issues":147,"watchers":291,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"b946f8fb5b68b80aae48751b82e0ddc48d214513","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":87455763,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ1NTc2Mw==","name":"mapbox-navigation-android","full_name":"mapbox/mapbox-navigation-android","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-navigation-android","description":"Mapbox Navigation SDK for Android","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/deployments","created_at":"2017-04-06T17:18:23Z","updated_at":"2019-12-23T12:52:42Z","pushed_at":"2019-12-23T18:11:22Z","git_url":"git://github.com/mapbox/mapbox-navigation-android.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-android.git","clone_url":"https://github.com/mapbox/mapbox-navigation-android.git","svn_url":"https://github.com/mapbox/mapbox-navigation-android","homepage":"https://www.mapbox.com/android-docs/navigation/overview/","size":10938,"stargazers_count":291,"watchers_count":291,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":147,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":184,"open_issues":147,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-android/pull/2320"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/2320"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/2320/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/2320/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/9959a2cb8da4733ab5ff48e50b75acf8d33d7eb9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abhishek1508"}}