{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/364856441","pull_request_review_id":340675860,"id":364856441,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDg1NjQ0MQ==","diff_hunk":"@@ -709,4 +737,35 @@ class FennecMigrator private constructor(\n             }\n         }\n     }\n+\n+    @SuppressWarnings(\"TooGenericExceptionCaught\")\n+    private suspend fun migrateAddons(): Result<AddonMigrationResult> {\n+        return try {\n+            logger.debug(\"Migrating add-ons...\")\n+            val result = AddonMigration.migrate(engine!!)\n+            if (result is Result.Failure<AddonMigrationResult>) {\n+                val migrationFailureWrapper = result.throwables.first() as AddonMigrationException\n+                return when (val failure = migrationFailureWrapper.failure) {\n+                    is AddonMigrationResult.Failure.FailedToQueryInstalledAddons -> {\n+                        logger.error(\"Failed to query installed add-ons: $failure\")\n+                        crashReporter.submitCaughtException(migrationFailureWrapper)\n+                        result\n+                    }\n+                    is AddonMigrationResult.Failure.FailedToMigrateAddons -> {\n+                        logger.error(\"Failed to migrate add-ons: $failure\")\n+                        crashReporter.submitCaughtException(migrationFailureWrapper)","path":"components/support/migration/src/main/java/mozilla/components/support/migration/FennecMigrator.kt","position":104,"original_position":104,"commit_id":"889141111d12819aeec765a1f88025fbf821d69c","original_commit_id":"c3f80e951c0fb3a8323932ae439481536a5434e6","user":{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"body":"Ah, yes, I remember this. Case here is slightly different as I am mapping the exceptions to their addon, but I made part of your logic re-usable and applied it here as well so we now\r\n- properly report the underlying exception\r\n- and only do it once (and not spam Sentry)","created_at":"2020-01-09T17:03:17Z","updated_at":"2020-01-09T17:03:18Z","html_url":"https://github.com/mozilla-mobile/android-components/pull/5495#discussion_r364856441","pull_request_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments/364856441"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/5495#discussion_r364856441"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495"}},"in_reply_to_id":364525394},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495","id":360200024,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwMjAwMDI0","html_url":"https://github.com/mozilla-mobile/android-components/pull/5495","diff_url":"https://github.com/mozilla-mobile/android-components/pull/5495.diff","patch_url":"https://github.com/mozilla-mobile/android-components/pull/5495.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/5495","number":5495,"state":"open","locked":false,"title":"Closes #5460: Fennec migration: Disable currently unsupported add-ons","user":{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"body":"This is for the first iteration and currently disabling *all* installed addons. Later we want to match against supported addons from our AMO collection and/or an offline whitelist.\r\n\r\nMade sure to capture all outcomes in `AddonMigrationResult`s so we can add telemetry/logs, as needed. Let me know if I missed anything :).","created_at":"2020-01-07T22:25:20Z","updated_at":"2020-01-09T17:03:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e105a447029dbba90a95bb5febc94d3a44b88b56","assignee":{"login":"pocmo","id":89638,"node_id":"MDQ6VXNlcjg5NjM4","avatar_url":"https://avatars0.githubusercontent.com/u/89638?v=4","gravatar_id":"","url":"https://api.github.com/users/pocmo","html_url":"https://github.com/pocmo","followers_url":"https://api.github.com/users/pocmo/followers","following_url":"https://api.github.com/users/pocmo/following{/other_user}","gists_url":"https://api.github.com/users/pocmo/gists{/gist_id}","starred_url":"https://api.github.com/users/pocmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocmo/subscriptions","organizations_url":"https://api.github.com/users/pocmo/orgs","repos_url":"https://api.github.com/users/pocmo/repos","events_url":"https://api.github.com/users/pocmo/events{/privacy}","received_events_url":"https://api.github.com/users/pocmo/received_events","type":"User","site_admin":false},"assignees":[{"login":"pocmo","id":89638,"node_id":"MDQ6VXNlcjg5NjM4","avatar_url":"https://avatars0.githubusercontent.com/u/89638?v=4","gravatar_id":"","url":"https://api.github.com/users/pocmo","html_url":"https://github.com/pocmo","followers_url":"https://api.github.com/users/pocmo/followers","following_url":"https://api.github.com/users/pocmo/following{/other_user}","gists_url":"https://api.github.com/users/pocmo/gists{/gist_id}","starred_url":"https://api.github.com/users/pocmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocmo/subscriptions","organizations_url":"https://api.github.com/users/pocmo/orgs","repos_url":"https://api.github.com/users/pocmo/repos","events_url":"https://api.github.com/users/pocmo/events{/privacy}","received_events_url":"https://api.github.com/users/pocmo/received_events","type":"User","site_admin":false},{"login":"grigoryk","id":465422,"node_id":"MDQ6VXNlcjQ2NTQyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/465422?v=4","gravatar_id":"","url":"https://api.github.com/users/grigoryk","html_url":"https://github.com/grigoryk","followers_url":"https://api.github.com/users/grigoryk/followers","following_url":"https://api.github.com/users/grigoryk/following{/other_user}","gists_url":"https://api.github.com/users/grigoryk/gists{/gist_id}","starred_url":"https://api.github.com/users/grigoryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grigoryk/subscriptions","organizations_url":"https://api.github.com/users/grigoryk/orgs","repos_url":"https://api.github.com/users/grigoryk/repos","events_url":"https://api.github.com/users/grigoryk/events{/privacy}","received_events_url":"https://api.github.com/users/grigoryk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/5495/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/889141111d12819aeec765a1f88025fbf821d69c","head":{"label":"csadilek:issue-5460","ref":"issue-5460","sha":"889141111d12819aeec765a1f88025fbf821d69c","user":{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"repo":{"id":126226751,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMjY3NTE=","name":"android-components","full_name":"csadilek/android-components","private":false,"owner":{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/csadilek/android-components","description":null,"fork":true,"url":"https://api.github.com/repos/csadilek/android-components","forks_url":"https://api.github.com/repos/csadilek/android-components/forks","keys_url":"https://api.github.com/repos/csadilek/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csadilek/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csadilek/android-components/teams","hooks_url":"https://api.github.com/repos/csadilek/android-components/hooks","issue_events_url":"https://api.github.com/repos/csadilek/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/csadilek/android-components/events","assignees_url":"https://api.github.com/repos/csadilek/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/csadilek/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/csadilek/android-components/tags","blobs_url":"https://api.github.com/repos/csadilek/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csadilek/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csadilek/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/csadilek/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csadilek/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/csadilek/android-components/languages","stargazers_url":"https://api.github.com/repos/csadilek/android-components/stargazers","contributors_url":"https://api.github.com/repos/csadilek/android-components/contributors","subscribers_url":"https://api.github.com/repos/csadilek/android-components/subscribers","subscription_url":"https://api.github.com/repos/csadilek/android-components/subscription","commits_url":"https://api.github.com/repos/csadilek/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/csadilek/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/csadilek/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/csadilek/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/csadilek/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/csadilek/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csadilek/android-components/merges","archive_url":"https://api.github.com/repos/csadilek/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csadilek/android-components/downloads","issues_url":"https://api.github.com/repos/csadilek/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/csadilek/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/csadilek/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/csadilek/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csadilek/android-components/labels{/name}","releases_url":"https://api.github.com/repos/csadilek/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/csadilek/android-components/deployments","created_at":"2018-03-21T18:56:59Z","updated_at":"2018-12-12T20:11:40Z","pushed_at":"2020-01-09T15:57:35Z","git_url":"git://github.com/csadilek/android-components.git","ssh_url":"git@github.com:csadilek/android-components.git","clone_url":"https://github.com/csadilek/android-components.git","svn_url":"https://github.com/csadilek/android-components","homepage":null,"size":106363,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"d1e723ca97a3a51cdc9913f89e8804f020f8f55e","user":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":126199585,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxOTk1ODU=","name":"android-components","full_name":"mozilla-mobile/android-components","private":false,"owner":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-mobile/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/android-components","forks_url":"https://api.github.com/repos/mozilla-mobile/android-components/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/android-components/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/android-components/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/android-components/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/android-components/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/android-components/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/android-components/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/android-components/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/android-components/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/android-components/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/android-components/deployments","created_at":"2018-03-21T15:24:03Z","updated_at":"2020-01-09T16:53:47Z","pushed_at":"2020-01-09T16:54:44Z","git_url":"git://github.com/mozilla-mobile/android-components.git","ssh_url":"git@github.com:mozilla-mobile/android-components.git","clone_url":"https://github.com/mozilla-mobile/android-components.git","svn_url":"https://github.com/mozilla-mobile/android-components","homepage":"https://mozac.org","size":60025,"stargazers_count":1150,"watchers_count":1150,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":252,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":673,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":252,"open_issues":673,"watchers":1150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/5495"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/5495"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/5495/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/5495/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/889141111d12819aeec765a1f88025fbf821d69c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"csadilek"}}