{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9708","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9708/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9708/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9708/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/9708","id":409811467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNjk4ODgy","number":9708,"title":"Implement PSA protected storage & restructure PSA storage implementation","user":{"login":"davidsaada","id":30656454,"node_id":"MDQ6VXNlcjMwNjU2NDU0","avatar_url":"https://avatars3.githubusercontent.com/u/30656454?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsaada","html_url":"https://github.com/davidsaada","followers_url":"https://api.github.com/users/davidsaada/followers","following_url":"https://api.github.com/users/davidsaada/following{/other_user}","gists_url":"https://api.github.com/users/davidsaada/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsaada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsaada/subscriptions","organizations_url":"https://api.github.com/users/davidsaada/orgs","repos_url":"https://api.github.com/users/davidsaada/repos","events_url":"https://api.github.com/users/davidsaada/events{/privacy}","received_events_url":"https://api.github.com/users/davidsaada/received_events","type":"User","site_admin":false},"labels":[{"id":642056257,"node_id":"MDU6TGFiZWw2NDIwNTYyNTc=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20preceding%20PR","name":"needs: preceding PR","color":"fef250","default":false},{"id":144902129,"node_id":"MDU6TGFiZWwxNDQ5MDIxMjk=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false},{"id":1132645798,"node_id":"MDU6TGFiZWwxMTMyNjQ1Nzk4","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/release-version:%205.12.0-rc1","name":"release-version: 5.12.0-rc1","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2019-02-13T13:43:46Z","updated_at":"2019-02-21T04:30:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9708","html_url":"https://github.com/ARMmbed/mbed-os/pull/9708","diff_url":"https://github.com/ARMmbed/mbed-os/pull/9708.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/9708.patch"},"body":"### Description\r\nThis PR's main purpose is the implementation of the PSA Protected Storage (PS) feature. As this implementation is almost identical to the one we already have in PSA's Internal Trusted Storage (ITS), it triggered a deeper change in the entire implementation of PSA storage.\r\n\r\nSo, changes included here are:\r\n- Move all PSA storage code under psa/storage directory\r\n- Create a global PSA error codes header, eliminating ITS specific ones (backed by [a change in the PSA spec](https://github.com/ARMmbed/psa_trusted_storage_api/pull/49))\r\n- Create a common header file for PSA storage type definitions, eliminating ITS specific ones (backed by the same change in the PSA spec)\r\n- Create a common implementation for PS & ITS\r\n- Implement protected storage feature\r\n- Change ITS test to be common to PS as well\r\n- Modify affected PSA crypto code (temporary, for CI sake only)\r\n\r\n**Important notes:**\r\n~- Changes in the mbed-crypto code, included in this PR, are temporary. Changes should eventually be taken from [PR #55 in the mbed-crypto repo](https://github.com/ARMmbed/mbed-crypto/pull/55). They are included here for CI sake only. After both PRs are approved, they should be merged together.~\r\n- This PR is based on the current PSA spec. There's an ongoing [discussion](https://github.com/ARMmbed/psa_trusted_storage_api/issues/53) regarding the way PSA get functions should behave that's still open. As we strive to push this PR for 5.12, we can't wait for this discussion to be resolved, but if it's resolved in a reasonable time frame, PR may change accordingly.\r\n\r\nTested with all PSA tests on K64F and FUTURE_SEQUANA boards.\r\n\r\n### Pull request type\r\n    [ ] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [x] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n### Release Notes\r\n- Restructure PSA storage implementation (directory structure and common code)\r\n- Add the PSA protected storage feature\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/465858055","html_url":"https://github.com/ARMmbed/mbed-os/pull/9708#issuecomment-465858055","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9708","id":465858055,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NTg1ODA1NQ==","user":{"login":"davidsaada","id":30656454,"node_id":"MDQ6VXNlcjMwNjU2NDU0","avatar_url":"https://avatars3.githubusercontent.com/u/30656454?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsaada","html_url":"https://github.com/davidsaada","followers_url":"https://api.github.com/users/davidsaada/followers","following_url":"https://api.github.com/users/davidsaada/following{/other_user}","gists_url":"https://api.github.com/users/davidsaada/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsaada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsaada/subscriptions","organizations_url":"https://api.github.com/users/davidsaada/orgs","repos_url":"https://api.github.com/users/davidsaada/repos","events_url":"https://api.github.com/users/davidsaada/events{/privacy}","received_events_url":"https://api.github.com/users/davidsaada/received_events","type":"User","site_admin":false},"created_at":"2019-02-21T04:30:40Z","updated_at":"2019-02-21T04:30:40Z","author_association":"CONTRIBUTOR","body":"> @davidsaada @Patater I'm sure y'all are aware, but it seems this is a critical-path PR. The sooner y'all are able to get work completed here, the sooner other PRs become unblocked.\r\n\r\nWe're well aware of it. Managed yesterday to rebase on master (pretty brutal rebase on top of the TFM PR), with mbedtls change tucked in as well. Just verifying the changes with Future Sequana and Musca boards now."}}
{"actor":{"display_login":"davidsaada"}}