{"action":"created","comment":{"url":"https://api.github.com/repos/holochain/lib3h/pulls/comments/325901197","pull_request_review_id":290213125,"id":325901197,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTkwMTE5Nw==","diff_hunk":"@@ -72,50 +83,84 @@ impl P2pGateway {\n     pub(crate) fn send(\n         &mut self,\n         span: Lib3hSpan,\n-        uri: &Url,\n-        payload: &[u8],\n-        parent_msg: GatewayToChildMessage,\n+        uri: Url,\n+        payload: Opaque,\n+        cb: SendCallback,\n     ) -> GhostResult<()> {\n         trace!(\"({}).send() {} | {}\", self.identifier, uri, payload.len());\n         // Forward to the child Transport\n-        self.inner_transport.request(\n-            span,\n+        println!(\"GATEWAY SEND [{:?}]: {:?}\", uri, payload);","path":"crates/lib3h/src/gateway/gateway_transport.rs","position":48,"original_position":47,"commit_id":"06863289c4baed2f1cbfedc0b09a63c120875a2b","original_commit_id":"6076b37c7199784f5f2f8f28c0a1d386aac858b4","user":{"login":"struktured","id":5060002,"node_id":"MDQ6VXNlcjUwNjAwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5060002?v=4","gravatar_id":"","url":"https://api.github.com/users/struktured","html_url":"https://github.com/struktured","followers_url":"https://api.github.com/users/struktured/followers","following_url":"https://api.github.com/users/struktured/following{/other_user}","gists_url":"https://api.github.com/users/struktured/gists{/gist_id}","starred_url":"https://api.github.com/users/struktured/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/struktured/subscriptions","organizations_url":"https://api.github.com/users/struktured/orgs","repos_url":"https://api.github.com/users/struktured/repos","events_url":"https://api.github.com/users/struktured/events{/privacy}","received_events_url":"https://api.github.com/users/struktured/received_events","type":"User","site_admin":false},"body":"Switch to `trace!/debug!/info!`?","created_at":"2019-09-18T21:29:33Z","updated_at":"2019-09-18T21:29:34Z","html_url":"https://github.com/holochain/lib3h/pull/366#discussion_r325901197","pull_request_url":"https://api.github.com/repos/holochain/lib3h/pulls/366","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/holochain/lib3h/pulls/comments/325901197"},"html":{"href":"https://github.com/holochain/lib3h/pull/366#discussion_r325901197"},"pull_request":{"href":"https://api.github.com/repos/holochain/lib3h/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/holochain/lib3h/pulls/366","id":319005807,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MDA1ODA3","html_url":"https://github.com/holochain/lib3h/pull/366","diff_url":"https://github.com/holochain/lib3h/pull/366.diff","patch_url":"https://github.com/holochain/lib3h/pull/366.patch","issue_url":"https://api.github.com/repos/holochain/lib3h/issues/366","number":366,"state":"open","locked":false,"title":"Ghost P2pGateway: pending messages + several fixes","user":{"login":"lucksus","id":311749,"node_id":"MDQ6VXNlcjMxMTc0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311749?v=4","gravatar_id":"","url":"https://api.github.com/users/lucksus","html_url":"https://github.com/lucksus","followers_url":"https://api.github.com/users/lucksus/followers","following_url":"https://api.github.com/users/lucksus/following{/other_user}","gists_url":"https://api.github.com/users/lucksus/gists{/gist_id}","starred_url":"https://api.github.com/users/lucksus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucksus/subscriptions","organizations_url":"https://api.github.com/users/lucksus/orgs","repos_url":"https://api.github.com/users/lucksus/repos","events_url":"https://api.github.com/users/lucksus/events{/privacy}","received_events_url":"https://api.github.com/users/lucksus/received_events","type":"User","site_admin":false},"body":"## PR summary\r\n\r\n## Review checklist \r\n- [ ] The story has unit or integration tests\r\n- [ ] No new bugs, and any tech-debt is identified and justified\r\n- [ ] There is enough API documentation (how to use)\r\n- [ ] There is enough code documentation (how the code works)\r\n","created_at":"2019-09-18T21:22:28Z","updated_at":"2019-09-18T21:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b5c29a422555c5757c6b613ed0f08a32ec82ab4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/holochain/lib3h/pulls/366/commits","review_comments_url":"https://api.github.com/repos/holochain/lib3h/pulls/366/comments","review_comment_url":"https://api.github.com/repos/holochain/lib3h/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holochain/lib3h/issues/366/comments","statuses_url":"https://api.github.com/repos/holochain/lib3h/statuses/06863289c4baed2f1cbfedc0b09a63c120875a2b","head":{"label":"holochain:ghost-gateway-pending-messages","ref":"ghost-gateway-pending-messages","sha":"06863289c4baed2f1cbfedc0b09a63c120875a2b","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":138816641,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4MTY2NDE=","name":"lib3h","full_name":"holochain/lib3h","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/lib3h","description":"The lib3h p2p communication rust library.","fork":false,"url":"https://api.github.com/repos/holochain/lib3h","forks_url":"https://api.github.com/repos/holochain/lib3h/forks","keys_url":"https://api.github.com/repos/holochain/lib3h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/lib3h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/lib3h/teams","hooks_url":"https://api.github.com/repos/holochain/lib3h/hooks","issue_events_url":"https://api.github.com/repos/holochain/lib3h/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/lib3h/events","assignees_url":"https://api.github.com/repos/holochain/lib3h/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/lib3h/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/lib3h/tags","blobs_url":"https://api.github.com/repos/holochain/lib3h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/lib3h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/lib3h/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/lib3h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/lib3h/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/lib3h/languages","stargazers_url":"https://api.github.com/repos/holochain/lib3h/stargazers","contributors_url":"https://api.github.com/repos/holochain/lib3h/contributors","subscribers_url":"https://api.github.com/repos/holochain/lib3h/subscribers","subscription_url":"https://api.github.com/repos/holochain/lib3h/subscription","commits_url":"https://api.github.com/repos/holochain/lib3h/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/lib3h/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/lib3h/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/lib3h/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/lib3h/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/lib3h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/lib3h/merges","archive_url":"https://api.github.com/repos/holochain/lib3h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/lib3h/downloads","issues_url":"https://api.github.com/repos/holochain/lib3h/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/lib3h/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/lib3h/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/lib3h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/lib3h/labels{/name}","releases_url":"https://api.github.com/repos/holochain/lib3h/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/lib3h/deployments","created_at":"2018-06-27T02:02:15Z","updated_at":"2019-09-18T00:49:25Z","pushed_at":"2019-09-18T21:28:48Z","git_url":"git://github.com/holochain/lib3h.git","ssh_url":"git@github.com:holochain/lib3h.git","clone_url":"https://github.com/holochain/lib3h.git","svn_url":"https://github.com/holochain/lib3h","homepage":"","size":2857,"stargazers_count":15,"watchers_count":15,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":95,"watchers":15,"default_branch":"develop"}},"base":{"label":"holochain:ghost-actor","ref":"ghost-actor","sha":"f619e1d29a2b00cc8755a06a2af2953f6b6ceb48","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":138816641,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4MTY2NDE=","name":"lib3h","full_name":"holochain/lib3h","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/lib3h","description":"The lib3h p2p communication rust library.","fork":false,"url":"https://api.github.com/repos/holochain/lib3h","forks_url":"https://api.github.com/repos/holochain/lib3h/forks","keys_url":"https://api.github.com/repos/holochain/lib3h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/lib3h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/lib3h/teams","hooks_url":"https://api.github.com/repos/holochain/lib3h/hooks","issue_events_url":"https://api.github.com/repos/holochain/lib3h/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/lib3h/events","assignees_url":"https://api.github.com/repos/holochain/lib3h/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/lib3h/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/lib3h/tags","blobs_url":"https://api.github.com/repos/holochain/lib3h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/lib3h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/lib3h/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/lib3h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/lib3h/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/lib3h/languages","stargazers_url":"https://api.github.com/repos/holochain/lib3h/stargazers","contributors_url":"https://api.github.com/repos/holochain/lib3h/contributors","subscribers_url":"https://api.github.com/repos/holochain/lib3h/subscribers","subscription_url":"https://api.github.com/repos/holochain/lib3h/subscription","commits_url":"https://api.github.com/repos/holochain/lib3h/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/lib3h/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/lib3h/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/lib3h/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/lib3h/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/lib3h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/lib3h/merges","archive_url":"https://api.github.com/repos/holochain/lib3h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/lib3h/downloads","issues_url":"https://api.github.com/repos/holochain/lib3h/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/lib3h/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/lib3h/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/lib3h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/lib3h/labels{/name}","releases_url":"https://api.github.com/repos/holochain/lib3h/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/lib3h/deployments","created_at":"2018-06-27T02:02:15Z","updated_at":"2019-09-18T00:49:25Z","pushed_at":"2019-09-18T21:28:48Z","git_url":"git://github.com/holochain/lib3h.git","ssh_url":"git@github.com:holochain/lib3h.git","clone_url":"https://github.com/holochain/lib3h.git","svn_url":"https://github.com/holochain/lib3h","homepage":"","size":2857,"stargazers_count":15,"watchers_count":15,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":95,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/holochain/lib3h/pulls/366"},"html":{"href":"https://github.com/holochain/lib3h/pull/366"},"issue":{"href":"https://api.github.com/repos/holochain/lib3h/issues/366"},"comments":{"href":"https://api.github.com/repos/holochain/lib3h/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/holochain/lib3h/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/holochain/lib3h/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holochain/lib3h/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/holochain/lib3h/statuses/06863289c4baed2f1cbfedc0b09a63c120875a2b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"struktured"}}