{"action":"created","issue":{"url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/1501","repository_url":"https://api.github.com/repos/Qiskit/qiskit-terra","labels_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/1501/labels{/name}","comments_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/1501/comments","events_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/1501/events","html_url":"https://github.com/Qiskit/qiskit-terra/issues/1501","id":391403155,"node_id":"MDU6SXNzdWUzOTE0MDMxNTU=","number":1501,"title":"Need a DAG edge remover/detector","user":{"login":"godott","id":1732818,"node_id":"MDQ6VXNlcjE3MzI4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1732818?v=4","gravatar_id":"","url":"https://api.github.com/users/godott","html_url":"https://github.com/godott","followers_url":"https://api.github.com/users/godott/followers","following_url":"https://api.github.com/users/godott/following{/other_user}","gists_url":"https://api.github.com/users/godott/gists{/gist_id}","starred_url":"https://api.github.com/users/godott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godott/subscriptions","organizations_url":"https://api.github.com/users/godott/orgs","repos_url":"https://api.github.com/users/godott/repos","events_url":"https://api.github.com/users/godott/events{/privacy}","received_events_url":"https://api.github.com/users/godott/received_events","type":"User","site_admin":false},"labels":[{"id":552526583,"node_id":"MDU6TGFiZWw1NTI1MjY1ODM=","url":"https://api.github.com/repos/Qiskit/qiskit-terra/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":933835135,"node_id":"MDU6TGFiZWw5MzM4MzUxMzU=","url":"https://api.github.com/repos/Qiskit/qiskit-terra/labels/wont%20fix","name":"wont fix","color":"ffffff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-15T19:00:13Z","updated_at":"2019-03-09T08:09:02Z","closed_at":"2019-03-08T16:19:39Z","author_association":"CONTRIBUTOR","body":"<!-- ⚠️ If you do not respect this template, your issue will be closed -->\r\n<!-- ⚠️ Make sure to browse the opened and closed issues to confirm this idea does not exist. -->\r\n\r\n1. Right now if there are two edges between two nodes(can happen between two CNOTs share two common qubits), dag.multi_graph.remove_edge(node1, nod2) can't specify which one to remove.\r\n2. dag.multi_graph.has_edge(node1, node2) can only tell if there's an edge between two nodes, but can't tell if there's an edge between the two nodes on a particular qubit wire.\r\n\r\n### What is the expected behavior?\r\n1. Given two nodes we can remove any subset of edges between them.\r\n2. Given two nodes we can tell if there is an edge on a particular qubit-wire.\r\n"},"comment":{"url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/comments/471156641","html_url":"https://github.com/Qiskit/qiskit-terra/issues/1501#issuecomment-471156641","issue_url":"https://api.github.com/repos/Qiskit/qiskit-terra/issues/1501","id":471156641,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTE1NjY0MQ==","user":{"login":"ajavadia","id":8622381,"node_id":"MDQ6VXNlcjg2MjIzODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8622381?v=4","gravatar_id":"","url":"https://api.github.com/users/ajavadia","html_url":"https://github.com/ajavadia","followers_url":"https://api.github.com/users/ajavadia/followers","following_url":"https://api.github.com/users/ajavadia/following{/other_user}","gists_url":"https://api.github.com/users/ajavadia/gists{/gist_id}","starred_url":"https://api.github.com/users/ajavadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajavadia/subscriptions","organizations_url":"https://api.github.com/users/ajavadia/orgs","repos_url":"https://api.github.com/users/ajavadia/repos","events_url":"https://api.github.com/users/ajavadia/events{/privacy}","received_events_url":"https://api.github.com/users/ajavadia/received_events","type":"User","site_admin":false},"created_at":"2019-03-09T08:09:02Z","updated_at":"2019-03-09T08:09:02Z","author_association":"MEMBER","body":"@godott Luciano is right that the \"DAG\" should be a dataflow graph, showing the wires on which information flows from gate to gate. We need to create a separate \"dependency graph\" for commutations, but not modify the DAG in this way. A CNOT with one edge will be invalid in the DAG, but ok in the dependency graph.\r\n\r\n@1ucian0 But I don't think we should remove the edge detector. That will not create invalid DAGs, and is needed for the commutation analysis to create that dependency graph."}}
{"actor":{"display_login":"ajavadia"}}