{"action":"created","comment":{"url":"https://api.github.com/repos/binast/binjs-ref/pulls/comments/257923103","pull_request_review_id":205069120,"id":257923103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzkyMzEwMw==","diff_hunk":"@@ -0,0 +1,13 @@\n+// Extensions to the webidl.\n+//\n+// These extensions are not part of the AST spec, but of the compression mechanism.\n+\n+[ExtendsTypeSum=Expression]\n+// An extension to `Expression` used to locally change probability tables.\n+interface BinASTExpressionWithProbabilityTable {","path":"spec/es6-extension.webidl","position":7,"original_position":7,"commit_id":"7c04fd19b03c52d64da868e5fbf72a9106a9a58b","original_commit_id":"7c04fd19b03c52d64da868e5fbf72a9106a9a58b","user":{"login":"Yoric","id":10190,"node_id":"MDQ6VXNlcjEwMTkw","avatar_url":"https://avatars1.githubusercontent.com/u/10190?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"body":"Ok, attempting to clarify.\r\n\r\nIn practice, the decoder will need to handle decompression of `BinASTExpressionWithProbabilityTable`. This should hopefully be a trivial rule.","created_at":"2019-02-19T07:57:35Z","updated_at":"2019-02-19T07:57:35Z","html_url":"https://github.com/binast/binjs-ref/pull/309#discussion_r257923103","pull_request_url":"https://api.github.com/repos/binast/binjs-ref/pulls/309","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/binast/binjs-ref/pulls/comments/257923103"},"html":{"href":"https://github.com/binast/binjs-ref/pull/309#discussion_r257923103"},"pull_request":{"href":"https://api.github.com/repos/binast/binjs-ref/pulls/309"}},"in_reply_to_id":257835380},"pull_request":{"url":"https://api.github.com/repos/binast/binjs-ref/pulls/309","id":253843212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzODQzMjEy","html_url":"https://github.com/binast/binjs-ref/pull/309","diff_url":"https://github.com/binast/binjs-ref/pull/309.diff","patch_url":"https://github.com/binast/binjs-ref/pull/309.patch","issue_url":"https://api.github.com/repos/binast/binjs-ref/issues/309","number":309,"state":"open","locked":false,"title":"Issue #296 - Extending the webidl with a secondary file.","user":{"login":"Yoric","id":10190,"node_id":"MDQ6VXNlcjEwMTkw","avatar_url":"https://avatars1.githubusercontent.com/u/10190?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"body":"This patch adds support for extending es6.webidl with an additional file es6-extension.webidl. The role of that file is to modify the AST in a manner that is useful for *compression* but has no impact on visible *syntax and semantics* of the language. In other words, es6.webidl is meant to be part of the BinAST language specification, while es6-extension.webidl is meant to be part of the compression format.\r\n\r\nThe main objective of this patch is to let us adopt specialized compression dictionaries for e.g. JSON, arithmetic expressions, etc.","created_at":"2019-02-18T09:37:49Z","updated_at":"2019-02-19T07:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c6fab7e0a6b36b81b1aae9354b06ecac986dbce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binast/binjs-ref/pulls/309/commits","review_comments_url":"https://api.github.com/repos/binast/binjs-ref/pulls/309/comments","review_comment_url":"https://api.github.com/repos/binast/binjs-ref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binast/binjs-ref/issues/309/comments","statuses_url":"https://api.github.com/repos/binast/binjs-ref/statuses/7c04fd19b03c52d64da868e5fbf72a9106a9a58b","head":{"label":"Yoric:entropy-0.4-sublanguage","ref":"entropy-0.4-sublanguage","sha":"7c04fd19b03c52d64da868e5fbf72a9106a9a58b","user":{"login":"Yoric","id":10190,"node_id":"MDQ6VXNlcjEwMTkw","avatar_url":"https://avatars1.githubusercontent.com/u/10190?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"repo":{"id":151379140,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEzNzkxNDA=","name":"binjs-ref","full_name":"Yoric/binjs-ref","private":false,"owner":{"login":"Yoric","id":10190,"node_id":"MDQ6VXNlcjEwMTkw","avatar_url":"https://avatars1.githubusercontent.com/u/10190?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Yoric/binjs-ref","description":"Reference implementation for the JavaScript Binary AST format","fork":true,"url":"https://api.github.com/repos/Yoric/binjs-ref","forks_url":"https://api.github.com/repos/Yoric/binjs-ref/forks","keys_url":"https://api.github.com/repos/Yoric/binjs-ref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoric/binjs-ref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoric/binjs-ref/teams","hooks_url":"https://api.github.com/repos/Yoric/binjs-ref/hooks","issue_events_url":"https://api.github.com/repos/Yoric/binjs-ref/issues/events{/number}","events_url":"https://api.github.com/repos/Yoric/binjs-ref/events","assignees_url":"https://api.github.com/repos/Yoric/binjs-ref/assignees{/user}","branches_url":"https://api.github.com/repos/Yoric/binjs-ref/branches{/branch}","tags_url":"https://api.github.com/repos/Yoric/binjs-ref/tags","blobs_url":"https://api.github.com/repos/Yoric/binjs-ref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoric/binjs-ref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoric/binjs-ref/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoric/binjs-ref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoric/binjs-ref/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoric/binjs-ref/languages","stargazers_url":"https://api.github.com/repos/Yoric/binjs-ref/stargazers","contributors_url":"https://api.github.com/repos/Yoric/binjs-ref/contributors","subscribers_url":"https://api.github.com/repos/Yoric/binjs-ref/subscribers","subscription_url":"https://api.github.com/repos/Yoric/binjs-ref/subscription","commits_url":"https://api.github.com/repos/Yoric/binjs-ref/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoric/binjs-ref/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoric/binjs-ref/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoric/binjs-ref/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoric/binjs-ref/contents/{+path}","compare_url":"https://api.github.com/repos/Yoric/binjs-ref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoric/binjs-ref/merges","archive_url":"https://api.github.com/repos/Yoric/binjs-ref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoric/binjs-ref/downloads","issues_url":"https://api.github.com/repos/Yoric/binjs-ref/issues{/number}","pulls_url":"https://api.github.com/repos/Yoric/binjs-ref/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoric/binjs-ref/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoric/binjs-ref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoric/binjs-ref/labels{/name}","releases_url":"https://api.github.com/repos/Yoric/binjs-ref/releases{/id}","deployments_url":"https://api.github.com/repos/Yoric/binjs-ref/deployments","created_at":"2018-10-03T07:56:02Z","updated_at":"2018-11-16T10:54:36Z","pushed_at":"2019-02-18T20:31:03Z","git_url":"git://github.com/Yoric/binjs-ref.git","ssh_url":"git@github.com:Yoric/binjs-ref.git","clone_url":"https://github.com/Yoric/binjs-ref.git","svn_url":"https://github.com/Yoric/binjs-ref","homepage":"https://binast.github.io/binjs-ref/binjs/index.html","size":53161,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binast:master","ref":"master","sha":"1ca04298bca5c651e82d56eeee53260b2e5aa1af","user":{"login":"binast","id":34548197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTQ4MTk3","avatar_url":"https://avatars3.githubusercontent.com/u/34548197?v=4","gravatar_id":"","url":"https://api.github.com/users/binast","html_url":"https://github.com/binast","followers_url":"https://api.github.com/users/binast/followers","following_url":"https://api.github.com/users/binast/following{/other_user}","gists_url":"https://api.github.com/users/binast/gists{/gist_id}","starred_url":"https://api.github.com/users/binast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binast/subscriptions","organizations_url":"https://api.github.com/users/binast/orgs","repos_url":"https://api.github.com/users/binast/repos","events_url":"https://api.github.com/users/binast/events{/privacy}","received_events_url":"https://api.github.com/users/binast/received_events","type":"Organization","site_admin":false},"repo":{"id":90141336,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE0MTMzNg==","name":"binjs-ref","full_name":"binast/binjs-ref","private":false,"owner":{"login":"binast","id":34548197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTQ4MTk3","avatar_url":"https://avatars3.githubusercontent.com/u/34548197?v=4","gravatar_id":"","url":"https://api.github.com/users/binast","html_url":"https://github.com/binast","followers_url":"https://api.github.com/users/binast/followers","following_url":"https://api.github.com/users/binast/following{/other_user}","gists_url":"https://api.github.com/users/binast/gists{/gist_id}","starred_url":"https://api.github.com/users/binast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binast/subscriptions","organizations_url":"https://api.github.com/users/binast/orgs","repos_url":"https://api.github.com/users/binast/repos","events_url":"https://api.github.com/users/binast/events{/privacy}","received_events_url":"https://api.github.com/users/binast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binast/binjs-ref","description":"Reference implementation for the JavaScript Binary AST format","fork":false,"url":"https://api.github.com/repos/binast/binjs-ref","forks_url":"https://api.github.com/repos/binast/binjs-ref/forks","keys_url":"https://api.github.com/repos/binast/binjs-ref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binast/binjs-ref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binast/binjs-ref/teams","hooks_url":"https://api.github.com/repos/binast/binjs-ref/hooks","issue_events_url":"https://api.github.com/repos/binast/binjs-ref/issues/events{/number}","events_url":"https://api.github.com/repos/binast/binjs-ref/events","assignees_url":"https://api.github.com/repos/binast/binjs-ref/assignees{/user}","branches_url":"https://api.github.com/repos/binast/binjs-ref/branches{/branch}","tags_url":"https://api.github.com/repos/binast/binjs-ref/tags","blobs_url":"https://api.github.com/repos/binast/binjs-ref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binast/binjs-ref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binast/binjs-ref/git/refs{/sha}","trees_url":"https://api.github.com/repos/binast/binjs-ref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binast/binjs-ref/statuses/{sha}","languages_url":"https://api.github.com/repos/binast/binjs-ref/languages","stargazers_url":"https://api.github.com/repos/binast/binjs-ref/stargazers","contributors_url":"https://api.github.com/repos/binast/binjs-ref/contributors","subscribers_url":"https://api.github.com/repos/binast/binjs-ref/subscribers","subscription_url":"https://api.github.com/repos/binast/binjs-ref/subscription","commits_url":"https://api.github.com/repos/binast/binjs-ref/commits{/sha}","git_commits_url":"https://api.github.com/repos/binast/binjs-ref/git/commits{/sha}","comments_url":"https://api.github.com/repos/binast/binjs-ref/comments{/number}","issue_comment_url":"https://api.github.com/repos/binast/binjs-ref/issues/comments{/number}","contents_url":"https://api.github.com/repos/binast/binjs-ref/contents/{+path}","compare_url":"https://api.github.com/repos/binast/binjs-ref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binast/binjs-ref/merges","archive_url":"https://api.github.com/repos/binast/binjs-ref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binast/binjs-ref/downloads","issues_url":"https://api.github.com/repos/binast/binjs-ref/issues{/number}","pulls_url":"https://api.github.com/repos/binast/binjs-ref/pulls{/number}","milestones_url":"https://api.github.com/repos/binast/binjs-ref/milestones{/number}","notifications_url":"https://api.github.com/repos/binast/binjs-ref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binast/binjs-ref/labels{/name}","releases_url":"https://api.github.com/repos/binast/binjs-ref/releases{/id}","deployments_url":"https://api.github.com/repos/binast/binjs-ref/deployments","created_at":"2017-05-03T11:25:08Z","updated_at":"2019-02-18T22:23:43Z","pushed_at":"2019-02-18T23:29:01Z","git_url":"git://github.com/binast/binjs-ref.git","ssh_url":"git@github.com:binast/binjs-ref.git","clone_url":"https://github.com/binast/binjs-ref.git","svn_url":"https://github.com/binast/binjs-ref","homepage":"https://binast.github.io/binjs-ref/binjs/index.html","size":43894,"stargazers_count":75,"watchers_count":75,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":93,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binast/binjs-ref/pulls/309"},"html":{"href":"https://github.com/binast/binjs-ref/pull/309"},"issue":{"href":"https://api.github.com/repos/binast/binjs-ref/issues/309"},"comments":{"href":"https://api.github.com/repos/binast/binjs-ref/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/binast/binjs-ref/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/binast/binjs-ref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binast/binjs-ref/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/binast/binjs-ref/statuses/7c04fd19b03c52d64da868e5fbf72a9106a9a58b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Yoric"}}