{"action":"closed","number":314,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/314","id":254666295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NjY2Mjk1","html_url":"https://github.com/DataDog/dd-trace-php/pull/314","diff_url":"https://github.com/DataDog/dd-trace-php/pull/314.diff","patch_url":"https://github.com/DataDog/dd-trace-php/pull/314.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues/314","number":314,"state":"closed","locked":false,"title":"Fix accessing freed memory when instrumentation code un/instrumented itself ","user":{"login":"pawelchcki","id":812891,"node_id":"MDQ6VXNlcjgxMjg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/812891?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelchcki","html_url":"https://github.com/pawelchcki","followers_url":"https://api.github.com/users/pawelchcki/followers","following_url":"https://api.github.com/users/pawelchcki/following{/other_user}","gists_url":"https://api.github.com/users/pawelchcki/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelchcki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelchcki/subscriptions","organizations_url":"https://api.github.com/users/pawelchcki/orgs","repos_url":"https://api.github.com/users/pawelchcki/repos","events_url":"https://api.github.com/users/pawelchcki/events{/privacy}","received_events_url":"https://api.github.com/users/pawelchcki/received_events","type":"User","site_admin":false},"body":"### Description\r\nIn rare cases where instrumented code have actually removed/changed existing instrumentation of its own execution a freed pointer was accessed when removing recursion guard. \r\n\r\n### Readiness checklist\r\n- [x] [Changelog entry](docs/changelog.md) added, if necessary\r\n- [x] Tests added for this feature/bug\r\n","created_at":"2019-02-20T14:48:30Z","updated_at":"2019-02-20T16:05:47Z","closed_at":"2019-02-20T16:05:46Z","merged_at":"2019-02-20T16:05:46Z","merge_commit_sha":"4188827531428fb3c22e09e44f3b8181caeace34","assignee":{"login":"SammyK","id":578780,"node_id":"MDQ6VXNlcjU3ODc4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/578780?v=4","gravatar_id":"","url":"https://api.github.com/users/SammyK","html_url":"https://github.com/SammyK","followers_url":"https://api.github.com/users/SammyK/followers","following_url":"https://api.github.com/users/SammyK/following{/other_user}","gists_url":"https://api.github.com/users/SammyK/gists{/gist_id}","starred_url":"https://api.github.com/users/SammyK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SammyK/subscriptions","organizations_url":"https://api.github.com/users/SammyK/orgs","repos_url":"https://api.github.com/users/SammyK/repos","events_url":"https://api.github.com/users/SammyK/events{/privacy}","received_events_url":"https://api.github.com/users/SammyK/received_events","type":"User","site_admin":false},"assignees":[{"login":"SammyK","id":578780,"node_id":"MDQ6VXNlcjU3ODc4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/578780?v=4","gravatar_id":"","url":"https://api.github.com/users/SammyK","html_url":"https://github.com/SammyK","followers_url":"https://api.github.com/users/SammyK/followers","following_url":"https://api.github.com/users/SammyK/following{/other_user}","gists_url":"https://api.github.com/users/SammyK/gists{/gist_id}","starred_url":"https://api.github.com/users/SammyK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SammyK/subscriptions","organizations_url":"https://api.github.com/users/SammyK/orgs","repos_url":"https://api.github.com/users/SammyK/repos","events_url":"https://api.github.com/users/SammyK/events{/privacy}","received_events_url":"https://api.github.com/users/SammyK/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1179163373,"node_id":"MDU6TGFiZWwxMTc5MTYzMzcz","url":"https://api.github.com/repos/DataDog/dd-trace-php/labels/c-extension","name":"c-extension","color":"b6f94a","default":false},{"id":824958542,"node_id":"MDU6TGFiZWw4MjQ5NTg1NDI=","url":"https://api.github.com/repos/DataDog/dd-trace-php/labels/%F0%9F%90%9B%20bug","name":"🐛 bug","color":"d73a4a","default":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-trace-php/milestones/28","html_url":"https://github.com/DataDog/dd-trace-php/milestone/28","labels_url":"https://api.github.com/repos/DataDog/dd-trace-php/milestones/28/labels","id":4073004,"node_id":"MDk6TWlsZXN0b25lNDA3MzAwNA==","number":28,"title":"0.13.4","description":"","creator":{"login":"pawelchcki","id":812891,"node_id":"MDQ6VXNlcjgxMjg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/812891?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelchcki","html_url":"https://github.com/pawelchcki","followers_url":"https://api.github.com/users/pawelchcki/followers","following_url":"https://api.github.com/users/pawelchcki/following{/other_user}","gists_url":"https://api.github.com/users/pawelchcki/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelchcki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelchcki/subscriptions","organizations_url":"https://api.github.com/users/pawelchcki/orgs","repos_url":"https://api.github.com/users/pawelchcki/repos","events_url":"https://api.github.com/users/pawelchcki/events{/privacy}","received_events_url":"https://api.github.com/users/pawelchcki/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2019-02-20T14:51:08Z","updated_at":"2019-02-20T16:05:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/314/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/314/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues/314/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-php/statuses/ecc465559769ed17e89bdff37686ebdb70906622","head":{"label":"DataDog:make_dispatch_pointer_a_smart_pointer","ref":"make_dispatch_pointer_a_smart_pointer","sha":"ecc465559769ed17e89bdff37686ebdb70906622","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":119990860,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5OTA4NjA=","name":"dd-trace-php","full_name":"DataDog/dd-trace-php","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-php","description":"Datadog Tracing PHP Client (Beta)","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-php","forks_url":"https://api.github.com/repos/DataDog/dd-trace-php/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-php/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-php/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-php/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-php/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-php/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-php/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-php/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-php/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-php/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-php/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-php/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-php/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-php/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-php/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-php/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-php/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-php/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-php/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-php/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-php/deployments","created_at":"2018-02-02T14:21:54Z","updated_at":"2019-02-19T20:54:50Z","pushed_at":"2019-02-20T16:05:46Z","git_url":"git://github.com/DataDog/dd-trace-php.git","ssh_url":"git@github.com:DataDog/dd-trace-php.git","clone_url":"https://github.com/DataDog/dd-trace-php.git","svn_url":"https://github.com/DataDog/dd-trace-php","homepage":"https://docs.datadoghq.com/tracing/setup/php","size":14593,"stargazers_count":75,"watchers_count":75,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":22,"open_issues":21,"watchers":75,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"2f8c70864c0d88e47ce445e2cdc1cdbb3990b8d3","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":119990860,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5OTA4NjA=","name":"dd-trace-php","full_name":"DataDog/dd-trace-php","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/dd-trace-php","description":"Datadog Tracing PHP Client (Beta)","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-php","forks_url":"https://api.github.com/repos/DataDog/dd-trace-php/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-php/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-php/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-php/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-php/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-php/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-php/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-php/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-php/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-php/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-php/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-php/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-php/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-php/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-php/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-php/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-php/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-php/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-php/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-php/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-php/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-php/deployments","created_at":"2018-02-02T14:21:54Z","updated_at":"2019-02-19T20:54:50Z","pushed_at":"2019-02-20T16:05:46Z","git_url":"git://github.com/DataDog/dd-trace-php.git","ssh_url":"git@github.com:DataDog/dd-trace-php.git","clone_url":"https://github.com/DataDog/dd-trace-php.git","svn_url":"https://github.com/DataDog/dd-trace-php","homepage":"https://docs.datadoghq.com/tracing/setup/php","size":14593,"stargazers_count":75,"watchers_count":75,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":22,"open_issues":21,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/314"},"html":{"href":"https://github.com/DataDog/dd-trace-php/pull/314"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/issues/314"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-php/statuses/ecc465559769ed17e89bdff37686ebdb70906622"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pawelchcki","id":812891,"node_id":"MDQ6VXNlcjgxMjg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/812891?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelchcki","html_url":"https://github.com/pawelchcki","followers_url":"https://api.github.com/users/pawelchcki/followers","following_url":"https://api.github.com/users/pawelchcki/following{/other_user}","gists_url":"https://api.github.com/users/pawelchcki/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelchcki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelchcki/subscriptions","organizations_url":"https://api.github.com/users/pawelchcki/orgs","repos_url":"https://api.github.com/users/pawelchcki/repos","events_url":"https://api.github.com/users/pawelchcki/events{/privacy}","received_events_url":"https://api.github.com/users/pawelchcki/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":4,"additions":65,"deletions":22,"changed_files":8}}
{"actor":{"display_login":"pawelchcki"}}