{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/344971917","pull_request_review_id":315236465,"id":344971917,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDk3MTkxNw==","diff_hunk":"@@ -393,15 +404,20 @@ public function columnSql(TableSchema $schema, string $name): string\n             $out .= '(' . $data['length'] . ')';\n         }\n \n-        $hasPrecision = [TableSchema::TYPE_FLOAT, TableSchema::TYPE_DECIMAL];\n-        if (in_array($data['type'], $hasPrecision, true) && isset($data['length'])) {\n+        $hasLengthAndPrecision = [TableSchema::TYPE_FLOAT, TableSchema::TYPE_DECIMAL];\n+        if (in_array($data['type'], $hasLengthAndPrecision, true) && isset($data['length'])) {\n             if (isset($data['precision'])) {\n                 $out .= '(' . (int)$data['length'] . ',' . (int)$data['precision'] . ')';\n             } else {\n                 $out .= '(' . (int)$data['length'] . ')';\n             }\n         }\n \n+        $hasPrecision = [TableSchema::TYPE_DATETIME_FRACTIONAL, TableSchema::TYPE_TIMESTAMP_FRACTIONAL];","path":"src/Database/Schema/MysqlSchema.php","position":45,"original_position":45,"commit_id":"c63778cbcc6baf5905e2b9454e77babd115057d0","original_commit_id":"c63778cbcc6baf5905e2b9454e77babd115057d0","user":{"login":"othercorey","id":24221186,"node_id":"MDQ6VXNlcjI0MjIxMTg2","avatar_url":"https://avatars1.githubusercontent.com/u/24221186?v=4","gravatar_id":"","url":"https://api.github.com/users/othercorey","html_url":"https://github.com/othercorey","followers_url":"https://api.github.com/users/othercorey/followers","following_url":"https://api.github.com/users/othercorey/following{/other_user}","gists_url":"https://api.github.com/users/othercorey/gists{/gist_id}","starred_url":"https://api.github.com/users/othercorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othercorey/subscriptions","organizations_url":"https://api.github.com/users/othercorey/orgs","repos_url":"https://api.github.com/users/othercorey/repos","events_url":"https://api.github.com/users/othercorey/events{/privacy}","received_events_url":"https://api.github.com/users/othercorey/received_events","type":"User","site_admin":false},"body":"I was just following the existing naming.  I can update it.","created_at":"2019-11-12T00:41:40Z","updated_at":"2019-11-12T00:41:40Z","html_url":"https://github.com/cakephp/cakephp/pull/13864#discussion_r344971917","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13864","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/344971917"},"html":{"href":"https://github.com/cakephp/cakephp/pull/13864#discussion_r344971917"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13864"}},"in_reply_to_id":344945336},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/13864","id":338826363,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4ODI2MzYz","html_url":"https://github.com/cakephp/cakephp/pull/13864","diff_url":"https://github.com/cakephp/cakephp/pull/13864.diff","patch_url":"https://github.com/cakephp/cakephp/pull/13864.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/13864","number":13864,"state":"open","locked":false,"title":"4.x - MySQL + PostgreSQL - Mapped DATETIME(N) and TIMESTAMP(N)","user":{"login":"othercorey","id":24221186,"node_id":"MDQ6VXNlcjI0MjIxMTg2","avatar_url":"https://avatars1.githubusercontent.com/u/24221186?v=4","gravatar_id":"","url":"https://api.github.com/users/othercorey","html_url":"https://github.com/othercorey","followers_url":"https://api.github.com/users/othercorey/followers","following_url":"https://api.github.com/users/othercorey/following{/other_user}","gists_url":"https://api.github.com/users/othercorey/gists{/gist_id}","starred_url":"https://api.github.com/users/othercorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othercorey/subscriptions","organizations_url":"https://api.github.com/users/othercorey/orgs","repos_url":"https://api.github.com/users/othercorey/repos","events_url":"https://api.github.com/users/othercorey/events{/privacy}","received_events_url":"https://api.github.com/users/othercorey/received_events","type":"User","site_admin":false},"body":"This adds proper type mapping for the datetime types with precision now that we have a type that supports them.\r\n\r\n**mysql**\r\n``DATETIME`` => ``TYPE_DATETIME``\r\n``DATETIME(0)`` => ``TYPE_DATETIME``\r\n``DATETIME(1-6)`` => ``TYPE_DATETIME_FRACTIONAL``\r\n``TIMESTAMP`` => ``TYPE_TIMESTAMP``\r\n``TIMESTAMP(0)`` => ``TYPE_TIMESTAMP``\r\n``TIMESTAMP(1-6)`` => ``TYPE_TIMESTAMP_FRACTIONAL``\r\n\r\n**postgresql**\r\n``TIMESTAMP`` => ``TYPE_TIMESTAMP_FRACTIONAL``\r\n``TIMESTAMP(0)`` => ``TYPE_TIMESTAMP``\r\n``TIMESTAMP(1-6)`` => ``TYPE_TIMESTAMP_FRACTIONAL``\r\n\r\nIn postgres, ``TIMESTAMP`` without specifying the precision is the same as ``TIMESTAMP(6)``.  This changes the default type to support that as users don't spell out ``TIMESTAMP(6)`` with posgresql.\r\n","created_at":"2019-11-08T19:32:53Z","updated_at":"2019-11-12T00:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed05020b0e33f960dc5afb7507d63470a6ea1a31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":366710731,"node_id":"MDU6TGFiZWwzNjY3MTA3MzE=","url":"https://api.github.com/repos/cakephp/cakephp/labels/database","name":"database","color":"ffffff","default":false},{"id":60504144,"node_id":"MDU6TGFiZWw2MDUwNDE0NA==","url":"https://api.github.com/repos/cakephp/cakephp/labels/enhancement","name":"enhancement","color":"bfe5bf","default":true}],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/105","html_url":"https://github.com/cakephp/cakephp/milestone/105","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/105/labels","id":2023366,"node_id":"MDk6TWlsZXN0b25lMjAyMzM2Ng==","number":105,"title":"4.0.0","description":"4.0.0 is an *API breaking* release. It will:\r\n\r\n* Remove the features deprecated in 3.x.\r\n\r\nCode that works in the latest 3.x with no deprecation warnings should work in 4.0.0 as well.\r\n\r\nSee the roadmap for more information https://github.com/cakephp/cakephp/wiki/4.0-Roadmap","creator":{"login":"markstory","id":24086,"node_id":"MDQ6VXNlcjI0MDg2","avatar_url":"https://avatars3.githubusercontent.com/u/24086?v=4","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":684,"state":"open","created_at":"2016-09-23T01:51:53Z","updated_at":"2019-11-11T07:54:49Z","due_on":"2019-11-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13864/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13864/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/13864/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/c63778cbcc6baf5905e2b9454e77babd115057d0","head":{"label":"othercorey:4.x-fractional-schema","ref":"4.x-fractional-schema","sha":"c63778cbcc6baf5905e2b9454e77babd115057d0","user":{"login":"othercorey","id":24221186,"node_id":"MDQ6VXNlcjI0MjIxMTg2","avatar_url":"https://avatars1.githubusercontent.com/u/24221186?v=4","gravatar_id":"","url":"https://api.github.com/users/othercorey","html_url":"https://github.com/othercorey","followers_url":"https://api.github.com/users/othercorey/followers","following_url":"https://api.github.com/users/othercorey/following{/other_user}","gists_url":"https://api.github.com/users/othercorey/gists{/gist_id}","starred_url":"https://api.github.com/users/othercorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othercorey/subscriptions","organizations_url":"https://api.github.com/users/othercorey/orgs","repos_url":"https://api.github.com/users/othercorey/repos","events_url":"https://api.github.com/users/othercorey/events{/privacy}","received_events_url":"https://api.github.com/users/othercorey/received_events","type":"User","site_admin":false},"repo":{"id":184079878,"node_id":"MDEwOlJlcG9zaXRvcnkxODQwNzk4Nzg=","name":"cakephp","full_name":"othercorey/cakephp","private":false,"owner":{"login":"othercorey","id":24221186,"node_id":"MDQ6VXNlcjI0MjIxMTg2","avatar_url":"https://avatars1.githubusercontent.com/u/24221186?v=4","gravatar_id":"","url":"https://api.github.com/users/othercorey","html_url":"https://github.com/othercorey","followers_url":"https://api.github.com/users/othercorey/followers","following_url":"https://api.github.com/users/othercorey/following{/other_user}","gists_url":"https://api.github.com/users/othercorey/gists{/gist_id}","starred_url":"https://api.github.com/users/othercorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othercorey/subscriptions","organizations_url":"https://api.github.com/users/othercorey/orgs","repos_url":"https://api.github.com/users/othercorey/repos","events_url":"https://api.github.com/users/othercorey/events{/privacy}","received_events_url":"https://api.github.com/users/othercorey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/othercorey/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/othercorey/cakephp","forks_url":"https://api.github.com/repos/othercorey/cakephp/forks","keys_url":"https://api.github.com/repos/othercorey/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/othercorey/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/othercorey/cakephp/teams","hooks_url":"https://api.github.com/repos/othercorey/cakephp/hooks","issue_events_url":"https://api.github.com/repos/othercorey/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/othercorey/cakephp/events","assignees_url":"https://api.github.com/repos/othercorey/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/othercorey/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/othercorey/cakephp/tags","blobs_url":"https://api.github.com/repos/othercorey/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/othercorey/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/othercorey/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/othercorey/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/othercorey/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/othercorey/cakephp/languages","stargazers_url":"https://api.github.com/repos/othercorey/cakephp/stargazers","contributors_url":"https://api.github.com/repos/othercorey/cakephp/contributors","subscribers_url":"https://api.github.com/repos/othercorey/cakephp/subscribers","subscription_url":"https://api.github.com/repos/othercorey/cakephp/subscription","commits_url":"https://api.github.com/repos/othercorey/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/othercorey/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/othercorey/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/othercorey/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/othercorey/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/othercorey/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/othercorey/cakephp/merges","archive_url":"https://api.github.com/repos/othercorey/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/othercorey/cakephp/downloads","issues_url":"https://api.github.com/repos/othercorey/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/othercorey/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/othercorey/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/othercorey/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/othercorey/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/othercorey/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/othercorey/cakephp/deployments","created_at":"2019-04-29T13:49:32Z","updated_at":"2019-11-07T00:52:12Z","pushed_at":"2019-11-11T07:55:22Z","git_url":"git://github.com/othercorey/cakephp.git","ssh_url":"git@github.com:othercorey/cakephp.git","clone_url":"https://github.com/othercorey/cakephp.git","svn_url":"https://github.com/othercorey/cakephp","homepage":"http://cakephp.org","size":88293,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:4.x","ref":"4.x","sha":"a201b570142dee4d24ee3a134f8151764370fe85","user":{"login":"cakephp","id":23666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY2","avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"node_id":"MDEwOlJlcG9zaXRvcnk2NTY0OTQ=","name":"cakephp","full_name":"cakephp/cakephp","private":false,"owner":{"login":"cakephp","id":23666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY2","avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2019-11-11T06:53:20Z","pushed_at":"2019-11-11T18:11:42Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":88320,"stargazers_count":8009,"watchers_count":8009,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3428,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3428,"open_issues":112,"watchers":8009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13864"},"html":{"href":"https://github.com/cakephp/cakephp/pull/13864"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/13864"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/13864/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13864/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13864/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/c63778cbcc6baf5905e2b9454e77babd115057d0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"othercorey"}}