{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/294050597","pull_request_review_id":250196590,"id":294050597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDA1MDU5Nw==","diff_hunk":"@@ -1089,13 +1089,15 @@ def _validate_specification(self):\n                     raise ValueError('len(left_on) must equal the number '\n                                      'of levels in the index of \"right\"')\n                 self.right_on = [None] * n\n+            self.right_on = self.right_on or [None] * len(self.left_on)\n         elif self.right_on is not None:\n             n = len(self.right_on)\n             if self.left_index:\n                 if len(self.right_on) != self.left.index.nlevels:\n                     raise ValueError('len(right_on) must equal the number '\n                                      'of levels in the index of \"left\"')\n                 self.left_on = [None] * n\n+            self.left_on = self.left_on or [None] * len(self.right_on)","path":"pandas/core/reshape/merge.py","position":12,"original_position":12,"commit_id":"639694744d7cd14ed6af905398180747ce7ff247","original_commit_id":"639694744d7cd14ed6af905398180747ce7ff247","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"ok we’ll see if u can simplify things with passing tests ","created_at":"2019-06-15T15:19:20Z","updated_at":"2019-06-15T15:19:21Z","html_url":"https://github.com/pandas-dev/pandas/pull/26855#discussion_r294050597","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/294050597"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/26855#discussion_r294050597"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855"}},"in_reply_to_id":294049524},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855","id":288416542,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NDE2NTQy","html_url":"https://github.com/pandas-dev/pandas/pull/26855","diff_url":"https://github.com/pandas-dev/pandas/pull/26855.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/26855.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/26855","number":26855,"state":"open","locked":false,"title":"BUG:Sanity check on merge parameters for correct exception #26824","user":{"login":"harshit-py","id":28984166,"node_id":"MDQ6VXNlcjI4OTg0MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/28984166?v=4","gravatar_id":"","url":"https://api.github.com/users/harshit-py","html_url":"https://github.com/harshit-py","followers_url":"https://api.github.com/users/harshit-py/followers","following_url":"https://api.github.com/users/harshit-py/following{/other_user}","gists_url":"https://api.github.com/users/harshit-py/gists{/gist_id}","starred_url":"https://api.github.com/users/harshit-py/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshit-py/subscriptions","organizations_url":"https://api.github.com/users/harshit-py/orgs","repos_url":"https://api.github.com/users/harshit-py/repos","events_url":"https://api.github.com/users/harshit-py/events{/privacy}","received_events_url":"https://api.github.com/users/harshit-py/received_events","type":"User","site_admin":false},"body":"- [x] closes #26824\r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry","created_at":"2019-06-14T17:21:57Z","updated_at":"2019-06-15T15:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b8ef12332622f13e6f8aa0a1a95e116b58fb2fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":42670965,"node_id":"MDU6TGFiZWw0MjY3MDk2NQ==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Error%20Reporting","name":"Error Reporting","color":"ffa0ff","default":false}],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/61","html_url":"https://github.com/pandas-dev/pandas/milestone/61","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/61/labels","id":3759483,"node_id":"MDk6TWlsZXN0b25lMzc1OTQ4Mw==","number":61,"title":"0.25.0","description":"","creator":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":939,"state":"open","created_at":"2018-10-23T02:34:15Z","updated_at":"2019-06-15T14:09:42Z","due_on":"2019-07-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/26855/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/639694744d7cd14ed6af905398180747ce7ff247","head":{"label":"harshit-py:merge_py_bug","ref":"merge_py_bug","sha":"639694744d7cd14ed6af905398180747ce7ff247","user":{"login":"harshit-py","id":28984166,"node_id":"MDQ6VXNlcjI4OTg0MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/28984166?v=4","gravatar_id":"","url":"https://api.github.com/users/harshit-py","html_url":"https://github.com/harshit-py","followers_url":"https://api.github.com/users/harshit-py/followers","following_url":"https://api.github.com/users/harshit-py/following{/other_user}","gists_url":"https://api.github.com/users/harshit-py/gists{/gist_id}","starred_url":"https://api.github.com/users/harshit-py/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshit-py/subscriptions","organizations_url":"https://api.github.com/users/harshit-py/orgs","repos_url":"https://api.github.com/users/harshit-py/repos","events_url":"https://api.github.com/users/harshit-py/events{/privacy}","received_events_url":"https://api.github.com/users/harshit-py/received_events","type":"User","site_admin":false},"repo":{"id":189452042,"node_id":"MDEwOlJlcG9zaXRvcnkxODk0NTIwNDI=","name":"pandas","full_name":"harshit-py/pandas","private":false,"owner":{"login":"harshit-py","id":28984166,"node_id":"MDQ6VXNlcjI4OTg0MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/28984166?v=4","gravatar_id":"","url":"https://api.github.com/users/harshit-py","html_url":"https://github.com/harshit-py","followers_url":"https://api.github.com/users/harshit-py/followers","following_url":"https://api.github.com/users/harshit-py/following{/other_user}","gists_url":"https://api.github.com/users/harshit-py/gists{/gist_id}","starred_url":"https://api.github.com/users/harshit-py/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshit-py/subscriptions","organizations_url":"https://api.github.com/users/harshit-py/orgs","repos_url":"https://api.github.com/users/harshit-py/repos","events_url":"https://api.github.com/users/harshit-py/events{/privacy}","received_events_url":"https://api.github.com/users/harshit-py/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harshit-py/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/harshit-py/pandas","forks_url":"https://api.github.com/repos/harshit-py/pandas/forks","keys_url":"https://api.github.com/repos/harshit-py/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshit-py/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshit-py/pandas/teams","hooks_url":"https://api.github.com/repos/harshit-py/pandas/hooks","issue_events_url":"https://api.github.com/repos/harshit-py/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/harshit-py/pandas/events","assignees_url":"https://api.github.com/repos/harshit-py/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/harshit-py/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/harshit-py/pandas/tags","blobs_url":"https://api.github.com/repos/harshit-py/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshit-py/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshit-py/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshit-py/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshit-py/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/harshit-py/pandas/languages","stargazers_url":"https://api.github.com/repos/harshit-py/pandas/stargazers","contributors_url":"https://api.github.com/repos/harshit-py/pandas/contributors","subscribers_url":"https://api.github.com/repos/harshit-py/pandas/subscribers","subscription_url":"https://api.github.com/repos/harshit-py/pandas/subscription","commits_url":"https://api.github.com/repos/harshit-py/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshit-py/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshit-py/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshit-py/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshit-py/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/harshit-py/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshit-py/pandas/merges","archive_url":"https://api.github.com/repos/harshit-py/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshit-py/pandas/downloads","issues_url":"https://api.github.com/repos/harshit-py/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/harshit-py/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/harshit-py/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/harshit-py/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshit-py/pandas/labels{/name}","releases_url":"https://api.github.com/repos/harshit-py/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/harshit-py/pandas/deployments","created_at":"2019-05-30T17:04:23Z","updated_at":"2019-05-30T17:04:32Z","pushed_at":"2019-06-15T14:40:09Z","git_url":"git://github.com/harshit-py/pandas.git","ssh_url":"git@github.com:harshit-py/pandas.git","clone_url":"https://github.com/harshit-py/pandas.git","svn_url":"https://github.com/harshit-py/pandas","homepage":"https://pandas.pydata.org","size":158871,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"430f0fd04646a0ab44ccbfbad706dfe22e9fabfe","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2019-06-15T13:16:47Z","pushed_at":"2019-06-15T14:40:13Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":158971,"stargazers_count":19921,"watchers_count":19921,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7896,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3038,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":7896,"open_issues":3038,"watchers":19921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/26855"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/26855"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/26855/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/26855/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/639694744d7cd14ed6af905398180747ce7ff247"}},"author_association":"NONE"}}
{"actor":{"display_login":"jreback"}}