{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-go/pulls/comments/353973412","pull_request_review_id":327141535,"id":353973412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mzk3MzQxMg==","diff_hunk":"@@ -374,10 +413,20 @@ func (c Client) setVersioning(bucketName string, config []byte, length int64, md\n \n // EnableVersioning - Enable object versioning in given bucket.\n func (c Client) EnableVersioning(bucketName string) error {\n-\treturn c.setVersioning(bucketName, versionEnableConfig, versionEnableConfigLen, versionEnableConfigMD5Sum, versionEnableConfigSHA256)\n+\treturn c.EnableVersioningWithContext(context.Background(), bucketName)\n+}\n+\n+// EnableVersioning - Enable object versioning in given bucket with a context to control cancellations and timeouts.\n+func (c Client) EnableVersioningWithContext(ctx context.Context, bucketName string) error {\n+\treturn c.setVersioning(ctx, bucketName, versionEnableConfig, versionEnableConfigLen, versionEnableConfigMD5Sum, versionEnableConfigSHA256)\n }\n \n // DisableVersioning - Disable object versioning in given bucket.\n func (c Client) DisableVersioning(bucketName string) error {\n-\treturn c.setVersioning(bucketName, versionDisableConfig, versionDisableConfigLen, versionDisableConfigMD5Sum, versionDisableConfigSHA256)\n+\treturn c.DisableVersioningWithContext(context.Background(), bucketName)\n+}\n+\n+// DisableVersioning - Disable object versioning in given bucket with a context to control cancellations and timeouts.","path":"api-put-bucket.go","position":231,"original_position":231,"commit_id":"36a8fb4266ff09c7a2a0777e41c329e07fe67d98","original_commit_id":"36a8fb4266ff09c7a2a0777e41c329e07fe67d98","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"comment on exported method Client.DisableVersioningWithContext should be of the form \"DisableVersioningWithContext ...\"","created_at":"2019-12-04T20:46:08Z","updated_at":"2019-12-04T20:46:10Z","html_url":"https://github.com/minio/minio-go/pull/1192#discussion_r353973412","pull_request_url":"https://api.github.com/repos/minio/minio-go/pulls/1192","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments/353973412"},"html":{"href":"https://github.com/minio/minio-go/pull/1192#discussion_r353973412"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-go/pulls/1192"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio-go/pulls/1192","id":349051265,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5MDUxMjY1","html_url":"https://github.com/minio/minio-go/pull/1192","diff_url":"https://github.com/minio/minio-go/pull/1192.diff","patch_url":"https://github.com/minio/minio-go/pull/1192.patch","issue_url":"https://api.github.com/repos/minio/minio-go/issues/1192","number":1192,"state":"open","locked":false,"title":"Support for Context on Bucket Operations","user":{"login":"dvaldivia","id":18384552,"node_id":"MDQ6VXNlcjE4Mzg0NTUy","avatar_url":"https://avatars3.githubusercontent.com/u/18384552?v=4","gravatar_id":"","url":"https://api.github.com/users/dvaldivia","html_url":"https://github.com/dvaldivia","followers_url":"https://api.github.com/users/dvaldivia/followers","following_url":"https://api.github.com/users/dvaldivia/following{/other_user}","gists_url":"https://api.github.com/users/dvaldivia/gists{/gist_id}","starred_url":"https://api.github.com/users/dvaldivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvaldivia/subscriptions","organizations_url":"https://api.github.com/users/dvaldivia/orgs","repos_url":"https://api.github.com/users/dvaldivia/repos","events_url":"https://api.github.com/users/dvaldivia/events{/privacy}","received_events_url":"https://api.github.com/users/dvaldivia/received_events","type":"User","site_admin":false},"body":"Needed to be able to timeout ListBuckets by passing a context, the implementation was already there, but it had a hard coded `context.Background` so I just wrapped the existing function and have it call by default with `context.Background` similar to what `PutObject` does with `PutObjectWithContext`","created_at":"2019-12-04T19:20:18Z","updated_at":"2019-12-04T20:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fad858a0938afeb40dd2def934318a93235d6d5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-go/pulls/1192/commits","review_comments_url":"https://api.github.com/repos/minio/minio-go/pulls/1192/comments","review_comment_url":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-go/issues/1192/comments","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/36a8fb4266ff09c7a2a0777e41c329e07fe67d98","head":{"label":"dvaldivia:list-buckets-with-ctx","ref":"list-buckets-with-ctx","sha":"36a8fb4266ff09c7a2a0777e41c329e07fe67d98","user":{"login":"dvaldivia","id":18384552,"node_id":"MDQ6VXNlcjE4Mzg0NTUy","avatar_url":"https://avatars3.githubusercontent.com/u/18384552?v=4","gravatar_id":"","url":"https://api.github.com/users/dvaldivia","html_url":"https://github.com/dvaldivia","followers_url":"https://api.github.com/users/dvaldivia/followers","following_url":"https://api.github.com/users/dvaldivia/following{/other_user}","gists_url":"https://api.github.com/users/dvaldivia/gists{/gist_id}","starred_url":"https://api.github.com/users/dvaldivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvaldivia/subscriptions","organizations_url":"https://api.github.com/users/dvaldivia/orgs","repos_url":"https://api.github.com/users/dvaldivia/repos","events_url":"https://api.github.com/users/dvaldivia/events{/privacy}","received_events_url":"https://api.github.com/users/dvaldivia/received_events","type":"User","site_admin":false},"repo":{"id":193001094,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMwMDEwOTQ=","name":"minio-go","full_name":"dvaldivia/minio-go","private":false,"owner":{"login":"dvaldivia","id":18384552,"node_id":"MDQ6VXNlcjE4Mzg0NTUy","avatar_url":"https://avatars3.githubusercontent.com/u/18384552?v=4","gravatar_id":"","url":"https://api.github.com/users/dvaldivia","html_url":"https://github.com/dvaldivia","followers_url":"https://api.github.com/users/dvaldivia/followers","following_url":"https://api.github.com/users/dvaldivia/following{/other_user}","gists_url":"https://api.github.com/users/dvaldivia/gists{/gist_id}","starred_url":"https://api.github.com/users/dvaldivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvaldivia/subscriptions","organizations_url":"https://api.github.com/users/dvaldivia/orgs","repos_url":"https://api.github.com/users/dvaldivia/repos","events_url":"https://api.github.com/users/dvaldivia/events{/privacy}","received_events_url":"https://api.github.com/users/dvaldivia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dvaldivia/minio-go","description":"MinIO Client SDK for Go","fork":true,"url":"https://api.github.com/repos/dvaldivia/minio-go","forks_url":"https://api.github.com/repos/dvaldivia/minio-go/forks","keys_url":"https://api.github.com/repos/dvaldivia/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvaldivia/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvaldivia/minio-go/teams","hooks_url":"https://api.github.com/repos/dvaldivia/minio-go/hooks","issue_events_url":"https://api.github.com/repos/dvaldivia/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/dvaldivia/minio-go/events","assignees_url":"https://api.github.com/repos/dvaldivia/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/dvaldivia/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/dvaldivia/minio-go/tags","blobs_url":"https://api.github.com/repos/dvaldivia/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvaldivia/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvaldivia/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvaldivia/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvaldivia/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/dvaldivia/minio-go/languages","stargazers_url":"https://api.github.com/repos/dvaldivia/minio-go/stargazers","contributors_url":"https://api.github.com/repos/dvaldivia/minio-go/contributors","subscribers_url":"https://api.github.com/repos/dvaldivia/minio-go/subscribers","subscription_url":"https://api.github.com/repos/dvaldivia/minio-go/subscription","commits_url":"https://api.github.com/repos/dvaldivia/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvaldivia/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvaldivia/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvaldivia/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvaldivia/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/dvaldivia/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvaldivia/minio-go/merges","archive_url":"https://api.github.com/repos/dvaldivia/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvaldivia/minio-go/downloads","issues_url":"https://api.github.com/repos/dvaldivia/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/dvaldivia/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/dvaldivia/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/dvaldivia/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvaldivia/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/dvaldivia/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/dvaldivia/minio-go/deployments","created_at":"2019-06-20T23:53:35Z","updated_at":"2019-12-04T19:10:42Z","pushed_at":"2019-12-04T20:43:10Z","git_url":"git://github.com/dvaldivia/minio-go.git","ssh_url":"git@github.com:dvaldivia/minio-go.git","clone_url":"https://github.com/dvaldivia/minio-go.git","svn_url":"https://github.com/dvaldivia/minio-go","homepage":"https://docs.min.io/docs/golang-client-quickstart-guide.html","size":5387,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"351efed7cc2219c9db0cce3713866451ef7d2ba9","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":34933072,"node_id":"MDEwOlJlcG9zaXRvcnkzNDkzMzA3Mg==","name":"minio-go","full_name":"minio/minio-go","private":false,"owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/minio/minio-go","description":"MinIO Client SDK for Go","fork":false,"url":"https://api.github.com/repos/minio/minio-go","forks_url":"https://api.github.com/repos/minio/minio-go/forks","keys_url":"https://api.github.com/repos/minio/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-go/teams","hooks_url":"https://api.github.com/repos/minio/minio-go/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-go/events","assignees_url":"https://api.github.com/repos/minio/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-go/tags","blobs_url":"https://api.github.com/repos/minio/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-go/languages","stargazers_url":"https://api.github.com/repos/minio/minio-go/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-go/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-go/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-go/subscription","commits_url":"https://api.github.com/repos/minio/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-go/merges","archive_url":"https://api.github.com/repos/minio/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-go/downloads","issues_url":"https://api.github.com/repos/minio/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-go/deployments","created_at":"2015-05-02T02:36:46Z","updated_at":"2019-12-04T15:57:56Z","pushed_at":"2019-12-04T20:43:12Z","git_url":"git://github.com/minio/minio-go.git","ssh_url":"git@github.com:minio/minio-go.git","clone_url":"https://github.com/minio/minio-go.git","svn_url":"https://github.com/minio/minio-go","homepage":"https://docs.min.io/docs/golang-client-quickstart-guide.html","size":5342,"stargazers_count":811,"watchers_count":811,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":267,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":267,"open_issues":6,"watchers":811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/1192"},"html":{"href":"https://github.com/minio/minio-go/pull/1192"},"issue":{"href":"https://api.github.com/repos/minio/minio-go/issues/1192"},"comments":{"href":"https://api.github.com/repos/minio/minio-go/issues/1192/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-go/pulls/1192/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-go/pulls/1192/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-go/statuses/36a8fb4266ff09c7a2a0777e41c329e07fe67d98"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}