{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/docs/pulls/comments/273430604","pull_request_review_id":224325579,"id":273430604,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzQzMDYwNA==","diff_hunk":"@@ -66,6 +66,18 @@ Please see [Troubleshooting Complex URLs](https://asciidoctor.org/docs/user-manu\n This is an example of an URL containing problematic characters which needs special treatment:\n `https://www.owasp.org/index.php/Cross-site_Scripting_(XSS)`\n \n+**Strongly** in favour of using the following method which greatly improves readability while authoring the document.\n+\n+```\n+= The Page Header\n+:internal-link-name: https://example.com/content/link_can_be_very_long\n+\n+Text {internal-link-name}[highlighted text] text.\n+```\n+\n+It is important that `:internal-link-name:` is directly placed below the page header.\n+More of these link directives can be added in new lines.","path":"docs/best-practices.md","position":14,"original_position":14,"commit_id":"b9494981ac22ddba68eced744e93b7176ba44df2","original_commit_id":"978dd62f1fe55746aada9d48231f93256d1e404c","user":{"login":"settermjd","id":196801,"node_id":"MDQ6VXNlcjE5NjgwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/196801?v=4","gravatar_id":"","url":"https://api.github.com/users/settermjd","html_url":"https://github.com/settermjd","followers_url":"https://api.github.com/users/settermjd/followers","following_url":"https://api.github.com/users/settermjd/following{/other_user}","gists_url":"https://api.github.com/users/settermjd/gists{/gist_id}","starred_url":"https://api.github.com/users/settermjd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/settermjd/subscriptions","organizations_url":"https://api.github.com/users/settermjd/orgs","repos_url":"https://api.github.com/users/settermjd/repos","events_url":"https://api.github.com/users/settermjd/events{/privacy}","received_events_url":"https://api.github.com/users/settermjd/received_events","type":"User","site_admin":false},"body":"I'd suggest changing this to: \"Any number of these link directives can be added.\"","created_at":"2019-04-09T10:44:24Z","updated_at":"2019-04-09T10:44:25Z","html_url":"https://github.com/owncloud/docs/pull/908#discussion_r273430604","pull_request_url":"https://api.github.com/repos/owncloud/docs/pulls/908","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/owncloud/docs/pulls/comments/273430604"},"html":{"href":"https://github.com/owncloud/docs/pull/908#discussion_r273430604"},"pull_request":{"href":"https://api.github.com/repos/owncloud/docs/pulls/908"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/docs/pulls/908","id":268278028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4Mjc4MDI4","html_url":"https://github.com/owncloud/docs/pull/908","diff_url":"https://github.com/owncloud/docs/pull/908.diff","patch_url":"https://github.com/owncloud/docs/pull/908.patch","issue_url":"https://api.github.com/repos/owncloud/docs/issues/908","number":908,"state":"open","locked":false,"title":"Improving how links can be written","user":{"login":"mmattel","id":3321281,"node_id":"MDQ6VXNlcjMzMjEyODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3321281?v=4","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"body":"This PR enhances the description in docs/best practices how links can be written/used.","created_at":"2019-04-08T10:39:23Z","updated_at":"2019-04-09T10:44:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36e13197b1a136d4534033d9403e4c39c0c32a74","assignee":null,"assignees":[],"requested_reviewers":[{"login":"voroyam","id":24212810,"node_id":"MDQ6VXNlcjI0MjEyODEw","avatar_url":"https://avatars0.githubusercontent.com/u/24212810?v=4","gravatar_id":"","url":"https://api.github.com/users/voroyam","html_url":"https://github.com/voroyam","followers_url":"https://api.github.com/users/voroyam/followers","following_url":"https://api.github.com/users/voroyam/following{/other_user}","gists_url":"https://api.github.com/users/voroyam/gists{/gist_id}","starred_url":"https://api.github.com/users/voroyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voroyam/subscriptions","organizations_url":"https://api.github.com/users/voroyam/orgs","repos_url":"https://api.github.com/users/voroyam/repos","events_url":"https://api.github.com/users/voroyam/events{/privacy}","received_events_url":"https://api.github.com/users/voroyam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1228439135,"node_id":"MDU6TGFiZWwxMjI4NDM5MTM1","url":"https://api.github.com/repos/owncloud/docs/labels/backport","name":"backport","color":"9551b5","default":false},{"id":899556285,"node_id":"MDU6TGFiZWw4OTk1NTYyODU=","url":"https://api.github.com/repos/owncloud/docs/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/docs/pulls/908/commits","review_comments_url":"https://api.github.com/repos/owncloud/docs/pulls/908/comments","review_comment_url":"https://api.github.com/repos/owncloud/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/docs/issues/908/comments","statuses_url":"https://api.github.com/repos/owncloud/docs/statuses/b9494981ac22ddba68eced744e93b7176ba44df2","head":{"label":"owncloud:external_link_improvement","ref":"external_link_improvement","sha":"b9494981ac22ddba68eced744e93b7176ba44df2","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":129260244,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyNjAyNDQ=","name":"docs","full_name":"owncloud/docs","private":false,"owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/owncloud/docs","description":"ownCloud Documentation (v2)","fork":false,"url":"https://api.github.com/repos/owncloud/docs","forks_url":"https://api.github.com/repos/owncloud/docs/forks","keys_url":"https://api.github.com/repos/owncloud/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/docs/teams","hooks_url":"https://api.github.com/repos/owncloud/docs/hooks","issue_events_url":"https://api.github.com/repos/owncloud/docs/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/docs/events","assignees_url":"https://api.github.com/repos/owncloud/docs/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/docs/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/docs/tags","blobs_url":"https://api.github.com/repos/owncloud/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/docs/languages","stargazers_url":"https://api.github.com/repos/owncloud/docs/stargazers","contributors_url":"https://api.github.com/repos/owncloud/docs/contributors","subscribers_url":"https://api.github.com/repos/owncloud/docs/subscribers","subscription_url":"https://api.github.com/repos/owncloud/docs/subscription","commits_url":"https://api.github.com/repos/owncloud/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/docs/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/docs/merges","archive_url":"https://api.github.com/repos/owncloud/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/docs/downloads","issues_url":"https://api.github.com/repos/owncloud/docs/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/docs/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/docs/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/docs/deployments","created_at":"2018-04-12T14:01:28Z","updated_at":"2019-04-09T10:32:55Z","pushed_at":"2019-04-09T10:43:13Z","git_url":"git://github.com/owncloud/docs.git","ssh_url":"git@github.com:owncloud/docs.git","clone_url":"https://github.com/owncloud/docs.git","svn_url":"https://github.com/owncloud/docs","homepage":"","size":144908,"stargazers_count":13,"watchers_count":13,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":195,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":195,"watchers":13,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"cda58fa7e5eb9ef63e77ec09ec91acef97579a7d","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":129260244,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyNjAyNDQ=","name":"docs","full_name":"owncloud/docs","private":false,"owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/owncloud/docs","description":"ownCloud Documentation (v2)","fork":false,"url":"https://api.github.com/repos/owncloud/docs","forks_url":"https://api.github.com/repos/owncloud/docs/forks","keys_url":"https://api.github.com/repos/owncloud/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/docs/teams","hooks_url":"https://api.github.com/repos/owncloud/docs/hooks","issue_events_url":"https://api.github.com/repos/owncloud/docs/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/docs/events","assignees_url":"https://api.github.com/repos/owncloud/docs/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/docs/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/docs/tags","blobs_url":"https://api.github.com/repos/owncloud/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/docs/languages","stargazers_url":"https://api.github.com/repos/owncloud/docs/stargazers","contributors_url":"https://api.github.com/repos/owncloud/docs/contributors","subscribers_url":"https://api.github.com/repos/owncloud/docs/subscribers","subscription_url":"https://api.github.com/repos/owncloud/docs/subscription","commits_url":"https://api.github.com/repos/owncloud/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/docs/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/docs/merges","archive_url":"https://api.github.com/repos/owncloud/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/docs/downloads","issues_url":"https://api.github.com/repos/owncloud/docs/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/docs/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/docs/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/docs/deployments","created_at":"2018-04-12T14:01:28Z","updated_at":"2019-04-09T10:32:55Z","pushed_at":"2019-04-09T10:43:13Z","git_url":"git://github.com/owncloud/docs.git","ssh_url":"git@github.com:owncloud/docs.git","clone_url":"https://github.com/owncloud/docs.git","svn_url":"https://github.com/owncloud/docs","homepage":"","size":144908,"stargazers_count":13,"watchers_count":13,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":195,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":195,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/docs/pulls/908"},"html":{"href":"https://github.com/owncloud/docs/pull/908"},"issue":{"href":"https://api.github.com/repos/owncloud/docs/issues/908"},"comments":{"href":"https://api.github.com/repos/owncloud/docs/issues/908/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/docs/pulls/908/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/docs/pulls/908/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/docs/statuses/b9494981ac22ddba68eced744e93b7176ba44df2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"settermjd"}}