{"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/329177566","pull_request_review_id":294465627,"id":329177566,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTE3NzU2Ng==","diff_hunk":"@@ -749,13 +749,13 @@ protected void checkCacheControlHeaders(final Request request,\n      * </p>\n      * @param servletResponse the servlet response\n      * @param resource the fedora resource\n-     * @param session the session\n+     * @param transaction the transaction\n      */\n     protected void addCacheControlHeaders(final HttpServletResponse servletResponse,\n                                                  final FedoraResource resource,\n-                                                 final HttpSession session) {\n+                                                 final Transaction transaction) {\n \n-        if (session.isBatchSession()) {\n+        if (!transaction.isShortLived()) {","path":"fcrepo-http-api/src/main/java/org/fcrepo/http/api/ContentExposingResource.java","position":41,"original_position":41,"commit_id":"92e1929a14cc0609136571ffed7fde7d39f0b235","original_commit_id":"92e1929a14cc0609136571ffed7fde7d39f0b235","user":{"login":"dbernstein","id":344939,"node_id":"MDQ6VXNlcjM0NDkzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/344939?v=4","gravatar_id":"","url":"https://api.github.com/users/dbernstein","html_url":"https://github.com/dbernstein","followers_url":"https://api.github.com/users/dbernstein/followers","following_url":"https://api.github.com/users/dbernstein/following{/other_user}","gists_url":"https://api.github.com/users/dbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbernstein/subscriptions","organizations_url":"https://api.github.com/users/dbernstein/orgs","repos_url":"https://api.github.com/users/dbernstein/repos","events_url":"https://api.github.com/users/dbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/dbernstein/received_events","type":"User","site_admin":false},"body":"+1 to adding commitIfShortLived() method.","created_at":"2019-09-27T17:32:44Z","updated_at":"2019-09-27T17:32:44Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/1559#discussion_r329177566","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/329177566"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1559#discussion_r329177566"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559"}},"in_reply_to_id":329163086},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559","id":322208976,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyMjA4OTc2","html_url":"https://github.com/fcrepo4/fcrepo4/pull/1559","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/1559.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/1559.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1559","number":1559,"state":"open","locked":false,"title":"Removed HttpSession, SessionFactory, and SessionProvider","user":{"login":"mohideen","id":1703851,"node_id":"MDQ6VXNlcjE3MDM4NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1703851?v=4","gravatar_id":"","url":"https://api.github.com/users/mohideen","html_url":"https://github.com/mohideen","followers_url":"https://api.github.com/users/mohideen/followers","following_url":"https://api.github.com/users/mohideen/following{/other_user}","gists_url":"https://api.github.com/users/mohideen/gists{/gist_id}","starred_url":"https://api.github.com/users/mohideen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohideen/subscriptions","organizations_url":"https://api.github.com/users/mohideen/orgs","repos_url":"https://api.github.com/users/mohideen/repos","events_url":"https://api.github.com/users/mohideen/events{/privacy}","received_events_url":"https://api.github.com/users/mohideen/received_events","type":"User","site_admin":false},"body":"**JIRA Ticket**: https://jira.duraspace.org/browse/FCREPO-3073\r\n\r\n# What does this Pull Request do?\r\nRemoves HttpSession, SessionFactory, and SessionProvider\r\n\r\n# What's new?\r\nAdded TransactionProvider to replace SessionProvider\r\n\r\n# Interested parties\r\n@dbernstein \r\n","created_at":"2019-09-27T15:10:03Z","updated_at":"2019-09-27T17:32:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a88672d129dc0fde16f557a4ae27d6060f69f6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1559/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/92e1929a14cc0609136571ffed7fde7d39f0b235","head":{"label":"mohideen:FCREPO-3073","ref":"FCREPO-3073","sha":"92e1929a14cc0609136571ffed7fde7d39f0b235","user":{"login":"mohideen","id":1703851,"node_id":"MDQ6VXNlcjE3MDM4NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1703851?v=4","gravatar_id":"","url":"https://api.github.com/users/mohideen","html_url":"https://github.com/mohideen","followers_url":"https://api.github.com/users/mohideen/followers","following_url":"https://api.github.com/users/mohideen/following{/other_user}","gists_url":"https://api.github.com/users/mohideen/gists{/gist_id}","starred_url":"https://api.github.com/users/mohideen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohideen/subscriptions","organizations_url":"https://api.github.com/users/mohideen/orgs","repos_url":"https://api.github.com/users/mohideen/repos","events_url":"https://api.github.com/users/mohideen/events{/privacy}","received_events_url":"https://api.github.com/users/mohideen/received_events","type":"User","site_admin":false},"repo":{"id":41635004,"node_id":"MDEwOlJlcG9zaXRvcnk0MTYzNTAwNA==","name":"fcrepo4","full_name":"mohideen/fcrepo4","private":false,"owner":{"login":"mohideen","id":1703851,"node_id":"MDQ6VXNlcjE3MDM4NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1703851?v=4","gravatar_id":"","url":"https://api.github.com/users/mohideen","html_url":"https://github.com/mohideen","followers_url":"https://api.github.com/users/mohideen/followers","following_url":"https://api.github.com/users/mohideen/following{/other_user}","gists_url":"https://api.github.com/users/mohideen/gists{/gist_id}","starred_url":"https://api.github.com/users/mohideen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohideen/subscriptions","organizations_url":"https://api.github.com/users/mohideen/orgs","repos_url":"https://api.github.com/users/mohideen/repos","events_url":"https://api.github.com/users/mohideen/events{/privacy}","received_events_url":"https://api.github.com/users/mohideen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mohideen/fcrepo4","description":"Fedora 4","fork":true,"url":"https://api.github.com/repos/mohideen/fcrepo4","forks_url":"https://api.github.com/repos/mohideen/fcrepo4/forks","keys_url":"https://api.github.com/repos/mohideen/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mohideen/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mohideen/fcrepo4/teams","hooks_url":"https://api.github.com/repos/mohideen/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/mohideen/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/mohideen/fcrepo4/events","assignees_url":"https://api.github.com/repos/mohideen/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/mohideen/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/mohideen/fcrepo4/tags","blobs_url":"https://api.github.com/repos/mohideen/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mohideen/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mohideen/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/mohideen/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mohideen/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/mohideen/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/mohideen/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/mohideen/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/mohideen/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/mohideen/fcrepo4/subscription","commits_url":"https://api.github.com/repos/mohideen/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/mohideen/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/mohideen/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/mohideen/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/mohideen/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/mohideen/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mohideen/fcrepo4/merges","archive_url":"https://api.github.com/repos/mohideen/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mohideen/fcrepo4/downloads","issues_url":"https://api.github.com/repos/mohideen/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/mohideen/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/mohideen/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/mohideen/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mohideen/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/mohideen/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/mohideen/fcrepo4/deployments","created_at":"2015-08-30T16:21:44Z","updated_at":"2015-08-30T16:21:49Z","pushed_at":"2019-09-27T15:11:59Z","git_url":"git://github.com/mohideen/fcrepo4.git","ssh_url":"git@github.com:mohideen/fcrepo4.git","clone_url":"https://github.com/mohideen/fcrepo4.git","svn_url":"https://github.com/mohideen/fcrepo4","homepage":"http://github.com/fcrepo4/fcrepo4","size":77510,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"548602461f7635fa3e8ddc20f34705da8c543453","user":{"login":"fcrepo4","id":3057565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTc1NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkyNzk3","name":"fcrepo4","full_name":"fcrepo4/fcrepo4","private":false,"owner":{"login":"fcrepo4","id":3057565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTc1NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/deployments","created_at":"2013-02-03T16:18:55Z","updated_at":"2019-09-26T21:48:17Z","pushed_at":"2019-09-27T15:12:00Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"https://wiki.duraspace.org/display/FF/Fedora+Repository+Home","size":112565,"stargazers_count":126,"watchers_count":126,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":115,"open_issues":17,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1559"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1559"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1559/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1559/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/92e1929a14cc0609136571ffed7fde7d39f0b235"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dbernstein"}}