{"action":"created","issue":{"url":"https://api.github.com/repos/dundalek/closh/issues/164","repository_url":"https://api.github.com/repos/dundalek/closh","labels_url":"https://api.github.com/repos/dundalek/closh/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/dundalek/closh/issues/164/comments","events_url":"https://api.github.com/repos/dundalek/closh/issues/164/events","html_url":"https://github.com/dundalek/closh/pull/164","id":519952917,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4NjI1NTYx","number":164,"title":"First attemp to fix glob","user":{"login":"kirillsalykin","id":136315,"node_id":"MDQ6VXNlcjEzNjMxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/136315?v=4","gravatar_id":"","url":"https://api.github.com/users/kirillsalykin","html_url":"https://github.com/kirillsalykin","followers_url":"https://api.github.com/users/kirillsalykin/followers","following_url":"https://api.github.com/users/kirillsalykin/following{/other_user}","gists_url":"https://api.github.com/users/kirillsalykin/gists{/gist_id}","starred_url":"https://api.github.com/users/kirillsalykin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirillsalykin/subscriptions","organizations_url":"https://api.github.com/users/kirillsalykin/orgs","repos_url":"https://api.github.com/users/kirillsalykin/repos","events_url":"https://api.github.com/users/kirillsalykin/events{/privacy}","received_events_url":"https://api.github.com/users/kirillsalykin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-11-08T11:04:45Z","updated_at":"2019-11-09T11:58:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dundalek/closh/pulls/164","html_url":"https://github.com/dundalek/closh/pull/164","diff_url":"https://github.com/dundalek/closh/pull/164.diff","patch_url":"https://github.com/dundalek/closh/pull/164.patch"},"body":"This PR fixes glob on JVM.\r\n\r\n@dundalek not sure I understand when `cwd` can be nil and why it is treated as a valid condition."},"comment":{"url":"https://api.github.com/repos/dundalek/closh/issues/comments/552093251","html_url":"https://github.com/dundalek/closh/pull/164#issuecomment-552093251","issue_url":"https://api.github.com/repos/dundalek/closh/issues/164","id":552093251,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MjA5MzI1MQ==","user":{"login":"dundalek","id":755611,"node_id":"MDQ6VXNlcjc1NTYxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/755611?v=4","gravatar_id":"","url":"https://api.github.com/users/dundalek","html_url":"https://github.com/dundalek","followers_url":"https://api.github.com/users/dundalek/followers","following_url":"https://api.github.com/users/dundalek/following{/other_user}","gists_url":"https://api.github.com/users/dundalek/gists{/gist_id}","starred_url":"https://api.github.com/users/dundalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dundalek/subscriptions","organizations_url":"https://api.github.com/users/dundalek/orgs","repos_url":"https://api.github.com/users/dundalek/repos","events_url":"https://api.github.com/users/dundalek/events{/privacy}","received_events_url":"https://api.github.com/users/dundalek/received_events","type":"User","site_admin":false},"created_at":"2019-11-09T11:58:45Z","updated_at":"2019-11-09T11:58:45Z","author_association":"OWNER","body":"Hi @kirillsalykin, thanks for the help. This looks cool.\r\n\r\nThe nil `cwd` is there because of historical reasons. I think we can make it be always explicitly passed and fix any code that uses it with incorrect single arity.\r\n\r\nI would love if we could somehow leverage the clj-glob test suite to make sure we cover all of the other cases like brace expansion, question mark wildcards, etc."}}
{"actor":{"display_login":"dundalek"}}