{"action":"created","comment":{"url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments/276598656","pull_request_review_id":228201639,"id":276598656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjU5ODY1Ng==","diff_hunk":"@@ -133,8 +140,32 @@ func TestPostUpgradeIndexesVersionChange(t *testing.T) {\n \tsgIndexes[IndexAccess] = accessIndex\n \n \t// Validate that removeObsoleteIndexes now triggers removal of one index\n-\tremovedIndexes, removeErr = removeObsoleteIndexes(testBucket.Bucket, true, db.UseXattrs())\n+\tremovedIndexes, removeErr = removeObsoleteIndexes(gocbBucket, true, db.UseXattrs())\n \tlog.Printf(\"removedIndexes: %+v\", removedIndexes)\n \tgoassert.Equals(t, len(removedIndexes), 1)\n \tassert.NoError(t, removeErr, \"Unexpected error running removeObsoleteIndexes with hacked sgIndexes\")\n }\n+\n+func TestRemoveObsoleteIndexOnFail(t *testing.T) {","path":"db/indexes_test.go","position":69,"original_position":69,"commit_id":"7f79971977af7e1d25ca3ddf15980d4f139328b4","original_commit_id":"7f79971977af7e1d25ca3ddf15980d4f139328b4","user":{"login":"bbrks","id":1525809,"node_id":"MDQ6VXNlcjE1MjU4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1525809?v=4","gravatar_id":"","url":"https://api.github.com/users/bbrks","html_url":"https://github.com/bbrks","followers_url":"https://api.github.com/users/bbrks/followers","following_url":"https://api.github.com/users/bbrks/following{/other_user}","gists_url":"https://api.github.com/users/bbrks/gists{/gist_id}","starred_url":"https://api.github.com/users/bbrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbrks/subscriptions","organizations_url":"https://api.github.com/users/bbrks/orgs","repos_url":"https://api.github.com/users/bbrks/repos","events_url":"https://api.github.com/users/bbrks/events{/privacy}","received_events_url":"https://api.github.com/users/bbrks/received_events","type":"User","site_admin":false},"body":"probably only want to run for non-walrus tests","created_at":"2019-04-18T10:02:57Z","updated_at":"2019-04-18T10:12:14Z","html_url":"https://github.com/couchbase/sync_gateway/pull/4085#discussion_r276598656","pull_request_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments/276598656"},"html":{"href":"https://github.com/couchbase/sync_gateway/pull/4085#discussion_r276598656"},"pull_request":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085"}}},"pull_request":{"url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085","id":271449541,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNDQ5NTQx","html_url":"https://github.com/couchbase/sync_gateway/pull/4085","diff_url":"https://github.com/couchbase/sync_gateway/pull/4085.diff","patch_url":"https://github.com/couchbase/sync_gateway/pull/4085.patch","issue_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/4085","number":4085,"state":"open","locked":false,"title":"CBG-307:Continue on error when removing obsolete indexes","user":{"login":"JRascagneres","id":3264971,"node_id":"MDQ6VXNlcjMyNjQ5NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3264971?v=4","gravatar_id":"","url":"https://api.github.com/users/JRascagneres","html_url":"https://github.com/JRascagneres","followers_url":"https://api.github.com/users/JRascagneres/followers","following_url":"https://api.github.com/users/JRascagneres/following{/other_user}","gists_url":"https://api.github.com/users/JRascagneres/gists{/gist_id}","starred_url":"https://api.github.com/users/JRascagneres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JRascagneres/subscriptions","organizations_url":"https://api.github.com/users/JRascagneres/orgs","repos_url":"https://api.github.com/users/JRascagneres/repos","events_url":"https://api.github.com/users/JRascagneres/events{/privacy}","received_events_url":"https://api.github.com/users/JRascagneres/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-17T20:02:55Z","updated_at":"2019-04-18T10:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ba1f33bfaf740a2c4189d959b2eab4e83471551","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":107354377,"node_id":"MDU6TGFiZWwxMDczNTQzNzc=","url":"https://api.github.com/repos/couchbase/sync_gateway/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":109316238,"node_id":"MDU6TGFiZWwxMDkzMTYyMzg=","url":"https://api.github.com/repos/couchbase/sync_gateway/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085/commits","review_comments_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085/comments","review_comment_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/4085/comments","statuses_url":"https://api.github.com/repos/couchbase/sync_gateway/statuses/7f79971977af7e1d25ca3ddf15980d4f139328b4","head":{"label":"couchbase:CBG-307","ref":"CBG-307","sha":"7f79971977af7e1d25ca3ddf15980d4f139328b4","user":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":6082996,"node_id":"MDEwOlJlcG9zaXRvcnk2MDgyOTk2","name":"sync_gateway","full_name":"couchbase/sync_gateway","private":false,"owner":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/couchbase/sync_gateway","description":"Manages access and synchronization between Couchbase Lite and Couchbase Server","fork":false,"url":"https://api.github.com/repos/couchbase/sync_gateway","forks_url":"https://api.github.com/repos/couchbase/sync_gateway/forks","keys_url":"https://api.github.com/repos/couchbase/sync_gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/sync_gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/sync_gateway/teams","hooks_url":"https://api.github.com/repos/couchbase/sync_gateway/hooks","issue_events_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/sync_gateway/events","assignees_url":"https://api.github.com/repos/couchbase/sync_gateway/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/sync_gateway/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/sync_gateway/tags","blobs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/sync_gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/sync_gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/sync_gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/sync_gateway/languages","stargazers_url":"https://api.github.com/repos/couchbase/sync_gateway/stargazers","contributors_url":"https://api.github.com/repos/couchbase/sync_gateway/contributors","subscribers_url":"https://api.github.com/repos/couchbase/sync_gateway/subscribers","subscription_url":"https://api.github.com/repos/couchbase/sync_gateway/subscription","commits_url":"https://api.github.com/repos/couchbase/sync_gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/sync_gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/sync_gateway/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/sync_gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/sync_gateway/merges","archive_url":"https://api.github.com/repos/couchbase/sync_gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/sync_gateway/downloads","issues_url":"https://api.github.com/repos/couchbase/sync_gateway/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/sync_gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/sync_gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/sync_gateway/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/sync_gateway/releases{/id}","deployments_url":"https://api.github.com/repos/couchbase/sync_gateway/deployments","created_at":"2012-10-04T22:25:43Z","updated_at":"2019-04-18T02:42:50Z","pushed_at":"2019-04-17T20:02:56Z","git_url":"git://github.com/couchbase/sync_gateway.git","ssh_url":"git@github.com:couchbase/sync_gateway.git","clone_url":"https://github.com/couchbase/sync_gateway.git","svn_url":"https://github.com/couchbase/sync_gateway","homepage":"https://www.couchbase.com/products/sync-gateway","size":31450,"stargazers_count":404,"watchers_count":404,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":319,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":126,"open_issues":319,"watchers":404,"default_branch":"master"}},"base":{"label":"couchbase:master","ref":"master","sha":"2dd77a001b6a8ed6caab81a14dd403fc62f40ec4","user":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"repo":{"id":6082996,"node_id":"MDEwOlJlcG9zaXRvcnk2MDgyOTk2","name":"sync_gateway","full_name":"couchbase/sync_gateway","private":false,"owner":{"login":"couchbase","id":605755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNTc1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/605755?v=4","gravatar_id":"","url":"https://api.github.com/users/couchbase","html_url":"https://github.com/couchbase","followers_url":"https://api.github.com/users/couchbase/followers","following_url":"https://api.github.com/users/couchbase/following{/other_user}","gists_url":"https://api.github.com/users/couchbase/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbase/subscriptions","organizations_url":"https://api.github.com/users/couchbase/orgs","repos_url":"https://api.github.com/users/couchbase/repos","events_url":"https://api.github.com/users/couchbase/events{/privacy}","received_events_url":"https://api.github.com/users/couchbase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/couchbase/sync_gateway","description":"Manages access and synchronization between Couchbase Lite and Couchbase Server","fork":false,"url":"https://api.github.com/repos/couchbase/sync_gateway","forks_url":"https://api.github.com/repos/couchbase/sync_gateway/forks","keys_url":"https://api.github.com/repos/couchbase/sync_gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbase/sync_gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbase/sync_gateway/teams","hooks_url":"https://api.github.com/repos/couchbase/sync_gateway/hooks","issue_events_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/events{/number}","events_url":"https://api.github.com/repos/couchbase/sync_gateway/events","assignees_url":"https://api.github.com/repos/couchbase/sync_gateway/assignees{/user}","branches_url":"https://api.github.com/repos/couchbase/sync_gateway/branches{/branch}","tags_url":"https://api.github.com/repos/couchbase/sync_gateway/tags","blobs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbase/sync_gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbase/sync_gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbase/sync_gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbase/sync_gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbase/sync_gateway/languages","stargazers_url":"https://api.github.com/repos/couchbase/sync_gateway/stargazers","contributors_url":"https://api.github.com/repos/couchbase/sync_gateway/contributors","subscribers_url":"https://api.github.com/repos/couchbase/sync_gateway/subscribers","subscription_url":"https://api.github.com/repos/couchbase/sync_gateway/subscription","commits_url":"https://api.github.com/repos/couchbase/sync_gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbase/sync_gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbase/sync_gateway/contents/{+path}","compare_url":"https://api.github.com/repos/couchbase/sync_gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbase/sync_gateway/merges","archive_url":"https://api.github.com/repos/couchbase/sync_gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbase/sync_gateway/downloads","issues_url":"https://api.github.com/repos/couchbase/sync_gateway/issues{/number}","pulls_url":"https://api.github.com/repos/couchbase/sync_gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbase/sync_gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbase/sync_gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbase/sync_gateway/labels{/name}","releases_url":"https://api.github.com/repos/couchbase/sync_gateway/releases{/id}","deployments_url":"https://api.github.com/repos/couchbase/sync_gateway/deployments","created_at":"2012-10-04T22:25:43Z","updated_at":"2019-04-18T02:42:50Z","pushed_at":"2019-04-17T20:02:56Z","git_url":"git://github.com/couchbase/sync_gateway.git","ssh_url":"git@github.com:couchbase/sync_gateway.git","clone_url":"https://github.com/couchbase/sync_gateway.git","svn_url":"https://github.com/couchbase/sync_gateway","homepage":"https://www.couchbase.com/products/sync-gateway","size":31450,"stargazers_count":404,"watchers_count":404,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":319,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":126,"open_issues":319,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085"},"html":{"href":"https://github.com/couchbase/sync_gateway/pull/4085"},"issue":{"href":"https://api.github.com/repos/couchbase/sync_gateway/issues/4085"},"comments":{"href":"https://api.github.com/repos/couchbase/sync_gateway/issues/4085/comments"},"review_comments":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085/comments"},"review_comment":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/couchbase/sync_gateway/pulls/4085/commits"},"statuses":{"href":"https://api.github.com/repos/couchbase/sync_gateway/statuses/7f79971977af7e1d25ca3ddf15980d4f139328b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bbrks"}}