{"action":"created","comment":{"url":"https://api.github.com/repos/rloganiv/kglm-model/pulls/comments/256996694","pull_request_review_id":203951057,"id":256996694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1Njk5NjY5NA==","diff_hunk":"@@ -1,21 +1,19 @@\n # pylint: disable=protected-access,not-callable,unused-import\n \n-from allennlp.common.testing import ModelTestCase\n+from kglm.common.testing import KglmModelTestCase\n import numpy as np\n import torch\n \n from kglm.data.dataset_readers.enhanced_wikitext import EnhancedWikitextKglmReader\n from kglm.models.alias_copynet import AliasCopynet\n \n \n-class  AliasCopynetTest(ModelTestCase):\n+class AliasCopynetTest(KglmModelTestCase):\n \n     def setUp(self):\n         super().setUp()\n         self.set_up_model(\"kglm/tests/fixtures/training_config/alias_copynet.json\",\n                           \"kglm/tests/fixtures/enhanced-wikitext.jsonl\")\n \n     def test_model_can_train_save_and_load(self):\n-        # TODO: Construct a test case where we can ensure that _copy_mode_projection is learning","path":"kglm/tests/models/alias_copynet_test.py","position":21,"original_position":21,"commit_id":"4c11211463d9bce736eda9612c828babbf0f1a75","original_commit_id":"4c11211463d9bce736eda9612c828babbf0f1a75","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"body":"@rloganiv i hope this comment doesn't apply anymore...it seems to calculate grads just fine for `_copy_mode_projection`. Hopefully this is expected?","created_at":"2019-02-14T20:19:30Z","updated_at":"2019-02-14T20:19:30Z","html_url":"https://github.com/rloganiv/kglm-model/pull/22#discussion_r256996694","pull_request_url":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rloganiv/kglm-model/pulls/comments/256996694"},"html":{"href":"https://github.com/rloganiv/kglm-model/pull/22#discussion_r256996694"},"pull_request":{"href":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22","id":253208854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMjA4ODU0","html_url":"https://github.com/rloganiv/kglm-model/pull/22","diff_url":"https://github.com/rloganiv/kglm-model/pull/22.diff","patch_url":"https://github.com/rloganiv/kglm-model/pull/22.patch","issue_url":"https://api.github.com/repos/rloganiv/kglm-model/issues/22","number":22,"state":"open","locked":false,"title":"Fix alias copynet tests","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-14T20:18:57Z","updated_at":"2019-02-14T20:19:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66145495d9cfef353c5cce86f561e49f29ee382b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22/commits","review_comments_url":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22/comments","review_comment_url":"https://api.github.com/repos/rloganiv/kglm-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rloganiv/kglm-model/issues/22/comments","statuses_url":"https://api.github.com/repos/rloganiv/kglm-model/statuses/4c11211463d9bce736eda9612c828babbf0f1a75","head":{"label":"nelson-liu:fix_alias_copynet_tests","ref":"fix_alias_copynet_tests","sha":"4c11211463d9bce736eda9612c828babbf0f1a75","user":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"repo":{"id":167857783,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc4NTc3ODM=","name":"kglm-model","full_name":"nelson-liu/kglm-model","private":false,"owner":{"login":"nelson-liu","id":7272031,"node_id":"MDQ6VXNlcjcyNzIwMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7272031?v=4","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nelson-liu/kglm-model","description":null,"fork":true,"url":"https://api.github.com/repos/nelson-liu/kglm-model","forks_url":"https://api.github.com/repos/nelson-liu/kglm-model/forks","keys_url":"https://api.github.com/repos/nelson-liu/kglm-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelson-liu/kglm-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelson-liu/kglm-model/teams","hooks_url":"https://api.github.com/repos/nelson-liu/kglm-model/hooks","issue_events_url":"https://api.github.com/repos/nelson-liu/kglm-model/issues/events{/number}","events_url":"https://api.github.com/repos/nelson-liu/kglm-model/events","assignees_url":"https://api.github.com/repos/nelson-liu/kglm-model/assignees{/user}","branches_url":"https://api.github.com/repos/nelson-liu/kglm-model/branches{/branch}","tags_url":"https://api.github.com/repos/nelson-liu/kglm-model/tags","blobs_url":"https://api.github.com/repos/nelson-liu/kglm-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelson-liu/kglm-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelson-liu/kglm-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelson-liu/kglm-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelson-liu/kglm-model/statuses/{sha}","languages_url":"https://api.github.com/repos/nelson-liu/kglm-model/languages","stargazers_url":"https://api.github.com/repos/nelson-liu/kglm-model/stargazers","contributors_url":"https://api.github.com/repos/nelson-liu/kglm-model/contributors","subscribers_url":"https://api.github.com/repos/nelson-liu/kglm-model/subscribers","subscription_url":"https://api.github.com/repos/nelson-liu/kglm-model/subscription","commits_url":"https://api.github.com/repos/nelson-liu/kglm-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelson-liu/kglm-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelson-liu/kglm-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelson-liu/kglm-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelson-liu/kglm-model/contents/{+path}","compare_url":"https://api.github.com/repos/nelson-liu/kglm-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelson-liu/kglm-model/merges","archive_url":"https://api.github.com/repos/nelson-liu/kglm-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelson-liu/kglm-model/downloads","issues_url":"https://api.github.com/repos/nelson-liu/kglm-model/issues{/number}","pulls_url":"https://api.github.com/repos/nelson-liu/kglm-model/pulls{/number}","milestones_url":"https://api.github.com/repos/nelson-liu/kglm-model/milestones{/number}","notifications_url":"https://api.github.com/repos/nelson-liu/kglm-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelson-liu/kglm-model/labels{/name}","releases_url":"https://api.github.com/repos/nelson-liu/kglm-model/releases{/id}","deployments_url":"https://api.github.com/repos/nelson-liu/kglm-model/deployments","created_at":"2019-01-27T20:56:18Z","updated_at":"2019-02-14T19:44:19Z","pushed_at":"2019-02-14T20:18:41Z","git_url":"git://github.com/nelson-liu/kglm-model.git","ssh_url":"git@github.com:nelson-liu/kglm-model.git","clone_url":"https://github.com/nelson-liu/kglm-model.git","svn_url":"https://github.com/nelson-liu/kglm-model","homepage":null,"size":2714,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rloganiv:master","ref":"master","sha":"1de9e3554bef4368195657eccdf11d84b558368b","user":{"login":"rloganiv","id":12504112,"node_id":"MDQ6VXNlcjEyNTA0MTEy","avatar_url":"https://avatars1.githubusercontent.com/u/12504112?v=4","gravatar_id":"","url":"https://api.github.com/users/rloganiv","html_url":"https://github.com/rloganiv","followers_url":"https://api.github.com/users/rloganiv/followers","following_url":"https://api.github.com/users/rloganiv/following{/other_user}","gists_url":"https://api.github.com/users/rloganiv/gists{/gist_id}","starred_url":"https://api.github.com/users/rloganiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rloganiv/subscriptions","organizations_url":"https://api.github.com/users/rloganiv/orgs","repos_url":"https://api.github.com/users/rloganiv/repos","events_url":"https://api.github.com/users/rloganiv/events{/privacy}","received_events_url":"https://api.github.com/users/rloganiv/received_events","type":"User","site_admin":false},"repo":{"id":162177443,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxNzc0NDM=","name":"kglm-model","full_name":"rloganiv/kglm-model","private":false,"owner":{"login":"rloganiv","id":12504112,"node_id":"MDQ6VXNlcjEyNTA0MTEy","avatar_url":"https://avatars1.githubusercontent.com/u/12504112?v=4","gravatar_id":"","url":"https://api.github.com/users/rloganiv","html_url":"https://github.com/rloganiv","followers_url":"https://api.github.com/users/rloganiv/followers","following_url":"https://api.github.com/users/rloganiv/following{/other_user}","gists_url":"https://api.github.com/users/rloganiv/gists{/gist_id}","starred_url":"https://api.github.com/users/rloganiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rloganiv/subscriptions","organizations_url":"https://api.github.com/users/rloganiv/orgs","repos_url":"https://api.github.com/users/rloganiv/repos","events_url":"https://api.github.com/users/rloganiv/events{/privacy}","received_events_url":"https://api.github.com/users/rloganiv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rloganiv/kglm-model","description":null,"fork":false,"url":"https://api.github.com/repos/rloganiv/kglm-model","forks_url":"https://api.github.com/repos/rloganiv/kglm-model/forks","keys_url":"https://api.github.com/repos/rloganiv/kglm-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rloganiv/kglm-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rloganiv/kglm-model/teams","hooks_url":"https://api.github.com/repos/rloganiv/kglm-model/hooks","issue_events_url":"https://api.github.com/repos/rloganiv/kglm-model/issues/events{/number}","events_url":"https://api.github.com/repos/rloganiv/kglm-model/events","assignees_url":"https://api.github.com/repos/rloganiv/kglm-model/assignees{/user}","branches_url":"https://api.github.com/repos/rloganiv/kglm-model/branches{/branch}","tags_url":"https://api.github.com/repos/rloganiv/kglm-model/tags","blobs_url":"https://api.github.com/repos/rloganiv/kglm-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rloganiv/kglm-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rloganiv/kglm-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/rloganiv/kglm-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rloganiv/kglm-model/statuses/{sha}","languages_url":"https://api.github.com/repos/rloganiv/kglm-model/languages","stargazers_url":"https://api.github.com/repos/rloganiv/kglm-model/stargazers","contributors_url":"https://api.github.com/repos/rloganiv/kglm-model/contributors","subscribers_url":"https://api.github.com/repos/rloganiv/kglm-model/subscribers","subscription_url":"https://api.github.com/repos/rloganiv/kglm-model/subscription","commits_url":"https://api.github.com/repos/rloganiv/kglm-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/rloganiv/kglm-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/rloganiv/kglm-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/rloganiv/kglm-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/rloganiv/kglm-model/contents/{+path}","compare_url":"https://api.github.com/repos/rloganiv/kglm-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rloganiv/kglm-model/merges","archive_url":"https://api.github.com/repos/rloganiv/kglm-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rloganiv/kglm-model/downloads","issues_url":"https://api.github.com/repos/rloganiv/kglm-model/issues{/number}","pulls_url":"https://api.github.com/repos/rloganiv/kglm-model/pulls{/number}","milestones_url":"https://api.github.com/repos/rloganiv/kglm-model/milestones{/number}","notifications_url":"https://api.github.com/repos/rloganiv/kglm-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rloganiv/kglm-model/labels{/name}","releases_url":"https://api.github.com/repos/rloganiv/kglm-model/releases{/id}","deployments_url":"https://api.github.com/repos/rloganiv/kglm-model/deployments","created_at":"2018-12-17T19:06:49Z","updated_at":"2019-02-14T20:04:00Z","pushed_at":"2019-02-14T20:18:57Z","git_url":"git://github.com/rloganiv/kglm-model.git","ssh_url":"git@github.com:rloganiv/kglm-model.git","clone_url":"https://github.com/rloganiv/kglm-model.git","svn_url":"https://github.com/rloganiv/kglm-model","homepage":null,"size":2792,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22"},"html":{"href":"https://github.com/rloganiv/kglm-model/pull/22"},"issue":{"href":"https://api.github.com/repos/rloganiv/kglm-model/issues/22"},"comments":{"href":"https://api.github.com/repos/rloganiv/kglm-model/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/rloganiv/kglm-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rloganiv/kglm-model/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/rloganiv/kglm-model/statuses/4c11211463d9bce736eda9612c828babbf0f1a75"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nelson-liu"}}