{"action":"closed","number":270,"pull_request":{"url":"https://api.github.com/repos/justeat/AwsWatchman/pulls/270","id":256717244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2NzE3MjQ0","html_url":"https://github.com/justeat/AwsWatchman/pull/270","diff_url":"https://github.com/justeat/AwsWatchman/pull/270.diff","patch_url":"https://github.com/justeat/AwsWatchman/pull/270.patch","issue_url":"https://api.github.com/repos/justeat/AwsWatchman/issues/270","number":270,"state":"closed","locked":false,"title":"Use treat missing data propery on InvocationsLow lambda alarm","user":{"login":"mexisd","id":12252499,"node_id":"MDQ6VXNlcjEyMjUyNDk5","avatar_url":"https://avatars3.githubusercontent.com/u/12252499?v=4","gravatar_id":"","url":"https://api.github.com/users/mexisd","html_url":"https://github.com/mexisd","followers_url":"https://api.github.com/users/mexisd/followers","following_url":"https://api.github.com/users/mexisd/following{/other_user}","gists_url":"https://api.github.com/users/mexisd/gists{/gist_id}","starred_url":"https://api.github.com/users/mexisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexisd/subscriptions","organizations_url":"https://api.github.com/users/mexisd/orgs","repos_url":"https://api.github.com/users/mexisd/repos","events_url":"https://api.github.com/users/mexisd/events{/privacy}","received_events_url":"https://api.github.com/users/mexisd/received_events","type":"User","site_admin":false},"body":"When a lambda is not invoked, there is not a metric and the alarm goes into `INSUFFICIENT_DATA` and as a result it does not fire when it should. We should alert when there is not any data as it means the lambda did not really run.\r\n\r\nI also changed the `statistic` to `Sum` as it seems a better fit than `SampleCount`.","created_at":"2019-02-27T15:07:34Z","updated_at":"2019-02-27T16:14:59Z","closed_at":"2019-02-27T16:14:59Z","merged_at":"2019-02-27T16:14:59Z","merge_commit_sha":"952cf82403012d2186db8d9006ab3211f3e91a3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/justeat/AwsWatchman/pulls/270/commits","review_comments_url":"https://api.github.com/repos/justeat/AwsWatchman/pulls/270/comments","review_comment_url":"https://api.github.com/repos/justeat/AwsWatchman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/justeat/AwsWatchman/issues/270/comments","statuses_url":"https://api.github.com/repos/justeat/AwsWatchman/statuses/ca4d1430df0fc8819d0f0c7e1b8274bd8105bdad","head":{"label":"mexisd:UseMissingDataInLambdaAlarm","ref":"UseMissingDataInLambdaAlarm","sha":"ca4d1430df0fc8819d0f0c7e1b8274bd8105bdad","user":{"login":"mexisd","id":12252499,"node_id":"MDQ6VXNlcjEyMjUyNDk5","avatar_url":"https://avatars3.githubusercontent.com/u/12252499?v=4","gravatar_id":"","url":"https://api.github.com/users/mexisd","html_url":"https://github.com/mexisd","followers_url":"https://api.github.com/users/mexisd/followers","following_url":"https://api.github.com/users/mexisd/following{/other_user}","gists_url":"https://api.github.com/users/mexisd/gists{/gist_id}","starred_url":"https://api.github.com/users/mexisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexisd/subscriptions","organizations_url":"https://api.github.com/users/mexisd/orgs","repos_url":"https://api.github.com/users/mexisd/repos","events_url":"https://api.github.com/users/mexisd/events{/privacy}","received_events_url":"https://api.github.com/users/mexisd/received_events","type":"User","site_admin":false},"repo":{"id":153454874,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0NTQ4NzQ=","name":"AwsWatchman","full_name":"mexisd/AwsWatchman","private":false,"owner":{"login":"mexisd","id":12252499,"node_id":"MDQ6VXNlcjEyMjUyNDk5","avatar_url":"https://avatars3.githubusercontent.com/u/12252499?v=4","gravatar_id":"","url":"https://api.github.com/users/mexisd","html_url":"https://github.com/mexisd","followers_url":"https://api.github.com/users/mexisd/followers","following_url":"https://api.github.com/users/mexisd/following{/other_user}","gists_url":"https://api.github.com/users/mexisd/gists{/gist_id}","starred_url":"https://api.github.com/users/mexisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexisd/subscriptions","organizations_url":"https://api.github.com/users/mexisd/orgs","repos_url":"https://api.github.com/users/mexisd/repos","events_url":"https://api.github.com/users/mexisd/events{/privacy}","received_events_url":"https://api.github.com/users/mexisd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mexisd/AwsWatchman","description":"Because unmonitored infrastructure will bite you","fork":true,"url":"https://api.github.com/repos/mexisd/AwsWatchman","forks_url":"https://api.github.com/repos/mexisd/AwsWatchman/forks","keys_url":"https://api.github.com/repos/mexisd/AwsWatchman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mexisd/AwsWatchman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mexisd/AwsWatchman/teams","hooks_url":"https://api.github.com/repos/mexisd/AwsWatchman/hooks","issue_events_url":"https://api.github.com/repos/mexisd/AwsWatchman/issues/events{/number}","events_url":"https://api.github.com/repos/mexisd/AwsWatchman/events","assignees_url":"https://api.github.com/repos/mexisd/AwsWatchman/assignees{/user}","branches_url":"https://api.github.com/repos/mexisd/AwsWatchman/branches{/branch}","tags_url":"https://api.github.com/repos/mexisd/AwsWatchman/tags","blobs_url":"https://api.github.com/repos/mexisd/AwsWatchman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mexisd/AwsWatchman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mexisd/AwsWatchman/git/refs{/sha}","trees_url":"https://api.github.com/repos/mexisd/AwsWatchman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mexisd/AwsWatchman/statuses/{sha}","languages_url":"https://api.github.com/repos/mexisd/AwsWatchman/languages","stargazers_url":"https://api.github.com/repos/mexisd/AwsWatchman/stargazers","contributors_url":"https://api.github.com/repos/mexisd/AwsWatchman/contributors","subscribers_url":"https://api.github.com/repos/mexisd/AwsWatchman/subscribers","subscription_url":"https://api.github.com/repos/mexisd/AwsWatchman/subscription","commits_url":"https://api.github.com/repos/mexisd/AwsWatchman/commits{/sha}","git_commits_url":"https://api.github.com/repos/mexisd/AwsWatchman/git/commits{/sha}","comments_url":"https://api.github.com/repos/mexisd/AwsWatchman/comments{/number}","issue_comment_url":"https://api.github.com/repos/mexisd/AwsWatchman/issues/comments{/number}","contents_url":"https://api.github.com/repos/mexisd/AwsWatchman/contents/{+path}","compare_url":"https://api.github.com/repos/mexisd/AwsWatchman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mexisd/AwsWatchman/merges","archive_url":"https://api.github.com/repos/mexisd/AwsWatchman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mexisd/AwsWatchman/downloads","issues_url":"https://api.github.com/repos/mexisd/AwsWatchman/issues{/number}","pulls_url":"https://api.github.com/repos/mexisd/AwsWatchman/pulls{/number}","milestones_url":"https://api.github.com/repos/mexisd/AwsWatchman/milestones{/number}","notifications_url":"https://api.github.com/repos/mexisd/AwsWatchman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mexisd/AwsWatchman/labels{/name}","releases_url":"https://api.github.com/repos/mexisd/AwsWatchman/releases{/id}","deployments_url":"https://api.github.com/repos/mexisd/AwsWatchman/deployments","created_at":"2018-10-17T12:41:06Z","updated_at":"2019-02-27T14:52:47Z","pushed_at":"2019-02-27T15:03:54Z","git_url":"git://github.com/mexisd/AwsWatchman.git","ssh_url":"git@github.com:mexisd/AwsWatchman.git","clone_url":"https://github.com/mexisd/AwsWatchman.git","svn_url":"https://github.com/mexisd/AwsWatchman","homepage":null,"size":708,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"justeat:master","ref":"master","sha":"b0e29056ce4717d9ac366529a3070d46f0998989","user":{"login":"justeat","id":1516790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTY3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1516790?v=4","gravatar_id":"","url":"https://api.github.com/users/justeat","html_url":"https://github.com/justeat","followers_url":"https://api.github.com/users/justeat/followers","following_url":"https://api.github.com/users/justeat/following{/other_user}","gists_url":"https://api.github.com/users/justeat/gists{/gist_id}","starred_url":"https://api.github.com/users/justeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justeat/subscriptions","organizations_url":"https://api.github.com/users/justeat/orgs","repos_url":"https://api.github.com/users/justeat/repos","events_url":"https://api.github.com/users/justeat/events{/privacy}","received_events_url":"https://api.github.com/users/justeat/received_events","type":"Organization","site_admin":false},"repo":{"id":78201833,"node_id":"MDEwOlJlcG9zaXRvcnk3ODIwMTgzMw==","name":"AwsWatchman","full_name":"justeat/AwsWatchman","private":false,"owner":{"login":"justeat","id":1516790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTY3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1516790?v=4","gravatar_id":"","url":"https://api.github.com/users/justeat","html_url":"https://github.com/justeat","followers_url":"https://api.github.com/users/justeat/followers","following_url":"https://api.github.com/users/justeat/following{/other_user}","gists_url":"https://api.github.com/users/justeat/gists{/gist_id}","starred_url":"https://api.github.com/users/justeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justeat/subscriptions","organizations_url":"https://api.github.com/users/justeat/orgs","repos_url":"https://api.github.com/users/justeat/repos","events_url":"https://api.github.com/users/justeat/events{/privacy}","received_events_url":"https://api.github.com/users/justeat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/justeat/AwsWatchman","description":"Because unmonitored infrastructure will bite you","fork":false,"url":"https://api.github.com/repos/justeat/AwsWatchman","forks_url":"https://api.github.com/repos/justeat/AwsWatchman/forks","keys_url":"https://api.github.com/repos/justeat/AwsWatchman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justeat/AwsWatchman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justeat/AwsWatchman/teams","hooks_url":"https://api.github.com/repos/justeat/AwsWatchman/hooks","issue_events_url":"https://api.github.com/repos/justeat/AwsWatchman/issues/events{/number}","events_url":"https://api.github.com/repos/justeat/AwsWatchman/events","assignees_url":"https://api.github.com/repos/justeat/AwsWatchman/assignees{/user}","branches_url":"https://api.github.com/repos/justeat/AwsWatchman/branches{/branch}","tags_url":"https://api.github.com/repos/justeat/AwsWatchman/tags","blobs_url":"https://api.github.com/repos/justeat/AwsWatchman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justeat/AwsWatchman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justeat/AwsWatchman/git/refs{/sha}","trees_url":"https://api.github.com/repos/justeat/AwsWatchman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justeat/AwsWatchman/statuses/{sha}","languages_url":"https://api.github.com/repos/justeat/AwsWatchman/languages","stargazers_url":"https://api.github.com/repos/justeat/AwsWatchman/stargazers","contributors_url":"https://api.github.com/repos/justeat/AwsWatchman/contributors","subscribers_url":"https://api.github.com/repos/justeat/AwsWatchman/subscribers","subscription_url":"https://api.github.com/repos/justeat/AwsWatchman/subscription","commits_url":"https://api.github.com/repos/justeat/AwsWatchman/commits{/sha}","git_commits_url":"https://api.github.com/repos/justeat/AwsWatchman/git/commits{/sha}","comments_url":"https://api.github.com/repos/justeat/AwsWatchman/comments{/number}","issue_comment_url":"https://api.github.com/repos/justeat/AwsWatchman/issues/comments{/number}","contents_url":"https://api.github.com/repos/justeat/AwsWatchman/contents/{+path}","compare_url":"https://api.github.com/repos/justeat/AwsWatchman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justeat/AwsWatchman/merges","archive_url":"https://api.github.com/repos/justeat/AwsWatchman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justeat/AwsWatchman/downloads","issues_url":"https://api.github.com/repos/justeat/AwsWatchman/issues{/number}","pulls_url":"https://api.github.com/repos/justeat/AwsWatchman/pulls{/number}","milestones_url":"https://api.github.com/repos/justeat/AwsWatchman/milestones{/number}","notifications_url":"https://api.github.com/repos/justeat/AwsWatchman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justeat/AwsWatchman/labels{/name}","releases_url":"https://api.github.com/repos/justeat/AwsWatchman/releases{/id}","deployments_url":"https://api.github.com/repos/justeat/AwsWatchman/deployments","created_at":"2017-01-06T11:42:02Z","updated_at":"2019-02-27T14:52:07Z","pushed_at":"2019-02-27T16:14:59Z","git_url":"git://github.com/justeat/AwsWatchman.git","ssh_url":"git@github.com:justeat/AwsWatchman.git","clone_url":"https://github.com/justeat/AwsWatchman.git","svn_url":"https://github.com/justeat/AwsWatchman","homepage":null,"size":712,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/justeat/AwsWatchman/pulls/270"},"html":{"href":"https://github.com/justeat/AwsWatchman/pull/270"},"issue":{"href":"https://api.github.com/repos/justeat/AwsWatchman/issues/270"},"comments":{"href":"https://api.github.com/repos/justeat/AwsWatchman/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/justeat/AwsWatchman/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/justeat/AwsWatchman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/justeat/AwsWatchman/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/justeat/AwsWatchman/statuses/ca4d1430df0fc8819d0f0c7e1b8274bd8105bdad"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tomhaigh","id":2573870,"node_id":"MDQ6VXNlcjI1NzM4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/2573870?v=4","gravatar_id":"","url":"https://api.github.com/users/tomhaigh","html_url":"https://github.com/tomhaigh","followers_url":"https://api.github.com/users/tomhaigh/followers","following_url":"https://api.github.com/users/tomhaigh/following{/other_user}","gists_url":"https://api.github.com/users/tomhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/tomhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomhaigh/subscriptions","organizations_url":"https://api.github.com/users/tomhaigh/orgs","repos_url":"https://api.github.com/users/tomhaigh/repos","events_url":"https://api.github.com/users/tomhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/tomhaigh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"tomhaigh"}}