{"action":"created","issue":{"url":"https://api.github.com/repos/MAIF/izanami/issues/244","repository_url":"https://api.github.com/repos/MAIF/izanami","labels_url":"https://api.github.com/repos/MAIF/izanami/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/MAIF/izanami/issues/244/comments","events_url":"https://api.github.com/repos/MAIF/izanami/issues/244/events","html_url":"https://github.com/MAIF/izanami/pull/244","id":436655588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczMDk4MjM5","number":244,"title":"Fix #242 : create a valid request for the health check","user":{"login":"gmembre-zenika","id":7294764,"node_id":"MDQ6VXNlcjcyOTQ3NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7294764?v=4","gravatar_id":"","url":"https://api.github.com/users/gmembre-zenika","html_url":"https://github.com/gmembre-zenika","followers_url":"https://api.github.com/users/gmembre-zenika/followers","following_url":"https://api.github.com/users/gmembre-zenika/following{/other_user}","gists_url":"https://api.github.com/users/gmembre-zenika/gists{/gist_id}","starred_url":"https://api.github.com/users/gmembre-zenika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmembre-zenika/subscriptions","organizations_url":"https://api.github.com/users/gmembre-zenika/orgs","repos_url":"https://api.github.com/users/gmembre-zenika/repos","events_url":"https://api.github.com/users/gmembre-zenika/events{/privacy}","received_events_url":"https://api.github.com/users/gmembre-zenika/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-04-24T11:58:37Z","updated_at":"2019-04-25T16:47:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MAIF/izanami/pulls/244","html_url":"https://github.com/MAIF/izanami/pull/244","diff_url":"https://github.com/MAIF/izanami/pull/244.diff","patch_url":"https://github.com/MAIF/izanami/pull/244.patch"},"body":"Hi,\r\n\r\nthanks for your work, as described in #242, here a fix for the empty request which now works for the health ckeck endpoint.\r\n\r\nBest regards\r\nGuillaume"},"comment":{"url":"https://api.github.com/repos/MAIF/izanami/issues/comments/486750792","html_url":"https://github.com/MAIF/izanami/pull/244#issuecomment-486750792","issue_url":"https://api.github.com/repos/MAIF/izanami/issues/244","id":486750792,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4Njc1MDc5Mg==","user":{"login":"gmembre-zenika","id":7294764,"node_id":"MDQ6VXNlcjcyOTQ3NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7294764?v=4","gravatar_id":"","url":"https://api.github.com/users/gmembre-zenika","html_url":"https://github.com/gmembre-zenika","followers_url":"https://api.github.com/users/gmembre-zenika/followers","following_url":"https://api.github.com/users/gmembre-zenika/following{/other_user}","gists_url":"https://api.github.com/users/gmembre-zenika/gists{/gist_id}","starred_url":"https://api.github.com/users/gmembre-zenika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmembre-zenika/subscriptions","organizations_url":"https://api.github.com/users/gmembre-zenika/orgs","repos_url":"https://api.github.com/users/gmembre-zenika/repos","events_url":"https://api.github.com/users/gmembre-zenika/events{/privacy}","received_events_url":"https://api.github.com/users/gmembre-zenika/received_events","type":"User","site_admin":false},"created_at":"2019-04-25T16:47:15Z","updated_at":"2019-04-25T16:47:15Z","author_association":"CONTRIBUTOR","body":"A bit more description : \r\nduring healthcheck, a request was made to the dynamodb to ensure that it is still working. In order to be safe, a limit of `0` was fixed in order to avoid to retrieve the complete database. But, (I don't why it happens now), this limit of `0` is not permitted and thus it must be `1` at a minimum.\r\nIf I only changed `withLimit(0)` to `withLimit(1)` a new error is thrown stating that a query should contains criteria.\r\nThe proposed modification ensure the query is valid and look for a dummy value which isn't expected to exist in order to check the connection. If the value exist, it doesn't change the behaviour, the retrieved value isn't read.\r\n\r\nWhat do you think of this ?"}}
{"actor":{"display_login":"gmembre-zenika"}}