{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/hive/issues/732","repository_url":"https://api.github.com/repos/openshift/hive","labels_url":"https://api.github.com/repos/openshift/hive/issues/732/labels{/name}","comments_url":"https://api.github.com/repos/openshift/hive/issues/732/comments","events_url":"https://api.github.com/repos/openshift/hive/issues/732/events","html_url":"https://github.com/openshift/hive/pull/732","id":534235122,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMTgwOTAy","number":732,"title":"allow machine pools to be auto-scaled","user":{"login":"staebler","id":30120115,"node_id":"MDQ6VXNlcjMwMTIwMTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30120115?v=4","gravatar_id":"","url":"https://api.github.com/users/staebler","html_url":"https://github.com/staebler","followers_url":"https://api.github.com/users/staebler/followers","following_url":"https://api.github.com/users/staebler/following{/other_user}","gists_url":"https://api.github.com/users/staebler/gists{/gist_id}","starred_url":"https://api.github.com/users/staebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staebler/subscriptions","organizations_url":"https://api.github.com/users/staebler/orgs","repos_url":"https://api.github.com/users/staebler/repos","events_url":"https://api.github.com/users/staebler/events{/privacy}","received_events_url":"https://api.github.com/users/staebler/received_events","type":"User","site_admin":false},"labels":[{"id":1065256951,"node_id":"MDU6TGFiZWwxMDY1MjU2OTUx","url":"https://api.github.com/repos/openshift/hive/labels/approved","name":"approved","color":"0ffa16","default":false,"description":"Indicates a PR has been approved by an approver from all required OWNERS files."},{"id":1065257811,"node_id":"MDU6TGFiZWwxMDY1MjU3ODEx","url":"https://api.github.com/repos/openshift/hive/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false,"description":"Indicates that a PR should not merge because someone has issued a /hold command."},{"id":1062686833,"node_id":"MDU6TGFiZWwxMDYyNjg2ODMz","url":"https://api.github.com/repos/openshift/hive/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false,"description":"Denotes a PR that changes 1000+ lines, ignoring generated files."}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-12-06T20:07:50Z","updated_at":"2019-12-06T21:42:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/hive/pulls/732","html_url":"https://github.com/openshift/hive/pull/732","diff_url":"https://github.com/openshift/hive/pull/732.diff","patch_url":"https://github.com/openshift/hive/pull/732.patch"},"body":"This adds an autoscaling field to MachinePools. Under the autoscaling field are the minReplicas and maxReplicas fields. The autoscaling field is mutually exclusive with the replicas field. The user can either specify a static number of replicas or specify that the cluster should take care of auto-scaling between the min and max replicas.\r\n\r\nWhen auto-scaling is enabled for a machine pool, Hive will ensure that the cluster has a \"default\" ClusterAutoscaler resource with scale down enabled. Hive will also create MachineAutoscaler resources for each of the MachineSets for the MachinePool. The minReplicas and maxReplicas specified in the MachinePool will be distributed evenly across all of the MachineAutoscaler resources.\r\n\r\nFor example, let us say that minReplicas is 5 and maxReplicas is 10 for a MachinePool using 3 zones. Since there are 3 zones, there will be 3 MachineSets and 3 MachineAutoscalers. The first MachineAutoscaler will specify a minimum of 2 replicas and a maximum of 4 replicas. The second MachineAutoscaler will specify a minimum of 2 replicas and a maximum of 3 replicas. The last MachineAutoscaler will specify a minimum of 1 replica and a maximum of 3 replicas. In total, the minimum replicas specified by the MachineAutoscalers will be (2+2+1=) 5 and the maximum replicas will be (4+3+3=) 10.\r\n\r\nIn order for the autoscaler to consider a MachineSet for scaling, that MachineSet must specify at least 1 replica. Consequently, the minimum number of replicas is bounded on the lower end by the number of zones used for the MachinePool. If the zones are specified explicitly in the MachinePool, then the validator will ensure that the minimum replicas specified are sufficient. If the zones are not specified explicitly, then the controller will put a condition on the MachinePool if the minimum replicas are not sufficient. In the latter case, the controller will not create any MachineSets until the user specifies a sufficient number of minimum replicas."},"comment":{"url":"https://api.github.com/repos/openshift/hive/issues/comments/562747665","html_url":"https://github.com/openshift/hive/pull/732#issuecomment-562747665","issue_url":"https://api.github.com/repos/openshift/hive/issues/732","id":562747665,"node_id":"MDEyOklzc3VlQ29tbWVudDU2Mjc0NzY2NQ==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-12-06T21:42:54Z","updated_at":"2019-12-06T21:42:54Z","author_association":"NONE","body":"@staebler: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/e2e | 2300e97948fcad840711e9b2b778ef794e3db4b0 | [link](https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_hive/732/pull-ci-openshift-hive-v1-e2e/94) | `/test e2e`\n\n[Full PR test history](https://prow.svc.ci.openshift.org/pr-history?org=openshift&repo=hive&pr=732). [Your PR dashboard](https://prow.svc.ci.openshift.org/pr?query=is:pr+state:open+author:staebler). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/hive/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}