{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/comments/325891032","pull_request_review_id":290200123,"id":325891032,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTg5MTAzMg==","diff_hunk":"@@ -215,11 +223,21 @@ describe('owners bot', () => {\n           '_test_hash_',\n           checkRun\n         );\n-\n         // Ensures the test fails if the assertion is never run.\n         expect(true).toBe(true);\n       });\n     });\n+\n+    it('creates a notification comment', async () => {\n+      expect.assertions(1);\n+      getCheckRunIdsStub.returns({});\n+      sandbox.stub(OwnersBot.prototype, 'createNotifications');\n+      await ownersBot.runOwnersCheck(github, pr);\n+\n+      sandbox.assert.calledOnce(ownersBot.createNotifications);","path":"owners/test/owners_bot.test.js","position":105,"original_position":105,"commit_id":"5a158b66f3cd2c3ea2f157c564921c6dae938cfc","original_commit_id":"5a158b66f3cd2c3ea2f157c564921c6dae938cfc","user":{"login":"rcebulko","id":6694512,"node_id":"MDQ6VXNlcjY2OTQ1MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6694512?v=4","gravatar_id":"","url":"https://api.github.com/users/rcebulko","html_url":"https://github.com/rcebulko","followers_url":"https://api.github.com/users/rcebulko/followers","following_url":"https://api.github.com/users/rcebulko/following{/other_user}","gists_url":"https://api.github.com/users/rcebulko/gists{/gist_id}","starred_url":"https://api.github.com/users/rcebulko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcebulko/subscriptions","organizations_url":"https://api.github.com/users/rcebulko/orgs","repos_url":"https://api.github.com/users/rcebulko/repos","events_url":"https://api.github.com/users/rcebulko/events{/privacy}","received_events_url":"https://api.github.com/users/rcebulko/received_events","type":"User","site_admin":false},"body":"Sinon is designed to be used in another test suite, be it mocha or jest or something else, so I don't see an issue with that. I don't like the expects there, but sinon doesn't have a similar expect.assertions method. I'm not sure what the best solution would be.","created_at":"2019-09-18T21:03:16Z","updated_at":"2019-09-18T21:03:16Z","html_url":"https://github.com/ampproject/amp-github-apps/pull/443#discussion_r325891032","pull_request_url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/comments/325891032"},"html":{"href":"https://github.com/ampproject/amp-github-apps/pull/443#discussion_r325891032"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443"}},"in_reply_to_id":325838137},"pull_request":{"url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443","id":318929211,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4OTI5MjEx","html_url":"https://github.com/ampproject/amp-github-apps/pull/443","diff_url":"https://github.com/ampproject/amp-github-apps/pull/443.diff","patch_url":"https://github.com/ampproject/amp-github-apps/pull/443.patch","issue_url":"https://api.github.com/repos/ampproject/amp-github-apps/issues/443","number":443,"state":"open","locked":false,"title":"[owners] Create a comment tagging owners with the always-notify modifier","user":{"login":"rcebulko","id":6694512,"node_id":"MDQ6VXNlcjY2OTQ1MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6694512?v=4","gravatar_id":"","url":"https://api.github.com/users/rcebulko","html_url":"https://github.com/rcebulko","followers_url":"https://api.github.com/users/rcebulko/followers","following_url":"https://api.github.com/users/rcebulko/following{/other_user}","gists_url":"https://api.github.com/users/rcebulko/gists{/gist_id}","starred_url":"https://api.github.com/users/rcebulko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcebulko/subscriptions","organizations_url":"https://api.github.com/users/rcebulko/orgs","repos_url":"https://api.github.com/users/rcebulko/repos","events_url":"https://api.github.com/users/rcebulko/events{/privacy}","received_events_url":"https://api.github.com/users/rcebulko/received_events","type":"User","site_admin":false},"body":"Owners specified as always-notify, ie. `!rcebulko`, should be tagged on a PR even if they are not a reviewer. This PR uses existing API interfaces to verify that such a comment does not yet exist, determine which users/teams should be notified for which files, and creates a PR comment tagging those users/teams.","created_at":"2019-09-18T17:50:36Z","updated_at":"2019-09-18T21:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf5a0cb61909e6e266ff90b13c7b81a731a8054d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1380754822,"node_id":"MDU6TGFiZWwxMzgwNzU0ODIy","url":"https://api.github.com/repos/ampproject/amp-github-apps/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443/commits","review_comments_url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443/comments","review_comment_url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amp-github-apps/issues/443/comments","statuses_url":"https://api.github.com/repos/ampproject/amp-github-apps/statuses/5a158b66f3cd2c3ea2f157c564921c6dae938cfc","head":{"label":"rcebulko:notify","ref":"notify","sha":"5a158b66f3cd2c3ea2f157c564921c6dae938cfc","user":{"login":"rcebulko","id":6694512,"node_id":"MDQ6VXNlcjY2OTQ1MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6694512?v=4","gravatar_id":"","url":"https://api.github.com/users/rcebulko","html_url":"https://github.com/rcebulko","followers_url":"https://api.github.com/users/rcebulko/followers","following_url":"https://api.github.com/users/rcebulko/following{/other_user}","gists_url":"https://api.github.com/users/rcebulko/gists{/gist_id}","starred_url":"https://api.github.com/users/rcebulko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcebulko/subscriptions","organizations_url":"https://api.github.com/users/rcebulko/orgs","repos_url":"https://api.github.com/users/rcebulko/repos","events_url":"https://api.github.com/users/rcebulko/events{/privacy}","received_events_url":"https://api.github.com/users/rcebulko/received_events","type":"User","site_admin":false},"repo":{"id":189616799,"node_id":"MDEwOlJlcG9zaXRvcnkxODk2MTY3OTk=","name":"amp-github-apps","full_name":"rcebulko/amp-github-apps","private":false,"owner":{"login":"rcebulko","id":6694512,"node_id":"MDQ6VXNlcjY2OTQ1MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6694512?v=4","gravatar_id":"","url":"https://api.github.com/users/rcebulko","html_url":"https://github.com/rcebulko","followers_url":"https://api.github.com/users/rcebulko/followers","following_url":"https://api.github.com/users/rcebulko/following{/other_user}","gists_url":"https://api.github.com/users/rcebulko/gists{/gist_id}","starred_url":"https://api.github.com/users/rcebulko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcebulko/subscriptions","organizations_url":"https://api.github.com/users/rcebulko/orgs","repos_url":"https://api.github.com/users/rcebulko/repos","events_url":"https://api.github.com/users/rcebulko/events{/privacy}","received_events_url":"https://api.github.com/users/rcebulko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rcebulko/amp-github-apps","description":"GitHub Apps for the AMP Project","fork":true,"url":"https://api.github.com/repos/rcebulko/amp-github-apps","forks_url":"https://api.github.com/repos/rcebulko/amp-github-apps/forks","keys_url":"https://api.github.com/repos/rcebulko/amp-github-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcebulko/amp-github-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcebulko/amp-github-apps/teams","hooks_url":"https://api.github.com/repos/rcebulko/amp-github-apps/hooks","issue_events_url":"https://api.github.com/repos/rcebulko/amp-github-apps/issues/events{/number}","events_url":"https://api.github.com/repos/rcebulko/amp-github-apps/events","assignees_url":"https://api.github.com/repos/rcebulko/amp-github-apps/assignees{/user}","branches_url":"https://api.github.com/repos/rcebulko/amp-github-apps/branches{/branch}","tags_url":"https://api.github.com/repos/rcebulko/amp-github-apps/tags","blobs_url":"https://api.github.com/repos/rcebulko/amp-github-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcebulko/amp-github-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcebulko/amp-github-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcebulko/amp-github-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcebulko/amp-github-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/rcebulko/amp-github-apps/languages","stargazers_url":"https://api.github.com/repos/rcebulko/amp-github-apps/stargazers","contributors_url":"https://api.github.com/repos/rcebulko/amp-github-apps/contributors","subscribers_url":"https://api.github.com/repos/rcebulko/amp-github-apps/subscribers","subscription_url":"https://api.github.com/repos/rcebulko/amp-github-apps/subscription","commits_url":"https://api.github.com/repos/rcebulko/amp-github-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcebulko/amp-github-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcebulko/amp-github-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcebulko/amp-github-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcebulko/amp-github-apps/contents/{+path}","compare_url":"https://api.github.com/repos/rcebulko/amp-github-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcebulko/amp-github-apps/merges","archive_url":"https://api.github.com/repos/rcebulko/amp-github-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcebulko/amp-github-apps/downloads","issues_url":"https://api.github.com/repos/rcebulko/amp-github-apps/issues{/number}","pulls_url":"https://api.github.com/repos/rcebulko/amp-github-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/rcebulko/amp-github-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/rcebulko/amp-github-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcebulko/amp-github-apps/labels{/name}","releases_url":"https://api.github.com/repos/rcebulko/amp-github-apps/releases{/id}","deployments_url":"https://api.github.com/repos/rcebulko/amp-github-apps/deployments","created_at":"2019-05-31T15:24:52Z","updated_at":"2019-09-18T16:27:23Z","pushed_at":"2019-09-18T17:51:53Z","git_url":"git://github.com/rcebulko/amp-github-apps.git","ssh_url":"git@github.com:rcebulko/amp-github-apps.git","clone_url":"https://github.com/rcebulko/amp-github-apps.git","svn_url":"https://github.com/rcebulko/amp-github-apps","homepage":"http://amp.dev","size":3086,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"1df1882899abda5ecd05264855635365af6575d3","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":157890524,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4OTA1MjQ=","name":"amp-github-apps","full_name":"ampproject/amp-github-apps","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amp-github-apps","description":"GitHub Apps for the AMP Project","fork":false,"url":"https://api.github.com/repos/ampproject/amp-github-apps","forks_url":"https://api.github.com/repos/ampproject/amp-github-apps/forks","keys_url":"https://api.github.com/repos/ampproject/amp-github-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amp-github-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amp-github-apps/teams","hooks_url":"https://api.github.com/repos/ampproject/amp-github-apps/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amp-github-apps/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amp-github-apps/events","assignees_url":"https://api.github.com/repos/ampproject/amp-github-apps/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amp-github-apps/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amp-github-apps/tags","blobs_url":"https://api.github.com/repos/ampproject/amp-github-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amp-github-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amp-github-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amp-github-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amp-github-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amp-github-apps/languages","stargazers_url":"https://api.github.com/repos/ampproject/amp-github-apps/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amp-github-apps/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amp-github-apps/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amp-github-apps/subscription","commits_url":"https://api.github.com/repos/ampproject/amp-github-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amp-github-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amp-github-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amp-github-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amp-github-apps/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amp-github-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amp-github-apps/merges","archive_url":"https://api.github.com/repos/ampproject/amp-github-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amp-github-apps/downloads","issues_url":"https://api.github.com/repos/ampproject/amp-github-apps/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amp-github-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amp-github-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amp-github-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amp-github-apps/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amp-github-apps/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amp-github-apps/deployments","created_at":"2018-11-16T16:04:24Z","updated_at":"2019-09-18T16:55:28Z","pushed_at":"2019-09-18T17:51:55Z","git_url":"git://github.com/ampproject/amp-github-apps.git","ssh_url":"git@github.com:ampproject/amp-github-apps.git","clone_url":"https://github.com/ampproject/amp-github-apps.git","svn_url":"https://github.com/ampproject/amp-github-apps","homepage":"http://amp.dev","size":3088,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":23,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443"},"html":{"href":"https://github.com/ampproject/amp-github-apps/pull/443"},"issue":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/issues/443"},"comments":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amp-github-apps/statuses/5a158b66f3cd2c3ea2f157c564921c6dae938cfc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rcebulko"}}