{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/6590","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/6590/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/6590/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/6590/events","html_url":"https://github.com/apache/kafka/pull/6590","id":434073873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxMTQzMjI5","number":6590,"title":"MINOR: make LogCleaner.shouldRetainRecord more clear to read","user":{"login":"FreeeeLy","id":31944335,"node_id":"MDQ6VXNlcjMxOTQ0MzM1","avatar_url":"https://avatars3.githubusercontent.com/u/31944335?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeeeLy","html_url":"https://github.com/FreeeeLy","followers_url":"https://api.github.com/users/FreeeeLy/followers","following_url":"https://api.github.com/users/FreeeeLy/following{/other_user}","gists_url":"https://api.github.com/users/FreeeeLy/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeeeLy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeeeLy/subscriptions","organizations_url":"https://api.github.com/users/FreeeeLy/orgs","repos_url":"https://api.github.com/users/FreeeeLy/repos","events_url":"https://api.github.com/users/FreeeeLy/events{/privacy}","received_events_url":"https://api.github.com/users/FreeeeLy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-04-17T03:19:20Z","updated_at":"2019-04-19T06:16:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/6590","html_url":"https://github.com/apache/kafka/pull/6590","diff_url":"https://github.com/apache/kafka/pull/6590.diff","patch_url":"https://github.com/apache/kafka/pull/6590.patch"},"body":"The comments of LogCleaner.shouldRetainRecord are pretty clear to tell us when to retain a record.\r\nHowever, I think the code is not so clear as the comments so that i make some changes:\r\n`val redundant = foundOffset >= 0 && record.offset < foundOffset`\r\n--->\r\n`val latest= foundOffset < 0 || record.offset >= foundOffset`\r\n\r\nif there dose not exist a message with the key, foundOffset will be -1, record.offset is larger than -1:\r\n`val latest = record.offset() >= foundOffset`"},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/484778695","html_url":"https://github.com/apache/kafka/pull/6590#issuecomment-484778695","issue_url":"https://api.github.com/repos/apache/kafka/issues/6590","id":484778695,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NDc3ODY5NQ==","user":{"login":"FreeeeLy","id":31944335,"node_id":"MDQ6VXNlcjMxOTQ0MzM1","avatar_url":"https://avatars3.githubusercontent.com/u/31944335?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeeeLy","html_url":"https://github.com/FreeeeLy","followers_url":"https://api.github.com/users/FreeeeLy/followers","following_url":"https://api.github.com/users/FreeeeLy/following{/other_user}","gists_url":"https://api.github.com/users/FreeeeLy/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeeeLy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeeeLy/subscriptions","organizations_url":"https://api.github.com/users/FreeeeLy/orgs","repos_url":"https://api.github.com/users/FreeeeLy/repos","events_url":"https://api.github.com/users/FreeeeLy/events{/privacy}","received_events_url":"https://api.github.com/users/FreeeeLy/received_events","type":"User","site_admin":false},"created_at":"2019-04-19T06:16:39Z","updated_at":"2019-04-19T06:16:39Z","author_association":"CONTRIBUTOR","body":"Retest this,please"}}
{"actor":{"display_login":"FreeeeLy"}}