{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/avocado/issues/18","repository_url":"https://api.github.com/repos/mozilla/avocado","labels_url":"https://api.github.com/repos/mozilla/avocado/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/avocado/issues/18/comments","events_url":"https://api.github.com/repos/mozilla/avocado/issues/18/events","html_url":"https://github.com/mozilla/avocado/pull/18","id":449871995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMzEyNTI4","number":18,"title":"added coverage and istanbul fixes # 12","user":{"login":"zyjenny","id":50588415,"node_id":"MDQ6VXNlcjUwNTg4NDE1","avatar_url":"https://avatars3.githubusercontent.com/u/50588415?v=4","gravatar_id":"","url":"https://api.github.com/users/zyjenny","html_url":"https://github.com/zyjenny","followers_url":"https://api.github.com/users/zyjenny/followers","following_url":"https://api.github.com/users/zyjenny/following{/other_user}","gists_url":"https://api.github.com/users/zyjenny/gists{/gist_id}","starred_url":"https://api.github.com/users/zyjenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyjenny/subscriptions","organizations_url":"https://api.github.com/users/zyjenny/orgs","repos_url":"https://api.github.com/users/zyjenny/repos","events_url":"https://api.github.com/users/zyjenny/events{/privacy}","received_events_url":"https://api.github.com/users/zyjenny/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-29T15:21:02Z","updated_at":"2019-05-30T03:55:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mozilla/avocado/pulls/18","html_url":"https://github.com/mozilla/avocado/pull/18","diff_url":"https://github.com/mozilla/avocado/pull/18.diff","patch_url":"https://github.com/mozilla/avocado/pull/18.patch"},"body":"[Just gonna comment here on this PR since Jared is sick and I'd feel bad slacking him all this]\r\n\r\n1. <img width=\"424\" alt=\"Screen Shot 2019-05-29 at 11 07 43 AM\" src=\"https://user-images.githubusercontent.com/50588415/58568560-7ff7c300-8202-11e9-8dd2-36d6745b7505.png\">\r\n\r\nthese are the threshold options for istanbul check-coverage, do we need to add any? \r\n\r\n2. Also, currently when we run \"istanbul\": \"istanbul check-coverage\"\r\nnothing is outputted in the terminal. I’m not sure if the exit code is hidden, or we need to add a some failing test cases for it trigger a 1, or no output is good news, or <some other possibility>? \r\n\r\n3. [cover] is used in the other project example. Should we also include this? \r\ncover   transparently adds coverage information to a node command. Saves\r\n              coverage.json and reports at the end of execution"},"comment":{"url":"https://api.github.com/repos/mozilla/avocado/issues/comments/497192949","html_url":"https://github.com/mozilla/avocado/pull/18#issuecomment-497192949","issue_url":"https://api.github.com/repos/mozilla/avocado/issues/18","id":497192949,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NzE5Mjk0OQ==","user":{"login":"jaredkerim","id":119884,"node_id":"MDQ6VXNlcjExOTg4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/119884?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredkerim","html_url":"https://github.com/jaredkerim","followers_url":"https://api.github.com/users/jaredkerim/followers","following_url":"https://api.github.com/users/jaredkerim/following{/other_user}","gists_url":"https://api.github.com/users/jaredkerim/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredkerim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredkerim/subscriptions","organizations_url":"https://api.github.com/users/jaredkerim/orgs","repos_url":"https://api.github.com/users/jaredkerim/repos","events_url":"https://api.github.com/users/jaredkerim/events{/privacy}","received_events_url":"https://api.github.com/users/jaredkerim/received_events","type":"User","site_admin":false},"created_at":"2019-05-30T03:55:59Z","updated_at":"2019-05-30T03:55:59Z","author_association":"COLLABORATOR","body":"Yep istanbul is the right thing here, but I think we can do this even simpler.  The jest docs say that it has istanbul built in, so we don't need to install it separately.  And we can do the coverage checking just by adding this to package.json:\r\n\r\nhttps://github.com/facebook/jest/blob/master/docs/Configuration.md#coveragethreshold-object\r\n\r\nI just tried it and it works perfectly.  So revert these changes (we don't need to install istanbul or call it separately) and add those settings to package.json and try it yourself, that should close this off."}}
{"actor":{"display_login":"jaredkerim"}}