{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/comments/361035000","pull_request_review_id":336048681,"id":361035000,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTAzNTAwMA==","diff_hunk":"@@ -0,0 +1,484 @@\n+\"\"\"\n+Search functionality for the Gemini archive of observations.\n+\n+For questions, contact ooberdorf@gemini.edu\n+\"\"\"\n+\n+from datetime import date\n+\n+import warnings\n+\n+import astropy\n+from astropy import units\n+from astropy.table import Table, MaskedColumn\n+from astropy.utils.exceptions import AstropyUserWarning\n+from ..utils import commons\n+import numpy as np\n+\n+import json\n+\n+from ..query import BaseQuery\n+from ..utils.class_or_instance import class_or_instance\n+from ..utils import async_to_sync\n+from . import conf\n+\n+__all__ = ['Observations', 'ObservationsClass']  # specifies what to import\n+\n+\n+__valid_instruments__ = [","path":"astroquery/gemini/core.py","position":28,"original_position":28,"commit_id":"4a5dbbee9491b48df11f81021a9e6638586ae0bf","original_commit_id":"6854e9d2e5189c240641989cbfbb28ec9f26fc76","user":{"login":"olyoberdorf","id":9758989,"node_id":"MDQ6VXNlcjk3NTg5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/9758989?v=4","gravatar_id":"","url":"https://api.github.com/users/olyoberdorf","html_url":"https://github.com/olyoberdorf","followers_url":"https://api.github.com/users/olyoberdorf/followers","following_url":"https://api.github.com/users/olyoberdorf/following{/other_user}","gists_url":"https://api.github.com/users/olyoberdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/olyoberdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olyoberdorf/subscriptions","organizations_url":"https://api.github.com/users/olyoberdorf/orgs","repos_url":"https://api.github.com/users/olyoberdorf/repos","events_url":"https://api.github.com/users/olyoberdorf/events{/privacy}","received_events_url":"https://api.github.com/users/olyoberdorf/received_events","type":"User","site_admin":false},"body":"I've decided I'm nervous about defining these options more concretely than the free form strings.  The danger is we see additional options supported server-side and the astroquery data structures will be behind what is actually live.  Tabling for now, but will revisit.","created_at":"2019-12-24T00:52:15Z","updated_at":"2019-12-24T00:52:15Z","html_url":"https://github.com/astropy/astroquery/pull/1596#discussion_r361035000","pull_request_url":"https://api.github.com/repos/astropy/astroquery/pulls/1596","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments/361035000"},"html":{"href":"https://github.com/astropy/astroquery/pull/1596#discussion_r361035000"},"pull_request":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1596"}},"in_reply_to_id":352945406},"pull_request":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/1596","id":348064460,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MDY0NDYw","html_url":"https://github.com/astropy/astroquery/pull/1596","diff_url":"https://github.com/astropy/astroquery/pull/1596.diff","patch_url":"https://github.com/astropy/astroquery/pull/1596.patch","issue_url":"https://api.github.com/repos/astropy/astroquery/issues/1596","number":1596,"state":"open","locked":false,"title":"Initial gemini archive support","user":{"login":"olyoberdorf","id":9758989,"node_id":"MDQ6VXNlcjk3NTg5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/9758989?v=4","gravatar_id":"","url":"https://api.github.com/users/olyoberdorf","html_url":"https://github.com/olyoberdorf","followers_url":"https://api.github.com/users/olyoberdorf/followers","following_url":"https://api.github.com/users/olyoberdorf/following{/other_user}","gists_url":"https://api.github.com/users/olyoberdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/olyoberdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olyoberdorf/subscriptions","organizations_url":"https://api.github.com/users/olyoberdorf/orgs","repos_url":"https://api.github.com/users/olyoberdorf/repos","events_url":"https://api.github.com/users/olyoberdorf/events{/privacy}","received_events_url":"https://api.github.com/users/olyoberdorf/received_events","type":"User","site_admin":false},"body":"This is my initial work towards an astroquery API for Gemini's archive.  For now, I have focused on some basic observation data searches:\r\n\r\n- search by cone\r\n- search by target name\r\n- search by set of parameters with validation\r\n- search by open ended list of search terms (mimiccing the web url for archive.gemini.edu so all web searches are possible/fully futureproofed)\r\n","created_at":"2019-12-03T01:24:57Z","updated_at":"2019-12-24T00:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eebef8e69872a995e322c47e3a8127e4b9b43e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astroquery/pulls/1596/commits","review_comments_url":"https://api.github.com/repos/astropy/astroquery/pulls/1596/comments","review_comment_url":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astroquery/issues/1596/comments","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/4a5dbbee9491b48df11f81021a9e6638586ae0bf","head":{"label":"olyoberdorf:initial_gemini_archive_support","ref":"initial_gemini_archive_support","sha":"4a5dbbee9491b48df11f81021a9e6638586ae0bf","user":{"login":"olyoberdorf","id":9758989,"node_id":"MDQ6VXNlcjk3NTg5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/9758989?v=4","gravatar_id":"","url":"https://api.github.com/users/olyoberdorf","html_url":"https://github.com/olyoberdorf","followers_url":"https://api.github.com/users/olyoberdorf/followers","following_url":"https://api.github.com/users/olyoberdorf/following{/other_user}","gists_url":"https://api.github.com/users/olyoberdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/olyoberdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olyoberdorf/subscriptions","organizations_url":"https://api.github.com/users/olyoberdorf/orgs","repos_url":"https://api.github.com/users/olyoberdorf/repos","events_url":"https://api.github.com/users/olyoberdorf/events{/privacy}","received_events_url":"https://api.github.com/users/olyoberdorf/received_events","type":"User","site_admin":false},"repo":{"id":223263374,"node_id":"MDEwOlJlcG9zaXRvcnkyMjMyNjMzNzQ=","name":"astroquery","full_name":"olyoberdorf/astroquery","private":false,"owner":{"login":"olyoberdorf","id":9758989,"node_id":"MDQ6VXNlcjk3NTg5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/9758989?v=4","gravatar_id":"","url":"https://api.github.com/users/olyoberdorf","html_url":"https://github.com/olyoberdorf","followers_url":"https://api.github.com/users/olyoberdorf/followers","following_url":"https://api.github.com/users/olyoberdorf/following{/other_user}","gists_url":"https://api.github.com/users/olyoberdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/olyoberdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olyoberdorf/subscriptions","organizations_url":"https://api.github.com/users/olyoberdorf/orgs","repos_url":"https://api.github.com/users/olyoberdorf/repos","events_url":"https://api.github.com/users/olyoberdorf/events{/privacy}","received_events_url":"https://api.github.com/users/olyoberdorf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/olyoberdorf/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":true,"url":"https://api.github.com/repos/olyoberdorf/astroquery","forks_url":"https://api.github.com/repos/olyoberdorf/astroquery/forks","keys_url":"https://api.github.com/repos/olyoberdorf/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olyoberdorf/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olyoberdorf/astroquery/teams","hooks_url":"https://api.github.com/repos/olyoberdorf/astroquery/hooks","issue_events_url":"https://api.github.com/repos/olyoberdorf/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/olyoberdorf/astroquery/events","assignees_url":"https://api.github.com/repos/olyoberdorf/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/olyoberdorf/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/olyoberdorf/astroquery/tags","blobs_url":"https://api.github.com/repos/olyoberdorf/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olyoberdorf/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olyoberdorf/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/olyoberdorf/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olyoberdorf/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/olyoberdorf/astroquery/languages","stargazers_url":"https://api.github.com/repos/olyoberdorf/astroquery/stargazers","contributors_url":"https://api.github.com/repos/olyoberdorf/astroquery/contributors","subscribers_url":"https://api.github.com/repos/olyoberdorf/astroquery/subscribers","subscription_url":"https://api.github.com/repos/olyoberdorf/astroquery/subscription","commits_url":"https://api.github.com/repos/olyoberdorf/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/olyoberdorf/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/olyoberdorf/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/olyoberdorf/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/olyoberdorf/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/olyoberdorf/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olyoberdorf/astroquery/merges","archive_url":"https://api.github.com/repos/olyoberdorf/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olyoberdorf/astroquery/downloads","issues_url":"https://api.github.com/repos/olyoberdorf/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/olyoberdorf/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/olyoberdorf/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/olyoberdorf/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olyoberdorf/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/olyoberdorf/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/olyoberdorf/astroquery/deployments","created_at":"2019-11-21T20:51:44Z","updated_at":"2019-11-21T20:51:45Z","pushed_at":"2019-12-24T00:39:29Z","git_url":"git://github.com/olyoberdorf/astroquery.git","ssh_url":"git@github.com:olyoberdorf/astroquery.git","clone_url":"https://github.com/olyoberdorf/astroquery.git","svn_url":"https://github.com/olyoberdorf/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":63071,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"07e55c395f08e911122b5b1954cfb02b6aa3d8f9","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":4787269,"node_id":"MDEwOlJlcG9zaXRvcnk0Nzg3MjY5","name":"astroquery","full_name":"astropy/astroquery","private":false,"owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/astropy/astroquery","description":"Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz","fork":false,"url":"https://api.github.com/repos/astropy/astroquery","forks_url":"https://api.github.com/repos/astropy/astroquery/forks","keys_url":"https://api.github.com/repos/astropy/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astroquery/teams","hooks_url":"https://api.github.com/repos/astropy/astroquery/hooks","issue_events_url":"https://api.github.com/repos/astropy/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astroquery/events","assignees_url":"https://api.github.com/repos/astropy/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astroquery/tags","blobs_url":"https://api.github.com/repos/astropy/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astroquery/languages","stargazers_url":"https://api.github.com/repos/astropy/astroquery/stargazers","contributors_url":"https://api.github.com/repos/astropy/astroquery/contributors","subscribers_url":"https://api.github.com/repos/astropy/astroquery/subscribers","subscription_url":"https://api.github.com/repos/astropy/astroquery/subscription","commits_url":"https://api.github.com/repos/astropy/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astroquery/merges","archive_url":"https://api.github.com/repos/astropy/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astroquery/downloads","issues_url":"https://api.github.com/repos/astropy/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astroquery/deployments","created_at":"2012-06-25T20:52:07Z","updated_at":"2019-12-17T16:07:49Z","pushed_at":"2019-12-24T00:39:31Z","git_url":"git://github.com/astropy/astroquery.git","ssh_url":"git@github.com:astropy/astroquery.git","clone_url":"https://github.com/astropy/astroquery.git","svn_url":"https://github.com/astropy/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":63096,"stargazers_count":254,"watchers_count":254,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":223,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":301,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":223,"open_issues":301,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1596"},"html":{"href":"https://github.com/astropy/astroquery/pull/1596"},"issue":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1596"},"comments":{"href":"https://api.github.com/repos/astropy/astroquery/issues/1596/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1596/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/1596/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astroquery/statuses/4a5dbbee9491b48df11f81021a9e6638586ae0bf"}},"author_association":"NONE"}}
{"actor":{"display_login":"olyoberdorf"}}