{"action":"closed","number":2709,"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/2709","id":300922148,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwOTIyMTQ4","html_url":"https://github.com/google/blockly/pull/2709","diff_url":"https://github.com/google/blockly/pull/2709.diff","patch_url":"https://github.com/google/blockly/pull/2709.patch","issue_url":"https://api.github.com/repos/google/blockly/issues/2709","number":2709,"state":"closed","locked":false,"title":"Updating debug rendering for top and bottom block rows.","user":{"login":"moniika","id":6621618,"node_id":"MDQ6VXNlcjY2MjE2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6621618?v=4","gravatar_id":"","url":"https://api.github.com/users/moniika","html_url":"https://github.com/moniika","followers_url":"https://api.github.com/users/moniika/followers","following_url":"https://api.github.com/users/moniika/following{/other_user}","gists_url":"https://api.github.com/users/moniika/gists{/gist_id}","starred_url":"https://api.github.com/users/moniika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moniika/subscriptions","organizations_url":"https://api.github.com/users/moniika/orgs","repos_url":"https://api.github.com/users/moniika/repos","events_url":"https://api.github.com/users/moniika/events{/privacy}","received_events_url":"https://api.github.com/users/moniika/received_events","type":"User","site_admin":false},"body":"<!--\r\n  - Thanks for submitting code to Blockly!  Please fill out the following as part of\r\n  - your pull request so we can review your code more easily.\r\n  -->\r\n\r\n## The basics\r\n\r\n<!-- TODO: Verify the following, checking each box with an 'x' between the brackets: [x] -->\r\n\r\n- [x] I branched from develop\r\n- [x] My pull request is against develop\r\n- [x] My code follows the [style guide](https://developers.google.com/blockly/guides/modify/web/style-guide)\r\n\r\n## The details\r\n### Proposed Changes\r\n\r\nUpdates debug rendering for top and bottom row to treat them like rows with elements rather than spacer rows.\r\n\r\n### Reason for Changes\r\n\r\nDisplays more information useful for debugging rendering.\r\n\r\nold debug rendering:\r\n![old](https://user-images.githubusercontent.com/6621618/61833806-605bd000-ae2a-11e9-88cb-d315e18a39f8.png)\r\n\r\nnew debug rendering:\r\n![new](https://user-images.githubusercontent.com/6621618/61833813-65b91a80-ae2a-11e9-8b0c-732eeabb31d3.png)\r\n\r\n\r\n### Test Coverage\r\n\r\n<!-- TODO: Please show how you have added tests to cover your changes,\r\n  -        or tell us how you tested it. For each systems you tested,\r\n  -        uncomment the systems in the list below.\r\n  -->\r\n\r\nTested on:\r\n* Desktop Chrome\r\n<!-- * Desktop Firefox -->\r\n<!-- * Desktop Safari -->\r\n<!-- * Desktop Opera -->\r\n<!-- * Windows Internet Explorer 10 -->\r\n<!-- * Windows Internet Explorer 11 -->\r\n<!-- * Windows Edge -->\r\n\r\n<!--\r\n* Smartphone/Tablet/Chromebook (please complete the following information):\r\n  * Device: [e.g. iPhone6]\r\n  * OS: [e.g. iOS8.1]\r\n  * Browser [e.g. stock browser, safari]\r\n  * Version [e.g. 22]\r\n-->","created_at":"2019-07-24T22:48:37Z","updated_at":"2019-07-25T20:32:25Z","closed_at":"2019-07-25T20:32:25Z","merged_at":"2019-07-25T20:32:25Z","merge_commit_sha":"15ca31650f6daad1791937145fad4d15e81aeefe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/blockly/pulls/2709/commits","review_comments_url":"https://api.github.com/repos/google/blockly/pulls/2709/comments","review_comment_url":"https://api.github.com/repos/google/blockly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/blockly/issues/2709/comments","statuses_url":"https://api.github.com/repos/google/blockly/statuses/c858153ea01a01daf5e7eae14aca1904abefb52a","head":{"label":"moniika:moniika-render-debug-top-bottom","ref":"moniika-render-debug-top-bottom","sha":"c858153ea01a01daf5e7eae14aca1904abefb52a","user":{"login":"moniika","id":6621618,"node_id":"MDQ6VXNlcjY2MjE2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6621618?v=4","gravatar_id":"","url":"https://api.github.com/users/moniika","html_url":"https://github.com/moniika","followers_url":"https://api.github.com/users/moniika/followers","following_url":"https://api.github.com/users/moniika/following{/other_user}","gists_url":"https://api.github.com/users/moniika/gists{/gist_id}","starred_url":"https://api.github.com/users/moniika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moniika/subscriptions","organizations_url":"https://api.github.com/users/moniika/orgs","repos_url":"https://api.github.com/users/moniika/repos","events_url":"https://api.github.com/users/moniika/events{/privacy}","received_events_url":"https://api.github.com/users/moniika/received_events","type":"User","site_admin":false},"repo":{"id":196089359,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYwODkzNTk=","name":"blockly","full_name":"moniika/blockly","private":false,"owner":{"login":"moniika","id":6621618,"node_id":"MDQ6VXNlcjY2MjE2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6621618?v=4","gravatar_id":"","url":"https://api.github.com/users/moniika","html_url":"https://github.com/moniika","followers_url":"https://api.github.com/users/moniika/followers","following_url":"https://api.github.com/users/moniika/following{/other_user}","gists_url":"https://api.github.com/users/moniika/gists{/gist_id}","starred_url":"https://api.github.com/users/moniika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moniika/subscriptions","organizations_url":"https://api.github.com/users/moniika/orgs","repos_url":"https://api.github.com/users/moniika/repos","events_url":"https://api.github.com/users/moniika/events{/privacy}","received_events_url":"https://api.github.com/users/moniika/received_events","type":"User","site_admin":false},"html_url":"https://github.com/moniika/blockly","description":"The web-based visual programming editor.","fork":true,"url":"https://api.github.com/repos/moniika/blockly","forks_url":"https://api.github.com/repos/moniika/blockly/forks","keys_url":"https://api.github.com/repos/moniika/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moniika/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moniika/blockly/teams","hooks_url":"https://api.github.com/repos/moniika/blockly/hooks","issue_events_url":"https://api.github.com/repos/moniika/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/moniika/blockly/events","assignees_url":"https://api.github.com/repos/moniika/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/moniika/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/moniika/blockly/tags","blobs_url":"https://api.github.com/repos/moniika/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moniika/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moniika/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/moniika/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moniika/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/moniika/blockly/languages","stargazers_url":"https://api.github.com/repos/moniika/blockly/stargazers","contributors_url":"https://api.github.com/repos/moniika/blockly/contributors","subscribers_url":"https://api.github.com/repos/moniika/blockly/subscribers","subscription_url":"https://api.github.com/repos/moniika/blockly/subscription","commits_url":"https://api.github.com/repos/moniika/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/moniika/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/moniika/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/moniika/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/moniika/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/moniika/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moniika/blockly/merges","archive_url":"https://api.github.com/repos/moniika/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moniika/blockly/downloads","issues_url":"https://api.github.com/repos/moniika/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/moniika/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/moniika/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/moniika/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moniika/blockly/labels{/name}","releases_url":"https://api.github.com/repos/moniika/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/moniika/blockly/deployments","created_at":"2019-07-09T21:57:30Z","updated_at":"2019-07-24T22:26:18Z","pushed_at":"2019-07-25T19:37:17Z","git_url":"git://github.com/moniika/blockly.git","ssh_url":"git@github.com:moniika/blockly.git","clone_url":"https://github.com/moniika/blockly.git","svn_url":"https://github.com/moniika/blockly","homepage":"https://developers.google.com/blockly/","size":93802,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:develop","ref":"develop","sha":"2a528c38b45fac43469611119fd47a0464138802","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":13872231,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MjIzMQ==","name":"blockly","full_name":"google/blockly","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/blockly","description":"The web-based visual programming editor.","fork":false,"url":"https://api.github.com/repos/google/blockly","forks_url":"https://api.github.com/repos/google/blockly/forks","keys_url":"https://api.github.com/repos/google/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/blockly/teams","hooks_url":"https://api.github.com/repos/google/blockly/hooks","issue_events_url":"https://api.github.com/repos/google/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/google/blockly/events","assignees_url":"https://api.github.com/repos/google/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/google/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/google/blockly/tags","blobs_url":"https://api.github.com/repos/google/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/blockly/languages","stargazers_url":"https://api.github.com/repos/google/blockly/stargazers","contributors_url":"https://api.github.com/repos/google/blockly/contributors","subscribers_url":"https://api.github.com/repos/google/blockly/subscribers","subscription_url":"https://api.github.com/repos/google/blockly/subscription","commits_url":"https://api.github.com/repos/google/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/google/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/blockly/merges","archive_url":"https://api.github.com/repos/google/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/blockly/downloads","issues_url":"https://api.github.com/repos/google/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/google/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/blockly/labels{/name}","releases_url":"https://api.github.com/repos/google/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/google/blockly/deployments","created_at":"2013-10-25T21:13:33Z","updated_at":"2019-07-25T13:31:17Z","pushed_at":"2019-07-25T20:32:25Z","git_url":"git://github.com/google/blockly.git","ssh_url":"git@github.com:google/blockly.git","clone_url":"https://github.com/google/blockly.git","svn_url":"https://github.com/google/blockly","homepage":"https://developers.google.com/blockly/","size":95655,"stargazers_count":6382,"watchers_count":6382,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2310,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":448,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2310,"open_issues":448,"watchers":6382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/2709"},"html":{"href":"https://github.com/google/blockly/pull/2709"},"issue":{"href":"https://api.github.com/repos/google/blockly/issues/2709"},"comments":{"href":"https://api.github.com/repos/google/blockly/issues/2709/comments"},"review_comments":{"href":"https://api.github.com/repos/google/blockly/pulls/2709/comments"},"review_comment":{"href":"https://api.github.com/repos/google/blockly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/blockly/pulls/2709/commits"},"statuses":{"href":"https://api.github.com/repos/google/blockly/statuses/c858153ea01a01daf5e7eae14aca1904abefb52a"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"moniika","id":6621618,"node_id":"MDQ6VXNlcjY2MjE2MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6621618?v=4","gravatar_id":"","url":"https://api.github.com/users/moniika","html_url":"https://github.com/moniika","followers_url":"https://api.github.com/users/moniika/followers","following_url":"https://api.github.com/users/moniika/following{/other_user}","gists_url":"https://api.github.com/users/moniika/gists{/gist_id}","starred_url":"https://api.github.com/users/moniika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moniika/subscriptions","organizations_url":"https://api.github.com/users/moniika/orgs","repos_url":"https://api.github.com/users/moniika/repos","events_url":"https://api.github.com/users/moniika/events{/privacy}","received_events_url":"https://api.github.com/users/moniika/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":16,"deletions":23,"changed_files":2}}
{"actor":{"display_login":"moniika"}}