{"action":"created","issue":{"url":"https://api.github.com/repos/api-platform/core/issues/2906","repository_url":"https://api.github.com/repos/api-platform/core","labels_url":"https://api.github.com/repos/api-platform/core/issues/2906/labels{/name}","comments_url":"https://api.github.com/repos/api-platform/core/issues/2906/comments","events_url":"https://api.github.com/repos/api-platform/core/issues/2906/events","html_url":"https://github.com/api-platform/core/pull/2906","id":464375363,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NjY4ODU0","number":2906,"title":"Use workaround for a phpstan error","user":{"login":"teohhanhui","id":548843,"node_id":"MDQ6VXNlcjU0ODg0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/548843?v=4","gravatar_id":"","url":"https://api.github.com/users/teohhanhui","html_url":"https://github.com/teohhanhui","followers_url":"https://api.github.com/users/teohhanhui/followers","following_url":"https://api.github.com/users/teohhanhui/following{/other_user}","gists_url":"https://api.github.com/users/teohhanhui/gists{/gist_id}","starred_url":"https://api.github.com/users/teohhanhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teohhanhui/subscriptions","organizations_url":"https://api.github.com/users/teohhanhui/orgs","repos_url":"https://api.github.com/users/teohhanhui/repos","events_url":"https://api.github.com/users/teohhanhui/events{/privacy}","received_events_url":"https://api.github.com/users/teohhanhui/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-07-04T19:20:25Z","updated_at":"2019-07-04T20:01:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/api-platform/core/pulls/2906","html_url":"https://github.com/api-platform/core/pull/2906","diff_url":"https://github.com/api-platform/core/pull/2906.diff","patch_url":"https://github.com/api-platform/core/pull/2906.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | N/A\r\n| License       | MIT\r\n| Doc PR        | N/A\r\n\r\nUse a workaround for a phpstan error ignored in https://github.com/api-platform/core/pull/2897\r\n\r\nSee https://github.com/phpstan/phpstan/issues/1905#issuecomment-464388880 for some context. But in short:\r\n\r\nphpstan does not infer property type from constructor argument type, and it's not planned to be supported\r\n\r\nI believe this would be a problem for any project that follows the current Symfony CS of not adding `@var` on a property when the matching argument is already type-hinted in the constructor. We've been told that IDEs support that just fine, but we will not have relief in phpstan until we can upgrade to PHP 7.4"},"comment":{"url":"https://api.github.com/repos/api-platform/core/issues/comments/508567092","html_url":"https://github.com/api-platform/core/pull/2906#issuecomment-508567092","issue_url":"https://api.github.com/repos/api-platform/core/issues/2906","id":508567092,"node_id":"MDEyOklzc3VlQ29tbWVudDUwODU2NzA5Mg==","user":{"login":"teohhanhui","id":548843,"node_id":"MDQ6VXNlcjU0ODg0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/548843?v=4","gravatar_id":"","url":"https://api.github.com/users/teohhanhui","html_url":"https://github.com/teohhanhui","followers_url":"https://api.github.com/users/teohhanhui/followers","following_url":"https://api.github.com/users/teohhanhui/following{/other_user}","gists_url":"https://api.github.com/users/teohhanhui/gists{/gist_id}","starred_url":"https://api.github.com/users/teohhanhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teohhanhui/subscriptions","organizations_url":"https://api.github.com/users/teohhanhui/orgs","repos_url":"https://api.github.com/users/teohhanhui/repos","events_url":"https://api.github.com/users/teohhanhui/events{/privacy}","received_events_url":"https://api.github.com/users/teohhanhui/received_events","type":"User","site_admin":false},"created_at":"2019-07-04T20:01:57Z","updated_at":"2019-07-04T20:01:57Z","author_association":"MEMBER","body":"Travis failures seem unrelated. Is the build broken on `master`, @dunglas?"}}
{"actor":{"display_login":"teohhanhui"}}