{"action":"created","issue":{"url":"https://api.github.com/repos/plerup/espsoftwareserial/issues/123","repository_url":"https://api.github.com/repos/plerup/espsoftwareserial","labels_url":"https://api.github.com/repos/plerup/espsoftwareserial/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/plerup/espsoftwareserial/issues/123/comments","events_url":"https://api.github.com/repos/plerup/espsoftwareserial/issues/123/events","html_url":"https://github.com/plerup/espsoftwareserial/issues/123","id":523823451,"node_id":"MDU6SXNzdWU1MjM4MjM0NTE=","number":123,"title":"Removal of the (receivePin, transmitPin, inverse_logic, bufSize, isrBufSize) constructor after 5.0.4","user":{"login":"pawelsky","id":7121220,"node_id":"MDQ6VXNlcjcxMjEyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7121220?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelsky","html_url":"https://github.com/pawelsky","followers_url":"https://api.github.com/users/pawelsky/followers","following_url":"https://api.github.com/users/pawelsky/following{/other_user}","gists_url":"https://api.github.com/users/pawelsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelsky/subscriptions","organizations_url":"https://api.github.com/users/pawelsky/orgs","repos_url":"https://api.github.com/users/pawelsky/repos","events_url":"https://api.github.com/users/pawelsky/events{/privacy}","received_events_url":"https://api.github.com/users/pawelsky/received_events","type":"User","site_admin":false},"labels":[{"id":263758158,"node_id":"MDU6TGFiZWwyNjM3NTgxNTg=","url":"https://api.github.com/repos/plerup/espsoftwareserial/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2019-11-16T09:46:06Z","updated_at":"2019-11-19T08:34:26Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nfirst of all - great library. Glad to see an actively maintained SoftSerial for ESP platforms.\r\n\r\nQuick question though - any particular reason for which the\r\n`SoftwareSerial(int receivePin, int transmitPin, bool inverse_logic = false, int bufSize = 64, int isrBufSize = 0);`\r\nconstructor has been removed and later replaced in 6.0.0 with just:\r\n`SoftwareSerial(int8_t rxPin, int8_t txPin = -1);`\r\n\r\nThat breaks compatibility with the standard Arduino SoftSerial library constructor\r\n`SoftwareSerial(uint8_t receivePin, uint8_t transmitPin, bool inverse_logic = false);`\r\nand makes it more difficult to maintain multi-platform libraries using inverted softserial.\r\n\r\nWould you consider adding it back?"},"comment":{"url":"https://api.github.com/repos/plerup/espsoftwareserial/issues/comments/555392309","html_url":"https://github.com/plerup/espsoftwareserial/issues/123#issuecomment-555392309","issue_url":"https://api.github.com/repos/plerup/espsoftwareserial/issues/123","id":555392309,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NTM5MjMwOQ==","user":{"login":"pawelsky","id":7121220,"node_id":"MDQ6VXNlcjcxMjEyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7121220?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelsky","html_url":"https://github.com/pawelsky","followers_url":"https://api.github.com/users/pawelsky/followers","following_url":"https://api.github.com/users/pawelsky/following{/other_user}","gists_url":"https://api.github.com/users/pawelsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelsky/subscriptions","organizations_url":"https://api.github.com/users/pawelsky/orgs","repos_url":"https://api.github.com/users/pawelsky/repos","events_url":"https://api.github.com/users/pawelsky/events{/privacy}","received_events_url":"https://api.github.com/users/pawelsky/received_events","type":"User","site_admin":false},"created_at":"2019-11-19T08:34:26Z","updated_at":"2019-11-19T08:34:26Z","author_association":"NONE","body":"> but beyond that, it's fine using the defaults.\r\n\r\nThere is one problem though - when you use one begin variant with just non-default parameters provided the invert flag set in constructor will be kept, but if you use the other one it will be overwritten with false. I'm afraid this inconsistency may lead to some head-scratching if someone is not aware of that. Other than that it is fine."}}
{"actor":{"display_login":"pawelsky"}}