{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/49","id":278428955,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4NDI4OTU1","html_url":"https://github.com/MajicDesigns/MD_Parola/pull/49","diff_url":"https://github.com/MajicDesigns/MD_Parola/pull/49.diff","patch_url":"https://github.com/MajicDesigns/MD_Parola/pull/49.patch","issue_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues/49","number":49,"state":"closed","locked":false,"title":"Allow predefining MD_Parola macros when invoking C++ compiler","user":{"login":"thloe1","id":10789210,"node_id":"MDQ6VXNlcjEwNzg5MjEw","avatar_url":"https://avatars1.githubusercontent.com/u/10789210?v=4","gravatar_id":"","url":"https://api.github.com/users/thloe1","html_url":"https://github.com/thloe1","followers_url":"https://api.github.com/users/thloe1/followers","following_url":"https://api.github.com/users/thloe1/following{/other_user}","gists_url":"https://api.github.com/users/thloe1/gists{/gist_id}","starred_url":"https://api.github.com/users/thloe1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thloe1/subscriptions","organizations_url":"https://api.github.com/users/thloe1/orgs","repos_url":"https://api.github.com/users/thloe1/repos","events_url":"https://api.github.com/users/thloe1/events{/privacy}","received_events_url":"https://api.github.com/users/thloe1/received_events","type":"User","site_admin":false},"body":"I have surrounded the `#define`s that enable or disable the animations in `#ifndef`/`#endif` directives.\r\n\r\nThat allows predefining these macros in a `Makefile` or the file `platformio.ini` (the PlatformIO project configuration file), for example:\r\n```\r\n-D ENA_MISC=0\r\n```","created_at":"2019-05-13T20:46:52Z","updated_at":"2019-05-14T21:43:44Z","closed_at":"2019-05-14T21:43:44Z","merged_at":"2019-05-14T21:43:44Z","merge_commit_sha":"8a6ead511dafe6b88e12610c6b2aa995080e261e","assignee":{"login":"MajicDesigns","id":19828051,"node_id":"MDQ6VXNlcjE5ODI4MDUx","avatar_url":"https://avatars2.githubusercontent.com/u/19828051?v=4","gravatar_id":"","url":"https://api.github.com/users/MajicDesigns","html_url":"https://github.com/MajicDesigns","followers_url":"https://api.github.com/users/MajicDesigns/followers","following_url":"https://api.github.com/users/MajicDesigns/following{/other_user}","gists_url":"https://api.github.com/users/MajicDesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/MajicDesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajicDesigns/subscriptions","organizations_url":"https://api.github.com/users/MajicDesigns/orgs","repos_url":"https://api.github.com/users/MajicDesigns/repos","events_url":"https://api.github.com/users/MajicDesigns/events{/privacy}","received_events_url":"https://api.github.com/users/MajicDesigns/received_events","type":"User","site_admin":false},"assignees":[{"login":"MajicDesigns","id":19828051,"node_id":"MDQ6VXNlcjE5ODI4MDUx","avatar_url":"https://avatars2.githubusercontent.com/u/19828051?v=4","gravatar_id":"","url":"https://api.github.com/users/MajicDesigns","html_url":"https://github.com/MajicDesigns","followers_url":"https://api.github.com/users/MajicDesigns/followers","following_url":"https://api.github.com/users/MajicDesigns/following{/other_user}","gists_url":"https://api.github.com/users/MajicDesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/MajicDesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajicDesigns/subscriptions","organizations_url":"https://api.github.com/users/MajicDesigns/orgs","repos_url":"https://api.github.com/users/MajicDesigns/repos","events_url":"https://api.github.com/users/MajicDesigns/events{/privacy}","received_events_url":"https://api.github.com/users/MajicDesigns/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":480996871,"node_id":"MDU6TGFiZWw0ODA5OTY4NzE=","url":"https://api.github.com/repos/MajicDesigns/MD_Parola/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/49/commits","review_comments_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/49/comments","review_comment_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues/49/comments","statuses_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/statuses/3ebe26eedf14664641d34910697ce96156ff2e46","head":{"label":"thloe1:master","ref":"master","sha":"3ebe26eedf14664641d34910697ce96156ff2e46","user":{"login":"thloe1","id":10789210,"node_id":"MDQ6VXNlcjEwNzg5MjEw","avatar_url":"https://avatars1.githubusercontent.com/u/10789210?v=4","gravatar_id":"","url":"https://api.github.com/users/thloe1","html_url":"https://github.com/thloe1","followers_url":"https://api.github.com/users/thloe1/followers","following_url":"https://api.github.com/users/thloe1/following{/other_user}","gists_url":"https://api.github.com/users/thloe1/gists{/gist_id}","starred_url":"https://api.github.com/users/thloe1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thloe1/subscriptions","organizations_url":"https://api.github.com/users/thloe1/orgs","repos_url":"https://api.github.com/users/thloe1/repos","events_url":"https://api.github.com/users/thloe1/events{/privacy}","received_events_url":"https://api.github.com/users/thloe1/received_events","type":"User","site_admin":false},"repo":{"id":186477196,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0NzcxOTY=","name":"MD_Parola","full_name":"thloe1/MD_Parola","private":false,"owner":{"login":"thloe1","id":10789210,"node_id":"MDQ6VXNlcjEwNzg5MjEw","avatar_url":"https://avatars1.githubusercontent.com/u/10789210?v=4","gravatar_id":"","url":"https://api.github.com/users/thloe1","html_url":"https://github.com/thloe1","followers_url":"https://api.github.com/users/thloe1/followers","following_url":"https://api.github.com/users/thloe1/following{/other_user}","gists_url":"https://api.github.com/users/thloe1/gists{/gist_id}","starred_url":"https://api.github.com/users/thloe1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thloe1/subscriptions","organizations_url":"https://api.github.com/users/thloe1/orgs","repos_url":"https://api.github.com/users/thloe1/repos","events_url":"https://api.github.com/users/thloe1/events{/privacy}","received_events_url":"https://api.github.com/users/thloe1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thloe1/MD_Parola","description":"Library for modular scrolling LED matrix text displays","fork":true,"url":"https://api.github.com/repos/thloe1/MD_Parola","forks_url":"https://api.github.com/repos/thloe1/MD_Parola/forks","keys_url":"https://api.github.com/repos/thloe1/MD_Parola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thloe1/MD_Parola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thloe1/MD_Parola/teams","hooks_url":"https://api.github.com/repos/thloe1/MD_Parola/hooks","issue_events_url":"https://api.github.com/repos/thloe1/MD_Parola/issues/events{/number}","events_url":"https://api.github.com/repos/thloe1/MD_Parola/events","assignees_url":"https://api.github.com/repos/thloe1/MD_Parola/assignees{/user}","branches_url":"https://api.github.com/repos/thloe1/MD_Parola/branches{/branch}","tags_url":"https://api.github.com/repos/thloe1/MD_Parola/tags","blobs_url":"https://api.github.com/repos/thloe1/MD_Parola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thloe1/MD_Parola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thloe1/MD_Parola/git/refs{/sha}","trees_url":"https://api.github.com/repos/thloe1/MD_Parola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thloe1/MD_Parola/statuses/{sha}","languages_url":"https://api.github.com/repos/thloe1/MD_Parola/languages","stargazers_url":"https://api.github.com/repos/thloe1/MD_Parola/stargazers","contributors_url":"https://api.github.com/repos/thloe1/MD_Parola/contributors","subscribers_url":"https://api.github.com/repos/thloe1/MD_Parola/subscribers","subscription_url":"https://api.github.com/repos/thloe1/MD_Parola/subscription","commits_url":"https://api.github.com/repos/thloe1/MD_Parola/commits{/sha}","git_commits_url":"https://api.github.com/repos/thloe1/MD_Parola/git/commits{/sha}","comments_url":"https://api.github.com/repos/thloe1/MD_Parola/comments{/number}","issue_comment_url":"https://api.github.com/repos/thloe1/MD_Parola/issues/comments{/number}","contents_url":"https://api.github.com/repos/thloe1/MD_Parola/contents/{+path}","compare_url":"https://api.github.com/repos/thloe1/MD_Parola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thloe1/MD_Parola/merges","archive_url":"https://api.github.com/repos/thloe1/MD_Parola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thloe1/MD_Parola/downloads","issues_url":"https://api.github.com/repos/thloe1/MD_Parola/issues{/number}","pulls_url":"https://api.github.com/repos/thloe1/MD_Parola/pulls{/number}","milestones_url":"https://api.github.com/repos/thloe1/MD_Parola/milestones{/number}","notifications_url":"https://api.github.com/repos/thloe1/MD_Parola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thloe1/MD_Parola/labels{/name}","releases_url":"https://api.github.com/repos/thloe1/MD_Parola/releases{/id}","deployments_url":"https://api.github.com/repos/thloe1/MD_Parola/deployments","created_at":"2019-05-13T18:48:54Z","updated_at":"2019-05-13T20:12:21Z","pushed_at":"2019-05-13T20:12:19Z","git_url":"git://github.com/thloe1/MD_Parola.git","ssh_url":"git@github.com:thloe1/MD_Parola.git","clone_url":"https://github.com/thloe1/MD_Parola.git","svn_url":"https://github.com/thloe1/MD_Parola","homepage":null,"size":10084,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MajicDesigns:master","ref":"master","sha":"3b17bda28e2e5e579249a7b9aebb874cb9374cd2","user":{"login":"MajicDesigns","id":19828051,"node_id":"MDQ6VXNlcjE5ODI4MDUx","avatar_url":"https://avatars2.githubusercontent.com/u/19828051?v=4","gravatar_id":"","url":"https://api.github.com/users/MajicDesigns","html_url":"https://github.com/MajicDesigns","followers_url":"https://api.github.com/users/MajicDesigns/followers","following_url":"https://api.github.com/users/MajicDesigns/following{/other_user}","gists_url":"https://api.github.com/users/MajicDesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/MajicDesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajicDesigns/subscriptions","organizations_url":"https://api.github.com/users/MajicDesigns/orgs","repos_url":"https://api.github.com/users/MajicDesigns/repos","events_url":"https://api.github.com/users/MajicDesigns/events{/privacy}","received_events_url":"https://api.github.com/users/MajicDesigns/received_events","type":"User","site_admin":false},"repo":{"id":73666740,"node_id":"MDEwOlJlcG9zaXRvcnk3MzY2Njc0MA==","name":"MD_Parola","full_name":"MajicDesigns/MD_Parola","private":false,"owner":{"login":"MajicDesigns","id":19828051,"node_id":"MDQ6VXNlcjE5ODI4MDUx","avatar_url":"https://avatars2.githubusercontent.com/u/19828051?v=4","gravatar_id":"","url":"https://api.github.com/users/MajicDesigns","html_url":"https://github.com/MajicDesigns","followers_url":"https://api.github.com/users/MajicDesigns/followers","following_url":"https://api.github.com/users/MajicDesigns/following{/other_user}","gists_url":"https://api.github.com/users/MajicDesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/MajicDesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajicDesigns/subscriptions","organizations_url":"https://api.github.com/users/MajicDesigns/orgs","repos_url":"https://api.github.com/users/MajicDesigns/repos","events_url":"https://api.github.com/users/MajicDesigns/events{/privacy}","received_events_url":"https://api.github.com/users/MajicDesigns/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MajicDesigns/MD_Parola","description":"Library for modular scrolling LED matrix text displays","fork":false,"url":"https://api.github.com/repos/MajicDesigns/MD_Parola","forks_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/forks","keys_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/teams","hooks_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/hooks","issue_events_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues/events{/number}","events_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/events","assignees_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/assignees{/user}","branches_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/branches{/branch}","tags_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/tags","blobs_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/git/refs{/sha}","trees_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/statuses/{sha}","languages_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/languages","stargazers_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/stargazers","contributors_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/contributors","subscribers_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/subscribers","subscription_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/subscription","commits_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/commits{/sha}","git_commits_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/git/commits{/sha}","comments_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/comments{/number}","issue_comment_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues/comments{/number}","contents_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/contents/{+path}","compare_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/merges","archive_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/downloads","issues_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues{/number}","pulls_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls{/number}","milestones_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/milestones{/number}","notifications_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/labels{/name}","releases_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/releases{/id}","deployments_url":"https://api.github.com/repos/MajicDesigns/MD_Parola/deployments","created_at":"2016-11-14T04:25:17Z","updated_at":"2019-05-11T21:08:24Z","pushed_at":"2019-05-14T21:43:44Z","git_url":"git://github.com/MajicDesigns/MD_Parola.git","ssh_url":"git@github.com:MajicDesigns/MD_Parola.git","clone_url":"https://github.com/MajicDesigns/MD_Parola.git","svn_url":"https://github.com/MajicDesigns/MD_Parola","homepage":null,"size":10079,"stargazers_count":159,"watchers_count":159,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":53,"open_issues":1,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/49"},"html":{"href":"https://github.com/MajicDesigns/MD_Parola/pull/49"},"issue":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues/49"},"comments":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/MajicDesigns/MD_Parola/statuses/3ebe26eedf14664641d34910697ce96156ff2e46"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MajicDesigns","id":19828051,"node_id":"MDQ6VXNlcjE5ODI4MDUx","avatar_url":"https://avatars2.githubusercontent.com/u/19828051?v=4","gravatar_id":"","url":"https://api.github.com/users/MajicDesigns","html_url":"https://github.com/MajicDesigns","followers_url":"https://api.github.com/users/MajicDesigns/followers","following_url":"https://api.github.com/users/MajicDesigns/following{/other_user}","gists_url":"https://api.github.com/users/MajicDesigns/gists{/gist_id}","starred_url":"https://api.github.com/users/MajicDesigns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajicDesigns/subscriptions","organizations_url":"https://api.github.com/users/MajicDesigns/orgs","repos_url":"https://api.github.com/users/MajicDesigns/repos","events_url":"https://api.github.com/users/MajicDesigns/events{/privacy}","received_events_url":"https://api.github.com/users/MajicDesigns/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"MajicDesigns"}}