{"action":"closed","number":366,"pull_request":{"url":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/366","id":318630881,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4NjMwODgx","html_url":"https://github.com/RTradeLtd/Temporal/pull/366","diff_url":"https://github.com/RTradeLtd/Temporal/pull/366.diff","patch_url":"https://github.com/RTradeLtd/Temporal/pull/366.patch","issue_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues/366","number":366,"state":"closed","locked":false,"title":"cors fix ","user":{"login":"postables","id":17089485,"node_id":"MDQ6VXNlcjE3MDg5NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/17089485?v=4","gravatar_id":"","url":"https://api.github.com/users/postables","html_url":"https://github.com/postables","followers_url":"https://api.github.com/users/postables/followers","following_url":"https://api.github.com/users/postables/following{/other_user}","gists_url":"https://api.github.com/users/postables/gists{/gist_id}","starred_url":"https://api.github.com/users/postables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postables/subscriptions","organizations_url":"https://api.github.com/users/postables/orgs","repos_url":"https://api.github.com/users/postables/repos","events_url":"https://api.github.com/users/postables/events{/privacy}","received_events_url":"https://api.github.com/users/postables/received_events","type":"User","site_admin":false},"body":"## :construction_worker: Purpose\r\nOur CORS middleware was having some issues, in part not correctly handling injection of the CORS header. Closes https://github.com/RTradeLtd/Temporal/issues/365\r\n\r\n\r\n## :rocket: Changes\r\n* Switches CORS middleware to `rs/cors` and ensure we appropriately whitelist all needed headers, and methods.\r\n* Enables go1.13\r\n\r\n\r\n## :warning: Breaking Changes\r\nNone\r\n\r\n\r\n","created_at":"2019-09-18T05:14:43Z","updated_at":"2019-09-18T23:53:33Z","closed_at":"2019-09-18T23:53:33Z","merged_at":"2019-09-18T23:53:33Z","merge_commit_sha":"bfda370ef32fde2fe88ecb6207f5a57494762b65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/366/commits","review_comments_url":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/366/comments","review_comment_url":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues/366/comments","statuses_url":"https://api.github.com/repos/RTradeLtd/Temporal/statuses/3b29f8e820517be9e48157c485765edcb3931ff9","head":{"label":"RTradeLtd:cors","ref":"cors","sha":"3b29f8e820517be9e48157c485765edcb3931ff9","user":{"login":"RTradeLtd","id":34983363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0OTgzMzYz","avatar_url":"https://avatars3.githubusercontent.com/u/34983363?v=4","gravatar_id":"","url":"https://api.github.com/users/RTradeLtd","html_url":"https://github.com/RTradeLtd","followers_url":"https://api.github.com/users/RTradeLtd/followers","following_url":"https://api.github.com/users/RTradeLtd/following{/other_user}","gists_url":"https://api.github.com/users/RTradeLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/RTradeLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTradeLtd/subscriptions","organizations_url":"https://api.github.com/users/RTradeLtd/orgs","repos_url":"https://api.github.com/users/RTradeLtd/repos","events_url":"https://api.github.com/users/RTradeLtd/events{/privacy}","received_events_url":"https://api.github.com/users/RTradeLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":132073198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwNzMxOTg=","name":"Temporal","full_name":"RTradeLtd/Temporal","private":false,"owner":{"login":"RTradeLtd","id":34983363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0OTgzMzYz","avatar_url":"https://avatars3.githubusercontent.com/u/34983363?v=4","gravatar_id":"","url":"https://api.github.com/users/RTradeLtd","html_url":"https://github.com/RTradeLtd","followers_url":"https://api.github.com/users/RTradeLtd/followers","following_url":"https://api.github.com/users/RTradeLtd/following{/other_user}","gists_url":"https://api.github.com/users/RTradeLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/RTradeLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTradeLtd/subscriptions","organizations_url":"https://api.github.com/users/RTradeLtd/orgs","repos_url":"https://api.github.com/users/RTradeLtd/repos","events_url":"https://api.github.com/users/RTradeLtd/events{/privacy}","received_events_url":"https://api.github.com/users/RTradeLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RTradeLtd/Temporal","description":"☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage","fork":false,"url":"https://api.github.com/repos/RTradeLtd/Temporal","forks_url":"https://api.github.com/repos/RTradeLtd/Temporal/forks","keys_url":"https://api.github.com/repos/RTradeLtd/Temporal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RTradeLtd/Temporal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RTradeLtd/Temporal/teams","hooks_url":"https://api.github.com/repos/RTradeLtd/Temporal/hooks","issue_events_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues/events{/number}","events_url":"https://api.github.com/repos/RTradeLtd/Temporal/events","assignees_url":"https://api.github.com/repos/RTradeLtd/Temporal/assignees{/user}","branches_url":"https://api.github.com/repos/RTradeLtd/Temporal/branches{/branch}","tags_url":"https://api.github.com/repos/RTradeLtd/Temporal/tags","blobs_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/refs{/sha}","trees_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RTradeLtd/Temporal/statuses/{sha}","languages_url":"https://api.github.com/repos/RTradeLtd/Temporal/languages","stargazers_url":"https://api.github.com/repos/RTradeLtd/Temporal/stargazers","contributors_url":"https://api.github.com/repos/RTradeLtd/Temporal/contributors","subscribers_url":"https://api.github.com/repos/RTradeLtd/Temporal/subscribers","subscription_url":"https://api.github.com/repos/RTradeLtd/Temporal/subscription","commits_url":"https://api.github.com/repos/RTradeLtd/Temporal/commits{/sha}","git_commits_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/commits{/sha}","comments_url":"https://api.github.com/repos/RTradeLtd/Temporal/comments{/number}","issue_comment_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues/comments{/number}","contents_url":"https://api.github.com/repos/RTradeLtd/Temporal/contents/{+path}","compare_url":"https://api.github.com/repos/RTradeLtd/Temporal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RTradeLtd/Temporal/merges","archive_url":"https://api.github.com/repos/RTradeLtd/Temporal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RTradeLtd/Temporal/downloads","issues_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues{/number}","pulls_url":"https://api.github.com/repos/RTradeLtd/Temporal/pulls{/number}","milestones_url":"https://api.github.com/repos/RTradeLtd/Temporal/milestones{/number}","notifications_url":"https://api.github.com/repos/RTradeLtd/Temporal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RTradeLtd/Temporal/labels{/name}","releases_url":"https://api.github.com/repos/RTradeLtd/Temporal/releases{/id}","deployments_url":"https://api.github.com/repos/RTradeLtd/Temporal/deployments","created_at":"2018-05-04T02:10:10Z","updated_at":"2019-09-14T23:08:18Z","pushed_at":"2019-09-18T23:53:33Z","git_url":"git://github.com/RTradeLtd/Temporal.git","ssh_url":"git@github.com:RTradeLtd/Temporal.git","clone_url":"https://github.com/RTradeLtd/Temporal.git","svn_url":"https://github.com/RTradeLtd/Temporal","homepage":"https://temporal.cloud","size":2147584,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":7,"watchers":125,"default_branch":"master"}},"base":{"label":"RTradeLtd:master","ref":"master","sha":"5f579d9fcbcaf98132b7126f0d962412718f6966","user":{"login":"RTradeLtd","id":34983363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0OTgzMzYz","avatar_url":"https://avatars3.githubusercontent.com/u/34983363?v=4","gravatar_id":"","url":"https://api.github.com/users/RTradeLtd","html_url":"https://github.com/RTradeLtd","followers_url":"https://api.github.com/users/RTradeLtd/followers","following_url":"https://api.github.com/users/RTradeLtd/following{/other_user}","gists_url":"https://api.github.com/users/RTradeLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/RTradeLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTradeLtd/subscriptions","organizations_url":"https://api.github.com/users/RTradeLtd/orgs","repos_url":"https://api.github.com/users/RTradeLtd/repos","events_url":"https://api.github.com/users/RTradeLtd/events{/privacy}","received_events_url":"https://api.github.com/users/RTradeLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":132073198,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwNzMxOTg=","name":"Temporal","full_name":"RTradeLtd/Temporal","private":false,"owner":{"login":"RTradeLtd","id":34983363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0OTgzMzYz","avatar_url":"https://avatars3.githubusercontent.com/u/34983363?v=4","gravatar_id":"","url":"https://api.github.com/users/RTradeLtd","html_url":"https://github.com/RTradeLtd","followers_url":"https://api.github.com/users/RTradeLtd/followers","following_url":"https://api.github.com/users/RTradeLtd/following{/other_user}","gists_url":"https://api.github.com/users/RTradeLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/RTradeLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTradeLtd/subscriptions","organizations_url":"https://api.github.com/users/RTradeLtd/orgs","repos_url":"https://api.github.com/users/RTradeLtd/repos","events_url":"https://api.github.com/users/RTradeLtd/events{/privacy}","received_events_url":"https://api.github.com/users/RTradeLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RTradeLtd/Temporal","description":"☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage","fork":false,"url":"https://api.github.com/repos/RTradeLtd/Temporal","forks_url":"https://api.github.com/repos/RTradeLtd/Temporal/forks","keys_url":"https://api.github.com/repos/RTradeLtd/Temporal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RTradeLtd/Temporal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RTradeLtd/Temporal/teams","hooks_url":"https://api.github.com/repos/RTradeLtd/Temporal/hooks","issue_events_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues/events{/number}","events_url":"https://api.github.com/repos/RTradeLtd/Temporal/events","assignees_url":"https://api.github.com/repos/RTradeLtd/Temporal/assignees{/user}","branches_url":"https://api.github.com/repos/RTradeLtd/Temporal/branches{/branch}","tags_url":"https://api.github.com/repos/RTradeLtd/Temporal/tags","blobs_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/refs{/sha}","trees_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RTradeLtd/Temporal/statuses/{sha}","languages_url":"https://api.github.com/repos/RTradeLtd/Temporal/languages","stargazers_url":"https://api.github.com/repos/RTradeLtd/Temporal/stargazers","contributors_url":"https://api.github.com/repos/RTradeLtd/Temporal/contributors","subscribers_url":"https://api.github.com/repos/RTradeLtd/Temporal/subscribers","subscription_url":"https://api.github.com/repos/RTradeLtd/Temporal/subscription","commits_url":"https://api.github.com/repos/RTradeLtd/Temporal/commits{/sha}","git_commits_url":"https://api.github.com/repos/RTradeLtd/Temporal/git/commits{/sha}","comments_url":"https://api.github.com/repos/RTradeLtd/Temporal/comments{/number}","issue_comment_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues/comments{/number}","contents_url":"https://api.github.com/repos/RTradeLtd/Temporal/contents/{+path}","compare_url":"https://api.github.com/repos/RTradeLtd/Temporal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RTradeLtd/Temporal/merges","archive_url":"https://api.github.com/repos/RTradeLtd/Temporal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RTradeLtd/Temporal/downloads","issues_url":"https://api.github.com/repos/RTradeLtd/Temporal/issues{/number}","pulls_url":"https://api.github.com/repos/RTradeLtd/Temporal/pulls{/number}","milestones_url":"https://api.github.com/repos/RTradeLtd/Temporal/milestones{/number}","notifications_url":"https://api.github.com/repos/RTradeLtd/Temporal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RTradeLtd/Temporal/labels{/name}","releases_url":"https://api.github.com/repos/RTradeLtd/Temporal/releases{/id}","deployments_url":"https://api.github.com/repos/RTradeLtd/Temporal/deployments","created_at":"2018-05-04T02:10:10Z","updated_at":"2019-09-14T23:08:18Z","pushed_at":"2019-09-18T23:53:33Z","git_url":"git://github.com/RTradeLtd/Temporal.git","ssh_url":"git@github.com:RTradeLtd/Temporal.git","clone_url":"https://github.com/RTradeLtd/Temporal.git","svn_url":"https://github.com/RTradeLtd/Temporal","homepage":"https://temporal.cloud","size":2147584,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":7,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/366"},"html":{"href":"https://github.com/RTradeLtd/Temporal/pull/366"},"issue":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/issues/366"},"comments":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/RTradeLtd/Temporal/statuses/3b29f8e820517be9e48157c485765edcb3931ff9"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"postables","id":17089485,"node_id":"MDQ6VXNlcjE3MDg5NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/17089485?v=4","gravatar_id":"","url":"https://api.github.com/users/postables","html_url":"https://github.com/postables","followers_url":"https://api.github.com/users/postables/followers","following_url":"https://api.github.com/users/postables/following{/other_user}","gists_url":"https://api.github.com/users/postables/gists{/gist_id}","starred_url":"https://api.github.com/users/postables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postables/subscriptions","organizations_url":"https://api.github.com/users/postables/orgs","repos_url":"https://api.github.com/users/postables/repos","events_url":"https://api.github.com/users/postables/events{/privacy}","received_events_url":"https://api.github.com/users/postables/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":10,"additions":122,"deletions":64,"changed_files":7}}
{"actor":{"display_login":"postables"}}