{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/52980","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/52980/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/52980/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/52980/events","html_url":"https://github.com/saltstack/salt/pull/52980","id":443129523,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MDY5NDQy","number":52980,"title":"logstash_mod makePickle doesn't convert to bytes","user":{"login":"kiemlicz","id":7331452,"node_id":"MDQ6VXNlcjczMzE0NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7331452?v=4","gravatar_id":"","url":"https://api.github.com/users/kiemlicz","html_url":"https://github.com/kiemlicz","followers_url":"https://api.github.com/users/kiemlicz/followers","following_url":"https://api.github.com/users/kiemlicz/following{/other_user}","gists_url":"https://api.github.com/users/kiemlicz/gists{/gist_id}","starred_url":"https://api.github.com/users/kiemlicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiemlicz/subscriptions","organizations_url":"https://api.github.com/users/kiemlicz/orgs","repos_url":"https://api.github.com/users/kiemlicz/repos","events_url":"https://api.github.com/users/kiemlicz/events{/privacy}","received_events_url":"https://api.github.com/users/kiemlicz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-05-12T17:49:18Z","updated_at":"2019-06-06T21:25:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/52980","html_url":"https://github.com/saltstack/salt/pull/52980","diff_url":"https://github.com/saltstack/salt/pull/52980.diff","patch_url":"https://github.com/saltstack/salt/pull/52980.patch"},"body":"### What does this PR do?\r\nAdds missing `to_bytes` conversion in log\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/saltstack/salt/issues/51123\r\n\r\n### Previous Behavior\r\n```\r\n--- Logging error ---\r\nTraceback (most recent call last):\r\n  File \"/usr/lib/python3.6/logging/handlers.py\", line 634, in emit\r\n    self.send(s)\r\n  File \"/usr/lib/python3.6/logging/handlers.py\", line 692, in send\r\n    self.sock.sendto(s, self.address)\r\nTypeError: a bytes-like object is required, not 'str'\r\n```\r\n\r\n### New Behavior\r\nNo stacktrace, message sent to logstash\r\n\r\n### Tests written?\r\nNo\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/499673430","html_url":"https://github.com/saltstack/salt/pull/52980#issuecomment-499673430","issue_url":"https://api.github.com/repos/saltstack/salt/issues/52980","id":499673430,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5OTY3MzQzMA==","user":{"login":"kiemlicz","id":7331452,"node_id":"MDQ6VXNlcjczMzE0NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7331452?v=4","gravatar_id":"","url":"https://api.github.com/users/kiemlicz","html_url":"https://github.com/kiemlicz","followers_url":"https://api.github.com/users/kiemlicz/followers","following_url":"https://api.github.com/users/kiemlicz/following{/other_user}","gists_url":"https://api.github.com/users/kiemlicz/gists{/gist_id}","starred_url":"https://api.github.com/users/kiemlicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiemlicz/subscriptions","organizations_url":"https://api.github.com/users/kiemlicz/orgs","repos_url":"https://api.github.com/users/kiemlicz/repos","events_url":"https://api.github.com/users/kiemlicz/events{/privacy}","received_events_url":"https://api.github.com/users/kiemlicz/received_events","type":"User","site_admin":false},"created_at":"2019-06-06T21:25:14Z","updated_at":"2019-06-06T21:25:14Z","author_association":"CONTRIBUTOR","body":"Sure\r\nFirst: It's a `develop` branch\r\nMy OS it's a debian 9.9 \r\n```\r\n> uname -ra\r\nLinux my-hostname-here 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux\r\n```\r\nIn virtualenv, I've performed roughly:\r\n```\r\nsalt_dir > pip3 install pyzmq PyYAML pycrypto msgpack-python jinja2 psutil futures tornado\r\nsalt_dir > pip3 install -e .\r\nsalt_dir > pip3 install -r requirements/dev_python34.txt\r\nsalt_dir > pip3 install -r requirements/pytest.txt\r\nsalt_dir > pip3 install -r requirements/tests.txt\r\n```"}}
{"actor":{"display_login":"kiemlicz"}}