{"action":"created","issue":{"url":"https://api.github.com/repos/jedmao/editorconfig-ini/issues/10","repository_url":"https://api.github.com/repos/jedmao/editorconfig-ini","labels_url":"https://api.github.com/repos/jedmao/editorconfig-ini/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/jedmao/editorconfig-ini/issues/10/comments","events_url":"https://api.github.com/repos/jedmao/editorconfig-ini/issues/10/events","html_url":"https://github.com/jedmao/editorconfig-ini/pull/10","id":528248934,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1MzQ3NTM5","number":10,"title":"Fix limited character-range","user":{"login":"florianb","id":983507,"node_id":"MDQ6VXNlcjk4MzUwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/983507?v=4","gravatar_id":"","url":"https://api.github.com/users/florianb","html_url":"https://github.com/florianb","followers_url":"https://api.github.com/users/florianb/followers","following_url":"https://api.github.com/users/florianb/following{/other_user}","gists_url":"https://api.github.com/users/florianb/gists{/gist_id}","starred_url":"https://api.github.com/users/florianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florianb/subscriptions","organizations_url":"https://api.github.com/users/florianb/orgs","repos_url":"https://api.github.com/users/florianb/repos","events_url":"https://api.github.com/users/florianb/events{/privacy}","received_events_url":"https://api.github.com/users/florianb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-11-25T18:04:56Z","updated_at":"2019-12-03T05:19:38Z","closed_at":"2019-12-03T05:18:30Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jedmao/editorconfig-ini/pulls/10","html_url":"https://github.com/jedmao/editorconfig-ini/pull/10","diff_url":"https://github.com/jedmao/editorconfig-ini/pull/10.diff","patch_url":"https://github.com/jedmao/editorconfig-ini/pull/10.patch"},"body":"This proposal tries to fix the currently limited character range to `char`. This didn't work without the following rules:\r\n\r\n- A `name` always end with a closing bracket (`]`) and an `eol`.\r\n- A `key` never begins with an opening bracket (`[`) and it never contains an equal-sign (`=`).\r\n\r\nTo avoid these rules i see only the option to introduce escaping. @jedmao  - i am really curious what you think about it?\r\n\r\n---\r\n\r\nI also restructured it a little bit to meet the common practice having atomic and tokens at the end of the grammar. I feel like the order of the current rules is a bit more readable if you're not used to read this grammar. But it's only a suggestion."},"comment":{"url":"https://api.github.com/repos/jedmao/editorconfig-ini/issues/comments/561003304","html_url":"https://github.com/jedmao/editorconfig-ini/pull/10#issuecomment-561003304","issue_url":"https://api.github.com/repos/jedmao/editorconfig-ini/issues/10","id":561003304,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MTAwMzMwNA==","user":{"login":"jedmao","id":1058243,"node_id":"MDQ6VXNlcjEwNTgyNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1058243?v=4","gravatar_id":"","url":"https://api.github.com/users/jedmao","html_url":"https://github.com/jedmao","followers_url":"https://api.github.com/users/jedmao/followers","following_url":"https://api.github.com/users/jedmao/following{/other_user}","gists_url":"https://api.github.com/users/jedmao/gists{/gist_id}","starred_url":"https://api.github.com/users/jedmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedmao/subscriptions","organizations_url":"https://api.github.com/users/jedmao/orgs","repos_url":"https://api.github.com/users/jedmao/repos","events_url":"https://api.github.com/users/jedmao/events{/privacy}","received_events_url":"https://api.github.com/users/jedmao/received_events","type":"User","site_admin":false},"created_at":"2019-12-03T05:19:38Z","updated_at":"2019-12-03T05:19:38Z","author_association":"OWNER","body":"Hey @florianb, I had to iterate on this and make my own commit to fix it. I hope you don't mind that your name isn't on the commit?"}}
{"actor":{"display_login":"jedmao"}}