{"action":"created","issue":{"url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/168","repository_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1","labels_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/168/comments","events_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/168/events","html_url":"https://github.com/rust-bitcoin/rust-secp256k1/issues/168","id":509433818,"node_id":"MDU6SXNzdWU1MDk0MzM4MTg=","number":168,"title":"Should we remove der_lax decoding?","user":{"login":"elichai","id":2167860,"node_id":"MDQ6VXNlcjIxNjc4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2167860?v=4","gravatar_id":"","url":"https://api.github.com/users/elichai","html_url":"https://github.com/elichai","followers_url":"https://api.github.com/users/elichai/followers","following_url":"https://api.github.com/users/elichai/following{/other_user}","gists_url":"https://api.github.com/users/elichai/gists{/gist_id}","starred_url":"https://api.github.com/users/elichai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elichai/subscriptions","organizations_url":"https://api.github.com/users/elichai/orgs","repos_url":"https://api.github.com/users/elichai/repos","events_url":"https://api.github.com/users/elichai/events{/privacy}","received_events_url":"https://api.github.com/users/elichai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2019-10-19T10:59:30Z","updated_at":"2019-11-06T14:14:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The exact implementation in the `der_lax()` function is very bitcoin specific, and it's a \"demo code\" in libsecp256k1.\r\n\r\nI do not think this library is meant for bitcoin's consensus verification. if someone wants to verify an old bitcoin signature he can either implement the weird strict der_lax we have or just grab some DER deserializer off the shelf that won't match bitcoin's consensus but will do the job.\r\n\r\n@apoelstra any thoughts?"},"comment":{"url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/comments/550327467","html_url":"https://github.com/rust-bitcoin/rust-secp256k1/issues/168#issuecomment-550327467","issue_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/168","id":550327467,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MDMyNzQ2Nw==","user":{"login":"stevenroose","id":853468,"node_id":"MDQ6VXNlcjg1MzQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/853468?v=4","gravatar_id":"","url":"https://api.github.com/users/stevenroose","html_url":"https://github.com/stevenroose","followers_url":"https://api.github.com/users/stevenroose/followers","following_url":"https://api.github.com/users/stevenroose/following{/other_user}","gists_url":"https://api.github.com/users/stevenroose/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenroose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenroose/subscriptions","organizations_url":"https://api.github.com/users/stevenroose/orgs","repos_url":"https://api.github.com/users/stevenroose/repos","events_url":"https://api.github.com/users/stevenroose/events{/privacy}","received_events_url":"https://api.github.com/users/stevenroose/received_events","type":"User","site_admin":false},"created_at":"2019-11-06T14:14:25Z","updated_at":"2019-11-06T14:14:25Z","author_association":"CONTRIBUTOR","body":"> @real-or-random one reason to rewrite it in Rust is that we could remove a bit of noise from our build.rs file and have one less function to deal with linker problems about.\r\n\r\n@real-or-random \r\n\r\nLike this line in the vendor script in the secp256k1-sys PR:\r\n```sh\r\nfind \"$DIR\" -not -path '*/\\.*' -type f -print0 | xargs -0 sed -i \\\r\n\"/^#include/! s/ecdsa_signature_parse_der_lax/rustsecp256k1_v${VERSIONCODE}_ecdsa_signature_parse_der_lax/g\"\r\n```"}}
{"actor":{"display_login":"stevenroose"}}