{"action":"created","issue":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/17420","repository_url":"https://api.github.com/repos/pytorch/pytorch","labels_url":"https://api.github.com/repos/pytorch/pytorch/issues/17420/labels{/name}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/17420/comments","events_url":"https://api.github.com/repos/pytorch/pytorch/issues/17420/events","html_url":"https://github.com/pytorch/pytorch/pull/17420","id":413608136,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NTU1ODcy","number":17420,"title":"[Onnx] - refactoring serialization of ONNX initializers to be name-based","user":{"login":"spandantiwari","id":23646532,"node_id":"MDQ6VXNlcjIzNjQ2NTMy","avatar_url":"https://avatars3.githubusercontent.com/u/23646532?v=4","gravatar_id":"","url":"https://api.github.com/users/spandantiwari","html_url":"https://github.com/spandantiwari","followers_url":"https://api.github.com/users/spandantiwari/followers","following_url":"https://api.github.com/users/spandantiwari/following{/other_user}","gists_url":"https://api.github.com/users/spandantiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/spandantiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spandantiwari/subscriptions","organizations_url":"https://api.github.com/users/spandantiwari/orgs","repos_url":"https://api.github.com/users/spandantiwari/repos","events_url":"https://api.github.com/users/spandantiwari/events{/privacy}","received_events_url":"https://api.github.com/users/spandantiwari/received_events","type":"User","site_admin":false},"labels":[{"id":679953983,"node_id":"MDU6TGFiZWw2Nzk5NTM5ODM=","url":"https://api.github.com/repos/pytorch/pytorch/labels/jit","name":"jit","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-02-22T22:43:31Z","updated_at":"2019-02-28T23:55:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/17420","html_url":"https://github.com/pytorch/pytorch/pull/17420","diff_url":"https://github.com/pytorch/pytorch/pull/17420.diff","patch_url":"https://github.com/pytorch/pytorch/pull/17420.patch"},"body":"Currently, serialization of model parameters in ONNX export depends on the order in which they are stored in a container (`list` on Python side and `std::vector` on C++ side). This has worked fine till now, but if we need to do any pass on that graph that mutates the parameter list, then strictly order-based serialization may not work.\r\n\r\nThis PR is the first in a set to bring in more passes (such as constant folding) related to ONNX export. This PR lays the groundwork by moving the serialization in ONNX export from order-based to name based approach, which is more amenable to some of the passes. \r\n\r\n@houseroad - As discussed this change uses a map for export, and removes the code from `export.cpp` that relies on the order to compute initializer names. \r\n"},"comment":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/comments/468487410","html_url":"https://github.com/pytorch/pytorch/pull/17420#issuecomment-468487410","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/17420","id":468487410,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2ODQ4NzQxMA==","user":{"login":"spandantiwari","id":23646532,"node_id":"MDQ6VXNlcjIzNjQ2NTMy","avatar_url":"https://avatars3.githubusercontent.com/u/23646532?v=4","gravatar_id":"","url":"https://api.github.com/users/spandantiwari","html_url":"https://github.com/spandantiwari","followers_url":"https://api.github.com/users/spandantiwari/followers","following_url":"https://api.github.com/users/spandantiwari/following{/other_user}","gists_url":"https://api.github.com/users/spandantiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/spandantiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spandantiwari/subscriptions","organizations_url":"https://api.github.com/users/spandantiwari/orgs","repos_url":"https://api.github.com/users/spandantiwari/repos","events_url":"https://api.github.com/users/spandantiwari/events{/privacy}","received_events_url":"https://api.github.com/users/spandantiwari/received_events","type":"User","site_admin":false},"created_at":"2019-02-28T23:55:54Z","updated_at":"2019-02-28T23:55:54Z","author_association":"CONTRIBUTOR","body":"@houseroad - I am seeing that SIGFPE type failure again. Could you please take a look and suggest what can be done to fix this. Thanks."}}
{"actor":{"display_login":"spandantiwari"}}