{"action":"created","issue":{"url":"https://api.github.com/repos/ooni/probe/issues/846","repository_url":"https://api.github.com/repos/ooni/probe","labels_url":"https://api.github.com/repos/ooni/probe/issues/846/labels{/name}","comments_url":"https://api.github.com/repos/ooni/probe/issues/846/comments","events_url":"https://api.github.com/repos/ooni/probe/issues/846/events","html_url":"https://github.com/ooni/probe/issues/846","id":407530503,"node_id":"MDU6SXNzdWU0MDc1MzA1MDM=","number":846,"title":"Define UI and UX for uploading not uploaded measurements","user":{"login":"hellais","id":424620,"node_id":"MDQ6VXNlcjQyNDYyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/424620?v=4","gravatar_id":"","url":"https://api.github.com/users/hellais","html_url":"https://github.com/hellais","followers_url":"https://api.github.com/users/hellais/followers","following_url":"https://api.github.com/users/hellais/following{/other_user}","gists_url":"https://api.github.com/users/hellais/gists{/gist_id}","starred_url":"https://api.github.com/users/hellais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellais/subscriptions","organizations_url":"https://api.github.com/users/hellais/orgs","repos_url":"https://api.github.com/users/hellais/repos","events_url":"https://api.github.com/users/hellais/events{/privacy}","received_events_url":"https://api.github.com/users/hellais/received_events","type":"User","site_admin":false},"labels":[{"id":1196711713,"node_id":"MDU6TGFiZWwxMTk2NzExNzEz","url":"https://api.github.com/repos/ooni/probe/labels/UX","name":"UX","color":"2d6a99","default":false},{"id":1136504456,"node_id":"MDU6TGFiZWwxMTM2NTA0NDU2","url":"https://api.github.com/repos/ooni/probe/labels/probe-mobile","name":"probe-mobile","color":"5dfc7d","default":false}],"state":"open","locked":false,"assignee":{"login":"elioqoshi","id":5436686,"node_id":"MDQ6VXNlcjU0MzY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/5436686?v=4","gravatar_id":"","url":"https://api.github.com/users/elioqoshi","html_url":"https://github.com/elioqoshi","followers_url":"https://api.github.com/users/elioqoshi/followers","following_url":"https://api.github.com/users/elioqoshi/following{/other_user}","gists_url":"https://api.github.com/users/elioqoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/elioqoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elioqoshi/subscriptions","organizations_url":"https://api.github.com/users/elioqoshi/orgs","repos_url":"https://api.github.com/users/elioqoshi/repos","events_url":"https://api.github.com/users/elioqoshi/events{/privacy}","received_events_url":"https://api.github.com/users/elioqoshi/received_events","type":"User","site_admin":false},"assignees":[{"login":"elioqoshi","id":5436686,"node_id":"MDQ6VXNlcjU0MzY2ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/5436686?v=4","gravatar_id":"","url":"https://api.github.com/users/elioqoshi","html_url":"https://github.com/elioqoshi","followers_url":"https://api.github.com/users/elioqoshi/followers","following_url":"https://api.github.com/users/elioqoshi/following{/other_user}","gists_url":"https://api.github.com/users/elioqoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/elioqoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elioqoshi/subscriptions","organizations_url":"https://api.github.com/users/elioqoshi/orgs","repos_url":"https://api.github.com/users/elioqoshi/repos","events_url":"https://api.github.com/users/elioqoshi/events{/privacy}","received_events_url":"https://api.github.com/users/elioqoshi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ooni/probe/milestones/19","html_url":"https://github.com/ooni/probe/milestone/19","labels_url":"https://api.github.com/repos/ooni/probe/milestones/19/labels","id":3970612,"node_id":"MDk6TWlsZXN0b25lMzk3MDYxMg==","number":19,"title":"OONI Probe Mobile 2.1","description":"It includes all issues that need to go into the release 2.1.0.","creator":{"login":"gabelula","id":28330,"node_id":"MDQ6VXNlcjI4MzMw","avatar_url":"https://avatars2.githubusercontent.com/u/28330?v=4","gravatar_id":"","url":"https://api.github.com/users/gabelula","html_url":"https://github.com/gabelula","followers_url":"https://api.github.com/users/gabelula/followers","following_url":"https://api.github.com/users/gabelula/following{/other_user}","gists_url":"https://api.github.com/users/gabelula/gists{/gist_id}","starred_url":"https://api.github.com/users/gabelula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabelula/subscriptions","organizations_url":"https://api.github.com/users/gabelula/orgs","repos_url":"https://api.github.com/users/gabelula/repos","events_url":"https://api.github.com/users/gabelula/events{/privacy}","received_events_url":"https://api.github.com/users/gabelula/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2019-01-14T20:42:01Z","updated_at":"2019-03-11T08:55:11Z","due_on":"2019-03-10T08:00:00Z","closed_at":null},"comments":20,"created_at":"2019-02-07T03:46:33Z","updated_at":"2019-03-11T08:57:29Z","closed_at":null,"author_association":"MEMBER","body":"It is possible that the measurement upload will fail (or that the user did not want to upload measurements at the time to save bandwidth or other reasons) and hence we should offer the possibility inside of the app to upload not uploaded measurements.\r\n\r\nThe implementation of this specified in: https://github.com/ooni/probe/issues/838\r\n\r\nIt would be great if @elioqoshi @holantonela could help us define a UI for handling this scenario.\r\n\r\nI think the upload of not uploaded measurements should be possible on a per-result basis, but most importantly it should be possible to upload all the measurements.\r\n\r\nOne aspect which is especially important is ensuring that the meaning of the *Publish results*, *Sharing* setting option is understood.\r\n\r\nFor example if a user does the following:\r\n1. Has configured their app to not publish results\r\n2. Runs some tests and they are not uploaded\r\n3. Goes to the result listing and no \"Upload all results\" button appears (because the \"Publish results\" setting is still false)\r\n4. Changes their mind about publish results and enables it in the settings\r\n5. They go to the result listing and they can now upload the previously not uploadable results (because they changed the setting)\r\n\r\nHow can we ensure that it's clear that the meaning of the flag is *Publish results* is at the moment in which the upload is offerred and can apply also retroactively to measurements?\r\n\r\nIs it a bad idea to make the flag apply retroactively?\r\n\r\nCan we make the default be that it doesn't apply retroactively, but that still it's possible for a user to override it by making some setting changes?\r\n\r\nI personally think that just showing a modal when the *Publish results* option is flipped on saying \"previously not uploaded measurements will now be uploadable\" is the way to go, but I would also like to hear what @elioqoshi and @holantonela think about this."},"comment":{"url":"https://api.github.com/repos/ooni/probe/issues/comments/471454983","html_url":"https://github.com/ooni/probe/issues/846#issuecomment-471454983","issue_url":"https://api.github.com/repos/ooni/probe/issues/846","id":471454983,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTQ1NDk4Mw==","user":{"login":"lorenzoPrimi","id":1616097,"node_id":"MDQ6VXNlcjE2MTYwOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1616097?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzoPrimi","html_url":"https://github.com/lorenzoPrimi","followers_url":"https://api.github.com/users/lorenzoPrimi/followers","following_url":"https://api.github.com/users/lorenzoPrimi/following{/other_user}","gists_url":"https://api.github.com/users/lorenzoPrimi/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzoPrimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzoPrimi/subscriptions","organizations_url":"https://api.github.com/users/lorenzoPrimi/orgs","repos_url":"https://api.github.com/users/lorenzoPrimi/repos","events_url":"https://api.github.com/users/lorenzoPrimi/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzoPrimi/received_events","type":"User","site_admin":false},"created_at":"2019-03-11T08:57:29Z","updated_at":"2019-03-11T08:57:29Z","author_association":"NONE","body":"> My initial idea was to show that modal dialog when the user taps the question mark icon. Tapping on Upload / Upload All doesn't show it and move ahead right away with Uploading.\r\n\r\nSo that popup is shown if pressing on the `?`while `Upload` / `Upload All` starts the process immediately? "}}
{"actor":{"display_login":"lorenzoPrimi"}}