{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/317998294","pull_request_review_id":280088467,"id":317998294,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzk5ODI5NA==","diff_hunk":"@@ -6,14 +6,36 @@\n extern {\n // CHECK: Function Attrs: nounwind\n // CHECK-NEXT: declare void @extern_fn\n-    fn extern_fn();\n-// CHECK-NOT: Function Attrs: nounwind\n+    fn extern_fn(); // assumed not to unwind","path":"src/test/codegen/extern-functions.rs","position":6,"original_position":6,"commit_id":"edcfc261f994399c4063c878c95cbdc78f7cc302","original_commit_id":"2201adc1080fd5e9161cc8203d849f055650f040","user":{"login":"gnzlbg","id":904614,"node_id":"MDQ6VXNlcjkwNDYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/904614?v=4","gravatar_id":"","url":"https://api.github.com/users/gnzlbg","html_url":"https://github.com/gnzlbg","followers_url":"https://api.github.com/users/gnzlbg/followers","following_url":"https://api.github.com/users/gnzlbg/following{/other_user}","gists_url":"https://api.github.com/users/gnzlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/gnzlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnzlbg/subscriptions","organizations_url":"https://api.github.com/users/gnzlbg/orgs","repos_url":"https://api.github.com/users/gnzlbg/repos","events_url":"https://api.github.com/users/gnzlbg/events{/privacy}","received_events_url":"https://api.github.com/users/gnzlbg/received_events","type":"User","site_admin":false},"body":"> This PR removes the nounwind on the first edge the panic crosses (Rust -> C), but there's another edge (C -> Rust) and we should not have nounwind there either.\r\n\r\nYes, that's correct, that is, the check should be `CHECK-NOT: nounwind`. Otherwise, the second example in #63943, which is equivalent to mozjpeg use case, would still be miscompiled.","created_at":"2019-08-27T10:05:54Z","updated_at":"2019-08-27T10:05:54Z","html_url":"https://github.com/rust-lang/rust/pull/63909#discussion_r317998294","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/63909","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/317998294"},"html":{"href":"https://github.com/rust-lang/rust/pull/63909#discussion_r317998294"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/63909"}},"in_reply_to_id":317480199},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/63909","id":310797501,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwNzk3NTAx","html_url":"https://github.com/rust-lang/rust/pull/63909","diff_url":"https://github.com/rust-lang/rust/pull/63909.diff","patch_url":"https://github.com/rust-lang/rust/pull/63909.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/63909","number":63909,"state":"open","locked":false,"title":"fix nounwind attribute logic","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"body":"With https://github.com/rust-lang/rust/pull/62603 landed, we should also not emit `nounwind` for `extern fn` because we are not actually catching those panics.\r\n\r\nI also noticed that we annotate `extern \"Rust\"` *declarations* with `nounwind`, which seems wrong? I changed this to only do that for non-Rust ABIs. But even that seems wrong to me, given that we let panics bubble into C code by default, shouldn't we also accept panics coming from C code?\r\n\r\nThis should be beta-backported if https://github.com/rust-lang/rust/pull/62603 gets backported.","created_at":"2019-08-26T07:20:49Z","updated_at":"2019-08-27T10:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c56c7ba3074b1074d7e158c9c16cca29652f6187","assignee":{"login":"estebank","id":1606434,"node_id":"MDQ6VXNlcjE2MDY0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"assignees":[{"login":"estebank","id":1606434,"node_id":"MDQ6VXNlcjE2MDY0MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":31942528,"node_id":"MDU6TGFiZWwzMTk0MjUyOA==","url":"https://api.github.com/repos/rust-lang/rust/labels/I-nominated","name":"I-nominated","color":"e10c02","default":false},{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false},{"id":211668100,"node_id":"MDU6TGFiZWwyMTE2NjgxMDA=","url":"https://api.github.com/repos/rust-lang/rust/labels/T-compiler","name":"T-compiler","color":"bfd4f2","default":false},{"id":211668019,"node_id":"MDU6TGFiZWwyMTE2NjgwMTk=","url":"https://api.github.com/repos/rust-lang/rust/labels/T-lang","name":"T-lang","color":"bfd4f2","default":false},{"id":201991156,"node_id":"MDU6TGFiZWwyMDE5OTExNTY=","url":"https://api.github.com/repos/rust-lang/rust/labels/beta-nominated","name":"beta-nominated","color":"1e76d9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/63909/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/63909/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/63909/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/edcfc261f994399c4063c878c95cbdc78f7cc302","head":{"label":"RalfJung:nounwind","ref":"nounwind","sha":"edcfc261f994399c4063c878c95cbdc78f7cc302","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"repo":{"id":81860024,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg2MDAyNA==","name":"rust","full_name":"RalfJung/rust","private":false,"owner":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RalfJung/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/RalfJung/rust","forks_url":"https://api.github.com/repos/RalfJung/rust/forks","keys_url":"https://api.github.com/repos/RalfJung/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RalfJung/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RalfJung/rust/teams","hooks_url":"https://api.github.com/repos/RalfJung/rust/hooks","issue_events_url":"https://api.github.com/repos/RalfJung/rust/issues/events{/number}","events_url":"https://api.github.com/repos/RalfJung/rust/events","assignees_url":"https://api.github.com/repos/RalfJung/rust/assignees{/user}","branches_url":"https://api.github.com/repos/RalfJung/rust/branches{/branch}","tags_url":"https://api.github.com/repos/RalfJung/rust/tags","blobs_url":"https://api.github.com/repos/RalfJung/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RalfJung/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RalfJung/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/RalfJung/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RalfJung/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/RalfJung/rust/languages","stargazers_url":"https://api.github.com/repos/RalfJung/rust/stargazers","contributors_url":"https://api.github.com/repos/RalfJung/rust/contributors","subscribers_url":"https://api.github.com/repos/RalfJung/rust/subscribers","subscription_url":"https://api.github.com/repos/RalfJung/rust/subscription","commits_url":"https://api.github.com/repos/RalfJung/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/RalfJung/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/RalfJung/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/RalfJung/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/RalfJung/rust/contents/{+path}","compare_url":"https://api.github.com/repos/RalfJung/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RalfJung/rust/merges","archive_url":"https://api.github.com/repos/RalfJung/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RalfJung/rust/downloads","issues_url":"https://api.github.com/repos/RalfJung/rust/issues{/number}","pulls_url":"https://api.github.com/repos/RalfJung/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/RalfJung/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/RalfJung/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RalfJung/rust/labels{/name}","releases_url":"https://api.github.com/repos/RalfJung/rust/releases{/id}","deployments_url":"https://api.github.com/repos/RalfJung/rust/deployments","created_at":"2017-02-13T18:59:58Z","updated_at":"2019-06-21T07:07:10Z","pushed_at":"2019-08-27T07:52:14Z","git_url":"git://github.com/RalfJung/rust.git","ssh_url":"git@github.com:RalfJung/rust.git","clone_url":"https://github.com/RalfJung/rust.git","svn_url":"https://github.com/RalfJung/rust","homepage":"https://www.rust-lang.org","size":451533,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"4c58535d09d1261d21569df0036b974811544256","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"Empowering everyone to build reliable and efficient software.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2019-08-27T09:59:24Z","pushed_at":"2019-08-27T09:58:53Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":455249,"stargazers_count":38680,"watchers_count":38680,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6018,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5182,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6018,"open_issues":5182,"watchers":38680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/63909"},"html":{"href":"https://github.com/rust-lang/rust/pull/63909"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/63909"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/63909/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/63909/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/63909/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/edcfc261f994399c4063c878c95cbdc78f7cc302"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gnzlbg"}}