{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/18196","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/18196/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/18196/comments","events_url":"https://api.github.com/repos/electron/electron/issues/18196/events","html_url":"https://github.com/electron/electron/pull/18196","id":441301046,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2NjUzMzgw","number":18196,"title":"fix: destroy tray on current tick","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"labels":[{"id":1243058793,"node_id":"MDU6TGFiZWwxMjQzMDU4Nzkz","url":"https://api.github.com/repos/electron/electron/labels/new-pr%20%F0%9F%8C%B1","name":"new-pr 🌱","color":"8af297","default":false},{"id":1280680886,"node_id":"MDU6TGFiZWwxMjgwNjgwODg2","url":"https://api.github.com/repos/electron/electron/labels/target/4-2-x","name":"target/4-2-x","color":"f22fa2","default":false},{"id":1204064037,"node_id":"MDU6TGFiZWwxMjA0MDY0MDM3","url":"https://api.github.com/repos/electron/electron/labels/target/5-0-x","name":"target/5-0-x","color":"f22fa2","default":false},{"id":1326922782,"node_id":"MDU6TGFiZWwxMzI2OTIyNzgy","url":"https://api.github.com/repos/electron/electron/labels/target/6-0-x","name":"target/6-0-x","color":"f22fa2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-07T15:36:19Z","updated_at":"2019-05-07T19:50:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/18196","html_url":"https://github.com/electron/electron/pull/18196","diff_url":"https://github.com/electron/electron/pull/18196.diff","patch_url":"https://github.com/electron/electron/pull/18196.patch"},"body":"#### Description of Change\r\n\r\nResolves https://github.com/electron/electron/issues/17622.\r\n\r\nThis code was originally added in https://github.com/electron/electron/pull/6448 to handle an edge case crash in 10.9, and we no longer support 10.9 and therefore no longer need to account for this case.\r\n\r\nIt addressed the crash, but also created a race condition whereby when a new tray is created the old tray's destroy wouldn't have been fully completed and therefore a new one would be spawned. This fixes that by destroying the tray on the current tick once more. \r\n\r\ncc @zcbenz @MarshallOfSound \r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Fixed an issue where tray.destroy was not working properly on some linux distros.\r\n"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/490230334","html_url":"https://github.com/electron/electron/pull/18196#issuecomment-490230334","issue_url":"https://api.github.com/repos/electron/electron/issues/18196","id":490230334,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MDIzMDMzNA==","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"created_at":"2019-05-07T19:50:17Z","updated_at":"2019-05-07T19:50:17Z","author_association":"MEMBER","body":"@deepak1556 i added some specs but if there are more specifics that i should test please let me know!"}}
{"actor":{"display_login":"codebytere"}}