{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9815","repository_url":"https://api.github.com/repos/DynamoDS/Dynamo","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9815/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9815/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9815/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/9815","id":460208413,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMzgzOTYz","number":9815,"title":"Prevent custom node package containing duplicate node definition from loading","user":{"login":"aparajit-pratap","id":5710686,"node_id":"MDQ6VXNlcjU3MTA2ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/5710686?v=4","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"labels":[{"id":207906980,"node_id":"MDU6TGFiZWwyMDc5MDY5ODA=","url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/PTAL","name":"PTAL","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-06-25T04:52:06Z","updated_at":"2019-06-27T18:20:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9815","html_url":"https://github.com/DynamoDS/Dynamo/pull/9815","diff_url":"https://github.com/DynamoDS/Dynamo/pull/9815.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/9815.patch"},"body":"### Purpose\r\n\r\nJIRA: DYN-1993\r\n- [X] Prevent custom node package containing an existing node definition from loading (conflicting package)\r\n- [X] Display \"Cannot download package\" dialog with \"MarkForUninstall\" option when trying to install conflicting package\r\n- [X] Display failure to load conflicting CN package notification to notification view extension during startup (when loading already downloaded package) and also during install\r\n- [X] Test these changes with @scottmitchell's fixes in https://github.com/DynamoDS/Dynamo/pull/9803\r\n\r\n![image](https://user-images.githubusercontent.com/5710686/60236110-2671cb00-9878-11e9-815d-e567fa76454b.png)\r\n\r\n\r\nTODO: \r\n- [ ] Turn package install button red on failure to install ZT and custom node packages\r\n- [ ] Add failure dialog similar to failed custom node package install for ZT package install as well\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [X] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [x] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [x] Snapshot of UI changes, if any.\r\n- [ ] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n\r\n### FYIs\r\n\r\n@mjkkirschner @scottmitchell @QilongTang \r\n"},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/506456353","html_url":"https://github.com/DynamoDS/Dynamo/pull/9815#issuecomment-506456353","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9815","id":506456353,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNjQ1NjM1Mw==","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"created_at":"2019-06-27T18:20:00Z","updated_at":"2019-06-27T18:20:00Z","author_association":"MEMBER","body":"heres my try:\r\n```\r\n{clockwork 1.x} cannot be loaded. \r\n\r\nInstalling it will conflict with one or more node definitions that already exist in { clockwork 2.x } which is currently loaded. \r\n\r\nTo install { clockwork 1.x }, Dynamo needs to first uninstall { clockwork 2.x }. \r\n\r\nRestart Dynamo to complete the uninstall, then try and download {clockwork 1.x } again.</value>\r\n\r\n```"}}
{"actor":{"display_login":"mjkkirschner"}}