{"action":"created","comment":{"url":"https://api.github.com/repos/jni-rs/jni-rs/pulls/comments/296118595","pull_request_review_id":252665044,"id":296118595,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjExODU5NQ==","diff_hunk":"@@ -36,6 +36,12 @@ use InitArgs;\n /// an appropriately-sized local frame for larger code fragments\n /// (see [`with_local_frame`](struct.JNIEnv.html#method.with_local_frame))\n /// and [auto locals](struct.JNIEnv.html#method.auto_local) in loops.\n+///\n+/// Jni-rs provides a helper struct to deal with such local references -","path":"src/wrapper/java_vm/vm.rs","position":14,"original_position":14,"commit_id":"c3e8125cb293670a8b6b68dd21bb8a6826756054","original_commit_id":"c3e8125cb293670a8b6b68dd21bb8a6826756054","user":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"body":"I struggle to put in a clear and concise way :-) Basically, it provides JNIEnv to any native thread, combining the performance benefits of permanent attaches whilst removing the risk of local references leaks if used consistently. Is that correct that it is its main value proposition?","created_at":"2019-06-21T07:03:21Z","updated_at":"2019-06-21T07:08:37Z","html_url":"https://github.com/jni-rs/jni-rs/pull/186#discussion_r296118595","pull_request_url":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jni-rs/jni-rs/pulls/comments/296118595"},"html":{"href":"https://github.com/jni-rs/jni-rs/pull/186#discussion_r296118595"},"pull_request":{"href":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186","id":289148144,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MTQ4MTQ0","html_url":"https://github.com/jni-rs/jni-rs/pull/186","diff_url":"https://github.com/jni-rs/jni-rs/pull/186.diff","patch_url":"https://github.com/jni-rs/jni-rs/pull/186.patch","issue_url":"https://api.github.com/repos/jni-rs/jni-rs/issues/186","number":186,"state":"open","locked":false,"title":"Add Executor abstraction","user":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nExecutor is a simple thread attachment manager. It allows to execute closures in attached threads with automatic local references managment done with `with_local_frame`.\r\n\r\nTODO: update changelog, fix formatting\r\n\r\n### Definition of Done\r\n\r\n- [ ] There are no TODOs left in the code\r\n- [ ] Change is covered by automated [tests](https://github.com/jni-rs/jni-rs/blob/master/CONTRIBUTING.md#tests)\r\n- [ ] The [coding guidelines](https://github.com/jni-rs/jni-rs/blob/master/CONTRIBUTING.md#the-code-style) are followed\r\n- [ ] Public API has documentation\r\n- [ ] This change is not breaking **or** mentioned in the Changelog\r\n- [ ] The [continuous integration build](https://www.travis-ci.org/jni-rs/jni-rs) passes\r\n","created_at":"2019-06-18T07:55:52Z","updated_at":"2019-06-21T07:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c51b3c94e88336040781f44e7662d8a60285ff7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186/commits","review_comments_url":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186/comments","review_comment_url":"https://api.github.com/repos/jni-rs/jni-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jni-rs/jni-rs/issues/186/comments","statuses_url":"https://api.github.com/repos/jni-rs/jni-rs/statuses/c3e8125cb293670a8b6b68dd21bb8a6826756054","head":{"label":"vitvakatu:executors","ref":"executors","sha":"c3e8125cb293670a8b6b68dd21bb8a6826756054","user":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"repo":{"id":147303665,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczMDM2NjU=","name":"jni-rs","full_name":"vitvakatu/jni-rs","private":false,"owner":{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vitvakatu/jni-rs","description":"Rust bindings to the JNI","fork":true,"url":"https://api.github.com/repos/vitvakatu/jni-rs","forks_url":"https://api.github.com/repos/vitvakatu/jni-rs/forks","keys_url":"https://api.github.com/repos/vitvakatu/jni-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitvakatu/jni-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitvakatu/jni-rs/teams","hooks_url":"https://api.github.com/repos/vitvakatu/jni-rs/hooks","issue_events_url":"https://api.github.com/repos/vitvakatu/jni-rs/issues/events{/number}","events_url":"https://api.github.com/repos/vitvakatu/jni-rs/events","assignees_url":"https://api.github.com/repos/vitvakatu/jni-rs/assignees{/user}","branches_url":"https://api.github.com/repos/vitvakatu/jni-rs/branches{/branch}","tags_url":"https://api.github.com/repos/vitvakatu/jni-rs/tags","blobs_url":"https://api.github.com/repos/vitvakatu/jni-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitvakatu/jni-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitvakatu/jni-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitvakatu/jni-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitvakatu/jni-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/vitvakatu/jni-rs/languages","stargazers_url":"https://api.github.com/repos/vitvakatu/jni-rs/stargazers","contributors_url":"https://api.github.com/repos/vitvakatu/jni-rs/contributors","subscribers_url":"https://api.github.com/repos/vitvakatu/jni-rs/subscribers","subscription_url":"https://api.github.com/repos/vitvakatu/jni-rs/subscription","commits_url":"https://api.github.com/repos/vitvakatu/jni-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitvakatu/jni-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitvakatu/jni-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitvakatu/jni-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitvakatu/jni-rs/contents/{+path}","compare_url":"https://api.github.com/repos/vitvakatu/jni-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitvakatu/jni-rs/merges","archive_url":"https://api.github.com/repos/vitvakatu/jni-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitvakatu/jni-rs/downloads","issues_url":"https://api.github.com/repos/vitvakatu/jni-rs/issues{/number}","pulls_url":"https://api.github.com/repos/vitvakatu/jni-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/vitvakatu/jni-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/vitvakatu/jni-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitvakatu/jni-rs/labels{/name}","releases_url":"https://api.github.com/repos/vitvakatu/jni-rs/releases{/id}","deployments_url":"https://api.github.com/repos/vitvakatu/jni-rs/deployments","created_at":"2018-09-04T07:11:15Z","updated_at":"2019-05-27T08:55:32Z","pushed_at":"2019-06-19T14:55:10Z","git_url":"git://github.com/vitvakatu/jni-rs.git","ssh_url":"git@github.com:vitvakatu/jni-rs.git","clone_url":"https://github.com/vitvakatu/jni-rs.git","svn_url":"https://github.com/vitvakatu/jni-rs","homepage":null,"size":459,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jni-rs:auto-detach-threads","ref":"auto-detach-threads","sha":"93ca45d630ce50845c193a4d5e37ac8ff70aadef","user":{"login":"jni-rs","id":42682431,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjgyNDMx","avatar_url":"https://avatars1.githubusercontent.com/u/42682431?v=4","gravatar_id":"","url":"https://api.github.com/users/jni-rs","html_url":"https://github.com/jni-rs","followers_url":"https://api.github.com/users/jni-rs/followers","following_url":"https://api.github.com/users/jni-rs/following{/other_user}","gists_url":"https://api.github.com/users/jni-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/jni-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jni-rs/subscriptions","organizations_url":"https://api.github.com/users/jni-rs/orgs","repos_url":"https://api.github.com/users/jni-rs/repos","events_url":"https://api.github.com/users/jni-rs/events{/privacy}","received_events_url":"https://api.github.com/users/jni-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":72892565,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg5MjU2NQ==","name":"jni-rs","full_name":"jni-rs/jni-rs","private":false,"owner":{"login":"jni-rs","id":42682431,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjgyNDMx","avatar_url":"https://avatars1.githubusercontent.com/u/42682431?v=4","gravatar_id":"","url":"https://api.github.com/users/jni-rs","html_url":"https://github.com/jni-rs","followers_url":"https://api.github.com/users/jni-rs/followers","following_url":"https://api.github.com/users/jni-rs/following{/other_user}","gists_url":"https://api.github.com/users/jni-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/jni-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jni-rs/subscriptions","organizations_url":"https://api.github.com/users/jni-rs/orgs","repos_url":"https://api.github.com/users/jni-rs/repos","events_url":"https://api.github.com/users/jni-rs/events{/privacy}","received_events_url":"https://api.github.com/users/jni-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jni-rs/jni-rs","description":"Rust bindings to the JNI","fork":false,"url":"https://api.github.com/repos/jni-rs/jni-rs","forks_url":"https://api.github.com/repos/jni-rs/jni-rs/forks","keys_url":"https://api.github.com/repos/jni-rs/jni-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jni-rs/jni-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jni-rs/jni-rs/teams","hooks_url":"https://api.github.com/repos/jni-rs/jni-rs/hooks","issue_events_url":"https://api.github.com/repos/jni-rs/jni-rs/issues/events{/number}","events_url":"https://api.github.com/repos/jni-rs/jni-rs/events","assignees_url":"https://api.github.com/repos/jni-rs/jni-rs/assignees{/user}","branches_url":"https://api.github.com/repos/jni-rs/jni-rs/branches{/branch}","tags_url":"https://api.github.com/repos/jni-rs/jni-rs/tags","blobs_url":"https://api.github.com/repos/jni-rs/jni-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jni-rs/jni-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jni-rs/jni-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jni-rs/jni-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jni-rs/jni-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/jni-rs/jni-rs/languages","stargazers_url":"https://api.github.com/repos/jni-rs/jni-rs/stargazers","contributors_url":"https://api.github.com/repos/jni-rs/jni-rs/contributors","subscribers_url":"https://api.github.com/repos/jni-rs/jni-rs/subscribers","subscription_url":"https://api.github.com/repos/jni-rs/jni-rs/subscription","commits_url":"https://api.github.com/repos/jni-rs/jni-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jni-rs/jni-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jni-rs/jni-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jni-rs/jni-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jni-rs/jni-rs/contents/{+path}","compare_url":"https://api.github.com/repos/jni-rs/jni-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jni-rs/jni-rs/merges","archive_url":"https://api.github.com/repos/jni-rs/jni-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jni-rs/jni-rs/downloads","issues_url":"https://api.github.com/repos/jni-rs/jni-rs/issues{/number}","pulls_url":"https://api.github.com/repos/jni-rs/jni-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/jni-rs/jni-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/jni-rs/jni-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jni-rs/jni-rs/labels{/name}","releases_url":"https://api.github.com/repos/jni-rs/jni-rs/releases{/id}","deployments_url":"https://api.github.com/repos/jni-rs/jni-rs/deployments","created_at":"2016-11-04T23:22:21Z","updated_at":"2019-06-20T18:01:18Z","pushed_at":"2019-06-20T14:42:35Z","git_url":"git://github.com/jni-rs/jni-rs.git","ssh_url":"git@github.com:jni-rs/jni-rs.git","clone_url":"https://github.com/jni-rs/jni-rs.git","svn_url":"https://github.com/jni-rs/jni-rs","homepage":null,"size":425,"stargazers_count":169,"watchers_count":169,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":49,"open_issues":36,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186"},"html":{"href":"https://github.com/jni-rs/jni-rs/pull/186"},"issue":{"href":"https://api.github.com/repos/jni-rs/jni-rs/issues/186"},"comments":{"href":"https://api.github.com/repos/jni-rs/jni-rs/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/jni-rs/jni-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jni-rs/jni-rs/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/jni-rs/jni-rs/statuses/c3e8125cb293670a8b6b68dd21bb8a6826756054"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmitry-timofeev"}}