{"action":"created","issue":{"url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/issues/144","repository_url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model","labels_url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/issues/144/comments","events_url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/issues/144/events","html_url":"https://github.com/MPAS-Dev/MPAS-Model/pull/144","id":406769067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMzkxMDEy","number":144,"title":"Update ISOMIP+ test case and add new parameter studies","user":{"login":"xylar","id":4179064,"node_id":"MDQ6VXNlcjQxNzkwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"labels":[{"id":949661127,"node_id":"MDU6TGFiZWw5NDk2NjExMjc=","url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/labels/Compass","name":"Compass","color":"6dadc6","default":false},{"id":46899427,"node_id":"MDU6TGFiZWw0Njg5OTQyNw==","url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/labels/Ocean","name":"Ocean","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"xylar","id":4179064,"node_id":"MDQ6VXNlcjQxNzkwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false},"assignees":[{"login":"xylar","id":4179064,"node_id":"MDQ6VXNlcjQxNzkwNjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4179064?v=4","gravatar_id":"","url":"https://api.github.com/users/xylar","html_url":"https://github.com/xylar","followers_url":"https://api.github.com/users/xylar/followers","following_url":"https://api.github.com/users/xylar/following{/other_user}","gists_url":"https://api.github.com/users/xylar/gists{/gist_id}","starred_url":"https://api.github.com/users/xylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xylar/subscriptions","organizations_url":"https://api.github.com/users/xylar/orgs","repos_url":"https://api.github.com/users/xylar/repos","events_url":"https://api.github.com/users/xylar/events{/privacy}","received_events_url":"https://api.github.com/users/xylar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2019-02-05T12:53:35Z","updated_at":"2019-02-12T22:06:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/pulls/144","html_url":"https://github.com/MPAS-Dev/MPAS-Model/pull/144","diff_url":"https://github.com/MPAS-Dev/MPAS-Model/pull/144.diff","patch_url":"https://github.com/MPAS-Dev/MPAS-Model/pull/144.patch"},"body":"Variables are now averaged with `timeSeriesStatsMonthlyOutput` to ISOMIP+ test cases.  Evaporation rates are computed based on monthly mean melt rates.  Visualization and output for MISOMIP are computed from this output as well.\r\n\r\nNew default parameter values are used in ISOMIP+ based on redoing the Ocean0 parameter study (varying the heat and salt transfer coefficients and finding the value that gives 30 m/yr mean melt rate for `landIceDraft < -300`).\r\n\r\nScripts have been added for generating 3 different parameter studies that will be used in Gwyther et al., \"The importance of vertical processes and resolution on simulated basal melt of an ice shelf: a multi-model study within the ISOMIP+ framework\", in prep.\r\n"},"comment":{"url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/issues/comments/462955567","html_url":"https://github.com/MPAS-Dev/MPAS-Model/pull/144#issuecomment-462955567","issue_url":"https://api.github.com/repos/MPAS-Dev/MPAS-Model/issues/144","id":462955567,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2Mjk1NTU2Nw==","user":{"login":"mark-petersen","id":4036816,"node_id":"MDQ6VXNlcjQwMzY4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4036816?v=4","gravatar_id":"","url":"https://api.github.com/users/mark-petersen","html_url":"https://github.com/mark-petersen","followers_url":"https://api.github.com/users/mark-petersen/followers","following_url":"https://api.github.com/users/mark-petersen/following{/other_user}","gists_url":"https://api.github.com/users/mark-petersen/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-petersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-petersen/subscriptions","organizations_url":"https://api.github.com/users/mark-petersen/orgs","repos_url":"https://api.github.com/users/mark-petersen/repos","events_url":"https://api.github.com/users/mark-petersen/events{/privacy}","received_events_url":"https://api.github.com/users/mark-petersen/received_events","type":"User","site_admin":false},"created_at":"2019-02-12T22:06:08Z","updated_at":"2019-02-12T22:06:08Z","author_association":"CONTRIBUTOR","body":" I ran the `land_ice_fluxes_test_suite` on the head of ocean/develop and separately on this branch.  Both pass all tests, using gnu on grizzly:<details>  \r\n```\r\n ** Running case ISOMIP 1.01 - Smoke Test\r\n      PASS\r\n ** Running case ISOMIP 2.01 - Smoke Test\r\n      PASS\r\n ** Running case ISOMIP+ Ocean0 - Smoke Test\r\n      PASS\r\n ** Running case ISOMIP+ Ocean1 - Smoke Test\r\n      PASS\r\n ** Running case ISOMIP+ Ocean2 - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - default - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - Haney-number constrained - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - iterative init - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - Haney-number constrained, iterative init - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - Smoke Test with frazil\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - restart test\r\n      PASS\r\n ** Running case QU 240km - Smoke Test\r\n      PASS\r\n ** Running case QU 120km - Smoke Test\r\n      PASS\r\n```\r\n</details>\r\nIf I _compare_ the suite between ocean/develop and this branch, there are 5 that do not match.\r\n<details>  \r\n\r\n```\r\n  ** Running case ISOMIP 1.01 - Smoke Test\r\n      PASS\r\n ** Running case ISOMIP 2.01 - Smoke Test\r\n      PASS\r\n ** Running case ISOMIP+ Ocean0 - Smoke Test\r\n   ** FAIL (See case_outputs/ISOMIP+_Ocean0_-_Smoke_Test for more information)\r\n ** Running case ISOMIP+ Ocean1 - Smoke Test\r\n   ** FAIL (See case_outputs/ISOMIP+_Ocean1_-_Smoke_Test for more information)\r\n ** Running case ISOMIP+ Ocean2 - Smoke Test\r\n   ** FAIL (See case_outputs/ISOMIP+_Ocean2_-_Smoke_Test for more information)\r\n ** Running case sub-ice-shelf 2D - default - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - Haney-number constrained - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - iterative init - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - Haney-number constrained, iterative init - Smoke Test\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - Smoke Test with frazil\r\n      PASS\r\n ** Running case sub-ice-shelf 2D - restart test\r\n      PASS\r\n ** Running case QU 240km - Smoke Test\r\n   ** FAIL (See case_outputs/QU_240km_-_Smoke_Test for more information)\r\n ** Running case QU 120km - Smoke Test\r\n   ** FAIL (See case_outputs/QU_120km_-_Smoke_Test for more information)\r\n```\r\n</details>\r\n@xylar is that what you expect?"}}
{"actor":{"display_login":"mark-petersen"}}