{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/25718","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/25718/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/25718/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/25718/events","html_url":"https://github.com/magento/magento2/pull/25718","id":527680830,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0ODk0ODQz","number":25718,"title":"add the possibility to add display mode dependant layout handles","user":{"login":"brosenberger","id":2969243,"node_id":"MDQ6VXNlcjI5NjkyNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2969243?v=4","gravatar_id":"","url":"https://api.github.com/users/brosenberger","html_url":"https://github.com/brosenberger","followers_url":"https://api.github.com/users/brosenberger/followers","following_url":"https://api.github.com/users/brosenberger/following{/other_user}","gists_url":"https://api.github.com/users/brosenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/brosenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brosenberger/subscriptions","organizations_url":"https://api.github.com/users/brosenberger/orgs","repos_url":"https://api.github.com/users/brosenberger/repos","events_url":"https://api.github.com/users/brosenberger/events{/privacy}","received_events_url":"https://api.github.com/users/brosenberger/received_events","type":"User","site_admin":false},"labels":[{"id":1404851252,"node_id":"MDU6TGFiZWwxNDA0ODUxMjUy","url":"https://api.github.com/repos/magento/magento2/labels/Auto-Tests:%20Covered","name":"Auto-Tests: Covered","color":"6dd337","default":false,"description":"All changes in Pull Request is covered by auto-tests"},{"id":374038437,"node_id":"MDU6TGFiZWwzNzQwMzg0Mzc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Catalog","name":"Component: Catalog","color":"7fb703","default":false,"description":null},{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20needs%20update","name":"Progress: needs update","color":"b60205","default":false,"description":null},{"id":1304821044,"node_id":"MDU6TGFiZWwxMzA0ODIxMDQ0","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.4","name":"Release Line: 2.4","color":"fbca04","default":false,"description":""}],"state":"open","locked":false,"assignee":{"login":"aleron75","id":1199894,"node_id":"MDQ6VXNlcjExOTk4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199894?v=4","gravatar_id":"","url":"https://api.github.com/users/aleron75","html_url":"https://github.com/aleron75","followers_url":"https://api.github.com/users/aleron75/followers","following_url":"https://api.github.com/users/aleron75/following{/other_user}","gists_url":"https://api.github.com/users/aleron75/gists{/gist_id}","starred_url":"https://api.github.com/users/aleron75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleron75/subscriptions","organizations_url":"https://api.github.com/users/aleron75/orgs","repos_url":"https://api.github.com/users/aleron75/repos","events_url":"https://api.github.com/users/aleron75/events{/privacy}","received_events_url":"https://api.github.com/users/aleron75/received_events","type":"User","site_admin":false},"assignees":[{"login":"aleron75","id":1199894,"node_id":"MDQ6VXNlcjExOTk4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199894?v=4","gravatar_id":"","url":"https://api.github.com/users/aleron75","html_url":"https://github.com/aleron75","followers_url":"https://api.github.com/users/aleron75/followers","following_url":"https://api.github.com/users/aleron75/following{/other_user}","gists_url":"https://api.github.com/users/aleron75/gists{/gist_id}","starred_url":"https://api.github.com/users/aleron75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleron75/subscriptions","organizations_url":"https://api.github.com/users/aleron75/orgs","repos_url":"https://api.github.com/users/aleron75/repos","events_url":"https://api.github.com/users/aleron75/events{/privacy}","received_events_url":"https://api.github.com/users/aleron75/received_events","type":"User","site_admin":false},{"login":"engcom-Alfa","id":51679138,"node_id":"MDQ6VXNlcjUxNjc5MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/51679138?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-Alfa","html_url":"https://github.com/engcom-Alfa","followers_url":"https://api.github.com/users/engcom-Alfa/followers","following_url":"https://api.github.com/users/engcom-Alfa/following{/other_user}","gists_url":"https://api.github.com/users/engcom-Alfa/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-Alfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-Alfa/subscriptions","organizations_url":"https://api.github.com/users/engcom-Alfa/orgs","repos_url":"https://api.github.com/users/engcom-Alfa/repos","events_url":"https://api.github.com/users/engcom-Alfa/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-Alfa/received_events","type":"User","site_admin":false},{"login":"engcom-Golf","id":51681547,"node_id":"MDQ6VXNlcjUxNjgxNTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/51681547?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-Golf","html_url":"https://github.com/engcom-Golf","followers_url":"https://api.github.com/users/engcom-Golf/followers","following_url":"https://api.github.com/users/engcom-Golf/following{/other_user}","gists_url":"https://api.github.com/users/engcom-Golf/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-Golf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-Golf/subscriptions","organizations_url":"https://api.github.com/users/engcom-Golf/orgs","repos_url":"https://api.github.com/users/engcom-Golf/repos","events_url":"https://api.github.com/users/engcom-Golf/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-Golf/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2019-11-24T10:53:49Z","updated_at":"2020-01-06T12:11:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/25718","html_url":"https://github.com/magento/magento2/pull/25718","diff_url":"https://github.com/magento/magento2/pull/25718.diff","patch_url":"https://github.com/magento/magento2/pull/25718.patch"},"body":"\r\n### Description (*)\r\nlayout updates for categories can only be automatically added by default handle, pagetype (anchor, with children,...), with id and custom settings stored within the category.\r\nAnother option would be to set the display mode within the backend (static block, static block + products or products only) which is not considered for layout handles from the controller. this commit adds the possibility to add displaymode dependant layout handles:\r\n\r\n* catalog_category_view_displaymode_page.xml (Static block only)\r\n* catalog_category_view_displaymode_products.xml (Products only)\r\n* catalog_category_view_displaymode_product_and_page.xml (Static block and products)\r\n\r\n### Manual testing scenarios (*)\r\n\r\n1. add a display mode specific layout xml\r\n2. set a catgory to that specific display mode\r\n3. clear caches\r\n4. go to the changed category and test if the newly added blocks/container/... from the specific layout xml are applied\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/571116562","html_url":"https://github.com/magento/magento2/pull/25718#issuecomment-571116562","issue_url":"https://api.github.com/repos/magento/magento2/issues/25718","id":571116562,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MTExNjU2Mg==","user":{"login":"engcom-Golf","id":51681547,"node_id":"MDQ6VXNlcjUxNjgxNTQ3","avatar_url":"https://avatars0.githubusercontent.com/u/51681547?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-Golf","html_url":"https://github.com/engcom-Golf","followers_url":"https://api.github.com/users/engcom-Golf/followers","following_url":"https://api.github.com/users/engcom-Golf/following{/other_user}","gists_url":"https://api.github.com/users/engcom-Golf/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-Golf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-Golf/subscriptions","organizations_url":"https://api.github.com/users/engcom-Golf/orgs","repos_url":"https://api.github.com/users/engcom-Golf/repos","events_url":"https://api.github.com/users/engcom-Golf/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-Golf/received_events","type":"User","site_admin":false},"created_at":"2020-01-06T12:11:52Z","updated_at":"2020-01-06T12:11:52Z","author_association":"CONTRIBUTOR","body":"HI @aleron75 all changes covered by unit test, could you please review ?"}}
{"actor":{"display_login":"engcom-Golf"}}