{"action":"created","issue":{"url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/323","repository_url":"https://api.github.com/repos/ericmjl/pyjanitor","labels_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/323/labels{/name}","comments_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/323/comments","events_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/323/events","html_url":"https://github.com/ericmjl/pyjanitor/pull/323","id":442923615,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3OTMzMzg2","number":323,"title":"[DOC] Update naming conventions in functions and issue template","user":{"login":"HectorM14","id":23343812,"node_id":"MDQ6VXNlcjIzMzQzODEy","avatar_url":"https://avatars0.githubusercontent.com/u/23343812?v=4","gravatar_id":"","url":"https://api.github.com/users/HectorM14","html_url":"https://github.com/HectorM14","followers_url":"https://api.github.com/users/HectorM14/followers","following_url":"https://api.github.com/users/HectorM14/following{/other_user}","gists_url":"https://api.github.com/users/HectorM14/gists{/gist_id}","starred_url":"https://api.github.com/users/HectorM14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HectorM14/subscriptions","organizations_url":"https://api.github.com/users/HectorM14/orgs","repos_url":"https://api.github.com/users/HectorM14/repos","events_url":"https://api.github.com/users/HectorM14/events{/privacy}","received_events_url":"https://api.github.com/users/HectorM14/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-05-10T23:09:46Z","updated_at":"2019-05-11T11:54:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/323","html_url":"https://github.com/ericmjl/pyjanitor/pull/323","diff_url":"https://github.com/ericmjl/pyjanitor/pull/323.diff","patch_url":"https://github.com/ericmjl/pyjanitor/pull/323.patch"},"body":"# PR Description\r\n\r\nPlease describe the changes proposed in the pull request: \r\n\r\n- Update naming conventions in `round_to_fraction()` and `transform_columns()`\r\n- Update naming conventions in `currency_column_to_numeric()` and `select_columns()`\r\n\r\n<!-- Doing so provides maintainers with context on what the PR is, and can help us more effectively review your PR. -->\r\n\r\n<!-- Please also identify below which issue that has been raised that you are going to close. -->\r\n\r\n**This PR resolves #59 .**\r\n\r\n<!-- As you go down the PR template, please feel free to delete sections that are irrelevant. -->\r\n\r\n# PR Checklist\r\n\r\n<!-- This checklist exists for newcomers who are not yet familiar with our requirements. If you are experienced with\r\nthe project, please feel free to delete this section. -->\r\n\r\nPlease ensure that you have done the following:\r\n\r\n1. [X] PR in from a fork off your branch. Do not PR from `<your_username>`:master, but rather from `<your_username>`:<branch_name>.\r\n<!-- Doing this helps us keep the commit history much cleaner than it would otherwise be. -->\r\n2. [X] If you're not on the contributors list, add yourself to `AUTHORS.rst`.\r\n<!-- We'd like to acknowledge your contributions! -->\r\n\r\n## Quick Check\r\n\r\nTo do a very quick check that everything is correct, follow these steps below:\r\n\r\n- [ ] Run the command `make check` from pyjanitor's top-level directory. This will automatically run:\r\n    - [X] black formatting\r\n    - [X] pycodestyle checking\r\n    - [X] running the test suite\r\n    - docs build\r\n    \r\nOnce done, please check off the check-box above.\r\n    \r\nIf `make check` does not work for you, you can execute the commands listed in the Makefile individually.\r\n\r\n## Code Changes\r\n\r\n<!-- If you have not made code changes, please feel free to delete this section. -->\r\n\r\nIf you are adding code changes, please ensure the following:\r\n\r\n- [ ] Ensure that you have added tests.\r\n- [X] Run all tests (`$ pytest .`) locally on your machine.\r\n    - [ ] Check to ensure that test coverage covers the lines of code that you have added.\r\n    - [ ] Ensure that all tests pass.\r\n\r\n# Relevant Reviewers\r\n\r\n<!-- Finally, please tag relevant maintainers to review. -->\r\n\r\nPlease tag maintainers to review.\r\n\r\n- @ericmjl\r\n"},"comment":{"url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/comments/491504567","html_url":"https://github.com/ericmjl/pyjanitor/pull/323#issuecomment-491504567","issue_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/323","id":491504567,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MTUwNDU2Nw==","user":{"login":"ericmjl","id":2631566,"node_id":"MDQ6VXNlcjI2MzE1NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2631566?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmjl","html_url":"https://github.com/ericmjl","followers_url":"https://api.github.com/users/ericmjl/followers","following_url":"https://api.github.com/users/ericmjl/following{/other_user}","gists_url":"https://api.github.com/users/ericmjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmjl/subscriptions","organizations_url":"https://api.github.com/users/ericmjl/orgs","repos_url":"https://api.github.com/users/ericmjl/repos","events_url":"https://api.github.com/users/ericmjl/events{/privacy}","received_events_url":"https://api.github.com/users/ericmjl/received_events","type":"User","site_admin":false},"created_at":"2019-05-11T11:54:08Z","updated_at":"2019-05-11T11:54:08Z","author_association":"OWNER","body":"I think it was an internet connection issue. Restarting the build should have done the trick. "}}
{"actor":{"display_login":"ericmjl"}}