{"action":"created","issue":{"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/731","repository_url":"https://api.github.com/repos/valor-software/ngx-bootstrap","labels_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/731/comments","events_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/731/events","html_url":"https://github.com/valor-software/ngx-bootstrap/issues/731","id":165505086,"node_id":"MDU6SXNzdWUxNjU1MDUwODY=","number":731,"title":"feat(modals): add an options to append modals to element","user":{"login":"zl810881283","id":8832481,"node_id":"MDQ6VXNlcjg4MzI0ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/8832481?v=4","gravatar_id":"","url":"https://api.github.com/users/zl810881283","html_url":"https://github.com/zl810881283","followers_url":"https://api.github.com/users/zl810881283/followers","following_url":"https://api.github.com/users/zl810881283/following{/other_user}","gists_url":"https://api.github.com/users/zl810881283/gists{/gist_id}","starred_url":"https://api.github.com/users/zl810881283/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zl810881283/subscriptions","organizations_url":"https://api.github.com/users/zl810881283/orgs","repos_url":"https://api.github.com/users/zl810881283/repos","events_url":"https://api.github.com/users/zl810881283/events{/privacy}","received_events_url":"https://api.github.com/users/zl810881283/received_events","type":"User","site_admin":false},"labels":[{"id":805190896,"node_id":"MDU6TGFiZWw4MDUxOTA4OTY=","url":"https://api.github.com/repos/valor-software/ngx-bootstrap/labels/added%20to%20aggregation%20issue","name":"added to aggregation issue","color":"f9d0c4","default":false},{"id":411822414,"node_id":"MDU6TGFiZWw0MTE4MjI0MTQ=","url":"https://api.github.com/repos/valor-software/ngx-bootstrap/labels/comp(modal)","name":"comp(modal)","color":"0e8a16","default":false},{"id":254605143,"node_id":"MDU6TGFiZWwyNTQ2MDUxNDM=","url":"https://api.github.com/repos/valor-software/ngx-bootstrap/labels/effort2:%20medium%20(days)","name":"effort2: medium (days)","color":"bfe5bf","default":false},{"id":245589271,"node_id":"MDU6TGFiZWwyNDU1ODkyNzE=","url":"https://api.github.com/repos/valor-software/ngx-bootstrap/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-14T08:24:16Z","updated_at":"2019-03-14T18:38:22Z","closed_at":null,"author_association":"NONE","body":"I follow the [modal](http://valor-software.com/ng2-bootstrap/#/modals) doc, and find that I should do a  small hack in the root component, which is need in my project. I wonder whether I can set modals to child component. what should I do?\n\n``` javascript\nimport {Component, ViewContainerRef} from '@angular/core';\n\n@Component({selector:'app-root'})\nclass AppRoot {\n  public constructor(viewContainerRef:ViewContainerRef) {\n    // You need this small hack in order to catch application root view container ref\n    this.viewContainerRef = viewContainerRef;\n  }\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/comments/473005868","html_url":"https://github.com/valor-software/ngx-bootstrap/issues/731#issuecomment-473005868","issue_url":"https://api.github.com/repos/valor-software/ngx-bootstrap/issues/731","id":473005868,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MzAwNTg2OA==","user":{"login":"cannontechnology","id":3844488,"node_id":"MDQ6VXNlcjM4NDQ0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/3844488?v=4","gravatar_id":"","url":"https://api.github.com/users/cannontechnology","html_url":"https://github.com/cannontechnology","followers_url":"https://api.github.com/users/cannontechnology/followers","following_url":"https://api.github.com/users/cannontechnology/following{/other_user}","gists_url":"https://api.github.com/users/cannontechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/cannontechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cannontechnology/subscriptions","organizations_url":"https://api.github.com/users/cannontechnology/orgs","repos_url":"https://api.github.com/users/cannontechnology/repos","events_url":"https://api.github.com/users/cannontechnology/events{/privacy}","received_events_url":"https://api.github.com/users/cannontechnology/received_events","type":"User","site_admin":false},"created_at":"2019-03-14T18:38:22Z","updated_at":"2019-03-14T18:38:22Z","author_association":"NONE","body":"I think ticket [2609](https://github.com/valor-software/ngx-bootstrap/issues/2609) was more appropriate for the following issue but it was closed and pointed to this one.\r\n\r\nMy application needs to be VPAT complaint and one of the accessibility rules is that \"All page content must be contained by landmarks\".  see https://dequeuniversity.com/rules/axe/3.1/region?application=AxeChrome \r\n\r\nCurrently the popover component can only be attached to the body via container=\"body\".  Could that be extended to append to any DOM element?  If so, I could attach to a landmark instead and meet the requirement."}}
{"actor":{"display_login":"cannontechnology"}}