{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/274069114","pull_request_review_id":225106481,"id":274069114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDA2OTExNA==","diff_hunk":"@@ -25792,10 +25792,10 @@ static void script_parse_builtin(void)\n \n \t\tBUILDIN_DEF(itempreview, \"i\"),\n \t\tBUILDIN_DEF(enchantitem, \"iii\"),\n-\t\tBUILDIN_DEF(expandInventoryAck, \"i?\"),","path":"src/map/script.c","position":40,"original_position":40,"commit_id":"9120ed9566c19b91e3c4205653fd3c6a7ca56fbb","original_commit_id":"9120ed9566c19b91e3c4205653fd3c6a7ca56fbb","user":{"login":"AnnieRuru","id":6211477,"node_id":"MDQ6VXNlcjYyMTE0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"body":"nonono, please test this PR, this doesn't need to deprecate\r\nthere is already the wrong case detection in the script engine to throw that error already\r\n\r\nalso, when I tested the `BUILDIN_DEF2_DEPRECATED` like you said, when I did it before\r\nthe small letter case got deprecated as well for some reason ...\r\n\r\ntry it yourself","created_at":"2019-04-10T17:14:41Z","updated_at":"2019-04-10T17:14:42Z","html_url":"https://github.com/HerculesWS/Hercules/pull/2374#discussion_r274069114","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/274069114"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2374#discussion_r274069114"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374"}},"in_reply_to_id":257249767},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374","id":253374645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMzc0NjQ1","html_url":"https://github.com/HerculesWS/Hercules/pull/2374","diff_url":"https://github.com/HerculesWS/Hercules/pull/2374.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2374.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2374","number":2374,"state":"open","locked":false,"title":"standardize script commands to small letters","user":{"login":"AnnieRuru","id":6211477,"node_id":"MDQ6VXNlcjYyMTE0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"body":"[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n### Pull Request Prelude\r\n- [x] I have followed [proper Hercules code styling][code].\r\n- [x] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [x] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Issues addressed\r\nhttp://herc.ws/board/topic/16526-some-upcoming-hercules-features/?do=findComment&comment=90516\r\n\r\n### Changes Proposed\r\nAll script commands should be in small letters\r\n\r\n### Affected Branches\r\n* Master\r\n\r\n### Known Issues and TODO List\r\nI don't want to memorize another special capital letter case\r\n\"All\" and \"all\" is already enough for us -> https://github.com/HerculesWS/Hercules/issues/784\r\n--> standardize into \"all\" for script commands -> https://github.com/HerculesWS/Hercules/pull/2380\r\n\r\n~so if Haru say again this isn't an issue, feel free to close this PR~\r\nfor standardization, script commands has to be small letters","created_at":"2019-02-15T10:15:18Z","updated_at":"2019-04-10T17:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4185ee952a492c9a435b233194518da483e7c1a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":287787453,"node_id":"MDU6TGFiZWwyODc3ODc0NTM=","url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:core:scriptengine","name":"component:core:scriptengine","color":"803050","default":false},{"id":288045871,"node_id":"MDU6TGFiZWwyODgwNDU4NzE=","url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:documentation","name":"component:documentation","color":"5319e7","default":false},{"id":48712212,"node_id":"MDU6TGFiZWw0ODcxMjIxMg==","url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:scripts","name":"component:scripts","color":"d06000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2374/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/9120ed9566c19b91e3c4205653fd3c6a7ca56fbb","head":{"label":"AnnieRuru:57-getInventorySize","ref":"57-getInventorySize","sha":"9120ed9566c19b91e3c4205653fd3c6a7ca56fbb","user":{"login":"AnnieRuru","id":6211477,"node_id":"MDQ6VXNlcjYyMTE0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"repo":{"id":17571108,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU3MTEwOA==","name":"Hercules","full_name":"AnnieRuru/Hercules","private":false,"owner":{"login":"AnnieRuru","id":6211477,"node_id":"MDQ6VXNlcjYyMTE0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6211477?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnieRuru","html_url":"https://github.com/AnnieRuru","followers_url":"https://api.github.com/users/AnnieRuru/followers","following_url":"https://api.github.com/users/AnnieRuru/following{/other_user}","gists_url":"https://api.github.com/users/AnnieRuru/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnieRuru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnieRuru/subscriptions","organizations_url":"https://api.github.com/users/AnnieRuru/orgs","repos_url":"https://api.github.com/users/AnnieRuru/repos","events_url":"https://api.github.com/users/AnnieRuru/events{/privacy}","received_events_url":"https://api.github.com/users/AnnieRuru/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AnnieRuru/Hercules","description":null,"fork":true,"url":"https://api.github.com/repos/AnnieRuru/Hercules","forks_url":"https://api.github.com/repos/AnnieRuru/Hercules/forks","keys_url":"https://api.github.com/repos/AnnieRuru/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnnieRuru/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnnieRuru/Hercules/teams","hooks_url":"https://api.github.com/repos/AnnieRuru/Hercules/hooks","issue_events_url":"https://api.github.com/repos/AnnieRuru/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/AnnieRuru/Hercules/events","assignees_url":"https://api.github.com/repos/AnnieRuru/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/AnnieRuru/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/AnnieRuru/Hercules/tags","blobs_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnnieRuru/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/AnnieRuru/Hercules/languages","stargazers_url":"https://api.github.com/repos/AnnieRuru/Hercules/stargazers","contributors_url":"https://api.github.com/repos/AnnieRuru/Hercules/contributors","subscribers_url":"https://api.github.com/repos/AnnieRuru/Hercules/subscribers","subscription_url":"https://api.github.com/repos/AnnieRuru/Hercules/subscription","commits_url":"https://api.github.com/repos/AnnieRuru/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnnieRuru/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnnieRuru/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnnieRuru/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnnieRuru/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/AnnieRuru/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnnieRuru/Hercules/merges","archive_url":"https://api.github.com/repos/AnnieRuru/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnnieRuru/Hercules/downloads","issues_url":"https://api.github.com/repos/AnnieRuru/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/AnnieRuru/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/AnnieRuru/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/AnnieRuru/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnnieRuru/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/AnnieRuru/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/AnnieRuru/Hercules/deployments","created_at":"2014-03-09T18:52:55Z","updated_at":"2019-03-19T19:04:27Z","pushed_at":"2019-04-10T16:50:45Z","git_url":"git://github.com/AnnieRuru/Hercules.git","ssh_url":"git@github.com:AnnieRuru/Hercules.git","clone_url":"https://github.com/AnnieRuru/Hercules.git","svn_url":"https://github.com/AnnieRuru/Hercules","homepage":"http://hercules.ws","size":179036,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"HerculesWS:master","ref":"master","sha":"423214508f80cb007fd07ca2a0cc729fd473336f","user":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"node_id":"MDEwOlJlcG9zaXRvcnk3NTUxNDI5","name":"Hercules","full_name":"HerculesWS/Hercules","private":false,"owner":{"login":"HerculesWS","id":3220669,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjA2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2019-04-10T13:13:32Z","pushed_at":"2019-04-10T16:50:59Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":204807,"stargazers_count":516,"watchers_count":516,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":604,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":476,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":604,"open_issues":476,"watchers":516,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2374"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2374"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2374/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2374/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/9120ed9566c19b91e3c4205653fd3c6a7ca56fbb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AnnieRuru"}}