{"action":"opened","number":4735,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4735","id":273805311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczODA1MzEx","html_url":"https://github.com/ReactiveX/rxjs/pull/4735","diff_url":"https://github.com/ReactiveX/rxjs/pull/4735.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/4735.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/4735","number":4735,"state":"open","locked":false,"title":"fix(endWith): wrap args - they are not observables - in of before concatenating","user":{"login":"cartant","id":3878593,"node_id":"MDQ6VXNlcjM4Nzg1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3878593?v=4","gravatar_id":"","url":"https://api.github.com/users/cartant","html_url":"https://github.com/cartant","followers_url":"https://api.github.com/users/cartant/followers","following_url":"https://api.github.com/users/cartant/following{/other_user}","gists_url":"https://api.github.com/users/cartant/gists{/gist_id}","starred_url":"https://api.github.com/users/cartant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartant/subscriptions","organizations_url":"https://api.github.com/users/cartant/orgs","repos_url":"https://api.github.com/users/cartant/repos","events_url":"https://api.github.com/users/cartant/events{/privacy}","received_events_url":"https://api.github.com/users/cartant/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to Rx\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] The operator should also be documented. See [Documentation Guidelines](../CONTRIBUTING.md).\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\n\r\nThis PR spreads the arguments passed to `endWith` into a call to `of` which is then passed to `concat.\r\n\r\nThe current implementation spreads the args directly into `concat` which is incorrect. The tests pass because strings are iterable and are therefore valid observable inputs. And the strings in the tests each contain only a single character. The test added in this PR uses numbers for values, and their use effects an error from the current, incorrect `endWith` implementation.\r\n\r\n**Related issue (if exists):** #4731","created_at":"2019-04-26T08:22:40Z","updated_at":"2019-04-26T08:22:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"benlesh","id":1540597,"node_id":"MDQ6VXNlcjE1NDA1OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1540597?v=4","gravatar_id":"","url":"https://api.github.com/users/benlesh","html_url":"https://github.com/benlesh","followers_url":"https://api.github.com/users/benlesh/followers","following_url":"https://api.github.com/users/benlesh/following{/other_user}","gists_url":"https://api.github.com/users/benlesh/gists{/gist_id}","starred_url":"https://api.github.com/users/benlesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlesh/subscriptions","organizations_url":"https://api.github.com/users/benlesh/orgs","repos_url":"https://api.github.com/users/benlesh/repos","events_url":"https://api.github.com/users/benlesh/events{/privacy}","received_events_url":"https://api.github.com/users/benlesh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4735/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4735/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/4735/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/a831e7ae7518dfa21e45435c3a0f715d035dabf5","head":{"label":"cartant:issue-4731","ref":"issue-4731","sha":"a831e7ae7518dfa21e45435c3a0f715d035dabf5","user":{"login":"cartant","id":3878593,"node_id":"MDQ6VXNlcjM4Nzg1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3878593?v=4","gravatar_id":"","url":"https://api.github.com/users/cartant","html_url":"https://github.com/cartant","followers_url":"https://api.github.com/users/cartant/followers","following_url":"https://api.github.com/users/cartant/following{/other_user}","gists_url":"https://api.github.com/users/cartant/gists{/gist_id}","starred_url":"https://api.github.com/users/cartant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartant/subscriptions","organizations_url":"https://api.github.com/users/cartant/orgs","repos_url":"https://api.github.com/users/cartant/repos","events_url":"https://api.github.com/users/cartant/events{/privacy}","received_events_url":"https://api.github.com/users/cartant/received_events","type":"User","site_admin":false},"repo":{"id":68100454,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEwMDQ1NA==","name":"rxjs","full_name":"cartant/rxjs","private":false,"owner":{"login":"cartant","id":3878593,"node_id":"MDQ6VXNlcjM4Nzg1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3878593?v=4","gravatar_id":"","url":"https://api.github.com/users/cartant","html_url":"https://github.com/cartant","followers_url":"https://api.github.com/users/cartant/followers","following_url":"https://api.github.com/users/cartant/following{/other_user}","gists_url":"https://api.github.com/users/cartant/gists{/gist_id}","starred_url":"https://api.github.com/users/cartant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartant/subscriptions","organizations_url":"https://api.github.com/users/cartant/orgs","repos_url":"https://api.github.com/users/cartant/repos","events_url":"https://api.github.com/users/cartant/events{/privacy}","received_events_url":"https://api.github.com/users/cartant/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cartant/rxjs","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/cartant/rxjs","forks_url":"https://api.github.com/repos/cartant/rxjs/forks","keys_url":"https://api.github.com/repos/cartant/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cartant/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cartant/rxjs/teams","hooks_url":"https://api.github.com/repos/cartant/rxjs/hooks","issue_events_url":"https://api.github.com/repos/cartant/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/cartant/rxjs/events","assignees_url":"https://api.github.com/repos/cartant/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/cartant/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/cartant/rxjs/tags","blobs_url":"https://api.github.com/repos/cartant/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cartant/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cartant/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cartant/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cartant/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cartant/rxjs/languages","stargazers_url":"https://api.github.com/repos/cartant/rxjs/stargazers","contributors_url":"https://api.github.com/repos/cartant/rxjs/contributors","subscribers_url":"https://api.github.com/repos/cartant/rxjs/subscribers","subscription_url":"https://api.github.com/repos/cartant/rxjs/subscription","commits_url":"https://api.github.com/repos/cartant/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cartant/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cartant/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cartant/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cartant/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/cartant/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cartant/rxjs/merges","archive_url":"https://api.github.com/repos/cartant/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cartant/rxjs/downloads","issues_url":"https://api.github.com/repos/cartant/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/cartant/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cartant/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cartant/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cartant/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/cartant/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/cartant/rxjs/deployments","created_at":"2016-09-13T10:57:45Z","updated_at":"2019-04-26T08:06:42Z","pushed_at":"2019-04-26T08:17:14Z","git_url":"git://github.com/cartant/rxjs.git","ssh_url":"git@github.com:cartant/rxjs.git","clone_url":"https://github.com/cartant/rxjs.git","svn_url":"https://github.com/cartant/rxjs","homepage":"http://reactivex.io/rxjs","size":72385,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"cd5895d0e44008714ccd702af959ae40c8262f16","user":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"node_id":"MDEwOlJlcG9zaXRvcnkzMjI0Nzg0Nw==","name":"rxjs","full_name":"ReactiveX/rxjs","private":false,"owner":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2019-04-26T08:01:41Z","pushed_at":"2019-04-26T08:01:34Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"https://rxjs.dev","size":108503,"stargazers_count":18133,"watchers_count":18133,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1856,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":291,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1856,"open_issues":291,"watchers":18133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4735"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/4735"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/4735"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/4735/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4735/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4735/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/a831e7ae7518dfa21e45435c3a0f715d035dabf5"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":12,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"cartant"}}