{"action":"created","comment":{"url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/comments/363609100","pull_request_review_id":339053240,"id":363609100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzYwOTEwMA==","diff_hunk":"@@ -125,62 +125,60 @@ st.msg(\"This is a message from dds to ros2\");\n ```\n \n #### `HelloWorldSubscriber.cxx`\n-Analogous to the first publisher modification, search the `topicName` line\n+Analogously to the above publisher modification, search the `topicName` line of the subscriber\n ```c++\n-Wparam.topic.topicName = \"Vector2iSub\";\n+Wparam.topic.topicName = \"HelloWorldPubSubTopic\";\n ```\n-and modify with the following topic Name:\n+and modify it with a different topic name, for instance the following:\n ```c++\n Wparam.topic.topicName = \"hello_dds\";\n ```\n \n Once the files have been modified, we need to compile them.\n Simply, write `make` in your build folder.\n \n-If we run now the publisher and subscriber, they will not match among them.\n+If we now run the dds world publisher and subscriber, they will not match between them.\n \n \n ### Deploy\n-For deploy all the system we will need 5 terminals at the same time:\n+To deploy the system we will need 5 terminals at the same time:\n ![](images/terminal_deploy.png)\n \n #### Terminal 1\n-To publish the topic from ros2, only need to write the following commands:\n+To publish the topic from ros2, we only need to write the following commands:\n ```\n-source ~/ros2_eloquent/ros2-linux/setup.bash\n-ros2 topic pub /hello_dds std_msgs/String \"This is a message from ros2 to dds\"\n+source ~/ros2_eloquent/install/setup.bash\n+ros2 topic pub /hello_dds std_msgs/String \"{\\\"This is a message from ros2 to dds\\\"}\"\n ```\n \n #### Terminal 2\n-Similar to publish from ros2, for subscribe we need to write:\n+Similarly to what we did to publish from ros2, for subscribing we need to write:\n ```\n-source ~/ros2_eloquent/ros2-linux/setup.bash\n+source ~/ros2_eloquent/install/setup.bash\n ros2 topic echo /hello_ros std_msgs/String\n ```\n \n #### Terminal 3\n-Placed into the build folder when you have generated the HelloWorld publisher and subscriber.\n-Run the publisher\n+Placed into the build folder where you have generated the HelloWorld publisher and subscriber, run the dds world publisher\n ```\n ./HelloWorld publisher\n ```\n \n #### Terminal 4\n-Similar to terminal 4, but running the subscriber:\n+As in terminal 3, run the dds world subscriber:\n ```\n ./HelloWorld subscriber\n ```\n \n #### Terminal 5\n-Before running soss, any matched is made.\n-Placed into the `soss` workspace.\n-Source both, ros2 and your installation, and run the `soss` executable with the previous yaml.\n+All matchings are made before running soss.","path":"doc/tutorial.md","position":192,"original_position":192,"commit_id":"b538ec074bcb0f031abdf27dd02d5d7019f504b4","original_commit_id":"b538ec074bcb0f031abdf27dd02d5d7019f504b4","user":{"login":"FranFin","id":58737168,"node_id":"MDQ6VXNlcjU4NzM3MTY4","avatar_url":"https://avatars0.githubusercontent.com/u/58737168?v=4","gravatar_id":"","url":"https://api.github.com/users/FranFin","html_url":"https://github.com/FranFin","followers_url":"https://api.github.com/users/FranFin/followers","following_url":"https://api.github.com/users/FranFin/following{/other_user}","gists_url":"https://api.github.com/users/FranFin/gists{/gist_id}","starred_url":"https://api.github.com/users/FranFin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FranFin/subscriptions","organizations_url":"https://api.github.com/users/FranFin/orgs","repos_url":"https://api.github.com/users/FranFin/repos","events_url":"https://api.github.com/users/FranFin/events{/privacy}","received_events_url":"https://api.github.com/users/FranFin/received_events","type":"User","site_admin":false},"body":"Ah ok. So maybe we could change it to: \"No matching is made before running soss.\".","created_at":"2020-01-07T06:38:34Z","updated_at":"2020-01-07T06:38:34Z","html_url":"https://github.com/eProsima/SOSS-DDS/pull/40#discussion_r363609100","pull_request_url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/comments/363609100"},"html":{"href":"https://github.com/eProsima/SOSS-DDS/pull/40#discussion_r363609100"},"pull_request":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40"}},"in_reply_to_id":362782556},"pull_request":{"url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40","id":358941827,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU4OTQxODI3","html_url":"https://github.com/eProsima/SOSS-DDS/pull/40","diff_url":"https://github.com/eProsima/SOSS-DDS/pull/40.diff","patch_url":"https://github.com/eProsima/SOSS-DDS/pull/40.patch","issue_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/40","number":40,"state":"open","locked":false,"title":"Doc/tutorial fix","user":{"login":"FranFin","id":58737168,"node_id":"MDQ6VXNlcjU4NzM3MTY4","avatar_url":"https://avatars0.githubusercontent.com/u/58737168?v=4","gravatar_id":"","url":"https://api.github.com/users/FranFin","html_url":"https://github.com/FranFin","followers_url":"https://api.github.com/users/FranFin/followers","following_url":"https://api.github.com/users/FranFin/following{/other_user}","gists_url":"https://api.github.com/users/FranFin/gists{/gist_id}","starred_url":"https://api.github.com/users/FranFin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FranFin/subscriptions","organizations_url":"https://api.github.com/users/FranFin/orgs","repos_url":"https://api.github.com/users/FranFin/repos","events_url":"https://api.github.com/users/FranFin/events{/privacy}","received_events_url":"https://api.github.com/users/FranFin/received_events","type":"User","site_admin":false},"body":"","created_at":"2020-01-03T10:30:46Z","updated_at":"2020-01-07T06:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2b9072ed812fbe7e7ee55392654096b281388fa","assignee":{"login":"lemunozm","id":15687891,"node_id":"MDQ6VXNlcjE1Njg3ODkx","avatar_url":"https://avatars0.githubusercontent.com/u/15687891?v=4","gravatar_id":"","url":"https://api.github.com/users/lemunozm","html_url":"https://github.com/lemunozm","followers_url":"https://api.github.com/users/lemunozm/followers","following_url":"https://api.github.com/users/lemunozm/following{/other_user}","gists_url":"https://api.github.com/users/lemunozm/gists{/gist_id}","starred_url":"https://api.github.com/users/lemunozm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemunozm/subscriptions","organizations_url":"https://api.github.com/users/lemunozm/orgs","repos_url":"https://api.github.com/users/lemunozm/repos","events_url":"https://api.github.com/users/lemunozm/events{/privacy}","received_events_url":"https://api.github.com/users/lemunozm/received_events","type":"User","site_admin":false},"assignees":[{"login":"lemunozm","id":15687891,"node_id":"MDQ6VXNlcjE1Njg3ODkx","avatar_url":"https://avatars0.githubusercontent.com/u/15687891?v=4","gravatar_id":"","url":"https://api.github.com/users/lemunozm","html_url":"https://github.com/lemunozm","followers_url":"https://api.github.com/users/lemunozm/followers","following_url":"https://api.github.com/users/lemunozm/following{/other_user}","gists_url":"https://api.github.com/users/lemunozm/gists{/gist_id}","starred_url":"https://api.github.com/users/lemunozm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemunozm/subscriptions","organizations_url":"https://api.github.com/users/lemunozm/orgs","repos_url":"https://api.github.com/users/lemunozm/repos","events_url":"https://api.github.com/users/lemunozm/events{/privacy}","received_events_url":"https://api.github.com/users/lemunozm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40/commits","review_comments_url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40/comments","review_comment_url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/40/comments","statuses_url":"https://api.github.com/repos/eProsima/SOSS-DDS/statuses/b538ec074bcb0f031abdf27dd02d5d7019f504b4","head":{"label":"eProsima:doc/tutorial-fix","ref":"doc/tutorial-fix","sha":"b538ec074bcb0f031abdf27dd02d5d7019f504b4","user":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"repo":{"id":191137086,"node_id":"MDEwOlJlcG9zaXRvcnkxOTExMzcwODY=","name":"SOSS-DDS","full_name":"eProsima/SOSS-DDS","private":false,"owner":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eProsima/SOSS-DDS","description":"System handle to connect DDS to SOSS.","fork":false,"url":"https://api.github.com/repos/eProsima/SOSS-DDS","forks_url":"https://api.github.com/repos/eProsima/SOSS-DDS/forks","keys_url":"https://api.github.com/repos/eProsima/SOSS-DDS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eProsima/SOSS-DDS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eProsima/SOSS-DDS/teams","hooks_url":"https://api.github.com/repos/eProsima/SOSS-DDS/hooks","issue_events_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/events{/number}","events_url":"https://api.github.com/repos/eProsima/SOSS-DDS/events","assignees_url":"https://api.github.com/repos/eProsima/SOSS-DDS/assignees{/user}","branches_url":"https://api.github.com/repos/eProsima/SOSS-DDS/branches{/branch}","tags_url":"https://api.github.com/repos/eProsima/SOSS-DDS/tags","blobs_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/refs{/sha}","trees_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eProsima/SOSS-DDS/statuses/{sha}","languages_url":"https://api.github.com/repos/eProsima/SOSS-DDS/languages","stargazers_url":"https://api.github.com/repos/eProsima/SOSS-DDS/stargazers","contributors_url":"https://api.github.com/repos/eProsima/SOSS-DDS/contributors","subscribers_url":"https://api.github.com/repos/eProsima/SOSS-DDS/subscribers","subscription_url":"https://api.github.com/repos/eProsima/SOSS-DDS/subscription","commits_url":"https://api.github.com/repos/eProsima/SOSS-DDS/commits{/sha}","git_commits_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/commits{/sha}","comments_url":"https://api.github.com/repos/eProsima/SOSS-DDS/comments{/number}","issue_comment_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/comments{/number}","contents_url":"https://api.github.com/repos/eProsima/SOSS-DDS/contents/{+path}","compare_url":"https://api.github.com/repos/eProsima/SOSS-DDS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eProsima/SOSS-DDS/merges","archive_url":"https://api.github.com/repos/eProsima/SOSS-DDS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eProsima/SOSS-DDS/downloads","issues_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues{/number}","pulls_url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls{/number}","milestones_url":"https://api.github.com/repos/eProsima/SOSS-DDS/milestones{/number}","notifications_url":"https://api.github.com/repos/eProsima/SOSS-DDS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eProsima/SOSS-DDS/labels{/name}","releases_url":"https://api.github.com/repos/eProsima/SOSS-DDS/releases{/id}","deployments_url":"https://api.github.com/repos/eProsima/SOSS-DDS/deployments","created_at":"2019-06-10T09:25:15Z","updated_at":"2019-10-31T09:32:14Z","pushed_at":"2020-01-03T10:30:47Z","git_url":"git://github.com/eProsima/SOSS-DDS.git","ssh_url":"git@github.com:eProsima/SOSS-DDS.git","clone_url":"https://github.com/eProsima/SOSS-DDS.git","svn_url":"https://github.com/eProsima/SOSS-DDS","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"eProsima:doc/tutorial","ref":"doc/tutorial","sha":"506face06169e1f1a36c1bc69af41068cae85b81","user":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"repo":{"id":191137086,"node_id":"MDEwOlJlcG9zaXRvcnkxOTExMzcwODY=","name":"SOSS-DDS","full_name":"eProsima/SOSS-DDS","private":false,"owner":{"login":"eProsima","id":6390783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTA3ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6390783?v=4","gravatar_id":"","url":"https://api.github.com/users/eProsima","html_url":"https://github.com/eProsima","followers_url":"https://api.github.com/users/eProsima/followers","following_url":"https://api.github.com/users/eProsima/following{/other_user}","gists_url":"https://api.github.com/users/eProsima/gists{/gist_id}","starred_url":"https://api.github.com/users/eProsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eProsima/subscriptions","organizations_url":"https://api.github.com/users/eProsima/orgs","repos_url":"https://api.github.com/users/eProsima/repos","events_url":"https://api.github.com/users/eProsima/events{/privacy}","received_events_url":"https://api.github.com/users/eProsima/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eProsima/SOSS-DDS","description":"System handle to connect DDS to SOSS.","fork":false,"url":"https://api.github.com/repos/eProsima/SOSS-DDS","forks_url":"https://api.github.com/repos/eProsima/SOSS-DDS/forks","keys_url":"https://api.github.com/repos/eProsima/SOSS-DDS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eProsima/SOSS-DDS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eProsima/SOSS-DDS/teams","hooks_url":"https://api.github.com/repos/eProsima/SOSS-DDS/hooks","issue_events_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/events{/number}","events_url":"https://api.github.com/repos/eProsima/SOSS-DDS/events","assignees_url":"https://api.github.com/repos/eProsima/SOSS-DDS/assignees{/user}","branches_url":"https://api.github.com/repos/eProsima/SOSS-DDS/branches{/branch}","tags_url":"https://api.github.com/repos/eProsima/SOSS-DDS/tags","blobs_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/refs{/sha}","trees_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eProsima/SOSS-DDS/statuses/{sha}","languages_url":"https://api.github.com/repos/eProsima/SOSS-DDS/languages","stargazers_url":"https://api.github.com/repos/eProsima/SOSS-DDS/stargazers","contributors_url":"https://api.github.com/repos/eProsima/SOSS-DDS/contributors","subscribers_url":"https://api.github.com/repos/eProsima/SOSS-DDS/subscribers","subscription_url":"https://api.github.com/repos/eProsima/SOSS-DDS/subscription","commits_url":"https://api.github.com/repos/eProsima/SOSS-DDS/commits{/sha}","git_commits_url":"https://api.github.com/repos/eProsima/SOSS-DDS/git/commits{/sha}","comments_url":"https://api.github.com/repos/eProsima/SOSS-DDS/comments{/number}","issue_comment_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/comments{/number}","contents_url":"https://api.github.com/repos/eProsima/SOSS-DDS/contents/{+path}","compare_url":"https://api.github.com/repos/eProsima/SOSS-DDS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eProsima/SOSS-DDS/merges","archive_url":"https://api.github.com/repos/eProsima/SOSS-DDS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eProsima/SOSS-DDS/downloads","issues_url":"https://api.github.com/repos/eProsima/SOSS-DDS/issues{/number}","pulls_url":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls{/number}","milestones_url":"https://api.github.com/repos/eProsima/SOSS-DDS/milestones{/number}","notifications_url":"https://api.github.com/repos/eProsima/SOSS-DDS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eProsima/SOSS-DDS/labels{/name}","releases_url":"https://api.github.com/repos/eProsima/SOSS-DDS/releases{/id}","deployments_url":"https://api.github.com/repos/eProsima/SOSS-DDS/deployments","created_at":"2019-06-10T09:25:15Z","updated_at":"2019-10-31T09:32:14Z","pushed_at":"2020-01-03T10:30:47Z","git_url":"git://github.com/eProsima/SOSS-DDS.git","ssh_url":"git@github.com:eProsima/SOSS-DDS.git","clone_url":"https://github.com/eProsima/SOSS-DDS.git","svn_url":"https://github.com/eProsima/SOSS-DDS","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40"},"html":{"href":"https://github.com/eProsima/SOSS-DDS/pull/40"},"issue":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/40"},"comments":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/eProsima/SOSS-DDS/statuses/b538ec074bcb0f031abdf27dd02d5d7019f504b4"}},"author_association":"NONE"}}
{"actor":{"display_login":"FranFin"}}