{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/27007","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/27007/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/27007/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/27007/events","html_url":"https://github.com/nodejs/node/pull/27007","id":427249259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1OTE4NzQ1","number":27007,"title":"tools: fix `test.py --time`","user":{"login":"richardlau","id":5445507,"node_id":"MDQ6VXNlcjU0NDU1MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/5445507?v=4","gravatar_id":"","url":"https://api.github.com/users/richardlau","html_url":"https://github.com/richardlau","followers_url":"https://api.github.com/users/richardlau/followers","following_url":"https://api.github.com/users/richardlau/following{/other_user}","gists_url":"https://api.github.com/users/richardlau/gists{/gist_id}","starred_url":"https://api.github.com/users/richardlau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardlau/subscriptions","organizations_url":"https://api.github.com/users/richardlau/orgs","repos_url":"https://api.github.com/users/richardlau/repos","events_url":"https://api.github.com/users/richardlau/events{/privacy}","received_events_url":"https://api.github.com/users/richardlau/received_events","type":"User","site_admin":false},"labels":[{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":237979054,"node_id":"MDU6TGFiZWwyMzc5NzkwNTQ=","url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-30T06:21:22Z","updated_at":"2019-03-30T12:47:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/27007","html_url":"https://github.com/nodejs/node/pull/27007","diff_url":"https://github.com/nodejs/node/pull/27007.diff","patch_url":"https://github.com/nodejs/node/pull/27007.patch"},"body":"Before:\r\n```console\r\n-bash-4.2$ ./tools/test.py --time doctool\r\n[00:02|% 100|+   4|-   0]: Done\r\n\r\n--- Total time: 00:02.770 ---\r\nTraceback (most recent call last):\r\n  File \"./tools/test.py\", line 1765, in <module>\r\n    sys.exit(Main())\r\n  File \"./tools/test.py\", line 1758, in Main\r\n    t = FormatTimedelta(entry.duration)\r\n  File \"./tools/test.py\", line 1514, in FormatTimedelta\r\n    if hasattr(td.total, 'total_seconds'):\r\nAttributeError: 'datetime.timedelta' object has no attribute 'total'\r\n-bash-4.2$\r\n```\r\n\r\nAfter:\r\n```console\r\n-bash-4.2$ ./tools/test.py --time doctool\r\n[00:02|% 100|+   4|-   0]: Done\r\n\r\n--- Total time: 00:02.905 ---\r\n   1 (00:01.612) release test-apilinks\r\n   2 (00:00.710) release test-doctool-html\r\n   3 (00:00.411) release test-doctool-json\r\n   4 (00:00.171) release test-make-doc\r\n-bash-4.2$\r\n```\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/478242692","html_url":"https://github.com/nodejs/node/pull/27007#issuecomment-478242692","issue_url":"https://api.github.com/repos/nodejs/node/issues/27007","id":478242692,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3ODI0MjY5Mg==","user":{"login":"targos","id":2352663,"node_id":"MDQ6VXNlcjIzNTI2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"created_at":"2019-03-30T12:47:26Z","updated_at":"2019-03-30T12:47:26Z","author_association":"MEMBER","body":"TIL about the `--time` option 😄 "}}
{"actor":{"display_login":"targos"}}