{"action":"created","issue":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3829","repository_url":"https://api.github.com/repos/lightningnetwork/lnd","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3829/labels{/name}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3829/comments","events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3829/events","html_url":"https://github.com/lightningnetwork/lnd/pull/3829","id":537029571,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyNDU3NDMx","number":3829,"title":"[anchor] Pluggable commitments","user":{"login":"halseth","id":3765732,"node_id":"MDQ6VXNlcjM3NjU3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3765732?v=4","gravatar_id":"","url":"https://api.github.com/users/halseth","html_url":"https://github.com/halseth","followers_url":"https://api.github.com/users/halseth/followers","following_url":"https://api.github.com/users/halseth/following{/other_user}","gists_url":"https://api.github.com/users/halseth/gists{/gist_id}","starred_url":"https://api.github.com/users/halseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halseth/subscriptions","organizations_url":"https://api.github.com/users/halseth/orgs","repos_url":"https://api.github.com/users/halseth/repos","events_url":"https://api.github.com/users/halseth/events{/privacy}","received_events_url":"https://api.github.com/users/halseth/received_events","type":"User","site_admin":false},"labels":[{"id":1716760340,"node_id":"MDU6TGFiZWwxNzE2NzYwMzQw","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/anchors","name":"anchors","color":"ebb2f7","default":false,"description":""},{"id":1477059160,"node_id":"MDU6TGFiZWwxNDc3MDU5MTYw","url":"https://api.github.com/repos/lightningnetwork/lnd/labels/v0.9.0","name":"v0.9.0","color":"48f29d","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16","html_url":"https://github.com/lightningnetwork/lnd/milestone/16","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/milestones/16/labels","id":4535167,"node_id":"MDk6TWlsZXN0b25lNDUzNTE2Nw==","number":16,"title":"0.9.0","description":"","creator":{"login":"cfromknecht","id":2013993,"node_id":"MDQ6VXNlcjIwMTM5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2013993?v=4","gravatar_id":"","url":"https://api.github.com/users/cfromknecht","html_url":"https://github.com/cfromknecht","followers_url":"https://api.github.com/users/cfromknecht/followers","following_url":"https://api.github.com/users/cfromknecht/following{/other_user}","gists_url":"https://api.github.com/users/cfromknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/cfromknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfromknecht/subscriptions","organizations_url":"https://api.github.com/users/cfromknecht/orgs","repos_url":"https://api.github.com/users/cfromknecht/repos","events_url":"https://api.github.com/users/cfromknecht/events{/privacy}","received_events_url":"https://api.github.com/users/cfromknecht/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":86,"state":"open","created_at":"2019-07-31T01:37:41Z","updated_at":"2019-12-19T09:48:15Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2019-12-12T14:57:55Z","updated_at":"2019-12-19T14:15:27Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/3829","html_url":"https://github.com/lightningnetwork/lnd/pull/3829","diff_url":"https://github.com/lightningnetwork/lnd/pull/3829.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/3829.patch"},"body":"This lays the groundwork for making it easy to introduce anchor commitments.\r\n\r\nReplaces #3773 "},"comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments/567506563","html_url":"https://github.com/lightningnetwork/lnd/pull/3829#issuecomment-567506563","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/3829","id":567506563,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NzUwNjU2Mw==","user":{"login":"halseth","id":3765732,"node_id":"MDQ6VXNlcjM3NjU3MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3765732?v=4","gravatar_id":"","url":"https://api.github.com/users/halseth","html_url":"https://github.com/halseth","followers_url":"https://api.github.com/users/halseth/followers","following_url":"https://api.github.com/users/halseth/following{/other_user}","gists_url":"https://api.github.com/users/halseth/gists{/gist_id}","starred_url":"https://api.github.com/users/halseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halseth/subscriptions","organizations_url":"https://api.github.com/users/halseth/orgs","repos_url":"https://api.github.com/users/halseth/repos","events_url":"https://api.github.com/users/halseth/events{/privacy}","received_events_url":"https://api.github.com/users/halseth/received_events","type":"User","site_admin":false},"created_at":"2019-12-19T14:15:27Z","updated_at":"2019-12-19T14:15:27Z","author_association":"COLLABORATOR","body":"Ended up rever\r\n\r\n> > With regards to naming, it can get quite confusing here and there with the definition of local/remote. Maybe in some cases, our and their may be more clear.\r\n> \r\n> I did a sweep to find a few places where this could be made more clear. Opted for `ours/theirs` in cases of static perspective (where we are always handling keys, outputs, commitments from our local node perspective), and `local/remote` for the dynamic perspective (where we are sharing logic from both perspectives).\r\n> \r\n> Obviously this naming is used interchangeably throughout the codebase, so it was an effort way to large for this PR to change it everywhere, but would be nice to decide on a naming scheme and stick to it going forward.\r\n> \r\n> I did the change in the parts already touched by this PR and for the `ChannelConfigs`:\r\n> [0785952](https://github.com/lightningnetwork/lnd/commit/07859528852f697cf9d5ec89750e2fe69162bce1)\r\n> [7f7449d](https://github.com/lightningnetwork/lnd/commit/7f7449d937b1118812bc3f80d349eeb094471556)\r\n> [03a6d37](https://github.com/lightningnetwork/lnd/commit/03a6d377e6cc8cbad9cb4502abcdf9cd784a6e5f)\r\n> [4f02cde](https://github.com/lightningnetwork/lnd/commit/4f02cdea60f6ef261b47f044c9eee5629f35554c)\r\n> [80f4ece](https://github.com/lightningnetwork/lnd/commit/80f4ece42aacb0988820c031cc9d4d0b8a3302a3)\r\n> \r\n> lmk what you think!\r\n\r\nEnded up reverting most of these changes, since it made a large PR even larger. I think we should agree on a proper way of naming things, and do a PR that does only that change if wanted."}}
{"actor":{"display_login":"halseth"}}