{"action":"created","comment":{"url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/comments/315429887","pull_request_review_id":276837127,"id":315429887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNTQyOTg4Nw==","diff_hunk":"@@ -320,9 +319,7 @@ def configure_createcollection(self, ns, definition):\n         @wraps(definition.func)\n         def create_collection(**path_data):\n             request_data = load_request_data(definition.request_schema)\n-            # NB: if we don't filter the request body through an explicit page schema,\n-            # we will leak other request arguments into the pagination query strings\n-            page = self.page_cls.from_query_string(self.page_schema(), request_data)\n+            page = self.page_cls.from_query_string(self.page_schema(), {})","path":"microcosm_flask/conventions/crud.py","position":17,"original_position":17,"commit_id":"289cc4958621dfe9445fcda7bfdda7738e2ac793","original_commit_id":"83ffaeb8100ba539472eddfb586ca44db4acbd1e","user":{"login":"GabeLambda","id":19560680,"node_id":"MDQ6VXNlcjE5NTYwNjgw","avatar_url":"https://avatars3.githubusercontent.com/u/19560680?v=4","gravatar_id":"","url":"https://api.github.com/users/GabeLambda","html_url":"https://github.com/GabeLambda","followers_url":"https://api.github.com/users/GabeLambda/followers","following_url":"https://api.github.com/users/GabeLambda/following{/other_user}","gists_url":"https://api.github.com/users/GabeLambda/gists{/gist_id}","starred_url":"https://api.github.com/users/GabeLambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabeLambda/subscriptions","organizations_url":"https://api.github.com/users/GabeLambda/orgs","repos_url":"https://api.github.com/users/GabeLambda/repos","events_url":"https://api.github.com/users/GabeLambda/events{/privacy}","received_events_url":"https://api.github.com/users/GabeLambda/received_events","type":"User","site_admin":false},"body":"I'll double-check this.","created_at":"2019-08-19T21:57:22Z","updated_at":"2019-08-19T21:57:22Z","html_url":"https://github.com/globality-corp/microcosm-flask/pull/231#discussion_r315429887","pull_request_url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/comments/315429887"},"html":{"href":"https://github.com/globality-corp/microcosm-flask/pull/231#discussion_r315429887"},"pull_request":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231"}},"in_reply_to_id":315350121},"pull_request":{"url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231","id":308727692,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4NzI3Njky","html_url":"https://github.com/globality-corp/microcosm-flask/pull/231","diff_url":"https://github.com/globality-corp/microcosm-flask/pull/231.diff","patch_url":"https://github.com/globality-corp/microcosm-flask/pull/231.patch","issue_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/231","number":231,"state":"open","locked":false,"title":"GLOB-35427 Upgrade to marshmallow 3.0","user":{"login":"GabeLambda","id":19560680,"node_id":"MDQ6VXNlcjE5NTYwNjgw","avatar_url":"https://avatars3.githubusercontent.com/u/19560680?v=4","gravatar_id":"","url":"https://api.github.com/users/GabeLambda","html_url":"https://github.com/GabeLambda","followers_url":"https://api.github.com/users/GabeLambda/followers","following_url":"https://api.github.com/users/GabeLambda/following{/other_user}","gists_url":"https://api.github.com/users/GabeLambda/gists{/gist_id}","starred_url":"https://api.github.com/users/GabeLambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabeLambda/subscriptions","organizations_url":"https://api.github.com/users/GabeLambda/orgs","repos_url":"https://api.github.com/users/GabeLambda/repos","events_url":"https://api.github.com/users/GabeLambda/events{/privacy}","received_events_url":"https://api.github.com/users/GabeLambda/received_events","type":"User","site_admin":false},"body":"Updates usages of marshmallow to account for several changes in marshmallow 3.0\r\n\r\nNote that this effectively moves this repo to be python 3.5+ compatible-only, given that those are the versions that marshmallow itself supports.\r\n\r\nNote: I haven't run this in another live service yet; I wouldn't be surprised if there are other subtle issues that may have cropped up here. I hadn't yet pored through every line in the [upgrade doc](https://marshmallow.readthedocs.io/en/stable/upgrading.html). I'll do some testing and read through that first before merging.","created_at":"2019-08-19T18:22:55Z","updated_at":"2019-08-19T21:57:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88fbb975bec09d712da3eaf9db5133cc8a476794","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231/commits","review_comments_url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231/comments","review_comment_url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/231/comments","statuses_url":"https://api.github.com/repos/globality-corp/microcosm-flask/statuses/289cc4958621dfe9445fcda7bfdda7738e2ac793","head":{"label":"globality-corp:feature/upgrade-to-marshmallow-3.0","ref":"feature/upgrade-to-marshmallow-3.0","sha":"289cc4958621dfe9445fcda7bfdda7738e2ac793","user":{"login":"globality-corp","id":11172782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTcyNzgy","avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"repo":{"id":53442595,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ0MjU5NQ==","name":"microcosm-flask","full_name":"globality-corp/microcosm-flask","private":false,"owner":{"login":"globality-corp","id":11172782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTcyNzgy","avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/globality-corp/microcosm-flask","description":"Opinionated Flask services","fork":false,"url":"https://api.github.com/repos/globality-corp/microcosm-flask","forks_url":"https://api.github.com/repos/globality-corp/microcosm-flask/forks","keys_url":"https://api.github.com/repos/globality-corp/microcosm-flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globality-corp/microcosm-flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globality-corp/microcosm-flask/teams","hooks_url":"https://api.github.com/repos/globality-corp/microcosm-flask/hooks","issue_events_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/events{/number}","events_url":"https://api.github.com/repos/globality-corp/microcosm-flask/events","assignees_url":"https://api.github.com/repos/globality-corp/microcosm-flask/assignees{/user}","branches_url":"https://api.github.com/repos/globality-corp/microcosm-flask/branches{/branch}","tags_url":"https://api.github.com/repos/globality-corp/microcosm-flask/tags","blobs_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globality-corp/microcosm-flask/statuses/{sha}","languages_url":"https://api.github.com/repos/globality-corp/microcosm-flask/languages","stargazers_url":"https://api.github.com/repos/globality-corp/microcosm-flask/stargazers","contributors_url":"https://api.github.com/repos/globality-corp/microcosm-flask/contributors","subscribers_url":"https://api.github.com/repos/globality-corp/microcosm-flask/subscribers","subscription_url":"https://api.github.com/repos/globality-corp/microcosm-flask/subscription","commits_url":"https://api.github.com/repos/globality-corp/microcosm-flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/globality-corp/microcosm-flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/globality-corp/microcosm-flask/contents/{+path}","compare_url":"https://api.github.com/repos/globality-corp/microcosm-flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globality-corp/microcosm-flask/merges","archive_url":"https://api.github.com/repos/globality-corp/microcosm-flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globality-corp/microcosm-flask/downloads","issues_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues{/number}","pulls_url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls{/number}","milestones_url":"https://api.github.com/repos/globality-corp/microcosm-flask/milestones{/number}","notifications_url":"https://api.github.com/repos/globality-corp/microcosm-flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globality-corp/microcosm-flask/labels{/name}","releases_url":"https://api.github.com/repos/globality-corp/microcosm-flask/releases{/id}","deployments_url":"https://api.github.com/repos/globality-corp/microcosm-flask/deployments","created_at":"2016-03-08T20:23:55Z","updated_at":"2019-08-19T15:44:18Z","pushed_at":"2019-08-19T20:59:01Z","git_url":"git://github.com/globality-corp/microcosm-flask.git","ssh_url":"git@github.com:globality-corp/microcosm-flask.git","clone_url":"https://github.com/globality-corp/microcosm-flask.git","svn_url":"https://github.com/globality-corp/microcosm-flask","homepage":null,"size":579,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":2,"watchers":7,"default_branch":"develop"}},"base":{"label":"globality-corp:develop","ref":"develop","sha":"e483bbe43617c9a2a41249e1b85390cb1a8927ad","user":{"login":"globality-corp","id":11172782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTcyNzgy","avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"repo":{"id":53442595,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ0MjU5NQ==","name":"microcosm-flask","full_name":"globality-corp/microcosm-flask","private":false,"owner":{"login":"globality-corp","id":11172782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMTcyNzgy","avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/globality-corp/microcosm-flask","description":"Opinionated Flask services","fork":false,"url":"https://api.github.com/repos/globality-corp/microcosm-flask","forks_url":"https://api.github.com/repos/globality-corp/microcosm-flask/forks","keys_url":"https://api.github.com/repos/globality-corp/microcosm-flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globality-corp/microcosm-flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globality-corp/microcosm-flask/teams","hooks_url":"https://api.github.com/repos/globality-corp/microcosm-flask/hooks","issue_events_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/events{/number}","events_url":"https://api.github.com/repos/globality-corp/microcosm-flask/events","assignees_url":"https://api.github.com/repos/globality-corp/microcosm-flask/assignees{/user}","branches_url":"https://api.github.com/repos/globality-corp/microcosm-flask/branches{/branch}","tags_url":"https://api.github.com/repos/globality-corp/microcosm-flask/tags","blobs_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globality-corp/microcosm-flask/statuses/{sha}","languages_url":"https://api.github.com/repos/globality-corp/microcosm-flask/languages","stargazers_url":"https://api.github.com/repos/globality-corp/microcosm-flask/stargazers","contributors_url":"https://api.github.com/repos/globality-corp/microcosm-flask/contributors","subscribers_url":"https://api.github.com/repos/globality-corp/microcosm-flask/subscribers","subscription_url":"https://api.github.com/repos/globality-corp/microcosm-flask/subscription","commits_url":"https://api.github.com/repos/globality-corp/microcosm-flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/globality-corp/microcosm-flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/globality-corp/microcosm-flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/globality-corp/microcosm-flask/contents/{+path}","compare_url":"https://api.github.com/repos/globality-corp/microcosm-flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globality-corp/microcosm-flask/merges","archive_url":"https://api.github.com/repos/globality-corp/microcosm-flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globality-corp/microcosm-flask/downloads","issues_url":"https://api.github.com/repos/globality-corp/microcosm-flask/issues{/number}","pulls_url":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls{/number}","milestones_url":"https://api.github.com/repos/globality-corp/microcosm-flask/milestones{/number}","notifications_url":"https://api.github.com/repos/globality-corp/microcosm-flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globality-corp/microcosm-flask/labels{/name}","releases_url":"https://api.github.com/repos/globality-corp/microcosm-flask/releases{/id}","deployments_url":"https://api.github.com/repos/globality-corp/microcosm-flask/deployments","created_at":"2016-03-08T20:23:55Z","updated_at":"2019-08-19T15:44:18Z","pushed_at":"2019-08-19T20:59:01Z","git_url":"git://github.com/globality-corp/microcosm-flask.git","ssh_url":"git@github.com:globality-corp/microcosm-flask.git","clone_url":"https://github.com/globality-corp/microcosm-flask.git","svn_url":"https://github.com/globality-corp/microcosm-flask","homepage":null,"size":579,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":2,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231"},"html":{"href":"https://github.com/globality-corp/microcosm-flask/pull/231"},"issue":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/231"},"comments":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/globality-corp/microcosm-flask/statuses/289cc4958621dfe9445fcda7bfdda7738e2ac793"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GabeLambda"}}