{"action":"created","comment":{"url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/comments/357826175","pull_request_review_id":332105424,"id":357826175,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzgyNjE3NQ==","diff_hunk":"@@ -9,6 +9,8 @@\n \n class Project(FieldsMixin, ClarityElement):\n     UNIVERSAL_TAG = \"{http://genologics.com/ri/project}project\"\n+    BATCH_FLAGS = BatchFlags.QUERY\n+","path":"s4/clarity/project.py","position":13,"original_position":13,"commit_id":"2202c0e7363d9489daeb53c1a74d29f268f9ef0c","original_commit_id":"2202c0e7363d9489daeb53c1a74d29f268f9ef0c","user":{"login":"jeremysnell","id":14983313,"node_id":"MDQ6VXNlcjE0OTgzMzEz","avatar_url":"https://avatars0.githubusercontent.com/u/14983313?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremysnell","html_url":"https://github.com/jeremysnell","followers_url":"https://api.github.com/users/jeremysnell/followers","following_url":"https://api.github.com/users/jeremysnell/following{/other_user}","gists_url":"https://api.github.com/users/jeremysnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremysnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremysnell/subscriptions","organizations_url":"https://api.github.com/users/jeremysnell/orgs","repos_url":"https://api.github.com/users/jeremysnell/repos","events_url":"https://api.github.com/users/jeremysnell/events{/privacy}","received_events_url":"https://api.github.com/users/jeremysnell/received_events","type":"User","site_admin":false},"body":"Extra newline?","created_at":"2019-12-13T20:46:33Z","updated_at":"2019-12-13T20:47:49Z","html_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib/pull/9#discussion_r357826175","pull_request_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/comments/357826175"},"html":{"href":"https://github.com/SemaphoreSolutions/s4-clarity-lib/pull/9#discussion_r357826175"},"pull_request":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9","id":353062822,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMDYyODIy","html_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib/pull/9","diff_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib/pull/9.diff","patch_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib/pull/9.patch","issue_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues/9","number":9,"state":"open","locked":false,"title":"Remove class constants from element factory constructors","user":{"login":"AvroNelson","id":14112554,"node_id":"MDQ6VXNlcjE0MTEyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/14112554?v=4","gravatar_id":"","url":"https://api.github.com/users/AvroNelson","html_url":"https://github.com/AvroNelson","followers_url":"https://api.github.com/users/AvroNelson/followers","following_url":"https://api.github.com/users/AvroNelson/following{/other_user}","gists_url":"https://api.github.com/users/AvroNelson/gists{/gist_id}","starred_url":"https://api.github.com/users/AvroNelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvroNelson/subscriptions","organizations_url":"https://api.github.com/users/AvroNelson/orgs","repos_url":"https://api.github.com/users/AvroNelson/repos","events_url":"https://api.github.com/users/AvroNelson/events{/privacy}","received_events_url":"https://api.github.com/users/AvroNelson/received_events","type":"User","site_admin":false},"body":"Moving the Batch Flags, Request Path and Name Attribute values out of the Element Factory initializers and into class constants on the actual element objects.  Added some expanded comments and unit tests to verify expected behaviour.\r\n\r\nMultiple `can_batch_X()` methods on the ElementFactory have the values cast to bool as that is what they report to return, but were returning int values.","created_at":"2019-12-13T20:28:50Z","updated_at":"2019-12-13T20:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5291d6ff006b8380ceb2717c6b944360addbc190","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9/commits","review_comments_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9/comments","review_comment_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues/9/comments","statuses_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/statuses/2202c0e7363d9489daeb53c1a74d29f268f9ef0c","head":{"label":"AvroNelson:Remove-Class-Constants-from-ElementFactory-Constructors","ref":"Remove-Class-Constants-from-ElementFactory-Constructors","sha":"2202c0e7363d9489daeb53c1a74d29f268f9ef0c","user":{"login":"AvroNelson","id":14112554,"node_id":"MDQ6VXNlcjE0MTEyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/14112554?v=4","gravatar_id":"","url":"https://api.github.com/users/AvroNelson","html_url":"https://github.com/AvroNelson","followers_url":"https://api.github.com/users/AvroNelson/followers","following_url":"https://api.github.com/users/AvroNelson/following{/other_user}","gists_url":"https://api.github.com/users/AvroNelson/gists{/gist_id}","starred_url":"https://api.github.com/users/AvroNelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvroNelson/subscriptions","organizations_url":"https://api.github.com/users/AvroNelson/orgs","repos_url":"https://api.github.com/users/AvroNelson/repos","events_url":"https://api.github.com/users/AvroNelson/events{/privacy}","received_events_url":"https://api.github.com/users/AvroNelson/received_events","type":"User","site_admin":false},"repo":{"id":188311640,"node_id":"MDEwOlJlcG9zaXRvcnkxODgzMTE2NDA=","name":"s4-clarity-lib","full_name":"AvroNelson/s4-clarity-lib","private":false,"owner":{"login":"AvroNelson","id":14112554,"node_id":"MDQ6VXNlcjE0MTEyNTU0","avatar_url":"https://avatars1.githubusercontent.com/u/14112554?v=4","gravatar_id":"","url":"https://api.github.com/users/AvroNelson","html_url":"https://github.com/AvroNelson","followers_url":"https://api.github.com/users/AvroNelson/followers","following_url":"https://api.github.com/users/AvroNelson/following{/other_user}","gists_url":"https://api.github.com/users/AvroNelson/gists{/gist_id}","starred_url":"https://api.github.com/users/AvroNelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvroNelson/subscriptions","organizations_url":"https://api.github.com/users/AvroNelson/orgs","repos_url":"https://api.github.com/users/AvroNelson/repos","events_url":"https://api.github.com/users/AvroNelson/events{/privacy}","received_events_url":"https://api.github.com/users/AvroNelson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AvroNelson/s4-clarity-lib","description":"A modern Python library for BaseSpace Clarity LIMS.","fork":true,"url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib","forks_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/forks","keys_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/teams","hooks_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/hooks","issue_events_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/issues/events{/number}","events_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/events","assignees_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/assignees{/user}","branches_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/branches{/branch}","tags_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/tags","blobs_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/languages","stargazers_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/stargazers","contributors_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/contributors","subscribers_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/subscribers","subscription_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/subscription","commits_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/contents/{+path}","compare_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/merges","archive_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/downloads","issues_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/issues{/number}","pulls_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/labels{/name}","releases_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/releases{/id}","deployments_url":"https://api.github.com/repos/AvroNelson/s4-clarity-lib/deployments","created_at":"2019-05-23T21:51:56Z","updated_at":"2019-05-23T21:57:35Z","pushed_at":"2019-12-13T20:21:32Z","git_url":"git://github.com/AvroNelson/s4-clarity-lib.git","ssh_url":"git@github.com:AvroNelson/s4-clarity-lib.git","clone_url":"https://github.com/AvroNelson/s4-clarity-lib.git","svn_url":"https://github.com/AvroNelson/s4-clarity-lib","homepage":"https://s4-clarity-lib.readthedocs.io","size":133,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SemaphoreSolutions:master","ref":"master","sha":"af6f2ec77cdb7f942f5ea3990a61950aa2a1b3a4","user":{"login":"SemaphoreSolutions","id":1675223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzUyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1675223?v=4","gravatar_id":"","url":"https://api.github.com/users/SemaphoreSolutions","html_url":"https://github.com/SemaphoreSolutions","followers_url":"https://api.github.com/users/SemaphoreSolutions/followers","following_url":"https://api.github.com/users/SemaphoreSolutions/following{/other_user}","gists_url":"https://api.github.com/users/SemaphoreSolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/SemaphoreSolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemaphoreSolutions/subscriptions","organizations_url":"https://api.github.com/users/SemaphoreSolutions/orgs","repos_url":"https://api.github.com/users/SemaphoreSolutions/repos","events_url":"https://api.github.com/users/SemaphoreSolutions/events{/privacy}","received_events_url":"https://api.github.com/users/SemaphoreSolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":180194151,"node_id":"MDEwOlJlcG9zaXRvcnkxODAxOTQxNTE=","name":"s4-clarity-lib","full_name":"SemaphoreSolutions/s4-clarity-lib","private":false,"owner":{"login":"SemaphoreSolutions","id":1675223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzUyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1675223?v=4","gravatar_id":"","url":"https://api.github.com/users/SemaphoreSolutions","html_url":"https://github.com/SemaphoreSolutions","followers_url":"https://api.github.com/users/SemaphoreSolutions/followers","following_url":"https://api.github.com/users/SemaphoreSolutions/following{/other_user}","gists_url":"https://api.github.com/users/SemaphoreSolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/SemaphoreSolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemaphoreSolutions/subscriptions","organizations_url":"https://api.github.com/users/SemaphoreSolutions/orgs","repos_url":"https://api.github.com/users/SemaphoreSolutions/repos","events_url":"https://api.github.com/users/SemaphoreSolutions/events{/privacy}","received_events_url":"https://api.github.com/users/SemaphoreSolutions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib","description":"A modern Python library for BaseSpace Clarity LIMS.","fork":false,"url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib","forks_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/forks","keys_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/teams","hooks_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/hooks","issue_events_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues/events{/number}","events_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/events","assignees_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/assignees{/user}","branches_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/branches{/branch}","tags_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/tags","blobs_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/languages","stargazers_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/stargazers","contributors_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/contributors","subscribers_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/subscribers","subscription_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/subscription","commits_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/contents/{+path}","compare_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/merges","archive_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/downloads","issues_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues{/number}","pulls_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/labels{/name}","releases_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/releases{/id}","deployments_url":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/deployments","created_at":"2019-04-08T16:55:54Z","updated_at":"2019-05-03T23:44:14Z","pushed_at":"2019-12-13T20:28:51Z","git_url":"git://github.com/SemaphoreSolutions/s4-clarity-lib.git","ssh_url":"git@github.com:SemaphoreSolutions/s4-clarity-lib.git","clone_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib.git","svn_url":"https://github.com/SemaphoreSolutions/s4-clarity-lib","homepage":"https://s4-clarity-lib.readthedocs.io","size":126,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9"},"html":{"href":"https://github.com/SemaphoreSolutions/s4-clarity-lib/pull/9"},"issue":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues/9"},"comments":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/SemaphoreSolutions/s4-clarity-lib/statuses/2202c0e7363d9489daeb53c1a74d29f268f9ef0c"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeremysnell"}}