{"action":"created","comment":{"url":"https://api.github.com/repos/strudeljs/strudel/pulls/comments/289364046","pull_request_review_id":244274063,"id":289364046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTM2NDA0Ng==","diff_hunk":"@@ -67,6 +68,15 @@ class Registry {\n       warn(`Component registered under selector: ${selector} already exists.`, klass);\n     } else {\n       this._registrationQueue[selector] = klass;\n+\n+      if (!this._isRegisterScheduled) {\n+        this._isRegisterScheduled = true;\n+\n+        setTimeout(() => {","path":"src/core/registry.js","position":null,"original_position":16,"commit_id":"0149b1a7f3091e9de3b6fe039c8c1eb2cda2f207","original_commit_id":"5c24aef107e03558835904ed7a3b6aca24c1acdf","user":{"login":"m-suchorski","id":36552116,"node_id":"MDQ6VXNlcjM2NTUyMTE2","avatar_url":"https://avatars0.githubusercontent.com/u/36552116?v=4","gravatar_id":"","url":"https://api.github.com/users/m-suchorski","html_url":"https://github.com/m-suchorski","followers_url":"https://api.github.com/users/m-suchorski/followers","following_url":"https://api.github.com/users/m-suchorski/following{/other_user}","gists_url":"https://api.github.com/users/m-suchorski/gists{/gist_id}","starred_url":"https://api.github.com/users/m-suchorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-suchorski/subscriptions","organizations_url":"https://api.github.com/users/m-suchorski/orgs","repos_url":"https://api.github.com/users/m-suchorski/repos","events_url":"https://api.github.com/users/m-suchorski/events{/privacy}","received_events_url":"https://api.github.com/users/m-suchorski/received_events","type":"User","site_admin":false},"body":"requestIdleCallback isn't supported on IE11. I've cahnged it to requestAnimationFrame.","created_at":"2019-05-31T12:11:56Z","updated_at":"2019-05-31T12:11:57Z","html_url":"https://github.com/strudeljs/strudel/pull/96#discussion_r289364046","pull_request_url":"https://api.github.com/repos/strudeljs/strudel/pulls/96","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/strudeljs/strudel/pulls/comments/289364046"},"html":{"href":"https://github.com/strudeljs/strudel/pull/96#discussion_r289364046"},"pull_request":{"href":"https://api.github.com/repos/strudeljs/strudel/pulls/96"}},"in_reply_to_id":289362255},"pull_request":{"url":"https://api.github.com/repos/strudeljs/strudel/pulls/96","id":281544865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxNTQ0ODY1","html_url":"https://github.com/strudeljs/strudel/pull/96","diff_url":"https://github.com/strudeljs/strudel/pull/96.diff","patch_url":"https://github.com/strudeljs/strudel/pull/96.patch","issue_url":"https://api.github.com/repos/strudeljs/strudel/issues/96","number":96,"state":"open","locked":false,"title":"feat(Dynamic components): Added temporary registry type","user":{"login":"m-suchorski","id":36552116,"node_id":"MDQ6VXNlcjM2NTUyMTE2","avatar_url":"https://avatars0.githubusercontent.com/u/36552116?v=4","gravatar_id":"","url":"https://api.github.com/users/m-suchorski","html_url":"https://github.com/m-suchorski","followers_url":"https://api.github.com/users/m-suchorski/followers","following_url":"https://api.github.com/users/m-suchorski/following{/other_user}","gists_url":"https://api.github.com/users/m-suchorski/gists{/gist_id}","starred_url":"https://api.github.com/users/m-suchorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-suchorski/subscriptions","organizations_url":"https://api.github.com/users/m-suchorski/orgs","repos_url":"https://api.github.com/users/m-suchorski/repos","events_url":"https://api.github.com/users/m-suchorski/events{/privacy}","received_events_url":"https://api.github.com/users/m-suchorski/received_events","type":"User","site_admin":false},"body":"Added a temporary registry, which is used in component registration process. Entires from temporary registry are moved to permanent one after a successful action. This approach eliminates the error of trying to attach component to a node that has already been initialized. ","created_at":"2019-05-23T10:43:33Z","updated_at":"2019-05-31T12:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cc3387add7a3ffeb44f22c0e95f47459dd7d33c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strudeljs/strudel/pulls/96/commits","review_comments_url":"https://api.github.com/repos/strudeljs/strudel/pulls/96/comments","review_comment_url":"https://api.github.com/repos/strudeljs/strudel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strudeljs/strudel/issues/96/comments","statuses_url":"https://api.github.com/repos/strudeljs/strudel/statuses/0149b1a7f3091e9de3b6fe039c8c1eb2cda2f207","head":{"label":"m-suchorski:feature/dynamic","ref":"feature/dynamic","sha":"0149b1a7f3091e9de3b6fe039c8c1eb2cda2f207","user":{"login":"m-suchorski","id":36552116,"node_id":"MDQ6VXNlcjM2NTUyMTE2","avatar_url":"https://avatars0.githubusercontent.com/u/36552116?v=4","gravatar_id":"","url":"https://api.github.com/users/m-suchorski","html_url":"https://github.com/m-suchorski","followers_url":"https://api.github.com/users/m-suchorski/followers","following_url":"https://api.github.com/users/m-suchorski/following{/other_user}","gists_url":"https://api.github.com/users/m-suchorski/gists{/gist_id}","starred_url":"https://api.github.com/users/m-suchorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-suchorski/subscriptions","organizations_url":"https://api.github.com/users/m-suchorski/orgs","repos_url":"https://api.github.com/users/m-suchorski/repos","events_url":"https://api.github.com/users/m-suchorski/events{/privacy}","received_events_url":"https://api.github.com/users/m-suchorski/received_events","type":"User","site_admin":false},"repo":{"id":188213076,"node_id":"MDEwOlJlcG9zaXRvcnkxODgyMTMwNzY=","name":"strudel","full_name":"m-suchorski/strudel","private":false,"owner":{"login":"m-suchorski","id":36552116,"node_id":"MDQ6VXNlcjM2NTUyMTE2","avatar_url":"https://avatars0.githubusercontent.com/u/36552116?v=4","gravatar_id":"","url":"https://api.github.com/users/m-suchorski","html_url":"https://github.com/m-suchorski","followers_url":"https://api.github.com/users/m-suchorski/followers","following_url":"https://api.github.com/users/m-suchorski/following{/other_user}","gists_url":"https://api.github.com/users/m-suchorski/gists{/gist_id}","starred_url":"https://api.github.com/users/m-suchorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-suchorski/subscriptions","organizations_url":"https://api.github.com/users/m-suchorski/orgs","repos_url":"https://api.github.com/users/m-suchorski/repos","events_url":"https://api.github.com/users/m-suchorski/events{/privacy}","received_events_url":"https://api.github.com/users/m-suchorski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/m-suchorski/strudel","description":"A front-end framework for the back-end powered web","fork":true,"url":"https://api.github.com/repos/m-suchorski/strudel","forks_url":"https://api.github.com/repos/m-suchorski/strudel/forks","keys_url":"https://api.github.com/repos/m-suchorski/strudel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-suchorski/strudel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-suchorski/strudel/teams","hooks_url":"https://api.github.com/repos/m-suchorski/strudel/hooks","issue_events_url":"https://api.github.com/repos/m-suchorski/strudel/issues/events{/number}","events_url":"https://api.github.com/repos/m-suchorski/strudel/events","assignees_url":"https://api.github.com/repos/m-suchorski/strudel/assignees{/user}","branches_url":"https://api.github.com/repos/m-suchorski/strudel/branches{/branch}","tags_url":"https://api.github.com/repos/m-suchorski/strudel/tags","blobs_url":"https://api.github.com/repos/m-suchorski/strudel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-suchorski/strudel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-suchorski/strudel/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-suchorski/strudel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-suchorski/strudel/statuses/{sha}","languages_url":"https://api.github.com/repos/m-suchorski/strudel/languages","stargazers_url":"https://api.github.com/repos/m-suchorski/strudel/stargazers","contributors_url":"https://api.github.com/repos/m-suchorski/strudel/contributors","subscribers_url":"https://api.github.com/repos/m-suchorski/strudel/subscribers","subscription_url":"https://api.github.com/repos/m-suchorski/strudel/subscription","commits_url":"https://api.github.com/repos/m-suchorski/strudel/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-suchorski/strudel/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-suchorski/strudel/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-suchorski/strudel/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-suchorski/strudel/contents/{+path}","compare_url":"https://api.github.com/repos/m-suchorski/strudel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-suchorski/strudel/merges","archive_url":"https://api.github.com/repos/m-suchorski/strudel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-suchorski/strudel/downloads","issues_url":"https://api.github.com/repos/m-suchorski/strudel/issues{/number}","pulls_url":"https://api.github.com/repos/m-suchorski/strudel/pulls{/number}","milestones_url":"https://api.github.com/repos/m-suchorski/strudel/milestones{/number}","notifications_url":"https://api.github.com/repos/m-suchorski/strudel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-suchorski/strudel/labels{/name}","releases_url":"https://api.github.com/repos/m-suchorski/strudel/releases{/id}","deployments_url":"https://api.github.com/repos/m-suchorski/strudel/deployments","created_at":"2019-05-23T10:32:14Z","updated_at":"2019-05-23T10:47:21Z","pushed_at":"2019-05-31T12:11:29Z","git_url":"git://github.com/m-suchorski/strudel.git","ssh_url":"git@github.com:m-suchorski/strudel.git","clone_url":"https://github.com/m-suchorski/strudel.git","svn_url":"https://github.com/m-suchorski/strudel","homepage":"https://strudeljs.org","size":1216,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"strudeljs:dev","ref":"dev","sha":"3fb1d4d7576b3e65c7e4bb543075181d2567dbb6","user":{"login":"strudeljs","id":27229624,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjI5NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/27229624?v=4","gravatar_id":"","url":"https://api.github.com/users/strudeljs","html_url":"https://github.com/strudeljs","followers_url":"https://api.github.com/users/strudeljs/followers","following_url":"https://api.github.com/users/strudeljs/following{/other_user}","gists_url":"https://api.github.com/users/strudeljs/gists{/gist_id}","starred_url":"https://api.github.com/users/strudeljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strudeljs/subscriptions","organizations_url":"https://api.github.com/users/strudeljs/orgs","repos_url":"https://api.github.com/users/strudeljs/repos","events_url":"https://api.github.com/users/strudeljs/events{/privacy}","received_events_url":"https://api.github.com/users/strudeljs/received_events","type":"Organization","site_admin":false},"repo":{"id":87837995,"node_id":"MDEwOlJlcG9zaXRvcnk4NzgzNzk5NQ==","name":"strudel","full_name":"strudeljs/strudel","private":false,"owner":{"login":"strudeljs","id":27229624,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjI5NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/27229624?v=4","gravatar_id":"","url":"https://api.github.com/users/strudeljs","html_url":"https://github.com/strudeljs","followers_url":"https://api.github.com/users/strudeljs/followers","following_url":"https://api.github.com/users/strudeljs/following{/other_user}","gists_url":"https://api.github.com/users/strudeljs/gists{/gist_id}","starred_url":"https://api.github.com/users/strudeljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strudeljs/subscriptions","organizations_url":"https://api.github.com/users/strudeljs/orgs","repos_url":"https://api.github.com/users/strudeljs/repos","events_url":"https://api.github.com/users/strudeljs/events{/privacy}","received_events_url":"https://api.github.com/users/strudeljs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strudeljs/strudel","description":"A front-end framework for the back-end powered web","fork":false,"url":"https://api.github.com/repos/strudeljs/strudel","forks_url":"https://api.github.com/repos/strudeljs/strudel/forks","keys_url":"https://api.github.com/repos/strudeljs/strudel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strudeljs/strudel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strudeljs/strudel/teams","hooks_url":"https://api.github.com/repos/strudeljs/strudel/hooks","issue_events_url":"https://api.github.com/repos/strudeljs/strudel/issues/events{/number}","events_url":"https://api.github.com/repos/strudeljs/strudel/events","assignees_url":"https://api.github.com/repos/strudeljs/strudel/assignees{/user}","branches_url":"https://api.github.com/repos/strudeljs/strudel/branches{/branch}","tags_url":"https://api.github.com/repos/strudeljs/strudel/tags","blobs_url":"https://api.github.com/repos/strudeljs/strudel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strudeljs/strudel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strudeljs/strudel/git/refs{/sha}","trees_url":"https://api.github.com/repos/strudeljs/strudel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strudeljs/strudel/statuses/{sha}","languages_url":"https://api.github.com/repos/strudeljs/strudel/languages","stargazers_url":"https://api.github.com/repos/strudeljs/strudel/stargazers","contributors_url":"https://api.github.com/repos/strudeljs/strudel/contributors","subscribers_url":"https://api.github.com/repos/strudeljs/strudel/subscribers","subscription_url":"https://api.github.com/repos/strudeljs/strudel/subscription","commits_url":"https://api.github.com/repos/strudeljs/strudel/commits{/sha}","git_commits_url":"https://api.github.com/repos/strudeljs/strudel/git/commits{/sha}","comments_url":"https://api.github.com/repos/strudeljs/strudel/comments{/number}","issue_comment_url":"https://api.github.com/repos/strudeljs/strudel/issues/comments{/number}","contents_url":"https://api.github.com/repos/strudeljs/strudel/contents/{+path}","compare_url":"https://api.github.com/repos/strudeljs/strudel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strudeljs/strudel/merges","archive_url":"https://api.github.com/repos/strudeljs/strudel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strudeljs/strudel/downloads","issues_url":"https://api.github.com/repos/strudeljs/strudel/issues{/number}","pulls_url":"https://api.github.com/repos/strudeljs/strudel/pulls{/number}","milestones_url":"https://api.github.com/repos/strudeljs/strudel/milestones{/number}","notifications_url":"https://api.github.com/repos/strudeljs/strudel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strudeljs/strudel/labels{/name}","releases_url":"https://api.github.com/repos/strudeljs/strudel/releases{/id}","deployments_url":"https://api.github.com/repos/strudeljs/strudel/deployments","created_at":"2017-04-10T17:23:24Z","updated_at":"2019-05-30T09:51:13Z","pushed_at":"2019-05-31T12:11:30Z","git_url":"git://github.com/strudeljs/strudel.git","ssh_url":"git@github.com:strudeljs/strudel.git","clone_url":"https://github.com/strudeljs/strudel.git","svn_url":"https://github.com/strudeljs/strudel","homepage":"https://strudeljs.org","size":1182,"stargazers_count":167,"watchers_count":167,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":167,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/strudeljs/strudel/pulls/96"},"html":{"href":"https://github.com/strudeljs/strudel/pull/96"},"issue":{"href":"https://api.github.com/repos/strudeljs/strudel/issues/96"},"comments":{"href":"https://api.github.com/repos/strudeljs/strudel/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/strudeljs/strudel/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/strudeljs/strudel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strudeljs/strudel/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/strudeljs/strudel/statuses/0149b1a7f3091e9de3b6fe039c8c1eb2cda2f207"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"m-suchorski"}}