{"action":"created","comment":{"url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/comments/284005494","pull_request_review_id":237508319,"id":284005494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDAwNTQ5NA==","diff_hunk":"@@ -234,7 +234,8 @@ module dm_csrs #(\n                     end\n                     if (!cmdbusy_i) begin\n                         // check whether we need to re-execute the command (just give a cmd_valid)\n-                        cmd_valid_d = abstractauto_q.autoexecdata[dmi_req_i.addr[3:0] - int'(dm::Data0)];\n+                        cmd_valid_d = abstractauto_q.autoexecdata[dmi_req_i.addr[3:0] -","path":"src/dm_csrs.sv","position":62,"original_position":62,"commit_id":"d1b59f9ad06be68f7e8f86d08a155e0cb18b6e72","original_commit_id":"d1b59f9ad06be68f7e8f86d08a155e0cb18b6e72","user":{"login":"sjgitty","id":41092437,"node_id":"MDQ6VXNlcjQxMDkyNDM3","avatar_url":"https://avatars0.githubusercontent.com/u/41092437?v=4","gravatar_id":"","url":"https://api.github.com/users/sjgitty","html_url":"https://github.com/sjgitty","followers_url":"https://api.github.com/users/sjgitty/followers","following_url":"https://api.github.com/users/sjgitty/following{/other_user}","gists_url":"https://api.github.com/users/sjgitty/gists{/gist_id}","starred_url":"https://api.github.com/users/sjgitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjgitty/subscriptions","organizations_url":"https://api.github.com/users/sjgitty/orgs","repos_url":"https://api.github.com/users/sjgitty/repos","events_url":"https://api.github.com/users/sjgitty/events{/privacy}","received_events_url":"https://api.github.com/users/sjgitty/received_events","type":"User","site_admin":false},"body":"formatted to be <= 100 chars","created_at":"2019-05-14T21:20:39Z","updated_at":"2019-05-14T21:34:42Z","html_url":"https://github.com/pulp-platform/riscv-dbg/pull/15#discussion_r284005494","pull_request_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/comments/284005494"},"html":{"href":"https://github.com/pulp-platform/riscv-dbg/pull/15#discussion_r284005494"},"pull_request":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15","id":278855992,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4ODU1OTky","html_url":"https://github.com/pulp-platform/riscv-dbg/pull/15","diff_url":"https://github.com/pulp-platform/riscv-dbg/pull/15.diff","patch_url":"https://github.com/pulp-platform/riscv-dbg/pull/15.patch","issue_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues/15","number":15,"state":"open","locked":false,"title":"[lint] clean up some lint errors","user":{"login":"sjgitty","id":41092437,"node_id":"MDQ6VXNlcjQxMDkyNDM3","avatar_url":"https://avatars0.githubusercontent.com/u/41092437?v=4","gravatar_id":"","url":"https://api.github.com/users/sjgitty","html_url":"https://github.com/sjgitty","followers_url":"https://api.github.com/users/sjgitty/followers","following_url":"https://api.github.com/users/sjgitty/following{/other_user}","gists_url":"https://api.github.com/users/sjgitty/gists{/gist_id}","starred_url":"https://api.github.com/users/sjgitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjgitty/subscriptions","organizations_url":"https://api.github.com/users/sjgitty/orgs","repos_url":"https://api.github.com/users/sjgitty/repos","events_url":"https://api.github.com/users/sjgitty/events{/privacy}","received_events_url":"https://api.github.com/users/sjgitty/received_events","type":"User","site_admin":false},"body":"These messages were cleaned up as part of a run against AscentLint. There are a few that are purely style - eg our policy tries to keep < 100 characters. Feel free to push back against those if you consider it less readable. I will annotate the rationale where it is not obvious. There are still a few dozen lint errors, but most are waivable. I will highlight ones that are still questionable.","created_at":"2019-05-14T21:19:29Z","updated_at":"2019-05-14T21:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03893da9c634472f03c90a5078aa4eb6e17d447b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15/commits","review_comments_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15/comments","review_comment_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues/15/comments","statuses_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/statuses/d1b59f9ad06be68f7e8f86d08a155e0cb18b6e72","head":{"label":"sjgitty:pulpissimo_integration","ref":"pulpissimo_integration","sha":"d1b59f9ad06be68f7e8f86d08a155e0cb18b6e72","user":{"login":"sjgitty","id":41092437,"node_id":"MDQ6VXNlcjQxMDkyNDM3","avatar_url":"https://avatars0.githubusercontent.com/u/41092437?v=4","gravatar_id":"","url":"https://api.github.com/users/sjgitty","html_url":"https://github.com/sjgitty","followers_url":"https://api.github.com/users/sjgitty/followers","following_url":"https://api.github.com/users/sjgitty/following{/other_user}","gists_url":"https://api.github.com/users/sjgitty/gists{/gist_id}","starred_url":"https://api.github.com/users/sjgitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjgitty/subscriptions","organizations_url":"https://api.github.com/users/sjgitty/orgs","repos_url":"https://api.github.com/users/sjgitty/repos","events_url":"https://api.github.com/users/sjgitty/events{/privacy}","received_events_url":"https://api.github.com/users/sjgitty/received_events","type":"User","site_admin":false},"repo":{"id":186700299,"node_id":"MDEwOlJlcG9zaXRvcnkxODY3MDAyOTk=","name":"riscv-dbg","full_name":"sjgitty/riscv-dbg","private":false,"owner":{"login":"sjgitty","id":41092437,"node_id":"MDQ6VXNlcjQxMDkyNDM3","avatar_url":"https://avatars0.githubusercontent.com/u/41092437?v=4","gravatar_id":"","url":"https://api.github.com/users/sjgitty","html_url":"https://github.com/sjgitty","followers_url":"https://api.github.com/users/sjgitty/followers","following_url":"https://api.github.com/users/sjgitty/following{/other_user}","gists_url":"https://api.github.com/users/sjgitty/gists{/gist_id}","starred_url":"https://api.github.com/users/sjgitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjgitty/subscriptions","organizations_url":"https://api.github.com/users/sjgitty/orgs","repos_url":"https://api.github.com/users/sjgitty/repos","events_url":"https://api.github.com/users/sjgitty/events{/privacy}","received_events_url":"https://api.github.com/users/sjgitty/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjgitty/riscv-dbg","description":"RISC-V Debug Support for our PULP Cores","fork":true,"url":"https://api.github.com/repos/sjgitty/riscv-dbg","forks_url":"https://api.github.com/repos/sjgitty/riscv-dbg/forks","keys_url":"https://api.github.com/repos/sjgitty/riscv-dbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjgitty/riscv-dbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjgitty/riscv-dbg/teams","hooks_url":"https://api.github.com/repos/sjgitty/riscv-dbg/hooks","issue_events_url":"https://api.github.com/repos/sjgitty/riscv-dbg/issues/events{/number}","events_url":"https://api.github.com/repos/sjgitty/riscv-dbg/events","assignees_url":"https://api.github.com/repos/sjgitty/riscv-dbg/assignees{/user}","branches_url":"https://api.github.com/repos/sjgitty/riscv-dbg/branches{/branch}","tags_url":"https://api.github.com/repos/sjgitty/riscv-dbg/tags","blobs_url":"https://api.github.com/repos/sjgitty/riscv-dbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjgitty/riscv-dbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjgitty/riscv-dbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjgitty/riscv-dbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjgitty/riscv-dbg/statuses/{sha}","languages_url":"https://api.github.com/repos/sjgitty/riscv-dbg/languages","stargazers_url":"https://api.github.com/repos/sjgitty/riscv-dbg/stargazers","contributors_url":"https://api.github.com/repos/sjgitty/riscv-dbg/contributors","subscribers_url":"https://api.github.com/repos/sjgitty/riscv-dbg/subscribers","subscription_url":"https://api.github.com/repos/sjgitty/riscv-dbg/subscription","commits_url":"https://api.github.com/repos/sjgitty/riscv-dbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjgitty/riscv-dbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjgitty/riscv-dbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjgitty/riscv-dbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjgitty/riscv-dbg/contents/{+path}","compare_url":"https://api.github.com/repos/sjgitty/riscv-dbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjgitty/riscv-dbg/merges","archive_url":"https://api.github.com/repos/sjgitty/riscv-dbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjgitty/riscv-dbg/downloads","issues_url":"https://api.github.com/repos/sjgitty/riscv-dbg/issues{/number}","pulls_url":"https://api.github.com/repos/sjgitty/riscv-dbg/pulls{/number}","milestones_url":"https://api.github.com/repos/sjgitty/riscv-dbg/milestones{/number}","notifications_url":"https://api.github.com/repos/sjgitty/riscv-dbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjgitty/riscv-dbg/labels{/name}","releases_url":"https://api.github.com/repos/sjgitty/riscv-dbg/releases{/id}","deployments_url":"https://api.github.com/repos/sjgitty/riscv-dbg/deployments","created_at":"2019-05-14T21:04:43Z","updated_at":"2019-05-14T21:04:46Z","pushed_at":"2019-05-14T21:16:34Z","git_url":"git://github.com/sjgitty/riscv-dbg.git","ssh_url":"git@github.com:sjgitty/riscv-dbg.git","clone_url":"https://github.com/sjgitty/riscv-dbg.git","svn_url":"https://github.com/sjgitty/riscv-dbg","homepage":null,"size":186,"stargazers_count":0,"watchers_count":0,"language":"SystemVerilog","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp-platform:pulpissimo_integration","ref":"pulpissimo_integration","sha":"a736e00fe8110f4440e456e101c3e797e891d9bb","user":{"login":"pulp-platform","id":14332106,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzMyMTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14332106?v=4","gravatar_id":"","url":"https://api.github.com/users/pulp-platform","html_url":"https://github.com/pulp-platform","followers_url":"https://api.github.com/users/pulp-platform/followers","following_url":"https://api.github.com/users/pulp-platform/following{/other_user}","gists_url":"https://api.github.com/users/pulp-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp-platform/subscriptions","organizations_url":"https://api.github.com/users/pulp-platform/orgs","repos_url":"https://api.github.com/users/pulp-platform/repos","events_url":"https://api.github.com/users/pulp-platform/events{/privacy}","received_events_url":"https://api.github.com/users/pulp-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":167359198,"node_id":"MDEwOlJlcG9zaXRvcnkxNjczNTkxOTg=","name":"riscv-dbg","full_name":"pulp-platform/riscv-dbg","private":false,"owner":{"login":"pulp-platform","id":14332106,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzMyMTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14332106?v=4","gravatar_id":"","url":"https://api.github.com/users/pulp-platform","html_url":"https://github.com/pulp-platform","followers_url":"https://api.github.com/users/pulp-platform/followers","following_url":"https://api.github.com/users/pulp-platform/following{/other_user}","gists_url":"https://api.github.com/users/pulp-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp-platform/subscriptions","organizations_url":"https://api.github.com/users/pulp-platform/orgs","repos_url":"https://api.github.com/users/pulp-platform/repos","events_url":"https://api.github.com/users/pulp-platform/events{/privacy}","received_events_url":"https://api.github.com/users/pulp-platform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pulp-platform/riscv-dbg","description":"RISC-V Debug Support for our PULP Cores","fork":false,"url":"https://api.github.com/repos/pulp-platform/riscv-dbg","forks_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/forks","keys_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/teams","hooks_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/hooks","issue_events_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues/events{/number}","events_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/events","assignees_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/assignees{/user}","branches_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/branches{/branch}","tags_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/tags","blobs_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/languages","stargazers_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/stargazers","contributors_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/contributors","subscribers_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/subscribers","subscription_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/subscription","commits_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/contents/{+path}","compare_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/merges","archive_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/downloads","issues_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues{/number}","pulls_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/labels{/name}","releases_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/releases{/id}","deployments_url":"https://api.github.com/repos/pulp-platform/riscv-dbg/deployments","created_at":"2019-01-24T11:49:31Z","updated_at":"2019-03-22T18:33:16Z","pushed_at":"2019-05-14T21:19:29Z","git_url":"git://github.com/pulp-platform/riscv-dbg.git","ssh_url":"git@github.com:pulp-platform/riscv-dbg.git","clone_url":"https://github.com/pulp-platform/riscv-dbg.git","svn_url":"https://github.com/pulp-platform/riscv-dbg","homepage":null,"size":186,"stargazers_count":3,"watchers_count":3,"language":"SystemVerilog","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15"},"html":{"href":"https://github.com/pulp-platform/riscv-dbg/pull/15"},"issue":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues/15"},"comments":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/pulp-platform/riscv-dbg/statuses/d1b59f9ad06be68f7e8f86d08a155e0cb18b6e72"}},"author_association":"NONE"}}
{"actor":{"display_login":"sjgitty"}}