{"action":"created","issue":{"url":"https://api.github.com/repos/sofa-framework/sofa/issues/1168","repository_url":"https://api.github.com/repos/sofa-framework/sofa","labels_url":"https://api.github.com/repos/sofa-framework/sofa/issues/1168/labels{/name}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/issues/1168/comments","events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/1168/events","html_url":"https://github.com/sofa-framework/sofa/pull/1168","id":501930891,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MTA2OTE0","number":1168,"title":"[SofaKernel] Make componentState a real data field","user":{"login":"damienmarchal","id":12644882,"node_id":"MDQ6VXNlcjEyNjQ0ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/12644882?v=4","gravatar_id":"","url":"https://api.github.com/users/damienmarchal","html_url":"https://github.com/damienmarchal","followers_url":"https://api.github.com/users/damienmarchal/followers","following_url":"https://api.github.com/users/damienmarchal/following{/other_user}","gists_url":"https://api.github.com/users/damienmarchal/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmarchal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmarchal/subscriptions","organizations_url":"https://api.github.com/users/damienmarchal/orgs","repos_url":"https://api.github.com/users/damienmarchal/repos","events_url":"https://api.github.com/users/damienmarchal/events{/privacy}","received_events_url":"https://api.github.com/users/damienmarchal/received_events","type":"User","site_admin":false},"labels":[{"id":385295642,"node_id":"MDU6TGFiZWwzODUyOTU2NDI=","url":"https://api.github.com/repos/sofa-framework/sofa/labels/enhancement","name":"enhancement","color":"98e698","default":true},{"id":596999679,"node_id":"MDU6TGFiZWw1OTY5OTk2Nzk=","url":"https://api.github.com/repos/sofa-framework/sofa/labels/status:%20to%20review","name":"status: to review","color":"BEBEBE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-10-03T08:42:58Z","updated_at":"2019-10-07T16:48:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sofa-framework/sofa/pulls/1168","html_url":"https://github.com/sofa-framework/sofa/pull/1168","diff_url":"https://github.com/sofa-framework/sofa/pull/1168.diff","patch_url":"https://github.com/sofa-framework/sofa/pull/1168.patch"},"body":"Currently in Sofa the attribute m_componentstate is not a data field. By transformating it into a data field allows different components to track each-other state (and changes) through the data tracker's mechanisms. \r\n\r\nThe implementation is focus on minimize the amount of change and is not breaking.  \r\nThere is a basic test for the feature.\r\nThere is a non-breaking deprecation mechanism implemented to ease the renaming of m_componentstate to d_componentstate.\r\n______________________________________________________\r\n<!--- Please leave this at the end of your message -->\r\nThis PR: \r\n- [ ] builds with SUCCESS for all platforms on the CI.\r\n- [ ] does not generate new warnings.\r\n- [ ] does not generate new unit test failures.\r\n- [ ] does not generate new scene test failures.\r\n- [ ] does not break API compatibility.\r\n- [ ] is more than 1 week old (or has fast-merge label).\r\n\r\n**Reviewers will merge only if all these checks are true.**\r\n"},"comment":{"url":"https://api.github.com/repos/sofa-framework/sofa/issues/comments/539103791","html_url":"https://github.com/sofa-framework/sofa/pull/1168#issuecomment-539103791","issue_url":"https://api.github.com/repos/sofa-framework/sofa/issues/1168","id":539103791,"node_id":"MDEyOklzc3VlQ29tbWVudDUzOTEwMzc5MQ==","user":{"login":"damienmarchal","id":12644882,"node_id":"MDQ6VXNlcjEyNjQ0ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/12644882?v=4","gravatar_id":"","url":"https://api.github.com/users/damienmarchal","html_url":"https://github.com/damienmarchal","followers_url":"https://api.github.com/users/damienmarchal/followers","following_url":"https://api.github.com/users/damienmarchal/following{/other_user}","gists_url":"https://api.github.com/users/damienmarchal/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmarchal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmarchal/subscriptions","organizations_url":"https://api.github.com/users/damienmarchal/orgs","repos_url":"https://api.github.com/users/damienmarchal/repos","events_url":"https://api.github.com/users/damienmarchal/events{/privacy}","received_events_url":"https://api.github.com/users/damienmarchal/received_events","type":"User","site_admin":false},"created_at":"2019-10-07T16:48:46Z","updated_at":"2019-10-07T16:48:46Z","author_association":"CONTRIBUTOR","body":"[ci-build][with-scene-tests][with-regression-tests]"}}
{"actor":{"display_login":"damienmarchal"}}