{"action":"opened","number":450,"pull_request":{"url":"https://api.github.com/repos/google-research/bert/pulls/450","id":255457382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NDU3Mzgy","html_url":"https://github.com/google-research/bert/pull/450","diff_url":"https://github.com/google-research/bert/pull/450.diff","patch_url":"https://github.com/google-research/bert/pull/450.patch","issue_url":"https://api.github.com/repos/google-research/bert/issues/450","number":450,"state":"open","locked":false,"title":"Fix unnecessary reloading of the pre-trained model in EVAL and PREDICT","user":{"login":"peidaqi","id":18495787,"node_id":"MDQ6VXNlcjE4NDk1Nzg3","avatar_url":"https://avatars0.githubusercontent.com/u/18495787?v=4","gravatar_id":"","url":"https://api.github.com/users/peidaqi","html_url":"https://github.com/peidaqi","followers_url":"https://api.github.com/users/peidaqi/followers","following_url":"https://api.github.com/users/peidaqi/following{/other_user}","gists_url":"https://api.github.com/users/peidaqi/gists{/gist_id}","starred_url":"https://api.github.com/users/peidaqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peidaqi/subscriptions","organizations_url":"https://api.github.com/users/peidaqi/orgs","repos_url":"https://api.github.com/users/peidaqi/repos","events_url":"https://api.github.com/users/peidaqi/events{/privacy}","received_events_url":"https://api.github.com/users/peidaqi/received_events","type":"User","site_admin":false},"body":"In the current implementation, the pre-trained model will be loaded not only in TRAIN, but also in EVAL and PREDICT.\r\nThis is not necessary as the weights will be overwritten anyway when the Estimator framework loads previous check points from TRAIN in EVAL and PREDICT phases.\r\n\r\nA RunHook was used to provide a clean solution to load the pre-trained model, as in this way the model_fn() is left with only the graph construction code. By passing the RunHook to estimator.train(), it ensures the pre-trained model gets loaded only during TRAIN. Since the RunHook will run on CPU, there's no longer needs for scaffolding, either.","created_at":"2019-02-22T16:36:02Z","updated_at":"2019-02-22T16:36:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google-research/bert/pulls/450/commits","review_comments_url":"https://api.github.com/repos/google-research/bert/pulls/450/comments","review_comment_url":"https://api.github.com/repos/google-research/bert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google-research/bert/issues/450/comments","statuses_url":"https://api.github.com/repos/google-research/bert/statuses/81d5352f05a19378a4f6a89934ef4727ceafd3cf","head":{"label":"peidaqi:master","ref":"master","sha":"81d5352f05a19378a4f6a89934ef4727ceafd3cf","user":{"login":"peidaqi","id":18495787,"node_id":"MDQ6VXNlcjE4NDk1Nzg3","avatar_url":"https://avatars0.githubusercontent.com/u/18495787?v=4","gravatar_id":"","url":"https://api.github.com/users/peidaqi","html_url":"https://github.com/peidaqi","followers_url":"https://api.github.com/users/peidaqi/followers","following_url":"https://api.github.com/users/peidaqi/following{/other_user}","gists_url":"https://api.github.com/users/peidaqi/gists{/gist_id}","starred_url":"https://api.github.com/users/peidaqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peidaqi/subscriptions","organizations_url":"https://api.github.com/users/peidaqi/orgs","repos_url":"https://api.github.com/users/peidaqi/repos","events_url":"https://api.github.com/users/peidaqi/events{/privacy}","received_events_url":"https://api.github.com/users/peidaqi/received_events","type":"User","site_admin":false},"repo":{"id":172094320,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIwOTQzMjA=","name":"bert","full_name":"peidaqi/bert","private":false,"owner":{"login":"peidaqi","id":18495787,"node_id":"MDQ6VXNlcjE4NDk1Nzg3","avatar_url":"https://avatars0.githubusercontent.com/u/18495787?v=4","gravatar_id":"","url":"https://api.github.com/users/peidaqi","html_url":"https://github.com/peidaqi","followers_url":"https://api.github.com/users/peidaqi/followers","following_url":"https://api.github.com/users/peidaqi/following{/other_user}","gists_url":"https://api.github.com/users/peidaqi/gists{/gist_id}","starred_url":"https://api.github.com/users/peidaqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peidaqi/subscriptions","organizations_url":"https://api.github.com/users/peidaqi/orgs","repos_url":"https://api.github.com/users/peidaqi/repos","events_url":"https://api.github.com/users/peidaqi/events{/privacy}","received_events_url":"https://api.github.com/users/peidaqi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/peidaqi/bert","description":"TensorFlow code and pre-trained models for BERT","fork":true,"url":"https://api.github.com/repos/peidaqi/bert","forks_url":"https://api.github.com/repos/peidaqi/bert/forks","keys_url":"https://api.github.com/repos/peidaqi/bert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peidaqi/bert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peidaqi/bert/teams","hooks_url":"https://api.github.com/repos/peidaqi/bert/hooks","issue_events_url":"https://api.github.com/repos/peidaqi/bert/issues/events{/number}","events_url":"https://api.github.com/repos/peidaqi/bert/events","assignees_url":"https://api.github.com/repos/peidaqi/bert/assignees{/user}","branches_url":"https://api.github.com/repos/peidaqi/bert/branches{/branch}","tags_url":"https://api.github.com/repos/peidaqi/bert/tags","blobs_url":"https://api.github.com/repos/peidaqi/bert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peidaqi/bert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peidaqi/bert/git/refs{/sha}","trees_url":"https://api.github.com/repos/peidaqi/bert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peidaqi/bert/statuses/{sha}","languages_url":"https://api.github.com/repos/peidaqi/bert/languages","stargazers_url":"https://api.github.com/repos/peidaqi/bert/stargazers","contributors_url":"https://api.github.com/repos/peidaqi/bert/contributors","subscribers_url":"https://api.github.com/repos/peidaqi/bert/subscribers","subscription_url":"https://api.github.com/repos/peidaqi/bert/subscription","commits_url":"https://api.github.com/repos/peidaqi/bert/commits{/sha}","git_commits_url":"https://api.github.com/repos/peidaqi/bert/git/commits{/sha}","comments_url":"https://api.github.com/repos/peidaqi/bert/comments{/number}","issue_comment_url":"https://api.github.com/repos/peidaqi/bert/issues/comments{/number}","contents_url":"https://api.github.com/repos/peidaqi/bert/contents/{+path}","compare_url":"https://api.github.com/repos/peidaqi/bert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peidaqi/bert/merges","archive_url":"https://api.github.com/repos/peidaqi/bert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peidaqi/bert/downloads","issues_url":"https://api.github.com/repos/peidaqi/bert/issues{/number}","pulls_url":"https://api.github.com/repos/peidaqi/bert/pulls{/number}","milestones_url":"https://api.github.com/repos/peidaqi/bert/milestones{/number}","notifications_url":"https://api.github.com/repos/peidaqi/bert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peidaqi/bert/labels{/name}","releases_url":"https://api.github.com/repos/peidaqi/bert/releases{/id}","deployments_url":"https://api.github.com/repos/peidaqi/bert/deployments","created_at":"2019-02-22T16:01:55Z","updated_at":"2019-02-22T16:26:31Z","pushed_at":"2019-02-22T16:26:25Z","git_url":"git://github.com/peidaqi/bert.git","ssh_url":"git@github.com:peidaqi/bert.git","clone_url":"https://github.com/peidaqi/bert.git","svn_url":"https://github.com/peidaqi/bert","homepage":"https://arxiv.org/abs/1810.04805","size":289,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google-research:master","ref":"master","sha":"ffbda2a1aafe530525212d13194cc84d92ed0313","user":{"login":"google-research","id":43830688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODMwNjg4","avatar_url":"https://avatars1.githubusercontent.com/u/43830688?v=4","gravatar_id":"","url":"https://api.github.com/users/google-research","html_url":"https://github.com/google-research","followers_url":"https://api.github.com/users/google-research/followers","following_url":"https://api.github.com/users/google-research/following{/other_user}","gists_url":"https://api.github.com/users/google-research/gists{/gist_id}","starred_url":"https://api.github.com/users/google-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google-research/subscriptions","organizations_url":"https://api.github.com/users/google-research/orgs","repos_url":"https://api.github.com/users/google-research/repos","events_url":"https://api.github.com/users/google-research/events{/privacy}","received_events_url":"https://api.github.com/users/google-research/received_events","type":"Organization","site_admin":false},"repo":{"id":154747577,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ3NDc1Nzc=","name":"bert","full_name":"google-research/bert","private":false,"owner":{"login":"google-research","id":43830688,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODMwNjg4","avatar_url":"https://avatars1.githubusercontent.com/u/43830688?v=4","gravatar_id":"","url":"https://api.github.com/users/google-research","html_url":"https://github.com/google-research","followers_url":"https://api.github.com/users/google-research/followers","following_url":"https://api.github.com/users/google-research/following{/other_user}","gists_url":"https://api.github.com/users/google-research/gists{/gist_id}","starred_url":"https://api.github.com/users/google-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google-research/subscriptions","organizations_url":"https://api.github.com/users/google-research/orgs","repos_url":"https://api.github.com/users/google-research/repos","events_url":"https://api.github.com/users/google-research/events{/privacy}","received_events_url":"https://api.github.com/users/google-research/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google-research/bert","description":"TensorFlow code and pre-trained models for BERT","fork":false,"url":"https://api.github.com/repos/google-research/bert","forks_url":"https://api.github.com/repos/google-research/bert/forks","keys_url":"https://api.github.com/repos/google-research/bert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google-research/bert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google-research/bert/teams","hooks_url":"https://api.github.com/repos/google-research/bert/hooks","issue_events_url":"https://api.github.com/repos/google-research/bert/issues/events{/number}","events_url":"https://api.github.com/repos/google-research/bert/events","assignees_url":"https://api.github.com/repos/google-research/bert/assignees{/user}","branches_url":"https://api.github.com/repos/google-research/bert/branches{/branch}","tags_url":"https://api.github.com/repos/google-research/bert/tags","blobs_url":"https://api.github.com/repos/google-research/bert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google-research/bert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google-research/bert/git/refs{/sha}","trees_url":"https://api.github.com/repos/google-research/bert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google-research/bert/statuses/{sha}","languages_url":"https://api.github.com/repos/google-research/bert/languages","stargazers_url":"https://api.github.com/repos/google-research/bert/stargazers","contributors_url":"https://api.github.com/repos/google-research/bert/contributors","subscribers_url":"https://api.github.com/repos/google-research/bert/subscribers","subscription_url":"https://api.github.com/repos/google-research/bert/subscription","commits_url":"https://api.github.com/repos/google-research/bert/commits{/sha}","git_commits_url":"https://api.github.com/repos/google-research/bert/git/commits{/sha}","comments_url":"https://api.github.com/repos/google-research/bert/comments{/number}","issue_comment_url":"https://api.github.com/repos/google-research/bert/issues/comments{/number}","contents_url":"https://api.github.com/repos/google-research/bert/contents/{+path}","compare_url":"https://api.github.com/repos/google-research/bert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google-research/bert/merges","archive_url":"https://api.github.com/repos/google-research/bert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google-research/bert/downloads","issues_url":"https://api.github.com/repos/google-research/bert/issues{/number}","pulls_url":"https://api.github.com/repos/google-research/bert/pulls{/number}","milestones_url":"https://api.github.com/repos/google-research/bert/milestones{/number}","notifications_url":"https://api.github.com/repos/google-research/bert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google-research/bert/labels{/name}","releases_url":"https://api.github.com/repos/google-research/bert/releases{/id}","deployments_url":"https://api.github.com/repos/google-research/bert/deployments","created_at":"2018-10-25T22:57:34Z","updated_at":"2019-02-22T15:54:42Z","pushed_at":"2019-02-21T23:49:53Z","git_url":"git://github.com/google-research/bert.git","ssh_url":"git@github.com:google-research/bert.git","clone_url":"https://github.com/google-research/bert.git","svn_url":"https://github.com/google-research/bert","homepage":"https://arxiv.org/abs/1810.04805","size":289,"stargazers_count":12342,"watchers_count":12342,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2594,"mirror_url":null,"archived":false,"open_issues_count":194,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2594,"open_issues":194,"watchers":12342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google-research/bert/pulls/450"},"html":{"href":"https://github.com/google-research/bert/pull/450"},"issue":{"href":"https://api.github.com/repos/google-research/bert/issues/450"},"comments":{"href":"https://api.github.com/repos/google-research/bert/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/google-research/bert/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/google-research/bert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google-research/bert/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/google-research/bert/statuses/81d5352f05a19378a4f6a89934ef4727ceafd3cf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":28,"deletions":31,"changed_files":1}}
{"actor":{"display_login":"peidaqi"}}