{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/335185491","pull_request_review_id":302208396,"id":335185491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTE4NTQ5MQ==","diff_hunk":"@@ -320,29 +416,29 @@ internal string GetDescription()\n         {\n             if (NodeNature == Nature.Deprecated)\n             {\n-                if (string.IsNullOrEmpty(LegacyAssembly))\n+                if (string.IsNullOrEmpty(FunctionName))\n                 {\n-                    const string format = \"Node of type '{0}' is now deprecated\";\n-                    return string.Format(format, LegacyNodeName);\n+                    const string format = \"Node of type '{0}',from assembly '{1}', is now deprecated.\";\n+                    return string.Format(format, TypeName, LegacyAssembly);\n                 }\n                 else\n                 {\n-                    const string format = \"Node of type '{0}' ({1}) is now deprecated\";\n-                    return string.Format(format, LegacyNodeName, LegacyAssembly);\n+                    const string format = \"Node '{0}' is now deprecated\";\n+                    return string.Format(format, FunctionName);\n                 }\n             }\n \n             if (NodeNature == Nature.Unresolved)\n             {\n-                if (string.IsNullOrEmpty(LegacyAssembly))\n+                if (string.IsNullOrEmpty(FunctionName))\n                 {\n-                    const string format = \"Node of type '{0}' cannot be resolved\";\n-                    return string.Format(format, LegacyNodeName);\n+                    const string format = \"Node of type '{0}', from assembly '{1}', cannot be resolved.\";\n+                    return string.Format(format, TypeName, LegacyAssembly);\n                 }\n                 else\n                 {\n-                    const string format = \"Node of type '{0}' ({1}) cannot be resolved\";\n-                    return string.Format(format, LegacyNodeName, LegacyAssembly);","path":"src/DynamoCore/Graph/Nodes/DummyNode.cs","position":144,"original_position":144,"commit_id":"69d0cab6a2cee004d6a841dc359f09ed4e3e573b","original_commit_id":"69d0cab6a2cee004d6a841dc359f09ed4e3e573b","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"body":"is `LegacyNodeName` used anywhere anymore? If not maybe you want to obsolete it?","created_at":"2019-10-15T21:26:48Z","updated_at":"2019-10-15T21:26:48Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/10051#discussion_r335185491","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/335185491"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/10051#discussion_r335185491"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051","id":327056308,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MDU2MzA4","html_url":"https://github.com/DynamoDS/Dynamo/pull/10051","diff_url":"https://github.com/DynamoDS/Dynamo/pull/10051.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/10051.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/10051","number":10051,"state":"open","locked":false,"title":"DYN-2149 DummyNode unresolved node messages are confusing","user":{"login":"reddyashish","id":43763136,"node_id":"MDQ6VXNlcjQzNzYzMTM2","avatar_url":"https://avatars0.githubusercontent.com/u/43763136?v=4","gravatar_id":"","url":"https://api.github.com/users/reddyashish","html_url":"https://github.com/reddyashish","followers_url":"https://api.github.com/users/reddyashish/followers","following_url":"https://api.github.com/users/reddyashish/following{/other_user}","gists_url":"https://api.github.com/users/reddyashish/gists{/gist_id}","starred_url":"https://api.github.com/users/reddyashish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddyashish/subscriptions","organizations_url":"https://api.github.com/users/reddyashish/orgs","repos_url":"https://api.github.com/users/reddyashish/repos","events_url":"https://api.github.com/users/reddyashish/events{/privacy}","received_events_url":"https://api.github.com/users/reddyashish/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nThis PR is to improve the warning message shown on the unresolved dummy nodes. \r\nTask: https://jira.autodesk.com/browse/DYN-2149\r\n\r\nThe description of the node is shown when the user hovers on the node. When the node is of type 'unresolved', a warning message is shown that specifies the function name. \r\n\r\nBefore this change, the message was:\r\n\r\n![previous](https://user-images.githubusercontent.com/43763136/66630091-8135f500-ebd1-11e9-826e-03032f71acb4.png)\r\n\r\nAfter this change, \r\n\r\n<img width=\"348\" alt=\"Screen Shot 2019-10-11 at 2 48 16 AM\" src=\"https://user-images.githubusercontent.com/43763136/66630154-9d399680-ebd1-11e9-8e18-cab7e01cea2c.png\">\r\n\r\nThe assembly name is not stored in the object so instead we show the whole function name(along with the namespace).\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [x] All tests pass using the self-service CI.\r\n- [x] Snapshot of UI changes, if any.\r\n- [ ] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n@DynamoDS/dynamo \r\n\r\n\r\n\r\n","created_at":"2019-10-11T06:52:51Z","updated_at":"2019-10-15T21:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5318f2743f0f05fd467af908790405c4fd64e20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/10051/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/69d0cab6a2cee004d6a841dc359f09ed4e3e573b","head":{"label":"reddyashish:master","ref":"master","sha":"69d0cab6a2cee004d6a841dc359f09ed4e3e573b","user":{"login":"reddyashish","id":43763136,"node_id":"MDQ6VXNlcjQzNzYzMTM2","avatar_url":"https://avatars0.githubusercontent.com/u/43763136?v=4","gravatar_id":"","url":"https://api.github.com/users/reddyashish","html_url":"https://github.com/reddyashish","followers_url":"https://api.github.com/users/reddyashish/followers","following_url":"https://api.github.com/users/reddyashish/following{/other_user}","gists_url":"https://api.github.com/users/reddyashish/gists{/gist_id}","starred_url":"https://api.github.com/users/reddyashish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddyashish/subscriptions","organizations_url":"https://api.github.com/users/reddyashish/orgs","repos_url":"https://api.github.com/users/reddyashish/repos","events_url":"https://api.github.com/users/reddyashish/events{/privacy}","received_events_url":"https://api.github.com/users/reddyashish/received_events","type":"User","site_admin":false},"repo":{"id":156452248,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0NTIyNDg=","name":"Dynamo","full_name":"reddyashish/Dynamo","private":false,"owner":{"login":"reddyashish","id":43763136,"node_id":"MDQ6VXNlcjQzNzYzMTM2","avatar_url":"https://avatars0.githubusercontent.com/u/43763136?v=4","gravatar_id":"","url":"https://api.github.com/users/reddyashish","html_url":"https://github.com/reddyashish","followers_url":"https://api.github.com/users/reddyashish/followers","following_url":"https://api.github.com/users/reddyashish/following{/other_user}","gists_url":"https://api.github.com/users/reddyashish/gists{/gist_id}","starred_url":"https://api.github.com/users/reddyashish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddyashish/subscriptions","organizations_url":"https://api.github.com/users/reddyashish/orgs","repos_url":"https://api.github.com/users/reddyashish/repos","events_url":"https://api.github.com/users/reddyashish/events{/privacy}","received_events_url":"https://api.github.com/users/reddyashish/received_events","type":"User","site_admin":false},"html_url":"https://github.com/reddyashish/Dynamo","description":"Open Source Graphical Programming for Design","fork":true,"url":"https://api.github.com/repos/reddyashish/Dynamo","forks_url":"https://api.github.com/repos/reddyashish/Dynamo/forks","keys_url":"https://api.github.com/repos/reddyashish/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddyashish/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddyashish/Dynamo/teams","hooks_url":"https://api.github.com/repos/reddyashish/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/reddyashish/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/reddyashish/Dynamo/events","assignees_url":"https://api.github.com/repos/reddyashish/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/reddyashish/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/reddyashish/Dynamo/tags","blobs_url":"https://api.github.com/repos/reddyashish/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddyashish/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddyashish/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddyashish/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddyashish/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/reddyashish/Dynamo/languages","stargazers_url":"https://api.github.com/repos/reddyashish/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/reddyashish/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/reddyashish/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/reddyashish/Dynamo/subscription","commits_url":"https://api.github.com/repos/reddyashish/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddyashish/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddyashish/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddyashish/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddyashish/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/reddyashish/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddyashish/Dynamo/merges","archive_url":"https://api.github.com/repos/reddyashish/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddyashish/Dynamo/downloads","issues_url":"https://api.github.com/repos/reddyashish/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/reddyashish/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/reddyashish/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/reddyashish/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddyashish/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/reddyashish/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/reddyashish/Dynamo/deployments","created_at":"2018-11-06T21:46:32Z","updated_at":"2019-10-15T18:05:54Z","pushed_at":"2019-10-15T18:05:51Z","git_url":"git://github.com/reddyashish/Dynamo.git","ssh_url":"git@github.com:reddyashish/Dynamo.git","clone_url":"https://github.com/reddyashish/Dynamo.git","svn_url":"https://github.com/reddyashish/Dynamo","homepage":"http://dynamobim.org","size":1477460,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"01fdc4f60626bf87056ac60cb8d64279de93bffd","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk1MTc5","name":"Dynamo","full_name":"DynamoDS/Dynamo","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/Dynamo","description":"Open Source Graphical Programming for Design","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2019-10-15T04:21:38Z","pushed_at":"2019-10-15T19:21:58Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1480077,"stargazers_count":783,"watchers_count":783,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":427,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":385,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":427,"open_issues":385,"watchers":783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/10051"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/10051"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/10051/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/10051/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/69d0cab6a2cee004d6a841dc359f09ed4e3e573b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mjkkirschner"}}