{"action":"created","comment":{"url":"https://api.github.com/repos/SymbiFlow/yosys/pulls/comments/343626914","pull_request_review_id":313307296,"id":343626914,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzYyNjkxNA==","diff_hunk":"@@ -0,0 +1,212 @@\n+/*\n+ *  yosys -- Yosys Open SYnthesis Suite\n+ *\n+ *  Copyright (C) 2012  Clifford Wolf <clifford@clifford.at>\n+ *\n+ *  Permission to use, copy, modify, and/or distribute this software for any\n+ *  purpose with or without fee is hereby granted, provided that the above\n+ *  copyright notice and this permission notice appear in all copies.\n+ *\n+ *  THE SOFTWARE IS PROVIDED \"AS IS\" AND THE AUTHOR DISCLAIMS ALL WARRANTIES\n+ *  WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF\n+ *  MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR\n+ *  ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES\n+ *  WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN\n+ *  ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF\n+ *  OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.\n+ *\n+ *  ---\n+ *\n+ *   XDC commands + FASM backend.\n+ *\n+ *   This plugin operates on the existing design and modifies its structure\n+ *   based on the content of the XDC (Xilinx Design Constraints) file.\n+ *   Since the XDC file consists of Tcl commands it is read using Yosys's\n+ *   tcl command and processed by the new XDC commands imported to the\n+ *   Tcl interpreter.\n+ */\n+\n+#include \"kernel/register.h\"\n+#include \"kernel/rtlil.h\"\n+#include \"kernel/log.h\"\n+\n+USING_YOSYS_NAMESPACE\n+PRIVATE_NAMESPACE_BEGIN\n+\n+int current_iobank = 0;\n+\n+// Coordinates of HCLK_IOI tiles associated with a specified bank\n+// This is very part specific and is for Arty's xc7a35tcsg324 part\n+std::unordered_map<int, std::string> bank_tiles = {\n+\t{14, \"X1Y26\"},","path":"examples/arty/xdc-plugin/xdc.cc","position":41,"original_position":41,"commit_id":"eddcec449fabcba42f73c13e130be6b81ff4ae0d","original_commit_id":"eddcec449fabcba42f73c13e130be6b81ff4ae0d","user":{"login":"tmichalak","id":38781500,"node_id":"MDQ6VXNlcjM4NzgxNTAw","avatar_url":"https://avatars1.githubusercontent.com/u/38781500?v=4","gravatar_id":"","url":"https://api.github.com/users/tmichalak","html_url":"https://github.com/tmichalak","followers_url":"https://api.github.com/users/tmichalak/followers","following_url":"https://api.github.com/users/tmichalak/following{/other_user}","gists_url":"https://api.github.com/users/tmichalak/gists{/gist_id}","starred_url":"https://api.github.com/users/tmichalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmichalak/subscriptions","organizations_url":"https://api.github.com/users/tmichalak/orgs","repos_url":"https://api.github.com/users/tmichalak/repos","events_url":"https://api.github.com/users/tmichalak/events{/privacy}","received_events_url":"https://api.github.com/users/tmichalak/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-11-07T12:34:36Z","updated_at":"2019-11-07T12:34:37Z","html_url":"https://github.com/SymbiFlow/yosys/pull/44#discussion_r343626914","pull_request_url":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SymbiFlow/yosys/pulls/comments/343626914"},"html":{"href":"https://github.com/SymbiFlow/yosys/pull/44#discussion_r343626914"},"pull_request":{"href":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44"}},"in_reply_to_id":342680122},"pull_request":{"url":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44","id":336757080,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NzU3MDgw","html_url":"https://github.com/SymbiFlow/yosys/pull/44","diff_url":"https://github.com/SymbiFlow/yosys/pull/44.diff","patch_url":"https://github.com/SymbiFlow/yosys/pull/44.patch","issue_url":"https://api.github.com/repos/SymbiFlow/yosys/issues/44","number":44,"state":"open","locked":false,"title":"WIP: Initial version of the xdc plugin support","user":{"login":"tmichalak","id":38781500,"node_id":"MDQ6VXNlcjM4NzgxNTAw","avatar_url":"https://avatars1.githubusercontent.com/u/38781500?v=4","gravatar_id":"","url":"https://api.github.com/users/tmichalak","html_url":"https://github.com/tmichalak","followers_url":"https://api.github.com/users/tmichalak/followers","following_url":"https://api.github.com/users/tmichalak/following{/other_user}","gists_url":"https://api.github.com/users/tmichalak/gists{/gist_id}","starred_url":"https://api.github.com/users/tmichalak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmichalak/subscriptions","organizations_url":"https://api.github.com/users/tmichalak/orgs","repos_url":"https://api.github.com/users/tmichalak/repos","events_url":"https://api.github.com/users/tmichalak/events{/privacy}","received_events_url":"https://api.github.com/users/tmichalak/received_events","type":"User","site_admin":false},"body":"The initial version of the plugin is capable of reading an XDC file with the INTERNAL_VREF settings and generating a FASM file with the features that we currently have in our database that are related to the VREF settings per bank.\r\nThis plugin operates on the existing design and modifies its structure based on the content of the XDC (Xilinx Design Constraints) file.\r\nSince the XDC file consists of Tcl commands it is read using Yosys's tcl command and processed by the new XDC commands imported to the Tcl interpreter.\r\n\r\nThe plugins for yosys have a separate repository (https://github.com/YosysHQ/yosys-plugins).\r\nHowever we could simply add the plugin to the symbiflow-arch-defs.\r\nWe also need to add the concatenation step to symbiflow-arch-defs.\r\n","created_at":"2019-11-05T12:38:03Z","updated_at":"2019-11-07T12:34:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c4751b5465797d515dab21e23c9fe2085b1bd65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44/commits","review_comments_url":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44/comments","review_comment_url":"https://api.github.com/repos/SymbiFlow/yosys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SymbiFlow/yosys/issues/44/comments","statuses_url":"https://api.github.com/repos/SymbiFlow/yosys/statuses/eddcec449fabcba42f73c13e130be6b81ff4ae0d","head":{"label":"antmicro:xdc_support","ref":"xdc_support","sha":"eddcec449fabcba42f73c13e130be6b81ff4ae0d","user":{"login":"antmicro","id":927785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzc4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/927785?v=4","gravatar_id":"","url":"https://api.github.com/users/antmicro","html_url":"https://github.com/antmicro","followers_url":"https://api.github.com/users/antmicro/followers","following_url":"https://api.github.com/users/antmicro/following{/other_user}","gists_url":"https://api.github.com/users/antmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/antmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmicro/subscriptions","organizations_url":"https://api.github.com/users/antmicro/orgs","repos_url":"https://api.github.com/users/antmicro/repos","events_url":"https://api.github.com/users/antmicro/events{/privacy}","received_events_url":"https://api.github.com/users/antmicro/received_events","type":"Organization","site_admin":false},"repo":{"id":48416004,"node_id":"MDEwOlJlcG9zaXRvcnk0ODQxNjAwNA==","name":"yosys","full_name":"antmicro/yosys","private":false,"owner":{"login":"antmicro","id":927785,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNzc4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/927785?v=4","gravatar_id":"","url":"https://api.github.com/users/antmicro","html_url":"https://github.com/antmicro","followers_url":"https://api.github.com/users/antmicro/followers","following_url":"https://api.github.com/users/antmicro/following{/other_user}","gists_url":"https://api.github.com/users/antmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/antmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmicro/subscriptions","organizations_url":"https://api.github.com/users/antmicro/orgs","repos_url":"https://api.github.com/users/antmicro/repos","events_url":"https://api.github.com/users/antmicro/events{/privacy}","received_events_url":"https://api.github.com/users/antmicro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/antmicro/yosys","description":"Yosys Open SYnthesis Suite","fork":true,"url":"https://api.github.com/repos/antmicro/yosys","forks_url":"https://api.github.com/repos/antmicro/yosys/forks","keys_url":"https://api.github.com/repos/antmicro/yosys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antmicro/yosys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antmicro/yosys/teams","hooks_url":"https://api.github.com/repos/antmicro/yosys/hooks","issue_events_url":"https://api.github.com/repos/antmicro/yosys/issues/events{/number}","events_url":"https://api.github.com/repos/antmicro/yosys/events","assignees_url":"https://api.github.com/repos/antmicro/yosys/assignees{/user}","branches_url":"https://api.github.com/repos/antmicro/yosys/branches{/branch}","tags_url":"https://api.github.com/repos/antmicro/yosys/tags","blobs_url":"https://api.github.com/repos/antmicro/yosys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antmicro/yosys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antmicro/yosys/git/refs{/sha}","trees_url":"https://api.github.com/repos/antmicro/yosys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antmicro/yosys/statuses/{sha}","languages_url":"https://api.github.com/repos/antmicro/yosys/languages","stargazers_url":"https://api.github.com/repos/antmicro/yosys/stargazers","contributors_url":"https://api.github.com/repos/antmicro/yosys/contributors","subscribers_url":"https://api.github.com/repos/antmicro/yosys/subscribers","subscription_url":"https://api.github.com/repos/antmicro/yosys/subscription","commits_url":"https://api.github.com/repos/antmicro/yosys/commits{/sha}","git_commits_url":"https://api.github.com/repos/antmicro/yosys/git/commits{/sha}","comments_url":"https://api.github.com/repos/antmicro/yosys/comments{/number}","issue_comment_url":"https://api.github.com/repos/antmicro/yosys/issues/comments{/number}","contents_url":"https://api.github.com/repos/antmicro/yosys/contents/{+path}","compare_url":"https://api.github.com/repos/antmicro/yosys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antmicro/yosys/merges","archive_url":"https://api.github.com/repos/antmicro/yosys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antmicro/yosys/downloads","issues_url":"https://api.github.com/repos/antmicro/yosys/issues{/number}","pulls_url":"https://api.github.com/repos/antmicro/yosys/pulls{/number}","milestones_url":"https://api.github.com/repos/antmicro/yosys/milestones{/number}","notifications_url":"https://api.github.com/repos/antmicro/yosys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antmicro/yosys/labels{/name}","releases_url":"https://api.github.com/repos/antmicro/yosys/releases{/id}","deployments_url":"https://api.github.com/repos/antmicro/yosys/deployments","created_at":"2015-12-22T07:00:09Z","updated_at":"2019-05-16T12:26:43Z","pushed_at":"2019-11-05T12:29:15Z","git_url":"git://github.com/antmicro/yosys.git","ssh_url":"git@github.com:antmicro/yosys.git","clone_url":"https://github.com/antmicro/yosys.git","svn_url":"https://github.com/antmicro/yosys","homepage":"http://www.clifford.at/yosys/","size":13164,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SymbiFlow:master+wip","ref":"master+wip","sha":"39a9dc5ca4cc346854ec1473794bd12e0284d126","user":{"login":"SymbiFlow","id":34549754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTQ5NzU0","avatar_url":"https://avatars0.githubusercontent.com/u/34549754?v=4","gravatar_id":"","url":"https://api.github.com/users/SymbiFlow","html_url":"https://github.com/SymbiFlow","followers_url":"https://api.github.com/users/SymbiFlow/followers","following_url":"https://api.github.com/users/SymbiFlow/following{/other_user}","gists_url":"https://api.github.com/users/SymbiFlow/gists{/gist_id}","starred_url":"https://api.github.com/users/SymbiFlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SymbiFlow/subscriptions","organizations_url":"https://api.github.com/users/SymbiFlow/orgs","repos_url":"https://api.github.com/users/SymbiFlow/repos","events_url":"https://api.github.com/users/SymbiFlow/events{/privacy}","received_events_url":"https://api.github.com/users/SymbiFlow/received_events","type":"Organization","site_admin":false},"repo":{"id":115797718,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3OTc3MTg=","name":"yosys","full_name":"SymbiFlow/yosys","private":false,"owner":{"login":"SymbiFlow","id":34549754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTQ5NzU0","avatar_url":"https://avatars0.githubusercontent.com/u/34549754?v=4","gravatar_id":"","url":"https://api.github.com/users/SymbiFlow","html_url":"https://github.com/SymbiFlow","followers_url":"https://api.github.com/users/SymbiFlow/followers","following_url":"https://api.github.com/users/SymbiFlow/following{/other_user}","gists_url":"https://api.github.com/users/SymbiFlow/gists{/gist_id}","starred_url":"https://api.github.com/users/SymbiFlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SymbiFlow/subscriptions","organizations_url":"https://api.github.com/users/SymbiFlow/orgs","repos_url":"https://api.github.com/users/SymbiFlow/repos","events_url":"https://api.github.com/users/SymbiFlow/events{/privacy}","received_events_url":"https://api.github.com/users/SymbiFlow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SymbiFlow/yosys","description":"SymbiFlow WIP changes for Yosys Open SYnthesis Suite","fork":true,"url":"https://api.github.com/repos/SymbiFlow/yosys","forks_url":"https://api.github.com/repos/SymbiFlow/yosys/forks","keys_url":"https://api.github.com/repos/SymbiFlow/yosys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SymbiFlow/yosys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SymbiFlow/yosys/teams","hooks_url":"https://api.github.com/repos/SymbiFlow/yosys/hooks","issue_events_url":"https://api.github.com/repos/SymbiFlow/yosys/issues/events{/number}","events_url":"https://api.github.com/repos/SymbiFlow/yosys/events","assignees_url":"https://api.github.com/repos/SymbiFlow/yosys/assignees{/user}","branches_url":"https://api.github.com/repos/SymbiFlow/yosys/branches{/branch}","tags_url":"https://api.github.com/repos/SymbiFlow/yosys/tags","blobs_url":"https://api.github.com/repos/SymbiFlow/yosys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SymbiFlow/yosys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SymbiFlow/yosys/git/refs{/sha}","trees_url":"https://api.github.com/repos/SymbiFlow/yosys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SymbiFlow/yosys/statuses/{sha}","languages_url":"https://api.github.com/repos/SymbiFlow/yosys/languages","stargazers_url":"https://api.github.com/repos/SymbiFlow/yosys/stargazers","contributors_url":"https://api.github.com/repos/SymbiFlow/yosys/contributors","subscribers_url":"https://api.github.com/repos/SymbiFlow/yosys/subscribers","subscription_url":"https://api.github.com/repos/SymbiFlow/yosys/subscription","commits_url":"https://api.github.com/repos/SymbiFlow/yosys/commits{/sha}","git_commits_url":"https://api.github.com/repos/SymbiFlow/yosys/git/commits{/sha}","comments_url":"https://api.github.com/repos/SymbiFlow/yosys/comments{/number}","issue_comment_url":"https://api.github.com/repos/SymbiFlow/yosys/issues/comments{/number}","contents_url":"https://api.github.com/repos/SymbiFlow/yosys/contents/{+path}","compare_url":"https://api.github.com/repos/SymbiFlow/yosys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SymbiFlow/yosys/merges","archive_url":"https://api.github.com/repos/SymbiFlow/yosys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SymbiFlow/yosys/downloads","issues_url":"https://api.github.com/repos/SymbiFlow/yosys/issues{/number}","pulls_url":"https://api.github.com/repos/SymbiFlow/yosys/pulls{/number}","milestones_url":"https://api.github.com/repos/SymbiFlow/yosys/milestones{/number}","notifications_url":"https://api.github.com/repos/SymbiFlow/yosys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SymbiFlow/yosys/labels{/name}","releases_url":"https://api.github.com/repos/SymbiFlow/yosys/releases{/id}","deployments_url":"https://api.github.com/repos/SymbiFlow/yosys/deployments","created_at":"2017-12-30T13:11:53Z","updated_at":"2019-10-02T17:07:50Z","pushed_at":"2019-11-07T12:30:16Z","git_url":"git://github.com/SymbiFlow/yosys.git","ssh_url":"git@github.com:SymbiFlow/yosys.git","clone_url":"https://github.com/SymbiFlow/yosys.git","svn_url":"https://github.com/SymbiFlow/yosys","homepage":"http://www.clifford.at/yosys/","size":12874,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":4,"open_issues":15,"watchers":13,"default_branch":"master+wip"}},"_links":{"self":{"href":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44"},"html":{"href":"https://github.com/SymbiFlow/yosys/pull/44"},"issue":{"href":"https://api.github.com/repos/SymbiFlow/yosys/issues/44"},"comments":{"href":"https://api.github.com/repos/SymbiFlow/yosys/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/SymbiFlow/yosys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SymbiFlow/yosys/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/SymbiFlow/yosys/statuses/eddcec449fabcba42f73c13e130be6b81ff4ae0d"}},"author_association":"NONE"}}
{"actor":{"display_login":"tmichalak"}}