{"push_id":4394042967,"size":4,"distinct_size":4,"ref":"refs/heads/master","head":"4500ebba21836c4bf264a043b68cf580cfa55611","before":"867df5952c968c544193c38d9f88aebd1b09479d","commits":[{"sha":"9eb4b4ed01f893c2fc7ff3ee4f99301dec7ea3c2","author":{"name":"Edouard CHIN","email":"0f35ddd701f3b7c445a138ecbf133edbe34fcfb7@shopify.com"},"message":"Fix deprecation being thrown at boot time:\n\n-\n  ### Problem\n\n  In rails/rails@bbfab0b33ab I introduced a change which outputs\n  a deprecation whenever a class inherits from ActiveJob::Base.\n\n  This has the negative effect to trigger a massive amount of\n  deprecation at boot time especially if your app is eagerloaded\n  (like it's usually the case on CI).\n\n  Another issue with this approach was that the deprecation will\n  be output no matter if a job define a `after_perform` callbacks\n  i.e.\n  ```ruby\n    class MyJob < AJ::Base\n      before_enqueue { throw(:abort) }\n    end\n\n    # This shouldn't trigger a deprecation since no after callbacks are defined\n    # The change in 6.2 will be already safe for the app.\n  ```\n\n  ### Solution\n\n  Trigger the deprecation only when a job is abort\n  (during enqueuing or performing) AND a `after_perform`\n  callback is defined on the job.","distinct":true,"url":"https://api.github.com/repos/tloudon/rails/commits/9eb4b4ed01f893c2fc7ff3ee4f99301dec7ea3c2"},{"sha":"1421f70ff32660c34db3b70b54a7ba994206f71d","author":{"name":"Rafael França","email":"2d8d596a0b97569f9226a8c33ed9c6dbc8d88120@franca.dev"},"message":"Merge pull request #37950 from Edouard-chin/ec-activejob-too-much-deprecation\n\nFix deprecation being thrown at boot time:","distinct":true,"url":"https://api.github.com/repos/tloudon/rails/commits/1421f70ff32660c34db3b70b54a7ba994206f71d"},{"sha":"6e6019b9bf1537cd06078af9acf0d5099ec224eb","author":{"name":"Younes SERRAJ","email":"c17fcfa681c82712af2fc6a26477c9dbc29138a2@gmail.com"},"message":"Fixes typo in autoloading_and_reloading_constants guide [ci skip]\n\nThe javascript directory under app/ is in a singular form (app/javascript) but the documentation was mentionning it in the plural form (app/javascripts).","distinct":true,"url":"https://api.github.com/repos/tloudon/rails/commits/6e6019b9bf1537cd06078af9acf0d5099ec224eb"},{"sha":"4500ebba21836c4bf264a043b68cf580cfa55611","author":{"name":"Vipul A M","email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com"},"message":"Merge pull request #37958 from yoones/fix_typo_in_autoloading_guide\n\nFixes typo in autoloading_and_reloading_constants guide","distinct":true,"url":"https://api.github.com/repos/tloudon/rails/commits/4500ebba21836c4bf264a043b68cf580cfa55611"}]}
{"actor":{"display_login":"pull"}}