{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/ignition/pulls/comments/272241537","pull_request_review_id":222843923,"id":272241537,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MjI0MTUzNw==","diff_hunk":"@@ -155,20 +155,20 @@ func (u Util) WriteLink(s types.Link) error {\n \treturn nil\n }\n \n-func (u Util) SetPermissions(f types.File) error {\n-\tif f.Mode != nil {\n-\t\tmode := os.FileMode(*f.Mode)\n-\t\tif err := os.Chmod(f.Path, mode); err != nil {\n+func (u Util) SetPermissions(mode *int, node types.Node) error {\n+\tif mode != nil {\n+\t\tmode := os.FileMode(*mode)\n+\t\tif err := os.Chmod(node.Path, mode); err != nil {\n \t\t\treturn err\n \t\t}\n \t}\n \n-\tdefaultUid, defaultGid, _ := getFileOwnerAndMode(f.Path)\n-\tuid, gid, err := u.ResolveNodeUidAndGid(f.Node, defaultUid, defaultGid)\n+\tdefaultUid, defaultGid, _ := getFileOwnerAndMode(node.Path)\n+\tuid, gid, err := u.ResolveNodeUidAndGid(node, defaultUid, defaultGid)\n \tif err != nil {\n \t\treturn err\n \t}\n-\treturn os.Chown(f.Path, uid, gid)\n+\treturn os.Chown(node.Path, uid, gid)","path":"internal/exec/util/file.go","position":24,"original_position":24,"commit_id":"59de6065f50c3536cc816a41871ba566bba15263","original_commit_id":"dfc09cfd680888ac0ec6dba4aa0a8467ae003c8d","user":{"login":"ajeddeloh","id":2753421,"node_id":"MDQ6VXNlcjI3NTM0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2753421?v=4","gravatar_id":"","url":"https://api.github.com/users/ajeddeloh","html_url":"https://github.com/ajeddeloh","followers_url":"https://api.github.com/users/ajeddeloh/followers","following_url":"https://api.github.com/users/ajeddeloh/following{/other_user}","gists_url":"https://api.github.com/users/ajeddeloh/gists{/gist_id}","starred_url":"https://api.github.com/users/ajeddeloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajeddeloh/subscriptions","organizations_url":"https://api.github.com/users/ajeddeloh/orgs","repos_url":"https://api.github.com/users/ajeddeloh/repos","events_url":"https://api.github.com/users/ajeddeloh/events{/privacy}","received_events_url":"https://api.github.com/users/ajeddeloh/received_events","type":"User","site_admin":false},"body":":100: This is something that's rampant in the Ignition codebase.","created_at":"2019-04-04T15:38:04Z","updated_at":"2019-04-04T15:38:05Z","html_url":"https://github.com/coreos/ignition/pull/784#discussion_r272241537","pull_request_url":"https://api.github.com/repos/coreos/ignition/pulls/784","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coreos/ignition/pulls/comments/272241537"},"html":{"href":"https://github.com/coreos/ignition/pull/784#discussion_r272241537"},"pull_request":{"href":"https://api.github.com/repos/coreos/ignition/pulls/784"}},"in_reply_to_id":272180628},"pull_request":{"url":"https://api.github.com/repos/coreos/ignition/pulls/784","id":266793248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2NzkzMjQ4","html_url":"https://github.com/coreos/ignition/pull/784","diff_url":"https://github.com/coreos/ignition/pull/784.diff","patch_url":"https://github.com/coreos/ignition/pull/784.patch","issue_url":"https://api.github.com/repos/coreos/ignition/issues/784","number":784,"state":"open","locked":false,"title":"Fix dir perms","user":{"login":"ajeddeloh","id":2753421,"node_id":"MDQ6VXNlcjI3NTM0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2753421?v=4","gravatar_id":"","url":"https://api.github.com/users/ajeddeloh","html_url":"https://github.com/ajeddeloh","followers_url":"https://api.github.com/users/ajeddeloh/followers","following_url":"https://api.github.com/users/ajeddeloh/following{/other_user}","gists_url":"https://api.github.com/users/ajeddeloh/gists{/gist_id}","starred_url":"https://api.github.com/users/ajeddeloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajeddeloh/subscriptions","organizations_url":"https://api.github.com/users/ajeddeloh/orgs","repos_url":"https://api.github.com/users/ajeddeloh/repos","events_url":"https://api.github.com/users/ajeddeloh/events{/privacy}","received_events_url":"https://api.github.com/users/ajeddeloh/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-02T20:16:41Z","updated_at":"2019-04-04T15:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"008a79ebbde8b5aa54b6eaa857e12cdc8fffc7ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/ignition/pulls/784/commits","review_comments_url":"https://api.github.com/repos/coreos/ignition/pulls/784/comments","review_comment_url":"https://api.github.com/repos/coreos/ignition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/ignition/issues/784/comments","statuses_url":"https://api.github.com/repos/coreos/ignition/statuses/59de6065f50c3536cc816a41871ba566bba15263","head":{"label":"ajeddeloh:fix-dir-perms","ref":"fix-dir-perms","sha":"59de6065f50c3536cc816a41871ba566bba15263","user":{"login":"ajeddeloh","id":2753421,"node_id":"MDQ6VXNlcjI3NTM0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2753421?v=4","gravatar_id":"","url":"https://api.github.com/users/ajeddeloh","html_url":"https://github.com/ajeddeloh","followers_url":"https://api.github.com/users/ajeddeloh/followers","following_url":"https://api.github.com/users/ajeddeloh/following{/other_user}","gists_url":"https://api.github.com/users/ajeddeloh/gists{/gist_id}","starred_url":"https://api.github.com/users/ajeddeloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajeddeloh/subscriptions","organizations_url":"https://api.github.com/users/ajeddeloh/orgs","repos_url":"https://api.github.com/users/ajeddeloh/repos","events_url":"https://api.github.com/users/ajeddeloh/events{/privacy}","received_events_url":"https://api.github.com/users/ajeddeloh/received_events","type":"User","site_admin":false},"repo":{"id":59787248,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc4NzI0OA==","name":"ignition","full_name":"ajeddeloh/ignition","private":false,"owner":{"login":"ajeddeloh","id":2753421,"node_id":"MDQ6VXNlcjI3NTM0MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2753421?v=4","gravatar_id":"","url":"https://api.github.com/users/ajeddeloh","html_url":"https://github.com/ajeddeloh","followers_url":"https://api.github.com/users/ajeddeloh/followers","following_url":"https://api.github.com/users/ajeddeloh/following{/other_user}","gists_url":"https://api.github.com/users/ajeddeloh/gists{/gist_id}","starred_url":"https://api.github.com/users/ajeddeloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajeddeloh/subscriptions","organizations_url":"https://api.github.com/users/ajeddeloh/orgs","repos_url":"https://api.github.com/users/ajeddeloh/repos","events_url":"https://api.github.com/users/ajeddeloh/events{/privacy}","received_events_url":"https://api.github.com/users/ajeddeloh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ajeddeloh/ignition","description":"CoreOS first-boot installer and configuration tool","fork":true,"url":"https://api.github.com/repos/ajeddeloh/ignition","forks_url":"https://api.github.com/repos/ajeddeloh/ignition/forks","keys_url":"https://api.github.com/repos/ajeddeloh/ignition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajeddeloh/ignition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajeddeloh/ignition/teams","hooks_url":"https://api.github.com/repos/ajeddeloh/ignition/hooks","issue_events_url":"https://api.github.com/repos/ajeddeloh/ignition/issues/events{/number}","events_url":"https://api.github.com/repos/ajeddeloh/ignition/events","assignees_url":"https://api.github.com/repos/ajeddeloh/ignition/assignees{/user}","branches_url":"https://api.github.com/repos/ajeddeloh/ignition/branches{/branch}","tags_url":"https://api.github.com/repos/ajeddeloh/ignition/tags","blobs_url":"https://api.github.com/repos/ajeddeloh/ignition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajeddeloh/ignition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajeddeloh/ignition/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajeddeloh/ignition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajeddeloh/ignition/statuses/{sha}","languages_url":"https://api.github.com/repos/ajeddeloh/ignition/languages","stargazers_url":"https://api.github.com/repos/ajeddeloh/ignition/stargazers","contributors_url":"https://api.github.com/repos/ajeddeloh/ignition/contributors","subscribers_url":"https://api.github.com/repos/ajeddeloh/ignition/subscribers","subscription_url":"https://api.github.com/repos/ajeddeloh/ignition/subscription","commits_url":"https://api.github.com/repos/ajeddeloh/ignition/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajeddeloh/ignition/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajeddeloh/ignition/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajeddeloh/ignition/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajeddeloh/ignition/contents/{+path}","compare_url":"https://api.github.com/repos/ajeddeloh/ignition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajeddeloh/ignition/merges","archive_url":"https://api.github.com/repos/ajeddeloh/ignition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajeddeloh/ignition/downloads","issues_url":"https://api.github.com/repos/ajeddeloh/ignition/issues{/number}","pulls_url":"https://api.github.com/repos/ajeddeloh/ignition/pulls{/number}","milestones_url":"https://api.github.com/repos/ajeddeloh/ignition/milestones{/number}","notifications_url":"https://api.github.com/repos/ajeddeloh/ignition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajeddeloh/ignition/labels{/name}","releases_url":"https://api.github.com/repos/ajeddeloh/ignition/releases{/id}","deployments_url":"https://api.github.com/repos/ajeddeloh/ignition/deployments","created_at":"2016-05-26T22:29:28Z","updated_at":"2018-12-07T23:18:07Z","pushed_at":"2019-04-03T23:40:26Z","git_url":"git://github.com/ajeddeloh/ignition.git","ssh_url":"git@github.com:ajeddeloh/ignition.git","clone_url":"https://github.com/ajeddeloh/ignition.git","svn_url":"https://github.com/ajeddeloh/ignition","homepage":"https://coreos.com/ignition","size":3057,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"9b0d67d6225d483e5361ed387fc1fa0520f0cd6b","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":33020174,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAyMDE3NA==","name":"ignition","full_name":"coreos/ignition","private":false,"owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coreos/ignition","description":"First boot installer and configuration tool","fork":false,"url":"https://api.github.com/repos/coreos/ignition","forks_url":"https://api.github.com/repos/coreos/ignition/forks","keys_url":"https://api.github.com/repos/coreos/ignition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/ignition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/ignition/teams","hooks_url":"https://api.github.com/repos/coreos/ignition/hooks","issue_events_url":"https://api.github.com/repos/coreos/ignition/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/ignition/events","assignees_url":"https://api.github.com/repos/coreos/ignition/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/ignition/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/ignition/tags","blobs_url":"https://api.github.com/repos/coreos/ignition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/ignition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/ignition/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/ignition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/ignition/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/ignition/languages","stargazers_url":"https://api.github.com/repos/coreos/ignition/stargazers","contributors_url":"https://api.github.com/repos/coreos/ignition/contributors","subscribers_url":"https://api.github.com/repos/coreos/ignition/subscribers","subscription_url":"https://api.github.com/repos/coreos/ignition/subscription","commits_url":"https://api.github.com/repos/coreos/ignition/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/ignition/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/ignition/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/ignition/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/ignition/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/ignition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/ignition/merges","archive_url":"https://api.github.com/repos/coreos/ignition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/ignition/downloads","issues_url":"https://api.github.com/repos/coreos/ignition/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/ignition/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/ignition/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/ignition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/ignition/labels{/name}","releases_url":"https://api.github.com/repos/coreos/ignition/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/ignition/deployments","created_at":"2015-03-28T03:52:33Z","updated_at":"2019-04-02T20:44:06Z","pushed_at":"2019-04-03T23:41:15Z","git_url":"git://github.com/coreos/ignition.git","ssh_url":"git@github.com:coreos/ignition.git","clone_url":"https://github.com/coreos/ignition.git","svn_url":"https://github.com/coreos/ignition","homepage":"https://coreos.com/ignition/docs/latest/","size":2948,"stargazers_count":307,"watchers_count":307,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":126,"open_issues":46,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/ignition/pulls/784"},"html":{"href":"https://github.com/coreos/ignition/pull/784"},"issue":{"href":"https://api.github.com/repos/coreos/ignition/issues/784"},"comments":{"href":"https://api.github.com/repos/coreos/ignition/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/ignition/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/ignition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/ignition/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/ignition/statuses/59de6065f50c3536cc816a41871ba566bba15263"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajeddeloh"}}