{"action":"closed","number":2651,"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/2651","id":307505914,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NTA1OTE0","html_url":"https://github.com/GoogleContainerTools/skaffold/pull/2651","diff_url":"https://github.com/GoogleContainerTools/skaffold/pull/2651.diff","patch_url":"https://github.com/GoogleContainerTools/skaffold/pull/2651.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/2651","number":2651,"state":"closed","locked":false,"title":"Don't look up services in all namespaces.","user":{"login":"tejal29","id":1534539,"node_id":"MDQ6VXNlcjE1MzQ1Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1534539?v=4","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"body":"fixes #2495, \r\n\r\nIn #2640, i made changes to collect all namespaces for deployed resources.\r\nIn PR, we go through all namespaces in the context and then look for services in each namespace.","created_at":"2019-08-14T21:30:49Z","updated_at":"2019-08-14T23:13:32Z","closed_at":"2019-08-14T23:13:32Z","merged_at":null,"merge_commit_sha":"c658c699d4c38943c374886fb558a51e705195b8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dgageot","id":153495,"node_id":"MDQ6VXNlcjE1MzQ5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/153495?v=4","gravatar_id":"","url":"https://api.github.com/users/dgageot","html_url":"https://github.com/dgageot","followers_url":"https://api.github.com/users/dgageot/followers","following_url":"https://api.github.com/users/dgageot/following{/other_user}","gists_url":"https://api.github.com/users/dgageot/gists{/gist_id}","starred_url":"https://api.github.com/users/dgageot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgageot/subscriptions","organizations_url":"https://api.github.com/users/dgageot/orgs","repos_url":"https://api.github.com/users/dgageot/repos","events_url":"https://api.github.com/users/dgageot/events{/privacy}","received_events_url":"https://api.github.com/users/dgageot/received_events","type":"User","site_admin":false},{"login":"balopat","id":635073,"node_id":"MDQ6VXNlcjYzNTA3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/635073?v=4","gravatar_id":"","url":"https://api.github.com/users/balopat","html_url":"https://github.com/balopat","followers_url":"https://api.github.com/users/balopat/followers","following_url":"https://api.github.com/users/balopat/following{/other_user}","gists_url":"https://api.github.com/users/balopat/gists{/gist_id}","starred_url":"https://api.github.com/users/balopat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balopat/subscriptions","organizations_url":"https://api.github.com/users/balopat/orgs","repos_url":"https://api.github.com/users/balopat/repos","events_url":"https://api.github.com/users/balopat/events{/privacy}","received_events_url":"https://api.github.com/users/balopat/received_events","type":"User","site_admin":false},{"login":"nkubala","id":5531168,"node_id":"MDQ6VXNlcjU1MzExNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5531168?v=4","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1205248983,"node_id":"MDU6TGFiZWwxMjA1MjQ4OTgz","url":"https://api.github.com/repos/GoogleContainerTools/skaffold/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/2651/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/2651/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/2651/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/statuses/edf02ffdf73ae0901a664d690604c6e9232b030d","head":{"label":"tejal29:fix_port_forwarding","ref":"fix_port_forwarding","sha":"edf02ffdf73ae0901a664d690604c6e9232b030d","user":{"login":"tejal29","id":1534539,"node_id":"MDQ6VXNlcjE1MzQ1Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1534539?v=4","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"repo":{"id":133549534,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDk1MzQ=","name":"skaffold","full_name":"tejal29/skaffold","private":false,"owner":{"login":"tejal29","id":1534539,"node_id":"MDQ6VXNlcjE1MzQ1Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1534539?v=4","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tejal29/skaffold","description":"Easy and Repeatable Kubernetes Development","fork":true,"url":"https://api.github.com/repos/tejal29/skaffold","forks_url":"https://api.github.com/repos/tejal29/skaffold/forks","keys_url":"https://api.github.com/repos/tejal29/skaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tejal29/skaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tejal29/skaffold/teams","hooks_url":"https://api.github.com/repos/tejal29/skaffold/hooks","issue_events_url":"https://api.github.com/repos/tejal29/skaffold/issues/events{/number}","events_url":"https://api.github.com/repos/tejal29/skaffold/events","assignees_url":"https://api.github.com/repos/tejal29/skaffold/assignees{/user}","branches_url":"https://api.github.com/repos/tejal29/skaffold/branches{/branch}","tags_url":"https://api.github.com/repos/tejal29/skaffold/tags","blobs_url":"https://api.github.com/repos/tejal29/skaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tejal29/skaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tejal29/skaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/tejal29/skaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tejal29/skaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/tejal29/skaffold/languages","stargazers_url":"https://api.github.com/repos/tejal29/skaffold/stargazers","contributors_url":"https://api.github.com/repos/tejal29/skaffold/contributors","subscribers_url":"https://api.github.com/repos/tejal29/skaffold/subscribers","subscription_url":"https://api.github.com/repos/tejal29/skaffold/subscription","commits_url":"https://api.github.com/repos/tejal29/skaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/tejal29/skaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/tejal29/skaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/tejal29/skaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/tejal29/skaffold/contents/{+path}","compare_url":"https://api.github.com/repos/tejal29/skaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tejal29/skaffold/merges","archive_url":"https://api.github.com/repos/tejal29/skaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tejal29/skaffold/downloads","issues_url":"https://api.github.com/repos/tejal29/skaffold/issues{/number}","pulls_url":"https://api.github.com/repos/tejal29/skaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/tejal29/skaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/tejal29/skaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tejal29/skaffold/labels{/name}","releases_url":"https://api.github.com/repos/tejal29/skaffold/releases{/id}","deployments_url":"https://api.github.com/repos/tejal29/skaffold/deployments","created_at":"2018-05-15T17:19:28Z","updated_at":"2019-06-27T21:11:33Z","pushed_at":"2019-08-14T22:24:50Z","git_url":"git://github.com/tejal29/skaffold.git","ssh_url":"git@github.com:tejal29/skaffold.git","clone_url":"https://github.com/tejal29/skaffold.git","svn_url":"https://github.com/tejal29/skaffold","homepage":"","size":57847,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"686e75f47536a51a320fd91db16efab0329e235f","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118654121,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2NTQxMjE=","name":"skaffold","full_name":"GoogleContainerTools/skaffold","private":false,"owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GoogleContainerTools/skaffold","description":"Easy and Repeatable Kubernetes Development","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/skaffold","forks_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/skaffold/deployments","created_at":"2018-01-23T18:51:29Z","updated_at":"2019-08-14T23:04:29Z","pushed_at":"2019-08-14T22:50:00Z","git_url":"git://github.com/GoogleContainerTools/skaffold.git","ssh_url":"git@github.com:GoogleContainerTools/skaffold.git","clone_url":"https://github.com/GoogleContainerTools/skaffold.git","svn_url":"https://github.com/GoogleContainerTools/skaffold","homepage":"https://skaffold.dev/","size":38809,"stargazers_count":7385,"watchers_count":7385,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":621,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":289,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":621,"open_issues":289,"watchers":7385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/2651"},"html":{"href":"https://github.com/GoogleContainerTools/skaffold/pull/2651"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/2651"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/issues/2651/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/2651/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/pulls/2651/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/skaffold/statuses/edf02ffdf73ae0901a664d690604c6e9232b030d"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":136,"deletions":25,"changed_files":3}}
{"actor":{"display_login":"balopat"}}