{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/26841","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/26841/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/26841/comments","events_url":"https://api.github.com/repos/apache/spark/issues/26841/events","html_url":"https://github.com/apache/spark/pull/26841","id":536045604,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNjQ2ODc2","number":26841,"title":"[SPARK-29152][2.4][CORE]Executor Plugin shutdown when dynamic allocation is enabled","user":{"login":"iRakson","id":15366835,"node_id":"MDQ6VXNlcjE1MzY2ODM1","avatar_url":"https://avatars2.githubusercontent.com/u/15366835?v=4","gravatar_id":"","url":"https://api.github.com/users/iRakson","html_url":"https://github.com/iRakson","followers_url":"https://api.github.com/users/iRakson/followers","following_url":"https://api.github.com/users/iRakson/following{/other_user}","gists_url":"https://api.github.com/users/iRakson/gists{/gist_id}","starred_url":"https://api.github.com/users/iRakson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iRakson/subscriptions","organizations_url":"https://api.github.com/users/iRakson/orgs","repos_url":"https://api.github.com/users/iRakson/repos","events_url":"https://api.github.com/users/iRakson/events{/privacy}","received_events_url":"https://api.github.com/users/iRakson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-12-10T23:07:16Z","updated_at":"2019-12-11T01:59:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/26841","html_url":"https://github.com/apache/spark/pull/26841","diff_url":"https://github.com/apache/spark/pull/26841.diff","patch_url":"https://github.com/apache/spark/pull/26841.patch"},"body":"\r\n\r\n<!--\r\nThanks for sending a pull request!  Here are some tips for you:\r\n  1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html\r\n  2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html\r\n  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.\r\n  4. Be sure to keep the PR description updated to reflect all changes.\r\n  5. Please write your PR title to summarize what this PR proposes.\r\n  6. If possible, provide a concise example to reproduce the issue for a faster review.\r\n-->\r\n\r\n### What changes were proposed in this pull request?\r\nAdded `shutdownHook` for shutdown method of executor plugin. This will ensure that shutdown method will be called always.\r\n<!--\r\nPlease clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. \r\nIf possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.\r\n  1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.\r\n  2. If you fix some SQL features, you can provide some references of other DBMSes.\r\n  3. If there is design documentation, please add the link.\r\n  4. If there is a discussion in the mailing list, please add the link.\r\n-->\r\n\r\n\r\n### Why are the changes needed?\r\nWhenever executors are not going down gracefully, i.e getting killed due to idle time or getting killed forcefully, shutdown method of executors plugin is not getting called. Shutdown method can be used to release any resources that plugin has acquired during its initialisation. So its important to make sure that every time a executor goes down shutdown method of plugin gets called.\r\n<!--\r\nPlease clarify why the changes are needed. For instance,\r\n  1. If you propose a new API, clarify the use case for a new API.\r\n  2. If you fix a bug, you can clarify why it is a bug.\r\n-->\r\n\r\n\r\n### Does this PR introduce any user-facing change?\r\nNo\r\n<!--\r\nIf yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.\r\nIf no, write 'No'.\r\n-->\r\n\r\n\r\n### How was this patch tested?\r\nTested Manually\r\n<!--\r\nIf tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.\r\nIf it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.\r\nIf tests were not added, please describe why they were not added and/or why it was difficult to add.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/564342669","html_url":"https://github.com/apache/spark/pull/26841#issuecomment-564342669","issue_url":"https://api.github.com/repos/apache/spark/issues/26841","id":564342669,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NDM0MjY2OQ==","user":{"login":"AmplabJenkins","id":4031291,"node_id":"MDQ6VXNlcjQwMzEyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4031291?v=4","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2019-12-11T01:59:47Z","updated_at":"2019-12-11T01:59:47Z","author_association":"NONE","body":"Merged build finished. Test PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}