{"action":"created","issue":{"url":"https://api.github.com/repos/kassisol/tsa/issues/1","repository_url":"https://api.github.com/repos/kassisol/tsa","labels_url":"https://api.github.com/repos/kassisol/tsa/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/kassisol/tsa/issues/1/comments","events_url":"https://api.github.com/repos/kassisol/tsa/issues/1/events","html_url":"https://github.com/kassisol/tsa/pull/1","id":419851174,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMjU3MDE5","number":1,"title":"Fix username validation for CommonName.","user":{"login":"eiraelr","id":48470346,"node_id":"MDQ6VXNlcjQ4NDcwMzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/48470346?v=4","gravatar_id":"","url":"https://api.github.com/users/eiraelr","html_url":"https://github.com/eiraelr","followers_url":"https://api.github.com/users/eiraelr/followers","following_url":"https://api.github.com/users/eiraelr/following{/other_user}","gists_url":"https://api.github.com/users/eiraelr/gists{/gist_id}","starred_url":"https://api.github.com/users/eiraelr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eiraelr/subscriptions","organizations_url":"https://api.github.com/users/eiraelr/orgs","repos_url":"https://api.github.com/users/eiraelr/repos","events_url":"https://api.github.com/users/eiraelr/events{/privacy}","received_events_url":"https://api.github.com/users/eiraelr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-12T08:09:36Z","updated_at":"2019-03-20T14:08:38Z","closed_at":"2019-03-20T14:08:38Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kassisol/tsa/pulls/1","html_url":"https://github.com/kassisol/tsa/pull/1","diff_url":"https://github.com/kassisol/tsa/pull/1.diff","patch_url":"https://github.com/kassisol/tsa/pull/1.patch"},"body":"Fixes an issue with usernames containing numbers.\r\n\r\nThe IsValidFQDN code checks if the last part of its argument only contains ascii letters and fails otherwise.\r\nAs usernames only have one part any name containing any other characters will fail.\r\n\r\nI should say that I haven't been able to test this fix."},"comment":{"url":"https://api.github.com/repos/kassisol/tsa/issues/comments/474845195","html_url":"https://github.com/kassisol/tsa/pull/1#issuecomment-474845195","issue_url":"https://api.github.com/repos/kassisol/tsa/issues/1","id":474845195,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3NDg0NTE5NQ==","user":{"login":"juliengk","id":7716239,"node_id":"MDQ6VXNlcjc3MTYyMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7716239?v=4","gravatar_id":"","url":"https://api.github.com/users/juliengk","html_url":"https://github.com/juliengk","followers_url":"https://api.github.com/users/juliengk/followers","following_url":"https://api.github.com/users/juliengk/following{/other_user}","gists_url":"https://api.github.com/users/juliengk/gists{/gist_id}","starred_url":"https://api.github.com/users/juliengk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliengk/subscriptions","organizations_url":"https://api.github.com/users/juliengk/orgs","repos_url":"https://api.github.com/users/juliengk/repos","events_url":"https://api.github.com/users/juliengk/events{/privacy}","received_events_url":"https://api.github.com/users/juliengk/received_events","type":"User","site_admin":false},"created_at":"2019-03-20T14:08:38Z","updated_at":"2019-03-20T14:08:38Z","author_association":"CONTRIBUTOR","body":"the package `go-utils/validation` has not been updated to the latest [one](https://github.com/kassisol/tsa/blob/master/vendor/vendor.json#L151) and since then there was a commit to fix the fqdn validation function.\r\n\r\nI'm closing that PR as that's not the fix to your problem"}}
{"actor":{"display_login":"juliengk"}}