{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/257038367","pull_request_review_id":204003385,"id":257038367,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzAzODM2Nw==","diff_hunk":"@@ -254,6 +260,40 @@ public void testEmptyBucket()\n         assertEquals(getSplits(hiveSplitSource, OptionalInt.of(3), 10).size(), 0);\n     }\n \n+    @Test\n+    public void testLoadAllSplitsBeforeScheduling()\n+            throws Exception\n+    {\n+        ConnectorSession session = new TestingConnectorSession(","path":"presto-hive/src/test/java/com/facebook/presto/hive/TestHiveSplitSource.java","position":57,"original_position":57,"commit_id":"b082a2bf930d500e4bde595c45881e6a9892359d","original_commit_id":"b082a2bf930d500e4bde595c45881e6a9892359d","user":{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false},"body":"`HiveTestUtils::SESSION` is a `ConnectorSession`, which cannot be transformed to a `Session` to be used for `Session::builder`. Ideally we should make `HiveTestUtils::SESSION` a `Session` and use `toConnectorSession` for existing usage so we could leverage builder pattern for other tests. ","created_at":"2019-02-14T22:26:12Z","updated_at":"2019-02-14T22:26:12Z","html_url":"https://github.com/prestodb/presto/pull/12330#discussion_r257038367","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/12330","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/257038367"},"html":{"href":"https://github.com/prestodb/presto/pull/12330#discussion_r257038367"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12330"}},"in_reply_to_id":256967672},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/12330","id":252444972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNDQ0OTcy","html_url":"https://github.com/prestodb/presto/pull/12330","diff_url":"https://github.com/prestodb/presto/pull/12330.diff","patch_url":"https://github.com/prestodb/presto/pull/12330.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/12330","number":12330,"state":"open","locked":false,"title":" Add option to load all splits before scheduling for grouped execution","user":{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-12T19:38:29Z","updated_at":"2019-02-14T22:26:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd3eae68cf6a8528209bd1971c902be135e7b509","assignee":{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false},"assignees":[{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kokosing","id":7569403,"node_id":"MDQ6VXNlcjc1Njk0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7569403?v=4","gravatar_id":"","url":"https://api.github.com/users/kokosing","html_url":"https://github.com/kokosing","followers_url":"https://api.github.com/users/kokosing/followers","following_url":"https://api.github.com/users/kokosing/following{/other_user}","gists_url":"https://api.github.com/users/kokosing/gists{/gist_id}","starred_url":"https://api.github.com/users/kokosing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokosing/subscriptions","organizations_url":"https://api.github.com/users/kokosing/orgs","repos_url":"https://api.github.com/users/kokosing/repos","events_url":"https://api.github.com/users/kokosing/events{/privacy}","received_events_url":"https://api.github.com/users/kokosing/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/12330/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/12330/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/12330/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/b082a2bf930d500e4bde595c45881e6a9892359d","head":{"label":"shixuan-fan:discover","ref":"discover","sha":"b082a2bf930d500e4bde595c45881e6a9892359d","user":{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false},"repo":{"id":101144253,"node_id":"MDEwOlJlcG9zaXRvcnkxMDExNDQyNTM=","name":"presto","full_name":"shixuan-fan/presto","private":false,"owner":{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shixuan-fan/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/shixuan-fan/presto","forks_url":"https://api.github.com/repos/shixuan-fan/presto/forks","keys_url":"https://api.github.com/repos/shixuan-fan/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shixuan-fan/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shixuan-fan/presto/teams","hooks_url":"https://api.github.com/repos/shixuan-fan/presto/hooks","issue_events_url":"https://api.github.com/repos/shixuan-fan/presto/issues/events{/number}","events_url":"https://api.github.com/repos/shixuan-fan/presto/events","assignees_url":"https://api.github.com/repos/shixuan-fan/presto/assignees{/user}","branches_url":"https://api.github.com/repos/shixuan-fan/presto/branches{/branch}","tags_url":"https://api.github.com/repos/shixuan-fan/presto/tags","blobs_url":"https://api.github.com/repos/shixuan-fan/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shixuan-fan/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shixuan-fan/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/shixuan-fan/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shixuan-fan/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/shixuan-fan/presto/languages","stargazers_url":"https://api.github.com/repos/shixuan-fan/presto/stargazers","contributors_url":"https://api.github.com/repos/shixuan-fan/presto/contributors","subscribers_url":"https://api.github.com/repos/shixuan-fan/presto/subscribers","subscription_url":"https://api.github.com/repos/shixuan-fan/presto/subscription","commits_url":"https://api.github.com/repos/shixuan-fan/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/shixuan-fan/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/shixuan-fan/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/shixuan-fan/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/shixuan-fan/presto/contents/{+path}","compare_url":"https://api.github.com/repos/shixuan-fan/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shixuan-fan/presto/merges","archive_url":"https://api.github.com/repos/shixuan-fan/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shixuan-fan/presto/downloads","issues_url":"https://api.github.com/repos/shixuan-fan/presto/issues{/number}","pulls_url":"https://api.github.com/repos/shixuan-fan/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/shixuan-fan/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/shixuan-fan/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shixuan-fan/presto/labels{/name}","releases_url":"https://api.github.com/repos/shixuan-fan/presto/releases{/id}","deployments_url":"https://api.github.com/repos/shixuan-fan/presto/deployments","created_at":"2017-08-23T06:10:53Z","updated_at":"2019-02-11T23:57:59Z","pushed_at":"2019-02-14T19:08:29Z","git_url":"git://github.com/shixuan-fan/presto.git","ssh_url":"git@github.com:shixuan-fan/presto.git","clone_url":"https://github.com/shixuan-fan/presto.git","svn_url":"https://github.com/shixuan-fan/presto","homepage":"https://prestodb.io","size":106092,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"928eaa921ac3004fc5fa57a27823995487f18ae1","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2019-02-14T15:24:20Z","pushed_at":"2019-02-14T20:09:25Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"http://prestodb.github.io","size":106643,"stargazers_count":8711,"watchers_count":8711,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2957,"mirror_url":null,"archived":false,"open_issues_count":1430,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2957,"open_issues":1430,"watchers":8711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12330"},"html":{"href":"https://github.com/prestodb/presto/pull/12330"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/12330"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/12330/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12330/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12330/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/b082a2bf930d500e4bde595c45881e6a9892359d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shixuan-fan"}}