{"action":"created","issue":{"url":"https://api.github.com/repos/bschn2/rainforest/issues/4","repository_url":"https://api.github.com/repos/bschn2/rainforest","labels_url":"https://api.github.com/repos/bschn2/rainforest/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/bschn2/rainforest/issues/4/comments","events_url":"https://api.github.com/repos/bschn2/rainforest/issues/4/events","html_url":"https://github.com/bschn2/rainforest/pull/4","id":416545711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NzU1NjU1","number":4,"title":"Build fixes","user":{"login":"MikeMurdo","id":42321661,"node_id":"MDQ6VXNlcjQyMzIxNjYx","avatar_url":"https://avatars2.githubusercontent.com/u/42321661?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMurdo","html_url":"https://github.com/MikeMurdo","followers_url":"https://api.github.com/users/MikeMurdo/followers","following_url":"https://api.github.com/users/MikeMurdo/following{/other_user}","gists_url":"https://api.github.com/users/MikeMurdo/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMurdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMurdo/subscriptions","organizations_url":"https://api.github.com/users/MikeMurdo/orgs","repos_url":"https://api.github.com/users/MikeMurdo/repos","events_url":"https://api.github.com/users/MikeMurdo/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMurdo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2019-03-03T18:17:32Z","updated_at":"2019-03-10T17:33:44Z","closed_at":"2019-03-03T18:21:29Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bschn2/rainforest/pulls/4","html_url":"https://github.com/bschn2/rainforest/pull/4","diff_url":"https://github.com/bschn2/rainforest/pull/4.diff","patch_url":"https://github.com/bschn2/rainforest/pull/4.patch"},"body":"Hello Bill,\r\nsome users are facing build errors and warnings like here https://imgur.com/uEOLZpL or here https://gist.github.com/quagliero/90f493f123c7b1ddba5428ba0146329a#gistcomment-2800719 .\r\n\r\nI've addressed them, they were missing types (ulong) and void* arithmetics (forbidden in C++). I have also updated the patches for cpuminer and sgminer. For yiimp I have not updated it as tpruvot merged it and fixed it already. But the cpuminer and sgminer patches are likely to be applied as is on forks from older versions of these miners.\r\n\r\nPlease merge this as adoption by some coins might possibly be stopped just because of this."},"comment":{"url":"https://api.github.com/repos/bschn2/rainforest/issues/comments/471326567","html_url":"https://github.com/bschn2/rainforest/pull/4#issuecomment-471326567","issue_url":"https://api.github.com/repos/bschn2/rainforest/issues/4","id":471326567,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTMyNjU2Nw==","user":{"login":"aivve","id":18482330,"node_id":"MDQ6VXNlcjE4NDgyMzMw","avatar_url":"https://avatars2.githubusercontent.com/u/18482330?v=4","gravatar_id":"","url":"https://api.github.com/users/aivve","html_url":"https://github.com/aivve","followers_url":"https://api.github.com/users/aivve/followers","following_url":"https://api.github.com/users/aivve/following{/other_user}","gists_url":"https://api.github.com/users/aivve/gists{/gist_id}","starred_url":"https://api.github.com/users/aivve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aivve/subscriptions","organizations_url":"https://api.github.com/users/aivve/orgs","repos_url":"https://api.github.com/users/aivve/repos","events_url":"https://api.github.com/users/aivve/events{/privacy}","received_events_url":"https://api.github.com/users/aivve/received_events","type":"User","site_admin":false},"created_at":"2019-03-10T17:33:44Z","updated_at":"2019-03-10T17:33:44Z","author_association":"NONE","body":"Hello @bschn2,\r\n\r\nIf I would want to use the hash twice, i.e. feed in a second pass the output of first one of length 64, then I suppose I would need to uncomment \"optimized\" code. Not all coins have input of 80, for example  cpuminer won't mine correctly at cryptonight  algo if block template contains more than 127 transactions. "}}
{"actor":{"display_login":"aivve"}}