{"action":"created","issue":{"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/201","repository_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle","labels_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/201/comments","events_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/201/events","html_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/201","id":500764333,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMTY1MTky","number":201,"title":"add phpstan check to ci","user":{"login":"brambaud","id":9115419,"node_id":"MDQ6VXNlcjkxMTU0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/9115419?v=4","gravatar_id":"","url":"https://api.github.com/users/brambaud","html_url":"https://github.com/brambaud","followers_url":"https://api.github.com/users/brambaud/followers","following_url":"https://api.github.com/users/brambaud/following{/other_user}","gists_url":"https://api.github.com/users/brambaud/gists{/gist_id}","starred_url":"https://api.github.com/users/brambaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brambaud/subscriptions","organizations_url":"https://api.github.com/users/brambaud/orgs","repos_url":"https://api.github.com/users/brambaud/repos","events_url":"https://api.github.com/users/brambaud/events{/privacy}","received_events_url":"https://api.github.com/users/brambaud/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2019-10-01T09:10:55Z","updated_at":"2019-10-04T16:43:50Z","closed_at":"2019-10-03T14:36:47Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/pulls/201","html_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/201","diff_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/201.diff","patch_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/201.patch"},"body":"See issue #88 \r\n\r\nHere's a first try to integrate phpstan :)\r\n\r\nWith the higher phpstan level (the higher the stricter), i.e. 7, there is at this moment 221 errors detected.\r\n\r\nNot all of them are relevant IMHO.\r\nFor instance there is a lot of \"errors\" like ` Return typehint of method KnpU\\OAuth2ClientBundle\\Client\\Provider\\SlackClient::fetchUserFromToken() has invalid type AdamPaterson\\OAuth2\\Client\\Provider\\SlackResourceOwner.` that could be ignore.\r\n\r\nI'd like to have opinion of others about how to proceed about the detected errors.\r\nDo we handle them in this PR?\r\nWhich errors should be ignored?\r\nShould we decrease the phpstan level at first and increase it little by little?"},"comment":{"url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/comments/538474150","html_url":"https://github.com/knpuniversity/oauth2-client-bundle/pull/201#issuecomment-538474150","issue_url":"https://api.github.com/repos/knpuniversity/oauth2-client-bundle/issues/201","id":538474150,"node_id":"MDEyOklzc3VlQ29tbWVudDUzODQ3NDE1MA==","user":{"login":"alister","id":173165,"node_id":"MDQ6VXNlcjE3MzE2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/173165?v=4","gravatar_id":"","url":"https://api.github.com/users/alister","html_url":"https://github.com/alister","followers_url":"https://api.github.com/users/alister/followers","following_url":"https://api.github.com/users/alister/following{/other_user}","gists_url":"https://api.github.com/users/alister/gists{/gist_id}","starred_url":"https://api.github.com/users/alister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alister/subscriptions","organizations_url":"https://api.github.com/users/alister/orgs","repos_url":"https://api.github.com/users/alister/repos","events_url":"https://api.github.com/users/alister/events{/privacy}","received_events_url":"https://api.github.com/users/alister/received_events","type":"User","site_admin":false},"created_at":"2019-10-04T16:43:50Z","updated_at":"2019-10-04T16:43:50Z","author_association":"NONE","body":"I'd be happy to take a look at these over the weekend. From a quick look, there only looks to be 8 or 9 actual distinct issues.\r\n\r\nMost of the 90+ issues with ResourceOwnerInterface is just the @return type causing PHPStan  to complain. It's actually a mix of the error where the various ::class are not known yet, because they aren't required dependencies, but then also the comment on #33 about removing `| ResourceOwnerInterface`. PHPStan can't know what those external classes implement, so must presume it does not. The hard part may be going and looking if it really does provide it."}}
{"actor":{"display_login":"alister"}}