{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/288135174","pull_request_review_id":242709196,"id":288135174,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODEzNTE3NA==","diff_hunk":"@@ -17,8 +17,8 @@ stdenv.mkDerivation rec {\n \n   configureFlags = [ \"--without-tcl\" ];\n \n+  # Disable ccache documentation as it needs yodl","path":"pkgs/development/tools/misc/swig/3.x.nix","position":13,"original_position":13,"commit_id":"072f4d61c06661567c0ee00efe6d539db0342f06","original_commit_id":"072f4d61c06661567c0ee00efe6d539db0342f06","user":{"login":"bhipple","id":2071583,"node_id":"MDQ6VXNlcjIwNzE1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/2071583?v=4","gravatar_id":"","url":"https://api.github.com/users/bhipple","html_url":"https://github.com/bhipple","followers_url":"https://api.github.com/users/bhipple/followers","following_url":"https://api.github.com/users/bhipple/following{/other_user}","gists_url":"https://api.github.com/users/bhipple/gists{/gist_id}","starred_url":"https://api.github.com/users/bhipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhipple/subscriptions","organizations_url":"https://api.github.com/users/bhipple/orgs","repos_url":"https://api.github.com/users/bhipple/repos","events_url":"https://api.github.com/users/bhipple/events{/privacy}","received_events_url":"https://api.github.com/users/bhipple/received_events","type":"User","site_admin":false},"body":"Just fixing a small grammar mistake while I'm here, and moving the comment out of the `postPatch` so it can be updated without a rebuild.","created_at":"2019-05-28T14:29:20Z","updated_at":"2019-05-28T14:29:20Z","html_url":"https://github.com/NixOS/nixpkgs/pull/62158#discussion_r288135174","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/288135174"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/62158#discussion_r288135174"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158","id":282857085,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyODU3MDg1","html_url":"https://github.com/NixOS/nixpkgs/pull/62158","diff_url":"https://github.com/NixOS/nixpkgs/pull/62158.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/62158.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/62158","number":62158,"state":"open","locked":false,"title":"swig: use pname and standardize meta","user":{"login":"bhipple","id":2071583,"node_id":"MDQ6VXNlcjIwNzE1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/2071583?v=4","gravatar_id":"","url":"https://api.github.com/users/bhipple","html_url":"https://github.com/bhipple","followers_url":"https://api.github.com/users/bhipple/followers","following_url":"https://api.github.com/users/bhipple/following{/other_user}","gists_url":"https://api.github.com/users/bhipple/gists{/gist_id}","starred_url":"https://api.github.com/users/bhipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhipple/subscriptions","organizations_url":"https://api.github.com/users/bhipple/orgs","repos_url":"https://api.github.com/users/bhipple/repos","events_url":"https://api.github.com/users/bhipple/events{/privacy}","received_events_url":"https://api.github.com/users/bhipple/received_events","type":"User","site_admin":false},"body":"- pname makes it easier to override the version in an overlay and looks generally cleaner\r\n- Updated the meta sections to match between the various versions\r\n\r\nNo real functional change, just cleanup.\r\n\r\n###### Things done\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run \"nix-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Assured whether relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n","created_at":"2019-05-28T14:26:57Z","updated_at":"2019-05-28T14:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9976be95ba7a10f76067b611b43016ec3b49fb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/62158/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/072f4d61c06661567c0ee00efe6d539db0342f06","head":{"label":"bhipple:fix/swig","ref":"fix/swig","sha":"072f4d61c06661567c0ee00efe6d539db0342f06","user":{"login":"bhipple","id":2071583,"node_id":"MDQ6VXNlcjIwNzE1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/2071583?v=4","gravatar_id":"","url":"https://api.github.com/users/bhipple","html_url":"https://github.com/bhipple","followers_url":"https://api.github.com/users/bhipple/followers","following_url":"https://api.github.com/users/bhipple/following{/other_user}","gists_url":"https://api.github.com/users/bhipple/gists{/gist_id}","starred_url":"https://api.github.com/users/bhipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhipple/subscriptions","organizations_url":"https://api.github.com/users/bhipple/orgs","repos_url":"https://api.github.com/users/bhipple/repos","events_url":"https://api.github.com/users/bhipple/events{/privacy}","received_events_url":"https://api.github.com/users/bhipple/received_events","type":"User","site_admin":false},"repo":{"id":76206587,"node_id":"MDEwOlJlcG9zaXRvcnk3NjIwNjU4Nw==","name":"nixpkgs","full_name":"bhipple/nixpkgs","private":false,"owner":{"login":"bhipple","id":2071583,"node_id":"MDQ6VXNlcjIwNzE1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/2071583?v=4","gravatar_id":"","url":"https://api.github.com/users/bhipple","html_url":"https://github.com/bhipple","followers_url":"https://api.github.com/users/bhipple/followers","following_url":"https://api.github.com/users/bhipple/following{/other_user}","gists_url":"https://api.github.com/users/bhipple/gists{/gist_id}","starred_url":"https://api.github.com/users/bhipple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhipple/subscriptions","organizations_url":"https://api.github.com/users/bhipple/orgs","repos_url":"https://api.github.com/users/bhipple/repos","events_url":"https://api.github.com/users/bhipple/events{/privacy}","received_events_url":"https://api.github.com/users/bhipple/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bhipple/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bhipple/nixpkgs","forks_url":"https://api.github.com/repos/bhipple/nixpkgs/forks","keys_url":"https://api.github.com/repos/bhipple/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhipple/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhipple/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bhipple/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bhipple/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bhipple/nixpkgs/events","assignees_url":"https://api.github.com/repos/bhipple/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bhipple/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bhipple/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bhipple/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhipple/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhipple/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhipple/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhipple/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bhipple/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bhipple/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bhipple/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bhipple/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bhipple/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bhipple/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhipple/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhipple/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhipple/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhipple/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bhipple/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhipple/nixpkgs/merges","archive_url":"https://api.github.com/repos/bhipple/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhipple/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bhipple/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bhipple/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bhipple/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bhipple/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhipple/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bhipple/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/bhipple/nixpkgs/deployments","created_at":"2016-12-11T23:29:16Z","updated_at":"2018-06-09T15:32:33Z","pushed_at":"2019-05-28T14:25:25Z","git_url":"git://github.com/bhipple/nixpkgs.git","ssh_url":"git@github.com:bhipple/nixpkgs.git","clone_url":"https://github.com/bhipple/nixpkgs.git","svn_url":"https://github.com/bhipple/nixpkgs","homepage":null,"size":871344,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:staging","ref":"staging","sha":"07dbc438cce81ff15c3c9ae3213a1762d178274f","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-05-28T13:03:48Z","pushed_at":"2019-05-28T14:26:58Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":975035,"stargazers_count":3781,"watchers_count":3781,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3691,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4232,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3691,"open_issues":4232,"watchers":3781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/62158"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/62158"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/62158/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/62158/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/072f4d61c06661567c0ee00efe6d539db0342f06"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bhipple"}}