{"action":"created","comment":{"url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/comments/348307054","pull_request_review_id":319564222,"id":348307054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODMwNzA1NA==","diff_hunk":"@@ -22,16 +22,23 @@\n \n FAN_PATH = \"/var/run/hw-management/thermal/\"\n LED_PATH = \"/var/run/hw-management/led/\"\n+# fan_dir only exist SPC2 switches","path":"platform/mellanox/mlnx-platform-api/sonic_platform/fan.py","position":4,"original_position":4,"commit_id":"c202771cd59e78b16755dcee988fc834bcaf330f","original_commit_id":"c202771cd59e78b16755dcee988fc834bcaf330f","user":{"login":"liat-grozovik","id":44433539,"node_id":"MDQ6VXNlcjQ0NDMzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/44433539?v=4","gravatar_id":"","url":"https://api.github.com/users/liat-grozovik","html_url":"https://github.com/liat-grozovik","followers_url":"https://api.github.com/users/liat-grozovik/followers","following_url":"https://api.github.com/users/liat-grozovik/following{/other_user}","gists_url":"https://api.github.com/users/liat-grozovik/gists{/gist_id}","starred_url":"https://api.github.com/users/liat-grozovik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liat-grozovik/subscriptions","organizations_url":"https://api.github.com/users/liat-grozovik/orgs","repos_url":"https://api.github.com/users/liat-grozovik/repos","events_url":"https://api.github.com/users/liat-grozovik/events{/privacy}","received_events_url":"https://api.github.com/users/liat-grozovik/received_events","type":"User","site_admin":false},"body":"Please dont use acronyms. Use Spectrum-2","created_at":"2019-11-20T06:18:06Z","updated_at":"2019-11-20T06:34:20Z","html_url":"https://github.com/stephenxs/sonic-buildimage/pull/17#discussion_r348307054","pull_request_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/comments/348307054"},"html":{"href":"https://github.com/stephenxs/sonic-buildimage/pull/17#discussion_r348307054"},"pull_request":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17","id":342993593,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyOTkzNTkz","html_url":"https://github.com/stephenxs/sonic-buildimage/pull/17","diff_url":"https://github.com/stephenxs/sonic-buildimage/pull/17.diff","patch_url":"https://github.com/stephenxs/sonic-buildimage/pull/17.patch","issue_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/17","number":17,"state":"open","locked":false,"title":"[Mellanox]support led for fan/psu and fan direction","user":{"login":"stephenxs","id":5379172,"node_id":"MDQ6VXNlcjUzNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5379172?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenxs","html_url":"https://github.com/stephenxs","followers_url":"https://api.github.com/users/stephenxs/followers","following_url":"https://api.github.com/users/stephenxs/following{/other_user}","gists_url":"https://api.github.com/users/stephenxs/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenxs/subscriptions","organizations_url":"https://api.github.com/users/stephenxs/orgs","repos_url":"https://api.github.com/users/stephenxs/repos","events_url":"https://api.github.com/users/stephenxs/events{/privacy}","received_events_url":"https://api.github.com/users/stephenxs/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\nsupport led for fan/psu and fan direction\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\nset led for fan/psu and then check\r\nget fan direction\r\n[test-led-fandir.txt](https://github.com/Azure/sonic-buildimage/files/3867135/test-led-fandir.txt)\r\n\r\n**- Description for the changelog**\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n","created_at":"2019-11-20T03:08:21Z","updated_at":"2019-11-20T06:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e27a1687bcbb2585eeaa7e87f9752a30f34c638a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17/commits","review_comments_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17/comments","review_comment_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/17/comments","statuses_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/statuses/c202771cd59e78b16755dcee988fc834bcaf330f","head":{"label":"stephenxs:led-fan_dir","ref":"led-fan_dir","sha":"c202771cd59e78b16755dcee988fc834bcaf330f","user":{"login":"stephenxs","id":5379172,"node_id":"MDQ6VXNlcjUzNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5379172?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenxs","html_url":"https://github.com/stephenxs","followers_url":"https://api.github.com/users/stephenxs/followers","following_url":"https://api.github.com/users/stephenxs/following{/other_user}","gists_url":"https://api.github.com/users/stephenxs/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenxs/subscriptions","organizations_url":"https://api.github.com/users/stephenxs/orgs","repos_url":"https://api.github.com/users/stephenxs/repos","events_url":"https://api.github.com/users/stephenxs/events{/privacy}","received_events_url":"https://api.github.com/users/stephenxs/received_events","type":"User","site_admin":false},"repo":{"id":196355522,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzNTU1MjI=","name":"sonic-buildimage","full_name":"stephenxs/sonic-buildimage","private":false,"owner":{"login":"stephenxs","id":5379172,"node_id":"MDQ6VXNlcjUzNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5379172?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenxs","html_url":"https://github.com/stephenxs","followers_url":"https://api.github.com/users/stephenxs/followers","following_url":"https://api.github.com/users/stephenxs/following{/other_user}","gists_url":"https://api.github.com/users/stephenxs/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenxs/subscriptions","organizations_url":"https://api.github.com/users/stephenxs/orgs","repos_url":"https://api.github.com/users/stephenxs/repos","events_url":"https://api.github.com/users/stephenxs/events{/privacy}","received_events_url":"https://api.github.com/users/stephenxs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stephenxs/sonic-buildimage","description":"Scripts which perform an installable binary image build for SONiC","fork":true,"url":"https://api.github.com/repos/stephenxs/sonic-buildimage","forks_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/forks","keys_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/teams","hooks_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/hooks","issue_events_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/events{/number}","events_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/events","assignees_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/assignees{/user}","branches_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/branches{/branch}","tags_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/tags","blobs_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/languages","stargazers_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/stargazers","contributors_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/contributors","subscribers_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/subscribers","subscription_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/subscription","commits_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/contents/{+path}","compare_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/merges","archive_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/downloads","issues_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues{/number}","pulls_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/labels{/name}","releases_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/releases{/id}","deployments_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/deployments","created_at":"2019-07-11T08:44:40Z","updated_at":"2019-11-16T04:05:43Z","pushed_at":"2019-11-20T03:08:21Z","git_url":"git://github.com/stephenxs/sonic-buildimage.git","ssh_url":"git@github.com:stephenxs/sonic-buildimage.git","clone_url":"https://github.com/stephenxs/sonic-buildimage.git","svn_url":"https://github.com/stephenxs/sonic-buildimage","homepage":null,"size":12290,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"stephenxs:master","ref":"master","sha":"f9e36d3b0b73c34a10e31951d25b53ddb0eaa949","user":{"login":"stephenxs","id":5379172,"node_id":"MDQ6VXNlcjUzNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5379172?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenxs","html_url":"https://github.com/stephenxs","followers_url":"https://api.github.com/users/stephenxs/followers","following_url":"https://api.github.com/users/stephenxs/following{/other_user}","gists_url":"https://api.github.com/users/stephenxs/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenxs/subscriptions","organizations_url":"https://api.github.com/users/stephenxs/orgs","repos_url":"https://api.github.com/users/stephenxs/repos","events_url":"https://api.github.com/users/stephenxs/events{/privacy}","received_events_url":"https://api.github.com/users/stephenxs/received_events","type":"User","site_admin":false},"repo":{"id":196355522,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzNTU1MjI=","name":"sonic-buildimage","full_name":"stephenxs/sonic-buildimage","private":false,"owner":{"login":"stephenxs","id":5379172,"node_id":"MDQ6VXNlcjUzNzkxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5379172?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenxs","html_url":"https://github.com/stephenxs","followers_url":"https://api.github.com/users/stephenxs/followers","following_url":"https://api.github.com/users/stephenxs/following{/other_user}","gists_url":"https://api.github.com/users/stephenxs/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenxs/subscriptions","organizations_url":"https://api.github.com/users/stephenxs/orgs","repos_url":"https://api.github.com/users/stephenxs/repos","events_url":"https://api.github.com/users/stephenxs/events{/privacy}","received_events_url":"https://api.github.com/users/stephenxs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stephenxs/sonic-buildimage","description":"Scripts which perform an installable binary image build for SONiC","fork":true,"url":"https://api.github.com/repos/stephenxs/sonic-buildimage","forks_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/forks","keys_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/teams","hooks_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/hooks","issue_events_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/events{/number}","events_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/events","assignees_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/assignees{/user}","branches_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/branches{/branch}","tags_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/tags","blobs_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/languages","stargazers_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/stargazers","contributors_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/contributors","subscribers_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/subscribers","subscription_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/subscription","commits_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/contents/{+path}","compare_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/merges","archive_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/downloads","issues_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues{/number}","pulls_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/labels{/name}","releases_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/releases{/id}","deployments_url":"https://api.github.com/repos/stephenxs/sonic-buildimage/deployments","created_at":"2019-07-11T08:44:40Z","updated_at":"2019-11-16T04:05:43Z","pushed_at":"2019-11-20T03:08:21Z","git_url":"git://github.com/stephenxs/sonic-buildimage.git","ssh_url":"git@github.com:stephenxs/sonic-buildimage.git","clone_url":"https://github.com/stephenxs/sonic-buildimage.git","svn_url":"https://github.com/stephenxs/sonic-buildimage","homepage":null,"size":12290,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17"},"html":{"href":"https://github.com/stephenxs/sonic-buildimage/pull/17"},"issue":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/17"},"comments":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/stephenxs/sonic-buildimage/statuses/c202771cd59e78b16755dcee988fc834bcaf330f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"liat-grozovik"}}