{"action":"created","comment":{"url":"https://api.github.com/repos/Guidap/booking.js/pulls/comments/273377164","pull_request_review_id":224256160,"id":273377164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzM3NzE2NA==","diff_hunk":"@@ -4,29 +4,41 @@\n         let _rootElement = null;\n         let _contentElement = null;\n         let _iframeElement = null;\n+        let _frameElement = null;\n+        let isSafaraIos = window.navigator.platform.includes('iPhone') && window.navigator.userAgent.includes('Safari')\n \n         /**\n          * Creates root element for modal to be displayed\n          */\n         let _createRoot = function() {\n             _rootElement = document.createElement('div');\n-            _rootElement.setAttribute('style', 'display:none; position:fixed; left:0; top:0; height:100vh; width:100vw; background-color:rgba(50, 50, 50, 0.5); z-index:99999');\n+            _rootElement.setAttribute('style', 'display:none; position:fixed; left:0; top:0; height:100vh; width:100vw; background-color:rgba(50, 50, 50, 0.5); z-index:99998');\n         };\n \n         /**\n          * Creates backdrop meant to darken website, hold close button and iframe\n          */\n         let _createBackdrop = function() {\n             _contentElement = document.createElement('div');\n-            _contentElement.setAttribute('style', 'position:absolute; left:5vw; top:5vh; width:90vw; height:90vh; box-sizing: border-box; border:1px solid #E0E0E0; background-color:#fff; box-shadow: 0 0 30px rgba(0, 0, 0, 0.3);');\n+            if (isSafaraIos) {\n+                _contentElement.setAttribute('style', 'position:absolute; left:5vw; top:2vh; width:90%; height:85%; box-sizing: content-box; border:1px solid #E0E0E0; background-color:#fff; box-shadow: 0 0 30px rgba(0, 0, 0, 0.3); ');\n+            } else _contentElement.setAttribute('style', 'position:absolute; left:5vw; top:5vh; width:90%; height:90vh; box-sizing: content-box; border:1px solid #E0E0E0; background-color:#fff; box-shadow: 0 0 30px rgba(0, 0, 0, 0.3); ');","path":"src/index.js","position":24,"original_position":24,"commit_id":"5ad6cb4c04ef2abe32b071371017fbea3d80b5f1","original_commit_id":"5ad6cb4c04ef2abe32b071371017fbea3d80b5f1","user":{"login":"SylvainMarty","id":10723351,"node_id":"MDQ6VXNlcjEwNzIzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/10723351?v=4","gravatar_id":"","url":"https://api.github.com/users/SylvainMarty","html_url":"https://github.com/SylvainMarty","followers_url":"https://api.github.com/users/SylvainMarty/followers","following_url":"https://api.github.com/users/SylvainMarty/following{/other_user}","gists_url":"https://api.github.com/users/SylvainMarty/gists{/gist_id}","starred_url":"https://api.github.com/users/SylvainMarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SylvainMarty/subscriptions","organizations_url":"https://api.github.com/users/SylvainMarty/orgs","repos_url":"https://api.github.com/users/SylvainMarty/repos","events_url":"https://api.github.com/users/SylvainMarty/events{/privacy}","received_events_url":"https://api.github.com/users/SylvainMarty/received_events","type":"User","site_admin":false},"body":"Manque les accolades ici :eyes: \r\nEt aussi, peux-tu mettre le style dupliqué dans une variable avant le if et simplement y ajouter tes spécificités pour safari IOS ? Ça évitera la duplication de code","created_at":"2019-04-09T08:24:07Z","updated_at":"2019-04-09T08:24:39Z","html_url":"https://github.com/Guidap/booking.js/pull/10#discussion_r273377164","pull_request_url":"https://api.github.com/repos/Guidap/booking.js/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Guidap/booking.js/pulls/comments/273377164"},"html":{"href":"https://github.com/Guidap/booking.js/pull/10#discussion_r273377164"},"pull_request":{"href":"https://api.github.com/repos/Guidap/booking.js/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Guidap/booking.js/pulls/10","id":259442958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NDQyOTU4","html_url":"https://github.com/Guidap/booking.js/pull/10","diff_url":"https://github.com/Guidap/booking.js/pull/10.diff","patch_url":"https://github.com/Guidap/booking.js/pull/10.patch","issue_url":"https://api.github.com/repos/Guidap/booking.js/issues/10","number":10,"state":"open","locked":false,"title":"Fix/reservation modal ios safari","user":{"login":"ludolaloux13","id":46750688,"node_id":"MDQ6VXNlcjQ2NzUwNjg4","avatar_url":"https://avatars0.githubusercontent.com/u/46750688?v=4","gravatar_id":"","url":"https://api.github.com/users/ludolaloux13","html_url":"https://github.com/ludolaloux13","followers_url":"https://api.github.com/users/ludolaloux13/followers","following_url":"https://api.github.com/users/ludolaloux13/following{/other_user}","gists_url":"https://api.github.com/users/ludolaloux13/gists{/gist_id}","starred_url":"https://api.github.com/users/ludolaloux13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludolaloux13/subscriptions","organizations_url":"https://api.github.com/users/ludolaloux13/orgs","repos_url":"https://api.github.com/users/ludolaloux13/repos","events_url":"https://api.github.com/users/ludolaloux13/events{/privacy}","received_events_url":"https://api.github.com/users/ludolaloux13/received_events","type":"User","site_admin":false},"body":"Works on #1432\r\n\r\nFixing the scrolling and display problem by creating an intermediate div, only on IOS Safari with an specific overflow and the atttribute \"no scrolling\" in the iframe.\r\n","created_at":"2019-03-08T11:13:04Z","updated_at":"2019-04-09T08:24:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b8cd61403c193508c5cc34f20dc1c4fe6a3587f","assignee":{"login":"ludolaloux13","id":46750688,"node_id":"MDQ6VXNlcjQ2NzUwNjg4","avatar_url":"https://avatars0.githubusercontent.com/u/46750688?v=4","gravatar_id":"","url":"https://api.github.com/users/ludolaloux13","html_url":"https://github.com/ludolaloux13","followers_url":"https://api.github.com/users/ludolaloux13/followers","following_url":"https://api.github.com/users/ludolaloux13/following{/other_user}","gists_url":"https://api.github.com/users/ludolaloux13/gists{/gist_id}","starred_url":"https://api.github.com/users/ludolaloux13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludolaloux13/subscriptions","organizations_url":"https://api.github.com/users/ludolaloux13/orgs","repos_url":"https://api.github.com/users/ludolaloux13/repos","events_url":"https://api.github.com/users/ludolaloux13/events{/privacy}","received_events_url":"https://api.github.com/users/ludolaloux13/received_events","type":"User","site_admin":false},"assignees":[{"login":"ludolaloux13","id":46750688,"node_id":"MDQ6VXNlcjQ2NzUwNjg4","avatar_url":"https://avatars0.githubusercontent.com/u/46750688?v=4","gravatar_id":"","url":"https://api.github.com/users/ludolaloux13","html_url":"https://github.com/ludolaloux13","followers_url":"https://api.github.com/users/ludolaloux13/followers","following_url":"https://api.github.com/users/ludolaloux13/following{/other_user}","gists_url":"https://api.github.com/users/ludolaloux13/gists{/gist_id}","starred_url":"https://api.github.com/users/ludolaloux13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludolaloux13/subscriptions","organizations_url":"https://api.github.com/users/ludolaloux13/orgs","repos_url":"https://api.github.com/users/ludolaloux13/repos","events_url":"https://api.github.com/users/ludolaloux13/events{/privacy}","received_events_url":"https://api.github.com/users/ludolaloux13/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Guidap/booking.js/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Guidap/booking.js/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Guidap/booking.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Guidap/booking.js/issues/10/comments","statuses_url":"https://api.github.com/repos/Guidap/booking.js/statuses/5ad6cb4c04ef2abe32b071371017fbea3d80b5f1","head":{"label":"ludolaloux13:fix/reservation-modal-ios-safari","ref":"fix/reservation-modal-ios-safari","sha":"5ad6cb4c04ef2abe32b071371017fbea3d80b5f1","user":{"login":"ludolaloux13","id":46750688,"node_id":"MDQ6VXNlcjQ2NzUwNjg4","avatar_url":"https://avatars0.githubusercontent.com/u/46750688?v=4","gravatar_id":"","url":"https://api.github.com/users/ludolaloux13","html_url":"https://github.com/ludolaloux13","followers_url":"https://api.github.com/users/ludolaloux13/followers","following_url":"https://api.github.com/users/ludolaloux13/following{/other_user}","gists_url":"https://api.github.com/users/ludolaloux13/gists{/gist_id}","starred_url":"https://api.github.com/users/ludolaloux13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludolaloux13/subscriptions","organizations_url":"https://api.github.com/users/ludolaloux13/orgs","repos_url":"https://api.github.com/users/ludolaloux13/repos","events_url":"https://api.github.com/users/ludolaloux13/events{/privacy}","received_events_url":"https://api.github.com/users/ludolaloux13/received_events","type":"User","site_admin":false},"repo":{"id":174319623,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQzMTk2MjM=","name":"booking.js","full_name":"ludolaloux13/booking.js","private":false,"owner":{"login":"ludolaloux13","id":46750688,"node_id":"MDQ6VXNlcjQ2NzUwNjg4","avatar_url":"https://avatars0.githubusercontent.com/u/46750688?v=4","gravatar_id":"","url":"https://api.github.com/users/ludolaloux13","html_url":"https://github.com/ludolaloux13","followers_url":"https://api.github.com/users/ludolaloux13/followers","following_url":"https://api.github.com/users/ludolaloux13/following{/other_user}","gists_url":"https://api.github.com/users/ludolaloux13/gists{/gist_id}","starred_url":"https://api.github.com/users/ludolaloux13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludolaloux13/subscriptions","organizations_url":"https://api.github.com/users/ludolaloux13/orgs","repos_url":"https://api.github.com/users/ludolaloux13/repos","events_url":"https://api.github.com/users/ludolaloux13/events{/privacy}","received_events_url":"https://api.github.com/users/ludolaloux13/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ludolaloux13/booking.js","description":"A public library used to import GUIDAP reservation module on your website 🚀","fork":true,"url":"https://api.github.com/repos/ludolaloux13/booking.js","forks_url":"https://api.github.com/repos/ludolaloux13/booking.js/forks","keys_url":"https://api.github.com/repos/ludolaloux13/booking.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ludolaloux13/booking.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ludolaloux13/booking.js/teams","hooks_url":"https://api.github.com/repos/ludolaloux13/booking.js/hooks","issue_events_url":"https://api.github.com/repos/ludolaloux13/booking.js/issues/events{/number}","events_url":"https://api.github.com/repos/ludolaloux13/booking.js/events","assignees_url":"https://api.github.com/repos/ludolaloux13/booking.js/assignees{/user}","branches_url":"https://api.github.com/repos/ludolaloux13/booking.js/branches{/branch}","tags_url":"https://api.github.com/repos/ludolaloux13/booking.js/tags","blobs_url":"https://api.github.com/repos/ludolaloux13/booking.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ludolaloux13/booking.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ludolaloux13/booking.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ludolaloux13/booking.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ludolaloux13/booking.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ludolaloux13/booking.js/languages","stargazers_url":"https://api.github.com/repos/ludolaloux13/booking.js/stargazers","contributors_url":"https://api.github.com/repos/ludolaloux13/booking.js/contributors","subscribers_url":"https://api.github.com/repos/ludolaloux13/booking.js/subscribers","subscription_url":"https://api.github.com/repos/ludolaloux13/booking.js/subscription","commits_url":"https://api.github.com/repos/ludolaloux13/booking.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ludolaloux13/booking.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ludolaloux13/booking.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ludolaloux13/booking.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ludolaloux13/booking.js/contents/{+path}","compare_url":"https://api.github.com/repos/ludolaloux13/booking.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ludolaloux13/booking.js/merges","archive_url":"https://api.github.com/repos/ludolaloux13/booking.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ludolaloux13/booking.js/downloads","issues_url":"https://api.github.com/repos/ludolaloux13/booking.js/issues{/number}","pulls_url":"https://api.github.com/repos/ludolaloux13/booking.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ludolaloux13/booking.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ludolaloux13/booking.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ludolaloux13/booking.js/labels{/name}","releases_url":"https://api.github.com/repos/ludolaloux13/booking.js/releases{/id}","deployments_url":"https://api.github.com/repos/ludolaloux13/booking.js/deployments","created_at":"2019-03-07T10:05:47Z","updated_at":"2019-03-07T10:05:49Z","pushed_at":"2019-03-11T14:21:25Z","git_url":"git://github.com/ludolaloux13/booking.js.git","ssh_url":"git@github.com:ludolaloux13/booking.js.git","clone_url":"https://github.com/ludolaloux13/booking.js.git","svn_url":"https://github.com/ludolaloux13/booking.js","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Guidap:develop","ref":"develop","sha":"5cee9fd8867ab58933f611b788f3704f44f329e6","user":{"login":"Guidap","id":29726304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzI2MzA0","avatar_url":"https://avatars3.githubusercontent.com/u/29726304?v=4","gravatar_id":"","url":"https://api.github.com/users/Guidap","html_url":"https://github.com/Guidap","followers_url":"https://api.github.com/users/Guidap/followers","following_url":"https://api.github.com/users/Guidap/following{/other_user}","gists_url":"https://api.github.com/users/Guidap/gists{/gist_id}","starred_url":"https://api.github.com/users/Guidap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guidap/subscriptions","organizations_url":"https://api.github.com/users/Guidap/orgs","repos_url":"https://api.github.com/users/Guidap/repos","events_url":"https://api.github.com/users/Guidap/events{/privacy}","received_events_url":"https://api.github.com/users/Guidap/received_events","type":"Organization","site_admin":false},"repo":{"id":150968999,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA5Njg5OTk=","name":"booking.js","full_name":"Guidap/booking.js","private":false,"owner":{"login":"Guidap","id":29726304,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzI2MzA0","avatar_url":"https://avatars3.githubusercontent.com/u/29726304?v=4","gravatar_id":"","url":"https://api.github.com/users/Guidap","html_url":"https://github.com/Guidap","followers_url":"https://api.github.com/users/Guidap/followers","following_url":"https://api.github.com/users/Guidap/following{/other_user}","gists_url":"https://api.github.com/users/Guidap/gists{/gist_id}","starred_url":"https://api.github.com/users/Guidap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guidap/subscriptions","organizations_url":"https://api.github.com/users/Guidap/orgs","repos_url":"https://api.github.com/users/Guidap/repos","events_url":"https://api.github.com/users/Guidap/events{/privacy}","received_events_url":"https://api.github.com/users/Guidap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Guidap/booking.js","description":"A public library used to import GUIDAP reservation module on your website 🚀","fork":false,"url":"https://api.github.com/repos/Guidap/booking.js","forks_url":"https://api.github.com/repos/Guidap/booking.js/forks","keys_url":"https://api.github.com/repos/Guidap/booking.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Guidap/booking.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Guidap/booking.js/teams","hooks_url":"https://api.github.com/repos/Guidap/booking.js/hooks","issue_events_url":"https://api.github.com/repos/Guidap/booking.js/issues/events{/number}","events_url":"https://api.github.com/repos/Guidap/booking.js/events","assignees_url":"https://api.github.com/repos/Guidap/booking.js/assignees{/user}","branches_url":"https://api.github.com/repos/Guidap/booking.js/branches{/branch}","tags_url":"https://api.github.com/repos/Guidap/booking.js/tags","blobs_url":"https://api.github.com/repos/Guidap/booking.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Guidap/booking.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Guidap/booking.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Guidap/booking.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Guidap/booking.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Guidap/booking.js/languages","stargazers_url":"https://api.github.com/repos/Guidap/booking.js/stargazers","contributors_url":"https://api.github.com/repos/Guidap/booking.js/contributors","subscribers_url":"https://api.github.com/repos/Guidap/booking.js/subscribers","subscription_url":"https://api.github.com/repos/Guidap/booking.js/subscription","commits_url":"https://api.github.com/repos/Guidap/booking.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Guidap/booking.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Guidap/booking.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Guidap/booking.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Guidap/booking.js/contents/{+path}","compare_url":"https://api.github.com/repos/Guidap/booking.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Guidap/booking.js/merges","archive_url":"https://api.github.com/repos/Guidap/booking.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Guidap/booking.js/downloads","issues_url":"https://api.github.com/repos/Guidap/booking.js/issues{/number}","pulls_url":"https://api.github.com/repos/Guidap/booking.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Guidap/booking.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Guidap/booking.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Guidap/booking.js/labels{/name}","releases_url":"https://api.github.com/repos/Guidap/booking.js/releases{/id}","deployments_url":"https://api.github.com/repos/Guidap/booking.js/deployments","created_at":"2018-09-30T13:19:12Z","updated_at":"2018-10-11T12:23:40Z","pushed_at":"2019-03-11T14:21:26Z","git_url":"git://github.com/Guidap/booking.js.git","ssh_url":"git@github.com:Guidap/booking.js.git","clone_url":"https://github.com/Guidap/booking.js.git","svn_url":"https://github.com/Guidap/booking.js","homepage":null,"size":75,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Guidap/booking.js/pulls/10"},"html":{"href":"https://github.com/Guidap/booking.js/pull/10"},"issue":{"href":"https://api.github.com/repos/Guidap/booking.js/issues/10"},"comments":{"href":"https://api.github.com/repos/Guidap/booking.js/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Guidap/booking.js/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Guidap/booking.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Guidap/booking.js/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Guidap/booking.js/statuses/5ad6cb4c04ef2abe32b071371017fbea3d80b5f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"SylvainMarty"}}