{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/278497712","pull_request_review_id":230578547,"id":278497712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODQ5NzcxMg==","diff_hunk":"@@ -15,6 +15,10 @@ namespace react {\n \n class JSCExecutorFactory : public JSExecutorFactory {\n public:\n+  explicit JSCExecutorFactory(","path":"React/CxxBridge/JSCExecutorFactory.h","position":11,"original_position":4,"commit_id":"319d2da9c7e4ff5e8a1faf77bfb4490f7894cfe4","original_commit_id":"319d2da9c7e4ff5e8a1faf77bfb4490f7894cfe4","user":{"login":"karanjthakkar","id":1824298,"node_id":"MDQ6VXNlcjE4MjQyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1824298?v=4","gravatar_id":"","url":"https://api.github.com/users/karanjthakkar","html_url":"https://github.com/karanjthakkar","followers_url":"https://api.github.com/users/karanjthakkar/followers","following_url":"https://api.github.com/users/karanjthakkar/following{/other_user}","gists_url":"https://api.github.com/users/karanjthakkar/gists{/gist_id}","starred_url":"https://api.github.com/users/karanjthakkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanjthakkar/subscriptions","organizations_url":"https://api.github.com/users/karanjthakkar/orgs","repos_url":"https://api.github.com/users/karanjthakkar/repos","events_url":"https://api.github.com/users/karanjthakkar/events{/privacy}","received_events_url":"https://api.github.com/users/karanjthakkar/received_events","type":"User","site_admin":false},"body":"This change is needed to make the [RNTester turbo module](https://github.com/facebook/react-native/blob/421ffb05aeb7ccf7013425bdac6b14372325bb26/RNTester/RNTester/AppDelegate.mm#L137) example work.","created_at":"2019-04-25T10:53:10Z","updated_at":"2019-04-25T10:53:10Z","html_url":"https://github.com/facebook/react-native/pull/23851#discussion_r278497712","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/23851","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/278497712"},"html":{"href":"https://github.com/facebook/react-native/pull/23851#discussion_r278497712"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/23851"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/23851","id":259976609,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5OTc2NjA5","html_url":"https://github.com/facebook/react-native/pull/23851","diff_url":"https://github.com/facebook/react-native/pull/23851.diff","patch_url":"https://github.com/facebook/react-native/pull/23851.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/23851","number":23851,"state":"open","locked":false,"title":"Fix broken perf marker logging for RN > 0.58 on Android","user":{"login":"karanjthakkar","id":1824298,"node_id":"MDQ6VXNlcjE4MjQyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1824298?v=4","gravatar_id":"","url":"https://api.github.com/users/karanjthakkar","html_url":"https://github.com/karanjthakkar","followers_url":"https://api.github.com/users/karanjthakkar/followers","following_url":"https://api.github.com/users/karanjthakkar/following{/other_user}","gists_url":"https://api.github.com/users/karanjthakkar/gists{/gist_id}","starred_url":"https://api.github.com/users/karanjthakkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanjthakkar/subscriptions","organizations_url":"https://api.github.com/users/karanjthakkar/orgs","repos_url":"https://api.github.com/users/karanjthakkar/repos","events_url":"https://api.github.com/users/karanjthakkar/events{/privacy}","received_events_url":"https://api.github.com/users/karanjthakkar/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->\r\n\r\n## Summary\r\n\r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n\r\nFixes #23771 \r\n\r\n## Changelog\r\n\r\n<!-- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. -->\r\n\r\n[Android] [Fixed] - Fix broken perf marker logging for RN > 0.58 on Android\r\n\r\n## Test Plan\r\n\r\n<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->\r\n\r\nThe relevant markers are now logged whenever you initialise RN bridge.","created_at":"2019-03-11T13:53:39Z","updated_at":"2019-04-25T10:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07786684653b0dc236bb526f198f278b6ea3b8c8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mhorowitz","id":290225,"node_id":"MDQ6VXNlcjI5MDIyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/290225?v=4","gravatar_id":"","url":"https://api.github.com/users/mhorowitz","html_url":"https://github.com/mhorowitz","followers_url":"https://api.github.com/users/mhorowitz/followers","following_url":"https://api.github.com/users/mhorowitz/following{/other_user}","gists_url":"https://api.github.com/users/mhorowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/mhorowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhorowitz/subscriptions","organizations_url":"https://api.github.com/users/mhorowitz/orgs","repos_url":"https://api.github.com/users/mhorowitz/repos","events_url":"https://api.github.com/users/mhorowitz/events{/privacy}","received_events_url":"https://api.github.com/users/mhorowitz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false},{"id":869759799,"node_id":"MDU6TGFiZWw4Njk3NTk3OTk=","url":"https://api.github.com/repos/facebook/react-native/labels/Includes%20Changelog","name":"Includes Changelog","color":"0e8a16","default":false},{"id":870851515,"node_id":"MDU6TGFiZWw4NzA4NTE1MTU=","url":"https://api.github.com/repos/facebook/react-native/labels/Platform:%20Android","name":"Platform: Android","color":"bfd4f2","default":false},{"id":869764092,"node_id":"MDU6TGFiZWw4Njk3NjQwOTI=","url":"https://api.github.com/repos/facebook/react-native/labels/Type:%20Bug%20Fix%F0%9F%90%9B","name":"Type: Bug Fix🐛","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/23851/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/23851/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/23851/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/319d2da9c7e4ff5e8a1faf77bfb4490f7894cfe4","head":{"label":"karanjthakkar:fix_react_markers","ref":"fix_react_markers","sha":"319d2da9c7e4ff5e8a1faf77bfb4490f7894cfe4","user":{"login":"karanjthakkar","id":1824298,"node_id":"MDQ6VXNlcjE4MjQyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1824298?v=4","gravatar_id":"","url":"https://api.github.com/users/karanjthakkar","html_url":"https://github.com/karanjthakkar","followers_url":"https://api.github.com/users/karanjthakkar/followers","following_url":"https://api.github.com/users/karanjthakkar/following{/other_user}","gists_url":"https://api.github.com/users/karanjthakkar/gists{/gist_id}","starred_url":"https://api.github.com/users/karanjthakkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanjthakkar/subscriptions","organizations_url":"https://api.github.com/users/karanjthakkar/orgs","repos_url":"https://api.github.com/users/karanjthakkar/repos","events_url":"https://api.github.com/users/karanjthakkar/events{/privacy}","received_events_url":"https://api.github.com/users/karanjthakkar/received_events","type":"User","site_admin":false},"repo":{"id":86374238,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM3NDIzOA==","name":"react-native","full_name":"karanjthakkar/react-native","private":false,"owner":{"login":"karanjthakkar","id":1824298,"node_id":"MDQ6VXNlcjE4MjQyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1824298?v=4","gravatar_id":"","url":"https://api.github.com/users/karanjthakkar","html_url":"https://github.com/karanjthakkar","followers_url":"https://api.github.com/users/karanjthakkar/followers","following_url":"https://api.github.com/users/karanjthakkar/following{/other_user}","gists_url":"https://api.github.com/users/karanjthakkar/gists{/gist_id}","starred_url":"https://api.github.com/users/karanjthakkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanjthakkar/subscriptions","organizations_url":"https://api.github.com/users/karanjthakkar/orgs","repos_url":"https://api.github.com/users/karanjthakkar/repos","events_url":"https://api.github.com/users/karanjthakkar/events{/privacy}","received_events_url":"https://api.github.com/users/karanjthakkar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karanjthakkar/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/karanjthakkar/react-native","forks_url":"https://api.github.com/repos/karanjthakkar/react-native/forks","keys_url":"https://api.github.com/repos/karanjthakkar/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karanjthakkar/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karanjthakkar/react-native/teams","hooks_url":"https://api.github.com/repos/karanjthakkar/react-native/hooks","issue_events_url":"https://api.github.com/repos/karanjthakkar/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/karanjthakkar/react-native/events","assignees_url":"https://api.github.com/repos/karanjthakkar/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/karanjthakkar/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/karanjthakkar/react-native/tags","blobs_url":"https://api.github.com/repos/karanjthakkar/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karanjthakkar/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karanjthakkar/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/karanjthakkar/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karanjthakkar/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/karanjthakkar/react-native/languages","stargazers_url":"https://api.github.com/repos/karanjthakkar/react-native/stargazers","contributors_url":"https://api.github.com/repos/karanjthakkar/react-native/contributors","subscribers_url":"https://api.github.com/repos/karanjthakkar/react-native/subscribers","subscription_url":"https://api.github.com/repos/karanjthakkar/react-native/subscription","commits_url":"https://api.github.com/repos/karanjthakkar/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/karanjthakkar/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/karanjthakkar/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/karanjthakkar/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/karanjthakkar/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/karanjthakkar/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karanjthakkar/react-native/merges","archive_url":"https://api.github.com/repos/karanjthakkar/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karanjthakkar/react-native/downloads","issues_url":"https://api.github.com/repos/karanjthakkar/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/karanjthakkar/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/karanjthakkar/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/karanjthakkar/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karanjthakkar/react-native/labels{/name}","releases_url":"https://api.github.com/repos/karanjthakkar/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/karanjthakkar/react-native/deployments","created_at":"2017-03-27T19:12:18Z","updated_at":"2019-04-25T09:49:27Z","pushed_at":"2019-04-25T10:51:51Z","git_url":"git://github.com/karanjthakkar/react-native.git","ssh_url":"git@github.com:karanjthakkar/react-native.git","clone_url":"https://github.com/karanjthakkar/react-native.git","svn_url":"https://github.com/karanjthakkar/react-native","homepage":"http://facebook.github.io/react-native/","size":279220,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"421ffb05aeb7ccf7013425bdac6b14372325bb26","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"node_id":"MDEwOlJlcG9zaXRvcnkyOTAyODc3NQ==","name":"react-native","full_name":"facebook/react-native","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2019-04-25T10:49:01Z","pushed_at":"2019-04-25T10:51:56Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"https://facebook.github.io/react-native/","size":332886,"stargazers_count":76399,"watchers_count":76399,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17038,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":490,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17038,"open_issues":490,"watchers":76399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/23851"},"html":{"href":"https://github.com/facebook/react-native/pull/23851"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/23851"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/23851/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/23851/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/23851/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/319d2da9c7e4ff5e8a1faf77bfb4490f7894cfe4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"karanjthakkar"}}