{"push_id":3455044142,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"47ced23812b8d2cb2380da29576bf8187e1daa69","before":"3619fbf01ed71d9d404c78cb19309d56acc4b9d7","commits":[{"sha":"47ced23812b8d2cb2380da29576bf8187e1daa69","author":{"name":"Lucas Werkmeister","email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@lucaswerkmeister.de"},"message":"Catch permission errors when getting unpatrolled revisions\n\nUsers who are not autoconfirmed are not allowed to retrieve unpatrolled\nrecent changes; previously, this would result in an internal server\nerror. We now catch this error and present it to the user, with the most\nlikely cause.\n\nThe error page is more vague than it needs to be: if we wanted to, we\ncould get the user’s groups and rights, and check if they are\nautoconfirmed and/or do or don’t have the required rights. But that just\nraises the question of what error to show if it’s not the expected case\nof “user is not autoconfirmed”. Since I’m not aware of other cases where\nthis would happen, I prefer to keep the error page vague like this.\n\n(We have to wrap the whole loop in a try/catch – unpatrolled_changes()\nis a generator, and any exception it raises is only thrown once we start\nto iterate it, extracting the unpatrolled_changes() call into a variable\nand wrapping just that doesn’t work.)\n\nThanks to blinry for finding this bug and testing the fix!\nhttps://twitter.com/blinry/status/1111590362349477889","distinct":true,"url":"https://api.github.com/repos/lucaswerkmeister/tool-speedpatrolling/commits/47ced23812b8d2cb2380da29576bf8187e1daa69"}]}
{"actor":{"display_login":"lucaswerkmeister"}}