{"action":"closed","number":83,"pull_request":{"url":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/83","id":323073805,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMDczODA1","html_url":"https://github.com/cds-snc/node-starter-app/pull/83","diff_url":"https://github.com/cds-snc/node-starter-app/pull/83.diff","patch_url":"https://github.com/cds-snc/node-starter-app/pull/83.patch","issue_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues/83","number":83,"state":"closed","locked":false,"title":"Localized URL paths","user":{"login":"jneen","id":225017,"node_id":"MDQ6VXNlcjIyNTAxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/225017?v=4","gravatar_id":"","url":"https://api.github.com/users/jneen","html_url":"https://github.com/jneen","followers_url":"https://api.github.com/users/jneen/followers","following_url":"https://api.github.com/users/jneen/following{/other_user}","gists_url":"https://api.github.com/users/jneen/gists{/gist_id}","starred_url":"https://api.github.com/users/jneen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jneen/subscriptions","organizations_url":"https://api.github.com/users/jneen/orgs","repos_url":"https://api.github.com/users/jneen/repos","events_url":"https://api.github.com/users/jneen/events{/privacy}","received_events_url":"https://api.github.com/users/jneen/received_events","type":"User","site_admin":false},"body":"A proposal to address #58, depends on #82. The idea is to insert a `LocaleGroup` at the root of the tree, and use two separate routing tables. This means we call each controller function twice, so we can register both paths.","created_at":"2019-10-01T04:19:36Z","updated_at":"2019-10-03T21:28:10Z","closed_at":"2019-10-03T21:28:10Z","merged_at":null,"merge_commit_sha":"d521b0b279d566ba2082d8735cd8dc1f4c69a731","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/83/commits","review_comments_url":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/83/comments","review_comment_url":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues/83/comments","statuses_url":"https://api.github.com/repos/cds-snc/node-starter-app/statuses/377417dcedea31081c9c9a9b2cac2e3c9d28d942","head":{"label":"cds-snc:feature.localized-urls","ref":"feature.localized-urls","sha":"377417dcedea31081c9c9a9b2cac2e3c9d28d942","user":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":205173590,"node_id":"MDEwOlJlcG9zaXRvcnkyMDUxNzM1OTA=","name":"node-starter-app","full_name":"cds-snc/node-starter-app","private":false,"owner":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cds-snc/node-starter-app","description":"Quick start application setup.... because you have to start somewhere.","fork":false,"url":"https://api.github.com/repos/cds-snc/node-starter-app","forks_url":"https://api.github.com/repos/cds-snc/node-starter-app/forks","keys_url":"https://api.github.com/repos/cds-snc/node-starter-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/node-starter-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/node-starter-app/teams","hooks_url":"https://api.github.com/repos/cds-snc/node-starter-app/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/node-starter-app/events","assignees_url":"https://api.github.com/repos/cds-snc/node-starter-app/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/node-starter-app/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/node-starter-app/tags","blobs_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/node-starter-app/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/node-starter-app/languages","stargazers_url":"https://api.github.com/repos/cds-snc/node-starter-app/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/node-starter-app/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/node-starter-app/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/node-starter-app/subscription","commits_url":"https://api.github.com/repos/cds-snc/node-starter-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/node-starter-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/node-starter-app/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/node-starter-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/node-starter-app/merges","archive_url":"https://api.github.com/repos/cds-snc/node-starter-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/node-starter-app/downloads","issues_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/node-starter-app/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/node-starter-app/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/node-starter-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/node-starter-app/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/node-starter-app/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/node-starter-app/deployments","created_at":"2019-08-29T13:45:27Z","updated_at":"2019-10-02T15:44:08Z","pushed_at":"2019-10-03T21:23:42Z","git_url":"git://github.com/cds-snc/node-starter-app.git","ssh_url":"git@github.com:cds-snc/node-starter-app.git","clone_url":"https://github.com/cds-snc/node-starter-app.git","svn_url":"https://github.com/cds-snc/node-starter-app","homepage":"https://cds-node-starter.herokuapp.com","size":713,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":4,"default_branch":"master"}},"base":{"label":"cds-snc:master","ref":"master","sha":"b32823f7e3ea4a232f84142d05cf497e6fdcc0d1","user":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":205173590,"node_id":"MDEwOlJlcG9zaXRvcnkyMDUxNzM1OTA=","name":"node-starter-app","full_name":"cds-snc/node-starter-app","private":false,"owner":{"login":"cds-snc","id":30166251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTY2MjUx","avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cds-snc/node-starter-app","description":"Quick start application setup.... because you have to start somewhere.","fork":false,"url":"https://api.github.com/repos/cds-snc/node-starter-app","forks_url":"https://api.github.com/repos/cds-snc/node-starter-app/forks","keys_url":"https://api.github.com/repos/cds-snc/node-starter-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/node-starter-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/node-starter-app/teams","hooks_url":"https://api.github.com/repos/cds-snc/node-starter-app/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/node-starter-app/events","assignees_url":"https://api.github.com/repos/cds-snc/node-starter-app/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/node-starter-app/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/node-starter-app/tags","blobs_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/node-starter-app/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/node-starter-app/languages","stargazers_url":"https://api.github.com/repos/cds-snc/node-starter-app/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/node-starter-app/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/node-starter-app/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/node-starter-app/subscription","commits_url":"https://api.github.com/repos/cds-snc/node-starter-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/node-starter-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/node-starter-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/node-starter-app/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/node-starter-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/node-starter-app/merges","archive_url":"https://api.github.com/repos/cds-snc/node-starter-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/node-starter-app/downloads","issues_url":"https://api.github.com/repos/cds-snc/node-starter-app/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/node-starter-app/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/node-starter-app/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/node-starter-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/node-starter-app/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/node-starter-app/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/node-starter-app/deployments","created_at":"2019-08-29T13:45:27Z","updated_at":"2019-10-02T15:44:08Z","pushed_at":"2019-10-03T21:23:42Z","git_url":"git://github.com/cds-snc/node-starter-app.git","ssh_url":"git@github.com:cds-snc/node-starter-app.git","clone_url":"https://github.com/cds-snc/node-starter-app.git","svn_url":"https://github.com/cds-snc/node-starter-app","homepage":"https://cds-node-starter.herokuapp.com","size":713,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/83"},"html":{"href":"https://github.com/cds-snc/node-starter-app/pull/83"},"issue":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/issues/83"},"comments":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/cds-snc/node-starter-app/statuses/377417dcedea31081c9c9a9b2cac2e3c9d28d942"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":15,"additions":150,"deletions":292,"changed_files":17}}
{"actor":{"display_login":"jneen"}}