{"action":"created","comment":{"url":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments/296892560","pull_request_review_id":253629521,"id":296892560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Njg5MjU2MA==","diff_hunk":"@@ -966,6 +968,9 @@ func (app *Application) CascadedDeletion() bool {\n \n func (app *Application) IsRefreshRequested() (RefreshType, bool) {\n \trefreshType := RefreshTypeNormal\n+\tif app.Spec.Alwayshardrefresh {\n+\t\trefreshType = RefreshTypeHard\n+\t}\n \tannotations := app.GetAnnotations()\n \tif annotations == nil {\n \t\treturn refreshType, false","path":"pkg/apis/application/v1alpha1/types.go","position":18,"original_position":18,"commit_id":"72cb90a1f176c4906cab325c5334916d4478acfb","original_commit_id":"72cb90a1f176c4906cab325c5334916d4478acfb","user":{"login":"tafkam","id":11283594,"node_id":"MDQ6VXNlcjExMjgzNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/11283594?v=4","gravatar_id":"","url":"https://api.github.com/users/tafkam","html_url":"https://github.com/tafkam","followers_url":"https://api.github.com/users/tafkam/followers","following_url":"https://api.github.com/users/tafkam/following{/other_user}","gists_url":"https://api.github.com/users/tafkam/gists{/gist_id}","starred_url":"https://api.github.com/users/tafkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafkam/subscriptions","organizations_url":"https://api.github.com/users/tafkam/orgs","repos_url":"https://api.github.com/users/tafkam/repos","events_url":"https://api.github.com/users/tafkam/events{/privacy}","received_events_url":"https://api.github.com/users/tafkam/received_events","type":"User","site_admin":false},"body":"I'm not sure what you mean here. I have to explicitly overwrite the pre-defined variable refreshType. If I define refreshType in a if-statement, golang will throw undefined variable build errors, since neither option in the if-statement might be used.","created_at":"2019-06-24T20:05:42Z","updated_at":"2019-06-24T20:05:42Z","html_url":"https://github.com/argoproj/argo-cd/pull/1794#discussion_r296892560","pull_request_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments/296892560"},"html":{"href":"https://github.com/argoproj/argo-cd/pull/1794#discussion_r296892560"},"pull_request":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794"}},"in_reply_to_id":296844468},"pull_request":{"url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794","id":290308511,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwMzA4NTEx","html_url":"https://github.com/argoproj/argo-cd/pull/1794","diff_url":"https://github.com/argoproj/argo-cd/pull/1794.diff","patch_url":"https://github.com/argoproj/argo-cd/pull/1794.patch","issue_url":"https://api.github.com/repos/argoproj/argo-cd/issues/1794","number":1794,"state":"open","locked":false,"title":"Application option for always using hard-refresh","user":{"login":"tafkam","id":11283594,"node_id":"MDQ6VXNlcjExMjgzNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/11283594?v=4","gravatar_id":"","url":"https://api.github.com/users/tafkam","html_url":"https://github.com/tafkam","followers_url":"https://api.github.com/users/tafkam/followers","following_url":"https://api.github.com/users/tafkam/following{/other_user}","gists_url":"https://api.github.com/users/tafkam/gists{/gist_id}","starred_url":"https://api.github.com/users/tafkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafkam/subscriptions","organizations_url":"https://api.github.com/users/tafkam/orgs","repos_url":"https://api.github.com/users/tafkam/repos","events_url":"https://api.github.com/users/tafkam/events{/privacy}","received_events_url":"https://api.github.com/users/tafkam/received_events","type":"User","site_admin":false},"body":"Application option for always using hard-refresh. Tested on minikube with kustomize remote bases. Mentioned in #1646.\r\n\r\nThis is my first try in golang, so I have no idea what I'm doing! ;-) Couldn't figure out the different use-cases in func needRefreshAppStatus, so I added the check for the new option at the top.\r\nAdded a few bits to the logging output for debugging purposes, holler me if you want them removed.\r\n","created_at":"2019-06-20T17:30:34Z","updated_at":"2019-06-24T20:05:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fc4a0396985ded087e910ee590024f09649a037","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jessesuen","id":12677113,"node_id":"MDQ6VXNlcjEyNjc3MTEz","avatar_url":"https://avatars0.githubusercontent.com/u/12677113?v=4","gravatar_id":"","url":"https://api.github.com/users/jessesuen","html_url":"https://github.com/jessesuen","followers_url":"https://api.github.com/users/jessesuen/followers","following_url":"https://api.github.com/users/jessesuen/following{/other_user}","gists_url":"https://api.github.com/users/jessesuen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesuen/subscriptions","organizations_url":"https://api.github.com/users/jessesuen/orgs","repos_url":"https://api.github.com/users/jessesuen/repos","events_url":"https://api.github.com/users/jessesuen/events{/privacy}","received_events_url":"https://api.github.com/users/jessesuen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794/commits","review_comments_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794/comments","review_comment_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/argoproj/argo-cd/issues/1794/comments","statuses_url":"https://api.github.com/repos/argoproj/argo-cd/statuses/72cb90a1f176c4906cab325c5334916d4478acfb","head":{"label":"tafkam:master","ref":"master","sha":"72cb90a1f176c4906cab325c5334916d4478acfb","user":{"login":"tafkam","id":11283594,"node_id":"MDQ6VXNlcjExMjgzNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/11283594?v=4","gravatar_id":"","url":"https://api.github.com/users/tafkam","html_url":"https://github.com/tafkam","followers_url":"https://api.github.com/users/tafkam/followers","following_url":"https://api.github.com/users/tafkam/following{/other_user}","gists_url":"https://api.github.com/users/tafkam/gists{/gist_id}","starred_url":"https://api.github.com/users/tafkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafkam/subscriptions","organizations_url":"https://api.github.com/users/tafkam/orgs","repos_url":"https://api.github.com/users/tafkam/repos","events_url":"https://api.github.com/users/tafkam/events{/privacy}","received_events_url":"https://api.github.com/users/tafkam/received_events","type":"User","site_admin":false},"repo":{"id":192895524,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI4OTU1MjQ=","name":"argo-cd","full_name":"tafkam/argo-cd","private":false,"owner":{"login":"tafkam","id":11283594,"node_id":"MDQ6VXNlcjExMjgzNTk0","avatar_url":"https://avatars2.githubusercontent.com/u/11283594?v=4","gravatar_id":"","url":"https://api.github.com/users/tafkam","html_url":"https://github.com/tafkam","followers_url":"https://api.github.com/users/tafkam/followers","following_url":"https://api.github.com/users/tafkam/following{/other_user}","gists_url":"https://api.github.com/users/tafkam/gists{/gist_id}","starred_url":"https://api.github.com/users/tafkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafkam/subscriptions","organizations_url":"https://api.github.com/users/tafkam/orgs","repos_url":"https://api.github.com/users/tafkam/repos","events_url":"https://api.github.com/users/tafkam/events{/privacy}","received_events_url":"https://api.github.com/users/tafkam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tafkam/argo-cd","description":"Declarative continuous deployment for Kubernetes.","fork":true,"url":"https://api.github.com/repos/tafkam/argo-cd","forks_url":"https://api.github.com/repos/tafkam/argo-cd/forks","keys_url":"https://api.github.com/repos/tafkam/argo-cd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tafkam/argo-cd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tafkam/argo-cd/teams","hooks_url":"https://api.github.com/repos/tafkam/argo-cd/hooks","issue_events_url":"https://api.github.com/repos/tafkam/argo-cd/issues/events{/number}","events_url":"https://api.github.com/repos/tafkam/argo-cd/events","assignees_url":"https://api.github.com/repos/tafkam/argo-cd/assignees{/user}","branches_url":"https://api.github.com/repos/tafkam/argo-cd/branches{/branch}","tags_url":"https://api.github.com/repos/tafkam/argo-cd/tags","blobs_url":"https://api.github.com/repos/tafkam/argo-cd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tafkam/argo-cd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tafkam/argo-cd/git/refs{/sha}","trees_url":"https://api.github.com/repos/tafkam/argo-cd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tafkam/argo-cd/statuses/{sha}","languages_url":"https://api.github.com/repos/tafkam/argo-cd/languages","stargazers_url":"https://api.github.com/repos/tafkam/argo-cd/stargazers","contributors_url":"https://api.github.com/repos/tafkam/argo-cd/contributors","subscribers_url":"https://api.github.com/repos/tafkam/argo-cd/subscribers","subscription_url":"https://api.github.com/repos/tafkam/argo-cd/subscription","commits_url":"https://api.github.com/repos/tafkam/argo-cd/commits{/sha}","git_commits_url":"https://api.github.com/repos/tafkam/argo-cd/git/commits{/sha}","comments_url":"https://api.github.com/repos/tafkam/argo-cd/comments{/number}","issue_comment_url":"https://api.github.com/repos/tafkam/argo-cd/issues/comments{/number}","contents_url":"https://api.github.com/repos/tafkam/argo-cd/contents/{+path}","compare_url":"https://api.github.com/repos/tafkam/argo-cd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tafkam/argo-cd/merges","archive_url":"https://api.github.com/repos/tafkam/argo-cd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tafkam/argo-cd/downloads","issues_url":"https://api.github.com/repos/tafkam/argo-cd/issues{/number}","pulls_url":"https://api.github.com/repos/tafkam/argo-cd/pulls{/number}","milestones_url":"https://api.github.com/repos/tafkam/argo-cd/milestones{/number}","notifications_url":"https://api.github.com/repos/tafkam/argo-cd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tafkam/argo-cd/labels{/name}","releases_url":"https://api.github.com/repos/tafkam/argo-cd/releases{/id}","deployments_url":"https://api.github.com/repos/tafkam/argo-cd/deployments","created_at":"2019-06-20T09:57:17Z","updated_at":"2019-06-20T17:28:51Z","pushed_at":"2019-06-20T17:28:49Z","git_url":"git://github.com/tafkam/argo-cd.git","ssh_url":"git@github.com:tafkam/argo-cd.git","clone_url":"https://github.com/tafkam/argo-cd.git","svn_url":"https://github.com/tafkam/argo-cd","homepage":"https://argoproj.github.io/argo-cd/","size":15011,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"argoproj:master","ref":"master","sha":"024dee09f543ce7bb5af7ca50260504d89dfda94","user":{"login":"argoproj","id":30269780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY5Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"repo":{"id":120896210,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4OTYyMTA=","name":"argo-cd","full_name":"argoproj/argo-cd","private":false,"owner":{"login":"argoproj","id":30269780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY5Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/argoproj/argo-cd","description":"Declarative continuous deployment for Kubernetes.","fork":false,"url":"https://api.github.com/repos/argoproj/argo-cd","forks_url":"https://api.github.com/repos/argoproj/argo-cd/forks","keys_url":"https://api.github.com/repos/argoproj/argo-cd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/argoproj/argo-cd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/argoproj/argo-cd/teams","hooks_url":"https://api.github.com/repos/argoproj/argo-cd/hooks","issue_events_url":"https://api.github.com/repos/argoproj/argo-cd/issues/events{/number}","events_url":"https://api.github.com/repos/argoproj/argo-cd/events","assignees_url":"https://api.github.com/repos/argoproj/argo-cd/assignees{/user}","branches_url":"https://api.github.com/repos/argoproj/argo-cd/branches{/branch}","tags_url":"https://api.github.com/repos/argoproj/argo-cd/tags","blobs_url":"https://api.github.com/repos/argoproj/argo-cd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/argoproj/argo-cd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/argoproj/argo-cd/git/refs{/sha}","trees_url":"https://api.github.com/repos/argoproj/argo-cd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/argoproj/argo-cd/statuses/{sha}","languages_url":"https://api.github.com/repos/argoproj/argo-cd/languages","stargazers_url":"https://api.github.com/repos/argoproj/argo-cd/stargazers","contributors_url":"https://api.github.com/repos/argoproj/argo-cd/contributors","subscribers_url":"https://api.github.com/repos/argoproj/argo-cd/subscribers","subscription_url":"https://api.github.com/repos/argoproj/argo-cd/subscription","commits_url":"https://api.github.com/repos/argoproj/argo-cd/commits{/sha}","git_commits_url":"https://api.github.com/repos/argoproj/argo-cd/git/commits{/sha}","comments_url":"https://api.github.com/repos/argoproj/argo-cd/comments{/number}","issue_comment_url":"https://api.github.com/repos/argoproj/argo-cd/issues/comments{/number}","contents_url":"https://api.github.com/repos/argoproj/argo-cd/contents/{+path}","compare_url":"https://api.github.com/repos/argoproj/argo-cd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/argoproj/argo-cd/merges","archive_url":"https://api.github.com/repos/argoproj/argo-cd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/argoproj/argo-cd/downloads","issues_url":"https://api.github.com/repos/argoproj/argo-cd/issues{/number}","pulls_url":"https://api.github.com/repos/argoproj/argo-cd/pulls{/number}","milestones_url":"https://api.github.com/repos/argoproj/argo-cd/milestones{/number}","notifications_url":"https://api.github.com/repos/argoproj/argo-cd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/argoproj/argo-cd/labels{/name}","releases_url":"https://api.github.com/repos/argoproj/argo-cd/releases{/id}","deployments_url":"https://api.github.com/repos/argoproj/argo-cd/deployments","created_at":"2018-02-09T11:12:01Z","updated_at":"2019-06-24T15:14:29Z","pushed_at":"2019-06-24T19:58:24Z","git_url":"git://github.com/argoproj/argo-cd.git","ssh_url":"git@github.com:argoproj/argo-cd.git","clone_url":"https://github.com/argoproj/argo-cd.git","svn_url":"https://github.com/argoproj/argo-cd","homepage":"https://argoproj.github.io/argo-cd/","size":15127,"stargazers_count":1271,"watchers_count":1271,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":196,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":196,"open_issues":117,"watchers":1271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794"},"html":{"href":"https://github.com/argoproj/argo-cd/pull/1794"},"issue":{"href":"https://api.github.com/repos/argoproj/argo-cd/issues/1794"},"comments":{"href":"https://api.github.com/repos/argoproj/argo-cd/issues/1794/comments"},"review_comments":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794/comments"},"review_comment":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1794/commits"},"statuses":{"href":"https://api.github.com/repos/argoproj/argo-cd/statuses/72cb90a1f176c4906cab325c5334916d4478acfb"}},"author_association":"NONE"}}
{"actor":{"display_login":"tafkam"}}