{"action":"created","issue":{"url":"https://api.github.com/repos/Tiiffi/mcrcon/issues/34","repository_url":"https://api.github.com/repos/Tiiffi/mcrcon","labels_url":"https://api.github.com/repos/Tiiffi/mcrcon/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/Tiiffi/mcrcon/issues/34/comments","events_url":"https://api.github.com/repos/Tiiffi/mcrcon/issues/34/events","html_url":"https://github.com/Tiiffi/mcrcon/pull/34","id":537902561,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMTY3NDc0","number":34,"title":"Adds a `-w` option to throttle commands execution","user":{"login":"HorlogeSkynet","id":5331869,"node_id":"MDQ6VXNlcjUzMzE4Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/5331869?v=4","gravatar_id":"","url":"https://api.github.com/users/HorlogeSkynet","html_url":"https://github.com/HorlogeSkynet","followers_url":"https://api.github.com/users/HorlogeSkynet/followers","following_url":"https://api.github.com/users/HorlogeSkynet/following{/other_user}","gists_url":"https://api.github.com/users/HorlogeSkynet/gists{/gist_id}","starred_url":"https://api.github.com/users/HorlogeSkynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HorlogeSkynet/subscriptions","organizations_url":"https://api.github.com/users/HorlogeSkynet/orgs","repos_url":"https://api.github.com/users/HorlogeSkynet/repos","events_url":"https://api.github.com/users/HorlogeSkynet/events{/privacy}","received_events_url":"https://api.github.com/users/HorlogeSkynet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-12-14T11:34:57Z","updated_at":"2019-12-14T16:57:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Tiiffi/mcrcon/pulls/34","html_url":"https://github.com/Tiiffi/mcrcon/pull/34","diff_url":"https://github.com/Tiiffi/mcrcon/pull/34.diff","patch_url":"https://github.com/Tiiffi/mcrcon/pull/34.patch"},"body":"Hey over here !\r\n\r\nThis is a pretty simple patch implementing a new `-w` option to throttle commands execution (non-interactive mode).\r\nIt could be pretty useful to `say` a message to players before `stop`-ping the server (for instance).\r\n\r\nBye 👋"},"comment":{"url":"https://api.github.com/repos/Tiiffi/mcrcon/issues/comments/565734071","html_url":"https://github.com/Tiiffi/mcrcon/pull/34#issuecomment-565734071","issue_url":"https://api.github.com/repos/Tiiffi/mcrcon/issues/34","id":565734071,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NTczNDA3MQ==","user":{"login":"HorlogeSkynet","id":5331869,"node_id":"MDQ6VXNlcjUzMzE4Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/5331869?v=4","gravatar_id":"","url":"https://api.github.com/users/HorlogeSkynet","html_url":"https://github.com/HorlogeSkynet","followers_url":"https://api.github.com/users/HorlogeSkynet/followers","following_url":"https://api.github.com/users/HorlogeSkynet/following{/other_user}","gists_url":"https://api.github.com/users/HorlogeSkynet/gists{/gist_id}","starred_url":"https://api.github.com/users/HorlogeSkynet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HorlogeSkynet/subscriptions","organizations_url":"https://api.github.com/users/HorlogeSkynet/orgs","repos_url":"https://api.github.com/users/HorlogeSkynet/repos","events_url":"https://api.github.com/users/HorlogeSkynet/events{/privacy}","received_events_url":"https://api.github.com/users/HorlogeSkynet/received_events","type":"User","site_admin":false},"created_at":"2019-12-14T16:57:22Z","updated_at":"2019-12-14T16:57:22Z","author_association":"NONE","body":"Hey back @Tiiffi, thanks for your fast feedback !\r\n\r\nSo I've taken in consideration your comments :\r\n\r\n1. My `master` is now your `develop` with the patch on top of it, and this very PR has been changed to update your `develop` directly ;\r\n2. At the moment there is only one `sleep` occurrence so I've added the macro for Windows' case directly in the `run_commands` function ;\r\n3. A proper `strtol` call now replaces the first naive `atoi` one ;\r\n4. [BONUS] I've updated as well the `run_commands` function, simplifying its logic mostly.\r\n\r\nBye, keep me posted 👋"}}
{"actor":{"display_login":"HorlogeSkynet"}}