{"action":"created","issue":{"url":"https://api.github.com/repos/theelous3/asks/issues/127","repository_url":"https://api.github.com/repos/theelous3/asks","labels_url":"https://api.github.com/repos/theelous3/asks/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/theelous3/asks/issues/127/comments","events_url":"https://api.github.com/repos/theelous3/asks/issues/127/events","html_url":"https://github.com/theelous3/asks/issues/127","id":459000156,"node_id":"MDU6SXNzdWU0NTkwMDAxNTY=","number":127,"title":"can raise RequestTimeout on connection timeout","user":{"login":"belm0","id":1708631,"node_id":"MDQ6VXNlcjE3MDg2MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1708631?v=4","gravatar_id":"","url":"https://api.github.com/users/belm0","html_url":"https://github.com/belm0","followers_url":"https://api.github.com/users/belm0/followers","following_url":"https://api.github.com/users/belm0/following{/other_user}","gists_url":"https://api.github.com/users/belm0/gists{/gist_id}","starred_url":"https://api.github.com/users/belm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belm0/subscriptions","organizations_url":"https://api.github.com/users/belm0/orgs","repos_url":"https://api.github.com/users/belm0/repos","events_url":"https://api.github.com/users/belm0/events{/privacy}","received_events_url":"https://api.github.com/users/belm0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-06-21T04:18:11Z","updated_at":"2019-10-07T10:58:26Z","closed_at":null,"author_association":"NONE","body":"in request():\r\n```\r\nsock = await timeout_manager(\r\n     connection_timeout, self._grab_connection, url)\r\n```\r\nso this is establishing a connection, not making the request.  Yet timeout_manager() will raise RequestTimeout.\r\n\r\nOverall it would be helpful if exception cases are documented for request().\r\n"},"comment":{"url":"https://api.github.com/repos/theelous3/asks/issues/comments/538951705","html_url":"https://github.com/theelous3/asks/issues/127#issuecomment-538951705","issue_url":"https://api.github.com/repos/theelous3/asks/issues/127","id":538951705,"node_id":"MDEyOklzc3VlQ29tbWVudDUzODk1MTcwNQ==","user":{"login":"belm0","id":1708631,"node_id":"MDQ6VXNlcjE3MDg2MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/1708631?v=4","gravatar_id":"","url":"https://api.github.com/users/belm0","html_url":"https://github.com/belm0","followers_url":"https://api.github.com/users/belm0/followers","following_url":"https://api.github.com/users/belm0/following{/other_user}","gists_url":"https://api.github.com/users/belm0/gists{/gist_id}","starred_url":"https://api.github.com/users/belm0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belm0/subscriptions","organizations_url":"https://api.github.com/users/belm0/orgs","repos_url":"https://api.github.com/users/belm0/repos","events_url":"https://api.github.com/users/belm0/events{/privacy}","received_events_url":"https://api.github.com/users/belm0/received_events","type":"User","site_admin":false},"created_at":"2019-10-07T10:58:26Z","updated_at":"2019-10-07T10:58:26Z","author_association":"NONE","body":"> This was resolved in ced7a74\r\n\r\nI don't think so, since that commit predates the problem report by a year."}}
{"actor":{"display_login":"belm0"}}