{"action":"created","comment":{"url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/comments/306886150","pull_request_review_id":266116288,"id":306886150,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjg4NjE1MA==","diff_hunk":"@@ -32,7 +32,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n \r\n #include <OpenColorIO/OpenColorIO.h>\r\n \r\n-#include \"ilmbase/half.h\"\r\n+#include \"OpenEXR/half.h\"\r","path":"src/OpenColorIO/BitDepthUtils.h","position":5,"original_position":5,"commit_id":"e8874cbeb0caab8d1c8f84f97d87e15dccde37e3","original_commit_id":"e8874cbeb0caab8d1c8f84f97d87e15dccde37e3","user":{"login":"michdolan","id":2299963,"node_id":"MDQ6VXNlcjIyOTk5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2299963?v=4","gravatar_id":"","url":"https://api.github.com/users/michdolan","html_url":"https://github.com/michdolan","followers_url":"https://api.github.com/users/michdolan/followers","following_url":"https://api.github.com/users/michdolan/following{/other_user}","gists_url":"https://api.github.com/users/michdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/michdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michdolan/subscriptions","organizations_url":"https://api.github.com/users/michdolan/orgs","repos_url":"https://api.github.com/users/michdolan/repos","events_url":"https://api.github.com/users/michdolan/events{/privacy}","received_events_url":"https://api.github.com/users/michdolan/received_events","type":"User","site_admin":false},"body":"No, just Half, but AFAIK the OpenEXR CMake installs IlmBase headers to OpenEXR/ always. At least that was true in my tests and examples I found. Our previous embedded location appeared to be non-standard. This also made the Find module be able to locate existing installs on systems.","created_at":"2019-07-24T15:47:46Z","updated_at":"2019-07-24T15:47:46Z","html_url":"https://github.com/imageworks/OpenColorIO/pull/771#discussion_r306886150","pull_request_url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/comments/306886150"},"html":{"href":"https://github.com/imageworks/OpenColorIO/pull/771#discussion_r306886150"},"pull_request":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771"}},"in_reply_to_id":306843814},"pull_request":{"url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771","id":298247721,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MjQ3NzIx","html_url":"https://github.com/imageworks/OpenColorIO/pull/771","diff_url":"https://github.com/imageworks/OpenColorIO/pull/771.diff","patch_url":"https://github.com/imageworks/OpenColorIO/pull/771.patch","issue_url":"https://api.github.com/repos/imageworks/OpenColorIO/issues/771","number":771,"state":"open","locked":false,"title":"Remove embedded ext/ dependencies","user":{"login":"michdolan","id":2299963,"node_id":"MDQ6VXNlcjIyOTk5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2299963?v=4","gravatar_id":"","url":"https://api.github.com/users/michdolan","html_url":"https://github.com/michdolan","followers_url":"https://api.github.com/users/michdolan/followers","following_url":"https://api.github.com/users/michdolan/following{/other_user}","gists_url":"https://api.github.com/users/michdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/michdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michdolan/subscriptions","organizations_url":"https://api.github.com/users/michdolan/orgs","repos_url":"https://api.github.com/users/michdolan/repos","events_url":"https://api.github.com/users/michdolan/events{/privacy}","received_events_url":"https://api.github.com/users/michdolan/received_events","type":"User","site_admin":false},"body":"This PR removes these embedded dependencies:\r\n- Expat\r\n- IlmBase (Half)\r\n- LCMS2\r\n- pystring\r\n- yaml-cpp\r\n\r\nBy default, the OCIO build now expects these packages to be available in the build environment. Respective CMake Find modules can either find them in standard locations, or reference package-specific CMake variables hinting at non-standard locations.\r\n\r\nIt was our goal however to also continue offering an easy way to pull and build dependent packages automatically, to maintain the ease of build that users of OCIO have had in the past. A new OCIO_INSTALL_EXT_PACKAGES option is introduced to do just that. Each CMake Find module will check this variable and determine if it should add a dependent install target to the imported target which pulls the source, builds, and statically links packages at build time.\r\n\r\nThere are options to install all dependencies (into ext/ for linking), or just those that are not found on the current system. Please read the new documentation in `installation.rst` (part of this PR) for a more detailed explanation.\r\n\r\nThis PR also addresses a number of doc build errors and compiler warnings related to external dependencies, and adds a weekly cron CI job to try building OCIO against the latest git tag of each of these projects (static analysis is also run in the same cron). Additional install .sh scripts are added to support those efforts.\r\n\r\nI have tested this all quite extensively on Linux, but not at all on macOS or Windows, so chances are it will take some iteration to resolve various build issues in Azure on those platforms.\r\n\r\nAnother PR is coming shortly which adopts the OIIO unittest header, further cleaning up ext/ ( #772 ).\r\n\r\n@jmertic confirmed that the sample ICC license is compatible with OCIO's BSD 3-Clause, so can be kept in our source. I've added an additional copyright statement pertaining to our modifications of the ICC code per his feedback.\r\n\r\nLegal question:\r\nNow that these sources are out of our repo, am I right in thinking we can purge LICENSE.md of the licenses for these cleaned up dependencies?","created_at":"2019-07-16T23:03:20Z","updated_at":"2019-07-24T15:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c60680abd1ba18ee54865111ca9a79aa251f347","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":525411836,"node_id":"MDU6TGFiZWw1MjU0MTE4MzY=","url":"https://api.github.com/repos/imageworks/OpenColorIO/labels/Critical","name":"Critical","color":"b31313","default":false}],"milestone":{"url":"https://api.github.com/repos/imageworks/OpenColorIO/milestones/2","html_url":"https://github.com/imageworks/OpenColorIO/milestone/2","labels_url":"https://api.github.com/repos/imageworks/OpenColorIO/milestones/2/labels","id":95650,"node_id":"MDk6TWlsZXN0b25lOTU2NTA=","number":2,"title":"OCIO 2.0","description":"2.0 does not need to maintain ABI compatibility with 1.0.\r\n\r\n.ocio configs from all previous versions must be readable","creator":{"login":"jeremyselan","id":240544,"node_id":"MDQ6VXNlcjI0MDU0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/240544?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyselan","html_url":"https://github.com/jeremyselan","followers_url":"https://api.github.com/users/jeremyselan/followers","following_url":"https://api.github.com/users/jeremyselan/following{/other_user}","gists_url":"https://api.github.com/users/jeremyselan/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyselan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyselan/subscriptions","organizations_url":"https://api.github.com/users/jeremyselan/orgs","repos_url":"https://api.github.com/users/jeremyselan/repos","events_url":"https://api.github.com/users/jeremyselan/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyselan/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":68,"state":"open","created_at":"2012-03-13T17:08:35Z","updated_at":"2019-07-24T07:05:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771/commits","review_comments_url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771/comments","review_comment_url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imageworks/OpenColorIO/issues/771/comments","statuses_url":"https://api.github.com/repos/imageworks/OpenColorIO/statuses/e8874cbeb0caab8d1c8f84f97d87e15dccde37e3","head":{"label":"michdolan:ext_refactor","ref":"ext_refactor","sha":"e8874cbeb0caab8d1c8f84f97d87e15dccde37e3","user":{"login":"michdolan","id":2299963,"node_id":"MDQ6VXNlcjIyOTk5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2299963?v=4","gravatar_id":"","url":"https://api.github.com/users/michdolan","html_url":"https://github.com/michdolan","followers_url":"https://api.github.com/users/michdolan/followers","following_url":"https://api.github.com/users/michdolan/following{/other_user}","gists_url":"https://api.github.com/users/michdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/michdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michdolan/subscriptions","organizations_url":"https://api.github.com/users/michdolan/orgs","repos_url":"https://api.github.com/users/michdolan/repos","events_url":"https://api.github.com/users/michdolan/events{/privacy}","received_events_url":"https://api.github.com/users/michdolan/received_events","type":"User","site_admin":false},"repo":{"id":125263176,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNjMxNzY=","name":"OpenColorIO","full_name":"michdolan/OpenColorIO","private":false,"owner":{"login":"michdolan","id":2299963,"node_id":"MDQ6VXNlcjIyOTk5NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2299963?v=4","gravatar_id":"","url":"https://api.github.com/users/michdolan","html_url":"https://github.com/michdolan","followers_url":"https://api.github.com/users/michdolan/followers","following_url":"https://api.github.com/users/michdolan/following{/other_user}","gists_url":"https://api.github.com/users/michdolan/gists{/gist_id}","starred_url":"https://api.github.com/users/michdolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michdolan/subscriptions","organizations_url":"https://api.github.com/users/michdolan/orgs","repos_url":"https://api.github.com/users/michdolan/repos","events_url":"https://api.github.com/users/michdolan/events{/privacy}","received_events_url":"https://api.github.com/users/michdolan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michdolan/OpenColorIO","description":"A color management framework for visual effects and animation.","fork":true,"url":"https://api.github.com/repos/michdolan/OpenColorIO","forks_url":"https://api.github.com/repos/michdolan/OpenColorIO/forks","keys_url":"https://api.github.com/repos/michdolan/OpenColorIO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michdolan/OpenColorIO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michdolan/OpenColorIO/teams","hooks_url":"https://api.github.com/repos/michdolan/OpenColorIO/hooks","issue_events_url":"https://api.github.com/repos/michdolan/OpenColorIO/issues/events{/number}","events_url":"https://api.github.com/repos/michdolan/OpenColorIO/events","assignees_url":"https://api.github.com/repos/michdolan/OpenColorIO/assignees{/user}","branches_url":"https://api.github.com/repos/michdolan/OpenColorIO/branches{/branch}","tags_url":"https://api.github.com/repos/michdolan/OpenColorIO/tags","blobs_url":"https://api.github.com/repos/michdolan/OpenColorIO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michdolan/OpenColorIO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michdolan/OpenColorIO/git/refs{/sha}","trees_url":"https://api.github.com/repos/michdolan/OpenColorIO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michdolan/OpenColorIO/statuses/{sha}","languages_url":"https://api.github.com/repos/michdolan/OpenColorIO/languages","stargazers_url":"https://api.github.com/repos/michdolan/OpenColorIO/stargazers","contributors_url":"https://api.github.com/repos/michdolan/OpenColorIO/contributors","subscribers_url":"https://api.github.com/repos/michdolan/OpenColorIO/subscribers","subscription_url":"https://api.github.com/repos/michdolan/OpenColorIO/subscription","commits_url":"https://api.github.com/repos/michdolan/OpenColorIO/commits{/sha}","git_commits_url":"https://api.github.com/repos/michdolan/OpenColorIO/git/commits{/sha}","comments_url":"https://api.github.com/repos/michdolan/OpenColorIO/comments{/number}","issue_comment_url":"https://api.github.com/repos/michdolan/OpenColorIO/issues/comments{/number}","contents_url":"https://api.github.com/repos/michdolan/OpenColorIO/contents/{+path}","compare_url":"https://api.github.com/repos/michdolan/OpenColorIO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michdolan/OpenColorIO/merges","archive_url":"https://api.github.com/repos/michdolan/OpenColorIO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michdolan/OpenColorIO/downloads","issues_url":"https://api.github.com/repos/michdolan/OpenColorIO/issues{/number}","pulls_url":"https://api.github.com/repos/michdolan/OpenColorIO/pulls{/number}","milestones_url":"https://api.github.com/repos/michdolan/OpenColorIO/milestones{/number}","notifications_url":"https://api.github.com/repos/michdolan/OpenColorIO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michdolan/OpenColorIO/labels{/name}","releases_url":"https://api.github.com/repos/michdolan/OpenColorIO/releases{/id}","deployments_url":"https://api.github.com/repos/michdolan/OpenColorIO/deployments","created_at":"2018-03-14T19:25:52Z","updated_at":"2019-07-20T18:51:55Z","pushed_at":"2019-07-24T06:42:13Z","git_url":"git://github.com/michdolan/OpenColorIO.git","ssh_url":"git@github.com:michdolan/OpenColorIO.git","clone_url":"https://github.com/michdolan/OpenColorIO.git","svn_url":"https://github.com/michdolan/OpenColorIO","homepage":"opencolorio.org","size":44497,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"imageworks:master","ref":"master","sha":"91585da10546da1819fe90b690735e904b3ce6c0","user":{"login":"imageworks","id":320618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDYxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/320618?v=4","gravatar_id":"","url":"https://api.github.com/users/imageworks","html_url":"https://github.com/imageworks","followers_url":"https://api.github.com/users/imageworks/followers","following_url":"https://api.github.com/users/imageworks/following{/other_user}","gists_url":"https://api.github.com/users/imageworks/gists{/gist_id}","starred_url":"https://api.github.com/users/imageworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imageworks/subscriptions","organizations_url":"https://api.github.com/users/imageworks/orgs","repos_url":"https://api.github.com/users/imageworks/repos","events_url":"https://api.github.com/users/imageworks/events{/privacy}","received_events_url":"https://api.github.com/users/imageworks/received_events","type":"Organization","site_admin":false},"repo":{"id":775131,"node_id":"MDEwOlJlcG9zaXRvcnk3NzUxMzE=","name":"OpenColorIO","full_name":"imageworks/OpenColorIO","private":false,"owner":{"login":"imageworks","id":320618,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDYxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/320618?v=4","gravatar_id":"","url":"https://api.github.com/users/imageworks","html_url":"https://github.com/imageworks","followers_url":"https://api.github.com/users/imageworks/followers","following_url":"https://api.github.com/users/imageworks/following{/other_user}","gists_url":"https://api.github.com/users/imageworks/gists{/gist_id}","starred_url":"https://api.github.com/users/imageworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imageworks/subscriptions","organizations_url":"https://api.github.com/users/imageworks/orgs","repos_url":"https://api.github.com/users/imageworks/repos","events_url":"https://api.github.com/users/imageworks/events{/privacy}","received_events_url":"https://api.github.com/users/imageworks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/imageworks/OpenColorIO","description":"A color management framework for visual effects and animation.","fork":false,"url":"https://api.github.com/repos/imageworks/OpenColorIO","forks_url":"https://api.github.com/repos/imageworks/OpenColorIO/forks","keys_url":"https://api.github.com/repos/imageworks/OpenColorIO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imageworks/OpenColorIO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imageworks/OpenColorIO/teams","hooks_url":"https://api.github.com/repos/imageworks/OpenColorIO/hooks","issue_events_url":"https://api.github.com/repos/imageworks/OpenColorIO/issues/events{/number}","events_url":"https://api.github.com/repos/imageworks/OpenColorIO/events","assignees_url":"https://api.github.com/repos/imageworks/OpenColorIO/assignees{/user}","branches_url":"https://api.github.com/repos/imageworks/OpenColorIO/branches{/branch}","tags_url":"https://api.github.com/repos/imageworks/OpenColorIO/tags","blobs_url":"https://api.github.com/repos/imageworks/OpenColorIO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imageworks/OpenColorIO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imageworks/OpenColorIO/git/refs{/sha}","trees_url":"https://api.github.com/repos/imageworks/OpenColorIO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imageworks/OpenColorIO/statuses/{sha}","languages_url":"https://api.github.com/repos/imageworks/OpenColorIO/languages","stargazers_url":"https://api.github.com/repos/imageworks/OpenColorIO/stargazers","contributors_url":"https://api.github.com/repos/imageworks/OpenColorIO/contributors","subscribers_url":"https://api.github.com/repos/imageworks/OpenColorIO/subscribers","subscription_url":"https://api.github.com/repos/imageworks/OpenColorIO/subscription","commits_url":"https://api.github.com/repos/imageworks/OpenColorIO/commits{/sha}","git_commits_url":"https://api.github.com/repos/imageworks/OpenColorIO/git/commits{/sha}","comments_url":"https://api.github.com/repos/imageworks/OpenColorIO/comments{/number}","issue_comment_url":"https://api.github.com/repos/imageworks/OpenColorIO/issues/comments{/number}","contents_url":"https://api.github.com/repos/imageworks/OpenColorIO/contents/{+path}","compare_url":"https://api.github.com/repos/imageworks/OpenColorIO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imageworks/OpenColorIO/merges","archive_url":"https://api.github.com/repos/imageworks/OpenColorIO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imageworks/OpenColorIO/downloads","issues_url":"https://api.github.com/repos/imageworks/OpenColorIO/issues{/number}","pulls_url":"https://api.github.com/repos/imageworks/OpenColorIO/pulls{/number}","milestones_url":"https://api.github.com/repos/imageworks/OpenColorIO/milestones{/number}","notifications_url":"https://api.github.com/repos/imageworks/OpenColorIO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imageworks/OpenColorIO/labels{/name}","releases_url":"https://api.github.com/repos/imageworks/OpenColorIO/releases{/id}","deployments_url":"https://api.github.com/repos/imageworks/OpenColorIO/deployments","created_at":"2010-07-14T18:22:06Z","updated_at":"2019-07-24T07:05:57Z","pushed_at":"2019-07-24T13:02:41Z","git_url":"git://github.com/imageworks/OpenColorIO.git","ssh_url":"git@github.com:imageworks/OpenColorIO.git","clone_url":"https://github.com/imageworks/OpenColorIO.git","svn_url":"https://github.com/imageworks/OpenColorIO","homepage":"opencolorio.org","size":44693,"stargazers_count":744,"watchers_count":744,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":213,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":195,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":213,"open_issues":195,"watchers":744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771"},"html":{"href":"https://github.com/imageworks/OpenColorIO/pull/771"},"issue":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/issues/771"},"comments":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/imageworks/OpenColorIO/statuses/e8874cbeb0caab8d1c8f84f97d87e15dccde37e3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michdolan"}}