{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/machine-config-operator/issues/1221","repository_url":"https://api.github.com/repos/openshift/machine-config-operator","labels_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/1221/labels{/name}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/1221/comments","events_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/1221/events","html_url":"https://github.com/openshift/machine-config-operator/pull/1221","id":514061628,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNzM3MDc2","number":1221,"title":"setup-etcd-environment: support scaling from cluster-etcd-operator","user":{"login":"hexfusion","id":1249749,"node_id":"MDQ6VXNlcjEyNDk3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1249749?v=4","gravatar_id":"","url":"https://api.github.com/users/hexfusion","html_url":"https://github.com/hexfusion","followers_url":"https://api.github.com/users/hexfusion/followers","following_url":"https://api.github.com/users/hexfusion/following{/other_user}","gists_url":"https://api.github.com/users/hexfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfusion/subscriptions","organizations_url":"https://api.github.com/users/hexfusion/orgs","repos_url":"https://api.github.com/users/hexfusion/repos","events_url":"https://api.github.com/users/hexfusion/events{/privacy}","received_events_url":"https://api.github.com/users/hexfusion/received_events","type":"User","site_admin":false},"labels":[{"id":1005850192,"node_id":"MDU6TGFiZWwxMDA1ODUwMTky","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1005849393,"node_id":"MDU6TGFiZWwxMDA1ODQ5Mzkz","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1005853548,"node_id":"MDU6TGFiZWwxMDA1ODUzNTQ4","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"retroflexer","id":50588817,"node_id":"MDQ6VXNlcjUwNTg4ODE3","avatar_url":"https://avatars3.githubusercontent.com/u/50588817?v=4","gravatar_id":"","url":"https://api.github.com/users/retroflexer","html_url":"https://github.com/retroflexer","followers_url":"https://api.github.com/users/retroflexer/followers","following_url":"https://api.github.com/users/retroflexer/following{/other_user}","gists_url":"https://api.github.com/users/retroflexer/gists{/gist_id}","starred_url":"https://api.github.com/users/retroflexer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retroflexer/subscriptions","organizations_url":"https://api.github.com/users/retroflexer/orgs","repos_url":"https://api.github.com/users/retroflexer/repos","events_url":"https://api.github.com/users/retroflexer/events{/privacy}","received_events_url":"https://api.github.com/users/retroflexer/received_events","type":"User","site_admin":false},"assignees":[{"login":"retroflexer","id":50588817,"node_id":"MDQ6VXNlcjUwNTg4ODE3","avatar_url":"https://avatars3.githubusercontent.com/u/50588817?v=4","gravatar_id":"","url":"https://api.github.com/users/retroflexer","html_url":"https://github.com/retroflexer","followers_url":"https://api.github.com/users/retroflexer/followers","following_url":"https://api.github.com/users/retroflexer/following{/other_user}","gists_url":"https://api.github.com/users/retroflexer/gists{/gist_id}","starred_url":"https://api.github.com/users/retroflexer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retroflexer/subscriptions","organizations_url":"https://api.github.com/users/retroflexer/orgs","repos_url":"https://api.github.com/users/retroflexer/repos","events_url":"https://api.github.com/users/retroflexer/events{/privacy}","received_events_url":"https://api.github.com/users/retroflexer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2019-10-29T16:38:52Z","updated_at":"2019-11-05T16:18:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/1221","html_url":"https://github.com/openshift/machine-config-operator/pull/1221","diff_url":"https://github.com/openshift/machine-config-operator/pull/1221.diff","patch_url":"https://github.com/openshift/machine-config-operator/pull/1221.patch"},"body":"The discovery init container is a very important part of the bootstraping process. Currently, we use SRV queries to populate ENV variables consumed by other containers in the pod.\r\n\r\nAs we move to an operator managed etcd cluster additional data points and validations need to be performed. The scaling of etcd is managed by the clustermembercontroller (CMC). When a new candidate for membership is verified as `Ready` to join the cluster the CMC populates a ConfigMap with basic information for the scaling process. This information includes details on the current members of the cluster. From this information, we can then populate the ETCD_INITIAL_CLUSTER variable which directs etcd on who its peers are.\r\n\r\nTo manage new candidates from racing only 1 member can scale at a time. Until that member has been added and verified no other member can be added. We do this by doing a wait until we observe the data identifying the pod as scaling.\r\n \r\nWe also populate a new ENV variable  ETCD_ENDPOINTS this is used later on in the process by a new init container called membership.\r\n\r\nPending changes: The following items will change in the near future.\r\n- the `member-config` ConfigMap will stop using annotations for scaling data instead a more traditional `data: ` key.\r\n\r\ndepends on https://github.com/openshift/machine-config-operator/pull/1224"},"comment":{"url":"https://api.github.com/repos/openshift/machine-config-operator/issues/comments/549878024","html_url":"https://github.com/openshift/machine-config-operator/pull/1221#issuecomment-549878024","issue_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/1221","id":549878024,"node_id":"MDEyOklzc3VlQ29tbWVudDU0OTg3ODAyNA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-11-05T15:39:47Z","updated_at":"2019-11-05T15:39:47Z","author_association":"NONE","body":"@hexfusion: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/e2e-aws-scaleup-rhel7 | 37e68516031bead1bc4eefe086648c0f90efcb17 | [link](https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1221/pull-ci-openshift-machine-config-operator-master-e2e-aws-scaleup-rhel7/538) | `/test e2e-aws-scaleup-rhel7`\nci/prow/e2e-gcp-op | 37e68516031bead1bc4eefe086648c0f90efcb17 | [link](https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/1221/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op/319) | `/test e2e-gcp-op`\n\n[Full PR test history](https://prow.svc.ci.openshift.org/pr-history?org=openshift&repo=machine-config-operator&pr=1221). [Your PR dashboard](https://prow.svc.ci.openshift.org/pr?query=is:pr+state:open+author:hexfusion). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/machine-config-operator/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}