{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/comments/326434293","pull_request_review_id":290907923,"id":326434293,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjQzNDI5Mw==","diff_hunk":"@@ -147,7 +150,11 @@ spec:\n                       fieldPath: metadata.name\n                 - name: OPERATOR_NAME\n                   value: cluster-nfd-operator\n+                - name: NODE_FEATURE_DISCOVERY_IMAGE\n+                  value: quay.io/openshift/origin-node-feature-discovery:latest\n+#                  value: \"quay.io/zvonkok/node-feature-discovery:v4.2\"","path":"manifests/olm-catalog/4.2/nfd.v4.2.0.clusterserviceversion.yaml","position":null,"original_position":33,"commit_id":"3d1584187599693ae3c74718321bc70e43a7cbde","original_commit_id":"32eeee093c7739ce670d73fbec9dedeae1f9daf2","user":{"login":"zvonkok","id":3725238,"node_id":"MDQ6VXNlcjM3MjUyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3725238?v=4","gravatar_id":"","url":"https://api.github.com/users/zvonkok","html_url":"https://github.com/zvonkok","followers_url":"https://api.github.com/users/zvonkok/followers","following_url":"https://api.github.com/users/zvonkok/following{/other_user}","gists_url":"https://api.github.com/users/zvonkok/gists{/gist_id}","starred_url":"https://api.github.com/users/zvonkok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvonkok/subscriptions","organizations_url":"https://api.github.com/users/zvonkok/orgs","repos_url":"https://api.github.com/users/zvonkok/repos","events_url":"https://api.github.com/users/zvonkok/events{/privacy}","received_events_url":"https://api.github.com/users/zvonkok/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-09-20T00:37:50Z","updated_at":"2019-09-20T00:37:50Z","html_url":"https://github.com/openshift/cluster-nfd-operator/pull/29#discussion_r326434293","pull_request_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/comments/326434293"},"html":{"href":"https://github.com/openshift/cluster-nfd-operator/pull/29#discussion_r326434293"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29"}},"in_reply_to_id":326293453},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29","id":319378865,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5Mzc4ODY1","html_url":"https://github.com/openshift/cluster-nfd-operator/pull/29","diff_url":"https://github.com/openshift/cluster-nfd-operator/pull/29.diff","patch_url":"https://github.com/openshift/cluster-nfd-operator/pull/29.patch","issue_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/29","number":29,"state":"open","locked":false,"title":"Csv config fixes","user":{"login":"zvonkok","id":3725238,"node_id":"MDQ6VXNlcjM3MjUyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/3725238?v=4","gravatar_id":"","url":"https://api.github.com/users/zvonkok","html_url":"https://github.com/zvonkok","followers_url":"https://api.github.com/users/zvonkok/followers","following_url":"https://api.github.com/users/zvonkok/following{/other_user}","gists_url":"https://api.github.com/users/zvonkok/gists{/gist_id}","starred_url":"https://api.github.com/users/zvonkok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvonkok/subscriptions","organizations_url":"https://api.github.com/users/zvonkok/orgs","repos_url":"https://api.github.com/users/zvonkok/repos","events_url":"https://api.github.com/users/zvonkok/events{/privacy}","received_events_url":"https://api.github.com/users/zvonkok/received_events","type":"User","site_admin":false},"body":"This PR fixes several bugs for NFD.\r\n- Updated CSV with correct version\r\n- Updated CSV and added contact email (`operator-courier` was not complaining)\r\n- Added new state to configure Namespace\r\n- Added namespace to CR for confiruation where to install the operand","created_at":"2019-09-19T17:12:17Z","updated_at":"2019-09-20T00:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6573c21e47dc6cd4309f7e35d0fdce94e357957","assignee":{"login":"sjug","id":7550641,"node_id":"MDQ6VXNlcjc1NTA2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7550641?v=4","gravatar_id":"","url":"https://api.github.com/users/sjug","html_url":"https://github.com/sjug","followers_url":"https://api.github.com/users/sjug/followers","following_url":"https://api.github.com/users/sjug/following{/other_user}","gists_url":"https://api.github.com/users/sjug/gists{/gist_id}","starred_url":"https://api.github.com/users/sjug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjug/subscriptions","organizations_url":"https://api.github.com/users/sjug/orgs","repos_url":"https://api.github.com/users/sjug/repos","events_url":"https://api.github.com/users/sjug/events{/privacy}","received_events_url":"https://api.github.com/users/sjug/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjug","id":7550641,"node_id":"MDQ6VXNlcjc1NTA2NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7550641?v=4","gravatar_id":"","url":"https://api.github.com/users/sjug","html_url":"https://github.com/sjug","followers_url":"https://api.github.com/users/sjug/followers","following_url":"https://api.github.com/users/sjug/following{/other_user}","gists_url":"https://api.github.com/users/sjug/gists{/gist_id}","starred_url":"https://api.github.com/users/sjug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjug/subscriptions","organizations_url":"https://api.github.com/users/sjug/orgs","repos_url":"https://api.github.com/users/sjug/repos","events_url":"https://api.github.com/users/sjug/events{/privacy}","received_events_url":"https://api.github.com/users/sjug/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1111875399,"node_id":"MDU6TGFiZWwxMTExODc1Mzk5","url":"https://api.github.com/repos/openshift/cluster-nfd-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1111882004,"node_id":"MDU6TGFiZWwxMTExODgyMDA0","url":"https://api.github.com/repos/openshift/cluster-nfd-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1111878938,"node_id":"MDU6TGFiZWwxMTExODc4OTM4","url":"https://api.github.com/repos/openshift/cluster-nfd-operator/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/29/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/statuses/3d1584187599693ae3c74718321bc70e43a7cbde","head":{"label":"openshift:csv-config-fixes","ref":"csv-config-fixes","sha":"3d1584187599693ae3c74718321bc70e43a7cbde","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":154893767,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4OTM3Njc=","name":"cluster-nfd-operator","full_name":"openshift/cluster-nfd-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-nfd-operator","description":" The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.","fork":false,"url":"https://api.github.com/repos/openshift/cluster-nfd-operator","forks_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/deployments","created_at":"2018-10-26T20:58:27Z","updated_at":"2019-09-18T23:27:52Z","pushed_at":"2019-09-20T00:09:31Z","git_url":"git://github.com/openshift/cluster-nfd-operator.git","ssh_url":"git@github.com:openshift/cluster-nfd-operator.git","clone_url":"https://github.com/openshift/cluster-nfd-operator.git","svn_url":"https://github.com/openshift/cluster-nfd-operator","homepage":null,"size":19921,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"26c9debbae5b873da5b392ff95b0cfec30b03401","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":154893767,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4OTM3Njc=","name":"cluster-nfd-operator","full_name":"openshift/cluster-nfd-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-nfd-operator","description":" The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.","fork":false,"url":"https://api.github.com/repos/openshift/cluster-nfd-operator","forks_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-nfd-operator/deployments","created_at":"2018-10-26T20:58:27Z","updated_at":"2019-09-18T23:27:52Z","pushed_at":"2019-09-20T00:09:31Z","git_url":"git://github.com/openshift/cluster-nfd-operator.git","ssh_url":"git@github.com:openshift/cluster-nfd-operator.git","clone_url":"https://github.com/openshift/cluster-nfd-operator.git","svn_url":"https://github.com/openshift/cluster-nfd-operator","homepage":null,"size":19921,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29"},"html":{"href":"https://github.com/openshift/cluster-nfd-operator/pull/29"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/29"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-nfd-operator/statuses/3d1584187599693ae3c74718321bc70e43a7cbde"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zvonkok"}}