{"action":"created","comment":{"url":"https://api.github.com/repos/yuzutech/kroki/pulls/comments/338439932","pull_request_review_id":306394276,"id":338439932,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODQzOTkzMg==","diff_hunk":"@@ -0,0 +1,16 @@\n+{\n+  \"name\": \"smoke-tests\",\n+  \"version\": \"1.0.0\",\n+  \"description\": \"\",\n+  \"main\": \"smoke.js\",\n+  \"dependencies\": {","path":"package.json","position":6,"original_position":6,"commit_id":"935d5fe00cad2e6fc3b8df124e7023ff30c1175b","original_commit_id":"935d5fe00cad2e6fc3b8df124e7023ff30c1175b","user":{"login":"Mogztter","id":333276,"node_id":"MDQ6VXNlcjMzMzI3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/333276?v=4","gravatar_id":"","url":"https://api.github.com/users/Mogztter","html_url":"https://github.com/Mogztter","followers_url":"https://api.github.com/users/Mogztter/followers","following_url":"https://api.github.com/users/Mogztter/following{/other_user}","gists_url":"https://api.github.com/users/Mogztter/gists{/gist_id}","starred_url":"https://api.github.com/users/Mogztter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mogztter/subscriptions","organizations_url":"https://api.github.com/users/Mogztter/orgs","repos_url":"https://api.github.com/users/Mogztter/repos","events_url":"https://api.github.com/users/Mogztter/events{/privacy}","received_events_url":"https://api.github.com/users/Mogztter/received_events","type":"User","site_admin":false},"body":"we should probably add `\"private\": true` to prevent accidental publication: https://docs.npmjs.com/files/package.json#private","created_at":"2019-10-24T08:19:45Z","updated_at":"2019-10-24T08:19:45Z","html_url":"https://github.com/yuzutech/kroki/pull/27#discussion_r338439932","pull_request_url":"https://api.github.com/repos/yuzutech/kroki/pulls/27","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yuzutech/kroki/pulls/comments/338439932"},"html":{"href":"https://github.com/yuzutech/kroki/pull/27#discussion_r338439932"},"pull_request":{"href":"https://api.github.com/repos/yuzutech/kroki/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/yuzutech/kroki/pulls/27","id":331381784,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxMzgxNzg0","html_url":"https://github.com/yuzutech/kroki/pull/27","diff_url":"https://github.com/yuzutech/kroki/pull/27.diff","patch_url":"https://github.com/yuzutech/kroki/pull/27.patch","issue_url":"https://api.github.com/repos/yuzutech/kroki/issues/27","number":27,"state":"open","locked":false,"title":"Travis smoke tests","user":{"login":"groovytron","id":17252501,"node_id":"MDQ6VXNlcjE3MjUyNTAx","avatar_url":"https://avatars0.githubusercontent.com/u/17252501?v=4","gravatar_id":"","url":"https://api.github.com/users/groovytron","html_url":"https://github.com/groovytron","followers_url":"https://api.github.com/users/groovytron/followers","following_url":"https://api.github.com/users/groovytron/following{/other_user}","gists_url":"https://api.github.com/users/groovytron/gists{/gist_id}","starred_url":"https://api.github.com/users/groovytron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groovytron/subscriptions","organizations_url":"https://api.github.com/users/groovytron/orgs","repos_url":"https://api.github.com/users/groovytron/repos","events_url":"https://api.github.com/users/groovytron/events{/privacy}","received_events_url":"https://api.github.com/users/groovytron/received_events","type":"User","site_admin":false},"body":"This is a starting point to resolve #24 \r\n\r\nI struggled a bit with bashcripts so I switched to using the `Makefile` with JavaScript ([Chai](https://www.chaijs.com/), [Chai HTTP](https://www.chaijs.com/plugins/chai-http/) and [Mocha](https://mochajs.org/)) to implement the smoke tests like suggested [here](https://github.com/yuzutech/kroki/issues/24#issuecomment-544167041). I didn't know that `nodejs` could be installed so easily in Travis' Java machine so it was a good suprise. :wink: \r\n\r\nI added a `smokeTests` target to the `Makefile` that:\r\n\r\n1. Starts the containers with `docker-compose`\r\n2. Logs the running containers (for debugging mainly)\r\n3. Waits for ports `8000` , `8001` and `8002` to be open\r\n4. Waits 15 seconds to allow the services inside the containers to be started completely\r\n5. Queries the Kroki container with different diagram engines (`nomnoml` test is commented because it raises a HTTP 500 at the moment and might need more insights)\r\n6. Stops the containers\r\n\r\nI hope it helps. Thanks for your feedback.","created_at":"2019-10-23T07:15:21Z","updated_at":"2019-10-24T08:19:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b11a867dc6ace256e503adb1b4cf6ddf8c4f6fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuzutech/kroki/pulls/27/commits","review_comments_url":"https://api.github.com/repos/yuzutech/kroki/pulls/27/comments","review_comment_url":"https://api.github.com/repos/yuzutech/kroki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuzutech/kroki/issues/27/comments","statuses_url":"https://api.github.com/repos/yuzutech/kroki/statuses/935d5fe00cad2e6fc3b8df124e7023ff30c1175b","head":{"label":"groovytron:travis-smoke-tests","ref":"travis-smoke-tests","sha":"935d5fe00cad2e6fc3b8df124e7023ff30c1175b","user":{"login":"groovytron","id":17252501,"node_id":"MDQ6VXNlcjE3MjUyNTAx","avatar_url":"https://avatars0.githubusercontent.com/u/17252501?v=4","gravatar_id":"","url":"https://api.github.com/users/groovytron","html_url":"https://github.com/groovytron","followers_url":"https://api.github.com/users/groovytron/followers","following_url":"https://api.github.com/users/groovytron/following{/other_user}","gists_url":"https://api.github.com/users/groovytron/gists{/gist_id}","starred_url":"https://api.github.com/users/groovytron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groovytron/subscriptions","organizations_url":"https://api.github.com/users/groovytron/orgs","repos_url":"https://api.github.com/users/groovytron/repos","events_url":"https://api.github.com/users/groovytron/events{/privacy}","received_events_url":"https://api.github.com/users/groovytron/received_events","type":"User","site_admin":false},"repo":{"id":212177128,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIxNzcxMjg=","name":"kroki","full_name":"groovytron/kroki","private":false,"owner":{"login":"groovytron","id":17252501,"node_id":"MDQ6VXNlcjE3MjUyNTAx","avatar_url":"https://avatars0.githubusercontent.com/u/17252501?v=4","gravatar_id":"","url":"https://api.github.com/users/groovytron","html_url":"https://github.com/groovytron","followers_url":"https://api.github.com/users/groovytron/followers","following_url":"https://api.github.com/users/groovytron/following{/other_user}","gists_url":"https://api.github.com/users/groovytron/gists{/gist_id}","starred_url":"https://api.github.com/users/groovytron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groovytron/subscriptions","organizations_url":"https://api.github.com/users/groovytron/orgs","repos_url":"https://api.github.com/users/groovytron/repos","events_url":"https://api.github.com/users/groovytron/events{/privacy}","received_events_url":"https://api.github.com/users/groovytron/received_events","type":"User","site_admin":false},"html_url":"https://github.com/groovytron/kroki","description":"Convert plain text diagrams to images !","fork":true,"url":"https://api.github.com/repos/groovytron/kroki","forks_url":"https://api.github.com/repos/groovytron/kroki/forks","keys_url":"https://api.github.com/repos/groovytron/kroki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groovytron/kroki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groovytron/kroki/teams","hooks_url":"https://api.github.com/repos/groovytron/kroki/hooks","issue_events_url":"https://api.github.com/repos/groovytron/kroki/issues/events{/number}","events_url":"https://api.github.com/repos/groovytron/kroki/events","assignees_url":"https://api.github.com/repos/groovytron/kroki/assignees{/user}","branches_url":"https://api.github.com/repos/groovytron/kroki/branches{/branch}","tags_url":"https://api.github.com/repos/groovytron/kroki/tags","blobs_url":"https://api.github.com/repos/groovytron/kroki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groovytron/kroki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groovytron/kroki/git/refs{/sha}","trees_url":"https://api.github.com/repos/groovytron/kroki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groovytron/kroki/statuses/{sha}","languages_url":"https://api.github.com/repos/groovytron/kroki/languages","stargazers_url":"https://api.github.com/repos/groovytron/kroki/stargazers","contributors_url":"https://api.github.com/repos/groovytron/kroki/contributors","subscribers_url":"https://api.github.com/repos/groovytron/kroki/subscribers","subscription_url":"https://api.github.com/repos/groovytron/kroki/subscription","commits_url":"https://api.github.com/repos/groovytron/kroki/commits{/sha}","git_commits_url":"https://api.github.com/repos/groovytron/kroki/git/commits{/sha}","comments_url":"https://api.github.com/repos/groovytron/kroki/comments{/number}","issue_comment_url":"https://api.github.com/repos/groovytron/kroki/issues/comments{/number}","contents_url":"https://api.github.com/repos/groovytron/kroki/contents/{+path}","compare_url":"https://api.github.com/repos/groovytron/kroki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groovytron/kroki/merges","archive_url":"https://api.github.com/repos/groovytron/kroki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groovytron/kroki/downloads","issues_url":"https://api.github.com/repos/groovytron/kroki/issues{/number}","pulls_url":"https://api.github.com/repos/groovytron/kroki/pulls{/number}","milestones_url":"https://api.github.com/repos/groovytron/kroki/milestones{/number}","notifications_url":"https://api.github.com/repos/groovytron/kroki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groovytron/kroki/labels{/name}","releases_url":"https://api.github.com/repos/groovytron/kroki/releases{/id}","deployments_url":"https://api.github.com/repos/groovytron/kroki/deployments","created_at":"2019-10-01T19:02:25Z","updated_at":"2019-10-22T19:19:03Z","pushed_at":"2019-10-23T06:20:43Z","git_url":"git://github.com/groovytron/kroki.git","ssh_url":"git@github.com:groovytron/kroki.git","clone_url":"https://github.com/groovytron/kroki.git","svn_url":"https://github.com/groovytron/kroki","homepage":"https://kroki.io","size":7651,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yuzutech:master","ref":"master","sha":"cce38156565f264bab814d759cf7af306e1fc5e9","user":{"login":"yuzutech","id":4894788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTQ3ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/4894788?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzutech","html_url":"https://github.com/yuzutech","followers_url":"https://api.github.com/users/yuzutech/followers","following_url":"https://api.github.com/users/yuzutech/following{/other_user}","gists_url":"https://api.github.com/users/yuzutech/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzutech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzutech/subscriptions","organizations_url":"https://api.github.com/users/yuzutech/orgs","repos_url":"https://api.github.com/users/yuzutech/repos","events_url":"https://api.github.com/users/yuzutech/events{/privacy}","received_events_url":"https://api.github.com/users/yuzutech/received_events","type":"Organization","site_admin":false},"repo":{"id":165063056,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUwNjMwNTY=","name":"kroki","full_name":"yuzutech/kroki","private":false,"owner":{"login":"yuzutech","id":4894788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTQ3ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/4894788?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzutech","html_url":"https://github.com/yuzutech","followers_url":"https://api.github.com/users/yuzutech/followers","following_url":"https://api.github.com/users/yuzutech/following{/other_user}","gists_url":"https://api.github.com/users/yuzutech/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzutech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzutech/subscriptions","organizations_url":"https://api.github.com/users/yuzutech/orgs","repos_url":"https://api.github.com/users/yuzutech/repos","events_url":"https://api.github.com/users/yuzutech/events{/privacy}","received_events_url":"https://api.github.com/users/yuzutech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yuzutech/kroki","description":"Convert plain text diagrams to images !","fork":false,"url":"https://api.github.com/repos/yuzutech/kroki","forks_url":"https://api.github.com/repos/yuzutech/kroki/forks","keys_url":"https://api.github.com/repos/yuzutech/kroki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzutech/kroki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzutech/kroki/teams","hooks_url":"https://api.github.com/repos/yuzutech/kroki/hooks","issue_events_url":"https://api.github.com/repos/yuzutech/kroki/issues/events{/number}","events_url":"https://api.github.com/repos/yuzutech/kroki/events","assignees_url":"https://api.github.com/repos/yuzutech/kroki/assignees{/user}","branches_url":"https://api.github.com/repos/yuzutech/kroki/branches{/branch}","tags_url":"https://api.github.com/repos/yuzutech/kroki/tags","blobs_url":"https://api.github.com/repos/yuzutech/kroki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzutech/kroki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzutech/kroki/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzutech/kroki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzutech/kroki/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzutech/kroki/languages","stargazers_url":"https://api.github.com/repos/yuzutech/kroki/stargazers","contributors_url":"https://api.github.com/repos/yuzutech/kroki/contributors","subscribers_url":"https://api.github.com/repos/yuzutech/kroki/subscribers","subscription_url":"https://api.github.com/repos/yuzutech/kroki/subscription","commits_url":"https://api.github.com/repos/yuzutech/kroki/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzutech/kroki/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzutech/kroki/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzutech/kroki/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzutech/kroki/contents/{+path}","compare_url":"https://api.github.com/repos/yuzutech/kroki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzutech/kroki/merges","archive_url":"https://api.github.com/repos/yuzutech/kroki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzutech/kroki/downloads","issues_url":"https://api.github.com/repos/yuzutech/kroki/issues{/number}","pulls_url":"https://api.github.com/repos/yuzutech/kroki/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzutech/kroki/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzutech/kroki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzutech/kroki/labels{/name}","releases_url":"https://api.github.com/repos/yuzutech/kroki/releases{/id}","deployments_url":"https://api.github.com/repos/yuzutech/kroki/deployments","created_at":"2019-01-10T13:17:19Z","updated_at":"2019-10-23T18:45:23Z","pushed_at":"2019-10-23T07:15:21Z","git_url":"git://github.com/yuzutech/kroki.git","ssh_url":"git@github.com:yuzutech/kroki.git","clone_url":"https://github.com/yuzutech/kroki.git","svn_url":"https://github.com/yuzutech/kroki","homepage":"https://kroki.io","size":7625,"stargazers_count":351,"watchers_count":351,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":null,"forks":15,"open_issues":12,"watchers":351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuzutech/kroki/pulls/27"},"html":{"href":"https://github.com/yuzutech/kroki/pull/27"},"issue":{"href":"https://api.github.com/repos/yuzutech/kroki/issues/27"},"comments":{"href":"https://api.github.com/repos/yuzutech/kroki/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/yuzutech/kroki/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/yuzutech/kroki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuzutech/kroki/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/yuzutech/kroki/statuses/935d5fe00cad2e6fc3b8df124e7023ff30c1175b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mogztter"}}