{"action":"created","comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/335729254","pull_request_review_id":302903713,"id":335729254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTcyOTI1NA==","diff_hunk":"@@ -66,7 +66,8 @@ class DataOverview extends React.Component {\n           typeof error === 'string' &&\n           (error.includes('maximum number of tables') ||\n             error.includes('The table name is invalid') ||\n-            error.includes('The table was renamed'))\n+            error.includes('The table was renamed') ||\n+            error.includes('There is already a table with name'))","path":"apps/src/storage/dataBrowser/DataOverview.jsx","position":6,"original_position":6,"commit_id":"76a2dc4f8c903b462aae4e6c11b8423d43f1ce03","original_commit_id":"76ca97d5614ab3b6c7bd85620823e6725caf5785","user":{"login":"ajpal","id":8787187,"node_id":"MDQ6VXNlcjg3ODcxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8787187?v=4","gravatar_id":"","url":"https://api.github.com/users/ajpal","html_url":"https://github.com/ajpal","followers_url":"https://api.github.com/users/ajpal/followers","following_url":"https://api.github.com/users/ajpal/following{/other_user}","gists_url":"https://api.github.com/users/ajpal/gists{/gist_id}","starred_url":"https://api.github.com/users/ajpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajpal/subscriptions","organizations_url":"https://api.github.com/users/ajpal/orgs","repos_url":"https://api.github.com/users/ajpal/repos","events_url":"https://api.github.com/users/ajpal/events{/privacy}","received_events_url":"https://api.github.com/users/ajpal/received_events","type":"User","site_admin":false},"body":"I don't think this would end up being a very clean solution because these error strings are parameterized, which is why we only look for a partial string match, here. So to pull them out to constants, I think we would actually need two constants for each error message- the full template string and the partial string to check for here. ","created_at":"2019-10-16T22:02:08Z","updated_at":"2019-10-16T22:02:08Z","html_url":"https://github.com/code-dot-org/code-dot-org/pull/31298#discussion_r335729254","pull_request_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/335729254"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/31298#discussion_r335729254"},"pull_request":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298"}},"in_reply_to_id":335666448},"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298","id":328511820,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NTExODIw","html_url":"https://github.com/code-dot-org/code-dot-org/pull/31298","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/31298.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/31298.patch","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/31298","number":31298,"state":"open","locked":false,"title":"[Applab Datasets] Enforce that tables must be uniquely named","user":{"login":"ajpal","id":8787187,"node_id":"MDQ6VXNlcjg3ODcxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8787187?v=4","gravatar_id":"","url":"https://api.github.com/users/ajpal","html_url":"https://github.com/ajpal","followers_url":"https://api.github.com/users/ajpal/followers","following_url":"https://api.github.com/users/ajpal/following{/other_user}","gists_url":"https://api.github.com/users/ajpal/gists{/gist_id}","starred_url":"https://api.github.com/users/ajpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajpal/subscriptions","organizations_url":"https://api.github.com/users/ajpal/orgs","repos_url":"https://api.github.com/users/ajpal/repos","events_url":"https://api.github.com/users/ajpal/events{/privacy}","received_events_url":"https://api.github.com/users/ajpal/received_events","type":"User","site_admin":false},"body":"# Description\r\nWe would like to enforce that there are no name collisions between current tables and project tables. This change will prevent you from either importing or creating a table with the same name as an existing table.\r\n\r\n![image](https://user-images.githubusercontent.com/8787187/66877875-2bb06e00-ef6c-11e9-8632-b9d0546df6bc.png)\r\n\r\n## Links\r\n\r\n- [jira](https://codedotorg.atlassian.net/browse/STAR-762)\r\n\r\n## Testing story\r\n\r\nUnit tests\r\n\r\n# Reviewer Checklist:\r\n\r\n- [ ] Tests provide adequate coverage\r\n- [ ] Code is well-commented\r\n- [ ] New features are translatable or updates will not break translations\r\n- [ ] Relevant documentation has been added or updated\r\n- [ ] User impact is well-understood and desirable\r\n- [ ] Pull Request is labeled appropriately\r\n- [ ] Follow-up work items (including potential tech debt) are tracked and linked\r\n","created_at":"2019-10-15T23:53:57Z","updated_at":"2019-10-16T22:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"764bab707d9bcd77f106c032a53f845ef6cffa4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":401725469,"node_id":"MDU6TGFiZWw0MDE3MjU0Njk=","url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels/star-labs","name":"star-labs","color":"ffa400","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298/commits","review_comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298/comments","review_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/31298/comments","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/76a2dc4f8c903b462aae4e6c11b8423d43f1ce03","head":{"label":"code-dot-org:oct15-readRecords-current","ref":"oct15-readRecords-current","sha":"76a2dc4f8c903b462aae4e6c11b8423d43f1ce03","user":{"login":"code-dot-org","id":5124627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMjQ2Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"node_id":"MDEwOlJlcG9zaXRvcnkyNDI1MDAwOQ==","name":"code-dot-org","full_name":"code-dot-org/code-dot-org","private":false,"owner":{"login":"code-dot-org","id":5124627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMjQ2Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2019-10-16T20:04:53Z","pushed_at":"2019-10-16T22:00:43Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"git@github.com:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":10204747,"stargazers_count":499,"watchers_count":499,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":290,"open_issues":177,"watchers":499,"default_branch":"staging"}},"base":{"label":"code-dot-org:staging","ref":"staging","sha":"7df2013fbf5957c7c843228ca643cd20ef992357","user":{"login":"code-dot-org","id":5124627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMjQ2Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"node_id":"MDEwOlJlcG9zaXRvcnkyNDI1MDAwOQ==","name":"code-dot-org","full_name":"code-dot-org/code-dot-org","private":false,"owner":{"login":"code-dot-org","id":5124627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMjQ2Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2019-10-16T20:04:53Z","pushed_at":"2019-10-16T22:00:43Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"git@github.com:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":10204747,"stargazers_count":499,"watchers_count":499,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":290,"open_issues":177,"watchers":499,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/31298"},"issue":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/31298"},"comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/31298/comments"},"review_comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298/comments"},"review_comment":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/31298/commits"},"statuses":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/76a2dc4f8c903b462aae4e6c11b8423d43f1ce03"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajpal"}}