{"action":"closed","number":70,"pull_request":{"url":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/70","id":273599378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNTk5Mzc4","html_url":"https://github.com/istio-ecosystem/istio-installer/pull/70","diff_url":"https://github.com/istio-ecosystem/istio-installer/pull/70.diff","patch_url":"https://github.com/istio-ecosystem/istio-installer/pull/70.patch","issue_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues/70","number":70,"state":"closed","locked":false,"title":"fix: update mixer config to match istio/istio","user":{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"body":"There were a large number of diffs around mixer config in the `mixer-telemetry` and `istio-policy` directories. This PR attempts to correct those issues.\r\n\r\nIn particular, this PR:\r\n- updates the attribute manifests to match 1.1.x\r\n- removes telemetry-related config from policy\r\n- updates CRs to use the new-style config (only instances, handlers, rules)\r\n- adds adapter config guards based on install options.\r\n\r\nHelps to address #67.","created_at":"2019-04-25T16:33:17Z","updated_at":"2019-04-25T18:00:17Z","closed_at":"2019-04-25T18:00:17Z","merged_at":"2019-04-25T18:00:16Z","merge_commit_sha":"460a499e5d021ce54990d2b46c31474d8213f267","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/70/commits","review_comments_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/70/comments","review_comment_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues/70/comments","statuses_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/statuses/eb60c05bbcf2642e16b987b40fcf3130228b530d","head":{"label":"douglas-reid:update-mixer-telemetry-config","ref":"update-mixer-telemetry-config","sha":"eb60c05bbcf2642e16b987b40fcf3130228b530d","user":{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"repo":{"id":183466944,"node_id":"MDEwOlJlcG9zaXRvcnkxODM0NjY5NDQ=","name":"istio-installer","full_name":"douglas-reid/istio-installer","private":false,"owner":{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/douglas-reid/istio-installer","description":"A piece meal installer for Istio components","fork":true,"url":"https://api.github.com/repos/douglas-reid/istio-installer","forks_url":"https://api.github.com/repos/douglas-reid/istio-installer/forks","keys_url":"https://api.github.com/repos/douglas-reid/istio-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/douglas-reid/istio-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/douglas-reid/istio-installer/teams","hooks_url":"https://api.github.com/repos/douglas-reid/istio-installer/hooks","issue_events_url":"https://api.github.com/repos/douglas-reid/istio-installer/issues/events{/number}","events_url":"https://api.github.com/repos/douglas-reid/istio-installer/events","assignees_url":"https://api.github.com/repos/douglas-reid/istio-installer/assignees{/user}","branches_url":"https://api.github.com/repos/douglas-reid/istio-installer/branches{/branch}","tags_url":"https://api.github.com/repos/douglas-reid/istio-installer/tags","blobs_url":"https://api.github.com/repos/douglas-reid/istio-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/douglas-reid/istio-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/douglas-reid/istio-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/douglas-reid/istio-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/douglas-reid/istio-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/douglas-reid/istio-installer/languages","stargazers_url":"https://api.github.com/repos/douglas-reid/istio-installer/stargazers","contributors_url":"https://api.github.com/repos/douglas-reid/istio-installer/contributors","subscribers_url":"https://api.github.com/repos/douglas-reid/istio-installer/subscribers","subscription_url":"https://api.github.com/repos/douglas-reid/istio-installer/subscription","commits_url":"https://api.github.com/repos/douglas-reid/istio-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/douglas-reid/istio-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/douglas-reid/istio-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/douglas-reid/istio-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/douglas-reid/istio-installer/contents/{+path}","compare_url":"https://api.github.com/repos/douglas-reid/istio-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/douglas-reid/istio-installer/merges","archive_url":"https://api.github.com/repos/douglas-reid/istio-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/douglas-reid/istio-installer/downloads","issues_url":"https://api.github.com/repos/douglas-reid/istio-installer/issues{/number}","pulls_url":"https://api.github.com/repos/douglas-reid/istio-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/douglas-reid/istio-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/douglas-reid/istio-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/douglas-reid/istio-installer/labels{/name}","releases_url":"https://api.github.com/repos/douglas-reid/istio-installer/releases{/id}","deployments_url":"https://api.github.com/repos/douglas-reid/istio-installer/deployments","created_at":"2019-04-25T15:59:42Z","updated_at":"2019-04-25T15:59:44Z","pushed_at":"2019-04-25T17:35:40Z","git_url":"git://github.com/douglas-reid/istio-installer.git","ssh_url":"git@github.com:douglas-reid/istio-installer.git","clone_url":"https://github.com/douglas-reid/istio-installer.git","svn_url":"https://github.com/douglas-reid/istio-installer","homepage":null,"size":309,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio-ecosystem:master","ref":"master","sha":"43d5487c538eb97fc2d3130713c31fd9cfc49b9f","user":{"login":"istio-ecosystem","id":43223487,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjIzNDg3","avatar_url":"https://avatars0.githubusercontent.com/u/43223487?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-ecosystem","html_url":"https://github.com/istio-ecosystem","followers_url":"https://api.github.com/users/istio-ecosystem/followers","following_url":"https://api.github.com/users/istio-ecosystem/following{/other_user}","gists_url":"https://api.github.com/users/istio-ecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-ecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-ecosystem/subscriptions","organizations_url":"https://api.github.com/users/istio-ecosystem/orgs","repos_url":"https://api.github.com/users/istio-ecosystem/repos","events_url":"https://api.github.com/users/istio-ecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/istio-ecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":172785406,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI3ODU0MDY=","name":"istio-installer","full_name":"istio-ecosystem/istio-installer","private":false,"owner":{"login":"istio-ecosystem","id":43223487,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjIzNDg3","avatar_url":"https://avatars0.githubusercontent.com/u/43223487?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-ecosystem","html_url":"https://github.com/istio-ecosystem","followers_url":"https://api.github.com/users/istio-ecosystem/followers","following_url":"https://api.github.com/users/istio-ecosystem/following{/other_user}","gists_url":"https://api.github.com/users/istio-ecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-ecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-ecosystem/subscriptions","organizations_url":"https://api.github.com/users/istio-ecosystem/orgs","repos_url":"https://api.github.com/users/istio-ecosystem/repos","events_url":"https://api.github.com/users/istio-ecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/istio-ecosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio-ecosystem/istio-installer","description":"A piece meal installer for Istio components","fork":false,"url":"https://api.github.com/repos/istio-ecosystem/istio-installer","forks_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/forks","keys_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/teams","hooks_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/hooks","issue_events_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues/events{/number}","events_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/events","assignees_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/assignees{/user}","branches_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/branches{/branch}","tags_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/tags","blobs_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/languages","stargazers_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/stargazers","contributors_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/contributors","subscribers_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/subscribers","subscription_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/subscription","commits_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/contents/{+path}","compare_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/merges","archive_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/downloads","issues_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues{/number}","pulls_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/labels{/name}","releases_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/releases{/id}","deployments_url":"https://api.github.com/repos/istio-ecosystem/istio-installer/deployments","created_at":"2019-02-26T20:29:09Z","updated_at":"2019-04-25T17:55:39Z","pushed_at":"2019-04-25T18:00:16Z","git_url":"git://github.com/istio-ecosystem/istio-installer.git","ssh_url":"git@github.com:istio-ecosystem/istio-installer.git","clone_url":"https://github.com/istio-ecosystem/istio-installer.git","svn_url":"https://github.com/istio-ecosystem/istio-installer","homepage":null,"size":301,"stargazers_count":16,"watchers_count":16,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":26,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/70"},"html":{"href":"https://github.com/istio-ecosystem/istio-installer/pull/70"},"issue":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues/70"},"comments":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/istio-ecosystem/istio-installer/statuses/eb60c05bbcf2642e16b987b40fcf3130228b530d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":463,"deletions":691,"changed_files":4}}
{"actor":{"display_login":"costinm"}}