{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/262673196","pull_request_review_id":210898325,"id":262673196,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjY3MzE5Ng==","diff_hunk":"@@ -220,16 +221,12 @@ def write_state_file(contents)\n       stale_checked = Time.now - (Puppet[:statettl] + 1)\n       Puppet::Util::Storage.cache(:yayness)[:checked] = recent_checked\n       Puppet::Util::Storage.cache(:stale)[:checked] = stale_checked\n-      expect(Puppet::Util::Storage.state).to eq(\n-        {\n-          :yayness => {\n-            :checked => recent_checked\n-          },\n-          :stale => {\n-            :checked => stale_checked\n-          }\n-        }\n-      )\n+\n+      expect(Puppet::Util::Storage.state.keys).to contain_exactly(:yayness, :stale)\n+      expect(Puppet::Util::Storage.state[:yayness].keys).to contain_exactly(:checked)\n+      expect(Puppet::Util::Storage.state[:stale].keys).to contain_exactly(:checked)\n+      expect(Puppet::Util::Storage.state[:yayness][:checked]).to be_within(@A_SMALL_AMOUNT_OF_TIME).of(recent_checked)\n+      expect(Puppet::Util::Storage.state[:stale][:checked]).to be_within(@A_SMALL_AMOUNT_OF_TIME).of(stale_checked)","path":"spec/unit/util/storage_spec.rb","position":27,"original_position":27,"commit_id":"20e5cfee70ad8eb40a3acfb3ac685ff1492cb104","original_commit_id":"20e5cfee70ad8eb40a3acfb3ac685ff1492cb104","user":{"login":"kris-bosland","id":28908461,"node_id":"MDQ6VXNlcjI4OTA4NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/28908461?v=4","gravatar_id":"","url":"https://api.github.com/users/kris-bosland","html_url":"https://github.com/kris-bosland","followers_url":"https://api.github.com/users/kris-bosland/followers","following_url":"https://api.github.com/users/kris-bosland/following{/other_user}","gists_url":"https://api.github.com/users/kris-bosland/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-bosland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-bosland/subscriptions","organizations_url":"https://api.github.com/users/kris-bosland/orgs","repos_url":"https://api.github.com/users/kris-bosland/repos","events_url":"https://api.github.com/users/kris-bosland/events{/privacy}","received_events_url":"https://api.github.com/users/kris-bosland/received_events","type":"User","site_admin":false},"body":"I'll try it.","created_at":"2019-03-05T20:17:57Z","updated_at":"2019-03-05T20:17:58Z","html_url":"https://github.com/puppetlabs/puppet/pull/7418#discussion_r262673196","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/262673196"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/7418#discussion_r262673196"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418"}},"in_reply_to_id":262670648},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418","id":258466785,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4NDY2Nzg1","html_url":"https://github.com/puppetlabs/puppet/pull/7418","diff_url":"https://github.com/puppetlabs/puppet/pull/7418.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/7418.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7418","number":7418,"state":"open","locked":false,"title":"(maint) Convert time eq to within in spec test","user":{"login":"kris-bosland","id":28908461,"node_id":"MDQ6VXNlcjI4OTA4NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/28908461?v=4","gravatar_id":"","url":"https://api.github.com/users/kris-bosland","html_url":"https://github.com/kris-bosland","followers_url":"https://api.github.com/users/kris-bosland/followers","following_url":"https://api.github.com/users/kris-bosland/following{/other_user}","gists_url":"https://api.github.com/users/kris-bosland/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-bosland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-bosland/subscriptions","organizations_url":"https://api.github.com/users/kris-bosland/orgs","repos_url":"https://api.github.com/users/kris-bosland/repos","events_url":"https://api.github.com/users/kris-bosland/events{/privacy}","received_events_url":"https://api.github.com/users/kris-bosland/received_events","type":"User","site_admin":false},"body":"Before this change, sometimes tests could fail because Floating point numbers would not be exactly equal.\r\nWith this change, comparison is now within a small amount of time, so a false fail is less likely.","created_at":"2019-03-05T20:03:48Z","updated_at":"2019-03-05T20:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b32ba4c7f984475729c2d93adb9f59faa2abcd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/7418/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/20e5cfee70ad8eb40a3acfb3ac685ff1492cb104","head":{"label":"kris-bosland:maint-convert-time-eq-to-within-in-spec-test","ref":"maint-convert-time-eq-to-within-in-spec-test","sha":"20e5cfee70ad8eb40a3acfb3ac685ff1492cb104","user":{"login":"kris-bosland","id":28908461,"node_id":"MDQ6VXNlcjI4OTA4NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/28908461?v=4","gravatar_id":"","url":"https://api.github.com/users/kris-bosland","html_url":"https://github.com/kris-bosland","followers_url":"https://api.github.com/users/kris-bosland/followers","following_url":"https://api.github.com/users/kris-bosland/following{/other_user}","gists_url":"https://api.github.com/users/kris-bosland/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-bosland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-bosland/subscriptions","organizations_url":"https://api.github.com/users/kris-bosland/orgs","repos_url":"https://api.github.com/users/kris-bosland/repos","events_url":"https://api.github.com/users/kris-bosland/events{/privacy}","received_events_url":"https://api.github.com/users/kris-bosland/received_events","type":"User","site_admin":false},"repo":{"id":109729797,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3Mjk3OTc=","name":"puppet","full_name":"kris-bosland/puppet","private":false,"owner":{"login":"kris-bosland","id":28908461,"node_id":"MDQ6VXNlcjI4OTA4NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/28908461?v=4","gravatar_id":"","url":"https://api.github.com/users/kris-bosland","html_url":"https://github.com/kris-bosland","followers_url":"https://api.github.com/users/kris-bosland/followers","following_url":"https://api.github.com/users/kris-bosland/following{/other_user}","gists_url":"https://api.github.com/users/kris-bosland/gists{/gist_id}","starred_url":"https://api.github.com/users/kris-bosland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kris-bosland/subscriptions","organizations_url":"https://api.github.com/users/kris-bosland/orgs","repos_url":"https://api.github.com/users/kris-bosland/repos","events_url":"https://api.github.com/users/kris-bosland/events{/privacy}","received_events_url":"https://api.github.com/users/kris-bosland/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kris-bosland/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/kris-bosland/puppet","forks_url":"https://api.github.com/repos/kris-bosland/puppet/forks","keys_url":"https://api.github.com/repos/kris-bosland/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kris-bosland/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kris-bosland/puppet/teams","hooks_url":"https://api.github.com/repos/kris-bosland/puppet/hooks","issue_events_url":"https://api.github.com/repos/kris-bosland/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/kris-bosland/puppet/events","assignees_url":"https://api.github.com/repos/kris-bosland/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/kris-bosland/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/kris-bosland/puppet/tags","blobs_url":"https://api.github.com/repos/kris-bosland/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kris-bosland/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kris-bosland/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kris-bosland/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kris-bosland/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/kris-bosland/puppet/languages","stargazers_url":"https://api.github.com/repos/kris-bosland/puppet/stargazers","contributors_url":"https://api.github.com/repos/kris-bosland/puppet/contributors","subscribers_url":"https://api.github.com/repos/kris-bosland/puppet/subscribers","subscription_url":"https://api.github.com/repos/kris-bosland/puppet/subscription","commits_url":"https://api.github.com/repos/kris-bosland/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kris-bosland/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kris-bosland/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kris-bosland/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kris-bosland/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/kris-bosland/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kris-bosland/puppet/merges","archive_url":"https://api.github.com/repos/kris-bosland/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kris-bosland/puppet/downloads","issues_url":"https://api.github.com/repos/kris-bosland/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/kris-bosland/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/kris-bosland/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/kris-bosland/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kris-bosland/puppet/labels{/name}","releases_url":"https://api.github.com/repos/kris-bosland/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/kris-bosland/puppet/deployments","created_at":"2017-11-06T17:51:54Z","updated_at":"2018-08-13T21:37:11Z","pushed_at":"2019-03-05T19:59:58Z","git_url":"git://github.com/kris-bosland/puppet.git","ssh_url":"git@github.com:kris-bosland/puppet.git","clone_url":"https://github.com/kris-bosland/puppet.git","svn_url":"https://github.com/kris-bosland/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":68719,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:5.5.x","ref":"5.5.x","sha":"11130f4d427f322aece8960adbb611bcd05790bb","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NDQ=","name":"puppet","full_name":"puppetlabs/puppet","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2019-03-05T08:35:22Z","pushed_at":"2019-03-05T20:03:49Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":72318,"stargazers_count":5212,"watchers_count":5212,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2068,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2068,"open_issues":41,"watchers":5212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/7418"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/7418"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/7418/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/7418/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/20e5cfee70ad8eb40a3acfb3ac685ff1492cb104"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kris-bosland"}}