{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments/275276757","pull_request_review_id":226540455,"id":275276757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTI3Njc1Nw==","diff_hunk":"@@ -53,7 +53,15 @@ else\n fi\n \n singlejar=\"$(rlocation \"io_bazel/src/tools/singlejar/singlejar${EXE_EXT}\")\"\n-jartool=\"$(rlocation \"local_jdk/bin/jar${EXE_EXT}\")\"\n+javabase=\"$1\"\n+if [[ $javabase = /* ]]; then","path":"src/tools/singlejar/zip64_test.sh","position":null,"original_position":6,"commit_id":"f4e5cc94ad115fc25ac60e5418eecc0ec977359e","original_commit_id":"88c4e7b0c3721c840b92d06a059155bd490b91ee","user":{"login":"buchgr","id":1388179,"node_id":"MDQ6VXNlcjEzODgxNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1388179?v=4","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"body":"thanks! done","created_at":"2019-04-15T09:29:40Z","updated_at":"2019-04-15T09:29:40Z","html_url":"https://github.com/bazelbuild/bazel/pull/8034#discussion_r275276757","pull_request_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments/275276757"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/8034#discussion_r275276757"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034"}},"in_reply_to_id":275269358},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034","id":270430122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNDMwMTIy","html_url":"https://github.com/bazelbuild/bazel/pull/8034","diff_url":"https://github.com/bazelbuild/bazel/pull/8034.diff","patch_url":"https://github.com/bazelbuild/bazel/pull/8034.patch","issue_url":"https://api.github.com/repos/bazelbuild/bazel/issues/8034","number":8034,"state":"open","locked":false,"title":"fix zip64_test to work with absolute $(JAVABASE)","user":{"login":"buchgr","id":1388179,"node_id":"MDQ6VXNlcjEzODgxNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1388179?v=4","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"body":"Tested with an absolute $(JAVABASE) and --(no)legacy_external_runfiles.\r\n\r\nProgress towards #8033","created_at":"2019-04-15T09:05:11Z","updated_at":"2019-04-15T09:29:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f534941cbc6c055b0469a26928b8506c9868d07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":323761238,"node_id":"MDU6TGFiZWwzMjM3NjEyMzg=","url":"https://api.github.com/repos/bazelbuild/bazel/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/issues/8034/comments","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/f4e5cc94ad115fc25ac60e5418eecc0ec977359e","head":{"label":"buchgr:zip64_test","ref":"zip64_test","sha":"f4e5cc94ad115fc25ac60e5418eecc0ec977359e","user":{"login":"buchgr","id":1388179,"node_id":"MDQ6VXNlcjEzODgxNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1388179?v=4","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"repo":{"id":82068400,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA2ODQwMA==","name":"bazel","full_name":"buchgr/bazel","private":false,"owner":{"login":"buchgr","id":1388179,"node_id":"MDQ6VXNlcjEzODgxNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1388179?v=4","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/buchgr/bazel","description":"Correct, reproducible, and fast builds for everyone.","fork":true,"url":"https://api.github.com/repos/buchgr/bazel","forks_url":"https://api.github.com/repos/buchgr/bazel/forks","keys_url":"https://api.github.com/repos/buchgr/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buchgr/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buchgr/bazel/teams","hooks_url":"https://api.github.com/repos/buchgr/bazel/hooks","issue_events_url":"https://api.github.com/repos/buchgr/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/buchgr/bazel/events","assignees_url":"https://api.github.com/repos/buchgr/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/buchgr/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/buchgr/bazel/tags","blobs_url":"https://api.github.com/repos/buchgr/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buchgr/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buchgr/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/buchgr/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buchgr/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/buchgr/bazel/languages","stargazers_url":"https://api.github.com/repos/buchgr/bazel/stargazers","contributors_url":"https://api.github.com/repos/buchgr/bazel/contributors","subscribers_url":"https://api.github.com/repos/buchgr/bazel/subscribers","subscription_url":"https://api.github.com/repos/buchgr/bazel/subscription","commits_url":"https://api.github.com/repos/buchgr/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/buchgr/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/buchgr/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/buchgr/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/buchgr/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/buchgr/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buchgr/bazel/merges","archive_url":"https://api.github.com/repos/buchgr/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buchgr/bazel/downloads","issues_url":"https://api.github.com/repos/buchgr/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/buchgr/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/buchgr/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/buchgr/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buchgr/bazel/labels{/name}","releases_url":"https://api.github.com/repos/buchgr/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/buchgr/bazel/deployments","created_at":"2017-02-15T14:19:53Z","updated_at":"2018-05-13T12:04:43Z","pushed_at":"2019-04-15T09:29:29Z","git_url":"git://github.com/buchgr/bazel.git","ssh_url":"git@github.com:buchgr/bazel.git","clone_url":"https://github.com/buchgr/bazel.git","svn_url":"https://github.com/buchgr/bazel","homepage":"https://bazel.build","size":599214,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"6f90d01fa2c0d0a985687a5df363928fb9d7ab51","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":20773773,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3Mzc3Mw==","name":"bazel","full_name":"bazelbuild/bazel","private":false,"owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bazelbuild/bazel","description":"a fast, scalable, multi-language and extensible build system","fork":false,"url":"https://api.github.com/repos/bazelbuild/bazel","forks_url":"https://api.github.com/repos/bazelbuild/bazel/forks","keys_url":"https://api.github.com/repos/bazelbuild/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/bazel/teams","hooks_url":"https://api.github.com/repos/bazelbuild/bazel/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/bazel/events","assignees_url":"https://api.github.com/repos/bazelbuild/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/bazel/tags","blobs_url":"https://api.github.com/repos/bazelbuild/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/bazel/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/bazel/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/bazel/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/bazel/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/bazel/subscription","commits_url":"https://api.github.com/repos/bazelbuild/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/bazel/merges","archive_url":"https://api.github.com/repos/bazelbuild/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/bazel/downloads","issues_url":"https://api.github.com/repos/bazelbuild/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/bazel/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/bazel/deployments","created_at":"2014-06-12T16:00:38Z","updated_at":"2019-04-15T07:50:54Z","pushed_at":"2019-04-15T09:29:30Z","git_url":"git://github.com/bazelbuild/bazel.git","ssh_url":"git@github.com:bazelbuild/bazel.git","clone_url":"https://github.com/bazelbuild/bazel.git","svn_url":"https://github.com/bazelbuild/bazel","homepage":"https://bazel.build","size":597864,"stargazers_count":11632,"watchers_count":11632,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1880,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1779,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1880,"open_issues":1779,"watchers":11632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/8034"},"issue":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/8034"},"comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/8034/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/8034/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/bazel/statuses/f4e5cc94ad115fc25ac60e5418eecc0ec977359e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"buchgr"}}