{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/308007788","pull_request_review_id":267512461,"id":308007788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODAwNzc4OA==","diff_hunk":"@@ -619,6 +619,21 @@ def test_relative_to_common(self):\n         self.assertRaises(ValueError, p.relative_to, '')\n         self.assertRaises(ValueError, p.relative_to, P('a'))\n \n+    def test_is_relative_to(self):","path":"Lib/test/test_pathlib.py","position":4,"original_position":4,"commit_id":"92657049084ffa33f5b21ec57584dc98b11fa328","original_commit_id":"92657049084ffa33f5b21ec57584dc98b11fa328","user":{"login":"pitrou","id":1721820,"node_id":"MDQ6VXNlcjE3MjE4MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1721820?v=4","gravatar_id":"","url":"https://api.github.com/users/pitrou","html_url":"https://github.com/pitrou","followers_url":"https://api.github.com/users/pitrou/followers","following_url":"https://api.github.com/users/pitrou/following{/other_user}","gists_url":"https://api.github.com/users/pitrou/gists{/gist_id}","starred_url":"https://api.github.com/users/pitrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitrou/subscriptions","organizations_url":"https://api.github.com/users/pitrou/orgs","repos_url":"https://api.github.com/users/pitrou/repos","events_url":"https://api.github.com/users/pitrou/events{/privacy}","received_events_url":"https://api.github.com/users/pitrou/received_events","type":"User","site_admin":false},"body":"I would like to see more comprehensive testing. You can imply reuse the various cases from the `relative_to` tests.","created_at":"2019-07-28T16:00:07Z","updated_at":"2019-07-28T16:00:39Z","html_url":"https://github.com/python/cpython/pull/14982#discussion_r308007788","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/14982","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/308007788"},"html":{"href":"https://github.com/python/cpython/pull/14982#discussion_r308007788"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/14982"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/14982","id":301775302,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNzc1MzAy","html_url":"https://github.com/python/cpython/pull/14982","diff_url":"https://github.com/python/cpython/pull/14982.diff","patch_url":"https://github.com/python/cpython/pull/14982.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/14982","number":14982,"state":"open","locked":false,"title":"bpo-37689: add Path.is_relative_to() method","user":{"login":"shihai1991","id":9103416,"node_id":"MDQ6VXNlcjkxMDM0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9103416?v=4","gravatar_id":"","url":"https://api.github.com/users/shihai1991","html_url":"https://github.com/shihai1991","followers_url":"https://api.github.com/users/shihai1991/followers","following_url":"https://api.github.com/users/shihai1991/following{/other_user}","gists_url":"https://api.github.com/users/shihai1991/gists{/gist_id}","starred_url":"https://api.github.com/users/shihai1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shihai1991/subscriptions","organizations_url":"https://api.github.com/users/shihai1991/orgs","repos_url":"https://api.github.com/users/shihai1991/repos","events_url":"https://api.github.com/users/shihai1991/events{/privacy}","received_events_url":"https://api.github.com/users/shihai1991/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: [bpo-37689](https://bugs.python.org/issue37689) -->\nhttps://bugs.python.org/issue37689\n<!-- /issue-number -->\n","created_at":"2019-07-27T17:56:45Z","updated_at":"2019-07-28T16:00:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ecd37b3c7b88e8d7e8f64b37d31118682883a6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979871,"node_id":"MDU6TGFiZWw2NjY5Nzk4NzE=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20core%20review","name":"awaiting core review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/14982/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/14982/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/14982/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/92657049084ffa33f5b21ec57584dc98b11fa328","head":{"label":"shihai1991:bpo_37689","ref":"bpo_37689","sha":"92657049084ffa33f5b21ec57584dc98b11fa328","user":{"login":"shihai1991","id":9103416,"node_id":"MDQ6VXNlcjkxMDM0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9103416?v=4","gravatar_id":"","url":"https://api.github.com/users/shihai1991","html_url":"https://github.com/shihai1991","followers_url":"https://api.github.com/users/shihai1991/followers","following_url":"https://api.github.com/users/shihai1991/following{/other_user}","gists_url":"https://api.github.com/users/shihai1991/gists{/gist_id}","starred_url":"https://api.github.com/users/shihai1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shihai1991/subscriptions","organizations_url":"https://api.github.com/users/shihai1991/orgs","repos_url":"https://api.github.com/users/shihai1991/repos","events_url":"https://api.github.com/users/shihai1991/events{/privacy}","received_events_url":"https://api.github.com/users/shihai1991/received_events","type":"User","site_admin":false},"repo":{"id":188716744,"node_id":"MDEwOlJlcG9zaXRvcnkxODg3MTY3NDQ=","name":"cpython","full_name":"shihai1991/cpython","private":false,"owner":{"login":"shihai1991","id":9103416,"node_id":"MDQ6VXNlcjkxMDM0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9103416?v=4","gravatar_id":"","url":"https://api.github.com/users/shihai1991","html_url":"https://github.com/shihai1991","followers_url":"https://api.github.com/users/shihai1991/followers","following_url":"https://api.github.com/users/shihai1991/following{/other_user}","gists_url":"https://api.github.com/users/shihai1991/gists{/gist_id}","starred_url":"https://api.github.com/users/shihai1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shihai1991/subscriptions","organizations_url":"https://api.github.com/users/shihai1991/orgs","repos_url":"https://api.github.com/users/shihai1991/repos","events_url":"https://api.github.com/users/shihai1991/events{/privacy}","received_events_url":"https://api.github.com/users/shihai1991/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shihai1991/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/shihai1991/cpython","forks_url":"https://api.github.com/repos/shihai1991/cpython/forks","keys_url":"https://api.github.com/repos/shihai1991/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shihai1991/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shihai1991/cpython/teams","hooks_url":"https://api.github.com/repos/shihai1991/cpython/hooks","issue_events_url":"https://api.github.com/repos/shihai1991/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/shihai1991/cpython/events","assignees_url":"https://api.github.com/repos/shihai1991/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/shihai1991/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/shihai1991/cpython/tags","blobs_url":"https://api.github.com/repos/shihai1991/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shihai1991/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shihai1991/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/shihai1991/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shihai1991/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/shihai1991/cpython/languages","stargazers_url":"https://api.github.com/repos/shihai1991/cpython/stargazers","contributors_url":"https://api.github.com/repos/shihai1991/cpython/contributors","subscribers_url":"https://api.github.com/repos/shihai1991/cpython/subscribers","subscription_url":"https://api.github.com/repos/shihai1991/cpython/subscription","commits_url":"https://api.github.com/repos/shihai1991/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/shihai1991/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/shihai1991/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/shihai1991/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/shihai1991/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/shihai1991/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shihai1991/cpython/merges","archive_url":"https://api.github.com/repos/shihai1991/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shihai1991/cpython/downloads","issues_url":"https://api.github.com/repos/shihai1991/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/shihai1991/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/shihai1991/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/shihai1991/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shihai1991/cpython/labels{/name}","releases_url":"https://api.github.com/repos/shihai1991/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/shihai1991/cpython/deployments","created_at":"2019-05-26T18:14:51Z","updated_at":"2019-06-22T10:36:10Z","pushed_at":"2019-07-28T09:03:03Z","git_url":"git://github.com/shihai1991/cpython.git","ssh_url":"git@github.com:shihai1991/cpython.git","clone_url":"https://github.com/shihai1991/cpython.git","svn_url":"https://github.com/shihai1991/cpython","homepage":"https://www.python.org/","size":291060,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"3221a63c69268a9362802371a616f49d522a5c4f","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2019-07-28T14:39:18Z","pushed_at":"2019-07-28T15:16:21Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":293150,"stargazers_count":25700,"watchers_count":25700,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10862,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1038,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10862,"open_issues":1038,"watchers":25700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/14982"},"html":{"href":"https://github.com/python/cpython/pull/14982"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/14982"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/14982/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/14982/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/14982/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/92657049084ffa33f5b21ec57584dc98b11fa328"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pitrou"}}