{"action":"created","issue":{"url":"https://api.github.com/repos/intel/opa-psm2/issues/25","repository_url":"https://api.github.com/repos/intel/opa-psm2","labels_url":"https://api.github.com/repos/intel/opa-psm2/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/intel/opa-psm2/issues/25/comments","events_url":"https://api.github.com/repos/intel/opa-psm2/issues/25/events","html_url":"https://github.com/intel/opa-psm2/pull/25","id":305439457,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1MTY1ODE0","number":25,"title":"fix gcc8 compilation error","user":{"login":"nmorey","id":108326,"node_id":"MDQ6VXNlcjEwODMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/108326?v=4","gravatar_id":"","url":"https://api.github.com/users/nmorey","html_url":"https://github.com/nmorey","followers_url":"https://api.github.com/users/nmorey/followers","following_url":"https://api.github.com/users/nmorey/following{/other_user}","gists_url":"https://api.github.com/users/nmorey/gists{/gist_id}","starred_url":"https://api.github.com/users/nmorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmorey/subscriptions","organizations_url":"https://api.github.com/users/nmorey/orgs","repos_url":"https://api.github.com/users/nmorey/repos","events_url":"https://api.github.com/users/nmorey/events{/privacy}","received_events_url":"https://api.github.com/users/nmorey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-15T07:17:35Z","updated_at":"2019-10-02T13:01:36Z","closed_at":"2019-10-02T13:01:35Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/intel/opa-psm2/pulls/25","html_url":"https://github.com/intel/opa-psm2/pull/25","diff_url":"https://github.com/intel/opa-psm2/pull/25.diff","patch_url":"https://github.com/intel/opa-psm2/pull/25.patch"},"body":"Compiling with gcc 8.0.1 fails with:\r\n/home/abuild/rpmbuild/BUILD/libpsm2-10.3.37/psm_utils.c: In function 'psmi_faultinj_getspec':\r\n/home/abuild/rpmbuild/BUILD/libpsm2-10.3.37/psm_utils.c:985:59: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size between 110 and 237 [-Werror=format-truncation=]\r\n   snprintf(fdesc, sizeof(fdesc) - 1, \"Fault Injection %s <%s>\",\r\n                                                           ^~\r\n     fname, fvals_str);\r\n            ~~~~~~~~~\r\nIn file included from /usr/include/stdio.h:862,\r\n                 from /usr/include/malloc.h:24,\r\n                 from /home/abuild/rpmbuild/BUILD/libpsm2-10.3.37/psm_utils.c:55:\r\n/usr/include/bits/stdio2.h:64:10: note: '__builtin___snprintf_chk' output between 20 and 274 bytes into a destination of size 255\r\n   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,\r\n          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n        __bos (__s), __fmt, __va_arg_pack ());\r\n        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\ncc1: all warnings being treated as errors\r\nmake[1]: *** [Makefile:522: /home/abuild/rpmbuild/BUILD/libpsm2-10.3.37/build_release/psm_utils.o] Error 1\r\n\r\nThis increases the target buffer size to remove the error\r\n\r\nSigned-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>"},"comment":{"url":"https://api.github.com/repos/intel/opa-psm2/issues/comments/537481371","html_url":"https://github.com/intel/opa-psm2/pull/25#issuecomment-537481371","issue_url":"https://api.github.com/repos/intel/opa-psm2/issues/25","id":537481371,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNzQ4MTM3MQ==","user":{"login":"mwheinz","id":10899262,"node_id":"MDQ6VXNlcjEwODk5MjYy","avatar_url":"https://avatars3.githubusercontent.com/u/10899262?v=4","gravatar_id":"","url":"https://api.github.com/users/mwheinz","html_url":"https://github.com/mwheinz","followers_url":"https://api.github.com/users/mwheinz/followers","following_url":"https://api.github.com/users/mwheinz/following{/other_user}","gists_url":"https://api.github.com/users/mwheinz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwheinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwheinz/subscriptions","organizations_url":"https://api.github.com/users/mwheinz/orgs","repos_url":"https://api.github.com/users/mwheinz/repos","events_url":"https://api.github.com/users/mwheinz/events{/privacy}","received_events_url":"https://api.github.com/users/mwheinz/received_events","type":"User","site_admin":false},"created_at":"2019-10-02T13:01:35Z","updated_at":"2019-10-02T13:01:35Z","author_association":"COLLABORATOR","body":"Reviewing the code it appears that this change was implicitly folded into commit 8a12e84dc7e3a89eb81f7d0d2fba13c5d9d9c484 last fall."}}
{"actor":{"display_login":"mwheinz"}}