{"action":"created","comment":{"url":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments/260401891","pull_request_review_id":208101890,"id":260401891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDQwMTg5MQ==","diff_hunk":"@@ -97,6 +97,8 @@ data:\n       - repositories.stash.appscode.com\n       kinds:\n       - Snapshot\n+      clusters:\n+      - '*'","path":"docs/argocd-cm.yaml","position":12,"original_position":5,"commit_id":"6b065bd1db2ba76249627739cd3c7ae62d89ed19","original_commit_id":"7f4e26461e7b92caa67c9417200b428f332b7718","user":{"login":"jessesuen","id":12677113,"node_id":"MDQ6VXNlcjEyNjc3MTEz","avatar_url":"https://avatars0.githubusercontent.com/u/12677113?v=4","gravatar_id":"","url":"https://api.github.com/users/jessesuen","html_url":"https://github.com/jessesuen","followers_url":"https://api.github.com/users/jessesuen/followers","following_url":"https://api.github.com/users/jessesuen/following{/other_user}","gists_url":"https://api.github.com/users/jessesuen/gists{/gist_id}","starred_url":"https://api.github.com/users/jessesuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessesuen/subscriptions","organizations_url":"https://api.github.com/users/jessesuen/orgs","repos_url":"https://api.github.com/users/jessesuen/repos","events_url":"https://api.github.com/users/jessesuen/events{/privacy}","received_events_url":"https://api.github.com/users/jessesuen/received_events","type":"User","site_admin":false},"body":"OK i think clusters should be additive. This is similar to the behavior esourceNames field with rbac rules. Especially since I don't think the cluster filter is entirely useful, and most people will want the same filters in all clusters.  I'll file an issue to fix this","created_at":"2019-02-26T17:32:36Z","updated_at":"2019-02-26T17:32:37Z","html_url":"https://github.com/argoproj/argo-cd/pull/1165#discussion_r260401891","pull_request_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments/260401891"},"html":{"href":"https://github.com/argoproj/argo-cd/pull/1165#discussion_r260401891"},"pull_request":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165"}},"in_reply_to_id":260096363},"pull_request":{"url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165","id":255569300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NTY5MzAw","html_url":"https://github.com/argoproj/argo-cd/pull/1165","diff_url":"https://github.com/argoproj/argo-cd/pull/1165.diff","patch_url":"https://github.com/argoproj/argo-cd/pull/1165.patch","issue_url":"https://api.github.com/repos/argoproj/argo-cd/issues/1165","number":1165,"state":"open","locked":false,"title":"Adds support for Jsonnet External Variables and Top-Level Arguments. …","user":{"login":"alexec","id":1142830,"node_id":"MDQ6VXNlcjExNDI4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1142830?v=4","gravatar_id":"","url":"https://api.github.com/users/alexec","html_url":"https://github.com/alexec","followers_url":"https://api.github.com/users/alexec/followers","following_url":"https://api.github.com/users/alexec/following{/other_user}","gists_url":"https://api.github.com/users/alexec/gists{/gist_id}","starred_url":"https://api.github.com/users/alexec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexec/subscriptions","organizations_url":"https://api.github.com/users/alexec/orgs","repos_url":"https://api.github.com/users/alexec/repos","events_url":"https://api.github.com/users/alexec/events{/privacy}","received_events_url":"https://api.github.com/users/alexec/received_events","type":"User","site_admin":false},"body":"…Closes #1107 \r\n\r\n* [x] Update UI.\r\n* [x] Write docs.\r\n* [x] What do the requestors think of the YAML format for `code` options?","created_at":"2019-02-23T00:02:46Z","updated_at":"2019-02-26T17:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61bd602abe72d10e9dfed7d2a063eb21aec490c6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexmt","id":426437,"node_id":"MDQ6VXNlcjQyNjQzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/426437?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmt","html_url":"https://github.com/alexmt","followers_url":"https://api.github.com/users/alexmt/followers","following_url":"https://api.github.com/users/alexmt/following{/other_user}","gists_url":"https://api.github.com/users/alexmt/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmt/subscriptions","organizations_url":"https://api.github.com/users/alexmt/orgs","repos_url":"https://api.github.com/users/alexmt/repos","events_url":"https://api.github.com/users/alexmt/events{/privacy}","received_events_url":"https://api.github.com/users/alexmt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165/commits","review_comments_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165/comments","review_comment_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/argoproj/argo-cd/issues/1165/comments","statuses_url":"https://api.github.com/repos/argoproj/argo-cd/statuses/6b065bd1db2ba76249627739cd3c7ae62d89ed19","head":{"label":"alexec:jsonnet-ext-vars-and-tlas","ref":"jsonnet-ext-vars-and-tlas","sha":"6b065bd1db2ba76249627739cd3c7ae62d89ed19","user":{"login":"alexec","id":1142830,"node_id":"MDQ6VXNlcjExNDI4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1142830?v=4","gravatar_id":"","url":"https://api.github.com/users/alexec","html_url":"https://github.com/alexec","followers_url":"https://api.github.com/users/alexec/followers","following_url":"https://api.github.com/users/alexec/following{/other_user}","gists_url":"https://api.github.com/users/alexec/gists{/gist_id}","starred_url":"https://api.github.com/users/alexec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexec/subscriptions","organizations_url":"https://api.github.com/users/alexec/orgs","repos_url":"https://api.github.com/users/alexec/repos","events_url":"https://api.github.com/users/alexec/events{/privacy}","received_events_url":"https://api.github.com/users/alexec/received_events","type":"User","site_admin":false},"repo":{"id":169463097,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0NjMwOTc=","name":"argo-cd","full_name":"alexec/argo-cd","private":false,"owner":{"login":"alexec","id":1142830,"node_id":"MDQ6VXNlcjExNDI4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1142830?v=4","gravatar_id":"","url":"https://api.github.com/users/alexec","html_url":"https://github.com/alexec","followers_url":"https://api.github.com/users/alexec/followers","following_url":"https://api.github.com/users/alexec/following{/other_user}","gists_url":"https://api.github.com/users/alexec/gists{/gist_id}","starred_url":"https://api.github.com/users/alexec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexec/subscriptions","organizations_url":"https://api.github.com/users/alexec/orgs","repos_url":"https://api.github.com/users/alexec/repos","events_url":"https://api.github.com/users/alexec/events{/privacy}","received_events_url":"https://api.github.com/users/alexec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexec/argo-cd","description":"Declarative continuous deployment for Kubernetes.","fork":true,"url":"https://api.github.com/repos/alexec/argo-cd","forks_url":"https://api.github.com/repos/alexec/argo-cd/forks","keys_url":"https://api.github.com/repos/alexec/argo-cd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexec/argo-cd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexec/argo-cd/teams","hooks_url":"https://api.github.com/repos/alexec/argo-cd/hooks","issue_events_url":"https://api.github.com/repos/alexec/argo-cd/issues/events{/number}","events_url":"https://api.github.com/repos/alexec/argo-cd/events","assignees_url":"https://api.github.com/repos/alexec/argo-cd/assignees{/user}","branches_url":"https://api.github.com/repos/alexec/argo-cd/branches{/branch}","tags_url":"https://api.github.com/repos/alexec/argo-cd/tags","blobs_url":"https://api.github.com/repos/alexec/argo-cd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexec/argo-cd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexec/argo-cd/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexec/argo-cd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexec/argo-cd/statuses/{sha}","languages_url":"https://api.github.com/repos/alexec/argo-cd/languages","stargazers_url":"https://api.github.com/repos/alexec/argo-cd/stargazers","contributors_url":"https://api.github.com/repos/alexec/argo-cd/contributors","subscribers_url":"https://api.github.com/repos/alexec/argo-cd/subscribers","subscription_url":"https://api.github.com/repos/alexec/argo-cd/subscription","commits_url":"https://api.github.com/repos/alexec/argo-cd/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexec/argo-cd/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexec/argo-cd/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexec/argo-cd/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexec/argo-cd/contents/{+path}","compare_url":"https://api.github.com/repos/alexec/argo-cd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexec/argo-cd/merges","archive_url":"https://api.github.com/repos/alexec/argo-cd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexec/argo-cd/downloads","issues_url":"https://api.github.com/repos/alexec/argo-cd/issues{/number}","pulls_url":"https://api.github.com/repos/alexec/argo-cd/pulls{/number}","milestones_url":"https://api.github.com/repos/alexec/argo-cd/milestones{/number}","notifications_url":"https://api.github.com/repos/alexec/argo-cd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexec/argo-cd/labels{/name}","releases_url":"https://api.github.com/repos/alexec/argo-cd/releases{/id}","deployments_url":"https://api.github.com/repos/alexec/argo-cd/deployments","created_at":"2019-02-06T19:23:39Z","updated_at":"2019-02-06T19:23:42Z","pushed_at":"2019-02-26T17:07:10Z","git_url":"git://github.com/alexec/argo-cd.git","ssh_url":"git@github.com:alexec/argo-cd.git","clone_url":"https://github.com/alexec/argo-cd.git","svn_url":"https://github.com/alexec/argo-cd","homepage":"","size":9361,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"argoproj:master","ref":"master","sha":"caacba907c05826df235d731d405d265c0560f0e","user":{"login":"argoproj","id":30269780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY5Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"repo":{"id":120896210,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4OTYyMTA=","name":"argo-cd","full_name":"argoproj/argo-cd","private":false,"owner":{"login":"argoproj","id":30269780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY5Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/argoproj/argo-cd","description":"Declarative continuous deployment for Kubernetes.","fork":false,"url":"https://api.github.com/repos/argoproj/argo-cd","forks_url":"https://api.github.com/repos/argoproj/argo-cd/forks","keys_url":"https://api.github.com/repos/argoproj/argo-cd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/argoproj/argo-cd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/argoproj/argo-cd/teams","hooks_url":"https://api.github.com/repos/argoproj/argo-cd/hooks","issue_events_url":"https://api.github.com/repos/argoproj/argo-cd/issues/events{/number}","events_url":"https://api.github.com/repos/argoproj/argo-cd/events","assignees_url":"https://api.github.com/repos/argoproj/argo-cd/assignees{/user}","branches_url":"https://api.github.com/repos/argoproj/argo-cd/branches{/branch}","tags_url":"https://api.github.com/repos/argoproj/argo-cd/tags","blobs_url":"https://api.github.com/repos/argoproj/argo-cd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/argoproj/argo-cd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/argoproj/argo-cd/git/refs{/sha}","trees_url":"https://api.github.com/repos/argoproj/argo-cd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/argoproj/argo-cd/statuses/{sha}","languages_url":"https://api.github.com/repos/argoproj/argo-cd/languages","stargazers_url":"https://api.github.com/repos/argoproj/argo-cd/stargazers","contributors_url":"https://api.github.com/repos/argoproj/argo-cd/contributors","subscribers_url":"https://api.github.com/repos/argoproj/argo-cd/subscribers","subscription_url":"https://api.github.com/repos/argoproj/argo-cd/subscription","commits_url":"https://api.github.com/repos/argoproj/argo-cd/commits{/sha}","git_commits_url":"https://api.github.com/repos/argoproj/argo-cd/git/commits{/sha}","comments_url":"https://api.github.com/repos/argoproj/argo-cd/comments{/number}","issue_comment_url":"https://api.github.com/repos/argoproj/argo-cd/issues/comments{/number}","contents_url":"https://api.github.com/repos/argoproj/argo-cd/contents/{+path}","compare_url":"https://api.github.com/repos/argoproj/argo-cd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/argoproj/argo-cd/merges","archive_url":"https://api.github.com/repos/argoproj/argo-cd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/argoproj/argo-cd/downloads","issues_url":"https://api.github.com/repos/argoproj/argo-cd/issues{/number}","pulls_url":"https://api.github.com/repos/argoproj/argo-cd/pulls{/number}","milestones_url":"https://api.github.com/repos/argoproj/argo-cd/milestones{/number}","notifications_url":"https://api.github.com/repos/argoproj/argo-cd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/argoproj/argo-cd/labels{/name}","releases_url":"https://api.github.com/repos/argoproj/argo-cd/releases{/id}","deployments_url":"https://api.github.com/repos/argoproj/argo-cd/deployments","created_at":"2018-02-09T11:12:01Z","updated_at":"2019-02-26T15:27:43Z","pushed_at":"2019-02-26T17:07:11Z","git_url":"git://github.com/argoproj/argo-cd.git","ssh_url":"git@github.com:argoproj/argo-cd.git","clone_url":"https://github.com/argoproj/argo-cd.git","svn_url":"https://github.com/argoproj/argo-cd","homepage":"","size":9347,"stargazers_count":789,"watchers_count":789,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":109,"open_issues":85,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165"},"html":{"href":"https://github.com/argoproj/argo-cd/pull/1165"},"issue":{"href":"https://api.github.com/repos/argoproj/argo-cd/issues/1165"},"comments":{"href":"https://api.github.com/repos/argoproj/argo-cd/issues/1165/comments"},"review_comments":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165/comments"},"review_comment":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1165/commits"},"statuses":{"href":"https://api.github.com/repos/argoproj/argo-cd/statuses/6b065bd1db2ba76249627739cd3c7ae62d89ed19"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jessesuen"}}