{"action":"created","issue":{"url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/issues/1","repository_url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00","labels_url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/issues/1/comments","events_url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/issues/1/events","html_url":"https://github.com/helleworldGIT/InfoCoin_v00/pull/1","id":532933671,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5MDkyMDY3","number":1,"title":"Agregando .gitignore y eliminacion de las carpetas ./node_modules y ./dist","user":{"login":"Carlos-Trinidad","id":18605964,"node_id":"MDQ6VXNlcjE4NjA1OTY0","avatar_url":"https://avatars3.githubusercontent.com/u/18605964?v=4","gravatar_id":"","url":"https://api.github.com/users/Carlos-Trinidad","html_url":"https://github.com/Carlos-Trinidad","followers_url":"https://api.github.com/users/Carlos-Trinidad/followers","following_url":"https://api.github.com/users/Carlos-Trinidad/following{/other_user}","gists_url":"https://api.github.com/users/Carlos-Trinidad/gists{/gist_id}","starred_url":"https://api.github.com/users/Carlos-Trinidad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carlos-Trinidad/subscriptions","organizations_url":"https://api.github.com/users/Carlos-Trinidad/orgs","repos_url":"https://api.github.com/users/Carlos-Trinidad/repos","events_url":"https://api.github.com/users/Carlos-Trinidad/events{/privacy}","received_events_url":"https://api.github.com/users/Carlos-Trinidad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-12-04T21:04:36Z","updated_at":"2019-12-04T21:35:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/pulls/1","html_url":"https://github.com/helleworldGIT/InfoCoin_v00/pull/1","diff_url":"https://github.com/helleworldGIT/InfoCoin_v00/pull/1.diff","patch_url":"https://github.com/helleworldGIT/InfoCoin_v00/pull/1.patch"},"body":"Hola! Vi que compartiste este repo por twitter y me dieron ganas de mirarlo. Te dejo unos cambios y recomendaciones para que tengas en cuenta!\r\n\r\nSiempre se intenta no subir la carpeta node_modules al repositorio de git, ya que pesa demasiado y no hace falta. Una vez clonado el repositorio localmente se puede hacer el comando npm install y automaticamente se va crear la carpeta node_modules con todas las dependencias necesarias.\r\n\r\nPor otro lado, es opcional, pero también se intenta no subir la carpeta dist, ya que esta es el codigo compilado final y lo mejor es que en el repositorio solo quede codigo fuente. Una vez mas, con el repositorio clonado localmente se puede hacer el build y obtener la carpeta dist.\r\n\r\nY por ultimo también te dejo el archivo .gitignore, en este archivo se específica cuales archivos se deben ignorar, de este modo git no los trackea y no se suben al repo. En este caso le agregue las carpetas node_modules y dist.\r\n\r\nSigue avanzando!"},"comment":{"url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/issues/comments/561849790","html_url":"https://github.com/helleworldGIT/InfoCoin_v00/pull/1#issuecomment-561849790","issue_url":"https://api.github.com/repos/helleworldGIT/InfoCoin_v00/issues/1","id":561849790,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MTg0OTc5MA==","user":{"login":"helleworldGIT","id":44606766,"node_id":"MDQ6VXNlcjQ0NjA2NzY2","avatar_url":"https://avatars2.githubusercontent.com/u/44606766?v=4","gravatar_id":"","url":"https://api.github.com/users/helleworldGIT","html_url":"https://github.com/helleworldGIT","followers_url":"https://api.github.com/users/helleworldGIT/followers","following_url":"https://api.github.com/users/helleworldGIT/following{/other_user}","gists_url":"https://api.github.com/users/helleworldGIT/gists{/gist_id}","starred_url":"https://api.github.com/users/helleworldGIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helleworldGIT/subscriptions","organizations_url":"https://api.github.com/users/helleworldGIT/orgs","repos_url":"https://api.github.com/users/helleworldGIT/repos","events_url":"https://api.github.com/users/helleworldGIT/events{/privacy}","received_events_url":"https://api.github.com/users/helleworldGIT/received_events","type":"User","site_admin":false},"created_at":"2019-12-04T21:35:54Z","updated_at":"2019-12-04T21:35:54Z","author_association":"OWNER","body":"¡Mil gracias por revisar el repo! Subí la carpeta **dist** porque entendí que al utilizar **Netlify** para deployear debía subirla... ¿En caso de borrarla, Netlify podrá compilar por sí mismo y subir la página? Perdón si parece muy obvio, es la primera vez que subo algo a Netlify desde Github!"}}
{"actor":{"display_login":"helleworldGIT"}}