{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/journal-formula/pulls/comments/283880501","pull_request_review_id":237350771,"id":283880501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Mzg4MDUwMQ==","diff_hunk":"@@ -0,0 +1,9 @@\n+{%- if pillar.elife.env == 'dev' -%}\n+{%- set app_env = 'ci' -%}\n+{%- else -%}\n+{%- set app_env = pillar.elife.env -%}\n+{%- endif -%}\n+APP_ENV={{ app_env }}","path":"salt/journal/config/srv-journal-containers.env","position":6,"original_position":6,"commit_id":"a5dc7421c80c86c6687446ed03750e0bb990f5b8","original_commit_id":"a5dc7421c80c86c6687446ed03750e0bb990f5b8","user":{"login":"giorgiosironi","id":160299,"node_id":"MDQ6VXNlcjE2MDI5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"Wrong, it was provided before through `fastcgi_param` and in various other places.","created_at":"2019-05-14T16:06:19Z","updated_at":"2019-05-14T16:06:19Z","html_url":"https://github.com/elifesciences/journal-formula/pull/90#discussion_r283880501","pull_request_url":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/journal-formula/pulls/comments/283880501"},"html":{"href":"https://github.com/elifesciences/journal-formula/pull/90#discussion_r283880501"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90"}},"in_reply_to_id":283849909},"pull_request":{"url":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90","id":278705756,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4NzA1NzU2","html_url":"https://github.com/elifesciences/journal-formula/pull/90","diff_url":"https://github.com/elifesciences/journal-formula/pull/90.diff","patch_url":"https://github.com/elifesciences/journal-formula/pull/90.patch","issue_url":"https://api.github.com/repos/elifesciences/journal-formula/issues/90","number":90,"state":"open","locked":false,"title":"Run journal in containers","user":{"login":"giorgiosironi","id":160299,"node_id":"MDQ6VXNlcjE2MDI5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"Main part of https://github.com/elifesciences/issues/issues/3676\n\nA host-based nginx is the only remaining part since it has a complex configuration. It forwards to static files in the `elifesciences/journal_web` container, and to the php-fpm container `elifesciences/journal`.","created_at":"2019-05-14T14:19:54Z","updated_at":"2019-05-14T16:06:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae29d7102e0f6c65be8e6733a9df482716c51c3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90/commits","review_comments_url":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90/comments","review_comment_url":"https://api.github.com/repos/elifesciences/journal-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/journal-formula/issues/90/comments","statuses_url":"https://api.github.com/repos/elifesciences/journal-formula/statuses/a5dc7421c80c86c6687446ed03750e0bb990f5b8","head":{"label":"elifesciences:run_container_image","ref":"run_container_image","sha":"a5dc7421c80c86c6687446ed03750e0bb990f5b8","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":62222825,"node_id":"MDEwOlJlcG9zaXRvcnk2MjIyMjgyNQ==","name":"journal-formula","full_name":"elifesciences/journal-formula","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/journal-formula","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/journal-formula","forks_url":"https://api.github.com/repos/elifesciences/journal-formula/forks","keys_url":"https://api.github.com/repos/elifesciences/journal-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/journal-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/journal-formula/teams","hooks_url":"https://api.github.com/repos/elifesciences/journal-formula/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/journal-formula/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/journal-formula/events","assignees_url":"https://api.github.com/repos/elifesciences/journal-formula/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/journal-formula/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/journal-formula/tags","blobs_url":"https://api.github.com/repos/elifesciences/journal-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/journal-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/journal-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/journal-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/journal-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/journal-formula/languages","stargazers_url":"https://api.github.com/repos/elifesciences/journal-formula/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/journal-formula/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/journal-formula/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/journal-formula/subscription","commits_url":"https://api.github.com/repos/elifesciences/journal-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/journal-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/journal-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/journal-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/journal-formula/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/journal-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/journal-formula/merges","archive_url":"https://api.github.com/repos/elifesciences/journal-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/journal-formula/downloads","issues_url":"https://api.github.com/repos/elifesciences/journal-formula/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/journal-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/journal-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/journal-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/journal-formula/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/journal-formula/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/journal-formula/deployments","created_at":"2016-06-29T12:07:21Z","updated_at":"2019-03-18T15:46:12Z","pushed_at":"2019-05-14T14:58:32Z","git_url":"git://github.com/elifesciences/journal-formula.git","ssh_url":"git@github.com:elifesciences/journal-formula.git","clone_url":"https://github.com/elifesciences/journal-formula.git","svn_url":"https://github.com/elifesciences/journal-formula","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"elifesciences:master","ref":"master","sha":"3783d661efb7a3cc830d1639acc2ac7182b324ca","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":62222825,"node_id":"MDEwOlJlcG9zaXRvcnk2MjIyMjgyNQ==","name":"journal-formula","full_name":"elifesciences/journal-formula","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/journal-formula","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/journal-formula","forks_url":"https://api.github.com/repos/elifesciences/journal-formula/forks","keys_url":"https://api.github.com/repos/elifesciences/journal-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/journal-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/journal-formula/teams","hooks_url":"https://api.github.com/repos/elifesciences/journal-formula/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/journal-formula/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/journal-formula/events","assignees_url":"https://api.github.com/repos/elifesciences/journal-formula/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/journal-formula/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/journal-formula/tags","blobs_url":"https://api.github.com/repos/elifesciences/journal-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/journal-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/journal-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/journal-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/journal-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/journal-formula/languages","stargazers_url":"https://api.github.com/repos/elifesciences/journal-formula/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/journal-formula/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/journal-formula/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/journal-formula/subscription","commits_url":"https://api.github.com/repos/elifesciences/journal-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/journal-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/journal-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/journal-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/journal-formula/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/journal-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/journal-formula/merges","archive_url":"https://api.github.com/repos/elifesciences/journal-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/journal-formula/downloads","issues_url":"https://api.github.com/repos/elifesciences/journal-formula/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/journal-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/journal-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/journal-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/journal-formula/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/journal-formula/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/journal-formula/deployments","created_at":"2016-06-29T12:07:21Z","updated_at":"2019-03-18T15:46:12Z","pushed_at":"2019-05-14T14:58:32Z","git_url":"git://github.com/elifesciences/journal-formula.git","ssh_url":"git@github.com:elifesciences/journal-formula.git","clone_url":"https://github.com/elifesciences/journal-formula.git","svn_url":"https://github.com/elifesciences/journal-formula","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90"},"html":{"href":"https://github.com/elifesciences/journal-formula/pull/90"},"issue":{"href":"https://api.github.com/repos/elifesciences/journal-formula/issues/90"},"comments":{"href":"https://api.github.com/repos/elifesciences/journal-formula/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/journal-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/journal-formula/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/journal-formula/statuses/a5dc7421c80c86c6687446ed03750e0bb990f5b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giorgiosironi"}}