{"action":"opened","issue":{"url":"https://api.github.com/repos/swarrot/swarrot/issues/187","repository_url":"https://api.github.com/repos/swarrot/swarrot","labels_url":"https://api.github.com/repos/swarrot/swarrot/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/swarrot/swarrot/issues/187/comments","events_url":"https://api.github.com/repos/swarrot/swarrot/issues/187/events","html_url":"https://github.com/swarrot/swarrot/issues/187","id":445032082,"node_id":"MDU6SXNzdWU0NDUwMzIwODI=","number":187,"title":"Avoid dynamic messages when logging","user":{"login":"greg0ire","id":657779,"node_id":"MDQ6VXNlcjY1Nzc3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-16T15:49:10Z","updated_at":"2019-05-16T15:49:10Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Right now, when I look at my Kibana dashboard, I get no grouping\r\n![Untitled](https://user-images.githubusercontent.com/657779/57868007-77ff5280-7802-11e9-900e-b3d28a644af9.png)\r\n\r\nThis can easily be fixed by using static messages and a dynamic `$context`:\r\n\r\n```php\r\n    $this->logger->info(\r\n        \"[Ack] Message # has been correctly ack'ed\",\r\n        [\r\n           'message_id' => $message->getId(),\r\n           'swarrot_processor' => 'ack',\r\n        ]\r\n    );\r\n```\r\n\r\ninstead of https://github.com/swarrot/swarrot/blob/4b945ad0225a1be8e275ee83849482f3a39f33b3/src/Swarrot/Processor/Ack/AckProcessor.php#L51-L56\r\n\r\nIf you agree, I can create a PR. There are many more instances of that issue, that's why I'm asking before fixing them all.\r\n"}}
{"actor":{"display_login":"greg0ire"}}