{"action":"created","comment":{"url":"https://api.github.com/repos/carbon-design-system/carbon/pulls/comments/354977233","pull_request_review_id":328237785,"id":354977233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDk3NzIzMw==","diff_hunk":"@@ -123,20 +126,21 @@ async function inlineSassDependencies(\n function findSassModule(packageName, cwd) {\n   let currentDirectory = cwd;\n \n-  while (currentDirectory !== '/') {\n-    const nodeModulesFolder = path.join(currentDirectory, 'node_modules');\n+  if (","path":"packages/bundler/src/commands/inline.js","position":74,"original_position":74,"commit_id":"ada870bd444dbb242d6ecbb229f7a4a25d4f091d","original_commit_id":"20359555a5cc4cde6d4eaf5ac8e6af083be5e3de","user":{"login":"joshblack","id":3901764,"node_id":"MDQ6VXNlcjM5MDE3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3901764?v=4","gravatar_id":"","url":"https://api.github.com/users/joshblack","html_url":"https://github.com/joshblack","followers_url":"https://api.github.com/users/joshblack/followers","following_url":"https://api.github.com/users/joshblack/following{/other_user}","gists_url":"https://api.github.com/users/joshblack/gists{/gist_id}","starred_url":"https://api.github.com/users/joshblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshblack/subscriptions","organizations_url":"https://api.github.com/users/joshblack/orgs","repos_url":"https://api.github.com/users/joshblack/repos","events_url":"https://api.github.com/users/joshblack/events{/privacy}","received_events_url":"https://api.github.com/users/joshblack/received_events","type":"User","site_admin":false},"body":"Seems like we lost the recursive nature of this block, any particular reason?\r\n\r\nSeparately, what are the best practices for handling per-drive directory naming conventions? 🤔 ","created_at":"2019-12-06T18:45:39Z","updated_at":"2019-12-06T18:46:24Z","html_url":"https://github.com/carbon-design-system/carbon/pull/4823#discussion_r354977233","pull_request_url":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/carbon-design-system/carbon/pulls/comments/354977233"},"html":{"href":"https://github.com/carbon-design-system/carbon/pull/4823#discussion_r354977233"},"pull_request":{"href":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823"}}},"pull_request":{"url":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823","id":349832272,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5ODMyMjcy","html_url":"https://github.com/carbon-design-system/carbon/pull/4823","diff_url":"https://github.com/carbon-design-system/carbon/pull/4823.diff","patch_url":"https://github.com/carbon-design-system/carbon/pull/4823.patch","issue_url":"https://api.github.com/repos/carbon-design-system/carbon/issues/4823","number":4823,"state":"open","locked":false,"title":"fix(project): build issues on windows","user":{"login":"sichangi","id":16804232,"node_id":"MDQ6VXNlcjE2ODA0MjMy","avatar_url":"https://avatars1.githubusercontent.com/u/16804232?v=4","gravatar_id":"","url":"https://api.github.com/users/sichangi","html_url":"https://github.com/sichangi","followers_url":"https://api.github.com/users/sichangi/followers","following_url":"https://api.github.com/users/sichangi/following{/other_user}","gists_url":"https://api.github.com/users/sichangi/gists{/gist_id}","starred_url":"https://api.github.com/users/sichangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sichangi/subscriptions","organizations_url":"https://api.github.com/users/sichangi/orgs","repos_url":"https://api.github.com/users/sichangi/repos","events_url":"https://api.github.com/users/sichangi/events{/privacy}","received_events_url":"https://api.github.com/users/sichangi/received_events","type":"User","site_admin":false},"body":"Closes #4809\r\n\r\nFixes build errors on running the ``build`` script on the windows operating system\r\n\r\n#### Changelog\r\n\r\n**New**\r\n\r\n- The react & vanilla icon builder checks the current operating system and handles path related operations accordingly\r\n- The same applies to the bundlers ``inline`` command\r\n- As well as the ``elements`` package build task\r\n- Clearer logging during builds\r\n\r\n**Changed**\r\n\r\n- The react & vanilla icon builder script now generates icon variable names that start with a number, which throws an error while bundling, with an underscore on windows but retains initial behavior on other operating systems.\r\n\r\n#### Testing / Reviewing\r\n- Should work as expected on any other previously functional operating system\r\n- Should generate similarly functioning outputs for react & vanilla icons \r\n\r\n","created_at":"2019-12-06T08:54:30Z","updated_at":"2019-12-06T18:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69eda19f7d51c727862720184c19de5a483b5bfa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asudoh","id":1259051,"node_id":"MDQ6VXNlcjEyNTkwNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1259051?v=4","gravatar_id":"","url":"https://api.github.com/users/asudoh","html_url":"https://github.com/asudoh","followers_url":"https://api.github.com/users/asudoh/followers","following_url":"https://api.github.com/users/asudoh/following{/other_user}","gists_url":"https://api.github.com/users/asudoh/gists{/gist_id}","starred_url":"https://api.github.com/users/asudoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asudoh/subscriptions","organizations_url":"https://api.github.com/users/asudoh/orgs","repos_url":"https://api.github.com/users/asudoh/repos","events_url":"https://api.github.com/users/asudoh/events{/privacy}","received_events_url":"https://api.github.com/users/asudoh/received_events","type":"User","site_admin":false},{"login":"dakahn","id":40970507,"node_id":"MDQ6VXNlcjQwOTcwNTA3","avatar_url":"https://avatars3.githubusercontent.com/u/40970507?v=4","gravatar_id":"","url":"https://api.github.com/users/dakahn","html_url":"https://github.com/dakahn","followers_url":"https://api.github.com/users/dakahn/followers","following_url":"https://api.github.com/users/dakahn/following{/other_user}","gists_url":"https://api.github.com/users/dakahn/gists{/gist_id}","starred_url":"https://api.github.com/users/dakahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakahn/subscriptions","organizations_url":"https://api.github.com/users/dakahn/orgs","repos_url":"https://api.github.com/users/dakahn/repos","events_url":"https://api.github.com/users/dakahn/events{/privacy}","received_events_url":"https://api.github.com/users/dakahn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823/commits","review_comments_url":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823/comments","review_comment_url":"https://api.github.com/repos/carbon-design-system/carbon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carbon-design-system/carbon/issues/4823/comments","statuses_url":"https://api.github.com/repos/carbon-design-system/carbon/statuses/ada870bd444dbb242d6ecbb229f7a4a25d4f091d","head":{"label":"sichangi:windows-support","ref":"windows-support","sha":"ada870bd444dbb242d6ecbb229f7a4a25d4f091d","user":{"login":"sichangi","id":16804232,"node_id":"MDQ6VXNlcjE2ODA0MjMy","avatar_url":"https://avatars1.githubusercontent.com/u/16804232?v=4","gravatar_id":"","url":"https://api.github.com/users/sichangi","html_url":"https://github.com/sichangi","followers_url":"https://api.github.com/users/sichangi/followers","following_url":"https://api.github.com/users/sichangi/following{/other_user}","gists_url":"https://api.github.com/users/sichangi/gists{/gist_id}","starred_url":"https://api.github.com/users/sichangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sichangi/subscriptions","organizations_url":"https://api.github.com/users/sichangi/orgs","repos_url":"https://api.github.com/users/sichangi/repos","events_url":"https://api.github.com/users/sichangi/events{/privacy}","received_events_url":"https://api.github.com/users/sichangi/received_events","type":"User","site_admin":false},"repo":{"id":226279844,"node_id":"MDEwOlJlcG9zaXRvcnkyMjYyNzk4NDQ=","name":"carbon","full_name":"sichangi/carbon","private":false,"owner":{"login":"sichangi","id":16804232,"node_id":"MDQ6VXNlcjE2ODA0MjMy","avatar_url":"https://avatars1.githubusercontent.com/u/16804232?v=4","gravatar_id":"","url":"https://api.github.com/users/sichangi","html_url":"https://github.com/sichangi","followers_url":"https://api.github.com/users/sichangi/followers","following_url":"https://api.github.com/users/sichangi/following{/other_user}","gists_url":"https://api.github.com/users/sichangi/gists{/gist_id}","starred_url":"https://api.github.com/users/sichangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sichangi/subscriptions","organizations_url":"https://api.github.com/users/sichangi/orgs","repos_url":"https://api.github.com/users/sichangi/repos","events_url":"https://api.github.com/users/sichangi/events{/privacy}","received_events_url":"https://api.github.com/users/sichangi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sichangi/carbon","description":"A design system built by IBM","fork":true,"url":"https://api.github.com/repos/sichangi/carbon","forks_url":"https://api.github.com/repos/sichangi/carbon/forks","keys_url":"https://api.github.com/repos/sichangi/carbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sichangi/carbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sichangi/carbon/teams","hooks_url":"https://api.github.com/repos/sichangi/carbon/hooks","issue_events_url":"https://api.github.com/repos/sichangi/carbon/issues/events{/number}","events_url":"https://api.github.com/repos/sichangi/carbon/events","assignees_url":"https://api.github.com/repos/sichangi/carbon/assignees{/user}","branches_url":"https://api.github.com/repos/sichangi/carbon/branches{/branch}","tags_url":"https://api.github.com/repos/sichangi/carbon/tags","blobs_url":"https://api.github.com/repos/sichangi/carbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sichangi/carbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sichangi/carbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sichangi/carbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sichangi/carbon/statuses/{sha}","languages_url":"https://api.github.com/repos/sichangi/carbon/languages","stargazers_url":"https://api.github.com/repos/sichangi/carbon/stargazers","contributors_url":"https://api.github.com/repos/sichangi/carbon/contributors","subscribers_url":"https://api.github.com/repos/sichangi/carbon/subscribers","subscription_url":"https://api.github.com/repos/sichangi/carbon/subscription","commits_url":"https://api.github.com/repos/sichangi/carbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sichangi/carbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sichangi/carbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sichangi/carbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sichangi/carbon/contents/{+path}","compare_url":"https://api.github.com/repos/sichangi/carbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sichangi/carbon/merges","archive_url":"https://api.github.com/repos/sichangi/carbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sichangi/carbon/downloads","issues_url":"https://api.github.com/repos/sichangi/carbon/issues{/number}","pulls_url":"https://api.github.com/repos/sichangi/carbon/pulls{/number}","milestones_url":"https://api.github.com/repos/sichangi/carbon/milestones{/number}","notifications_url":"https://api.github.com/repos/sichangi/carbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sichangi/carbon/labels{/name}","releases_url":"https://api.github.com/repos/sichangi/carbon/releases{/id}","deployments_url":"https://api.github.com/repos/sichangi/carbon/deployments","created_at":"2019-12-06T08:20:43Z","updated_at":"2019-12-06T08:20:45Z","pushed_at":"2019-12-06T16:54:45Z","git_url":"git://github.com/sichangi/carbon.git","ssh_url":"git@github.com:sichangi/carbon.git","clone_url":"https://github.com/sichangi/carbon.git","svn_url":"https://github.com/sichangi/carbon","homepage":"https://www.carbondesignsystem.com","size":450182,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"carbon-design-system:master","ref":"master","sha":"a0f1d75782a1fc240272ae7d8ff9a268ba1d51ef","user":{"login":"carbon-design-system","id":25179978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTc5OTc4","avatar_url":"https://avatars3.githubusercontent.com/u/25179978?v=4","gravatar_id":"","url":"https://api.github.com/users/carbon-design-system","html_url":"https://github.com/carbon-design-system","followers_url":"https://api.github.com/users/carbon-design-system/followers","following_url":"https://api.github.com/users/carbon-design-system/following{/other_user}","gists_url":"https://api.github.com/users/carbon-design-system/gists{/gist_id}","starred_url":"https://api.github.com/users/carbon-design-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbon-design-system/subscriptions","organizations_url":"https://api.github.com/users/carbon-design-system/orgs","repos_url":"https://api.github.com/users/carbon-design-system/repos","events_url":"https://api.github.com/users/carbon-design-system/events{/privacy}","received_events_url":"https://api.github.com/users/carbon-design-system/received_events","type":"Organization","site_admin":false},"repo":{"id":84835535,"node_id":"MDEwOlJlcG9zaXRvcnk4NDgzNTUzNQ==","name":"carbon","full_name":"carbon-design-system/carbon","private":false,"owner":{"login":"carbon-design-system","id":25179978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTc5OTc4","avatar_url":"https://avatars3.githubusercontent.com/u/25179978?v=4","gravatar_id":"","url":"https://api.github.com/users/carbon-design-system","html_url":"https://github.com/carbon-design-system","followers_url":"https://api.github.com/users/carbon-design-system/followers","following_url":"https://api.github.com/users/carbon-design-system/following{/other_user}","gists_url":"https://api.github.com/users/carbon-design-system/gists{/gist_id}","starred_url":"https://api.github.com/users/carbon-design-system/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbon-design-system/subscriptions","organizations_url":"https://api.github.com/users/carbon-design-system/orgs","repos_url":"https://api.github.com/users/carbon-design-system/repos","events_url":"https://api.github.com/users/carbon-design-system/events{/privacy}","received_events_url":"https://api.github.com/users/carbon-design-system/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/carbon-design-system/carbon","description":"A design system built by IBM","fork":false,"url":"https://api.github.com/repos/carbon-design-system/carbon","forks_url":"https://api.github.com/repos/carbon-design-system/carbon/forks","keys_url":"https://api.github.com/repos/carbon-design-system/carbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carbon-design-system/carbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carbon-design-system/carbon/teams","hooks_url":"https://api.github.com/repos/carbon-design-system/carbon/hooks","issue_events_url":"https://api.github.com/repos/carbon-design-system/carbon/issues/events{/number}","events_url":"https://api.github.com/repos/carbon-design-system/carbon/events","assignees_url":"https://api.github.com/repos/carbon-design-system/carbon/assignees{/user}","branches_url":"https://api.github.com/repos/carbon-design-system/carbon/branches{/branch}","tags_url":"https://api.github.com/repos/carbon-design-system/carbon/tags","blobs_url":"https://api.github.com/repos/carbon-design-system/carbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carbon-design-system/carbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carbon-design-system/carbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/carbon-design-system/carbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carbon-design-system/carbon/statuses/{sha}","languages_url":"https://api.github.com/repos/carbon-design-system/carbon/languages","stargazers_url":"https://api.github.com/repos/carbon-design-system/carbon/stargazers","contributors_url":"https://api.github.com/repos/carbon-design-system/carbon/contributors","subscribers_url":"https://api.github.com/repos/carbon-design-system/carbon/subscribers","subscription_url":"https://api.github.com/repos/carbon-design-system/carbon/subscription","commits_url":"https://api.github.com/repos/carbon-design-system/carbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/carbon-design-system/carbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/carbon-design-system/carbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/carbon-design-system/carbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/carbon-design-system/carbon/contents/{+path}","compare_url":"https://api.github.com/repos/carbon-design-system/carbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carbon-design-system/carbon/merges","archive_url":"https://api.github.com/repos/carbon-design-system/carbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carbon-design-system/carbon/downloads","issues_url":"https://api.github.com/repos/carbon-design-system/carbon/issues{/number}","pulls_url":"https://api.github.com/repos/carbon-design-system/carbon/pulls{/number}","milestones_url":"https://api.github.com/repos/carbon-design-system/carbon/milestones{/number}","notifications_url":"https://api.github.com/repos/carbon-design-system/carbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carbon-design-system/carbon/labels{/name}","releases_url":"https://api.github.com/repos/carbon-design-system/carbon/releases{/id}","deployments_url":"https://api.github.com/repos/carbon-design-system/carbon/deployments","created_at":"2017-03-13T14:23:59Z","updated_at":"2019-12-06T18:38:26Z","pushed_at":"2019-12-06T16:54:47Z","git_url":"git://github.com/carbon-design-system/carbon.git","ssh_url":"git@github.com:carbon-design-system/carbon.git","clone_url":"https://github.com/carbon-design-system/carbon.git","svn_url":"https://github.com/carbon-design-system/carbon","homepage":"https://www.carbondesignsystem.com","size":450177,"stargazers_count":2360,"watchers_count":2360,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":501,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":453,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":501,"open_issues":453,"watchers":2360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823"},"html":{"href":"https://github.com/carbon-design-system/carbon/pull/4823"},"issue":{"href":"https://api.github.com/repos/carbon-design-system/carbon/issues/4823"},"comments":{"href":"https://api.github.com/repos/carbon-design-system/carbon/issues/4823/comments"},"review_comments":{"href":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823/comments"},"review_comment":{"href":"https://api.github.com/repos/carbon-design-system/carbon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carbon-design-system/carbon/pulls/4823/commits"},"statuses":{"href":"https://api.github.com/repos/carbon-design-system/carbon/statuses/ada870bd444dbb242d6ecbb229f7a4a25d4f091d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joshblack"}}