{"action":"created","comment":{"url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/comments/354177163","pull_request_review_id":327390026,"id":354177163,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDE3NzE2Mw==","diff_hunk":"@@ -82,15 +81,44 @@ describe('/signals/settings/roles/components/RoleForm', () => {\n     });\n   });\n \n+  it('should handle submit flow when saving an new role', () => {\n+    props.role = undefined;","path":"src/signals/settings/roles/containers/RoleFormContainer/components/RoleForm/__test__/RoleForm.test.js","position":null,"original_position":71,"commit_id":"4dce0c36a3b48abc799eb8340f781c3e72d98cbd","original_commit_id":"47b4a3c3e84d239ebd701dc7bf079da9381bc95e","user":{"login":"jasperswart","id":4640157,"node_id":"MDQ6VXNlcjQ2NDAxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4640157?v=4","gravatar_id":"","url":"https://api.github.com/users/jasperswart","html_url":"https://github.com/jasperswart","followers_url":"https://api.github.com/users/jasperswart/followers","following_url":"https://api.github.com/users/jasperswart/following{/other_user}","gists_url":"https://api.github.com/users/jasperswart/gists{/gist_id}","starred_url":"https://api.github.com/users/jasperswart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasperswart/subscriptions","organizations_url":"https://api.github.com/users/jasperswart/orgs","repos_url":"https://api.github.com/users/jasperswart/repos","events_url":"https://api.github.com/users/jasperswart/events{/privacy}","received_events_url":"https://api.github.com/users/jasperswart/received_events","type":"User","site_admin":false},"body":"gedaan","created_at":"2019-12-05T08:57:42Z","updated_at":"2019-12-05T08:57:43Z","html_url":"https://github.com/Amsterdam/signals-frontend/pull/485#discussion_r354177163","pull_request_url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/comments/354177163"},"html":{"href":"https://github.com/Amsterdam/signals-frontend/pull/485#discussion_r354177163"},"pull_request":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485"}},"in_reply_to_id":353193795},"pull_request":{"url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485","id":347540201,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3NTQwMjAx","html_url":"https://github.com/Amsterdam/signals-frontend/pull/485","diff_url":"https://github.com/Amsterdam/signals-frontend/pull/485.diff","patch_url":"https://github.com/Amsterdam/signals-frontend/pull/485.patch","issue_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/485","number":485,"state":"open","locked":false,"title":"Sig 1844 add role","user":{"login":"jasperswart","id":4640157,"node_id":"MDQ6VXNlcjQ2NDAxNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4640157?v=4","gravatar_id":"","url":"https://api.github.com/users/jasperswart","html_url":"https://github.com/jasperswart","followers_url":"https://api.github.com/users/jasperswart/followers","following_url":"https://api.github.com/users/jasperswart/following{/other_user}","gists_url":"https://api.github.com/users/jasperswart/gists{/gist_id}","starred_url":"https://api.github.com/users/jasperswart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasperswart/subscriptions","organizations_url":"https://api.github.com/users/jasperswart/orgs","repos_url":"https://api.github.com/users/jasperswart/repos","events_url":"https://api.github.com/users/jasperswart/events{/privacy}","received_events_url":"https://api.github.com/users/jasperswart/received_events","type":"User","site_admin":false},"body":"In this PR:\r\n- added onSaveRole action to RoleForm and RoleFormContainer\r\n- moved Form and List components in containers/components dir \r\n- added FormFooter to RoleForm\r\n- removed disabled state in submit button\r\n- added new role button in RoleListContainer\r\n- removed all hard coded routes\r\n- useCallback everywhere\r\n\r\nPLEASE NOTE: this is a branching from role-edit","created_at":"2019-12-02T10:09:58Z","updated_at":"2019-12-05T08:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"316ac523115236b7c169b621abb4b42d47233fdc","assignee":{"login":"spaces-ga","id":57347361,"node_id":"MDQ6VXNlcjU3MzQ3MzYx","avatar_url":"https://avatars1.githubusercontent.com/u/57347361?v=4","gravatar_id":"","url":"https://api.github.com/users/spaces-ga","html_url":"https://github.com/spaces-ga","followers_url":"https://api.github.com/users/spaces-ga/followers","following_url":"https://api.github.com/users/spaces-ga/following{/other_user}","gists_url":"https://api.github.com/users/spaces-ga/gists{/gist_id}","starred_url":"https://api.github.com/users/spaces-ga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaces-ga/subscriptions","organizations_url":"https://api.github.com/users/spaces-ga/orgs","repos_url":"https://api.github.com/users/spaces-ga/repos","events_url":"https://api.github.com/users/spaces-ga/events{/privacy}","received_events_url":"https://api.github.com/users/spaces-ga/received_events","type":"User","site_admin":false},"assignees":[{"login":"spaces-ga","id":57347361,"node_id":"MDQ6VXNlcjU3MzQ3MzYx","avatar_url":"https://avatars1.githubusercontent.com/u/57347361?v=4","gravatar_id":"","url":"https://api.github.com/users/spaces-ga","html_url":"https://github.com/spaces-ga","followers_url":"https://api.github.com/users/spaces-ga/followers","following_url":"https://api.github.com/users/spaces-ga/following{/other_user}","gists_url":"https://api.github.com/users/spaces-ga/gists{/gist_id}","starred_url":"https://api.github.com/users/spaces-ga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaces-ga/subscriptions","organizations_url":"https://api.github.com/users/spaces-ga/orgs","repos_url":"https://api.github.com/users/spaces-ga/repos","events_url":"https://api.github.com/users/spaces-ga/events{/privacy}","received_events_url":"https://api.github.com/users/spaces-ga/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"spaces-ga","id":57347361,"node_id":"MDQ6VXNlcjU3MzQ3MzYx","avatar_url":"https://avatars1.githubusercontent.com/u/57347361?v=4","gravatar_id":"","url":"https://api.github.com/users/spaces-ga","html_url":"https://github.com/spaces-ga","followers_url":"https://api.github.com/users/spaces-ga/followers","following_url":"https://api.github.com/users/spaces-ga/following{/other_user}","gists_url":"https://api.github.com/users/spaces-ga/gists{/gist_id}","starred_url":"https://api.github.com/users/spaces-ga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaces-ga/subscriptions","organizations_url":"https://api.github.com/users/spaces-ga/orgs","repos_url":"https://api.github.com/users/spaces-ga/repos","events_url":"https://api.github.com/users/spaces-ga/events{/privacy}","received_events_url":"https://api.github.com/users/spaces-ga/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485/commits","review_comments_url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485/comments","review_comment_url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/485/comments","statuses_url":"https://api.github.com/repos/Amsterdam/signals-frontend/statuses/4dce0c36a3b48abc799eb8340f781c3e72d98cbd","head":{"label":"Amsterdam:SIG-1844-add-role","ref":"SIG-1844-add-role","sha":"4dce0c36a3b48abc799eb8340f781c3e72d98cbd","user":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":136471205,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NzEyMDU=","name":"signals-frontend","full_name":"Amsterdam/signals-frontend","private":false,"owner":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Amsterdam/signals-frontend","description":"Frontend of the SIA (Signalen Informatievoorziening Amsterdam)","fork":false,"url":"https://api.github.com/repos/Amsterdam/signals-frontend","forks_url":"https://api.github.com/repos/Amsterdam/signals-frontend/forks","keys_url":"https://api.github.com/repos/Amsterdam/signals-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amsterdam/signals-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amsterdam/signals-frontend/teams","hooks_url":"https://api.github.com/repos/Amsterdam/signals-frontend/hooks","issue_events_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Amsterdam/signals-frontend/events","assignees_url":"https://api.github.com/repos/Amsterdam/signals-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Amsterdam/signals-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Amsterdam/signals-frontend/tags","blobs_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amsterdam/signals-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Amsterdam/signals-frontend/languages","stargazers_url":"https://api.github.com/repos/Amsterdam/signals-frontend/stargazers","contributors_url":"https://api.github.com/repos/Amsterdam/signals-frontend/contributors","subscribers_url":"https://api.github.com/repos/Amsterdam/signals-frontend/subscribers","subscription_url":"https://api.github.com/repos/Amsterdam/signals-frontend/subscription","commits_url":"https://api.github.com/repos/Amsterdam/signals-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amsterdam/signals-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amsterdam/signals-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Amsterdam/signals-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amsterdam/signals-frontend/merges","archive_url":"https://api.github.com/repos/Amsterdam/signals-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amsterdam/signals-frontend/downloads","issues_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Amsterdam/signals-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Amsterdam/signals-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amsterdam/signals-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Amsterdam/signals-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Amsterdam/signals-frontend/deployments","created_at":"2018-06-07T12:02:30Z","updated_at":"2019-12-04T10:59:15Z","pushed_at":"2019-12-05T08:49:44Z","git_url":"git://github.com/Amsterdam/signals-frontend.git","ssh_url":"git@github.com:Amsterdam/signals-frontend.git","clone_url":"https://github.com/Amsterdam/signals-frontend.git","svn_url":"https://github.com/Amsterdam/signals-frontend","homepage":"","size":7593,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":5,"open_issues":8,"watchers":1,"default_branch":"develop"}},"base":{"label":"Amsterdam:SIG-1917_instellingen","ref":"SIG-1917_instellingen","sha":"e533aace901f7577e7fedd21eeba4836293f4433","user":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":136471205,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NzEyMDU=","name":"signals-frontend","full_name":"Amsterdam/signals-frontend","private":false,"owner":{"login":"Amsterdam","id":14022058,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDIyMDU4","avatar_url":"https://avatars0.githubusercontent.com/u/14022058?v=4","gravatar_id":"","url":"https://api.github.com/users/Amsterdam","html_url":"https://github.com/Amsterdam","followers_url":"https://api.github.com/users/Amsterdam/followers","following_url":"https://api.github.com/users/Amsterdam/following{/other_user}","gists_url":"https://api.github.com/users/Amsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/Amsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amsterdam/subscriptions","organizations_url":"https://api.github.com/users/Amsterdam/orgs","repos_url":"https://api.github.com/users/Amsterdam/repos","events_url":"https://api.github.com/users/Amsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/Amsterdam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Amsterdam/signals-frontend","description":"Frontend of the SIA (Signalen Informatievoorziening Amsterdam)","fork":false,"url":"https://api.github.com/repos/Amsterdam/signals-frontend","forks_url":"https://api.github.com/repos/Amsterdam/signals-frontend/forks","keys_url":"https://api.github.com/repos/Amsterdam/signals-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amsterdam/signals-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amsterdam/signals-frontend/teams","hooks_url":"https://api.github.com/repos/Amsterdam/signals-frontend/hooks","issue_events_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Amsterdam/signals-frontend/events","assignees_url":"https://api.github.com/repos/Amsterdam/signals-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Amsterdam/signals-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Amsterdam/signals-frontend/tags","blobs_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amsterdam/signals-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Amsterdam/signals-frontend/languages","stargazers_url":"https://api.github.com/repos/Amsterdam/signals-frontend/stargazers","contributors_url":"https://api.github.com/repos/Amsterdam/signals-frontend/contributors","subscribers_url":"https://api.github.com/repos/Amsterdam/signals-frontend/subscribers","subscription_url":"https://api.github.com/repos/Amsterdam/signals-frontend/subscription","commits_url":"https://api.github.com/repos/Amsterdam/signals-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amsterdam/signals-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amsterdam/signals-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amsterdam/signals-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Amsterdam/signals-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amsterdam/signals-frontend/merges","archive_url":"https://api.github.com/repos/Amsterdam/signals-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amsterdam/signals-frontend/downloads","issues_url":"https://api.github.com/repos/Amsterdam/signals-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Amsterdam/signals-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Amsterdam/signals-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amsterdam/signals-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Amsterdam/signals-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Amsterdam/signals-frontend/deployments","created_at":"2018-06-07T12:02:30Z","updated_at":"2019-12-04T10:59:15Z","pushed_at":"2019-12-05T08:49:44Z","git_url":"git://github.com/Amsterdam/signals-frontend.git","ssh_url":"git@github.com:Amsterdam/signals-frontend.git","clone_url":"https://github.com/Amsterdam/signals-frontend.git","svn_url":"https://github.com/Amsterdam/signals-frontend","homepage":"","size":7593,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":5,"open_issues":8,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485"},"html":{"href":"https://github.com/Amsterdam/signals-frontend/pull/485"},"issue":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/485"},"comments":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/Amsterdam/signals-frontend/statuses/4dce0c36a3b48abc799eb8340f781c3e72d98cbd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jasperswart"}}