{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/devtools/pulls/comments/348841156","pull_request_review_id":320571365,"id":348841156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODg0MTE1Ng==","diff_hunk":"@@ -50,11 +61,16 @@ class TimelineScreenBodyState extends State<TimelineScreenBody>\n     with AutoDisposeMixin {\n   TimelineController controller;\n \n+  TimelineMode get timelineMode => controller.timelineModeNotifier.value;\n+\n   @override\n   void didChangeDependencies() {\n     super.didChangeDependencies();\n     controller = Controllers.of(context).timeline;\n     controller.timelineService.updateListeningState(true);\n+\n+    cancel();\n+    addAutoDisposeListener(controller.timelineModeNotifier, refresh);","path":"packages/devtools_app/lib/src/timeline/flutter/timeline_screen.dart","position":45,"original_position":38,"commit_id":"ed8c81c7d05e061c3b17599089d783fe93cc47a4","original_commit_id":"73127a3780fd5de4cda52300a79bd7057204cb31","user":{"login":"DaveShuckerow","id":14947366,"node_id":"MDQ6VXNlcjE0OTQ3MzY2","avatar_url":"https://avatars2.githubusercontent.com/u/14947366?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveShuckerow","html_url":"https://github.com/DaveShuckerow","followers_url":"https://api.github.com/users/DaveShuckerow/followers","following_url":"https://api.github.com/users/DaveShuckerow/following{/other_user}","gists_url":"https://api.github.com/users/DaveShuckerow/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveShuckerow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveShuckerow/subscriptions","organizations_url":"https://api.github.com/users/DaveShuckerow/orgs","repos_url":"https://api.github.com/users/DaveShuckerow/repos","events_url":"https://api.github.com/users/DaveShuckerow/events{/privacy}","received_events_url":"https://api.github.com/users/DaveShuckerow/received_events","type":"User","site_admin":false},"body":"suggestion: we can make refresh private, and make the second parameter to this method an optional positional argument.  When not provided, default to refresh.","created_at":"2019-11-21T00:19:18Z","updated_at":"2019-11-21T00:41:19Z","html_url":"https://github.com/flutter/devtools/pull/1371#discussion_r348841156","pull_request_url":"https://api.github.com/repos/flutter/devtools/pulls/1371","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/devtools/pulls/comments/348841156"},"html":{"href":"https://github.com/flutter/devtools/pull/1371#discussion_r348841156"},"pull_request":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1371"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/devtools/pulls/1371","id":343720330,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzNzIwMzMw","html_url":"https://github.com/flutter/devtools/pull/1371","diff_url":"https://github.com/flutter/devtools/pull/1371.diff","patch_url":"https://github.com/flutter/devtools/pull/1371.patch","issue_url":"https://api.github.com/repos/flutter/devtools/issues/1371","number":1371,"state":"open","locked":false,"title":"Hook up Timeline buttons setup initial recording UI.","user":{"login":"kenzieschmoll","id":43759233,"node_id":"MDQ6VXNlcjQzNzU5MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43759233?v=4","gravatar_id":"","url":"https://api.github.com/users/kenzieschmoll","html_url":"https://github.com/kenzieschmoll","followers_url":"https://api.github.com/users/kenzieschmoll/followers","following_url":"https://api.github.com/users/kenzieschmoll/following{/other_user}","gists_url":"https://api.github.com/users/kenzieschmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/kenzieschmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenzieschmoll/subscriptions","organizations_url":"https://api.github.com/users/kenzieschmoll/orgs","repos_url":"https://api.github.com/users/kenzieschmoll/repos","events_url":"https://api.github.com/users/kenzieschmoll/events{/privacy}","received_events_url":"https://api.github.com/users/kenzieschmoll/received_events","type":"User","site_admin":false},"body":"Timeline buttons now pause/resume/record/stop/clear as expected.\r\n\r\nThis CL also switches to using a value notifier pattern throughout the timeline.\r\n\r\nAdded record instructions and status for full timeline.\r\n<img width=\"708\" alt=\"Screen Shot 2019-11-19 at 7 24 15 AM\" src=\"https://user-images.githubusercontent.com/43759233/69277754-b0a72c80-0b95-11ea-8506-a4a3d77e6641.png\">\r\n<img width=\"705\" alt=\"Screen Shot 2019-11-19 at 7 25 07 AM\" src=\"https://user-images.githubusercontent.com/43759233/69277769-b6047700-0b95-11ea-9c48-cc28ea7fda2d.png\">\r\n","created_at":"2019-11-20T21:00:44Z","updated_at":"2019-11-21T00:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"221d39364fbea89f7c691787c0b34ea4960736c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/devtools/pulls/1371/commits","review_comments_url":"https://api.github.com/repos/flutter/devtools/pulls/1371/comments","review_comment_url":"https://api.github.com/repos/flutter/devtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/devtools/issues/1371/comments","statuses_url":"https://api.github.com/repos/flutter/devtools/statuses/ed8c81c7d05e061c3b17599089d783fe93cc47a4","head":{"label":"kenzieschmoll:hookUpButtons","ref":"hookUpButtons","sha":"ed8c81c7d05e061c3b17599089d783fe93cc47a4","user":{"login":"kenzieschmoll","id":43759233,"node_id":"MDQ6VXNlcjQzNzU5MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43759233?v=4","gravatar_id":"","url":"https://api.github.com/users/kenzieschmoll","html_url":"https://github.com/kenzieschmoll","followers_url":"https://api.github.com/users/kenzieschmoll/followers","following_url":"https://api.github.com/users/kenzieschmoll/following{/other_user}","gists_url":"https://api.github.com/users/kenzieschmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/kenzieschmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenzieschmoll/subscriptions","organizations_url":"https://api.github.com/users/kenzieschmoll/orgs","repos_url":"https://api.github.com/users/kenzieschmoll/repos","events_url":"https://api.github.com/users/kenzieschmoll/events{/privacy}","received_events_url":"https://api.github.com/users/kenzieschmoll/received_events","type":"User","site_admin":false},"repo":{"id":159411616,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0MTE2MTY=","name":"devtools","full_name":"kenzieschmoll/devtools","private":false,"owner":{"login":"kenzieschmoll","id":43759233,"node_id":"MDQ6VXNlcjQzNzU5MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43759233?v=4","gravatar_id":"","url":"https://api.github.com/users/kenzieschmoll","html_url":"https://github.com/kenzieschmoll","followers_url":"https://api.github.com/users/kenzieschmoll/followers","following_url":"https://api.github.com/users/kenzieschmoll/following{/other_user}","gists_url":"https://api.github.com/users/kenzieschmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/kenzieschmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenzieschmoll/subscriptions","organizations_url":"https://api.github.com/users/kenzieschmoll/orgs","repos_url":"https://api.github.com/users/kenzieschmoll/repos","events_url":"https://api.github.com/users/kenzieschmoll/events{/privacy}","received_events_url":"https://api.github.com/users/kenzieschmoll/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kenzieschmoll/devtools","description":"Performance tools for Flutter.","fork":true,"url":"https://api.github.com/repos/kenzieschmoll/devtools","forks_url":"https://api.github.com/repos/kenzieschmoll/devtools/forks","keys_url":"https://api.github.com/repos/kenzieschmoll/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenzieschmoll/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenzieschmoll/devtools/teams","hooks_url":"https://api.github.com/repos/kenzieschmoll/devtools/hooks","issue_events_url":"https://api.github.com/repos/kenzieschmoll/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/kenzieschmoll/devtools/events","assignees_url":"https://api.github.com/repos/kenzieschmoll/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/kenzieschmoll/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/kenzieschmoll/devtools/tags","blobs_url":"https://api.github.com/repos/kenzieschmoll/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenzieschmoll/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenzieschmoll/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenzieschmoll/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenzieschmoll/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/kenzieschmoll/devtools/languages","stargazers_url":"https://api.github.com/repos/kenzieschmoll/devtools/stargazers","contributors_url":"https://api.github.com/repos/kenzieschmoll/devtools/contributors","subscribers_url":"https://api.github.com/repos/kenzieschmoll/devtools/subscribers","subscription_url":"https://api.github.com/repos/kenzieschmoll/devtools/subscription","commits_url":"https://api.github.com/repos/kenzieschmoll/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenzieschmoll/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenzieschmoll/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenzieschmoll/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenzieschmoll/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/kenzieschmoll/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenzieschmoll/devtools/merges","archive_url":"https://api.github.com/repos/kenzieschmoll/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenzieschmoll/devtools/downloads","issues_url":"https://api.github.com/repos/kenzieschmoll/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/kenzieschmoll/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/kenzieschmoll/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/kenzieschmoll/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenzieschmoll/devtools/labels{/name}","releases_url":"https://api.github.com/repos/kenzieschmoll/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/kenzieschmoll/devtools/deployments","created_at":"2018-11-27T22:57:16Z","updated_at":"2019-11-20T17:56:38Z","pushed_at":"2019-11-21T00:11:40Z","git_url":"git://github.com/kenzieschmoll/devtools.git","ssh_url":"git@github.com:kenzieschmoll/devtools.git","clone_url":"https://github.com/kenzieschmoll/devtools.git","svn_url":"https://github.com/kenzieschmoll/devtools","homepage":null,"size":45633,"stargazers_count":1,"watchers_count":1,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"ac3743ce555422e95db5625cd7b284ac6edc7937","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":143762238,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NjIyMzg=","name":"devtools","full_name":"flutter/devtools","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/devtools","description":"Performance tools for Flutter.","fork":false,"url":"https://api.github.com/repos/flutter/devtools","forks_url":"https://api.github.com/repos/flutter/devtools/forks","keys_url":"https://api.github.com/repos/flutter/devtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/devtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/devtools/teams","hooks_url":"https://api.github.com/repos/flutter/devtools/hooks","issue_events_url":"https://api.github.com/repos/flutter/devtools/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/devtools/events","assignees_url":"https://api.github.com/repos/flutter/devtools/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/devtools/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/devtools/tags","blobs_url":"https://api.github.com/repos/flutter/devtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/devtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/devtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/devtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/devtools/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/devtools/languages","stargazers_url":"https://api.github.com/repos/flutter/devtools/stargazers","contributors_url":"https://api.github.com/repos/flutter/devtools/contributors","subscribers_url":"https://api.github.com/repos/flutter/devtools/subscribers","subscription_url":"https://api.github.com/repos/flutter/devtools/subscription","commits_url":"https://api.github.com/repos/flutter/devtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/devtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/devtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/devtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/devtools/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/devtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/devtools/merges","archive_url":"https://api.github.com/repos/flutter/devtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/devtools/downloads","issues_url":"https://api.github.com/repos/flutter/devtools/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/devtools/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/devtools/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/devtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/devtools/labels{/name}","releases_url":"https://api.github.com/repos/flutter/devtools/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/devtools/deployments","created_at":"2018-08-06T17:39:43Z","updated_at":"2019-11-20T23:37:05Z","pushed_at":"2019-11-21T00:11:42Z","git_url":"git://github.com/flutter/devtools.git","ssh_url":"git@github.com:flutter/devtools.git","clone_url":"https://github.com/flutter/devtools.git","svn_url":"https://github.com/flutter/devtools","homepage":"https://flutter.dev/docs/development/tools/devtools/","size":46973,"stargazers_count":410,"watchers_count":410,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":243,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":48,"open_issues":243,"watchers":410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1371"},"html":{"href":"https://github.com/flutter/devtools/pull/1371"},"issue":{"href":"https://api.github.com/repos/flutter/devtools/issues/1371"},"comments":{"href":"https://api.github.com/repos/flutter/devtools/issues/1371/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1371/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/devtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/devtools/pulls/1371/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/devtools/statuses/ed8c81c7d05e061c3b17599089d783fe93cc47a4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DaveShuckerow"}}