{"action":"opened","number":53,"pull_request":{"url":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/53","id":289696932,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5Njk2OTMy","html_url":"https://github.com/dvsa/mes-data-poller-service/pull/53","diff_url":"https://github.com/dvsa/mes-data-poller-service/pull/53.diff","patch_url":"https://github.com/dvsa/mes-data-poller-service/pull/53.patch","issue_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/53","number":53,"state":"open","locked":false,"title":"WIP: MES-2530 Allow checkDigit to be zero","user":{"login":"jameshighfield","id":44976690,"node_id":"MDQ6VXNlcjQ0OTc2Njkw","avatar_url":"https://avatars3.githubusercontent.com/u/44976690?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshighfield","html_url":"https://github.com/jameshighfield","followers_url":"https://api.github.com/users/jameshighfield/followers","following_url":"https://api.github.com/users/jameshighfield/following{/other_user}","gists_url":"https://api.github.com/users/jameshighfield/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshighfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshighfield/subscriptions","organizations_url":"https://api.github.com/users/jameshighfield/orgs","repos_url":"https://api.github.com/users/jameshighfield/repos","events_url":"https://api.github.com/users/jameshighfield/events{/privacy}","received_events_url":"https://api.github.com/users/jameshighfield/received_events","type":"User","site_admin":false},"body":"# Description and relevant Jira numbers\r\n\r\ncheckDigit was previously not set when zero because if statement was only checking `checkDigit` was truthy instead of not null.\r\n\r\n## Pull Request checklist\r\n\r\n- [ ] [WIP] tag removed from PR title\r\n- [ ] PR has an understandable description\r\n\r\n## Git feature branch checklist\r\n\r\n- [x] branch name comply with our branching strategy\r\n- [x] git branch contains relevant JIRA ticket number\r\n- [x] branch rebased against the latest develop\r\n\r\n## Sign off process checklist\r\n\r\n- [ ] Code has been tested manually\r\n- [ ] Tested by QA\r\n- [ ] PO's approval\r\n- [ ] Reviewers selected in Github\r\n- [ ] PR link added to JIRA","created_at":"2019-06-19T13:07:37Z","updated_at":"2019-06-19T13:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/53/commits","review_comments_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/53/comments","review_comment_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/53/comments","statuses_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/statuses/84fe20016b71a9f3e6e269cfd58045a4772027ea","head":{"label":"dvsa:mes-2530-allow-checkdigit-zero","ref":"mes-2530-allow-checkdigit-zero","sha":"84fe20016b71a9f3e6e269cfd58045a4772027ea","user":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":153799881,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3OTk4ODE=","name":"mes-data-poller-service","full_name":"dvsa/mes-data-poller-service","private":false,"owner":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dvsa/mes-data-poller-service","description":"DVSA Mobile Examiner Services - Data poller service","fork":false,"url":"https://api.github.com/repos/dvsa/mes-data-poller-service","forks_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/forks","keys_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/teams","hooks_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/hooks","issue_events_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/events","assignees_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/tags","blobs_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/languages","stargazers_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/stargazers","contributors_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/contributors","subscribers_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/subscribers","subscription_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/subscription","commits_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/merges","archive_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/downloads","issues_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/deployments","created_at":"2018-10-19T14:57:31Z","updated_at":"2019-06-13T10:52:05Z","pushed_at":"2019-06-19T13:04:07Z","git_url":"git://github.com/dvsa/mes-data-poller-service.git","ssh_url":"git@github.com:dvsa/mes-data-poller-service.git","clone_url":"https://github.com/dvsa/mes-data-poller-service.git","svn_url":"https://github.com/dvsa/mes-data-poller-service","homepage":"","size":511,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"dvsa:develop","ref":"develop","sha":"0117f28477b5f96d2aa2ec785be51a7c382bcbc9","user":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":153799881,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3OTk4ODE=","name":"mes-data-poller-service","full_name":"dvsa/mes-data-poller-service","private":false,"owner":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dvsa/mes-data-poller-service","description":"DVSA Mobile Examiner Services - Data poller service","fork":false,"url":"https://api.github.com/repos/dvsa/mes-data-poller-service","forks_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/forks","keys_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/teams","hooks_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/hooks","issue_events_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/events","assignees_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/tags","blobs_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/languages","stargazers_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/stargazers","contributors_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/contributors","subscribers_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/subscribers","subscription_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/subscription","commits_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/merges","archive_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/downloads","issues_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/mes-data-poller-service/deployments","created_at":"2018-10-19T14:57:31Z","updated_at":"2019-06-13T10:52:05Z","pushed_at":"2019-06-19T13:04:07Z","git_url":"git://github.com/dvsa/mes-data-poller-service.git","ssh_url":"git@github.com:dvsa/mes-data-poller-service.git","clone_url":"https://github.com/dvsa/mes-data-poller-service.git","svn_url":"https://github.com/dvsa/mes-data-poller-service","homepage":"","size":511,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/53"},"html":{"href":"https://github.com/dvsa/mes-data-poller-service/pull/53"},"issue":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/53"},"comments":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/dvsa/mes-data-poller-service/statuses/84fe20016b71a9f3e6e269cfd58045a4772027ea"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":35,"deletions":22,"changed_files":5}}
{"actor":{"display_login":"jameshighfield"}}