{"action":"closed","number":40481,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/40481","id":295211111,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1MjExMTEx","html_url":"https://github.com/elastic/kibana/pull/40481","diff_url":"https://github.com/elastic/kibana/pull/40481.diff","patch_url":"https://github.com/elastic/kibana/pull/40481.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/40481","number":40481,"state":"closed","locked":false,"title":"[code] Remove the redundant content in the reference title.","user":{"login":"movie-travel-code","id":5517506,"node_id":"MDQ6VXNlcjU1MTc1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5517506?v=4","gravatar_id":"","url":"https://api.github.com/users/movie-travel-code","html_url":"https://github.com/movie-travel-code","followers_url":"https://api.github.com/users/movie-travel-code/followers","following_url":"https://api.github.com/users/movie-travel-code/following{/other_user}","gists_url":"https://api.github.com/users/movie-travel-code/gists{/gist_id}","starred_url":"https://api.github.com/users/movie-travel-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movie-travel-code/subscriptions","organizations_url":"https://api.github.com/users/movie-travel-code/orgs","repos_url":"https://api.github.com/users/movie-travel-code/repos","events_url":"https://api.github.com/users/movie-travel-code/events{/privacy}","received_events_url":"https://api.github.com/users/movie-travel-code/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nRelated issue: https://github.com/elastic/code/issues/1401.\r\n\r\nThe root cause of this issue is that the code server is not designed for\r\nhover results with the `MarkupContent` format. The hover results with\r\n`MarkupContent` format is monolithic, that's why for the langserver \r\nuse `MarkupContent` format, the reference title is very long and \r\ncontains markdown label. \r\n\r\nGiven that the main usage of the hover results is hovering not reference \r\ntitle. It is not appropriate to simply the hovering result on the langserver \r\nside. So extracting pieces from the monolithic hover result to construct\r\nthe reference title is the doable approach.\r\n\r\nFor `MarkupContent` format, there are different patterns for different \r\nlanguages like go langserver, the pattern is\r\n'comment? + ```go\\n + declaration + \\n```'\r\nwe have to use different extract patterns for different languages.\r\n\r\nFor now for the go langserver, because the markup kind is `markdown`,\r\n**the reference title is the first line of the code block**.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [ ] ~~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~\r\n- [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~\r\n- [ ] ~~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~\r\n- [ ] ~~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~\r\n- [ ] ~~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [ ] ~~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~\r\n\r\n","created_at":"2019-07-08T07:32:06Z","updated_at":"2019-07-11T10:06:40Z","closed_at":"2019-07-11T10:06:40Z","merged_at":"2019-07-11T10:06:40Z","merge_commit_sha":"3789010d478e802447772dfecccd5be637eeaeae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"spacedragon","id":631261,"node_id":"MDQ6VXNlcjYzMTI2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/631261?v=4","gravatar_id":"","url":"https://api.github.com/users/spacedragon","html_url":"https://github.com/spacedragon","followers_url":"https://api.github.com/users/spacedragon/followers","following_url":"https://api.github.com/users/spacedragon/following{/other_user}","gists_url":"https://api.github.com/users/spacedragon/gists{/gist_id}","starred_url":"https://api.github.com/users/spacedragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacedragon/subscriptions","organizations_url":"https://api.github.com/users/spacedragon/orgs","repos_url":"https://api.github.com/users/spacedragon/repos","events_url":"https://api.github.com/users/spacedragon/events{/privacy}","received_events_url":"https://api.github.com/users/spacedragon/received_events","type":"User","site_admin":false},{"login":"zfy0701","id":1646270,"node_id":"MDQ6VXNlcjE2NDYyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1646270?v=4","gravatar_id":"","url":"https://api.github.com/users/zfy0701","html_url":"https://github.com/zfy0701","followers_url":"https://api.github.com/users/zfy0701/followers","following_url":"https://api.github.com/users/zfy0701/following{/other_user}","gists_url":"https://api.github.com/users/zfy0701/gists{/gist_id}","starred_url":"https://api.github.com/users/zfy0701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfy0701/subscriptions","organizations_url":"https://api.github.com/users/zfy0701/orgs","repos_url":"https://api.github.com/users/zfy0701/repos","events_url":"https://api.github.com/users/zfy0701/events{/privacy}","received_events_url":"https://api.github.com/users/zfy0701/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1159464224,"node_id":"MDU6TGFiZWwxMTU5NDY0MjI0","url":"https://api.github.com/repos/elastic/kibana/labels/Team:Code","name":"Team:Code","color":"fef2c0","default":false},{"id":26198236,"node_id":"MDU6TGFiZWwyNjE5ODIzNg==","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:enhancement","name":"release_note:enhancement","color":"4a4ea8","default":false},{"id":1395348911,"node_id":"MDU6TGFiZWwxMzk1MzQ4OTEx","url":"https://api.github.com/repos/elastic/kibana/labels/v7.4.0","name":"v7.4.0","color":"FFFFFF","default":false},{"id":1124458249,"node_id":"MDU6TGFiZWwxMTI0NDU4MjQ5","url":"https://api.github.com/repos/elastic/kibana/labels/v8.0.0","name":"v8.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/40481/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/40481/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/40481/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/70705e22b67b61fd79c04bae7161da1463544780","head":{"label":"movie-travel-code:FixGoReferenceTitle","ref":"FixGoReferenceTitle","sha":"70705e22b67b61fd79c04bae7161da1463544780","user":{"login":"movie-travel-code","id":5517506,"node_id":"MDQ6VXNlcjU1MTc1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5517506?v=4","gravatar_id":"","url":"https://api.github.com/users/movie-travel-code","html_url":"https://github.com/movie-travel-code","followers_url":"https://api.github.com/users/movie-travel-code/followers","following_url":"https://api.github.com/users/movie-travel-code/following{/other_user}","gists_url":"https://api.github.com/users/movie-travel-code/gists{/gist_id}","starred_url":"https://api.github.com/users/movie-travel-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movie-travel-code/subscriptions","organizations_url":"https://api.github.com/users/movie-travel-code/orgs","repos_url":"https://api.github.com/users/movie-travel-code/repos","events_url":"https://api.github.com/users/movie-travel-code/events{/privacy}","received_events_url":"https://api.github.com/users/movie-travel-code/received_events","type":"User","site_admin":false},"repo":{"id":164580211,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ1ODAyMTE=","name":"kibana","full_name":"movie-travel-code/kibana","private":false,"owner":{"login":"movie-travel-code","id":5517506,"node_id":"MDQ6VXNlcjU1MTc1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5517506?v=4","gravatar_id":"","url":"https://api.github.com/users/movie-travel-code","html_url":"https://github.com/movie-travel-code","followers_url":"https://api.github.com/users/movie-travel-code/followers","following_url":"https://api.github.com/users/movie-travel-code/following{/other_user}","gists_url":"https://api.github.com/users/movie-travel-code/gists{/gist_id}","starred_url":"https://api.github.com/users/movie-travel-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movie-travel-code/subscriptions","organizations_url":"https://api.github.com/users/movie-travel-code/orgs","repos_url":"https://api.github.com/users/movie-travel-code/repos","events_url":"https://api.github.com/users/movie-travel-code/events{/privacy}","received_events_url":"https://api.github.com/users/movie-travel-code/received_events","type":"User","site_admin":false},"html_url":"https://github.com/movie-travel-code/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/movie-travel-code/kibana","forks_url":"https://api.github.com/repos/movie-travel-code/kibana/forks","keys_url":"https://api.github.com/repos/movie-travel-code/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/movie-travel-code/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/movie-travel-code/kibana/teams","hooks_url":"https://api.github.com/repos/movie-travel-code/kibana/hooks","issue_events_url":"https://api.github.com/repos/movie-travel-code/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/movie-travel-code/kibana/events","assignees_url":"https://api.github.com/repos/movie-travel-code/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/movie-travel-code/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/movie-travel-code/kibana/tags","blobs_url":"https://api.github.com/repos/movie-travel-code/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/movie-travel-code/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/movie-travel-code/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/movie-travel-code/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/movie-travel-code/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/movie-travel-code/kibana/languages","stargazers_url":"https://api.github.com/repos/movie-travel-code/kibana/stargazers","contributors_url":"https://api.github.com/repos/movie-travel-code/kibana/contributors","subscribers_url":"https://api.github.com/repos/movie-travel-code/kibana/subscribers","subscription_url":"https://api.github.com/repos/movie-travel-code/kibana/subscription","commits_url":"https://api.github.com/repos/movie-travel-code/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/movie-travel-code/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/movie-travel-code/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/movie-travel-code/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/movie-travel-code/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/movie-travel-code/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/movie-travel-code/kibana/merges","archive_url":"https://api.github.com/repos/movie-travel-code/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/movie-travel-code/kibana/downloads","issues_url":"https://api.github.com/repos/movie-travel-code/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/movie-travel-code/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/movie-travel-code/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/movie-travel-code/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/movie-travel-code/kibana/labels{/name}","releases_url":"https://api.github.com/repos/movie-travel-code/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/movie-travel-code/kibana/deployments","created_at":"2019-01-08T06:33:03Z","updated_at":"2019-07-08T07:26:16Z","pushed_at":"2019-07-11T09:03:22Z","git_url":"git://github.com/movie-travel-code/kibana.git","ssh_url":"git@github.com:movie-travel-code/kibana.git","clone_url":"https://github.com/movie-travel-code/kibana.git","svn_url":"https://github.com/movie-travel-code/kibana","homepage":"https://www.elastic.co/products/kibana","size":850026,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"d1c594384e071aff8216af04678fcdf109fc4056","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":"Your window into the Elastic Stack","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-07-11T09:16:36Z","pushed_at":"2019-07-11T10:06:40Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":897366,"stargazers_count":12435,"watchers_count":12435,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4817,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4788,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4817,"open_issues":4788,"watchers":12435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40481"},"html":{"href":"https://github.com/elastic/kibana/pull/40481"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/40481"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/40481/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40481/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40481/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/70705e22b67b61fd79c04bae7161da1463544780"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"movie-travel-code","id":5517506,"node_id":"MDQ6VXNlcjU1MTc1MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5517506?v=4","gravatar_id":"","url":"https://api.github.com/users/movie-travel-code","html_url":"https://github.com/movie-travel-code","followers_url":"https://api.github.com/users/movie-travel-code/followers","following_url":"https://api.github.com/users/movie-travel-code/following{/other_user}","gists_url":"https://api.github.com/users/movie-travel-code/gists{/gist_id}","starred_url":"https://api.github.com/users/movie-travel-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movie-travel-code/subscriptions","organizations_url":"https://api.github.com/users/movie-travel-code/orgs","repos_url":"https://api.github.com/users/movie-travel-code/repos","events_url":"https://api.github.com/users/movie-travel-code/events{/privacy}","received_events_url":"https://api.github.com/users/movie-travel-code/received_events","type":"User","site_admin":false},"comments":5,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"movie-travel-code"}}