{"action":"created","issue":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/93","repository_url":"https://api.github.com/repos/Betterment/test_track_rails_client","labels_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/93/comments","events_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/93/events","html_url":"https://github.com/Betterment/test_track_rails_client/pull/93","id":495537901,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MDY2OTM4","number":93,"title":"Fix CLI failures when English module is missing","user":{"login":"aburgel","id":341478,"node_id":"MDQ6VXNlcjM0MTQ3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/341478?v=4","gravatar_id":"","url":"https://api.github.com/users/aburgel","html_url":"https://github.com/aburgel","followers_url":"https://api.github.com/users/aburgel/followers","following_url":"https://api.github.com/users/aburgel/following{/other_user}","gists_url":"https://api.github.com/users/aburgel/gists{/gist_id}","starred_url":"https://api.github.com/users/aburgel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aburgel/subscriptions","organizations_url":"https://api.github.com/users/aburgel/orgs","repos_url":"https://api.github.com/users/aburgel/repos","events_url":"https://api.github.com/users/aburgel/events{/privacy}","received_events_url":"https://api.github.com/users/aburgel/received_events","type":"User","site_admin":false},"labels":[{"id":1449096805,"node_id":"MDU6TGFiZWwxNDQ5MDk2ODA1","url":"https://api.github.com/repos/Betterment/test_track_rails_client/labels/domain-not-claimed","name":"domain-not-claimed","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-09-19T02:21:54Z","updated_at":"2019-09-19T02:41:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/pulls/93","html_url":"https://github.com/Betterment/test_track_rails_client/pull/93","diff_url":"https://github.com/Betterment/test_track_rails_client/pull/93.diff","patch_url":"https://github.com/Betterment/test_track_rails_client/pull/93.patch"},"body":"/domain @Betterment/test_track_core \r\n/no-platform\r\n/cc @joejansen @fidelscodes\r\n\r\n`TesttrackCli` module makes use of `$CHILD_STATUS`, which is provided by the `English` module. We weren't explicitly requiring it, so the code only happened to work because many gems `require 'English'` for their own purposes. The airbrake gem, which we carried as a dependency up until recently, is one example. If you're unlucky enough to not use such a gem, then `$CHILD_STATUS` will always be nil and blow up in our usecase.\r\n\r\nI added a test that runs the CLI via `TesttrackCli`, hoping that it would fail, but it turns out that `simplecov` gem does a `require 'English'`, so `TesttrackCli#call` succeeds. I'm going to leave the test in anyways, since its a useful integration test."},"comment":{"url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/comments/532940971","html_url":"https://github.com/Betterment/test_track_rails_client/pull/93#issuecomment-532940971","issue_url":"https://api.github.com/repos/Betterment/test_track_rails_client/issues/93","id":532940971,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMjk0MDk3MQ==","user":{"login":"nanda-prbot","id":13210998,"node_id":"MDQ6VXNlcjEzMjEwOTk4","avatar_url":"https://avatars2.githubusercontent.com/u/13210998?v=4","gravatar_id":"","url":"https://api.github.com/users/nanda-prbot","html_url":"https://github.com/nanda-prbot","followers_url":"https://api.github.com/users/nanda-prbot/followers","following_url":"https://api.github.com/users/nanda-prbot/following{/other_user}","gists_url":"https://api.github.com/users/nanda-prbot/gists{/gist_id}","starred_url":"https://api.github.com/users/nanda-prbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanda-prbot/subscriptions","organizations_url":"https://api.github.com/users/nanda-prbot/orgs","repos_url":"https://api.github.com/users/nanda-prbot/repos","events_url":"https://api.github.com/users/nanda-prbot/events{/privacy}","received_events_url":"https://api.github.com/users/nanda-prbot/received_events","type":"User","site_admin":false},"created_at":"2019-09-19T02:41:55Z","updated_at":"2019-09-19T02:41:55Z","author_association":"NONE","body":"Approved! :gift: :flags: :fireworks:"}}
{"actor":{"display_login":"nanda-prbot"}}