{"action":"created","issue":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5503","repository_url":"https://api.github.com/repos/statsmodels/statsmodels","labels_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5503/labels{/name}","comments_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5503/comments","events_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5503/events","html_url":"https://github.com/statsmodels/statsmodels/pull/5503","id":411112586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNjY3NTIx","number":5503,"title":"WIP ENH: add stats.control_charts","user":{"login":"josef-pkt","id":440735,"node_id":"MDQ6VXNlcjQ0MDczNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"labels":[{"id":204626,"node_id":"MDU6TGFiZWwyMDQ2MjY=","url":"https://api.github.com/repos/statsmodels/statsmodels/labels/comp-stats","name":"comp-stats","color":"ededed","default":false},{"id":142961,"node_id":"MDU6TGFiZWwxNDI5NjE=","url":"https://api.github.com/repos/statsmodels/statsmodels/labels/type-enh","name":"type-enh","color":"99ffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-02-16T20:54:07Z","updated_at":"2019-02-18T00:06:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/statsmodels/statsmodels/pulls/5503","html_url":"https://github.com/statsmodels/statsmodels/pull/5503","diff_url":"https://github.com/statsmodels/statsmodels/pull/5503.diff","patch_url":"https://github.com/statsmodels/statsmodels/pull/5503.patch"},"body":"adding by getting started with control charts script from #4191 to stats.control_charts\r\n\r\nexample converted to notebook is at https://gist.github.com/josef-pkt/f97874ca89237e78a505392803f6b40a\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/statsmodels/statsmodels/issues/comments/464530732","html_url":"https://github.com/statsmodels/statsmodels/pull/5503#issuecomment-464530732","issue_url":"https://api.github.com/repos/statsmodels/statsmodels/issues/5503","id":464530732,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NDUzMDczMg==","user":{"login":"josef-pkt","id":440735,"node_id":"MDQ6VXNlcjQ0MDczNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/440735?v=4","gravatar_id":"","url":"https://api.github.com/users/josef-pkt","html_url":"https://github.com/josef-pkt","followers_url":"https://api.github.com/users/josef-pkt/followers","following_url":"https://api.github.com/users/josef-pkt/following{/other_user}","gists_url":"https://api.github.com/users/josef-pkt/gists{/gist_id}","starred_url":"https://api.github.com/users/josef-pkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josef-pkt/subscriptions","organizations_url":"https://api.github.com/users/josef-pkt/orgs","repos_url":"https://api.github.com/users/josef-pkt/repos","events_url":"https://api.github.com/users/josef-pkt/events{/privacy}","received_events_url":"https://api.github.com/users/josef-pkt/received_events","type":"User","site_admin":false},"created_at":"2019-02-18T00:06:01Z","updated_at":"2019-02-18T00:06:01Z","author_association":"MEMBER","body":"What are the required methods to modularize this and let subclasses overwrite for the specific case?\r\n\r\ne.g. `plot_chart` currently computes the statistic for the test sample, this should be in a separate method so plot_chart only does the plotting independently of which chart is used.\r\nDo we need several plots/charts in the same plot as I currently have? Should we have a plot grid in the vectorized case or just add an index for which column/variable to plot?\r\n(I like vectorized because it comes almost for free and can complement multivariate plots, and we could add a max plot.)\r\n\r\nHow can we have a class that doesn't use data, i.e. only phase 2 for fixed given parameters.\r\n\r\nplot_chart in ControlChartMvMean  and ControlChartEWMAMvMean use `statistic` and are identical except for computing the statistic for new data. This should be the generic case.\r\n\r\nin analogy to model/results classes, we would have `fit`, `update_fit` and `predict` or `get_prediction` plus plotting the chart.\r\n- estimate parameters, currently in `__init__` -> use private `_fit` called from `__init__`?\r\n- compute the test statistic, i.e. predict and prediction interval (which is currently fixed at low and upp) plus possible computed out of sample residual. (aside families in GLM comput resid_dev and resid_anscombe with data as arguments, i.e. can be used also for out-of-sample, resid_pearson is in GLMResults and uses endog attribute)\r\n\r\n\r\n"}}
{"actor":{"display_login":"josef-pkt"}}