{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14942","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14942/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14942/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14942/events","html_url":"https://github.com/bitcoin/bitcoin/pull/14942","id":390467893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjI4MzQw","number":14942,"title":"wallet: Make scan / abort status private to CWallet","user":{"login":"Empact","id":5470,"node_id":"MDQ6VXNlcjU0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5470?v=4","gravatar_id":"","url":"https://api.github.com/users/Empact","html_url":"https://github.com/Empact","followers_url":"https://api.github.com/users/Empact/followers","following_url":"https://api.github.com/users/Empact/following{/other_user}","gists_url":"https://api.github.com/users/Empact/gists{/gist_id}","starred_url":"https://api.github.com/users/Empact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Empact/subscriptions","organizations_url":"https://api.github.com/users/Empact/orgs","repos_url":"https://api.github.com/users/Empact/repos","events_url":"https://api.github.com/users/Empact/events{/privacy}","received_events_url":"https://api.github.com/users/Empact/received_events","type":"User","site_admin":false},"labels":[{"id":955867938,"node_id":"MDU6TGFiZWw5NTU4Njc5Mzg=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Needs%20rebase","name":"Needs rebase","color":"cccccc","default":false},{"id":149424,"node_id":"MDU6TGFiZWwxNDk0MjQ=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"08a781","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-12-13T00:31:12Z","updated_at":"2019-05-17T03:02:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14942","html_url":"https://github.com/bitcoin/bitcoin/pull/14942","diff_url":"https://github.com/bitcoin/bitcoin/pull/14942.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14942.patch"},"body":"By returning `ScanResult` from `RescanFromTime` and reporting the effectuality of `AbortScan`.\r\n\r\n~And consolidate rpc-level error handling across `RescanFromTime` and\r\n`ScanForWalletTransactions`.~\r\n\r\n~Note this changes the `rescanblockchain` scan failure error from\r\n`RPC_MISC_ERROR` to `RPC_WALLET_ERROR`, which seems more appropriate and matches the\r\nbehavior from the rpcdump methods.~\r\n\r\nThis follows up on #13076."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/493301763","html_url":"https://github.com/bitcoin/bitcoin/pull/14942#issuecomment-493301763","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14942","id":493301763,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MzMwMTc2Mw==","user":{"login":"Empact","id":5470,"node_id":"MDQ6VXNlcjU0NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5470?v=4","gravatar_id":"","url":"https://api.github.com/users/Empact","html_url":"https://github.com/Empact","followers_url":"https://api.github.com/users/Empact/followers","following_url":"https://api.github.com/users/Empact/following{/other_user}","gists_url":"https://api.github.com/users/Empact/gists{/gist_id}","starred_url":"https://api.github.com/users/Empact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Empact/subscriptions","organizations_url":"https://api.github.com/users/Empact/orgs","repos_url":"https://api.github.com/users/Empact/repos","events_url":"https://api.github.com/users/Empact/events{/privacy}","received_events_url":"https://api.github.com/users/Empact/received_events","type":"User","site_admin":false},"created_at":"2019-05-17T03:02:56Z","updated_at":"2019-05-17T03:02:56Z","author_association":"MEMBER","body":"Rebased, and restored `IsScanning` as it's needed for d3e8458365"}}
{"actor":{"display_login":"Empact"}}