{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/5662","repository_url":"https://api.github.com/repos/prometheus/prometheus","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/5662/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/5662/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/5662/events","html_url":"https://github.com/prometheus/prometheus/issues/5662","id":456094057,"node_id":"MDU6SXNzdWU0NTYwOTQwNTc=","number":5662,"title":"Option to make failures of non-primary reads not warnings","user":{"login":"jacksontj","id":1619869,"node_id":"MDQ6VXNlcjE2MTk4Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1619869?v=4","gravatar_id":"","url":"https://api.github.com/users/jacksontj","html_url":"https://github.com/jacksontj","followers_url":"https://api.github.com/users/jacksontj/followers","following_url":"https://api.github.com/users/jacksontj/following{/other_user}","gists_url":"https://api.github.com/users/jacksontj/gists{/gist_id}","starred_url":"https://api.github.com/users/jacksontj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacksontj/subscriptions","organizations_url":"https://api.github.com/users/jacksontj/orgs","repos_url":"https://api.github.com/users/jacksontj/repos","events_url":"https://api.github.com/users/jacksontj/events{/privacy}","received_events_url":"https://api.github.com/users/jacksontj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-06-14T07:07:28Z","updated_at":"2019-06-14T16:51:04Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Proposal\r\n**Use case. Why is this important?**\r\nSomewhat recently a change was made that made errors from remote-read endpoints not return errors but rather return warnings (https://github.com/prometheus/prometheus/pull/4832). Although I think its great to have the option to make remote_read non-fatal; the current implementation completely disallows for configuring any remote_read endpoint as required (meaning errors from it are fatal).\r\n\r\nMy proposal is to add an option to each remote_read which would determine if the errors should be considered errors or warnings (presumably the default would remain as warnings)-- this would enable users to mark remote_read as required if they so desire."},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/502184709","html_url":"https://github.com/prometheus/prometheus/issues/5662#issuecomment-502184709","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/5662","id":502184709,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMjE4NDcwOQ==","user":{"login":"brian-brazil","id":7115638,"node_id":"MDQ6VXNlcjcxMTU2Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7115638?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"created_at":"2019-06-14T16:51:04Z","updated_at":"2019-06-14T16:51:04Z","author_association":"MEMBER","body":"Even with remote_write/read configured, you should tolerate them being down. If you want to consider a specific query failed if there's a remote error, there's nothing stopping you from erroring out when you see a warning."}}
{"actor":{"display_login":"brian-brazil"}}