{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/185","repository_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress","labels_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/185/comments","events_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/185/events","html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/185","id":444722633,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5MzIzMTI1","number":185,"title":"Removing agPrefix; Allowing for it to be set with an env var","user":{"login":"draychev","id":49918230,"node_id":"MDQ6VXNlcjQ5OTE4MjMw","avatar_url":"https://avatars1.githubusercontent.com/u/49918230?v=4","gravatar_id":"","url":"https://api.github.com/users/draychev","html_url":"https://github.com/draychev","followers_url":"https://api.github.com/users/draychev/followers","following_url":"https://api.github.com/users/draychev/following{/other_user}","gists_url":"https://api.github.com/users/draychev/gists{/gist_id}","starred_url":"https://api.github.com/users/draychev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draychev/subscriptions","organizations_url":"https://api.github.com/users/draychev/orgs","repos_url":"https://api.github.com/users/draychev/repos","events_url":"https://api.github.com/users/draychev/events{/privacy}","received_events_url":"https://api.github.com/users/draychev/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-16T02:18:06Z","updated_at":"2019-05-17T06:08:30Z","closed_at":"2019-05-16T18:51:01Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/pulls/185","html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/185","diff_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/185.diff","patch_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/185.patch"},"body":"We had a discussion this week and decided that it is safe and good overall to remove this prefix.\r\n\r\nThe prefix was used for all App Gateway property names.  These are limited to 80 characters so this took precious space from the otherwise long names.\r\n\r\nConcerns with the removal of the prefix:\r\n  1. This makes it easy to identify App Gateways being controlled by a K8s Ingress\r\n  2. The prefix provides a namespace so multiple Ingresses could eventually configure the same App Gwy.\r\n\r\nConcerns are addressed by:\r\n  1. We implemented tagging of App Gateways w/ PR https://github.com/Azure/application-gateway-kubernetes-ingress/pull/174\r\n  2. Is out of scope for v1 of the Ingress controller\r\n\r\nWith this - we are moving forward with the removal of prefixing App Gateway properties by default. New installations of the Ingress will **not** have `k8s-ag-ingress-` in front of property names.\r\n\r\nTo allow users to apply a prefix, should that became necessary, we leave the option of using the `APPGW_CONFIG_NAME_PREFIX` environment variable."},"comment":{"url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/comments/493332769","html_url":"https://github.com/Azure/application-gateway-kubernetes-ingress/pull/185#issuecomment-493332769","issue_url":"https://api.github.com/repos/Azure/application-gateway-kubernetes-ingress/issues/185","id":493332769,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MzMzMjc2OQ==","user":{"login":"wesselkranenborg","id":4964604,"node_id":"MDQ6VXNlcjQ5NjQ2MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4964604?v=4","gravatar_id":"","url":"https://api.github.com/users/wesselkranenborg","html_url":"https://github.com/wesselkranenborg","followers_url":"https://api.github.com/users/wesselkranenborg/followers","following_url":"https://api.github.com/users/wesselkranenborg/following{/other_user}","gists_url":"https://api.github.com/users/wesselkranenborg/gists{/gist_id}","starred_url":"https://api.github.com/users/wesselkranenborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesselkranenborg/subscriptions","organizations_url":"https://api.github.com/users/wesselkranenborg/orgs","repos_url":"https://api.github.com/users/wesselkranenborg/repos","events_url":"https://api.github.com/users/wesselkranenborg/events{/privacy}","received_events_url":"https://api.github.com/users/wesselkranenborg/received_events","type":"User","site_admin":false},"created_at":"2019-05-17T06:08:30Z","updated_at":"2019-05-17T06:08:30Z","author_association":"NONE","body":"Thanks for changing this. This is what I was trying to say here: https://github.com/Azure/application-gateway-kubernetes-ingress/pull/92#issuecomment-465553304."}}
{"actor":{"display_login":"wesselkranenborg"}}