{"action":"created","comment":{"url":"https://api.github.com/repos/windmilleng/tilt/pulls/comments/334185176","pull_request_review_id":300939372,"id":334185176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDE4NTE3Ng==","diff_hunk":"@@ -48,6 +48,8 @@ func (c *downCmd) down(ctx context.Context, downDeps DownDeps) error {\n \t\treturn err\n \t}\n \n+\ttlr.DockerPruneSettings.Disabled = true // don't docker prune on tilt down","path":"internal/cli/down.go","position":4,"original_position":4,"commit_id":"c90fb5b66c1244ed00cecc92575e939e9ec201ec","original_commit_id":"c90fb5b66c1244ed00cecc92575e939e9ec201ec","user":{"login":"nicks","id":278641,"node_id":"MDQ6VXNlcjI3ODY0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/278641?v=4","gravatar_id":"","url":"https://api.github.com/users/nicks","html_url":"https://github.com/nicks","followers_url":"https://api.github.com/users/nicks/followers","following_url":"https://api.github.com/users/nicks/following{/other_user}","gists_url":"https://api.github.com/users/nicks/gists{/gist_id}","starred_url":"https://api.github.com/users/nicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicks/subscriptions","organizations_url":"https://api.github.com/users/nicks/orgs","repos_url":"https://api.github.com/users/nicks/repos","events_url":"https://api.github.com/users/nicks/events{/privacy}","received_events_url":"https://api.github.com/users/nicks/received_events","type":"User","site_admin":false},"body":"i wonder if we should do the opposite: DockerPruneSettings.Enabled, which default to false unless the Tiltfile has run and this is a 'tilt up'","created_at":"2019-10-11T21:47:18Z","updated_at":"2019-10-11T21:47:25Z","html_url":"https://github.com/windmilleng/tilt/pull/2334#discussion_r334185176","pull_request_url":"https://api.github.com/repos/windmilleng/tilt/pulls/2334","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/comments/334185176"},"html":{"href":"https://github.com/windmilleng/tilt/pull/2334#discussion_r334185176"},"pull_request":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2334"}}},"pull_request":{"url":"https://api.github.com/repos/windmilleng/tilt/pulls/2334","id":327371111,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MzcxMTEx","html_url":"https://github.com/windmilleng/tilt/pull/2334","diff_url":"https://github.com/windmilleng/tilt/pull/2334.diff","patch_url":"https://github.com/windmilleng/tilt/pull/2334.patch","issue_url":"https://api.github.com/repos/windmilleng/tilt/issues/2334","number":2334,"state":"open","locked":false,"title":"tiltfile/dockerpruner: configure docker pruner from tiltfile, more options for when we prune [ch3661]","user":{"login":"maiamcc","id":6332648,"node_id":"MDQ6VXNlcjYzMzI2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/6332648?v=4","gravatar_id":"","url":"https://api.github.com/users/maiamcc","html_url":"https://github.com/maiamcc","followers_url":"https://api.github.com/users/maiamcc/followers","following_url":"https://api.github.com/users/maiamcc/following{/other_user}","gists_url":"https://api.github.com/users/maiamcc/gists{/gist_id}","starred_url":"https://api.github.com/users/maiamcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maiamcc/subscriptions","organizations_url":"https://api.github.com/users/maiamcc/orgs","repos_url":"https://api.github.com/users/maiamcc/repos","events_url":"https://api.github.com/users/maiamcc/events{/privacy}","received_events_url":"https://api.github.com/users/maiamcc/received_events","type":"User","site_admin":false},"body":"Hello @jazzdan, @nicks,\n\nPlease review the following commits I made in branch maiamcc/tiltfile-docker-prune:\n\n3b8ef4389c13c4b58289ce0bfa89b913961d6e18 (2019-10-11 17:17:45 -0400)\ntests\n\nd13689981265d54f895b1e696d422dd889048dc5 (2019-10-11 17:17:42 -0400)\nbe smarter about when we do/don't prune\n\n6a375340c0e32f3edc5022cbde4b00df80e68b3f (2019-10-11 17:17:38 -0400)\ntiltfile tweaks\n\ndd885d0515e2a034026146425790f02eac640034 (2019-10-11 17:17:35 -0400)\napply the settings\n\n94e8746c7b823579f7a8972de6169a5da231db76 (2019-10-11 17:17:30 -0400)\ncontrol docker prune settings from tiltfile\n\nCode review reminders, by giving a LGTM you attest that:\n\n* Commits are adequately tested\n* Code is easy to understand and conforms to style guides\n* Incomplete code is marked with TODOs\n* Code is suitably instrumented with logging and metrics","created_at":"2019-10-11T21:19:04Z","updated_at":"2019-10-11T21:47:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a0c58fbf31bf44e605c6485cb9dce89222cb1ba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jazzdan","id":452453,"node_id":"MDQ6VXNlcjQ1MjQ1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/452453?v=4","gravatar_id":"","url":"https://api.github.com/users/jazzdan","html_url":"https://github.com/jazzdan","followers_url":"https://api.github.com/users/jazzdan/followers","following_url":"https://api.github.com/users/jazzdan/following{/other_user}","gists_url":"https://api.github.com/users/jazzdan/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzdan/subscriptions","organizations_url":"https://api.github.com/users/jazzdan/orgs","repos_url":"https://api.github.com/users/jazzdan/repos","events_url":"https://api.github.com/users/jazzdan/events{/privacy}","received_events_url":"https://api.github.com/users/jazzdan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/windmilleng/tilt/pulls/2334/commits","review_comments_url":"https://api.github.com/repos/windmilleng/tilt/pulls/2334/comments","review_comment_url":"https://api.github.com/repos/windmilleng/tilt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windmilleng/tilt/issues/2334/comments","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/c90fb5b66c1244ed00cecc92575e939e9ec201ec","head":{"label":"windmilleng:maiamcc/tiltfile-docker-prune","ref":"maiamcc/tiltfile-docker-prune","sha":"c90fb5b66c1244ed00cecc92575e939e9ec201ec","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":143896900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTY5MDA=","name":"tilt","full_name":"windmilleng/tilt","private":false,"owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windmilleng/tilt","description":"Local Kubernetes development with no stress","fork":false,"url":"https://api.github.com/repos/windmilleng/tilt","forks_url":"https://api.github.com/repos/windmilleng/tilt/forks","keys_url":"https://api.github.com/repos/windmilleng/tilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/tilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/tilt/teams","hooks_url":"https://api.github.com/repos/windmilleng/tilt/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/tilt/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/tilt/events","assignees_url":"https://api.github.com/repos/windmilleng/tilt/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/tilt/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/tilt/tags","blobs_url":"https://api.github.com/repos/windmilleng/tilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/tilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/tilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/tilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/tilt/languages","stargazers_url":"https://api.github.com/repos/windmilleng/tilt/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/tilt/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/tilt/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/tilt/subscription","commits_url":"https://api.github.com/repos/windmilleng/tilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/tilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/tilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/tilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/tilt/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/tilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/tilt/merges","archive_url":"https://api.github.com/repos/windmilleng/tilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/tilt/downloads","issues_url":"https://api.github.com/repos/windmilleng/tilt/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/tilt/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/tilt/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/tilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/tilt/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/tilt/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/tilt/deployments","created_at":"2018-08-07T16:00:26Z","updated_at":"2019-10-11T21:29:34Z","pushed_at":"2019-10-11T21:46:54Z","git_url":"git://github.com/windmilleng/tilt.git","ssh_url":"git@github.com:windmilleng/tilt.git","clone_url":"https://github.com/windmilleng/tilt.git","svn_url":"https://github.com/windmilleng/tilt","homepage":"https://tilt.dev/","size":33826,"stargazers_count":2853,"watchers_count":2853,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":101,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":80,"open_issues":101,"watchers":2853,"default_branch":"master"}},"base":{"label":"windmilleng:master","ref":"master","sha":"0bfff3cfe9368c0a5a24e5cd7f1a7ce6393f0fe0","user":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"repo":{"id":143896900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTY5MDA=","name":"tilt","full_name":"windmilleng/tilt","private":false,"owner":{"login":"windmilleng","id":26349925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzQ5OTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26349925?v=4","gravatar_id":"","url":"https://api.github.com/users/windmilleng","html_url":"https://github.com/windmilleng","followers_url":"https://api.github.com/users/windmilleng/followers","following_url":"https://api.github.com/users/windmilleng/following{/other_user}","gists_url":"https://api.github.com/users/windmilleng/gists{/gist_id}","starred_url":"https://api.github.com/users/windmilleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windmilleng/subscriptions","organizations_url":"https://api.github.com/users/windmilleng/orgs","repos_url":"https://api.github.com/users/windmilleng/repos","events_url":"https://api.github.com/users/windmilleng/events{/privacy}","received_events_url":"https://api.github.com/users/windmilleng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/windmilleng/tilt","description":"Local Kubernetes development with no stress","fork":false,"url":"https://api.github.com/repos/windmilleng/tilt","forks_url":"https://api.github.com/repos/windmilleng/tilt/forks","keys_url":"https://api.github.com/repos/windmilleng/tilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windmilleng/tilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windmilleng/tilt/teams","hooks_url":"https://api.github.com/repos/windmilleng/tilt/hooks","issue_events_url":"https://api.github.com/repos/windmilleng/tilt/issues/events{/number}","events_url":"https://api.github.com/repos/windmilleng/tilt/events","assignees_url":"https://api.github.com/repos/windmilleng/tilt/assignees{/user}","branches_url":"https://api.github.com/repos/windmilleng/tilt/branches{/branch}","tags_url":"https://api.github.com/repos/windmilleng/tilt/tags","blobs_url":"https://api.github.com/repos/windmilleng/tilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windmilleng/tilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windmilleng/tilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/windmilleng/tilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windmilleng/tilt/statuses/{sha}","languages_url":"https://api.github.com/repos/windmilleng/tilt/languages","stargazers_url":"https://api.github.com/repos/windmilleng/tilt/stargazers","contributors_url":"https://api.github.com/repos/windmilleng/tilt/contributors","subscribers_url":"https://api.github.com/repos/windmilleng/tilt/subscribers","subscription_url":"https://api.github.com/repos/windmilleng/tilt/subscription","commits_url":"https://api.github.com/repos/windmilleng/tilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/windmilleng/tilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/windmilleng/tilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/windmilleng/tilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/windmilleng/tilt/contents/{+path}","compare_url":"https://api.github.com/repos/windmilleng/tilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windmilleng/tilt/merges","archive_url":"https://api.github.com/repos/windmilleng/tilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windmilleng/tilt/downloads","issues_url":"https://api.github.com/repos/windmilleng/tilt/issues{/number}","pulls_url":"https://api.github.com/repos/windmilleng/tilt/pulls{/number}","milestones_url":"https://api.github.com/repos/windmilleng/tilt/milestones{/number}","notifications_url":"https://api.github.com/repos/windmilleng/tilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windmilleng/tilt/labels{/name}","releases_url":"https://api.github.com/repos/windmilleng/tilt/releases{/id}","deployments_url":"https://api.github.com/repos/windmilleng/tilt/deployments","created_at":"2018-08-07T16:00:26Z","updated_at":"2019-10-11T21:29:34Z","pushed_at":"2019-10-11T21:46:54Z","git_url":"git://github.com/windmilleng/tilt.git","ssh_url":"git@github.com:windmilleng/tilt.git","clone_url":"https://github.com/windmilleng/tilt.git","svn_url":"https://github.com/windmilleng/tilt","homepage":"https://tilt.dev/","size":33826,"stargazers_count":2853,"watchers_count":2853,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":101,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":80,"open_issues":101,"watchers":2853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2334"},"html":{"href":"https://github.com/windmilleng/tilt/pull/2334"},"issue":{"href":"https://api.github.com/repos/windmilleng/tilt/issues/2334"},"comments":{"href":"https://api.github.com/repos/windmilleng/tilt/issues/2334/comments"},"review_comments":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2334/comments"},"review_comment":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windmilleng/tilt/pulls/2334/commits"},"statuses":{"href":"https://api.github.com/repos/windmilleng/tilt/statuses/c90fb5b66c1244ed00cecc92575e939e9ec201ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicks"}}