{"action":"closed","number":3671,"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3671","id":280321592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwMzIxNTky","html_url":"https://github.com/LiskHQ/lisk-sdk/pull/3671","diff_url":"https://github.com/LiskHQ/lisk-sdk/pull/3671.diff","patch_url":"https://github.com/LiskHQ/lisk-sdk/pull/3671.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3671","number":3671,"state":"closed","locked":false,"title":"Add way to retarget specific peers on the network to account for the new LIP advertising feature - Closes #3565","user":{"login":"jondubois","id":1187447,"node_id":"MDQ6VXNlcjExODc0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1187447?v=4","gravatar_id":"","url":"https://api.github.com/users/jondubois","html_url":"https://github.com/jondubois","followers_url":"https://api.github.com/users/jondubois/followers","following_url":"https://api.github.com/users/jondubois/following{/other_user}","gists_url":"https://api.github.com/users/jondubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jondubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondubois/subscriptions","organizations_url":"https://api.github.com/users/jondubois/orgs","repos_url":"https://api.github.com/users/jondubois/repos","events_url":"https://api.github.com/users/jondubois/events{/privacy}","received_events_url":"https://api.github.com/users/jondubois/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\n\r\nThere was no way to target specific peers in the network for advanced use cases.\r\n\r\n### How did I fix it?\r\n\r\nAdded two new actions for peer targeting.\r\n\r\n### How to test it?\r\n\r\nRun `npm run test:integration` in `lisk-p2p`.\r\n\r\n### Review checklist\r\n\r\n* The PR resolves #3565\r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2019-05-20T10:03:14Z","updated_at":"2019-05-28T15:47:07Z","closed_at":"2019-05-28T15:47:07Z","merged_at":"2019-05-28T15:47:07Z","merge_commit_sha":"bb9b5af39d81f85f816795a2f521ea441d5b91f1","assignee":{"login":"jondubois","id":1187447,"node_id":"MDQ6VXNlcjExODc0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1187447?v=4","gravatar_id":"","url":"https://api.github.com/users/jondubois","html_url":"https://github.com/jondubois","followers_url":"https://api.github.com/users/jondubois/followers","following_url":"https://api.github.com/users/jondubois/following{/other_user}","gists_url":"https://api.github.com/users/jondubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jondubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondubois/subscriptions","organizations_url":"https://api.github.com/users/jondubois/orgs","repos_url":"https://api.github.com/users/jondubois/repos","events_url":"https://api.github.com/users/jondubois/events{/privacy}","received_events_url":"https://api.github.com/users/jondubois/received_events","type":"User","site_admin":false},"assignees":[{"login":"jondubois","id":1187447,"node_id":"MDQ6VXNlcjExODc0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1187447?v=4","gravatar_id":"","url":"https://api.github.com/users/jondubois","html_url":"https://github.com/jondubois","followers_url":"https://api.github.com/users/jondubois/followers","following_url":"https://api.github.com/users/jondubois/following{/other_user}","gists_url":"https://api.github.com/users/jondubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jondubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondubois/subscriptions","organizations_url":"https://api.github.com/users/jondubois/orgs","repos_url":"https://api.github.com/users/jondubois/repos","events_url":"https://api.github.com/users/jondubois/events{/privacy}","received_events_url":"https://api.github.com/users/jondubois/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":377168380,"node_id":"MDU6TGFiZWwzNzcxNjgzODA=","url":"https://api.github.com/repos/LiskHQ/lisk-sdk/labels/:white_check_mark:%20ready","name":":white_check_mark: ready","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3671/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3671/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3671/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/statuses/d13c083aa1560531b521920d939ac73f32aa9c01","head":{"label":"LiskHQ:3565-peer_targeting","ref":"3565-peer_targeting","sha":"d13c083aa1560531b521920d939ac73f32aa9c01","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk-sdk","full_name":"LiskHQ/lisk-sdk","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk-sdk","description":"🔩 Lisk software development kit","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-sdk","forks_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2019-05-28T14:40:51Z","pushed_at":"2019-05-28T15:47:07Z","git_url":"git://github.com/LiskHQ/lisk-sdk.git","ssh_url":"git@github.com:LiskHQ/lisk-sdk.git","clone_url":"https://github.com/LiskHQ/lisk-sdk.git","svn_url":"https://github.com/LiskHQ/lisk-sdk","homepage":"https://lisk.io/","size":60851,"stargazers_count":2657,"watchers_count":2657,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":429,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":224,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":429,"open_issues":224,"watchers":2657,"default_branch":"development"}},"base":{"label":"LiskHQ:feature/implement-lip-p2p","ref":"feature/implement-lip-p2p","sha":"5375222288767127f810b4aec54f7ea73514dacb","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk-sdk","full_name":"LiskHQ/lisk-sdk","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk-sdk","description":"🔩 Lisk software development kit","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-sdk","forks_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-sdk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2019-05-28T14:40:51Z","pushed_at":"2019-05-28T15:47:07Z","git_url":"git://github.com/LiskHQ/lisk-sdk.git","ssh_url":"git@github.com:LiskHQ/lisk-sdk.git","clone_url":"https://github.com/LiskHQ/lisk-sdk.git","svn_url":"https://github.com/LiskHQ/lisk-sdk","homepage":"https://lisk.io/","size":60851,"stargazers_count":2657,"watchers_count":2657,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":429,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":224,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":429,"open_issues":224,"watchers":2657,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3671"},"html":{"href":"https://github.com/LiskHQ/lisk-sdk/pull/3671"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3671"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/issues/3671/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3671/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/pulls/3671/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk-sdk/statuses/d13c083aa1560531b521920d939ac73f32aa9c01"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":198,"deletions":25,"changed_files":7}}
{"actor":{"display_login":"shuse2"}}