{"action":"opened","number":16033,"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/16033","id":254727860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NzI3ODYw","html_url":"https://github.com/sympy/sympy/pull/16033","diff_url":"https://github.com/sympy/sympy/pull/16033.diff","patch_url":"https://github.com/sympy/sympy/pull/16033.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/16033","number":16033,"state":"open","locked":false,"title":"[WIP] Simplify the sets obtained from trigonometric solveset","user":{"login":"oscargus","id":8114497,"node_id":"MDQ6VXNlcjgxMTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8114497?v=4","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"body":"<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n#### References to other Issues or PRs\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests . Please also\r\nwrite a comment on that issue linking back to this pull request once it is\r\nopen. -->\r\nRelates to #16031 \r\n\r\nI just found out about #11188 and #12011. They seem more general, which may be a reason that they are not yet merged. There are several more issues and PRs that relates to this to some extent.\r\n\r\n#### Brief description of what is fixed or changed\r\nSome simple heuristics for simplifying (primarily) the `Union` of `ImageSet`s that comes from the trigonometric solveset solvers.\r\n\r\nMore code comments and tests are needed, but I want to get some initial input if it is a worthwhile path to go or not? Also, I'm not really happy with the structure of the code. Finally, it is worthwhile to check all the existing tests etc.\r\n\r\n#### Other comments\r\nOne fundamental reason why I decided to just solve it locally is that it is not obvious to me how Dummy variables with identical name but different indices shall be handled. By knowing that the ImageSets come from the same solution, I can also be certain that Dummy-variables with the same name actually are the same. I think.\r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. The bot will check your release notes\r\nautomatically to see if they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* solvers\r\n   * The solutions from solveset of trigonometric expressions is simpler.\r\n<!-- END RELEASE NOTES -->\r\n","created_at":"2019-02-20T17:29:51Z","updated_at":"2019-02-20T17:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":226914699,"node_id":"MDU6TGFiZWwyMjY5MTQ2OTk=","url":"https://api.github.com/repos/sympy/sympy/labels/solvers.solveset","name":"solvers.solveset","color":"0000FF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/16033/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/16033/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/16033/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/f2dd5b716962d6ea0c27c12bf1a4783f259fe6b0","head":{"label":"oscargus:simplifysolvesetunion","ref":"simplifysolvesetunion","sha":"f2dd5b716962d6ea0c27c12bf1a4783f259fe6b0","user":{"login":"oscargus","id":8114497,"node_id":"MDQ6VXNlcjgxMTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8114497?v=4","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"repo":{"id":164848022,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ4NDgwMjI=","name":"sympy","full_name":"oscargus/sympy","private":false,"owner":{"login":"oscargus","id":8114497,"node_id":"MDQ6VXNlcjgxMTQ0OTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8114497?v=4","gravatar_id":"","url":"https://api.github.com/users/oscargus","html_url":"https://github.com/oscargus","followers_url":"https://api.github.com/users/oscargus/followers","following_url":"https://api.github.com/users/oscargus/following{/other_user}","gists_url":"https://api.github.com/users/oscargus/gists{/gist_id}","starred_url":"https://api.github.com/users/oscargus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscargus/subscriptions","organizations_url":"https://api.github.com/users/oscargus/orgs","repos_url":"https://api.github.com/users/oscargus/repos","events_url":"https://api.github.com/users/oscargus/events{/privacy}","received_events_url":"https://api.github.com/users/oscargus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oscargus/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/oscargus/sympy","forks_url":"https://api.github.com/repos/oscargus/sympy/forks","keys_url":"https://api.github.com/repos/oscargus/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oscargus/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oscargus/sympy/teams","hooks_url":"https://api.github.com/repos/oscargus/sympy/hooks","issue_events_url":"https://api.github.com/repos/oscargus/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/oscargus/sympy/events","assignees_url":"https://api.github.com/repos/oscargus/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/oscargus/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/oscargus/sympy/tags","blobs_url":"https://api.github.com/repos/oscargus/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oscargus/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oscargus/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/oscargus/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oscargus/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/oscargus/sympy/languages","stargazers_url":"https://api.github.com/repos/oscargus/sympy/stargazers","contributors_url":"https://api.github.com/repos/oscargus/sympy/contributors","subscribers_url":"https://api.github.com/repos/oscargus/sympy/subscribers","subscription_url":"https://api.github.com/repos/oscargus/sympy/subscription","commits_url":"https://api.github.com/repos/oscargus/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/oscargus/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/oscargus/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/oscargus/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/oscargus/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/oscargus/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oscargus/sympy/merges","archive_url":"https://api.github.com/repos/oscargus/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oscargus/sympy/downloads","issues_url":"https://api.github.com/repos/oscargus/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/oscargus/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/oscargus/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/oscargus/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oscargus/sympy/labels{/name}","releases_url":"https://api.github.com/repos/oscargus/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/oscargus/sympy/deployments","created_at":"2019-01-09T11:12:38Z","updated_at":"2019-02-20T11:25:41Z","pushed_at":"2019-02-20T17:10:55Z","git_url":"git://github.com/oscargus/sympy.git","ssh_url":"git@github.com:oscargus/sympy.git","clone_url":"https://github.com/oscargus/sympy.git","svn_url":"https://github.com/oscargus/sympy","homepage":"https://sympy.org/","size":100271,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"11c3623ed7bd5469a9e81592c1d3e42dfefb0cc5","user":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"node_id":"MDEwOlJlcG9zaXRvcnk2NDA1MzQ=","name":"sympy","full_name":"sympy/sympy","private":false,"owner":{"login":"sympy","id":260832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/260832?v=4","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2019-02-20T13:26:43Z","pushed_at":"2019-02-20T16:25:19Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"https://sympy.org/","size":99994,"stargazers_count":5571,"watchers_count":5571,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2514,"mirror_url":null,"archived":false,"open_issues_count":3571,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2514,"open_issues":3571,"watchers":5571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/16033"},"html":{"href":"https://github.com/sympy/sympy/pull/16033"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/16033"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/16033/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/16033/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/16033/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/f2dd5b716962d6ea0c27c12bf1a4783f259fe6b0"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":108,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"oscargus"}}