{"action":"created","comment":{"url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/comments/329630812","pull_request_review_id":295045887,"id":329630812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTYzMDgxMg==","diff_hunk":"@@ -61,6 +60,58 @@ describe('features/modeling/behavior - detach events', function() {\n       expect(boundaryEvent.type).to.equal('bpmn:BoundaryEvent');\n       expect(boundaryEvent.businessObject.attachedToRef).to.equal(subProcess.businessObject);\n     }));\n+\n+\n+    it('should execute on batch', inject(function(canvas, elementRegistry, modeling) {\n+\n+      // given\n+      var eventIds = [ 'BoundaryEventWithLabel', 'BoundaryEvent', 'BoundaryTimerEvent', 'BoundaryNonInterruptingMessageEvent', 'BoundaryEventWithConnections' ],\n+          elements = eventIds.map(function(eventId) {\n+            return elementRegistry.get(eventId);\n+          }),\n+          clone = elements.slice(0),\n+          root = canvas.getRootElement();\n+\n+      // when\n+      modeling.moveElements(elements, { x: 0, y: 300 }, root);\n+\n+      // then\n+      elements.forEach(function(element, index) {\n+        var expectedType = isCatchEvent(element) ? 'bpmn:IntermediateCatchEvent' : 'bpmn:IntermediateThrowEvent';\n+\n+        expect(clone[ index ].parent).to.not.exist;\n+        expect(element.parent).to.exist;\n+        expect(element.type).to.equal(expectedType);\n+        expect(element.businessObject.attachedToRef).to.not.exist;\n+        expect(element.parent).to.equal(root);\n+      });\n+    }));\n+\n+\n+    it('should not execute when moved with host', inject(function(canvas, elementRegistry, modeling) {\n+\n+      // given\n+      var eventIds = [ 'BoundaryEventWithLabel', 'BoundaryEvent', 'BoundaryTimerEvent' ],\n+          elements = eventIds.map(function(eventId) {\n+            return elementRegistry.get(eventId);\n+          }),\n+          subProcess = elementRegistry.get('SubProcess_1'),\n+          root = canvas.getRootElement();\n+      elements.push(subProcess);","path":"test/spec/features/modeling/behavior/DetachEventBehaviorSpec.js","position":49,"original_position":49,"commit_id":"9585ddced1e5133063ce11cf3aa9e6bda52f698e","original_commit_id":"9585ddced1e5133063ce11cf3aa9e6bda52f698e","user":{"login":"barmac","id":28307541,"node_id":"MDQ6VXNlcjI4MzA3NTQx","avatar_url":"https://avatars1.githubusercontent.com/u/28307541?v=4","gravatar_id":"","url":"https://api.github.com/users/barmac","html_url":"https://github.com/barmac","followers_url":"https://api.github.com/users/barmac/followers","following_url":"https://api.github.com/users/barmac/following{/other_user}","gists_url":"https://api.github.com/users/barmac/gists{/gist_id}","starred_url":"https://api.github.com/users/barmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barmac/subscriptions","organizations_url":"https://api.github.com/users/barmac/orgs","repos_url":"https://api.github.com/users/barmac/repos","events_url":"https://api.github.com/users/barmac/events{/privacy}","received_events_url":"https://api.github.com/users/barmac/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n      var movedElements = elements.concat(subProcess);\r\n```","created_at":"2019-09-30T15:06:53Z","updated_at":"2019-09-30T15:06:54Z","html_url":"https://github.com/bpmn-io/bpmn-js/pull/1206#discussion_r329630812","pull_request_url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/comments/329630812"},"html":{"href":"https://github.com/bpmn-io/bpmn-js/pull/1206#discussion_r329630812"},"pull_request":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206"}}},"pull_request":{"url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206","id":322781257,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyNzgxMjU3","html_url":"https://github.com/bpmn-io/bpmn-js/pull/1206","diff_url":"https://github.com/bpmn-io/bpmn-js/pull/1206.diff","patch_url":"https://github.com/bpmn-io/bpmn-js/pull/1206.patch","issue_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/1206","number":1206,"state":"open","locked":false,"title":"fix(DetachEventBehavior): allow batch detach on elements.move","user":{"login":"oguzeroglu","id":15003836,"node_id":"MDQ6VXNlcjE1MDAzODM2","avatar_url":"https://avatars3.githubusercontent.com/u/15003836?v=4","gravatar_id":"","url":"https://api.github.com/users/oguzeroglu","html_url":"https://github.com/oguzeroglu","followers_url":"https://api.github.com/users/oguzeroglu/followers","following_url":"https://api.github.com/users/oguzeroglu/following{/other_user}","gists_url":"https://api.github.com/users/oguzeroglu/gists{/gist_id}","starred_url":"https://api.github.com/users/oguzeroglu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oguzeroglu/subscriptions","organizations_url":"https://api.github.com/users/oguzeroglu/orgs","repos_url":"https://api.github.com/users/oguzeroglu/repos","events_url":"https://api.github.com/users/oguzeroglu/events{/privacy}","received_events_url":"https://api.github.com/users/oguzeroglu/received_events","type":"User","site_admin":false},"body":"Closes #1202\r\n\r\n![Kapture 2019-09-30 at 15 25 12](https://user-images.githubusercontent.com/15003836/65883057-8bb4eb00-e396-11e9-9992-ccba93ca0108.gif)\r\n\r\n","created_at":"2019-09-30T13:25:45Z","updated_at":"2019-09-30T15:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cace46ef937af12b56655e54e4f79ea3cbb91bc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":103861819,"node_id":"MDU6TGFiZWwxMDM4NjE4MTk=","url":"https://api.github.com/repos/bpmn-io/bpmn-js/labels/needs%20review","name":"needs review","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206/commits","review_comments_url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206/comments","review_comment_url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/1206/comments","statuses_url":"https://api.github.com/repos/bpmn-io/bpmn-js/statuses/9585ddced1e5133063ce11cf3aa9e6bda52f698e","head":{"label":"bpmn-io:1202-batch-detach-on-move","ref":"1202-batch-detach-on-move","sha":"9585ddced1e5133063ce11cf3aa9e6bda52f698e","user":{"login":"bpmn-io","id":6481734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0ODE3MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6481734?v=4","gravatar_id":"","url":"https://api.github.com/users/bpmn-io","html_url":"https://github.com/bpmn-io","followers_url":"https://api.github.com/users/bpmn-io/followers","following_url":"https://api.github.com/users/bpmn-io/following{/other_user}","gists_url":"https://api.github.com/users/bpmn-io/gists{/gist_id}","starred_url":"https://api.github.com/users/bpmn-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpmn-io/subscriptions","organizations_url":"https://api.github.com/users/bpmn-io/orgs","repos_url":"https://api.github.com/users/bpmn-io/repos","events_url":"https://api.github.com/users/bpmn-io/events{/privacy}","received_events_url":"https://api.github.com/users/bpmn-io/received_events","type":"Organization","site_admin":false},"repo":{"id":17592572,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU5MjU3Mg==","name":"bpmn-js","full_name":"bpmn-io/bpmn-js","private":false,"owner":{"login":"bpmn-io","id":6481734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0ODE3MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6481734?v=4","gravatar_id":"","url":"https://api.github.com/users/bpmn-io","html_url":"https://github.com/bpmn-io","followers_url":"https://api.github.com/users/bpmn-io/followers","following_url":"https://api.github.com/users/bpmn-io/following{/other_user}","gists_url":"https://api.github.com/users/bpmn-io/gists{/gist_id}","starred_url":"https://api.github.com/users/bpmn-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpmn-io/subscriptions","organizations_url":"https://api.github.com/users/bpmn-io/orgs","repos_url":"https://api.github.com/users/bpmn-io/repos","events_url":"https://api.github.com/users/bpmn-io/events{/privacy}","received_events_url":"https://api.github.com/users/bpmn-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bpmn-io/bpmn-js","description":"A BPMN 2.0 rendering toolkit and web modeler.","fork":false,"url":"https://api.github.com/repos/bpmn-io/bpmn-js","forks_url":"https://api.github.com/repos/bpmn-io/bpmn-js/forks","keys_url":"https://api.github.com/repos/bpmn-io/bpmn-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bpmn-io/bpmn-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bpmn-io/bpmn-js/teams","hooks_url":"https://api.github.com/repos/bpmn-io/bpmn-js/hooks","issue_events_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/events{/number}","events_url":"https://api.github.com/repos/bpmn-io/bpmn-js/events","assignees_url":"https://api.github.com/repos/bpmn-io/bpmn-js/assignees{/user}","branches_url":"https://api.github.com/repos/bpmn-io/bpmn-js/branches{/branch}","tags_url":"https://api.github.com/repos/bpmn-io/bpmn-js/tags","blobs_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bpmn-io/bpmn-js/statuses/{sha}","languages_url":"https://api.github.com/repos/bpmn-io/bpmn-js/languages","stargazers_url":"https://api.github.com/repos/bpmn-io/bpmn-js/stargazers","contributors_url":"https://api.github.com/repos/bpmn-io/bpmn-js/contributors","subscribers_url":"https://api.github.com/repos/bpmn-io/bpmn-js/subscribers","subscription_url":"https://api.github.com/repos/bpmn-io/bpmn-js/subscription","commits_url":"https://api.github.com/repos/bpmn-io/bpmn-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bpmn-io/bpmn-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bpmn-io/bpmn-js/contents/{+path}","compare_url":"https://api.github.com/repos/bpmn-io/bpmn-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bpmn-io/bpmn-js/merges","archive_url":"https://api.github.com/repos/bpmn-io/bpmn-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bpmn-io/bpmn-js/downloads","issues_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues{/number}","pulls_url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls{/number}","milestones_url":"https://api.github.com/repos/bpmn-io/bpmn-js/milestones{/number}","notifications_url":"https://api.github.com/repos/bpmn-io/bpmn-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bpmn-io/bpmn-js/labels{/name}","releases_url":"https://api.github.com/repos/bpmn-io/bpmn-js/releases{/id}","deployments_url":"https://api.github.com/repos/bpmn-io/bpmn-js/deployments","created_at":"2014-03-10T12:57:00Z","updated_at":"2019-09-30T11:34:15Z","pushed_at":"2019-09-30T13:25:46Z","git_url":"git://github.com/bpmn-io/bpmn-js.git","ssh_url":"git@github.com:bpmn-io/bpmn-js.git","clone_url":"https://github.com/bpmn-io/bpmn-js.git","svn_url":"https://github.com/bpmn-io/bpmn-js","homepage":"https://bpmn.io/toolkit/bpmn-js/","size":8245,"stargazers_count":2679,"watchers_count":2679,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":524,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":524,"open_issues":80,"watchers":2679,"default_branch":"develop"}},"base":{"label":"bpmn-io:master","ref":"master","sha":"37bcd070e8406a43a7316893c6b68debeaae5e26","user":{"login":"bpmn-io","id":6481734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0ODE3MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6481734?v=4","gravatar_id":"","url":"https://api.github.com/users/bpmn-io","html_url":"https://github.com/bpmn-io","followers_url":"https://api.github.com/users/bpmn-io/followers","following_url":"https://api.github.com/users/bpmn-io/following{/other_user}","gists_url":"https://api.github.com/users/bpmn-io/gists{/gist_id}","starred_url":"https://api.github.com/users/bpmn-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpmn-io/subscriptions","organizations_url":"https://api.github.com/users/bpmn-io/orgs","repos_url":"https://api.github.com/users/bpmn-io/repos","events_url":"https://api.github.com/users/bpmn-io/events{/privacy}","received_events_url":"https://api.github.com/users/bpmn-io/received_events","type":"Organization","site_admin":false},"repo":{"id":17592572,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU5MjU3Mg==","name":"bpmn-js","full_name":"bpmn-io/bpmn-js","private":false,"owner":{"login":"bpmn-io","id":6481734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0ODE3MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6481734?v=4","gravatar_id":"","url":"https://api.github.com/users/bpmn-io","html_url":"https://github.com/bpmn-io","followers_url":"https://api.github.com/users/bpmn-io/followers","following_url":"https://api.github.com/users/bpmn-io/following{/other_user}","gists_url":"https://api.github.com/users/bpmn-io/gists{/gist_id}","starred_url":"https://api.github.com/users/bpmn-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpmn-io/subscriptions","organizations_url":"https://api.github.com/users/bpmn-io/orgs","repos_url":"https://api.github.com/users/bpmn-io/repos","events_url":"https://api.github.com/users/bpmn-io/events{/privacy}","received_events_url":"https://api.github.com/users/bpmn-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bpmn-io/bpmn-js","description":"A BPMN 2.0 rendering toolkit and web modeler.","fork":false,"url":"https://api.github.com/repos/bpmn-io/bpmn-js","forks_url":"https://api.github.com/repos/bpmn-io/bpmn-js/forks","keys_url":"https://api.github.com/repos/bpmn-io/bpmn-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bpmn-io/bpmn-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bpmn-io/bpmn-js/teams","hooks_url":"https://api.github.com/repos/bpmn-io/bpmn-js/hooks","issue_events_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/events{/number}","events_url":"https://api.github.com/repos/bpmn-io/bpmn-js/events","assignees_url":"https://api.github.com/repos/bpmn-io/bpmn-js/assignees{/user}","branches_url":"https://api.github.com/repos/bpmn-io/bpmn-js/branches{/branch}","tags_url":"https://api.github.com/repos/bpmn-io/bpmn-js/tags","blobs_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bpmn-io/bpmn-js/statuses/{sha}","languages_url":"https://api.github.com/repos/bpmn-io/bpmn-js/languages","stargazers_url":"https://api.github.com/repos/bpmn-io/bpmn-js/stargazers","contributors_url":"https://api.github.com/repos/bpmn-io/bpmn-js/contributors","subscribers_url":"https://api.github.com/repos/bpmn-io/bpmn-js/subscribers","subscription_url":"https://api.github.com/repos/bpmn-io/bpmn-js/subscription","commits_url":"https://api.github.com/repos/bpmn-io/bpmn-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bpmn-io/bpmn-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bpmn-io/bpmn-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bpmn-io/bpmn-js/contents/{+path}","compare_url":"https://api.github.com/repos/bpmn-io/bpmn-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bpmn-io/bpmn-js/merges","archive_url":"https://api.github.com/repos/bpmn-io/bpmn-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bpmn-io/bpmn-js/downloads","issues_url":"https://api.github.com/repos/bpmn-io/bpmn-js/issues{/number}","pulls_url":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls{/number}","milestones_url":"https://api.github.com/repos/bpmn-io/bpmn-js/milestones{/number}","notifications_url":"https://api.github.com/repos/bpmn-io/bpmn-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bpmn-io/bpmn-js/labels{/name}","releases_url":"https://api.github.com/repos/bpmn-io/bpmn-js/releases{/id}","deployments_url":"https://api.github.com/repos/bpmn-io/bpmn-js/deployments","created_at":"2014-03-10T12:57:00Z","updated_at":"2019-09-30T11:34:15Z","pushed_at":"2019-09-30T13:25:46Z","git_url":"git://github.com/bpmn-io/bpmn-js.git","ssh_url":"git@github.com:bpmn-io/bpmn-js.git","clone_url":"https://github.com/bpmn-io/bpmn-js.git","svn_url":"https://github.com/bpmn-io/bpmn-js","homepage":"https://bpmn.io/toolkit/bpmn-js/","size":8245,"stargazers_count":2679,"watchers_count":2679,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":524,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":524,"open_issues":80,"watchers":2679,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206"},"html":{"href":"https://github.com/bpmn-io/bpmn-js/pull/1206"},"issue":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/1206"},"comments":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/issues/1206/comments"},"review_comments":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206/comments"},"review_comment":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/pulls/1206/commits"},"statuses":{"href":"https://api.github.com/repos/bpmn-io/bpmn-js/statuses/9585ddced1e5133063ce11cf3aa9e6bda52f698e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"barmac"}}