{"action":"created","issue":{"url":"https://api.github.com/repos/KevinOConnor/klipper/issues/1434","repository_url":"https://api.github.com/repos/KevinOConnor/klipper","labels_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/1434/labels{/name}","comments_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/1434/comments","events_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/1434/events","html_url":"https://github.com/KevinOConnor/klipper/pull/1434","id":424006395,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzNDU1NTIw","number":1434,"title":"Fixed build on OSX","user":{"login":"lylecheatham","id":9408493,"node_id":"MDQ6VXNlcjk0MDg0OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9408493?v=4","gravatar_id":"","url":"https://api.github.com/users/lylecheatham","html_url":"https://github.com/lylecheatham","followers_url":"https://api.github.com/users/lylecheatham/followers","following_url":"https://api.github.com/users/lylecheatham/following{/other_user}","gists_url":"https://api.github.com/users/lylecheatham/gists{/gist_id}","starred_url":"https://api.github.com/users/lylecheatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylecheatham/subscriptions","organizations_url":"https://api.github.com/users/lylecheatham/orgs","repos_url":"https://api.github.com/users/lylecheatham/repos","events_url":"https://api.github.com/users/lylecheatham/events{/privacy}","received_events_url":"https://api.github.com/users/lylecheatham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-03-22T01:15:29Z","updated_at":"2019-04-14T16:59:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/KevinOConnor/klipper/pulls/1434","html_url":"https://github.com/KevinOConnor/klipper/pull/1434","diff_url":"https://github.com/KevinOConnor/klipper/pull/1434.diff","patch_url":"https://github.com/KevinOConnor/klipper/pull/1434.patch"},"body":"Made the changes I outlined in #1432, tested the build on Linux and OSX"},"comment":{"url":"https://api.github.com/repos/KevinOConnor/klipper/issues/comments/483017440","html_url":"https://github.com/KevinOConnor/klipper/pull/1434#issuecomment-483017440","issue_url":"https://api.github.com/repos/KevinOConnor/klipper/issues/1434","id":483017440,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4MzAxNzQ0MA==","user":{"login":"lylecheatham","id":9408493,"node_id":"MDQ6VXNlcjk0MDg0OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9408493?v=4","gravatar_id":"","url":"https://api.github.com/users/lylecheatham","html_url":"https://github.com/lylecheatham","followers_url":"https://api.github.com/users/lylecheatham/followers","following_url":"https://api.github.com/users/lylecheatham/following{/other_user}","gists_url":"https://api.github.com/users/lylecheatham/gists{/gist_id}","starred_url":"https://api.github.com/users/lylecheatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylecheatham/subscriptions","organizations_url":"https://api.github.com/users/lylecheatham/orgs","repos_url":"https://api.github.com/users/lylecheatham/repos","events_url":"https://api.github.com/users/lylecheatham/events{/privacy}","received_events_url":"https://api.github.com/users/lylecheatham/received_events","type":"User","site_admin":false},"created_at":"2019-04-14T16:59:55Z","updated_at":"2019-04-14T16:59:55Z","author_association":"NONE","body":"Also an additional problem I spotted that's not related to building on OSX, but related to running on OSX: the `clear_hupcl(fd)` function on line 20 of `klippy/util.py` throws an error on OSX, I'm guessing it's just unsupported or something.\r\n\r\n~~~~\r\nUnhandled exception during connect\r\nTraceback (most recent call last):\r\n  File \"./klippy/klippy.py\", line 137, in _connect\r\n    cb()\r\n  File \"/Users/Lyle/Documents/workspace/klipper/klippy/mcu.py\", line 609, in _connect\r\n    self._serial.connect()\r\n  File \"/Users/Lyle/Documents/workspace/klipper/klippy/serialhdl.py\", line 69, in connect\r\n    stk500v2_leave(self.ser, self.reactor)\r\n  File \"/Users/Lyle/Documents/workspace/klipper/klippy/serialhdl.py\", line 269, in stk500v2_leave\r\n    util.clear_hupcl(ser.fileno())\r\n  File \"/Users/Lyle/Documents/workspace/klipper/klippy/util.py\", line 23, in clear_hupcl\r\n    termios.tcsetattr(fd, termios.TCSADRAIN, attrs)\r\nerror: (22, 'Invalid argument')\r\n~~~~\r\n\r\nI did some reading and this seems to be a pretty esoteric feature of hardware serial ports that doesn't have much significance/ is unsupported by modern usb to serial chips, and that's not even counting the fact that many chips are just USB CDC and never even go to a hardware serial layer."}}
{"actor":{"display_login":"lylecheatham"}}