{"action":"created","issue":{"url":"https://api.github.com/repos/SatelliteQE/testimony/issues/141","repository_url":"https://api.github.com/repos/SatelliteQE/testimony","labels_url":"https://api.github.com/repos/SatelliteQE/testimony/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/SatelliteQE/testimony/issues/141/comments","events_url":"https://api.github.com/repos/SatelliteQE/testimony/issues/141/events","html_url":"https://github.com/SatelliteQE/testimony/pull/141","id":444881096,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5NDQ2NDgz","number":141,"title":"Make it possible to also check if token values are from expected pool","user":{"login":"jhutar","id":3397250,"node_id":"MDQ6VXNlcjMzOTcyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3397250?v=4","gravatar_id":"","url":"https://api.github.com/users/jhutar","html_url":"https://github.com/jhutar","followers_url":"https://api.github.com/users/jhutar/followers","following_url":"https://api.github.com/users/jhutar/following{/other_user}","gists_url":"https://api.github.com/users/jhutar/gists{/gist_id}","starred_url":"https://api.github.com/users/jhutar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhutar/subscriptions","organizations_url":"https://api.github.com/users/jhutar/orgs","repos_url":"https://api.github.com/users/jhutar/repos","events_url":"https://api.github.com/users/jhutar/events{/privacy}","received_events_url":"https://api.github.com/users/jhutar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-05-16T10:37:43Z","updated_at":"2019-05-20T10:52:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/SatelliteQE/testimony/pulls/141","html_url":"https://github.com/SatelliteQE/testimony/pull/141","diff_url":"https://github.com/SatelliteQE/testimony/pull/141.diff","patch_url":"https://github.com/SatelliteQE/testimony/pull/141.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/SatelliteQE/testimony/issues/comments/493936551","html_url":"https://github.com/SatelliteQE/testimony/pull/141#issuecomment-493936551","issue_url":"https://api.github.com/repos/SatelliteQE/testimony/issues/141","id":493936551,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MzkzNjU1MQ==","user":{"login":"mirzal","id":12373754,"node_id":"MDQ6VXNlcjEyMzczNzU0","avatar_url":"https://avatars2.githubusercontent.com/u/12373754?v=4","gravatar_id":"","url":"https://api.github.com/users/mirzal","html_url":"https://github.com/mirzal","followers_url":"https://api.github.com/users/mirzal/followers","following_url":"https://api.github.com/users/mirzal/following{/other_user}","gists_url":"https://api.github.com/users/mirzal/gists{/gist_id}","starred_url":"https://api.github.com/users/mirzal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirzal/subscriptions","organizations_url":"https://api.github.com/users/mirzal/orgs","repos_url":"https://api.github.com/users/mirzal/repos","events_url":"https://api.github.com/users/mirzal/events{/privacy}","received_events_url":"https://api.github.com/users/mirzal/received_events","type":"User","site_admin":false},"created_at":"2019-05-20T10:52:01Z","updated_at":"2019-05-20T10:52:01Z","author_association":"MEMBER","body":"> IMO it depends whether we want to have testimony doing all the checks at once or to have multiple separate checks.\r\n\r\nI prefer to run all checks at once. There are couple of reasons:\r\n\r\n1. You can control number and scope of checks to perform through config file. If you want to check if only expected tokens are provided, and if each test has minimum set of tokens defined (basically, mimic current behavior), you may pass config file like this:\r\n```yaml\r\n---\r\nCaseImportance:\r\n    required: true\r\nCaseAutomation:\r\nComponent:\r\n    required: true\r\n```\r\nIf you also want to check if correct values are provided, then you may use config file like this:\r\n```yaml\r\n---\r\nCaseImportance:\r\n    required: true\r\n    type: choice\r\n    choices:\r\n        - Critical\r\n        - High\r\n        - Medium\r\n        - Low\r\nCaseAutomation:\r\nComponent:\r\n    required: true\r\n```\r\n\r\nIf you want to do atomic checks, you only need to keep bunch of config files around. If you want to have all checks done in single pass, you dump everything in single config file.\r\n\r\n2. With little benchmarking that I did, I am confident that parsing metadata out of docstrings is the slowest part of testimony. On my machine, it takes about 1 second to parse single file, and about 45 seconds to parse entire `robottelo/tests/foreman`. Running `validate` or `validate-values` on all tests takes 0.01 second. For me, it's clear that we should try to do as much as possible on single reading of tests docstrings.\r\n\r\n3. It seems to be more in line with initial design decisions and intentions of testimony authors.\r\n\r\nI am happy to take this PR over from here and working on this further. You did a great deal of very valuable work already."}}
{"actor":{"display_login":"mirzal"}}