{"action":"created","issue":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2747","repository_url":"https://api.github.com/repos/AvaloniaUI/Avalonia","labels_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2747/labels{/name}","comments_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2747/comments","events_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2747/events","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/2747","id":469242474,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4NTEzODI2","number":2747,"title":"Implement equality","user":{"login":"JaggerJo","id":13090415,"node_id":"MDQ6VXNlcjEzMDkwNDE1","avatar_url":"https://avatars3.githubusercontent.com/u/13090415?v=4","gravatar_id":"","url":"https://api.github.com/users/JaggerJo","html_url":"https://github.com/JaggerJo","followers_url":"https://api.github.com/users/JaggerJo/followers","following_url":"https://api.github.com/users/JaggerJo/following{/other_user}","gists_url":"https://api.github.com/users/JaggerJo/gists{/gist_id}","starred_url":"https://api.github.com/users/JaggerJo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaggerJo/subscriptions","organizations_url":"https://api.github.com/users/JaggerJo/orgs","repos_url":"https://api.github.com/users/JaggerJo/repos","events_url":"https://api.github.com/users/JaggerJo/events{/privacy}","received_events_url":"https://api.github.com/users/JaggerJo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2019-07-17T14:18:18Z","updated_at":"2019-07-19T11:37:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/pulls/2747","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/2747","diff_url":"https://github.com/AvaloniaUI/Avalonia/pull/2747.diff","patch_url":"https://github.com/AvaloniaUI/Avalonia/pull/2747.patch"},"body":"## What does the pull request do?\r\nAdd equality implementations to:\r\n- SolidColorBrush & ImmutableSolidColorBrush\r\n- RowDefinition & RowDefinitions\r\n- ColumnDefinition & ColumnDefinitions\r\n\r\n\r\n## What is the current behavior?\r\nThe types use the default (reference) equality\r\n\r\n\r\n## What is the updated/expected behavior with this PR?\r\nThe types use value equality\r\n\r\n\r\n## How was the solution implemented (if it's not obvious)?\r\n<!--- Include any information that might be of use to a reviewer here. -->\r\n\r\n\r\n## Checklist\r\n\r\n- [x] Added unit tests (if possible)?\r\n- [x] Added XML documentation to any related classes?\r\n- [x] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation\r\n\r\n## Breaking changes\r\n\r\n## Fixed issues\r\n"},"comment":{"url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/comments/513197183","html_url":"https://github.com/AvaloniaUI/Avalonia/pull/2747#issuecomment-513197183","issue_url":"https://api.github.com/repos/AvaloniaUI/Avalonia/issues/2747","id":513197183,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMzE5NzE4Mw==","user":{"login":"grokys","id":1775141,"node_id":"MDQ6VXNlcjE3NzUxNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1775141?v=4","gravatar_id":"","url":"https://api.github.com/users/grokys","html_url":"https://github.com/grokys","followers_url":"https://api.github.com/users/grokys/followers","following_url":"https://api.github.com/users/grokys/following{/other_user}","gists_url":"https://api.github.com/users/grokys/gists{/gist_id}","starred_url":"https://api.github.com/users/grokys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokys/subscriptions","organizations_url":"https://api.github.com/users/grokys/orgs","repos_url":"https://api.github.com/users/grokys/repos","events_url":"https://api.github.com/users/grokys/events{/privacy}","received_events_url":"https://api.github.com/users/grokys/received_events","type":"User","site_admin":false},"created_at":"2019-07-19T11:37:31Z","updated_at":"2019-07-19T11:37:31Z","author_association":"MEMBER","body":"> Yeah, I thinks so too. Bad that this warning exists.\r\n\r\nSorry, I'm lost here. Are you saying \"I think so to\" to agree with disallowing overriding `Equals` and `GetHashCode` like in WPF?"}}
{"actor":{"display_login":"grokys"}}