{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/comments/309335643","pull_request_review_id":269159347,"id":309335643,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTMzNTY0Mw==","diff_hunk":"@@ -1,13 +1,52 @@\n+enum AnimationPath {\n+    //% block=\"fly to center of screen\"\n+    FlyToCenter,\n+    //% block=\"shake\"\n+    Shake,\n+    //% block=\"bounce (right)\"\n+    BounceRight,\n+    //% block=\"bounce (left)\"\n+    BounceLeft,\n+    //% block=\"parachute (right)\"\n+    ParachuteRight,\n+    //% block=\"parachute (left)\"\n+    ParachuteLeft,\n+    //% block=\"ease (right)\"\n+    EaseRight,\n+    //% block=\"ease (left)\"\n+    EaseLeft,\n+    //% block=\"ease (down)\"\n+    EaseDown,\n+    //% block=\"ease (up)\"\n+    EaseUp,\n+    //% block=\"wave (right)\"\n+    WaveRight,\n+    //% block=\"wave (left)\"\n+    WaveLeft,\n+    //% block=\"bobbing (in place)\"\n+    Bobbing,\n+    //% block=\"bobbing (right)\"\n+    BobbingRight,\n+    //% block=\"bobbing (left)\"\n+    BobbingLeft\n+}\n+\n /*\n     Animation library for sprites\n */\n //% color=\"#03AA74\" weight=78 icon=\"\\uf021\"\n namespace animation {\n-    //Handles all the updates\n-    let animations: Animation[];\n+    export interface AnimationState {\n+        movementAnimation?: MovementAnimation,\n+        imageAnimation?: ImageAnimation\n+    }\n+\n+    // Stores the animations for the current scene\n+    let animations: AnimationState;","path":"libs/animation/animation.ts","position":47,"original_position":47,"commit_id":"c30fcc65224f2e9c849ba3cb398db3dea694f9ab","original_commit_id":"c30fcc65224f2e9c849ba3cb398db3dea694f9ab","user":{"login":"pelikhan","id":4175913,"node_id":"MDQ6VXNlcjQxNzU5MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4175913?v=4","gravatar_id":"","url":"https://api.github.com/users/pelikhan","html_url":"https://github.com/pelikhan","followers_url":"https://api.github.com/users/pelikhan/followers","following_url":"https://api.github.com/users/pelikhan/following{/other_user}","gists_url":"https://api.github.com/users/pelikhan/gists{/gist_id}","starred_url":"https://api.github.com/users/pelikhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelikhan/subscriptions","organizations_url":"https://api.github.com/users/pelikhan/orgs","repos_url":"https://api.github.com/users/pelikhan/repos","events_url":"https://api.github.com/users/pelikhan/events{/privacy}","received_events_url":"https://api.github.com/users/pelikhan/received_events","type":"User","site_admin":false},"body":"animations should be stored in the scene.state.","created_at":"2019-07-31T17:13:17Z","updated_at":"2019-07-31T17:17:55Z","html_url":"https://github.com/microsoft/pxt-common-packages/pull/906#discussion_r309335643","pull_request_url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/comments/309335643"},"html":{"href":"https://github.com/microsoft/pxt-common-packages/pull/906#discussion_r309335643"},"pull_request":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906","id":303038166,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzMDM4MTY2","html_url":"https://github.com/microsoft/pxt-common-packages/pull/906","diff_url":"https://github.com/microsoft/pxt-common-packages/pull/906.diff","patch_url":"https://github.com/microsoft/pxt-common-packages/pull/906.patch","issue_url":"https://api.github.com/repos/microsoft/pxt-common-packages/issues/906","number":906,"state":"open","locked":false,"title":"New animation extension","user":{"login":"dannytech","id":20747523,"node_id":"MDQ6VXNlcjIwNzQ3NTIz","avatar_url":"https://avatars3.githubusercontent.com/u/20747523?v=4","gravatar_id":"","url":"https://api.github.com/users/dannytech","html_url":"https://github.com/dannytech","followers_url":"https://api.github.com/users/dannytech/followers","following_url":"https://api.github.com/users/dannytech/following{/other_user}","gists_url":"https://api.github.com/users/dannytech/gists{/gist_id}","starred_url":"https://api.github.com/users/dannytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannytech/subscriptions","organizations_url":"https://api.github.com/users/dannytech/orgs","repos_url":"https://api.github.com/users/dannytech/repos","events_url":"https://api.github.com/users/dannytech/events{/privacy}","received_events_url":"https://api.github.com/users/dannytech/received_events","type":"User","site_admin":false},"body":"This PR would replace the existing animation extension with a new one containing some major functionality changes. The overall objectives were to reduce the amount of blocks needed to run an animation to one and add movement animations (animation sprite position over time).\r\n\r\nChanges:\r\n\r\n* The old animation blocks are now hidden. They have been replaced with two blocks, one for image animations and one for movement animations. There is another block that returns SVG path strings to be consumed by the movement animation block.\r\n* Image animations and movement animations can run in parallel.\r\n* Animations are now tied to a sprite when they are created and are immediately run after being created, removing the need for extra blocks to perform those actions.\r\n* Animations can now be configured as either blocking or non-blocking..\r\n\r\nFuture changes:\r\n\r\n* Due to the number of parameters, the block wraps inputs into lines. This has the unfortunate effect of moving the \"ms\" text after the time picker to the next line.\r\n* Loop and stop blocks will be added to remove the need for manually looping and allow running animations to be interrupted.\r\n","created_at":"2019-07-31T16:39:46Z","updated_at":"2019-07-31T17:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c7d71359a264ebcce2f32e8ef8453bc27e42e1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906/commits","review_comments_url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906/comments","review_comment_url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/pxt-common-packages/issues/906/comments","statuses_url":"https://api.github.com/repos/microsoft/pxt-common-packages/statuses/c30fcc65224f2e9c849ba3cb398db3dea694f9ab","head":{"label":"dannytech:new-animation","ref":"new-animation","sha":"c30fcc65224f2e9c849ba3cb398db3dea694f9ab","user":{"login":"dannytech","id":20747523,"node_id":"MDQ6VXNlcjIwNzQ3NTIz","avatar_url":"https://avatars3.githubusercontent.com/u/20747523?v=4","gravatar_id":"","url":"https://api.github.com/users/dannytech","html_url":"https://github.com/dannytech","followers_url":"https://api.github.com/users/dannytech/followers","following_url":"https://api.github.com/users/dannytech/following{/other_user}","gists_url":"https://api.github.com/users/dannytech/gists{/gist_id}","starred_url":"https://api.github.com/users/dannytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannytech/subscriptions","organizations_url":"https://api.github.com/users/dannytech/orgs","repos_url":"https://api.github.com/users/dannytech/repos","events_url":"https://api.github.com/users/dannytech/events{/privacy}","received_events_url":"https://api.github.com/users/dannytech/received_events","type":"User","site_admin":false},"repo":{"id":195865306,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU4NjUzMDY=","name":"pxt-common-packages","full_name":"dannytech/pxt-common-packages","private":false,"owner":{"login":"dannytech","id":20747523,"node_id":"MDQ6VXNlcjIwNzQ3NTIz","avatar_url":"https://avatars3.githubusercontent.com/u/20747523?v=4","gravatar_id":"","url":"https://api.github.com/users/dannytech","html_url":"https://github.com/dannytech","followers_url":"https://api.github.com/users/dannytech/followers","following_url":"https://api.github.com/users/dannytech/following{/other_user}","gists_url":"https://api.github.com/users/dannytech/gists{/gist_id}","starred_url":"https://api.github.com/users/dannytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannytech/subscriptions","organizations_url":"https://api.github.com/users/dannytech/orgs","repos_url":"https://api.github.com/users/dannytech/repos","events_url":"https://api.github.com/users/dannytech/events{/privacy}","received_events_url":"https://api.github.com/users/dannytech/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dannytech/pxt-common-packages","description":"Common packages for Microsoft MakeCode editors","fork":true,"url":"https://api.github.com/repos/dannytech/pxt-common-packages","forks_url":"https://api.github.com/repos/dannytech/pxt-common-packages/forks","keys_url":"https://api.github.com/repos/dannytech/pxt-common-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannytech/pxt-common-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannytech/pxt-common-packages/teams","hooks_url":"https://api.github.com/repos/dannytech/pxt-common-packages/hooks","issue_events_url":"https://api.github.com/repos/dannytech/pxt-common-packages/issues/events{/number}","events_url":"https://api.github.com/repos/dannytech/pxt-common-packages/events","assignees_url":"https://api.github.com/repos/dannytech/pxt-common-packages/assignees{/user}","branches_url":"https://api.github.com/repos/dannytech/pxt-common-packages/branches{/branch}","tags_url":"https://api.github.com/repos/dannytech/pxt-common-packages/tags","blobs_url":"https://api.github.com/repos/dannytech/pxt-common-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannytech/pxt-common-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannytech/pxt-common-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannytech/pxt-common-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannytech/pxt-common-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/dannytech/pxt-common-packages/languages","stargazers_url":"https://api.github.com/repos/dannytech/pxt-common-packages/stargazers","contributors_url":"https://api.github.com/repos/dannytech/pxt-common-packages/contributors","subscribers_url":"https://api.github.com/repos/dannytech/pxt-common-packages/subscribers","subscription_url":"https://api.github.com/repos/dannytech/pxt-common-packages/subscription","commits_url":"https://api.github.com/repos/dannytech/pxt-common-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannytech/pxt-common-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannytech/pxt-common-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannytech/pxt-common-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannytech/pxt-common-packages/contents/{+path}","compare_url":"https://api.github.com/repos/dannytech/pxt-common-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannytech/pxt-common-packages/merges","archive_url":"https://api.github.com/repos/dannytech/pxt-common-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannytech/pxt-common-packages/downloads","issues_url":"https://api.github.com/repos/dannytech/pxt-common-packages/issues{/number}","pulls_url":"https://api.github.com/repos/dannytech/pxt-common-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/dannytech/pxt-common-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/dannytech/pxt-common-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannytech/pxt-common-packages/labels{/name}","releases_url":"https://api.github.com/repos/dannytech/pxt-common-packages/releases{/id}","deployments_url":"https://api.github.com/repos/dannytech/pxt-common-packages/deployments","created_at":"2019-07-08T18:23:20Z","updated_at":"2019-07-19T00:38:47Z","pushed_at":"2019-07-31T17:01:16Z","git_url":"git://github.com/dannytech/pxt-common-packages.git","ssh_url":"git@github.com:dannytech/pxt-common-packages.git","clone_url":"https://github.com/dannytech/pxt-common-packages.git","svn_url":"https://github.com/dannytech/pxt-common-packages","homepage":"https://makecode.com","size":6128,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"cf3be9ef62e546dd4f897a23864ea7776aa94126","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":83395040,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM5NTA0MA==","name":"pxt-common-packages","full_name":"microsoft/pxt-common-packages","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/pxt-common-packages","description":"Common packages for Microsoft MakeCode editors","fork":false,"url":"https://api.github.com/repos/microsoft/pxt-common-packages","forks_url":"https://api.github.com/repos/microsoft/pxt-common-packages/forks","keys_url":"https://api.github.com/repos/microsoft/pxt-common-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/pxt-common-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/pxt-common-packages/teams","hooks_url":"https://api.github.com/repos/microsoft/pxt-common-packages/hooks","issue_events_url":"https://api.github.com/repos/microsoft/pxt-common-packages/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/pxt-common-packages/events","assignees_url":"https://api.github.com/repos/microsoft/pxt-common-packages/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/pxt-common-packages/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/pxt-common-packages/tags","blobs_url":"https://api.github.com/repos/microsoft/pxt-common-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/pxt-common-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/pxt-common-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/pxt-common-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/pxt-common-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/pxt-common-packages/languages","stargazers_url":"https://api.github.com/repos/microsoft/pxt-common-packages/stargazers","contributors_url":"https://api.github.com/repos/microsoft/pxt-common-packages/contributors","subscribers_url":"https://api.github.com/repos/microsoft/pxt-common-packages/subscribers","subscription_url":"https://api.github.com/repos/microsoft/pxt-common-packages/subscription","commits_url":"https://api.github.com/repos/microsoft/pxt-common-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/pxt-common-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/pxt-common-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/pxt-common-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/pxt-common-packages/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/pxt-common-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/pxt-common-packages/merges","archive_url":"https://api.github.com/repos/microsoft/pxt-common-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/pxt-common-packages/downloads","issues_url":"https://api.github.com/repos/microsoft/pxt-common-packages/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/pxt-common-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/pxt-common-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/pxt-common-packages/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/pxt-common-packages/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/pxt-common-packages/deployments","created_at":"2017-02-28T05:53:15Z","updated_at":"2019-07-31T17:15:49Z","pushed_at":"2019-07-31T17:15:50Z","git_url":"git://github.com/microsoft/pxt-common-packages.git","ssh_url":"git@github.com:microsoft/pxt-common-packages.git","clone_url":"https://github.com/microsoft/pxt-common-packages.git","svn_url":"https://github.com/microsoft/pxt-common-packages","homepage":"https://makecode.com","size":5766,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":8,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906"},"html":{"href":"https://github.com/microsoft/pxt-common-packages/pull/906"},"issue":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/issues/906"},"comments":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/pxt-common-packages/statuses/c30fcc65224f2e9c849ba3cb398db3dea694f9ab"}},"author_association":"NONE"}}
{"actor":{"display_login":"pelikhan"}}