{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/290284189","pull_request_review_id":245429928,"id":290284189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDI4NDE4OQ==","diff_hunk":"@@ -243,6 +243,11 @@ struct rdp_update\n \trdpPcap* pcap_rfx;\n \tBOOL initialState;\n \n+\t/* if autoCalculateBitmapData is set to TRUE, the server automatically \n+\t * fills BITMAP_DATA struct members: flags, cbCompMainBodySize and cbCompFirstRowSize.\n+\t*/\n+\tBOOL autoCalculateBitmapData;\n+","path":"include/freerdp/update.h","position":8,"original_position":8,"commit_id":"66d2b756238d4d140802b0ffdb092aa970c56d4b","original_commit_id":"66d2b756238d4d140802b0ffdb092aa970c56d4b","user":{"login":"hardening","id":3237998,"node_id":"MDQ6VXNlcjMyMzc5OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3237998?v=4","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"body":"would be nice to move that new field at the end of the struct for binary compatibility","created_at":"2019-06-04T13:03:19Z","updated_at":"2019-06-04T13:03:19Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/5423#discussion_r290284189","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/290284189"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/5423#discussion_r290284189"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423","id":284878830,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0ODc4ODMw","html_url":"https://github.com/FreeRDP/FreeRDP/pull/5423","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/5423.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/5423.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/5423","number":5423,"state":"open","locked":false,"title":"rdpUpdate: add autoBitmapDataCalculate","user":{"login":"kubistika","id":29171557,"node_id":"MDQ6VXNlcjI5MTcxNTU3","avatar_url":"https://avatars3.githubusercontent.com/u/29171557?v=4","gravatar_id":"","url":"https://api.github.com/users/kubistika","html_url":"https://github.com/kubistika","followers_url":"https://api.github.com/users/kubistika/followers","following_url":"https://api.github.com/users/kubistika/following{/other_user}","gists_url":"https://api.github.com/users/kubistika/gists{/gist_id}","starred_url":"https://api.github.com/users/kubistika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubistika/subscriptions","organizations_url":"https://api.github.com/users/kubistika/orgs","repos_url":"https://api.github.com/users/kubistika/repos","events_url":"https://api.github.com/users/kubistika/events{/privacy}","received_events_url":"https://api.github.com/users/kubistika/received_events","type":"User","site_admin":false},"body":"I found a bug in our proxy that occurs when the target server is win7:\r\nthe target sends bitmap update data with flags=0 and the server code changes it to 0x401 instead of sending it as is, then the client (mstsc) closes the connection (because it got an uncompressed bitmap with flags indicating that it is compressed, I guess)\r\n\r\nI didn't want to break the API so I though of a way to fix it and wanted to hear what do you guys think of it\r\n@akallabeth @hardening \r\n\r\nBTW, wasn't sure about the name `autoBitmapDataCalculate`, because it actually calculate only three members of the struct. I noted this in the comment, before the declaration of this struct member. So a new name for this member / a different idea for a solution will be welcomed ","created_at":"2019-06-04T09:03:38Z","updated_at":"2019-06-04T13:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e94998e5ad539ceea3483e13723fda3c36c04f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/5423/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/66d2b756238d4d140802b0ffdb092aa970c56d4b","head":{"label":"kubistika:feat/bitmap-auto-flag-calculate","ref":"feat/bitmap-auto-flag-calculate","sha":"66d2b756238d4d140802b0ffdb092aa970c56d4b","user":{"login":"kubistika","id":29171557,"node_id":"MDQ6VXNlcjI5MTcxNTU3","avatar_url":"https://avatars3.githubusercontent.com/u/29171557?v=4","gravatar_id":"","url":"https://api.github.com/users/kubistika","html_url":"https://github.com/kubistika","followers_url":"https://api.github.com/users/kubistika/followers","following_url":"https://api.github.com/users/kubistika/following{/other_user}","gists_url":"https://api.github.com/users/kubistika/gists{/gist_id}","starred_url":"https://api.github.com/users/kubistika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubistika/subscriptions","organizations_url":"https://api.github.com/users/kubistika/orgs","repos_url":"https://api.github.com/users/kubistika/repos","events_url":"https://api.github.com/users/kubistika/events{/privacy}","received_events_url":"https://api.github.com/users/kubistika/received_events","type":"User","site_admin":false},"repo":{"id":177085080,"node_id":"MDEwOlJlcG9zaXRvcnkxNzcwODUwODA=","name":"FreeRDP","full_name":"kubistika/FreeRDP","private":false,"owner":{"login":"kubistika","id":29171557,"node_id":"MDQ6VXNlcjI5MTcxNTU3","avatar_url":"https://avatars3.githubusercontent.com/u/29171557?v=4","gravatar_id":"","url":"https://api.github.com/users/kubistika","html_url":"https://github.com/kubistika","followers_url":"https://api.github.com/users/kubistika/followers","following_url":"https://api.github.com/users/kubistika/following{/other_user}","gists_url":"https://api.github.com/users/kubistika/gists{/gist_id}","starred_url":"https://api.github.com/users/kubistika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubistika/subscriptions","organizations_url":"https://api.github.com/users/kubistika/orgs","repos_url":"https://api.github.com/users/kubistika/repos","events_url":"https://api.github.com/users/kubistika/events{/privacy}","received_events_url":"https://api.github.com/users/kubistika/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kubistika/FreeRDP","description":"FreeRDP is a free remote desktop protocol library and clients","fork":true,"url":"https://api.github.com/repos/kubistika/FreeRDP","forks_url":"https://api.github.com/repos/kubistika/FreeRDP/forks","keys_url":"https://api.github.com/repos/kubistika/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubistika/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubistika/FreeRDP/teams","hooks_url":"https://api.github.com/repos/kubistika/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/kubistika/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/kubistika/FreeRDP/events","assignees_url":"https://api.github.com/repos/kubistika/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/kubistika/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/kubistika/FreeRDP/tags","blobs_url":"https://api.github.com/repos/kubistika/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubistika/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubistika/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubistika/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubistika/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/kubistika/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/kubistika/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/kubistika/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/kubistika/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/kubistika/FreeRDP/subscription","commits_url":"https://api.github.com/repos/kubistika/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubistika/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubistika/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubistika/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubistika/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/kubistika/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubistika/FreeRDP/merges","archive_url":"https://api.github.com/repos/kubistika/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubistika/FreeRDP/downloads","issues_url":"https://api.github.com/repos/kubistika/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/kubistika/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/kubistika/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/kubistika/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubistika/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/kubistika/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/kubistika/FreeRDP/deployments","created_at":"2019-03-22T06:37:07Z","updated_at":"2019-05-05T09:23:05Z","pushed_at":"2019-06-04T09:00:58Z","git_url":"git://github.com/kubistika/FreeRDP.git","ssh_url":"git@github.com:kubistika/FreeRDP.git","clone_url":"https://github.com/kubistika/FreeRDP.git","svn_url":"https://github.com/kubistika/FreeRDP","homepage":"http://www.freerdp.com/","size":37928,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"20c4e3bab03bd2977a70e5bd560d3a15d0ce9031","user":{"login":"FreeRDP","id":663376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzM3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/663376?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5Nzk3","name":"FreeRDP","full_name":"FreeRDP/FreeRDP","private":false,"owner":{"login":"FreeRDP","id":663376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2MzM3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/663376?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol library and clients","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/deployments","created_at":"2011-06-30T19:14:15Z","updated_at":"2019-06-04T11:51:55Z","pushed_at":"2019-06-04T11:51:47Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":37924,"stargazers_count":3266,"watchers_count":3266,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1307,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":325,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1307,"open_issues":325,"watchers":3266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/5423"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/5423"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/5423/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/5423/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/66d2b756238d4d140802b0ffdb092aa970c56d4b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hardening"}}