{"action":"opened","number":44,"pull_request":{"url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/44","id":338587226,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4NTg3MjI2","html_url":"https://github.com/VictorAvelar/mollie-api-go/pull/44","diff_url":"https://github.com/VictorAvelar/mollie-api-go/pull/44.diff","patch_url":"https://github.com/VictorAvelar/mollie-api-go/pull/44.patch","issue_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues/44","number":44,"state":"open","locked":false,"title":"Issue/fix 43 wrong type","user":{"login":"dwikur21","id":26384044,"node_id":"MDQ6VXNlcjI2Mzg0MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/26384044?v=4","gravatar_id":"","url":"https://api.github.com/users/dwikur21","html_url":"https://github.com/dwikur21","followers_url":"https://api.github.com/users/dwikur21/followers","following_url":"https://api.github.com/users/dwikur21/following{/other_user}","gists_url":"https://api.github.com/users/dwikur21/gists{/gist_id}","starred_url":"https://api.github.com/users/dwikur21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwikur21/subscriptions","organizations_url":"https://api.github.com/users/dwikur21/orgs","repos_url":"https://api.github.com/users/dwikur21/repos","events_url":"https://api.github.com/users/dwikur21/events{/privacy}","received_events_url":"https://api.github.com/users/dwikur21/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n\r\nFix wrong type of Status (string) in ErrorResponse struct. Replace it with StatusCode (int). Included are other fixes that I found while I'm testing the orders_test.go as a side effect of my previous PR #41. This is why I'm not squashing my commits. Now, for the tests of TestOrdersService_CancelOrderLines, TestOrdersService_CreatePaymentFailed, and TestOrdersService_CreateOrderRefundFailed, for those to be failed the ErrorResponse should nil and the error should not nil.\r\n\r\n## Motivation and context\r\n\r\nFixes #43 \r\n\r\n## How has this been tested?\r\nTested using the built-in Golang test tools.\r\nGolang version go1.12.6 windows/amd64.\r\nFollowing the steps to reproduce, produces the expected results.\r\n\r\n## Screenshots (if appropriate)\r\n![image](https://user-images.githubusercontent.com/26384044/68463502-5f1bab00-0241-11ea-97ef-91ed5e63d3ab.png)\r\n\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce? Put an `x` in all the boxes that apply:\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\nGo over all the following points, and put an `x` in all the boxes that apply.\r\n\r\nPlease, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your [tests and code style pass](https://help.github.com/articles/about-required-status-checks/).\r\n\r\n- [x] I have read the **[CONTRIBUTING](CONTRIBUTING.md)** document.\r\n- [x] My pull request addresses exactly one patch/feature.\r\n- [x] I have created a branch for this patch/feature.\r\n- [x] Each individual commit in the pull request is meaningful.\r\n- [x] I have added tests to cover my changes.\r\n- [x] If my change requires a change to the documentation, I have updated it accordingly.\r\n\r\nIf you're unsure about any of these, don't hesitate to ask. We're here to help!\r\n","created_at":"2019-11-08T09:29:31Z","updated_at":"2019-11-08T09:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/44/commits","review_comments_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/44/comments","review_comment_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues/44/comments","statuses_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/statuses/10cfbb2e75f70a7f8f97f92a75d48bec79d47383","head":{"label":"dwikur21:issue/fix-43-wrong-type","ref":"issue/fix-43-wrong-type","sha":"10cfbb2e75f70a7f8f97f92a75d48bec79d47383","user":{"login":"dwikur21","id":26384044,"node_id":"MDQ6VXNlcjI2Mzg0MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/26384044?v=4","gravatar_id":"","url":"https://api.github.com/users/dwikur21","html_url":"https://github.com/dwikur21","followers_url":"https://api.github.com/users/dwikur21/followers","following_url":"https://api.github.com/users/dwikur21/following{/other_user}","gists_url":"https://api.github.com/users/dwikur21/gists{/gist_id}","starred_url":"https://api.github.com/users/dwikur21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwikur21/subscriptions","organizations_url":"https://api.github.com/users/dwikur21/orgs","repos_url":"https://api.github.com/users/dwikur21/repos","events_url":"https://api.github.com/users/dwikur21/events{/privacy}","received_events_url":"https://api.github.com/users/dwikur21/received_events","type":"User","site_admin":false},"repo":{"id":213334423,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMzMzQ0MjM=","name":"mollie-api-go","full_name":"dwikur21/mollie-api-go","private":false,"owner":{"login":"dwikur21","id":26384044,"node_id":"MDQ6VXNlcjI2Mzg0MDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/26384044?v=4","gravatar_id":"","url":"https://api.github.com/users/dwikur21","html_url":"https://github.com/dwikur21","followers_url":"https://api.github.com/users/dwikur21/followers","following_url":"https://api.github.com/users/dwikur21/following{/other_user}","gists_url":"https://api.github.com/users/dwikur21/gists{/gist_id}","starred_url":"https://api.github.com/users/dwikur21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwikur21/subscriptions","organizations_url":"https://api.github.com/users/dwikur21/orgs","repos_url":"https://api.github.com/users/dwikur21/repos","events_url":"https://api.github.com/users/dwikur21/events{/privacy}","received_events_url":"https://api.github.com/users/dwikur21/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dwikur21/mollie-api-go","description":"Mollie API client for Golang (WIP)","fork":true,"url":"https://api.github.com/repos/dwikur21/mollie-api-go","forks_url":"https://api.github.com/repos/dwikur21/mollie-api-go/forks","keys_url":"https://api.github.com/repos/dwikur21/mollie-api-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwikur21/mollie-api-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwikur21/mollie-api-go/teams","hooks_url":"https://api.github.com/repos/dwikur21/mollie-api-go/hooks","issue_events_url":"https://api.github.com/repos/dwikur21/mollie-api-go/issues/events{/number}","events_url":"https://api.github.com/repos/dwikur21/mollie-api-go/events","assignees_url":"https://api.github.com/repos/dwikur21/mollie-api-go/assignees{/user}","branches_url":"https://api.github.com/repos/dwikur21/mollie-api-go/branches{/branch}","tags_url":"https://api.github.com/repos/dwikur21/mollie-api-go/tags","blobs_url":"https://api.github.com/repos/dwikur21/mollie-api-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwikur21/mollie-api-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwikur21/mollie-api-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwikur21/mollie-api-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwikur21/mollie-api-go/statuses/{sha}","languages_url":"https://api.github.com/repos/dwikur21/mollie-api-go/languages","stargazers_url":"https://api.github.com/repos/dwikur21/mollie-api-go/stargazers","contributors_url":"https://api.github.com/repos/dwikur21/mollie-api-go/contributors","subscribers_url":"https://api.github.com/repos/dwikur21/mollie-api-go/subscribers","subscription_url":"https://api.github.com/repos/dwikur21/mollie-api-go/subscription","commits_url":"https://api.github.com/repos/dwikur21/mollie-api-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwikur21/mollie-api-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwikur21/mollie-api-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwikur21/mollie-api-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwikur21/mollie-api-go/contents/{+path}","compare_url":"https://api.github.com/repos/dwikur21/mollie-api-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwikur21/mollie-api-go/merges","archive_url":"https://api.github.com/repos/dwikur21/mollie-api-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwikur21/mollie-api-go/downloads","issues_url":"https://api.github.com/repos/dwikur21/mollie-api-go/issues{/number}","pulls_url":"https://api.github.com/repos/dwikur21/mollie-api-go/pulls{/number}","milestones_url":"https://api.github.com/repos/dwikur21/mollie-api-go/milestones{/number}","notifications_url":"https://api.github.com/repos/dwikur21/mollie-api-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwikur21/mollie-api-go/labels{/name}","releases_url":"https://api.github.com/repos/dwikur21/mollie-api-go/releases{/id}","deployments_url":"https://api.github.com/repos/dwikur21/mollie-api-go/deployments","created_at":"2019-10-07T08:43:50Z","updated_at":"2019-11-02T05:53:10Z","pushed_at":"2019-11-08T08:59:52Z","git_url":"git://github.com/dwikur21/mollie-api-go.git","ssh_url":"git@github.com:dwikur21/mollie-api-go.git","clone_url":"https://github.com/dwikur21/mollie-api-go.git","svn_url":"https://github.com/dwikur21/mollie-api-go","homepage":"http://www.mollie.com","size":176,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VictorAvelar:master","ref":"master","sha":"6b85db55a644c3dcb763a39e6858fb50a798ed92","user":{"login":"VictorAvelar","id":7926849,"node_id":"MDQ6VXNlcjc5MjY4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7926849?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorAvelar","html_url":"https://github.com/VictorAvelar","followers_url":"https://api.github.com/users/VictorAvelar/followers","following_url":"https://api.github.com/users/VictorAvelar/following{/other_user}","gists_url":"https://api.github.com/users/VictorAvelar/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorAvelar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorAvelar/subscriptions","organizations_url":"https://api.github.com/users/VictorAvelar/orgs","repos_url":"https://api.github.com/users/VictorAvelar/repos","events_url":"https://api.github.com/users/VictorAvelar/events{/privacy}","received_events_url":"https://api.github.com/users/VictorAvelar/received_events","type":"User","site_admin":false},"repo":{"id":204290796,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQyOTA3OTY=","name":"mollie-api-go","full_name":"VictorAvelar/mollie-api-go","private":false,"owner":{"login":"VictorAvelar","id":7926849,"node_id":"MDQ6VXNlcjc5MjY4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7926849?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorAvelar","html_url":"https://github.com/VictorAvelar","followers_url":"https://api.github.com/users/VictorAvelar/followers","following_url":"https://api.github.com/users/VictorAvelar/following{/other_user}","gists_url":"https://api.github.com/users/VictorAvelar/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorAvelar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorAvelar/subscriptions","organizations_url":"https://api.github.com/users/VictorAvelar/orgs","repos_url":"https://api.github.com/users/VictorAvelar/repos","events_url":"https://api.github.com/users/VictorAvelar/events{/privacy}","received_events_url":"https://api.github.com/users/VictorAvelar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VictorAvelar/mollie-api-go","description":"Golang wrapper for Mollie's REST API with full resource coverage.","fork":false,"url":"https://api.github.com/repos/VictorAvelar/mollie-api-go","forks_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/forks","keys_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/teams","hooks_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/hooks","issue_events_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues/events{/number}","events_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/events","assignees_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/assignees{/user}","branches_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/branches{/branch}","tags_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/tags","blobs_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/statuses/{sha}","languages_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/languages","stargazers_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/stargazers","contributors_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/contributors","subscribers_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/subscribers","subscription_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/subscription","commits_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/contents/{+path}","compare_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/merges","archive_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/downloads","issues_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues{/number}","pulls_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls{/number}","milestones_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/milestones{/number}","notifications_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/labels{/name}","releases_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/releases{/id}","deployments_url":"https://api.github.com/repos/VictorAvelar/mollie-api-go/deployments","created_at":"2019-08-25T12:25:30Z","updated_at":"2019-11-01T18:03:48Z","pushed_at":"2019-11-01T18:02:50Z","git_url":"git://github.com/VictorAvelar/mollie-api-go.git","ssh_url":"git@github.com:VictorAvelar/mollie-api-go.git","clone_url":"https://github.com/VictorAvelar/mollie-api-go.git","svn_url":"https://github.com/VictorAvelar/mollie-api-go","homepage":"http://www.mollie.com","size":176,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/44"},"html":{"href":"https://github.com/VictorAvelar/mollie-api-go/pull/44"},"issue":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues/44"},"comments":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/VictorAvelar/mollie-api-go/statuses/10cfbb2e75f70a7f8f97f92a75d48bec79d47383"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":25,"deletions":17,"changed_files":3}}
{"actor":{"display_login":"dwikur21"}}