{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/substrate/pulls/comments/286941359","pull_request_review_id":241200691,"id":286941359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Njk0MTM1OQ==","diff_hunk":"@@ -589,8 +589,8 @@ decl_module! {\n \t\t\t}\n \n \t\t\torigin_contract.storage_size -= key_values_taken.iter()\n-\t\t\t\t.map(|(_, value)| value.len() as u64)\n-\t\t\t\t.sum::<u64>();\n+\t\t\t\t.map(|(_, value)| value.len() as u32)\n+\t\t\t\t.sum::<u32>();","path":"srml/contract/src/lib.rs","position":157,"original_position":16,"commit_id":"78a4b5e894574fad55e34dba5cade00874b4f9af","original_commit_id":"34321a46ed81c1dd1ca3c30ca7079327a76f386f","user":{"login":"thiolliere","id":10416848,"node_id":"MDQ6VXNlcjEwNDE2ODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10416848?v=4","gravatar_id":"","url":"https://api.github.com/users/thiolliere","html_url":"https://github.com/thiolliere","followers_url":"https://api.github.com/users/thiolliere/followers","following_url":"https://api.github.com/users/thiolliere/following{/other_user}","gists_url":"https://api.github.com/users/thiolliere/gists{/gist_id}","starred_url":"https://api.github.com/users/thiolliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiolliere/subscriptions","organizations_url":"https://api.github.com/users/thiolliere/orgs","repos_url":"https://api.github.com/users/thiolliere/repos","events_url":"https://api.github.com/users/thiolliere/events{/privacy}","received_events_url":"https://api.github.com/users/thiolliere/received_events","type":"User","site_admin":false},"body":"probably better to change to u64 again for storage_size as it won't exceed 2^64 soon :-)","created_at":"2019-05-23T13:27:16Z","updated_at":"2019-05-23T13:27:17Z","html_url":"https://github.com/paritytech/substrate/pull/2502#discussion_r286941359","pull_request_url":"https://api.github.com/repos/paritytech/substrate/pulls/2502","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/comments/286941359"},"html":{"href":"https://github.com/paritytech/substrate/pull/2502#discussion_r286941359"},"pull_request":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/2502"}},"in_reply_to_id":286932741},"pull_request":{"url":"https://api.github.com/repos/paritytech/substrate/pulls/2502","id":276895144,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2ODk1MTQ0","html_url":"https://github.com/paritytech/substrate/pull/2502","diff_url":"https://github.com/paritytech/substrate/pull/2502.diff","patch_url":"https://github.com/paritytech/substrate/pull/2502.patch","issue_url":"https://api.github.com/repos/paritytech/substrate/issues/2502","number":2502,"state":"closed","locked":false,"title":"Contract restoration","user":{"login":"thiolliere","id":10416848,"node_id":"MDQ6VXNlcjEwNDE2ODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/10416848?v=4","gravatar_id":"","url":"https://api.github.com/users/thiolliere","html_url":"https://github.com/thiolliere","followers_url":"https://api.github.com/users/thiolliere/followers","following_url":"https://api.github.com/users/thiolliere/following{/other_user}","gists_url":"https://api.github.com/users/thiolliere/gists{/gist_id}","starred_url":"https://api.github.com/users/thiolliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiolliere/subscriptions","organizations_url":"https://api.github.com/users/thiolliere/orgs","repos_url":"https://api.github.com/users/thiolliere/repos","events_url":"https://api.github.com/users/thiolliere/events{/privacy}","received_events_url":"https://api.github.com/users/thiolliere/received_events","type":"User","site_admin":false},"body":"https://github.com/paritytech/substrate/issues/1883\r\n\r\nDone:\r\n* tombstone doesn't use storage size anymore\r\n* contract info now has last_write\r\n* we only compute_storage_root if last_write is not current block to avoid expansive operation\r\n\r\n* test restoration failing because storage don't match\r\n* test restoration failing because storage is dirty\r\n* test restoration success\r\n* TestExternalities has been improved and now make us eof InMemory backend and StorageOverlay.\r\n  at least some modification were needed for having child storage root computed correctly\r\n* restoration call","created_at":"2019-05-08T08:06:10Z","updated_at":"2019-05-23T13:27:17Z","closed_at":"2019-05-23T13:09:17Z","merged_at":"2019-05-23T13:09:17Z","merge_commit_sha":"6d38263434aba843585c7dc8744fc89703be90b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":746560607,"node_id":"MDU6TGFiZWw3NDY1NjA2MDc=","url":"https://api.github.com/repos/paritytech/substrate/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false},{"id":1184370747,"node_id":"MDU6TGFiZWwxMTg0MzcwNzQ3","url":"https://api.github.com/repos/paritytech/substrate/labels/B2-breaksapi","name":"B2-breaksapi","color":"f9f2f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/substrate/pulls/2502/commits","review_comments_url":"https://api.github.com/repos/paritytech/substrate/pulls/2502/comments","review_comment_url":"https://api.github.com/repos/paritytech/substrate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/substrate/issues/2502/comments","statuses_url":"https://api.github.com/repos/paritytech/substrate/statuses/78a4b5e894574fad55e34dba5cade00874b4f9af","head":{"label":"paritytech:gui-restoration","ref":"gui-restoration","sha":"78a4b5e894574fad55e34dba5cade00874b4f9af","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"substrate","full_name":"paritytech/substrate","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/substrate","description":"Substrate: The platform for blockchain innovators","fork":false,"url":"https://api.github.com/repos/paritytech/substrate","forks_url":"https://api.github.com/repos/paritytech/substrate/forks","keys_url":"https://api.github.com/repos/paritytech/substrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/substrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/substrate/teams","hooks_url":"https://api.github.com/repos/paritytech/substrate/hooks","issue_events_url":"https://api.github.com/repos/paritytech/substrate/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/substrate/events","assignees_url":"https://api.github.com/repos/paritytech/substrate/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/substrate/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/substrate/tags","blobs_url":"https://api.github.com/repos/paritytech/substrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/substrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/substrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/substrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/substrate/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/substrate/languages","stargazers_url":"https://api.github.com/repos/paritytech/substrate/stargazers","contributors_url":"https://api.github.com/repos/paritytech/substrate/contributors","subscribers_url":"https://api.github.com/repos/paritytech/substrate/subscribers","subscription_url":"https://api.github.com/repos/paritytech/substrate/subscription","commits_url":"https://api.github.com/repos/paritytech/substrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/substrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/substrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/substrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/substrate/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/substrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/substrate/merges","archive_url":"https://api.github.com/repos/paritytech/substrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/substrate/downloads","issues_url":"https://api.github.com/repos/paritytech/substrate/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/substrate/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/substrate/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/substrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/substrate/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/substrate/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/substrate/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2019-05-23T13:09:23Z","pushed_at":"2019-05-23T13:11:15Z","git_url":"git://github.com/paritytech/substrate.git","ssh_url":"git@github.com:paritytech/substrate.git","clone_url":"https://github.com/paritytech/substrate.git","svn_url":"https://github.com/paritytech/substrate","homepage":"","size":79725,"stargazers_count":1107,"watchers_count":1107,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":336,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":243,"open_issues":336,"watchers":1107,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"2fcf061bc003789c25aad2d84c5f26f58fa0f431","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"substrate","full_name":"paritytech/substrate","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/substrate","description":"Substrate: The platform for blockchain innovators","fork":false,"url":"https://api.github.com/repos/paritytech/substrate","forks_url":"https://api.github.com/repos/paritytech/substrate/forks","keys_url":"https://api.github.com/repos/paritytech/substrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/substrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/substrate/teams","hooks_url":"https://api.github.com/repos/paritytech/substrate/hooks","issue_events_url":"https://api.github.com/repos/paritytech/substrate/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/substrate/events","assignees_url":"https://api.github.com/repos/paritytech/substrate/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/substrate/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/substrate/tags","blobs_url":"https://api.github.com/repos/paritytech/substrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/substrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/substrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/substrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/substrate/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/substrate/languages","stargazers_url":"https://api.github.com/repos/paritytech/substrate/stargazers","contributors_url":"https://api.github.com/repos/paritytech/substrate/contributors","subscribers_url":"https://api.github.com/repos/paritytech/substrate/subscribers","subscription_url":"https://api.github.com/repos/paritytech/substrate/subscription","commits_url":"https://api.github.com/repos/paritytech/substrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/substrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/substrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/substrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/substrate/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/substrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/substrate/merges","archive_url":"https://api.github.com/repos/paritytech/substrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/substrate/downloads","issues_url":"https://api.github.com/repos/paritytech/substrate/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/substrate/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/substrate/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/substrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/substrate/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/substrate/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/substrate/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2019-05-23T13:09:23Z","pushed_at":"2019-05-23T13:11:15Z","git_url":"git://github.com/paritytech/substrate.git","ssh_url":"git@github.com:paritytech/substrate.git","clone_url":"https://github.com/paritytech/substrate.git","svn_url":"https://github.com/paritytech/substrate","homepage":"","size":79725,"stargazers_count":1107,"watchers_count":1107,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":336,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":243,"open_issues":336,"watchers":1107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/2502"},"html":{"href":"https://github.com/paritytech/substrate/pull/2502"},"issue":{"href":"https://api.github.com/repos/paritytech/substrate/issues/2502"},"comments":{"href":"https://api.github.com/repos/paritytech/substrate/issues/2502/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/2502/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/2502/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/substrate/statuses/78a4b5e894574fad55e34dba5cade00874b4f9af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thiolliere"}}