{"action":"created","comment":{"url":"https://api.github.com/repos/demisto/content/pulls/comments/355161913","pull_request_review_id":327405041,"id":355161913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTE2MTkxMw==","diff_hunk":"@@ -56,18 +63,73 @@ def get_cases(self, status: Optional[str] = None, case_type: Optional[str] = Non\n             Response JSON as dictionary\n         \"\"\"\n         suffix: str = f'/cases/{query_type}' if query_type else '/cases'\n-        params = {\n+        params: Dict = {\n             'status': status,\n             'type': case_type,\n-            'maxRecords': int(max_records),\n             'offset': int(offset),\n-            'dateField': date_field,\n-            'dateBegin': begin_date,\n-            'dateEnd': end_date\n+            'maxRecords': int(max_records)\n         }\n-        return self._http_request('GET',\n-                                  url_suffix=suffix,\n-                                  params=assign_params(**params))\n+        raw_response: Dict = self._http_request('GET',\n+                                                url_suffix=suffix,\n+                                                params=assign_params(**params),\n+                                                timeout=20)\n+        cases_temp: List = raw_response.get('data', [])\n+\n+        format_time = \"%Y-%m-%dT%H:%M:%SZ\"\n+        last_time: datetime = None if not cases_temp else datetime.strptime(cases_temp[0].get(date_field), format_time)\n+        end_date_obj: datetime = datetime.strptime(end_date, format_time) if end_date else datetime.now()\n+        begin_date_obj: Optional[datetime] = datetime.strptime(begin_date, format_time) if begin_date else None\n+\n+        index = 0","path":"Integrations/PhishLabsIOC_DRP/PhishLabsIOC_DRP.py","position":83,"original_position":76,"commit_id":"90918deab5f7a6d0740101a6bb18a94078e2283e","original_commit_id":"90918deab5f7a6d0740101a6bb18a94078e2283e","user":{"login":"yaakovi","id":30797606,"node_id":"MDQ6VXNlcjMwNzk3NjA2","avatar_url":"https://avatars1.githubusercontent.com/u/30797606?v=4","gravatar_id":"","url":"https://api.github.com/users/yaakovi","html_url":"https://github.com/yaakovi","followers_url":"https://api.github.com/users/yaakovi/followers","following_url":"https://api.github.com/users/yaakovi/following{/other_user}","gists_url":"https://api.github.com/users/yaakovi/gists{/gist_id}","starred_url":"https://api.github.com/users/yaakovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaakovi/subscriptions","organizations_url":"https://api.github.com/users/yaakovi/orgs","repos_url":"https://api.github.com/users/yaakovi/repos","events_url":"https://api.github.com/users/yaakovi/events{/privacy}","received_events_url":"https://api.github.com/users/yaakovi/received_events","type":"User","site_admin":false},"body":"split the filtering code to another functions by logical units","created_at":"2019-12-08T05:44:49Z","updated_at":"2019-12-08T05:50:29Z","html_url":"https://github.com/demisto/content/pull/4836#discussion_r355161913","pull_request_url":"https://api.github.com/repos/demisto/content/pulls/4836","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/demisto/content/pulls/comments/355161913"},"html":{"href":"https://github.com/demisto/content/pull/4836#discussion_r355161913"},"pull_request":{"href":"https://api.github.com/repos/demisto/content/pulls/4836"}}},"pull_request":{"url":"https://api.github.com/repos/demisto/content/pulls/4836","id":339154705,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MTU0NzA1","html_url":"https://github.com/demisto/content/pull/4836","diff_url":"https://github.com/demisto/content/pull/4836.diff","patch_url":"https://github.com/demisto/content/pull/4836.patch","issue_url":"https://api.github.com/repos/demisto/content/issues/4836","number":4836,"state":"open","locked":false,"title":"Phishlabs drp","user":{"login":"GalRabin","id":53563021,"node_id":"MDQ6VXNlcjUzNTYzMDIx","avatar_url":"https://avatars3.githubusercontent.com/u/53563021?v=4","gravatar_id":"","url":"https://api.github.com/users/GalRabin","html_url":"https://github.com/GalRabin","followers_url":"https://api.github.com/users/GalRabin/followers","following_url":"https://api.github.com/users/GalRabin/following{/other_user}","gists_url":"https://api.github.com/users/GalRabin/gists{/gist_id}","starred_url":"https://api.github.com/users/GalRabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GalRabin/subscriptions","organizations_url":"https://api.github.com/users/GalRabin/orgs","repos_url":"https://api.github.com/users/GalRabin/repos","events_url":"https://api.github.com/users/GalRabin/events{/privacy}","received_events_url":"https://api.github.com/users/GalRabin/received_events","type":"User","site_admin":false},"body":"## Status\r\nIn Progress\r\n\r\n## Related Issues\r\nfixes: https://github.com/demisto/etc/issues/19788\r\n\r\n## Description\r\nPartial implementation for DRP service of PhishLabs\r\n\r\n## Required version of Demisto\r\nx.x.x\r\n\r\n## Does it break backward compatibility?\r\n   - No\r\n\r\n## Must have\r\n- [ ] Tests\r\n- [ ] Documentation (with link to it)\r\n- [ ] Code Review\r\n\r\n## Technical writer review\r\nMention and link to the files that require a technical writer review.\r\n- [ ] [YAML file](link)\r\n- [ ] [CHANGELOG](link)","created_at":"2019-11-10T14:16:19Z","updated_at":"2019-12-08T05:50:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d040b30ce8911fee71cc773c2ccc9d3eb3e719d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/demisto/content/pulls/4836/commits","review_comments_url":"https://api.github.com/repos/demisto/content/pulls/4836/comments","review_comment_url":"https://api.github.com/repos/demisto/content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/demisto/content/issues/4836/comments","statuses_url":"https://api.github.com/repos/demisto/content/statuses/90918deab5f7a6d0740101a6bb18a94078e2283e","head":{"label":"demisto:phishlabs-drp","ref":"phishlabs-drp","sha":"90918deab5f7a6d0740101a6bb18a94078e2283e","user":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"repo":{"id":60525392,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUyNTM5Mg==","name":"content","full_name":"demisto/content","private":false,"owner":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/demisto/content","description":"This repository contains all Demisto content and from here we share content updates","fork":false,"url":"https://api.github.com/repos/demisto/content","forks_url":"https://api.github.com/repos/demisto/content/forks","keys_url":"https://api.github.com/repos/demisto/content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/demisto/content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/demisto/content/teams","hooks_url":"https://api.github.com/repos/demisto/content/hooks","issue_events_url":"https://api.github.com/repos/demisto/content/issues/events{/number}","events_url":"https://api.github.com/repos/demisto/content/events","assignees_url":"https://api.github.com/repos/demisto/content/assignees{/user}","branches_url":"https://api.github.com/repos/demisto/content/branches{/branch}","tags_url":"https://api.github.com/repos/demisto/content/tags","blobs_url":"https://api.github.com/repos/demisto/content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/demisto/content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/demisto/content/git/refs{/sha}","trees_url":"https://api.github.com/repos/demisto/content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/demisto/content/statuses/{sha}","languages_url":"https://api.github.com/repos/demisto/content/languages","stargazers_url":"https://api.github.com/repos/demisto/content/stargazers","contributors_url":"https://api.github.com/repos/demisto/content/contributors","subscribers_url":"https://api.github.com/repos/demisto/content/subscribers","subscription_url":"https://api.github.com/repos/demisto/content/subscription","commits_url":"https://api.github.com/repos/demisto/content/commits{/sha}","git_commits_url":"https://api.github.com/repos/demisto/content/git/commits{/sha}","comments_url":"https://api.github.com/repos/demisto/content/comments{/number}","issue_comment_url":"https://api.github.com/repos/demisto/content/issues/comments{/number}","contents_url":"https://api.github.com/repos/demisto/content/contents/{+path}","compare_url":"https://api.github.com/repos/demisto/content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/demisto/content/merges","archive_url":"https://api.github.com/repos/demisto/content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/demisto/content/downloads","issues_url":"https://api.github.com/repos/demisto/content/issues{/number}","pulls_url":"https://api.github.com/repos/demisto/content/pulls{/number}","milestones_url":"https://api.github.com/repos/demisto/content/milestones{/number}","notifications_url":"https://api.github.com/repos/demisto/content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/demisto/content/labels{/name}","releases_url":"https://api.github.com/repos/demisto/content/releases{/id}","deployments_url":"https://api.github.com/repos/demisto/content/deployments","created_at":"2016-06-06T12:17:02Z","updated_at":"2019-12-05T17:47:21Z","pushed_at":"2019-12-08T00:45:08Z","git_url":"git://github.com/demisto/content.git","ssh_url":"git@github.com:demisto/content.git","clone_url":"https://github.com/demisto/content.git","svn_url":"https://github.com/demisto/content","homepage":"","size":113724,"stargazers_count":326,"watchers_count":326,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":80,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":219,"open_issues":80,"watchers":326,"default_branch":"master"}},"base":{"label":"demisto:master","ref":"master","sha":"e44170f378724f3301592de7fed81545d35729ec","user":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"repo":{"id":60525392,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUyNTM5Mg==","name":"content","full_name":"demisto/content","private":false,"owner":{"login":"demisto","id":11011767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDExNzY3","avatar_url":"https://avatars1.githubusercontent.com/u/11011767?v=4","gravatar_id":"","url":"https://api.github.com/users/demisto","html_url":"https://github.com/demisto","followers_url":"https://api.github.com/users/demisto/followers","following_url":"https://api.github.com/users/demisto/following{/other_user}","gists_url":"https://api.github.com/users/demisto/gists{/gist_id}","starred_url":"https://api.github.com/users/demisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demisto/subscriptions","organizations_url":"https://api.github.com/users/demisto/orgs","repos_url":"https://api.github.com/users/demisto/repos","events_url":"https://api.github.com/users/demisto/events{/privacy}","received_events_url":"https://api.github.com/users/demisto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/demisto/content","description":"This repository contains all Demisto content and from here we share content updates","fork":false,"url":"https://api.github.com/repos/demisto/content","forks_url":"https://api.github.com/repos/demisto/content/forks","keys_url":"https://api.github.com/repos/demisto/content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/demisto/content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/demisto/content/teams","hooks_url":"https://api.github.com/repos/demisto/content/hooks","issue_events_url":"https://api.github.com/repos/demisto/content/issues/events{/number}","events_url":"https://api.github.com/repos/demisto/content/events","assignees_url":"https://api.github.com/repos/demisto/content/assignees{/user}","branches_url":"https://api.github.com/repos/demisto/content/branches{/branch}","tags_url":"https://api.github.com/repos/demisto/content/tags","blobs_url":"https://api.github.com/repos/demisto/content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/demisto/content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/demisto/content/git/refs{/sha}","trees_url":"https://api.github.com/repos/demisto/content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/demisto/content/statuses/{sha}","languages_url":"https://api.github.com/repos/demisto/content/languages","stargazers_url":"https://api.github.com/repos/demisto/content/stargazers","contributors_url":"https://api.github.com/repos/demisto/content/contributors","subscribers_url":"https://api.github.com/repos/demisto/content/subscribers","subscription_url":"https://api.github.com/repos/demisto/content/subscription","commits_url":"https://api.github.com/repos/demisto/content/commits{/sha}","git_commits_url":"https://api.github.com/repos/demisto/content/git/commits{/sha}","comments_url":"https://api.github.com/repos/demisto/content/comments{/number}","issue_comment_url":"https://api.github.com/repos/demisto/content/issues/comments{/number}","contents_url":"https://api.github.com/repos/demisto/content/contents/{+path}","compare_url":"https://api.github.com/repos/demisto/content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/demisto/content/merges","archive_url":"https://api.github.com/repos/demisto/content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/demisto/content/downloads","issues_url":"https://api.github.com/repos/demisto/content/issues{/number}","pulls_url":"https://api.github.com/repos/demisto/content/pulls{/number}","milestones_url":"https://api.github.com/repos/demisto/content/milestones{/number}","notifications_url":"https://api.github.com/repos/demisto/content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/demisto/content/labels{/name}","releases_url":"https://api.github.com/repos/demisto/content/releases{/id}","deployments_url":"https://api.github.com/repos/demisto/content/deployments","created_at":"2016-06-06T12:17:02Z","updated_at":"2019-12-05T17:47:21Z","pushed_at":"2019-12-08T00:45:08Z","git_url":"git://github.com/demisto/content.git","ssh_url":"git@github.com:demisto/content.git","clone_url":"https://github.com/demisto/content.git","svn_url":"https://github.com/demisto/content","homepage":"","size":113724,"stargazers_count":326,"watchers_count":326,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":80,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":219,"open_issues":80,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/demisto/content/pulls/4836"},"html":{"href":"https://github.com/demisto/content/pull/4836"},"issue":{"href":"https://api.github.com/repos/demisto/content/issues/4836"},"comments":{"href":"https://api.github.com/repos/demisto/content/issues/4836/comments"},"review_comments":{"href":"https://api.github.com/repos/demisto/content/pulls/4836/comments"},"review_comment":{"href":"https://api.github.com/repos/demisto/content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/demisto/content/pulls/4836/commits"},"statuses":{"href":"https://api.github.com/repos/demisto/content/statuses/90918deab5f7a6d0740101a6bb18a94078e2283e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yaakovi"}}