{"action":"created","comment":{"url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/comments/293926017","pull_request_review_id":250056795,"id":293926017,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzkyNjAxNw==","diff_hunk":"@@ -0,0 +1,119 @@\n+defmodule Valkyrie.TopicPerDatasetTest do\n+  require Logger\n+\n+  use ExUnit.Case\n+  use Divo\n+\n+  alias SmartCity.TestDataGenerator, as: TDG\n+\n+  @endpoints Application.get_env(:valkyrie, :brod_brokers)\n+  @elsa_endpoints Application.get_env(:valkyrie, :elsa_brokers)\n+\n+  import Record, only: [defrecord: 2, extract: 2]","path":"test/integration/topic_per_dataset_test.exs","position":12,"original_position":12,"commit_id":"73d8297c3babc449f018ccf0421b7d806aadc988","original_commit_id":"73d8297c3babc449f018ccf0421b7d806aadc988","user":{"login":"jakeprem","id":10181938,"node_id":"MDQ6VXNlcjEwMTgxOTM4","avatar_url":"https://avatars3.githubusercontent.com/u/10181938?v=4","gravatar_id":"","url":"https://api.github.com/users/jakeprem","html_url":"https://github.com/jakeprem","followers_url":"https://api.github.com/users/jakeprem/followers","following_url":"https://api.github.com/users/jakeprem/following{/other_user}","gists_url":"https://api.github.com/users/jakeprem/gists{/gist_id}","starred_url":"https://api.github.com/users/jakeprem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakeprem/subscriptions","organizations_url":"https://api.github.com/users/jakeprem/orgs","repos_url":"https://api.github.com/users/jakeprem/repos","events_url":"https://api.github.com/users/jakeprem/events{/privacy}","received_events_url":"https://api.github.com/users/jakeprem/received_events","type":"User","site_admin":false},"body":"They are because something in this test is accessing the Record.\r\n\r\nI agree that this abstraction should be handled by Elsa, but at this point we just adapted what's in Forklift & Voltron","created_at":"2019-06-14T18:25:30Z","updated_at":"2019-06-14T18:25:30Z","html_url":"https://github.com/smartcitiesdata/valkyrie/pull/43#discussion_r293926017","pull_request_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/comments/293926017"},"html":{"href":"https://github.com/smartcitiesdata/valkyrie/pull/43#discussion_r293926017"},"pull_request":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43"}},"in_reply_to_id":293923187},"pull_request":{"url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43","id":288426078,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NDI2MDc4","html_url":"https://github.com/smartcitiesdata/valkyrie/pull/43","diff_url":"https://github.com/smartcitiesdata/valkyrie/pull/43.diff","patch_url":"https://github.com/smartcitiesdata/valkyrie/pull/43.patch","issue_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/43","number":43,"state":"open","locked":false,"title":"Migrate Valkyrie to read from and create a topic per dataset","user":{"login":"jakeprem","id":10181938,"node_id":"MDQ6VXNlcjEwMTgxOTM4","avatar_url":"https://avatars3.githubusercontent.com/u/10181938?v=4","gravatar_id":"","url":"https://api.github.com/users/jakeprem","html_url":"https://github.com/jakeprem","followers_url":"https://api.github.com/users/jakeprem/followers","following_url":"https://api.github.com/users/jakeprem/following{/other_user}","gists_url":"https://api.github.com/users/jakeprem/gists{/gist_id}","starred_url":"https://api.github.com/users/jakeprem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakeprem/subscriptions","organizations_url":"https://api.github.com/users/jakeprem/orgs","repos_url":"https://api.github.com/users/jakeprem/repos","events_url":"https://api.github.com/users/jakeprem/events{/privacy}","received_events_url":"https://api.github.com/users/jakeprem/received_events","type":"User","site_admin":false},"body":"Co-authored-by: Cameron Marsh <cmarsh@pillartechnology.com>","created_at":"2019-06-14T17:55:04Z","updated_at":"2019-06-14T18:25:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcb0c5e1edbd7307fb6f4d7488421c38a640631","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43/commits","review_comments_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43/comments","review_comment_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/43/comments","statuses_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/statuses/73d8297c3babc449f018ccf0421b7d806aadc988","head":{"label":"smartcitiesdata:consumer_from_dataset_topics","ref":"consumer_from_dataset_topics","sha":"73d8297c3babc449f018ccf0421b7d806aadc988","user":{"login":"smartcitiesdata","id":50330003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzMwMDAz","avatar_url":"https://avatars2.githubusercontent.com/u/50330003?v=4","gravatar_id":"","url":"https://api.github.com/users/smartcitiesdata","html_url":"https://github.com/smartcitiesdata","followers_url":"https://api.github.com/users/smartcitiesdata/followers","following_url":"https://api.github.com/users/smartcitiesdata/following{/other_user}","gists_url":"https://api.github.com/users/smartcitiesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcitiesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcitiesdata/subscriptions","organizations_url":"https://api.github.com/users/smartcitiesdata/orgs","repos_url":"https://api.github.com/users/smartcitiesdata/repos","events_url":"https://api.github.com/users/smartcitiesdata/events{/privacy}","received_events_url":"https://api.github.com/users/smartcitiesdata/received_events","type":"Organization","site_admin":false},"repo":{"id":171343964,"node_id":"MDEwOlJlcG9zaXRvcnkxNzEzNDM5NjQ=","name":"valkyrie","full_name":"smartcitiesdata/valkyrie","private":false,"owner":{"login":"smartcitiesdata","id":50330003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzMwMDAz","avatar_url":"https://avatars2.githubusercontent.com/u/50330003?v=4","gravatar_id":"","url":"https://api.github.com/users/smartcitiesdata","html_url":"https://github.com/smartcitiesdata","followers_url":"https://api.github.com/users/smartcitiesdata/followers","following_url":"https://api.github.com/users/smartcitiesdata/following{/other_user}","gists_url":"https://api.github.com/users/smartcitiesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcitiesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcitiesdata/subscriptions","organizations_url":"https://api.github.com/users/smartcitiesdata/orgs","repos_url":"https://api.github.com/users/smartcitiesdata/repos","events_url":"https://api.github.com/users/smartcitiesdata/events{/privacy}","received_events_url":"https://api.github.com/users/smartcitiesdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartcitiesdata/valkyrie","description":"Validate data messages in the data pipeline","fork":false,"url":"https://api.github.com/repos/smartcitiesdata/valkyrie","forks_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/forks","keys_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/teams","hooks_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/hooks","issue_events_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/events{/number}","events_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/events","assignees_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/assignees{/user}","branches_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/branches{/branch}","tags_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/tags","blobs_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/statuses/{sha}","languages_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/languages","stargazers_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/stargazers","contributors_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/contributors","subscribers_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/subscribers","subscription_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/subscription","commits_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/contents/{+path}","compare_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/merges","archive_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/downloads","issues_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues{/number}","pulls_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls{/number}","milestones_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/milestones{/number}","notifications_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/labels{/name}","releases_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/releases{/id}","deployments_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/deployments","created_at":"2019-02-18T19:32:34Z","updated_at":"2019-06-07T19:05:27Z","pushed_at":"2019-06-14T17:55:05Z","git_url":"git://github.com/smartcitiesdata/valkyrie.git","ssh_url":"git@github.com:smartcitiesdata/valkyrie.git","clone_url":"https://github.com/smartcitiesdata/valkyrie.git","svn_url":"https://github.com/smartcitiesdata/valkyrie","homepage":"","size":117,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"smartcitiesdata:master","ref":"master","sha":"5f0b8d5abaf4f6df4122ab97215007bd41cdcae6","user":{"login":"smartcitiesdata","id":50330003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzMwMDAz","avatar_url":"https://avatars2.githubusercontent.com/u/50330003?v=4","gravatar_id":"","url":"https://api.github.com/users/smartcitiesdata","html_url":"https://github.com/smartcitiesdata","followers_url":"https://api.github.com/users/smartcitiesdata/followers","following_url":"https://api.github.com/users/smartcitiesdata/following{/other_user}","gists_url":"https://api.github.com/users/smartcitiesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcitiesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcitiesdata/subscriptions","organizations_url":"https://api.github.com/users/smartcitiesdata/orgs","repos_url":"https://api.github.com/users/smartcitiesdata/repos","events_url":"https://api.github.com/users/smartcitiesdata/events{/privacy}","received_events_url":"https://api.github.com/users/smartcitiesdata/received_events","type":"Organization","site_admin":false},"repo":{"id":171343964,"node_id":"MDEwOlJlcG9zaXRvcnkxNzEzNDM5NjQ=","name":"valkyrie","full_name":"smartcitiesdata/valkyrie","private":false,"owner":{"login":"smartcitiesdata","id":50330003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzMwMDAz","avatar_url":"https://avatars2.githubusercontent.com/u/50330003?v=4","gravatar_id":"","url":"https://api.github.com/users/smartcitiesdata","html_url":"https://github.com/smartcitiesdata","followers_url":"https://api.github.com/users/smartcitiesdata/followers","following_url":"https://api.github.com/users/smartcitiesdata/following{/other_user}","gists_url":"https://api.github.com/users/smartcitiesdata/gists{/gist_id}","starred_url":"https://api.github.com/users/smartcitiesdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartcitiesdata/subscriptions","organizations_url":"https://api.github.com/users/smartcitiesdata/orgs","repos_url":"https://api.github.com/users/smartcitiesdata/repos","events_url":"https://api.github.com/users/smartcitiesdata/events{/privacy}","received_events_url":"https://api.github.com/users/smartcitiesdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartcitiesdata/valkyrie","description":"Validate data messages in the data pipeline","fork":false,"url":"https://api.github.com/repos/smartcitiesdata/valkyrie","forks_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/forks","keys_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/teams","hooks_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/hooks","issue_events_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/events{/number}","events_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/events","assignees_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/assignees{/user}","branches_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/branches{/branch}","tags_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/tags","blobs_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/statuses/{sha}","languages_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/languages","stargazers_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/stargazers","contributors_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/contributors","subscribers_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/subscribers","subscription_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/subscription","commits_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/contents/{+path}","compare_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/merges","archive_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/downloads","issues_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues{/number}","pulls_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls{/number}","milestones_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/milestones{/number}","notifications_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/labels{/name}","releases_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/releases{/id}","deployments_url":"https://api.github.com/repos/smartcitiesdata/valkyrie/deployments","created_at":"2019-02-18T19:32:34Z","updated_at":"2019-06-07T19:05:27Z","pushed_at":"2019-06-14T17:55:05Z","git_url":"git://github.com/smartcitiesdata/valkyrie.git","ssh_url":"git@github.com:smartcitiesdata/valkyrie.git","clone_url":"https://github.com/smartcitiesdata/valkyrie.git","svn_url":"https://github.com/smartcitiesdata/valkyrie","homepage":"","size":117,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43"},"html":{"href":"https://github.com/smartcitiesdata/valkyrie/pull/43"},"issue":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/43"},"comments":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/smartcitiesdata/valkyrie/statuses/73d8297c3babc449f018ccf0421b7d806aadc988"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jakeprem"}}