{"action":"created","comment":{"url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments/288771672","pull_request_review_id":243521128,"id":288771672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODc3MTY3Mg==","diff_hunk":"@@ -528,4 +535,39 @@ public static Range getElementDeclMissingContentOrCategory(int offset, DOMDocume\n \t\treturn null;\r\n \t}\r\n \r\n+\tpublic static boolean doesTagCoverPosition(Range startTagRange, Range endTagRange, Position position) {\r\n+\t\treturn startTagRange != null && covers(startTagRange, position)\r\n+\t\t\t\t|| endTagRange != null && covers(endTagRange, position);\r\n+\t}\r\n+\r\n+\tpublic static boolean covers(Range range, Position position) {\r","path":"org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/utils/XMLPositionUtility.java","position":37,"original_position":37,"commit_id":"8fc1179ae1f44a708d2fd142b573e14a016d1564","original_commit_id":"8fc1179ae1f44a708d2fd142b573e14a016d1564","user":{"login":"angelozerr","id":1932211,"node_id":"MDQ6VXNlcjE5MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1932211?v=4","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"body":"Please add javadoc","created_at":"2019-05-29T21:14:31Z","updated_at":"2019-05-29T21:14:31Z","html_url":"https://github.com/angelozerr/lsp4xml/pull/403#discussion_r288771672","pull_request_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments/288771672"},"html":{"href":"https://github.com/angelozerr/lsp4xml/pull/403#discussion_r288771672"},"pull_request":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403","id":283379730,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzMzc5NzMw","html_url":"https://github.com/angelozerr/lsp4xml/pull/403","diff_url":"https://github.com/angelozerr/lsp4xml/pull/403.diff","patch_url":"https://github.com/angelozerr/lsp4xml/pull/403.patch","issue_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/403","number":403,"state":"open","locked":false,"title":"Improved namespace renaming for XML/XSD","user":{"login":"NikolasKomonen","id":32624665,"node_id":"MDQ6VXNlcjMyNjI0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/32624665?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolasKomonen","html_url":"https://github.com/NikolasKomonen","followers_url":"https://api.github.com/users/NikolasKomonen/followers","following_url":"https://api.github.com/users/NikolasKomonen/following{/other_user}","gists_url":"https://api.github.com/users/NikolasKomonen/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolasKomonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolasKomonen/subscriptions","organizations_url":"https://api.github.com/users/NikolasKomonen/orgs","repos_url":"https://api.github.com/users/NikolasKomonen/repos","events_url":"https://api.github.com/users/NikolasKomonen/events{/privacy}","received_events_url":"https://api.github.com/users/NikolasKomonen/received_events","type":"User","site_admin":false},"body":"Fixes #366\r\n\r\nCan rename namespace declaration and all will change, renaming element with namespace does not wipe\r\nnamespace, attribute values referencing a namespace will update if necessary","created_at":"2019-05-29T18:26:44Z","updated_at":"2019-05-29T21:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d48ea5b27892f2ed45e316e2e348e7b1b28438d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403/commits","review_comments_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403/comments","review_comment_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/403/comments","statuses_url":"https://api.github.com/repos/angelozerr/lsp4xml/statuses/8fc1179ae1f44a708d2fd142b573e14a016d1564","head":{"label":"NikolasKomonen:renameNamespace","ref":"renameNamespace","sha":"8fc1179ae1f44a708d2fd142b573e14a016d1564","user":{"login":"NikolasKomonen","id":32624665,"node_id":"MDQ6VXNlcjMyNjI0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/32624665?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolasKomonen","html_url":"https://github.com/NikolasKomonen","followers_url":"https://api.github.com/users/NikolasKomonen/followers","following_url":"https://api.github.com/users/NikolasKomonen/following{/other_user}","gists_url":"https://api.github.com/users/NikolasKomonen/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolasKomonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolasKomonen/subscriptions","organizations_url":"https://api.github.com/users/NikolasKomonen/orgs","repos_url":"https://api.github.com/users/NikolasKomonen/repos","events_url":"https://api.github.com/users/NikolasKomonen/events{/privacy}","received_events_url":"https://api.github.com/users/NikolasKomonen/received_events","type":"User","site_admin":false},"repo":{"id":138757816,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3NTc4MTY=","name":"lsp4xml","full_name":"NikolasKomonen/lsp4xml","private":false,"owner":{"login":"NikolasKomonen","id":32624665,"node_id":"MDQ6VXNlcjMyNjI0NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/32624665?v=4","gravatar_id":"","url":"https://api.github.com/users/NikolasKomonen","html_url":"https://github.com/NikolasKomonen","followers_url":"https://api.github.com/users/NikolasKomonen/followers","following_url":"https://api.github.com/users/NikolasKomonen/following{/other_user}","gists_url":"https://api.github.com/users/NikolasKomonen/gists{/gist_id}","starred_url":"https://api.github.com/users/NikolasKomonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikolasKomonen/subscriptions","organizations_url":"https://api.github.com/users/NikolasKomonen/orgs","repos_url":"https://api.github.com/users/NikolasKomonen/repos","events_url":"https://api.github.com/users/NikolasKomonen/events{/privacy}","received_events_url":"https://api.github.com/users/NikolasKomonen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NikolasKomonen/lsp4xml","description":"XML Language Server","fork":true,"url":"https://api.github.com/repos/NikolasKomonen/lsp4xml","forks_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/forks","keys_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/teams","hooks_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/hooks","issue_events_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/issues/events{/number}","events_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/events","assignees_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/assignees{/user}","branches_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/branches{/branch}","tags_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/tags","blobs_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/refs{/sha}","trees_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/statuses/{sha}","languages_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/languages","stargazers_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/stargazers","contributors_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/contributors","subscribers_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/subscribers","subscription_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/subscription","commits_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/commits{/sha}","git_commits_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/git/commits{/sha}","comments_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/comments{/number}","issue_comment_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/issues/comments{/number}","contents_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/contents/{+path}","compare_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/merges","archive_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/downloads","issues_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/issues{/number}","pulls_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/pulls{/number}","milestones_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/milestones{/number}","notifications_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/labels{/name}","releases_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/releases{/id}","deployments_url":"https://api.github.com/repos/NikolasKomonen/lsp4xml/deployments","created_at":"2018-06-26T15:29:29Z","updated_at":"2019-04-16T22:24:49Z","pushed_at":"2019-05-29T21:10:53Z","git_url":"git://github.com/NikolasKomonen/lsp4xml.git","ssh_url":"git@github.com:NikolasKomonen/lsp4xml.git","clone_url":"https://github.com/NikolasKomonen/lsp4xml.git","svn_url":"https://github.com/NikolasKomonen/lsp4xml","homepage":null,"size":7868,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angelozerr:master","ref":"master","sha":"f9d525324d3ae2fbae28e879147e04ff475d330a","user":{"login":"angelozerr","id":1932211,"node_id":"MDQ6VXNlcjE5MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1932211?v=4","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"repo":{"id":138315669,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMTU2Njk=","name":"lsp4xml","full_name":"angelozerr/lsp4xml","private":false,"owner":{"login":"angelozerr","id":1932211,"node_id":"MDQ6VXNlcjE5MzIyMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1932211?v=4","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/angelozerr/lsp4xml","description":"XML Language Server","fork":false,"url":"https://api.github.com/repos/angelozerr/lsp4xml","forks_url":"https://api.github.com/repos/angelozerr/lsp4xml/forks","keys_url":"https://api.github.com/repos/angelozerr/lsp4xml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angelozerr/lsp4xml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angelozerr/lsp4xml/teams","hooks_url":"https://api.github.com/repos/angelozerr/lsp4xml/hooks","issue_events_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/events{/number}","events_url":"https://api.github.com/repos/angelozerr/lsp4xml/events","assignees_url":"https://api.github.com/repos/angelozerr/lsp4xml/assignees{/user}","branches_url":"https://api.github.com/repos/angelozerr/lsp4xml/branches{/branch}","tags_url":"https://api.github.com/repos/angelozerr/lsp4xml/tags","blobs_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/refs{/sha}","trees_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angelozerr/lsp4xml/statuses/{sha}","languages_url":"https://api.github.com/repos/angelozerr/lsp4xml/languages","stargazers_url":"https://api.github.com/repos/angelozerr/lsp4xml/stargazers","contributors_url":"https://api.github.com/repos/angelozerr/lsp4xml/contributors","subscribers_url":"https://api.github.com/repos/angelozerr/lsp4xml/subscribers","subscription_url":"https://api.github.com/repos/angelozerr/lsp4xml/subscription","commits_url":"https://api.github.com/repos/angelozerr/lsp4xml/commits{/sha}","git_commits_url":"https://api.github.com/repos/angelozerr/lsp4xml/git/commits{/sha}","comments_url":"https://api.github.com/repos/angelozerr/lsp4xml/comments{/number}","issue_comment_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues/comments{/number}","contents_url":"https://api.github.com/repos/angelozerr/lsp4xml/contents/{+path}","compare_url":"https://api.github.com/repos/angelozerr/lsp4xml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angelozerr/lsp4xml/merges","archive_url":"https://api.github.com/repos/angelozerr/lsp4xml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angelozerr/lsp4xml/downloads","issues_url":"https://api.github.com/repos/angelozerr/lsp4xml/issues{/number}","pulls_url":"https://api.github.com/repos/angelozerr/lsp4xml/pulls{/number}","milestones_url":"https://api.github.com/repos/angelozerr/lsp4xml/milestones{/number}","notifications_url":"https://api.github.com/repos/angelozerr/lsp4xml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angelozerr/lsp4xml/labels{/name}","releases_url":"https://api.github.com/repos/angelozerr/lsp4xml/releases{/id}","deployments_url":"https://api.github.com/repos/angelozerr/lsp4xml/deployments","created_at":"2018-06-22T15:00:18Z","updated_at":"2019-05-29T18:57:02Z","pushed_at":"2019-05-29T21:12:46Z","git_url":"git://github.com/angelozerr/lsp4xml.git","ssh_url":"git@github.com:angelozerr/lsp4xml.git","clone_url":"https://github.com/angelozerr/lsp4xml.git","svn_url":"https://github.com/angelozerr/lsp4xml","homepage":null,"size":7837,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":19,"open_issues":76,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403"},"html":{"href":"https://github.com/angelozerr/lsp4xml/pull/403"},"issue":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/issues/403"},"comments":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/angelozerr/lsp4xml/statuses/8fc1179ae1f44a708d2fd142b573e14a016d1564"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"angelozerr"}}