{"action":"created","issue":{"url":"https://api.github.com/repos/raven-os/feathers/issues/127","repository_url":"https://api.github.com/repos/raven-os/feathers","labels_url":"https://api.github.com/repos/raven-os/feathers/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/raven-os/feathers/issues/127/comments","events_url":"https://api.github.com/repos/raven-os/feathers/issues/127/events","html_url":"https://github.com/raven-os/feathers/pull/127","id":512412048,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNDI2ODg0","number":127,"title":"Added popup handling for popups and layer shell surfaces","user":{"login":"Gaspard--","id":8182392,"node_id":"MDQ6VXNlcjgxODIzOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8182392?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaspard--","html_url":"https://github.com/Gaspard--","followers_url":"https://api.github.com/users/Gaspard--/followers","following_url":"https://api.github.com/users/Gaspard--/following{/other_user}","gists_url":"https://api.github.com/users/Gaspard--/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaspard--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaspard--/subscriptions","organizations_url":"https://api.github.com/users/Gaspard--/orgs","repos_url":"https://api.github.com/users/Gaspard--/repos","events_url":"https://api.github.com/users/Gaspard--/events{/privacy}","received_events_url":"https://api.github.com/users/Gaspard--/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-10-25T09:39:19Z","updated_at":"2019-11-10T15:17:51Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/raven-os/feathers/pulls/127","html_url":"https://github.com/raven-os/feathers/pull/127","diff_url":"https://github.com/raven-os/feathers/pull/127.diff","patch_url":"https://github.com/raven-os/feathers/pull/127.patch"},"body":"Need to test this before merging."},"comment":{"url":"https://api.github.com/repos/raven-os/feathers/issues/comments/552203803","html_url":"https://github.com/raven-os/feathers/pull/127#issuecomment-552203803","issue_url":"https://api.github.com/repos/raven-os/feathers/issues/127","id":552203803,"node_id":"MDEyOklzc3VlQ29tbWVudDU1MjIwMzgwMw==","user":{"login":"Gaspard--","id":8182392,"node_id":"MDQ6VXNlcjgxODIzOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8182392?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaspard--","html_url":"https://github.com/Gaspard--","followers_url":"https://api.github.com/users/Gaspard--/followers","following_url":"https://api.github.com/users/Gaspard--/following{/other_user}","gists_url":"https://api.github.com/users/Gaspard--/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaspard--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaspard--/subscriptions","organizations_url":"https://api.github.com/users/Gaspard--/orgs","repos_url":"https://api.github.com/users/Gaspard--/repos","events_url":"https://api.github.com/users/Gaspard--/events{/privacy}","received_events_url":"https://api.github.com/users/Gaspard--/received_events","type":"User","site_admin":false},"created_at":"2019-11-10T15:17:51Z","updated_at":"2019-11-10T15:17:51Z","author_association":"MEMBER","body":"Couple of comments to help review:\r\n- to simplify things a bit, added a `getFocusedView` in server.\r\n- getFocusedSurface is similar to getFocusedView, but also takes other surfaces into account, not only desktop views.\r\n- View::view_at likewise checks layer & xdg views\r\n- XdgView::desktop_view_at is not really used yet, but only checks desktop views. (I think we'll probably need it when cleaning multiple output handling)\r\nYou will often see the pattern where I check a range of layers, then the desktop and then sometimes another range of layers. This is because ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY and ZWLR_LAYER_SHELL_V1_LAYER_TOP are above desktop surfaces, and the 2 others below."}}
{"actor":{"display_login":"Gaspard--"}}