{"action":"created","comment":{"url":"https://api.github.com/repos/sinonjs/samsam/pulls/comments/293422788","pull_request_review_id":249405905,"id":293422788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzQyMjc4OA==","diff_hunk":"@@ -152,6 +153,23 @@ function deepEqualCyclic(actual, expectation, match) {\n             return isSubset(actualObj, expectationObj, deepEqual);\n         }\n \n+        if (isMap(actualObj) || isMap(expectationObj)) {\n+            if (\n+                !isMap(actualObj) ||\n+                !isMap(expectationObj) ||\n+                actualObj.size !== expectationObj.size\n+            ) {\n+                return false;\n+            }\n+\n+            return Array.from(actualObj.keys()).every(function(key) {","path":"lib/deep-equal.js","position":null,"original_position":21,"commit_id":"6f06cdfd64a30d44ca2e2ccff1f5c2d657ded97b","original_commit_id":"26f1cd2955e24b51107c81d444d5fb9bc0f1a30c","user":{"login":"mroderick","id":20321,"node_id":"MDQ6VXNlcjIwMzIx","avatar_url":"https://avatars2.githubusercontent.com/u/20321?v=4","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"body":"Pushed a commit to do this","created_at":"2019-06-13T14:54:19Z","updated_at":"2019-06-13T14:54:19Z","html_url":"https://github.com/sinonjs/samsam/pull/69#discussion_r293422788","pull_request_url":"https://api.github.com/repos/sinonjs/samsam/pulls/69","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sinonjs/samsam/pulls/comments/293422788"},"html":{"href":"https://github.com/sinonjs/samsam/pull/69#discussion_r293422788"},"pull_request":{"href":"https://api.github.com/repos/sinonjs/samsam/pulls/69"}},"in_reply_to_id":293095679},"pull_request":{"url":"https://api.github.com/repos/sinonjs/samsam/pulls/69","id":287541140,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3NTQxMTQw","html_url":"https://github.com/sinonjs/samsam/pull/69","diff_url":"https://github.com/sinonjs/samsam/pull/69.diff","patch_url":"https://github.com/sinonjs/samsam/pull/69.patch","issue_url":"https://api.github.com/repos/sinonjs/samsam/issues/69","number":69,"state":"open","locked":false,"title":"Fix #67: Add support for Map","user":{"login":"mroderick","id":20321,"node_id":"MDQ6VXNlcjIwMzIx","avatar_url":"https://avatars2.githubusercontent.com/u/20321?v=4","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"body":"This PR fixes #67, where using deepEqual on non-equal `Map`  instances would return `true`\r\n\r\n#### Checklist for author\r\n\r\n- [x] `npm run lint` passes\r\n- [x] References to standard library functions are [cached](https://github.com/sinonjs/sinon/pull/1523).\r\n","created_at":"2019-06-12T14:42:01Z","updated_at":"2019-06-13T14:54:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10838d30508a71bdfb805eb6e0559909a0916a3b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fatso83","id":618076,"node_id":"MDQ6VXNlcjYxODA3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/samsam/pulls/69/commits","review_comments_url":"https://api.github.com/repos/sinonjs/samsam/pulls/69/comments","review_comment_url":"https://api.github.com/repos/sinonjs/samsam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/samsam/issues/69/comments","statuses_url":"https://api.github.com/repos/sinonjs/samsam/statuses/6f06cdfd64a30d44ca2e2ccff1f5c2d657ded97b","head":{"label":"mroderick:issue-67","ref":"issue-67","sha":"6f06cdfd64a30d44ca2e2ccff1f5c2d657ded97b","user":{"login":"mroderick","id":20321,"node_id":"MDQ6VXNlcjIwMzIx","avatar_url":"https://avatars2.githubusercontent.com/u/20321?v=4","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"repo":{"id":39121479,"node_id":"MDEwOlJlcG9zaXRvcnkzOTEyMTQ3OQ==","name":"samsam","full_name":"mroderick/samsam","private":false,"owner":{"login":"mroderick","id":20321,"node_id":"MDQ6VXNlcjIwMzIx","avatar_url":"https://avatars2.githubusercontent.com/u/20321?v=4","gravatar_id":"","url":"https://api.github.com/users/mroderick","html_url":"https://github.com/mroderick","followers_url":"https://api.github.com/users/mroderick/followers","following_url":"https://api.github.com/users/mroderick/following{/other_user}","gists_url":"https://api.github.com/users/mroderick/gists{/gist_id}","starred_url":"https://api.github.com/users/mroderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroderick/subscriptions","organizations_url":"https://api.github.com/users/mroderick/orgs","repos_url":"https://api.github.com/users/mroderick/repos","events_url":"https://api.github.com/users/mroderick/events{/privacy}","received_events_url":"https://api.github.com/users/mroderick/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mroderick/samsam","description":"Value identification and comparison functions","fork":true,"url":"https://api.github.com/repos/mroderick/samsam","forks_url":"https://api.github.com/repos/mroderick/samsam/forks","keys_url":"https://api.github.com/repos/mroderick/samsam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroderick/samsam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroderick/samsam/teams","hooks_url":"https://api.github.com/repos/mroderick/samsam/hooks","issue_events_url":"https://api.github.com/repos/mroderick/samsam/issues/events{/number}","events_url":"https://api.github.com/repos/mroderick/samsam/events","assignees_url":"https://api.github.com/repos/mroderick/samsam/assignees{/user}","branches_url":"https://api.github.com/repos/mroderick/samsam/branches{/branch}","tags_url":"https://api.github.com/repos/mroderick/samsam/tags","blobs_url":"https://api.github.com/repos/mroderick/samsam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroderick/samsam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroderick/samsam/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroderick/samsam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroderick/samsam/statuses/{sha}","languages_url":"https://api.github.com/repos/mroderick/samsam/languages","stargazers_url":"https://api.github.com/repos/mroderick/samsam/stargazers","contributors_url":"https://api.github.com/repos/mroderick/samsam/contributors","subscribers_url":"https://api.github.com/repos/mroderick/samsam/subscribers","subscription_url":"https://api.github.com/repos/mroderick/samsam/subscription","commits_url":"https://api.github.com/repos/mroderick/samsam/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroderick/samsam/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroderick/samsam/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroderick/samsam/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroderick/samsam/contents/{+path}","compare_url":"https://api.github.com/repos/mroderick/samsam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroderick/samsam/merges","archive_url":"https://api.github.com/repos/mroderick/samsam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroderick/samsam/downloads","issues_url":"https://api.github.com/repos/mroderick/samsam/issues{/number}","pulls_url":"https://api.github.com/repos/mroderick/samsam/pulls{/number}","milestones_url":"https://api.github.com/repos/mroderick/samsam/milestones{/number}","notifications_url":"https://api.github.com/repos/mroderick/samsam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroderick/samsam/labels{/name}","releases_url":"https://api.github.com/repos/mroderick/samsam/releases{/id}","deployments_url":"https://api.github.com/repos/mroderick/samsam/deployments","created_at":"2015-07-15T06:55:30Z","updated_at":"2018-01-26T14:52:58Z","pushed_at":"2019-06-13T14:53:56Z","git_url":"git://github.com/mroderick/samsam.git","ssh_url":"git@github.com:mroderick/samsam.git","clone_url":"https://github.com/mroderick/samsam.git","svn_url":"https://github.com/mroderick/samsam","homepage":null,"size":797,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"c8617141932241bd63f02253b08639a41120dd44","user":{"login":"sinonjs","id":6570253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":5026317,"node_id":"MDEwOlJlcG9zaXRvcnk1MDI2MzE3","name":"samsam","full_name":"sinonjs/samsam","private":false,"owner":{"login":"sinonjs","id":6570253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sinonjs/samsam","description":"Value identification and comparison functions","fork":false,"url":"https://api.github.com/repos/sinonjs/samsam","forks_url":"https://api.github.com/repos/sinonjs/samsam/forks","keys_url":"https://api.github.com/repos/sinonjs/samsam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/samsam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/samsam/teams","hooks_url":"https://api.github.com/repos/sinonjs/samsam/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/samsam/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/samsam/events","assignees_url":"https://api.github.com/repos/sinonjs/samsam/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/samsam/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/samsam/tags","blobs_url":"https://api.github.com/repos/sinonjs/samsam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/samsam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/samsam/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/samsam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/samsam/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/samsam/languages","stargazers_url":"https://api.github.com/repos/sinonjs/samsam/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/samsam/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/samsam/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/samsam/subscription","commits_url":"https://api.github.com/repos/sinonjs/samsam/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/samsam/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/samsam/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/samsam/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/samsam/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/samsam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/samsam/merges","archive_url":"https://api.github.com/repos/sinonjs/samsam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/samsam/downloads","issues_url":"https://api.github.com/repos/sinonjs/samsam/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/samsam/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/samsam/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/samsam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/samsam/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/samsam/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/samsam/deployments","created_at":"2012-07-13T22:04:25Z","updated_at":"2019-06-05T00:36:35Z","pushed_at":"2019-06-13T14:53:57Z","git_url":"git://github.com/sinonjs/samsam.git","ssh_url":"git@github.com:sinonjs/samsam.git","clone_url":"https://github.com/sinonjs/samsam.git","svn_url":"https://github.com/sinonjs/samsam","homepage":"http://sinonjs.github.io/samsam/","size":913,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":4,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/samsam/pulls/69"},"html":{"href":"https://github.com/sinonjs/samsam/pull/69"},"issue":{"href":"https://api.github.com/repos/sinonjs/samsam/issues/69"},"comments":{"href":"https://api.github.com/repos/sinonjs/samsam/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/samsam/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/samsam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/samsam/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/samsam/statuses/6f06cdfd64a30d44ca2e2ccff1f5c2d657ded97b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mroderick"}}