{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/303996927","pull_request_review_id":262528017,"id":303996927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzk5NjkyNw==","diff_hunk":"@@ -36,24 +39,35 @@ cache:\n shallow_clone: true\n \n install:\n-  # We want  protoc.exe on PATH.\n-  - SET PATH=C:/%RIPPLED_DEPS_PATH%;%PATH%\n-\n   # Download dependencies if appveyor didn't restore them from the cache.\n   # Use 7zip to unzip.\n   - ps: |\n-        if (-not(Test-Path 'C:/$env:RIPPLED_DEPS_PATH')) {\n-            echo \"Download from $env:RIPPLED_DEPS_URL\"\n-            Start-FileDownload \"$env:RIPPLED_DEPS_URL\"\n-            7z x \"$($env:RIPPLED_DEPS_PATH).zip\" -oC:\\ -y > $null\n-            if ($LastExitCode -ne 0) { throw \"7z failed\" }\n+        if (-not(Test-Path \"C:/$env:RIPPLED_DEPS_PATH/openssl\")) {\n+            $files = @(\n+              \"$env:RIPPLED_BOOST\",\n+              \"$env:RIPPLED_BOOST_STAGE\",\n+              \"$env:RIPPLED_OPENSSL\"\n+              )\n+            For ($i=0; $i -lt $files.Length; $i++) {\n+                $file = $files[$i]\n+                $url = \"$env:RIPPLED_DEPS_BASE_URL/$file\"\n+                echo \"Download $file from $url\"\n+                Start-FileDownload \"$url\"\n+                7z x \"$file\" -o\"C:\\$env:RIPPLED_DEPS_PATH\" -y > $null\n+                if ($LastExitCode -ne 0) { throw \"7z failed\" }\n+            }\n+        }\n+        else\n+        {\n+            \"Dependencies are in cache\"\n+            ls \"C:/$env:RIPPLED_DEPS_PATH\"\n         }\n \n   # Newer DEPS include a versions file.\n   # Dump it so we can verify correct behavior.\n   - ps: |\n-        if (Test-Path \"C:/$env:RIPPLED_DEPS_PATH/versions.txt\") {\n-          cat \"C:/$env:RIPPLED_DEPS_PATH/versions.txt\"\n+        if (Test-Path \"C:/$env:RIPPLED_DEPS_PATH/version*.txt\") {","path":"appveyor.yml","position":60,"original_position":60,"commit_id":"6dc8f9bebb5feca493a0ce3be06d8724130bd873","original_commit_id":"6dc8f9bebb5feca493a0ce3be06d8724130bd873","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"There's more than one file - one per package. I think I agree that not having any files would be a sign of a problem.","created_at":"2019-07-16T16:09:27Z","updated_at":"2019-07-16T16:09:27Z","html_url":"https://github.com/ripple/rippled/pull/3000#discussion_r303996927","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/3000","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/303996927"},"html":{"href":"https://github.com/ripple/rippled/pull/3000#discussion_r303996927"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/3000"}},"in_reply_to_id":303682082},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/3000","id":297818793,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3ODE4Nzkz","html_url":"https://github.com/ripple/rippled/pull/3000","diff_url":"https://github.com/ripple/rippled/pull/3000.diff","patch_url":"https://github.com/ripple/rippled/pull/3000.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/3000","number":3000,"state":"open","locked":false,"title":"Update appveyor dependencies for boost 1.70","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"body":"Rippled 1.3.* increased the minimum required version of boost to 1.70, but did not include an update to the appveyor config to keep up to date. This resolves that, using the update set of archives in `Downloads`.\r\n\r\nNote that Gitlab CI will fail on this PR because of the boost version. That is fixed in #2999 ","created_at":"2019-07-15T23:11:00Z","updated_at":"2019-07-16T16:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bc1d0d7e1ed33ba8c4618c128c37a20842d78a6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jwbusch","id":9566946,"node_id":"MDQ6VXNlcjk1NjY5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/9566946?v=4","gravatar_id":"","url":"https://api.github.com/users/jwbusch","html_url":"https://github.com/jwbusch","followers_url":"https://api.github.com/users/jwbusch/followers","following_url":"https://api.github.com/users/jwbusch/following{/other_user}","gists_url":"https://api.github.com/users/jwbusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jwbusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwbusch/subscriptions","organizations_url":"https://api.github.com/users/jwbusch/orgs","repos_url":"https://api.github.com/users/jwbusch/repos","events_url":"https://api.github.com/users/jwbusch/events{/privacy}","received_events_url":"https://api.github.com/users/jwbusch/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/3000/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/3000/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/3000/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/6dc8f9bebb5feca493a0ce3be06d8724130bd873","head":{"label":"ximinez:appveyor.1.70","ref":"appveyor.1.70","sha":"6dc8f9bebb5feca493a0ce3be06d8724130bd873","user":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"repo":{"id":17236735,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIzNjczNQ==","name":"rippled","full_name":"ximinez/rippled","private":false,"owner":{"login":"ximinez","id":6757714,"node_id":"MDQ6VXNlcjY3NTc3MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6757714?v=4","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ximinez/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/ximinez/rippled","forks_url":"https://api.github.com/repos/ximinez/rippled/forks","keys_url":"https://api.github.com/repos/ximinez/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ximinez/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ximinez/rippled/teams","hooks_url":"https://api.github.com/repos/ximinez/rippled/hooks","issue_events_url":"https://api.github.com/repos/ximinez/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ximinez/rippled/events","assignees_url":"https://api.github.com/repos/ximinez/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ximinez/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ximinez/rippled/tags","blobs_url":"https://api.github.com/repos/ximinez/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ximinez/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ximinez/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ximinez/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ximinez/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ximinez/rippled/languages","stargazers_url":"https://api.github.com/repos/ximinez/rippled/stargazers","contributors_url":"https://api.github.com/repos/ximinez/rippled/contributors","subscribers_url":"https://api.github.com/repos/ximinez/rippled/subscribers","subscription_url":"https://api.github.com/repos/ximinez/rippled/subscription","commits_url":"https://api.github.com/repos/ximinez/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ximinez/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ximinez/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ximinez/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ximinez/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ximinez/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ximinez/rippled/merges","archive_url":"https://api.github.com/repos/ximinez/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ximinez/rippled/downloads","issues_url":"https://api.github.com/repos/ximinez/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ximinez/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ximinez/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ximinez/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ximinez/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ximinez/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ximinez/rippled/deployments","created_at":"2014-02-27T04:33:56Z","updated_at":"2019-07-11T19:25:45Z","pushed_at":"2019-07-15T23:04:55Z","git_url":"git://github.com/ximinez/rippled.git","ssh_url":"git@github.com:ximinez/rippled.git","clone_url":"https://github.com/ximinez/rippled.git","svn_url":"https://github.com/ximinez/rippled","homepage":"https://ripple.com","size":96364,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"caa5c9e2232ff1eee1d0c61907283649e48e6fbc","user":{"login":"ripple","id":3165523,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjU1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI0MTY3","name":"rippled","full_name":"ripple/rippled","private":false,"owner":{"login":"ripple","id":3165523,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjU1MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2019-07-15T18:01:47Z","pushed_at":"2019-07-16T00:32:29Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com/xrp","size":95903,"stargazers_count":3272,"watchers_count":3272,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":983,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":150,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":983,"open_issues":150,"watchers":3272,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/3000"},"html":{"href":"https://github.com/ripple/rippled/pull/3000"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/3000"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/3000/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/3000/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/3000/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/6dc8f9bebb5feca493a0ce3be06d8724130bd873"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ximinez"}}