{"action":"created","issue":{"url":"https://api.github.com/repos/awslabs/aws-cdk/issues/3003","repository_url":"https://api.github.com/repos/awslabs/aws-cdk","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/3003/labels{/name}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/3003/comments","events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/3003/events","html_url":"https://github.com/awslabs/aws-cdk/pull/3003","id":459379475,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNzUzNTU1","number":3003,"title":"refactor(ecs): changed the launchType to be an enum instead of string…","user":{"login":"hencrice","id":3822365,"node_id":"MDQ6VXNlcjM4MjIzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3822365?v=4","gravatar_id":"","url":"https://api.github.com/users/hencrice","html_url":"https://github.com/hencrice","followers_url":"https://api.github.com/users/hencrice/followers","following_url":"https://api.github.com/users/hencrice/following{/other_user}","gists_url":"https://api.github.com/users/hencrice/gists{/gist_id}","starred_url":"https://api.github.com/users/hencrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hencrice/subscriptions","organizations_url":"https://api.github.com/users/hencrice/orgs","repos_url":"https://api.github.com/users/hencrice/repos","events_url":"https://api.github.com/users/hencrice/events{/privacy}","received_events_url":"https://api.github.com/users/hencrice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-06-21T21:28:58Z","updated_at":"2019-06-21T21:32:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/3003","html_url":"https://github.com/awslabs/aws-cdk/pull/3003","diff_url":"https://github.com/awslabs/aws-cdk/pull/3003.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/3003.patch"},"body":"… constants\r\n\r\nCloses #3002.\r\n\r\n----\r\n\r\n### Pull Request Checklist\r\n\r\n* [x] Testing\r\n  - Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)\r\n  - __CLI change?:__ coordinate update of integration tests with team\r\n  - __cdk-init template change?:__ coordinated update of integration tests with team\r\n* [x] Docs\r\n  - __jsdocs__: All public APIs documented\r\n  - __README__: README and/or documentation topic updated\r\n  - __Design__: For significant features, design document added to `design` folder\r\n* [x] Title and Description\r\n  - __Change type__: title prefixed with **fix**, **feat** and module name in parens, which will appear in changelog\r\n  - __Title__: use lower-case and doesn't end with a period\r\n  - __Breaking?__: last paragraph: \"BREAKING CHANGE: <describe what changed + link for details>\"\r\n  - __Issues__: Indicate issues fixed via: \"**Fixes #xxx**\" or \"**Closes #xxx**\"\r\n* [N/A] Sensitive Modules (requires 2 PR approvers)\r\n  - IAM Policy Document (in @aws-cdk/aws-iam)\r\n  - EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)\r\n  - Grant APIs (only if not based on official documentation with a reference)\r\n\r\n\r\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*\r\n\r\n----\r\n"},"comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments/504579385","html_url":"https://github.com/awslabs/aws-cdk/pull/3003#issuecomment-504579385","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/3003","id":504579385,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNDU3OTM4NQ==","user":{"login":"hencrice","id":3822365,"node_id":"MDQ6VXNlcjM4MjIzNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3822365?v=4","gravatar_id":"","url":"https://api.github.com/users/hencrice","html_url":"https://github.com/hencrice","followers_url":"https://api.github.com/users/hencrice/followers","following_url":"https://api.github.com/users/hencrice/following{/other_user}","gists_url":"https://api.github.com/users/hencrice/gists{/gist_id}","starred_url":"https://api.github.com/users/hencrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hencrice/subscriptions","organizations_url":"https://api.github.com/users/hencrice/orgs","repos_url":"https://api.github.com/users/hencrice/repos","events_url":"https://api.github.com/users/hencrice/events{/privacy}","received_events_url":"https://api.github.com/users/hencrice/received_events","type":"User","site_admin":false},"created_at":"2019-06-21T21:32:04Z","updated_at":"2019-06-21T21:32:04Z","author_association":"CONTRIBUTOR","body":"I tried to enforce the type of the `launchType` field to be the newly defined enum type. However, since it's one of the field in [`additionalProps`](https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-ecs/lib/base/base-service.ts#L137), I could not do so."}}
{"actor":{"display_login":"hencrice"}}