{"action":"created","issue":{"url":"https://api.github.com/repos/Yelp/Tron/issues/654","repository_url":"https://api.github.com/repos/Yelp/Tron","labels_url":"https://api.github.com/repos/Yelp/Tron/issues/654/labels{/name}","comments_url":"https://api.github.com/repos/Yelp/Tron/issues/654/comments","events_url":"https://api.github.com/repos/Yelp/Tron/issues/654/events","html_url":"https://github.com/Yelp/Tron/pull/654","id":437864811,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MDUyMDIz","number":654,"title":"removed mirror store","user":{"login":"EmanekaT","id":25218586,"node_id":"MDQ6VXNlcjI1MjE4NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/25218586?v=4","gravatar_id":"","url":"https://api.github.com/users/EmanekaT","html_url":"https://github.com/EmanekaT","followers_url":"https://api.github.com/users/EmanekaT/followers","following_url":"https://api.github.com/users/EmanekaT/following{/other_user}","gists_url":"https://api.github.com/users/EmanekaT/gists{/gist_id}","starred_url":"https://api.github.com/users/EmanekaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmanekaT/subscriptions","organizations_url":"https://api.github.com/users/EmanekaT/orgs","repos_url":"https://api.github.com/users/EmanekaT/repos","events_url":"https://api.github.com/users/EmanekaT/events{/privacy}","received_events_url":"https://api.github.com/users/EmanekaT/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-04-26T22:16:46Z","updated_at":"2019-05-04T00:00:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Yelp/Tron/pulls/654","html_url":"https://github.com/Yelp/Tron/pull/654","diff_url":"https://github.com/Yelp/Tron/pull/654.diff","patch_url":"https://github.com/Yelp/Tron/pull/654.patch"},"body":"I removed mirror_store, and changed all keys in dynamodb_state_store from shelvekey to regular string.\r\nTested with make test. I kept shelvestore there since I don't think we necessarily need to remove it."},"comment":{"url":"https://api.github.com/repos/Yelp/Tron/issues/comments/489273902","html_url":"https://github.com/Yelp/Tron/pull/654#issuecomment-489273902","issue_url":"https://api.github.com/repos/Yelp/Tron/issues/654","id":489273902,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4OTI3MzkwMg==","user":{"login":"EmanekaT","id":25218586,"node_id":"MDQ6VXNlcjI1MjE4NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/25218586?v=4","gravatar_id":"","url":"https://api.github.com/users/EmanekaT","html_url":"https://github.com/EmanekaT","followers_url":"https://api.github.com/users/EmanekaT/followers","following_url":"https://api.github.com/users/EmanekaT/following{/other_user}","gists_url":"https://api.github.com/users/EmanekaT/gists{/gist_id}","starred_url":"https://api.github.com/users/EmanekaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmanekaT/subscriptions","organizations_url":"https://api.github.com/users/EmanekaT/orgs","repos_url":"https://api.github.com/users/EmanekaT/repos","events_url":"https://api.github.com/users/EmanekaT/events{/privacy}","received_events_url":"https://api.github.com/users/EmanekaT/received_events","type":"User","site_admin":false},"created_at":"2019-05-04T00:00:39Z","updated_at":"2019-05-04T00:00:39Z","author_association":"CONTRIBUTOR","body":"Changes:\r\n* updated __setitem__ to use transact_write_items. Writing items with more than 10 partitions is still not atomic because transact_write_items could only handle up to 10 items at once. We only have one job with around 13 partitions across all clusters right now so this is probably not a big deal.\r\n* updated __get_items_ so that it fails after retrying 10 times and throws an exception \r\n*  transact_write_items/batch_get_items do not retry after failure, so I implemented retrying myself. \r\n* updated alerts to include different error messages for different failures. It still only emails me until it is thoroughly tested.\r\n* Upgraded requirements using requirements_tools because transact_write_items is only available in the latest version \r\n* using new version of boto3 with moto might cause an error on travis. I might need to resolve it. \r\n\r\n "}}
{"actor":{"display_login":"EmanekaT"}}