{"action":"created","comment":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/350330584","pull_request_review_id":322464131,"id":350330584,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDMzMDU4NA==","diff_hunk":"@@ -18,7 +17,7 @@ interface KInterface2 : KInterface  {\n // +\n // 0 INVOKESTATIC KInterface2.access\\$test2\\$jd\n // =\n-// 1 INVOKESTATIC\n+// 1 INVOKESTATIC KInterface","path":"compiler/testData/codegen/bytecodeText/jvm8/jvmDefault/compatibility/simpleFunctionWithAbstractOverride.kt","position":11,"original_position":11,"commit_id":"57969691e0b9a84f1a0a1d540053487d84547277","original_commit_id":"57969691e0b9a84f1a0a1d540053487d84547277","user":{"login":"kandersen","id":1170540,"node_id":"MDQ6VXNlcjExNzA1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1170540?v=4","gravatar_id":"","url":"https://api.github.com/users/kandersen","html_url":"https://github.com/kandersen","followers_url":"https://api.github.com/users/kandersen/followers","following_url":"https://api.github.com/users/kandersen/following{/other_user}","gists_url":"https://api.github.com/users/kandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/kandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kandersen/subscriptions","organizations_url":"https://api.github.com/users/kandersen/orgs","repos_url":"https://api.github.com/users/kandersen/repos","events_url":"https://api.github.com/users/kandersen/events{/privacy}","received_events_url":"https://api.github.com/users/kandersen/received_events","type":"User","site_admin":false},"body":"The test was over-specified: the IR backend produces a nullcheck on `this` in `KInterface$DefaultImpls$test2` which is a static method.","created_at":"2019-11-25T17:46:46Z","updated_at":"2019-11-25T17:46:47Z","html_url":"https://github.com/JetBrains/kotlin/pull/2756#discussion_r350330584","pull_request_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments/350330584"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/2756#discussion_r350330584"},"pull_request":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756"}}},"pull_request":{"url":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756","id":336320953,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2MzIwOTUz","html_url":"https://github.com/JetBrains/kotlin/pull/2756","diff_url":"https://github.com/JetBrains/kotlin/pull/2756.diff","patch_url":"https://github.com/JetBrains/kotlin/pull/2756.patch","issue_url":"https://api.github.com/repos/JetBrains/kotlin/issues/2756","number":2756,"state":"open","locked":false,"title":"[JVM_IR] Fix interface method resolution","user":{"login":"kandersen","id":1170540,"node_id":"MDQ6VXNlcjExNzA1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1170540?v=4","gravatar_id":"","url":"https://api.github.com/users/kandersen","html_url":"https://github.com/kandersen","followers_url":"https://api.github.com/users/kandersen/followers","following_url":"https://api.github.com/users/kandersen/following{/other_user}","gists_url":"https://api.github.com/users/kandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/kandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kandersen/subscriptions","organizations_url":"https://api.github.com/users/kandersen/orgs","repos_url":"https://api.github.com/users/kandersen/repos","events_url":"https://api.github.com/users/kandersen/events{/privacy}","received_events_url":"https://api.github.com/users/kandersen/received_events","type":"User","site_admin":false},"body":"The JVM IR was too agressive in delegating statically to `$DefaultImpls`\r\nclass.\r\n\r\nConsider the following library, compiled separately, and then client,\r\ncompiled against that library:\r\n\r\n```\r\n//library\r\ninterface A { @JvmDefault fun foo() = \"A\" }\r\n\r\ninterface Left : A { }\r\ninterface Right : A { @JvmDefault override fun foo() = \"Right\" }\r\n\r\n//client\r\ninterface C : Left, Right {}\r\n\r\nfun main() {\r\n  val x = object : C {}\r\n  println(x.foo())\r\n}\r\n```\r\n\r\nPreviously, the IR backend generates an overriding bridge in `C`, which\r\ncalls `C$DefaultImpls` which calls statically into `Right$DefaultImpls`.\r\n\r\nWhen then library is recompilerd with an override of foo in Left, the\r\nexisting binary of the client continues to run against the recompiled\r\nlibrary erroneously running `Right.foo()`.\r\n\r\nThe old backend throws an IncompatibleClassChange exception due to\r\nambiguity of multiple inherited default implementations. kotlinc indeed\r\nrejects the client when recompiled against the new library.\r\n\r\nWe have no tests constraining this behaviour, but we could conceivably\r\nstrap something together in CustomBinaries tests.","created_at":"2019-11-04T14:56:09Z","updated_at":"2019-11-25T17:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b993c0886c43a2b1222f5010ee4eed25225b20","assignee":{"login":"max-kammerer","id":1205032,"node_id":"MDQ6VXNlcjEyMDUwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1205032?v=4","gravatar_id":"","url":"https://api.github.com/users/max-kammerer","html_url":"https://github.com/max-kammerer","followers_url":"https://api.github.com/users/max-kammerer/followers","following_url":"https://api.github.com/users/max-kammerer/following{/other_user}","gists_url":"https://api.github.com/users/max-kammerer/gists{/gist_id}","starred_url":"https://api.github.com/users/max-kammerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-kammerer/subscriptions","organizations_url":"https://api.github.com/users/max-kammerer/orgs","repos_url":"https://api.github.com/users/max-kammerer/repos","events_url":"https://api.github.com/users/max-kammerer/events{/privacy}","received_events_url":"https://api.github.com/users/max-kammerer/received_events","type":"User","site_admin":false},"assignees":[{"login":"max-kammerer","id":1205032,"node_id":"MDQ6VXNlcjEyMDUwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1205032?v=4","gravatar_id":"","url":"https://api.github.com/users/max-kammerer","html_url":"https://github.com/max-kammerer","followers_url":"https://api.github.com/users/max-kammerer/followers","following_url":"https://api.github.com/users/max-kammerer/following{/other_user}","gists_url":"https://api.github.com/users/max-kammerer/gists{/gist_id}","starred_url":"https://api.github.com/users/max-kammerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-kammerer/subscriptions","organizations_url":"https://api.github.com/users/max-kammerer/orgs","repos_url":"https://api.github.com/users/max-kammerer/repos","events_url":"https://api.github.com/users/max-kammerer/events{/privacy}","received_events_url":"https://api.github.com/users/max-kammerer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1145076122,"node_id":"MDU6TGFiZWwxMTQ1MDc2MTIy","url":"https://api.github.com/repos/JetBrains/kotlin/labels/Backend","name":"Backend","color":"8E1600","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756/commits","review_comments_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756/comments","review_comment_url":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/issues/2756/comments","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/57969691e0b9a84f1a0a1d540053487d84547277","head":{"label":"kandersen:interface-delegation-fix","ref":"interface-delegation-fix","sha":"57969691e0b9a84f1a0a1d540053487d84547277","user":{"login":"kandersen","id":1170540,"node_id":"MDQ6VXNlcjExNzA1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1170540?v=4","gravatar_id":"","url":"https://api.github.com/users/kandersen","html_url":"https://github.com/kandersen","followers_url":"https://api.github.com/users/kandersen/followers","following_url":"https://api.github.com/users/kandersen/following{/other_user}","gists_url":"https://api.github.com/users/kandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/kandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kandersen/subscriptions","organizations_url":"https://api.github.com/users/kandersen/orgs","repos_url":"https://api.github.com/users/kandersen/repos","events_url":"https://api.github.com/users/kandersen/events{/privacy}","received_events_url":"https://api.github.com/users/kandersen/received_events","type":"User","site_admin":false},"repo":{"id":206306563,"node_id":"MDEwOlJlcG9zaXRvcnkyMDYzMDY1NjM=","name":"kotlin","full_name":"kandersen/kotlin","private":false,"owner":{"login":"kandersen","id":1170540,"node_id":"MDQ6VXNlcjExNzA1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1170540?v=4","gravatar_id":"","url":"https://api.github.com/users/kandersen","html_url":"https://github.com/kandersen","followers_url":"https://api.github.com/users/kandersen/followers","following_url":"https://api.github.com/users/kandersen/following{/other_user}","gists_url":"https://api.github.com/users/kandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/kandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kandersen/subscriptions","organizations_url":"https://api.github.com/users/kandersen/orgs","repos_url":"https://api.github.com/users/kandersen/repos","events_url":"https://api.github.com/users/kandersen/events{/privacy}","received_events_url":"https://api.github.com/users/kandersen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kandersen/kotlin","description":"The Kotlin Programming Language","fork":true,"url":"https://api.github.com/repos/kandersen/kotlin","forks_url":"https://api.github.com/repos/kandersen/kotlin/forks","keys_url":"https://api.github.com/repos/kandersen/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kandersen/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kandersen/kotlin/teams","hooks_url":"https://api.github.com/repos/kandersen/kotlin/hooks","issue_events_url":"https://api.github.com/repos/kandersen/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/kandersen/kotlin/events","assignees_url":"https://api.github.com/repos/kandersen/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/kandersen/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/kandersen/kotlin/tags","blobs_url":"https://api.github.com/repos/kandersen/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kandersen/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kandersen/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kandersen/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kandersen/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/kandersen/kotlin/languages","stargazers_url":"https://api.github.com/repos/kandersen/kotlin/stargazers","contributors_url":"https://api.github.com/repos/kandersen/kotlin/contributors","subscribers_url":"https://api.github.com/repos/kandersen/kotlin/subscribers","subscription_url":"https://api.github.com/repos/kandersen/kotlin/subscription","commits_url":"https://api.github.com/repos/kandersen/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kandersen/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kandersen/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kandersen/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kandersen/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/kandersen/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kandersen/kotlin/merges","archive_url":"https://api.github.com/repos/kandersen/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kandersen/kotlin/downloads","issues_url":"https://api.github.com/repos/kandersen/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/kandersen/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/kandersen/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/kandersen/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kandersen/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/kandersen/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/kandersen/kotlin/deployments","created_at":"2019-09-04T11:46:58Z","updated_at":"2019-11-20T16:02:37Z","pushed_at":"2019-11-25T17:44:52Z","git_url":"git://github.com/kandersen/kotlin.git","ssh_url":"git@github.com:kandersen/kotlin.git","clone_url":"https://github.com/kandersen/kotlin.git","svn_url":"https://github.com/kandersen/kotlin","homepage":"https://kotlinlang.org/","size":602407,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JetBrains:master","ref":"master","sha":"ea8ade0852b81f82c10ff58dcc3b8254c880fcce","user":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"repo":{"id":3432266,"node_id":"MDEwOlJlcG9zaXRvcnkzNDMyMjY2","name":"kotlin","full_name":"JetBrains/kotlin","private":false,"owner":{"login":"JetBrains","id":878437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3ODQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/878437?v=4","gravatar_id":"","url":"https://api.github.com/users/JetBrains","html_url":"https://github.com/JetBrains","followers_url":"https://api.github.com/users/JetBrains/followers","following_url":"https://api.github.com/users/JetBrains/following{/other_user}","gists_url":"https://api.github.com/users/JetBrains/gists{/gist_id}","starred_url":"https://api.github.com/users/JetBrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetBrains/subscriptions","organizations_url":"https://api.github.com/users/JetBrains/orgs","repos_url":"https://api.github.com/users/JetBrains/repos","events_url":"https://api.github.com/users/JetBrains/events{/privacy}","received_events_url":"https://api.github.com/users/JetBrains/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JetBrains/kotlin","description":"The Kotlin Programming Language","fork":false,"url":"https://api.github.com/repos/JetBrains/kotlin","forks_url":"https://api.github.com/repos/JetBrains/kotlin/forks","keys_url":"https://api.github.com/repos/JetBrains/kotlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JetBrains/kotlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JetBrains/kotlin/teams","hooks_url":"https://api.github.com/repos/JetBrains/kotlin/hooks","issue_events_url":"https://api.github.com/repos/JetBrains/kotlin/issues/events{/number}","events_url":"https://api.github.com/repos/JetBrains/kotlin/events","assignees_url":"https://api.github.com/repos/JetBrains/kotlin/assignees{/user}","branches_url":"https://api.github.com/repos/JetBrains/kotlin/branches{/branch}","tags_url":"https://api.github.com/repos/JetBrains/kotlin/tags","blobs_url":"https://api.github.com/repos/JetBrains/kotlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JetBrains/kotlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JetBrains/kotlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JetBrains/kotlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JetBrains/kotlin/statuses/{sha}","languages_url":"https://api.github.com/repos/JetBrains/kotlin/languages","stargazers_url":"https://api.github.com/repos/JetBrains/kotlin/stargazers","contributors_url":"https://api.github.com/repos/JetBrains/kotlin/contributors","subscribers_url":"https://api.github.com/repos/JetBrains/kotlin/subscribers","subscription_url":"https://api.github.com/repos/JetBrains/kotlin/subscription","commits_url":"https://api.github.com/repos/JetBrains/kotlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JetBrains/kotlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JetBrains/kotlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JetBrains/kotlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JetBrains/kotlin/contents/{+path}","compare_url":"https://api.github.com/repos/JetBrains/kotlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JetBrains/kotlin/merges","archive_url":"https://api.github.com/repos/JetBrains/kotlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JetBrains/kotlin/downloads","issues_url":"https://api.github.com/repos/JetBrains/kotlin/issues{/number}","pulls_url":"https://api.github.com/repos/JetBrains/kotlin/pulls{/number}","milestones_url":"https://api.github.com/repos/JetBrains/kotlin/milestones{/number}","notifications_url":"https://api.github.com/repos/JetBrains/kotlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JetBrains/kotlin/labels{/name}","releases_url":"https://api.github.com/repos/JetBrains/kotlin/releases{/id}","deployments_url":"https://api.github.com/repos/JetBrains/kotlin/deployments","created_at":"2012-02-13T17:29:58Z","updated_at":"2019-11-25T17:25:35Z","pushed_at":"2019-11-25T17:44:57Z","git_url":"git://github.com/JetBrains/kotlin.git","ssh_url":"git@github.com:JetBrains/kotlin.git","clone_url":"https://github.com/JetBrains/kotlin.git","svn_url":"https://github.com/JetBrains/kotlin","homepage":"https://kotlinlang.org/","size":610120,"stargazers_count":29788,"watchers_count":29788,"language":"Kotlin","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3543,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":137,"license":null,"forks":3543,"open_issues":137,"watchers":29788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756"},"html":{"href":"https://github.com/JetBrains/kotlin/pull/2756"},"issue":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/2756"},"comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/issues/2756/comments"},"review_comments":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756/comments"},"review_comment":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JetBrains/kotlin/pulls/2756/commits"},"statuses":{"href":"https://api.github.com/repos/JetBrains/kotlin/statuses/57969691e0b9a84f1a0a1d540053487d84547277"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kandersen"}}