{"action":"created","issue":{"url":"https://api.github.com/repos/stellar/js-stellar-base/issues/200","repository_url":"https://api.github.com/repos/stellar/js-stellar-base","labels_url":"https://api.github.com/repos/stellar/js-stellar-base/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/stellar/js-stellar-base/issues/200/comments","events_url":"https://api.github.com/repos/stellar/js-stellar-base/issues/200/events","html_url":"https://github.com/stellar/js-stellar-base/issues/200","id":453743796,"node_id":"MDU6SXNzdWU0NTM3NDM3OTY=","number":200,"title":"manageBuyOffer inconsistent parameter naming","user":{"login":"MisterTicot","id":36534020,"node_id":"MDQ6VXNlcjM2NTM0MDIw","avatar_url":"https://avatars3.githubusercontent.com/u/36534020?v=4","gravatar_id":"","url":"https://api.github.com/users/MisterTicot","html_url":"https://github.com/MisterTicot","followers_url":"https://api.github.com/users/MisterTicot/followers","following_url":"https://api.github.com/users/MisterTicot/following{/other_user}","gists_url":"https://api.github.com/users/MisterTicot/gists{/gist_id}","starred_url":"https://api.github.com/users/MisterTicot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MisterTicot/subscriptions","organizations_url":"https://api.github.com/users/MisterTicot/orgs","repos_url":"https://api.github.com/users/MisterTicot/repos","events_url":"https://api.github.com/users/MisterTicot/events{/privacy}","received_events_url":"https://api.github.com/users/MisterTicot/received_events","type":"User","site_admin":false},"labels":[{"id":195199508,"node_id":"MDU6TGFiZWwxOTUxOTk1MDg=","url":"https://api.github.com/repos/stellar/js-stellar-base/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-06-08T01:49:53Z","updated_at":"2019-09-19T01:27:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In js-stellar-base, [manageBuyOffer](https://stellar.github.io/js-stellar-base/Operation.html#.manageBuyOffer) amount parameter has been named `buyAmount`. \r\n\r\nHowever, in the [stellar.org guide](https://www.stellar.org/developers/guides/concepts/list-of-operations.html#manage-buy-offer) it is referenced as `amount`. Horizon uses `amount` parameter as well when returning the [operation record](https://horizon-testnet.stellar.org/operations/3061014601928705).\r\n\r\nHence, I assume js-stellar-base should use `amount` instead of `buyAmount` for a matter of consistency, which is also more consistent with manageSellOffer & passiveSellOffer amount parameters."},"comment":{"url":"https://api.github.com/repos/stellar/js-stellar-base/issues/comments/532926909","html_url":"https://github.com/stellar/js-stellar-base/issues/200#issuecomment-532926909","issue_url":"https://api.github.com/repos/stellar/js-stellar-base/issues/200","id":532926909,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMjkyNjkwOQ==","user":{"login":"MisterTicot","id":36534020,"node_id":"MDQ6VXNlcjM2NTM0MDIw","avatar_url":"https://avatars3.githubusercontent.com/u/36534020?v=4","gravatar_id":"","url":"https://api.github.com/users/MisterTicot","html_url":"https://github.com/MisterTicot","followers_url":"https://api.github.com/users/MisterTicot/followers","following_url":"https://api.github.com/users/MisterTicot/following{/other_user}","gists_url":"https://api.github.com/users/MisterTicot/gists{/gist_id}","starred_url":"https://api.github.com/users/MisterTicot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MisterTicot/subscriptions","organizations_url":"https://api.github.com/users/MisterTicot/orgs","repos_url":"https://api.github.com/users/MisterTicot/repos","events_url":"https://api.github.com/users/MisterTicot/events{/privacy}","received_events_url":"https://api.github.com/users/MisterTicot/received_events","type":"User","site_admin":false},"created_at":"2019-09-19T01:27:46Z","updated_at":"2019-09-19T01:27:46Z","author_association":"CONTRIBUTOR","body":"The sooner this one is dealt with, the better: the last thing we want is inconsistent naming to accumulate over time."}}
{"actor":{"display_login":"MisterTicot"}}