{"action":"created","comment":{"url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/comments/344168283","pull_request_review_id":314192926,"id":344168283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDE2ODI4Mw==","diff_hunk":"@@ -0,0 +1,78 @@\n+pragma solidity 0.4.24;\n+\n+import \"./HomeBridgeNativeToErc.sol\";\n+import \"../RelativeExecutionDailyLimit.sol\";\n+\n+contract HomeBridgeNativeToErcRelativeDailyLimit is HomeBridgeNativeToErc, RelativeExecutionDailyLimit {\n+    function executeAffirmation(address recipient, uint256 value, bytes32 transactionHash) public onlyValidator {\n+        _updateTodayLimit();\n+        super.executeAffirmation(recipient, value, transactionHash);\n+    }\n+\n+    function initialize(\n+        address _validatorContract,\n+        uint256[] _requestLimitsArray, // [ 0 = _dailyLimit, 1 = _maxPerTx, 2 = _minPerTx ]\n+        uint256 _homeGasPrice,\n+        uint256 _requiredBlockConfirmations,\n+        uint256[] _executionLimitsArray, // [ 0 = _targetLimit, 1 = _tthreshold, 2 = _foreignMaxPerTx, 3 = _foreignMinPerTx ]","path":"contracts/upgradeable_contracts/native_to_erc20/HomeBridgeNativeToErcRelativeDailyLimit.sol","position":17,"original_position":17,"commit_id":"d7834d09177b42075bf549d270d5de5e9cd23a1f","original_commit_id":"d7834d09177b42075bf549d270d5de5e9cd23a1f","user":{"login":"patitonar","id":4614574,"node_id":"MDQ6VXNlcjQ2MTQ1NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4614574?v=4","gravatar_id":"","url":"https://api.github.com/users/patitonar","html_url":"https://github.com/patitonar","followers_url":"https://api.github.com/users/patitonar/followers","following_url":"https://api.github.com/users/patitonar/following{/other_user}","gists_url":"https://api.github.com/users/patitonar/gists{/gist_id}","starred_url":"https://api.github.com/users/patitonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patitonar/subscriptions","organizations_url":"https://api.github.com/users/patitonar/orgs","repos_url":"https://api.github.com/users/patitonar/repos","events_url":"https://api.github.com/users/patitonar/events{/privacy}","received_events_url":"https://api.github.com/users/patitonar/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n        uint256[] _executionLimitsArray, // [ 0 = _targetLimit, 1 = _threshold, 2 = _foreignMaxPerTx, 3 = _foreignMinPerTx ]\r\n```","created_at":"2019-11-08T13:17:13Z","updated_at":"2019-11-08T13:17:13Z","html_url":"https://github.com/poanetwork/tokenbridge-contracts/pull/306#discussion_r344168283","pull_request_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/comments/344168283"},"html":{"href":"https://github.com/poanetwork/tokenbridge-contracts/pull/306#discussion_r344168283"},"pull_request":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306","id":327818279,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3ODE4Mjc5","html_url":"https://github.com/poanetwork/tokenbridge-contracts/pull/306","diff_url":"https://github.com/poanetwork/tokenbridge-contracts/pull/306.diff","patch_url":"https://github.com/poanetwork/tokenbridge-contracts/pull/306.patch","issue_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/306","number":306,"state":"open","locked":false,"title":"Relative daily limit","user":{"login":"maxaleks","id":13244928,"node_id":"MDQ6VXNlcjEzMjQ0OTI4","avatar_url":"https://avatars0.githubusercontent.com/u/13244928?v=4","gravatar_id":"","url":"https://api.github.com/users/maxaleks","html_url":"https://github.com/maxaleks","followers_url":"https://api.github.com/users/maxaleks/followers","following_url":"https://api.github.com/users/maxaleks/following{/other_user}","gists_url":"https://api.github.com/users/maxaleks/gists{/gist_id}","starred_url":"https://api.github.com/users/maxaleks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxaleks/subscriptions","organizations_url":"https://api.github.com/users/maxaleks/orgs","repos_url":"https://api.github.com/users/maxaleks/repos","events_url":"https://api.github.com/users/maxaleks/events{/privacy}","received_events_url":"https://api.github.com/users/maxaleks/received_events","type":"User","site_admin":false},"body":"These changes are adding the ability to use a relative daily limit for withdrawals","created_at":"2019-10-14T14:05:02Z","updated_at":"2019-11-08T13:17:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b056f9ecf89fd9100af67f542044a9e8d1d64cd6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306/commits","review_comments_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306/comments","review_comment_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/306/comments","statuses_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/statuses/d7834d09177b42075bf549d270d5de5e9cd23a1f","head":{"label":"poanetwork:relative-daily-limit","ref":"relative-daily-limit","sha":"d7834d09177b42075bf549d270d5de5e9cd23a1f","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":121341498,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzNDE0OTg=","name":"tokenbridge-contracts","full_name":"poanetwork/tokenbridge-contracts","private":false,"owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poanetwork/tokenbridge-contracts","description":"Smart contracts for TokenBridge","fork":false,"url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts","forks_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/forks","keys_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/teams","hooks_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/events","assignees_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/tags","blobs_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/languages","stargazers_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/subscription","commits_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/merges","archive_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/downloads","issues_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/deployments","created_at":"2018-02-13T05:10:29Z","updated_at":"2019-11-08T05:50:38Z","pushed_at":"2019-11-07T22:44:20Z","git_url":"git://github.com/poanetwork/tokenbridge-contracts.git","ssh_url":"git@github.com:poanetwork/tokenbridge-contracts.git","clone_url":"https://github.com/poanetwork/tokenbridge-contracts.git","svn_url":"https://github.com/poanetwork/tokenbridge-contracts","homepage":"http://docs.tokenbridge.net","size":2978,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":54,"open_issues":24,"watchers":44,"default_branch":"master"}},"base":{"label":"poanetwork:develop","ref":"develop","sha":"cc7718284d8a35cf74f6ec6847fd7dc7ed1ca885","user":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":121341498,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzNDE0OTg=","name":"tokenbridge-contracts","full_name":"poanetwork/tokenbridge-contracts","private":false,"owner":{"login":"poanetwork","id":28943015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4OTQzMDE1","avatar_url":"https://avatars2.githubusercontent.com/u/28943015?v=4","gravatar_id":"","url":"https://api.github.com/users/poanetwork","html_url":"https://github.com/poanetwork","followers_url":"https://api.github.com/users/poanetwork/followers","following_url":"https://api.github.com/users/poanetwork/following{/other_user}","gists_url":"https://api.github.com/users/poanetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/poanetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poanetwork/subscriptions","organizations_url":"https://api.github.com/users/poanetwork/orgs","repos_url":"https://api.github.com/users/poanetwork/repos","events_url":"https://api.github.com/users/poanetwork/events{/privacy}","received_events_url":"https://api.github.com/users/poanetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poanetwork/tokenbridge-contracts","description":"Smart contracts for TokenBridge","fork":false,"url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts","forks_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/forks","keys_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/teams","hooks_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/hooks","issue_events_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/events","assignees_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/tags","blobs_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/languages","stargazers_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/stargazers","contributors_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/contributors","subscribers_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/subscribers","subscription_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/subscription","commits_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/merges","archive_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/downloads","issues_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/labels{/name}","releases_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/deployments","created_at":"2018-02-13T05:10:29Z","updated_at":"2019-11-08T05:50:38Z","pushed_at":"2019-11-07T22:44:20Z","git_url":"git://github.com/poanetwork/tokenbridge-contracts.git","ssh_url":"git@github.com:poanetwork/tokenbridge-contracts.git","clone_url":"https://github.com/poanetwork/tokenbridge-contracts.git","svn_url":"https://github.com/poanetwork/tokenbridge-contracts","homepage":"http://docs.tokenbridge.net","size":2978,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":54,"open_issues":24,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306"},"html":{"href":"https://github.com/poanetwork/tokenbridge-contracts/pull/306"},"issue":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/306"},"comments":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/poanetwork/tokenbridge-contracts/statuses/d7834d09177b42075bf549d270d5de5e9cd23a1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"patitonar"}}