{"action":"created","comment":{"url":"https://api.github.com/repos/opensds/nbp/pulls/comments/328450033","pull_request_review_id":293492908,"id":328450033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODQ1MDAzMw==","diff_hunk":"@@ -0,0 +1,106 @@\n+// Copyright 2019 The OpenSDS Authors.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\"); you may\n+// not use this file except in compliance with the License. You may obtain\n+// a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+// License for the specific language governing permissions and limitations\n+// under the License.\n+\n+package org.opensds.vmware.ngc.task.createDatastore;\n+\n+import org.opensds.vmware.ngc.common.Storage;\n+import org.opensds.vmware.ngc.models.ALLOC_TYPE;\n+import org.opensds.vmware.ngc.models.VolumeMO;\n+import org.opensds.vmware.ngc.base.TaskInfoConst;\n+import org.opensds.vmware.ngc.model.DatastoreInfo;\n+import org.opensds.vmware.ngc.task.AbstractTask;\n+import org.opensds.vmware.ngc.task.TaskExecution;\n+import org.opensds.vmware.ngc.util.CapacityUtil;\n+import com.vmware.vim25.ManagedObjectReference;\n+import com.vmware.vim25.TaskInfo;\n+import com.vmware.vise.usersession.ServerInfo;\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+import java.util.Map;\n+\n+\n+public class CreateLunTask extends AbstractTask implements TaskExecution {\n+\n+    private static Log logger = LogFactory.getLog(CreateLunTask.class);\n+\n+    private VolumeMO volumeMO;\n+\n+    private Map context;\n+\n+    public CreateLunTask(DatastoreInfo datastoreInfo,\n+                         ManagedObjectReference[] hostMos,\n+                         ServerInfo serverInfo,\n+                         Storage storage) {\n+        super.serverInfo = serverInfo;\n+        super.hostMos = hostMos;\n+        super.datastoreInfo = datastoreInfo;\n+        super.storage = storage;\n+    }\n+\n+    @Override\n+    public void setContext(Map context) {\n+        this.context = context;\n+    }\n+\n+    @Override\n+    public void runTask() throws Exception {\n+\n+        logger.info(\"---------Step one, run create the datastoreInfo task and create volume...\");","path":"vmware/ngc/NGC-Plugin/src/main/java/org/opensds/vmware/ngc/task/createDatastore/CreateLunTask.java","position":63,"original_position":63,"commit_id":"a30cad77f5841ebc83d074b15e72631a3b6f2c76","original_commit_id":"a30cad77f5841ebc83d074b15e72631a3b6f2c76","user":{"login":"NajmudheenCT","id":45681499,"node_id":"MDQ6VXNlcjQ1NjgxNDk5","avatar_url":"https://avatars2.githubusercontent.com/u/45681499?v=4","gravatar_id":"","url":"https://api.github.com/users/NajmudheenCT","html_url":"https://github.com/NajmudheenCT","followers_url":"https://api.github.com/users/NajmudheenCT/followers","following_url":"https://api.github.com/users/NajmudheenCT/following{/other_user}","gists_url":"https://api.github.com/users/NajmudheenCT/gists{/gist_id}","starred_url":"https://api.github.com/users/NajmudheenCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NajmudheenCT/subscriptions","organizations_url":"https://api.github.com/users/NajmudheenCT/orgs","repos_url":"https://api.github.com/users/NajmudheenCT/repos","events_url":"https://api.github.com/users/NajmudheenCT/events{/privacy}","received_events_url":"https://api.github.com/users/NajmudheenCT/received_events","type":"User","site_admin":false},"body":"same as above \"step one\" can be removed ","created_at":"2019-09-26T06:19:34Z","updated_at":"2019-09-26T06:44:09Z","html_url":"https://github.com/opensds/nbp/pull/252#discussion_r328450033","pull_request_url":"https://api.github.com/repos/opensds/nbp/pulls/252","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/opensds/nbp/pulls/comments/328450033"},"html":{"href":"https://github.com/opensds/nbp/pull/252#discussion_r328450033"},"pull_request":{"href":"https://api.github.com/repos/opensds/nbp/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/opensds/nbp/pulls/252","id":318957809,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4OTU3ODA5","html_url":"https://github.com/opensds/nbp/pull/252","diff_url":"https://github.com/opensds/nbp/pull/252.diff","patch_url":"https://github.com/opensds/nbp/pull/252.patch","issue_url":"https://api.github.com/repos/opensds/nbp/issues/252","number":252,"state":"open","locked":false,"title":"VMWare vSphere OpenSDS Storage Plugin","user":{"login":"himanshuvar","id":8712951,"node_id":"MDQ6VXNlcjg3MTI5NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/8712951?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshuvar","html_url":"https://github.com/himanshuvar","followers_url":"https://api.github.com/users/himanshuvar/followers","following_url":"https://api.github.com/users/himanshuvar/following{/other_user}","gists_url":"https://api.github.com/users/himanshuvar/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshuvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshuvar/subscriptions","organizations_url":"https://api.github.com/users/himanshuvar/orgs","repos_url":"https://api.github.com/users/himanshuvar/repos","events_url":"https://api.github.com/users/himanshuvar/events{/privacy}","received_events_url":"https://api.github.com/users/himanshuvar/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nWith reference to opensds/design-specs#38, This PR is to\r\nsupport VMware vSphere web client plugin  for OpenSDS storage and third party storage. \r\n\r\n**Special notes for your reviewer**: \r\nThis is a work in progress PR, which includes\r\n\r\n1. NGC Plugin: Which is the module to communicate with vSphere components.\r\n2. Adapter Manager : This is the adapter implementation of opensds and thirdparty storage.\r\n\r\ncompilation guide can be seen in /vmware/ngc/doc\r\nknown limitations:\r\n1. text  formatting of some files.\r\n2. opensds adapter for taking default(first) network adapter for picking Initiator IP.\r\n3. default block profile should be created for OpenSDS storage.\r\n\r\n**Testing notes**:\r\n1. Tested OpenSDS storage platform addition.\r\n2. Tested OpenSDS login for OpenSDS platform.\r\n3. Tested stoarge pool listing.\r\n4. Tested Volume Creation.\r\n5. Tested Volume Attachment to the ESXI host.\r\n\r\n\r\n**Release note**:","created_at":"2019-09-18T19:06:53Z","updated_at":"2019-09-26T06:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fabe4c2e53c9d492375eebd3e4636ef1560974","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensds/nbp/pulls/252/commits","review_comments_url":"https://api.github.com/repos/opensds/nbp/pulls/252/comments","review_comment_url":"https://api.github.com/repos/opensds/nbp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensds/nbp/issues/252/comments","statuses_url":"https://api.github.com/repos/opensds/nbp/statuses/a30cad77f5841ebc83d074b15e72631a3b6f2c76","head":{"label":"himanshuvar:VMware-vSphere-NGC-Plugin-Step1","ref":"VMware-vSphere-NGC-Plugin-Step1","sha":"a30cad77f5841ebc83d074b15e72631a3b6f2c76","user":{"login":"himanshuvar","id":8712951,"node_id":"MDQ6VXNlcjg3MTI5NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/8712951?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshuvar","html_url":"https://github.com/himanshuvar","followers_url":"https://api.github.com/users/himanshuvar/followers","following_url":"https://api.github.com/users/himanshuvar/following{/other_user}","gists_url":"https://api.github.com/users/himanshuvar/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshuvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshuvar/subscriptions","organizations_url":"https://api.github.com/users/himanshuvar/orgs","repos_url":"https://api.github.com/users/himanshuvar/repos","events_url":"https://api.github.com/users/himanshuvar/events{/privacy}","received_events_url":"https://api.github.com/users/himanshuvar/received_events","type":"User","site_admin":false},"repo":{"id":199661700,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk2NjE3MDA=","name":"nbp","full_name":"himanshuvar/nbp","private":false,"owner":{"login":"himanshuvar","id":8712951,"node_id":"MDQ6VXNlcjg3MTI5NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/8712951?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshuvar","html_url":"https://github.com/himanshuvar","followers_url":"https://api.github.com/users/himanshuvar/followers","following_url":"https://api.github.com/users/himanshuvar/following{/other_user}","gists_url":"https://api.github.com/users/himanshuvar/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshuvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshuvar/subscriptions","organizations_url":"https://api.github.com/users/himanshuvar/orgs","repos_url":"https://api.github.com/users/himanshuvar/repos","events_url":"https://api.github.com/users/himanshuvar/events{/privacy}","received_events_url":"https://api.github.com/users/himanshuvar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/himanshuvar/nbp","description":"Sushi: OpenSDS Northbound Plugin Project","fork":true,"url":"https://api.github.com/repos/himanshuvar/nbp","forks_url":"https://api.github.com/repos/himanshuvar/nbp/forks","keys_url":"https://api.github.com/repos/himanshuvar/nbp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himanshuvar/nbp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himanshuvar/nbp/teams","hooks_url":"https://api.github.com/repos/himanshuvar/nbp/hooks","issue_events_url":"https://api.github.com/repos/himanshuvar/nbp/issues/events{/number}","events_url":"https://api.github.com/repos/himanshuvar/nbp/events","assignees_url":"https://api.github.com/repos/himanshuvar/nbp/assignees{/user}","branches_url":"https://api.github.com/repos/himanshuvar/nbp/branches{/branch}","tags_url":"https://api.github.com/repos/himanshuvar/nbp/tags","blobs_url":"https://api.github.com/repos/himanshuvar/nbp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himanshuvar/nbp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himanshuvar/nbp/git/refs{/sha}","trees_url":"https://api.github.com/repos/himanshuvar/nbp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himanshuvar/nbp/statuses/{sha}","languages_url":"https://api.github.com/repos/himanshuvar/nbp/languages","stargazers_url":"https://api.github.com/repos/himanshuvar/nbp/stargazers","contributors_url":"https://api.github.com/repos/himanshuvar/nbp/contributors","subscribers_url":"https://api.github.com/repos/himanshuvar/nbp/subscribers","subscription_url":"https://api.github.com/repos/himanshuvar/nbp/subscription","commits_url":"https://api.github.com/repos/himanshuvar/nbp/commits{/sha}","git_commits_url":"https://api.github.com/repos/himanshuvar/nbp/git/commits{/sha}","comments_url":"https://api.github.com/repos/himanshuvar/nbp/comments{/number}","issue_comment_url":"https://api.github.com/repos/himanshuvar/nbp/issues/comments{/number}","contents_url":"https://api.github.com/repos/himanshuvar/nbp/contents/{+path}","compare_url":"https://api.github.com/repos/himanshuvar/nbp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himanshuvar/nbp/merges","archive_url":"https://api.github.com/repos/himanshuvar/nbp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himanshuvar/nbp/downloads","issues_url":"https://api.github.com/repos/himanshuvar/nbp/issues{/number}","pulls_url":"https://api.github.com/repos/himanshuvar/nbp/pulls{/number}","milestones_url":"https://api.github.com/repos/himanshuvar/nbp/milestones{/number}","notifications_url":"https://api.github.com/repos/himanshuvar/nbp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himanshuvar/nbp/labels{/name}","releases_url":"https://api.github.com/repos/himanshuvar/nbp/releases{/id}","deployments_url":"https://api.github.com/repos/himanshuvar/nbp/deployments","created_at":"2019-07-30T13:54:30Z","updated_at":"2019-07-30T13:54:32Z","pushed_at":"2019-09-23T09:15:09Z","git_url":"git://github.com/himanshuvar/nbp.git","ssh_url":"git@github.com:himanshuvar/nbp.git","clone_url":"https://github.com/himanshuvar/nbp.git","svn_url":"https://github.com/himanshuvar/nbp","homepage":"","size":115612,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opensds:master","ref":"master","sha":"6fb391c7a5a396a294927b6357c206b0ca4d9abc","user":{"login":"opensds","id":23061836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDYxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/23061836?v=4","gravatar_id":"","url":"https://api.github.com/users/opensds","html_url":"https://github.com/opensds","followers_url":"https://api.github.com/users/opensds/followers","following_url":"https://api.github.com/users/opensds/following{/other_user}","gists_url":"https://api.github.com/users/opensds/gists{/gist_id}","starred_url":"https://api.github.com/users/opensds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensds/subscriptions","organizations_url":"https://api.github.com/users/opensds/orgs","repos_url":"https://api.github.com/users/opensds/repos","events_url":"https://api.github.com/users/opensds/events{/privacy}","received_events_url":"https://api.github.com/users/opensds/received_events","type":"Organization","site_admin":false},"repo":{"id":99203413,"node_id":"MDEwOlJlcG9zaXRvcnk5OTIwMzQxMw==","name":"nbp","full_name":"opensds/nbp","private":false,"owner":{"login":"opensds","id":23061836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDYxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/23061836?v=4","gravatar_id":"","url":"https://api.github.com/users/opensds","html_url":"https://github.com/opensds","followers_url":"https://api.github.com/users/opensds/followers","following_url":"https://api.github.com/users/opensds/following{/other_user}","gists_url":"https://api.github.com/users/opensds/gists{/gist_id}","starred_url":"https://api.github.com/users/opensds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensds/subscriptions","organizations_url":"https://api.github.com/users/opensds/orgs","repos_url":"https://api.github.com/users/opensds/repos","events_url":"https://api.github.com/users/opensds/events{/privacy}","received_events_url":"https://api.github.com/users/opensds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opensds/nbp","description":"Sushi: OpenSDS Northbound Plugin Project","fork":false,"url":"https://api.github.com/repos/opensds/nbp","forks_url":"https://api.github.com/repos/opensds/nbp/forks","keys_url":"https://api.github.com/repos/opensds/nbp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensds/nbp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensds/nbp/teams","hooks_url":"https://api.github.com/repos/opensds/nbp/hooks","issue_events_url":"https://api.github.com/repos/opensds/nbp/issues/events{/number}","events_url":"https://api.github.com/repos/opensds/nbp/events","assignees_url":"https://api.github.com/repos/opensds/nbp/assignees{/user}","branches_url":"https://api.github.com/repos/opensds/nbp/branches{/branch}","tags_url":"https://api.github.com/repos/opensds/nbp/tags","blobs_url":"https://api.github.com/repos/opensds/nbp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensds/nbp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensds/nbp/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensds/nbp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensds/nbp/statuses/{sha}","languages_url":"https://api.github.com/repos/opensds/nbp/languages","stargazers_url":"https://api.github.com/repos/opensds/nbp/stargazers","contributors_url":"https://api.github.com/repos/opensds/nbp/contributors","subscribers_url":"https://api.github.com/repos/opensds/nbp/subscribers","subscription_url":"https://api.github.com/repos/opensds/nbp/subscription","commits_url":"https://api.github.com/repos/opensds/nbp/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensds/nbp/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensds/nbp/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensds/nbp/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensds/nbp/contents/{+path}","compare_url":"https://api.github.com/repos/opensds/nbp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensds/nbp/merges","archive_url":"https://api.github.com/repos/opensds/nbp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensds/nbp/downloads","issues_url":"https://api.github.com/repos/opensds/nbp/issues{/number}","pulls_url":"https://api.github.com/repos/opensds/nbp/pulls{/number}","milestones_url":"https://api.github.com/repos/opensds/nbp/milestones{/number}","notifications_url":"https://api.github.com/repos/opensds/nbp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensds/nbp/labels{/name}","releases_url":"https://api.github.com/repos/opensds/nbp/releases{/id}","deployments_url":"https://api.github.com/repos/opensds/nbp/deployments","created_at":"2017-08-03T07:23:00Z","updated_at":"2019-09-26T03:34:24Z","pushed_at":"2019-09-24T12:50:42Z","git_url":"git://github.com/opensds/nbp.git","ssh_url":"git@github.com:opensds/nbp.git","clone_url":"https://github.com/opensds/nbp.git","svn_url":"https://github.com/opensds/nbp","homepage":"","size":106220,"stargazers_count":35,"watchers_count":35,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":7,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensds/nbp/pulls/252"},"html":{"href":"https://github.com/opensds/nbp/pull/252"},"issue":{"href":"https://api.github.com/repos/opensds/nbp/issues/252"},"comments":{"href":"https://api.github.com/repos/opensds/nbp/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/opensds/nbp/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/opensds/nbp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensds/nbp/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/opensds/nbp/statuses/a30cad77f5841ebc83d074b15e72631a3b6f2c76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NajmudheenCT"}}