{"push_id":3514256437,"size":44,"distinct_size":1,"ref":"refs/heads/single-app-manifest","head":"9547fedcc3723a9f92a5e9b63ae6dea22441081f","before":"d3d4c8f3d6c7b86ed2da2faff725628a0ed2e48a","commits":[{"sha":"e0b61e3d704aadf776f8c8e58511f47934ae5ae3","author":{"name":"Pea Tyczynska","email":"4aa033b796e79b1c8d3e1b854f2b32e948292970@digital.cabinet-office.gov.uk"},"message":"Call precompiled letter preview with overlay","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/e0b61e3d704aadf776f8c8e58511f47934ae5ae3"},{"sha":"858e98736f9908b4817796076c40032f83117a8c","author":{"name":"Pea Tyczynska","email":"4aa033b796e79b1c8d3e1b854f2b32e948292970@digital.cabinet-office.gov.uk"},"message":"Test that preview with overlay gets called","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/858e98736f9908b4817796076c40032f83117a8c"},{"sha":"3c302e459512224ab816f8df762a5b6be1331a25","author":{"name":"Alexey Bezhan","email":"2f9ee2b336682012cb445da6f3a0a52c68caf471@fueledbylemons.com"},"message":"Stop pyup from trying to upgrade gunicorn","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/3c302e459512224ab816f8df762a5b6be1331a25"},{"sha":"436d023722569acba79e43da8971193b80e7a6ea","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Block incomplete requests to go live\n\nDealing with users who request to go live but haven’t completed all the\nsteps still represents a significant support overhead for our team.\nWe’ve made some improvements to the percentage of incomplete requests\nwith a better page design, but ultimately because it still shows the\nbutton people think it’s OK to press the button while some of the items\non the page still say [Not completed].\n\nWe can do this now because organisations are in the database, which\nmeans we can mark the agreement signed as soon as we get it back,\nwithout having to deploy code.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/436d023722569acba79e43da8971193b80e7a6ea"},{"sha":"f997b446ff192759d7b0a67ae9e6bc89fa003a2e","author":{"name":"karlchillmaid","email":"dcfe243f834541e9485c88d8971d88aa1737ec10@digital.cabinet-office.gov.uk"},"message":"Update app/templates/views/service-settings/request-to-go-live.html\n\nCo-Authored-By: quis <me@quis.cc>","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/f997b446ff192759d7b0a67ae9e6bc89fa003a2e"},{"sha":"278317b2226133ee91bd327adb054bee37abee18","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Merge pull request #2907 from alphagov/no-go-live-without-checklist\n\nBlock incomplete requests to go live","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/278317b2226133ee91bd327adb054bee37abee18"},{"sha":"df1a1b5b664a505386b85f4dc54d2f1f2ce3c2da","author":{"name":"Alexey Bezhan","email":"2f9ee2b336682012cb445da6f3a0a52c68caf471@fueledbylemons.com"},"message":"Merge pull request #2905 from alphagov/pin-gunicorn-pyup\n\nStop pyup from trying to upgrade gunicorn","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/df1a1b5b664a505386b85f4dc54d2f1f2ce3c2da"},{"sha":"9863aa3c48ce81b9d77e44c96c9ea4bca78d5a81","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Automate counting of live services and orgs\n\nReturns the data calculated by the API. Stored in Redis against a\nhardcoded key so that no-one hammering the home page is directly hitting\nthe database.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/9863aa3c48ce81b9d77e44c96c9ea4bca78d5a81"},{"sha":"718f4407203ccbb253dd3879536d7d5a3781132f","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Get info about organisations from database table\n\nThis is the first step of replacing the `domains.yml` file.\n\nIn order to replicate the same functionality we get from the\n`domains.yml` file and its associated code this commit adds a\n`Organisation` model. This model copies a lot of methods from the\n`AgreementInfo` class which wrapped the `domains.yml` file.\n\nIt factors out some stuff that would otherwise be duplicated between the\n`Organisation` and `Service` model, in such a way that could be reused\nfor making other models in the future.\n\nThis commit doesn’t change other parts of the code to make use of this\nnew model yet – that will come in subsequent commits.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/718f4407203ccbb253dd3879536d7d5a3781132f"},{"sha":"72f49a9a1e93c313d8fa27eefb8c532726dc9ede","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Remove dependence on domains.yml from static pages\n\nThis will allow us to remove the `domains.yml` file, by using\ninformation about organisations that is now stored in the database\ninstead.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/72f49a9a1e93c313d8fa27eefb8c532726dc9ede"},{"sha":"98249158cb687b7c7e732a055971894545ffe483","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Stop trying to infer branding when adding services\n\nThe API handles this now.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/98249158cb687b7c7e732a055971894545ffe483"},{"sha":"835d11d8d6958ac90246d52bacb853fd5fedf2db","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Remove domains.yml dependence from agreement pages\n\nThis will allow us to remove the `domains.yml` file, by using\ninformation about organisations that is now stored in the database\ninstead.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/835d11d8d6958ac90246d52bacb853fd5fedf2db"},{"sha":"b41c3779c4eb5eeca7e865e2a198d422009f3efd","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Merge pull request #2906 from alphagov/auto-service-counts\n\nAutomate counting of live services and orgs","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/b41c3779c4eb5eeca7e865e2a198d422009f3efd"},{"sha":"3565ffc33f7c17cb42ac3d01880a0bd44215d147","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Remove dependence on domains.yml from settings\n\nSettings looked at `domains.yml` when users were making go live requests\nor email branding requests.\n\nThis will allow us to remove the `domains.yml` file, by using\ninformation about organisations that is now stored in the database\ninstead.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/3565ffc33f7c17cb42ac3d01880a0bd44215d147"},{"sha":"9684e962ae4850bb4d954beb0db2ee5c8f69eeff","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Refactor go live tags into service model\n\nSince this function only takes one argument, a service, it might as well\nbe a method of the service.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/9684e962ae4850bb4d954beb0db2ee5c8f69eeff"},{"sha":"470b8a2912c4c42318a7bc199d094825acc2e92b","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Remove domains from branding forms\n\nWe’re deprecating storing the domain as text on a branding in favour of\na database relationship between branding and organisation.\n\nWe need to do this now in order to remove the validation on these fields\n(which depends on the data in `domains.yml`)","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/470b8a2912c4c42318a7bc199d094825acc2e92b"},{"sha":"9d99c78c3adf7a69d76203c73fb919c1aad1a016","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Remove code that reads `domains.yml`\n\nSince we’ve removed calls to this code from the rest of the app, it can\nsafely be removed now.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/9d99c78c3adf7a69d76203c73fb919c1aad1a016"},{"sha":"5d091b214a4d682ae14d084949e380de90786f1d","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Remove domains.yml file\n\nSince we’ve now removed the code that reads this file, it can safely be\ndeleted.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/5d091b214a4d682ae14d084949e380de90786f1d"},{"sha":"07c754404972f921afc0f0ee2caa767110c4603b","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Use crown not crown_status as prop name\n\nIt’s confusing having a property name which is different from the\nattribute returned in the JSON from the API.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/07c754404972f921afc0f0ee2caa767110c4603b"},{"sha":"3212915a5126d94e1404f120af3c0198fc277818","author":{"name":"Chris Hill-Scott","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@quis.cc"},"message":"Simplifying code for checking email domains\n\nSince this code isn’t trying to inherit from the code that also looked\nup domain names in `domains.yml` it can go back to being a lot simpler.\n\nThis code is thoroughly tested already here:\nhttps://github.com/alphagov/notifications-admin/blob/a249382e6990635ddef9fef7fe614c9c8e57d55e/tests/app/main/test_validators.py#L74-L155","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/3212915a5126d94e1404f120af3c0198fc277818"}]}
{"actor":{"display_login":"leohemsted"}}