{"action":"created","comment":{"url":"https://api.github.com/repos/openebs/maya/pulls/comments/317891403","pull_request_review_id":279952488,"id":317891403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzg5MTQwMw==","diff_hunk":"@@ -126,8 +126,8 @@ func (pc *PoolConfig) GetPoolDeploySpec(csp *apis.CStorPoolInstance) (*appsv1.De\n \t\t\t\t\t\tWithName(PoolMgmtContainerName).\n \t\t\t\t\t\tWithImagePullPolicy(corev1.PullIfNotPresent).\n \t\t\t\t\t\tWithPrivilegedSecurityContext(&privileged).\n-\t\t\t\t\t\tWithEnvsNew(getPoolMgmtEnv(pc.AlgorithmConfig.CSPC)).","path":"cmd/cspc-operator/app/storagepool_create.go","position":4,"original_position":4,"commit_id":"5f2db7bb11c2aeb5508548a2d9ce80d4dd953113","original_commit_id":"5f2db7bb11c2aeb5508548a2d9ce80d4dd953113","user":{"login":"vishnuitta","id":25415415,"node_id":"MDQ6VXNlcjI1NDE1NDE1","avatar_url":"https://avatars2.githubusercontent.com/u/25415415?v=4","gravatar_id":"","url":"https://api.github.com/users/vishnuitta","html_url":"https://github.com/vishnuitta","followers_url":"https://api.github.com/users/vishnuitta/followers","following_url":"https://api.github.com/users/vishnuitta/following{/other_user}","gists_url":"https://api.github.com/users/vishnuitta/gists{/gist_id}","starred_url":"https://api.github.com/users/vishnuitta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishnuitta/subscriptions","organizations_url":"https://api.github.com/users/vishnuitta/orgs","repos_url":"https://api.github.com/users/vishnuitta/repos","events_url":"https://api.github.com/users/vishnuitta/events{/privacy}","received_events_url":"https://api.github.com/users/vishnuitta/received_events","type":"User","site_admin":false},"body":"fix fn names","created_at":"2019-08-27T04:45:40Z","updated_at":"2019-08-27T04:45:40Z","html_url":"https://github.com/openebs/maya/pull/1409#discussion_r317891403","pull_request_url":"https://api.github.com/repos/openebs/maya/pulls/1409","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openebs/maya/pulls/comments/317891403"},"html":{"href":"https://github.com/openebs/maya/pull/1409#discussion_r317891403"},"pull_request":{"href":"https://api.github.com/repos/openebs/maya/pulls/1409"}}},"pull_request":{"url":"https://api.github.com/repos/openebs/maya/pulls/1409","id":310884525,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwODg0NTI1","html_url":"https://github.com/openebs/maya/pull/1409","diff_url":"https://github.com/openebs/maya/pull/1409.diff","patch_url":"https://github.com/openebs/maya/pull/1409.patch","issue_url":"https://api.github.com/repos/openebs/maya/issues/1409","number":1409,"state":"open","locked":false,"title":"fix(cvr,cspc,cspi): use Pool env to get the pool instance uid","user":{"login":"prateekpandey14","id":7140415,"node_id":"MDQ6VXNlcjcxNDA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7140415?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekpandey14","html_url":"https://github.com/prateekpandey14","followers_url":"https://api.github.com/users/prateekpandey14/followers","following_url":"https://api.github.com/users/prateekpandey14/following{/other_user}","gists_url":"https://api.github.com/users/prateekpandey14/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekpandey14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekpandey14/subscriptions","organizations_url":"https://api.github.com/users/prateekpandey14/orgs","repos_url":"https://api.github.com/users/prateekpandey14/repos","events_url":"https://api.github.com/users/prateekpandey14/events{/privacy}","received_events_url":"https://api.github.com/users/prateekpandey14/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you -->\r\n\r\n**What this PR does / why we need it**:\r\nChanges will add the env `OPENSBS_IO_POOL_NAME`  to get the `cstorPoolInstance` uid in case of cspc and csi based volumes provisioning.\r\n\r\n**Special notes for your reviewer**:\r\n- Above changes are done taking care with backward compatibilities for\r\n  older way of provisioning.\r\n- `OPENSBS_IO_POOL_NAME` env has to be added in case of backup and restore controllers.\r\n\r\n**Checklist:**\r\n- [ ] Fixes #<issue number>\r\n- [ ] Labelled this PR & related issue with `documentation` tag\r\n- [ ] PR messages has document related information\r\n- [ ] Labelled this PR & related issue with `breaking-changes` tag\r\n- [ ] PR messages has breaking changes related information\r\n- [ ] Labelled this PR & related issue with `requires-upgrade` tag\r\n- [ ] PR messages has upgrade related information\r\n- [ ] Commit has unit tests\r\n- [ ] Commit has integration tests\r\nSigned-off-by: prateekpandey14 <prateek.pandey@openebs.io>","created_at":"2019-08-26T11:48:19Z","updated_at":"2019-08-27T04:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a46893808f737717bdb0b01cbcfc7a50fcbf1e4c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sonasingh46","id":24835120,"node_id":"MDQ6VXNlcjI0ODM1MTIw","avatar_url":"https://avatars3.githubusercontent.com/u/24835120?v=4","gravatar_id":"","url":"https://api.github.com/users/sonasingh46","html_url":"https://github.com/sonasingh46","followers_url":"https://api.github.com/users/sonasingh46/followers","following_url":"https://api.github.com/users/sonasingh46/following{/other_user}","gists_url":"https://api.github.com/users/sonasingh46/gists{/gist_id}","starred_url":"https://api.github.com/users/sonasingh46/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonasingh46/subscriptions","organizations_url":"https://api.github.com/users/sonasingh46/orgs","repos_url":"https://api.github.com/users/sonasingh46/repos","events_url":"https://api.github.com/users/sonasingh46/events{/privacy}","received_events_url":"https://api.github.com/users/sonasingh46/received_events","type":"User","site_admin":false},{"login":"mynktl","id":33252549,"node_id":"MDQ6VXNlcjMzMjUyNTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/33252549?v=4","gravatar_id":"","url":"https://api.github.com/users/mynktl","html_url":"https://github.com/mynktl","followers_url":"https://api.github.com/users/mynktl/followers","following_url":"https://api.github.com/users/mynktl/following{/other_user}","gists_url":"https://api.github.com/users/mynktl/gists{/gist_id}","starred_url":"https://api.github.com/users/mynktl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mynktl/subscriptions","organizations_url":"https://api.github.com/users/mynktl/orgs","repos_url":"https://api.github.com/users/mynktl/repos","events_url":"https://api.github.com/users/mynktl/events{/privacy}","received_events_url":"https://api.github.com/users/mynktl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/maya/pulls/1409/commits","review_comments_url":"https://api.github.com/repos/openebs/maya/pulls/1409/comments","review_comment_url":"https://api.github.com/repos/openebs/maya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/maya/issues/1409/comments","statuses_url":"https://api.github.com/repos/openebs/maya/statuses/5f2db7bb11c2aeb5508548a2d9ce80d4dd953113","head":{"label":"prateekpandey14:poolid-change","ref":"poolid-change","sha":"5f2db7bb11c2aeb5508548a2d9ce80d4dd953113","user":{"login":"prateekpandey14","id":7140415,"node_id":"MDQ6VXNlcjcxNDA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7140415?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekpandey14","html_url":"https://github.com/prateekpandey14","followers_url":"https://api.github.com/users/prateekpandey14/followers","following_url":"https://api.github.com/users/prateekpandey14/following{/other_user}","gists_url":"https://api.github.com/users/prateekpandey14/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekpandey14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekpandey14/subscriptions","organizations_url":"https://api.github.com/users/prateekpandey14/orgs","repos_url":"https://api.github.com/users/prateekpandey14/repos","events_url":"https://api.github.com/users/prateekpandey14/events{/privacy}","received_events_url":"https://api.github.com/users/prateekpandey14/received_events","type":"User","site_admin":false},"repo":{"id":105143487,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxNDM0ODc=","name":"maya","full_name":"prateekpandey14/maya","private":false,"owner":{"login":"prateekpandey14","id":7140415,"node_id":"MDQ6VXNlcjcxNDA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/7140415?v=4","gravatar_id":"","url":"https://api.github.com/users/prateekpandey14","html_url":"https://github.com/prateekpandey14","followers_url":"https://api.github.com/users/prateekpandey14/followers","following_url":"https://api.github.com/users/prateekpandey14/following{/other_user}","gists_url":"https://api.github.com/users/prateekpandey14/gists{/gist_id}","starred_url":"https://api.github.com/users/prateekpandey14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateekpandey14/subscriptions","organizations_url":"https://api.github.com/users/prateekpandey14/orgs","repos_url":"https://api.github.com/users/prateekpandey14/repos","events_url":"https://api.github.com/users/prateekpandey14/events{/privacy}","received_events_url":"https://api.github.com/users/prateekpandey14/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prateekpandey14/maya","description":"OpenEBS storage orchestrator and infrastructure management engine, extending K8S and other to enable containerized storage for containers.","fork":true,"url":"https://api.github.com/repos/prateekpandey14/maya","forks_url":"https://api.github.com/repos/prateekpandey14/maya/forks","keys_url":"https://api.github.com/repos/prateekpandey14/maya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prateekpandey14/maya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prateekpandey14/maya/teams","hooks_url":"https://api.github.com/repos/prateekpandey14/maya/hooks","issue_events_url":"https://api.github.com/repos/prateekpandey14/maya/issues/events{/number}","events_url":"https://api.github.com/repos/prateekpandey14/maya/events","assignees_url":"https://api.github.com/repos/prateekpandey14/maya/assignees{/user}","branches_url":"https://api.github.com/repos/prateekpandey14/maya/branches{/branch}","tags_url":"https://api.github.com/repos/prateekpandey14/maya/tags","blobs_url":"https://api.github.com/repos/prateekpandey14/maya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prateekpandey14/maya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prateekpandey14/maya/git/refs{/sha}","trees_url":"https://api.github.com/repos/prateekpandey14/maya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prateekpandey14/maya/statuses/{sha}","languages_url":"https://api.github.com/repos/prateekpandey14/maya/languages","stargazers_url":"https://api.github.com/repos/prateekpandey14/maya/stargazers","contributors_url":"https://api.github.com/repos/prateekpandey14/maya/contributors","subscribers_url":"https://api.github.com/repos/prateekpandey14/maya/subscribers","subscription_url":"https://api.github.com/repos/prateekpandey14/maya/subscription","commits_url":"https://api.github.com/repos/prateekpandey14/maya/commits{/sha}","git_commits_url":"https://api.github.com/repos/prateekpandey14/maya/git/commits{/sha}","comments_url":"https://api.github.com/repos/prateekpandey14/maya/comments{/number}","issue_comment_url":"https://api.github.com/repos/prateekpandey14/maya/issues/comments{/number}","contents_url":"https://api.github.com/repos/prateekpandey14/maya/contents/{+path}","compare_url":"https://api.github.com/repos/prateekpandey14/maya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prateekpandey14/maya/merges","archive_url":"https://api.github.com/repos/prateekpandey14/maya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prateekpandey14/maya/downloads","issues_url":"https://api.github.com/repos/prateekpandey14/maya/issues{/number}","pulls_url":"https://api.github.com/repos/prateekpandey14/maya/pulls{/number}","milestones_url":"https://api.github.com/repos/prateekpandey14/maya/milestones{/number}","notifications_url":"https://api.github.com/repos/prateekpandey14/maya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prateekpandey14/maya/labels{/name}","releases_url":"https://api.github.com/repos/prateekpandey14/maya/releases{/id}","deployments_url":"https://api.github.com/repos/prateekpandey14/maya/deployments","created_at":"2017-09-28T12:07:01Z","updated_at":"2019-01-11T14:49:33Z","pushed_at":"2019-08-26T14:49:04Z","git_url":"git://github.com/prateekpandey14/maya.git","ssh_url":"git@github.com:prateekpandey14/maya.git","clone_url":"https://github.com/prateekpandey14/maya.git","svn_url":"https://github.com/prateekpandey14/maya","homepage":"","size":102495,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openebs:master","ref":"master","sha":"935ecbb2dfa9340572c7869ce8ae45d5c62d68c0","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":70136587,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEzNjU4Nw==","name":"maya","full_name":"openebs/maya","private":false,"owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openebs/maya","description":"Manage Container Attached Storage (CAS) - Data Engines in Kubernetes","fork":false,"url":"https://api.github.com/repos/openebs/maya","forks_url":"https://api.github.com/repos/openebs/maya/forks","keys_url":"https://api.github.com/repos/openebs/maya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/maya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/maya/teams","hooks_url":"https://api.github.com/repos/openebs/maya/hooks","issue_events_url":"https://api.github.com/repos/openebs/maya/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/maya/events","assignees_url":"https://api.github.com/repos/openebs/maya/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/maya/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/maya/tags","blobs_url":"https://api.github.com/repos/openebs/maya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/maya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/maya/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/maya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/maya/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/maya/languages","stargazers_url":"https://api.github.com/repos/openebs/maya/stargazers","contributors_url":"https://api.github.com/repos/openebs/maya/contributors","subscribers_url":"https://api.github.com/repos/openebs/maya/subscribers","subscription_url":"https://api.github.com/repos/openebs/maya/subscription","commits_url":"https://api.github.com/repos/openebs/maya/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/maya/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/maya/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/maya/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/maya/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/maya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/maya/merges","archive_url":"https://api.github.com/repos/openebs/maya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/maya/downloads","issues_url":"https://api.github.com/repos/openebs/maya/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/maya/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/maya/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/maya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/maya/labels{/name}","releases_url":"https://api.github.com/repos/openebs/maya/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/maya/deployments","created_at":"2016-10-06T08:34:13Z","updated_at":"2019-08-27T04:22:55Z","pushed_at":"2019-08-26T14:49:06Z","git_url":"git://github.com/openebs/maya.git","ssh_url":"git@github.com:openebs/maya.git","clone_url":"https://github.com/openebs/maya.git","svn_url":"https://github.com/openebs/maya","homepage":"https://docs.openebs.io","size":102124,"stargazers_count":134,"watchers_count":134,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":92,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":204,"open_issues":92,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/maya/pulls/1409"},"html":{"href":"https://github.com/openebs/maya/pull/1409"},"issue":{"href":"https://api.github.com/repos/openebs/maya/issues/1409"},"comments":{"href":"https://api.github.com/repos/openebs/maya/issues/1409/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/maya/pulls/1409/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/maya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/maya/pulls/1409/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/maya/statuses/5f2db7bb11c2aeb5508548a2d9ce80d4dd953113"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vishnuitta"}}