{"action":"created","issue":{"url":"https://api.github.com/repos/replete-repl/replete-web/issues/4","repository_url":"https://api.github.com/repos/replete-repl/replete-web","labels_url":"https://api.github.com/repos/replete-repl/replete-web/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/replete-repl/replete-web/issues/4/comments","events_url":"https://api.github.com/repos/replete-repl/replete-web/issues/4/events","html_url":"https://github.com/replete-repl/replete-web/pull/4","id":445727142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwMTA4NTY2","number":4,"title":"Format output using replete pprint","user":{"login":"mfikes","id":1723464,"node_id":"MDQ6VXNlcjE3MjM0NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1723464?v=4","gravatar_id":"","url":"https://api.github.com/users/mfikes","html_url":"https://github.com/mfikes","followers_url":"https://api.github.com/users/mfikes/followers","following_url":"https://api.github.com/users/mfikes/following{/other_user}","gists_url":"https://api.github.com/users/mfikes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfikes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfikes/subscriptions","organizations_url":"https://api.github.com/users/mfikes/orgs","repos_url":"https://api.github.com/users/mfikes/repos","events_url":"https://api.github.com/users/mfikes/events{/privacy}","received_events_url":"https://api.github.com/users/mfikes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-05-18T15:36:06Z","updated_at":"2019-05-18T16:22:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/replete-repl/replete-web/pulls/4","html_url":"https://github.com/replete-repl/replete-web/pull/4","diff_url":"https://github.com/replete-repl/replete-web/pull/4.diff","patch_url":"https://github.com/replete-repl/replete-web/pull/4.patch"},"body":"Hey @raymcdermott this PR isn't really meant to be merged as it is just exploring an idea.\r\n\r\nIt appears that values are rendered by first converting them to strings using `str`. But, that skips the Replete value pretty-printing subsystem. A consequence of that is that forms are not wrapped using Fipp, certain Replete formatting things, like the way `(atom 1)` is rendered, abbreviations for Vars and keywords, etc., are skipped. You can also see this if you macroexpand a form: Instead of data, you see a string.\r\n\r\nThis PR explores hooking value formatting back into the Replete pretty-printing infrastructure.\r\n\r\nFrom the big picture, it seem that the way Replete Web is structured, it ends up in the position it is in because it is using the pREPL interface, where it only has values to render, but maybe it is possible to use Replete to help render those values."},"comment":{"url":"https://api.github.com/repos/replete-repl/replete-web/issues/comments/493689054","html_url":"https://github.com/replete-repl/replete-web/pull/4#issuecomment-493689054","issue_url":"https://api.github.com/repos/replete-repl/replete-web/issues/4","id":493689054,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MzY4OTA1NA==","user":{"login":"mfikes","id":1723464,"node_id":"MDQ6VXNlcjE3MjM0NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1723464?v=4","gravatar_id":"","url":"https://api.github.com/users/mfikes","html_url":"https://github.com/mfikes","followers_url":"https://api.github.com/users/mfikes/followers","following_url":"https://api.github.com/users/mfikes/following{/other_user}","gists_url":"https://api.github.com/users/mfikes/gists{/gist_id}","starred_url":"https://api.github.com/users/mfikes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfikes/subscriptions","organizations_url":"https://api.github.com/users/mfikes/orgs","repos_url":"https://api.github.com/users/mfikes/repos","events_url":"https://api.github.com/users/mfikes/events{/privacy}","received_events_url":"https://api.github.com/users/mfikes/received_events","type":"User","site_admin":false},"created_at":"2019-05-18T16:22:07Z","updated_at":"2019-05-18T16:22:07Z","author_association":"MEMBER","body":"@raymcdermott One open question I haven't sorted with this PR is that the output for things like `(doc range)` are then formatted as strings (with quotes and embedded `\\n` characters). \r\n\r\nI'll take a look at that particular issue... I suspect that this is because the PR is treating all values the same way, and not honoring the pREPL notion that some return values are \"printed\" output."}}
{"actor":{"display_login":"mfikes"}}