{"action":"created","comment":{"url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/comments/298909770","pull_request_review_id":256167281,"id":298909770,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODkwOTc3MA==","diff_hunk":"@@ -302,7 +302,8 @@ function plupload_element_pre_render($element) {\n  * Returns the path to the plupload library.\n  */\n function _plupload_library_path() {\n-  $path = config_get('plupload.settings','library_path');\n+  // preset path to library now that it is included in module.\n+  $path = 'modules/plupload/lib/plupload';","path":"plupload.module","position":null,"original_position":6,"commit_id":"d4544872e85b161a22f28ece85415836c6dc0a55","original_commit_id":"ce1823677bf2e26129f3a10f41857175791a4648","user":{"login":"Graham-72","id":10559274,"node_id":"MDQ6VXNlcjEwNTU5Mjc0","avatar_url":"https://avatars2.githubusercontent.com/u/10559274?v=4","gravatar_id":"","url":"https://api.github.com/users/Graham-72","html_url":"https://github.com/Graham-72","followers_url":"https://api.github.com/users/Graham-72/followers","following_url":"https://api.github.com/users/Graham-72/following{/other_user}","gists_url":"https://api.github.com/users/Graham-72/gists{/gist_id}","starred_url":"https://api.github.com/users/Graham-72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graham-72/subscriptions","organizations_url":"https://api.github.com/users/Graham-72/orgs","repos_url":"https://api.github.com/users/Graham-72/repos","events_url":"https://api.github.com/users/Graham-72/events{/privacy}","received_events_url":"https://api.github.com/users/Graham-72/received_events","type":"User","site_admin":false},"body":"Yes, good point. I have modified the PR (I hope!).\r\n\r\nI have not yet removed the _plupload_library_path() function because it is called four times in plupload.install and doesn't need to be fixed at the moment.","created_at":"2019-07-01T07:20:46Z","updated_at":"2019-07-01T07:20:46Z","html_url":"https://github.com/backdrop-contrib/plupload/pull/6#discussion_r298909770","pull_request_url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/comments/298909770"},"html":{"href":"https://github.com/backdrop-contrib/plupload/pull/6#discussion_r298909770"},"pull_request":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6"}},"in_reply_to_id":298813493},"pull_request":{"url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6","id":293015472,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzMDE1NDcy","html_url":"https://github.com/backdrop-contrib/plupload/pull/6","diff_url":"https://github.com/backdrop-contrib/plupload/pull/6.diff","patch_url":"https://github.com/backdrop-contrib/plupload/pull/6.patch","issue_url":"https://api.github.com/repos/backdrop-contrib/plupload/issues/6","number":6,"state":"open","locked":false,"title":"Issue #4: include library in module.","user":{"login":"Graham-72","id":10559274,"node_id":"MDQ6VXNlcjEwNTU5Mjc0","avatar_url":"https://avatars2.githubusercontent.com/u/10559274?v=4","gravatar_id":"","url":"https://api.github.com/users/Graham-72","html_url":"https://github.com/Graham-72","followers_url":"https://api.github.com/users/Graham-72/followers","following_url":"https://api.github.com/users/Graham-72/following{/other_user}","gists_url":"https://api.github.com/users/Graham-72/gists{/gist_id}","starred_url":"https://api.github.com/users/Graham-72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graham-72/subscriptions","organizations_url":"https://api.github.com/users/Graham-72/orgs","repos_url":"https://api.github.com/users/Graham-72/repos","events_url":"https://api.github.com/users/Graham-72/events{/privacy}","received_events_url":"https://api.github.com/users/Graham-72/received_events","type":"User","site_admin":false},"body":"Proposed fix for issue #4","created_at":"2019-06-29T05:31:33Z","updated_at":"2019-07-01T07:20:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c3b173aeaaa5509aa5888c15afba5c60e40fad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6/commits","review_comments_url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6/comments","review_comment_url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/comments{/number}","comments_url":"https://api.github.com/repos/backdrop-contrib/plupload/issues/6/comments","statuses_url":"https://api.github.com/repos/backdrop-contrib/plupload/statuses/d4544872e85b161a22f28ece85415836c6dc0a55","head":{"label":"Graham-72:incorporate_library","ref":"incorporate_library","sha":"d4544872e85b161a22f28ece85415836c6dc0a55","user":{"login":"Graham-72","id":10559274,"node_id":"MDQ6VXNlcjEwNTU5Mjc0","avatar_url":"https://avatars2.githubusercontent.com/u/10559274?v=4","gravatar_id":"","url":"https://api.github.com/users/Graham-72","html_url":"https://github.com/Graham-72","followers_url":"https://api.github.com/users/Graham-72/followers","following_url":"https://api.github.com/users/Graham-72/following{/other_user}","gists_url":"https://api.github.com/users/Graham-72/gists{/gist_id}","starred_url":"https://api.github.com/users/Graham-72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graham-72/subscriptions","organizations_url":"https://api.github.com/users/Graham-72/orgs","repos_url":"https://api.github.com/users/Graham-72/repos","events_url":"https://api.github.com/users/Graham-72/events{/privacy}","received_events_url":"https://api.github.com/users/Graham-72/received_events","type":"User","site_admin":false},"repo":{"id":194228893,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQyMjg4OTM=","name":"plupload","full_name":"Graham-72/plupload","private":false,"owner":{"login":"Graham-72","id":10559274,"node_id":"MDQ6VXNlcjEwNTU5Mjc0","avatar_url":"https://avatars2.githubusercontent.com/u/10559274?v=4","gravatar_id":"","url":"https://api.github.com/users/Graham-72","html_url":"https://github.com/Graham-72","followers_url":"https://api.github.com/users/Graham-72/followers","following_url":"https://api.github.com/users/Graham-72/following{/other_user}","gists_url":"https://api.github.com/users/Graham-72/gists{/gist_id}","starred_url":"https://api.github.com/users/Graham-72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graham-72/subscriptions","organizations_url":"https://api.github.com/users/Graham-72/orgs","repos_url":"https://api.github.com/users/Graham-72/repos","events_url":"https://api.github.com/users/Graham-72/events{/privacy}","received_events_url":"https://api.github.com/users/Graham-72/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Graham-72/plupload","description":"Integrates the Plupload library with Backdrop forms.","fork":true,"url":"https://api.github.com/repos/Graham-72/plupload","forks_url":"https://api.github.com/repos/Graham-72/plupload/forks","keys_url":"https://api.github.com/repos/Graham-72/plupload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Graham-72/plupload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Graham-72/plupload/teams","hooks_url":"https://api.github.com/repos/Graham-72/plupload/hooks","issue_events_url":"https://api.github.com/repos/Graham-72/plupload/issues/events{/number}","events_url":"https://api.github.com/repos/Graham-72/plupload/events","assignees_url":"https://api.github.com/repos/Graham-72/plupload/assignees{/user}","branches_url":"https://api.github.com/repos/Graham-72/plupload/branches{/branch}","tags_url":"https://api.github.com/repos/Graham-72/plupload/tags","blobs_url":"https://api.github.com/repos/Graham-72/plupload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Graham-72/plupload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Graham-72/plupload/git/refs{/sha}","trees_url":"https://api.github.com/repos/Graham-72/plupload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Graham-72/plupload/statuses/{sha}","languages_url":"https://api.github.com/repos/Graham-72/plupload/languages","stargazers_url":"https://api.github.com/repos/Graham-72/plupload/stargazers","contributors_url":"https://api.github.com/repos/Graham-72/plupload/contributors","subscribers_url":"https://api.github.com/repos/Graham-72/plupload/subscribers","subscription_url":"https://api.github.com/repos/Graham-72/plupload/subscription","commits_url":"https://api.github.com/repos/Graham-72/plupload/commits{/sha}","git_commits_url":"https://api.github.com/repos/Graham-72/plupload/git/commits{/sha}","comments_url":"https://api.github.com/repos/Graham-72/plupload/comments{/number}","issue_comment_url":"https://api.github.com/repos/Graham-72/plupload/issues/comments{/number}","contents_url":"https://api.github.com/repos/Graham-72/plupload/contents/{+path}","compare_url":"https://api.github.com/repos/Graham-72/plupload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Graham-72/plupload/merges","archive_url":"https://api.github.com/repos/Graham-72/plupload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Graham-72/plupload/downloads","issues_url":"https://api.github.com/repos/Graham-72/plupload/issues{/number}","pulls_url":"https://api.github.com/repos/Graham-72/plupload/pulls{/number}","milestones_url":"https://api.github.com/repos/Graham-72/plupload/milestones{/number}","notifications_url":"https://api.github.com/repos/Graham-72/plupload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Graham-72/plupload/labels{/name}","releases_url":"https://api.github.com/repos/Graham-72/plupload/releases{/id}","deployments_url":"https://api.github.com/repos/Graham-72/plupload/deployments","created_at":"2019-06-28T07:32:34Z","updated_at":"2019-06-28T07:32:36Z","pushed_at":"2019-07-01T06:57:47Z","git_url":"git://github.com/Graham-72/plupload.git","ssh_url":"git@github.com:Graham-72/plupload.git","clone_url":"https://github.com/Graham-72/plupload.git","svn_url":"https://github.com/Graham-72/plupload","homepage":"https://backdropcms.org/project/plupload","size":414,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x-1.x"}},"base":{"label":"backdrop-contrib:1.x-1.x","ref":"1.x-1.x","sha":"3d3c4b12f81b9e82a99ca2277f163b070bbcf544","user":{"login":"backdrop-contrib","id":7720679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3MjA2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/7720679?v=4","gravatar_id":"","url":"https://api.github.com/users/backdrop-contrib","html_url":"https://github.com/backdrop-contrib","followers_url":"https://api.github.com/users/backdrop-contrib/followers","following_url":"https://api.github.com/users/backdrop-contrib/following{/other_user}","gists_url":"https://api.github.com/users/backdrop-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/backdrop-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backdrop-contrib/subscriptions","organizations_url":"https://api.github.com/users/backdrop-contrib/orgs","repos_url":"https://api.github.com/users/backdrop-contrib/repos","events_url":"https://api.github.com/users/backdrop-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/backdrop-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":56396390,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM5NjM5MA==","name":"plupload","full_name":"backdrop-contrib/plupload","private":false,"owner":{"login":"backdrop-contrib","id":7720679,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3MjA2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/7720679?v=4","gravatar_id":"","url":"https://api.github.com/users/backdrop-contrib","html_url":"https://github.com/backdrop-contrib","followers_url":"https://api.github.com/users/backdrop-contrib/followers","following_url":"https://api.github.com/users/backdrop-contrib/following{/other_user}","gists_url":"https://api.github.com/users/backdrop-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/backdrop-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backdrop-contrib/subscriptions","organizations_url":"https://api.github.com/users/backdrop-contrib/orgs","repos_url":"https://api.github.com/users/backdrop-contrib/repos","events_url":"https://api.github.com/users/backdrop-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/backdrop-contrib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/backdrop-contrib/plupload","description":"Integrates the Plupload library with Backdrop forms.","fork":false,"url":"https://api.github.com/repos/backdrop-contrib/plupload","forks_url":"https://api.github.com/repos/backdrop-contrib/plupload/forks","keys_url":"https://api.github.com/repos/backdrop-contrib/plupload/keys{/key_id}","collaborators_url":"https://api.github.com/repos/backdrop-contrib/plupload/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/backdrop-contrib/plupload/teams","hooks_url":"https://api.github.com/repos/backdrop-contrib/plupload/hooks","issue_events_url":"https://api.github.com/repos/backdrop-contrib/plupload/issues/events{/number}","events_url":"https://api.github.com/repos/backdrop-contrib/plupload/events","assignees_url":"https://api.github.com/repos/backdrop-contrib/plupload/assignees{/user}","branches_url":"https://api.github.com/repos/backdrop-contrib/plupload/branches{/branch}","tags_url":"https://api.github.com/repos/backdrop-contrib/plupload/tags","blobs_url":"https://api.github.com/repos/backdrop-contrib/plupload/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/backdrop-contrib/plupload/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/backdrop-contrib/plupload/git/refs{/sha}","trees_url":"https://api.github.com/repos/backdrop-contrib/plupload/git/trees{/sha}","statuses_url":"https://api.github.com/repos/backdrop-contrib/plupload/statuses/{sha}","languages_url":"https://api.github.com/repos/backdrop-contrib/plupload/languages","stargazers_url":"https://api.github.com/repos/backdrop-contrib/plupload/stargazers","contributors_url":"https://api.github.com/repos/backdrop-contrib/plupload/contributors","subscribers_url":"https://api.github.com/repos/backdrop-contrib/plupload/subscribers","subscription_url":"https://api.github.com/repos/backdrop-contrib/plupload/subscription","commits_url":"https://api.github.com/repos/backdrop-contrib/plupload/commits{/sha}","git_commits_url":"https://api.github.com/repos/backdrop-contrib/plupload/git/commits{/sha}","comments_url":"https://api.github.com/repos/backdrop-contrib/plupload/comments{/number}","issue_comment_url":"https://api.github.com/repos/backdrop-contrib/plupload/issues/comments{/number}","contents_url":"https://api.github.com/repos/backdrop-contrib/plupload/contents/{+path}","compare_url":"https://api.github.com/repos/backdrop-contrib/plupload/compare/{base}...{head}","merges_url":"https://api.github.com/repos/backdrop-contrib/plupload/merges","archive_url":"https://api.github.com/repos/backdrop-contrib/plupload/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/backdrop-contrib/plupload/downloads","issues_url":"https://api.github.com/repos/backdrop-contrib/plupload/issues{/number}","pulls_url":"https://api.github.com/repos/backdrop-contrib/plupload/pulls{/number}","milestones_url":"https://api.github.com/repos/backdrop-contrib/plupload/milestones{/number}","notifications_url":"https://api.github.com/repos/backdrop-contrib/plupload/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/backdrop-contrib/plupload/labels{/name}","releases_url":"https://api.github.com/repos/backdrop-contrib/plupload/releases{/id}","deployments_url":"https://api.github.com/repos/backdrop-contrib/plupload/deployments","created_at":"2016-04-16T17:22:48Z","updated_at":"2019-07-01T06:30:38Z","pushed_at":"2019-07-01T06:57:48Z","git_url":"git://github.com/backdrop-contrib/plupload.git","ssh_url":"git@github.com:backdrop-contrib/plupload.git","clone_url":"https://github.com/backdrop-contrib/plupload.git","svn_url":"https://github.com/backdrop-contrib/plupload","homepage":"https://backdropcms.org/project/plupload","size":162,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2,"open_issues":4,"watchers":0,"default_branch":"1.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6"},"html":{"href":"https://github.com/backdrop-contrib/plupload/pull/6"},"issue":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/issues/6"},"comments":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/backdrop-contrib/plupload/statuses/d4544872e85b161a22f28ece85415836c6dc0a55"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Graham-72"}}