{"action":"created","comment":{"url":"https://api.github.com/repos/1024pix/pix/pulls/comments/348333124","pull_request_review_id":319647935,"id":348333124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODMzMzEyNA==","diff_hunk":"@@ -67,4 +68,11 @@ export default Component.extend({\n     return this.mailGenerator\n       .generateEmail(this.get('challenge.id'), this.get('assessment.id'), window.location.hostname, config.environment);\n   },\n+\n+  _initIllustrationAlt() {\n+    if (!this.get('challenge.illustrationAlt')) {\n+      const defaultAlt = 'Illustration de l\\'épreuve';\n+      this.set('challenge.illustrationAlt', defaultAlt);","path":"mon-pix/app/components/challenge-statement.js","position":16,"original_position":16,"commit_id":"84e4ec35ac8b24d5237b7d46513da714404daefd","original_commit_id":"84e4ec35ac8b24d5237b7d46513da714404daefd","user":{"login":"laura-bergoens","id":48727874,"node_id":"MDQ6VXNlcjQ4NzI3ODc0","avatar_url":"https://avatars3.githubusercontent.com/u/48727874?v=4","gravatar_id":"","url":"https://api.github.com/users/laura-bergoens","html_url":"https://github.com/laura-bergoens","followers_url":"https://api.github.com/users/laura-bergoens/followers","following_url":"https://api.github.com/users/laura-bergoens/following{/other_user}","gists_url":"https://api.github.com/users/laura-bergoens/gists{/gist_id}","starred_url":"https://api.github.com/users/laura-bergoens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laura-bergoens/subscriptions","organizations_url":"https://api.github.com/users/laura-bergoens/orgs","repos_url":"https://api.github.com/users/laura-bergoens/repos","events_url":"https://api.github.com/users/laura-bergoens/events{/privacy}","received_events_url":"https://api.github.com/users/laura-bergoens/received_events","type":"User","site_admin":false},"body":"Pourquoi ne pas mettre la valeur par défaut dans le model challenge, plutôt que de faire l'initialisation de cette valeur par défaut dans le component?","created_at":"2019-11-20T07:56:37Z","updated_at":"2019-11-20T07:58:07Z","html_url":"https://github.com/1024pix/pix/pull/846#discussion_r348333124","pull_request_url":"https://api.github.com/repos/1024pix/pix/pulls/846","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/1024pix/pix/pulls/comments/348333124"},"html":{"href":"https://github.com/1024pix/pix/pull/846#discussion_r348333124"},"pull_request":{"href":"https://api.github.com/repos/1024pix/pix/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/1024pix/pix/pulls/846","id":342750139,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyNzUwMTM5","html_url":"https://github.com/1024pix/pix/pull/846","diff_url":"https://github.com/1024pix/pix/pull/846.diff","patch_url":"https://github.com/1024pix/pix/pull/846.patch","issue_url":"https://api.github.com/repos/1024pix/pix/issues/846","number":846,"state":"open","locked":false,"title":"[A11Y] Ajouter ALT sur les images dans les challenges","user":{"login":"celineung","id":11294487,"node_id":"MDQ6VXNlcjExMjk0NDg3","avatar_url":"https://avatars1.githubusercontent.com/u/11294487?v=4","gravatar_id":"","url":"https://api.github.com/users/celineung","html_url":"https://github.com/celineung","followers_url":"https://api.github.com/users/celineung/followers","following_url":"https://api.github.com/users/celineung/following{/other_user}","gists_url":"https://api.github.com/users/celineung/gists{/gist_id}","starred_url":"https://api.github.com/users/celineung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celineung/subscriptions","organizations_url":"https://api.github.com/users/celineung/orgs","repos_url":"https://api.github.com/users/celineung/repos","events_url":"https://api.github.com/users/celineung/events{/privacy}","received_events_url":"https://api.github.com/users/celineung/received_events","type":"User","site_admin":false},"body":"## :unicorn: Problème\r\nPour les malvoyants, ajouter un texte alternatif à l'image présente dans les challenges.\r\n\r\n## :robot: Solution\r\nUn champ `Texte alternatif illustration` existe déjà sur Airtable.\r\nCette PR récupère cette variable et l'injecte dans l'attribut `alt` de l'image d'un challenge.\r\n\r\n## :rainbow: Remarques\r\nL'objet `challenge` retourné au front contient alors `illustrationUrl` et `illustrationAlt` (_+ autres propriétés_).\r\nPensez-vous qu'il est intéressant et possible factoriser en un objet `illustration: { url, alt }` sans utiliser les serializers ember? Car l'objet `illustration` ne respecte pas le format JSONAPI (il n'a pas d'_id_).\r\nLa solution des serializers transformerait l'objet `illustration` au format API, mais dans ce cas là, autant l'aplatir dans dans le back comme c'est fait dans cette PR.","created_at":"2019-11-19T15:47:43Z","updated_at":"2019-11-20T07:58:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13ae4d2a44811daf3ad961e56d4f6e723379da8e","assignee":{"login":"celineung","id":11294487,"node_id":"MDQ6VXNlcjExMjk0NDg3","avatar_url":"https://avatars1.githubusercontent.com/u/11294487?v=4","gravatar_id":"","url":"https://api.github.com/users/celineung","html_url":"https://github.com/celineung","followers_url":"https://api.github.com/users/celineung/followers","following_url":"https://api.github.com/users/celineung/following{/other_user}","gists_url":"https://api.github.com/users/celineung/gists{/gist_id}","starred_url":"https://api.github.com/users/celineung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celineung/subscriptions","organizations_url":"https://api.github.com/users/celineung/orgs","repos_url":"https://api.github.com/users/celineung/repos","events_url":"https://api.github.com/users/celineung/events{/privacy}","received_events_url":"https://api.github.com/users/celineung/received_events","type":"User","site_admin":false},"assignees":[{"login":"celineung","id":11294487,"node_id":"MDQ6VXNlcjExMjk0NDg3","avatar_url":"https://avatars1.githubusercontent.com/u/11294487?v=4","gravatar_id":"","url":"https://api.github.com/users/celineung","html_url":"https://github.com/celineung","followers_url":"https://api.github.com/users/celineung/followers","following_url":"https://api.github.com/users/celineung/following{/other_user}","gists_url":"https://api.github.com/users/celineung/gists{/gist_id}","starred_url":"https://api.github.com/users/celineung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celineung/subscriptions","organizations_url":"https://api.github.com/users/celineung/orgs","repos_url":"https://api.github.com/users/celineung/repos","events_url":"https://api.github.com/users/celineung/events{/privacy}","received_events_url":"https://api.github.com/users/celineung/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1233307524,"node_id":"MDU6TGFiZWwxMjMzMzA3NTI0","url":"https://api.github.com/repos/1024pix/pix/labels/Func%20Review%20Needed","name":"Func Review Needed","color":"540d6e","default":false,"description":""},{"id":1128820237,"node_id":"MDU6TGFiZWwxMTI4ODIwMjM3","url":"https://api.github.com/repos/1024pix/pix/labels/Tech%20Review%20Needed","name":"Tech Review Needed","color":"ee4266","default":false,"description":""},{"id":1685662464,"node_id":"MDU6TGFiZWwxNjg1NjYyNDY0","url":"https://api.github.com/repos/1024pix/pix/labels/team-%C3%A9valuation","name":"team-évaluation","color":"ffe066","default":false,"description":"PR relatives à l'expérience d'évaluation"}],"milestone":null,"commits_url":"https://api.github.com/repos/1024pix/pix/pulls/846/commits","review_comments_url":"https://api.github.com/repos/1024pix/pix/pulls/846/comments","review_comment_url":"https://api.github.com/repos/1024pix/pix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/1024pix/pix/issues/846/comments","statuses_url":"https://api.github.com/repos/1024pix/pix/statuses/84e4ec35ac8b24d5237b7d46513da714404daefd","head":{"label":"1024pix:pf-912-alt-image-challenge-page","ref":"pf-912-alt-image-challenge-page","sha":"84e4ec35ac8b24d5237b7d46513da714404daefd","user":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"repo":{"id":126852331,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NTIzMzE=","name":"pix","full_name":"1024pix/pix","private":false,"owner":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/1024pix/pix","description":"Service public d'évaluation et de certification des compétences numériques pour tous.","fork":false,"url":"https://api.github.com/repos/1024pix/pix","forks_url":"https://api.github.com/repos/1024pix/pix/forks","keys_url":"https://api.github.com/repos/1024pix/pix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1024pix/pix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1024pix/pix/teams","hooks_url":"https://api.github.com/repos/1024pix/pix/hooks","issue_events_url":"https://api.github.com/repos/1024pix/pix/issues/events{/number}","events_url":"https://api.github.com/repos/1024pix/pix/events","assignees_url":"https://api.github.com/repos/1024pix/pix/assignees{/user}","branches_url":"https://api.github.com/repos/1024pix/pix/branches{/branch}","tags_url":"https://api.github.com/repos/1024pix/pix/tags","blobs_url":"https://api.github.com/repos/1024pix/pix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1024pix/pix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1024pix/pix/git/refs{/sha}","trees_url":"https://api.github.com/repos/1024pix/pix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1024pix/pix/statuses/{sha}","languages_url":"https://api.github.com/repos/1024pix/pix/languages","stargazers_url":"https://api.github.com/repos/1024pix/pix/stargazers","contributors_url":"https://api.github.com/repos/1024pix/pix/contributors","subscribers_url":"https://api.github.com/repos/1024pix/pix/subscribers","subscription_url":"https://api.github.com/repos/1024pix/pix/subscription","commits_url":"https://api.github.com/repos/1024pix/pix/commits{/sha}","git_commits_url":"https://api.github.com/repos/1024pix/pix/git/commits{/sha}","comments_url":"https://api.github.com/repos/1024pix/pix/comments{/number}","issue_comment_url":"https://api.github.com/repos/1024pix/pix/issues/comments{/number}","contents_url":"https://api.github.com/repos/1024pix/pix/contents/{+path}","compare_url":"https://api.github.com/repos/1024pix/pix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1024pix/pix/merges","archive_url":"https://api.github.com/repos/1024pix/pix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1024pix/pix/downloads","issues_url":"https://api.github.com/repos/1024pix/pix/issues{/number}","pulls_url":"https://api.github.com/repos/1024pix/pix/pulls{/number}","milestones_url":"https://api.github.com/repos/1024pix/pix/milestones{/number}","notifications_url":"https://api.github.com/repos/1024pix/pix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1024pix/pix/labels{/name}","releases_url":"https://api.github.com/repos/1024pix/pix/releases{/id}","deployments_url":"https://api.github.com/repos/1024pix/pix/deployments","created_at":"2018-03-26T15:47:12Z","updated_at":"2019-11-19T15:58:30Z","pushed_at":"2019-11-19T18:43:55Z","git_url":"git://github.com/1024pix/pix.git","ssh_url":"git@github.com:1024pix/pix.git","clone_url":"https://github.com/1024pix/pix.git","svn_url":"https://github.com/1024pix/pix","homepage":"https://pix.fr","size":51053,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":13,"open_issues":27,"watchers":53,"default_branch":"dev"}},"base":{"label":"1024pix:dev","ref":"dev","sha":"ac064ec4ff694916f2c9cababec7fcae6a5e4ccf","user":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"repo":{"id":126852331,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NTIzMzE=","name":"pix","full_name":"1024pix/pix","private":false,"owner":{"login":"1024pix","id":24589578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg5NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/24589578?v=4","gravatar_id":"","url":"https://api.github.com/users/1024pix","html_url":"https://github.com/1024pix","followers_url":"https://api.github.com/users/1024pix/followers","following_url":"https://api.github.com/users/1024pix/following{/other_user}","gists_url":"https://api.github.com/users/1024pix/gists{/gist_id}","starred_url":"https://api.github.com/users/1024pix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1024pix/subscriptions","organizations_url":"https://api.github.com/users/1024pix/orgs","repos_url":"https://api.github.com/users/1024pix/repos","events_url":"https://api.github.com/users/1024pix/events{/privacy}","received_events_url":"https://api.github.com/users/1024pix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/1024pix/pix","description":"Service public d'évaluation et de certification des compétences numériques pour tous.","fork":false,"url":"https://api.github.com/repos/1024pix/pix","forks_url":"https://api.github.com/repos/1024pix/pix/forks","keys_url":"https://api.github.com/repos/1024pix/pix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1024pix/pix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1024pix/pix/teams","hooks_url":"https://api.github.com/repos/1024pix/pix/hooks","issue_events_url":"https://api.github.com/repos/1024pix/pix/issues/events{/number}","events_url":"https://api.github.com/repos/1024pix/pix/events","assignees_url":"https://api.github.com/repos/1024pix/pix/assignees{/user}","branches_url":"https://api.github.com/repos/1024pix/pix/branches{/branch}","tags_url":"https://api.github.com/repos/1024pix/pix/tags","blobs_url":"https://api.github.com/repos/1024pix/pix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1024pix/pix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1024pix/pix/git/refs{/sha}","trees_url":"https://api.github.com/repos/1024pix/pix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1024pix/pix/statuses/{sha}","languages_url":"https://api.github.com/repos/1024pix/pix/languages","stargazers_url":"https://api.github.com/repos/1024pix/pix/stargazers","contributors_url":"https://api.github.com/repos/1024pix/pix/contributors","subscribers_url":"https://api.github.com/repos/1024pix/pix/subscribers","subscription_url":"https://api.github.com/repos/1024pix/pix/subscription","commits_url":"https://api.github.com/repos/1024pix/pix/commits{/sha}","git_commits_url":"https://api.github.com/repos/1024pix/pix/git/commits{/sha}","comments_url":"https://api.github.com/repos/1024pix/pix/comments{/number}","issue_comment_url":"https://api.github.com/repos/1024pix/pix/issues/comments{/number}","contents_url":"https://api.github.com/repos/1024pix/pix/contents/{+path}","compare_url":"https://api.github.com/repos/1024pix/pix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1024pix/pix/merges","archive_url":"https://api.github.com/repos/1024pix/pix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1024pix/pix/downloads","issues_url":"https://api.github.com/repos/1024pix/pix/issues{/number}","pulls_url":"https://api.github.com/repos/1024pix/pix/pulls{/number}","milestones_url":"https://api.github.com/repos/1024pix/pix/milestones{/number}","notifications_url":"https://api.github.com/repos/1024pix/pix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1024pix/pix/labels{/name}","releases_url":"https://api.github.com/repos/1024pix/pix/releases{/id}","deployments_url":"https://api.github.com/repos/1024pix/pix/deployments","created_at":"2018-03-26T15:47:12Z","updated_at":"2019-11-19T15:58:30Z","pushed_at":"2019-11-19T18:43:55Z","git_url":"git://github.com/1024pix/pix.git","ssh_url":"git@github.com:1024pix/pix.git","clone_url":"https://github.com/1024pix/pix.git","svn_url":"https://github.com/1024pix/pix","homepage":"https://pix.fr","size":51053,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":13,"open_issues":27,"watchers":53,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/1024pix/pix/pulls/846"},"html":{"href":"https://github.com/1024pix/pix/pull/846"},"issue":{"href":"https://api.github.com/repos/1024pix/pix/issues/846"},"comments":{"href":"https://api.github.com/repos/1024pix/pix/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/1024pix/pix/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/1024pix/pix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/1024pix/pix/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/1024pix/pix/statuses/84e4ec35ac8b24d5237b7d46513da714404daefd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laura-bergoens"}}