{"action":"created","comment":{"url":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments/294447122","pull_request_review_id":250673840,"id":294447122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDQ0NzEyMg==","diff_hunk":"@@ -56,7 +55,8 @@ COPY [ \"splunk/common-files/updateetc.sh\", \"/sbin/\" ]\n \n # Setup users and groups\n RUN groupadd -r -g ${GID} ${SPLUNK_GROUP} \\\n-    && useradd -r -m -u ${UID} -g ${GID} ${SPLUNK_USER} \\\n+    && useradd -r -m -u ${UID} -g ${GID} -s /sbin/nologin -d ${SPLUNK_HOME} ${SPLUNK_USER} \\","path":"splunk/common-files/Dockerfile","position":24,"original_position":24,"commit_id":"feba747ef00b23b66b19f2355f3dcd690f3424e2","original_commit_id":"feba747ef00b23b66b19f2355f3dcd690f3424e2","user":{"login":"mikedickey","id":1159596,"node_id":"MDQ6VXNlcjExNTk1OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1159596?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedickey","html_url":"https://github.com/mikedickey","followers_url":"https://api.github.com/users/mikedickey/followers","following_url":"https://api.github.com/users/mikedickey/following{/other_user}","gists_url":"https://api.github.com/users/mikedickey/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedickey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedickey/subscriptions","organizations_url":"https://api.github.com/users/mikedickey/orgs","repos_url":"https://api.github.com/users/mikedickey/repos","events_url":"https://api.github.com/users/mikedickey/events{/privacy}","received_events_url":"https://api.github.com/users/mikedickey/received_events","type":"User","site_admin":false},"body":"It seemed confusing to me to have a \"SPLUNK_HOME\" which was not the same as the home directory for the user splunk. I assumed this was made different inadvertently by not explicitly specifying a home to `useradd`. I don't feel strongly about it one way or the other, and am curious to learn benefits of splitting it out.","created_at":"2019-06-17T18:32:11Z","updated_at":"2019-06-17T18:32:11Z","html_url":"https://github.com/splunk/docker-splunk/pull/202#discussion_r294447122","pull_request_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/202","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments/294447122"},"html":{"href":"https://github.com/splunk/docker-splunk/pull/202#discussion_r294447122"},"pull_request":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/202"}},"in_reply_to_id":294221238},"pull_request":{"url":"https://api.github.com/repos/splunk/docker-splunk/pulls/202","id":287316012,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3MzE2MDEy","html_url":"https://github.com/splunk/docker-splunk/pull/202","diff_url":"https://github.com/splunk/docker-splunk/pull/202.diff","patch_url":"https://github.com/splunk/docker-splunk/pull/202.patch","issue_url":"https://api.github.com/repos/splunk/docker-splunk/issues/202","number":202,"state":"closed","locked":false,"title":"Added /opt/splunk/etc to image and made some updates to splunk's home","user":{"login":"mikedickey","id":1159596,"node_id":"MDQ6VXNlcjExNTk1OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1159596?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedickey","html_url":"https://github.com/mikedickey","followers_url":"https://api.github.com/users/mikedickey/followers","following_url":"https://api.github.com/users/mikedickey/following{/other_user}","gists_url":"https://api.github.com/users/mikedickey/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedickey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedickey/subscriptions","organizations_url":"https://api.github.com/users/mikedickey/orgs","repos_url":"https://api.github.com/users/mikedickey/repos","events_url":"https://api.github.com/users/mikedickey/events{/privacy}","received_events_url":"https://api.github.com/users/mikedickey/received_events","type":"User","site_admin":false},"body":"Thinking this would fix the /opt/splunk/etc permission failures in splunk-ansible","created_at":"2019-06-12T01:27:12Z","updated_at":"2019-06-17T18:32:11Z","closed_at":"2019-06-14T21:21:27Z","merged_at":"2019-06-14T21:21:27Z","merge_commit_sha":"6b78733bd599e274f872895c1460b174ed416e82","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bb03","id":1892161,"node_id":"MDQ6VXNlcjE4OTIxNjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1892161?v=4","gravatar_id":"","url":"https://api.github.com/users/bb03","html_url":"https://github.com/bb03","followers_url":"https://api.github.com/users/bb03/followers","following_url":"https://api.github.com/users/bb03/following{/other_user}","gists_url":"https://api.github.com/users/bb03/gists{/gist_id}","starred_url":"https://api.github.com/users/bb03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb03/subscriptions","organizations_url":"https://api.github.com/users/bb03/orgs","repos_url":"https://api.github.com/users/bb03/repos","events_url":"https://api.github.com/users/bb03/events{/privacy}","received_events_url":"https://api.github.com/users/bb03/received_events","type":"User","site_admin":false},{"login":"lephino","id":2249857,"node_id":"MDQ6VXNlcjIyNDk4NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2249857?v=4","gravatar_id":"","url":"https://api.github.com/users/lephino","html_url":"https://github.com/lephino","followers_url":"https://api.github.com/users/lephino/followers","following_url":"https://api.github.com/users/lephino/following{/other_user}","gists_url":"https://api.github.com/users/lephino/gists{/gist_id}","starred_url":"https://api.github.com/users/lephino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lephino/subscriptions","organizations_url":"https://api.github.com/users/lephino/orgs","repos_url":"https://api.github.com/users/lephino/repos","events_url":"https://api.github.com/users/lephino/events{/privacy}","received_events_url":"https://api.github.com/users/lephino/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/202/commits","review_comments_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/202/comments","review_comment_url":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splunk/docker-splunk/issues/202/comments","statuses_url":"https://api.github.com/repos/splunk/docker-splunk/statuses/feba747ef00b23b66b19f2355f3dcd690f3424e2","head":{"label":"splunk:add-etc-directory-fix-home","ref":"add-etc-directory-fix-home","sha":"feba747ef00b23b66b19f2355f3dcd690f3424e2","user":{"login":"splunk","id":651467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTQ2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/651467?v=4","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"repo":{"id":150320454,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMjA0NTQ=","name":"docker-splunk","full_name":"splunk/docker-splunk","private":false,"owner":{"login":"splunk","id":651467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTQ2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/651467?v=4","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/splunk/docker-splunk","description":"Splunk Docker GitHub Repository","fork":false,"url":"https://api.github.com/repos/splunk/docker-splunk","forks_url":"https://api.github.com/repos/splunk/docker-splunk/forks","keys_url":"https://api.github.com/repos/splunk/docker-splunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splunk/docker-splunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splunk/docker-splunk/teams","hooks_url":"https://api.github.com/repos/splunk/docker-splunk/hooks","issue_events_url":"https://api.github.com/repos/splunk/docker-splunk/issues/events{/number}","events_url":"https://api.github.com/repos/splunk/docker-splunk/events","assignees_url":"https://api.github.com/repos/splunk/docker-splunk/assignees{/user}","branches_url":"https://api.github.com/repos/splunk/docker-splunk/branches{/branch}","tags_url":"https://api.github.com/repos/splunk/docker-splunk/tags","blobs_url":"https://api.github.com/repos/splunk/docker-splunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splunk/docker-splunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splunk/docker-splunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/splunk/docker-splunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splunk/docker-splunk/statuses/{sha}","languages_url":"https://api.github.com/repos/splunk/docker-splunk/languages","stargazers_url":"https://api.github.com/repos/splunk/docker-splunk/stargazers","contributors_url":"https://api.github.com/repos/splunk/docker-splunk/contributors","subscribers_url":"https://api.github.com/repos/splunk/docker-splunk/subscribers","subscription_url":"https://api.github.com/repos/splunk/docker-splunk/subscription","commits_url":"https://api.github.com/repos/splunk/docker-splunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/splunk/docker-splunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/splunk/docker-splunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/splunk/docker-splunk/issues/comments{/number}","contents_url":"https://api.github.com/repos/splunk/docker-splunk/contents/{+path}","compare_url":"https://api.github.com/repos/splunk/docker-splunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splunk/docker-splunk/merges","archive_url":"https://api.github.com/repos/splunk/docker-splunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splunk/docker-splunk/downloads","issues_url":"https://api.github.com/repos/splunk/docker-splunk/issues{/number}","pulls_url":"https://api.github.com/repos/splunk/docker-splunk/pulls{/number}","milestones_url":"https://api.github.com/repos/splunk/docker-splunk/milestones{/number}","notifications_url":"https://api.github.com/repos/splunk/docker-splunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splunk/docker-splunk/labels{/name}","releases_url":"https://api.github.com/repos/splunk/docker-splunk/releases{/id}","deployments_url":"https://api.github.com/repos/splunk/docker-splunk/deployments","created_at":"2018-09-25T19:43:22Z","updated_at":"2019-06-14T21:21:29Z","pushed_at":"2019-06-14T21:21:28Z","git_url":"git://github.com/splunk/docker-splunk.git","ssh_url":"git@github.com:splunk/docker-splunk.git","clone_url":"https://github.com/splunk/docker-splunk.git","svn_url":"https://github.com/splunk/docker-splunk","homepage":null,"size":1114,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":null,"forks":59,"open_issues":7,"watchers":80,"default_branch":"develop"}},"base":{"label":"splunk:develop","ref":"develop","sha":"18416b0b7e2deb5bf1d985572753c3eeb6b586a5","user":{"login":"splunk","id":651467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTQ2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/651467?v=4","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"repo":{"id":150320454,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMjA0NTQ=","name":"docker-splunk","full_name":"splunk/docker-splunk","private":false,"owner":{"login":"splunk","id":651467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTQ2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/651467?v=4","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/splunk/docker-splunk","description":"Splunk Docker GitHub Repository","fork":false,"url":"https://api.github.com/repos/splunk/docker-splunk","forks_url":"https://api.github.com/repos/splunk/docker-splunk/forks","keys_url":"https://api.github.com/repos/splunk/docker-splunk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splunk/docker-splunk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splunk/docker-splunk/teams","hooks_url":"https://api.github.com/repos/splunk/docker-splunk/hooks","issue_events_url":"https://api.github.com/repos/splunk/docker-splunk/issues/events{/number}","events_url":"https://api.github.com/repos/splunk/docker-splunk/events","assignees_url":"https://api.github.com/repos/splunk/docker-splunk/assignees{/user}","branches_url":"https://api.github.com/repos/splunk/docker-splunk/branches{/branch}","tags_url":"https://api.github.com/repos/splunk/docker-splunk/tags","blobs_url":"https://api.github.com/repos/splunk/docker-splunk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splunk/docker-splunk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splunk/docker-splunk/git/refs{/sha}","trees_url":"https://api.github.com/repos/splunk/docker-splunk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splunk/docker-splunk/statuses/{sha}","languages_url":"https://api.github.com/repos/splunk/docker-splunk/languages","stargazers_url":"https://api.github.com/repos/splunk/docker-splunk/stargazers","contributors_url":"https://api.github.com/repos/splunk/docker-splunk/contributors","subscribers_url":"https://api.github.com/repos/splunk/docker-splunk/subscribers","subscription_url":"https://api.github.com/repos/splunk/docker-splunk/subscription","commits_url":"https://api.github.com/repos/splunk/docker-splunk/commits{/sha}","git_commits_url":"https://api.github.com/repos/splunk/docker-splunk/git/commits{/sha}","comments_url":"https://api.github.com/repos/splunk/docker-splunk/comments{/number}","issue_comment_url":"https://api.github.com/repos/splunk/docker-splunk/issues/comments{/number}","contents_url":"https://api.github.com/repos/splunk/docker-splunk/contents/{+path}","compare_url":"https://api.github.com/repos/splunk/docker-splunk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splunk/docker-splunk/merges","archive_url":"https://api.github.com/repos/splunk/docker-splunk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splunk/docker-splunk/downloads","issues_url":"https://api.github.com/repos/splunk/docker-splunk/issues{/number}","pulls_url":"https://api.github.com/repos/splunk/docker-splunk/pulls{/number}","milestones_url":"https://api.github.com/repos/splunk/docker-splunk/milestones{/number}","notifications_url":"https://api.github.com/repos/splunk/docker-splunk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splunk/docker-splunk/labels{/name}","releases_url":"https://api.github.com/repos/splunk/docker-splunk/releases{/id}","deployments_url":"https://api.github.com/repos/splunk/docker-splunk/deployments","created_at":"2018-09-25T19:43:22Z","updated_at":"2019-06-14T21:21:29Z","pushed_at":"2019-06-14T21:21:28Z","git_url":"git://github.com/splunk/docker-splunk.git","ssh_url":"git@github.com:splunk/docker-splunk.git","clone_url":"https://github.com/splunk/docker-splunk.git","svn_url":"https://github.com/splunk/docker-splunk","homepage":null,"size":1114,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":null,"forks":59,"open_issues":7,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/202"},"html":{"href":"https://github.com/splunk/docker-splunk/pull/202"},"issue":{"href":"https://api.github.com/repos/splunk/docker-splunk/issues/202"},"comments":{"href":"https://api.github.com/repos/splunk/docker-splunk/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splunk/docker-splunk/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/splunk/docker-splunk/statuses/feba747ef00b23b66b19f2355f3dcd690f3424e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikedickey"}}