{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/307595782","pull_request_review_id":267000105,"id":307595782,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzU5NTc4Mg==","diff_hunk":"@@ -81,16 +81,19 @@ static ucs_config_field_t ucp_config_table[] = {\n \n   {\"TLS\", UCP_RSC_CONFIG_ALL,\n    \"Comma-separated list of transports to use. The order is not meaningful.\\n\"\n-   \" - all    : use all the available transports.\\n\"\n-   \" - sm/shm : all shared memory transports.\\n\"\n-   \" - mm     : shared memory transports - only memory mappers.\\n\"\n-   \" - ugni   : ugni_rdma and ugni_udt.\\n\"\n-   \" - ib     : all infiniband transports.\\n\"\n-   \" - rc     : rc verbs (uses ud for bootstrap).\\n\"\n-   \" - rc_x   : rc with accelerated verbs (uses ud_x for bootstrap).\\n\"\n-   \" - ud     : ud verbs.\\n\"\n-   \" - ud_x   : ud with accelerated verbs.\\n\"\n-   \" - dc_x   : dc with accelerated verbs.\\n\"\n+   \" - all     : use all the available transports.\\n\"\n+   \" - sm/shm  : all shared memory transports.\\n\"\n+   \" - mm      : shared memory transports - only memory mappers.\\n\"\n+   \" - ugni    : ugni_rdma and ugni_udt.\\n\"\n+   \" - ib      : all infiniband transports.\\n\"\n+   \" - rc_v    : rc verbs (uses ud for bootstrap).\\n\"\n+   \" - rc_x    : rc with accelerated verbs (uses ud_x for bootstrap).\\n\"\n+   \" - rc      : rc_v and rc_x (preferably if available) together\"\n+   \" - ud_v    : ud verbs.\\n\"\n+   \" - ud_x    : ud with accelerated verbs.\\n\"\n+   \" - ud      : ud_v and ud_x (preferably if available) together\"","path":"src/ucp/core/ucp_context.c","position":24,"original_position":24,"commit_id":"79aa71ac276367dc198d0de0e12fd576581fa5cd","original_commit_id":"79aa71ac276367dc198d0de0e12fd576581fa5cd","user":{"login":"brminich","id":14221180,"node_id":"MDQ6VXNlcjE0MjIxMTgw","avatar_url":"https://avatars1.githubusercontent.com/u/14221180?v=4","gravatar_id":"","url":"https://api.github.com/users/brminich","html_url":"https://github.com/brminich","followers_url":"https://api.github.com/users/brminich/followers","following_url":"https://api.github.com/users/brminich/following{/other_user}","gists_url":"https://api.github.com/users/brminich/gists{/gist_id}","starred_url":"https://api.github.com/users/brminich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brminich/subscriptions","organizations_url":"https://api.github.com/users/brminich/orgs","repos_url":"https://api.github.com/users/brminich/repos","events_url":"https://api.github.com/users/brminich/events{/privacy}","received_events_url":"https://api.github.com/users/brminich/received_events","type":"User","site_admin":false},"body":"`.` in the end and I'd remove `together`","created_at":"2019-07-26T05:45:46Z","updated_at":"2019-07-26T05:47:46Z","html_url":"https://github.com/openucx/ucx/pull/3958#discussion_r307595782","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/3958","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/307595782"},"html":{"href":"https://github.com/openucx/ucx/pull/3958#discussion_r307595782"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3958"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/3958","id":301234541,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMjM0NTQx","html_url":"https://github.com/openucx/ucx/pull/3958","diff_url":"https://github.com/openucx/ucx/pull/3958.diff","patch_url":"https://github.com/openucx/ucx/pull/3958.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/3958","number":3958,"state":"open","locked":false,"title":"UCP/CORE: Fix TLS config attribute description","user":{"login":"dmitrygx","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygx","html_url":"https://github.com/dmitrygx","followers_url":"https://api.github.com/users/dmitrygx/followers","following_url":"https://api.github.com/users/dmitrygx/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygx/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygx/subscriptions","organizations_url":"https://api.github.com/users/dmitrygx/orgs","repos_url":"https://api.github.com/users/dmitrygx/repos","events_url":"https://api.github.com/users/dmitrygx/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygx/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nFix TLS config attribute description + minor comment fixes for max_eps and max_ppn\r\n\r\n## Why ?\r\n\r\nAlign with recent changes + add TCP\r\n\r\n## How ?\r\n\r\nUpdate UCP config table","created_at":"2019-07-25T17:10:51Z","updated_at":"2019-07-26T05:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04081a385f494e5503388588e34d28a447706793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/3958/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/3958/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/3958/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/79aa71ac276367dc198d0de0e12fd576581fa5cd","head":{"label":"dmitrygx:topic/core/context","ref":"topic/core/context","sha":"79aa71ac276367dc198d0de0e12fd576581fa5cd","user":{"login":"dmitrygx","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygx","html_url":"https://github.com/dmitrygx","followers_url":"https://api.github.com/users/dmitrygx/followers","following_url":"https://api.github.com/users/dmitrygx/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygx/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygx/subscriptions","organizations_url":"https://api.github.com/users/dmitrygx/orgs","repos_url":"https://api.github.com/users/dmitrygx/repos","events_url":"https://api.github.com/users/dmitrygx/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygx/received_events","type":"User","site_admin":false},"repo":{"id":163088016,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMwODgwMTY=","name":"ucx","full_name":"dmitrygx/ucx","private":false,"owner":{"login":"dmitrygx","id":11650339,"node_id":"MDQ6VXNlcjExNjUwMzM5","avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrygx","html_url":"https://github.com/dmitrygx","followers_url":"https://api.github.com/users/dmitrygx/followers","following_url":"https://api.github.com/users/dmitrygx/following{/other_user}","gists_url":"https://api.github.com/users/dmitrygx/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrygx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrygx/subscriptions","organizations_url":"https://api.github.com/users/dmitrygx/orgs","repos_url":"https://api.github.com/users/dmitrygx/repos","events_url":"https://api.github.com/users/dmitrygx/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrygx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitrygx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/dmitrygx/ucx","forks_url":"https://api.github.com/repos/dmitrygx/ucx/forks","keys_url":"https://api.github.com/repos/dmitrygx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitrygx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitrygx/ucx/teams","hooks_url":"https://api.github.com/repos/dmitrygx/ucx/hooks","issue_events_url":"https://api.github.com/repos/dmitrygx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/dmitrygx/ucx/events","assignees_url":"https://api.github.com/repos/dmitrygx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/dmitrygx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/dmitrygx/ucx/tags","blobs_url":"https://api.github.com/repos/dmitrygx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitrygx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitrygx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitrygx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitrygx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitrygx/ucx/languages","stargazers_url":"https://api.github.com/repos/dmitrygx/ucx/stargazers","contributors_url":"https://api.github.com/repos/dmitrygx/ucx/contributors","subscribers_url":"https://api.github.com/repos/dmitrygx/ucx/subscribers","subscription_url":"https://api.github.com/repos/dmitrygx/ucx/subscription","commits_url":"https://api.github.com/repos/dmitrygx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitrygx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitrygx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitrygx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitrygx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/dmitrygx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitrygx/ucx/merges","archive_url":"https://api.github.com/repos/dmitrygx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitrygx/ucx/downloads","issues_url":"https://api.github.com/repos/dmitrygx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/dmitrygx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitrygx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitrygx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitrygx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/dmitrygx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/dmitrygx/ucx/deployments","created_at":"2018-12-25T14:09:36Z","updated_at":"2019-07-01T12:08:01Z","pushed_at":"2019-07-25T19:03:27Z","git_url":"git://github.com/dmitrygx/ucx.git","ssh_url":"git@github.com:dmitrygx/ucx.git","clone_url":"https://github.com/dmitrygx/ucx.git","svn_url":"https://github.com/dmitrygx/ucx","homepage":"http://www.openucx.org","size":19193,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"2b5ac871620222eeb8dc8fe9b3e35fe4ea2585c7","user":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"node_id":"MDEwOlJlcG9zaXRvcnkyNTM3OTM5MA==","name":"ucx","full_name":"openucx/ucx","private":false,"owner":{"login":"openucx","id":13118737,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTE4NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2019-07-25T08:17:49Z","pushed_at":"2019-07-26T05:26:31Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":21448,"stargazers_count":218,"watchers_count":218,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":111,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":213,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":213,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3958"},"html":{"href":"https://github.com/openucx/ucx/pull/3958"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/3958"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/3958/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3958/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/3958/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/79aa71ac276367dc198d0de0e12fd576581fa5cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"brminich"}}