{"action":"created","issue":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2438","repository_url":"https://api.github.com/repos/paparazzi/paparazzi","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2438/labels{/name}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2438/comments","events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2438/events","html_url":"https://github.com/paparazzi/paparazzi/pull/2438","id":456248834,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4MzMwNjk3","number":2438,"title":"Improvement to start.py maintenance tools","user":{"login":"matteobarbera","id":22910604,"node_id":"MDQ6VXNlcjIyOTEwNjA0","avatar_url":"https://avatars1.githubusercontent.com/u/22910604?v=4","gravatar_id":"","url":"https://api.github.com/users/matteobarbera","html_url":"https://github.com/matteobarbera","followers_url":"https://api.github.com/users/matteobarbera/followers","following_url":"https://api.github.com/users/matteobarbera/following{/other_user}","gists_url":"https://api.github.com/users/matteobarbera/gists{/gist_id}","starred_url":"https://api.github.com/users/matteobarbera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matteobarbera/subscriptions","organizations_url":"https://api.github.com/users/matteobarbera/orgs","repos_url":"https://api.github.com/users/matteobarbera/repos","events_url":"https://api.github.com/users/matteobarbera/events{/privacy}","received_events_url":"https://api.github.com/users/matteobarbera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-06-14T13:26:45Z","updated_at":"2019-06-20T15:12:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2438","html_url":"https://github.com/paparazzi/paparazzi/pull/2438","diff_url":"https://github.com/paparazzi/paparazzi/pull/2438.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/2438.patch"},"body":"The maintenance tools in start.py now allows the HTML table for the module overview to be generated based on an airframe board file, to quickly compare the used modules in all airframes of a certain board across all conf files."},"comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments/504065306","html_url":"https://github.com/paparazzi/paparazzi/pull/2438#issuecomment-504065306","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2438","id":504065306,"node_id":"MDEyOklzc3VlQ29tbWVudDUwNDA2NTMwNg==","user":{"login":"Fabien-B","id":7016951,"node_id":"MDQ6VXNlcjcwMTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/7016951?v=4","gravatar_id":"","url":"https://api.github.com/users/Fabien-B","html_url":"https://github.com/Fabien-B","followers_url":"https://api.github.com/users/Fabien-B/followers","following_url":"https://api.github.com/users/Fabien-B/following{/other_user}","gists_url":"https://api.github.com/users/Fabien-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabien-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabien-B/subscriptions","organizations_url":"https://api.github.com/users/Fabien-B/orgs","repos_url":"https://api.github.com/users/Fabien-B/repos","events_url":"https://api.github.com/users/Fabien-B/events{/privacy}","received_events_url":"https://api.github.com/users/Fabien-B/received_events","type":"User","site_admin":false},"created_at":"2019-06-20T15:12:47Z","updated_at":"2019-06-20T15:12:47Z","author_association":"CONTRIBUTOR","body":"I never really use this script (what a shame) so I will give my observations \"as is\" so they might not be all relevant :\r\n\r\n- At startup, it would be best if the pre-selected items in the combo boxes match the current configuration\r\n- When hiting the \"Set Active\" button, it works well, but the items in the combo boxes shift by one above (lower index)\r\n- The airframes used by a configuration file are shown, which is good. But when hiting \"More info\", the file is not regenerated, and all airframes are shown, which is confusing.\r\n\r\nIn the maintenance tools specifically :\r\n- Same thing for the Conf combo box: the default should be the active one\r\n- When selecting an item in a combo box, the other combobox automatically reset to \"--None Selected--\". Is this a normal behavior ? I don't really understand how it is meant to be used.\r\n- The Module usage is great. I might have so suggestions for improvement, but later.\r\n- I haven't tested the \"Show Untested Files\" because of a bug :\r\n`Traceback (most recent call last):\r\n  File \"./start.py\", line 143, in show_untested\r\n    show_modules=data[\"Modules\"].get_active())\r\n  File \"/home/fabien/paparazzi/sw/lib/python/paparazzi_health.py\", line 626, in run\r\n    self.not_tested_html(f, show_airframes, show_flightplans, show_boards, show_modules)\r\n  File \"/home/fabien/paparazzi/sw/lib/python/paparazzi_health.py\", line 523, in not_tested_html\r\n    afs_sorted = self.generate_sorted_list(afs)\r\n  File \"/home/fabien/paparazzi/sw/lib/python/paparazzi_health.py\", line 351, in generate_sorted_list\r\n    reverse=True)\r\n  File \"/home/fabien/paparazzi/sw/lib/python/paparazzi_health.py\", line 350, in <lambda>\r\n    file_date_lst = sorted(zip(lst, commit_dates), key=lambda x: datetime.datetime.strptime(x[1], '%d-%m-%Y'),\r\n  File \"/usr/lib/python2.7/_strptime.py\", line 332, in _strptime\r\n    (data_string, format))\r\nValueError: time data '00-00-0000' does not match format '%d-%m-%Y'`\r\n\r\n"}}
{"actor":{"display_login":"Fabien-B"}}