{"action":"created","issue":{"url":"https://api.github.com/repos/net-ssh/net-ssh/issues/714","repository_url":"https://api.github.com/repos/net-ssh/net-ssh","labels_url":"https://api.github.com/repos/net-ssh/net-ssh/issues/714/labels{/name}","comments_url":"https://api.github.com/repos/net-ssh/net-ssh/issues/714/comments","events_url":"https://api.github.com/repos/net-ssh/net-ssh/issues/714/events","html_url":"https://github.com/net-ssh/net-ssh/pull/714","id":493709640,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NjE5MzQ2","number":714,"title":"Add sha2-{256,512}-etm@openssh.com MAC algorithms","user":{"login":"graaff","id":11150,"node_id":"MDQ6VXNlcjExMTUw","avatar_url":"https://avatars0.githubusercontent.com/u/11150?v=4","gravatar_id":"","url":"https://api.github.com/users/graaff","html_url":"https://github.com/graaff","followers_url":"https://api.github.com/users/graaff/followers","following_url":"https://api.github.com/users/graaff/following{/other_user}","gists_url":"https://api.github.com/users/graaff/gists{/gist_id}","starred_url":"https://api.github.com/users/graaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graaff/subscriptions","organizations_url":"https://api.github.com/users/graaff/orgs","repos_url":"https://api.github.com/users/graaff/repos","events_url":"https://api.github.com/users/graaff/events{/privacy}","received_events_url":"https://api.github.com/users/graaff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2019-09-15T08:21:03Z","updated_at":"2019-09-16T07:02:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/net-ssh/net-ssh/pulls/714","html_url":"https://github.com/net-ssh/net-ssh/pull/714","diff_url":"https://github.com/net-ssh/net-ssh/pull/714.diff","patch_url":"https://github.com/net-ssh/net-ssh/pull/714.patch"},"body":"Implement the Encrypt-Then-Mac versions of the SHA2-256 and SHA2-512\r\nMACs. These MACs are implemented by openssh and may be the only MACs\r\navailable on a hardened installation of openssh.\r\n\r\nWith EtM the MAC is calculated over the unencrypted packet length and\r\nthe encrypted payload (which includes padding length and padding).\r\n\r\nThe main benefit of EtM schemes is that it allows the encrypted\r\npayload to be authenticated before it gets passed to the encryption\r\nengine. This patch does not implement that mechanism, but this can be\r\nadded later to the poll_next_packet method. Note that all current MACs\r\nalready pass unauthenticated data to the encryption engine.\r\n\r\nThis implements part of #441 "},"comment":{"url":"https://api.github.com/repos/net-ssh/net-ssh/issues/comments/531662528","html_url":"https://github.com/net-ssh/net-ssh/pull/714#issuecomment-531662528","issue_url":"https://api.github.com/repos/net-ssh/net-ssh/issues/714","id":531662528,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMTY2MjUyOA==","user":{"login":"fwininger","id":4974759,"node_id":"MDQ6VXNlcjQ5NzQ3NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4974759?v=4","gravatar_id":"","url":"https://api.github.com/users/fwininger","html_url":"https://github.com/fwininger","followers_url":"https://api.github.com/users/fwininger/followers","following_url":"https://api.github.com/users/fwininger/following{/other_user}","gists_url":"https://api.github.com/users/fwininger/gists{/gist_id}","starred_url":"https://api.github.com/users/fwininger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwininger/subscriptions","organizations_url":"https://api.github.com/users/fwininger/orgs","repos_url":"https://api.github.com/users/fwininger/repos","events_url":"https://api.github.com/users/fwininger/events{/privacy}","received_events_url":"https://api.github.com/users/fwininger/received_events","type":"User","site_admin":false},"created_at":"2019-09-16T07:02:27Z","updated_at":"2019-09-16T07:02:27Z","author_association":"CONTRIBUTOR","body":"Ok perfect! We can skip umac-128-etm@openssh.com for now. The next step is to implement Authenticated encryption with associated data (AEAD) like aes-gcm or chacha20-poly1305."}}
{"actor":{"display_login":"fwininger"}}