{"action":"closed","number":5910,"pull_request":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/5910","id":353495726,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzNDk1NzI2","html_url":"https://github.com/cocos-creator/engine/pull/5910","diff_url":"https://github.com/cocos-creator/engine/pull/5910.diff","patch_url":"https://github.com/cocos-creator/engine/pull/5910.patch","issue_url":"https://api.github.com/repos/cocos-creator/engine/issues/5910","number":5910,"state":"closed","locked":false,"title":"refactor material instance","user":{"login":"zxg0622","id":8241313,"node_id":"MDQ6VXNlcjgyNDEzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8241313?v=4","gravatar_id":"","url":"https://api.github.com/users/zxg0622","html_url":"https://github.com/zxg0622","followers_url":"https://api.github.com/users/zxg0622/followers","following_url":"https://api.github.com/users/zxg0622/following{/other_user}","gists_url":"https://api.github.com/users/zxg0622/gists{/gist_id}","starred_url":"https://api.github.com/users/zxg0622/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxg0622/subscriptions","organizations_url":"https://api.github.com/users/zxg0622/orgs","repos_url":"https://api.github.com/users/zxg0622/repos","events_url":"https://api.github.com/users/zxg0622/events{/privacy}","received_events_url":"https://api.github.com/users/zxg0622/received_events","type":"User","site_admin":false},"body":"Re: cocos-creator/2d-tasks#\r\n\r\nChanges:\r\n * \r\n\r\n<!-- Note: Makes sure these boxes are checked before submitting your PR - thank you!\r\n\r\n- [ ] If your pull request has gone \"stale\", you should **rebase** your work on top of the latest version of the upstream branch.\r\n- [ ] If your commit history is full of small, unimportant commits (such as \"fix pep8\" or \"update tests\"), **squash** your commits down to a few, or one, discreet changesets before submitting a pull request.\r\n\r\n- For official teams:\r\n  - [ ] Check that your javascript is following our [style guide](https://docs.cocos.com/creator/manual/zh/scripting/reference/coding-standards.html) and end files with a newline\r\n  - [ ] Document new code with comments in source code based on [API Docs](https://github.com/cocos-creator/fireball#api-docs)\r\n  - [ ] Make sure any **runtime** log information in `cc.log`, `cc.error` or `new Error()` has been moved into `EngineErrorMap.md` with an ID, and use `cc.logID(id)` or `new Error(cc.debug.getError(id))` instead.\r\n\r\n-->\r\n","created_at":"2019-12-16T10:47:31Z","updated_at":"2019-12-25T09:41:05Z","closed_at":"2019-12-25T09:41:05Z","merged_at":"2019-12-25T09:41:05Z","merge_commit_sha":"39a7fbdd896e0e5aa31ef73de6515ec3e77ba725","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/engine/pulls/5910/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/engine/pulls/5910/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/engine/issues/5910/comments","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/f6b3c2d4de6ef2319021e23c3b6aefdf84588b01","head":{"label":"zxg0622:3d","ref":"3d","sha":"f6b3c2d4de6ef2319021e23c3b6aefdf84588b01","user":{"login":"zxg0622","id":8241313,"node_id":"MDQ6VXNlcjgyNDEzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8241313?v=4","gravatar_id":"","url":"https://api.github.com/users/zxg0622","html_url":"https://github.com/zxg0622","followers_url":"https://api.github.com/users/zxg0622/followers","following_url":"https://api.github.com/users/zxg0622/following{/other_user}","gists_url":"https://api.github.com/users/zxg0622/gists{/gist_id}","starred_url":"https://api.github.com/users/zxg0622/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxg0622/subscriptions","organizations_url":"https://api.github.com/users/zxg0622/orgs","repos_url":"https://api.github.com/users/zxg0622/repos","events_url":"https://api.github.com/users/zxg0622/events{/privacy}","received_events_url":"https://api.github.com/users/zxg0622/received_events","type":"User","site_admin":false},"repo":{"id":149096705,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwOTY3MDU=","name":"engine","full_name":"zxg0622/engine","private":false,"owner":{"login":"zxg0622","id":8241313,"node_id":"MDQ6VXNlcjgyNDEzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8241313?v=4","gravatar_id":"","url":"https://api.github.com/users/zxg0622","html_url":"https://github.com/zxg0622","followers_url":"https://api.github.com/users/zxg0622/followers","following_url":"https://api.github.com/users/zxg0622/following{/other_user}","gists_url":"https://api.github.com/users/zxg0622/gists{/gist_id}","starred_url":"https://api.github.com/users/zxg0622/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxg0622/subscriptions","organizations_url":"https://api.github.com/users/zxg0622/orgs","repos_url":"https://api.github.com/users/zxg0622/repos","events_url":"https://api.github.com/users/zxg0622/events{/privacy}","received_events_url":"https://api.github.com/users/zxg0622/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zxg0622/engine","description":"The engine for Cocos Creator","fork":true,"url":"https://api.github.com/repos/zxg0622/engine","forks_url":"https://api.github.com/repos/zxg0622/engine/forks","keys_url":"https://api.github.com/repos/zxg0622/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zxg0622/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zxg0622/engine/teams","hooks_url":"https://api.github.com/repos/zxg0622/engine/hooks","issue_events_url":"https://api.github.com/repos/zxg0622/engine/issues/events{/number}","events_url":"https://api.github.com/repos/zxg0622/engine/events","assignees_url":"https://api.github.com/repos/zxg0622/engine/assignees{/user}","branches_url":"https://api.github.com/repos/zxg0622/engine/branches{/branch}","tags_url":"https://api.github.com/repos/zxg0622/engine/tags","blobs_url":"https://api.github.com/repos/zxg0622/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zxg0622/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zxg0622/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/zxg0622/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zxg0622/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/zxg0622/engine/languages","stargazers_url":"https://api.github.com/repos/zxg0622/engine/stargazers","contributors_url":"https://api.github.com/repos/zxg0622/engine/contributors","subscribers_url":"https://api.github.com/repos/zxg0622/engine/subscribers","subscription_url":"https://api.github.com/repos/zxg0622/engine/subscription","commits_url":"https://api.github.com/repos/zxg0622/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/zxg0622/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/zxg0622/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/zxg0622/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/zxg0622/engine/contents/{+path}","compare_url":"https://api.github.com/repos/zxg0622/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zxg0622/engine/merges","archive_url":"https://api.github.com/repos/zxg0622/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zxg0622/engine/downloads","issues_url":"https://api.github.com/repos/zxg0622/engine/issues{/number}","pulls_url":"https://api.github.com/repos/zxg0622/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/zxg0622/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/zxg0622/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zxg0622/engine/labels{/name}","releases_url":"https://api.github.com/repos/zxg0622/engine/releases{/id}","deployments_url":"https://api.github.com/repos/zxg0622/engine/deployments","created_at":"2018-09-17T08:55:37Z","updated_at":"2018-09-17T08:55:40Z","pushed_at":"2019-12-25T09:38:16Z","git_url":"git://github.com/zxg0622/engine.git","ssh_url":"git@github.com:zxg0622/engine.git","clone_url":"https://github.com/zxg0622/engine.git","svn_url":"https://github.com/zxg0622/engine","homepage":"http://www.cocos2d-x.org/creator","size":48298,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cocos-creator:3d","ref":"3d","sha":"fcc773db7149df233c588eb777216876d4473312","user":{"login":"cocos-creator","id":6937061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MzcwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":47440536,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ0MDUzNg==","name":"engine","full_name":"cocos-creator/engine","private":false,"owner":{"login":"cocos-creator","id":6937061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MzcwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6937061?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cocos-creator/engine","description":"Cocos Creator is a complete package of game development tools and workflow, including a game engine, resource management, scene editing, game preview, debug and publish one project to multiple platforms.","fork":false,"url":"https://api.github.com/repos/cocos-creator/engine","forks_url":"https://api.github.com/repos/cocos-creator/engine/forks","keys_url":"https://api.github.com/repos/cocos-creator/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/engine/teams","hooks_url":"https://api.github.com/repos/cocos-creator/engine/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/engine/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/engine/events","assignees_url":"https://api.github.com/repos/cocos-creator/engine/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/engine/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/engine/tags","blobs_url":"https://api.github.com/repos/cocos-creator/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/engine/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/engine/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/engine/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/engine/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/engine/subscription","commits_url":"https://api.github.com/repos/cocos-creator/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/engine/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/engine/merges","archive_url":"https://api.github.com/repos/cocos-creator/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/engine/downloads","issues_url":"https://api.github.com/repos/cocos-creator/engine/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/engine/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/engine/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/engine/deployments","created_at":"2015-12-05T03:28:59Z","updated_at":"2019-12-25T07:34:06Z","pushed_at":"2019-12-25T09:41:05Z","git_url":"git://github.com/cocos-creator/engine.git","ssh_url":"git@github.com:cocos-creator/engine.git","clone_url":"https://github.com/cocos-creator/engine.git","svn_url":"https://github.com/cocos-creator/engine","homepage":"http://www.cocos2d-x.org/creator","size":55209,"stargazers_count":1458,"watchers_count":1458,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":713,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":210,"license":null,"forks":713,"open_issues":210,"watchers":1458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/5910"},"html":{"href":"https://github.com/cocos-creator/engine/pull/5910"},"issue":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/5910"},"comments":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/5910/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/5910/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/5910/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/engine/statuses/f6b3c2d4de6ef2319021e23c3b6aefdf84588b01"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pandamicro","id":632460,"node_id":"MDQ6VXNlcjYzMjQ2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/632460?v=4","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"comments":9,"review_comments":14,"maintainer_can_modify":false,"commits":13,"additions":756,"deletions":581,"changed_files":35}}
{"actor":{"display_login":"pandamicro"}}