{"action":"created","comment":{"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments/319411411","pull_request_review_id":281898374,"id":319411411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxOTQxMTQxMQ==","diff_hunk":"@@ -2236,10 +2236,13 @@ DataSheet$set(\"public\",\"split_date\", function(col_name = \"\", year_val = FALSE, y\n     self$add_columns_to_data(col_name = col_name, col_data = dekad_val_vector)\r\n   }\r\n   if(dekad_abbr) {\r\n-    month_abbr_vector <- forcats::fct_shift(f = (lubridate::month(col_data, label = TRUE)), n = (s_start_month - 1))\r\n-\t  dekad_val_vector <- ((as.numeric(dekade(col_data))) - (s_start_month - 1)*3) %% 36\r\n-\t  dekad_val_vector <- ifelse(dekad_val_vector == 0, 36, dekad_val_vector)\r\n-\t  dekad_abbr_vector <- paste(month_abbr_vector, dekad_val_vector, sep = \"\")\r\n+    month_abbr_vector <- factor(forcats::fct_shift(f = (lubridate::month(col_data, label = TRUE)), n = (s_start_month - 1)),ordered = FALSE)\r\n+\t  dekad_val_vector <- ((as.numeric(dekade(col_data))) - (s_start_month - 1)*3) %% 3\r\n+\t  dekad_val_vector <- ifelse(dekad_val_vector == 0, 3, dekad_val_vector)\r\n+\t  month.list <- c(\"Jan\", \"Feb\", \"Mar\", \"Apr\", \"May\", \"Jun\", \"Jul\", \"Aug\", \"Sep\", \"Oct\", \"Nov\", \"Dec\")\r\n+\t  month_levels<-if (s_start_month == 1) month.list else c(tail(month.list, -s_start_month + 1), head(month.list, s_start_month - 1))\r","path":"instat/static/InstatObject/R/data_object_R6.R","position":21,"original_position":21,"commit_id":"ce45ba374989d8aefdcd17e193e15eb94407516e","original_commit_id":"ce45ba374989d8aefdcd17e193e15eb94407516e","user":{"login":"dannyparsons","id":11214914,"node_id":"MDQ6VXNlcjExMjE0OTE0","avatar_url":"https://avatars1.githubusercontent.com/u/11214914?v=4","gravatar_id":"","url":"https://api.github.com/users/dannyparsons","html_url":"https://github.com/dannyparsons","followers_url":"https://api.github.com/users/dannyparsons/followers","following_url":"https://api.github.com/users/dannyparsons/following{/other_user}","gists_url":"https://api.github.com/users/dannyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyparsons/subscriptions","organizations_url":"https://api.github.com/users/dannyparsons/orgs","repos_url":"https://api.github.com/users/dannyparsons/repos","events_url":"https://api.github.com/users/dannyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/dannyparsons/received_events","type":"User","site_admin":false},"body":"space around `<-`","created_at":"2019-08-30T08:34:39Z","updated_at":"2019-08-30T08:36:46Z","html_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5479#discussion_r319411411","pull_request_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments/319411411"},"html":{"href":"https://github.com/africanmathsinitiative/R-Instat/pull/5479#discussion_r319411411"},"pull_request":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479"}}},"pull_request":{"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479","id":311505349,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExNTA1MzQ5","html_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5479","diff_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5479.diff","patch_url":"https://github.com/africanmathsinitiative/R-Instat/pull/5479.patch","issue_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5479","number":5479,"state":"open","locked":false,"title":"dlgUseDate changes","user":{"login":"AlexSananka","id":25578150,"node_id":"MDQ6VXNlcjI1NTc4MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/25578150?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSananka","html_url":"https://github.com/AlexSananka","followers_url":"https://api.github.com/users/AlexSananka/followers","following_url":"https://api.github.com/users/AlexSananka/following{/other_user}","gists_url":"https://api.github.com/users/AlexSananka/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSananka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSananka/subscriptions","organizations_url":"https://api.github.com/users/AlexSananka/orgs","repos_url":"https://api.github.com/users/AlexSananka/repos","events_url":"https://api.github.com/users/AlexSananka/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSananka/received_events","type":"User","site_admin":false},"body":"@africanmathsinitiative/developers this is ready for review. It should fix #4603 ","created_at":"2019-08-27T18:15:55Z","updated_at":"2019-08-30T08:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03b448ac9eb5e1551dc5a8769a48e9242ac09a3b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479/commits","review_comments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479/comments","review_comment_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5479/comments","statuses_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/statuses/ce45ba374989d8aefdcd17e193e15eb94407516e","head":{"label":"AlexSananka:use_date_changes","ref":"use_date_changes","sha":"ce45ba374989d8aefdcd17e193e15eb94407516e","user":{"login":"AlexSananka","id":25578150,"node_id":"MDQ6VXNlcjI1NTc4MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/25578150?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSananka","html_url":"https://github.com/AlexSananka","followers_url":"https://api.github.com/users/AlexSananka/followers","following_url":"https://api.github.com/users/AlexSananka/following{/other_user}","gists_url":"https://api.github.com/users/AlexSananka/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSananka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSananka/subscriptions","organizations_url":"https://api.github.com/users/AlexSananka/orgs","repos_url":"https://api.github.com/users/AlexSananka/repos","events_url":"https://api.github.com/users/AlexSananka/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSananka/received_events","type":"User","site_admin":false},"repo":{"id":203051877,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMwNTE4Nzc=","name":"R-Instat","full_name":"AlexSananka/R-Instat","private":false,"owner":{"login":"AlexSananka","id":25578150,"node_id":"MDQ6VXNlcjI1NTc4MTUw","avatar_url":"https://avatars2.githubusercontent.com/u/25578150?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSananka","html_url":"https://github.com/AlexSananka","followers_url":"https://api.github.com/users/AlexSananka/followers","following_url":"https://api.github.com/users/AlexSananka/following{/other_user}","gists_url":"https://api.github.com/users/AlexSananka/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSananka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSananka/subscriptions","organizations_url":"https://api.github.com/users/AlexSananka/orgs","repos_url":"https://api.github.com/users/AlexSananka/repos","events_url":"https://api.github.com/users/AlexSananka/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSananka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlexSananka/R-Instat","description":"A statistics software package powered by R","fork":true,"url":"https://api.github.com/repos/AlexSananka/R-Instat","forks_url":"https://api.github.com/repos/AlexSananka/R-Instat/forks","keys_url":"https://api.github.com/repos/AlexSananka/R-Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexSananka/R-Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexSananka/R-Instat/teams","hooks_url":"https://api.github.com/repos/AlexSananka/R-Instat/hooks","issue_events_url":"https://api.github.com/repos/AlexSananka/R-Instat/issues/events{/number}","events_url":"https://api.github.com/repos/AlexSananka/R-Instat/events","assignees_url":"https://api.github.com/repos/AlexSananka/R-Instat/assignees{/user}","branches_url":"https://api.github.com/repos/AlexSananka/R-Instat/branches{/branch}","tags_url":"https://api.github.com/repos/AlexSananka/R-Instat/tags","blobs_url":"https://api.github.com/repos/AlexSananka/R-Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexSananka/R-Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexSananka/R-Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexSananka/R-Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexSananka/R-Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexSananka/R-Instat/languages","stargazers_url":"https://api.github.com/repos/AlexSananka/R-Instat/stargazers","contributors_url":"https://api.github.com/repos/AlexSananka/R-Instat/contributors","subscribers_url":"https://api.github.com/repos/AlexSananka/R-Instat/subscribers","subscription_url":"https://api.github.com/repos/AlexSananka/R-Instat/subscription","commits_url":"https://api.github.com/repos/AlexSananka/R-Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexSananka/R-Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexSananka/R-Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexSananka/R-Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexSananka/R-Instat/contents/{+path}","compare_url":"https://api.github.com/repos/AlexSananka/R-Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexSananka/R-Instat/merges","archive_url":"https://api.github.com/repos/AlexSananka/R-Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexSananka/R-Instat/downloads","issues_url":"https://api.github.com/repos/AlexSananka/R-Instat/issues{/number}","pulls_url":"https://api.github.com/repos/AlexSananka/R-Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexSananka/R-Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexSananka/R-Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexSananka/R-Instat/labels{/name}","releases_url":"https://api.github.com/repos/AlexSananka/R-Instat/releases{/id}","deployments_url":"https://api.github.com/repos/AlexSananka/R-Instat/deployments","created_at":"2019-08-18T20:13:36Z","updated_at":"2019-08-18T20:13:39Z","pushed_at":"2019-08-29T05:56:38Z","git_url":"git://github.com/AlexSananka/R-Instat.git","ssh_url":"git@github.com:AlexSananka/R-Instat.git","clone_url":"https://github.com/AlexSananka/R-Instat.git","svn_url":"https://github.com/AlexSananka/R-Instat","homepage":"http://r-instat.org/","size":3988992,"stargazers_count":0,"watchers_count":0,"language":"Visual Basic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"africanmathsinitiative:master","ref":"master","sha":"0f99dabfd77952e85c52143beb81737ecc21ad96","user":{"login":"africanmathsinitiative","id":13917566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE3NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/13917566?v=4","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":44009238,"node_id":"MDEwOlJlcG9zaXRvcnk0NDAwOTIzOA==","name":"R-Instat","full_name":"africanmathsinitiative/R-Instat","private":false,"owner":{"login":"africanmathsinitiative","id":13917566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTE3NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/13917566?v=4","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/africanmathsinitiative/R-Instat","description":"A statistics software package powered by R","fork":false,"url":"https://api.github.com/repos/africanmathsinitiative/R-Instat","forks_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/forks","keys_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/teams","hooks_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/hooks","issue_events_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/events{/number}","events_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/events","assignees_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/assignees{/user}","branches_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/branches{/branch}","tags_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/tags","blobs_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/languages","stargazers_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/stargazers","contributors_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/contributors","subscribers_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/subscribers","subscription_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/subscription","commits_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/contents/{+path}","compare_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/merges","archive_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/downloads","issues_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues{/number}","pulls_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/labels{/name}","releases_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/releases{/id}","deployments_url":"https://api.github.com/repos/africanmathsinitiative/R-Instat/deployments","created_at":"2015-10-10T12:10:32Z","updated_at":"2019-08-30T08:26:19Z","pushed_at":"2019-08-30T08:26:04Z","git_url":"git://github.com/africanmathsinitiative/R-Instat.git","ssh_url":"git@github.com:africanmathsinitiative/R-Instat.git","clone_url":"https://github.com/africanmathsinitiative/R-Instat.git","svn_url":"https://github.com/africanmathsinitiative/R-Instat","homepage":"http://r-instat.org/","size":3989013,"stargazers_count":15,"watchers_count":15,"language":"Visual Basic","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":626,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":55,"open_issues":626,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479"},"html":{"href":"https://github.com/africanmathsinitiative/R-Instat/pull/5479"},"issue":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5479"},"comments":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/issues/5479/comments"},"review_comments":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479/comments"},"review_comment":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/pulls/5479/commits"},"statuses":{"href":"https://api.github.com/repos/africanmathsinitiative/R-Instat/statuses/ce45ba374989d8aefdcd17e193e15eb94407516e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dannyparsons"}}