{"action":"created","comment":{"url":"https://api.github.com/repos/crypto-com/chain/pulls/comments/356371366","pull_request_review_id":330259930,"id":356371366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjM3MTM2Ng==","diff_hunk":"@@ -0,0 +1,85 @@\n+# ADR 001: Storage Consolidation\n+\n+## Changelog\n+* 10-12-2019: Initial Draft\n+\n+## Context\n+Currently (not counting Tendermint's internal storage or wallets), two processes maintain their internal storage:\n+\n+* chain-abci: stores the node state, Merkle trie of staking states, transaction metadata (whether spent or not),\n+validator tracking, etc.\n+* tx-validation enclave (TVE): sealed transaction data (of valid obfuscated transactions that have outputs)\n+\n+The reason for having two processes is that SGX SDK compilation is different and needs Intel SGX SDK tooling,\n+so for the development convenience, the transaction validation code that needs to execute in an enclave\n+is isolated. The inter-process communication is over a simple REQ-REP 0MQ socket.","path":"architecture-docs/adr-001.md","position":15,"original_position":15,"commit_id":"6824628055f5232b014ef83e84a663adbb075e3c","original_commit_id":"6824628055f5232b014ef83e84a663adbb075e3c","user":{"login":"leejw51crypto","id":51560997,"node_id":"MDQ6VXNlcjUxNTYwOTk3","avatar_url":"https://avatars1.githubusercontent.com/u/51560997?v=4","gravatar_id":"","url":"https://api.github.com/users/leejw51crypto","html_url":"https://github.com/leejw51crypto","followers_url":"https://api.github.com/users/leejw51crypto/followers","following_url":"https://api.github.com/users/leejw51crypto/following{/other_user}","gists_url":"https://api.github.com/users/leejw51crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/leejw51crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leejw51crypto/subscriptions","organizations_url":"https://api.github.com/users/leejw51crypto/orgs","repos_url":"https://api.github.com/users/leejw51crypto/repos","events_url":"https://api.github.com/users/leejw51crypto/events{/privacy}","received_events_url":"https://api.github.com/users/leejw51crypto/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2019-12-11T02:01:16Z","updated_at":"2019-12-11T02:01:16Z","html_url":"https://github.com/crypto-com/chain/pull/665#discussion_r356371366","pull_request_url":"https://api.github.com/repos/crypto-com/chain/pulls/665","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/crypto-com/chain/pulls/comments/356371366"},"html":{"href":"https://github.com/crypto-com/chain/pull/665#discussion_r356371366"},"pull_request":{"href":"https://api.github.com/repos/crypto-com/chain/pulls/665"}},"in_reply_to_id":355970648},"pull_request":{"url":"https://api.github.com/repos/crypto-com/chain/pulls/665","id":351307025,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMzA3MDI1","html_url":"https://github.com/crypto-com/chain/pull/665","diff_url":"https://github.com/crypto-com/chain/pull/665.diff","patch_url":"https://github.com/crypto-com/chain/pull/665.patch","issue_url":"https://api.github.com/repos/crypto-com/chain/issues/665","number":665,"state":"open","locked":false,"title":"Problem: non-consolidated storage architecture","user":{"login":"tomtau","id":2410580,"node_id":"MDQ6VXNlcjI0MTA1ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2410580?v=4","gravatar_id":"","url":"https://api.github.com/users/tomtau","html_url":"https://github.com/tomtau","followers_url":"https://api.github.com/users/tomtau/followers","following_url":"https://api.github.com/users/tomtau/following{/other_user}","gists_url":"https://api.github.com/users/tomtau/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtau/subscriptions","organizations_url":"https://api.github.com/users/tomtau/orgs","repos_url":"https://api.github.com/users/tomtau/repos","events_url":"https://api.github.com/users/tomtau/events{/privacy}","received_events_url":"https://api.github.com/users/tomtau/received_events","type":"User","site_admin":false},"body":"Solution: wrote up a proposal in ADR\r\n\r\nNOTE: it's marked as proposed, as it needs some discussion before it's accepted -- feel free to comment if anything is unclear or missing.\r\nI don't expect this changes to be in 0.1, but more for later releases","created_at":"2019-12-10T10:15:29Z","updated_at":"2019-12-11T02:01:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce6fea21bd3980d5db5c38cc4748f4c46eaf244d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"calvinaco","id":38898718,"node_id":"MDQ6VXNlcjM4ODk4NzE4","avatar_url":"https://avatars1.githubusercontent.com/u/38898718?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinaco","html_url":"https://github.com/calvinaco","followers_url":"https://api.github.com/users/calvinaco/followers","following_url":"https://api.github.com/users/calvinaco/following{/other_user}","gists_url":"https://api.github.com/users/calvinaco/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinaco/subscriptions","organizations_url":"https://api.github.com/users/calvinaco/orgs","repos_url":"https://api.github.com/users/calvinaco/repos","events_url":"https://api.github.com/users/calvinaco/events{/privacy}","received_events_url":"https://api.github.com/users/calvinaco/received_events","type":"User","site_admin":false},{"login":"devashishdxt","id":47516145,"node_id":"MDQ6VXNlcjQ3NTE2MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/47516145?v=4","gravatar_id":"","url":"https://api.github.com/users/devashishdxt","html_url":"https://github.com/devashishdxt","followers_url":"https://api.github.com/users/devashishdxt/followers","following_url":"https://api.github.com/users/devashishdxt/following{/other_user}","gists_url":"https://api.github.com/users/devashishdxt/gists{/gist_id}","starred_url":"https://api.github.com/users/devashishdxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devashishdxt/subscriptions","organizations_url":"https://api.github.com/users/devashishdxt/orgs","repos_url":"https://api.github.com/users/devashishdxt/repos","events_url":"https://api.github.com/users/devashishdxt/events{/privacy}","received_events_url":"https://api.github.com/users/devashishdxt/received_events","type":"User","site_admin":false},{"login":"leejw51crypto","id":51560997,"node_id":"MDQ6VXNlcjUxNTYwOTk3","avatar_url":"https://avatars1.githubusercontent.com/u/51560997?v=4","gravatar_id":"","url":"https://api.github.com/users/leejw51crypto","html_url":"https://github.com/leejw51crypto","followers_url":"https://api.github.com/users/leejw51crypto/followers","following_url":"https://api.github.com/users/leejw51crypto/following{/other_user}","gists_url":"https://api.github.com/users/leejw51crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/leejw51crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leejw51crypto/subscriptions","organizations_url":"https://api.github.com/users/leejw51crypto/orgs","repos_url":"https://api.github.com/users/leejw51crypto/repos","events_url":"https://api.github.com/users/leejw51crypto/events{/privacy}","received_events_url":"https://api.github.com/users/leejw51crypto/received_events","type":"User","site_admin":false},{"login":"lezzokafka","id":51898510,"node_id":"MDQ6VXNlcjUxODk4NTEw","avatar_url":"https://avatars0.githubusercontent.com/u/51898510?v=4","gravatar_id":"","url":"https://api.github.com/users/lezzokafka","html_url":"https://github.com/lezzokafka","followers_url":"https://api.github.com/users/lezzokafka/followers","following_url":"https://api.github.com/users/lezzokafka/following{/other_user}","gists_url":"https://api.github.com/users/lezzokafka/gists{/gist_id}","starred_url":"https://api.github.com/users/lezzokafka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lezzokafka/subscriptions","organizations_url":"https://api.github.com/users/lezzokafka/orgs","repos_url":"https://api.github.com/users/lezzokafka/repos","events_url":"https://api.github.com/users/lezzokafka/events{/privacy}","received_events_url":"https://api.github.com/users/lezzokafka/received_events","type":"User","site_admin":false},{"login":"linfeng-crypto","id":56661925,"node_id":"MDQ6VXNlcjU2NjYxOTI1","avatar_url":"https://avatars0.githubusercontent.com/u/56661925?v=4","gravatar_id":"","url":"https://api.github.com/users/linfeng-crypto","html_url":"https://github.com/linfeng-crypto","followers_url":"https://api.github.com/users/linfeng-crypto/followers","following_url":"https://api.github.com/users/linfeng-crypto/following{/other_user}","gists_url":"https://api.github.com/users/linfeng-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/linfeng-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linfeng-crypto/subscriptions","organizations_url":"https://api.github.com/users/linfeng-crypto/orgs","repos_url":"https://api.github.com/users/linfeng-crypto/repos","events_url":"https://api.github.com/users/linfeng-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/linfeng-crypto/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crypto-com/chain/pulls/665/commits","review_comments_url":"https://api.github.com/repos/crypto-com/chain/pulls/665/comments","review_comment_url":"https://api.github.com/repos/crypto-com/chain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crypto-com/chain/issues/665/comments","statuses_url":"https://api.github.com/repos/crypto-com/chain/statuses/6824628055f5232b014ef83e84a663adbb075e3c","head":{"label":"tomtau:adr/storage","ref":"adr/storage","sha":"6824628055f5232b014ef83e84a663adbb075e3c","user":{"login":"tomtau","id":2410580,"node_id":"MDQ6VXNlcjI0MTA1ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2410580?v=4","gravatar_id":"","url":"https://api.github.com/users/tomtau","html_url":"https://github.com/tomtau","followers_url":"https://api.github.com/users/tomtau/followers","following_url":"https://api.github.com/users/tomtau/following{/other_user}","gists_url":"https://api.github.com/users/tomtau/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtau/subscriptions","organizations_url":"https://api.github.com/users/tomtau/orgs","repos_url":"https://api.github.com/users/tomtau/repos","events_url":"https://api.github.com/users/tomtau/events{/privacy}","received_events_url":"https://api.github.com/users/tomtau/received_events","type":"User","site_admin":false},"repo":{"id":176685037,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY2ODUwMzc=","name":"chain","full_name":"tomtau/chain","private":false,"owner":{"login":"tomtau","id":2410580,"node_id":"MDQ6VXNlcjI0MTA1ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2410580?v=4","gravatar_id":"","url":"https://api.github.com/users/tomtau","html_url":"https://github.com/tomtau","followers_url":"https://api.github.com/users/tomtau/followers","following_url":"https://api.github.com/users/tomtau/following{/other_user}","gists_url":"https://api.github.com/users/tomtau/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtau/subscriptions","organizations_url":"https://api.github.com/users/tomtau/orgs","repos_url":"https://api.github.com/users/tomtau/repos","events_url":"https://api.github.com/users/tomtau/events{/privacy}","received_events_url":"https://api.github.com/users/tomtau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomtau/chain","description":"Pre-alpha version prototype of Crypto.com Chain⛓","fork":true,"url":"https://api.github.com/repos/tomtau/chain","forks_url":"https://api.github.com/repos/tomtau/chain/forks","keys_url":"https://api.github.com/repos/tomtau/chain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomtau/chain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomtau/chain/teams","hooks_url":"https://api.github.com/repos/tomtau/chain/hooks","issue_events_url":"https://api.github.com/repos/tomtau/chain/issues/events{/number}","events_url":"https://api.github.com/repos/tomtau/chain/events","assignees_url":"https://api.github.com/repos/tomtau/chain/assignees{/user}","branches_url":"https://api.github.com/repos/tomtau/chain/branches{/branch}","tags_url":"https://api.github.com/repos/tomtau/chain/tags","blobs_url":"https://api.github.com/repos/tomtau/chain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomtau/chain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomtau/chain/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomtau/chain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomtau/chain/statuses/{sha}","languages_url":"https://api.github.com/repos/tomtau/chain/languages","stargazers_url":"https://api.github.com/repos/tomtau/chain/stargazers","contributors_url":"https://api.github.com/repos/tomtau/chain/contributors","subscribers_url":"https://api.github.com/repos/tomtau/chain/subscribers","subscription_url":"https://api.github.com/repos/tomtau/chain/subscription","commits_url":"https://api.github.com/repos/tomtau/chain/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomtau/chain/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomtau/chain/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomtau/chain/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomtau/chain/contents/{+path}","compare_url":"https://api.github.com/repos/tomtau/chain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomtau/chain/merges","archive_url":"https://api.github.com/repos/tomtau/chain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomtau/chain/downloads","issues_url":"https://api.github.com/repos/tomtau/chain/issues{/number}","pulls_url":"https://api.github.com/repos/tomtau/chain/pulls{/number}","milestones_url":"https://api.github.com/repos/tomtau/chain/milestones{/number}","notifications_url":"https://api.github.com/repos/tomtau/chain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomtau/chain/labels{/name}","releases_url":"https://api.github.com/repos/tomtau/chain/releases{/id}","deployments_url":"https://api.github.com/repos/tomtau/chain/deployments","created_at":"2019-03-20T08:08:42Z","updated_at":"2019-11-27T07:03:39Z","pushed_at":"2019-12-10T10:10:30Z","git_url":"git://github.com/tomtau/chain.git","ssh_url":"git@github.com:tomtau/chain.git","clone_url":"https://github.com/tomtau/chain.git","svn_url":"https://github.com/tomtau/chain","homepage":"https://crypto.com/chain","size":4550,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"crypto-com:master","ref":"master","sha":"e076ff667530a92831192e5e78ff9aece1712030","user":{"login":"crypto-com","id":41934032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxOTM0MDMy","avatar_url":"https://avatars0.githubusercontent.com/u/41934032?v=4","gravatar_id":"","url":"https://api.github.com/users/crypto-com","html_url":"https://github.com/crypto-com","followers_url":"https://api.github.com/users/crypto-com/followers","following_url":"https://api.github.com/users/crypto-com/following{/other_user}","gists_url":"https://api.github.com/users/crypto-com/gists{/gist_id}","starred_url":"https://api.github.com/users/crypto-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crypto-com/subscriptions","organizations_url":"https://api.github.com/users/crypto-com/orgs","repos_url":"https://api.github.com/users/crypto-com/repos","events_url":"https://api.github.com/users/crypto-com/events{/privacy}","received_events_url":"https://api.github.com/users/crypto-com/received_events","type":"Organization","site_admin":false},"repo":{"id":170284143,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAyODQxNDM=","name":"chain","full_name":"crypto-com/chain","private":false,"owner":{"login":"crypto-com","id":41934032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxOTM0MDMy","avatar_url":"https://avatars0.githubusercontent.com/u/41934032?v=4","gravatar_id":"","url":"https://api.github.com/users/crypto-com","html_url":"https://github.com/crypto-com","followers_url":"https://api.github.com/users/crypto-com/followers","following_url":"https://api.github.com/users/crypto-com/following{/other_user}","gists_url":"https://api.github.com/users/crypto-com/gists{/gist_id}","starred_url":"https://api.github.com/users/crypto-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crypto-com/subscriptions","organizations_url":"https://api.github.com/users/crypto-com/orgs","repos_url":"https://api.github.com/users/crypto-com/repos","events_url":"https://api.github.com/users/crypto-com/events{/privacy}","received_events_url":"https://api.github.com/users/crypto-com/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crypto-com/chain","description":"Alpha version prototype of Crypto.com Chain⛓","fork":false,"url":"https://api.github.com/repos/crypto-com/chain","forks_url":"https://api.github.com/repos/crypto-com/chain/forks","keys_url":"https://api.github.com/repos/crypto-com/chain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crypto-com/chain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crypto-com/chain/teams","hooks_url":"https://api.github.com/repos/crypto-com/chain/hooks","issue_events_url":"https://api.github.com/repos/crypto-com/chain/issues/events{/number}","events_url":"https://api.github.com/repos/crypto-com/chain/events","assignees_url":"https://api.github.com/repos/crypto-com/chain/assignees{/user}","branches_url":"https://api.github.com/repos/crypto-com/chain/branches{/branch}","tags_url":"https://api.github.com/repos/crypto-com/chain/tags","blobs_url":"https://api.github.com/repos/crypto-com/chain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crypto-com/chain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crypto-com/chain/git/refs{/sha}","trees_url":"https://api.github.com/repos/crypto-com/chain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crypto-com/chain/statuses/{sha}","languages_url":"https://api.github.com/repos/crypto-com/chain/languages","stargazers_url":"https://api.github.com/repos/crypto-com/chain/stargazers","contributors_url":"https://api.github.com/repos/crypto-com/chain/contributors","subscribers_url":"https://api.github.com/repos/crypto-com/chain/subscribers","subscription_url":"https://api.github.com/repos/crypto-com/chain/subscription","commits_url":"https://api.github.com/repos/crypto-com/chain/commits{/sha}","git_commits_url":"https://api.github.com/repos/crypto-com/chain/git/commits{/sha}","comments_url":"https://api.github.com/repos/crypto-com/chain/comments{/number}","issue_comment_url":"https://api.github.com/repos/crypto-com/chain/issues/comments{/number}","contents_url":"https://api.github.com/repos/crypto-com/chain/contents/{+path}","compare_url":"https://api.github.com/repos/crypto-com/chain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crypto-com/chain/merges","archive_url":"https://api.github.com/repos/crypto-com/chain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crypto-com/chain/downloads","issues_url":"https://api.github.com/repos/crypto-com/chain/issues{/number}","pulls_url":"https://api.github.com/repos/crypto-com/chain/pulls{/number}","milestones_url":"https://api.github.com/repos/crypto-com/chain/milestones{/number}","notifications_url":"https://api.github.com/repos/crypto-com/chain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crypto-com/chain/labels{/name}","releases_url":"https://api.github.com/repos/crypto-com/chain/releases{/id}","deployments_url":"https://api.github.com/repos/crypto-com/chain/deployments","created_at":"2019-02-12T08:51:29Z","updated_at":"2019-12-10T08:49:02Z","pushed_at":"2019-12-10T21:12:36Z","git_url":"git://github.com/crypto-com/chain.git","ssh_url":"git@github.com:crypto-com/chain.git","clone_url":"https://github.com/crypto-com/chain.git","svn_url":"https://github.com/crypto-com/chain","homepage":"https://crypto.com/chain","size":4559,"stargazers_count":52,"watchers_count":52,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":5,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crypto-com/chain/pulls/665"},"html":{"href":"https://github.com/crypto-com/chain/pull/665"},"issue":{"href":"https://api.github.com/repos/crypto-com/chain/issues/665"},"comments":{"href":"https://api.github.com/repos/crypto-com/chain/issues/665/comments"},"review_comments":{"href":"https://api.github.com/repos/crypto-com/chain/pulls/665/comments"},"review_comment":{"href":"https://api.github.com/repos/crypto-com/chain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crypto-com/chain/pulls/665/commits"},"statuses":{"href":"https://api.github.com/repos/crypto-com/chain/statuses/6824628055f5232b014ef83e84a663adbb075e3c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"leejw51crypto"}}