{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments/343737667","pull_request_review_id":313456259,"id":343737667,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzczNzY2Nw==","diff_hunk":"@@ -152,12 +152,14 @@ export default class Dataframe extends DummyDataframe {\n     }\n \n     getPropertyTexture (propertyName) {\n-        if (this.propertyTex[propertyName]) {\n-            return this.propertyTex[propertyName];\n+        const encodedPropertyName = this._encodePropertyName(propertyName);\n+\n+        if (this.propertyTex[encodedPropertyName]) {\n+            return this.propertyTex[encodedPropertyName];\n         }\n \n         this._loadPropertyValuesToTexture(propertyName);","path":"src/renderer/dataframe/Dataframe.js","position":12,"original_position":12,"commit_id":"8d59a50b4ddbe291ccc8f513856a4fcaf5f603e1","original_commit_id":"8d59a50b4ddbe291ccc8f513856a4fcaf5f603e1","user":{"login":"Jesus89","id":2227572,"node_id":"MDQ6VXNlcjIyMjc1NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2227572?v=4","gravatar_id":"","url":"https://api.github.com/users/Jesus89","html_url":"https://github.com/Jesus89","followers_url":"https://api.github.com/users/Jesus89/followers","following_url":"https://api.github.com/users/Jesus89/following{/other_user}","gists_url":"https://api.github.com/users/Jesus89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jesus89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jesus89/subscriptions","organizations_url":"https://api.github.com/users/Jesus89/orgs","repos_url":"https://api.github.com/users/Jesus89/repos","events_url":"https://api.github.com/users/Jesus89/events{/privacy}","received_events_url":"https://api.github.com/users/Jesus89/received_events","type":"User","site_admin":false},"body":"Nope, because `_loadPropertyValuesToTexture` uses `propertyName` to access the `properties` and the encodedPropertyName is only for the textures.","created_at":"2019-11-07T16:11:24Z","updated_at":"2019-11-07T16:11:24Z","html_url":"https://github.com/CartoDB/carto-vl/pull/1410#discussion_r343737667","pull_request_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments/343737667"},"html":{"href":"https://github.com/CartoDB/carto-vl/pull/1410#discussion_r343737667"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410"}},"in_reply_to_id":343734047},"pull_request":{"url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410","id":337391081,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3MzkxMDgx","html_url":"https://github.com/CartoDB/carto-vl/pull/1410","diff_url":"https://github.com/CartoDB/carto-vl/pull/1410.diff","patch_url":"https://github.com/CartoDB/carto-vl/pull/1410.patch","issue_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/1410","number":1410,"state":"open","locked":false,"title":"Fix using length as a property name","user":{"login":"Jesus89","id":2227572,"node_id":"MDQ6VXNlcjIyMjc1NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2227572?v=4","gravatar_id":"","url":"https://api.github.com/users/Jesus89","html_url":"https://github.com/Jesus89","followers_url":"https://api.github.com/users/Jesus89/followers","following_url":"https://api.github.com/users/Jesus89/following{/other_user}","gists_url":"https://api.github.com/users/Jesus89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jesus89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jesus89/subscriptions","organizations_url":"https://api.github.com/users/Jesus89/orgs","repos_url":"https://api.github.com/users/Jesus89/repos","events_url":"https://api.github.com/users/Jesus89/events{/privacy}","received_events_url":"https://api.github.com/users/Jesus89/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/CartoDB/carto-vl/issues/1247","created_at":"2019-11-06T14:31:09Z","updated_at":"2019-11-07T16:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32cd2e32c9d1c40dfbb61e03234ace4b84dc7945","assignee":null,"assignees":[],"requested_reviewers":[{"login":"VictorVelarde","id":458196,"node_id":"MDQ6VXNlcjQ1ODE5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/458196?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorVelarde","html_url":"https://github.com/VictorVelarde","followers_url":"https://api.github.com/users/VictorVelarde/followers","following_url":"https://api.github.com/users/VictorVelarde/following{/other_user}","gists_url":"https://api.github.com/users/VictorVelarde/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorVelarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorVelarde/subscriptions","organizations_url":"https://api.github.com/users/VictorVelarde/orgs","repos_url":"https://api.github.com/users/VictorVelarde/repos","events_url":"https://api.github.com/users/VictorVelarde/events{/privacy}","received_events_url":"https://api.github.com/users/VictorVelarde/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410/commits","review_comments_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410/comments","review_comment_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/1410/comments","statuses_url":"https://api.github.com/repos/CartoDB/carto-vl/statuses/8d59a50b4ddbe291ccc8f513856a4fcaf5f603e1","head":{"label":"CartoDB:fix/1247-reserved-property-names","ref":"fix/1247-reserved-property-names","sha":"8d59a50b4ddbe291ccc8f513856a4fcaf5f603e1","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":106824313,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4MjQzMTM=","name":"carto-vl","full_name":"CartoDB/carto-vl","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/carto-vl","description":"CARTO VL: a Javascript library to create vector-based visualizations","fork":false,"url":"https://api.github.com/repos/CartoDB/carto-vl","forks_url":"https://api.github.com/repos/CartoDB/carto-vl/forks","keys_url":"https://api.github.com/repos/CartoDB/carto-vl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/carto-vl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/carto-vl/teams","hooks_url":"https://api.github.com/repos/CartoDB/carto-vl/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/carto-vl/events","assignees_url":"https://api.github.com/repos/CartoDB/carto-vl/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/carto-vl/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/carto-vl/tags","blobs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/carto-vl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/carto-vl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/carto-vl/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/carto-vl/languages","stargazers_url":"https://api.github.com/repos/CartoDB/carto-vl/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/carto-vl/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/carto-vl/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/carto-vl/subscription","commits_url":"https://api.github.com/repos/CartoDB/carto-vl/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/carto-vl/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/carto-vl/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/carto-vl/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/carto-vl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/carto-vl/merges","archive_url":"https://api.github.com/repos/CartoDB/carto-vl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/carto-vl/downloads","issues_url":"https://api.github.com/repos/CartoDB/carto-vl/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/carto-vl/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/carto-vl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/carto-vl/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/carto-vl/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/carto-vl/deployments","created_at":"2017-10-13T12:56:39Z","updated_at":"2019-11-07T11:50:50Z","pushed_at":"2019-11-07T13:27:20Z","git_url":"git://github.com/CartoDB/carto-vl.git","ssh_url":"git@github.com:CartoDB/carto-vl.git","clone_url":"https://github.com/CartoDB/carto-vl.git","svn_url":"https://github.com/CartoDB/carto-vl","homepage":"","size":59688,"stargazers_count":95,"watchers_count":95,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":129,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":19,"open_issues":129,"watchers":95,"default_branch":"master"}},"base":{"label":"CartoDB:develop","ref":"develop","sha":"5027b289d4a3880089710ed2e13dd93b4f80d31a","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":106824313,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4MjQzMTM=","name":"carto-vl","full_name":"CartoDB/carto-vl","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/carto-vl","description":"CARTO VL: a Javascript library to create vector-based visualizations","fork":false,"url":"https://api.github.com/repos/CartoDB/carto-vl","forks_url":"https://api.github.com/repos/CartoDB/carto-vl/forks","keys_url":"https://api.github.com/repos/CartoDB/carto-vl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/carto-vl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/carto-vl/teams","hooks_url":"https://api.github.com/repos/CartoDB/carto-vl/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/carto-vl/events","assignees_url":"https://api.github.com/repos/CartoDB/carto-vl/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/carto-vl/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/carto-vl/tags","blobs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/carto-vl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/carto-vl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/carto-vl/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/carto-vl/languages","stargazers_url":"https://api.github.com/repos/CartoDB/carto-vl/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/carto-vl/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/carto-vl/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/carto-vl/subscription","commits_url":"https://api.github.com/repos/CartoDB/carto-vl/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/carto-vl/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/carto-vl/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/carto-vl/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/carto-vl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/carto-vl/merges","archive_url":"https://api.github.com/repos/CartoDB/carto-vl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/carto-vl/downloads","issues_url":"https://api.github.com/repos/CartoDB/carto-vl/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/carto-vl/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/carto-vl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/carto-vl/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/carto-vl/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/carto-vl/deployments","created_at":"2017-10-13T12:56:39Z","updated_at":"2019-11-07T11:50:50Z","pushed_at":"2019-11-07T13:27:20Z","git_url":"git://github.com/CartoDB/carto-vl.git","ssh_url":"git@github.com:CartoDB/carto-vl.git","clone_url":"https://github.com/CartoDB/carto-vl.git","svn_url":"https://github.com/CartoDB/carto-vl","homepage":"","size":59688,"stargazers_count":95,"watchers_count":95,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":129,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":19,"open_issues":129,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410"},"html":{"href":"https://github.com/CartoDB/carto-vl/pull/1410"},"issue":{"href":"https://api.github.com/repos/CartoDB/carto-vl/issues/1410"},"comments":{"href":"https://api.github.com/repos/CartoDB/carto-vl/issues/1410/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/1410/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/carto-vl/statuses/8d59a50b4ddbe291ccc8f513856a4fcaf5f603e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Jesus89"}}