{"action":"created","comment":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/296082879","pull_request_review_id":252625028,"id":296082879,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjA4Mjg3OQ==","diff_hunk":"@@ -35,6 +35,7 @@ function(ConfigureBench CMAKE_BENCH_NAME CMAKE_BENCH_SRC)\n     if(CMAKE_ENABLE_BENCHMARKS)\n         add_executable(${CMAKE_BENCH_NAME}\n                     ${CMAKE_BENCH_SRC}\n+                    \"${CMAKE_CURRENT_SOURCE_DIR}/utilities/nvcategory_utils.cu\"","path":"cpp/tests/CMakeLists.txt","position":4,"original_position":4,"commit_id":"412c24713c52c2722baf7a923bf5e83f38b4c330","original_commit_id":"412c24713c52c2722baf7a923bf5e83f38b4c330","user":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"body":"Done. Though these should go to the benchmarks folder and the new CMakeLists...","created_at":"2019-06-21T03:16:25Z","updated_at":"2019-06-21T03:16:25Z","html_url":"https://github.com/rapidsai/cudf/pull/1908#discussion_r296082879","pull_request_url":"https://api.github.com/repos/rapidsai/cudf/pulls/1908","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments/296082879"},"html":{"href":"https://github.com/rapidsai/cudf/pull/1908#discussion_r296082879"},"pull_request":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1908"}},"in_reply_to_id":295854157},"pull_request":{"url":"https://api.github.com/repos/rapidsai/cudf/pulls/1908","id":284428015,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NDI4MDE1","html_url":"https://github.com/rapidsai/cudf/pull/1908","diff_url":"https://github.com/rapidsai/cudf/pull/1908.diff","patch_url":"https://github.com/rapidsai/cudf/pull/1908.patch","issue_url":"https://api.github.com/repos/rapidsai/cudf/issues/1908","number":1908,"state":"open","locked":false,"title":"cudf::fill() and cudf::copy_range(): Assign column values by index or range from either a scalar or another column","user":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"body":"This PR introduces\r\n - `cudf::fill`, which enables setting a specific index or range of indices of a column to a specified value.\r\n - `cudf::copy_range`, which enable setting a range of indices of a column to a range of values from a second column\r\n\r\nThese both use the same internal function template (`cudf::detail::copy_range`) and kernel, which is written to take a functor for getting the input data and validity for each index of the input range. The same functionality can be used to extend to arbitrary filling/copying functionality.\r\n\r\nCloses #1468 and closes #1934 \r\n\r\nThis PR also improves test utilities for string_category columns. With these changes a single test can be applied to both numeric and string_category columns.\r\n1. Adds `make_column_wrapper` utility which can make a `column_wrapper` from any type using an integer generator lambda -- even string_category columns.\r\n2. Extends `gdf_equal_columns` to compare string_category columns on their string values indexed by the column data, rather than on the indices.\r\n\r\n- [x] Decide whether API will be in-place, out-of-place, or have in-place option. [Currently allowing copy_range() to be legal for the source and dest to be the same column, with documentation stating that doing so with overlapping ranges is undefined behavior. fill() supports in-place only, currently.]\r\n- [x] Rename and move files to appropriate location (no longer just \"filling\")\r\n- [x] `cudf::detail::copy_range` implementation\r\n- [x] Support for setting null values in `cudf::detail::copy_range`\r\n- [x] Tests for filling data\r\n- [x] Tests for filling nulls\r\n- [x] Tests for copying ranges with/without nulls\r\n- [x] Tests for error situations\r\n- [x] Correct synchronization of nvcategory after copying a range of an nvstring_category column\r\n- [x] Tests for nvstring_category in copy_range tests\r\n- [ ] ~Ditto for fill_tests~ Need support for strings in gdf_scalar to support this. Punting to future PR.\r\n- [ ] ~Cython bindings~ Now in #2010 \r\n- [ ] ~Python plumbing~ Future PR","created_at":"2019-06-03T06:26:02Z","updated_at":"2019-06-21T03:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"791e9e382be87489eaf2378a2d860c8755e69b4d","assignee":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"assignees":[{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1013987503,"node_id":"MDU6TGFiZWwxMDEzOTg3NTAz","url":"https://api.github.com/repos/rapidsai/cudf/labels/2%20-%20In%20Progress","name":"2 - In Progress","color":"fef2c0","default":false},{"id":1139741213,"node_id":"MDU6TGFiZWwxMTM5NzQxMjEz","url":"https://api.github.com/repos/rapidsai/cudf/labels/cuDF%20(Python)","name":"cuDF (Python)","color":"1d76db","default":false},{"id":1139740666,"node_id":"MDU6TGFiZWwxMTM5NzQwNjY2","url":"https://api.github.com/repos/rapidsai/cudf/labels/libcudf%20(C++/CUDA)","name":"libcudf (C++/CUDA)","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapidsai/cudf/pulls/1908/commits","review_comments_url":"https://api.github.com/repos/rapidsai/cudf/pulls/1908/comments","review_comment_url":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapidsai/cudf/issues/1908/comments","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/412c24713c52c2722baf7a923bf5e83f38b4c330","head":{"label":"harrism:fea-set-range","ref":"fea-set-range","sha":"412c24713c52c2722baf7a923bf5e83f38b4c330","user":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"repo":{"id":151339230,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEzMzkyMzA=","name":"cudf","full_name":"harrism/cudf","private":false,"owner":{"login":"harrism","id":783069,"node_id":"MDQ6VXNlcjc4MzA2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/783069?v=4","gravatar_id":"","url":"https://api.github.com/users/harrism","html_url":"https://github.com/harrism","followers_url":"https://api.github.com/users/harrism/followers","following_url":"https://api.github.com/users/harrism/following{/other_user}","gists_url":"https://api.github.com/users/harrism/gists{/gist_id}","starred_url":"https://api.github.com/users/harrism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrism/subscriptions","organizations_url":"https://api.github.com/users/harrism/orgs","repos_url":"https://api.github.com/users/harrism/repos","events_url":"https://api.github.com/users/harrism/events{/privacy}","received_events_url":"https://api.github.com/users/harrism/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harrism/cudf","description":"Python GPU DataFrame Library","fork":true,"url":"https://api.github.com/repos/harrism/cudf","forks_url":"https://api.github.com/repos/harrism/cudf/forks","keys_url":"https://api.github.com/repos/harrism/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harrism/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harrism/cudf/teams","hooks_url":"https://api.github.com/repos/harrism/cudf/hooks","issue_events_url":"https://api.github.com/repos/harrism/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/harrism/cudf/events","assignees_url":"https://api.github.com/repos/harrism/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/harrism/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/harrism/cudf/tags","blobs_url":"https://api.github.com/repos/harrism/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harrism/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harrism/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/harrism/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harrism/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/harrism/cudf/languages","stargazers_url":"https://api.github.com/repos/harrism/cudf/stargazers","contributors_url":"https://api.github.com/repos/harrism/cudf/contributors","subscribers_url":"https://api.github.com/repos/harrism/cudf/subscribers","subscription_url":"https://api.github.com/repos/harrism/cudf/subscription","commits_url":"https://api.github.com/repos/harrism/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/harrism/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/harrism/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/harrism/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/harrism/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/harrism/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harrism/cudf/merges","archive_url":"https://api.github.com/repos/harrism/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harrism/cudf/downloads","issues_url":"https://api.github.com/repos/harrism/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/harrism/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/harrism/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/harrism/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harrism/cudf/labels{/name}","releases_url":"https://api.github.com/repos/harrism/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/harrism/cudf/deployments","created_at":"2018-10-02T23:57:26Z","updated_at":"2018-11-26T01:25:52Z","pushed_at":"2019-06-20T06:19:56Z","git_url":"git://github.com/harrism/cudf.git","ssh_url":"git@github.com:harrism/cudf.git","clone_url":"https://github.com/harrism/cudf.git","svn_url":"https://github.com/harrism/cudf","homepage":"http://gpuopenanalytics.com","size":22964,"stargazers_count":0,"watchers_count":0,"language":"Cuda","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapidsai:branch-0.8","ref":"branch-0.8","sha":"f7631e7782ca6ecc703903a2d3d8770761873b68","user":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"repo":{"id":90506918,"node_id":"MDEwOlJlcG9zaXRvcnk5MDUwNjkxOA==","name":"cudf","full_name":"rapidsai/cudf","private":false,"owner":{"login":"rapidsai","id":43887749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzODg3NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/43887749?v=4","gravatar_id":"","url":"https://api.github.com/users/rapidsai","html_url":"https://github.com/rapidsai","followers_url":"https://api.github.com/users/rapidsai/followers","following_url":"https://api.github.com/users/rapidsai/following{/other_user}","gists_url":"https://api.github.com/users/rapidsai/gists{/gist_id}","starred_url":"https://api.github.com/users/rapidsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapidsai/subscriptions","organizations_url":"https://api.github.com/users/rapidsai/orgs","repos_url":"https://api.github.com/users/rapidsai/repos","events_url":"https://api.github.com/users/rapidsai/events{/privacy}","received_events_url":"https://api.github.com/users/rapidsai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rapidsai/cudf","description":"cuDF - GPU DataFrame Library","fork":false,"url":"https://api.github.com/repos/rapidsai/cudf","forks_url":"https://api.github.com/repos/rapidsai/cudf/forks","keys_url":"https://api.github.com/repos/rapidsai/cudf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapidsai/cudf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapidsai/cudf/teams","hooks_url":"https://api.github.com/repos/rapidsai/cudf/hooks","issue_events_url":"https://api.github.com/repos/rapidsai/cudf/issues/events{/number}","events_url":"https://api.github.com/repos/rapidsai/cudf/events","assignees_url":"https://api.github.com/repos/rapidsai/cudf/assignees{/user}","branches_url":"https://api.github.com/repos/rapidsai/cudf/branches{/branch}","tags_url":"https://api.github.com/repos/rapidsai/cudf/tags","blobs_url":"https://api.github.com/repos/rapidsai/cudf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapidsai/cudf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapidsai/cudf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapidsai/cudf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapidsai/cudf/statuses/{sha}","languages_url":"https://api.github.com/repos/rapidsai/cudf/languages","stargazers_url":"https://api.github.com/repos/rapidsai/cudf/stargazers","contributors_url":"https://api.github.com/repos/rapidsai/cudf/contributors","subscribers_url":"https://api.github.com/repos/rapidsai/cudf/subscribers","subscription_url":"https://api.github.com/repos/rapidsai/cudf/subscription","commits_url":"https://api.github.com/repos/rapidsai/cudf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapidsai/cudf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapidsai/cudf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapidsai/cudf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapidsai/cudf/contents/{+path}","compare_url":"https://api.github.com/repos/rapidsai/cudf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapidsai/cudf/merges","archive_url":"https://api.github.com/repos/rapidsai/cudf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapidsai/cudf/downloads","issues_url":"https://api.github.com/repos/rapidsai/cudf/issues{/number}","pulls_url":"https://api.github.com/repos/rapidsai/cudf/pulls{/number}","milestones_url":"https://api.github.com/repos/rapidsai/cudf/milestones{/number}","notifications_url":"https://api.github.com/repos/rapidsai/cudf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapidsai/cudf/labels{/name}","releases_url":"https://api.github.com/repos/rapidsai/cudf/releases{/id}","deployments_url":"https://api.github.com/repos/rapidsai/cudf/deployments","created_at":"2017-05-07T03:43:37Z","updated_at":"2019-06-21T01:58:40Z","pushed_at":"2019-06-21T01:59:33Z","git_url":"git://github.com/rapidsai/cudf.git","ssh_url":"git@github.com:rapidsai/cudf.git","clone_url":"https://github.com/rapidsai/cudf.git","svn_url":"https://github.com/rapidsai/cudf","homepage":"http://rapids.ai","size":23213,"stargazers_count":1600,"watchers_count":1600,"language":"Cuda","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":345,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":236,"open_issues":345,"watchers":1600,"default_branch":"branch-0.8"}},"_links":{"self":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1908"},"html":{"href":"https://github.com/rapidsai/cudf/pull/1908"},"issue":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/1908"},"comments":{"href":"https://api.github.com/repos/rapidsai/cudf/issues/1908/comments"},"review_comments":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1908/comments"},"review_comment":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapidsai/cudf/pulls/1908/commits"},"statuses":{"href":"https://api.github.com/repos/rapidsai/cudf/statuses/412c24713c52c2722baf7a923bf5e83f38b4c330"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"harrism"}}