{"action":"created","issue":{"url":"https://api.github.com/repos/tektoncd/cli/issues/552","repository_url":"https://api.github.com/repos/tektoncd/cli","labels_url":"https://api.github.com/repos/tektoncd/cli/issues/552/labels{/name}","comments_url":"https://api.github.com/repos/tektoncd/cli/issues/552/comments","events_url":"https://api.github.com/repos/tektoncd/cli/issues/552/events","html_url":"https://github.com/tektoncd/cli/pull/552","id":542683097,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3MDc3Mjkz","number":552,"title":"Converting TaskRun Describe Tests to Use Test Builder Methods for StepState","user":{"login":"danielhelfand","id":34258252,"node_id":"MDQ6VXNlcjM0MjU4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/34258252?v=4","gravatar_id":"","url":"https://api.github.com/users/danielhelfand","html_url":"https://github.com/danielhelfand","followers_url":"https://api.github.com/users/danielhelfand/followers","following_url":"https://api.github.com/users/danielhelfand/following{/other_user}","gists_url":"https://api.github.com/users/danielhelfand/gists{/gist_id}","starred_url":"https://api.github.com/users/danielhelfand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielhelfand/subscriptions","organizations_url":"https://api.github.com/users/danielhelfand/orgs","repos_url":"https://api.github.com/users/danielhelfand/repos","events_url":"https://api.github.com/users/danielhelfand/events{/privacy}","received_events_url":"https://api.github.com/users/danielhelfand/received_events","type":"User","site_admin":false},"labels":[{"id":1324643976,"node_id":"MDU6TGFiZWwxMzI0NjQzOTc2","url":"https://api.github.com/repos/tektoncd/cli/labels/approved","name":"approved","color":"abea59","default":false,"description":"Indicates a PR has been approved by an approver from all required OWNERS files."},{"id":1333809654,"node_id":"MDU6TGFiZWwxMzMzODA5NjU0","url":"https://api.github.com/repos/tektoncd/cli/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false,"description":null},{"id":1323766928,"node_id":"MDU6TGFiZWwxMzIzNzY2OTI4","url":"https://api.github.com/repos/tektoncd/cli/labels/lgtm","name":"lgtm","color":"6aed75","default":false,"description":"Indicates that a PR is ready to be merged."},{"id":1344517653,"node_id":"MDU6TGFiZWwxMzQ0NTE3NjUz","url":"https://api.github.com/repos/tektoncd/cli/labels/size/M","name":"size/M","color":"eebb00","default":false,"description":"Denotes a PR that changes 30-99 lines, ignoring generated files."}],"state":"open","locked":false,"assignee":{"login":"pradeepitm12","id":26105461,"node_id":"MDQ6VXNlcjI2MTA1NDYx","avatar_url":"https://avatars0.githubusercontent.com/u/26105461?v=4","gravatar_id":"","url":"https://api.github.com/users/pradeepitm12","html_url":"https://github.com/pradeepitm12","followers_url":"https://api.github.com/users/pradeepitm12/followers","following_url":"https://api.github.com/users/pradeepitm12/following{/other_user}","gists_url":"https://api.github.com/users/pradeepitm12/gists{/gist_id}","starred_url":"https://api.github.com/users/pradeepitm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradeepitm12/subscriptions","organizations_url":"https://api.github.com/users/pradeepitm12/orgs","repos_url":"https://api.github.com/users/pradeepitm12/repos","events_url":"https://api.github.com/users/pradeepitm12/events{/privacy}","received_events_url":"https://api.github.com/users/pradeepitm12/received_events","type":"User","site_admin":false},"assignees":[{"login":"pradeepitm12","id":26105461,"node_id":"MDQ6VXNlcjI2MTA1NDYx","avatar_url":"https://avatars0.githubusercontent.com/u/26105461?v=4","gravatar_id":"","url":"https://api.github.com/users/pradeepitm12","html_url":"https://github.com/pradeepitm12","followers_url":"https://api.github.com/users/pradeepitm12/followers","following_url":"https://api.github.com/users/pradeepitm12/following{/other_user}","gists_url":"https://api.github.com/users/pradeepitm12/gists{/gist_id}","starred_url":"https://api.github.com/users/pradeepitm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradeepitm12/subscriptions","organizations_url":"https://api.github.com/users/pradeepitm12/orgs","repos_url":"https://api.github.com/users/pradeepitm12/repos","events_url":"https://api.github.com/users/pradeepitm12/events{/privacy}","received_events_url":"https://api.github.com/users/pradeepitm12/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2019-12-26T22:18:55Z","updated_at":"2019-12-27T05:56:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tektoncd/cli/pulls/552","html_url":"https://github.com/tektoncd/cli/pull/552","diff_url":"https://github.com/tektoncd/cli/pull/552.diff","patch_url":"https://github.com/tektoncd/cli/pull/552.patch"},"body":"I added test builder methods for step state in this [pull request](https://github.com/tektoncd/pipeline/pull/1591) to pipeline. These methods have been available since pipeline 0.9.0, so I am now updating the taskrun describe unit tests to make use of these additions.\r\n\r\n# Submitter Checklist\r\n\r\nThese are the criteria that every PR should meet, please check them off as you\r\nreview them:\r\n\r\n- [x] Includes [tests](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if functionality changed/added)\r\n- [ ] Includes [docs](https://github.com/tektoncd/community/blob/master/standards.md#principles) (if user facing)\r\n- [ ] Regenerate the manpages and docs with `make docs` and `make man` if needed.\r\n- [x] Run the code checkers with `make check`\r\n- [x] Commit messages follow [commit message best practices](https://github.com/tektoncd/community/blob/master/standards.md#commit-messages)\r\n\r\n# Release Notes\r\n\r\nN/A\r\n"},"comment":{"url":"https://api.github.com/repos/tektoncd/cli/issues/comments/569195981","html_url":"https://github.com/tektoncd/cli/pull/552#issuecomment-569195981","issue_url":"https://api.github.com/repos/tektoncd/cli/issues/552","id":569195981,"node_id":"MDEyOklzc3VlQ29tbWVudDU2OTE5NTk4MQ==","user":{"login":"tekton-robot","id":48335577,"node_id":"MDQ6VXNlcjQ4MzM1NTc3","avatar_url":"https://avatars3.githubusercontent.com/u/48335577?v=4","gravatar_id":"","url":"https://api.github.com/users/tekton-robot","html_url":"https://github.com/tekton-robot","followers_url":"https://api.github.com/users/tekton-robot/followers","following_url":"https://api.github.com/users/tekton-robot/following{/other_user}","gists_url":"https://api.github.com/users/tekton-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/tekton-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekton-robot/subscriptions","organizations_url":"https://api.github.com/users/tekton-robot/orgs","repos_url":"https://api.github.com/users/tekton-robot/repos","events_url":"https://api.github.com/users/tekton-robot/events{/privacy}","received_events_url":"https://api.github.com/users/tekton-robot/received_events","type":"User","site_admin":false},"created_at":"2019-12-27T05:56:46Z","updated_at":"2019-12-27T05:56:46Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/tektoncd/cli/pull/552#pullrequestreview-336659510\" title=\"Approved\">piyush-garg</a>*, *<a href=\"https://github.com/tektoncd/cli/pull/552#pullrequestreview-336676650\" title=\"LGTM\">pradeepitm12</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=tektoncd%2Fcli).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/tektoncd/cli/blob/master/OWNERS)~~ [piyush-garg]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"tekton-robot"}}