{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments/267537647","pull_request_review_id":216971423,"id":267537647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzUzNzY0Nw==","diff_hunk":"@@ -185,6 +190,7 @@ public void storeMobilePolicyForOrg(UserAccount account, int timeout, int passLe\n         final Editor e = sp.edit();\n         e.putInt(KEY_TIMEOUT, timeout);\n         e.putInt(KEY_PASSCODE_LENGTH, passLen);\n+        e.putBoolean(KEY_BIOMETRIC_ALLOWED, bioAllowed);\n         e.commit();","path":"libs/SalesforceSDK/src/com/salesforce/androidsdk/security/PasscodeManager.java","position":34,"original_position":34,"commit_id":"463999b3029bd38d8a24af9da5e3b0bb536b6a31","original_commit_id":"463999b3029bd38d8a24af9da5e3b0bb536b6a31","user":{"login":"mobilesdk-bot","id":37682872,"node_id":"MDQ6VXNlcjM3NjgyODcy","avatar_url":"https://avatars2.githubusercontent.com/u/37682872?v=4","gravatar_id":"","url":"https://api.github.com/users/mobilesdk-bot","html_url":"https://github.com/mobilesdk-bot","followers_url":"https://api.github.com/users/mobilesdk-bot/followers","following_url":"https://api.github.com/users/mobilesdk-bot/following{/other_user}","gists_url":"https://api.github.com/users/mobilesdk-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mobilesdk-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobilesdk-bot/subscriptions","organizations_url":"https://api.github.com/users/mobilesdk-bot/orgs","repos_url":"https://api.github.com/users/mobilesdk-bot/repos","events_url":"https://api.github.com/users/mobilesdk-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mobilesdk-bot/received_events","type":"User","site_admin":false},"body":"<table data-meta=\"generated_by_SalesforceSDK\">\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td width=\"100%\" data-sticky=\"false\"><span data-href=\"https://github.com/forcedotcom/SalesforceMobileSDK-Android/blob/463999b3029bd38d8a24af9da5e3b0bb536b6a31/libs/SalesforceSDK/src/com/salesforce/androidsdk/security/PasscodeManager.java#L194\"></span>Consider using <code>apply()</code> instead; <code>commit</code> writes its data to persistent storage immediately, whereas <code>apply</code> will handle it in the background</td>\n    </tr>\n  </tbody>\n</table>\n\n\n\n","created_at":"2019-03-20T20:43:15Z","updated_at":"2019-03-20T20:43:15Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1871#discussion_r267537647","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments/267537647"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1871#discussion_r267537647"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871","id":263026074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMDI2MDc0","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1871","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1871.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1871.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1871","number":1871,"state":"open","locked":false,"title":"Make the SDK respect connected app biometric attribute.","user":{"login":"brandonpage","id":28540387,"node_id":"MDQ6VXNlcjI4NTQwMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/28540387?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonpage","html_url":"https://github.com/brandonpage","followers_url":"https://api.github.com/users/brandonpage/followers","following_url":"https://api.github.com/users/brandonpage/following{/other_user}","gists_url":"https://api.github.com/users/brandonpage/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpage/subscriptions","organizations_url":"https://api.github.com/users/brandonpage/orgs","repos_url":"https://api.github.com/users/brandonpage/repos","events_url":"https://api.github.com/users/brandonpage/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpage/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-20T20:29:56Z","updated_at":"2019-03-20T20:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"493f54840be4f86dcb58fa47cff10818fc5d5e7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1871/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/statuses/463999b3029bd38d8a24af9da5e3b0bb536b6a31","head":{"label":"brandonpage:passcode","ref":"passcode","sha":"463999b3029bd38d8a24af9da5e3b0bb536b6a31","user":{"login":"brandonpage","id":28540387,"node_id":"MDQ6VXNlcjI4NTQwMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/28540387?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonpage","html_url":"https://github.com/brandonpage","followers_url":"https://api.github.com/users/brandonpage/followers","following_url":"https://api.github.com/users/brandonpage/following{/other_user}","gists_url":"https://api.github.com/users/brandonpage/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpage/subscriptions","organizations_url":"https://api.github.com/users/brandonpage/orgs","repos_url":"https://api.github.com/users/brandonpage/repos","events_url":"https://api.github.com/users/brandonpage/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpage/received_events","type":"User","site_admin":false},"repo":{"id":97054226,"node_id":"MDEwOlJlcG9zaXRvcnk5NzA1NDIyNg==","name":"SalesforceMobileSDK-Android","full_name":"brandonpage/SalesforceMobileSDK-Android","private":false,"owner":{"login":"brandonpage","id":28540387,"node_id":"MDQ6VXNlcjI4NTQwMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/28540387?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonpage","html_url":"https://github.com/brandonpage","followers_url":"https://api.github.com/users/brandonpage/followers","following_url":"https://api.github.com/users/brandonpage/following{/other_user}","gists_url":"https://api.github.com/users/brandonpage/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpage/subscriptions","organizations_url":"https://api.github.com/users/brandonpage/orgs","repos_url":"https://api.github.com/users/brandonpage/repos","events_url":"https://api.github.com/users/brandonpage/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpage/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brandonpage/SalesforceMobileSDK-Android","description":"Android SDK for Salesforce","fork":true,"url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android","forks_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/forks","keys_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/teams","hooks_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/hooks","issue_events_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/events","assignees_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/tags","blobs_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/languages","stargazers_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/stargazers","contributors_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/contributors","subscribers_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/subscribers","subscription_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/subscription","commits_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/merges","archive_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/downloads","issues_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/brandonpage/SalesforceMobileSDK-Android/deployments","created_at":"2017-07-12T21:40:27Z","updated_at":"2017-07-12T21:40:30Z","pushed_at":"2019-03-20T20:34:08Z","git_url":"git://github.com/brandonpage/SalesforceMobileSDK-Android.git","ssh_url":"git@github.com:brandonpage/SalesforceMobileSDK-Android.git","clone_url":"https://github.com/brandonpage/SalesforceMobileSDK-Android.git","svn_url":"https://github.com/brandonpage/SalesforceMobileSDK-Android","homepage":"","size":66418,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:dev","ref":"dev","sha":"a7b7a7d128fde084f2c8038a45473b7dbe2f3832","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2782691,"node_id":"MDEwOlJlcG9zaXRvcnkyNzgyNjkx","name":"SalesforceMobileSDK-Android","full_name":"forcedotcom/SalesforceMobileSDK-Android","private":false,"owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android","description":"Android SDK for Salesforce","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/deployments","created_at":"2011-11-15T19:35:05Z","updated_at":"2019-03-07T10:38:07Z","pushed_at":"2019-03-20T20:34:09Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-Android.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-Android.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android","homepage":"","size":67881,"stargazers_count":246,"watchers_count":246,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":331,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":331,"open_issues":8,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1871"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1871"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1871/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1871/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/statuses/463999b3029bd38d8a24af9da5e3b0bb536b6a31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mobilesdk-bot"}}