{"action":"created","comment":{"url":"https://api.github.com/repos/PDAL/PDAL/pulls/comments/262506938","pull_request_review_id":210678909,"id":262506938,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjUwNjkzOA==","diff_hunk":"@@ -125,8 +91,8 @@ BOX3D EptReader::Args::bounds() const\n     const BOX2D b(m_bounds.to2d());\n     if (b.empty())\n     {\n-        double mn((std::numeric_limits<double>::lowest)());\n-        double mx((std::numeric_limits<double>::max)());\n+        const double mn((std::numeric_limits<double>::lowest)());","path":"io/EptReader.cpp","position":73,"original_position":73,"commit_id":"d6544096814a5be497433c3ed520d8bb0d506c88","original_commit_id":"d6544096814a5be497433c3ed520d8bb0d506c88","user":{"login":"chambbj","id":717558,"node_id":"MDQ6VXNlcjcxNzU1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/717558?v=4","gravatar_id":"","url":"https://api.github.com/users/chambbj","html_url":"https://github.com/chambbj","followers_url":"https://api.github.com/users/chambbj/followers","following_url":"https://api.github.com/users/chambbj/following{/other_user}","gists_url":"https://api.github.com/users/chambbj/gists{/gist_id}","starred_url":"https://api.github.com/users/chambbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambbj/subscriptions","organizations_url":"https://api.github.com/users/chambbj/orgs","repos_url":"https://api.github.com/users/chambbj/repos","events_url":"https://api.github.com/users/chambbj/events{/privacy}","received_events_url":"https://api.github.com/users/chambbj/received_events","type":"User","site_admin":false},"body":"Wouldn't this cause an issue if you had legitimate negative coordinates but did not specify bounds?","created_at":"2019-03-05T13:57:08Z","updated_at":"2019-03-05T13:59:46Z","html_url":"https://github.com/PDAL/PDAL/pull/2391#discussion_r262506938","pull_request_url":"https://api.github.com/repos/PDAL/PDAL/pulls/2391","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/comments/262506938"},"html":{"href":"https://github.com/PDAL/PDAL/pull/2391#discussion_r262506938"},"pull_request":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/2391"}}},"pull_request":{"url":"https://api.github.com/repos/PDAL/PDAL/pulls/2391","id":258107327,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4MTA3MzI3","html_url":"https://github.com/PDAL/PDAL/pull/2391","diff_url":"https://github.com/PDAL/PDAL/pull/2391.diff","patch_url":"https://github.com/PDAL/PDAL/pull/2391.patch","issue_url":"https://api.github.com/repos/PDAL/PDAL/issues/2391","number":2391,"state":"open","locked":false,"title":"EPT addon dimension writer","user":{"login":"connormanning","id":5015470,"node_id":"MDQ6VXNlcjUwMTU0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5015470?v=4","gravatar_id":"","url":"https://api.github.com/users/connormanning","html_url":"https://github.com/connormanning","followers_url":"https://api.github.com/users/connormanning/followers","following_url":"https://api.github.com/users/connormanning/following{/other_user}","gists_url":"https://api.github.com/users/connormanning/gists{/gist_id}","starred_url":"https://api.github.com/users/connormanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connormanning/subscriptions","organizations_url":"https://api.github.com/users/connormanning/orgs","repos_url":"https://api.github.com/users/connormanning/repos","events_url":"https://api.github.com/users/connormanning/events{/privacy}","received_events_url":"https://api.github.com/users/connormanning/received_events","type":"User","site_admin":false},"body":"This PR adds an EPT addon dimension writer.\r\n\r\nThis writer lets you write additional attributes externally to the source EPT data itself, so write-access to the original data location is not needed.  Additionally to the new EPT addon writer, the EPT reader has been modified such that addon attributes may be associated with a dataset at read time.\r\n\r\nThe write-side might look something like this, which runs [SMRF ground classification](https://pdal.io/stages/filters.smrf.html) over a [remote EPT resource](http://potree.entwine.io/data/autzen.html), and writes the resulting `Classification` dimension to a local path:\r\n```\r\n[{\r\n    \"type\": \"readers.ept\",\r\n    \"filename\": \"http://na.entwine.io/autzen/ept.json\"\r\n}, {\r\n    \"type\": \"filters.assign\",\r\n    \"assignment\": \"Classification[:]=0\"\r\n}, {\r\n    \"type\": \"filters.smrf\"\r\n}, {\r\n    \"type\": \"writers.ept_addon\",\r\n    \"addons\": { \"~/entwine/addons/autzen/smrf\": \"Classification\" }\r\n}]\r\n```\r\n\r\nThe corresponding read-side might look like this, which maps the above addon location back into the `Classification` value within PDAL and writes the entire modified dataset to a single file:\r\n```\r\n[{\r\n    \"type\": \"readers.ept\",\r\n    \"filename\": \"http://na.entwine.io/autzen/ept.json\",\r\n    \"addons\": { \"Classification\": \"~/entwine/addons/autzen/smrf\" }\r\n}, \r\n\"autzen-smrf-output.las\"\r\n]\r\n```\r\n\r\nBounded queries are also supported: if an EPT addon writer is used in tandem with an EPT reader invocation which is bounded by space or resolution, then the attribute will only be applied to the queried data, and this attribute for points outside of the query will be zero-initialized on subsequent reads.\r\n\r\nUsage note: the `addons` option is reversed between the EPT reader and writer: in each case, the right-hand side represents an assignment to the left-hand side.  In the writer, the dimension value is assigned to an addon path.  In the reader, the addon path is assigned to a dimension.\r\n\r\nWhile this example discussed local paths for addons, S3/GCS/Dropbox/etc paths are also supported with appropriate configuration.","created_at":"2019-03-04T22:08:52Z","updated_at":"2019-03-05T13:59:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5992a84e6647dedceebf9c2ce993e95b769f3a49","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hobu","id":87751,"node_id":"MDQ6VXNlcjg3NzUx","avatar_url":"https://avatars2.githubusercontent.com/u/87751?v=4","gravatar_id":"","url":"https://api.github.com/users/hobu","html_url":"https://github.com/hobu","followers_url":"https://api.github.com/users/hobu/followers","following_url":"https://api.github.com/users/hobu/following{/other_user}","gists_url":"https://api.github.com/users/hobu/gists{/gist_id}","starred_url":"https://api.github.com/users/hobu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hobu/subscriptions","organizations_url":"https://api.github.com/users/hobu/orgs","repos_url":"https://api.github.com/users/hobu/repos","events_url":"https://api.github.com/users/hobu/events{/privacy}","received_events_url":"https://api.github.com/users/hobu/received_events","type":"User","site_admin":false},{"login":"msmitherdc","id":1004755,"node_id":"MDQ6VXNlcjEwMDQ3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1004755?v=4","gravatar_id":"","url":"https://api.github.com/users/msmitherdc","html_url":"https://github.com/msmitherdc","followers_url":"https://api.github.com/users/msmitherdc/followers","following_url":"https://api.github.com/users/msmitherdc/following{/other_user}","gists_url":"https://api.github.com/users/msmitherdc/gists{/gist_id}","starred_url":"https://api.github.com/users/msmitherdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmitherdc/subscriptions","organizations_url":"https://api.github.com/users/msmitherdc/orgs","repos_url":"https://api.github.com/users/msmitherdc/repos","events_url":"https://api.github.com/users/msmitherdc/events{/privacy}","received_events_url":"https://api.github.com/users/msmitherdc/received_events","type":"User","site_admin":false},{"login":"abellgithub","id":1316400,"node_id":"MDQ6VXNlcjEzMTY0MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/1316400?v=4","gravatar_id":"","url":"https://api.github.com/users/abellgithub","html_url":"https://github.com/abellgithub","followers_url":"https://api.github.com/users/abellgithub/followers","following_url":"https://api.github.com/users/abellgithub/following{/other_user}","gists_url":"https://api.github.com/users/abellgithub/gists{/gist_id}","starred_url":"https://api.github.com/users/abellgithub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellgithub/subscriptions","organizations_url":"https://api.github.com/users/abellgithub/orgs","repos_url":"https://api.github.com/users/abellgithub/repos","events_url":"https://api.github.com/users/abellgithub/events{/privacy}","received_events_url":"https://api.github.com/users/abellgithub/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PDAL/PDAL/pulls/2391/commits","review_comments_url":"https://api.github.com/repos/PDAL/PDAL/pulls/2391/comments","review_comment_url":"https://api.github.com/repos/PDAL/PDAL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PDAL/PDAL/issues/2391/comments","statuses_url":"https://api.github.com/repos/PDAL/PDAL/statuses/d6544096814a5be497433c3ed520d8bb0d506c88","head":{"label":"PDAL:ept-writer","ref":"ept-writer","sha":"d6544096814a5be497433c3ed520d8bb0d506c88","user":{"login":"PDAL","id":859797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTc5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/859797?v=4","gravatar_id":"","url":"https://api.github.com/users/PDAL","html_url":"https://github.com/PDAL","followers_url":"https://api.github.com/users/PDAL/followers","following_url":"https://api.github.com/users/PDAL/following{/other_user}","gists_url":"https://api.github.com/users/PDAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDAL/subscriptions","organizations_url":"https://api.github.com/users/PDAL/orgs","repos_url":"https://api.github.com/users/PDAL/repos","events_url":"https://api.github.com/users/PDAL/events{/privacy}","received_events_url":"https://api.github.com/users/PDAL/received_events","type":"Organization","site_admin":false},"repo":{"id":2234863,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM0ODYz","name":"PDAL","full_name":"PDAL/PDAL","private":false,"owner":{"login":"PDAL","id":859797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTc5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/859797?v=4","gravatar_id":"","url":"https://api.github.com/users/PDAL","html_url":"https://github.com/PDAL","followers_url":"https://api.github.com/users/PDAL/followers","following_url":"https://api.github.com/users/PDAL/following{/other_user}","gists_url":"https://api.github.com/users/PDAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDAL/subscriptions","organizations_url":"https://api.github.com/users/PDAL/orgs","repos_url":"https://api.github.com/users/PDAL/repos","events_url":"https://api.github.com/users/PDAL/events{/privacy}","received_events_url":"https://api.github.com/users/PDAL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PDAL/PDAL","description":"PDAL is Point Data Abstraction Library. GDAL for point cloud data.","fork":false,"url":"https://api.github.com/repos/PDAL/PDAL","forks_url":"https://api.github.com/repos/PDAL/PDAL/forks","keys_url":"https://api.github.com/repos/PDAL/PDAL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PDAL/PDAL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PDAL/PDAL/teams","hooks_url":"https://api.github.com/repos/PDAL/PDAL/hooks","issue_events_url":"https://api.github.com/repos/PDAL/PDAL/issues/events{/number}","events_url":"https://api.github.com/repos/PDAL/PDAL/events","assignees_url":"https://api.github.com/repos/PDAL/PDAL/assignees{/user}","branches_url":"https://api.github.com/repos/PDAL/PDAL/branches{/branch}","tags_url":"https://api.github.com/repos/PDAL/PDAL/tags","blobs_url":"https://api.github.com/repos/PDAL/PDAL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PDAL/PDAL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PDAL/PDAL/git/refs{/sha}","trees_url":"https://api.github.com/repos/PDAL/PDAL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PDAL/PDAL/statuses/{sha}","languages_url":"https://api.github.com/repos/PDAL/PDAL/languages","stargazers_url":"https://api.github.com/repos/PDAL/PDAL/stargazers","contributors_url":"https://api.github.com/repos/PDAL/PDAL/contributors","subscribers_url":"https://api.github.com/repos/PDAL/PDAL/subscribers","subscription_url":"https://api.github.com/repos/PDAL/PDAL/subscription","commits_url":"https://api.github.com/repos/PDAL/PDAL/commits{/sha}","git_commits_url":"https://api.github.com/repos/PDAL/PDAL/git/commits{/sha}","comments_url":"https://api.github.com/repos/PDAL/PDAL/comments{/number}","issue_comment_url":"https://api.github.com/repos/PDAL/PDAL/issues/comments{/number}","contents_url":"https://api.github.com/repos/PDAL/PDAL/contents/{+path}","compare_url":"https://api.github.com/repos/PDAL/PDAL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PDAL/PDAL/merges","archive_url":"https://api.github.com/repos/PDAL/PDAL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PDAL/PDAL/downloads","issues_url":"https://api.github.com/repos/PDAL/PDAL/issues{/number}","pulls_url":"https://api.github.com/repos/PDAL/PDAL/pulls{/number}","milestones_url":"https://api.github.com/repos/PDAL/PDAL/milestones{/number}","notifications_url":"https://api.github.com/repos/PDAL/PDAL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PDAL/PDAL/labels{/name}","releases_url":"https://api.github.com/repos/PDAL/PDAL/releases{/id}","deployments_url":"https://api.github.com/repos/PDAL/PDAL/deployments","created_at":"2011-08-19T15:57:50Z","updated_at":"2019-02-26T13:18:17Z","pushed_at":"2019-03-05T00:02:42Z","git_url":"git://github.com/PDAL/PDAL.git","ssh_url":"git@github.com:PDAL/PDAL.git","clone_url":"https://github.com/PDAL/PDAL.git","svn_url":"https://github.com/PDAL/PDAL","homepage":"https://pdal.io","size":128155,"stargazers_count":341,"watchers_count":341,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":190,"open_issues":101,"watchers":341,"default_branch":"master"}},"base":{"label":"PDAL:master","ref":"master","sha":"e4dc35e3d867ce981f30fcb98a644f8814c826e3","user":{"login":"PDAL","id":859797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTc5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/859797?v=4","gravatar_id":"","url":"https://api.github.com/users/PDAL","html_url":"https://github.com/PDAL","followers_url":"https://api.github.com/users/PDAL/followers","following_url":"https://api.github.com/users/PDAL/following{/other_user}","gists_url":"https://api.github.com/users/PDAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDAL/subscriptions","organizations_url":"https://api.github.com/users/PDAL/orgs","repos_url":"https://api.github.com/users/PDAL/repos","events_url":"https://api.github.com/users/PDAL/events{/privacy}","received_events_url":"https://api.github.com/users/PDAL/received_events","type":"Organization","site_admin":false},"repo":{"id":2234863,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM0ODYz","name":"PDAL","full_name":"PDAL/PDAL","private":false,"owner":{"login":"PDAL","id":859797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTc5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/859797?v=4","gravatar_id":"","url":"https://api.github.com/users/PDAL","html_url":"https://github.com/PDAL","followers_url":"https://api.github.com/users/PDAL/followers","following_url":"https://api.github.com/users/PDAL/following{/other_user}","gists_url":"https://api.github.com/users/PDAL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDAL/subscriptions","organizations_url":"https://api.github.com/users/PDAL/orgs","repos_url":"https://api.github.com/users/PDAL/repos","events_url":"https://api.github.com/users/PDAL/events{/privacy}","received_events_url":"https://api.github.com/users/PDAL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PDAL/PDAL","description":"PDAL is Point Data Abstraction Library. GDAL for point cloud data.","fork":false,"url":"https://api.github.com/repos/PDAL/PDAL","forks_url":"https://api.github.com/repos/PDAL/PDAL/forks","keys_url":"https://api.github.com/repos/PDAL/PDAL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PDAL/PDAL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PDAL/PDAL/teams","hooks_url":"https://api.github.com/repos/PDAL/PDAL/hooks","issue_events_url":"https://api.github.com/repos/PDAL/PDAL/issues/events{/number}","events_url":"https://api.github.com/repos/PDAL/PDAL/events","assignees_url":"https://api.github.com/repos/PDAL/PDAL/assignees{/user}","branches_url":"https://api.github.com/repos/PDAL/PDAL/branches{/branch}","tags_url":"https://api.github.com/repos/PDAL/PDAL/tags","blobs_url":"https://api.github.com/repos/PDAL/PDAL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PDAL/PDAL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PDAL/PDAL/git/refs{/sha}","trees_url":"https://api.github.com/repos/PDAL/PDAL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PDAL/PDAL/statuses/{sha}","languages_url":"https://api.github.com/repos/PDAL/PDAL/languages","stargazers_url":"https://api.github.com/repos/PDAL/PDAL/stargazers","contributors_url":"https://api.github.com/repos/PDAL/PDAL/contributors","subscribers_url":"https://api.github.com/repos/PDAL/PDAL/subscribers","subscription_url":"https://api.github.com/repos/PDAL/PDAL/subscription","commits_url":"https://api.github.com/repos/PDAL/PDAL/commits{/sha}","git_commits_url":"https://api.github.com/repos/PDAL/PDAL/git/commits{/sha}","comments_url":"https://api.github.com/repos/PDAL/PDAL/comments{/number}","issue_comment_url":"https://api.github.com/repos/PDAL/PDAL/issues/comments{/number}","contents_url":"https://api.github.com/repos/PDAL/PDAL/contents/{+path}","compare_url":"https://api.github.com/repos/PDAL/PDAL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PDAL/PDAL/merges","archive_url":"https://api.github.com/repos/PDAL/PDAL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PDAL/PDAL/downloads","issues_url":"https://api.github.com/repos/PDAL/PDAL/issues{/number}","pulls_url":"https://api.github.com/repos/PDAL/PDAL/pulls{/number}","milestones_url":"https://api.github.com/repos/PDAL/PDAL/milestones{/number}","notifications_url":"https://api.github.com/repos/PDAL/PDAL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PDAL/PDAL/labels{/name}","releases_url":"https://api.github.com/repos/PDAL/PDAL/releases{/id}","deployments_url":"https://api.github.com/repos/PDAL/PDAL/deployments","created_at":"2011-08-19T15:57:50Z","updated_at":"2019-02-26T13:18:17Z","pushed_at":"2019-03-05T00:02:42Z","git_url":"git://github.com/PDAL/PDAL.git","ssh_url":"git@github.com:PDAL/PDAL.git","clone_url":"https://github.com/PDAL/PDAL.git","svn_url":"https://github.com/PDAL/PDAL","homepage":"https://pdal.io","size":128155,"stargazers_count":341,"watchers_count":341,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":190,"open_issues":101,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/2391"},"html":{"href":"https://github.com/PDAL/PDAL/pull/2391"},"issue":{"href":"https://api.github.com/repos/PDAL/PDAL/issues/2391"},"comments":{"href":"https://api.github.com/repos/PDAL/PDAL/issues/2391/comments"},"review_comments":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/2391/comments"},"review_comment":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PDAL/PDAL/pulls/2391/commits"},"statuses":{"href":"https://api.github.com/repos/PDAL/PDAL/statuses/d6544096814a5be497433c3ed520d8bb0d506c88"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chambbj"}}