{"action":"opened","number":592,"pull_request":{"url":"https://api.github.com/repos/NBISweden/swefreq/pulls/592","id":308553583,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4NTUzNTgz","html_url":"https://github.com/NBISweden/swefreq/pull/592","diff_url":"https://github.com/NBISweden/swefreq/pull/592.diff","patch_url":"https://github.com/NBISweden/swefreq/pull/592.patch","issue_url":"https://api.github.com/repos/NBISweden/swefreq/issues/592","number":592,"state":"open","locked":false,"title":"BND code cleanup","user":{"login":"MalinAhlberg","id":1029190,"node_id":"MDQ6VXNlcjEwMjkxOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1029190?v=4","gravatar_id":"","url":"https://api.github.com/users/MalinAhlberg","html_url":"https://github.com/MalinAhlberg","followers_url":"https://api.github.com/users/MalinAhlberg/followers","following_url":"https://api.github.com/users/MalinAhlberg/following{/other_user}","gists_url":"https://api.github.com/users/MalinAhlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/MalinAhlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalinAhlberg/subscriptions","organizations_url":"https://api.github.com/users/MalinAhlberg/orgs","repos_url":"https://api.github.com/users/MalinAhlberg/repos","events_url":"https://api.github.com/users/MalinAhlberg/events{/privacy}","received_events_url":"https://api.github.com/users/MalinAhlberg/received_events","type":"User","site_admin":false},"body":"### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [X] Bug fix\r\n- [X] Functional change\r\n- [X] Code cleanup\r\n\r\n### Pull request long description:\r\nClean up of the code for parsing manta files / adding structural variants / breakends. Includes both plain refactoring and functional changes.\r\n\r\n\r\n### Changes made:\r\nFunctional changes:\r\n\r\n1.  14c498c Assumption: the manta files should always add data to an existing dataset, and should therefore never add / change counts for the whole dataset. The code doing this is removed, to avoid unintended changes of the dataset counts.\r\n\r\n2.  ba73daf The `counter` now counts: +1 for every row. This information is only used for logging and the progress bar, due to the commit above. No extra counting of reversed mates is done, since `count_entries` does not count these.\r\n\r\nBug fix:\r\n\r\n3. d1f783b Bug fix: remove `not` so that the progress bar can be updated.\r\n\r\nCode cleanup:\r\n\r\n4. 18dbe54 Improve comments etc.\r\n\r\n5. 69d9f01  Make the function `parse_manta` less long by breaking out parts into its own function.\r\n","created_at":"2019-08-19T10:54:01Z","updated_at":"2019-08-19T10:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NBISweden/swefreq/pulls/592/commits","review_comments_url":"https://api.github.com/repos/NBISweden/swefreq/pulls/592/comments","review_comment_url":"https://api.github.com/repos/NBISweden/swefreq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NBISweden/swefreq/issues/592/comments","statuses_url":"https://api.github.com/repos/NBISweden/swefreq/statuses/1cf64704eb780bde691c040edd5ad8fb9e80584d","head":{"label":"NBISweden:feature/bnd_code_cleanup","ref":"feature/bnd_code_cleanup","sha":"1cf64704eb780bde691c040edd5ad8fb9e80584d","user":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"repo":{"id":57871765,"node_id":"MDEwOlJlcG9zaXRvcnk1Nzg3MTc2NQ==","name":"swefreq","full_name":"NBISweden/swefreq","private":false,"owner":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NBISweden/swefreq","description":"Swedish Frequency resource for genomics website","fork":false,"url":"https://api.github.com/repos/NBISweden/swefreq","forks_url":"https://api.github.com/repos/NBISweden/swefreq/forks","keys_url":"https://api.github.com/repos/NBISweden/swefreq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NBISweden/swefreq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NBISweden/swefreq/teams","hooks_url":"https://api.github.com/repos/NBISweden/swefreq/hooks","issue_events_url":"https://api.github.com/repos/NBISweden/swefreq/issues/events{/number}","events_url":"https://api.github.com/repos/NBISweden/swefreq/events","assignees_url":"https://api.github.com/repos/NBISweden/swefreq/assignees{/user}","branches_url":"https://api.github.com/repos/NBISweden/swefreq/branches{/branch}","tags_url":"https://api.github.com/repos/NBISweden/swefreq/tags","blobs_url":"https://api.github.com/repos/NBISweden/swefreq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NBISweden/swefreq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NBISweden/swefreq/git/refs{/sha}","trees_url":"https://api.github.com/repos/NBISweden/swefreq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NBISweden/swefreq/statuses/{sha}","languages_url":"https://api.github.com/repos/NBISweden/swefreq/languages","stargazers_url":"https://api.github.com/repos/NBISweden/swefreq/stargazers","contributors_url":"https://api.github.com/repos/NBISweden/swefreq/contributors","subscribers_url":"https://api.github.com/repos/NBISweden/swefreq/subscribers","subscription_url":"https://api.github.com/repos/NBISweden/swefreq/subscription","commits_url":"https://api.github.com/repos/NBISweden/swefreq/commits{/sha}","git_commits_url":"https://api.github.com/repos/NBISweden/swefreq/git/commits{/sha}","comments_url":"https://api.github.com/repos/NBISweden/swefreq/comments{/number}","issue_comment_url":"https://api.github.com/repos/NBISweden/swefreq/issues/comments{/number}","contents_url":"https://api.github.com/repos/NBISweden/swefreq/contents/{+path}","compare_url":"https://api.github.com/repos/NBISweden/swefreq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NBISweden/swefreq/merges","archive_url":"https://api.github.com/repos/NBISweden/swefreq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NBISweden/swefreq/downloads","issues_url":"https://api.github.com/repos/NBISweden/swefreq/issues{/number}","pulls_url":"https://api.github.com/repos/NBISweden/swefreq/pulls{/number}","milestones_url":"https://api.github.com/repos/NBISweden/swefreq/milestones{/number}","notifications_url":"https://api.github.com/repos/NBISweden/swefreq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NBISweden/swefreq/labels{/name}","releases_url":"https://api.github.com/repos/NBISweden/swefreq/releases{/id}","deployments_url":"https://api.github.com/repos/NBISweden/swefreq/deployments","created_at":"2016-05-02T07:13:31Z","updated_at":"2019-08-16T06:45:15Z","pushed_at":"2019-08-19T10:53:08Z","git_url":"git://github.com/NBISweden/swefreq.git","ssh_url":"git@github.com:NBISweden/swefreq.git","clone_url":"https://github.com/NBISweden/swefreq.git","svn_url":"https://github.com/NBISweden/swefreq","homepage":"https://swefreq.nbis.se/","size":8974,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":27,"watchers":7,"default_branch":"develop"}},"base":{"label":"NBISweden:develop","ref":"develop","sha":"8e5a3f8b045698c7dfa9cdf3a634e25d45778179","user":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"repo":{"id":57871765,"node_id":"MDEwOlJlcG9zaXRvcnk1Nzg3MTc2NQ==","name":"swefreq","full_name":"NBISweden/swefreq","private":false,"owner":{"login":"NBISweden","id":1224807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjQ4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1224807?v=4","gravatar_id":"","url":"https://api.github.com/users/NBISweden","html_url":"https://github.com/NBISweden","followers_url":"https://api.github.com/users/NBISweden/followers","following_url":"https://api.github.com/users/NBISweden/following{/other_user}","gists_url":"https://api.github.com/users/NBISweden/gists{/gist_id}","starred_url":"https://api.github.com/users/NBISweden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBISweden/subscriptions","organizations_url":"https://api.github.com/users/NBISweden/orgs","repos_url":"https://api.github.com/users/NBISweden/repos","events_url":"https://api.github.com/users/NBISweden/events{/privacy}","received_events_url":"https://api.github.com/users/NBISweden/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NBISweden/swefreq","description":"Swedish Frequency resource for genomics website","fork":false,"url":"https://api.github.com/repos/NBISweden/swefreq","forks_url":"https://api.github.com/repos/NBISweden/swefreq/forks","keys_url":"https://api.github.com/repos/NBISweden/swefreq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NBISweden/swefreq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NBISweden/swefreq/teams","hooks_url":"https://api.github.com/repos/NBISweden/swefreq/hooks","issue_events_url":"https://api.github.com/repos/NBISweden/swefreq/issues/events{/number}","events_url":"https://api.github.com/repos/NBISweden/swefreq/events","assignees_url":"https://api.github.com/repos/NBISweden/swefreq/assignees{/user}","branches_url":"https://api.github.com/repos/NBISweden/swefreq/branches{/branch}","tags_url":"https://api.github.com/repos/NBISweden/swefreq/tags","blobs_url":"https://api.github.com/repos/NBISweden/swefreq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NBISweden/swefreq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NBISweden/swefreq/git/refs{/sha}","trees_url":"https://api.github.com/repos/NBISweden/swefreq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NBISweden/swefreq/statuses/{sha}","languages_url":"https://api.github.com/repos/NBISweden/swefreq/languages","stargazers_url":"https://api.github.com/repos/NBISweden/swefreq/stargazers","contributors_url":"https://api.github.com/repos/NBISweden/swefreq/contributors","subscribers_url":"https://api.github.com/repos/NBISweden/swefreq/subscribers","subscription_url":"https://api.github.com/repos/NBISweden/swefreq/subscription","commits_url":"https://api.github.com/repos/NBISweden/swefreq/commits{/sha}","git_commits_url":"https://api.github.com/repos/NBISweden/swefreq/git/commits{/sha}","comments_url":"https://api.github.com/repos/NBISweden/swefreq/comments{/number}","issue_comment_url":"https://api.github.com/repos/NBISweden/swefreq/issues/comments{/number}","contents_url":"https://api.github.com/repos/NBISweden/swefreq/contents/{+path}","compare_url":"https://api.github.com/repos/NBISweden/swefreq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NBISweden/swefreq/merges","archive_url":"https://api.github.com/repos/NBISweden/swefreq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NBISweden/swefreq/downloads","issues_url":"https://api.github.com/repos/NBISweden/swefreq/issues{/number}","pulls_url":"https://api.github.com/repos/NBISweden/swefreq/pulls{/number}","milestones_url":"https://api.github.com/repos/NBISweden/swefreq/milestones{/number}","notifications_url":"https://api.github.com/repos/NBISweden/swefreq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NBISweden/swefreq/labels{/name}","releases_url":"https://api.github.com/repos/NBISweden/swefreq/releases{/id}","deployments_url":"https://api.github.com/repos/NBISweden/swefreq/deployments","created_at":"2016-05-02T07:13:31Z","updated_at":"2019-08-16T06:45:15Z","pushed_at":"2019-08-19T10:53:08Z","git_url":"git://github.com/NBISweden/swefreq.git","ssh_url":"git@github.com:NBISweden/swefreq.git","clone_url":"https://github.com/NBISweden/swefreq.git","svn_url":"https://github.com/NBISweden/swefreq","homepage":"https://swefreq.nbis.se/","size":8974,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":27,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NBISweden/swefreq/pulls/592"},"html":{"href":"https://github.com/NBISweden/swefreq/pull/592"},"issue":{"href":"https://api.github.com/repos/NBISweden/swefreq/issues/592"},"comments":{"href":"https://api.github.com/repos/NBISweden/swefreq/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/NBISweden/swefreq/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/NBISweden/swefreq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NBISweden/swefreq/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/NBISweden/swefreq/statuses/1cf64704eb780bde691c040edd5ad8fb9e80584d"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":55,"deletions":63,"changed_files":1}}
{"actor":{"display_login":"MalinAhlberg"}}