{"action":"created","issue":{"url":"https://api.github.com/repos/firefox-devtools/profiler/issues/1681","repository_url":"https://api.github.com/repos/firefox-devtools/profiler","labels_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/1681/labels{/name}","comments_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/1681/comments","events_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/1681/events","html_url":"https://github.com/firefox-devtools/profiler/issues/1681","id":402791547,"node_id":"MDU6SXNzdWU0MDI3OTE1NDc=","number":1681,"title":"Network chart shows loading sub-phases in the wrong place sometimes","user":{"login":"mstange","id":961291,"node_id":"MDQ6VXNlcjk2MTI5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/961291?v=4","gravatar_id":"","url":"https://api.github.com/users/mstange","html_url":"https://github.com/mstange","followers_url":"https://api.github.com/users/mstange/followers","following_url":"https://api.github.com/users/mstange/following{/other_user}","gists_url":"https://api.github.com/users/mstange/gists{/gist_id}","starred_url":"https://api.github.com/users/mstange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstange/subscriptions","organizations_url":"https://api.github.com/users/mstange/orgs","repos_url":"https://api.github.com/users/mstange/repos","events_url":"https://api.github.com/users/mstange/events{/privacy}","received_events_url":"https://api.github.com/users/mstange/received_events","type":"User","site_admin":false},"labels":[{"id":657225,"node_id":"MDU6TGFiZWw2NTcyMjU=","url":"https://api.github.com/repos/firefox-devtools/profiler/labels/bug","name":"bug","color":"fc2929","default":true},{"id":988716708,"node_id":"MDU6TGFiZWw5ODg3MTY3MDg=","url":"https://api.github.com/repos/firefox-devtools/profiler/labels/network%20panel","name":"network panel","color":"77ccff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-01-24T16:32:06Z","updated_at":"2019-02-19T15:46:48Z","closed_at":null,"author_association":"COLLABORATOR","body":"In [this profile](http://bit.ly/2R8Ot03), look at the light gray piece inside the bar for the request to `https://aax.amazon-adsystem.com/e/dtb/bid?src=3079&u=...`: The piece is at the very start of the bar.\r\n\r\nHowever, in the parent process you can see that nothing happens at that time. I think this means that that light gray piece is drawn in the wrong spot.\r\n\r\n<img width=\"1440\" alt=\"screen shot 2019-01-24 at 11 30 12 am\" src=\"https://user-images.githubusercontent.com/961291/51692759-96c7a800-1fcb-11e9-8afc-7cd311d7b7f4.png\">\r\n<img width=\"1440\" alt=\"screen shot 2019-01-24 at 11 30 49 am\" src=\"https://user-images.githubusercontent.com/961291/51692766-99c29880-1fcb-11e9-957f-0d770fc1f962.png\">\r\n\r\nThe cause for this is known, too: The outer box starts at `marker.data.startTime`: https://github.com/devtools-html/perf.html/blob/f7a938c1b8efbe08e61862f02ba839e364948319/src/components/network-chart/index.js#L199 whereas the empty space before the gray piece, which is taken up by the `requestQueue` box, thinks the start is at `marker.start`: https://github.com/devtools-html/perf.html/blob/f7a938c1b8efbe08e61862f02ba839e364948319/src/components/network-chart/NetworkChartRow.js#L90\r\n\r\nAnd those two values can apparently be different. I think we need to understand exactly what they mean and when they can be different. I'm also extremely confused by some of the variable names in the `NetworkChartRowBar` component, I think they could use a cleanup."},"comment":{"url":"https://api.github.com/repos/firefox-devtools/profiler/issues/comments/465185740","html_url":"https://github.com/firefox-devtools/profiler/issues/1681#issuecomment-465185740","issue_url":"https://api.github.com/repos/firefox-devtools/profiler/issues/1681","id":465185740,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NTE4NTc0MA==","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"created_at":"2019-02-19T15:46:48Z","updated_at":"2019-02-19T15:46:48Z","author_association":"COLLABORATOR","body":"This may be fixed in https://github.com/firefox-devtools/profiler/pull/1746 but I'd like to keep it open until I fix #1715 too."}}
{"actor":{"display_login":"julienw"}}