{"action":"created","comment":{"url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/comments/275224681","pull_request_review_id":226467257,"id":275224681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTIyNDY4MQ==","diff_hunk":"@@ -0,0 +1,167 @@\n+package epam.rome.moviescollection.model;\n+\n+import org.junit.After;\n+import org.junit.Before;\n+import org.junit.Test;\n+\n+import static org.junit.Assert.*;\n+\n+public class FilmTest {\n+\n+    private Film testFilm;\n+    private Actor testActor;\n+\n+    @Before\n+    public void setUp() {\n+        testFilm = new Film(\"Jeeves and Wooster\", 1990);\n+        testActor = new Actor(\"Hugh\", \"Laurie\" , 1959);\n+        testFilm.addActor(testActor);\n+        testFilm.setGenre(\"Comedy\");\n+    }\n+\n+    @After\n+    public void cleanUp() {\n+        testFilm = null;\n+        testActor = null;\n+    }\n+\n+    @Test\n+    public void shouldNotSetTitleEmptyTest() {\n+        String newTitle = \"\";\n+        testFilm.setTitle(newTitle);\n+        assertNotEquals(newTitle, testFilm.getTitle());\n+        testFilm.setTitle(null);\n+        assertNotEquals(null, testFilm.getTitle());\n+    }\n+\n+    @Test\n+    public void shouldSetTitleProperlyTest() {\n+        String newTitle = \"Pulp Fiction\";\n+        testFilm.setTitle(newTitle);\n+        assertEquals(newTitle, testFilm.getTitle());\n+    }\n+\n+    @Test\n+    public void shouldSetYearTooSmallTest() {\n+        int newYear = 666;\n+        testFilm.setYear(newYear);\n+        assertNotEquals(newYear, testFilm.getYear());\n+    }\n+\n+    @Test\n+    public void shouldSetYearProperlyTest() {\n+        int newYear = 1994;\n+        testFilm.setYear(newYear);\n+        assertEquals(newYear, testFilm.getYear());\n+    }\n+\n+    @Test\n+    public void shouldNotSetGenreEmptyTest() {\n+        String newGenre = \"\";\n+        testFilm.setGenre(newGenre);\n+        assertNotEquals(newGenre, testFilm.getGenre());\n+        testFilm.setGenre(null);\n+        assertNotEquals(null, testFilm.getGenre());\n+    }\n+\n+    @Test\n+    public void shouldSetGenreProperlyTest() {\n+        String newGenre = \"Crime\";\n+        testFilm.setGenre(newGenre);\n+        assertEquals(newGenre, testFilm.getGenre());\n+    }\n+\n+    @Test\n+    public void shouldNotAddNullActorTest() {\n+        int sizeBefore = testFilm.getFilmCast().size();\n+        testFilm.addActor(null);\n+        assertEquals(sizeBefore, testFilm.getFilmCast().size());\n+    }\n+\n+    @Test\n+    public void shouldAddDefaultActorTest() {\n+        Actor newActor = new Actor();\n+        testFilm.addActor(newActor);        //ВОПРОС: НУЖНЫ ЛИ ТЕСТЫ ДЛЯ КОНСТРУКТОРА С ПАРАМЕТРАМИ?","path":"moviesCollection/src/test/java/epam/rome/moviescollection/model/FilmTest.java","position":84,"original_position":84,"commit_id":"52e0ba3ff0d0e0dddfe98f29677b288674e910f4","original_commit_id":"52e0ba3ff0d0e0dddfe98f29677b288674e910f4","user":{"login":"AnnaS91","id":11267551,"node_id":"MDQ6VXNlcjExMjY3NTUx","avatar_url":"https://avatars1.githubusercontent.com/u/11267551?v=4","gravatar_id":"","url":"https://api.github.com/users/AnnaS91","html_url":"https://github.com/AnnaS91","followers_url":"https://api.github.com/users/AnnaS91/followers","following_url":"https://api.github.com/users/AnnaS91/following{/other_user}","gists_url":"https://api.github.com/users/AnnaS91/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaS91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaS91/subscriptions","organizations_url":"https://api.github.com/users/AnnaS91/orgs","repos_url":"https://api.github.com/users/AnnaS91/repos","events_url":"https://api.github.com/users/AnnaS91/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaS91/received_events","type":"User","site_admin":false},"body":"в случае когда он просто инициализирует поля - нет, он покроется у Вас тестами за счёт вызова в других тестах. Если там какая-то крутая логика - да, нужны.","created_at":"2019-04-15T06:51:03Z","updated_at":"2019-04-15T06:52:29Z","html_url":"https://github.com/RomE-HK/java-at-lessons/pull/6#discussion_r275224681","pull_request_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/comments/275224681"},"html":{"href":"https://github.com/RomE-HK/java-at-lessons/pull/6#discussion_r275224681"},"pull_request":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6","id":270300490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMzAwNDkw","html_url":"https://github.com/RomE-HK/java-at-lessons/pull/6","diff_url":"https://github.com/RomE-HK/java-at-lessons/pull/6.diff","patch_url":"https://github.com/RomE-HK/java-at-lessons/pull/6.patch","issue_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/6","number":6,"state":"open","locked":false,"title":"Movies","user":{"login":"RomE-HK","id":12252901,"node_id":"MDQ6VXNlcjEyMjUyOTAx","avatar_url":"https://avatars2.githubusercontent.com/u/12252901?v=4","gravatar_id":"","url":"https://api.github.com/users/RomE-HK","html_url":"https://github.com/RomE-HK","followers_url":"https://api.github.com/users/RomE-HK/followers","following_url":"https://api.github.com/users/RomE-HK/following{/other_user}","gists_url":"https://api.github.com/users/RomE-HK/gists{/gist_id}","starred_url":"https://api.github.com/users/RomE-HK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomE-HK/subscriptions","organizations_url":"https://api.github.com/users/RomE-HK/orgs","repos_url":"https://api.github.com/users/RomE-HK/repos","events_url":"https://api.github.com/users/RomE-HK/events{/privacy}","received_events_url":"https://api.github.com/users/RomE-HK/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2019-04-14T14:19:06Z","updated_at":"2019-04-15T06:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"956d2ef8830cee84ec4a7f064a7a5f64fde502fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6/commits","review_comments_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6/comments","review_comment_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/6/comments","statuses_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/statuses/52e0ba3ff0d0e0dddfe98f29677b288674e910f4","head":{"label":"RomE-HK:movies","ref":"movies","sha":"52e0ba3ff0d0e0dddfe98f29677b288674e910f4","user":{"login":"RomE-HK","id":12252901,"node_id":"MDQ6VXNlcjEyMjUyOTAx","avatar_url":"https://avatars2.githubusercontent.com/u/12252901?v=4","gravatar_id":"","url":"https://api.github.com/users/RomE-HK","html_url":"https://github.com/RomE-HK","followers_url":"https://api.github.com/users/RomE-HK/followers","following_url":"https://api.github.com/users/RomE-HK/following{/other_user}","gists_url":"https://api.github.com/users/RomE-HK/gists{/gist_id}","starred_url":"https://api.github.com/users/RomE-HK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomE-HK/subscriptions","organizations_url":"https://api.github.com/users/RomE-HK/orgs","repos_url":"https://api.github.com/users/RomE-HK/repos","events_url":"https://api.github.com/users/RomE-HK/events{/privacy}","received_events_url":"https://api.github.com/users/RomE-HK/received_events","type":"User","site_admin":false},"repo":{"id":171654894,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTQ4OTQ=","name":"java-at-lessons","full_name":"RomE-HK/java-at-lessons","private":false,"owner":{"login":"RomE-HK","id":12252901,"node_id":"MDQ6VXNlcjEyMjUyOTAx","avatar_url":"https://avatars2.githubusercontent.com/u/12252901?v=4","gravatar_id":"","url":"https://api.github.com/users/RomE-HK","html_url":"https://github.com/RomE-HK","followers_url":"https://api.github.com/users/RomE-HK/followers","following_url":"https://api.github.com/users/RomE-HK/following{/other_user}","gists_url":"https://api.github.com/users/RomE-HK/gists{/gist_id}","starred_url":"https://api.github.com/users/RomE-HK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomE-HK/subscriptions","organizations_url":"https://api.github.com/users/RomE-HK/orgs","repos_url":"https://api.github.com/users/RomE-HK/repos","events_url":"https://api.github.com/users/RomE-HK/events{/privacy}","received_events_url":"https://api.github.com/users/RomE-HK/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RomE-HK/java-at-lessons","description":null,"fork":false,"url":"https://api.github.com/repos/RomE-HK/java-at-lessons","forks_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/forks","keys_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/teams","hooks_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/hooks","issue_events_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/events{/number}","events_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/events","assignees_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/assignees{/user}","branches_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/branches{/branch}","tags_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/tags","blobs_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/refs{/sha}","trees_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/statuses/{sha}","languages_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/languages","stargazers_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/stargazers","contributors_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/contributors","subscribers_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/subscribers","subscription_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/subscription","commits_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/commits{/sha}","git_commits_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/commits{/sha}","comments_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/comments{/number}","issue_comment_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/comments{/number}","contents_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/contents/{+path}","compare_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/merges","archive_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/downloads","issues_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues{/number}","pulls_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls{/number}","milestones_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/milestones{/number}","notifications_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/labels{/name}","releases_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/releases{/id}","deployments_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/deployments","created_at":"2019-02-20T10:47:55Z","updated_at":"2019-03-21T09:51:26Z","pushed_at":"2019-04-14T14:19:06Z","git_url":"git://github.com/RomE-HK/java-at-lessons.git","ssh_url":"git@github.com:RomE-HK/java-at-lessons.git","clone_url":"https://github.com/RomE-HK/java-at-lessons.git","svn_url":"https://github.com/RomE-HK/java-at-lessons","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"RomE-HK:master","ref":"master","sha":"d20de0d8ebe5e20b3684bed29db77fa718156d6e","user":{"login":"RomE-HK","id":12252901,"node_id":"MDQ6VXNlcjEyMjUyOTAx","avatar_url":"https://avatars2.githubusercontent.com/u/12252901?v=4","gravatar_id":"","url":"https://api.github.com/users/RomE-HK","html_url":"https://github.com/RomE-HK","followers_url":"https://api.github.com/users/RomE-HK/followers","following_url":"https://api.github.com/users/RomE-HK/following{/other_user}","gists_url":"https://api.github.com/users/RomE-HK/gists{/gist_id}","starred_url":"https://api.github.com/users/RomE-HK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomE-HK/subscriptions","organizations_url":"https://api.github.com/users/RomE-HK/orgs","repos_url":"https://api.github.com/users/RomE-HK/repos","events_url":"https://api.github.com/users/RomE-HK/events{/privacy}","received_events_url":"https://api.github.com/users/RomE-HK/received_events","type":"User","site_admin":false},"repo":{"id":171654894,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTQ4OTQ=","name":"java-at-lessons","full_name":"RomE-HK/java-at-lessons","private":false,"owner":{"login":"RomE-HK","id":12252901,"node_id":"MDQ6VXNlcjEyMjUyOTAx","avatar_url":"https://avatars2.githubusercontent.com/u/12252901?v=4","gravatar_id":"","url":"https://api.github.com/users/RomE-HK","html_url":"https://github.com/RomE-HK","followers_url":"https://api.github.com/users/RomE-HK/followers","following_url":"https://api.github.com/users/RomE-HK/following{/other_user}","gists_url":"https://api.github.com/users/RomE-HK/gists{/gist_id}","starred_url":"https://api.github.com/users/RomE-HK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomE-HK/subscriptions","organizations_url":"https://api.github.com/users/RomE-HK/orgs","repos_url":"https://api.github.com/users/RomE-HK/repos","events_url":"https://api.github.com/users/RomE-HK/events{/privacy}","received_events_url":"https://api.github.com/users/RomE-HK/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RomE-HK/java-at-lessons","description":null,"fork":false,"url":"https://api.github.com/repos/RomE-HK/java-at-lessons","forks_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/forks","keys_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/teams","hooks_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/hooks","issue_events_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/events{/number}","events_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/events","assignees_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/assignees{/user}","branches_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/branches{/branch}","tags_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/tags","blobs_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/refs{/sha}","trees_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/statuses/{sha}","languages_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/languages","stargazers_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/stargazers","contributors_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/contributors","subscribers_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/subscribers","subscription_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/subscription","commits_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/commits{/sha}","git_commits_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/git/commits{/sha}","comments_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/comments{/number}","issue_comment_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/comments{/number}","contents_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/contents/{+path}","compare_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/merges","archive_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/downloads","issues_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues{/number}","pulls_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls{/number}","milestones_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/milestones{/number}","notifications_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/labels{/name}","releases_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/releases{/id}","deployments_url":"https://api.github.com/repos/RomE-HK/java-at-lessons/deployments","created_at":"2019-02-20T10:47:55Z","updated_at":"2019-03-21T09:51:26Z","pushed_at":"2019-04-14T14:19:06Z","git_url":"git://github.com/RomE-HK/java-at-lessons.git","ssh_url":"git@github.com:RomE-HK/java-at-lessons.git","clone_url":"https://github.com/RomE-HK/java-at-lessons.git","svn_url":"https://github.com/RomE-HK/java-at-lessons","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6"},"html":{"href":"https://github.com/RomE-HK/java-at-lessons/pull/6"},"issue":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/6"},"comments":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/RomE-HK/java-at-lessons/statuses/52e0ba3ff0d0e0dddfe98f29677b288674e910f4"}},"author_association":"OWNER"}}
{"actor":{"display_login":"AnnaS91"}}