{"comment":{"url":"https://api.github.com/repos/zeek/zeek/comments/35493083","html_url":"https://github.com/zeek/zeek/commit/30a82365cd507e93466f8f02246d6c8f9be847b0#commitcomment-35493083","id":35493083,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzNTQ5MzA4Mw==","user":{"login":"jsiwek","id":422685,"node_id":"MDQ6VXNlcjQyMjY4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/422685?v=4","gravatar_id":"","url":"https://api.github.com/users/jsiwek","html_url":"https://github.com/jsiwek","followers_url":"https://api.github.com/users/jsiwek/followers","following_url":"https://api.github.com/users/jsiwek/following{/other_user}","gists_url":"https://api.github.com/users/jsiwek/gists{/gist_id}","starred_url":"https://api.github.com/users/jsiwek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsiwek/subscriptions","organizations_url":"https://api.github.com/users/jsiwek/orgs","repos_url":"https://api.github.com/users/jsiwek/repos","events_url":"https://api.github.com/users/jsiwek/events{/privacy}","received_events_url":"https://api.github.com/users/jsiwek/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"30a82365cd507e93466f8f02246d6c8f9be847b0","created_at":"2019-10-14T17:54:32Z","updated_at":"2019-10-14T17:54:32Z","author_association":"MEMBER","body":"Can you explain a bit where the copies were happening?  It looked like all `data_to_val` calls are all using `std::move`.  Or was it actually the move ctor for `data` generally performs worse than just passing by reference in most cases?  Also didn't get why `timestamp` and `timespan` are better to pass by value?  Maybe a time where a few explanatory comments could help?\r\n\r\nAnd nit: since C++11, there's no functional difference between `data()` and `c_str()`, right ?  If not, those changes are a bit distracting."}}
{"actor":{"display_login":"jsiwek"}}