{"action":"created","comment":{"url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/comments/269655571","pull_request_review_id":219580899,"id":269655571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTY1NTU3MQ==","diff_hunk":"@@ -328,6 +358,18 @@ define([\n                 this.$mediaStimulusContainer.removeClass('active');\n             }\n         },\n+        /**\n+         * Create countdown timer\n+         */\n+        initCountdown: function initCountdown() {\n+            if (this.config.autoStart === true) {\n+                var delayInSeconds = this.config.delayMinutes * 60 + this.config.delaySeconds;","path":"views/js/pciCreator/dev/audioRecordingInteraction/runtime/audioRecordingInteraction.js","position":103,"original_position":103,"commit_id":"b0f1863db199e11d19e3d567a2a0e95f16c7e0e7","original_commit_id":"b0f1863db199e11d19e3d567a2a0e95f16c7e0e7","user":{"login":"jsconan","id":1500098,"node_id":"MDQ6VXNlcjE1MDAwOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1500098?v=4","gravatar_id":"","url":"https://api.github.com/users/jsconan","html_url":"https://github.com/jsconan","followers_url":"https://api.github.com/users/jsconan/followers","following_url":"https://api.github.com/users/jsconan/following{/other_user}","gists_url":"https://api.github.com/users/jsconan/gists{/gist_id}","starred_url":"https://api.github.com/users/jsconan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsconan/subscriptions","organizations_url":"https://api.github.com/users/jsconan/orgs","repos_url":"https://api.github.com/users/jsconan/repos","events_url":"https://api.github.com/users/jsconan/events{/privacy}","received_events_url":"https://api.github.com/users/jsconan/received_events","type":"User","site_admin":false},"body":"Indeed, the variable could be avoided. However, the bigger issue is the variable declaration is not following the good practices: when using the `var` keyword, the variable should be always be declared on top to reflect hoisting.","created_at":"2019-03-27T16:30:22Z","updated_at":"2019-03-27T16:30:22Z","html_url":"https://github.com/oat-sa/extension-tao-itemqti-pci/pull/149#discussion_r269655571","pull_request_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/comments/269655571"},"html":{"href":"https://github.com/oat-sa/extension-tao-itemqti-pci/pull/149#discussion_r269655571"},"pull_request":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149"}},"in_reply_to_id":269641421},"pull_request":{"url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149","id":263240709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMjQwNzA5","html_url":"https://github.com/oat-sa/extension-tao-itemqti-pci/pull/149","diff_url":"https://github.com/oat-sa/extension-tao-itemqti-pci/pull/149.diff","patch_url":"https://github.com/oat-sa/extension-tao-itemqti-pci/pull/149.patch","issue_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/149","number":149,"state":"open","locked":false,"title":"Feature/tao 7801/countdown audio recording pause","user":{"login":"bziondik","id":25976342,"node_id":"MDQ6VXNlcjI1OTc2MzQy","avatar_url":"https://avatars2.githubusercontent.com/u/25976342?v=4","gravatar_id":"","url":"https://api.github.com/users/bziondik","html_url":"https://github.com/bziondik","followers_url":"https://api.github.com/users/bziondik/followers","following_url":"https://api.github.com/users/bziondik/following{/other_user}","gists_url":"https://api.github.com/users/bziondik/gists{/gist_id}","starred_url":"https://api.github.com/users/bziondik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bziondik/subscriptions","organizations_url":"https://api.github.com/users/bziondik/orgs","repos_url":"https://api.github.com/users/bziondik/repos","events_url":"https://api.github.com/users/bziondik/events{/privacy}","received_events_url":"https://api.github.com/users/bziondik/received_events","type":"User","site_admin":false},"body":"Related to: https://oat-sa.atlassian.net/browse/TAO-7801\r\n \r\nCreated uiElement countdownPieChart.\r\nIf set in config autoStart and delay then ask permission to access the mic before running countdown.\r\n  \r\n#### How to test\r\n- create Item with audio record interaction\r\n- set autoPlay\r\n- set delay\r\n- save\r\n- set permission Microphone - Ask\r\n- preview item\r\n- allow Microphone  ","created_at":"2019-03-21T13:44:20Z","updated_at":"2019-03-27T16:30:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61601631630964312184799e43e53b8e61340a7d","assignee":{"login":"ricproenca-tao","id":45600417,"node_id":"MDQ6VXNlcjQ1NjAwNDE3","avatar_url":"https://avatars0.githubusercontent.com/u/45600417?v=4","gravatar_id":"","url":"https://api.github.com/users/ricproenca-tao","html_url":"https://github.com/ricproenca-tao","followers_url":"https://api.github.com/users/ricproenca-tao/followers","following_url":"https://api.github.com/users/ricproenca-tao/following{/other_user}","gists_url":"https://api.github.com/users/ricproenca-tao/gists{/gist_id}","starred_url":"https://api.github.com/users/ricproenca-tao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricproenca-tao/subscriptions","organizations_url":"https://api.github.com/users/ricproenca-tao/orgs","repos_url":"https://api.github.com/users/ricproenca-tao/repos","events_url":"https://api.github.com/users/ricproenca-tao/events{/privacy}","received_events_url":"https://api.github.com/users/ricproenca-tao/received_events","type":"User","site_admin":false},"assignees":[{"login":"ricproenca-tao","id":45600417,"node_id":"MDQ6VXNlcjQ1NjAwNDE3","avatar_url":"https://avatars0.githubusercontent.com/u/45600417?v=4","gravatar_id":"","url":"https://api.github.com/users/ricproenca-tao","html_url":"https://github.com/ricproenca-tao","followers_url":"https://api.github.com/users/ricproenca-tao/followers","following_url":"https://api.github.com/users/ricproenca-tao/following{/other_user}","gists_url":"https://api.github.com/users/ricproenca-tao/gists{/gist_id}","starred_url":"https://api.github.com/users/ricproenca-tao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricproenca-tao/subscriptions","organizations_url":"https://api.github.com/users/ricproenca-tao/orgs","repos_url":"https://api.github.com/users/ricproenca-tao/repos","events_url":"https://api.github.com/users/ricproenca-tao/events{/privacy}","received_events_url":"https://api.github.com/users/ricproenca-tao/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149/commits","review_comments_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149/comments","review_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/149/comments","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/statuses/b0f1863db199e11d19e3d567a2a0e95f16c7e0e7","head":{"label":"oat-sa:feature/TAO-7801/countdown_audio_recording_pause","ref":"feature/TAO-7801/countdown_audio_recording_pause","sha":"b0f1863db199e11d19e3d567a2a0e95f16c7e0e7","user":{"login":"oat-sa","id":7581081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1ODEwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":22882861,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4Mjg2MQ==","name":"extension-tao-itemqti-pci","full_name":"oat-sa/extension-tao-itemqti-pci","private":false,"owner":{"login":"oat-sa","id":7581081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1ODEwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oat-sa/extension-tao-itemqti-pci","description":null,"fork":false,"url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci","forks_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/forks","keys_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/teams","hooks_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/hooks","issue_events_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/events{/number}","events_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/events","assignees_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/assignees{/user}","branches_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/branches{/branch}","tags_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/tags","blobs_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/refs{/sha}","trees_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/statuses/{sha}","languages_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/languages","stargazers_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/stargazers","contributors_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/contributors","subscribers_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/subscribers","subscription_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/subscription","commits_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/commits{/sha}","git_commits_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/commits{/sha}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/comments{/number}","issue_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/comments{/number}","contents_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/contents/{+path}","compare_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/merges","archive_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/downloads","issues_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues{/number}","pulls_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls{/number}","milestones_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/milestones{/number}","notifications_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/labels{/name}","releases_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/releases{/id}","deployments_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/deployments","created_at":"2014-08-12T15:39:33Z","updated_at":"2019-03-15T10:15:17Z","pushed_at":"2019-03-27T15:03:37Z","git_url":"git://github.com/oat-sa/extension-tao-itemqti-pci.git","ssh_url":"git@github.com:oat-sa/extension-tao-itemqti-pci.git","clone_url":"https://github.com/oat-sa/extension-tao-itemqti-pci.git","svn_url":"https://github.com/oat-sa/extension-tao-itemqti-pci","homepage":"","size":8826,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":7,"open_issues":2,"watchers":6,"default_branch":"master"}},"base":{"label":"oat-sa:develop","ref":"develop","sha":"058349f73dd5ce1f7138557712890b4e822f4f3c","user":{"login":"oat-sa","id":7581081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1ODEwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":22882861,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4Mjg2MQ==","name":"extension-tao-itemqti-pci","full_name":"oat-sa/extension-tao-itemqti-pci","private":false,"owner":{"login":"oat-sa","id":7581081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1ODEwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oat-sa/extension-tao-itemqti-pci","description":null,"fork":false,"url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci","forks_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/forks","keys_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/teams","hooks_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/hooks","issue_events_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/events{/number}","events_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/events","assignees_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/assignees{/user}","branches_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/branches{/branch}","tags_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/tags","blobs_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/refs{/sha}","trees_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/statuses/{sha}","languages_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/languages","stargazers_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/stargazers","contributors_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/contributors","subscribers_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/subscribers","subscription_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/subscription","commits_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/commits{/sha}","git_commits_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/git/commits{/sha}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/comments{/number}","issue_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/comments{/number}","contents_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/contents/{+path}","compare_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/merges","archive_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/downloads","issues_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues{/number}","pulls_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls{/number}","milestones_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/milestones{/number}","notifications_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/labels{/name}","releases_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/releases{/id}","deployments_url":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/deployments","created_at":"2014-08-12T15:39:33Z","updated_at":"2019-03-15T10:15:17Z","pushed_at":"2019-03-27T15:03:37Z","git_url":"git://github.com/oat-sa/extension-tao-itemqti-pci.git","ssh_url":"git@github.com:oat-sa/extension-tao-itemqti-pci.git","clone_url":"https://github.com/oat-sa/extension-tao-itemqti-pci.git","svn_url":"https://github.com/oat-sa/extension-tao-itemqti-pci","homepage":"","size":8826,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":7,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149"},"html":{"href":"https://github.com/oat-sa/extension-tao-itemqti-pci/pull/149"},"issue":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/149"},"comments":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/oat-sa/extension-tao-itemqti-pci/statuses/b0f1863db199e11d19e3d567a2a0e95f16c7e0e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsconan"}}