{"action":"opened","number":4347,"pull_request":{"url":"https://api.github.com/repos/OISF/suricata/pulls/4347","id":337342550,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3MzQyNTUw","html_url":"https://github.com/OISF/suricata/pull/4347","diff_url":"https://github.com/OISF/suricata/pull/4347.diff","patch_url":"https://github.com/OISF/suricata/pull/4347.patch","issue_url":"https://api.github.com/repos/OISF/suricata/issues/4347","number":4347,"state":"open","locked":false,"title":"transform: adds url_decode keyword","user":{"login":"catenacyber","id":35799796,"node_id":"MDQ6VXNlcjM1Nzk5Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/35799796?v=4","gravatar_id":"","url":"https://api.github.com/users/catenacyber","html_url":"https://github.com/catenacyber","followers_url":"https://api.github.com/users/catenacyber/followers","following_url":"https://api.github.com/users/catenacyber/following{/other_user}","gists_url":"https://api.github.com/users/catenacyber/gists{/gist_id}","starred_url":"https://api.github.com/users/catenacyber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catenacyber/subscriptions","organizations_url":"https://api.github.com/users/catenacyber/orgs","repos_url":"https://api.github.com/users/catenacyber/repos","events_url":"https://api.github.com/users/catenacyber/events{/privacy}","received_events_url":"https://api.github.com/users/catenacyber/received_events","type":"User","site_admin":false},"body":"Link to [redmine](https://redmine.openinfosecfoundation.org/projects/suricata/issues) ticket:\r\nhttps://redmine.openinfosecfoundation.org/issues/2689\r\n\r\nDescribe changes:\r\n- Adds url_decode transform keyword (and even updates the doc)\r\n\r\nThere are some open questions :\r\n- should this PR limit the size of the input buffer ? as mentioned here https://redmine.openinfosecfoundation.org/issues/2689#note-1\r\n- What should be the behavior in the case the transform fails ? (that is the buffer is not a valid url-encoded one and has patterns such as `%ZZ`) Right, now I keep undecoded data (like https://www.urldecoder.org for instance)\r\n- The use of a transform looked good to me as it can get reused and is only computed if needed, but there is the suggestion to do it like `http_uri`\r\n\r\nThere is no reuse of libhtp code as libhtp `htp_decode_path_inplace` mixes more context, such as setting `response_status_expected_number` for the transaction...\r\n\r\nMakes test https://github.com/OISF/suricata-verify/pull/146 pass","created_at":"2019-11-06T12:47:22Z","updated_at":"2019-11-06T12:47:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"norg","id":250673,"node_id":"MDQ6VXNlcjI1MDY3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/250673?v=4","gravatar_id":"","url":"https://api.github.com/users/norg","html_url":"https://github.com/norg","followers_url":"https://api.github.com/users/norg/followers","following_url":"https://api.github.com/users/norg/following{/other_user}","gists_url":"https://api.github.com/users/norg/gists{/gist_id}","starred_url":"https://api.github.com/users/norg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norg/subscriptions","organizations_url":"https://api.github.com/users/norg/orgs","repos_url":"https://api.github.com/users/norg/repos","events_url":"https://api.github.com/users/norg/events{/privacy}","received_events_url":"https://api.github.com/users/norg/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"OISF Team","id":2180748,"node_id":"MDQ6VGVhbTIxODA3NDg=","slug":"oisf-team","description":"","privacy":"closed","url":"https://api.github.com/teams/2180748","html_url":"https://github.com/orgs/OISF/teams/oisf-team","members_url":"https://api.github.com/teams/2180748/members{/member}","repositories_url":"https://api.github.com/teams/2180748/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OISF/suricata/pulls/4347/commits","review_comments_url":"https://api.github.com/repos/OISF/suricata/pulls/4347/comments","review_comment_url":"https://api.github.com/repos/OISF/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OISF/suricata/issues/4347/comments","statuses_url":"https://api.github.com/repos/OISF/suricata/statuses/d37b7ec518b5aa2cba8dd94402d119174e293c3b","head":{"label":"catenacyber:transform-urldecode-2689-v1","ref":"transform-urldecode-2689-v1","sha":"d37b7ec518b5aa2cba8dd94402d119174e293c3b","user":{"login":"catenacyber","id":35799796,"node_id":"MDQ6VXNlcjM1Nzk5Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/35799796?v=4","gravatar_id":"","url":"https://api.github.com/users/catenacyber","html_url":"https://github.com/catenacyber","followers_url":"https://api.github.com/users/catenacyber/followers","following_url":"https://api.github.com/users/catenacyber/following{/other_user}","gists_url":"https://api.github.com/users/catenacyber/gists{/gist_id}","starred_url":"https://api.github.com/users/catenacyber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catenacyber/subscriptions","organizations_url":"https://api.github.com/users/catenacyber/orgs","repos_url":"https://api.github.com/users/catenacyber/repos","events_url":"https://api.github.com/users/catenacyber/events{/privacy}","received_events_url":"https://api.github.com/users/catenacyber/received_events","type":"User","site_admin":false},"repo":{"id":118895629,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4OTU2Mjk=","name":"suricata","full_name":"catenacyber/suricata","private":false,"owner":{"login":"catenacyber","id":35799796,"node_id":"MDQ6VXNlcjM1Nzk5Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/35799796?v=4","gravatar_id":"","url":"https://api.github.com/users/catenacyber","html_url":"https://github.com/catenacyber","followers_url":"https://api.github.com/users/catenacyber/followers","following_url":"https://api.github.com/users/catenacyber/following{/other_user}","gists_url":"https://api.github.com/users/catenacyber/gists{/gist_id}","starred_url":"https://api.github.com/users/catenacyber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catenacyber/subscriptions","organizations_url":"https://api.github.com/users/catenacyber/orgs","repos_url":"https://api.github.com/users/catenacyber/repos","events_url":"https://api.github.com/users/catenacyber/events{/privacy}","received_events_url":"https://api.github.com/users/catenacyber/received_events","type":"User","site_admin":false},"html_url":"https://github.com/catenacyber/suricata","description":"Suricata git repository maintained by the OISF","fork":true,"url":"https://api.github.com/repos/catenacyber/suricata","forks_url":"https://api.github.com/repos/catenacyber/suricata/forks","keys_url":"https://api.github.com/repos/catenacyber/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catenacyber/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catenacyber/suricata/teams","hooks_url":"https://api.github.com/repos/catenacyber/suricata/hooks","issue_events_url":"https://api.github.com/repos/catenacyber/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/catenacyber/suricata/events","assignees_url":"https://api.github.com/repos/catenacyber/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/catenacyber/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/catenacyber/suricata/tags","blobs_url":"https://api.github.com/repos/catenacyber/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catenacyber/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catenacyber/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/catenacyber/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catenacyber/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/catenacyber/suricata/languages","stargazers_url":"https://api.github.com/repos/catenacyber/suricata/stargazers","contributors_url":"https://api.github.com/repos/catenacyber/suricata/contributors","subscribers_url":"https://api.github.com/repos/catenacyber/suricata/subscribers","subscription_url":"https://api.github.com/repos/catenacyber/suricata/subscription","commits_url":"https://api.github.com/repos/catenacyber/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/catenacyber/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/catenacyber/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/catenacyber/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/catenacyber/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/catenacyber/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catenacyber/suricata/merges","archive_url":"https://api.github.com/repos/catenacyber/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catenacyber/suricata/downloads","issues_url":"https://api.github.com/repos/catenacyber/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/catenacyber/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/catenacyber/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/catenacyber/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catenacyber/suricata/labels{/name}","releases_url":"https://api.github.com/repos/catenacyber/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/catenacyber/suricata/deployments","created_at":"2018-01-25T10:01:50Z","updated_at":"2019-05-29T19:22:14Z","pushed_at":"2019-11-06T12:23:17Z","git_url":"git://github.com/catenacyber/suricata.git","ssh_url":"git@github.com:catenacyber/suricata.git","clone_url":"https://github.com/catenacyber/suricata.git","svn_url":"https://github.com/catenacyber/suricata","homepage":"http://suricata-ids.org/","size":43743,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OISF:master","ref":"master","sha":"51ec980e803002aba695dc91c542646b64d7ded4","user":{"login":"OISF","id":2188963,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxODg5NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2188963?v=4","gravatar_id":"","url":"https://api.github.com/users/OISF","html_url":"https://github.com/OISF","followers_url":"https://api.github.com/users/OISF/followers","following_url":"https://api.github.com/users/OISF/following{/other_user}","gists_url":"https://api.github.com/users/OISF/gists{/gist_id}","starred_url":"https://api.github.com/users/OISF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OISF/subscriptions","organizations_url":"https://api.github.com/users/OISF/orgs","repos_url":"https://api.github.com/users/OISF/repos","events_url":"https://api.github.com/users/OISF/events{/privacy}","received_events_url":"https://api.github.com/users/OISF/received_events","type":"Organization","site_admin":false},"repo":{"id":5410234,"node_id":"MDEwOlJlcG9zaXRvcnk1NDEwMjM0","name":"suricata","full_name":"OISF/suricata","private":false,"owner":{"login":"OISF","id":2188963,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxODg5NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2188963?v=4","gravatar_id":"","url":"https://api.github.com/users/OISF","html_url":"https://github.com/OISF","followers_url":"https://api.github.com/users/OISF/followers","following_url":"https://api.github.com/users/OISF/following{/other_user}","gists_url":"https://api.github.com/users/OISF/gists{/gist_id}","starred_url":"https://api.github.com/users/OISF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OISF/subscriptions","organizations_url":"https://api.github.com/users/OISF/orgs","repos_url":"https://api.github.com/users/OISF/repos","events_url":"https://api.github.com/users/OISF/events{/privacy}","received_events_url":"https://api.github.com/users/OISF/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OISF/suricata","description":"Suricata git repository maintained by the OISF","fork":false,"url":"https://api.github.com/repos/OISF/suricata","forks_url":"https://api.github.com/repos/OISF/suricata/forks","keys_url":"https://api.github.com/repos/OISF/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OISF/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OISF/suricata/teams","hooks_url":"https://api.github.com/repos/OISF/suricata/hooks","issue_events_url":"https://api.github.com/repos/OISF/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/OISF/suricata/events","assignees_url":"https://api.github.com/repos/OISF/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/OISF/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/OISF/suricata/tags","blobs_url":"https://api.github.com/repos/OISF/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OISF/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OISF/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/OISF/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OISF/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/OISF/suricata/languages","stargazers_url":"https://api.github.com/repos/OISF/suricata/stargazers","contributors_url":"https://api.github.com/repos/OISF/suricata/contributors","subscribers_url":"https://api.github.com/repos/OISF/suricata/subscribers","subscription_url":"https://api.github.com/repos/OISF/suricata/subscription","commits_url":"https://api.github.com/repos/OISF/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/OISF/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/OISF/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/OISF/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/OISF/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/OISF/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OISF/suricata/merges","archive_url":"https://api.github.com/repos/OISF/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OISF/suricata/downloads","issues_url":"https://api.github.com/repos/OISF/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/OISF/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/OISF/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/OISF/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OISF/suricata/labels{/name}","releases_url":"https://api.github.com/repos/OISF/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/OISF/suricata/deployments","created_at":"2012-08-14T08:30:06Z","updated_at":"2019-11-05T03:36:19Z","pushed_at":"2019-11-06T09:50:15Z","git_url":"git://github.com/OISF/suricata.git","ssh_url":"git@github.com:OISF/suricata.git","clone_url":"https://github.com/OISF/suricata.git","svn_url":"https://github.com/OISF/suricata","homepage":"https://suricata-ids.org/","size":43602,"stargazers_count":1264,"watchers_count":1264,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":659,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":47,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":659,"open_issues":47,"watchers":1264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OISF/suricata/pulls/4347"},"html":{"href":"https://github.com/OISF/suricata/pull/4347"},"issue":{"href":"https://api.github.com/repos/OISF/suricata/issues/4347"},"comments":{"href":"https://api.github.com/repos/OISF/suricata/issues/4347/comments"},"review_comments":{"href":"https://api.github.com/repos/OISF/suricata/pulls/4347/comments"},"review_comment":{"href":"https://api.github.com/repos/OISF/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OISF/suricata/pulls/4347/commits"},"statuses":{"href":"https://api.github.com/repos/OISF/suricata/statuses/d37b7ec518b5aa2cba8dd94402d119174e293c3b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":208,"deletions":0,"changed_files":7}}
{"actor":{"display_login":"catenacyber"}}