{"action":"opened","number":1144,"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/1144","id":350259822,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMjU5ODIy","html_url":"https://github.com/Azure/sonic-swss/pull/1144","diff_url":"https://github.com/Azure/sonic-swss/pull/1144.diff","patch_url":"https://github.com/Azure/sonic-swss/pull/1144.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss/issues/1144","number":1144,"state":"open","locked":false,"title":"teamsyncd::Additional checks put inplace to make sure the netlink message is valid","user":{"login":"judyjoseph","id":53951155,"node_id":"MDQ6VXNlcjUzOTUxMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/53951155?v=4","gravatar_id":"","url":"https://api.github.com/users/judyjoseph","html_url":"https://github.com/judyjoseph","followers_url":"https://api.github.com/users/judyjoseph/followers","following_url":"https://api.github.com/users/judyjoseph/following{/other_user}","gists_url":"https://api.github.com/users/judyjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/judyjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judyjoseph/subscriptions","organizations_url":"https://api.github.com/users/judyjoseph/orgs","repos_url":"https://api.github.com/users/judyjoseph/repos","events_url":"https://api.github.com/users/judyjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/judyjoseph/received_events","type":"User","site_admin":false},"body":"**What I did**\r\n\r\nAdded additional checks in the netlink message handling of teamsyncd to make sure the message is for a valid interface with ifindex and name. This is using the netlink cache infrastructure to check if the interface name retrieved from cache with the ifindex is matching with the interfaceName in the netlink NEW LINK create message. If the interface name is not same, we drop the message.\r\n\r\n**Why I did it**\r\n\r\nHave seen random cases where teamsyncd fails and the stack trace was showing interface name as NULL and the ifindex an incorrect one.\r\n\r\n**How I verified it**\r\n\r\nCould not get the exact reproduction scenario, but induced these errors manually and found the teamsyncd staying up.\r\n\r\n**Details if related**\r\n","created_at":"2019-12-07T01:14:32Z","updated_at":"2019-12-07T01:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/1144/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/1144/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/issues/1144/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/ab9795bc87abcd79f8d1192244bb62412190facf","head":{"label":"judyjoseph:master","ref":"master","sha":"ab9795bc87abcd79f8d1192244bb62412190facf","user":{"login":"judyjoseph","id":53951155,"node_id":"MDQ6VXNlcjUzOTUxMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/53951155?v=4","gravatar_id":"","url":"https://api.github.com/users/judyjoseph","html_url":"https://github.com/judyjoseph","followers_url":"https://api.github.com/users/judyjoseph/followers","following_url":"https://api.github.com/users/judyjoseph/following{/other_user}","gists_url":"https://api.github.com/users/judyjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/judyjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judyjoseph/subscriptions","organizations_url":"https://api.github.com/users/judyjoseph/orgs","repos_url":"https://api.github.com/users/judyjoseph/repos","events_url":"https://api.github.com/users/judyjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/judyjoseph/received_events","type":"User","site_admin":false},"repo":{"id":224378103,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQzNzgxMDM=","name":"sonic-swss","full_name":"judyjoseph/sonic-swss","private":false,"owner":{"login":"judyjoseph","id":53951155,"node_id":"MDQ6VXNlcjUzOTUxMTU1","avatar_url":"https://avatars1.githubusercontent.com/u/53951155?v=4","gravatar_id":"","url":"https://api.github.com/users/judyjoseph","html_url":"https://github.com/judyjoseph","followers_url":"https://api.github.com/users/judyjoseph/followers","following_url":"https://api.github.com/users/judyjoseph/following{/other_user}","gists_url":"https://api.github.com/users/judyjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/judyjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judyjoseph/subscriptions","organizations_url":"https://api.github.com/users/judyjoseph/orgs","repos_url":"https://api.github.com/users/judyjoseph/repos","events_url":"https://api.github.com/users/judyjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/judyjoseph/received_events","type":"User","site_admin":false},"html_url":"https://github.com/judyjoseph/sonic-swss","description":"SONiC Switch State Service (SwSS)","fork":true,"url":"https://api.github.com/repos/judyjoseph/sonic-swss","forks_url":"https://api.github.com/repos/judyjoseph/sonic-swss/forks","keys_url":"https://api.github.com/repos/judyjoseph/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/judyjoseph/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/judyjoseph/sonic-swss/teams","hooks_url":"https://api.github.com/repos/judyjoseph/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/judyjoseph/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/judyjoseph/sonic-swss/events","assignees_url":"https://api.github.com/repos/judyjoseph/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/judyjoseph/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/judyjoseph/sonic-swss/tags","blobs_url":"https://api.github.com/repos/judyjoseph/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/judyjoseph/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/judyjoseph/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/judyjoseph/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/judyjoseph/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/judyjoseph/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/judyjoseph/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/judyjoseph/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/judyjoseph/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/judyjoseph/sonic-swss/subscription","commits_url":"https://api.github.com/repos/judyjoseph/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/judyjoseph/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/judyjoseph/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/judyjoseph/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/judyjoseph/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/judyjoseph/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/judyjoseph/sonic-swss/merges","archive_url":"https://api.github.com/repos/judyjoseph/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/judyjoseph/sonic-swss/downloads","issues_url":"https://api.github.com/repos/judyjoseph/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/judyjoseph/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/judyjoseph/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/judyjoseph/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/judyjoseph/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/judyjoseph/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/judyjoseph/sonic-swss/deployments","created_at":"2019-11-27T08:11:12Z","updated_at":"2019-12-07T00:52:36Z","pushed_at":"2019-12-07T00:52:34Z","git_url":"git://github.com/judyjoseph/sonic-swss.git","ssh_url":"git@github.com:judyjoseph/sonic-swss.git","clone_url":"https://github.com/judyjoseph/sonic-swss.git","svn_url":"https://github.com/judyjoseph/sonic-swss","homepage":"https://azure.github.io/SONiC","size":3324,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"a4a1d3be49c39eb1f137b02bdf1c4b479bbe1cba","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53515475,"node_id":"MDEwOlJlcG9zaXRvcnk1MzUxNTQ3NQ==","name":"sonic-swss","full_name":"Azure/sonic-swss","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-swss","description":"SONiC Switch State Service (SwSS)","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss","forks_url":"https://api.github.com/repos/Azure/sonic-swss/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss/deployments","created_at":"2016-03-09T17:01:09Z","updated_at":"2019-12-03T16:27:33Z","pushed_at":"2019-12-06T23:10:49Z","git_url":"git://github.com/Azure/sonic-swss.git","ssh_url":"git@github.com:Azure/sonic-swss.git","clone_url":"https://github.com/Azure/sonic-swss.git","svn_url":"https://github.com/Azure/sonic-swss","homepage":"https://azure.github.io/SONiC","size":3335,"stargazers_count":56,"watchers_count":56,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":154,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":178,"open_issues":154,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/1144"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/1144"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/1144"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/1144/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/1144/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/1144/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss/statuses/ab9795bc87abcd79f8d1192244bb62412190facf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":83,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"judyjoseph"}}