{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/substrate/pulls/comments/326227599","pull_request_review_id":290638788,"id":326227599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjIyNzU5OQ==","diff_hunk":"@@ -83,7 +83,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {\n \t// implementation changes and behavior does not, then leave spec_version as\n \t// is and increment impl_version.\n \tspec_version: 158,","path":"node/runtime/src/lib.rs","position":3,"original_position":3,"commit_id":"ff7c446e7e499c6956ff19022a46098976d2f518","original_commit_id":"ff7c446e7e499c6956ff19022a46098976d2f518","user":{"login":"kianenigma","id":5588131,"node_id":"MDQ6VXNlcjU1ODgxMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5588131?v=4","gravatar_id":"","url":"https://api.github.com/users/kianenigma","html_url":"https://github.com/kianenigma","followers_url":"https://api.github.com/users/kianenigma/followers","following_url":"https://api.github.com/users/kianenigma/following{/other_user}","gists_url":"https://api.github.com/users/kianenigma/gists{/gist_id}","starred_url":"https://api.github.com/users/kianenigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kianenigma/subscriptions","organizations_url":"https://api.github.com/users/kianenigma/orgs","repos_url":"https://api.github.com/users/kianenigma/repos","events_url":"https://api.github.com/users/kianenigma/events{/privacy}","received_events_url":"https://api.github.com/users/kianenigma/received_events","type":"User","site_admin":false},"body":"Yeah I usually do this only after approval of each PR :) ","created_at":"2019-09-19T15:06:22Z","updated_at":"2019-09-19T15:06:23Z","html_url":"https://github.com/paritytech/substrate/pull/3456#discussion_r326227599","pull_request_url":"https://api.github.com/repos/paritytech/substrate/pulls/3456","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/comments/326227599"},"html":{"href":"https://github.com/paritytech/substrate/pull/3456#discussion_r326227599"},"pull_request":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/3456"}},"in_reply_to_id":326111210},"pull_request":{"url":"https://api.github.com/repos/paritytech/substrate/pulls/3456","id":309582875,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5NTgyODc1","html_url":"https://github.com/paritytech/substrate/pull/3456","diff_url":"https://github.com/paritytech/substrate/pull/3456.diff","patch_url":"https://github.com/paritytech/substrate/pull/3456.patch","issue_url":"https://api.github.com/repos/paritytech/substrate/issues/3456","number":3456,"state":"open","locked":false,"title":"Refactor: fixed point arithmetic for SRML.","user":{"login":"kianenigma","id":5588131,"node_id":"MDQ6VXNlcjU1ODgxMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5588131?v=4","gravatar_id":"","url":"https://api.github.com/users/kianenigma","html_url":"https://github.com/kianenigma","followers_url":"https://api.github.com/users/kianenigma/followers","following_url":"https://api.github.com/users/kianenigma/following{/other_user}","gists_url":"https://api.github.com/users/kianenigma/gists{/gist_id}","starred_url":"https://api.github.com/users/kianenigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kianenigma/subscriptions","organizations_url":"https://api.github.com/users/kianenigma/orgs","repos_url":"https://api.github.com/users/kianenigma/repos","events_url":"https://api.github.com/users/kianenigma/events{/privacy}","received_events_url":"https://api.github.com/users/kianenigma/received_events","type":"User","site_admin":false},"body":"closes #3189 and resolves #2908 \r\n\r\n- [x] A macro generates a unified code for all per-things. \r\n   - [x] Does not work for types that have 64-bit native size while it should. e.g. I want to add:\r\n\r\n```\r\nimplement_per_thing!(Perquintill, test_perquintill, 10.pow(18), u64, u128, \"_Parts per Quintillion_\");\r\n```\r\n- [x] u128 is gone and a generic `Rational128` is added with some basic operations.\r\n- [x] Phragmen is refactored and uses the `Rational128`\r\n- [x] Adding mul and power impl to per-things (still needed @pepyakin?) \r\n- [x] Has still a bunch of TODOs in the code. \r\n- [x] Much much much more tests.\r\n\r\ncc @thiolliere ","created_at":"2019-08-21T16:26:27Z","updated_at":"2019-09-19T15:06:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4154bcf5bdb587cdfa677447a0626708f4cb5383","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pepyakin","id":2205845,"node_id":"MDQ6VXNlcjIyMDU4NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2205845?v=4","gravatar_id":"","url":"https://api.github.com/users/pepyakin","html_url":"https://github.com/pepyakin","followers_url":"https://api.github.com/users/pepyakin/followers","following_url":"https://api.github.com/users/pepyakin/following{/other_user}","gists_url":"https://api.github.com/users/pepyakin/gists{/gist_id}","starred_url":"https://api.github.com/users/pepyakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepyakin/subscriptions","organizations_url":"https://api.github.com/users/pepyakin/orgs","repos_url":"https://api.github.com/users/pepyakin/repos","events_url":"https://api.github.com/users/pepyakin/events{/privacy}","received_events_url":"https://api.github.com/users/pepyakin/received_events","type":"User","site_admin":false},{"login":"bkchr","id":5718007,"node_id":"MDQ6VXNlcjU3MTgwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5718007?v=4","gravatar_id":"","url":"https://api.github.com/users/bkchr","html_url":"https://github.com/bkchr","followers_url":"https://api.github.com/users/bkchr/followers","following_url":"https://api.github.com/users/bkchr/following{/other_user}","gists_url":"https://api.github.com/users/bkchr/gists{/gist_id}","starred_url":"https://api.github.com/users/bkchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkchr/subscriptions","organizations_url":"https://api.github.com/users/bkchr/orgs","repos_url":"https://api.github.com/users/bkchr/repos","events_url":"https://api.github.com/users/bkchr/events{/privacy}","received_events_url":"https://api.github.com/users/bkchr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":746560607,"node_id":"MDU6TGFiZWw3NDY1NjA2MDc=","url":"https://api.github.com/repos/paritytech/substrate/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/substrate/pulls/3456/commits","review_comments_url":"https://api.github.com/repos/paritytech/substrate/pulls/3456/comments","review_comment_url":"https://api.github.com/repos/paritytech/substrate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/substrate/issues/3456/comments","statuses_url":"https://api.github.com/repos/paritytech/substrate/statuses/ff7c446e7e499c6956ff19022a46098976d2f518","head":{"label":"paritytech:kiz-srml-fixed","ref":"kiz-srml-fixed","sha":"ff7c446e7e499c6956ff19022a46098976d2f518","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"substrate","full_name":"paritytech/substrate","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/substrate","description":"Substrate: The platform for blockchain innovators","fork":false,"url":"https://api.github.com/repos/paritytech/substrate","forks_url":"https://api.github.com/repos/paritytech/substrate/forks","keys_url":"https://api.github.com/repos/paritytech/substrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/substrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/substrate/teams","hooks_url":"https://api.github.com/repos/paritytech/substrate/hooks","issue_events_url":"https://api.github.com/repos/paritytech/substrate/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/substrate/events","assignees_url":"https://api.github.com/repos/paritytech/substrate/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/substrate/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/substrate/tags","blobs_url":"https://api.github.com/repos/paritytech/substrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/substrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/substrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/substrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/substrate/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/substrate/languages","stargazers_url":"https://api.github.com/repos/paritytech/substrate/stargazers","contributors_url":"https://api.github.com/repos/paritytech/substrate/contributors","subscribers_url":"https://api.github.com/repos/paritytech/substrate/subscribers","subscription_url":"https://api.github.com/repos/paritytech/substrate/subscription","commits_url":"https://api.github.com/repos/paritytech/substrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/substrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/substrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/substrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/substrate/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/substrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/substrate/merges","archive_url":"https://api.github.com/repos/paritytech/substrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/substrate/downloads","issues_url":"https://api.github.com/repos/paritytech/substrate/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/substrate/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/substrate/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/substrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/substrate/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/substrate/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/substrate/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2019-09-19T14:49:27Z","pushed_at":"2019-09-19T14:49:25Z","git_url":"git://github.com/paritytech/substrate.git","ssh_url":"git@github.com:paritytech/substrate.git","clone_url":"https://github.com/paritytech/substrate.git","svn_url":"https://github.com/paritytech/substrate","homepage":"","size":86725,"stargazers_count":1465,"watchers_count":1465,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":391,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":383,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":391,"open_issues":383,"watchers":1465,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"5a2be8bd56ed5d9dc787fb3b9a76ce10ced4704b","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":109872620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NzI2MjA=","name":"substrate","full_name":"paritytech/substrate","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/substrate","description":"Substrate: The platform for blockchain innovators","fork":false,"url":"https://api.github.com/repos/paritytech/substrate","forks_url":"https://api.github.com/repos/paritytech/substrate/forks","keys_url":"https://api.github.com/repos/paritytech/substrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/substrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/substrate/teams","hooks_url":"https://api.github.com/repos/paritytech/substrate/hooks","issue_events_url":"https://api.github.com/repos/paritytech/substrate/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/substrate/events","assignees_url":"https://api.github.com/repos/paritytech/substrate/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/substrate/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/substrate/tags","blobs_url":"https://api.github.com/repos/paritytech/substrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/substrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/substrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/substrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/substrate/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/substrate/languages","stargazers_url":"https://api.github.com/repos/paritytech/substrate/stargazers","contributors_url":"https://api.github.com/repos/paritytech/substrate/contributors","subscribers_url":"https://api.github.com/repos/paritytech/substrate/subscribers","subscription_url":"https://api.github.com/repos/paritytech/substrate/subscription","commits_url":"https://api.github.com/repos/paritytech/substrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/substrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/substrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/substrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/substrate/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/substrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/substrate/merges","archive_url":"https://api.github.com/repos/paritytech/substrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/substrate/downloads","issues_url":"https://api.github.com/repos/paritytech/substrate/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/substrate/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/substrate/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/substrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/substrate/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/substrate/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/substrate/deployments","created_at":"2017-11-07T18:08:53Z","updated_at":"2019-09-19T14:49:27Z","pushed_at":"2019-09-19T14:49:25Z","git_url":"git://github.com/paritytech/substrate.git","ssh_url":"git@github.com:paritytech/substrate.git","clone_url":"https://github.com/paritytech/substrate.git","svn_url":"https://github.com/paritytech/substrate","homepage":"","size":86725,"stargazers_count":1465,"watchers_count":1465,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":391,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":383,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":391,"open_issues":383,"watchers":1465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/3456"},"html":{"href":"https://github.com/paritytech/substrate/pull/3456"},"issue":{"href":"https://api.github.com/repos/paritytech/substrate/issues/3456"},"comments":{"href":"https://api.github.com/repos/paritytech/substrate/issues/3456/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/3456/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/substrate/pulls/3456/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/substrate/statuses/ff7c446e7e499c6956ff19022a46098976d2f518"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kianenigma"}}