{"action":"created","issue":{"url":"https://api.github.com/repos/google/fonts/issues/2303","repository_url":"https://api.github.com/repos/google/fonts","labels_url":"https://api.github.com/repos/google/fonts/issues/2303/labels{/name}","comments_url":"https://api.github.com/repos/google/fonts/issues/2303/comments","events_url":"https://api.github.com/repos/google/fonts/issues/2303/events","html_url":"https://github.com/google/fonts/pull/2303","id":548175492,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxNTI5MTM5","number":2303,"title":"gotu: v2.320 added","user":{"login":"m4rc1e","id":7525512,"node_id":"MDQ6VXNlcjc1MjU1MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2020-01-10T16:33:37Z","updated_at":"2020-01-10T16:40:42Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/google/fonts/pulls/2303","html_url":"https://github.com/google/fonts/pull/2303","diff_url":"https://github.com/google/fonts/pull/2303.diff","patch_url":"https://github.com/google/fonts/pull/2303.patch"},"body":"Taken from the upstream repo https://github.com/EkType/Gotu from release https://github.com/EkType/Gotu/releases/tag/2.32"},"comment":{"url":"https://api.github.com/repos/google/fonts/issues/comments/573110782","html_url":"https://github.com/google/fonts/pull/2303#issuecomment-573110782","issue_url":"https://api.github.com/repos/google/fonts/issues/2303","id":573110782,"node_id":"MDEyOklzc3VlQ29tbWVudDU3MzExMDc4Mg==","user":{"login":"gf-bot","id":44005092,"node_id":"MDQ6VXNlcjQ0MDA1MDky","avatar_url":"https://avatars1.githubusercontent.com/u/44005092?v=4","gravatar_id":"","url":"https://api.github.com/users/gf-bot","html_url":"https://github.com/gf-bot","followers_url":"https://api.github.com/users/gf-bot/followers","following_url":"https://api.github.com/users/gf-bot/following{/other_user}","gists_url":"https://api.github.com/users/gf-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/gf-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gf-bot/subscriptions","organizations_url":"https://api.github.com/users/gf-bot/orgs","repos_url":"https://api.github.com/users/gf-bot/repos","events_url":"https://api.github.com/users/gf-bot/events{/privacy}","received_events_url":"https://api.github.com/users/gf-bot/received_events","type":"User","site_admin":false},"created_at":"2020-01-10T16:40:42Z","updated_at":"2020-01-10T16:40:42Z","author_association":"NONE","body":"## Fontbakery report\n\nFontbakery version: 0.7.16\n\n<details>\n<summary><b>[1] Family checks</b></summary>\n<details>\n<summary>⚠ <b>WARN:</b> Is the command `ftxvalidator` (Apple Font Tool Suite) available?</summary>\n\n* [com.google.fonts/check/ftxvalidator_is_available](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/ftxvalidator_is_available)\n<pre>--- Rationale ---\n\nThere&#x27;s no reasonable (and legal) way to run the command `ftxvalidator` of the\nApple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.\n\nIf Font Bakery is not running on an OSX machine, the machine running Font\nBakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure\ncall (rpc).\n\nThere&#x27;s an ssh example implementation at:\nhttps://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds/ftxvalidator/ssh-implementation/ftxvalidator\n\n\n</pre>\n\n* ⚠ **WARN** ftxvalidator is not available.\n\n</details>\n<br>\n</details>\n<details>\n<summary><b>[10] Gotu-Regular.ttf</b></summary>\n<details>\n<summary>🔥 <b>FAIL:</b> METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?</summary>\n\n* [com.google.fonts/check/metadata/match_fullname_postscript](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/match_fullname_postscript)\n\n* 🔥 **FAIL** METADATA.pb font full_name = \"Gotu\" does not match post_script_name = \"Gotu-Regular\" [code: mismatch]\n\n</details>\n<details>\n<summary>🔥 <b>FAIL:</b> Copyright notices match canonical pattern in METADATA.pb</summary>\n\n* [com.google.fonts/check/metadata/valid_copyright](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/valid_copyright)\n\n* 🔥 **FAIL** METADATA.pb: Copyright notices should match a pattern similar to:\n \"Copyright 2019 The Familyname Project Authors (git url)\"\nBut instead we have got:\n\"Copyright (c) 2016, Ek Type. All rights reserved.\" [code: bad-notice-format]\n\n</details>\n<details>\n<summary>🔥 <b>FAIL:</b> Copyright notices match canonical pattern in fonts</summary>\n\n* [com.google.fonts/check/font_copyright](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/font_copyright)\n\n* 🔥 **FAIL** Name Table entry: Copyright notices should match a pattern similar to: \"Copyright 2019 The Familyname Project Authors (git url)\"\nBut instead we have got:\n\"Copyright (c) 2016, Ek Type. All rights reserved.\" [code: bad-notice-format]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> Font has old ttfautohint applied?</summary>\n\n* [com.google.fonts/check/old_ttfautohint](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/old_ttfautohint)\n<pre>--- Rationale ---\n\nThis check finds which version of ttfautohint was used, by inspecting name\ntable entries and then finds which version of ttfautohint is currently\ninstalled in the system.\n\n\n</pre>\n\n* ⚠ **WARN** ttfautohint used in font = 1.8.1; installed = 1.8.3; Need to re-run with the newer version! [code: old-ttfa]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> METADATA.pb: Fontfamily is listed on Google Fonts API?</summary>\n\n* [com.google.fonts/check/metadata/listed_on_gfonts](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/metadata/listed_on_gfonts)\n\n* ⚠ **WARN** Family not found via Google Fonts API. [code: not-found]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> Stricter unitsPerEm criteria for Google Fonts. </summary>\n\n* [com.google.fonts/check/unitsperem_strict](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/unitsperem_strict)\n<pre>--- Rationale ---\n\nEven though the OpenType spec allows unitsPerEm to be any value between 16 and\n16384, the Google Fonts project aims at a narrower set of reasonable values.\n\nThe spec suggests usage of powers of two in order to get some performance\nimprovements on legacy renderers, so those values are acceptable.\n\nBut value of 500 or 1000 are also acceptable, with the added benefit that it\nmakes upm math easier for designers, while the performance hit of not using a\npower of two is most likely negligible nowadays.\n\nAnother acceptable value is 2000. Since TT outlines are all integers (no\nfloats), then instances in a VF suffer rounding compromises, and therefore a\n1000 UPM is to small because it forces too many such compromises.\n\nTherefore 2000 is a good &#x27;new VF standard&#x27;, because 2000 is a simple 2x\nconversion from existing fonts drawn on a 1000 UPM, and anyone who knows what\n10 units can do for 1000 UPM will know what 20 units does too.\n\nAdditionally, values above 2048 would result in filesize increases with not\nmuch added benefit.\n\n\n</pre>\n\n* ⚠ **WARN** Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations. [code: legacy-value]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> Check if each glyph has the recommended amount of contours.</summary>\n\n* [com.google.fonts/check/contour_count](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/contour_count)\n<pre>--- Rationale ---\n\nVisually QAing thousands of glyphs by hand is tiring. Most glyphs can only be\nconstructured in a handful of ways. This means a glyph&#x27;s contour count will\nonly differ slightly amongst different fonts, e.g a &#x27;g&#x27; could either be 2 or 3\ncontours, depending on whether its double story or single story.\n\nHowever, a quotedbl should have 2 contours, unless the font belongs to a\ndisplay family.\n\nThis check currently does not cover variable fonts because there&#x27;s plenty of\nalternative ways of constructing glyphs with multiple outlines for each feature\nin a VarFont. The expected contour count data for this check is currently\noptimized for the typical construction of glyphs in static fonts.\n\n\n</pre>\n\n* ⚠ **WARN** This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.\n\nThe following glyphs do not have the recommended number of contours:\n\nGlyph name: nine.superior\tContours detected: 1\tExpected: 2\nGlyph name: six.inferior\tContours detected: 1\tExpected: 2\nGlyph name: nine.inferior\tContours detected: 1\tExpected: 2\nGlyph name: uni097B\tContours detected: 2\tExpected: 1\nGlyph name: uni097E\tContours detected: 3\tExpected: 2\nGlyph name: six.superior\tContours detected: 1\tExpected: 2\nGlyph name: Bindu.dv\tContours detected: 2\tExpected: 1\nGlyph name: Visarga.dv\tContours detected: 5\tExpected: 2\nGlyph name: vowelShortA.dv\tContours detected: 2\tExpected: 1\nGlyph name: vowelI.dv\tContours detected: 3\tExpected: 1\nGlyph name: vowelIi.dv\tContours detected: 3\tExpected: 1\nGlyph name: vowelRu.dv\tContours detected: 3\tExpected: 1\nGlyph name: vowelLru.dv\tContours detected: 2\tExpected: 1\nGlyph name: vowelShortE.dv\tContours detected: 2\tExpected: 1\nGlyph name: vowelAi.dv\tContours detected: 2\tExpected: 1\nGlyph name: vowelShortO.dv\tContours detected: 2\tExpected: 1\nGlyph name: vowelO.dv\tContours detected: 2\tExpected: 1\nGlyph name: vowelAu.dv\tContours detected: 2\tExpected: 1\nGlyph name: Ka.dv\tContours detected: 3\tExpected: 1 or 2\nGlyph name: Kha.dv\tContours detected: 2\tExpected: 1 or 3\nGlyph name: Ga.dv\tContours detected: 2\tExpected: 1\nGlyph name: Nga.dv\tContours detected: 4\tExpected: 2\nGlyph name: uni25CC\tContours detected: 8\tExpected: 16 or 12\nGlyph name: Cha.dv\tContours detected: 4\tExpected: 2\nGlyph name: Tta.dv\tContours detected: 2\tExpected: 1\nGlyph name: Ttha.dv\tContours detected: 3\tExpected: 2\nGlyph name: Dda.dv\tContours detected: 2\tExpected: 1\nGlyph name: Ddha.dv\tContours detected: 3\tExpected: 1 or 2\nGlyph name: Tha.dv\tContours detected: 2\tExpected: 1\nGlyph name: Da.dv\tContours detected: 3\tExpected: 1\nGlyph name: Na.dv\tContours detected: 2\tExpected: 1\nGlyph name: NaNukta.dv\tContours detected: 3\tExpected: 2\nGlyph name: Pha.dv\tContours detected: 3\tExpected: 2\nGlyph name: Bha.dv\tContours detected: 2\tExpected: 1\nGlyph name: Ma.dv\tContours detected: 3\tExpected: 2\nGlyph name: Ra.dv\tContours detected: 2\tExpected: 1\nGlyph name: RaNukta.dv\tContours detected: 3\tExpected: 2\nGlyph name: Lla.dv\tContours detected: 4\tExpected: 3\nGlyph name: LlaNukta.dv\tContours detected: 5\tExpected: 4\nGlyph name: Sha.dv\tContours detected: 4\tExpected: 2\nGlyph name: Sa.dv\tContours detected: 3\tExpected: 2\nGlyph name: Ha.dv\tContours detected: 2\tExpected: 1\nGlyph name: matraShortO.dv\tContours detected: 2\tExpected: 1\nGlyph name: matraO.dv\tContours detected: 2\tExpected: 1\nGlyph name: matraAu.dv\tContours detected: 2\tExpected: 1\nGlyph name: matraShortAu.dv\tContours detected: 2\tExpected: 1\nGlyph name: KaNukta.dv\tContours detected: 4\tExpected: 2 or 3\nGlyph name: KhaNukta.dv\tContours detected: 3\tExpected: 2 or 4\nGlyph name: GaNukta.dv\tContours detected: 3\tExpected: 2\nGlyph name: DdaNukta.dv\tContours detected: 3\tExpected: 2\nGlyph name: DdhaNukta.dv\tContours detected: 4\tExpected: 2 or 3\nGlyph name: PhaNukta.dv\tContours detected: 4\tExpected: 3\nGlyph name: vowelRuu.dv\tContours detected: 3\tExpected: 1\nGlyph name: vowelLruu.dv\tContours detected: 2\tExpected: 1\nGlyph name: Ek.dv\tContours detected: 2\tExpected: 1\nGlyph name: Don.dv\tContours detected: 2\tExpected: 1\nGlyph name: Teen.dv\tContours detected: 2\tExpected: 1\nGlyph name: Paach.dv\tContours detected: 2\tExpected: 1\nGlyph name: uni0975\tContours detected: 2\tExpected: 1\nGlyph name: fi\tContours detected: 1\tExpected: 3\nGlyph name: uni25CC\tContours detected: 8\tExpected: 16 or 12\nGlyph name: fl\tContours detected: 1\tExpected: 2\nGlyph name: uni097B\tContours detected: 2\tExpected: 1\nGlyph name: uni097E\tContours detected: 3\tExpected: 2\nGlyph name: uni0975\tContours detected: 2\tExpected: 1 [code: contour-count]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> Check name table: FULL_FONT_NAME entries.</summary>\n\n* [com.google.fonts/check/name/fullfontname](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/name/fullfontname)\n\n* ⚠ **WARN** Entry [FULL_FONT_NAME(4):WINDOWS(3)] on the \"name\" table: Got \"Gotu\" which lacks \"Regular\", but it is probably OK in this case. [code: lacks-regular]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> Are there caret positions declared for every ligature?</summary>\n\n* [com.google.fonts/check/ligature_carets](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/ligature_carets)\n<pre>--- Rationale ---\n\nAll ligatures in a font must have corresponding caret (text cursor) positions\ndefined in the GDEF table, otherwhise, users may experience issues with caret\nrendering.\n\n\n</pre>\n\n* ⚠ **WARN** This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]\n\n</details>\n<details>\n<summary>⚠ <b>WARN:</b> Is there kerning info for non-ligated sequences?</summary>\n\n* [com.google.fonts/check/kerning_for_non_ligated_sequences](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/kerning_for_non_ligated_sequences)\n<pre>--- Rationale ---\n\nFonts with ligatures should have kerning on the corresponding non-ligated\nsequences for text where ligatures aren&#x27;t used (eg\nhttps://github.com/impallari/Raleway/issues/14).\n\n\n</pre>\n\n* ⚠ **WARN** GPOS table lacks kerning info for the following non-ligated sequences:\n\t- f + f\n\t- f + i\n\t- i + f\n\t- f + j\n\t- j + f\n\t- f + l\n\t- l + f\n\t- f + h\n\t- h + i\n\t- i + j\n\t- j + k\n\t- k + l\n\n   [code: lacks-kern-info]\n\n</details>\n<br>\n</details>\n\n### Summary\n\n| 💔 ERROR | 🔥 FAIL | ⚠ WARN | 💤 SKIP | ℹ INFO | 🍞 PASS | 🔎 DEBUG |\n|:-----:|:----:|:----:|:----:|:----:|:----:|:----:|\n| 0 | 3 | 8 | 28 | 7 | 117 | 0 |\n| 0% | 2% | 5% | 17% | 4% | 72% | 0% |\n\n**Note:** The following loglevels were omitted in this report:\n* **SKIP**\n* **INFO**\n* **PASS**\n* **DEBUG**\n\n\n## Diff images: [qa.zip](http://35.238.63.0/media/6be6a93e-8489-46fb-ac53-b90db24b74db/qa.zip)"}}
{"actor":{"display_login":"gf-bot"}}