{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/338604370","pull_request_review_id":306616054,"id":338604370,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODYwNDM3MA==","diff_hunk":"@@ -76,41 +78,43 @@ indicate failure.\n Backward compatibility\n ----------------------\n \n-Anyone depending on ragged lists-of-lists creating object arrays will need to\n+Anyone depending on ragged nested sequences creating object arrays will need to\n modify their code. There will be a deprecation period during which the current\n behaviour will emit a ``DeprecationWarning``.\n \n \n Alternatives\n ------------\n \n-We could continue with the current situation.\n+- We could continue with the current situation.\n \n-It was also suggested to add a kwarg `depth` to array creation, or perhaps to\n-add another array creation API function `ragged_array_object`. The goal was\n-to eliminate the ambiguity in creating an object array from `array([[1, 2],\n-[1]], dtype=object)`: should the returned array have a shape of `(1,)`, or\n-`(2,)`? This NEP does not deal with that issue, and only deprecates the use of\n-`array` with no `dtype=object` for ragged arrays.\n+- It was also suggested to add a kwarg ``depth`` to array creation, or perhaps\n+  to add another array creation API function ``ragged_array_object``. The goal\n+  was to eliminate the ambiguity in creating an object array from ``array([[1,\n+  2], [1]], dtype=object)``: should the returned array have a shape of\n+  ``(1,)``, or ``(2,)``? This NEP does not deal with that issue, and only\n+  deprecates the use of ``array`` with no ``dtype=object`` for ragged nested\n+  sequences. Users of ragged nested sequences may face another deprecation\n+  cycle in the future.\n \n-It was also suggested to deprecate all automatic creation of ``object``-dtype\n-arrays, which would require a dtype for something like ``np.array([Decimal(10),\n-Decimal(10)])``. This too is out of scope for the current NEP: only if all the\n-top-level elements are `sequences`_ will we require an explicit\n-``dtype=object``.\n+- It was also suggested to deprecate all automatic creation of ``object``-dtype\n+  arrays, which would require a dtype for something like ``np.array([Decimal(10),\n+  Decimal(10)])``. This too is out of scope for the current NEP: only if all\n+  the top-level elements are `sequences`_ will we require an explicit\n+  ``dtype=object``.","path":"doc/neps/nep-0034.rst","position":104,"original_position":99,"commit_id":"49c37d9c8ef1daa01e609b02a15f58c30f987f69","original_commit_id":"49c37d9c8ef1daa01e609b02a15f58c30f987f69","user":{"login":"eric-wieser","id":425260,"node_id":"MDQ6VXNlcjQyNTI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/425260?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"body":"This is only if they are ragged, right? `np.array([[[Decimal(1)]]])` is still fine?","created_at":"2019-10-24T14:24:37Z","updated_at":"2019-10-24T14:24:38Z","html_url":"https://github.com/numpy/numpy/pull/14674#discussion_r338604370","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/14674","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/338604370"},"html":{"href":"https://github.com/numpy/numpy/pull/14674#discussion_r338604370"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/14674"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/14674","id":326702423,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2NzAyNDIz","html_url":"https://github.com/numpy/numpy/pull/14674","diff_url":"https://github.com/numpy/numpy/pull/14674.diff","patch_url":"https://github.com/numpy/numpy/pull/14674.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/14674","number":14674,"state":"open","locked":false,"title":"NEP: add default-dtype-object-deprecation nep","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"body":"NEP to deprecate `a = np.array([1, 2], [1])` without explicitly stating `dtype=object`.\r\n\r\nxref gh-5303, related to gh-13913, gh-14341.\r\n\r\n","created_at":"2019-10-10T12:12:15Z","updated_at":"2019-10-24T14:24:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf2243c26127e4a07a96bd2870c85f603dbbd3d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":860701368,"node_id":"MDU6TGFiZWw4NjA3MDEzNjg=","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20NEP","name":"component: NEP","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/14674/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/14674/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/14674/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/49c37d9c8ef1daa01e609b02a15f58c30f987f69","head":{"label":"mattip:nep-0034","ref":"nep-0034","sha":"49c37d9c8ef1daa01e609b02a15f58c30f987f69","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"repo":{"id":101918527,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MTg1Mjc=","name":"numpy","full_name":"mattip/numpy","private":false,"owner":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattip/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/mattip/numpy","forks_url":"https://api.github.com/repos/mattip/numpy/forks","keys_url":"https://api.github.com/repos/mattip/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattip/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattip/numpy/teams","hooks_url":"https://api.github.com/repos/mattip/numpy/hooks","issue_events_url":"https://api.github.com/repos/mattip/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/mattip/numpy/events","assignees_url":"https://api.github.com/repos/mattip/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/mattip/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/mattip/numpy/tags","blobs_url":"https://api.github.com/repos/mattip/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattip/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattip/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattip/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattip/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/mattip/numpy/languages","stargazers_url":"https://api.github.com/repos/mattip/numpy/stargazers","contributors_url":"https://api.github.com/repos/mattip/numpy/contributors","subscribers_url":"https://api.github.com/repos/mattip/numpy/subscribers","subscription_url":"https://api.github.com/repos/mattip/numpy/subscription","commits_url":"https://api.github.com/repos/mattip/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattip/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattip/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattip/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattip/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/mattip/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattip/numpy/merges","archive_url":"https://api.github.com/repos/mattip/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattip/numpy/downloads","issues_url":"https://api.github.com/repos/mattip/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/mattip/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/mattip/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/mattip/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattip/numpy/labels{/name}","releases_url":"https://api.github.com/repos/mattip/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/mattip/numpy/deployments","created_at":"2017-08-30T19:01:59Z","updated_at":"2019-08-08T17:22:30Z","pushed_at":"2019-10-24T14:08:20Z","git_url":"git://github.com/mattip/numpy.git","ssh_url":"git@github.com:mattip/numpy.git","clone_url":"https://github.com/mattip/numpy.git","svn_url":"https://github.com/mattip/numpy","homepage":"http://www.numpy.org/","size":69927,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"9451d6f26ab9ab1bd204bf1865ac743a5dff6ae0","user":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"node_id":"MDEwOlJlcG9zaXRvcnk5MDg2MDc=","name":"numpy","full_name":"numpy/numpy","private":false,"owner":{"login":"numpy","id":288276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/numpy/numpy","description":"The fundamental package for scientific computing with Python.","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2019-10-24T12:28:24Z","pushed_at":"2019-10-24T14:08:26Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"https://www.numpy.org/","size":71401,"stargazers_count":12077,"watchers_count":12077,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3947,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1920,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3947,"open_issues":1920,"watchers":12077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/14674"},"html":{"href":"https://github.com/numpy/numpy/pull/14674"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/14674"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/14674/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/14674/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/14674/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/49c37d9c8ef1daa01e609b02a15f58c30f987f69"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eric-wieser"}}