{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments/306191411","pull_request_review_id":265244287,"id":306191411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjE5MTQxMQ==","diff_hunk":"@@ -0,0 +1,24 @@\n+package com.sap.cloud.lm.sl.cf.process.steps;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+import org.springframework.stereotype.Component;\n+\n+import com.sap.cloud.lm.sl.cf.client.lib.domain.CloudServiceExtended;\n+import com.sap.cloud.lm.sl.cf.client.lib.domain.ImmutableCloudServiceExtended;\n+\n+@Component(\"checkServicesToDeleteStep\")\n+public class CheckServicesToDeleteStep extends CheckForOperationsInProgressStep {\n+\n+    @Override\n+    protected List<CloudServiceExtended> getServices(ExecutionWrapper execution) {\n+        List<CloudServiceExtended> services = new ArrayList<>();\n+        StepsUtil.getServicesToDelete(execution.getContext())\n+            .forEach(serviceName -> services.add(ImmutableCloudServiceExtended.builder()\n+                .name(serviceName)\n+                .build()));","path":"com.sap.cloud.lm.sl.cf.process/src/main/java/com/sap/cloud/lm/sl/cf/process/steps/CheckServicesToDeleteStep.java","position":20,"original_position":20,"commit_id":"3b49d8368330a1fd0040614fbf60341ea16fe0f6","original_commit_id":"a1a0beb2b829c4a1006f8a14fc5962e88723eec2","user":{"login":"radito3","id":14317668,"node_id":"MDQ6VXNlcjE0MzE3NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/14317668?v=4","gravatar_id":"","url":"https://api.github.com/users/radito3","html_url":"https://github.com/radito3","followers_url":"https://api.github.com/users/radito3/followers","following_url":"https://api.github.com/users/radito3/following{/other_user}","gists_url":"https://api.github.com/users/radito3/gists{/gist_id}","starred_url":"https://api.github.com/users/radito3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radito3/subscriptions","organizations_url":"https://api.github.com/users/radito3/orgs","repos_url":"https://api.github.com/users/radito3/repos","events_url":"https://api.github.com/users/radito3/events{/privacy}","received_events_url":"https://api.github.com/users/radito3/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2019-07-23T08:29:28Z","updated_at":"2019-07-23T08:58:38Z","html_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/562#discussion_r306191411","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments/306191411"},"html":{"href":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/562#discussion_r306191411"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562"}},"in_reply_to_id":298456482},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562","id":291980363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxOTgwMzYz","html_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/562","diff_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/562.diff","patch_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/562.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/562","number":562,"state":"open","locked":false,"title":"Handle service states in progress","user":{"login":"theghost5800","id":19528042,"node_id":"MDQ6VXNlcjE5NTI4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/19528042?v=4","gravatar_id":"","url":"https://api.github.com/users/theghost5800","html_url":"https://github.com/theghost5800","followers_url":"https://api.github.com/users/theghost5800/followers","following_url":"https://api.github.com/users/theghost5800/following{/other_user}","gists_url":"https://api.github.com/users/theghost5800/gists{/gist_id}","starred_url":"https://api.github.com/users/theghost5800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theghost5800/subscriptions","organizations_url":"https://api.github.com/users/theghost5800/orgs","repos_url":"https://api.github.com/users/theghost5800/repos","events_url":"https://api.github.com/users/theghost5800/events{/privacy}","received_events_url":"https://api.github.com/users/theghost5800/received_events","type":"User","site_admin":false},"body":"Wait service instances \"in progress\" state to finish before determine actions to\r\ncorresponding service\r\n\r\nJIRA:LMCROSSITXSADEPLOY-1436 Handle all service states when managing\r\nservices\r\n\r\n","created_at":"2019-06-26T13:07:15Z","updated_at":"2019-07-23T08:58:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06befdddf6090690c8b509990e1abaf247d5805a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/562/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/statuses/3b49d8368330a1fd0040614fbf60341ea16fe0f6","head":{"label":"theghost5800:handleServices","ref":"handleServices","sha":"3b49d8368330a1fd0040614fbf60341ea16fe0f6","user":{"login":"theghost5800","id":19528042,"node_id":"MDQ6VXNlcjE5NTI4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/19528042?v=4","gravatar_id":"","url":"https://api.github.com/users/theghost5800","html_url":"https://github.com/theghost5800","followers_url":"https://api.github.com/users/theghost5800/followers","following_url":"https://api.github.com/users/theghost5800/following{/other_user}","gists_url":"https://api.github.com/users/theghost5800/gists{/gist_id}","starred_url":"https://api.github.com/users/theghost5800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theghost5800/subscriptions","organizations_url":"https://api.github.com/users/theghost5800/orgs","repos_url":"https://api.github.com/users/theghost5800/repos","events_url":"https://api.github.com/users/theghost5800/events{/privacy}","received_events_url":"https://api.github.com/users/theghost5800/received_events","type":"User","site_admin":false},"repo":{"id":112333394,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMzMzOTQ=","name":"cf-mta-deploy-service","full_name":"theghost5800/cf-mta-deploy-service","private":false,"owner":{"login":"theghost5800","id":19528042,"node_id":"MDQ6VXNlcjE5NTI4MDQy","avatar_url":"https://avatars3.githubusercontent.com/u/19528042?v=4","gravatar_id":"","url":"https://api.github.com/users/theghost5800","html_url":"https://github.com/theghost5800","followers_url":"https://api.github.com/users/theghost5800/followers","following_url":"https://api.github.com/users/theghost5800/following{/other_user}","gists_url":"https://api.github.com/users/theghost5800/gists{/gist_id}","starred_url":"https://api.github.com/users/theghost5800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theghost5800/subscriptions","organizations_url":"https://api.github.com/users/theghost5800/orgs","repos_url":"https://api.github.com/users/theghost5800/repos","events_url":"https://api.github.com/users/theghost5800/events{/privacy}","received_events_url":"https://api.github.com/users/theghost5800/received_events","type":"User","site_admin":false},"html_url":"https://github.com/theghost5800/cf-mta-deploy-service","description":"Multi-Target Application (MTA) deployment service for Cloud Foundry ","fork":true,"url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service","forks_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/forks","keys_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/teams","hooks_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/hooks","issue_events_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/issues/events{/number}","events_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/events","assignees_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/assignees{/user}","branches_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/branches{/branch}","tags_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/tags","blobs_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/statuses/{sha}","languages_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/languages","stargazers_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/stargazers","contributors_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/contributors","subscribers_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/subscribers","subscription_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/subscription","commits_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/contents/{+path}","compare_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/merges","archive_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/downloads","issues_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/issues{/number}","pulls_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/pulls{/number}","milestones_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/milestones{/number}","notifications_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/labels{/name}","releases_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/releases{/id}","deployments_url":"https://api.github.com/repos/theghost5800/cf-mta-deploy-service/deployments","created_at":"2017-11-28T12:36:48Z","updated_at":"2018-06-06T15:06:28Z","pushed_at":"2019-07-19T12:23:13Z","git_url":"git://github.com/theghost5800/cf-mta-deploy-service.git","ssh_url":"git@github.com:theghost5800/cf-mta-deploy-service.git","clone_url":"https://github.com/theghost5800/cf-mta-deploy-service.git","svn_url":"https://github.com/theghost5800/cf-mta-deploy-service","homepage":"","size":11055,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudfoundry-incubator:master","ref":"master","sha":"be27729fc76e5df5601b471ddeba80ad698238d1","user":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":105860042,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4NjAwNDI=","name":"multiapps-controller","full_name":"cloudfoundry-incubator/multiapps-controller","private":false,"owner":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry-incubator/multiapps-controller","description":"The server side component (controller) for Multi-Target Application (MTA) for Cloud Foundry","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/deployments","created_at":"2017-10-05T07:14:47Z","updated_at":"2019-07-22T11:55:56Z","pushed_at":"2019-07-22T11:55:53Z","git_url":"git://github.com/cloudfoundry-incubator/multiapps-controller.git","ssh_url":"git@github.com:cloudfoundry-incubator/multiapps-controller.git","clone_url":"https://github.com/cloudfoundry-incubator/multiapps-controller.git","svn_url":"https://github.com/cloudfoundry-incubator/multiapps-controller","homepage":"","size":33249,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":14,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562"},"html":{"href":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/562"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/562"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/statuses/3b49d8368330a1fd0040614fbf60341ea16fe0f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"radito3"}}