{"action":"created","comment":{"url":"https://api.github.com/repos/pilosa/pilosa/pulls/comments/306879136","pull_request_review_id":266107336,"id":306879136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjg3OTEzNg==","diff_hunk":"@@ -42,7 +42,21 @@ While Pilosa does have some high system requirements it is not a best practice t\n \n Pilosa requires a large number of open files to support its memory-mapped file storage system. Most operating systems put limits on the maximum number of files that may be opened concurrently by a process. On Linux systems, this limit is controlled by a utility called [ulimit](https://ss64.com/bash/ulimit.html). Pilosa will automatically attempt to raise the limit to `262144` during startup, but it may fail due to access limitations. If you see errors related to open file limits when starting Pilosa, it is recommended that you run `sudo ulimit -n 262144` before starting Pilosa.\n \n-On Mac OS X, `ulimit` does not behave predictably. [This blog post](https://blog.dekstroza.io/ulimit-shenanigans-on-osx-el-capitan/) contains information about setting open file limits in OS X.\n+On Mac OS X, `ulimit` does not behave predictably. The Mac OS X system has a utility called csrutil that prevents you from changing the open file limit easily. One workaround that may work for you involves disabling the csrutil program. To disable the csrutil program, restart your laptop and when the start up screen pops up, hold down command + R to enter Recovery Mode. Open a terminal and enter `csrutil disable`, then restart your computer as you normally would. Now that the csrutil is disabled, you can change the open file limit. The open file limit can be changed by creating the following files and changing their ownership:\n+\n+Copy the contents of [this] file into a new file on your system located at /Library/LaunchDaemons/limit.maxfiles.plist, then run:","path":"docs/administration.md","position":7,"original_position":7,"commit_id":"27e62c40cfebaedfe75eaf5a195b17e55561c70e","original_commit_id":"27e62c40cfebaedfe75eaf5a195b17e55561c70e","user":{"login":"alanbernstein","id":16123214,"node_id":"MDQ6VXNlcjE2MTIzMjE0","avatar_url":"https://avatars3.githubusercontent.com/u/16123214?v=4","gravatar_id":"","url":"https://api.github.com/users/alanbernstein","html_url":"https://github.com/alanbernstein","followers_url":"https://api.github.com/users/alanbernstein/followers","following_url":"https://api.github.com/users/alanbernstein/following{/other_user}","gists_url":"https://api.github.com/users/alanbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/alanbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanbernstein/subscriptions","organizations_url":"https://api.github.com/users/alanbernstein/orgs","repos_url":"https://api.github.com/users/alanbernstein/repos","events_url":"https://api.github.com/users/alanbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/alanbernstein/received_events","type":"User","site_admin":false},"body":"Sorry, I was lazy and left out the url part of the link - we need to keep both of those.","created_at":"2019-07-24T15:34:14Z","updated_at":"2019-07-24T15:34:14Z","html_url":"https://github.com/pilosa/pilosa/pull/2046#discussion_r306879136","pull_request_url":"https://api.github.com/repos/pilosa/pilosa/pulls/2046","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/comments/306879136"},"html":{"href":"https://github.com/pilosa/pilosa/pull/2046#discussion_r306879136"},"pull_request":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/2046"}}},"pull_request":{"url":"https://api.github.com/repos/pilosa/pilosa/pulls/2046","id":300756645,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNzU2NjQ1","html_url":"https://github.com/pilosa/pilosa/pull/2046","diff_url":"https://github.com/pilosa/pilosa/pull/2046.diff","patch_url":"https://github.com/pilosa/pilosa/pull/2046.patch","issue_url":"https://api.github.com/repos/pilosa/pilosa/issues/2046","number":2046,"state":"open","locked":false,"title":"Updated Open File Limit in Administration Doc","user":{"login":"asvetlik","id":50917358,"node_id":"MDQ6VXNlcjUwOTE3MzU4","avatar_url":"https://avatars3.githubusercontent.com/u/50917358?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlik","html_url":"https://github.com/asvetlik","followers_url":"https://api.github.com/users/asvetlik/followers","following_url":"https://api.github.com/users/asvetlik/following{/other_user}","gists_url":"https://api.github.com/users/asvetlik/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlik/subscriptions","organizations_url":"https://api.github.com/users/asvetlik/orgs","repos_url":"https://api.github.com/users/asvetlik/repos","events_url":"https://api.github.com/users/asvetlik/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlik/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nFixed the commit history from Pull Request #2043 \r\n\r\n## Pull request checklist\r\n\r\n- [x] I have read the [contributing guide](https://github.com/pilosa/pilosa/blob/master/CONTRIBUTING.md).\r\n- [x] I have agreed to the [Contributor License Agreement](https://cla-assistant.io/pilosa/pilosa).\r\n- [x] I have updated the [documentation](https://github.com/pilosa/pilosa/tree/master/docs).\r\n- [x] I have resolved any merge conflicts.\r\n- [x] I have included tests that cover my changes.\r\n- [x] All new and existing tests pass.\r\n- [ ] Make sure PR title conforms to convention in CHANGELOG.md.\r\n- [ ] Add appropriate changelog label to PR (if applicable).\r\n\r\n## Code review checklist\r\nThis is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.\r\n\r\n- [ ] Ensure that any changes to external docs have been included in this pull request.\r\n- [ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.\r\n- [ ] Ensure the new code is [properly commented](https://github.com/golang/go/wiki/CodeReviewComments#doc-comments) and follows [Idiomatic Go](https://dmitri.shuralyov.com/idiomatic-go).\r\n- [ ] Check that tests have been written and that they cover the new functionality.\r\n- [ ] Run tests and ensure they pass.\r\n- [ ] Build and run the code, performing any applicable integration testing.\r\n- [ ] Make sure PR title conforms to convention in CHANGELOG.md.\r\n- [ ] Make sure PR is tagged with appropriate changelog label.\r\n","created_at":"2019-07-24T14:40:11Z","updated_at":"2019-07-24T15:34:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"543741561cf00ad4a5b084f69f2efbdddbf6edc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pilosa/pilosa/pulls/2046/commits","review_comments_url":"https://api.github.com/repos/pilosa/pilosa/pulls/2046/comments","review_comment_url":"https://api.github.com/repos/pilosa/pilosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pilosa/pilosa/issues/2046/comments","statuses_url":"https://api.github.com/repos/pilosa/pilosa/statuses/27e62c40cfebaedfe75eaf5a195b17e55561c70e","head":{"label":"asvetlik:admin2","ref":"admin2","sha":"27e62c40cfebaedfe75eaf5a195b17e55561c70e","user":{"login":"asvetlik","id":50917358,"node_id":"MDQ6VXNlcjUwOTE3MzU4","avatar_url":"https://avatars3.githubusercontent.com/u/50917358?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlik","html_url":"https://github.com/asvetlik","followers_url":"https://api.github.com/users/asvetlik/followers","following_url":"https://api.github.com/users/asvetlik/following{/other_user}","gists_url":"https://api.github.com/users/asvetlik/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlik/subscriptions","organizations_url":"https://api.github.com/users/asvetlik/orgs","repos_url":"https://api.github.com/users/asvetlik/repos","events_url":"https://api.github.com/users/asvetlik/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlik/received_events","type":"User","site_admin":false},"repo":{"id":188303953,"node_id":"MDEwOlJlcG9zaXRvcnkxODgzMDM5NTM=","name":"pilosa","full_name":"asvetlik/pilosa","private":false,"owner":{"login":"asvetlik","id":50917358,"node_id":"MDQ6VXNlcjUwOTE3MzU4","avatar_url":"https://avatars3.githubusercontent.com/u/50917358?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlik","html_url":"https://github.com/asvetlik","followers_url":"https://api.github.com/users/asvetlik/followers","following_url":"https://api.github.com/users/asvetlik/following{/other_user}","gists_url":"https://api.github.com/users/asvetlik/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlik/subscriptions","organizations_url":"https://api.github.com/users/asvetlik/orgs","repos_url":"https://api.github.com/users/asvetlik/repos","events_url":"https://api.github.com/users/asvetlik/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asvetlik/pilosa","description":"Pilosa is an open source, distributed bitmap index that dramatically accelerates queries across multiple, massive data sets.","fork":true,"url":"https://api.github.com/repos/asvetlik/pilosa","forks_url":"https://api.github.com/repos/asvetlik/pilosa/forks","keys_url":"https://api.github.com/repos/asvetlik/pilosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asvetlik/pilosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asvetlik/pilosa/teams","hooks_url":"https://api.github.com/repos/asvetlik/pilosa/hooks","issue_events_url":"https://api.github.com/repos/asvetlik/pilosa/issues/events{/number}","events_url":"https://api.github.com/repos/asvetlik/pilosa/events","assignees_url":"https://api.github.com/repos/asvetlik/pilosa/assignees{/user}","branches_url":"https://api.github.com/repos/asvetlik/pilosa/branches{/branch}","tags_url":"https://api.github.com/repos/asvetlik/pilosa/tags","blobs_url":"https://api.github.com/repos/asvetlik/pilosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asvetlik/pilosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asvetlik/pilosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/asvetlik/pilosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asvetlik/pilosa/statuses/{sha}","languages_url":"https://api.github.com/repos/asvetlik/pilosa/languages","stargazers_url":"https://api.github.com/repos/asvetlik/pilosa/stargazers","contributors_url":"https://api.github.com/repos/asvetlik/pilosa/contributors","subscribers_url":"https://api.github.com/repos/asvetlik/pilosa/subscribers","subscription_url":"https://api.github.com/repos/asvetlik/pilosa/subscription","commits_url":"https://api.github.com/repos/asvetlik/pilosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/asvetlik/pilosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/asvetlik/pilosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/asvetlik/pilosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/asvetlik/pilosa/contents/{+path}","compare_url":"https://api.github.com/repos/asvetlik/pilosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asvetlik/pilosa/merges","archive_url":"https://api.github.com/repos/asvetlik/pilosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asvetlik/pilosa/downloads","issues_url":"https://api.github.com/repos/asvetlik/pilosa/issues{/number}","pulls_url":"https://api.github.com/repos/asvetlik/pilosa/pulls{/number}","milestones_url":"https://api.github.com/repos/asvetlik/pilosa/milestones{/number}","notifications_url":"https://api.github.com/repos/asvetlik/pilosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asvetlik/pilosa/labels{/name}","releases_url":"https://api.github.com/repos/asvetlik/pilosa/releases{/id}","deployments_url":"https://api.github.com/repos/asvetlik/pilosa/deployments","created_at":"2019-05-23T20:44:54Z","updated_at":"2019-07-05T15:04:12Z","pushed_at":"2019-07-24T15:22:21Z","git_url":"git://github.com/asvetlik/pilosa.git","ssh_url":"git@github.com:asvetlik/pilosa.git","clone_url":"https://github.com/asvetlik/pilosa.git","svn_url":"https://github.com/asvetlik/pilosa","homepage":"https://www.pilosa.com","size":9881,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pilosa:master","ref":"master","sha":"bd00f1bfe2b261a6329cf8feec499ab35609cd0a","user":{"login":"pilosa","id":24233787,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MjMzNzg3","avatar_url":"https://avatars1.githubusercontent.com/u/24233787?v=4","gravatar_id":"","url":"https://api.github.com/users/pilosa","html_url":"https://github.com/pilosa","followers_url":"https://api.github.com/users/pilosa/followers","following_url":"https://api.github.com/users/pilosa/following{/other_user}","gists_url":"https://api.github.com/users/pilosa/gists{/gist_id}","starred_url":"https://api.github.com/users/pilosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilosa/subscriptions","organizations_url":"https://api.github.com/users/pilosa/orgs","repos_url":"https://api.github.com/users/pilosa/repos","events_url":"https://api.github.com/users/pilosa/events{/privacy}","received_events_url":"https://api.github.com/users/pilosa/received_events","type":"Organization","site_admin":false},"repo":{"id":40127179,"node_id":"MDEwOlJlcG9zaXRvcnk0MDEyNzE3OQ==","name":"pilosa","full_name":"pilosa/pilosa","private":false,"owner":{"login":"pilosa","id":24233787,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MjMzNzg3","avatar_url":"https://avatars1.githubusercontent.com/u/24233787?v=4","gravatar_id":"","url":"https://api.github.com/users/pilosa","html_url":"https://github.com/pilosa","followers_url":"https://api.github.com/users/pilosa/followers","following_url":"https://api.github.com/users/pilosa/following{/other_user}","gists_url":"https://api.github.com/users/pilosa/gists{/gist_id}","starred_url":"https://api.github.com/users/pilosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilosa/subscriptions","organizations_url":"https://api.github.com/users/pilosa/orgs","repos_url":"https://api.github.com/users/pilosa/repos","events_url":"https://api.github.com/users/pilosa/events{/privacy}","received_events_url":"https://api.github.com/users/pilosa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pilosa/pilosa","description":"Pilosa is an open source, distributed bitmap index that dramatically accelerates queries across multiple, massive data sets.","fork":false,"url":"https://api.github.com/repos/pilosa/pilosa","forks_url":"https://api.github.com/repos/pilosa/pilosa/forks","keys_url":"https://api.github.com/repos/pilosa/pilosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilosa/pilosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilosa/pilosa/teams","hooks_url":"https://api.github.com/repos/pilosa/pilosa/hooks","issue_events_url":"https://api.github.com/repos/pilosa/pilosa/issues/events{/number}","events_url":"https://api.github.com/repos/pilosa/pilosa/events","assignees_url":"https://api.github.com/repos/pilosa/pilosa/assignees{/user}","branches_url":"https://api.github.com/repos/pilosa/pilosa/branches{/branch}","tags_url":"https://api.github.com/repos/pilosa/pilosa/tags","blobs_url":"https://api.github.com/repos/pilosa/pilosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilosa/pilosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilosa/pilosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilosa/pilosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilosa/pilosa/statuses/{sha}","languages_url":"https://api.github.com/repos/pilosa/pilosa/languages","stargazers_url":"https://api.github.com/repos/pilosa/pilosa/stargazers","contributors_url":"https://api.github.com/repos/pilosa/pilosa/contributors","subscribers_url":"https://api.github.com/repos/pilosa/pilosa/subscribers","subscription_url":"https://api.github.com/repos/pilosa/pilosa/subscription","commits_url":"https://api.github.com/repos/pilosa/pilosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilosa/pilosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilosa/pilosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilosa/pilosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilosa/pilosa/contents/{+path}","compare_url":"https://api.github.com/repos/pilosa/pilosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilosa/pilosa/merges","archive_url":"https://api.github.com/repos/pilosa/pilosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilosa/pilosa/downloads","issues_url":"https://api.github.com/repos/pilosa/pilosa/issues{/number}","pulls_url":"https://api.github.com/repos/pilosa/pilosa/pulls{/number}","milestones_url":"https://api.github.com/repos/pilosa/pilosa/milestones{/number}","notifications_url":"https://api.github.com/repos/pilosa/pilosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilosa/pilosa/labels{/name}","releases_url":"https://api.github.com/repos/pilosa/pilosa/releases{/id}","deployments_url":"https://api.github.com/repos/pilosa/pilosa/deployments","created_at":"2015-08-03T13:48:08Z","updated_at":"2019-07-24T10:49:11Z","pushed_at":"2019-07-24T15:22:23Z","git_url":"git://github.com/pilosa/pilosa.git","ssh_url":"git@github.com:pilosa/pilosa.git","clone_url":"https://github.com/pilosa/pilosa.git","svn_url":"https://github.com/pilosa/pilosa","homepage":"https://www.pilosa.com","size":9909,"stargazers_count":1842,"watchers_count":1842,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":110,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":110,"watchers":1842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/2046"},"html":{"href":"https://github.com/pilosa/pilosa/pull/2046"},"issue":{"href":"https://api.github.com/repos/pilosa/pilosa/issues/2046"},"comments":{"href":"https://api.github.com/repos/pilosa/pilosa/issues/2046/comments"},"review_comments":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/2046/comments"},"review_comment":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/2046/commits"},"statuses":{"href":"https://api.github.com/repos/pilosa/pilosa/statuses/27e62c40cfebaedfe75eaf5a195b17e55561c70e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alanbernstein"}}