{"action":"created","issue":{"url":"https://api.github.com/repos/jeffchew/test-repo2/issues/268","repository_url":"https://api.github.com/repos/jeffchew/test-repo2","labels_url":"https://api.github.com/repos/jeffchew/test-repo2/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/jeffchew/test-repo2/issues/268/comments","events_url":"https://api.github.com/repos/jeffchew/test-repo2/issues/268/events","html_url":"https://github.com/jeffchew/test-repo2/issues/268","id":504972317,"node_id":"MDU6SXNzdWU1MDQ5NzIzMTc=","number":268,"title":"Cupcake website page creation - Components/Button page","user":{"login":"jeffchew","id":1641214,"node_id":"MDQ6VXNlcjE2NDEyMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1641214?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchew","html_url":"https://github.com/jeffchew","followers_url":"https://api.github.com/users/jeffchew/followers","following_url":"https://api.github.com/users/jeffchew/following{/other_user}","gists_url":"https://api.github.com/users/jeffchew/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchew/subscriptions","organizations_url":"https://api.github.com/users/jeffchew/orgs","repos_url":"https://api.github.com/users/jeffchew/repos","events_url":"https://api.github.com/users/jeffchew/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchew/received_events","type":"User","site_admin":false},"labels":[{"id":1606527899,"node_id":"MDU6TGFiZWwxNjA2NTI3ODk5","url":"https://api.github.com/repos/jeffchew/test-repo2/labels/content","name":"content","color":"dbc206","default":false},{"id":1606527910,"node_id":"MDU6TGFiZWwxNjA2NTI3OTEw","url":"https://api.github.com/repos/jeffchew/test-repo2/labels/design","name":"design","color":"a1c0ea","default":false},{"id":1606527982,"node_id":"MDU6TGFiZWwxNjA2NTI3OTgy","url":"https://api.github.com/repos/jeffchew/test-repo2/labels/migrate","name":"migrate","color":"a97ad6","default":false},{"id":1606528133,"node_id":"MDU6TGFiZWwxNjA2NTI4MTMz","url":"https://api.github.com/repos/jeffchew/test-repo2/labels/sprint%20demo","name":"sprint demo","color":"634bc1","default":false},{"id":1606528244,"node_id":"MDU6TGFiZWwxNjA2NTI4MjQ0","url":"https://api.github.com/repos/jeffchew/test-repo2/labels/website:%20cupcake","name":"website: cupcake","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jeffchew/test-repo2/milestones/38","html_url":"https://github.com/jeffchew/test-repo2/milestone/38","labels_url":"https://api.github.com/repos/jeffchew/test-repo2/milestones/38/labels","id":4738049,"node_id":"MDk6TWlsZXN0b25lNDczODA0OQ==","number":38,"title":"Sprint 19","description":"","creator":{"login":"jeffchew","id":1641214,"node_id":"MDQ6VXNlcjE2NDEyMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1641214?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchew","html_url":"https://github.com/jeffchew","followers_url":"https://api.github.com/users/jeffchew/followers","following_url":"https://api.github.com/users/jeffchew/following{/other_user}","gists_url":"https://api.github.com/users/jeffchew/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchew/subscriptions","organizations_url":"https://api.github.com/users/jeffchew/orgs","repos_url":"https://api.github.com/users/jeffchew/repos","events_url":"https://api.github.com/users/jeffchew/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchew/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":0,"state":"open","created_at":"2019-10-10T00:47:20Z","updated_at":"2019-10-10T01:04:31Z","due_on":"2019-10-11T07:00:00Z","closed_at":null},"comments":1,"created_at":"2019-10-10T01:04:31Z","updated_at":"2019-10-10T01:04:33Z","closed_at":null,"author_association":"OWNER","body":"_chsanche created the following on Sep 18:_  \n\n <!-- Avoid any type of solutions in this user story -->\r\n<!-- replace _{{...}}_ with your own words or remove -->\r\n#### User Story\r\n<!-- {{Provide a detailed description of the user's need here, but avoid any type of solutions}} -->\r\n> As an IBM.com page creator\r\n\r\n> I need to: have a good understanding of the components, patterns, etc\r\n\r\n\r\n> so that I can: do my day to day work without confusion.\r\n\r\n\r\n#### Additional information\r\n- Cupcake website page development priority can be viewed via #1664.\r\n- Button page on v19a website can be viewed [here](https://www.ibm.com/standards/web/components/button/).\r\n- Button page on the current Carbon Design website can be viewed [here](https://www.carbondesignsystem.com/components/button/code)\r\n\r\n\r\n#### Task\r\n- Collaborate with @Olivia-Flory for the content creation.\r\n\r\n#### Acceptance criteria\r\n- [ ] Content and design created and reviewed with the stream lead, the developer and Wonil.\r\n- [ ] Shared with the Carbon and IDL team for feedback.\r\n- [ ] Content and design accepted by Wonil and Linda.\r\n- [ ] Create the dev. issue for coding as the next step.\r\n\r\n<!-- Consider the following when writing Acceptance criteria for this story. -->\r\n<!-- *** Each product backlog item or user story should have at least one Acceptance criteria. -->\r\n<!-- *** Acceptance criteria defines a deliverable that can be completed in a single sprint -->\r\n<!-- *** Each Acceptance criterion is independently testable. -->\r\n<!-- *** Include functional as well as non-functional criteria – when relevant. -->\r\n<!-- *** Team members write Acceptance criteria and the Product Owner verifies it. -->\r\n \n\n_Original issue: https://github.ibm.com/webstandards/digital-design/issues/1730_"},"comment":{"url":"https://api.github.com/repos/jeffchew/test-repo2/issues/comments/540275285","html_url":"https://github.com/jeffchew/test-repo2/issues/268#issuecomment-540275285","issue_url":"https://api.github.com/repos/jeffchew/test-repo2/issues/268","id":540275285,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MDI3NTI4NQ==","user":{"login":"jeffchew","id":1641214,"node_id":"MDQ6VXNlcjE2NDEyMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1641214?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffchew","html_url":"https://github.com/jeffchew","followers_url":"https://api.github.com/users/jeffchew/followers","following_url":"https://api.github.com/users/jeffchew/following{/other_user}","gists_url":"https://api.github.com/users/jeffchew/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffchew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffchew/subscriptions","organizations_url":"https://api.github.com/users/jeffchew/orgs","repos_url":"https://api.github.com/users/jeffchew/repos","events_url":"https://api.github.com/users/jeffchew/events{/privacy}","received_events_url":"https://api.github.com/users/jeffchew/received_events","type":"User","site_admin":false},"created_at":"2019-10-10T01:04:33Z","updated_at":"2019-10-10T01:04:33Z","author_association":"OWNER","body":"_On Oct 08, Olivia-Flory commented:_\nThank you @chsanche, here are my comments for the content:\r\n\r\n### Demo\r\n- change \"Icon + text\" to \"Text + icon\". If this came from Anna we can double check with her because we call it \"text + icon\" in the design kit, and how we refer to it in the \"Styles\" documentation.\r\n- remove medium button option from demo, we will only have small and default\r\n- Update small button size to (40px)\r\n- Note: icon only should be disabled when tertiary, ghost, or danger button variant is selected.  saw your comment on the link page of the demo being coded to the proper \r\n\r\n### Formatting\r\n#### Styles\r\n- The description for Text only button is a little confusing to me, I see that's how we have it on the current page. Maybe we say something about Text only is the default for buttons, use when the context is clear through the button description. cc @jamespistilli can probably make this more clear. \r\n\r\n#### Styles\r\n- should include icon only? (I don't know the exact use case for this 😅 )\r\n- Sets of buttons has a double \"a a\" in the second line.\r\n\r\n### Content\r\n#### Label\r\n- do you think we should use examples that are more specific to marketing / editorial pages? \"Add, delete, save, discard, ok and cancel\" are all very product centric, my brain isn't able to come up with a better example right now. cc @jamespistilli \r\n\r\n#### Icon\r\n- Do not adjust the size of the icon within buttons\r\n- is the ghost button a separate list item or part of the sentence above?\r\n\r\n#### Color\r\nI don't think we need to include the sentence: *\"If color accessibility does not pass use modifier classes...blue 50.\"* We don't want anyone changing the buttons.\r\n\r\n"}}
{"actor":{"display_login":"jeffchew"}}