{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/comments/326581973","pull_request_review_id":291099642,"id":326581973,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjU4MTk3Mw==","diff_hunk":"@@ -108,15 +108,11 @@\n     \"print(\\\"a + b = {}\\\\n\\\".format(ab))\\n\",\n     \"\\n\",\n     \"# ECKey() operations\\n\",\n-    \"# convert our ints to 32 byte representations since that is what ECKey expects\\n\",\n-    \"a_bytes = a.to_bytes(32,'big')\\n\",\n-    \"b_bytes = b.to_bytes(32,'big')\\n\",\n-    \"\\n\",\n     \"# use our bytes to instantiate ECKey instances \\n\",\n     \"a_key = ECKey() \\n\",\n-    \"a_key.set(a_bytes, True) # set the secret value of the Eckey\\n\",\n+    \"a_key.set(a, True) # set the secret value of the Eckey\\n\",","path":"0.2-Elliptic-Curve-Math.ipynb","position":11,"original_position":11,"commit_id":"4aca7e02f42326406614025f126cbcae64169aae","original_commit_id":"4aca7e02f42326406614025f126cbcae64169aae","user":{"login":"bitschmidty","id":1615772,"node_id":"MDQ6VXNlcjE2MTU3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1615772?v=4","gravatar_id":"","url":"https://api.github.com/users/bitschmidty","html_url":"https://github.com/bitschmidty","followers_url":"https://api.github.com/users/bitschmidty/followers","following_url":"https://api.github.com/users/bitschmidty/following{/other_user}","gists_url":"https://api.github.com/users/bitschmidty/gists{/gist_id}","starred_url":"https://api.github.com/users/bitschmidty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitschmidty/subscriptions","organizations_url":"https://api.github.com/users/bitschmidty/orgs","repos_url":"https://api.github.com/users/bitschmidty/repos","events_url":"https://api.github.com/users/bitschmidty/events{/privacy}","received_events_url":"https://api.github.com/users/bitschmidty/received_events","type":"User","site_admin":false},"body":"Getting `TypeError: object of type 'int' has no len()` running through this. Im on Taproot_V0.1.2.","created_at":"2019-09-20T11:13:54Z","updated_at":"2019-09-20T11:16:43Z","html_url":"https://github.com/bitcoinops/taproot-workshop/pull/39#discussion_r326581973","pull_request_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/comments/326581973"},"html":{"href":"https://github.com/bitcoinops/taproot-workshop/pull/39#discussion_r326581973"},"pull_request":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39","id":319213063,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MjEzMDYz","html_url":"https://github.com/bitcoinops/taproot-workshop/pull/39","diff_url":"https://github.com/bitcoinops/taproot-workshop/pull/39.diff","patch_url":"https://github.com/bitcoinops/taproot-workshop/pull/39.patch","issue_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/39","number":39,"state":"open","locked":false,"title":"Making the code shorter and more readable","user":{"login":"elichai","id":2167860,"node_id":"MDQ6VXNlcjIxNjc4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2167860?v=4","gravatar_id":"","url":"https://api.github.com/users/elichai","html_url":"https://github.com/elichai","followers_url":"https://api.github.com/users/elichai/followers","following_url":"https://api.github.com/users/elichai/following{/other_user}","gists_url":"https://api.github.com/users/elichai/gists{/gist_id}","starred_url":"https://api.github.com/users/elichai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elichai/subscriptions","organizations_url":"https://api.github.com/users/elichai/orgs","repos_url":"https://api.github.com/users/elichai/repos","events_url":"https://api.github.com/users/elichai/events{/privacy}","received_events_url":"https://api.github.com/users/elichai/received_events","type":"User","site_admin":false},"body":"Hi.\r\nThis is based and blocked by https://github.com/bitcoinops/bitcoin/pull/11\r\nThe point is to try and remove any unneeded complexity.\r\nSolves #28 and fixed the assert in `verify_schnorr`","created_at":"2019-09-19T10:47:40Z","updated_at":"2019-09-20T11:16:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfb8d364837b0fbb9d976f749f982a17efd4cadd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jnewbery","id":1063656,"node_id":"MDQ6VXNlcjEwNjM2NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1063656?v=4","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},{"login":"jachiang","id":26572234,"node_id":"MDQ6VXNlcjI2NTcyMjM0","avatar_url":"https://avatars3.githubusercontent.com/u/26572234?v=4","gravatar_id":"","url":"https://api.github.com/users/jachiang","html_url":"https://github.com/jachiang","followers_url":"https://api.github.com/users/jachiang/followers","following_url":"https://api.github.com/users/jachiang/following{/other_user}","gists_url":"https://api.github.com/users/jachiang/gists{/gist_id}","starred_url":"https://api.github.com/users/jachiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jachiang/subscriptions","organizations_url":"https://api.github.com/users/jachiang/orgs","repos_url":"https://api.github.com/users/jachiang/repos","events_url":"https://api.github.com/users/jachiang/events{/privacy}","received_events_url":"https://api.github.com/users/jachiang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39/commits","review_comments_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39/comments","review_comment_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/39/comments","statuses_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/statuses/4aca7e02f42326406614025f126cbcae64169aae","head":{"label":"bitcoinops:2019-09-readability","ref":"2019-09-readability","sha":"4aca7e02f42326406614025f126cbcae64169aae","user":{"login":"bitcoinops","id":39812806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODEyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/39812806?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinops","html_url":"https://github.com/bitcoinops","followers_url":"https://api.github.com/users/bitcoinops/followers","following_url":"https://api.github.com/users/bitcoinops/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinops/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinops/subscriptions","organizations_url":"https://api.github.com/users/bitcoinops/orgs","repos_url":"https://api.github.com/users/bitcoinops/repos","events_url":"https://api.github.com/users/bitcoinops/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinops/received_events","type":"Organization","site_admin":false},"repo":{"id":200127576,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAxMjc1NzY=","name":"taproot-workshop","full_name":"bitcoinops/taproot-workshop","private":false,"owner":{"login":"bitcoinops","id":39812806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODEyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/39812806?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinops","html_url":"https://github.com/bitcoinops","followers_url":"https://api.github.com/users/bitcoinops/followers","following_url":"https://api.github.com/users/bitcoinops/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinops/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinops/subscriptions","organizations_url":"https://api.github.com/users/bitcoinops/orgs","repos_url":"https://api.github.com/users/bitcoinops/repos","events_url":"https://api.github.com/users/bitcoinops/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinops/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoinops/taproot-workshop","description":"Taproot & Schnorr Python Library & Documentation.","fork":false,"url":"https://api.github.com/repos/bitcoinops/taproot-workshop","forks_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/forks","keys_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/teams","hooks_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/hooks","issue_events_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/events","assignees_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/tags","blobs_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/languages","stargazers_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/stargazers","contributors_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/contributors","subscribers_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/subscribers","subscription_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/subscription","commits_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/merges","archive_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/downloads","issues_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/deployments","created_at":"2019-08-01T22:40:03Z","updated_at":"2019-09-19T10:36:30Z","pushed_at":"2019-09-19T21:56:23Z","git_url":"git://github.com/bitcoinops/taproot-workshop.git","ssh_url":"git@github.com:bitcoinops/taproot-workshop.git","clone_url":"https://github.com/bitcoinops/taproot-workshop.git","svn_url":"https://github.com/bitcoinops/taproot-workshop","homepage":null,"size":2381,"stargazers_count":12,"watchers_count":12,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":7,"open_issues":14,"watchers":12,"default_branch":"master"}},"base":{"label":"bitcoinops:master","ref":"master","sha":"687ef44e5706b6657b100e2880384477dae983e0","user":{"login":"bitcoinops","id":39812806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODEyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/39812806?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinops","html_url":"https://github.com/bitcoinops","followers_url":"https://api.github.com/users/bitcoinops/followers","following_url":"https://api.github.com/users/bitcoinops/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinops/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinops/subscriptions","organizations_url":"https://api.github.com/users/bitcoinops/orgs","repos_url":"https://api.github.com/users/bitcoinops/repos","events_url":"https://api.github.com/users/bitcoinops/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinops/received_events","type":"Organization","site_admin":false},"repo":{"id":200127576,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAxMjc1NzY=","name":"taproot-workshop","full_name":"bitcoinops/taproot-workshop","private":false,"owner":{"login":"bitcoinops","id":39812806,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODEyODA2","avatar_url":"https://avatars0.githubusercontent.com/u/39812806?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinops","html_url":"https://github.com/bitcoinops","followers_url":"https://api.github.com/users/bitcoinops/followers","following_url":"https://api.github.com/users/bitcoinops/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinops/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinops/subscriptions","organizations_url":"https://api.github.com/users/bitcoinops/orgs","repos_url":"https://api.github.com/users/bitcoinops/repos","events_url":"https://api.github.com/users/bitcoinops/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinops/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoinops/taproot-workshop","description":"Taproot & Schnorr Python Library & Documentation.","fork":false,"url":"https://api.github.com/repos/bitcoinops/taproot-workshop","forks_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/forks","keys_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/teams","hooks_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/hooks","issue_events_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/events","assignees_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/tags","blobs_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/languages","stargazers_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/stargazers","contributors_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/contributors","subscribers_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/subscribers","subscription_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/subscription","commits_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/merges","archive_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/downloads","issues_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinops/taproot-workshop/deployments","created_at":"2019-08-01T22:40:03Z","updated_at":"2019-09-19T10:36:30Z","pushed_at":"2019-09-19T21:56:23Z","git_url":"git://github.com/bitcoinops/taproot-workshop.git","ssh_url":"git@github.com:bitcoinops/taproot-workshop.git","clone_url":"https://github.com/bitcoinops/taproot-workshop.git","svn_url":"https://github.com/bitcoinops/taproot-workshop","homepage":null,"size":2381,"stargazers_count":12,"watchers_count":12,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":7,"open_issues":14,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39"},"html":{"href":"https://github.com/bitcoinops/taproot-workshop/pull/39"},"issue":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/39"},"comments":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinops/taproot-workshop/statuses/4aca7e02f42326406614025f126cbcae64169aae"}},"author_association":"NONE"}}
{"actor":{"display_login":"bitschmidty"}}