{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/304556457","pull_request_review_id":263194002,"id":304556457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDU1NjQ1Nw==","diff_hunk":"@@ -0,0 +1,30 @@\n+{ lib, buildPythonPackage, fetchFromGitHub, humanfriendly }:\n+\n+buildPythonPackage rec {\n+  pname = \"capturer\";\n+  version = \"2.4\";\n+\n+  src = fetchFromGitHub {\n+    owner  = \"xolox\";\n+    repo   = \"python-capturer\";\n+    rev    = version;\n+    sha256 = \"07zy264xd0g7pz9sxjqcpwmrck334xcbb7wfss26lmvgdr5nhcb9\";\n+  };\n+\n+  checkPhase = ''\n+    export PATH=$PATH:$out/bin\n+  '';\n+\n+  propagatedBuildInputs = [ humanfriendly ];\n+\n+  meta = with lib; {\n+    description = \"Easily capture stdout/stderr of the current process and subprocesses\";\n+    homepage = https://github.com/xolox/python-capturer;\n+    license = lib.licenses.mit;","path":"pkgs/development/python-modules/capturer/default.nix","position":23,"original_position":23,"commit_id":"a5351d1e7b962ade81e1fc38fbf3c03b842f0023","original_commit_id":"a5351d1e7b962ade81e1fc38fbf3c03b842f0023","user":{"login":"jonringer","id":7673602,"node_id":"MDQ6VXNlcjc2NzM2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/7673602?v=4","gravatar_id":"","url":"https://api.github.com/users/jonringer","html_url":"https://github.com/jonringer","followers_url":"https://api.github.com/users/jonringer/followers","following_url":"https://api.github.com/users/jonringer/following{/other_user}","gists_url":"https://api.github.com/users/jonringer/gists{/gist_id}","starred_url":"https://api.github.com/users/jonringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonringer/subscriptions","organizations_url":"https://api.github.com/users/jonringer/orgs","repos_url":"https://api.github.com/users/jonringer/repos","events_url":"https://api.github.com/users/jonringer/events{/privacy}","received_events_url":"https://api.github.com/users/jonringer/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    license = licenses.mit;\r\n```","created_at":"2019-07-17T17:34:59Z","updated_at":"2019-07-17T17:35:28Z","html_url":"https://github.com/NixOS/nixpkgs/pull/64989#discussion_r304556457","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/304556457"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/64989#discussion_r304556457"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989","id":298552311,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4NTUyMzEx","html_url":"https://github.com/NixOS/nixpkgs/pull/64989","diff_url":"https://github.com/NixOS/nixpkgs/pull/64989.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/64989.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/64989","number":64989,"state":"open","locked":false,"title":"pythonPackages.rotate-backups: init at 6.0","user":{"login":"eyJhb","id":25955146,"node_id":"MDQ6VXNlcjI1OTU1MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/25955146?v=4","gravatar_id":"","url":"https://api.github.com/users/eyJhb","html_url":"https://github.com/eyJhb","followers_url":"https://api.github.com/users/eyJhb/followers","following_url":"https://api.github.com/users/eyJhb/following{/other_user}","gists_url":"https://api.github.com/users/eyJhb/gists{/gist_id}","starred_url":"https://api.github.com/users/eyJhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyJhb/subscriptions","organizations_url":"https://api.github.com/users/eyJhb/orgs","repos_url":"https://api.github.com/users/eyJhb/repos","events_url":"https://api.github.com/users/eyJhb/events{/privacy}","received_events_url":"https://api.github.com/users/eyJhb/received_events","type":"User","site_admin":false},"body":"<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->\r\n###### Motivation for this change\r\nWanting roate-backups, but keep in mind it has A LOT of dependencies which depend on each other.\r\nI have done my best to keep it clean, and make as many tests as possible work.\r\n\r\nI couldn't find a good way to put them into the python-packages.nix file, as the alphabetic order is.. Non existing. So I have grouped them together.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run \"nix-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Ensured that relevant documentation is up to date\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n","created_at":"2019-07-17T15:32:03Z","updated_at":"2019-07-17T17:35:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2e888945a68c426558759948de2bb17d5b1733d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"FRidh","id":2129135,"node_id":"MDQ6VXNlcjIxMjkxMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":731735423,"node_id":"MDU6TGFiZWw3MzE3MzU0MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%2011-100","name":"10.rebuild-darwin: 11-100","color":"fbca04","default":false},{"id":731734101,"node_id":"MDU6TGFiZWw3MzE3MzQxMDE=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false},{"id":740714914,"node_id":"MDU6TGFiZWw3NDA3MTQ5MTQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/11.by:%20package-maintainer","name":"11.by: package-maintainer","color":"ddeecc","default":false},{"id":9820195,"node_id":"MDU6TGFiZWw5ODIwMTk1","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20python","name":"6.topic: python","color":"fef2c0","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/64989/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a5351d1e7b962ade81e1fc38fbf3c03b842f0023","head":{"label":"eyJhb:rotate-backups","ref":"rotate-backups","sha":"a5351d1e7b962ade81e1fc38fbf3c03b842f0023","user":{"login":"eyJhb","id":25955146,"node_id":"MDQ6VXNlcjI1OTU1MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/25955146?v=4","gravatar_id":"","url":"https://api.github.com/users/eyJhb","html_url":"https://github.com/eyJhb","followers_url":"https://api.github.com/users/eyJhb/followers","following_url":"https://api.github.com/users/eyJhb/following{/other_user}","gists_url":"https://api.github.com/users/eyJhb/gists{/gist_id}","starred_url":"https://api.github.com/users/eyJhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyJhb/subscriptions","organizations_url":"https://api.github.com/users/eyJhb/orgs","repos_url":"https://api.github.com/users/eyJhb/repos","events_url":"https://api.github.com/users/eyJhb/events{/privacy}","received_events_url":"https://api.github.com/users/eyJhb/received_events","type":"User","site_admin":false},"repo":{"id":160986660,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5ODY2NjA=","name":"nixpkgs","full_name":"eyJhb/nixpkgs","private":false,"owner":{"login":"eyJhb","id":25955146,"node_id":"MDQ6VXNlcjI1OTU1MTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/25955146?v=4","gravatar_id":"","url":"https://api.github.com/users/eyJhb","html_url":"https://github.com/eyJhb","followers_url":"https://api.github.com/users/eyJhb/followers","following_url":"https://api.github.com/users/eyJhb/following{/other_user}","gists_url":"https://api.github.com/users/eyJhb/gists{/gist_id}","starred_url":"https://api.github.com/users/eyJhb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyJhb/subscriptions","organizations_url":"https://api.github.com/users/eyJhb/orgs","repos_url":"https://api.github.com/users/eyJhb/repos","events_url":"https://api.github.com/users/eyJhb/events{/privacy}","received_events_url":"https://api.github.com/users/eyJhb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eyJhb/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/eyJhb/nixpkgs","forks_url":"https://api.github.com/repos/eyJhb/nixpkgs/forks","keys_url":"https://api.github.com/repos/eyJhb/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eyJhb/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eyJhb/nixpkgs/teams","hooks_url":"https://api.github.com/repos/eyJhb/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/eyJhb/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/eyJhb/nixpkgs/events","assignees_url":"https://api.github.com/repos/eyJhb/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/eyJhb/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/eyJhb/nixpkgs/tags","blobs_url":"https://api.github.com/repos/eyJhb/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eyJhb/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eyJhb/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/eyJhb/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eyJhb/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/eyJhb/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/eyJhb/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/eyJhb/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/eyJhb/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/eyJhb/nixpkgs/subscription","commits_url":"https://api.github.com/repos/eyJhb/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/eyJhb/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/eyJhb/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/eyJhb/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/eyJhb/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/eyJhb/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eyJhb/nixpkgs/merges","archive_url":"https://api.github.com/repos/eyJhb/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eyJhb/nixpkgs/downloads","issues_url":"https://api.github.com/repos/eyJhb/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/eyJhb/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/eyJhb/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/eyJhb/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eyJhb/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/eyJhb/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/eyJhb/nixpkgs/deployments","created_at":"2018-12-08T23:11:47Z","updated_at":"2019-07-17T08:27:29Z","pushed_at":"2019-07-17T15:56:30Z","git_url":"git://github.com/eyJhb/nixpkgs.git","ssh_url":"git@github.com:eyJhb/nixpkgs.git","clone_url":"https://github.com/eyJhb/nixpkgs.git","svn_url":"https://github.com/eyJhb/nixpkgs","homepage":null,"size":983730,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"d61e24ec51dc74399187c9a64d11e04ff1c85ec9","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-07-17T17:14:55Z","pushed_at":"2019-07-17T17:20:22Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":1000192,"stargazers_count":3969,"watchers_count":3969,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3806,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4525,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3806,"open_issues":4525,"watchers":3969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/64989"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/64989"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/64989/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/64989/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a5351d1e7b962ade81e1fc38fbf3c03b842f0023"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jonringer"}}