{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments/285254533","pull_request_review_id":239071686,"id":285254533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTI1NDUzMw==","diff_hunk":"@@ -311,7 +342,16 @@ fi\n \n mkdir -p ${ROOTFS_DIR}\n \n-if [ -n \"${USE_DOCKER}\" ] ; then\n+detect_go_version\n+\n+\n+if [ -z \"${USE_DOCKER}\" ] ; then\n+\t#Generate an error if the local Go version is too old\n+\tfoundVersion=$(go version | sed -E \"s/^.+([0-9]+\\.[0-9]+\\.[0-9]+).*$/\\1/g\")","path":"rootfs-builder/rootfs.sh","position":68,"original_position":68,"commit_id":"6d6cd0714aa339a76c0fc42caf18a813e4071b75","original_commit_id":"6d6cd0714aa339a76c0fc42caf18a813e4071b75","user":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"body":"I wonder if this should be applied in any case? ","created_at":"2019-05-17T19:09:53Z","updated_at":"2019-05-17T19:10:30Z","html_url":"https://github.com/kata-containers/osbuilder/pull/292#discussion_r285254533","pull_request_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments/285254533"},"html":{"href":"https://github.com/kata-containers/osbuilder/pull/292#discussion_r285254533"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292"}},"in_reply_to_id":285254218},"pull_request":{"url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292","id":279978933,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5OTc4OTMz","html_url":"https://github.com/kata-containers/osbuilder/pull/292","diff_url":"https://github.com/kata-containers/osbuilder/pull/292.diff","patch_url":"https://github.com/kata-containers/osbuilder/pull/292.patch","issue_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/292","number":292,"state":"open","locked":false,"title":"agent: detect required Go version from versions.yaml","user":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"body":"Detect the Go version required to build the agent from the versions.yaml\r\nfile in the runtime repository.\r\n    \r\nFixes: #291\r\n\r\n---- \r\nIncludes also:\r\n\r\nrootfs: enforce minimum Go version when building locally","created_at":"2019-05-17T17:49:07Z","updated_at":"2019-05-17T19:10:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e22f646482c2fc8d71b714a08b8aa036e3a07c95","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jodh-intel","id":20315601,"node_id":"MDQ6VXNlcjIwMzE1NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/20315601?v=4","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292/commits","review_comments_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292/comments","review_comment_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/292/comments","statuses_url":"https://api.github.com/repos/kata-containers/osbuilder/statuses/6d6cd0714aa339a76c0fc42caf18a813e4071b75","head":{"label":"marcov:versions.yaml","ref":"versions.yaml","sha":"6d6cd0714aa339a76c0fc42caf18a813e4071b75","user":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"repo":{"id":147547657,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NDc2NTc=","name":"kata-osbuilder","full_name":"marcov/kata-osbuilder","private":false,"owner":{"login":"marcov","id":424592,"node_id":"MDQ6VXNlcjQyNDU5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/424592?v=4","gravatar_id":"","url":"https://api.github.com/users/marcov","html_url":"https://github.com/marcov","followers_url":"https://api.github.com/users/marcov/followers","following_url":"https://api.github.com/users/marcov/following{/other_user}","gists_url":"https://api.github.com/users/marcov/gists{/gist_id}","starred_url":"https://api.github.com/users/marcov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcov/subscriptions","organizations_url":"https://api.github.com/users/marcov/orgs","repos_url":"https://api.github.com/users/marcov/repos","events_url":"https://api.github.com/users/marcov/events{/privacy}","received_events_url":"https://api.github.com/users/marcov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marcov/kata-osbuilder","description":"Kata Containers guest OS building scripts","fork":true,"url":"https://api.github.com/repos/marcov/kata-osbuilder","forks_url":"https://api.github.com/repos/marcov/kata-osbuilder/forks","keys_url":"https://api.github.com/repos/marcov/kata-osbuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcov/kata-osbuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcov/kata-osbuilder/teams","hooks_url":"https://api.github.com/repos/marcov/kata-osbuilder/hooks","issue_events_url":"https://api.github.com/repos/marcov/kata-osbuilder/issues/events{/number}","events_url":"https://api.github.com/repos/marcov/kata-osbuilder/events","assignees_url":"https://api.github.com/repos/marcov/kata-osbuilder/assignees{/user}","branches_url":"https://api.github.com/repos/marcov/kata-osbuilder/branches{/branch}","tags_url":"https://api.github.com/repos/marcov/kata-osbuilder/tags","blobs_url":"https://api.github.com/repos/marcov/kata-osbuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcov/kata-osbuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcov/kata-osbuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcov/kata-osbuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcov/kata-osbuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/marcov/kata-osbuilder/languages","stargazers_url":"https://api.github.com/repos/marcov/kata-osbuilder/stargazers","contributors_url":"https://api.github.com/repos/marcov/kata-osbuilder/contributors","subscribers_url":"https://api.github.com/repos/marcov/kata-osbuilder/subscribers","subscription_url":"https://api.github.com/repos/marcov/kata-osbuilder/subscription","commits_url":"https://api.github.com/repos/marcov/kata-osbuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcov/kata-osbuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcov/kata-osbuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcov/kata-osbuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcov/kata-osbuilder/contents/{+path}","compare_url":"https://api.github.com/repos/marcov/kata-osbuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcov/kata-osbuilder/merges","archive_url":"https://api.github.com/repos/marcov/kata-osbuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcov/kata-osbuilder/downloads","issues_url":"https://api.github.com/repos/marcov/kata-osbuilder/issues{/number}","pulls_url":"https://api.github.com/repos/marcov/kata-osbuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/marcov/kata-osbuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/marcov/kata-osbuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcov/kata-osbuilder/labels{/name}","releases_url":"https://api.github.com/repos/marcov/kata-osbuilder/releases{/id}","deployments_url":"https://api.github.com/repos/marcov/kata-osbuilder/deployments","created_at":"2018-09-05T16:25:54Z","updated_at":"2018-09-25T08:54:43Z","pushed_at":"2019-05-17T17:53:48Z","git_url":"git://github.com/marcov/kata-osbuilder.git","ssh_url":"git@github.com:marcov/kata-osbuilder.git","clone_url":"https://github.com/marcov/kata-osbuilder.git","svn_url":"https://github.com/marcov/kata-osbuilder","homepage":"","size":359,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"a800a5dee6925cb32dfb0ad08e7ca7251d95b3e7","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539619,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk2MTk=","name":"osbuilder","full_name":"kata-containers/osbuilder","private":false,"owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kata-containers/osbuilder","description":"Kata Containers guest OS building scripts","fork":false,"url":"https://api.github.com/repos/kata-containers/osbuilder","forks_url":"https://api.github.com/repos/kata-containers/osbuilder/forks","keys_url":"https://api.github.com/repos/kata-containers/osbuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/osbuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/osbuilder/teams","hooks_url":"https://api.github.com/repos/kata-containers/osbuilder/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/osbuilder/events","assignees_url":"https://api.github.com/repos/kata-containers/osbuilder/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/osbuilder/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/osbuilder/tags","blobs_url":"https://api.github.com/repos/kata-containers/osbuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/osbuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/osbuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/osbuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/osbuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/osbuilder/languages","stargazers_url":"https://api.github.com/repos/kata-containers/osbuilder/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/osbuilder/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/osbuilder/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/osbuilder/subscription","commits_url":"https://api.github.com/repos/kata-containers/osbuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/osbuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/osbuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/osbuilder/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/osbuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/osbuilder/merges","archive_url":"https://api.github.com/repos/kata-containers/osbuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/osbuilder/downloads","issues_url":"https://api.github.com/repos/kata-containers/osbuilder/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/osbuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/osbuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/osbuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/osbuilder/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/osbuilder/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/osbuilder/deployments","created_at":"2017-11-13T11:24:55Z","updated_at":"2019-05-17T09:00:04Z","pushed_at":"2019-05-17T17:53:49Z","git_url":"git://github.com/kata-containers/osbuilder.git","ssh_url":"git@github.com:kata-containers/osbuilder.git","clone_url":"https://github.com/kata-containers/osbuilder.git","svn_url":"https://github.com/kata-containers/osbuilder","homepage":"","size":371,"stargazers_count":65,"watchers_count":65,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":29,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292"},"html":{"href":"https://github.com/kata-containers/osbuilder/pull/292"},"issue":{"href":"https://api.github.com/repos/kata-containers/osbuilder/issues/292"},"comments":{"href":"https://api.github.com/repos/kata-containers/osbuilder/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/osbuilder/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/osbuilder/statuses/6d6cd0714aa339a76c0fc42caf18a813e4071b75"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jcvenegas"}}