{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/4461","repository_url":"https://api.github.com/repos/kubernetes-sigs/kubespray","labels_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/4461/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/4461/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/4461/events","html_url":"https://github.com/kubernetes-sigs/kubespray/pull/4461","id":430341497,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MjQ5MjIx","number":4461,"title":"Enable nodelocaldns by default","user":{"login":"woopstar","id":2997782,"node_id":"MDQ6VXNlcjI5OTc3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997782?v=4","gravatar_id":"","url":"https://api.github.com/users/woopstar","html_url":"https://github.com/woopstar","followers_url":"https://api.github.com/users/woopstar/followers","following_url":"https://api.github.com/users/woopstar/following{/other_user}","gists_url":"https://api.github.com/users/woopstar/gists{/gist_id}","starred_url":"https://api.github.com/users/woopstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woopstar/subscriptions","organizations_url":"https://api.github.com/users/woopstar/orgs","repos_url":"https://api.github.com/users/woopstar/repos","events_url":"https://api.github.com/users/woopstar/events{/privacy}","received_events_url":"https://api.github.com/users/woopstar/received_events","type":"User","site_admin":false},"labels":[{"id":1031817353,"node_id":"MDU6TGFiZWwxMDMxODE3MzUz","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485769464,"node_id":"MDU6TGFiZWw0ODU3Njk0NjQ=","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":677476400,"node_id":"MDU6TGFiZWw2Nzc0NzY0MDA=","url":"https://api.github.com/repos/kubernetes-sigs/kubespray/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-04-08T09:17:47Z","updated_at":"2019-04-08T09:54:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kubespray/pulls/4461","html_url":"https://github.com/kubernetes-sigs/kubespray/pull/4461","diff_url":"https://github.com/kubernetes-sigs/kubespray/pull/4461.diff","patch_url":"https://github.com/kubernetes-sigs/kubespray/pull/4461.patch"},"body":"Enable nodelocaldns by default as Kubespray is \"production-ready\".\r\n\r\nNodelocaldns prevents / mitigates racy DNS connections.\r\n\r\nSee more at:\r\n\r\n- https://blog.quentin-machu.fr/2018/06/24/5-15s-dns-lookups-on-kubernetes/\r\n- https://www.weave.works/blog/racy-conntrack-and-dns-lookup-timeouts\r\n- https://tech.xing.com/a-reason-for-unexplained-connection-timeouts-on-kubernetes-docker-abd041cf7e02\r\n- https://github.com/Quentin-M/weave-tc"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/comments/480765157","html_url":"https://github.com/kubernetes-sigs/kubespray/pull/4461#issuecomment-480765157","issue_url":"https://api.github.com/repos/kubernetes-sigs/kubespray/issues/4461","id":480765157,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4MDc2NTE1Nw==","user":{"login":"woopstar","id":2997782,"node_id":"MDQ6VXNlcjI5OTc3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997782?v=4","gravatar_id":"","url":"https://api.github.com/users/woopstar","html_url":"https://github.com/woopstar","followers_url":"https://api.github.com/users/woopstar/followers","following_url":"https://api.github.com/users/woopstar/following{/other_user}","gists_url":"https://api.github.com/users/woopstar/gists{/gist_id}","starred_url":"https://api.github.com/users/woopstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woopstar/subscriptions","organizations_url":"https://api.github.com/users/woopstar/orgs","repos_url":"https://api.github.com/users/woopstar/repos","events_url":"https://api.github.com/users/woopstar/events{/privacy}","received_events_url":"https://api.github.com/users/woopstar/received_events","type":"User","site_admin":false},"created_at":"2019-04-08T09:54:17Z","updated_at":"2019-04-08T09:54:17Z","author_association":"MEMBER","body":"> Two questions:\r\n> \r\n> 1. Should we remove it from `tests/files/gce_centos7-flannel-addons.yml` then ?\r\n> 2. Before or after 2.9.0 release?\r\n\r\nAfter 2.9.0 rls. :) \r\n\r\nI removed it, but maybe we should consider to set it to false in some test?"}}
{"actor":{"display_login":"woopstar"}}