{"action":"created","comment":{"url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/comments/259830923","pull_request_review_id":207400659,"id":259830923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTgzMDkyMw==","diff_hunk":"@@ -468,14 +482,18 @@ class Masq {\n     if (!this.dataEncryptionKey) throw Error('Data encryption key is not set')\n   }\n \n+  _checkNonce () {\n+    if (!this.nonce) throw Error('Nonce is not set')\n+  }","path":"src/index.js","position":114,"original_position":114,"commit_id":"4082ebccadbd3e5ad63740b30c30064b32ec1998","original_commit_id":"4082ebccadbd3e5ad63740b30c30064b32ec1998","user":{"login":"sujeebant","id":7206073,"node_id":"MDQ6VXNlcjcyMDYwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7206073?v=4","gravatar_id":"","url":"https://api.github.com/users/sujeebant","html_url":"https://github.com/sujeebant","followers_url":"https://api.github.com/users/sujeebant/followers","following_url":"https://api.github.com/users/sujeebant/following{/other_user}","gists_url":"https://api.github.com/users/sujeebant/gists{/gist_id}","starred_url":"https://api.github.com/users/sujeebant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sujeebant/subscriptions","organizations_url":"https://api.github.com/users/sujeebant/orgs","repos_url":"https://api.github.com/users/sujeebant/repos","events_url":"https://api.github.com/users/sujeebant/events{/privacy}","received_events_url":"https://api.github.com/users/sujeebant/received_events","type":"User","site_admin":false},"body":"function _checkNonce and _checkDEK never called ?","created_at":"2019-02-25T13:52:02Z","updated_at":"2019-02-25T13:52:02Z","html_url":"https://github.com/QwantResearch/masq-lib/pull/69#discussion_r259830923","pull_request_url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/comments/259830923"},"html":{"href":"https://github.com/QwantResearch/masq-lib/pull/69#discussion_r259830923"},"pull_request":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69","id":255443183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NDQzMTgz","html_url":"https://github.com/QwantResearch/masq-lib/pull/69","diff_url":"https://github.com/QwantResearch/masq-lib/pull/69.diff","patch_url":"https://github.com/QwantResearch/masq-lib/pull/69.patch","issue_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues/69","number":69,"state":"open","locked":false,"title":"Masq 196 nonce","user":{"login":"leventdem","id":6748529,"node_id":"MDQ6VXNlcjY3NDg1Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/6748529?v=4","gravatar_id":"","url":"https://api.github.com/users/leventdem","html_url":"https://github.com/leventdem","followers_url":"https://api.github.com/users/leventdem/followers","following_url":"https://api.github.com/users/leventdem/following{/other_user}","gists_url":"https://api.github.com/users/leventdem/gists{/gist_id}","starred_url":"https://api.github.com/users/leventdem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventdem/subscriptions","organizations_url":"https://api.github.com/users/leventdem/orgs","repos_url":"https://api.github.com/users/leventdem/repos","events_url":"https://api.github.com/users/leventdem/events{/privacy}","received_events_url":"https://api.github.com/users/leventdem/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-22T15:53:57Z","updated_at":"2019-02-25T13:52:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89e9f397e45ff39f02bc5490eb51bdaf0df1f545","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69/commits","review_comments_url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69/comments","review_comment_url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues/69/comments","statuses_url":"https://api.github.com/repos/QwantResearch/masq-lib/statuses/4082ebccadbd3e5ad63740b30c30064b32ec1998","head":{"label":"QwantResearch:Masq-196-nonce","ref":"Masq-196-nonce","sha":"4082ebccadbd3e5ad63740b30c30064b32ec1998","user":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":153622471,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MjI0NzE=","name":"masq-lib","full_name":"QwantResearch/masq-lib","private":false,"owner":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QwantResearch/masq-lib","description":null,"fork":false,"url":"https://api.github.com/repos/QwantResearch/masq-lib","forks_url":"https://api.github.com/repos/QwantResearch/masq-lib/forks","keys_url":"https://api.github.com/repos/QwantResearch/masq-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QwantResearch/masq-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QwantResearch/masq-lib/teams","hooks_url":"https://api.github.com/repos/QwantResearch/masq-lib/hooks","issue_events_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues/events{/number}","events_url":"https://api.github.com/repos/QwantResearch/masq-lib/events","assignees_url":"https://api.github.com/repos/QwantResearch/masq-lib/assignees{/user}","branches_url":"https://api.github.com/repos/QwantResearch/masq-lib/branches{/branch}","tags_url":"https://api.github.com/repos/QwantResearch/masq-lib/tags","blobs_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QwantResearch/masq-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/QwantResearch/masq-lib/languages","stargazers_url":"https://api.github.com/repos/QwantResearch/masq-lib/stargazers","contributors_url":"https://api.github.com/repos/QwantResearch/masq-lib/contributors","subscribers_url":"https://api.github.com/repos/QwantResearch/masq-lib/subscribers","subscription_url":"https://api.github.com/repos/QwantResearch/masq-lib/subscription","commits_url":"https://api.github.com/repos/QwantResearch/masq-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/QwantResearch/masq-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/QwantResearch/masq-lib/contents/{+path}","compare_url":"https://api.github.com/repos/QwantResearch/masq-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QwantResearch/masq-lib/merges","archive_url":"https://api.github.com/repos/QwantResearch/masq-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QwantResearch/masq-lib/downloads","issues_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues{/number}","pulls_url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/QwantResearch/masq-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/QwantResearch/masq-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QwantResearch/masq-lib/labels{/name}","releases_url":"https://api.github.com/repos/QwantResearch/masq-lib/releases{/id}","deployments_url":"https://api.github.com/repos/QwantResearch/masq-lib/deployments","created_at":"2018-10-18T12:46:03Z","updated_at":"2019-02-22T14:32:35Z","pushed_at":"2019-02-22T16:08:35Z","git_url":"git://github.com/QwantResearch/masq-lib.git","ssh_url":"git@github.com:QwantResearch/masq-lib.git","clone_url":"https://github.com/QwantResearch/masq-lib.git","svn_url":"https://github.com/QwantResearch/masq-lib","homepage":null,"size":943,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"QwantResearch:master","ref":"master","sha":"fcaa9bcb9417200ed069a5aebf54f514eb7f8903","user":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":153622471,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MjI0NzE=","name":"masq-lib","full_name":"QwantResearch/masq-lib","private":false,"owner":{"login":"QwantResearch","id":31347303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ3MzAz","avatar_url":"https://avatars3.githubusercontent.com/u/31347303?v=4","gravatar_id":"","url":"https://api.github.com/users/QwantResearch","html_url":"https://github.com/QwantResearch","followers_url":"https://api.github.com/users/QwantResearch/followers","following_url":"https://api.github.com/users/QwantResearch/following{/other_user}","gists_url":"https://api.github.com/users/QwantResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/QwantResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QwantResearch/subscriptions","organizations_url":"https://api.github.com/users/QwantResearch/orgs","repos_url":"https://api.github.com/users/QwantResearch/repos","events_url":"https://api.github.com/users/QwantResearch/events{/privacy}","received_events_url":"https://api.github.com/users/QwantResearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QwantResearch/masq-lib","description":null,"fork":false,"url":"https://api.github.com/repos/QwantResearch/masq-lib","forks_url":"https://api.github.com/repos/QwantResearch/masq-lib/forks","keys_url":"https://api.github.com/repos/QwantResearch/masq-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QwantResearch/masq-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QwantResearch/masq-lib/teams","hooks_url":"https://api.github.com/repos/QwantResearch/masq-lib/hooks","issue_events_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues/events{/number}","events_url":"https://api.github.com/repos/QwantResearch/masq-lib/events","assignees_url":"https://api.github.com/repos/QwantResearch/masq-lib/assignees{/user}","branches_url":"https://api.github.com/repos/QwantResearch/masq-lib/branches{/branch}","tags_url":"https://api.github.com/repos/QwantResearch/masq-lib/tags","blobs_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QwantResearch/masq-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/QwantResearch/masq-lib/languages","stargazers_url":"https://api.github.com/repos/QwantResearch/masq-lib/stargazers","contributors_url":"https://api.github.com/repos/QwantResearch/masq-lib/contributors","subscribers_url":"https://api.github.com/repos/QwantResearch/masq-lib/subscribers","subscription_url":"https://api.github.com/repos/QwantResearch/masq-lib/subscription","commits_url":"https://api.github.com/repos/QwantResearch/masq-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/QwantResearch/masq-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/QwantResearch/masq-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/QwantResearch/masq-lib/contents/{+path}","compare_url":"https://api.github.com/repos/QwantResearch/masq-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QwantResearch/masq-lib/merges","archive_url":"https://api.github.com/repos/QwantResearch/masq-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QwantResearch/masq-lib/downloads","issues_url":"https://api.github.com/repos/QwantResearch/masq-lib/issues{/number}","pulls_url":"https://api.github.com/repos/QwantResearch/masq-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/QwantResearch/masq-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/QwantResearch/masq-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QwantResearch/masq-lib/labels{/name}","releases_url":"https://api.github.com/repos/QwantResearch/masq-lib/releases{/id}","deployments_url":"https://api.github.com/repos/QwantResearch/masq-lib/deployments","created_at":"2018-10-18T12:46:03Z","updated_at":"2019-02-22T14:32:35Z","pushed_at":"2019-02-22T16:08:35Z","git_url":"git://github.com/QwantResearch/masq-lib.git","ssh_url":"git@github.com:QwantResearch/masq-lib.git","clone_url":"https://github.com/QwantResearch/masq-lib.git","svn_url":"https://github.com/QwantResearch/masq-lib","homepage":null,"size":943,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69"},"html":{"href":"https://github.com/QwantResearch/masq-lib/pull/69"},"issue":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/issues/69"},"comments":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/QwantResearch/masq-lib/statuses/4082ebccadbd3e5ad63740b30c30064b32ec1998"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sujeebant"}}