{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/comments/300742736","pull_request_review_id":258481672,"id":300742736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDc0MjczNg==","diff_hunk":"@@ -31,18 +31,18 @@\n # or\n # >>> study_path = '/Users/sophie/repos/ExampleData/'\n \n-study_path = sample.data_path()\n+study_path = '/home/stefanappelhoff/Downloads/eeg_matchingpennies'\n \n # ``subjects_dir`` : str\n #   The ``subjects_dir`` contains the MRI files for all subjects.\n \n-subjects_dir = os.path.join(study_path, 'subjects')\n+subjects_dir = os.path.join(study_path)\n \n-# ``meg_dir`` : str\n-#   The ``meg_dir`` contains the MEG data in subfolders\n+# ``meeg_dir`` : str\n+#   The ``meeg_dir`` contains the MEG or EEG data in subfolders\n #   named my_study_path/MEG/my_subject/\n \n-meg_dir = os.path.join(study_path, 'MEG')\n+meeg_dir = os.path.join(subjects_dir, 'eeg')","path":"config.py","position":20,"original_position":20,"commit_id":"1e0d49c92d43dacb1e9a96c6ec027029d8011c8f","original_commit_id":"1e0d49c92d43dacb1e9a96c6ec027029d8011c8f","user":{"login":"jasmainak","id":15852194,"node_id":"MDQ6VXNlcjE1ODUyMTk0","avatar_url":"https://avatars3.githubusercontent.com/u/15852194?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmainak","html_url":"https://github.com/jasmainak","followers_url":"https://api.github.com/users/jasmainak/followers","following_url":"https://api.github.com/users/jasmainak/following{/other_user}","gists_url":"https://api.github.com/users/jasmainak/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmainak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmainak/subscriptions","organizations_url":"https://api.github.com/users/jasmainak/orgs","repos_url":"https://api.github.com/users/jasmainak/repos","events_url":"https://api.github.com/users/jasmainak/events{/privacy}","received_events_url":"https://api.github.com/users/jasmainak/received_events","type":"User","site_admin":false},"body":"Just assume BIDS structure and get rid of this, no?","created_at":"2019-07-05T16:32:16Z","updated_at":"2019-07-05T16:32:17Z","html_url":"https://github.com/mne-tools/mne-study-template/pull/35#discussion_r300742736","pull_request_url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/comments/300742736"},"html":{"href":"https://github.com/mne-tools/mne-study-template/pull/35#discussion_r300742736"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35","id":294927695,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0OTI3Njk1","html_url":"https://github.com/mne-tools/mne-study-template/pull/35","diff_url":"https://github.com/mne-tools/mne-study-template/pull/35.diff","patch_url":"https://github.com/mne-tools/mne-study-template/pull/35.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-study-template/issues/35","number":35,"state":"open","locked":false,"title":"show the mess","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"body":"cc @jasmainak \r\n\r\nThis just shows that the whole `config.py` file is:\r\n1. targeted at MEG data (MEG-centric in a way that BIDS is MRI centric)\r\n1. targeted at a structure with `subjects` , such as for freesurfer and  `MEG` directories\r\n\r\nMaking the study template modality agnostic (i.e., make it work for EEG, MEG, iEEG) and work with a BIDS structure might be more effort than writing a new config from scratch and adding part by part ...\r\n\r\n","created_at":"2019-07-05T16:13:02Z","updated_at":"2019-07-05T16:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e9742b017f066637e7ae0746e5d0b1561f4bcc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-study-template/issues/35/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-study-template/statuses/1e0d49c92d43dacb1e9a96c6ec027029d8011c8f","head":{"label":"sappelhoff:bids","ref":"bids","sha":"1e0d49c92d43dacb1e9a96c6ec027029d8011c8f","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"repo":{"id":189055201,"node_id":"MDEwOlJlcG9zaXRvcnkxODkwNTUyMDE=","name":"mne-study-template","full_name":"sappelhoff/mne-study-template","private":false,"owner":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sappelhoff/mne-study-template","description":"Template for a group study using the MNE Python software","fork":true,"url":"https://api.github.com/repos/sappelhoff/mne-study-template","forks_url":"https://api.github.com/repos/sappelhoff/mne-study-template/forks","keys_url":"https://api.github.com/repos/sappelhoff/mne-study-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sappelhoff/mne-study-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sappelhoff/mne-study-template/teams","hooks_url":"https://api.github.com/repos/sappelhoff/mne-study-template/hooks","issue_events_url":"https://api.github.com/repos/sappelhoff/mne-study-template/issues/events{/number}","events_url":"https://api.github.com/repos/sappelhoff/mne-study-template/events","assignees_url":"https://api.github.com/repos/sappelhoff/mne-study-template/assignees{/user}","branches_url":"https://api.github.com/repos/sappelhoff/mne-study-template/branches{/branch}","tags_url":"https://api.github.com/repos/sappelhoff/mne-study-template/tags","blobs_url":"https://api.github.com/repos/sappelhoff/mne-study-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sappelhoff/mne-study-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sappelhoff/mne-study-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/sappelhoff/mne-study-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sappelhoff/mne-study-template/statuses/{sha}","languages_url":"https://api.github.com/repos/sappelhoff/mne-study-template/languages","stargazers_url":"https://api.github.com/repos/sappelhoff/mne-study-template/stargazers","contributors_url":"https://api.github.com/repos/sappelhoff/mne-study-template/contributors","subscribers_url":"https://api.github.com/repos/sappelhoff/mne-study-template/subscribers","subscription_url":"https://api.github.com/repos/sappelhoff/mne-study-template/subscription","commits_url":"https://api.github.com/repos/sappelhoff/mne-study-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/sappelhoff/mne-study-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/sappelhoff/mne-study-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/sappelhoff/mne-study-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/sappelhoff/mne-study-template/contents/{+path}","compare_url":"https://api.github.com/repos/sappelhoff/mne-study-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sappelhoff/mne-study-template/merges","archive_url":"https://api.github.com/repos/sappelhoff/mne-study-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sappelhoff/mne-study-template/downloads","issues_url":"https://api.github.com/repos/sappelhoff/mne-study-template/issues{/number}","pulls_url":"https://api.github.com/repos/sappelhoff/mne-study-template/pulls{/number}","milestones_url":"https://api.github.com/repos/sappelhoff/mne-study-template/milestones{/number}","notifications_url":"https://api.github.com/repos/sappelhoff/mne-study-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sappelhoff/mne-study-template/labels{/name}","releases_url":"https://api.github.com/repos/sappelhoff/mne-study-template/releases{/id}","deployments_url":"https://api.github.com/repos/sappelhoff/mne-study-template/deployments","created_at":"2019-05-28T15:27:24Z","updated_at":"2019-06-07T08:46:51Z","pushed_at":"2019-07-05T16:14:57Z","git_url":"git://github.com/sappelhoff/mne-study-template.git","ssh_url":"git@github.com:sappelhoff/mne-study-template.git","clone_url":"https://github.com/sappelhoff/mne-study-template.git","svn_url":"https://github.com/sappelhoff/mne-study-template","homepage":"","size":153,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"7f071ae8decea4e5437965a641798263f3fd8aef","user":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":167957354,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc5NTczNTQ=","name":"mne-study-template","full_name":"mne-tools/mne-study-template","private":false,"owner":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mne-tools/mne-study-template","description":"Template for a group study using the MNE Python software","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-study-template","forks_url":"https://api.github.com/repos/mne-tools/mne-study-template/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-study-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-study-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-study-template/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-study-template/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-study-template/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-study-template/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-study-template/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-study-template/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-study-template/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-study-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-study-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-study-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-study-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-study-template/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-study-template/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-study-template/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-study-template/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-study-template/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-study-template/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-study-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-study-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-study-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-study-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-study-template/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-study-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-study-template/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-study-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-study-template/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-study-template/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-study-template/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-study-template/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-study-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-study-template/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-study-template/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-study-template/deployments","created_at":"2019-01-28T12:18:07Z","updated_at":"2019-06-21T14:09:52Z","pushed_at":"2019-07-05T16:14:58Z","git_url":"git://github.com/mne-tools/mne-study-template.git","ssh_url":"git@github.com:mne-tools/mne-study-template.git","clone_url":"https://github.com/mne-tools/mne-study-template.git","svn_url":"https://github.com/mne-tools/mne-study-template","homepage":"","size":155,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":15,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35"},"html":{"href":"https://github.com/mne-tools/mne-study-template/pull/35"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/issues/35"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-study-template/statuses/1e0d49c92d43dacb1e9a96c6ec027029d8011c8f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jasmainak"}}