{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/14662","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/14662/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/14662/comments","events_url":"https://api.github.com/repos/helm/charts/issues/14662/events","html_url":"https://github.com/helm/charts/pull/14662","id":454135192,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NjQ4MzEx","number":14662,"title":"[stable/consul] Fix ingress service name","user":{"login":"phillebaba","id":10550243,"node_id":"MDQ6VXNlcjEwNTUwMjQz","avatar_url":"https://avatars3.githubusercontent.com/u/10550243?v=4","gravatar_id":"","url":"https://api.github.com/users/phillebaba","html_url":"https://github.com/phillebaba","followers_url":"https://api.github.com/users/phillebaba/followers","following_url":"https://api.github.com/users/phillebaba/following{/other_user}","gists_url":"https://api.github.com/users/phillebaba/gists{/gist_id}","starred_url":"https://api.github.com/users/phillebaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillebaba/subscriptions","organizations_url":"https://api.github.com/users/phillebaba/orgs","repos_url":"https://api.github.com/users/phillebaba/repos","events_url":"https://api.github.com/users/phillebaba/events{/privacy}","received_events_url":"https://api.github.com/users/phillebaba/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":764227863,"node_id":"MDU6TGFiZWw3NjQyMjc4NjM=","url":"https://api.github.com/repos/helm/charts/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":352669720,"node_id":"MDU6TGFiZWwzNTI2Njk3MjA=","url":"https://api.github.com/repos/helm/charts/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1120334296,"node_id":"MDU6TGFiZWwxMTIwMzM0Mjk2","url":"https://api.github.com/repos/helm/charts/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false},{"id":676475149,"node_id":"MDU6TGFiZWw2NzY0NzUxNDk=","url":"https://api.github.com/repos/helm/charts/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2019-06-10T11:58:42Z","updated_at":"2019-08-08T17:44:20Z","closed_at":"2019-06-17T21:48:16Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/14662","html_url":"https://github.com/helm/charts/pull/14662","diff_url":"https://github.com/helm/charts/pull/14662.diff","patch_url":"https://github.com/helm/charts/pull/14662.patch"},"body":"This change fixes the service name in the ingress backend configuration.\r\n\r\nThe name of the headless service is set with `\"{{ template \"consul.fullname\" . }}\"` which the the ingress expects the service name to be suffixed with `-ui`, causing the ingress to fail. Removing the suffix will solve the problem.\r\n\r\n#### Checklist\r\n- [x] [DCO](https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work) signed\r\n- [x] Chart Version bumped\r\n- [x] Title of the PR starts with chart name (e.g. `[stable/chart]`)\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/519619378","html_url":"https://github.com/helm/charts/pull/14662#issuecomment-519619378","issue_url":"https://api.github.com/repos/helm/charts/issues/14662","id":519619378,"node_id":"MDEyOklzc3VlQ29tbWVudDUxOTYxOTM3OA==","user":{"login":"phillebaba","id":10550243,"node_id":"MDQ6VXNlcjEwNTUwMjQz","avatar_url":"https://avatars3.githubusercontent.com/u/10550243?v=4","gravatar_id":"","url":"https://api.github.com/users/phillebaba","html_url":"https://github.com/phillebaba","followers_url":"https://api.github.com/users/phillebaba/followers","following_url":"https://api.github.com/users/phillebaba/following{/other_user}","gists_url":"https://api.github.com/users/phillebaba/gists{/gist_id}","starred_url":"https://api.github.com/users/phillebaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillebaba/subscriptions","organizations_url":"https://api.github.com/users/phillebaba/orgs","repos_url":"https://api.github.com/users/phillebaba/repos","events_url":"https://api.github.com/users/phillebaba/events{/privacy}","received_events_url":"https://api.github.com/users/phillebaba/received_events","type":"User","site_admin":false},"created_at":"2019-08-08T17:44:20Z","updated_at":"2019-08-08T17:44:20Z","author_association":"CONTRIBUTOR","body":"It is a bit confusing as there are two different services that can be created in this chart. There is a headless service in `consul-service.yaml` that will expose the UI on the HttpPort that you set in the values file. Then there is a separate service that can be created for the UI only in `ui-service.yaml` with the values in uiService.\r\n\r\nSo if you disable uiService there will still be a service created that the ingress will expose the UI.\r\n\r\nI do not know why the UI service was added in the first place, I think it should be removed unless there is a good reason for it. My guess is that somebody was not using ingress and needed a LoadBalancing service to expose the Consul UI.\r\n\r\nThe change I made basically points towards the headless service instead of the uiService, so things should still work if you are using an ALB with an ingress controller."}}
{"actor":{"display_login":"phillebaba"}}