{"action":"created","comment":{"url":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments/306541515","pull_request_review_id":265687871,"id":306541515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjU0MTUxNQ==","diff_hunk":"@@ -0,0 +1,18 @@\n+import * as models from '../models';\n+import requests from './requests';\n+\n+export class CertificatesService {\n+    public list(): Promise<models.RepoCert[]> {\n+        return requests.get('/certificates').then((res) => res.body as models.RepoCertList).then((list) => list.items || []);\n+    }\n+\n+    public create(certificates: models.RepoCertList): Promise<models.RepoCertList> {\n+        return requests.post('/certificates').send(certificates).then((res) => res.body as models.RepoCertList);\n+    }\n+\n+    public delete(serverName: string, certType: string, certSubType: string): Promise<models.RepoCert> {\n+        return requests.delete(`/certificates?hostNamePattern=${encodeURIComponent(serverName)}` +","path":"ui/src/app/shared/services/cert-service.ts","position":14,"original_position":14,"commit_id":"d38837c1d1bd87e3c00eccbaad8436f89cfb2474","original_commit_id":"fc68cfdd55c578497cae3deed1fd6478708fd537","user":{"login":"alexmt","id":426437,"node_id":"MDQ6VXNlcjQyNjQzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/426437?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmt","html_url":"https://github.com/alexmt","followers_url":"https://api.github.com/users/alexmt/followers","following_url":"https://api.github.com/users/alexmt/following{/other_user}","gists_url":"https://api.github.com/users/alexmt/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmt/subscriptions","organizations_url":"https://api.github.com/users/alexmt/orgs","repos_url":"https://api.github.com/users/alexmt/repos","events_url":"https://api.github.com/users/alexmt/events{/privacy}","received_events_url":"https://api.github.com/users/alexmt/received_events","type":"User","site_admin":false},"body":"I think you can use `requests.delete('/certificates').query({hostNamePattern: serverName...}).send()` instead of constructing URL manually.","created_at":"2019-07-23T21:28:37Z","updated_at":"2019-07-23T21:28:37Z","html_url":"https://github.com/argoproj/argo-cd/pull/1987#discussion_r306541515","pull_request_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments/306541515"},"html":{"href":"https://github.com/argoproj/argo-cd/pull/1987#discussion_r306541515"},"pull_request":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987"}}},"pull_request":{"url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987","id":300430747,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNDMwNzQ3","html_url":"https://github.com/argoproj/argo-cd/pull/1987","diff_url":"https://github.com/argoproj/argo-cd/pull/1987.diff","patch_url":"https://github.com/argoproj/argo-cd/pull/1987.patch","issue_url":"https://api.github.com/repos/argoproj/argo-cd/issues/1987","number":1987,"state":"open","locked":false,"title":"Add UI functionality for certificate management","user":{"login":"jannfis","id":3942683,"node_id":"MDQ6VXNlcjM5NDI2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3942683?v=4","gravatar_id":"","url":"https://api.github.com/users/jannfis","html_url":"https://github.com/jannfis","followers_url":"https://api.github.com/users/jannfis/followers","following_url":"https://api.github.com/users/jannfis/following{/other_user}","gists_url":"https://api.github.com/users/jannfis/gists{/gist_id}","starred_url":"https://api.github.com/users/jannfis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannfis/subscriptions","organizations_url":"https://api.github.com/users/jannfis/orgs","repos_url":"https://api.github.com/users/jannfis/repos","events_url":"https://api.github.com/users/jannfis/events{/privacy}","received_events_url":"https://api.github.com/users/jannfis/received_events","type":"User","site_admin":false},"body":"This PR aims to bring the UI closer to feature parity with the CLI by adding certificate management and addresses feature request #1670 .\r\n\r\nIt adds the ability to list, create and remove TLS certificates and SSH known hosts data via the UI.\r\n\r\nNote: The \"Certificate Info\" field in the certificate list - which should contain either SSH public key fingerprint or TLS certificate CN field - is left blank for now, since the server does not generate it yet. Right now the CLI has it, but generates it itself. This will be addressed by a separate PR in the future.","created_at":"2019-07-23T19:05:46Z","updated_at":"2019-07-23T21:28:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"326c3d4957ce630e7d88cb960701ac183a131af0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987/commits","review_comments_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987/comments","review_comment_url":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/argoproj/argo-cd/issues/1987/comments","statuses_url":"https://api.github.com/repos/argoproj/argo-cd/statuses/d38837c1d1bd87e3c00eccbaad8436f89cfb2474","head":{"label":"jannfis:1670-ui-cert-management","ref":"1670-ui-cert-management","sha":"d38837c1d1bd87e3c00eccbaad8436f89cfb2474","user":{"login":"jannfis","id":3942683,"node_id":"MDQ6VXNlcjM5NDI2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3942683?v=4","gravatar_id":"","url":"https://api.github.com/users/jannfis","html_url":"https://github.com/jannfis","followers_url":"https://api.github.com/users/jannfis/followers","following_url":"https://api.github.com/users/jannfis/following{/other_user}","gists_url":"https://api.github.com/users/jannfis/gists{/gist_id}","starred_url":"https://api.github.com/users/jannfis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannfis/subscriptions","organizations_url":"https://api.github.com/users/jannfis/orgs","repos_url":"https://api.github.com/users/jannfis/repos","events_url":"https://api.github.com/users/jannfis/events{/privacy}","received_events_url":"https://api.github.com/users/jannfis/received_events","type":"User","site_admin":false},"repo":{"id":186040800,"node_id":"MDEwOlJlcG9zaXRvcnkxODYwNDA4MDA=","name":"argo-cd","full_name":"jannfis/argo-cd","private":false,"owner":{"login":"jannfis","id":3942683,"node_id":"MDQ6VXNlcjM5NDI2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3942683?v=4","gravatar_id":"","url":"https://api.github.com/users/jannfis","html_url":"https://github.com/jannfis","followers_url":"https://api.github.com/users/jannfis/followers","following_url":"https://api.github.com/users/jannfis/following{/other_user}","gists_url":"https://api.github.com/users/jannfis/gists{/gist_id}","starred_url":"https://api.github.com/users/jannfis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannfis/subscriptions","organizations_url":"https://api.github.com/users/jannfis/orgs","repos_url":"https://api.github.com/users/jannfis/repos","events_url":"https://api.github.com/users/jannfis/events{/privacy}","received_events_url":"https://api.github.com/users/jannfis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jannfis/argo-cd","description":"Declarative continuous deployment for Kubernetes.","fork":true,"url":"https://api.github.com/repos/jannfis/argo-cd","forks_url":"https://api.github.com/repos/jannfis/argo-cd/forks","keys_url":"https://api.github.com/repos/jannfis/argo-cd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jannfis/argo-cd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jannfis/argo-cd/teams","hooks_url":"https://api.github.com/repos/jannfis/argo-cd/hooks","issue_events_url":"https://api.github.com/repos/jannfis/argo-cd/issues/events{/number}","events_url":"https://api.github.com/repos/jannfis/argo-cd/events","assignees_url":"https://api.github.com/repos/jannfis/argo-cd/assignees{/user}","branches_url":"https://api.github.com/repos/jannfis/argo-cd/branches{/branch}","tags_url":"https://api.github.com/repos/jannfis/argo-cd/tags","blobs_url":"https://api.github.com/repos/jannfis/argo-cd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jannfis/argo-cd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jannfis/argo-cd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jannfis/argo-cd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jannfis/argo-cd/statuses/{sha}","languages_url":"https://api.github.com/repos/jannfis/argo-cd/languages","stargazers_url":"https://api.github.com/repos/jannfis/argo-cd/stargazers","contributors_url":"https://api.github.com/repos/jannfis/argo-cd/contributors","subscribers_url":"https://api.github.com/repos/jannfis/argo-cd/subscribers","subscription_url":"https://api.github.com/repos/jannfis/argo-cd/subscription","commits_url":"https://api.github.com/repos/jannfis/argo-cd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jannfis/argo-cd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jannfis/argo-cd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jannfis/argo-cd/issues/comments{/number}","contents_url":"https://api.github.com/repos/jannfis/argo-cd/contents/{+path}","compare_url":"https://api.github.com/repos/jannfis/argo-cd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jannfis/argo-cd/merges","archive_url":"https://api.github.com/repos/jannfis/argo-cd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jannfis/argo-cd/downloads","issues_url":"https://api.github.com/repos/jannfis/argo-cd/issues{/number}","pulls_url":"https://api.github.com/repos/jannfis/argo-cd/pulls{/number}","milestones_url":"https://api.github.com/repos/jannfis/argo-cd/milestones{/number}","notifications_url":"https://api.github.com/repos/jannfis/argo-cd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jannfis/argo-cd/labels{/name}","releases_url":"https://api.github.com/repos/jannfis/argo-cd/releases{/id}","deployments_url":"https://api.github.com/repos/jannfis/argo-cd/deployments","created_at":"2019-05-10T19:04:01Z","updated_at":"2019-07-18T20:02:37Z","pushed_at":"2019-07-23T20:11:38Z","git_url":"git://github.com/jannfis/argo-cd.git","ssh_url":"git@github.com:jannfis/argo-cd.git","clone_url":"https://github.com/jannfis/argo-cd.git","svn_url":"https://github.com/jannfis/argo-cd","homepage":"https://argoproj.github.io/argo-cd/","size":16185,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"argoproj:master","ref":"master","sha":"6956dcb6dcca1fd0f8c522b8c7179c05ad149375","user":{"login":"argoproj","id":30269780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY5Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"repo":{"id":120896210,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA4OTYyMTA=","name":"argo-cd","full_name":"argoproj/argo-cd","private":false,"owner":{"login":"argoproj","id":30269780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMjY5Nzgw","avatar_url":"https://avatars3.githubusercontent.com/u/30269780?v=4","gravatar_id":"","url":"https://api.github.com/users/argoproj","html_url":"https://github.com/argoproj","followers_url":"https://api.github.com/users/argoproj/followers","following_url":"https://api.github.com/users/argoproj/following{/other_user}","gists_url":"https://api.github.com/users/argoproj/gists{/gist_id}","starred_url":"https://api.github.com/users/argoproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argoproj/subscriptions","organizations_url":"https://api.github.com/users/argoproj/orgs","repos_url":"https://api.github.com/users/argoproj/repos","events_url":"https://api.github.com/users/argoproj/events{/privacy}","received_events_url":"https://api.github.com/users/argoproj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/argoproj/argo-cd","description":"Declarative continuous deployment for Kubernetes.","fork":false,"url":"https://api.github.com/repos/argoproj/argo-cd","forks_url":"https://api.github.com/repos/argoproj/argo-cd/forks","keys_url":"https://api.github.com/repos/argoproj/argo-cd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/argoproj/argo-cd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/argoproj/argo-cd/teams","hooks_url":"https://api.github.com/repos/argoproj/argo-cd/hooks","issue_events_url":"https://api.github.com/repos/argoproj/argo-cd/issues/events{/number}","events_url":"https://api.github.com/repos/argoproj/argo-cd/events","assignees_url":"https://api.github.com/repos/argoproj/argo-cd/assignees{/user}","branches_url":"https://api.github.com/repos/argoproj/argo-cd/branches{/branch}","tags_url":"https://api.github.com/repos/argoproj/argo-cd/tags","blobs_url":"https://api.github.com/repos/argoproj/argo-cd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/argoproj/argo-cd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/argoproj/argo-cd/git/refs{/sha}","trees_url":"https://api.github.com/repos/argoproj/argo-cd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/argoproj/argo-cd/statuses/{sha}","languages_url":"https://api.github.com/repos/argoproj/argo-cd/languages","stargazers_url":"https://api.github.com/repos/argoproj/argo-cd/stargazers","contributors_url":"https://api.github.com/repos/argoproj/argo-cd/contributors","subscribers_url":"https://api.github.com/repos/argoproj/argo-cd/subscribers","subscription_url":"https://api.github.com/repos/argoproj/argo-cd/subscription","commits_url":"https://api.github.com/repos/argoproj/argo-cd/commits{/sha}","git_commits_url":"https://api.github.com/repos/argoproj/argo-cd/git/commits{/sha}","comments_url":"https://api.github.com/repos/argoproj/argo-cd/comments{/number}","issue_comment_url":"https://api.github.com/repos/argoproj/argo-cd/issues/comments{/number}","contents_url":"https://api.github.com/repos/argoproj/argo-cd/contents/{+path}","compare_url":"https://api.github.com/repos/argoproj/argo-cd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/argoproj/argo-cd/merges","archive_url":"https://api.github.com/repos/argoproj/argo-cd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/argoproj/argo-cd/downloads","issues_url":"https://api.github.com/repos/argoproj/argo-cd/issues{/number}","pulls_url":"https://api.github.com/repos/argoproj/argo-cd/pulls{/number}","milestones_url":"https://api.github.com/repos/argoproj/argo-cd/milestones{/number}","notifications_url":"https://api.github.com/repos/argoproj/argo-cd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/argoproj/argo-cd/labels{/name}","releases_url":"https://api.github.com/repos/argoproj/argo-cd/releases{/id}","deployments_url":"https://api.github.com/repos/argoproj/argo-cd/deployments","created_at":"2018-02-09T11:12:01Z","updated_at":"2019-07-23T21:16:41Z","pushed_at":"2019-07-23T21:16:37Z","git_url":"git://github.com/argoproj/argo-cd.git","ssh_url":"git@github.com:argoproj/argo-cd.git","clone_url":"https://github.com/argoproj/argo-cd.git","svn_url":"https://github.com/argoproj/argo-cd","homepage":"https://argoproj.github.io/argo-cd/","size":16051,"stargazers_count":1414,"watchers_count":1414,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":219,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":219,"open_issues":134,"watchers":1414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987"},"html":{"href":"https://github.com/argoproj/argo-cd/pull/1987"},"issue":{"href":"https://api.github.com/repos/argoproj/argo-cd/issues/1987"},"comments":{"href":"https://api.github.com/repos/argoproj/argo-cd/issues/1987/comments"},"review_comments":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987/comments"},"review_comment":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/argoproj/argo-cd/pulls/1987/commits"},"statuses":{"href":"https://api.github.com/repos/argoproj/argo-cd/statuses/d38837c1d1bd87e3c00eccbaad8436f89cfb2474"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alexmt"}}