{"action":"created","issue":{"url":"https://api.github.com/repos/sandreas/m4b-tool/issues/30","repository_url":"https://api.github.com/repos/sandreas/m4b-tool","labels_url":"https://api.github.com/repos/sandreas/m4b-tool/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/sandreas/m4b-tool/issues/30/comments","events_url":"https://api.github.com/repos/sandreas/m4b-tool/issues/30/events","html_url":"https://github.com/sandreas/m4b-tool/issues/30","id":427927017,"node_id":"MDU6SXNzdWU0Mjc5MjcwMTc=","number":30,"title":"Metadata not written to mp3 files","user":{"login":"gubler","id":3446,"node_id":"MDQ6VXNlcjM0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3446?v=4","gravatar_id":"","url":"https://api.github.com/users/gubler","html_url":"https://github.com/gubler","followers_url":"https://api.github.com/users/gubler/followers","following_url":"https://api.github.com/users/gubler/following{/other_user}","gists_url":"https://api.github.com/users/gubler/gists{/gist_id}","starred_url":"https://api.github.com/users/gubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gubler/subscriptions","organizations_url":"https://api.github.com/users/gubler/orgs","repos_url":"https://api.github.com/users/gubler/repos","events_url":"https://api.github.com/users/gubler/events{/privacy}","received_events_url":"https://api.github.com/users/gubler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-04-01T21:47:57Z","updated_at":"2019-04-02T14:54:58Z","closed_at":null,"author_association":"NONE","body":"I understand that the primary output for m4b-tool is m4b files, but the `merge` command does support mp3 output. When I try to merge a directory of already tagged mp3 files into a single mp3 file with chapters, I end up with an mp3 file with no tags (not even Artist, title, cover, etc.).\r\n\r\nI have tried several variations, including defining output format, codec, `--no-convert`, `--mark-chapters`, etc. It appears that the tagging step is just skipped if the output format is mp3. I did a test build of a m4b file and it was properly tagged and chaptered.\r\n\r\nIf this tool doesn't support tagging output mp3s, I can completely understand, I just wanted to confirm I was not missing something."},"comment":{"url":"https://api.github.com/repos/sandreas/m4b-tool/issues/comments/479034891","html_url":"https://github.com/sandreas/m4b-tool/issues/30#issuecomment-479034891","issue_url":"https://api.github.com/repos/sandreas/m4b-tool/issues/30","id":479034891,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3OTAzNDg5MQ==","user":{"login":"gubler","id":3446,"node_id":"MDQ6VXNlcjM0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3446?v=4","gravatar_id":"","url":"https://api.github.com/users/gubler","html_url":"https://github.com/gubler","followers_url":"https://api.github.com/users/gubler/followers","following_url":"https://api.github.com/users/gubler/following{/other_user}","gists_url":"https://api.github.com/users/gubler/gists{/gist_id}","starred_url":"https://api.github.com/users/gubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gubler/subscriptions","organizations_url":"https://api.github.com/users/gubler/orgs","repos_url":"https://api.github.com/users/gubler/repos","events_url":"https://api.github.com/users/gubler/events{/privacy}","received_events_url":"https://api.github.com/users/gubler/received_events","type":"User","site_admin":false},"created_at":"2019-04-02T14:54:58Z","updated_at":"2019-04-02T14:54:58Z","author_association":"NONE","body":"It looks like you can add chapters using ffmpeg directly, but I can only find [an example using a metadata file](https://medium.com/@dathanbennett/adding-chapters-to-an-mp4-file-using-ffmpeg-5e43df269687) and from what I can see in your code, you are writing all of the metadata via command line arguments (according to `AbstractConversionCommand`. The linked article references an mp4 file, but I dumped the metadata from a podcast episode with chapters and got a similar format (I have attached the metadata file).\r\n\r\n[metadata.txt](https://github.com/sandreas/m4b-tool/files/3034496/metadata.txt)\r\n\r\nI guess if the output file was an mp3 you could dump the metadata to a file (along with any chapter information) and then add the proper command line arguments to import it. I understand that would be a pain to do, however.\r\n\r\nI've forked the repo and if you don't get to it before I do, I'll see if I can figure out how to do that myself. However, it will be a month or more before I can really dig into the code (April is a very busy month for me).\r\n\r\nThanks for the awesome tool!"}}
{"actor":{"display_login":"gubler"}}