{"action":"opened","number":76,"pull_request":{"url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/76","id":300540608,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNTQwNjA4","html_url":"https://github.com/ChrisAdderley/KerbalAtomics/pull/76","diff_url":"https://github.com/ChrisAdderley/KerbalAtomics/pull/76.diff","patch_url":"https://github.com/ChrisAdderley/KerbalAtomics/pull/76.patch","issue_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues/76","number":76,"state":"open","locked":false,"title":"Fix LH2NTR MissingHistory patch interaction with RealPlume","user":{"login":"Wyzard256","id":23350503,"node_id":"MDQ6VXNlcjIzMzUwNTAz","avatar_url":"https://avatars1.githubusercontent.com/u/23350503?v=4","gravatar_id":"","url":"https://api.github.com/users/Wyzard256","html_url":"https://github.com/Wyzard256","followers_url":"https://api.github.com/users/Wyzard256/followers","following_url":"https://api.github.com/users/Wyzard256/following{/other_user}","gists_url":"https://api.github.com/users/Wyzard256/gists{/gist_id}","starred_url":"https://api.github.com/users/Wyzard256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wyzard256/subscriptions","organizations_url":"https://api.github.com/users/Wyzard256/orgs","repos_url":"https://api.github.com/users/Wyzard256/repos","events_url":"https://api.github.com/users/Wyzard256/events{/privacy}","received_events_url":"https://api.github.com/users/Wyzard256/received_events","type":"User","site_admin":false},"body":"The LH2NTR \"extra\" patch for two MissingHistory engines works by deleting the single-mode LF engine module and replacing it with a multi-mode LF/LH2 configuration.  As part of that, it needs to clone the engine's single effect definition to make two identical effects, since KSP doesn't correctly handle two engine modules sharing the same effect. \r\n\r\nWhen RealPlume is installed, it runs beforehand and deletes the \"running_closed\" effect, which breaks the LH2NTR patch that expects to copy from that effect.  To get the right result, the LH2NTR patch has to be aware of RealPlume's changes and copy from its replacement effect instead.\r\n\r\nOther LH2NTR patches (besides the MissingHistory one) don't need this treatment.  The only other one that clones effects is the one for the LV-2N and LV-4N cluster engines, and it locally defines the same effects that it later clones, so they always exist.\r\n\r\nFixes: #74 ","created_at":"2019-07-24T02:55:44Z","updated_at":"2019-07-24T02:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/76/commits","review_comments_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/76/comments","review_comment_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues/76/comments","statuses_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/statuses/195e2a0c6259e2e630163b3dcfca836059225d9f","head":{"label":"Wyzard256:fix-lh2ntr-realplume","ref":"fix-lh2ntr-realplume","sha":"195e2a0c6259e2e630163b3dcfca836059225d9f","user":{"login":"Wyzard256","id":23350503,"node_id":"MDQ6VXNlcjIzMzUwNTAz","avatar_url":"https://avatars1.githubusercontent.com/u/23350503?v=4","gravatar_id":"","url":"https://api.github.com/users/Wyzard256","html_url":"https://github.com/Wyzard256","followers_url":"https://api.github.com/users/Wyzard256/followers","following_url":"https://api.github.com/users/Wyzard256/following{/other_user}","gists_url":"https://api.github.com/users/Wyzard256/gists{/gist_id}","starred_url":"https://api.github.com/users/Wyzard256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wyzard256/subscriptions","organizations_url":"https://api.github.com/users/Wyzard256/orgs","repos_url":"https://api.github.com/users/Wyzard256/repos","events_url":"https://api.github.com/users/Wyzard256/events{/privacy}","received_events_url":"https://api.github.com/users/Wyzard256/received_events","type":"User","site_admin":false},"repo":{"id":109781458,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3ODE0NTg=","name":"KerbalAtomics","full_name":"Wyzard256/KerbalAtomics","private":false,"owner":{"login":"Wyzard256","id":23350503,"node_id":"MDQ6VXNlcjIzMzUwNTAz","avatar_url":"https://avatars1.githubusercontent.com/u/23350503?v=4","gravatar_id":"","url":"https://api.github.com/users/Wyzard256","html_url":"https://github.com/Wyzard256","followers_url":"https://api.github.com/users/Wyzard256/followers","following_url":"https://api.github.com/users/Wyzard256/following{/other_user}","gists_url":"https://api.github.com/users/Wyzard256/gists{/gist_id}","starred_url":"https://api.github.com/users/Wyzard256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wyzard256/subscriptions","organizations_url":"https://api.github.com/users/Wyzard256/orgs","repos_url":"https://api.github.com/users/Wyzard256/repos","events_url":"https://api.github.com/users/Wyzard256/events{/privacy}","received_events_url":"https://api.github.com/users/Wyzard256/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Wyzard256/KerbalAtomics","description":"Nuclear propulsion systems for Kerbal Space Program","fork":true,"url":"https://api.github.com/repos/Wyzard256/KerbalAtomics","forks_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/forks","keys_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/teams","hooks_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/hooks","issue_events_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/issues/events{/number}","events_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/events","assignees_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/assignees{/user}","branches_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/branches{/branch}","tags_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/tags","blobs_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/statuses/{sha}","languages_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/languages","stargazers_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/stargazers","contributors_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/contributors","subscribers_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/subscribers","subscription_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/subscription","commits_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/contents/{+path}","compare_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/merges","archive_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/downloads","issues_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/issues{/number}","pulls_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/pulls{/number}","milestones_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/milestones{/number}","notifications_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/labels{/name}","releases_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/releases{/id}","deployments_url":"https://api.github.com/repos/Wyzard256/KerbalAtomics/deployments","created_at":"2017-11-07T03:20:24Z","updated_at":"2018-04-03T06:25:32Z","pushed_at":"2019-07-24T02:51:02Z","git_url":"git://github.com/Wyzard256/KerbalAtomics.git","ssh_url":"git@github.com:Wyzard256/KerbalAtomics.git","clone_url":"https://github.com/Wyzard256/KerbalAtomics.git","svn_url":"https://github.com/Wyzard256/KerbalAtomics","homepage":"","size":59565,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ChrisAdderley:dev","ref":"dev","sha":"60b745c5547b96eea1787c5d2a9982d68cd77141","user":{"login":"ChrisAdderley","id":5642064,"node_id":"MDQ6VXNlcjU2NDIwNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5642064?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisAdderley","html_url":"https://github.com/ChrisAdderley","followers_url":"https://api.github.com/users/ChrisAdderley/followers","following_url":"https://api.github.com/users/ChrisAdderley/following{/other_user}","gists_url":"https://api.github.com/users/ChrisAdderley/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisAdderley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisAdderley/subscriptions","organizations_url":"https://api.github.com/users/ChrisAdderley/orgs","repos_url":"https://api.github.com/users/ChrisAdderley/repos","events_url":"https://api.github.com/users/ChrisAdderley/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisAdderley/received_events","type":"User","site_admin":false},"repo":{"id":49013629,"node_id":"MDEwOlJlcG9zaXRvcnk0OTAxMzYyOQ==","name":"KerbalAtomics","full_name":"ChrisAdderley/KerbalAtomics","private":false,"owner":{"login":"ChrisAdderley","id":5642064,"node_id":"MDQ6VXNlcjU2NDIwNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5642064?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisAdderley","html_url":"https://github.com/ChrisAdderley","followers_url":"https://api.github.com/users/ChrisAdderley/followers","following_url":"https://api.github.com/users/ChrisAdderley/following{/other_user}","gists_url":"https://api.github.com/users/ChrisAdderley/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisAdderley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisAdderley/subscriptions","organizations_url":"https://api.github.com/users/ChrisAdderley/orgs","repos_url":"https://api.github.com/users/ChrisAdderley/repos","events_url":"https://api.github.com/users/ChrisAdderley/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisAdderley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ChrisAdderley/KerbalAtomics","description":"Nuclear thermal propulsion systems for Kerbal Space Program","fork":false,"url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics","forks_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/forks","keys_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/teams","hooks_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/hooks","issue_events_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/events","assignees_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/tags","blobs_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/languages","stargazers_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/stargazers","contributors_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/contributors","subscribers_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/subscribers","subscription_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/subscription","commits_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/merges","archive_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/downloads","issues_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/labels{/name}","releases_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/releases{/id}","deployments_url":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/deployments","created_at":"2016-01-04T17:58:56Z","updated_at":"2019-07-09T21:16:37Z","pushed_at":"2019-07-09T21:18:08Z","git_url":"git://github.com/ChrisAdderley/KerbalAtomics.git","ssh_url":"git@github.com:ChrisAdderley/KerbalAtomics.git","clone_url":"https://github.com/ChrisAdderley/KerbalAtomics.git","svn_url":"https://github.com/ChrisAdderley/KerbalAtomics","homepage":"","size":123953,"stargazers_count":8,"watchers_count":8,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":13,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/76"},"html":{"href":"https://github.com/ChrisAdderley/KerbalAtomics/pull/76"},"issue":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues/76"},"comments":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/ChrisAdderley/KerbalAtomics/statuses/195e2a0c6259e2e630163b3dcfca836059225d9f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":35,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Wyzard256"}}