{"action":"created","issue":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/1192","repository_url":"https://api.github.com/repos/ElucidataInc/ElMaven","labels_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/1192/labels{/name}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/1192/comments","events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/1192/events","html_url":"https://github.com/ElucidataInc/ElMaven/pull/1192","id":541642332,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2MjM0Nzkw","number":1192,"title":"[Fix] Missing mz-intensity pairs from scans","user":{"login":"saifulbkhan","id":10397162,"node_id":"MDQ6VXNlcjEwMzk3MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/10397162?v=4","gravatar_id":"","url":"https://api.github.com/users/saifulbkhan","html_url":"https://github.com/saifulbkhan","followers_url":"https://api.github.com/users/saifulbkhan/followers","following_url":"https://api.github.com/users/saifulbkhan/following{/other_user}","gists_url":"https://api.github.com/users/saifulbkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/saifulbkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saifulbkhan/subscriptions","organizations_url":"https://api.github.com/users/saifulbkhan/orgs","repos_url":"https://api.github.com/users/saifulbkhan/repos","events_url":"https://api.github.com/users/saifulbkhan/events{/privacy}","received_events_url":"https://api.github.com/users/saifulbkhan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"shubhra-agrawal","id":28925846,"node_id":"MDQ6VXNlcjI4OTI1ODQ2","avatar_url":"https://avatars3.githubusercontent.com/u/28925846?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhra-agrawal","html_url":"https://github.com/shubhra-agrawal","followers_url":"https://api.github.com/users/shubhra-agrawal/followers","following_url":"https://api.github.com/users/shubhra-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/shubhra-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhra-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhra-agrawal/subscriptions","organizations_url":"https://api.github.com/users/shubhra-agrawal/orgs","repos_url":"https://api.github.com/users/shubhra-agrawal/repos","events_url":"https://api.github.com/users/shubhra-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/shubhra-agrawal/received_events","type":"User","site_admin":false},"assignees":[{"login":"shubhra-agrawal","id":28925846,"node_id":"MDQ6VXNlcjI4OTI1ODQ2","avatar_url":"https://avatars3.githubusercontent.com/u/28925846?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhra-agrawal","html_url":"https://github.com/shubhra-agrawal","followers_url":"https://api.github.com/users/shubhra-agrawal/followers","following_url":"https://api.github.com/users/shubhra-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/shubhra-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhra-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhra-agrawal/subscriptions","organizations_url":"https://api.github.com/users/shubhra-agrawal/orgs","repos_url":"https://api.github.com/users/shubhra-agrawal/repos","events_url":"https://api.github.com/users/shubhra-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/shubhra-agrawal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-12-23T08:29:17Z","updated_at":"2019-12-23T11:53:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/1192","html_url":"https://github.com/ElucidataInc/ElMaven/pull/1192","diff_url":"https://github.com/ElucidataInc/ElMaven/pull/1192.diff","patch_url":"https://github.com/ElucidataInc/ElMaven/pull/1192.patch"},"body":"While iterating over an mz-intensity pair vector (obtained from parsing mzXML spectra strings), we populate Scan::mz and Scan::intensity vectors in the exact same indexes as recorded in a scan. But some zero values could be present in-between two non-zero pairs, and when the mz and intensity vectors are resized to the non-zero count value, these zero pairs might end up staying while non-zero pairs are the end of the vectors are cleaved."},"comment":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/comments/568454817","html_url":"https://github.com/ElucidataInc/ElMaven/pull/1192#issuecomment-568454817","issue_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/1192","id":568454817,"node_id":"MDEyOklzc3VlQ29tbWVudDU2ODQ1NDgxNw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2019-12-23T11:53:32Z","updated_at":"2019-12-23T11:53:32Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192?src=pr&el=h1) Report\n> Merging [#1192](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192?src=pr&el=desc) into [develop](https://codecov.io/gh/ElucidataInc/ElMaven/commit/a608534a6cc97be0a1990d5635b4716f6a58c5f1?src=pr&el=desc) will **increase** coverage by `1.21%`.\n> The diff coverage is `100%`.\n\n```diff\n@@            Coverage Diff             @@\n##           develop   #1192      +/-   ##\n==========================================\n+ Coverage    45.59%   46.8%   +1.21%     \n==========================================\n  Files           55      55              \n  Lines         9054    8962      -92     \n==========================================\n+ Hits          4128    4195      +67     \n+ Misses        4926    4767     -159\n```\n\n| [Impacted Files](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/core/libmaven/mzSample.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vbXpTYW1wbGUuY3Bw) | `49.39% <100%> (+6.51%)` | :arrow_up: |\n| [src/core/libmaven/datastructures/mzSlice.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vZGF0YXN0cnVjdHVyZXMvbXpTbGljZS5jcHA=) | `86.11% <0%> (-8.89%)` | :arrow_down: |\n| [src/core/libmaven/PeakDetector.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vUGVha0RldGVjdG9yLmNwcA==) | `55.78% <0%> (-7.05%)` | :arrow_down: |\n| [src/core/libmaven/csvreports.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vY3N2cmVwb3J0cy5jcHA=) | `67.86% <0%> (-5.73%)` | :arrow_down: |\n| [src/core/libmaven/Compound.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vQ29tcG91bmQuY3Bw) | `30% <0%> (-3.34%)` | :arrow_down: |\n| [src/core/libmaven/mzSample.h](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vbXpTYW1wbGUuaA==) | `68.33% <0%> (-1.16%)` | :arrow_down: |\n| [src/core/libmaven/PeakGroup.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vUGVha0dyb3VwLmNwcA==) | `67.33% <0%> (-0.69%)` | :arrow_down: |\n| [src/core/libmaven/mzUtils.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vbXpVdGlscy5jcHA=) | `44.42% <0%> (-0.41%)` | :arrow_down: |\n| [src/core/libmaven/base64.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vYmFzZTY0LmNwcA==) | `82.6% <0%> (-0.38%)` | :arrow_down: |\n| [src/core/libmaven/groupFiltering.cpp](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree#diff-c3JjL2NvcmUvbGlibWF2ZW4vZ3JvdXBGaWx0ZXJpbmcuY3Bw) | `74.46% <0%> (-0.27%)` | :arrow_down: |\n| ... and [15 more](https://codecov.io/gh/ElucidataInc/ElMaven/pull/1192/diff?src=pr&el=tree-more) | |\n"}}
{"actor":{"display_login":"codecov-io"}}