{"action":"created","comment":{"url":"https://api.github.com/repos/google/gvisor/pulls/comments/312289996","pull_request_review_id":272895082,"id":312289996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjI4OTk5Ng==","diff_hunk":"@@ -227,6 +243,7 @@ func (c *Config) ToFlags() []string {\n \t\t\"--num-network-channels=\" + strconv.Itoa(c.NumNetworkChannels),\n \t\t\"--rootless=\" + strconv.FormatBool(c.Rootless),\n \t\t\"--alsologtostderr=\" + strconv.FormatBool(c.AlsoLogToStderr),\n+\t\t\"--ref-leak-mode=\" + c.ReferenceLeakMode.String(),","path":"runsc/boot/config.go","position":41,"original_position":41,"commit_id":"8d89c0d92b3839eed0839b1a9bc7666e6261d972","original_commit_id":"8d89c0d92b3839eed0839b1a9bc7666e6261d972","user":{"login":"ianlewis","id":49289,"node_id":"MDQ6VXNlcjQ5Mjg5","avatar_url":"https://avatars0.githubusercontent.com/u/49289?v=4","gravatar_id":"","url":"https://api.github.com/users/ianlewis","html_url":"https://github.com/ianlewis","followers_url":"https://api.github.com/users/ianlewis/followers","following_url":"https://api.github.com/users/ianlewis/following{/other_user}","gists_url":"https://api.github.com/users/ianlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/ianlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianlewis/subscriptions","organizations_url":"https://api.github.com/users/ianlewis/orgs","repos_url":"https://api.github.com/users/ianlewis/repos","events_url":"https://api.github.com/users/ianlewis/events{/privacy}","received_events_url":"https://api.github.com/users/ianlewis/received_events","type":"User","site_admin":false},"body":"Are the camel case strings used anywhere other than here? I feel like the Stringer returning \"disabled\", \"warning\" etc. is ok but it's not a big deal either way.","created_at":"2019-08-09T00:07:33Z","updated_at":"2019-08-09T00:09:20Z","html_url":"https://github.com/google/gvisor/pull/655#discussion_r312289996","pull_request_url":"https://api.github.com/repos/google/gvisor/pulls/655","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/gvisor/pulls/comments/312289996"},"html":{"href":"https://github.com/google/gvisor/pull/655#discussion_r312289996"},"pull_request":{"href":"https://api.github.com/repos/google/gvisor/pulls/655"}},"in_reply_to_id":311188480},"pull_request":{"url":"https://api.github.com/repos/google/gvisor/pulls/655","id":304350084,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0MzUwMDg0","html_url":"https://github.com/google/gvisor/pull/655","diff_url":"https://github.com/google/gvisor/pull/655.diff","patch_url":"https://github.com/google/gvisor/pull/655.patch","issue_url":"https://api.github.com/repos/google/gvisor/issues/655","number":655,"state":"open","locked":false,"title":"Add option to configure reference leak checking","user":{"login":"praveensastry","id":501335,"node_id":"MDQ6VXNlcjUwMTMzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/501335?v=4","gravatar_id":"","url":"https://api.github.com/users/praveensastry","html_url":"https://github.com/praveensastry","followers_url":"https://api.github.com/users/praveensastry/followers","following_url":"https://api.github.com/users/praveensastry/following{/other_user}","gists_url":"https://api.github.com/users/praveensastry/gists{/gist_id}","starred_url":"https://api.github.com/users/praveensastry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveensastry/subscriptions","organizations_url":"https://api.github.com/users/praveensastry/orgs","repos_url":"https://api.github.com/users/praveensastry/repos","events_url":"https://api.github.com/users/praveensastry/events{/privacy}","received_events_url":"https://api.github.com/users/praveensastry/received_events","type":"User","site_admin":false},"body":"Closes #365 ","created_at":"2019-08-05T15:20:17Z","updated_at":"2019-08-09T00:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"515da812e2e8105b7e4f5cb616d12a30f0a06ee2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1156870994,"node_id":"MDU6TGFiZWwxMTU2ODcwOTk0","url":"https://api.github.com/repos/google/gvisor/labels/cla:%20yes","name":"cla: yes","color":"6079c9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/gvisor/pulls/655/commits","review_comments_url":"https://api.github.com/repos/google/gvisor/pulls/655/comments","review_comment_url":"https://api.github.com/repos/google/gvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/gvisor/issues/655/comments","statuses_url":"https://api.github.com/repos/google/gvisor/statuses/8d89c0d92b3839eed0839b1a9bc7666e6261d972","head":{"label":"praveensastry:feature/runsc-ref-chk-leak","ref":"feature/runsc-ref-chk-leak","sha":"8d89c0d92b3839eed0839b1a9bc7666e6261d972","user":{"login":"praveensastry","id":501335,"node_id":"MDQ6VXNlcjUwMTMzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/501335?v=4","gravatar_id":"","url":"https://api.github.com/users/praveensastry","html_url":"https://github.com/praveensastry","followers_url":"https://api.github.com/users/praveensastry/followers","following_url":"https://api.github.com/users/praveensastry/following{/other_user}","gists_url":"https://api.github.com/users/praveensastry/gists{/gist_id}","starred_url":"https://api.github.com/users/praveensastry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveensastry/subscriptions","organizations_url":"https://api.github.com/users/praveensastry/orgs","repos_url":"https://api.github.com/users/praveensastry/repos","events_url":"https://api.github.com/users/praveensastry/events{/privacy}","received_events_url":"https://api.github.com/users/praveensastry/received_events","type":"User","site_admin":false},"repo":{"id":199542611,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk1NDI2MTE=","name":"gvisor","full_name":"praveensastry/gvisor","private":false,"owner":{"login":"praveensastry","id":501335,"node_id":"MDQ6VXNlcjUwMTMzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/501335?v=4","gravatar_id":"","url":"https://api.github.com/users/praveensastry","html_url":"https://github.com/praveensastry","followers_url":"https://api.github.com/users/praveensastry/followers","following_url":"https://api.github.com/users/praveensastry/following{/other_user}","gists_url":"https://api.github.com/users/praveensastry/gists{/gist_id}","starred_url":"https://api.github.com/users/praveensastry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveensastry/subscriptions","organizations_url":"https://api.github.com/users/praveensastry/orgs","repos_url":"https://api.github.com/users/praveensastry/repos","events_url":"https://api.github.com/users/praveensastry/events{/privacy}","received_events_url":"https://api.github.com/users/praveensastry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/praveensastry/gvisor","description":"Container Runtime Sandbox","fork":true,"url":"https://api.github.com/repos/praveensastry/gvisor","forks_url":"https://api.github.com/repos/praveensastry/gvisor/forks","keys_url":"https://api.github.com/repos/praveensastry/gvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praveensastry/gvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praveensastry/gvisor/teams","hooks_url":"https://api.github.com/repos/praveensastry/gvisor/hooks","issue_events_url":"https://api.github.com/repos/praveensastry/gvisor/issues/events{/number}","events_url":"https://api.github.com/repos/praveensastry/gvisor/events","assignees_url":"https://api.github.com/repos/praveensastry/gvisor/assignees{/user}","branches_url":"https://api.github.com/repos/praveensastry/gvisor/branches{/branch}","tags_url":"https://api.github.com/repos/praveensastry/gvisor/tags","blobs_url":"https://api.github.com/repos/praveensastry/gvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praveensastry/gvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praveensastry/gvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/praveensastry/gvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praveensastry/gvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/praveensastry/gvisor/languages","stargazers_url":"https://api.github.com/repos/praveensastry/gvisor/stargazers","contributors_url":"https://api.github.com/repos/praveensastry/gvisor/contributors","subscribers_url":"https://api.github.com/repos/praveensastry/gvisor/subscribers","subscription_url":"https://api.github.com/repos/praveensastry/gvisor/subscription","commits_url":"https://api.github.com/repos/praveensastry/gvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/praveensastry/gvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/praveensastry/gvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/praveensastry/gvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/praveensastry/gvisor/contents/{+path}","compare_url":"https://api.github.com/repos/praveensastry/gvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praveensastry/gvisor/merges","archive_url":"https://api.github.com/repos/praveensastry/gvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praveensastry/gvisor/downloads","issues_url":"https://api.github.com/repos/praveensastry/gvisor/issues{/number}","pulls_url":"https://api.github.com/repos/praveensastry/gvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/praveensastry/gvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/praveensastry/gvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praveensastry/gvisor/labels{/name}","releases_url":"https://api.github.com/repos/praveensastry/gvisor/releases{/id}","deployments_url":"https://api.github.com/repos/praveensastry/gvisor/deployments","created_at":"2019-07-30T00:01:02Z","updated_at":"2019-07-30T00:01:05Z","pushed_at":"2019-08-06T01:58:01Z","git_url":"git://github.com/praveensastry/gvisor.git","ssh_url":"git@github.com:praveensastry/gvisor.git","clone_url":"https://github.com/praveensastry/gvisor.git","svn_url":"https://github.com/praveensastry/gvisor","homepage":"https://gvisor.dev","size":10293,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"960a5e5536d5d961028ef60123e3b00ff3c04a56","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":131212638,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyMTI2Mzg=","name":"gvisor","full_name":"google/gvisor","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/gvisor","description":"Container Runtime Sandbox","fork":false,"url":"https://api.github.com/repos/google/gvisor","forks_url":"https://api.github.com/repos/google/gvisor/forks","keys_url":"https://api.github.com/repos/google/gvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/gvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/gvisor/teams","hooks_url":"https://api.github.com/repos/google/gvisor/hooks","issue_events_url":"https://api.github.com/repos/google/gvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/gvisor/events","assignees_url":"https://api.github.com/repos/google/gvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/gvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/gvisor/tags","blobs_url":"https://api.github.com/repos/google/gvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/gvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/gvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/gvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/gvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/gvisor/languages","stargazers_url":"https://api.github.com/repos/google/gvisor/stargazers","contributors_url":"https://api.github.com/repos/google/gvisor/contributors","subscribers_url":"https://api.github.com/repos/google/gvisor/subscribers","subscription_url":"https://api.github.com/repos/google/gvisor/subscription","commits_url":"https://api.github.com/repos/google/gvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/gvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/gvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/gvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/gvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/gvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/gvisor/merges","archive_url":"https://api.github.com/repos/google/gvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/gvisor/downloads","issues_url":"https://api.github.com/repos/google/gvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/gvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/gvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/gvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/gvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/gvisor/releases{/id}","deployments_url":"https://api.github.com/repos/google/gvisor/deployments","created_at":"2018-04-26T21:28:49Z","updated_at":"2019-08-08T23:51:05Z","pushed_at":"2019-08-09T00:01:03Z","git_url":"git://github.com/google/gvisor.git","ssh_url":"git@github.com:google/gvisor.git","clone_url":"https://github.com/google/gvisor.git","svn_url":"https://github.com/google/gvisor","homepage":"https://gvisor.dev","size":10865,"stargazers_count":8821,"watchers_count":8821,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":560,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":197,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":560,"open_issues":197,"watchers":8821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/gvisor/pulls/655"},"html":{"href":"https://github.com/google/gvisor/pull/655"},"issue":{"href":"https://api.github.com/repos/google/gvisor/issues/655"},"comments":{"href":"https://api.github.com/repos/google/gvisor/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/google/gvisor/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/google/gvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/gvisor/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/google/gvisor/statuses/8d89c0d92b3839eed0839b1a9bc7666e6261d972"}},"author_association":"NONE"}}
{"actor":{"display_login":"ianlewis"}}