{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/278695157","pull_request_review_id":230836714,"id":278695157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODY5NTE1Nw==","diff_hunk":"@@ -53,19 +56,31 @@ class BlockEsiCache extends VarnishCache\n      */\n     protected $recorder;\n \n+    /**\n+     * @var ControllerResolverInterface\n+     */\n+    protected $resolver;\n+\n+    /**\n+     * @var ArgumentResolverInterface\n+     */\n+    private $argumentResolver;\n+\n     /**\n      * @param string                       $token            A token\n      * @param array                        $servers          An array of servers\n      * @param RouterInterface              $router           A router instance\n      * @param string                       $purgeInstruction The purge instruction (purge in Varnish 2, ban in Varnish 3)\n+     * @param ControllerResolverInterface  $resolver         Controller Resolver\n+     * @param ArgumentResolverInterface    $argumentResolver Argument Resolver","path":"src/Cache/BlockEsiCache.php","position":35,"original_position":35,"commit_id":"7beb2d1f65d1fbdcebed62c380332908a4881d68","original_commit_id":"7beb2d1f65d1fbdcebed62c380332908a4881d68","user":{"login":"greg0ire","id":657779,"node_id":"MDQ6VXNlcjY1Nzc3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"I think both of these can be removed (and maybe more, but not in this PR)","created_at":"2019-04-25T19:19:22Z","updated_at":"2019-04-25T19:22:04Z","html_url":"https://github.com/sonata-project/SonataPageBundle/pull/1054#discussion_r278695157","pull_request_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/278695157"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/1054#discussion_r278695157"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054","id":272734306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyNzM0MzA2","html_url":"https://github.com/sonata-project/SonataPageBundle/pull/1054","diff_url":"https://github.com/sonata-project/SonataPageBundle/pull/1054.diff","patch_url":"https://github.com/sonata-project/SonataPageBundle/pull/1054.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/1054","number":1054,"state":"open","locked":false,"title":"chore(cache): allow the use of sonata-project/cache-bundle:^3.0","user":{"login":"xXNoceboXx","id":3227304,"node_id":"MDQ6VXNlcjMyMjczMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3227304?v=4","gravatar_id":"","url":"https://api.github.com/users/xXNoceboXx","html_url":"https://github.com/xXNoceboXx","followers_url":"https://api.github.com/users/xXNoceboXx/followers","following_url":"https://api.github.com/users/xXNoceboXx/following{/other_user}","gists_url":"https://api.github.com/users/xXNoceboXx/gists{/gist_id}","starred_url":"https://api.github.com/users/xXNoceboXx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xXNoceboXx/subscriptions","organizations_url":"https://api.github.com/users/xXNoceboXx/orgs","repos_url":"https://api.github.com/users/xXNoceboXx/repos","events_url":"https://api.github.com/users/xXNoceboXx/events{/privacy}","received_events_url":"https://api.github.com/users/xXNoceboXx/received_events","type":"User","site_admin":false},"body":"## Subject\r\n\r\nAllow the use of sonata-project/cache-bundle:^3.0 to use sonata-project/cache:^2.0\r\nBecause sonata-project/cache-bundle:2.4.2 require only sonata-project/cache:^1.0.3.\r\n\r\n```markdown\r\n### Changed\r\n - [x] Update version of sonata-project/cache-bundle in composer.json\r\n```","created_at":"2019-04-23T13:35:40Z","updated_at":"2019-04-25T19:22:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7185ec970bfc30b11dc7d62045575373610f048","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jordisala1991","id":1137485,"node_id":"MDQ6VXNlcjExMzc0ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1137485?v=4","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},{"login":"core23","id":3440437,"node_id":"MDQ6VXNlcjM0NDA0Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":369793264,"node_id":"MDU6TGFiZWwzNjk3OTMyNjQ=","url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels/major","name":"major","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/1054/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/7beb2d1f65d1fbdcebed62c380332908a4881d68","head":{"label":"xXNoceboXx:fix-cache-bundle","ref":"fix-cache-bundle","sha":"7beb2d1f65d1fbdcebed62c380332908a4881d68","user":{"login":"xXNoceboXx","id":3227304,"node_id":"MDQ6VXNlcjMyMjczMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3227304?v=4","gravatar_id":"","url":"https://api.github.com/users/xXNoceboXx","html_url":"https://github.com/xXNoceboXx","followers_url":"https://api.github.com/users/xXNoceboXx/followers","following_url":"https://api.github.com/users/xXNoceboXx/following{/other_user}","gists_url":"https://api.github.com/users/xXNoceboXx/gists{/gist_id}","starred_url":"https://api.github.com/users/xXNoceboXx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xXNoceboXx/subscriptions","organizations_url":"https://api.github.com/users/xXNoceboXx/orgs","repos_url":"https://api.github.com/users/xXNoceboXx/repos","events_url":"https://api.github.com/users/xXNoceboXx/events{/privacy}","received_events_url":"https://api.github.com/users/xXNoceboXx/received_events","type":"User","site_admin":false},"repo":{"id":183020027,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwMjAwMjc=","name":"SonataPageBundle","full_name":"xXNoceboXx/SonataPageBundle","private":false,"owner":{"login":"xXNoceboXx","id":3227304,"node_id":"MDQ6VXNlcjMyMjczMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3227304?v=4","gravatar_id":"","url":"https://api.github.com/users/xXNoceboXx","html_url":"https://github.com/xXNoceboXx","followers_url":"https://api.github.com/users/xXNoceboXx/followers","following_url":"https://api.github.com/users/xXNoceboXx/following{/other_user}","gists_url":"https://api.github.com/users/xXNoceboXx/gists{/gist_id}","starred_url":"https://api.github.com/users/xXNoceboXx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xXNoceboXx/subscriptions","organizations_url":"https://api.github.com/users/xXNoceboXx/orgs","repos_url":"https://api.github.com/users/xXNoceboXx/repos","events_url":"https://api.github.com/users/xXNoceboXx/events{/privacy}","received_events_url":"https://api.github.com/users/xXNoceboXx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xXNoceboXx/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":true,"url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle","forks_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/xXNoceboXx/SonataPageBundle/deployments","created_at":"2019-04-23T13:22:18Z","updated_at":"2019-04-23T13:22:21Z","pushed_at":"2019-04-25T10:59:17Z","git_url":"git://github.com/xXNoceboXx/SonataPageBundle.git","ssh_url":"git@github.com:xXNoceboXx/SonataPageBundle.git","clone_url":"https://github.com/xXNoceboXx/SonataPageBundle.git","svn_url":"https://github.com/xXNoceboXx/SonataPageBundle","homepage":"https://sonata-project.org/","size":4513,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:master","ref":"master","sha":"5ea0c20a2c8d8dfb2f8aff632f4be9363f5873c8","user":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1141608,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQxNjA4","name":"SonataPageBundle","full_name":"sonata-project/SonataPageBundle","private":false,"owner":{"login":"sonata-project","id":404157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sonata-project/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/deployments","created_at":"2010-12-06T00:18:21Z","updated_at":"2019-04-24T19:35:06Z","pushed_at":"2019-04-25T10:59:18Z","git_url":"git://github.com/sonata-project/SonataPageBundle.git","ssh_url":"git@github.com:sonata-project/SonataPageBundle.git","clone_url":"https://github.com/sonata-project/SonataPageBundle.git","svn_url":"https://github.com/sonata-project/SonataPageBundle","homepage":"https://sonata-project.org/","size":4526,"stargazers_count":169,"watchers_count":169,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":198,"open_issues":43,"watchers":169,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/1054"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/1054"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/7beb2d1f65d1fbdcebed62c380332908a4881d68"}},"author_association":"NONE"}}
{"actor":{"display_login":"greg0ire"}}