{"action":"opened","number":7212,"pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/7212","id":355619440,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1NjE5NDQw","html_url":"https://github.com/vaadin/flow/pull/7212","diff_url":"https://github.com/vaadin/flow/pull/7212.diff","patch_url":"https://github.com/vaadin/flow/pull/7212.patch","issue_url":"https://api.github.com/repos/vaadin/flow/issues/7212","number":7212,"state":"open","locked":false,"title":"Only clear all if value changes.","user":{"login":"caalador","id":2726090,"node_id":"MDQ6VXNlcjI3MjYwOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false},"body":"If we remove all when the innerHTML\r\nvalue stays the same we will loose the innerHTML\r\non the client as the value is not re-sent,\r\nbut is still cleared from the client.\r\n\r\nFixes #4644","created_at":"2019-12-20T08:50:03Z","updated_at":"2019-12-20T08:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/flow/pulls/7212/commits","review_comments_url":"https://api.github.com/repos/vaadin/flow/pulls/7212/comments","review_comment_url":"https://api.github.com/repos/vaadin/flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/7212/comments","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/c3b9e7aab717c722960eab8bbf1d610b5a029853","head":{"label":"vaadin:issues/4644_innerHTML","ref":"issues/4644_innerHTML","sha":"c3b9e7aab717c722960eab8bbf1d610b5a029853","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":34809191,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgwOTE5MQ==","name":"flow","full_name":"vaadin/flow","private":false,"owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vaadin/flow","description":"Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.","fork":false,"url":"https://api.github.com/repos/vaadin/flow","forks_url":"https://api.github.com/repos/vaadin/flow/forks","keys_url":"https://api.github.com/repos/vaadin/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow/teams","hooks_url":"https://api.github.com/repos/vaadin/flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow/events","assignees_url":"https://api.github.com/repos/vaadin/flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow/tags","blobs_url":"https://api.github.com/repos/vaadin/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow/subscription","commits_url":"https://api.github.com/repos/vaadin/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow/merges","archive_url":"https://api.github.com/repos/vaadin/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow/downloads","issues_url":"https://api.github.com/repos/vaadin/flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow/deployments","created_at":"2015-04-29T17:54:35Z","updated_at":"2019-12-19T12:27:53Z","pushed_at":"2019-12-20T08:49:36Z","git_url":"git://github.com/vaadin/flow.git","ssh_url":"git@github.com:vaadin/flow.git","clone_url":"https://github.com/vaadin/flow.git","svn_url":"https://github.com/vaadin/flow","homepage":"","size":135910,"stargazers_count":226,"watchers_count":226,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":794,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":69,"open_issues":794,"watchers":226,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"97fcebc2fde60f3aacf9b39eff195fb7fc90ba7e","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":34809191,"node_id":"MDEwOlJlcG9zaXRvcnkzNDgwOTE5MQ==","name":"flow","full_name":"vaadin/flow","private":false,"owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vaadin/flow","description":"Flow is a Java framework binding Vaadin web components to Java. This is part of Vaadin 10+.","fork":false,"url":"https://api.github.com/repos/vaadin/flow","forks_url":"https://api.github.com/repos/vaadin/flow/forks","keys_url":"https://api.github.com/repos/vaadin/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow/teams","hooks_url":"https://api.github.com/repos/vaadin/flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow/events","assignees_url":"https://api.github.com/repos/vaadin/flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow/tags","blobs_url":"https://api.github.com/repos/vaadin/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow/subscription","commits_url":"https://api.github.com/repos/vaadin/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow/merges","archive_url":"https://api.github.com/repos/vaadin/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow/downloads","issues_url":"https://api.github.com/repos/vaadin/flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow/deployments","created_at":"2015-04-29T17:54:35Z","updated_at":"2019-12-19T12:27:53Z","pushed_at":"2019-12-20T08:49:36Z","git_url":"git://github.com/vaadin/flow.git","ssh_url":"git@github.com:vaadin/flow.git","clone_url":"https://github.com/vaadin/flow.git","svn_url":"https://github.com/vaadin/flow","homepage":"","size":135910,"stargazers_count":226,"watchers_count":226,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":794,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":69,"open_issues":794,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow/pulls/7212"},"html":{"href":"https://github.com/vaadin/flow/pull/7212"},"issue":{"href":"https://api.github.com/repos/vaadin/flow/issues/7212"},"comments":{"href":"https://api.github.com/repos/vaadin/flow/issues/7212/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/flow/pulls/7212/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/flow/pulls/7212/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/flow/statuses/c3b9e7aab717c722960eab8bbf1d610b5a029853"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":109,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"caalador"}}