{"action":"created","comment":{"url":"https://api.github.com/repos/Sage/carbon/pulls/comments/269476604","pull_request_review_id":219356002,"id":269476604,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTQ3NjYwNA==","diff_hunk":"@@ -0,0 +1,364 @@\n+import React from 'react';\n+import 'jest-styled-components';\n+import { mount, shallow } from 'enzyme';\n+import Icon from 'components/icon';\n+import Link from 'components/link';\n+import TestRenderer from 'react-test-renderer';\n+import Button from '.';\n+import StyledButton from './button.style';\n+import BaseTheme from '../../style/themes/base';\n+import classicTheme from '../../style/themes/classic';\n+\n+import { assertStyleMatch } from '../../__spec_helper__/test-utils';\n+import { rootTagTest } from '../../utils/helpers/tags/tags-specs';\n+\n+const render = (props, renderer = shallow) => {\n+  return renderer(\n+    <Button { ...props } />\n+  );\n+};\n+\n+const variants = ['primary', 'secondary', 'tertiary', 'destructive', 'darkBackground'];\n+const sizes = { small: [32, 16], medium: [40, 24], large: [48, 32] };\n+\n+describe('Button', () => {\n+  describe('when no props other than children are passed into the component', () => {\n+    it('renders the default props and children to match the snapshot', () => {\n+      const wrapper = render({ children: 'foo' });\n+      expect(wrapper.props().renderAs).toEqual('secondary');\n+      expect(wrapper.props().size).toEqual('medium');\n+      expect(wrapper.props().disabled).toEqual(false);\n+      expect(wrapper.props().iconPosition).toEqual('');\n+      expect(!wrapper.contains(<Icon type='filter' />)).toBeTruthy();","path":"src/components/button/button.spec.js","position":32,"original_position":32,"commit_id":"9648653770953e40f7fad0c761d39a458833b367","original_commit_id":"9648653770953e40f7fad0c761d39a458833b367","user":{"login":"grabkowski","id":22885392,"node_id":"MDQ6VXNlcjIyODg1Mzky","avatar_url":"https://avatars3.githubusercontent.com/u/22885392?v=4","gravatar_id":"","url":"https://api.github.com/users/grabkowski","html_url":"https://github.com/grabkowski","followers_url":"https://api.github.com/users/grabkowski/followers","following_url":"https://api.github.com/users/grabkowski/following{/other_user}","gists_url":"https://api.github.com/users/grabkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/grabkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabkowski/subscriptions","organizations_url":"https://api.github.com/users/grabkowski/orgs","repos_url":"https://api.github.com/users/grabkowski/repos","events_url":"https://api.github.com/users/grabkowski/events{/privacy}","received_events_url":"https://api.github.com/users/grabkowski/received_events","type":"User","site_admin":false},"body":"why is that exclamation mark for?","created_at":"2019-03-27T09:47:13Z","updated_at":"2019-03-27T09:47:14Z","html_url":"https://github.com/Sage/carbon/pull/1978#discussion_r269476604","pull_request_url":"https://api.github.com/repos/Sage/carbon/pulls/1978","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Sage/carbon/pulls/comments/269476604"},"html":{"href":"https://github.com/Sage/carbon/pull/1978#discussion_r269476604"},"pull_request":{"href":"https://api.github.com/repos/Sage/carbon/pulls/1978"}}},"pull_request":{"url":"https://api.github.com/repos/Sage/carbon/pulls/1978","id":263613736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzNjEzNzM2","html_url":"https://github.com/Sage/carbon/pull/1978","diff_url":"https://github.com/Sage/carbon/pull/1978.diff","patch_url":"https://github.com/Sage/carbon/pull/1978.patch","issue_url":"https://api.github.com/repos/Sage/carbon/issues/1978","number":1978,"state":"open","locked":false,"title":"FE-1224 DLS button","user":{"login":"edleeks87","id":44157880,"node_id":"MDQ6VXNlcjQ0MTU3ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/44157880?v=4","gravatar_id":"","url":"https://api.github.com/users/edleeks87","html_url":"https://github.com/edleeks87","followers_url":"https://api.github.com/users/edleeks87/followers","following_url":"https://api.github.com/users/edleeks87/following{/other_user}","gists_url":"https://api.github.com/users/edleeks87/gists{/gist_id}","starred_url":"https://api.github.com/users/edleeks87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edleeks87/subscriptions","organizations_url":"https://api.github.com/users/edleeks87/orgs","repos_url":"https://api.github.com/users/edleeks87/repos","events_url":"https://api.github.com/users/edleeks87/events{/privacy}","received_events_url":"https://api.github.com/users/edleeks87/received_events","type":"User","site_admin":false},"body":"# Description\r\nImplements styled components to allow the theme based styling to be added to the Button component and bring it in line with what is described in the DLS.","created_at":"2019-03-22T13:33:40Z","updated_at":"2019-03-27T09:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd68046d392a44a586d5b22b881501cd73e7869","assignee":{"login":"edleeks87","id":44157880,"node_id":"MDQ6VXNlcjQ0MTU3ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/44157880?v=4","gravatar_id":"","url":"https://api.github.com/users/edleeks87","html_url":"https://github.com/edleeks87","followers_url":"https://api.github.com/users/edleeks87/followers","following_url":"https://api.github.com/users/edleeks87/following{/other_user}","gists_url":"https://api.github.com/users/edleeks87/gists{/gist_id}","starred_url":"https://api.github.com/users/edleeks87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edleeks87/subscriptions","organizations_url":"https://api.github.com/users/edleeks87/orgs","repos_url":"https://api.github.com/users/edleeks87/repos","events_url":"https://api.github.com/users/edleeks87/events{/privacy}","received_events_url":"https://api.github.com/users/edleeks87/received_events","type":"User","site_admin":false},"assignees":[{"login":"edleeks87","id":44157880,"node_id":"MDQ6VXNlcjQ0MTU3ODgw","avatar_url":"https://avatars3.githubusercontent.com/u/44157880?v=4","gravatar_id":"","url":"https://api.github.com/users/edleeks87","html_url":"https://github.com/edleeks87","followers_url":"https://api.github.com/users/edleeks87/followers","following_url":"https://api.github.com/users/edleeks87/following{/other_user}","gists_url":"https://api.github.com/users/edleeks87/gists{/gist_id}","starred_url":"https://api.github.com/users/edleeks87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edleeks87/subscriptions","organizations_url":"https://api.github.com/users/edleeks87/orgs","repos_url":"https://api.github.com/users/edleeks87/repos","events_url":"https://api.github.com/users/edleeks87/events{/privacy}","received_events_url":"https://api.github.com/users/edleeks87/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":302690636,"node_id":"MDU6TGFiZWwzMDI2OTA2MzY=","url":"https://api.github.com/repos/Sage/carbon/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"b60205","default":false},{"id":729476220,"node_id":"MDU6TGFiZWw3Mjk0NzYyMjA=","url":"https://api.github.com/repos/Sage/carbon/labels/Passed%20UX%20Review","name":"Passed UX Review","color":"bfe5bf","default":false},{"id":299974051,"node_id":"MDU6TGFiZWwyOTk5NzQwNTE=","url":"https://api.github.com/repos/Sage/carbon/labels/Pending%20QA","name":"Pending QA","color":"c7def8","default":false},{"id":262174249,"node_id":"MDU6TGFiZWwyNjIxNzQyNDk=","url":"https://api.github.com/repos/Sage/carbon/labels/Pending%20Review","name":"Pending Review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Sage/carbon/pulls/1978/commits","review_comments_url":"https://api.github.com/repos/Sage/carbon/pulls/1978/comments","review_comment_url":"https://api.github.com/repos/Sage/carbon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sage/carbon/issues/1978/comments","statuses_url":"https://api.github.com/repos/Sage/carbon/statuses/9648653770953e40f7fad0c761d39a458833b367","head":{"label":"Sage:FE-1224-draft-button-dls","ref":"FE-1224-draft-button-dls","sha":"9648653770953e40f7fad0c761d39a458833b367","user":{"login":"Sage","id":24190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/24190?v=4","gravatar_id":"","url":"https://api.github.com/users/Sage","html_url":"https://github.com/Sage","followers_url":"https://api.github.com/users/Sage/followers","following_url":"https://api.github.com/users/Sage/following{/other_user}","gists_url":"https://api.github.com/users/Sage/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage/subscriptions","organizations_url":"https://api.github.com/users/Sage/orgs","repos_url":"https://api.github.com/users/Sage/repos","events_url":"https://api.github.com/users/Sage/events{/privacy}","received_events_url":"https://api.github.com/users/Sage/received_events","type":"Organization","site_admin":false},"repo":{"id":41923638,"node_id":"MDEwOlJlcG9zaXRvcnk0MTkyMzYzOA==","name":"carbon","full_name":"Sage/carbon","private":false,"owner":{"login":"Sage","id":24190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/24190?v=4","gravatar_id":"","url":"https://api.github.com/users/Sage","html_url":"https://github.com/Sage","followers_url":"https://api.github.com/users/Sage/followers","following_url":"https://api.github.com/users/Sage/following{/other_user}","gists_url":"https://api.github.com/users/Sage/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage/subscriptions","organizations_url":"https://api.github.com/users/Sage/orgs","repos_url":"https://api.github.com/users/Sage/repos","events_url":"https://api.github.com/users/Sage/events{/privacy}","received_events_url":"https://api.github.com/users/Sage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Sage/carbon","description":"Carbon by Sage | ReactJS UI Component Library","fork":false,"url":"https://api.github.com/repos/Sage/carbon","forks_url":"https://api.github.com/repos/Sage/carbon/forks","keys_url":"https://api.github.com/repos/Sage/carbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage/carbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage/carbon/teams","hooks_url":"https://api.github.com/repos/Sage/carbon/hooks","issue_events_url":"https://api.github.com/repos/Sage/carbon/issues/events{/number}","events_url":"https://api.github.com/repos/Sage/carbon/events","assignees_url":"https://api.github.com/repos/Sage/carbon/assignees{/user}","branches_url":"https://api.github.com/repos/Sage/carbon/branches{/branch}","tags_url":"https://api.github.com/repos/Sage/carbon/tags","blobs_url":"https://api.github.com/repos/Sage/carbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage/carbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage/carbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage/carbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage/carbon/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage/carbon/languages","stargazers_url":"https://api.github.com/repos/Sage/carbon/stargazers","contributors_url":"https://api.github.com/repos/Sage/carbon/contributors","subscribers_url":"https://api.github.com/repos/Sage/carbon/subscribers","subscription_url":"https://api.github.com/repos/Sage/carbon/subscription","commits_url":"https://api.github.com/repos/Sage/carbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage/carbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage/carbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage/carbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage/carbon/contents/{+path}","compare_url":"https://api.github.com/repos/Sage/carbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage/carbon/merges","archive_url":"https://api.github.com/repos/Sage/carbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage/carbon/downloads","issues_url":"https://api.github.com/repos/Sage/carbon/issues{/number}","pulls_url":"https://api.github.com/repos/Sage/carbon/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage/carbon/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage/carbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage/carbon/labels{/name}","releases_url":"https://api.github.com/repos/Sage/carbon/releases{/id}","deployments_url":"https://api.github.com/repos/Sage/carbon/deployments","created_at":"2015-09-04T15:35:11Z","updated_at":"2019-03-27T08:27:00Z","pushed_at":"2019-03-27T09:19:51Z","git_url":"git://github.com/Sage/carbon.git","ssh_url":"git@github.com:Sage/carbon.git","clone_url":"https://github.com/Sage/carbon.git","svn_url":"https://github.com/Sage/carbon","homepage":"https://carbon.sage.com","size":24098,"stargazers_count":90,"watchers_count":90,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":135,"watchers":90,"default_branch":"master"}},"base":{"label":"Sage:master","ref":"master","sha":"236ee0ed4a2c737409613e6601bd5b375e4d2249","user":{"login":"Sage","id":24190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/24190?v=4","gravatar_id":"","url":"https://api.github.com/users/Sage","html_url":"https://github.com/Sage","followers_url":"https://api.github.com/users/Sage/followers","following_url":"https://api.github.com/users/Sage/following{/other_user}","gists_url":"https://api.github.com/users/Sage/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage/subscriptions","organizations_url":"https://api.github.com/users/Sage/orgs","repos_url":"https://api.github.com/users/Sage/repos","events_url":"https://api.github.com/users/Sage/events{/privacy}","received_events_url":"https://api.github.com/users/Sage/received_events","type":"Organization","site_admin":false},"repo":{"id":41923638,"node_id":"MDEwOlJlcG9zaXRvcnk0MTkyMzYzOA==","name":"carbon","full_name":"Sage/carbon","private":false,"owner":{"login":"Sage","id":24190,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MTkw","avatar_url":"https://avatars2.githubusercontent.com/u/24190?v=4","gravatar_id":"","url":"https://api.github.com/users/Sage","html_url":"https://github.com/Sage","followers_url":"https://api.github.com/users/Sage/followers","following_url":"https://api.github.com/users/Sage/following{/other_user}","gists_url":"https://api.github.com/users/Sage/gists{/gist_id}","starred_url":"https://api.github.com/users/Sage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sage/subscriptions","organizations_url":"https://api.github.com/users/Sage/orgs","repos_url":"https://api.github.com/users/Sage/repos","events_url":"https://api.github.com/users/Sage/events{/privacy}","received_events_url":"https://api.github.com/users/Sage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Sage/carbon","description":"Carbon by Sage | ReactJS UI Component Library","fork":false,"url":"https://api.github.com/repos/Sage/carbon","forks_url":"https://api.github.com/repos/Sage/carbon/forks","keys_url":"https://api.github.com/repos/Sage/carbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sage/carbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sage/carbon/teams","hooks_url":"https://api.github.com/repos/Sage/carbon/hooks","issue_events_url":"https://api.github.com/repos/Sage/carbon/issues/events{/number}","events_url":"https://api.github.com/repos/Sage/carbon/events","assignees_url":"https://api.github.com/repos/Sage/carbon/assignees{/user}","branches_url":"https://api.github.com/repos/Sage/carbon/branches{/branch}","tags_url":"https://api.github.com/repos/Sage/carbon/tags","blobs_url":"https://api.github.com/repos/Sage/carbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sage/carbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sage/carbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sage/carbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sage/carbon/statuses/{sha}","languages_url":"https://api.github.com/repos/Sage/carbon/languages","stargazers_url":"https://api.github.com/repos/Sage/carbon/stargazers","contributors_url":"https://api.github.com/repos/Sage/carbon/contributors","subscribers_url":"https://api.github.com/repos/Sage/carbon/subscribers","subscription_url":"https://api.github.com/repos/Sage/carbon/subscription","commits_url":"https://api.github.com/repos/Sage/carbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sage/carbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sage/carbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sage/carbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sage/carbon/contents/{+path}","compare_url":"https://api.github.com/repos/Sage/carbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sage/carbon/merges","archive_url":"https://api.github.com/repos/Sage/carbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sage/carbon/downloads","issues_url":"https://api.github.com/repos/Sage/carbon/issues{/number}","pulls_url":"https://api.github.com/repos/Sage/carbon/pulls{/number}","milestones_url":"https://api.github.com/repos/Sage/carbon/milestones{/number}","notifications_url":"https://api.github.com/repos/Sage/carbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sage/carbon/labels{/name}","releases_url":"https://api.github.com/repos/Sage/carbon/releases{/id}","deployments_url":"https://api.github.com/repos/Sage/carbon/deployments","created_at":"2015-09-04T15:35:11Z","updated_at":"2019-03-27T08:27:00Z","pushed_at":"2019-03-27T09:19:51Z","git_url":"git://github.com/Sage/carbon.git","ssh_url":"git@github.com:Sage/carbon.git","clone_url":"https://github.com/Sage/carbon.git","svn_url":"https://github.com/Sage/carbon","homepage":"https://carbon.sage.com","size":24098,"stargazers_count":90,"watchers_count":90,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":135,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":135,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sage/carbon/pulls/1978"},"html":{"href":"https://github.com/Sage/carbon/pull/1978"},"issue":{"href":"https://api.github.com/repos/Sage/carbon/issues/1978"},"comments":{"href":"https://api.github.com/repos/Sage/carbon/issues/1978/comments"},"review_comments":{"href":"https://api.github.com/repos/Sage/carbon/pulls/1978/comments"},"review_comment":{"href":"https://api.github.com/repos/Sage/carbon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sage/carbon/pulls/1978/commits"},"statuses":{"href":"https://api.github.com/repos/Sage/carbon/statuses/9648653770953e40f7fad0c761d39a458833b367"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grabkowski"}}