{"action":"created","comment":{"url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/comments/278564650","pull_request_review_id":230664682,"id":278564650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODU2NDY1MA==","diff_hunk":"@@ -0,0 +1,35 @@\n+\n+# fronzen_string_literal: true\n+\n+include Warden::Test::Helpers\n+Warden.test_mode!\n+\n+feature \"admin > users > edit\", :devise do\n+\n+  after(:each) do\n+    Warden.test_reset!\n+  end\n+\n+  let(:admin) { create :user, :admin }\n+\n+ before do\n+   login_as admin, scope: :user\n+   visit edit_admin_user_path(admin)\n+ end\n+    \n+  scenario \"user visit admin/user/edit page\" do\n+    expect(page).to have_button(\"Update User\")\n+    expect(page).to have_link href: admin_user_path(admin)\n+  end\n+\n+  scenario \"User edit fill\" do\n+    fill_in \"user_email\", :with => \"user@example.com\"\n+    fill_in \"user_name\", :with => \"elliots\"\n+    #select \"user\", form: \"select\"\n+    fill_in \"user_password\", :with => \"Ab@123456\"\n+    fill_in \"user_password_confirmation\", :with => \"Ab@123456 \"\n+    click_button(\"Update User\")\n+    # expect page to have url show","path":"spec/features/admin/users/edit_spec.rb","position":32,"original_position":32,"commit_id":"e007d0d4470c4649da8afd2ef07c27b4fd61df19","original_commit_id":"e007d0d4470c4649da8afd2ef07c27b4fd61df19","user":{"login":"yeuem1vannam","id":2409560,"node_id":"MDQ6VXNlcjI0MDk1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2409560?v=4","gravatar_id":"","url":"https://api.github.com/users/yeuem1vannam","html_url":"https://github.com/yeuem1vannam","followers_url":"https://api.github.com/users/yeuem1vannam/followers","following_url":"https://api.github.com/users/yeuem1vannam/following{/other_user}","gists_url":"https://api.github.com/users/yeuem1vannam/gists{/gist_id}","starred_url":"https://api.github.com/users/yeuem1vannam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeuem1vannam/subscriptions","organizations_url":"https://api.github.com/users/yeuem1vannam/orgs","repos_url":"https://api.github.com/users/yeuem1vannam/repos","events_url":"https://api.github.com/users/yeuem1vannam/events{/privacy}","received_events_url":"https://api.github.com/users/yeuem1vannam/received_events","type":"User","site_admin":false},"body":"1. Test thì luôn phải có `expect` cái gì đó, không test được giai đoạn sau của click_button thì ít nhất phải test đc là nó có cái button\r\n2. Code ko dùng thì xoá đi","created_at":"2019-04-25T14:00:49Z","updated_at":"2019-04-25T14:02:31Z","html_url":"https://github.com/yeuem1vannam/Minerva/pull/13#discussion_r278564650","pull_request_url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/comments/278564650"},"html":{"href":"https://github.com/yeuem1vannam/Minerva/pull/13#discussion_r278564650"},"pull_request":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13","id":268110588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY4MTEwNTg4","html_url":"https://github.com/yeuem1vannam/Minerva/pull/13","diff_url":"https://github.com/yeuem1vannam/Minerva/pull/13.diff","patch_url":"https://github.com/yeuem1vannam/Minerva/pull/13.patch","issue_url":"https://api.github.com/repos/yeuem1vannam/Minerva/issues/13","number":13,"state":"open","locked":false,"title":"feature test for /admin/users","user":{"login":"dutavi","id":43242076,"node_id":"MDQ6VXNlcjQzMjQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/43242076?v=4","gravatar_id":"","url":"https://api.github.com/users/dutavi","html_url":"https://github.com/dutavi","followers_url":"https://api.github.com/users/dutavi/followers","following_url":"https://api.github.com/users/dutavi/following{/other_user}","gists_url":"https://api.github.com/users/dutavi/gists{/gist_id}","starred_url":"https://api.github.com/users/dutavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutavi/subscriptions","organizations_url":"https://api.github.com/users/dutavi/orgs","repos_url":"https://api.github.com/users/dutavi/repos","events_url":"https://api.github.com/users/dutavi/events{/privacy}","received_events_url":"https://api.github.com/users/dutavi/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-07T14:25:47Z","updated_at":"2019-04-25T14:02:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e583cf80cf74178fdb842f8bd5aa71b8031db4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13/commits","review_comments_url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13/comments","review_comment_url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeuem1vannam/Minerva/issues/13/comments","statuses_url":"https://api.github.com/repos/yeuem1vannam/Minerva/statuses/e007d0d4470c4649da8afd2ef07c27b4fd61df19","head":{"label":"dutavi:test/admin/user","ref":"test/admin/user","sha":"e007d0d4470c4649da8afd2ef07c27b4fd61df19","user":{"login":"dutavi","id":43242076,"node_id":"MDQ6VXNlcjQzMjQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/43242076?v=4","gravatar_id":"","url":"https://api.github.com/users/dutavi","html_url":"https://github.com/dutavi","followers_url":"https://api.github.com/users/dutavi/followers","following_url":"https://api.github.com/users/dutavi/following{/other_user}","gists_url":"https://api.github.com/users/dutavi/gists{/gist_id}","starred_url":"https://api.github.com/users/dutavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutavi/subscriptions","organizations_url":"https://api.github.com/users/dutavi/orgs","repos_url":"https://api.github.com/users/dutavi/repos","events_url":"https://api.github.com/users/dutavi/events{/privacy}","received_events_url":"https://api.github.com/users/dutavi/received_events","type":"User","site_admin":false},"repo":{"id":178229316,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjkzMTY=","name":"Minerva","full_name":"dutavi/Minerva","private":false,"owner":{"login":"dutavi","id":43242076,"node_id":"MDQ6VXNlcjQzMjQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/43242076?v=4","gravatar_id":"","url":"https://api.github.com/users/dutavi","html_url":"https://github.com/dutavi","followers_url":"https://api.github.com/users/dutavi/followers","following_url":"https://api.github.com/users/dutavi/following{/other_user}","gists_url":"https://api.github.com/users/dutavi/gists{/gist_id}","starred_url":"https://api.github.com/users/dutavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutavi/subscriptions","organizations_url":"https://api.github.com/users/dutavi/orgs","repos_url":"https://api.github.com/users/dutavi/repos","events_url":"https://api.github.com/users/dutavi/events{/privacy}","received_events_url":"https://api.github.com/users/dutavi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dutavi/Minerva","description":"Training project for Book lover","fork":true,"url":"https://api.github.com/repos/dutavi/Minerva","forks_url":"https://api.github.com/repos/dutavi/Minerva/forks","keys_url":"https://api.github.com/repos/dutavi/Minerva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dutavi/Minerva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dutavi/Minerva/teams","hooks_url":"https://api.github.com/repos/dutavi/Minerva/hooks","issue_events_url":"https://api.github.com/repos/dutavi/Minerva/issues/events{/number}","events_url":"https://api.github.com/repos/dutavi/Minerva/events","assignees_url":"https://api.github.com/repos/dutavi/Minerva/assignees{/user}","branches_url":"https://api.github.com/repos/dutavi/Minerva/branches{/branch}","tags_url":"https://api.github.com/repos/dutavi/Minerva/tags","blobs_url":"https://api.github.com/repos/dutavi/Minerva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dutavi/Minerva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dutavi/Minerva/git/refs{/sha}","trees_url":"https://api.github.com/repos/dutavi/Minerva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dutavi/Minerva/statuses/{sha}","languages_url":"https://api.github.com/repos/dutavi/Minerva/languages","stargazers_url":"https://api.github.com/repos/dutavi/Minerva/stargazers","contributors_url":"https://api.github.com/repos/dutavi/Minerva/contributors","subscribers_url":"https://api.github.com/repos/dutavi/Minerva/subscribers","subscription_url":"https://api.github.com/repos/dutavi/Minerva/subscription","commits_url":"https://api.github.com/repos/dutavi/Minerva/commits{/sha}","git_commits_url":"https://api.github.com/repos/dutavi/Minerva/git/commits{/sha}","comments_url":"https://api.github.com/repos/dutavi/Minerva/comments{/number}","issue_comment_url":"https://api.github.com/repos/dutavi/Minerva/issues/comments{/number}","contents_url":"https://api.github.com/repos/dutavi/Minerva/contents/{+path}","compare_url":"https://api.github.com/repos/dutavi/Minerva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dutavi/Minerva/merges","archive_url":"https://api.github.com/repos/dutavi/Minerva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dutavi/Minerva/downloads","issues_url":"https://api.github.com/repos/dutavi/Minerva/issues{/number}","pulls_url":"https://api.github.com/repos/dutavi/Minerva/pulls{/number}","milestones_url":"https://api.github.com/repos/dutavi/Minerva/milestones{/number}","notifications_url":"https://api.github.com/repos/dutavi/Minerva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dutavi/Minerva/labels{/name}","releases_url":"https://api.github.com/repos/dutavi/Minerva/releases{/id}","deployments_url":"https://api.github.com/repos/dutavi/Minerva/deployments","created_at":"2019-03-28T15:15:00Z","updated_at":"2019-03-28T15:15:03Z","pushed_at":"2019-04-25T13:52:47Z","git_url":"git://github.com/dutavi/Minerva.git","ssh_url":"git@github.com:dutavi/Minerva.git","clone_url":"https://github.com/dutavi/Minerva.git","svn_url":"https://github.com/dutavi/Minerva","homepage":null,"size":298,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeuem1vannam:master","ref":"master","sha":"b31740885f3f2d15304b2ded6c7a1d83b08dec7e","user":{"login":"yeuem1vannam","id":2409560,"node_id":"MDQ6VXNlcjI0MDk1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2409560?v=4","gravatar_id":"","url":"https://api.github.com/users/yeuem1vannam","html_url":"https://github.com/yeuem1vannam","followers_url":"https://api.github.com/users/yeuem1vannam/followers","following_url":"https://api.github.com/users/yeuem1vannam/following{/other_user}","gists_url":"https://api.github.com/users/yeuem1vannam/gists{/gist_id}","starred_url":"https://api.github.com/users/yeuem1vannam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeuem1vannam/subscriptions","organizations_url":"https://api.github.com/users/yeuem1vannam/orgs","repos_url":"https://api.github.com/users/yeuem1vannam/repos","events_url":"https://api.github.com/users/yeuem1vannam/events{/privacy}","received_events_url":"https://api.github.com/users/yeuem1vannam/received_events","type":"User","site_admin":false},"repo":{"id":178205116,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMDUxMTY=","name":"Minerva","full_name":"yeuem1vannam/Minerva","private":false,"owner":{"login":"yeuem1vannam","id":2409560,"node_id":"MDQ6VXNlcjI0MDk1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/2409560?v=4","gravatar_id":"","url":"https://api.github.com/users/yeuem1vannam","html_url":"https://github.com/yeuem1vannam","followers_url":"https://api.github.com/users/yeuem1vannam/followers","following_url":"https://api.github.com/users/yeuem1vannam/following{/other_user}","gists_url":"https://api.github.com/users/yeuem1vannam/gists{/gist_id}","starred_url":"https://api.github.com/users/yeuem1vannam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeuem1vannam/subscriptions","organizations_url":"https://api.github.com/users/yeuem1vannam/orgs","repos_url":"https://api.github.com/users/yeuem1vannam/repos","events_url":"https://api.github.com/users/yeuem1vannam/events{/privacy}","received_events_url":"https://api.github.com/users/yeuem1vannam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yeuem1vannam/Minerva","description":"Training project for Language lover","fork":false,"url":"https://api.github.com/repos/yeuem1vannam/Minerva","forks_url":"https://api.github.com/repos/yeuem1vannam/Minerva/forks","keys_url":"https://api.github.com/repos/yeuem1vannam/Minerva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeuem1vannam/Minerva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeuem1vannam/Minerva/teams","hooks_url":"https://api.github.com/repos/yeuem1vannam/Minerva/hooks","issue_events_url":"https://api.github.com/repos/yeuem1vannam/Minerva/issues/events{/number}","events_url":"https://api.github.com/repos/yeuem1vannam/Minerva/events","assignees_url":"https://api.github.com/repos/yeuem1vannam/Minerva/assignees{/user}","branches_url":"https://api.github.com/repos/yeuem1vannam/Minerva/branches{/branch}","tags_url":"https://api.github.com/repos/yeuem1vannam/Minerva/tags","blobs_url":"https://api.github.com/repos/yeuem1vannam/Minerva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeuem1vannam/Minerva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeuem1vannam/Minerva/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeuem1vannam/Minerva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeuem1vannam/Minerva/statuses/{sha}","languages_url":"https://api.github.com/repos/yeuem1vannam/Minerva/languages","stargazers_url":"https://api.github.com/repos/yeuem1vannam/Minerva/stargazers","contributors_url":"https://api.github.com/repos/yeuem1vannam/Minerva/contributors","subscribers_url":"https://api.github.com/repos/yeuem1vannam/Minerva/subscribers","subscription_url":"https://api.github.com/repos/yeuem1vannam/Minerva/subscription","commits_url":"https://api.github.com/repos/yeuem1vannam/Minerva/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeuem1vannam/Minerva/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeuem1vannam/Minerva/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeuem1vannam/Minerva/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeuem1vannam/Minerva/contents/{+path}","compare_url":"https://api.github.com/repos/yeuem1vannam/Minerva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeuem1vannam/Minerva/merges","archive_url":"https://api.github.com/repos/yeuem1vannam/Minerva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeuem1vannam/Minerva/downloads","issues_url":"https://api.github.com/repos/yeuem1vannam/Minerva/issues{/number}","pulls_url":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls{/number}","milestones_url":"https://api.github.com/repos/yeuem1vannam/Minerva/milestones{/number}","notifications_url":"https://api.github.com/repos/yeuem1vannam/Minerva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeuem1vannam/Minerva/labels{/name}","releases_url":"https://api.github.com/repos/yeuem1vannam/Minerva/releases{/id}","deployments_url":"https://api.github.com/repos/yeuem1vannam/Minerva/deployments","created_at":"2019-03-28T13:04:50Z","updated_at":"2019-03-30T16:25:45Z","pushed_at":"2019-04-25T13:52:48Z","git_url":"git://github.com/yeuem1vannam/Minerva.git","ssh_url":"git@github.com:yeuem1vannam/Minerva.git","clone_url":"https://github.com/yeuem1vannam/Minerva.git","svn_url":"https://github.com/yeuem1vannam/Minerva","homepage":"","size":319,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13"},"html":{"href":"https://github.com/yeuem1vannam/Minerva/pull/13"},"issue":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/issues/13"},"comments":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/yeuem1vannam/Minerva/statuses/e007d0d4470c4649da8afd2ef07c27b4fd61df19"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yeuem1vannam"}}