{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/254346410","pull_request_review_id":200673628,"id":254346410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDM0NjQxMA==","diff_hunk":"@@ -8,7 +8,7 @@ function os::golang::verify_go_version() {\n \n \tlocal go_version\n \tgo_version=($(go version))\n-\tif [[ \"${go_version[2]}\" < \"${OS_REQUIRED_GO_VERSION}\" ]]; then\n+\tif ! echo \"${go_version[2]#go}\" | awk -F. -v min=${OS_REQUIRED_GO_VERSION#go} '{ exit $2 < min }'; then","path":"hack/lib/util/golang.sh","position":5,"original_position":5,"commit_id":"117392b69db0db10b40f7b1dc4a84430268f4e9a","original_commit_id":"117392b69db0db10b40f7b1dc4a84430268f4e9a","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"@cben feel free to open a PR fixing this and ping me there :)","created_at":"2019-02-06T16:30:08Z","updated_at":"2019-02-06T16:30:09Z","html_url":"https://github.com/openshift/origin/pull/18807#discussion_r254346410","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/18807","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/254346410"},"html":{"href":"https://github.com/openshift/origin/pull/18807#discussion_r254346410"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/18807"}},"in_reply_to_id":254295165},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/18807","id":172514217,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcyNTE0MjE3","html_url":"https://github.com/openshift/origin/pull/18807","diff_url":"https://github.com/openshift/origin/pull/18807.diff","patch_url":"https://github.com/openshift/origin/pull/18807.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/18807","number":18807,"state":"closed","locked":false,"title":"Fix golang check so that it performs arithemtic comparison","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"/assign @stevekuznetsov ","created_at":"2018-03-02T14:20:56Z","updated_at":"2019-02-06T16:30:09Z","closed_at":"2018-03-07T10:34:10Z","merged_at":"2018-03-07T10:34:10Z","merge_commit_sha":"49a173319c4466872ed4e3124d2da284256dcab8","assignee":{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"assignees":[{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":223051294,"node_id":"MDU6TGFiZWwyMjMwNTEyOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":223479084,"node_id":"MDU6TGFiZWwyMjM0NzkwODQ=","url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":640547849,"node_id":"MDU6TGFiZWw2NDA1NDc4NDk=","url":"https://api.github.com/repos/openshift/origin/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/18807/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/18807/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/18807/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/117392b69db0db10b40f7b1dc4a84430268f4e9a","head":{"label":"soltysh:fix_golang_check","ref":"fix_golang_check","sha":"117392b69db0db10b40f7b1dc4a84430268f4e9a","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"repo":{"id":22954476,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk1NDQ3Ng==","name":"origin","full_name":"soltysh/origin","private":false,"owner":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/soltysh/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/soltysh/origin","forks_url":"https://api.github.com/repos/soltysh/origin/forks","keys_url":"https://api.github.com/repos/soltysh/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltysh/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltysh/origin/teams","hooks_url":"https://api.github.com/repos/soltysh/origin/hooks","issue_events_url":"https://api.github.com/repos/soltysh/origin/issues/events{/number}","events_url":"https://api.github.com/repos/soltysh/origin/events","assignees_url":"https://api.github.com/repos/soltysh/origin/assignees{/user}","branches_url":"https://api.github.com/repos/soltysh/origin/branches{/branch}","tags_url":"https://api.github.com/repos/soltysh/origin/tags","blobs_url":"https://api.github.com/repos/soltysh/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltysh/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltysh/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltysh/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltysh/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/soltysh/origin/languages","stargazers_url":"https://api.github.com/repos/soltysh/origin/stargazers","contributors_url":"https://api.github.com/repos/soltysh/origin/contributors","subscribers_url":"https://api.github.com/repos/soltysh/origin/subscribers","subscription_url":"https://api.github.com/repos/soltysh/origin/subscription","commits_url":"https://api.github.com/repos/soltysh/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltysh/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltysh/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltysh/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltysh/origin/contents/{+path}","compare_url":"https://api.github.com/repos/soltysh/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltysh/origin/merges","archive_url":"https://api.github.com/repos/soltysh/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltysh/origin/downloads","issues_url":"https://api.github.com/repos/soltysh/origin/issues{/number}","pulls_url":"https://api.github.com/repos/soltysh/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/soltysh/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/soltysh/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltysh/origin/labels{/name}","releases_url":"https://api.github.com/repos/soltysh/origin/releases{/id}","deployments_url":"https://api.github.com/repos/soltysh/origin/deployments","created_at":"2014-08-14T13:19:11Z","updated_at":"2019-02-06T09:32:42Z","pushed_at":"2019-02-06T16:24:28Z","git_url":"git://github.com/soltysh/origin.git","ssh_url":"git@github.com:soltysh/origin.git","clone_url":"https://github.com/soltysh/origin.git","svn_url":"https://github.com/soltysh/origin","homepage":"https://openshift.github.io","size":986848,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d06384f8a4cbf2276d62548bfb8b6692a4cbb255","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjY2OA==","name":"origin","full_name":"openshift/origin","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2019-02-06T11:54:41Z","pushed_at":"2019-02-06T16:25:14Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":994751,"stargazers_count":5749,"watchers_count":5749,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3349,"mirror_url":null,"archived":false,"open_issues_count":563,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3349,"open_issues":563,"watchers":5749,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/18807"},"html":{"href":"https://github.com/openshift/origin/pull/18807"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/18807"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/18807/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/18807/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/18807/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/117392b69db0db10b40f7b1dc4a84430268f4e9a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"soltysh"}}