{"action":"created","issue":{"url":"https://api.github.com/repos/smrealms/smr/issues/743","repository_url":"https://api.github.com/repos/smrealms/smr","labels_url":"https://api.github.com/repos/smrealms/smr/issues/743/labels{/name}","comments_url":"https://api.github.com/repos/smrealms/smr/issues/743/comments","events_url":"https://api.github.com/repos/smrealms/smr/issues/743/events","html_url":"https://github.com/smrealms/smr/pull/743","id":453707738,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2MzQ0NDI1","number":743,"title":"filter_list.js cleanup","user":{"login":"Page-","id":360115,"node_id":"MDQ6VXNlcjM2MDExNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/360115?v=4","gravatar_id":"","url":"https://api.github.com/users/Page-","html_url":"https://github.com/Page-","followers_url":"https://api.github.com/users/Page-/followers","following_url":"https://api.github.com/users/Page-/following{/other_user}","gists_url":"https://api.github.com/users/Page-/gists{/gist_id}","starred_url":"https://api.github.com/users/Page-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Page-/subscriptions","organizations_url":"https://api.github.com/users/Page-/orgs","repos_url":"https://api.github.com/users/Page-/repos","events_url":"https://api.github.com/users/Page-/events{/privacy}","received_events_url":"https://api.github.com/users/Page-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-06-07T21:53:44Z","updated_at":"2019-06-10T10:36:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/smrealms/smr/pulls/743","html_url":"https://github.com/smrealms/smr/pull/743","diff_url":"https://github.com/smrealms/smr/pull/743.diff","patch_url":"https://github.com/smrealms/smr/pull/743.patch"},"body":"* Remove unnecessary `in_array` function\r\n* Avoid unnecessarily referencing `window`\r\n* Avoid the need to prepoulate the filter array\r\n\r\nThese changes should make the script a little easier to work with and also avoids modifying the array prototype (generally something to avoid), I haven't tested these because live SMR still has the old html so I can't drop in my changes to test but can do so once it's deployed if you want to wait"},"comment":{"url":"https://api.github.com/repos/smrealms/smr/issues/comments/500371029","html_url":"https://github.com/smrealms/smr/pull/743#issuecomment-500371029","issue_url":"https://api.github.com/repos/smrealms/smr/issues/743","id":500371029,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMDM3MTAyOQ==","user":{"login":"Page-","id":360115,"node_id":"MDQ6VXNlcjM2MDExNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/360115?v=4","gravatar_id":"","url":"https://api.github.com/users/Page-","html_url":"https://github.com/Page-","followers_url":"https://api.github.com/users/Page-/followers","following_url":"https://api.github.com/users/Page-/following{/other_user}","gists_url":"https://api.github.com/users/Page-/gists{/gist_id}","starred_url":"https://api.github.com/users/Page-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Page-/subscriptions","organizations_url":"https://api.github.com/users/Page-/orgs","repos_url":"https://api.github.com/users/Page-/repos","events_url":"https://api.github.com/users/Page-/events{/privacy}","received_events_url":"https://api.github.com/users/Page-/received_events","type":"User","site_admin":false},"created_at":"2019-06-10T10:36:23Z","updated_at":"2019-06-10T10:36:23Z","author_association":"MEMBER","body":"`== null` is a pretty standard way to check nullish in javascript and is usually accepted by linters with an option to be extra strict because it's a common way of checking so I'm guessing you've just configured scrutinizer to be overly strict (`eslint:recommended` is probably a good set of rules to go with)\r\n\r\nThe only alternative I see being used at all is `!x` which actually checks for `x == null || x === '' || x === 0 || ...` but can be equivalent if you know the other options aren't possible (or if they should also be handled the same way).\r\n\r\nBasically I think it's better to allow `== null` and treat it as a language feature that is part of using the language for better or worse (like `!!x` in C and some other languages for converting to a boolean) but if you still feel strongly against it I can change it"}}
{"actor":{"display_login":"Page-"}}