{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-cdk/pulls/comments/311614928","pull_request_review_id":272040425,"id":311614928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTYxNDkyOA==","diff_hunk":"@@ -111,3 +111,42 @@ export class IpTarget implements IApplicationLoadBalancerTarget, INetworkLoadBal\n     };\n   }\n }\n+\n+export class LambdaTarget implements IApplicationLoadBalancerTarget {","path":"packages/@aws-cdk/aws-elasticloadbalancingv2/lib/shared/load-balancer-targets.ts","position":5,"original_position":5,"commit_id":"3e2490834c01e69e7c6b605d0c79cedfacefeefe","original_commit_id":"3e2490834c01e69e7c6b605d0c79cedfacefeefe","user":{"login":"rix0rrr","id":524162,"node_id":"MDQ6VXNlcjUyNDE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/524162?v=4","gravatar_id":"","url":"https://api.github.com/users/rix0rrr","html_url":"https://github.com/rix0rrr","followers_url":"https://api.github.com/users/rix0rrr/followers","following_url":"https://api.github.com/users/rix0rrr/following{/other_user}","gists_url":"https://api.github.com/users/rix0rrr/gists{/gist_id}","starred_url":"https://api.github.com/users/rix0rrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rix0rrr/subscriptions","organizations_url":"https://api.github.com/users/rix0rrr/orgs","repos_url":"https://api.github.com/users/rix0rrr/repos","events_url":"https://api.github.com/users/rix0rrr/events{/privacy}","received_events_url":"https://api.github.com/users/rix0rrr/received_events","type":"User","site_admin":false},"body":"I'm wondering whether this class should go into a separate package, so we can set up dependencies properly so that...","created_at":"2019-08-07T15:21:41Z","updated_at":"2019-08-07T15:25:39Z","html_url":"https://github.com/aws/aws-cdk/pull/3348#discussion_r311614928","pull_request_url":"https://api.github.com/repos/aws/aws-cdk/pulls/3348","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-cdk/pulls/comments/311614928"},"html":{"href":"https://github.com/aws/aws-cdk/pull/3348#discussion_r311614928"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-cdk/pulls/3348"}}},"pull_request":{"url":"https://api.github.com/repos/aws/aws-cdk/pulls/3348","id":299028454,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5MDI4NDU0","html_url":"https://github.com/aws/aws-cdk/pull/3348","diff_url":"https://github.com/aws/aws-cdk/pull/3348.diff","patch_url":"https://github.com/aws/aws-cdk/pull/3348.patch","issue_url":"https://api.github.com/repos/aws/aws-cdk/issues/3348","number":3348,"state":"open","locked":false,"title":"feat(elasticloadbalancing): add support for lambda target","user":{"login":"bweigel","id":6681272,"node_id":"MDQ6VXNlcjY2ODEyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6681272?v=4","gravatar_id":"","url":"https://api.github.com/users/bweigel","html_url":"https://github.com/bweigel","followers_url":"https://api.github.com/users/bweigel/followers","following_url":"https://api.github.com/users/bweigel/following{/other_user}","gists_url":"https://api.github.com/users/bweigel/gists{/gist_id}","starred_url":"https://api.github.com/users/bweigel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bweigel/subscriptions","organizations_url":"https://api.github.com/users/bweigel/orgs","repos_url":"https://api.github.com/users/bweigel/repos","events_url":"https://api.github.com/users/bweigel/events{/privacy}","received_events_url":"https://api.github.com/users/bweigel/received_events","type":"User","site_admin":false},"body":"closes #1921 \r\n\r\n## What it does\r\n\r\nThis PR adds support for lambda targets using ALB.\r\n\r\n## What I did\r\n\r\n- Adds Lambda into TargetType Enum\r\n- uses the existsing `ApplicationTargetGroup` to implement behavior (not needing a vpc for lambdas)\r\n- adds new `LambdaTarget` \r\n\r\n## TODO\r\n\r\n- [x] add tests\r\n- [ ] (optional) add `AWS::Lambda::Permission` for ALB\r\n- [ ] (optional) implement `EventSource` and `EventSourceMapping` to be able to do `lambda.addEventSource(new AlbEventSource(alb));`","created_at":"2019-07-18T18:02:24Z","updated_at":"2019-08-07T15:25:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1708ac7fee54fda9d967eb0c8db7357c2982c71","assignee":{"login":"rix0rrr","id":524162,"node_id":"MDQ6VXNlcjUyNDE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/524162?v=4","gravatar_id":"","url":"https://api.github.com/users/rix0rrr","html_url":"https://github.com/rix0rrr","followers_url":"https://api.github.com/users/rix0rrr/followers","following_url":"https://api.github.com/users/rix0rrr/following{/other_user}","gists_url":"https://api.github.com/users/rix0rrr/gists{/gist_id}","starred_url":"https://api.github.com/users/rix0rrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rix0rrr/subscriptions","organizations_url":"https://api.github.com/users/rix0rrr/orgs","repos_url":"https://api.github.com/users/rix0rrr/repos","events_url":"https://api.github.com/users/rix0rrr/events{/privacy}","received_events_url":"https://api.github.com/users/rix0rrr/received_events","type":"User","site_admin":false},"assignees":[{"login":"rix0rrr","id":524162,"node_id":"MDQ6VXNlcjUyNDE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/524162?v=4","gravatar_id":"","url":"https://api.github.com/users/rix0rrr","html_url":"https://github.com/rix0rrr","followers_url":"https://api.github.com/users/rix0rrr/followers","following_url":"https://api.github.com/users/rix0rrr/following{/other_user}","gists_url":"https://api.github.com/users/rix0rrr/gists{/gist_id}","starred_url":"https://api.github.com/users/rix0rrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rix0rrr/subscriptions","organizations_url":"https://api.github.com/users/rix0rrr/orgs","repos_url":"https://api.github.com/users/rix0rrr/repos","events_url":"https://api.github.com/users/rix0rrr/events{/privacy}","received_events_url":"https://api.github.com/users/rix0rrr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-cdk/pulls/3348/commits","review_comments_url":"https://api.github.com/repos/aws/aws-cdk/pulls/3348/comments","review_comment_url":"https://api.github.com/repos/aws/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-cdk/issues/3348/comments","statuses_url":"https://api.github.com/repos/aws/aws-cdk/statuses/3e2490834c01e69e7c6b605d0c79cedfacefeefe","head":{"label":"bweigel:alb-lambda-target","ref":"alb-lambda-target","sha":"3e2490834c01e69e7c6b605d0c79cedfacefeefe","user":{"login":"bweigel","id":6681272,"node_id":"MDQ6VXNlcjY2ODEyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6681272?v=4","gravatar_id":"","url":"https://api.github.com/users/bweigel","html_url":"https://github.com/bweigel","followers_url":"https://api.github.com/users/bweigel/followers","following_url":"https://api.github.com/users/bweigel/following{/other_user}","gists_url":"https://api.github.com/users/bweigel/gists{/gist_id}","starred_url":"https://api.github.com/users/bweigel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bweigel/subscriptions","organizations_url":"https://api.github.com/users/bweigel/orgs","repos_url":"https://api.github.com/users/bweigel/repos","events_url":"https://api.github.com/users/bweigel/events{/privacy}","received_events_url":"https://api.github.com/users/bweigel/received_events","type":"User","site_admin":false},"repo":{"id":193124894,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMxMjQ4OTQ=","name":"aws-cdk","full_name":"bweigel/aws-cdk","private":false,"owner":{"login":"bweigel","id":6681272,"node_id":"MDQ6VXNlcjY2ODEyNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6681272?v=4","gravatar_id":"","url":"https://api.github.com/users/bweigel","html_url":"https://github.com/bweigel","followers_url":"https://api.github.com/users/bweigel/followers","following_url":"https://api.github.com/users/bweigel/following{/other_user}","gists_url":"https://api.github.com/users/bweigel/gists{/gist_id}","starred_url":"https://api.github.com/users/bweigel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bweigel/subscriptions","organizations_url":"https://api.github.com/users/bweigel/orgs","repos_url":"https://api.github.com/users/bweigel/repos","events_url":"https://api.github.com/users/bweigel/events{/privacy}","received_events_url":"https://api.github.com/users/bweigel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bweigel/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":true,"url":"https://api.github.com/repos/bweigel/aws-cdk","forks_url":"https://api.github.com/repos/bweigel/aws-cdk/forks","keys_url":"https://api.github.com/repos/bweigel/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bweigel/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bweigel/aws-cdk/teams","hooks_url":"https://api.github.com/repos/bweigel/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/bweigel/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/bweigel/aws-cdk/events","assignees_url":"https://api.github.com/repos/bweigel/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/bweigel/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/bweigel/aws-cdk/tags","blobs_url":"https://api.github.com/repos/bweigel/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bweigel/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bweigel/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bweigel/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bweigel/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bweigel/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/bweigel/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/bweigel/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/bweigel/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/bweigel/aws-cdk/subscription","commits_url":"https://api.github.com/repos/bweigel/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bweigel/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bweigel/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bweigel/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bweigel/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/bweigel/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bweigel/aws-cdk/merges","archive_url":"https://api.github.com/repos/bweigel/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bweigel/aws-cdk/downloads","issues_url":"https://api.github.com/repos/bweigel/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/bweigel/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bweigel/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bweigel/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bweigel/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/bweigel/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/bweigel/aws-cdk/deployments","created_at":"2019-06-21T15:53:00Z","updated_at":"2019-07-15T18:05:22Z","pushed_at":"2019-08-06T17:24:07Z","git_url":"git://github.com/bweigel/aws-cdk.git","ssh_url":"git@github.com:bweigel/aws-cdk.git","clone_url":"https://github.com/bweigel/aws-cdk.git","svn_url":"https://github.com/bweigel/aws-cdk","homepage":"https://docs.aws.amazon.com/cdk","size":64958,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"ebaa1b5fc2caefdbf02e9f0ac60269dceedf15f0","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"aws/aws-cdk","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/aws/aws-cdk","forks_url":"https://api.github.com/repos/aws/aws-cdk/forks","keys_url":"https://api.github.com/repos/aws/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-cdk/teams","hooks_url":"https://api.github.com/repos/aws/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-cdk/events","assignees_url":"https://api.github.com/repos/aws/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-cdk/tags","blobs_url":"https://api.github.com/repos/aws/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/aws/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-cdk/subscription","commits_url":"https://api.github.com/repos/aws/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-cdk/merges","archive_url":"https://api.github.com/repos/aws/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-cdk/downloads","issues_url":"https://api.github.com/repos/aws/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2019-08-07T15:21:36Z","pushed_at":"2019-08-07T15:22:22Z","git_url":"git://github.com/aws/aws-cdk.git","ssh_url":"git@github.com:aws/aws-cdk.git","clone_url":"https://github.com/aws/aws-cdk.git","svn_url":"https://github.com/aws/aws-cdk","homepage":"https://aws.amazon.com/cdk","size":63804,"stargazers_count":2885,"watchers_count":2885,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":427,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":811,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":427,"open_issues":811,"watchers":2885,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-cdk/pulls/3348"},"html":{"href":"https://github.com/aws/aws-cdk/pull/3348"},"issue":{"href":"https://api.github.com/repos/aws/aws-cdk/issues/3348"},"comments":{"href":"https://api.github.com/repos/aws/aws-cdk/issues/3348/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-cdk/pulls/3348/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-cdk/pulls/3348/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-cdk/statuses/3e2490834c01e69e7c6b605d0c79cedfacefeefe"}},"author_association":"NONE"}}
{"actor":{"display_login":"rix0rrr"}}