{"action":"created","comment":{"url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/comments/320581339","pull_request_review_id":283387262,"id":320581339,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDU4MTMzOQ==","diff_hunk":"@@ -0,0 +1,36 @@\n+kind: Pod\n+apiVersion: v1\n+metadata:\n+  name: nginx-secrets-store-inline\n+spec:\n+  containers:\n+    - image: nginx\n+      name: nginx\n+      volumeMounts:\n+        - name: secrets-store-inline\n+          mountPath: \"/mnt/secrets-store\"\n+          readOnly: true\n+  volumes:\n+    - name: secrets-store-inline\n+      csi:\n+        driver: secrets-store.csi.k8s.com\n+        readOnly: true\n+        volumeAttributes:\n+          providerName: \"azure\"\n+          usePodIdentity: \"false\" # [OPTIONAL] if not provided, will default to \"false\"\n+          keyvaultName: \"secrets-store-csi-e2e\" # the name of the KeyVault\n+          objects: |\n+            array:\n+              - |\n+                objectName: secret1\n+                objectType: secret        # object types: secret, key or cert\n+                objectVersion: \"\"         # [OPTIONAL] object versions, default to latest if empty\n+              - |\n+                objectName: key1\n+                objectType: key\n+                objectVersion: \"06baad80c1f74e51868fd2271ef2b06c\"\n+          resourceGroup: \"secrets-store-csi-driver-e2e\" # the resource group of the KeyVault\n+          subscriptionId: \"940f88ce-a64b-4e73-a258-9931349b9789\" # the subscription ID of the KeyVault\n+          tenantId: \"microsoft.com\" # the tenant ID of the KeyVault","path":"test/bats/tests/nginx-pod-secrets-store-inline-volume.yaml","position":34,"original_position":34,"commit_id":"c3cde687cbeaef3b6011f844277b624bb298d0de","original_commit_id":"c3cde687cbeaef3b6011f844277b624bb298d0de","user":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"body":"same env var","created_at":"2019-09-04T05:47:31Z","updated_at":"2019-09-04T05:47:31Z","html_url":"https://github.com/deislabs/secrets-store-csi-driver/pull/72#discussion_r320581339","pull_request_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/comments/320581339"},"html":{"href":"https://github.com/deislabs/secrets-store-csi-driver/pull/72#discussion_r320581339"},"pull_request":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72","id":313820311,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzODIwMzEx","html_url":"https://github.com/deislabs/secrets-store-csi-driver/pull/72","diff_url":"https://github.com/deislabs/secrets-store-csi-driver/pull/72.diff","patch_url":"https://github.com/deislabs/secrets-store-csi-driver/pull/72.patch","issue_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/72","number":72,"state":"open","locked":false,"title":"add e2e tests","user":{"login":"sozercan","id":852750,"node_id":"MDQ6VXNlcjg1Mjc1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/852750?v=4","gravatar_id":"","url":"https://api.github.com/users/sozercan","html_url":"https://github.com/sozercan","followers_url":"https://api.github.com/users/sozercan/followers","following_url":"https://api.github.com/users/sozercan/following{/other_user}","gists_url":"https://api.github.com/users/sozercan/gists{/gist_id}","starred_url":"https://api.github.com/users/sozercan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozercan/subscriptions","organizations_url":"https://api.github.com/users/sozercan/orgs","repos_url":"https://api.github.com/users/sozercan/repos","events_url":"https://api.github.com/users/sozercan/events{/privacy}","received_events_url":"https://api.github.com/users/sozercan/received_events","type":"User","site_admin":false},"body":"Closes #2 and #44\r\n\r\n- Adds e2e with kind cluster using travis (uses feature gate for CSI Inline volume)\r\n- Adds azure e2e test for csi inline volume\r\n- updates Azure Go SDK due to issue with apache thrift repo move","created_at":"2019-09-04T01:13:07Z","updated_at":"2019-09-04T05:47:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1de7b70f4d678ed9b4ca8df20c00588fd6f63333","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aramase","id":10608509,"node_id":"MDQ6VXNlcjEwNjA4NTA5","avatar_url":"https://avatars3.githubusercontent.com/u/10608509?v=4","gravatar_id":"","url":"https://api.github.com/users/aramase","html_url":"https://github.com/aramase","followers_url":"https://api.github.com/users/aramase/followers","following_url":"https://api.github.com/users/aramase/following{/other_user}","gists_url":"https://api.github.com/users/aramase/gists{/gist_id}","starred_url":"https://api.github.com/users/aramase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aramase/subscriptions","organizations_url":"https://api.github.com/users/aramase/orgs","repos_url":"https://api.github.com/users/aramase/repos","events_url":"https://api.github.com/users/aramase/events{/privacy}","received_events_url":"https://api.github.com/users/aramase/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72/commits","review_comments_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72/comments","review_comment_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/72/comments","statuses_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/statuses/c3cde687cbeaef3b6011f844277b624bb298d0de","head":{"label":"deislabs:e2e","ref":"e2e","sha":"c3cde687cbeaef3b6011f844277b624bb298d0de","user":{"login":"deislabs","id":44041561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDQxNTYx","avatar_url":"https://avatars1.githubusercontent.com/u/44041561?v=4","gravatar_id":"","url":"https://api.github.com/users/deislabs","html_url":"https://github.com/deislabs","followers_url":"https://api.github.com/users/deislabs/followers","following_url":"https://api.github.com/users/deislabs/following{/other_user}","gists_url":"https://api.github.com/users/deislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/deislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deislabs/subscriptions","organizations_url":"https://api.github.com/users/deislabs/orgs","repos_url":"https://api.github.com/users/deislabs/repos","events_url":"https://api.github.com/users/deislabs/events{/privacy}","received_events_url":"https://api.github.com/users/deislabs/received_events","type":"Organization","site_admin":false},"repo":{"id":163906733,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM5MDY3MzM=","name":"secrets-store-csi-driver","full_name":"deislabs/secrets-store-csi-driver","private":false,"owner":{"login":"deislabs","id":44041561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDQxNTYx","avatar_url":"https://avatars1.githubusercontent.com/u/44041561?v=4","gravatar_id":"","url":"https://api.github.com/users/deislabs","html_url":"https://github.com/deislabs","followers_url":"https://api.github.com/users/deislabs/followers","following_url":"https://api.github.com/users/deislabs/following{/other_user}","gists_url":"https://api.github.com/users/deislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/deislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deislabs/subscriptions","organizations_url":"https://api.github.com/users/deislabs/orgs","repos_url":"https://api.github.com/users/deislabs/repos","events_url":"https://api.github.com/users/deislabs/events{/privacy}","received_events_url":"https://api.github.com/users/deislabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deislabs/secrets-store-csi-driver","description":"Secrets Store CSI driver for Kubernetes secrets - Integrates secrets stores with Kubernetes via a CSI volume.  ","fork":false,"url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver","forks_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/forks","keys_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/teams","hooks_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/hooks","issue_events_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/events{/number}","events_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/events","assignees_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/assignees{/user}","branches_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/branches{/branch}","tags_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/tags","blobs_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/languages","stargazers_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/stargazers","contributors_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/contributors","subscribers_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/subscribers","subscription_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/subscription","commits_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/contents/{+path}","compare_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/merges","archive_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/downloads","issues_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues{/number}","pulls_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/labels{/name}","releases_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/releases{/id}","deployments_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/deployments","created_at":"2019-01-03T01:12:13Z","updated_at":"2019-09-03T17:01:47Z","pushed_at":"2019-09-04T05:16:56Z","git_url":"git://github.com/deislabs/secrets-store-csi-driver.git","ssh_url":"git@github.com:deislabs/secrets-store-csi-driver.git","clone_url":"https://github.com/deislabs/secrets-store-csi-driver.git","svn_url":"https://github.com/deislabs/secrets-store-csi-driver","homepage":"","size":104696,"stargazers_count":68,"watchers_count":68,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":28,"watchers":68,"default_branch":"master"}},"base":{"label":"deislabs:master","ref":"master","sha":"9bc50fe6294fa819f7f18e4697c4e53c0aff03a7","user":{"login":"deislabs","id":44041561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDQxNTYx","avatar_url":"https://avatars1.githubusercontent.com/u/44041561?v=4","gravatar_id":"","url":"https://api.github.com/users/deislabs","html_url":"https://github.com/deislabs","followers_url":"https://api.github.com/users/deislabs/followers","following_url":"https://api.github.com/users/deislabs/following{/other_user}","gists_url":"https://api.github.com/users/deislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/deislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deislabs/subscriptions","organizations_url":"https://api.github.com/users/deislabs/orgs","repos_url":"https://api.github.com/users/deislabs/repos","events_url":"https://api.github.com/users/deislabs/events{/privacy}","received_events_url":"https://api.github.com/users/deislabs/received_events","type":"Organization","site_admin":false},"repo":{"id":163906733,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM5MDY3MzM=","name":"secrets-store-csi-driver","full_name":"deislabs/secrets-store-csi-driver","private":false,"owner":{"login":"deislabs","id":44041561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDQxNTYx","avatar_url":"https://avatars1.githubusercontent.com/u/44041561?v=4","gravatar_id":"","url":"https://api.github.com/users/deislabs","html_url":"https://github.com/deislabs","followers_url":"https://api.github.com/users/deislabs/followers","following_url":"https://api.github.com/users/deislabs/following{/other_user}","gists_url":"https://api.github.com/users/deislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/deislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deislabs/subscriptions","organizations_url":"https://api.github.com/users/deislabs/orgs","repos_url":"https://api.github.com/users/deislabs/repos","events_url":"https://api.github.com/users/deislabs/events{/privacy}","received_events_url":"https://api.github.com/users/deislabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deislabs/secrets-store-csi-driver","description":"Secrets Store CSI driver for Kubernetes secrets - Integrates secrets stores with Kubernetes via a CSI volume.  ","fork":false,"url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver","forks_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/forks","keys_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/teams","hooks_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/hooks","issue_events_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/events{/number}","events_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/events","assignees_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/assignees{/user}","branches_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/branches{/branch}","tags_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/tags","blobs_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/languages","stargazers_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/stargazers","contributors_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/contributors","subscribers_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/subscribers","subscription_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/subscription","commits_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/contents/{+path}","compare_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/merges","archive_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/downloads","issues_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues{/number}","pulls_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/labels{/name}","releases_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/releases{/id}","deployments_url":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/deployments","created_at":"2019-01-03T01:12:13Z","updated_at":"2019-09-03T17:01:47Z","pushed_at":"2019-09-04T05:16:56Z","git_url":"git://github.com/deislabs/secrets-store-csi-driver.git","ssh_url":"git@github.com:deislabs/secrets-store-csi-driver.git","clone_url":"https://github.com/deislabs/secrets-store-csi-driver.git","svn_url":"https://github.com/deislabs/secrets-store-csi-driver","homepage":"","size":104696,"stargazers_count":68,"watchers_count":68,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":28,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72"},"html":{"href":"https://github.com/deislabs/secrets-store-csi-driver/pull/72"},"issue":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/72"},"comments":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/deislabs/secrets-store-csi-driver/statuses/c3cde687cbeaef3b6011f844277b624bb298d0de"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ritazh"}}