{"action":"closed","number":12407,"pull_request":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/12407","id":299622141,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NjIyMTQx","html_url":"https://github.com/aspnet/AspNetCore/pull/12407","diff_url":"https://github.com/aspnet/AspNetCore/pull/12407.diff","patch_url":"https://github.com/aspnet/AspNetCore/pull/12407.patch","issue_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/12407","number":12407,"state":"closed","locked":false,"title":"Clear unused routing params. Fixes #7419","user":{"login":"SteveSandersonMS","id":1101362,"node_id":"MDQ6VXNlcjExMDEzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1101362?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"body":"This implements the plan described in #7419, i.e., that when routing, we always supply *all* the possible route parameters for the target component (supplying `default` for any not in the matched URL).\r\n\r\n**Still to do:** Run all the other E2E tests to be sure this doesn't break anything.","created_at":"2019-07-21T09:17:13Z","updated_at":"2019-07-22T03:00:04Z","closed_at":"2019-07-22T03:00:04Z","merged_at":"2019-07-22T03:00:04Z","merge_commit_sha":"2c3a44371a651e31d10ed1969b1f0a86335214ee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pranavkm","id":174281,"node_id":"MDQ6VXNlcjE3NDI4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/174281?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},{"login":"javiercn","id":6995051,"node_id":"MDQ6VXNlcjY5OTUwNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6995051?v=4","gravatar_id":"","url":"https://api.github.com/users/javiercn","html_url":"https://github.com/javiercn","followers_url":"https://api.github.com/users/javiercn/followers","following_url":"https://api.github.com/users/javiercn/following{/other_user}","gists_url":"https://api.github.com/users/javiercn/gists{/gist_id}","starred_url":"https://api.github.com/users/javiercn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiercn/subscriptions","organizations_url":"https://api.github.com/users/javiercn/orgs","repos_url":"https://api.github.com/users/javiercn/repos","events_url":"https://api.github.com/users/javiercn/events{/privacy}","received_events_url":"https://api.github.com/users/javiercn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1164776385,"node_id":"MDU6TGFiZWwxMTY0Nzc2Mzg1","url":"https://api.github.com/repos/aspnet/AspNetCore/labels/area-blazor","name":"area-blazor","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/aspnet/AspNetCore/milestones/49","html_url":"https://github.com/aspnet/AspNetCore/milestone/49","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones/49/labels","id":4387477,"node_id":"MDk6TWlsZXN0b25lNDM4NzQ3Nw==","number":49,"title":"3.0.0-preview9","description":null,"creator":{"login":"mkArtakMSFT","id":34246760,"node_id":"MDQ6VXNlcjM0MjQ2NzYw","avatar_url":"https://avatars3.githubusercontent.com/u/34246760?v=4","gravatar_id":"","url":"https://api.github.com/users/mkArtakMSFT","html_url":"https://github.com/mkArtakMSFT","followers_url":"https://api.github.com/users/mkArtakMSFT/followers","following_url":"https://api.github.com/users/mkArtakMSFT/following{/other_user}","gists_url":"https://api.github.com/users/mkArtakMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/mkArtakMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkArtakMSFT/subscriptions","organizations_url":"https://api.github.com/users/mkArtakMSFT/orgs","repos_url":"https://api.github.com/users/mkArtakMSFT/repos","events_url":"https://api.github.com/users/mkArtakMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/mkArtakMSFT/received_events","type":"User","site_admin":false},"open_issues":71,"closed_issues":23,"state":"open","created_at":"2019-06-07T17:35:39Z","updated_at":"2019-07-22T03:00:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/12407/commits","review_comments_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/12407/comments","review_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/12407/comments","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/9275cde003cd98fe102894ea2ef443e6e8001d95","head":{"label":"aspnet:stevesa/7419-clear-unused-routing-params","ref":"stevesa/7419-clear-unused-routing-params","sha":"9275cde003cd98fe102894ea2ef443e6e8001d95","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-07-22T02:23:13Z","pushed_at":"2019-07-22T03:00:04Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":289885,"stargazers_count":12789,"watchers_count":12789,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3122,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1994,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3122,"open_issues":1994,"watchers":12789,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"ac7f30e63bb215041e95f0257277fc9efd9758b8","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-07-22T02:23:13Z","pushed_at":"2019-07-22T03:00:04Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"git@github.com:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":289885,"stargazers_count":12789,"watchers_count":12789,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3122,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1994,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3122,"open_issues":1994,"watchers":12789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/12407"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/12407"},"issue":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/12407"},"comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/12407/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/12407/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/12407/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/AspNetCore/statuses/9275cde003cd98fe102894ea2ef443e6e8001d95"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"SteveSandersonMS","id":1101362,"node_id":"MDQ6VXNlcjExMDEzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1101362?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"comments":1,"review_comments":7,"maintainer_can_modify":false,"commits":4,"additions":150,"deletions":48,"changed_files":9}}
{"actor":{"display_login":"SteveSandersonMS"}}