{"action":"created","comment":{"url":"https://api.github.com/repos/bluzelle/swarmDB/pulls/comments/294934070","pull_request_review_id":251235177,"id":294934070,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NDkzNDA3MA==","diff_hunk":"@@ -352,21 +352,35 @@ pbft::forward_request_to_primary(const bzn_envelope& request_env)\n     this->failure_detector->request_seen(req_hash);\n }\n \n+\n void\n-pbft::maybe_record_request(const pbft_msg& msg, const std::shared_ptr<pbft_operation>& op)\n+pbft::maybe_record_request(const pbft_msg& msg, const bzn_envelope& env, const std::shared_ptr<pbft_operation>& op)\n {\n-    if (msg.has_request() && !op->has_request())","path":"pbft/pbft.cpp","position":9,"original_position":9,"commit_id":"7d5bd7787ada2d2434845d08356becb76a9805ce","original_commit_id":"7d5bd7787ada2d2434845d08356becb76a9805ce","user":{"login":"isabelsavannah","id":36646585,"node_id":"MDQ6VXNlcjM2NjQ2NTg1","avatar_url":"https://avatars1.githubusercontent.com/u/36646585?v=4","gravatar_id":"","url":"https://api.github.com/users/isabelsavannah","html_url":"https://github.com/isabelsavannah","followers_url":"https://api.github.com/users/isabelsavannah/followers","following_url":"https://api.github.com/users/isabelsavannah/following{/other_user}","gists_url":"https://api.github.com/users/isabelsavannah/gists{/gist_id}","starred_url":"https://api.github.com/users/isabelsavannah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabelsavannah/subscriptions","organizations_url":"https://api.github.com/users/isabelsavannah/orgs","repos_url":"https://api.github.com/users/isabelsavannah/repos","events_url":"https://api.github.com/users/isabelsavannah/events{/privacy}","received_events_url":"https://api.github.com/users/isabelsavannah/received_events","type":"User","site_admin":false},"body":"Are we somehow getting the request body for internal requests as well here?","created_at":"2019-06-18T17:13:22Z","updated_at":"2019-06-18T17:24:09Z","html_url":"https://github.com/bluzelle/swarmDB/pull/331#discussion_r294934070","pull_request_url":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bluzelle/swarmDB/pulls/comments/294934070"},"html":{"href":"https://github.com/bluzelle/swarmDB/pull/331#discussion_r294934070"},"pull_request":{"href":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331","id":289020942,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MDIwOTQy","html_url":"https://github.com/bluzelle/swarmDB/pull/331","diff_url":"https://github.com/bluzelle/swarmDB/pull/331.diff","patch_url":"https://github.com/bluzelle/swarmDB/pull/331.patch","issue_url":"https://api.github.com/repos/bluzelle/swarmDB/issues/331","number":331,"state":"open","locked":false,"title":"KEP-823 Remove Full Request from Saved and Retransmitted Pre-prepares","user":{"login":"rnistuk","id":166319,"node_id":"MDQ6VXNlcjE2NjMxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/166319?v=4","gravatar_id":"","url":"https://api.github.com/users/rnistuk","html_url":"https://github.com/rnistuk","followers_url":"https://api.github.com/users/rnistuk/followers","following_url":"https://api.github.com/users/rnistuk/following{/other_user}","gists_url":"https://api.github.com/users/rnistuk/gists{/gist_id}","starred_url":"https://api.github.com/users/rnistuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnistuk/subscriptions","organizations_url":"https://api.github.com/users/rnistuk/orgs","repos_url":"https://api.github.com/users/rnistuk/repos","events_url":"https://api.github.com/users/rnistuk/events{/privacy}","received_events_url":"https://api.github.com/users/rnistuk/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-17T21:07:43Z","updated_at":"2019-06-18T17:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fa933a4222974afb5f4886d97cc8f1a1c7bb13e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331/commits","review_comments_url":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331/comments","review_comment_url":"https://api.github.com/repos/bluzelle/swarmDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bluzelle/swarmDB/issues/331/comments","statuses_url":"https://api.github.com/repos/bluzelle/swarmDB/statuses/7d5bd7787ada2d2434845d08356becb76a9805ce","head":{"label":"bluzelle:story/rnistuk/kep-823","ref":"story/rnistuk/kep-823","sha":"7d5bd7787ada2d2434845d08356becb76a9805ce","user":{"login":"bluzelle","id":23650344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjUwMzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23650344?v=4","gravatar_id":"","url":"https://api.github.com/users/bluzelle","html_url":"https://github.com/bluzelle","followers_url":"https://api.github.com/users/bluzelle/followers","following_url":"https://api.github.com/users/bluzelle/following{/other_user}","gists_url":"https://api.github.com/users/bluzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/bluzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluzelle/subscriptions","organizations_url":"https://api.github.com/users/bluzelle/orgs","repos_url":"https://api.github.com/users/bluzelle/repos","events_url":"https://api.github.com/users/bluzelle/events{/privacy}","received_events_url":"https://api.github.com/users/bluzelle/received_events","type":"Organization","site_admin":false},"repo":{"id":95110830,"node_id":"MDEwOlJlcG9zaXRvcnk5NTExMDgzMA==","name":"swarmDB","full_name":"bluzelle/swarmDB","private":false,"owner":{"login":"bluzelle","id":23650344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjUwMzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23650344?v=4","gravatar_id":"","url":"https://api.github.com/users/bluzelle","html_url":"https://github.com/bluzelle","followers_url":"https://api.github.com/users/bluzelle/followers","following_url":"https://api.github.com/users/bluzelle/following{/other_user}","gists_url":"https://api.github.com/users/bluzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/bluzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluzelle/subscriptions","organizations_url":"https://api.github.com/users/bluzelle/orgs","repos_url":"https://api.github.com/users/bluzelle/repos","events_url":"https://api.github.com/users/bluzelle/events{/privacy}","received_events_url":"https://api.github.com/users/bluzelle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bluzelle/swarmDB","description":"Bluzelle is a smart, in-memory data store. It can be used as a cache or as a database. ","fork":false,"url":"https://api.github.com/repos/bluzelle/swarmDB","forks_url":"https://api.github.com/repos/bluzelle/swarmDB/forks","keys_url":"https://api.github.com/repos/bluzelle/swarmDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluzelle/swarmDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluzelle/swarmDB/teams","hooks_url":"https://api.github.com/repos/bluzelle/swarmDB/hooks","issue_events_url":"https://api.github.com/repos/bluzelle/swarmDB/issues/events{/number}","events_url":"https://api.github.com/repos/bluzelle/swarmDB/events","assignees_url":"https://api.github.com/repos/bluzelle/swarmDB/assignees{/user}","branches_url":"https://api.github.com/repos/bluzelle/swarmDB/branches{/branch}","tags_url":"https://api.github.com/repos/bluzelle/swarmDB/tags","blobs_url":"https://api.github.com/repos/bluzelle/swarmDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluzelle/swarmDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluzelle/swarmDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluzelle/swarmDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluzelle/swarmDB/statuses/{sha}","languages_url":"https://api.github.com/repos/bluzelle/swarmDB/languages","stargazers_url":"https://api.github.com/repos/bluzelle/swarmDB/stargazers","contributors_url":"https://api.github.com/repos/bluzelle/swarmDB/contributors","subscribers_url":"https://api.github.com/repos/bluzelle/swarmDB/subscribers","subscription_url":"https://api.github.com/repos/bluzelle/swarmDB/subscription","commits_url":"https://api.github.com/repos/bluzelle/swarmDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluzelle/swarmDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluzelle/swarmDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluzelle/swarmDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluzelle/swarmDB/contents/{+path}","compare_url":"https://api.github.com/repos/bluzelle/swarmDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluzelle/swarmDB/merges","archive_url":"https://api.github.com/repos/bluzelle/swarmDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluzelle/swarmDB/downloads","issues_url":"https://api.github.com/repos/bluzelle/swarmDB/issues{/number}","pulls_url":"https://api.github.com/repos/bluzelle/swarmDB/pulls{/number}","milestones_url":"https://api.github.com/repos/bluzelle/swarmDB/milestones{/number}","notifications_url":"https://api.github.com/repos/bluzelle/swarmDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluzelle/swarmDB/labels{/name}","releases_url":"https://api.github.com/repos/bluzelle/swarmDB/releases{/id}","deployments_url":"https://api.github.com/repos/bluzelle/swarmDB/deployments","created_at":"2017-06-22T11:59:32Z","updated_at":"2019-06-13T18:11:30Z","pushed_at":"2019-06-17T21:07:44Z","git_url":"git://github.com/bluzelle/swarmDB.git","ssh_url":"git@github.com:bluzelle/swarmDB.git","clone_url":"https://github.com/bluzelle/swarmDB.git","svn_url":"https://github.com/bluzelle/swarmDB","homepage":"https://www.bluzelle.com","size":10949,"stargazers_count":203,"watchers_count":203,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":30,"open_issues":1,"watchers":203,"default_branch":"devel"}},"base":{"label":"bluzelle:devel","ref":"devel","sha":"5db9ceb4c44456c21405b95ec29ba91a43ba77d3","user":{"login":"bluzelle","id":23650344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjUwMzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23650344?v=4","gravatar_id":"","url":"https://api.github.com/users/bluzelle","html_url":"https://github.com/bluzelle","followers_url":"https://api.github.com/users/bluzelle/followers","following_url":"https://api.github.com/users/bluzelle/following{/other_user}","gists_url":"https://api.github.com/users/bluzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/bluzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluzelle/subscriptions","organizations_url":"https://api.github.com/users/bluzelle/orgs","repos_url":"https://api.github.com/users/bluzelle/repos","events_url":"https://api.github.com/users/bluzelle/events{/privacy}","received_events_url":"https://api.github.com/users/bluzelle/received_events","type":"Organization","site_admin":false},"repo":{"id":95110830,"node_id":"MDEwOlJlcG9zaXRvcnk5NTExMDgzMA==","name":"swarmDB","full_name":"bluzelle/swarmDB","private":false,"owner":{"login":"bluzelle","id":23650344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjUwMzQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23650344?v=4","gravatar_id":"","url":"https://api.github.com/users/bluzelle","html_url":"https://github.com/bluzelle","followers_url":"https://api.github.com/users/bluzelle/followers","following_url":"https://api.github.com/users/bluzelle/following{/other_user}","gists_url":"https://api.github.com/users/bluzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/bluzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluzelle/subscriptions","organizations_url":"https://api.github.com/users/bluzelle/orgs","repos_url":"https://api.github.com/users/bluzelle/repos","events_url":"https://api.github.com/users/bluzelle/events{/privacy}","received_events_url":"https://api.github.com/users/bluzelle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bluzelle/swarmDB","description":"Bluzelle is a smart, in-memory data store. It can be used as a cache or as a database. ","fork":false,"url":"https://api.github.com/repos/bluzelle/swarmDB","forks_url":"https://api.github.com/repos/bluzelle/swarmDB/forks","keys_url":"https://api.github.com/repos/bluzelle/swarmDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluzelle/swarmDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluzelle/swarmDB/teams","hooks_url":"https://api.github.com/repos/bluzelle/swarmDB/hooks","issue_events_url":"https://api.github.com/repos/bluzelle/swarmDB/issues/events{/number}","events_url":"https://api.github.com/repos/bluzelle/swarmDB/events","assignees_url":"https://api.github.com/repos/bluzelle/swarmDB/assignees{/user}","branches_url":"https://api.github.com/repos/bluzelle/swarmDB/branches{/branch}","tags_url":"https://api.github.com/repos/bluzelle/swarmDB/tags","blobs_url":"https://api.github.com/repos/bluzelle/swarmDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluzelle/swarmDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluzelle/swarmDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluzelle/swarmDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluzelle/swarmDB/statuses/{sha}","languages_url":"https://api.github.com/repos/bluzelle/swarmDB/languages","stargazers_url":"https://api.github.com/repos/bluzelle/swarmDB/stargazers","contributors_url":"https://api.github.com/repos/bluzelle/swarmDB/contributors","subscribers_url":"https://api.github.com/repos/bluzelle/swarmDB/subscribers","subscription_url":"https://api.github.com/repos/bluzelle/swarmDB/subscription","commits_url":"https://api.github.com/repos/bluzelle/swarmDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluzelle/swarmDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluzelle/swarmDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluzelle/swarmDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluzelle/swarmDB/contents/{+path}","compare_url":"https://api.github.com/repos/bluzelle/swarmDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluzelle/swarmDB/merges","archive_url":"https://api.github.com/repos/bluzelle/swarmDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluzelle/swarmDB/downloads","issues_url":"https://api.github.com/repos/bluzelle/swarmDB/issues{/number}","pulls_url":"https://api.github.com/repos/bluzelle/swarmDB/pulls{/number}","milestones_url":"https://api.github.com/repos/bluzelle/swarmDB/milestones{/number}","notifications_url":"https://api.github.com/repos/bluzelle/swarmDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluzelle/swarmDB/labels{/name}","releases_url":"https://api.github.com/repos/bluzelle/swarmDB/releases{/id}","deployments_url":"https://api.github.com/repos/bluzelle/swarmDB/deployments","created_at":"2017-06-22T11:59:32Z","updated_at":"2019-06-13T18:11:30Z","pushed_at":"2019-06-17T21:07:44Z","git_url":"git://github.com/bluzelle/swarmDB.git","ssh_url":"git@github.com:bluzelle/swarmDB.git","clone_url":"https://github.com/bluzelle/swarmDB.git","svn_url":"https://github.com/bluzelle/swarmDB","homepage":"https://www.bluzelle.com","size":10949,"stargazers_count":203,"watchers_count":203,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":30,"open_issues":1,"watchers":203,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331"},"html":{"href":"https://github.com/bluzelle/swarmDB/pull/331"},"issue":{"href":"https://api.github.com/repos/bluzelle/swarmDB/issues/331"},"comments":{"href":"https://api.github.com/repos/bluzelle/swarmDB/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/bluzelle/swarmDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bluzelle/swarmDB/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/bluzelle/swarmDB/statuses/7d5bd7787ada2d2434845d08356becb76a9805ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isabelsavannah"}}