{"action":"created","comment":{"url":"https://api.github.com/repos/inmanta/exec/pulls/comments/264164775","pull_request_review_id":212751154,"id":264164775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDE2NDc3NQ==","diff_hunk":"@@ -20,6 +20,24 @@ entity Run extends std::Resource:\n     \"\"\"\n         Run a command with almost exact semantics as the exec type of puppet\n \n+        *The command is not executed in a shell!* This means:\n+        \n+        * shell operators like `;`, `|`, `>` don't work\n+        * variable substitution doesn't work: `echo $PATH` will literally print `$PATH`\n+        * variable substitution doesn't work in environment variables either: setting `PATH` to `$PATH` will result in `command not found`\n+\n+        If want a shell, use the plugin 'in_shell':","path":"model/_init.cf","position":10,"original_position":10,"commit_id":"3cf3f17d7eb95bc3612e887b388739944ea657b2","original_commit_id":"3cf3f17d7eb95bc3612e887b388739944ea657b2","user":{"login":"bartv","id":10819,"node_id":"MDQ6VXNlcjEwODE5","avatar_url":"https://avatars2.githubusercontent.com/u/10819?v=4","gravatar_id":"","url":"https://api.github.com/users/bartv","html_url":"https://github.com/bartv","followers_url":"https://api.github.com/users/bartv/followers","following_url":"https://api.github.com/users/bartv/following{/other_user}","gists_url":"https://api.github.com/users/bartv/gists{/gist_id}","starred_url":"https://api.github.com/users/bartv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartv/subscriptions","organizations_url":"https://api.github.com/users/bartv/orgs","repos_url":"https://api.github.com/users/bartv/repos","events_url":"https://api.github.com/users/bartv/events{/privacy}","received_events_url":"https://api.github.com/users/bartv/received_events","type":"User","site_admin":false},"body":"strange sentence","created_at":"2019-03-11T10:17:11Z","updated_at":"2019-03-11T10:18:00Z","html_url":"https://github.com/inmanta/exec/pull/6#discussion_r264164775","pull_request_url":"https://api.github.com/repos/inmanta/exec/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inmanta/exec/pulls/comments/264164775"},"html":{"href":"https://github.com/inmanta/exec/pull/6#discussion_r264164775"},"pull_request":{"href":"https://api.github.com/repos/inmanta/exec/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/inmanta/exec/pulls/6","id":257450894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NDUwODk0","html_url":"https://github.com/inmanta/exec/pull/6","diff_url":"https://github.com/inmanta/exec/pull/6.diff","patch_url":"https://github.com/inmanta/exec/pull/6.patch","issue_url":"https://api.github.com/repos/inmanta/exec/issues/6","number":6,"state":"open","locked":false,"title":"Issue/4 env vars","user":{"login":"wouterdb","id":1788254,"node_id":"MDQ6VXNlcjE3ODgyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1788254?v=4","gravatar_id":"","url":"https://api.github.com/users/wouterdb","html_url":"https://github.com/wouterdb","followers_url":"https://api.github.com/users/wouterdb/followers","following_url":"https://api.github.com/users/wouterdb/following{/other_user}","gists_url":"https://api.github.com/users/wouterdb/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterdb/subscriptions","organizations_url":"https://api.github.com/users/wouterdb/orgs","repos_url":"https://api.github.com/users/wouterdb/repos","events_url":"https://api.github.com/users/wouterdb/events{/privacy}","received_events_url":"https://api.github.com/users/wouterdb/received_events","type":"User","site_admin":false},"body":"fixes #4 \r\n\r\nclarified the limitations of the exec plugin\r\n\r\n- [x] add testcase to new plugin","created_at":"2019-03-01T13:52:18Z","updated_at":"2019-03-11T10:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c21d2684135359697b6b5af53bba9e80aed6e35d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inmanta/exec/pulls/6/commits","review_comments_url":"https://api.github.com/repos/inmanta/exec/pulls/6/comments","review_comment_url":"https://api.github.com/repos/inmanta/exec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inmanta/exec/issues/6/comments","statuses_url":"https://api.github.com/repos/inmanta/exec/statuses/3cf3f17d7eb95bc3612e887b388739944ea657b2","head":{"label":"inmanta:issue/4-env-vars","ref":"issue/4-env-vars","sha":"3cf3f17d7eb95bc3612e887b388739944ea657b2","user":{"login":"inmanta","id":17945127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTQ1MTI3","avatar_url":"https://avatars1.githubusercontent.com/u/17945127?v=4","gravatar_id":"","url":"https://api.github.com/users/inmanta","html_url":"https://github.com/inmanta","followers_url":"https://api.github.com/users/inmanta/followers","following_url":"https://api.github.com/users/inmanta/following{/other_user}","gists_url":"https://api.github.com/users/inmanta/gists{/gist_id}","starred_url":"https://api.github.com/users/inmanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inmanta/subscriptions","organizations_url":"https://api.github.com/users/inmanta/orgs","repos_url":"https://api.github.com/users/inmanta/repos","events_url":"https://api.github.com/users/inmanta/events{/privacy}","received_events_url":"https://api.github.com/users/inmanta/received_events","type":"Organization","site_admin":false},"repo":{"id":67823739,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgyMzczOQ==","name":"exec","full_name":"inmanta/exec","private":false,"owner":{"login":"inmanta","id":17945127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTQ1MTI3","avatar_url":"https://avatars1.githubusercontent.com/u/17945127?v=4","gravatar_id":"","url":"https://api.github.com/users/inmanta","html_url":"https://github.com/inmanta","followers_url":"https://api.github.com/users/inmanta/followers","following_url":"https://api.github.com/users/inmanta/following{/other_user}","gists_url":"https://api.github.com/users/inmanta/gists{/gist_id}","starred_url":"https://api.github.com/users/inmanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inmanta/subscriptions","organizations_url":"https://api.github.com/users/inmanta/orgs","repos_url":"https://api.github.com/users/inmanta/repos","events_url":"https://api.github.com/users/inmanta/events{/privacy}","received_events_url":"https://api.github.com/users/inmanta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inmanta/exec","description":null,"fork":false,"url":"https://api.github.com/repos/inmanta/exec","forks_url":"https://api.github.com/repos/inmanta/exec/forks","keys_url":"https://api.github.com/repos/inmanta/exec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inmanta/exec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inmanta/exec/teams","hooks_url":"https://api.github.com/repos/inmanta/exec/hooks","issue_events_url":"https://api.github.com/repos/inmanta/exec/issues/events{/number}","events_url":"https://api.github.com/repos/inmanta/exec/events","assignees_url":"https://api.github.com/repos/inmanta/exec/assignees{/user}","branches_url":"https://api.github.com/repos/inmanta/exec/branches{/branch}","tags_url":"https://api.github.com/repos/inmanta/exec/tags","blobs_url":"https://api.github.com/repos/inmanta/exec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inmanta/exec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inmanta/exec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inmanta/exec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inmanta/exec/statuses/{sha}","languages_url":"https://api.github.com/repos/inmanta/exec/languages","stargazers_url":"https://api.github.com/repos/inmanta/exec/stargazers","contributors_url":"https://api.github.com/repos/inmanta/exec/contributors","subscribers_url":"https://api.github.com/repos/inmanta/exec/subscribers","subscription_url":"https://api.github.com/repos/inmanta/exec/subscription","commits_url":"https://api.github.com/repos/inmanta/exec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inmanta/exec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inmanta/exec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inmanta/exec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inmanta/exec/contents/{+path}","compare_url":"https://api.github.com/repos/inmanta/exec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inmanta/exec/merges","archive_url":"https://api.github.com/repos/inmanta/exec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inmanta/exec/downloads","issues_url":"https://api.github.com/repos/inmanta/exec/issues{/number}","pulls_url":"https://api.github.com/repos/inmanta/exec/pulls{/number}","milestones_url":"https://api.github.com/repos/inmanta/exec/milestones{/number}","notifications_url":"https://api.github.com/repos/inmanta/exec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inmanta/exec/labels{/name}","releases_url":"https://api.github.com/repos/inmanta/exec/releases{/id}","deployments_url":"https://api.github.com/repos/inmanta/exec/deployments","created_at":"2016-09-09T18:45:13Z","updated_at":"2019-02-28T11:12:16Z","pushed_at":"2019-03-11T09:12:23Z","git_url":"git://github.com/inmanta/exec.git","ssh_url":"git@github.com:inmanta/exec.git","clone_url":"https://github.com/inmanta/exec.git","svn_url":"https://github.com/inmanta/exec","homepage":null,"size":32,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"inmanta:master","ref":"master","sha":"55f5f04d2fc98141e5a532bd46c92c12310d11ef","user":{"login":"inmanta","id":17945127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTQ1MTI3","avatar_url":"https://avatars1.githubusercontent.com/u/17945127?v=4","gravatar_id":"","url":"https://api.github.com/users/inmanta","html_url":"https://github.com/inmanta","followers_url":"https://api.github.com/users/inmanta/followers","following_url":"https://api.github.com/users/inmanta/following{/other_user}","gists_url":"https://api.github.com/users/inmanta/gists{/gist_id}","starred_url":"https://api.github.com/users/inmanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inmanta/subscriptions","organizations_url":"https://api.github.com/users/inmanta/orgs","repos_url":"https://api.github.com/users/inmanta/repos","events_url":"https://api.github.com/users/inmanta/events{/privacy}","received_events_url":"https://api.github.com/users/inmanta/received_events","type":"Organization","site_admin":false},"repo":{"id":67823739,"node_id":"MDEwOlJlcG9zaXRvcnk2NzgyMzczOQ==","name":"exec","full_name":"inmanta/exec","private":false,"owner":{"login":"inmanta","id":17945127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTQ1MTI3","avatar_url":"https://avatars1.githubusercontent.com/u/17945127?v=4","gravatar_id":"","url":"https://api.github.com/users/inmanta","html_url":"https://github.com/inmanta","followers_url":"https://api.github.com/users/inmanta/followers","following_url":"https://api.github.com/users/inmanta/following{/other_user}","gists_url":"https://api.github.com/users/inmanta/gists{/gist_id}","starred_url":"https://api.github.com/users/inmanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inmanta/subscriptions","organizations_url":"https://api.github.com/users/inmanta/orgs","repos_url":"https://api.github.com/users/inmanta/repos","events_url":"https://api.github.com/users/inmanta/events{/privacy}","received_events_url":"https://api.github.com/users/inmanta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inmanta/exec","description":null,"fork":false,"url":"https://api.github.com/repos/inmanta/exec","forks_url":"https://api.github.com/repos/inmanta/exec/forks","keys_url":"https://api.github.com/repos/inmanta/exec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inmanta/exec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inmanta/exec/teams","hooks_url":"https://api.github.com/repos/inmanta/exec/hooks","issue_events_url":"https://api.github.com/repos/inmanta/exec/issues/events{/number}","events_url":"https://api.github.com/repos/inmanta/exec/events","assignees_url":"https://api.github.com/repos/inmanta/exec/assignees{/user}","branches_url":"https://api.github.com/repos/inmanta/exec/branches{/branch}","tags_url":"https://api.github.com/repos/inmanta/exec/tags","blobs_url":"https://api.github.com/repos/inmanta/exec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inmanta/exec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inmanta/exec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inmanta/exec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inmanta/exec/statuses/{sha}","languages_url":"https://api.github.com/repos/inmanta/exec/languages","stargazers_url":"https://api.github.com/repos/inmanta/exec/stargazers","contributors_url":"https://api.github.com/repos/inmanta/exec/contributors","subscribers_url":"https://api.github.com/repos/inmanta/exec/subscribers","subscription_url":"https://api.github.com/repos/inmanta/exec/subscription","commits_url":"https://api.github.com/repos/inmanta/exec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inmanta/exec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inmanta/exec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inmanta/exec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inmanta/exec/contents/{+path}","compare_url":"https://api.github.com/repos/inmanta/exec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inmanta/exec/merges","archive_url":"https://api.github.com/repos/inmanta/exec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inmanta/exec/downloads","issues_url":"https://api.github.com/repos/inmanta/exec/issues{/number}","pulls_url":"https://api.github.com/repos/inmanta/exec/pulls{/number}","milestones_url":"https://api.github.com/repos/inmanta/exec/milestones{/number}","notifications_url":"https://api.github.com/repos/inmanta/exec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inmanta/exec/labels{/name}","releases_url":"https://api.github.com/repos/inmanta/exec/releases{/id}","deployments_url":"https://api.github.com/repos/inmanta/exec/deployments","created_at":"2016-09-09T18:45:13Z","updated_at":"2019-02-28T11:12:16Z","pushed_at":"2019-03-11T09:12:23Z","git_url":"git://github.com/inmanta/exec.git","ssh_url":"git@github.com:inmanta/exec.git","clone_url":"https://github.com/inmanta/exec.git","svn_url":"https://github.com/inmanta/exec","homepage":null,"size":32,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inmanta/exec/pulls/6"},"html":{"href":"https://github.com/inmanta/exec/pull/6"},"issue":{"href":"https://api.github.com/repos/inmanta/exec/issues/6"},"comments":{"href":"https://api.github.com/repos/inmanta/exec/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/inmanta/exec/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/inmanta/exec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inmanta/exec/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/inmanta/exec/statuses/3cf3f17d7eb95bc3612e887b388739944ea657b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bartv"}}