{"action":"created","comment":{"url":"https://api.github.com/repos/grailbio/bigslice/pulls/comments/365548947","pull_request_review_id":341546881,"id":365548947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTU0ODk0Nw==","diff_hunk":"@@ -74,6 +75,10 @@ func setupEc2Cmd(args []string) {\n \t\tmust.True(os.IsNotExist(err), err)\n \t}\n \n+\tif region, ok := profile.Get(\"aws/env.region\"); ok && len(region) > 0 {\n+\t\tmust.Nil(profile.Set(\"bigmachine/ec2system.default-region\", strings.Trim(region, `\"`)))","path":"cmd/bigslice/ec2.go","position":13,"original_position":13,"commit_id":"0d07a334180d1918b8bbf594e14628ceacdd1745","original_commit_id":"0d07a334180d1918b8bbf594e14628ceacdd1745","user":{"login":"cosnicolaou","id":8702560,"node_id":"MDQ6VXNlcjg3MDI1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8702560?v=4","gravatar_id":"","url":"https://api.github.com/users/cosnicolaou","html_url":"https://github.com/cosnicolaou","followers_url":"https://api.github.com/users/cosnicolaou/followers","following_url":"https://api.github.com/users/cosnicolaou/following{/other_user}","gists_url":"https://api.github.com/users/cosnicolaou/gists{/gist_id}","starred_url":"https://api.github.com/users/cosnicolaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosnicolaou/subscriptions","organizations_url":"https://api.github.com/users/cosnicolaou/orgs","repos_url":"https://api.github.com/users/cosnicolaou/repos","events_url":"https://api.github.com/users/cosnicolaou/events{/privacy}","received_events_url":"https://api.github.com/users/cosnicolaou/received_events","type":"User","site_admin":false},"body":"I don't really know all of the code paths that lead to a value being setup here, nor how quotes are expected to be handled by grailbio/config but it's certainly the case the escaped quotes end up here. So in the interests of expediency, and knowing that the region will not have internal quotes, it seemed reasonable to just remove them here.","created_at":"2020-01-12T00:10:54Z","updated_at":"2020-01-12T00:10:55Z","html_url":"https://github.com/grailbio/bigslice/pull/34#discussion_r365548947","pull_request_url":"https://api.github.com/repos/grailbio/bigslice/pulls/34","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/grailbio/bigslice/pulls/comments/365548947"},"html":{"href":"https://github.com/grailbio/bigslice/pull/34#discussion_r365548947"},"pull_request":{"href":"https://api.github.com/repos/grailbio/bigslice/pulls/34"}},"in_reply_to_id":365046837},"pull_request":{"url":"https://api.github.com/repos/grailbio/bigslice/pulls/34","id":360137551,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwMTM3NTUx","html_url":"https://github.com/grailbio/bigslice/pull/34","diff_url":"https://github.com/grailbio/bigslice/pull/34.diff","patch_url":"https://github.com/grailbio/bigslice/pull/34.patch","issue_url":"https://api.github.com/repos/grailbio/bigslice/issues/34","number":34,"state":"open","locked":false,"title":"cmd/bigslice: set DefaultRegion and cleanup error message","user":{"login":"cosnicolaou","id":8702560,"node_id":"MDQ6VXNlcjg3MDI1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8702560?v=4","gravatar_id":"","url":"https://api.github.com/users/cosnicolaou","html_url":"https://github.com/cosnicolaou","followers_url":"https://api.github.com/users/cosnicolaou/followers","following_url":"https://api.github.com/users/cosnicolaou/following{/other_user}","gists_url":"https://api.github.com/users/cosnicolaou/gists{/gist_id}","starred_url":"https://api.github.com/users/cosnicolaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosnicolaou/subscriptions","organizations_url":"https://api.github.com/users/cosnicolaou/orgs","repos_url":"https://api.github.com/users/cosnicolaou/repos","events_url":"https://api.github.com/users/cosnicolaou/events{/privacy}","received_events_url":"https://api.github.com/users/cosnicolaou/received_events","type":"User","site_admin":false},"body":"This PR makes use of the change made [in](https://github.com/grailbio/bigmachine/pull/29) to set a default AWS region if one is present in the bigmachine config. It also improves an error message.\r\n\r\nAlso, dependencies are updated for grailbio/base to v.0.0.6 and not .0.0.5","created_at":"2020-01-07T19:29:53Z","updated_at":"2020-01-12T00:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e38ef1f987c0ead12f9fc706773e290d8637edd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grailbio/bigslice/pulls/34/commits","review_comments_url":"https://api.github.com/repos/grailbio/bigslice/pulls/34/comments","review_comment_url":"https://api.github.com/repos/grailbio/bigslice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grailbio/bigslice/issues/34/comments","statuses_url":"https://api.github.com/repos/grailbio/bigslice/statuses/0d07a334180d1918b8bbf594e14628ceacdd1745","head":{"label":"cosnicolaou:cos-use-better-default-region","ref":"cos-use-better-default-region","sha":"0d07a334180d1918b8bbf594e14628ceacdd1745","user":{"login":"cosnicolaou","id":8702560,"node_id":"MDQ6VXNlcjg3MDI1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8702560?v=4","gravatar_id":"","url":"https://api.github.com/users/cosnicolaou","html_url":"https://github.com/cosnicolaou","followers_url":"https://api.github.com/users/cosnicolaou/followers","following_url":"https://api.github.com/users/cosnicolaou/following{/other_user}","gists_url":"https://api.github.com/users/cosnicolaou/gists{/gist_id}","starred_url":"https://api.github.com/users/cosnicolaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosnicolaou/subscriptions","organizations_url":"https://api.github.com/users/cosnicolaou/orgs","repos_url":"https://api.github.com/users/cosnicolaou/repos","events_url":"https://api.github.com/users/cosnicolaou/events{/privacy}","received_events_url":"https://api.github.com/users/cosnicolaou/received_events","type":"User","site_admin":false},"repo":{"id":214336027,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQzMzYwMjc=","name":"bigslice","full_name":"cosnicolaou/bigslice","private":false,"owner":{"login":"cosnicolaou","id":8702560,"node_id":"MDQ6VXNlcjg3MDI1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8702560?v=4","gravatar_id":"","url":"https://api.github.com/users/cosnicolaou","html_url":"https://github.com/cosnicolaou","followers_url":"https://api.github.com/users/cosnicolaou/followers","following_url":"https://api.github.com/users/cosnicolaou/following{/other_user}","gists_url":"https://api.github.com/users/cosnicolaou/gists{/gist_id}","starred_url":"https://api.github.com/users/cosnicolaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosnicolaou/subscriptions","organizations_url":"https://api.github.com/users/cosnicolaou/orgs","repos_url":"https://api.github.com/users/cosnicolaou/repos","events_url":"https://api.github.com/users/cosnicolaou/events{/privacy}","received_events_url":"https://api.github.com/users/cosnicolaou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cosnicolaou/bigslice","description":"A serverless cluster computing system for the Go programming language","fork":true,"url":"https://api.github.com/repos/cosnicolaou/bigslice","forks_url":"https://api.github.com/repos/cosnicolaou/bigslice/forks","keys_url":"https://api.github.com/repos/cosnicolaou/bigslice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosnicolaou/bigslice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosnicolaou/bigslice/teams","hooks_url":"https://api.github.com/repos/cosnicolaou/bigslice/hooks","issue_events_url":"https://api.github.com/repos/cosnicolaou/bigslice/issues/events{/number}","events_url":"https://api.github.com/repos/cosnicolaou/bigslice/events","assignees_url":"https://api.github.com/repos/cosnicolaou/bigslice/assignees{/user}","branches_url":"https://api.github.com/repos/cosnicolaou/bigslice/branches{/branch}","tags_url":"https://api.github.com/repos/cosnicolaou/bigslice/tags","blobs_url":"https://api.github.com/repos/cosnicolaou/bigslice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosnicolaou/bigslice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosnicolaou/bigslice/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosnicolaou/bigslice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosnicolaou/bigslice/statuses/{sha}","languages_url":"https://api.github.com/repos/cosnicolaou/bigslice/languages","stargazers_url":"https://api.github.com/repos/cosnicolaou/bigslice/stargazers","contributors_url":"https://api.github.com/repos/cosnicolaou/bigslice/contributors","subscribers_url":"https://api.github.com/repos/cosnicolaou/bigslice/subscribers","subscription_url":"https://api.github.com/repos/cosnicolaou/bigslice/subscription","commits_url":"https://api.github.com/repos/cosnicolaou/bigslice/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosnicolaou/bigslice/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosnicolaou/bigslice/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosnicolaou/bigslice/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosnicolaou/bigslice/contents/{+path}","compare_url":"https://api.github.com/repos/cosnicolaou/bigslice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosnicolaou/bigslice/merges","archive_url":"https://api.github.com/repos/cosnicolaou/bigslice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosnicolaou/bigslice/downloads","issues_url":"https://api.github.com/repos/cosnicolaou/bigslice/issues{/number}","pulls_url":"https://api.github.com/repos/cosnicolaou/bigslice/pulls{/number}","milestones_url":"https://api.github.com/repos/cosnicolaou/bigslice/milestones{/number}","notifications_url":"https://api.github.com/repos/cosnicolaou/bigslice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosnicolaou/bigslice/labels{/name}","releases_url":"https://api.github.com/repos/cosnicolaou/bigslice/releases{/id}","deployments_url":"https://api.github.com/repos/cosnicolaou/bigslice/deployments","created_at":"2019-10-11T03:31:26Z","updated_at":"2019-12-05T19:11:34Z","pushed_at":"2020-01-09T17:12:28Z","git_url":"git://github.com/cosnicolaou/bigslice.git","ssh_url":"git@github.com:cosnicolaou/bigslice.git","clone_url":"https://github.com/cosnicolaou/bigslice.git","svn_url":"https://github.com/cosnicolaou/bigslice","homepage":"https://bigslice.io/","size":2455,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grailbio:master","ref":"master","sha":"b756831696d0cc35c20f29ffe231bee07b49dfe3","user":{"login":"grailbio","id":18486108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDg2MTA4","avatar_url":"https://avatars2.githubusercontent.com/u/18486108?v=4","gravatar_id":"","url":"https://api.github.com/users/grailbio","html_url":"https://github.com/grailbio","followers_url":"https://api.github.com/users/grailbio/followers","following_url":"https://api.github.com/users/grailbio/following{/other_user}","gists_url":"https://api.github.com/users/grailbio/gists{/gist_id}","starred_url":"https://api.github.com/users/grailbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grailbio/subscriptions","organizations_url":"https://api.github.com/users/grailbio/orgs","repos_url":"https://api.github.com/users/grailbio/repos","events_url":"https://api.github.com/users/grailbio/events{/privacy}","received_events_url":"https://api.github.com/users/grailbio/received_events","type":"Organization","site_admin":false},"repo":{"id":207667330,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc2NjczMzA=","name":"bigslice","full_name":"grailbio/bigslice","private":false,"owner":{"login":"grailbio","id":18486108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDg2MTA4","avatar_url":"https://avatars2.githubusercontent.com/u/18486108?v=4","gravatar_id":"","url":"https://api.github.com/users/grailbio","html_url":"https://github.com/grailbio","followers_url":"https://api.github.com/users/grailbio/followers","following_url":"https://api.github.com/users/grailbio/following{/other_user}","gists_url":"https://api.github.com/users/grailbio/gists{/gist_id}","starred_url":"https://api.github.com/users/grailbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grailbio/subscriptions","organizations_url":"https://api.github.com/users/grailbio/orgs","repos_url":"https://api.github.com/users/grailbio/repos","events_url":"https://api.github.com/users/grailbio/events{/privacy}","received_events_url":"https://api.github.com/users/grailbio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grailbio/bigslice","description":"A serverless cluster computing system for the Go programming language","fork":false,"url":"https://api.github.com/repos/grailbio/bigslice","forks_url":"https://api.github.com/repos/grailbio/bigslice/forks","keys_url":"https://api.github.com/repos/grailbio/bigslice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grailbio/bigslice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grailbio/bigslice/teams","hooks_url":"https://api.github.com/repos/grailbio/bigslice/hooks","issue_events_url":"https://api.github.com/repos/grailbio/bigslice/issues/events{/number}","events_url":"https://api.github.com/repos/grailbio/bigslice/events","assignees_url":"https://api.github.com/repos/grailbio/bigslice/assignees{/user}","branches_url":"https://api.github.com/repos/grailbio/bigslice/branches{/branch}","tags_url":"https://api.github.com/repos/grailbio/bigslice/tags","blobs_url":"https://api.github.com/repos/grailbio/bigslice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grailbio/bigslice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grailbio/bigslice/git/refs{/sha}","trees_url":"https://api.github.com/repos/grailbio/bigslice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grailbio/bigslice/statuses/{sha}","languages_url":"https://api.github.com/repos/grailbio/bigslice/languages","stargazers_url":"https://api.github.com/repos/grailbio/bigslice/stargazers","contributors_url":"https://api.github.com/repos/grailbio/bigslice/contributors","subscribers_url":"https://api.github.com/repos/grailbio/bigslice/subscribers","subscription_url":"https://api.github.com/repos/grailbio/bigslice/subscription","commits_url":"https://api.github.com/repos/grailbio/bigslice/commits{/sha}","git_commits_url":"https://api.github.com/repos/grailbio/bigslice/git/commits{/sha}","comments_url":"https://api.github.com/repos/grailbio/bigslice/comments{/number}","issue_comment_url":"https://api.github.com/repos/grailbio/bigslice/issues/comments{/number}","contents_url":"https://api.github.com/repos/grailbio/bigslice/contents/{+path}","compare_url":"https://api.github.com/repos/grailbio/bigslice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grailbio/bigslice/merges","archive_url":"https://api.github.com/repos/grailbio/bigslice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grailbio/bigslice/downloads","issues_url":"https://api.github.com/repos/grailbio/bigslice/issues{/number}","pulls_url":"https://api.github.com/repos/grailbio/bigslice/pulls{/number}","milestones_url":"https://api.github.com/repos/grailbio/bigslice/milestones{/number}","notifications_url":"https://api.github.com/repos/grailbio/bigslice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grailbio/bigslice/labels{/name}","releases_url":"https://api.github.com/repos/grailbio/bigslice/releases{/id}","deployments_url":"https://api.github.com/repos/grailbio/bigslice/deployments","created_at":"2019-09-10T21:35:17Z","updated_at":"2020-01-10T13:03:00Z","pushed_at":"2020-01-11T01:28:57Z","git_url":"git://github.com/grailbio/bigslice.git","ssh_url":"git@github.com:grailbio/bigslice.git","clone_url":"https://github.com/grailbio/bigslice.git","svn_url":"https://github.com/grailbio/bigslice","homepage":"https://bigslice.io/","size":2538,"stargazers_count":277,"watchers_count":277,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":8,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grailbio/bigslice/pulls/34"},"html":{"href":"https://github.com/grailbio/bigslice/pull/34"},"issue":{"href":"https://api.github.com/repos/grailbio/bigslice/issues/34"},"comments":{"href":"https://api.github.com/repos/grailbio/bigslice/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/grailbio/bigslice/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/grailbio/bigslice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grailbio/bigslice/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/grailbio/bigslice/statuses/0d07a334180d1918b8bbf594e14628ceacdd1745"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cosnicolaou"}}