{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments/259655059","pull_request_review_id":207188389,"id":259655059,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTY1NTA1OQ==","diff_hunk":"@@ -166,16 +165,18 @@ export default class DirectedGraph extends React.PureComponent<DirectedGraphProp\n     }\n   }\n \n-  _onPositionsDone = (result: Cancelled | PositionsDone) => {\n-    if (!result.isCancelled) {\n+  _onPositionsDone = (result: TCancelled | TPositionsDone) => {\n+    // typescript requires the `=== false` check for correct type inference","path":"packages/plexus/src/DirectedGraph/DirectedGraph.tsx","position":112,"original_position":87,"commit_id":"bfd29f250e982f850b4f61adb1087ab3d89f7abe","original_commit_id":"dda5e5cfed997b6b7fc63a34782f78e4097b40b6","user":{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"body":"Took a bit, but I got this working. Great catch!","created_at":"2019-02-25T01:33:05Z","updated_at":"2019-02-25T01:33:05Z","html_url":"https://github.com/jaegertracing/jaeger-ui/pull/331#discussion_r259655059","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments/259655059"},"html":{"href":"https://github.com/jaegertracing/jaeger-ui/pull/331#discussion_r259655059"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331"}},"in_reply_to_id":259496749},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331","id":253614394,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzNjE0Mzk0","html_url":"https://github.com/jaegertracing/jaeger-ui/pull/331","diff_url":"https://github.com/jaegertracing/jaeger-ui/pull/331.diff","patch_url":"https://github.com/jaegertracing/jaeger-ui/pull/331.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/331","number":331,"state":"open","locked":false,"title":"Shift plexus to TypeScript (from flowtypes)","user":{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"body":"Partially addresses #306.\r\n\r\nOutstanding items for this PR (before feedback):\r\n- [ ] Linting TypeScript in plexus\r\n- [ ] Document the build related changes\r\n- [ ] Misc cleanup","created_at":"2019-02-16T02:43:02Z","updated_at":"2019-02-25T01:33:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4300639f9381c7c2c89dd3dba458363ab58ed5f9","assignee":{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":786707068,"node_id":"MDU6TGFiZWw3ODY3MDcwNjg=","url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels/review","name":"review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/331/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/bfd29f250e982f850b4f61adb1087ab3d89f7abe","head":{"label":"jaegertracing:plexus-to-ts","ref":"plexus-to-ts","sha":"bfd29f250e982f850b4f61adb1087ab3d89f7abe","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":82920852,"node_id":"MDEwOlJlcG9zaXRvcnk4MjkyMDg1Mg==","name":"jaeger-ui","full_name":"jaegertracing/jaeger-ui","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger-ui","description":"Web UI for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-ui","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/deployments","created_at":"2017-02-23T11:30:29Z","updated_at":"2019-02-23T20:17:33Z","pushed_at":"2019-02-24T22:30:59Z","git_url":"git://github.com/jaegertracing/jaeger-ui.git","ssh_url":"git@github.com:jaegertracing/jaeger-ui.git","clone_url":"https://github.com/jaegertracing/jaeger-ui.git","svn_url":"https://github.com/jaegertracing/jaeger-ui","homepage":"http://jaegertracing.io/","size":4743,"stargazers_count":280,"watchers_count":280,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":93,"open_issues":76,"watchers":280,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"c07c41dbf7e21660301b3f44bb84da6185b3b56c","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":82920852,"node_id":"MDEwOlJlcG9zaXRvcnk4MjkyMDg1Mg==","name":"jaeger-ui","full_name":"jaegertracing/jaeger-ui","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger-ui","description":"Web UI for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-ui","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/deployments","created_at":"2017-02-23T11:30:29Z","updated_at":"2019-02-23T20:17:33Z","pushed_at":"2019-02-24T22:30:59Z","git_url":"git://github.com/jaegertracing/jaeger-ui.git","ssh_url":"git@github.com:jaegertracing/jaeger-ui.git","clone_url":"https://github.com/jaegertracing/jaeger-ui.git","svn_url":"https://github.com/jaegertracing/jaeger-ui","homepage":"http://jaegertracing.io/","size":4743,"stargazers_count":280,"watchers_count":280,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":93,"open_issues":76,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331"},"html":{"href":"https://github.com/jaegertracing/jaeger-ui/pull/331"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/331"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-ui/statuses/bfd29f250e982f850b4f61adb1087ab3d89f7abe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tiffon"}}