{"action":"created","comment":{"url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments/257508607","pull_request_review_id":204565163,"id":257508607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzUwODYwNw==","diff_hunk":"@@ -123,7 +125,8 @@ func (s *Service) Start(errChan chan error) (err error) {\n func selfRegister() error {\n \tcommon.LoggingClient.Debug(\"Trying to find Device Service: \" + common.ServiceName)\n \n-\tds, err := common.DeviceServiceClient.DeviceServiceForName(common.ServiceName, nil)\n+\tctx := context.WithValue(context.Background(), common.CorrelationHeader, uuid.New().String())\n+\tds, err := common.DeviceServiceClient.DeviceServiceForName(common.ServiceName, ctx)\n \n \tif err != nil {\n \t\tif errsc, ok := err.(*types.ErrServiceClient); ok && (errsc.StatusCode == http.StatusNotFound) {","path":"service.go","position":25,"original_position":25,"commit_id":"32b4f17d0351a508d680a29298dc6b4551ed7a32","original_commit_id":"32b4f17d0351a508d680a29298dc6b4551ed7a32","user":{"login":"cloudxxx8","id":11695863,"node_id":"MDQ6VXNlcjExNjk1ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/11695863?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudxxx8","html_url":"https://github.com/cloudxxx8","followers_url":"https://api.github.com/users/cloudxxx8/followers","following_url":"https://api.github.com/users/cloudxxx8/following{/other_user}","gists_url":"https://api.github.com/users/cloudxxx8/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudxxx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudxxx8/subscriptions","organizations_url":"https://api.github.com/users/cloudxxx8/orgs","repos_url":"https://api.github.com/users/cloudxxx8/repos","events_url":"https://api.github.com/users/cloudxxx8/events{/privacy}","received_events_url":"https://api.github.com/users/cloudxxx8/received_events","type":"User","site_admin":false},"body":"@tobiasmo1 you are right.  This returned error type is changed several times...\r\nPlease see:\r\nhttps://github.com/edgexfoundry/edgex-go/commit/65d80f6cb45a5483de5233600e275d54995d9d6c#diff-2311174e4ebc3d4be67d0cf62dc5e1d2\r\n\r\nI am opening another issue for this.  Thanks for the reminder.\r\n","created_at":"2019-02-17T14:59:18Z","updated_at":"2019-02-17T14:59:18Z","html_url":"https://github.com/edgexfoundry/device-sdk-go/pull/172#discussion_r257508607","pull_request_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments/257508607"},"html":{"href":"https://github.com/edgexfoundry/device-sdk-go/pull/172#discussion_r257508607"},"pull_request":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172"}},"in_reply_to_id":256724063},"pull_request":{"url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172","id":252955203,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyOTU1MjAz","html_url":"https://github.com/edgexfoundry/device-sdk-go/pull/172","diff_url":"https://github.com/edgexfoundry/device-sdk-go/pull/172.diff","patch_url":"https://github.com/edgexfoundry/device-sdk-go/pull/172.patch","issue_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/172","number":172,"state":"closed","locked":false,"title":"Add context for each client call in edgex","user":{"login":"cloudxxx8","id":11695863,"node_id":"MDQ6VXNlcjExNjk1ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/11695863?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudxxx8","html_url":"https://github.com/cloudxxx8","followers_url":"https://api.github.com/users/cloudxxx8/followers","following_url":"https://api.github.com/users/cloudxxx8/following{/other_user}","gists_url":"https://api.github.com/users/cloudxxx8/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudxxx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudxxx8/subscriptions","organizations_url":"https://api.github.com/users/cloudxxx8/orgs","repos_url":"https://api.github.com/users/cloudxxx8/repos","events_url":"https://api.github.com/users/cloudxxx8/events{/privacy}","received_events_url":"https://api.github.com/users/cloudxxx8/received_events","type":"User","site_admin":false},"body":"To meet edgexfoundry/edgex-go#1067\r\nAdd basic tracing and metrics via a simple correlation ID\r\nfix #169\r\n\r\nSigned-off-by: Cloud Tsai <cloudxxx8@gmail.com>","created_at":"2019-02-14T06:32:30Z","updated_at":"2019-02-17T14:59:18Z","closed_at":"2019-02-14T09:19:49Z","merged_at":"2019-02-14T09:19:49Z","merge_commit_sha":"75449a9932cfdfd2f2453ac1a4ba1db0f0d9b20b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172/commits","review_comments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172/comments","review_comment_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/172/comments","statuses_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/statuses/32b4f17d0351a508d680a29298dc6b4551ed7a32","head":{"label":"IOTechSystems:issue-169","ref":"issue-169","sha":"32b4f17d0351a508d680a29298dc6b4551ed7a32","user":{"login":"IOTechSystems","id":31407855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDA3ODU1","avatar_url":"https://avatars3.githubusercontent.com/u/31407855?v=4","gravatar_id":"","url":"https://api.github.com/users/IOTechSystems","html_url":"https://github.com/IOTechSystems","followers_url":"https://api.github.com/users/IOTechSystems/followers","following_url":"https://api.github.com/users/IOTechSystems/following{/other_user}","gists_url":"https://api.github.com/users/IOTechSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/IOTechSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOTechSystems/subscriptions","organizations_url":"https://api.github.com/users/IOTechSystems/orgs","repos_url":"https://api.github.com/users/IOTechSystems/repos","events_url":"https://api.github.com/users/IOTechSystems/events{/privacy}","received_events_url":"https://api.github.com/users/IOTechSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":143713164,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MTMxNjQ=","name":"device-sdk-go","full_name":"IOTechSystems/device-sdk-go","private":false,"owner":{"login":"IOTechSystems","id":31407855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDA3ODU1","avatar_url":"https://avatars3.githubusercontent.com/u/31407855?v=4","gravatar_id":"","url":"https://api.github.com/users/IOTechSystems","html_url":"https://github.com/IOTechSystems","followers_url":"https://api.github.com/users/IOTechSystems/followers","following_url":"https://api.github.com/users/IOTechSystems/following{/other_user}","gists_url":"https://api.github.com/users/IOTechSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/IOTechSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOTechSystems/subscriptions","organizations_url":"https://api.github.com/users/IOTechSystems/orgs","repos_url":"https://api.github.com/users/IOTechSystems/repos","events_url":"https://api.github.com/users/IOTechSystems/events{/privacy}","received_events_url":"https://api.github.com/users/IOTechSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IOTechSystems/device-sdk-go","description":null,"fork":true,"url":"https://api.github.com/repos/IOTechSystems/device-sdk-go","forks_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/forks","keys_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/teams","hooks_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/events","assignees_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/tags","blobs_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/languages","stargazers_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/subscription","commits_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/merges","archive_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/downloads","issues_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/IOTechSystems/device-sdk-go/deployments","created_at":"2018-08-06T10:30:06Z","updated_at":"2019-02-15T02:02:53Z","pushed_at":"2019-02-16T14:36:20Z","git_url":"git://github.com/IOTechSystems/device-sdk-go.git","ssh_url":"git@github.com:IOTechSystems/device-sdk-go.git","clone_url":"https://github.com/IOTechSystems/device-sdk-go.git","svn_url":"https://github.com/IOTechSystems/device-sdk-go","homepage":null,"size":466,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edgexfoundry:master","ref":"master","sha":"1e8d5f33cf489838adb2c14d176737322cd3b6da","user":{"login":"edgexfoundry","id":27781926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzgxOTI2","avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":142326038,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMjYwMzg=","name":"device-sdk-go","full_name":"edgexfoundry/device-sdk-go","private":false,"owner":{"login":"edgexfoundry","id":27781926,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzgxOTI2","avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edgexfoundry/device-sdk-go","description":null,"fork":false,"url":"https://api.github.com/repos/edgexfoundry/device-sdk-go","forks_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/forks","keys_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/teams","hooks_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/hooks","issue_events_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/events{/number}","events_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/events","assignees_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/assignees{/user}","branches_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/branches{/branch}","tags_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/tags","blobs_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/statuses/{sha}","languages_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/languages","stargazers_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/stargazers","contributors_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/contributors","subscribers_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/subscribers","subscription_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/subscription","commits_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/contents/{+path}","compare_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/merges","archive_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/downloads","issues_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues{/number}","pulls_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls{/number}","milestones_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/milestones{/number}","notifications_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/labels{/name}","releases_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/releases{/id}","deployments_url":"https://api.github.com/repos/edgexfoundry/device-sdk-go/deployments","created_at":"2018-07-25T16:27:16Z","updated_at":"2019-02-17T14:54:56Z","pushed_at":"2019-02-14T09:19:50Z","git_url":"git://github.com/edgexfoundry/device-sdk-go.git","ssh_url":"git@github.com:edgexfoundry/device-sdk-go.git","clone_url":"https://github.com/edgexfoundry/device-sdk-go.git","svn_url":"https://github.com/edgexfoundry/device-sdk-go","homepage":null,"size":460,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":31,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172"},"html":{"href":"https://github.com/edgexfoundry/device-sdk-go/pull/172"},"issue":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/172"},"comments":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/edgexfoundry/device-sdk-go/statuses/32b4f17d0351a508d680a29298dc6b4551ed7a32"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cloudxxx8"}}