{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/1145","repository_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb","labels_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/1145/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/1145/comments","events_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/1145/events","html_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/1145","id":530408966,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MDk4NTI3","number":1145,"title":"Improve project usability","user":{"login":"dgaubert","id":1936888,"node_id":"MDQ6VXNlcjE5MzY4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1936888?v=4","gravatar_id":"","url":"https://api.github.com/users/dgaubert","html_url":"https://github.com/dgaubert","followers_url":"https://api.github.com/users/dgaubert/followers","following_url":"https://api.github.com/users/dgaubert/following{/other_user}","gists_url":"https://api.github.com/users/dgaubert/gists{/gist_id}","starred_url":"https://api.github.com/users/dgaubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgaubert/subscriptions","organizations_url":"https://api.github.com/users/dgaubert/orgs","repos_url":"https://api.github.com/users/dgaubert/repos","events_url":"https://api.github.com/users/dgaubert/events{/privacy}","received_events_url":"https://api.github.com/users/dgaubert/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2019-11-29T15:52:13Z","updated_at":"2019-12-02T12:35:13Z","closed_at":"2019-12-02T11:36:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/pulls/1145","html_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/1145","diff_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/1145.diff","patch_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/1145.patch"},"body":"This is the kind of PR that makes me happier, a.k.a developer happiness:\r\n\r\n* Stop using two different tools for package management, testing, and any other developer workflow.\r\n  * Removes Makefile and related bash scripts\r\n  * Use `npm scripts` as the only tool for testing, CI and linting.\r\n* Simplified CI configuration.\r\n* Improved documentation:\r\n  * Centralized several documents into README.md\r\n  * Remove outdated sections\r\n  * Update old sections\r\n  * Added missing sections.\r\n* Remove deprecated coverage tool `istanbul`, using `nyc` instead.\r\n* Removed unused `dockerfile`s\r\n[...]"},"comment":{"url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/comments/560377858","html_url":"https://github.com/CartoDB/Windshaft-cartodb/pull/1145#issuecomment-560377858","issue_url":"https://api.github.com/repos/CartoDB/Windshaft-cartodb/issues/1145","id":560377858,"node_id":"MDEyOklzc3VlQ29tbWVudDU2MDM3Nzg1OA==","user":{"login":"Algunenano","id":664253,"node_id":"MDQ6VXNlcjY2NDI1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/664253?v=4","gravatar_id":"","url":"https://api.github.com/users/Algunenano","html_url":"https://github.com/Algunenano","followers_url":"https://api.github.com/users/Algunenano/followers","following_url":"https://api.github.com/users/Algunenano/following{/other_user}","gists_url":"https://api.github.com/users/Algunenano/gists{/gist_id}","starred_url":"https://api.github.com/users/Algunenano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Algunenano/subscriptions","organizations_url":"https://api.github.com/users/Algunenano/orgs","repos_url":"https://api.github.com/users/Algunenano/repos","events_url":"https://api.github.com/users/Algunenano/events{/privacy}","received_events_url":"https://api.github.com/users/Algunenano/received_events","type":"User","site_admin":false},"created_at":"2019-12-02T12:35:13Z","updated_at":"2019-12-02T12:35:13Z","author_association":"MEMBER","body":"> I think I should keep the previous behavior and set the search_path up. Wondering why you have so many issues with this PR.\r\n\r\nProbably because things are tested with 3 different flavours of Ubuntu with the same setup.\r\n\r\n\r\n> I thought we were setting search_path here: https://github.com/CartoDB/Windshaft-cartodb/blob/master/test/support/sql/windshaft.test.sql#L14\r\n\r\nThat doesn't include other users. The failing tests are using `test_windshaft_publicuser` and `test_windshaft_regular1`."}}
{"actor":{"display_login":"Algunenano"}}