{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/313261703","pull_request_review_id":274113478,"id":313261703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzI2MTcwMw==","diff_hunk":"@@ -18,16 +18,15 @@ Liveness and readiness probes can be configured using the `livenessProbe` and `r\n * `KafkaConnectS2I.spec`\n * `KafkaBridge.spec`\n \n-Both `livenessProbe` and `readinessProbe` support two additional options:\n+Both `livenessProbe` and `readinessProbe` support following options:\n \n * `initialDelaySeconds`\n * `timeoutSeconds`\n+* `periodSeconds`\n+* `successThreshold`\n+* `failureThreshold`\n \n-The `initialDelaySeconds` property defines the initial delay before the probe is tried for the first time.\n-Default is 15 seconds.\n-\n-The `timeoutSeconds` property defines timeout of the probe.\n-Default is 5 seconds.\n+For more information about the `livenessProbe` and `readinessProbe` options, see xref:type-Probe-reference[].\n \n .An example of liveness and readiness probe configuration","path":"documentation/book/ref-healthchecks.adoc","position":20,"original_position":20,"commit_id":"7ea02d3d6a889f7466c8894892644a5ccfa9da89","original_commit_id":"7c61828d91d2a1c5de53529c763eb5e83d30455f","user":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"I think it covers the two most common options. So I would keep it.","created_at":"2019-08-13T07:53:22Z","updated_at":"2019-08-13T07:53:23Z","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/1889#discussion_r313261703","pull_request_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/313261703"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/1889#discussion_r313261703"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889"}},"in_reply_to_id":313254774},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889","id":306776466,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2Nzc2NDY2","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/1889","diff_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/1889.diff","patch_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/1889.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/1889","number":1889,"state":"open","locked":false,"title":"Improve the Health-check documentation to cover the new options","user":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\n- Enhancement / new feature\r\n\r\n### Description\r\n\r\nIn the past we added some more options to the readiness and liveness probe configuration but we didn't document them. This Pr adds the new options and links to the API reference for their detailed description.","created_at":"2019-08-13T07:17:11Z","updated_at":"2019-08-13T07:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65be2c3f320c9b43777ff008890c72e1084ab066","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731902107,"node_id":"MDU6TGFiZWw3MzE5MDIxMDc=","url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels/documentation","name":"documentation","color":"d4c5f9","default":true},{"id":990587858,"node_id":"MDU6TGFiZWw5OTA1ODc4NTg=","url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels/peer-review-needed","name":"peer-review-needed","color":"c2e0c6","default":false},{"id":1002386099,"node_id":"MDU6TGFiZWwxMDAyMzg2MDk5","url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels/sme-review-needed","name":"sme-review-needed","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones/13","html_url":"https://github.com/strimzi/strimzi-kafka-operator/milestone/13","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones/13/labels","id":4518575,"node_id":"MDk6TWlsZXN0b25lNDUxODU3NQ==","number":13,"title":"0.14.0","description":"","creator":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":24,"state":"open","created_at":"2019-07-24T13:09:29Z","updated_at":"2019-08-13T07:17:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/1889/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/7ea02d3d6a889f7466c8894892644a5ccfa9da89","head":{"label":"scholzj:docs-improve-healthcheck-docs-to-cover-new-options","ref":"docs-improve-healthcheck-docs-to-cover-new-options","sha":"7ea02d3d6a889f7466c8894892644a5ccfa9da89","user":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"repo":{"id":102353803,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzNTM4MDM=","name":"strimzi-kafka-operator","full_name":"scholzj/strimzi-kafka-operator","private":false,"owner":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/scholzj/strimzi-kafka-operator","description":"Kafka as a Service with Docker and Kubernetes/Openshift","fork":true,"url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/scholzj/strimzi-kafka-operator/deployments","created_at":"2017-09-04T11:23:44Z","updated_at":"2019-02-21T09:04:24Z","pushed_at":"2019-08-13T07:52:52Z","git_url":"git://github.com/scholzj/strimzi-kafka-operator.git","ssh_url":"git@github.com:scholzj/strimzi-kafka-operator.git","clone_url":"https://github.com/scholzj/strimzi-kafka-operator.git","svn_url":"https://github.com/scholzj/strimzi-kafka-operator","homepage":"","size":23961,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"c28a8f8d2ba2c01e5f01c0134df8419d16c4a869","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","private":false,"owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2019-08-12T21:36:20Z","pushed_at":"2019-08-13T07:52:53Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"git@github.com:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":21434,"stargazers_count":809,"watchers_count":809,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":196,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":199,"open_issues":196,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/1889"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/1889"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/7ea02d3d6a889f7466c8894892644a5ccfa9da89"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"scholzj"}}