{"action":"created","issue":{"url":"https://api.github.com/repos/makerdiary/nrf52-u2f/issues/6","repository_url":"https://api.github.com/repos/makerdiary/nrf52-u2f","labels_url":"https://api.github.com/repos/makerdiary/nrf52-u2f/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/makerdiary/nrf52-u2f/issues/6/comments","events_url":"https://api.github.com/repos/makerdiary/nrf52-u2f/issues/6/events","html_url":"https://github.com/makerdiary/nrf52-u2f/pull/6","id":420542479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNzk5NzE1","number":6,"title":"Fixes for some of the errors known at compile time","user":{"login":"vinsec","id":22928057,"node_id":"MDQ6VXNlcjIyOTI4MDU3","avatar_url":"https://avatars0.githubusercontent.com/u/22928057?v=4","gravatar_id":"","url":"https://api.github.com/users/vinsec","html_url":"https://github.com/vinsec","followers_url":"https://api.github.com/users/vinsec/followers","following_url":"https://api.github.com/users/vinsec/following{/other_user}","gists_url":"https://api.github.com/users/vinsec/gists{/gist_id}","starred_url":"https://api.github.com/users/vinsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinsec/subscriptions","organizations_url":"https://api.github.com/users/vinsec/orgs","repos_url":"https://api.github.com/users/vinsec/repos","events_url":"https://api.github.com/users/vinsec/events{/privacy}","received_events_url":"https://api.github.com/users/vinsec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-03-13T14:49:21Z","updated_at":"2019-03-18T02:37:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/makerdiary/nrf52-u2f/pulls/6","html_url":"https://github.com/makerdiary/nrf52-u2f/pull/6","diff_url":"https://github.com/makerdiary/nrf52-u2f/pull/6.diff","patch_url":"https://github.com/makerdiary/nrf52-u2f/pull/6.patch"},"body":"1. Add the missing static libraries and move them into `nrf_sdks`. Accordingly,the Makefiles have been updated.\r\n\r\n2.The command `mergehex` is not usually installed in advance.A README.md has been added in order to make the compilation process smoother.\r\n\r\nAll these changes have been carefully validated.\r\n\r\nThe compiling environment is : \r\n```\r\nLinux 4.18.0-16-generic Ubuntu 18.04.1 x86_64\r\nGNU Arm Embedded Toolchain: 6-2017-q2-update\r\nnRF5 SDK: nRF5_SDK_v15.2.0_9412b96\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/makerdiary/nrf52-u2f/issues/comments/473748680","html_url":"https://github.com/makerdiary/nrf52-u2f/pull/6#issuecomment-473748680","issue_url":"https://api.github.com/repos/makerdiary/nrf52-u2f/issues/6","id":473748680,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3Mzc0ODY4MA==","user":{"login":"vinsec","id":22928057,"node_id":"MDQ6VXNlcjIyOTI4MDU3","avatar_url":"https://avatars0.githubusercontent.com/u/22928057?v=4","gravatar_id":"","url":"https://api.github.com/users/vinsec","html_url":"https://github.com/vinsec","followers_url":"https://api.github.com/users/vinsec/followers","following_url":"https://api.github.com/users/vinsec/following{/other_user}","gists_url":"https://api.github.com/users/vinsec/gists{/gist_id}","starred_url":"https://api.github.com/users/vinsec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinsec/subscriptions","organizations_url":"https://api.github.com/users/vinsec/orgs","repos_url":"https://api.github.com/users/vinsec/repos","events_url":"https://api.github.com/users/vinsec/events{/privacy}","received_events_url":"https://api.github.com/users/vinsec/received_events","type":"User","site_admin":false},"created_at":"2019-03-18T02:37:25Z","updated_at":"2019-03-18T02:37:25Z","author_association":"CONTRIBUTOR","body":"> @vinsec micro-ecc library is in the folder `<nRF5 SDK path>/external/micro-ecc`. Just change to the directory and run `./build_all.sh` or `.\\build_all.bat`. So, I think it is better to add a tutorial for this step rather than adding the pre-build libs.\r\n\r\nThat would be better :)"}}
{"actor":{"display_login":"vinsec"}}