{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/41644","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/41644/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/41644/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/41644/events","html_url":"https://github.com/cockroachdb/cockroach/pull/41644","id":507924772,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4ODIwNTg2","number":41644,"title":"storage: change fatalOnStatsMismatch semantics","user":{"login":"tbg","id":5076964,"node_id":"MDQ6VXNlcjUwNzY5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5076964?v=4","gravatar_id":"","url":"https://api.github.com/users/tbg","html_url":"https://github.com/tbg","followers_url":"https://api.github.com/users/tbg/followers","following_url":"https://api.github.com/users/tbg/following{/other_user}","gists_url":"https://api.github.com/users/tbg/gists{/gist_id}","starred_url":"https://api.github.com/users/tbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbg/subscriptions","organizations_url":"https://api.github.com/users/tbg/orgs","repos_url":"https://api.github.com/users/tbg/repos","events_url":"https://api.github.com/users/tbg/events{/privacy}","received_events_url":"https://api.github.com/users/tbg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-10-16T15:24:09Z","updated_at":"2019-10-17T08:14:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/41644","html_url":"https://github.com/cockroachdb/cockroach/pull/41644","diff_url":"https://github.com/cockroachdb/cockroach/pull/41644.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/41644.patch"},"body":"Older versions of CRDB do not necessarily maintain consistent stats.\r\nWe are more interested in violations that occur on current versions\r\nof CRDB (19.1+) in our nightly testing, where we wish to use this\r\nenv var more pervasively.\r\nIt was difficult to do this prior to this commit since the various\r\nupgrade tests could pick up inconsistencies and this mechanism\r\nwould have to selectively be disabled for those; doable, but not\r\nworth it.\r\n\r\nInstead, rename the env var (so that already-baked releases that\r\nknow about it ignore it) and change the behavior to include an\r\nadditional bootstrap version check: only clusters that came to\r\nlife on 19.1+ will fatal when the env var is set. This makes sure\r\nthat tests upgrading from old releases, even if the env var is\r\nset, don't trip over these inconsistencies we don't care about.\r\n\r\nI manually tested this via TestConsistencyQueueRecomputeStats by\r\nsetting the default to `true` (causing a panic) and then editing\r\nthe \"cutoff version\" to be 19.2 (which does not exist yet) which\r\nremoved the panic again.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/543060719","html_url":"https://github.com/cockroachdb/cockroach/pull/41644#issuecomment-543060719","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/41644","id":543060719,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MzA2MDcxOQ==","user":{"login":"tbg","id":5076964,"node_id":"MDQ6VXNlcjUwNzY5NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5076964?v=4","gravatar_id":"","url":"https://api.github.com/users/tbg","html_url":"https://github.com/tbg","followers_url":"https://api.github.com/users/tbg/followers","following_url":"https://api.github.com/users/tbg/following{/other_user}","gists_url":"https://api.github.com/users/tbg/gists{/gist_id}","starred_url":"https://api.github.com/users/tbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbg/subscriptions","organizations_url":"https://api.github.com/users/tbg/orgs","repos_url":"https://api.github.com/users/tbg/repos","events_url":"https://api.github.com/users/tbg/events{/privacy}","received_events_url":"https://api.github.com/users/tbg/received_events","type":"User","site_admin":false},"created_at":"2019-10-17T08:14:08Z","updated_at":"2019-10-17T08:14:08Z","author_association":"MEMBER","body":"Friendly ping @andreimatei "}}
{"actor":{"display_login":"tbg"}}