{"action":"created","comment":{"url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/comments/346315828","pull_request_review_id":316957176,"id":346315828,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NjMxNTgyOA==","diff_hunk":"@@ -0,0 +1,136 @@\n+import React, { Component } from \"react\";\n+import { render } from \"react-dom\";\n+import { Slider, Rail, Handles, Tracks, Ticks } from \"react-compound-slider\";\n+import { SliderRail, Handle, Track, Tick } from \"./components\"; // example render components - source below\n+import { format} from \"date-fns\";\n+import { scaleTime } from \"d3-scale\";\n+\n+const sliderStyle = {\n+  position: \"relative\",\n+  width: \"100%\"\n+};\n+\n+function formatTick(ms) {\n+  return format(new Date(ms), \"yyyy\");\n+}\n+\n+const oneYear = 1000 * 60 * 60 * 24 * 365;\n+\n+// Time\n+class Slider2 extends Component {\n+\tconstructor() {\n+\t    super();\n+\n+\t   \tconst defaultYear = new Date(1950, 3, 3);\n+\t    const startYear = new Date(1950, 3, 3);\n+\t    const endYear = new Date(2019, 3, 3);\n+\n+\t    this.state = {\n+\t      selected: defaultYear,\n+\t      updated: defaultYear,\n+\t      min: startYear,\n+\t      max: endYear\n+\t    };\n+\t  }\n+\n+\t  onChange = ([ms]) => {","path":"app/src/Slider.js","position":36,"original_position":36,"commit_id":"b79a8a6b203c041702dc88f2b942a3ba6491db93","original_commit_id":"b79a8a6b203c041702dc88f2b942a3ba6491db93","user":{"login":"tduffy000","id":42978662,"node_id":"MDQ6VXNlcjQyOTc4NjYy","avatar_url":"https://avatars3.githubusercontent.com/u/42978662?v=4","gravatar_id":"","url":"https://api.github.com/users/tduffy000","html_url":"https://github.com/tduffy000","followers_url":"https://api.github.com/users/tduffy000/followers","following_url":"https://api.github.com/users/tduffy000/following{/other_user}","gists_url":"https://api.github.com/users/tduffy000/gists{/gist_id}","starred_url":"https://api.github.com/users/tduffy000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tduffy000/subscriptions","organizations_url":"https://api.github.com/users/tduffy000/orgs","repos_url":"https://api.github.com/users/tduffy000/repos","events_url":"https://api.github.com/users/tduffy000/events{/privacy}","received_events_url":"https://api.github.com/users/tduffy000/received_events","type":"User","site_admin":false},"body":"I think you have to bind this in the constructor --> `this.onChange = this.onChange.bind(this)` see --> https://reactjs.org/docs/handling-events.html","created_at":"2019-11-14T13:41:36Z","updated_at":"2019-11-14T13:43:20Z","html_url":"https://github.com/tunghoangt/DataVisualization/pull/5#discussion_r346315828","pull_request_url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/comments/346315828"},"html":{"href":"https://github.com/tunghoangt/DataVisualization/pull/5#discussion_r346315828"},"pull_request":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5","id":340735824,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwNzM1ODI0","html_url":"https://github.com/tunghoangt/DataVisualization/pull/5","diff_url":"https://github.com/tunghoangt/DataVisualization/pull/5.diff","patch_url":"https://github.com/tunghoangt/DataVisualization/pull/5.patch","issue_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/5","number":5,"state":"open","locked":false,"title":"Slider","user":{"login":"tunghoangt","id":43008874,"node_id":"MDQ6VXNlcjQzMDA4ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/43008874?v=4","gravatar_id":"","url":"https://api.github.com/users/tunghoangt","html_url":"https://github.com/tunghoangt","followers_url":"https://api.github.com/users/tunghoangt/followers","following_url":"https://api.github.com/users/tunghoangt/following{/other_user}","gists_url":"https://api.github.com/users/tunghoangt/gists{/gist_id}","starred_url":"https://api.github.com/users/tunghoangt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunghoangt/subscriptions","organizations_url":"https://api.github.com/users/tunghoangt/orgs","repos_url":"https://api.github.com/users/tunghoangt/repos","events_url":"https://api.github.com/users/tunghoangt/events{/privacy}","received_events_url":"https://api.github.com/users/tunghoangt/received_events","type":"User","site_admin":false},"body":"Add the slider function","created_at":"2019-11-14T00:47:15Z","updated_at":"2019-11-14T13:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d299dd87e45ace59889315444aa289fcc33806","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5/commits","review_comments_url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5/comments","review_comment_url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/5/comments","statuses_url":"https://api.github.com/repos/tunghoangt/DataVisualization/statuses/b79a8a6b203c041702dc88f2b942a3ba6491db93","head":{"label":"tunghoangt:slider","ref":"slider","sha":"b79a8a6b203c041702dc88f2b942a3ba6491db93","user":{"login":"tunghoangt","id":43008874,"node_id":"MDQ6VXNlcjQzMDA4ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/43008874?v=4","gravatar_id":"","url":"https://api.github.com/users/tunghoangt","html_url":"https://github.com/tunghoangt","followers_url":"https://api.github.com/users/tunghoangt/followers","following_url":"https://api.github.com/users/tunghoangt/following{/other_user}","gists_url":"https://api.github.com/users/tunghoangt/gists{/gist_id}","starred_url":"https://api.github.com/users/tunghoangt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunghoangt/subscriptions","organizations_url":"https://api.github.com/users/tunghoangt/orgs","repos_url":"https://api.github.com/users/tunghoangt/repos","events_url":"https://api.github.com/users/tunghoangt/events{/privacy}","received_events_url":"https://api.github.com/users/tunghoangt/received_events","type":"User","site_admin":false},"repo":{"id":216926053,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY5MjYwNTM=","name":"DataVisualization","full_name":"tunghoangt/DataVisualization","private":false,"owner":{"login":"tunghoangt","id":43008874,"node_id":"MDQ6VXNlcjQzMDA4ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/43008874?v=4","gravatar_id":"","url":"https://api.github.com/users/tunghoangt","html_url":"https://github.com/tunghoangt","followers_url":"https://api.github.com/users/tunghoangt/followers","following_url":"https://api.github.com/users/tunghoangt/following{/other_user}","gists_url":"https://api.github.com/users/tunghoangt/gists{/gist_id}","starred_url":"https://api.github.com/users/tunghoangt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunghoangt/subscriptions","organizations_url":"https://api.github.com/users/tunghoangt/orgs","repos_url":"https://api.github.com/users/tunghoangt/repos","events_url":"https://api.github.com/users/tunghoangt/events{/privacy}","received_events_url":"https://api.github.com/users/tunghoangt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tunghoangt/DataVisualization","description":null,"fork":false,"url":"https://api.github.com/repos/tunghoangt/DataVisualization","forks_url":"https://api.github.com/repos/tunghoangt/DataVisualization/forks","keys_url":"https://api.github.com/repos/tunghoangt/DataVisualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tunghoangt/DataVisualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tunghoangt/DataVisualization/teams","hooks_url":"https://api.github.com/repos/tunghoangt/DataVisualization/hooks","issue_events_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/events{/number}","events_url":"https://api.github.com/repos/tunghoangt/DataVisualization/events","assignees_url":"https://api.github.com/repos/tunghoangt/DataVisualization/assignees{/user}","branches_url":"https://api.github.com/repos/tunghoangt/DataVisualization/branches{/branch}","tags_url":"https://api.github.com/repos/tunghoangt/DataVisualization/tags","blobs_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tunghoangt/DataVisualization/statuses/{sha}","languages_url":"https://api.github.com/repos/tunghoangt/DataVisualization/languages","stargazers_url":"https://api.github.com/repos/tunghoangt/DataVisualization/stargazers","contributors_url":"https://api.github.com/repos/tunghoangt/DataVisualization/contributors","subscribers_url":"https://api.github.com/repos/tunghoangt/DataVisualization/subscribers","subscription_url":"https://api.github.com/repos/tunghoangt/DataVisualization/subscription","commits_url":"https://api.github.com/repos/tunghoangt/DataVisualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/tunghoangt/DataVisualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/tunghoangt/DataVisualization/contents/{+path}","compare_url":"https://api.github.com/repos/tunghoangt/DataVisualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tunghoangt/DataVisualization/merges","archive_url":"https://api.github.com/repos/tunghoangt/DataVisualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tunghoangt/DataVisualization/downloads","issues_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues{/number}","pulls_url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls{/number}","milestones_url":"https://api.github.com/repos/tunghoangt/DataVisualization/milestones{/number}","notifications_url":"https://api.github.com/repos/tunghoangt/DataVisualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tunghoangt/DataVisualization/labels{/name}","releases_url":"https://api.github.com/repos/tunghoangt/DataVisualization/releases{/id}","deployments_url":"https://api.github.com/repos/tunghoangt/DataVisualization/deployments","created_at":"2019-10-22T23:11:51Z","updated_at":"2019-11-05T22:48:59Z","pushed_at":"2019-11-14T00:47:16Z","git_url":"git://github.com/tunghoangt/DataVisualization.git","ssh_url":"git@github.com:tunghoangt/DataVisualization.git","clone_url":"https://github.com/tunghoangt/DataVisualization.git","svn_url":"https://github.com/tunghoangt/DataVisualization","homepage":null,"size":2766,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tunghoangt:master","ref":"master","sha":"c656a49c0ec47724b5852527a5a1ffb460c51a83","user":{"login":"tunghoangt","id":43008874,"node_id":"MDQ6VXNlcjQzMDA4ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/43008874?v=4","gravatar_id":"","url":"https://api.github.com/users/tunghoangt","html_url":"https://github.com/tunghoangt","followers_url":"https://api.github.com/users/tunghoangt/followers","following_url":"https://api.github.com/users/tunghoangt/following{/other_user}","gists_url":"https://api.github.com/users/tunghoangt/gists{/gist_id}","starred_url":"https://api.github.com/users/tunghoangt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunghoangt/subscriptions","organizations_url":"https://api.github.com/users/tunghoangt/orgs","repos_url":"https://api.github.com/users/tunghoangt/repos","events_url":"https://api.github.com/users/tunghoangt/events{/privacy}","received_events_url":"https://api.github.com/users/tunghoangt/received_events","type":"User","site_admin":false},"repo":{"id":216926053,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY5MjYwNTM=","name":"DataVisualization","full_name":"tunghoangt/DataVisualization","private":false,"owner":{"login":"tunghoangt","id":43008874,"node_id":"MDQ6VXNlcjQzMDA4ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/43008874?v=4","gravatar_id":"","url":"https://api.github.com/users/tunghoangt","html_url":"https://github.com/tunghoangt","followers_url":"https://api.github.com/users/tunghoangt/followers","following_url":"https://api.github.com/users/tunghoangt/following{/other_user}","gists_url":"https://api.github.com/users/tunghoangt/gists{/gist_id}","starred_url":"https://api.github.com/users/tunghoangt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunghoangt/subscriptions","organizations_url":"https://api.github.com/users/tunghoangt/orgs","repos_url":"https://api.github.com/users/tunghoangt/repos","events_url":"https://api.github.com/users/tunghoangt/events{/privacy}","received_events_url":"https://api.github.com/users/tunghoangt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tunghoangt/DataVisualization","description":null,"fork":false,"url":"https://api.github.com/repos/tunghoangt/DataVisualization","forks_url":"https://api.github.com/repos/tunghoangt/DataVisualization/forks","keys_url":"https://api.github.com/repos/tunghoangt/DataVisualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tunghoangt/DataVisualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tunghoangt/DataVisualization/teams","hooks_url":"https://api.github.com/repos/tunghoangt/DataVisualization/hooks","issue_events_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/events{/number}","events_url":"https://api.github.com/repos/tunghoangt/DataVisualization/events","assignees_url":"https://api.github.com/repos/tunghoangt/DataVisualization/assignees{/user}","branches_url":"https://api.github.com/repos/tunghoangt/DataVisualization/branches{/branch}","tags_url":"https://api.github.com/repos/tunghoangt/DataVisualization/tags","blobs_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tunghoangt/DataVisualization/statuses/{sha}","languages_url":"https://api.github.com/repos/tunghoangt/DataVisualization/languages","stargazers_url":"https://api.github.com/repos/tunghoangt/DataVisualization/stargazers","contributors_url":"https://api.github.com/repos/tunghoangt/DataVisualization/contributors","subscribers_url":"https://api.github.com/repos/tunghoangt/DataVisualization/subscribers","subscription_url":"https://api.github.com/repos/tunghoangt/DataVisualization/subscription","commits_url":"https://api.github.com/repos/tunghoangt/DataVisualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/tunghoangt/DataVisualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/tunghoangt/DataVisualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/tunghoangt/DataVisualization/contents/{+path}","compare_url":"https://api.github.com/repos/tunghoangt/DataVisualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tunghoangt/DataVisualization/merges","archive_url":"https://api.github.com/repos/tunghoangt/DataVisualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tunghoangt/DataVisualization/downloads","issues_url":"https://api.github.com/repos/tunghoangt/DataVisualization/issues{/number}","pulls_url":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls{/number}","milestones_url":"https://api.github.com/repos/tunghoangt/DataVisualization/milestones{/number}","notifications_url":"https://api.github.com/repos/tunghoangt/DataVisualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tunghoangt/DataVisualization/labels{/name}","releases_url":"https://api.github.com/repos/tunghoangt/DataVisualization/releases{/id}","deployments_url":"https://api.github.com/repos/tunghoangt/DataVisualization/deployments","created_at":"2019-10-22T23:11:51Z","updated_at":"2019-11-05T22:48:59Z","pushed_at":"2019-11-14T00:47:16Z","git_url":"git://github.com/tunghoangt/DataVisualization.git","ssh_url":"git@github.com:tunghoangt/DataVisualization.git","clone_url":"https://github.com/tunghoangt/DataVisualization.git","svn_url":"https://github.com/tunghoangt/DataVisualization","homepage":null,"size":2766,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5"},"html":{"href":"https://github.com/tunghoangt/DataVisualization/pull/5"},"issue":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/5"},"comments":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/tunghoangt/DataVisualization/statuses/b79a8a6b203c041702dc88f2b942a3ba6491db93"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tduffy000"}}