{"action":"created","comment":{"url":"https://api.github.com/repos/p11-glue/p11-kit/pulls/comments/363726359","pull_request_review_id":339205804,"id":363726359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzcyNjM1OQ==","diff_hunk":"@@ -154,6 +154,21 @@ if test \"$os_unix\" = \"yes\"; then\n \tAC_CHECK_TYPES([sighandler_t, sig_t, __sighandler_t], [], [],\n \t\t[[#include <sys/types.h>\n \t\t  #include <signal.h>]])\n+\n+\tAC_MSG_CHECKING([whether vsock support is available])\n+\tAC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <sys/socket.h>\n+\t\t\t\t\t  #include <linux/vm_sockets.h>]],\n+\t                                [[struct sockaddr_vm sa = {\n+\t\t\t\t\t  .svm_family = AF_VSOCK,\n+\t\t\t\t\t  .svm_cid = VMADDR_CID_ANY,\n+\t\t\t\t\t  };\n+\t\t\t\t\t  (void)&sa;\n+\t\t\t\t\t  return 0;]])],\n+\t               [AC_DEFINE([HAVE_VSOCK], [1],\n+\t                          [Whether vsock support available])\n+\t                AC_MSG_RESULT([yes])],\n+\t               [AC_MSG_RESULT([no])])\n+","path":"configure.ac","position":18,"original_position":18,"commit_id":"d65342ee7414d81b8c52780880dac46e5eddc34d","original_commit_id":"d65342ee7414d81b8c52780880dac46e5eddc34d","user":{"login":"ueno","id":47549,"node_id":"MDQ6VXNlcjQ3NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/47549?v=4","gravatar_id":"","url":"https://api.github.com/users/ueno","html_url":"https://github.com/ueno","followers_url":"https://api.github.com/users/ueno/followers","following_url":"https://api.github.com/users/ueno/following{/other_user}","gists_url":"https://api.github.com/users/ueno/gists{/gist_id}","starred_url":"https://api.github.com/users/ueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ueno/subscriptions","organizations_url":"https://api.github.com/users/ueno/orgs","repos_url":"https://api.github.com/users/ueno/repos","events_url":"https://api.github.com/users/ueno/events{/privacy}","received_events_url":"https://api.github.com/users/ueno/received_events","type":"User","site_admin":false},"body":"If possible, please add this check in`meson.build` as well.","created_at":"2020-01-07T12:31:27Z","updated_at":"2020-01-07T12:44:35Z","html_url":"https://github.com/p11-glue/p11-kit/pull/270#discussion_r363726359","pull_request_url":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/p11-glue/p11-kit/pulls/comments/363726359"},"html":{"href":"https://github.com/p11-glue/p11-kit/pull/270#discussion_r363726359"},"pull_request":{"href":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270","id":359926163,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5OTI2MTYz","html_url":"https://github.com/p11-glue/p11-kit/pull/270","diff_url":"https://github.com/p11-glue/p11-kit/pull/270.diff","patch_url":"https://github.com/p11-glue/p11-kit/pull/270.patch","issue_url":"https://api.github.com/repos/p11-glue/p11-kit/issues/270","number":270,"state":"open","locked":false,"title":"rpc: Add vsock transport support","user":{"login":"dwmw2","id":911239,"node_id":"MDQ6VXNlcjkxMTIzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/911239?v=4","gravatar_id":"","url":"https://api.github.com/users/dwmw2","html_url":"https://github.com/dwmw2","followers_url":"https://api.github.com/users/dwmw2/followers","following_url":"https://api.github.com/users/dwmw2/following{/other_user}","gists_url":"https://api.github.com/users/dwmw2/gists{/gist_id}","starred_url":"https://api.github.com/users/dwmw2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwmw2/subscriptions","organizations_url":"https://api.github.com/users/dwmw2/orgs","repos_url":"https://api.github.com/users/dwmw2/repos","events_url":"https://api.github.com/users/dwmw2/events{/privacy}","received_events_url":"https://api.github.com/users/dwmw2/received_events","type":"User","site_admin":false},"body":"This adds support for AF_VSOCK as a transport for the remoting protocol.\r\n\r\nWith this, software tokens can be isolated into a microVM of their own and the communication happens over the vsock from the host/parent.\r\n\r\nIn addition to the barrier that virtualisation traditionally provides, technologies like AMD SEV and AWS Nitro Enclaves can turn this into something which approximates the security of a true hardware token.\r\n\r\nThere is no transport-level access control (yet). We could potentially filter on the client CID, and/or restrict it to root-owned ports. Using a PIN on the software token obviously does work.\r\n\r\nI also haven't updated the documentation in p11-kit-remoting.xml. Mostly because I don't really follow it as-is. My current test is just a module file containing:\r\n```\r\nremote:vsock:cid=3;port=9999\r\n```\r\n\r\nIf I were to touch the existing doc, I'd probably start by ripping out the latter half of it. NSS should be using p11-kit-proxy.so by *default* these days, shouldn't it? It shouldn't require anything special.","created_at":"2020-01-07T10:31:45Z","updated_at":"2020-01-07T12:44:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b75e238104b80967cbe043a71e355626bfe19f18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270/commits","review_comments_url":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270/comments","review_comment_url":"https://api.github.com/repos/p11-glue/p11-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p11-glue/p11-kit/issues/270/comments","statuses_url":"https://api.github.com/repos/p11-glue/p11-kit/statuses/d65342ee7414d81b8c52780880dac46e5eddc34d","head":{"label":"dwmw2:vsock","ref":"vsock","sha":"d65342ee7414d81b8c52780880dac46e5eddc34d","user":{"login":"dwmw2","id":911239,"node_id":"MDQ6VXNlcjkxMTIzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/911239?v=4","gravatar_id":"","url":"https://api.github.com/users/dwmw2","html_url":"https://github.com/dwmw2","followers_url":"https://api.github.com/users/dwmw2/followers","following_url":"https://api.github.com/users/dwmw2/following{/other_user}","gists_url":"https://api.github.com/users/dwmw2/gists{/gist_id}","starred_url":"https://api.github.com/users/dwmw2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwmw2/subscriptions","organizations_url":"https://api.github.com/users/dwmw2/orgs","repos_url":"https://api.github.com/users/dwmw2/repos","events_url":"https://api.github.com/users/dwmw2/events{/privacy}","received_events_url":"https://api.github.com/users/dwmw2/received_events","type":"User","site_admin":false},"repo":{"id":232274326,"node_id":"MDEwOlJlcG9zaXRvcnkyMzIyNzQzMjY=","name":"p11-kit","full_name":"dwmw2/p11-kit","private":false,"owner":{"login":"dwmw2","id":911239,"node_id":"MDQ6VXNlcjkxMTIzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/911239?v=4","gravatar_id":"","url":"https://api.github.com/users/dwmw2","html_url":"https://github.com/dwmw2","followers_url":"https://api.github.com/users/dwmw2/followers","following_url":"https://api.github.com/users/dwmw2/following{/other_user}","gists_url":"https://api.github.com/users/dwmw2/gists{/gist_id}","starred_url":"https://api.github.com/users/dwmw2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwmw2/subscriptions","organizations_url":"https://api.github.com/users/dwmw2/orgs","repos_url":"https://api.github.com/users/dwmw2/repos","events_url":"https://api.github.com/users/dwmw2/events{/privacy}","received_events_url":"https://api.github.com/users/dwmw2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dwmw2/p11-kit","description":"Provides a way to load and enumerate PKCS#11 modules.","fork":true,"url":"https://api.github.com/repos/dwmw2/p11-kit","forks_url":"https://api.github.com/repos/dwmw2/p11-kit/forks","keys_url":"https://api.github.com/repos/dwmw2/p11-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwmw2/p11-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwmw2/p11-kit/teams","hooks_url":"https://api.github.com/repos/dwmw2/p11-kit/hooks","issue_events_url":"https://api.github.com/repos/dwmw2/p11-kit/issues/events{/number}","events_url":"https://api.github.com/repos/dwmw2/p11-kit/events","assignees_url":"https://api.github.com/repos/dwmw2/p11-kit/assignees{/user}","branches_url":"https://api.github.com/repos/dwmw2/p11-kit/branches{/branch}","tags_url":"https://api.github.com/repos/dwmw2/p11-kit/tags","blobs_url":"https://api.github.com/repos/dwmw2/p11-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwmw2/p11-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwmw2/p11-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwmw2/p11-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwmw2/p11-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/dwmw2/p11-kit/languages","stargazers_url":"https://api.github.com/repos/dwmw2/p11-kit/stargazers","contributors_url":"https://api.github.com/repos/dwmw2/p11-kit/contributors","subscribers_url":"https://api.github.com/repos/dwmw2/p11-kit/subscribers","subscription_url":"https://api.github.com/repos/dwmw2/p11-kit/subscription","commits_url":"https://api.github.com/repos/dwmw2/p11-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwmw2/p11-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwmw2/p11-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwmw2/p11-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwmw2/p11-kit/contents/{+path}","compare_url":"https://api.github.com/repos/dwmw2/p11-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwmw2/p11-kit/merges","archive_url":"https://api.github.com/repos/dwmw2/p11-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwmw2/p11-kit/downloads","issues_url":"https://api.github.com/repos/dwmw2/p11-kit/issues{/number}","pulls_url":"https://api.github.com/repos/dwmw2/p11-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/dwmw2/p11-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/dwmw2/p11-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwmw2/p11-kit/labels{/name}","releases_url":"https://api.github.com/repos/dwmw2/p11-kit/releases{/id}","deployments_url":"https://api.github.com/repos/dwmw2/p11-kit/deployments","created_at":"2020-01-07T08:03:00Z","updated_at":"2020-01-07T08:03:02Z","pushed_at":"2020-01-07T10:36:15Z","git_url":"git://github.com/dwmw2/p11-kit.git","ssh_url":"git@github.com:dwmw2/p11-kit.git","clone_url":"https://github.com/dwmw2/p11-kit.git","svn_url":"https://github.com/dwmw2/p11-kit","homepage":"https://p11-glue.github.io/p11-glue/p11-kit.html","size":2089,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"p11-glue:master","ref":"master","sha":"6563ad8ececec05f2b6269b509d4e12c07d2a87e","user":{"login":"p11-glue","id":5215057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMTUwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5215057?v=4","gravatar_id":"","url":"https://api.github.com/users/p11-glue","html_url":"https://github.com/p11-glue","followers_url":"https://api.github.com/users/p11-glue/followers","following_url":"https://api.github.com/users/p11-glue/following{/other_user}","gists_url":"https://api.github.com/users/p11-glue/gists{/gist_id}","starred_url":"https://api.github.com/users/p11-glue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p11-glue/subscriptions","organizations_url":"https://api.github.com/users/p11-glue/orgs","repos_url":"https://api.github.com/users/p11-glue/repos","events_url":"https://api.github.com/users/p11-glue/events{/privacy}","received_events_url":"https://api.github.com/users/p11-glue/received_events","type":"Organization","site_admin":false},"repo":{"id":12060420,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2MDQyMA==","name":"p11-kit","full_name":"p11-glue/p11-kit","private":false,"owner":{"login":"p11-glue","id":5215057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyMTUwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5215057?v=4","gravatar_id":"","url":"https://api.github.com/users/p11-glue","html_url":"https://github.com/p11-glue","followers_url":"https://api.github.com/users/p11-glue/followers","following_url":"https://api.github.com/users/p11-glue/following{/other_user}","gists_url":"https://api.github.com/users/p11-glue/gists{/gist_id}","starred_url":"https://api.github.com/users/p11-glue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p11-glue/subscriptions","organizations_url":"https://api.github.com/users/p11-glue/orgs","repos_url":"https://api.github.com/users/p11-glue/repos","events_url":"https://api.github.com/users/p11-glue/events{/privacy}","received_events_url":"https://api.github.com/users/p11-glue/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/p11-glue/p11-kit","description":"Provides a way to load and enumerate PKCS#11 modules.","fork":false,"url":"https://api.github.com/repos/p11-glue/p11-kit","forks_url":"https://api.github.com/repos/p11-glue/p11-kit/forks","keys_url":"https://api.github.com/repos/p11-glue/p11-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p11-glue/p11-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p11-glue/p11-kit/teams","hooks_url":"https://api.github.com/repos/p11-glue/p11-kit/hooks","issue_events_url":"https://api.github.com/repos/p11-glue/p11-kit/issues/events{/number}","events_url":"https://api.github.com/repos/p11-glue/p11-kit/events","assignees_url":"https://api.github.com/repos/p11-glue/p11-kit/assignees{/user}","branches_url":"https://api.github.com/repos/p11-glue/p11-kit/branches{/branch}","tags_url":"https://api.github.com/repos/p11-glue/p11-kit/tags","blobs_url":"https://api.github.com/repos/p11-glue/p11-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p11-glue/p11-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p11-glue/p11-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/p11-glue/p11-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p11-glue/p11-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/p11-glue/p11-kit/languages","stargazers_url":"https://api.github.com/repos/p11-glue/p11-kit/stargazers","contributors_url":"https://api.github.com/repos/p11-glue/p11-kit/contributors","subscribers_url":"https://api.github.com/repos/p11-glue/p11-kit/subscribers","subscription_url":"https://api.github.com/repos/p11-glue/p11-kit/subscription","commits_url":"https://api.github.com/repos/p11-glue/p11-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/p11-glue/p11-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/p11-glue/p11-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/p11-glue/p11-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/p11-glue/p11-kit/contents/{+path}","compare_url":"https://api.github.com/repos/p11-glue/p11-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p11-glue/p11-kit/merges","archive_url":"https://api.github.com/repos/p11-glue/p11-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p11-glue/p11-kit/downloads","issues_url":"https://api.github.com/repos/p11-glue/p11-kit/issues{/number}","pulls_url":"https://api.github.com/repos/p11-glue/p11-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/p11-glue/p11-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/p11-glue/p11-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p11-glue/p11-kit/labels{/name}","releases_url":"https://api.github.com/repos/p11-glue/p11-kit/releases{/id}","deployments_url":"https://api.github.com/repos/p11-glue/p11-kit/deployments","created_at":"2013-08-12T16:16:15Z","updated_at":"2019-12-26T19:21:29Z","pushed_at":"2020-01-07T10:36:17Z","git_url":"git://github.com/p11-glue/p11-kit.git","ssh_url":"git@github.com:p11-glue/p11-kit.git","clone_url":"https://github.com/p11-glue/p11-kit.git","svn_url":"https://github.com/p11-glue/p11-kit","homepage":"https://p11-glue.github.io/p11-glue/p11-kit.html","size":2093,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":38,"open_issues":19,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270"},"html":{"href":"https://github.com/p11-glue/p11-kit/pull/270"},"issue":{"href":"https://api.github.com/repos/p11-glue/p11-kit/issues/270"},"comments":{"href":"https://api.github.com/repos/p11-glue/p11-kit/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/p11-glue/p11-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p11-glue/p11-kit/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/p11-glue/p11-kit/statuses/d65342ee7414d81b8c52780880dac46e5eddc34d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ueno"}}