{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/21341","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/21341/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/21341/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/21341/events","html_url":"https://github.com/magento/magento2/pull/21341","id":412112999,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0Mzk5OTM3","number":21341,"title":"[module-security] Remove duplicate DI arguments","user":{"login":"nickolasburr","id":4663695,"node_id":"MDQ6VXNlcjQ2NjM2OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/4663695?v=4","gravatar_id":"","url":"https://api.github.com/users/nickolasburr","html_url":"https://github.com/nickolasburr","followers_url":"https://api.github.com/users/nickolasburr/followers","following_url":"https://api.github.com/users/nickolasburr/following{/other_user}","gists_url":"https://api.github.com/users/nickolasburr/gists{/gist_id}","starred_url":"https://api.github.com/users/nickolasburr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickolasburr/subscriptions","organizations_url":"https://api.github.com/users/nickolasburr/orgs","repos_url":"https://api.github.com/users/nickolasburr/repos","events_url":"https://api.github.com/users/nickolasburr/events{/privacy}","received_events_url":"https://api.github.com/users/nickolasburr/received_events","type":"User","site_admin":false},"labels":[{"id":948292430,"node_id":"MDU6TGFiZWw5NDgyOTI0MzA=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Security","name":"Component: Security","color":"7fb703","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"aleron75","id":1199894,"node_id":"MDQ6VXNlcjExOTk4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199894?v=4","gravatar_id":"","url":"https://api.github.com/users/aleron75","html_url":"https://github.com/aleron75","followers_url":"https://api.github.com/users/aleron75/followers","following_url":"https://api.github.com/users/aleron75/following{/other_user}","gists_url":"https://api.github.com/users/aleron75/gists{/gist_id}","starred_url":"https://api.github.com/users/aleron75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleron75/subscriptions","organizations_url":"https://api.github.com/users/aleron75/orgs","repos_url":"https://api.github.com/users/aleron75/repos","events_url":"https://api.github.com/users/aleron75/events{/privacy}","received_events_url":"https://api.github.com/users/aleron75/received_events","type":"User","site_admin":false},"assignees":[{"login":"aleron75","id":1199894,"node_id":"MDQ6VXNlcjExOTk4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1199894?v=4","gravatar_id":"","url":"https://api.github.com/users/aleron75","html_url":"https://github.com/aleron75","followers_url":"https://api.github.com/users/aleron75/followers","following_url":"https://api.github.com/users/aleron75/following{/other_user}","gists_url":"https://api.github.com/users/aleron75/gists{/gist_id}","starred_url":"https://api.github.com/users/aleron75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleron75/subscriptions","organizations_url":"https://api.github.com/users/aleron75/orgs","repos_url":"https://api.github.com/users/aleron75/repos","events_url":"https://api.github.com/users/aleron75/events{/privacy}","received_events_url":"https://api.github.com/users/aleron75/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2019-02-19T20:36:45Z","updated_at":"2019-03-05T19:17:38Z","closed_at":"2019-03-05T19:17:37Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/21341","html_url":"https://github.com/magento/magento2/pull/21341","diff_url":"https://github.com/magento/magento2/pull/21341.diff","patch_url":"https://github.com/magento/magento2/pull/21341.patch"},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios\r\n    Fields marked with (*) are required. Please don't remove the template.\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description (*)\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\n\r\nRegarding `module-security`:\r\n\r\nDuplicate DI arguments for `Magento\\Security\\Model\\SecurityManager` are set via `etc/di.xml` and `etc/adminhtml/di.xml`. Since the arguments are already set globally and not modified or needed in an adminhtml-specific manner, this change removes the duplication from `etc/adminhtml/di.xml`.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\nN/A\r\n\r\n### Manual testing scenarios (*)\r\nN/A\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/469821190","html_url":"https://github.com/magento/magento2/pull/21341#issuecomment-469821190","issue_url":"https://api.github.com/repos/magento/magento2/issues/21341","id":469821190,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2OTgyMTE5MA==","user":{"login":"contribution-survey[bot]","id":46357089,"node_id":"MDM6Qm90NDYzNTcwODk=","avatar_url":"https://avatars2.githubusercontent.com/in/23056?v=4","gravatar_id":"","url":"https://api.github.com/users/contribution-survey%5Bbot%5D","html_url":"https://github.com/apps/contribution-survey","followers_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/followers","following_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/repos","events_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/contribution-survey%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-03-05T19:17:38Z","updated_at":"2019-03-05T19:17:38Z","author_association":"NONE","body":"Hi @nickolasburr, thank you for your contribution! </br>Please, complete [Contribution Survey](https://opensource.magento.com/survey/contribution/magento+magento2+21341), it will take less than a minute. </br>Your feedback will help us to improve contribution process."}}
{"actor":{"display_login":"contribution-survey"}}