{"action":"created","comment":{"url":"https://api.github.com/repos/traviscross/mtr/pulls/comments/256913061","pull_request_review_id":203846135,"id":256913061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjkxMzA2MQ==","diff_hunk":"@@ -11,4 +11,19 @@ if [ $# -lt 3 ]; then\n     exit 1\n fi\n \n-sed -e \"s|@VERSION[@]|$1|g\" $2 >$3\n+TMP_FILE=/tmp/mangen.$$\n+\n+sed -e \"s|@VERSION[@]|$1|g\" $2 >$TMP_FILE\n+\n+#\n+#  MacOS's groff is missing .UR and .UE support, which makes\n+#  URL completely disappear from man pages.  We need to strip\n+#  those codes out when building for MacOS\n+#","path":"build-aux/mangen.sh","position":13,"original_position":13,"commit_id":"726a40ac0ea68900f0226f68fbd1a86c10adf119","original_commit_id":"726a40ac0ea68900f0226f68fbd1a86c10adf119","user":{"login":"matt-kimball","id":23195746,"node_id":"MDQ6VXNlcjIzMTk1NzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/23195746?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-kimball","html_url":"https://github.com/matt-kimball","followers_url":"https://api.github.com/users/matt-kimball/followers","following_url":"https://api.github.com/users/matt-kimball/following{/other_user}","gists_url":"https://api.github.com/users/matt-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-kimball/subscriptions","organizations_url":"https://api.github.com/users/matt-kimball/orgs","repos_url":"https://api.github.com/users/matt-kimball/repos","events_url":"https://api.github.com/users/matt-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/matt-kimball/received_events","type":"User","site_admin":false},"body":"Yes, your rewrite works as expected for me.","created_at":"2019-02-14T16:36:12Z","updated_at":"2019-02-14T16:36:12Z","html_url":"https://github.com/traviscross/mtr/pull/289#discussion_r256913061","pull_request_url":"https://api.github.com/repos/traviscross/mtr/pulls/289","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/traviscross/mtr/pulls/comments/256913061"},"html":{"href":"https://github.com/traviscross/mtr/pull/289#discussion_r256913061"},"pull_request":{"href":"https://api.github.com/repos/traviscross/mtr/pulls/289"}},"in_reply_to_id":256784860},"pull_request":{"url":"https://api.github.com/repos/traviscross/mtr/pulls/289","id":252802007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyODAyMDA3","html_url":"https://github.com/traviscross/mtr/pull/289","diff_url":"https://github.com/traviscross/mtr/pull/289.diff","patch_url":"https://github.com/traviscross/mtr/pull/289.patch","issue_url":"https://api.github.com/repos/traviscross/mtr/issues/289","number":289,"state":"open","locked":false,"title":"Fix disappearing URLs in man pages for MacOS","user":{"login":"matt-kimball","id":23195746,"node_id":"MDQ6VXNlcjIzMTk1NzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/23195746?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-kimball","html_url":"https://github.com/matt-kimball","followers_url":"https://api.github.com/users/matt-kimball/followers","following_url":"https://api.github.com/users/matt-kimball/following{/other_user}","gists_url":"https://api.github.com/users/matt-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-kimball/subscriptions","organizations_url":"https://api.github.com/users/matt-kimball/orgs","repos_url":"https://api.github.com/users/matt-kimball/repos","events_url":"https://api.github.com/users/matt-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/matt-kimball/received_events","type":"User","site_admin":false},"body":"groff under MacOS is missing support for .UR and .UE codes, which are\r\nused to embed URLs in man pages.  In fact, using those codes causes\r\nthe URLs to disappear from the man page entirely.\r\n\r\nWith this change, when we generate man pages, strip of the .UR and .UE\r\ncodes when building under MacOS.","created_at":"2019-02-13T18:33:13Z","updated_at":"2019-02-14T16:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88c6be5ca9ad8318a14762eb22a16d88b4b09ded","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/traviscross/mtr/pulls/289/commits","review_comments_url":"https://api.github.com/repos/traviscross/mtr/pulls/289/comments","review_comment_url":"https://api.github.com/repos/traviscross/mtr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/traviscross/mtr/issues/289/comments","statuses_url":"https://api.github.com/repos/traviscross/mtr/statuses/726a40ac0ea68900f0226f68fbd1a86c10adf119","head":{"label":"matt-kimball:macos-manpage-url","ref":"macos-manpage-url","sha":"726a40ac0ea68900f0226f68fbd1a86c10adf119","user":{"login":"matt-kimball","id":23195746,"node_id":"MDQ6VXNlcjIzMTk1NzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/23195746?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-kimball","html_url":"https://github.com/matt-kimball","followers_url":"https://api.github.com/users/matt-kimball/followers","following_url":"https://api.github.com/users/matt-kimball/following{/other_user}","gists_url":"https://api.github.com/users/matt-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-kimball/subscriptions","organizations_url":"https://api.github.com/users/matt-kimball/orgs","repos_url":"https://api.github.com/users/matt-kimball/repos","events_url":"https://api.github.com/users/matt-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/matt-kimball/received_events","type":"User","site_admin":false},"repo":{"id":75243378,"node_id":"MDEwOlJlcG9zaXRvcnk3NTI0MzM3OA==","name":"mtr","full_name":"matt-kimball/mtr","private":false,"owner":{"login":"matt-kimball","id":23195746,"node_id":"MDQ6VXNlcjIzMTk1NzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/23195746?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-kimball","html_url":"https://github.com/matt-kimball","followers_url":"https://api.github.com/users/matt-kimball/followers","following_url":"https://api.github.com/users/matt-kimball/following{/other_user}","gists_url":"https://api.github.com/users/matt-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-kimball/subscriptions","organizations_url":"https://api.github.com/users/matt-kimball/orgs","repos_url":"https://api.github.com/users/matt-kimball/repos","events_url":"https://api.github.com/users/matt-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/matt-kimball/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matt-kimball/mtr","description":"Official repository for mtr, a network diagnostic tool","fork":true,"url":"https://api.github.com/repos/matt-kimball/mtr","forks_url":"https://api.github.com/repos/matt-kimball/mtr/forks","keys_url":"https://api.github.com/repos/matt-kimball/mtr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matt-kimball/mtr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matt-kimball/mtr/teams","hooks_url":"https://api.github.com/repos/matt-kimball/mtr/hooks","issue_events_url":"https://api.github.com/repos/matt-kimball/mtr/issues/events{/number}","events_url":"https://api.github.com/repos/matt-kimball/mtr/events","assignees_url":"https://api.github.com/repos/matt-kimball/mtr/assignees{/user}","branches_url":"https://api.github.com/repos/matt-kimball/mtr/branches{/branch}","tags_url":"https://api.github.com/repos/matt-kimball/mtr/tags","blobs_url":"https://api.github.com/repos/matt-kimball/mtr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matt-kimball/mtr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matt-kimball/mtr/git/refs{/sha}","trees_url":"https://api.github.com/repos/matt-kimball/mtr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matt-kimball/mtr/statuses/{sha}","languages_url":"https://api.github.com/repos/matt-kimball/mtr/languages","stargazers_url":"https://api.github.com/repos/matt-kimball/mtr/stargazers","contributors_url":"https://api.github.com/repos/matt-kimball/mtr/contributors","subscribers_url":"https://api.github.com/repos/matt-kimball/mtr/subscribers","subscription_url":"https://api.github.com/repos/matt-kimball/mtr/subscription","commits_url":"https://api.github.com/repos/matt-kimball/mtr/commits{/sha}","git_commits_url":"https://api.github.com/repos/matt-kimball/mtr/git/commits{/sha}","comments_url":"https://api.github.com/repos/matt-kimball/mtr/comments{/number}","issue_comment_url":"https://api.github.com/repos/matt-kimball/mtr/issues/comments{/number}","contents_url":"https://api.github.com/repos/matt-kimball/mtr/contents/{+path}","compare_url":"https://api.github.com/repos/matt-kimball/mtr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matt-kimball/mtr/merges","archive_url":"https://api.github.com/repos/matt-kimball/mtr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matt-kimball/mtr/downloads","issues_url":"https://api.github.com/repos/matt-kimball/mtr/issues{/number}","pulls_url":"https://api.github.com/repos/matt-kimball/mtr/pulls{/number}","milestones_url":"https://api.github.com/repos/matt-kimball/mtr/milestones{/number}","notifications_url":"https://api.github.com/repos/matt-kimball/mtr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matt-kimball/mtr/labels{/name}","releases_url":"https://api.github.com/repos/matt-kimball/mtr/releases{/id}","deployments_url":"https://api.github.com/repos/matt-kimball/mtr/deployments","created_at":"2016-12-01T01:33:34Z","updated_at":"2019-02-12T16:07:35Z","pushed_at":"2019-02-14T16:29:06Z","git_url":"git://github.com/matt-kimball/mtr.git","ssh_url":"git@github.com:matt-kimball/mtr.git","clone_url":"https://github.com/matt-kimball/mtr.git","svn_url":"https://github.com/matt-kimball/mtr","homepage":"http://www.bitwizard.nl/mtr/","size":1206,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"traviscross:master","ref":"master","sha":"3649b04337d38725f58a3d8ebe7845cb7fa3cabf","user":{"login":"traviscross","id":1076834,"node_id":"MDQ6VXNlcjEwNzY4MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1076834?v=4","gravatar_id":"","url":"https://api.github.com/users/traviscross","html_url":"https://github.com/traviscross","followers_url":"https://api.github.com/users/traviscross/followers","following_url":"https://api.github.com/users/traviscross/following{/other_user}","gists_url":"https://api.github.com/users/traviscross/gists{/gist_id}","starred_url":"https://api.github.com/users/traviscross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviscross/subscriptions","organizations_url":"https://api.github.com/users/traviscross/orgs","repos_url":"https://api.github.com/users/traviscross/repos","events_url":"https://api.github.com/users/traviscross/events{/privacy}","received_events_url":"https://api.github.com/users/traviscross/received_events","type":"User","site_admin":false},"repo":{"id":7972402,"node_id":"MDEwOlJlcG9zaXRvcnk3OTcyNDAy","name":"mtr","full_name":"traviscross/mtr","private":false,"owner":{"login":"traviscross","id":1076834,"node_id":"MDQ6VXNlcjEwNzY4MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1076834?v=4","gravatar_id":"","url":"https://api.github.com/users/traviscross","html_url":"https://github.com/traviscross","followers_url":"https://api.github.com/users/traviscross/followers","following_url":"https://api.github.com/users/traviscross/following{/other_user}","gists_url":"https://api.github.com/users/traviscross/gists{/gist_id}","starred_url":"https://api.github.com/users/traviscross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traviscross/subscriptions","organizations_url":"https://api.github.com/users/traviscross/orgs","repos_url":"https://api.github.com/users/traviscross/repos","events_url":"https://api.github.com/users/traviscross/events{/privacy}","received_events_url":"https://api.github.com/users/traviscross/received_events","type":"User","site_admin":false},"html_url":"https://github.com/traviscross/mtr","description":"Official repository for mtr, a network diagnostic tool","fork":false,"url":"https://api.github.com/repos/traviscross/mtr","forks_url":"https://api.github.com/repos/traviscross/mtr/forks","keys_url":"https://api.github.com/repos/traviscross/mtr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traviscross/mtr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traviscross/mtr/teams","hooks_url":"https://api.github.com/repos/traviscross/mtr/hooks","issue_events_url":"https://api.github.com/repos/traviscross/mtr/issues/events{/number}","events_url":"https://api.github.com/repos/traviscross/mtr/events","assignees_url":"https://api.github.com/repos/traviscross/mtr/assignees{/user}","branches_url":"https://api.github.com/repos/traviscross/mtr/branches{/branch}","tags_url":"https://api.github.com/repos/traviscross/mtr/tags","blobs_url":"https://api.github.com/repos/traviscross/mtr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traviscross/mtr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traviscross/mtr/git/refs{/sha}","trees_url":"https://api.github.com/repos/traviscross/mtr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traviscross/mtr/statuses/{sha}","languages_url":"https://api.github.com/repos/traviscross/mtr/languages","stargazers_url":"https://api.github.com/repos/traviscross/mtr/stargazers","contributors_url":"https://api.github.com/repos/traviscross/mtr/contributors","subscribers_url":"https://api.github.com/repos/traviscross/mtr/subscribers","subscription_url":"https://api.github.com/repos/traviscross/mtr/subscription","commits_url":"https://api.github.com/repos/traviscross/mtr/commits{/sha}","git_commits_url":"https://api.github.com/repos/traviscross/mtr/git/commits{/sha}","comments_url":"https://api.github.com/repos/traviscross/mtr/comments{/number}","issue_comment_url":"https://api.github.com/repos/traviscross/mtr/issues/comments{/number}","contents_url":"https://api.github.com/repos/traviscross/mtr/contents/{+path}","compare_url":"https://api.github.com/repos/traviscross/mtr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traviscross/mtr/merges","archive_url":"https://api.github.com/repos/traviscross/mtr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traviscross/mtr/downloads","issues_url":"https://api.github.com/repos/traviscross/mtr/issues{/number}","pulls_url":"https://api.github.com/repos/traviscross/mtr/pulls{/number}","milestones_url":"https://api.github.com/repos/traviscross/mtr/milestones{/number}","notifications_url":"https://api.github.com/repos/traviscross/mtr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traviscross/mtr/labels{/name}","releases_url":"https://api.github.com/repos/traviscross/mtr/releases{/id}","deployments_url":"https://api.github.com/repos/traviscross/mtr/deployments","created_at":"2013-02-02T06:01:22Z","updated_at":"2019-02-14T11:21:41Z","pushed_at":"2019-02-14T11:21:39Z","git_url":"git://github.com/traviscross/mtr.git","ssh_url":"git@github.com:traviscross/mtr.git","clone_url":"https://github.com/traviscross/mtr.git","svn_url":"https://github.com/traviscross/mtr","homepage":"http://www.bitwizard.nl/mtr/","size":1210,"stargazers_count":1074,"watchers_count":1074,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":205,"open_issues":82,"watchers":1074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/traviscross/mtr/pulls/289"},"html":{"href":"https://github.com/traviscross/mtr/pull/289"},"issue":{"href":"https://api.github.com/repos/traviscross/mtr/issues/289"},"comments":{"href":"https://api.github.com/repos/traviscross/mtr/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/traviscross/mtr/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/traviscross/mtr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/traviscross/mtr/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/traviscross/mtr/statuses/726a40ac0ea68900f0226f68fbd1a86c10adf119"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matt-kimball"}}