{"action":"opened","number":12869,"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/12869","id":272493462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyNDkzNDYy","html_url":"https://github.com/getsentry/sentry/pull/12869","diff_url":"https://github.com/getsentry/sentry/pull/12869.diff","patch_url":"https://github.com/getsentry/sentry/pull/12869.patch","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/12869","number":12869,"state":"open","locked":false,"title":"fix(dropdown-autocomplete): resolve arrow-key regression cause by addition of react-virtualized","user":{"login":"Chrissy","id":435981,"node_id":"MDQ6VXNlcjQzNTk4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/435981?v=4","gravatar_id":"","url":"https://api.github.com/users/Chrissy","html_url":"https://github.com/Chrissy","followers_url":"https://api.github.com/users/Chrissy/followers","following_url":"https://api.github.com/users/Chrissy/following{/other_user}","gists_url":"https://api.github.com/users/Chrissy/gists{/gist_id}","starred_url":"https://api.github.com/users/Chrissy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chrissy/subscriptions","organizations_url":"https://api.github.com/users/Chrissy/orgs","repos_url":"https://api.github.com/users/Chrissy/repos","events_url":"https://api.github.com/users/Chrissy/events{/privacy}","received_events_url":"https://api.github.com/users/Chrissy/received_events","type":"User","site_admin":false},"body":"![down-key](https://user-images.githubusercontent.com/435981/56521903-c0c13580-64fa-11e9-91ef-215b302bdcc9.gif)\r\n\r\ntldr;\r\n\r\n* autocomplete counts the number of child items and uses this to determine the limit of the index when arrowing around\r\n* react-virtualized will change the order and number of children fed into autocomplete\r\n* this is generally ok because we keep track of things by an index that is assigned from _above_ virtualized, so virtualized can do it's job in ignorant bliss\r\n* except for the arrow key limit, which is not fed in from above but is instead determined internally, so therefore the limit will more or less cap out at 10 which is the limit of react-virtualized, regardless of how many items are actually fed in. \r\n\r\nto fix this we feed in the results count from the top (omitting labels):\r\n\r\n![down-key-fixed](https://user-images.githubusercontent.com/435981/56526418-1993cc80-6501-11e9-8950-db287e964bba.gif)\r\n\r\n\r\n\r\n","created_at":"2019-04-22T20:29:16Z","updated_at":"2019-04-22T20:29:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"billyvg","id":79684,"node_id":"MDQ6VXNlcjc5Njg0","avatar_url":"https://avatars3.githubusercontent.com/u/79684?v=4","gravatar_id":"","url":"https://api.github.com/users/billyvg","html_url":"https://github.com/billyvg","followers_url":"https://api.github.com/users/billyvg/followers","following_url":"https://api.github.com/users/billyvg/following{/other_user}","gists_url":"https://api.github.com/users/billyvg/gists{/gist_id}","starred_url":"https://api.github.com/users/billyvg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billyvg/subscriptions","organizations_url":"https://api.github.com/users/billyvg/orgs","repos_url":"https://api.github.com/users/billyvg/repos","events_url":"https://api.github.com/users/billyvg/events{/privacy}","received_events_url":"https://api.github.com/users/billyvg/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"app-frontend","id":2894806,"node_id":"MDQ6VGVhbTI4OTQ4MDY=","slug":"app-frontend","description":"Application Frontend - JS/React/webpack/etc","privacy":"closed","url":"https://api.github.com/teams/2894806","html_url":"https://github.com/orgs/getsentry/teams/app-frontend","members_url":"https://api.github.com/teams/2894806/members{/member}","repositories_url":"https://api.github.com/teams/2894806/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/sentry/pulls/12869/commits","review_comments_url":"https://api.github.com/repos/getsentry/sentry/pulls/12869/comments","review_comment_url":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/12869/comments","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/b3814b45560126884aeaef941fd6e4c2e7a98235","head":{"label":"getsentry:fix/dropdown-autocomplete/fix-arrow-key-length-bug","ref":"fix/dropdown-autocomplete/fix-arrow-key-length-bug","sha":"b3814b45560126884aeaef941fd6e4c2e7a98235","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzMjg=","name":"sentry","full_name":"getsentry/sentry","private":false,"owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform application monitoring, with a focus on error reporting.","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2019-04-22T19:15:03Z","pushed_at":"2019-04-22T20:27:59Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":104446,"stargazers_count":20578,"watchers_count":20578,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":823,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2349,"open_issues":823,"watchers":20578,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"9be8904f66e984a02b1bd65db3344144b0e15a88","user":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"node_id":"MDEwOlJlcG9zaXRvcnk4NzMzMjg=","name":"sentry","full_name":"getsentry/sentry","private":false,"owner":{"login":"getsentry","id":1396951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTY5NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/getsentry/sentry","description":"Sentry is cross-platform application monitoring, with a focus on error reporting.","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2019-04-22T19:15:03Z","pushed_at":"2019-04-22T20:27:59Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":104446,"stargazers_count":20578,"watchers_count":20578,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":823,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2349,"open_issues":823,"watchers":20578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/12869"},"html":{"href":"https://github.com/getsentry/sentry/pull/12869"},"issue":{"href":"https://api.github.com/repos/getsentry/sentry/issues/12869"},"comments":{"href":"https://api.github.com/repos/getsentry/sentry/issues/12869/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/12869/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/12869/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/sentry/statuses/b3814b45560126884aeaef941fd6e4c2e7a98235"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":19,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"Chrissy"}}