{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/sun/issues/499","repository_url":"https://api.github.com/repos/phetsims/sun","labels_url":"https://api.github.com/repos/phetsims/sun/issues/499/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/sun/issues/499/comments","events_url":"https://api.github.com/repos/phetsims/sun/issues/499/events","html_url":"https://github.com/phetsims/sun/issues/499","id":433491043,"node_id":"MDU6SXNzdWU0MzM0OTEwNDM=","number":499,"title":"Expand functionality of AccessibleValueHandler","user":{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"labels":[{"id":243338588,"node_id":"MDU6TGFiZWwyNDMzMzg1ODg=","url":"https://api.github.com/repos/phetsims/sun/labels/dev:a11y","name":"dev:a11y","color":"008080","default":false},{"id":322344996,"node_id":"MDU6TGFiZWwzMjIzNDQ5OTY=","url":"https://api.github.com/repos/phetsims/sun/labels/status:ready-for-review","name":"status:ready-for-review","color":"3E766D","default":false}],"state":"closed","locked":false,"assignee":{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2019-04-15T21:42:17Z","updated_at":"2019-05-21T21:26:29Z","closed_at":"2019-05-21T21:26:29Z","author_association":"CONTRIBUTOR","body":"In phetsims/scenery#951 @zepumph made a new type called AccessibleValueHandler that handles `aria-valuetext` for an a11y component that is driven by a NumberProperty. AccessibleSlider and AccessibleNumberSpinner are using this. There may be other things that can be moved into AccessibleValueHandler as well. For instance, the input handling of these two types are similar. AccessibleValueHandler could have functions like\r\n```js\r\n       /**\r\n        * Adds a listener to the Node that set the NumberProperty when home/end are pressed.\r\n        **/\r\n        addHomeEndListener() {}\r\n```\r\n\r\nOr instead of adding listeners we could just have reusable functions that do this work and add custom listeners in the subtypes.\r\n\r\nWe also mentioned in phetsims/scenery#951 we also mentioned that perhaps `aria-valuetext` and `inputValue` setters of Accessibility.js could be moved into the AccessibleValueHandler trait."},"comment":{"url":"https://api.github.com/repos/phetsims/sun/issues/comments/494565068","html_url":"https://github.com/phetsims/sun/issues/499#issuecomment-494565068","issue_url":"https://api.github.com/repos/phetsims/sun/issues/499","id":494565068,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5NDU2NTA2OA==","user":{"login":"jessegreenberg","id":6396244,"node_id":"MDQ6VXNlcjYzOTYyNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/6396244?v=4","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"created_at":"2019-05-21T21:26:29Z","updated_at":"2019-05-21T21:26:29Z","author_association":"CONTRIBUTOR","body":"TODO removed and styling of the buttons is working correctly again. That was the last thing, this issue can be closed."}}
{"actor":{"display_login":"jessegreenberg"}}