{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/362651776","pull_request_review_id":337886025,"id":362651776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MjY1MTc3Ng==","diff_hunk":"@@ -643,14 +643,14 @@ MXNET_DLL int MXNDArrayCreateSparseEx(int storage_type,\n \n MXNET_DLL int MXNDArrayCreateSparseEx64(int storage_type,\n                                         const int64_t *shape,\n-                                        int ndim,\n+                                        uint32_t ndim,","path":"include/mxnet/c_api.h","position":null,"original_position":5,"commit_id":"2115c6979b786e3c870894e1e8577a3b83a9ba55","original_commit_id":"b814ae14de60689f68949b4903e6ff5f0e4ebd8c","user":{"login":"ChaiBapchya","id":10992635,"node_id":"MDQ6VXNlcjEwOTkyNjM1","avatar_url":"https://avatars3.githubusercontent.com/u/10992635?v=4","gravatar_id":"","url":"https://api.github.com/users/ChaiBapchya","html_url":"https://github.com/ChaiBapchya","followers_url":"https://api.github.com/users/ChaiBapchya/followers","following_url":"https://api.github.com/users/ChaiBapchya/following{/other_user}","gists_url":"https://api.github.com/users/ChaiBapchya/gists{/gist_id}","starred_url":"https://api.github.com/users/ChaiBapchya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChaiBapchya/subscriptions","organizations_url":"https://api.github.com/users/ChaiBapchya/orgs","repos_url":"https://api.github.com/users/ChaiBapchya/repos","events_url":"https://api.github.com/users/ChaiBapchya/events{/privacy}","received_events_url":"https://api.github.com/users/ChaiBapchya/received_events","type":"User","site_admin":false},"body":"@reminisce Confirmed with him. -1 is used to indicate \"unknown\". Internally mxnet does use int. Hence it makes sense to add 64bit API with ndim as int. \r\nSince 32 bit API existed before with uint32_t, not sure if it makes sense to have a API breaking change.","created_at":"2020-01-02T22:20:12Z","updated_at":"2020-01-02T22:20:13Z","html_url":"https://github.com/apache/incubator-mxnet/pull/16898#discussion_r362651776","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/362651776"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/16898#discussion_r362651776"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898"}},"in_reply_to_id":360771498},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898","id":345054297,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1MDU0Mjk3","html_url":"https://github.com/apache/incubator-mxnet/pull/16898","diff_url":"https://github.com/apache/incubator-mxnet/pull/16898.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/16898.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/16898","number":16898,"state":"open","locked":false,"title":"Sparse int64 Large tensor support","user":{"login":"ChaiBapchya","id":10992635,"node_id":"MDQ6VXNlcjEwOTkyNjM1","avatar_url":"https://avatars3.githubusercontent.com/u/10992635?v=4","gravatar_id":"","url":"https://api.github.com/users/ChaiBapchya","html_url":"https://github.com/ChaiBapchya","followers_url":"https://api.github.com/users/ChaiBapchya/followers","following_url":"https://api.github.com/users/ChaiBapchya/following{/other_user}","gists_url":"https://api.github.com/users/ChaiBapchya/gists{/gist_id}","starred_url":"https://api.github.com/users/ChaiBapchya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChaiBapchya/subscriptions","organizations_url":"https://api.github.com/users/ChaiBapchya/orgs","repos_url":"https://api.github.com/users/ChaiBapchya/repos","events_url":"https://api.github.com/users/ChaiBapchya/events{/privacy}","received_events_url":"https://api.github.com/users/ChaiBapchya/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nAdds support to Sparse tensor creation\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- [x] Code is well-documented: \r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [x] src/c_api/c_api.cc\r\n- [x]  python/mxnet/ndarray/sparse.py\r\n- [x] tests/nightly/test_large_array.py\r\n\r\n### Test ###\r\n```\r\npython -m nose tests/nightly/test_large_array.py:test_sparse_dot\r\n.\r\n----------------------------------------------------------------------\r\nRan 1 test in 3.688s\r\n\r\nOK\r\n```","created_at":"2019-11-25T07:06:22Z","updated_at":"2020-01-02T22:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d12e908caccba55c838e2c804212dc14dce1121","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anirudh2290","id":1522319,"node_id":"MDQ6VXNlcjE1MjIzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1522319?v=4","gravatar_id":"","url":"https://api.github.com/users/anirudh2290","html_url":"https://github.com/anirudh2290","followers_url":"https://api.github.com/users/anirudh2290/followers","following_url":"https://api.github.com/users/anirudh2290/following{/other_user}","gists_url":"https://api.github.com/users/anirudh2290/gists{/gist_id}","starred_url":"https://api.github.com/users/anirudh2290/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anirudh2290/subscriptions","organizations_url":"https://api.github.com/users/anirudh2290/orgs","repos_url":"https://api.github.com/users/anirudh2290/repos","events_url":"https://api.github.com/users/anirudh2290/events{/privacy}","received_events_url":"https://api.github.com/users/anirudh2290/received_events","type":"User","site_admin":false},{"login":"szha","id":2626883,"node_id":"MDQ6VXNlcjI2MjY4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false},{"login":"eric-haibin-lin","id":5545640,"node_id":"MDQ6VXNlcjU1NDU2NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/16898/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/2115c6979b786e3c870894e1e8577a3b83a9ba55","head":{"label":"ChaiBapchya:sparse_int64_fix","ref":"sparse_int64_fix","sha":"2115c6979b786e3c870894e1e8577a3b83a9ba55","user":{"login":"ChaiBapchya","id":10992635,"node_id":"MDQ6VXNlcjEwOTkyNjM1","avatar_url":"https://avatars3.githubusercontent.com/u/10992635?v=4","gravatar_id":"","url":"https://api.github.com/users/ChaiBapchya","html_url":"https://github.com/ChaiBapchya","followers_url":"https://api.github.com/users/ChaiBapchya/followers","following_url":"https://api.github.com/users/ChaiBapchya/following{/other_user}","gists_url":"https://api.github.com/users/ChaiBapchya/gists{/gist_id}","starred_url":"https://api.github.com/users/ChaiBapchya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChaiBapchya/subscriptions","organizations_url":"https://api.github.com/users/ChaiBapchya/orgs","repos_url":"https://api.github.com/users/ChaiBapchya/repos","events_url":"https://api.github.com/users/ChaiBapchya/events{/privacy}","received_events_url":"https://api.github.com/users/ChaiBapchya/received_events","type":"User","site_admin":false},"repo":{"id":147581538,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1ODE1Mzg=","name":"incubator-mxnet","full_name":"ChaiBapchya/incubator-mxnet","private":false,"owner":{"login":"ChaiBapchya","id":10992635,"node_id":"MDQ6VXNlcjEwOTkyNjM1","avatar_url":"https://avatars3.githubusercontent.com/u/10992635?v=4","gravatar_id":"","url":"https://api.github.com/users/ChaiBapchya","html_url":"https://github.com/ChaiBapchya","followers_url":"https://api.github.com/users/ChaiBapchya/followers","following_url":"https://api.github.com/users/ChaiBapchya/following{/other_user}","gists_url":"https://api.github.com/users/ChaiBapchya/gists{/gist_id}","starred_url":"https://api.github.com/users/ChaiBapchya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChaiBapchya/subscriptions","organizations_url":"https://api.github.com/users/ChaiBapchya/orgs","repos_url":"https://api.github.com/users/ChaiBapchya/repos","events_url":"https://api.github.com/users/ChaiBapchya/events{/privacy}","received_events_url":"https://api.github.com/users/ChaiBapchya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ChaiBapchya/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet","forks_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/ChaiBapchya/incubator-mxnet/deployments","created_at":"2018-09-05T21:28:04Z","updated_at":"2019-12-30T19:24:25Z","pushed_at":"2020-01-02T17:44:53Z","git_url":"git://github.com/ChaiBapchya/incubator-mxnet.git","ssh_url":"git@github.com:ChaiBapchya/incubator-mxnet.git","clone_url":"https://github.com/ChaiBapchya/incubator-mxnet.git","svn_url":"https://github.com/ChaiBapchya/incubator-mxnet","homepage":"https://mxnet.apache.org","size":76015,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"06aec8aada4c79991a854d27907e16f8815d95ad","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2020-01-02T21:26:05Z","pushed_at":"2020-01-02T22:02:20Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":76735,"stargazers_count":18232,"watchers_count":18232,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6485,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1626,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6485,"open_issues":1626,"watchers":18232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/16898"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/16898"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/16898/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/16898/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/2115c6979b786e3c870894e1e8577a3b83a9ba55"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChaiBapchya"}}