{"action":"created","comment":{"url":"https://api.github.com/repos/manifoldco/ui/pulls/comments/320994278","pull_request_review_id":283919895,"id":320994278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDk5NDI3OA==","diff_hunk":"@@ -26,15 +25,6 @@ export class ManifoldAuthToken {\n \n   componentWillLoad() {\n     this.setExternalToken(this.token);\n-    if (this.subscribe) {\n-      this.unsubscribe = this.subscribe((oldToken?: string, newToken?: string) => {\n-        if (oldToken && !newToken && this.oauthUrl) {\n-          const url = new URL(this.oauthUrl, window.location.href);\n-          url.searchParams.set('ts', new Date().getTime().toString());\n-          this.oauthUrl = url.href;\n-        }\n-      });\n-    }","path":"src/components/manifold-auth-token/manifold-auth-token.tsx","position":20,"original_position":20,"commit_id":"968de0f31ee391327d67ec932185819d93044de2","original_commit_id":"968de0f31ee391327d67ec932185819d93044de2","user":{"login":"dangodev","id":1369770,"node_id":"MDQ6VXNlcjEzNjk3NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1369770?v=4","gravatar_id":"","url":"https://api.github.com/users/dangodev","html_url":"https://github.com/dangodev","followers_url":"https://api.github.com/users/dangodev/followers","following_url":"https://api.github.com/users/dangodev/following{/other_user}","gists_url":"https://api.github.com/users/dangodev/gists{/gist_id}","starred_url":"https://api.github.com/users/dangodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangodev/subscriptions","organizations_url":"https://api.github.com/users/dangodev/orgs","repos_url":"https://api.github.com/users/dangodev/repos","events_url":"https://api.github.com/users/dangodev/events{/privacy}","received_events_url":"https://api.github.com/users/dangodev/received_events","type":"User","site_admin":false},"body":"This is the bit I was unsure about to get it working in UI.\r\n\r\n`<manifold-auth>` no longer has the `oauth-url` prop, which means we can’t set it. Which means we should remove the `oauth-url` prop from the `<manifold-auth-token>` component as well. Which means… should we be listening for changes? Is there anything else happening here we need to reserve?","created_at":"2019-09-04T22:00:09Z","updated_at":"2019-09-04T22:00:09Z","html_url":"https://github.com/manifoldco/ui/pull/477#discussion_r320994278","pull_request_url":"https://api.github.com/repos/manifoldco/ui/pulls/477","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/comments/320994278"},"html":{"href":"https://github.com/manifoldco/ui/pull/477#discussion_r320994278"},"pull_request":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/477"}}},"pull_request":{"url":"https://api.github.com/repos/manifoldco/ui/pulls/477","id":314244927,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE0MjQ0OTI3","html_url":"https://github.com/manifoldco/ui/pull/477","diff_url":"https://github.com/manifoldco/ui/pull/477.diff","patch_url":"https://github.com/manifoldco/ui/pull/477.patch","issue_url":"https://api.github.com/repos/manifoldco/ui/issues/477","number":477,"state":"open","locked":false,"title":"Update shadowcat","user":{"login":"dangodev","id":1369770,"node_id":"MDQ6VXNlcjEzNjk3NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1369770?v=4","gravatar_id":"","url":"https://api.github.com/users/dangodev","html_url":"https://github.com/dangodev","followers_url":"https://api.github.com/users/dangodev/followers","following_url":"https://api.github.com/users/dangodev/following{/other_user}","gists_url":"https://api.github.com/users/dangodev/gists{/gist_id}","starred_url":"https://api.github.com/users/dangodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangodev/subscriptions","organizations_url":"https://api.github.com/users/dangodev/orgs","repos_url":"https://api.github.com/users/dangodev/repos","events_url":"https://api.github.com/users/dangodev/events{/privacy}","received_events_url":"https://api.github.com/users/dangodev/received_events","type":"User","site_admin":false},"body":"## Reason for change\r\n\r\nUpdates UI with the latest security fixes from manifoldco/shadowcat.\r\n\r\n## Testing\r\n\r\nTesting has been completed in a partner platform, and everything still worked fine with all the new security patches. That’d be the recommended way to test this PR.\r\n\r\n## Checklist\r\n\r\n<!-- are all the steps completed? -->\r\n\r\n- [ ] **CHANGELOG**: The **Unreleased** section of CHANGELOG was updated\r\n- [ ] **Prop changes**: [docs][docs] were updated\r\n- [ ] **Prop changes**: E2E tests were updated, testing from the highest level possible\r\n- [ ] **Platform testing**: If this change should be [tested against a platform][platform-testing], has it been?\r\n\r\n[docs]: https://ui.sandbox.manifold.co\r\n[platform-testing]: https://app.gitbook.com/@manifold/s/engineering/playbooks/testing-your-code-against-a-platform\r\n","created_at":"2019-09-04T21:58:45Z","updated_at":"2019-09-04T22:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c823757d56aa51afad998e0d7a581032c171564","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sslotsky","id":374078,"node_id":"MDQ6VXNlcjM3NDA3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/374078?v=4","gravatar_id":"","url":"https://api.github.com/users/sslotsky","html_url":"https://github.com/sslotsky","followers_url":"https://api.github.com/users/sslotsky/followers","following_url":"https://api.github.com/users/sslotsky/following{/other_user}","gists_url":"https://api.github.com/users/sslotsky/gists{/gist_id}","starred_url":"https://api.github.com/users/sslotsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslotsky/subscriptions","organizations_url":"https://api.github.com/users/sslotsky/orgs","repos_url":"https://api.github.com/users/sslotsky/repos","events_url":"https://api.github.com/users/sslotsky/events{/privacy}","received_events_url":"https://api.github.com/users/sslotsky/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/manifoldco/ui/pulls/477/commits","review_comments_url":"https://api.github.com/repos/manifoldco/ui/pulls/477/comments","review_comment_url":"https://api.github.com/repos/manifoldco/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manifoldco/ui/issues/477/comments","statuses_url":"https://api.github.com/repos/manifoldco/ui/statuses/968de0f31ee391327d67ec932185819d93044de2","head":{"label":"manifoldco:dangodev/update-shadowcat","ref":"dangodev/update-shadowcat","sha":"968de0f31ee391327d67ec932185819d93044de2","user":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"repo":{"id":168354990,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNTQ5OTA=","name":"ui","full_name":"manifoldco/ui","private":false,"owner":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/manifoldco/ui","description":"Manifold’s web component UI library","fork":false,"url":"https://api.github.com/repos/manifoldco/ui","forks_url":"https://api.github.com/repos/manifoldco/ui/forks","keys_url":"https://api.github.com/repos/manifoldco/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manifoldco/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manifoldco/ui/teams","hooks_url":"https://api.github.com/repos/manifoldco/ui/hooks","issue_events_url":"https://api.github.com/repos/manifoldco/ui/issues/events{/number}","events_url":"https://api.github.com/repos/manifoldco/ui/events","assignees_url":"https://api.github.com/repos/manifoldco/ui/assignees{/user}","branches_url":"https://api.github.com/repos/manifoldco/ui/branches{/branch}","tags_url":"https://api.github.com/repos/manifoldco/ui/tags","blobs_url":"https://api.github.com/repos/manifoldco/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manifoldco/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manifoldco/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/manifoldco/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manifoldco/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/manifoldco/ui/languages","stargazers_url":"https://api.github.com/repos/manifoldco/ui/stargazers","contributors_url":"https://api.github.com/repos/manifoldco/ui/contributors","subscribers_url":"https://api.github.com/repos/manifoldco/ui/subscribers","subscription_url":"https://api.github.com/repos/manifoldco/ui/subscription","commits_url":"https://api.github.com/repos/manifoldco/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/manifoldco/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/manifoldco/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/manifoldco/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/manifoldco/ui/contents/{+path}","compare_url":"https://api.github.com/repos/manifoldco/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manifoldco/ui/merges","archive_url":"https://api.github.com/repos/manifoldco/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manifoldco/ui/downloads","issues_url":"https://api.github.com/repos/manifoldco/ui/issues{/number}","pulls_url":"https://api.github.com/repos/manifoldco/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/manifoldco/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/manifoldco/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manifoldco/ui/labels{/name}","releases_url":"https://api.github.com/repos/manifoldco/ui/releases{/id}","deployments_url":"https://api.github.com/repos/manifoldco/ui/deployments","created_at":"2019-01-30T14:19:58Z","updated_at":"2019-09-04T18:59:33Z","pushed_at":"2019-09-04T21:58:46Z","git_url":"git://github.com/manifoldco/ui.git","ssh_url":"git@github.com:manifoldco/ui.git","clone_url":"https://github.com/manifoldco/ui.git","svn_url":"https://github.com/manifoldco/ui","homepage":"https://ui.sandbox.manifold.co","size":5499,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"manifoldco:master","ref":"master","sha":"495f9bdf620bc4253463d9ce981ed9bb06267d1c","user":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"repo":{"id":168354990,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgzNTQ5OTA=","name":"ui","full_name":"manifoldco/ui","private":false,"owner":{"login":"manifoldco","id":16501525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTAxNTI1","avatar_url":"https://avatars2.githubusercontent.com/u/16501525?v=4","gravatar_id":"","url":"https://api.github.com/users/manifoldco","html_url":"https://github.com/manifoldco","followers_url":"https://api.github.com/users/manifoldco/followers","following_url":"https://api.github.com/users/manifoldco/following{/other_user}","gists_url":"https://api.github.com/users/manifoldco/gists{/gist_id}","starred_url":"https://api.github.com/users/manifoldco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manifoldco/subscriptions","organizations_url":"https://api.github.com/users/manifoldco/orgs","repos_url":"https://api.github.com/users/manifoldco/repos","events_url":"https://api.github.com/users/manifoldco/events{/privacy}","received_events_url":"https://api.github.com/users/manifoldco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/manifoldco/ui","description":"Manifold’s web component UI library","fork":false,"url":"https://api.github.com/repos/manifoldco/ui","forks_url":"https://api.github.com/repos/manifoldco/ui/forks","keys_url":"https://api.github.com/repos/manifoldco/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manifoldco/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manifoldco/ui/teams","hooks_url":"https://api.github.com/repos/manifoldco/ui/hooks","issue_events_url":"https://api.github.com/repos/manifoldco/ui/issues/events{/number}","events_url":"https://api.github.com/repos/manifoldco/ui/events","assignees_url":"https://api.github.com/repos/manifoldco/ui/assignees{/user}","branches_url":"https://api.github.com/repos/manifoldco/ui/branches{/branch}","tags_url":"https://api.github.com/repos/manifoldco/ui/tags","blobs_url":"https://api.github.com/repos/manifoldco/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manifoldco/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manifoldco/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/manifoldco/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manifoldco/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/manifoldco/ui/languages","stargazers_url":"https://api.github.com/repos/manifoldco/ui/stargazers","contributors_url":"https://api.github.com/repos/manifoldco/ui/contributors","subscribers_url":"https://api.github.com/repos/manifoldco/ui/subscribers","subscription_url":"https://api.github.com/repos/manifoldco/ui/subscription","commits_url":"https://api.github.com/repos/manifoldco/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/manifoldco/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/manifoldco/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/manifoldco/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/manifoldco/ui/contents/{+path}","compare_url":"https://api.github.com/repos/manifoldco/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manifoldco/ui/merges","archive_url":"https://api.github.com/repos/manifoldco/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manifoldco/ui/downloads","issues_url":"https://api.github.com/repos/manifoldco/ui/issues{/number}","pulls_url":"https://api.github.com/repos/manifoldco/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/manifoldco/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/manifoldco/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manifoldco/ui/labels{/name}","releases_url":"https://api.github.com/repos/manifoldco/ui/releases{/id}","deployments_url":"https://api.github.com/repos/manifoldco/ui/deployments","created_at":"2019-01-30T14:19:58Z","updated_at":"2019-09-04T18:59:33Z","pushed_at":"2019-09-04T21:58:46Z","git_url":"git://github.com/manifoldco/ui.git","ssh_url":"git@github.com:manifoldco/ui.git","clone_url":"https://github.com/manifoldco/ui.git","svn_url":"https://github.com/manifoldco/ui","homepage":"https://ui.sandbox.manifold.co","size":5499,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/477"},"html":{"href":"https://github.com/manifoldco/ui/pull/477"},"issue":{"href":"https://api.github.com/repos/manifoldco/ui/issues/477"},"comments":{"href":"https://api.github.com/repos/manifoldco/ui/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manifoldco/ui/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/manifoldco/ui/statuses/968de0f31ee391327d67ec932185819d93044de2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dangodev"}}