{"action":"created","issue":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/23269","repository_url":"https://api.github.com/repos/pytorch/pytorch","labels_url":"https://api.github.com/repos/pytorch/pytorch/issues/23269/labels{/name}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/23269/comments","events_url":"https://api.github.com/repos/pytorch/pytorch/issues/23269/events","html_url":"https://github.com/pytorch/pytorch/pull/23269","id":471966036,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNDgwNjky","number":23269,"title":"Rename torch::autograd::Function to torch::autograd::Node","user":{"login":"malvika2147","id":23109221,"node_id":"MDQ6VXNlcjIzMTA5MjIx","avatar_url":"https://avatars1.githubusercontent.com/u/23109221?v=4","gravatar_id":"","url":"https://api.github.com/users/malvika2147","html_url":"https://github.com/malvika2147","followers_url":"https://api.github.com/users/malvika2147/followers","following_url":"https://api.github.com/users/malvika2147/following{/other_user}","gists_url":"https://api.github.com/users/malvika2147/gists{/gist_id}","starred_url":"https://api.github.com/users/malvika2147/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malvika2147/subscriptions","organizations_url":"https://api.github.com/users/malvika2147/orgs","repos_url":"https://api.github.com/users/malvika2147/repos","events_url":"https://api.github.com/users/malvika2147/events{/privacy}","received_events_url":"https://api.github.com/users/malvika2147/received_events","type":"User","site_admin":false},"labels":[{"id":679953983,"node_id":"MDU6TGFiZWw2Nzk5NTM5ODM=","url":"https://api.github.com/repos/pytorch/pytorch/labels/jit","name":"jit","color":"c5def5","default":false},{"id":1243252054,"node_id":"MDU6TGFiZWwxMjQzMjUyMDU0","url":"https://api.github.com/repos/pytorch/pytorch/labels/merged","name":"merged","color":"39ce72","default":false},{"id":1076922545,"node_id":"MDU6TGFiZWwxMDc2OTIyNTQ1","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20autograd","name":"module: autograd","color":"f7e101","default":false},{"id":917150434,"node_id":"MDU6TGFiZWw5MTcxNTA0MzQ=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20cpp","name":"module: cpp","color":"f7e101","default":false},{"id":897287230,"node_id":"MDU6TGFiZWw4OTcyODcyMzA=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20docs","name":"module: docs","color":"f7e101","default":false},{"id":912691507,"node_id":"MDU6TGFiZWw5MTI2OTE1MDc=","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20internals","name":"module: internals","color":"f7e101","default":false},{"id":1311350199,"node_id":"MDU6TGFiZWwxMzExMzUwMTk5","url":"https://api.github.com/repos/pytorch/pytorch/labels/module:%20pybind","name":"module: pybind","color":"f7e101","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-23T21:35:50Z","updated_at":"2019-07-24T05:48:00Z","closed_at":"2019-07-24T03:54:53Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/23269","html_url":"https://github.com/pytorch/pytorch/pull/23269","diff_url":"https://github.com/pytorch/pytorch/pull/23269.diff","patch_url":"https://github.com/pytorch/pytorch/pull/23269.patch"},"body":"Stack from [ghstack](https://github.com/ezyang/ghstack):\r\n* **#23269 Rename torch::autograd::Function to torch::autograd::Node**\r\n\r\nSummary:\r\nWe will be adding an API for custom autograd functions in C++ (https://github.com/pytorch/pytorch/pull/23020) and we would like to expose it as `torch::autograd::Function` (which is different from the current `torch::autograd::Function`) to match the Python API. So, I plan to rename the current `torch::autograd::Function` to `torch::autograd::Node` and `torch::autograd::PyFunction` to `torch::autograd::PyNode`.  `FunctionTask`, and `deleteFunction` renamed to `NodeTask`, `deleteNode` for consistency.\n\nDifferential Revision: [D16454878](https://our.internmc.facebook.com/intern/diff/D16454878)"},"comment":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/comments/514489378","html_url":"https://github.com/pytorch/pytorch/pull/23269#issuecomment-514489378","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/23269","id":514489378,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNDQ4OTM3OA==","user":{"login":"pietern","id":9845,"node_id":"MDQ6VXNlcjk4NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/9845?v=4","gravatar_id":"","url":"https://api.github.com/users/pietern","html_url":"https://github.com/pietern","followers_url":"https://api.github.com/users/pietern/followers","following_url":"https://api.github.com/users/pietern/following{/other_user}","gists_url":"https://api.github.com/users/pietern/gists{/gist_id}","starred_url":"https://api.github.com/users/pietern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietern/subscriptions","organizations_url":"https://api.github.com/users/pietern/orgs","repos_url":"https://api.github.com/users/pietern/repos","events_url":"https://api.github.com/users/pietern/events{/privacy}","received_events_url":"https://api.github.com/users/pietern/received_events","type":"User","site_admin":false},"created_at":"2019-07-24T05:48:00Z","updated_at":"2019-07-24T05:48:00Z","author_association":"CONTRIBUTOR","body":"@ezyang FYI the PR summary didn't end up in the commit. Perhaps some race. But the summary here is very valuable for anyone casually reading the code and figuring out what motivated this change. "}}
{"actor":{"display_login":"pietern"}}