{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/vyper/pulls/comments/255260476","pull_request_review_id":201817945,"id":255260476,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTI2MDQ3Ng==","diff_hunk":"@@ -64,6 +64,8 @@ def transfer(_to : address, _value : uint256) -> bool:\n     @param _to The address to transfer to.\n     @param _value The amount to be transferred.\n     \"\"\"\n+    # NOTE: vyper does not allow unterflows\n+    #       so checks for sufficient funds/allowances are done implicitly","path":"examples/tokens/ERC20.vy","position":5,"original_position":5,"commit_id":"cddb91373d34aacdc0f4b56046caa639aa07039b","original_commit_id":"cddb91373d34aacdc0f4b56046caa639aa07039b","user":{"login":"fubuloubu","id":3859395,"node_id":"MDQ6VXNlcjM4NTkzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3859395?v=4","gravatar_id":"","url":"https://api.github.com/users/fubuloubu","html_url":"https://github.com/fubuloubu","followers_url":"https://api.github.com/users/fubuloubu/followers","following_url":"https://api.github.com/users/fubuloubu/following{/other_user}","gists_url":"https://api.github.com/users/fubuloubu/gists{/gist_id}","starred_url":"https://api.github.com/users/fubuloubu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fubuloubu/subscriptions","organizations_url":"https://api.github.com/users/fubuloubu/orgs","repos_url":"https://api.github.com/users/fubuloubu/repos","events_url":"https://api.github.com/users/fubuloubu/events{/privacy}","received_events_url":"https://api.github.com/users/fubuloubu/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    #       so the following subtraction would revert on insufficient balance\r\n```\r\n\r\nAlso, `underflows` above it","created_at":"2019-02-08T22:51:17Z","updated_at":"2019-02-08T22:53:29Z","html_url":"https://github.com/ethereum/vyper/pull/1238#discussion_r255260476","pull_request_url":"https://api.github.com/repos/ethereum/vyper/pulls/1238","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/vyper/pulls/comments/255260476"},"html":{"href":"https://github.com/ethereum/vyper/pull/1238#discussion_r255260476"},"pull_request":{"href":"https://api.github.com/repos/ethereum/vyper/pulls/1238"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/vyper/pulls/1238","id":251614259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNjE0MjU5","html_url":"https://github.com/ethereum/vyper/pull/1238","diff_url":"https://github.com/ethereum/vyper/pull/1238.diff","patch_url":"https://github.com/ethereum/vyper/pull/1238.patch","issue_url":"https://api.github.com/repos/ethereum/vyper/issues/1238","number":1238,"state":"open","locked":false,"title":"ERC20 contract example: Added comment for clarifying why not using assert","user":{"login":"ssteiger","id":10925195,"node_id":"MDQ6VXNlcjEwOTI1MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/10925195?v=4","gravatar_id":"","url":"https://api.github.com/users/ssteiger","html_url":"https://github.com/ssteiger","followers_url":"https://api.github.com/users/ssteiger/followers","following_url":"https://api.github.com/users/ssteiger/following{/other_user}","gists_url":"https://api.github.com/users/ssteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/ssteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssteiger/subscriptions","organizations_url":"https://api.github.com/users/ssteiger/orgs","repos_url":"https://api.github.com/users/ssteiger/repos","events_url":"https://api.github.com/users/ssteiger/events{/privacy}","received_events_url":"https://api.github.com/users/ssteiger/received_events","type":"User","site_admin":false},"body":"ref: #1237\r\n\r\n### - What I did\r\n\r\n### - How I did it\r\n\r\n### - How to verify it\r\n\r\n### - Description for the changelog\r\n\r\n### - Cute Animal Picture\r\n\r\n> put a cute animal picture here.\r\n![image](https://user-images.githubusercontent.com/10925195/52509075-1c1ba100-2bf7-11e9-975a-d825e76f7d40.png)\r\n\r\n","created_at":"2019-02-08T22:13:26Z","updated_at":"2019-02-08T22:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c944181d0a8dd0cdf0d6226e5b98183e4522d89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/vyper/pulls/1238/commits","review_comments_url":"https://api.github.com/repos/ethereum/vyper/pulls/1238/comments","review_comment_url":"https://api.github.com/repos/ethereum/vyper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/vyper/issues/1238/comments","statuses_url":"https://api.github.com/repos/ethereum/vyper/statuses/cddb91373d34aacdc0f4b56046caa639aa07039b","head":{"label":"ssteiger:patch-3","ref":"patch-3","sha":"cddb91373d34aacdc0f4b56046caa639aa07039b","user":{"login":"ssteiger","id":10925195,"node_id":"MDQ6VXNlcjEwOTI1MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/10925195?v=4","gravatar_id":"","url":"https://api.github.com/users/ssteiger","html_url":"https://github.com/ssteiger","followers_url":"https://api.github.com/users/ssteiger/followers","following_url":"https://api.github.com/users/ssteiger/following{/other_user}","gists_url":"https://api.github.com/users/ssteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/ssteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssteiger/subscriptions","organizations_url":"https://api.github.com/users/ssteiger/orgs","repos_url":"https://api.github.com/users/ssteiger/repos","events_url":"https://api.github.com/users/ssteiger/events{/privacy}","received_events_url":"https://api.github.com/users/ssteiger/received_events","type":"User","site_admin":false},"repo":{"id":169774326,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk3NzQzMjY=","name":"vyper","full_name":"ssteiger/vyper","private":false,"owner":{"login":"ssteiger","id":10925195,"node_id":"MDQ6VXNlcjEwOTI1MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/10925195?v=4","gravatar_id":"","url":"https://api.github.com/users/ssteiger","html_url":"https://github.com/ssteiger","followers_url":"https://api.github.com/users/ssteiger/followers","following_url":"https://api.github.com/users/ssteiger/following{/other_user}","gists_url":"https://api.github.com/users/ssteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/ssteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssteiger/subscriptions","organizations_url":"https://api.github.com/users/ssteiger/orgs","repos_url":"https://api.github.com/users/ssteiger/repos","events_url":"https://api.github.com/users/ssteiger/events{/privacy}","received_events_url":"https://api.github.com/users/ssteiger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ssteiger/vyper","description":"Pythonic Smart Contract Language for the EVM","fork":true,"url":"https://api.github.com/repos/ssteiger/vyper","forks_url":"https://api.github.com/repos/ssteiger/vyper/forks","keys_url":"https://api.github.com/repos/ssteiger/vyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssteiger/vyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssteiger/vyper/teams","hooks_url":"https://api.github.com/repos/ssteiger/vyper/hooks","issue_events_url":"https://api.github.com/repos/ssteiger/vyper/issues/events{/number}","events_url":"https://api.github.com/repos/ssteiger/vyper/events","assignees_url":"https://api.github.com/repos/ssteiger/vyper/assignees{/user}","branches_url":"https://api.github.com/repos/ssteiger/vyper/branches{/branch}","tags_url":"https://api.github.com/repos/ssteiger/vyper/tags","blobs_url":"https://api.github.com/repos/ssteiger/vyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssteiger/vyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssteiger/vyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssteiger/vyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssteiger/vyper/statuses/{sha}","languages_url":"https://api.github.com/repos/ssteiger/vyper/languages","stargazers_url":"https://api.github.com/repos/ssteiger/vyper/stargazers","contributors_url":"https://api.github.com/repos/ssteiger/vyper/contributors","subscribers_url":"https://api.github.com/repos/ssteiger/vyper/subscribers","subscription_url":"https://api.github.com/repos/ssteiger/vyper/subscription","commits_url":"https://api.github.com/repos/ssteiger/vyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssteiger/vyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssteiger/vyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssteiger/vyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssteiger/vyper/contents/{+path}","compare_url":"https://api.github.com/repos/ssteiger/vyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssteiger/vyper/merges","archive_url":"https://api.github.com/repos/ssteiger/vyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssteiger/vyper/downloads","issues_url":"https://api.github.com/repos/ssteiger/vyper/issues{/number}","pulls_url":"https://api.github.com/repos/ssteiger/vyper/pulls{/number}","milestones_url":"https://api.github.com/repos/ssteiger/vyper/milestones{/number}","notifications_url":"https://api.github.com/repos/ssteiger/vyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssteiger/vyper/labels{/name}","releases_url":"https://api.github.com/repos/ssteiger/vyper/releases{/id}","deployments_url":"https://api.github.com/repos/ssteiger/vyper/deployments","created_at":"2019-02-08T17:40:48Z","updated_at":"2019-02-08T17:40:51Z","pushed_at":"2019-02-08T22:11:27Z","git_url":"git://github.com/ssteiger/vyper.git","ssh_url":"git@github.com:ssteiger/vyper.git","clone_url":"https://github.com/ssteiger/vyper.git","svn_url":"https://github.com/ssteiger/vyper","homepage":"","size":3943,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"7558b237959093949317e38fae8a132254e7ee1d","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":73461676,"node_id":"MDEwOlJlcG9zaXRvcnk3MzQ2MTY3Ng==","name":"vyper","full_name":"ethereum/vyper","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/vyper","description":"Pythonic Smart Contract Language for the EVM","fork":false,"url":"https://api.github.com/repos/ethereum/vyper","forks_url":"https://api.github.com/repos/ethereum/vyper/forks","keys_url":"https://api.github.com/repos/ethereum/vyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/vyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/vyper/teams","hooks_url":"https://api.github.com/repos/ethereum/vyper/hooks","issue_events_url":"https://api.github.com/repos/ethereum/vyper/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/vyper/events","assignees_url":"https://api.github.com/repos/ethereum/vyper/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/vyper/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/vyper/tags","blobs_url":"https://api.github.com/repos/ethereum/vyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/vyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/vyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/vyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/vyper/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/vyper/languages","stargazers_url":"https://api.github.com/repos/ethereum/vyper/stargazers","contributors_url":"https://api.github.com/repos/ethereum/vyper/contributors","subscribers_url":"https://api.github.com/repos/ethereum/vyper/subscribers","subscription_url":"https://api.github.com/repos/ethereum/vyper/subscription","commits_url":"https://api.github.com/repos/ethereum/vyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/vyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/vyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/vyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/vyper/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/vyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/vyper/merges","archive_url":"https://api.github.com/repos/ethereum/vyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/vyper/downloads","issues_url":"https://api.github.com/repos/ethereum/vyper/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/vyper/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/vyper/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/vyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/vyper/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/vyper/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/vyper/deployments","created_at":"2016-11-11T08:56:41Z","updated_at":"2019-02-08T12:42:38Z","pushed_at":"2019-02-08T22:13:26Z","git_url":"git://github.com/ethereum/vyper.git","ssh_url":"git@github.com:ethereum/vyper.git","clone_url":"https://github.com/ethereum/vyper.git","svn_url":"https://github.com/ethereum/vyper","homepage":"","size":3939,"stargazers_count":2223,"watchers_count":2223,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":350,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":350,"open_issues":81,"watchers":2223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/vyper/pulls/1238"},"html":{"href":"https://github.com/ethereum/vyper/pull/1238"},"issue":{"href":"https://api.github.com/repos/ethereum/vyper/issues/1238"},"comments":{"href":"https://api.github.com/repos/ethereum/vyper/issues/1238/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/vyper/pulls/1238/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/vyper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/vyper/pulls/1238/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/vyper/statuses/cddb91373d34aacdc0f4b56046caa639aa07039b"}},"author_association":"NONE"}}
{"actor":{"display_login":"fubuloubu"}}