{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/site/pulls/comments/362942416","pull_request_review_id":338250534,"id":362942416,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mjk0MjQxNg==","diff_hunk":"@@ -10,32 +10,46 @@ import LearnSectionMenu from './LearnSectionMenu';\n \n import * as css from './Learn.m.css';\n \n+interface Guide {\n+\tname: string;\n+\tdirectory?: string;\n+\trepo?: string;\n+\tbranch?: string;\n+}\n+\n interface LearnProperties {\n \tguideName: string;\n \tpageName: string;\n \turl?: string;\n+\trepo?: string;\n+\tbranch?: string;\n }\n \n const factory = create({ theme, i18n }).properties<LearnProperties>();\n \n-export const guides = [\n-\t'Overview',\n-\t'Creating Widgets',\n-\t'Middleware',\n-\t'Building',\n-\t'I18n',\n-\t'Styling',\n-\t'Stores',\n-\t'Routing',\n-\t'Testing'\n+export const sources = {\n+\tframework: {\n+\t\trepo: 'dojo/framework',\n+\t\tbranch: 'v6'\n+\t}\n+};\n+\n+export const guides: Guide[] = [\n+\t{ name: 'Overview' },\n+\t{ name: 'Creating Widgets' },\n+\t{ name: 'Middleware' },\n+\t{ name: 'Building' },\n+\t{ name: 'I18n' },\n+\t{ name: 'Styling' },\n+\t{ name: 'Stores' },\n+\t{ name: 'Routing' },\n+\t{ name: 'Testing' }\n ];\n \n export default factory(function Learn({ properties, middleware: { theme, i18n } }) {\n-\tconst { guideName, pageName, url } = properties();\n+\tconst { guideName, pageName, url, repo = sources.framework.repo, branch = sources.framework.branch } = properties();","path":"src/learn/Learn.tsx","position":52,"original_position":52,"commit_id":"381235bf81dfab841e82bbb24a3b11818d275845","original_commit_id":"381235bf81dfab841e82bbb24a3b11818d275845","user":{"login":"KaneFreeman","id":1388138,"node_id":"MDQ6VXNlcjEzODgxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1388138?v=4","gravatar_id":"","url":"https://api.github.com/users/KaneFreeman","html_url":"https://github.com/KaneFreeman","followers_url":"https://api.github.com/users/KaneFreeman/followers","following_url":"https://api.github.com/users/KaneFreeman/following{/other_user}","gists_url":"https://api.github.com/users/KaneFreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/KaneFreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaneFreeman/subscriptions","organizations_url":"https://api.github.com/users/KaneFreeman/orgs","repos_url":"https://api.github.com/users/KaneFreeman/repos","events_url":"https://api.github.com/users/KaneFreeman/events{/privacy}","received_events_url":"https://api.github.com/users/KaneFreeman/received_events","type":"User","site_admin":false},"body":"Okay I see where it is being used now. Carry on!","created_at":"2020-01-03T20:01:46Z","updated_at":"2020-01-03T20:01:50Z","html_url":"https://github.com/dojo/site/pull/195#discussion_r362942416","pull_request_url":"https://api.github.com/repos/dojo/site/pulls/195","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dojo/site/pulls/comments/362942416"},"html":{"href":"https://github.com/dojo/site/pull/195#discussion_r362942416"},"pull_request":{"href":"https://api.github.com/repos/dojo/site/pulls/195"}},"in_reply_to_id":362850056},"pull_request":{"url":"https://api.github.com/repos/dojo/site/pulls/195","id":358403213,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU4NDAzMjEz","html_url":"https://github.com/dojo/site/pull/195","diff_url":"https://github.com/dojo/site/pull/195.diff","patch_url":"https://github.com/dojo/site/pull/195.patch","issue_url":"https://api.github.com/repos/dojo/site/issues/195","number":195,"state":"open","locked":false,"title":"Allow multi-repository guides","user":{"login":"pottedmeat","id":38750,"node_id":"MDQ6VXNlcjM4NzUw","avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nRefactors `guides` list in `src/learn/Learn.tsx` from `string[]` to `{ name: string }[]`\r\n\r\n- Adds optional `directory` property (Defaults to `name.toLowerCase().replace(' ', '-')`)\r\n- Adds optional `repo` property\r\n- Adds optional `branch` property\r\n\r\nREADME is updated to reflect the new `guides` definition.\r\n\r\n### Code\r\n\r\nThis PR touches:\r\n\r\n- [x] Content\r\n- [x] Content Pipeline\r\n- [ ] Frontend\r\n- [ ] Infrastructure\r\n\r\n### Tests\r\n\r\n- [ ] Tests are included?\r\n\r\nFixes #194 ","created_at":"2019-12-31T18:28:35Z","updated_at":"2020-01-03T20:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a3ae835fb36d39bf8ee835a0cde164abd073e8f","assignee":{"login":"pottedmeat","id":38750,"node_id":"MDQ6VXNlcjM4NzUw","avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"assignees":[{"login":"pottedmeat","id":38750,"node_id":"MDQ6VXNlcjM4NzUw","avatar_url":"https://avatars3.githubusercontent.com/u/38750?v=4","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"agubler","id":1982678,"node_id":"MDQ6VXNlcjE5ODI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1982678?v=4","gravatar_id":"","url":"https://api.github.com/users/agubler","html_url":"https://github.com/agubler","followers_url":"https://api.github.com/users/agubler/followers","following_url":"https://api.github.com/users/agubler/following{/other_user}","gists_url":"https://api.github.com/users/agubler/gists{/gist_id}","starred_url":"https://api.github.com/users/agubler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agubler/subscriptions","organizations_url":"https://api.github.com/users/agubler/orgs","repos_url":"https://api.github.com/users/agubler/repos","events_url":"https://api.github.com/users/agubler/events{/privacy}","received_events_url":"https://api.github.com/users/agubler/received_events","type":"User","site_admin":false},{"login":"matt-gadd","id":2183490,"node_id":"MDQ6VXNlcjIxODM0OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2183490?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-gadd","html_url":"https://github.com/matt-gadd","followers_url":"https://api.github.com/users/matt-gadd/followers","following_url":"https://api.github.com/users/matt-gadd/following{/other_user}","gists_url":"https://api.github.com/users/matt-gadd/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-gadd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-gadd/subscriptions","organizations_url":"https://api.github.com/users/matt-gadd/orgs","repos_url":"https://api.github.com/users/matt-gadd/repos","events_url":"https://api.github.com/users/matt-gadd/events{/privacy}","received_events_url":"https://api.github.com/users/matt-gadd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/site/pulls/195/commits","review_comments_url":"https://api.github.com/repos/dojo/site/pulls/195/comments","review_comment_url":"https://api.github.com/repos/dojo/site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/site/issues/195/comments","statuses_url":"https://api.github.com/repos/dojo/site/statuses/381235bf81dfab841e82bbb24a3b11818d275845","head":{"label":"dojo:multi-repo-guides","ref":"multi-repo-guides","sha":"381235bf81dfab841e82bbb24a3b11818d275845","user":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":156595956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1OTU5NTY=","name":"site","full_name":"dojo/site","private":false,"owner":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dojo/site","description":"Next generation dojo.io site","fork":false,"url":"https://api.github.com/repos/dojo/site","forks_url":"https://api.github.com/repos/dojo/site/forks","keys_url":"https://api.github.com/repos/dojo/site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/site/teams","hooks_url":"https://api.github.com/repos/dojo/site/hooks","issue_events_url":"https://api.github.com/repos/dojo/site/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/site/events","assignees_url":"https://api.github.com/repos/dojo/site/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/site/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/site/tags","blobs_url":"https://api.github.com/repos/dojo/site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/site/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/site/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/site/languages","stargazers_url":"https://api.github.com/repos/dojo/site/stargazers","contributors_url":"https://api.github.com/repos/dojo/site/contributors","subscribers_url":"https://api.github.com/repos/dojo/site/subscribers","subscription_url":"https://api.github.com/repos/dojo/site/subscription","commits_url":"https://api.github.com/repos/dojo/site/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/site/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/site/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/site/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/site/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/site/merges","archive_url":"https://api.github.com/repos/dojo/site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/site/downloads","issues_url":"https://api.github.com/repos/dojo/site/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/site/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/site/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/site/labels{/name}","releases_url":"https://api.github.com/repos/dojo/site/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/site/deployments","created_at":"2018-11-07T19:14:17Z","updated_at":"2020-01-03T17:31:21Z","pushed_at":"2020-01-03T17:31:22Z","git_url":"git://github.com/dojo/site.git","ssh_url":"git@github.com:dojo/site.git","clone_url":"https://github.com/dojo/site.git","svn_url":"https://github.com/dojo/site","homepage":null,"size":7398,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":13,"open_issues":26,"watchers":3,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"52f237d1a347721e02b35945ccc6d2f76121f9bf","user":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":156595956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY1OTU5NTY=","name":"site","full_name":"dojo/site","private":false,"owner":{"login":"dojo","id":86896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODk2","avatar_url":"https://avatars2.githubusercontent.com/u/86896?v=4","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dojo/site","description":"Next generation dojo.io site","fork":false,"url":"https://api.github.com/repos/dojo/site","forks_url":"https://api.github.com/repos/dojo/site/forks","keys_url":"https://api.github.com/repos/dojo/site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/site/teams","hooks_url":"https://api.github.com/repos/dojo/site/hooks","issue_events_url":"https://api.github.com/repos/dojo/site/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/site/events","assignees_url":"https://api.github.com/repos/dojo/site/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/site/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/site/tags","blobs_url":"https://api.github.com/repos/dojo/site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/site/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/site/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/site/languages","stargazers_url":"https://api.github.com/repos/dojo/site/stargazers","contributors_url":"https://api.github.com/repos/dojo/site/contributors","subscribers_url":"https://api.github.com/repos/dojo/site/subscribers","subscription_url":"https://api.github.com/repos/dojo/site/subscription","commits_url":"https://api.github.com/repos/dojo/site/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/site/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/site/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/site/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/site/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/site/merges","archive_url":"https://api.github.com/repos/dojo/site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/site/downloads","issues_url":"https://api.github.com/repos/dojo/site/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/site/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/site/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/site/labels{/name}","releases_url":"https://api.github.com/repos/dojo/site/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/site/deployments","created_at":"2018-11-07T19:14:17Z","updated_at":"2020-01-03T17:31:21Z","pushed_at":"2020-01-03T17:31:22Z","git_url":"git://github.com/dojo/site.git","ssh_url":"git@github.com:dojo/site.git","clone_url":"https://github.com/dojo/site.git","svn_url":"https://github.com/dojo/site","homepage":null,"size":7398,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":13,"open_issues":26,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/site/pulls/195"},"html":{"href":"https://github.com/dojo/site/pull/195"},"issue":{"href":"https://api.github.com/repos/dojo/site/issues/195"},"comments":{"href":"https://api.github.com/repos/dojo/site/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/site/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/site/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/site/statuses/381235bf81dfab841e82bbb24a3b11818d275845"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KaneFreeman"}}