{"action":"created","issue":{"url":"https://api.github.com/repos/tomv564/LSP/issues/33","repository_url":"https://api.github.com/repos/tomv564/LSP","labels_url":"https://api.github.com/repos/tomv564/LSP/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/tomv564/LSP/issues/33/comments","events_url":"https://api.github.com/repos/tomv564/LSP/issues/33/events","html_url":"https://github.com/tomv564/LSP/issues/33","id":251493043,"node_id":"MDU6SXNzdWUyNTE0OTMwNDM=","number":33,"title":"How to handle windows with multiple root folders?","user":{"login":"tomv564","id":4395832,"node_id":"MDQ6VXNlcjQzOTU4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4395832?v=4","gravatar_id":"","url":"https://api.github.com/users/tomv564","html_url":"https://github.com/tomv564","followers_url":"https://api.github.com/users/tomv564/followers","following_url":"https://api.github.com/users/tomv564/following{/other_user}","gists_url":"https://api.github.com/users/tomv564/gists{/gist_id}","starred_url":"https://api.github.com/users/tomv564/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomv564/subscriptions","organizations_url":"https://api.github.com/users/tomv564/orgs","repos_url":"https://api.github.com/users/tomv564/repos","events_url":"https://api.github.com/users/tomv564/events{/privacy}","received_events_url":"https://api.github.com/users/tomv564/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-20T14:45:38Z","updated_at":"2019-04-01T12:27:54Z","closed_at":"2017-10-01T23:53:28Z","author_association":"OWNER","body":"The LSP package currently handles windows with multiple folders by finding a common prefix.\r\n\r\nAs discovered in #24, a common usage with Sublime workspaces is to link in whole trees of projects, perhaps even from multiple drives (e.g. `C:\\Users\\Tom\\Projects` and `D:\\Work\\`)\r\n\r\nFor this scenario, it is increasingly unlikely that we can find a common prefix to give the language server as `rootUri`.\r\n\r\nLooking at the language server protocol, the workspace concept (of which there is only one in a language server process) offers these actions:\r\n\r\n`workspace/symbols` (would you really want to execute this across both drives ?) `workspace/didChangeConfiguration` (configuration is likely to be project-specific, if anything)\r\n\r\nAn improvement would be to create an LSP instance per `window.folders()`.\r\n\r\nUsers who choose to mount the parent folder of multiple projects will have to accept that:\r\n* workspace symbol listing is for projects\r\n* The LSP package will not be able to help with per-project configuration."},"comment":{"url":"https://api.github.com/repos/tomv564/LSP/issues/comments/478558648","html_url":"https://github.com/tomv564/LSP/issues/33#issuecomment-478558648","issue_url":"https://api.github.com/repos/tomv564/LSP/issues/33","id":478558648,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3ODU1ODY0OA==","user":{"login":"tomv564","id":4395832,"node_id":"MDQ6VXNlcjQzOTU4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4395832?v=4","gravatar_id":"","url":"https://api.github.com/users/tomv564","html_url":"https://github.com/tomv564","followers_url":"https://api.github.com/users/tomv564/followers","following_url":"https://api.github.com/users/tomv564/following{/other_user}","gists_url":"https://api.github.com/users/tomv564/gists{/gist_id}","starred_url":"https://api.github.com/users/tomv564/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomv564/subscriptions","organizations_url":"https://api.github.com/users/tomv564/orgs","repos_url":"https://api.github.com/users/tomv564/repos","events_url":"https://api.github.com/users/tomv564/events{/privacy}","received_events_url":"https://api.github.com/users/tomv564/received_events","type":"User","site_admin":false},"created_at":"2019-04-01T12:27:54Z","updated_at":"2019-04-01T12:27:54Z","author_association":"OWNER","body":"Thanks, pointed it to issue #82 instead!"}}
{"actor":{"display_login":"tomv564"}}