{"action":"created","comment":{"url":"https://api.github.com/repos/CSCfi/rems/pulls/comments/319882924","pull_request_review_id":282498410,"id":319882924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxOTg4MjkyNA==","diff_hunk":"@@ -185,8 +185,10 @@\n                    :handler (flash-message/default-success-handler\n                              description\n                              (fn [response]\n-                               (dispatch! (str \"#/administration/forms/\" (or (::form-id db)\n-                                                                             (:id response))))))\n+                               (dispatch! (str \"#/administration/forms/\"\n+                                               (if edit?\n+                                                 (db ::form-id)\n+                                                 (:id %))))))","path":"src/cljs/rems/administration/create_form.cljs","position":null,"original_position":9,"commit_id":"497bef35359566adf462a1043b6dc2693a1c2826","original_commit_id":"3957bc9d72e00a678c6fe9c09294451913dbd2b8","user":{"login":"okahilak","id":49641103,"node_id":"MDQ6VXNlcjQ5NjQxMTAz","avatar_url":"https://avatars3.githubusercontent.com/u/49641103?v=4","gravatar_id":"","url":"https://api.github.com/users/okahilak","html_url":"https://github.com/okahilak","followers_url":"https://api.github.com/users/okahilak/followers","following_url":"https://api.github.com/users/okahilak/following{/other_user}","gists_url":"https://api.github.com/users/okahilak/gists{/gist_id}","starred_url":"https://api.github.com/users/okahilak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okahilak/subscriptions","organizations_url":"https://api.github.com/users/okahilak/orgs","repos_url":"https://api.github.com/users/okahilak/repos","events_url":"https://api.github.com/users/okahilak/events{/privacy}","received_events_url":"https://api.github.com/users/okahilak/received_events","type":"User","site_admin":false},"body":"Thanks!","created_at":"2019-09-02T09:40:16Z","updated_at":"2019-09-02T09:40:17Z","html_url":"https://github.com/CSCfi/rems/pull/1566#discussion_r319882924","pull_request_url":"https://api.github.com/repos/CSCfi/rems/pulls/1566","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CSCfi/rems/pulls/comments/319882924"},"html":{"href":"https://github.com/CSCfi/rems/pull/1566#discussion_r319882924"},"pull_request":{"href":"https://api.github.com/repos/CSCfi/rems/pulls/1566"}},"in_reply_to_id":319881692},"pull_request":{"url":"https://api.github.com/repos/CSCfi/rems/pulls/1566","id":312713367,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyNzEzMzY3","html_url":"https://github.com/CSCfi/rems/pull/1566","diff_url":"https://github.com/CSCfi/rems/pull/1566.diff","patch_url":"https://github.com/CSCfi/rems/pull/1566.patch","issue_url":"https://api.github.com/repos/CSCfi/rems/issues/1566","number":1566,"state":"open","locked":false,"title":"Use flash messages on admin pages","user":{"login":"luontola","id":42678,"node_id":"MDQ6VXNlcjQyNjc4","avatar_url":"https://avatars0.githubusercontent.com/u/42678?v=4","gravatar_id":"","url":"https://api.github.com/users/luontola","html_url":"https://github.com/luontola","followers_url":"https://api.github.com/users/luontola/followers","following_url":"https://api.github.com/users/luontola/following{/other_user}","gists_url":"https://api.github.com/users/luontola/gists{/gist_id}","starred_url":"https://api.github.com/users/luontola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luontola/subscriptions","organizations_url":"https://api.github.com/users/luontola/orgs","repos_url":"https://api.github.com/users/luontola/repos","events_url":"https://api.github.com/users/luontola/events{/privacy}","received_events_url":"https://api.github.com/users/luontola/received_events","type":"User","site_admin":false},"body":"Closes #1469\r\n\r\n- [x] catalogue items\r\n- [x] resources\r\n- [x] forms\r\n- [x] workflows\r\n- [x] licenses\r\n\r\n\r\n# Definition of Done / Review checklist\r\n\r\n## Reviewability\r\n- [x] link to issue\r\n\r\n## Documentation\r\n- [x] update changelog if necessary\r\n- [ ] add or update docstrings for namespaces and functions\r\n- [ ] components are added to guide page\r\n\r\n## Testing\r\n- [ ] complex logic is unit tested\r\n- [ ] valuable features are integration / browser / acceptance tested automatically\r\n\r\n## Accessibility\r\n- [x] all icons have the aria-label attribute\r\n- [x] all fields have a label\r\n- [x] errors are linked to fields with aria-describedby\r\n- [x] contrast is checked\r\n- [x] conscious decision about where to move focus after an action\r\n\r\n## Follow-up\r\n- [x] new tasks are created for pending or remaining tasks\r\n- [x] no critical TODOs left to implement\r\n","created_at":"2019-08-30T12:14:21Z","updated_at":"2019-09-02T09:40:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62c6a32f8bd5257e5d6caace962dc6764c04bdd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CSCfi/rems/pulls/1566/commits","review_comments_url":"https://api.github.com/repos/CSCfi/rems/pulls/1566/comments","review_comment_url":"https://api.github.com/repos/CSCfi/rems/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CSCfi/rems/issues/1566/comments","statuses_url":"https://api.github.com/repos/CSCfi/rems/statuses/497bef35359566adf462a1043b6dc2693a1c2826","head":{"label":"CSCfi:no-admin-popups","ref":"no-admin-popups","sha":"497bef35359566adf462a1043b6dc2693a1c2826","user":{"login":"CSCfi","id":5947494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NDc0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5947494?v=4","gravatar_id":"","url":"https://api.github.com/users/CSCfi","html_url":"https://github.com/CSCfi","followers_url":"https://api.github.com/users/CSCfi/followers","following_url":"https://api.github.com/users/CSCfi/following{/other_user}","gists_url":"https://api.github.com/users/CSCfi/gists{/gist_id}","starred_url":"https://api.github.com/users/CSCfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CSCfi/subscriptions","organizations_url":"https://api.github.com/users/CSCfi/orgs","repos_url":"https://api.github.com/users/CSCfi/repos","events_url":"https://api.github.com/users/CSCfi/events{/privacy}","received_events_url":"https://api.github.com/users/CSCfi/received_events","type":"Organization","site_admin":false},"repo":{"id":73476171,"node_id":"MDEwOlJlcG9zaXRvcnk3MzQ3NjE3MQ==","name":"rems","full_name":"CSCfi/rems","private":false,"owner":{"login":"CSCfi","id":5947494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NDc0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5947494?v=4","gravatar_id":"","url":"https://api.github.com/users/CSCfi","html_url":"https://github.com/CSCfi","followers_url":"https://api.github.com/users/CSCfi/followers","following_url":"https://api.github.com/users/CSCfi/following{/other_user}","gists_url":"https://api.github.com/users/CSCfi/gists{/gist_id}","starred_url":"https://api.github.com/users/CSCfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CSCfi/subscriptions","organizations_url":"https://api.github.com/users/CSCfi/orgs","repos_url":"https://api.github.com/users/CSCfi/repos","events_url":"https://api.github.com/users/CSCfi/events{/privacy}","received_events_url":"https://api.github.com/users/CSCfi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CSCfi/rems","description":"Resource Entitlement Management System is a tool for managing access rights to resources, such as research datasets.","fork":false,"url":"https://api.github.com/repos/CSCfi/rems","forks_url":"https://api.github.com/repos/CSCfi/rems/forks","keys_url":"https://api.github.com/repos/CSCfi/rems/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CSCfi/rems/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CSCfi/rems/teams","hooks_url":"https://api.github.com/repos/CSCfi/rems/hooks","issue_events_url":"https://api.github.com/repos/CSCfi/rems/issues/events{/number}","events_url":"https://api.github.com/repos/CSCfi/rems/events","assignees_url":"https://api.github.com/repos/CSCfi/rems/assignees{/user}","branches_url":"https://api.github.com/repos/CSCfi/rems/branches{/branch}","tags_url":"https://api.github.com/repos/CSCfi/rems/tags","blobs_url":"https://api.github.com/repos/CSCfi/rems/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CSCfi/rems/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CSCfi/rems/git/refs{/sha}","trees_url":"https://api.github.com/repos/CSCfi/rems/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CSCfi/rems/statuses/{sha}","languages_url":"https://api.github.com/repos/CSCfi/rems/languages","stargazers_url":"https://api.github.com/repos/CSCfi/rems/stargazers","contributors_url":"https://api.github.com/repos/CSCfi/rems/contributors","subscribers_url":"https://api.github.com/repos/CSCfi/rems/subscribers","subscription_url":"https://api.github.com/repos/CSCfi/rems/subscription","commits_url":"https://api.github.com/repos/CSCfi/rems/commits{/sha}","git_commits_url":"https://api.github.com/repos/CSCfi/rems/git/commits{/sha}","comments_url":"https://api.github.com/repos/CSCfi/rems/comments{/number}","issue_comment_url":"https://api.github.com/repos/CSCfi/rems/issues/comments{/number}","contents_url":"https://api.github.com/repos/CSCfi/rems/contents/{+path}","compare_url":"https://api.github.com/repos/CSCfi/rems/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CSCfi/rems/merges","archive_url":"https://api.github.com/repos/CSCfi/rems/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CSCfi/rems/downloads","issues_url":"https://api.github.com/repos/CSCfi/rems/issues{/number}","pulls_url":"https://api.github.com/repos/CSCfi/rems/pulls{/number}","milestones_url":"https://api.github.com/repos/CSCfi/rems/milestones{/number}","notifications_url":"https://api.github.com/repos/CSCfi/rems/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CSCfi/rems/labels{/name}","releases_url":"https://api.github.com/repos/CSCfi/rems/releases{/id}","deployments_url":"https://api.github.com/repos/CSCfi/rems/deployments","created_at":"2016-11-11T12:31:56Z","updated_at":"2019-09-02T07:07:50Z","pushed_at":"2019-09-02T09:38:07Z","git_url":"git://github.com/CSCfi/rems.git","ssh_url":"git@github.com:CSCfi/rems.git","clone_url":"https://github.com/CSCfi/rems.git","svn_url":"https://github.com/CSCfi/rems","homepage":"","size":13616,"stargazers_count":6,"watchers_count":6,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":83,"watchers":6,"default_branch":"master"}},"base":{"label":"CSCfi:master","ref":"master","sha":"37ae10c30cc261d7cef10db1a95b3e8262f4b4cf","user":{"login":"CSCfi","id":5947494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NDc0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5947494?v=4","gravatar_id":"","url":"https://api.github.com/users/CSCfi","html_url":"https://github.com/CSCfi","followers_url":"https://api.github.com/users/CSCfi/followers","following_url":"https://api.github.com/users/CSCfi/following{/other_user}","gists_url":"https://api.github.com/users/CSCfi/gists{/gist_id}","starred_url":"https://api.github.com/users/CSCfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CSCfi/subscriptions","organizations_url":"https://api.github.com/users/CSCfi/orgs","repos_url":"https://api.github.com/users/CSCfi/repos","events_url":"https://api.github.com/users/CSCfi/events{/privacy}","received_events_url":"https://api.github.com/users/CSCfi/received_events","type":"Organization","site_admin":false},"repo":{"id":73476171,"node_id":"MDEwOlJlcG9zaXRvcnk3MzQ3NjE3MQ==","name":"rems","full_name":"CSCfi/rems","private":false,"owner":{"login":"CSCfi","id":5947494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NDc0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5947494?v=4","gravatar_id":"","url":"https://api.github.com/users/CSCfi","html_url":"https://github.com/CSCfi","followers_url":"https://api.github.com/users/CSCfi/followers","following_url":"https://api.github.com/users/CSCfi/following{/other_user}","gists_url":"https://api.github.com/users/CSCfi/gists{/gist_id}","starred_url":"https://api.github.com/users/CSCfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CSCfi/subscriptions","organizations_url":"https://api.github.com/users/CSCfi/orgs","repos_url":"https://api.github.com/users/CSCfi/repos","events_url":"https://api.github.com/users/CSCfi/events{/privacy}","received_events_url":"https://api.github.com/users/CSCfi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CSCfi/rems","description":"Resource Entitlement Management System is a tool for managing access rights to resources, such as research datasets.","fork":false,"url":"https://api.github.com/repos/CSCfi/rems","forks_url":"https://api.github.com/repos/CSCfi/rems/forks","keys_url":"https://api.github.com/repos/CSCfi/rems/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CSCfi/rems/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CSCfi/rems/teams","hooks_url":"https://api.github.com/repos/CSCfi/rems/hooks","issue_events_url":"https://api.github.com/repos/CSCfi/rems/issues/events{/number}","events_url":"https://api.github.com/repos/CSCfi/rems/events","assignees_url":"https://api.github.com/repos/CSCfi/rems/assignees{/user}","branches_url":"https://api.github.com/repos/CSCfi/rems/branches{/branch}","tags_url":"https://api.github.com/repos/CSCfi/rems/tags","blobs_url":"https://api.github.com/repos/CSCfi/rems/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CSCfi/rems/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CSCfi/rems/git/refs{/sha}","trees_url":"https://api.github.com/repos/CSCfi/rems/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CSCfi/rems/statuses/{sha}","languages_url":"https://api.github.com/repos/CSCfi/rems/languages","stargazers_url":"https://api.github.com/repos/CSCfi/rems/stargazers","contributors_url":"https://api.github.com/repos/CSCfi/rems/contributors","subscribers_url":"https://api.github.com/repos/CSCfi/rems/subscribers","subscription_url":"https://api.github.com/repos/CSCfi/rems/subscription","commits_url":"https://api.github.com/repos/CSCfi/rems/commits{/sha}","git_commits_url":"https://api.github.com/repos/CSCfi/rems/git/commits{/sha}","comments_url":"https://api.github.com/repos/CSCfi/rems/comments{/number}","issue_comment_url":"https://api.github.com/repos/CSCfi/rems/issues/comments{/number}","contents_url":"https://api.github.com/repos/CSCfi/rems/contents/{+path}","compare_url":"https://api.github.com/repos/CSCfi/rems/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CSCfi/rems/merges","archive_url":"https://api.github.com/repos/CSCfi/rems/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CSCfi/rems/downloads","issues_url":"https://api.github.com/repos/CSCfi/rems/issues{/number}","pulls_url":"https://api.github.com/repos/CSCfi/rems/pulls{/number}","milestones_url":"https://api.github.com/repos/CSCfi/rems/milestones{/number}","notifications_url":"https://api.github.com/repos/CSCfi/rems/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CSCfi/rems/labels{/name}","releases_url":"https://api.github.com/repos/CSCfi/rems/releases{/id}","deployments_url":"https://api.github.com/repos/CSCfi/rems/deployments","created_at":"2016-11-11T12:31:56Z","updated_at":"2019-09-02T07:07:50Z","pushed_at":"2019-09-02T09:38:07Z","git_url":"git://github.com/CSCfi/rems.git","ssh_url":"git@github.com:CSCfi/rems.git","clone_url":"https://github.com/CSCfi/rems.git","svn_url":"https://github.com/CSCfi/rems","homepage":"","size":13616,"stargazers_count":6,"watchers_count":6,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":83,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CSCfi/rems/pulls/1566"},"html":{"href":"https://github.com/CSCfi/rems/pull/1566"},"issue":{"href":"https://api.github.com/repos/CSCfi/rems/issues/1566"},"comments":{"href":"https://api.github.com/repos/CSCfi/rems/issues/1566/comments"},"review_comments":{"href":"https://api.github.com/repos/CSCfi/rems/pulls/1566/comments"},"review_comment":{"href":"https://api.github.com/repos/CSCfi/rems/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CSCfi/rems/pulls/1566/commits"},"statuses":{"href":"https://api.github.com/repos/CSCfi/rems/statuses/497bef35359566adf462a1043b6dc2693a1c2826"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"okahilak"}}