{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/pykeybasebot/pulls/comments/343424709","pull_request_review_id":313072961,"id":343424709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzQyNDcwOQ==","diff_hunk":"@@ -0,0 +1,157 @@\n+#!/usr/bin/env python3\n+\n+###################################\n+# WHAT IS IN THIS EXAMPLE?\n+#\n+# Keybase has added an encrypted key-value store intended to support\n+# security-conscious bot development with persistent state. It is a place to\n+# store small bits of data that are\n+#   (1) encrypted for a team or user (via the user's implicit self-team: e.g.\n+# alice,alice),\n+#   (2) persistent across logins\n+#   (3) fast and durable.\n+#\n+# It supports putting, getting, listing and deleting. There is also concurrency\n+# support, but check out 4_secret_storage.py for that. A team has many\n+# namespaces, a namespace has many entryKeys, and an entryKey has one current\n+# entryValue. Namespaces and entryKeys are in cleartext, and the Keybase client\n+# service will encrypt and sign the entryValue on the way in (as well as\n+# decrypt and verify on the way out) so keybase servers cannot see it or lie\n+# about it.","path":"examples/4_simple_storage.py","position":20,"original_position":20,"commit_id":"3d63ed23719f403e3cb2402124723262b69e165e","original_commit_id":"3d63ed23719f403e3cb2402124723262b69e165e","user":{"login":"mmou","id":1981254,"node_id":"MDQ6VXNlcjE5ODEyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1981254?v=4","gravatar_id":"","url":"https://api.github.com/users/mmou","html_url":"https://github.com/mmou","followers_url":"https://api.github.com/users/mmou/followers","following_url":"https://api.github.com/users/mmou/following{/other_user}","gists_url":"https://api.github.com/users/mmou/gists{/gist_id}","starred_url":"https://api.github.com/users/mmou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmou/subscriptions","organizations_url":"https://api.github.com/users/mmou/orgs","repos_url":"https://api.github.com/users/mmou/repos","events_url":"https://api.github.com/users/mmou/events{/privacy}","received_events_url":"https://api.github.com/users/mmou/received_events","type":"User","site_admin":false},"body":"i'll change \"lie\" to \"forge\" - does that address this issue?\r\nis there a docs page yet that i can link to?\r\nbtw, since this part was somewhat copied from the design doc -- what does \"durable\" in \"fast and durable\" mean here?","created_at":"2019-11-07T02:06:23Z","updated_at":"2019-11-07T02:06:24Z","html_url":"https://github.com/keybase/pykeybasebot/pull/28#discussion_r343424709","pull_request_url":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/keybase/pykeybasebot/pulls/comments/343424709"},"html":{"href":"https://github.com/keybase/pykeybasebot/pull/28#discussion_r343424709"},"pull_request":{"href":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28"}},"in_reply_to_id":342311577},"pull_request":{"url":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28","id":332895003,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyODk1MDAz","html_url":"https://github.com/keybase/pykeybasebot/pull/28","diff_url":"https://github.com/keybase/pykeybasebot/pull/28.diff","patch_url":"https://github.com/keybase/pykeybasebot/pull/28.patch","issue_url":"https://api.github.com/repos/keybase/pykeybasebot/issues/28","number":28,"state":"open","locked":false,"title":"add KVStoreClient, examples","user":{"login":"mmou","id":1981254,"node_id":"MDQ6VXNlcjE5ODEyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1981254?v=4","gravatar_id":"","url":"https://api.github.com/users/mmou","html_url":"https://github.com/mmou","followers_url":"https://api.github.com/users/mmou/followers","following_url":"https://api.github.com/users/mmou/following{/other_user}","gists_url":"https://api.github.com/users/mmou/gists{/gist_id}","starred_url":"https://api.github.com/users/mmou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmou/subscriptions","organizations_url":"https://api.github.com/users/mmou/orgs","repos_url":"https://api.github.com/users/mmou/repos","events_url":"https://api.github.com/users/mmou/events{/privacy}","received_events_url":"https://api.github.com/users/mmou/received_events","type":"User","site_admin":false},"body":"can't release until keybase/client is released with kv store feature\r\n\r\n@AMarcedone take a look at 4_secret_storage.py; i implemented the solution we discussed","created_at":"2019-10-27T21:24:07Z","updated_at":"2019-11-07T02:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eeae3fa583f0426938fcc58ee7ed1193694e10b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28/commits","review_comments_url":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28/comments","review_comment_url":"https://api.github.com/repos/keybase/pykeybasebot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/pykeybasebot/issues/28/comments","statuses_url":"https://api.github.com/repos/keybase/pykeybasebot/statuses/3d63ed23719f403e3cb2402124723262b69e165e","head":{"label":"keybase:mmou-kvstore","ref":"mmou-kvstore","sha":"3d63ed23719f403e3cb2402124723262b69e165e","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":189479264,"node_id":"MDEwOlJlcG9zaXRvcnkxODk0NzkyNjQ=","name":"pykeybasebot","full_name":"keybase/pykeybasebot","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/pykeybasebot","description":"Python Keybase Bot Library","fork":false,"url":"https://api.github.com/repos/keybase/pykeybasebot","forks_url":"https://api.github.com/repos/keybase/pykeybasebot/forks","keys_url":"https://api.github.com/repos/keybase/pykeybasebot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/pykeybasebot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/pykeybasebot/teams","hooks_url":"https://api.github.com/repos/keybase/pykeybasebot/hooks","issue_events_url":"https://api.github.com/repos/keybase/pykeybasebot/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/pykeybasebot/events","assignees_url":"https://api.github.com/repos/keybase/pykeybasebot/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/pykeybasebot/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/pykeybasebot/tags","blobs_url":"https://api.github.com/repos/keybase/pykeybasebot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/pykeybasebot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/pykeybasebot/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/pykeybasebot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/pykeybasebot/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/pykeybasebot/languages","stargazers_url":"https://api.github.com/repos/keybase/pykeybasebot/stargazers","contributors_url":"https://api.github.com/repos/keybase/pykeybasebot/contributors","subscribers_url":"https://api.github.com/repos/keybase/pykeybasebot/subscribers","subscription_url":"https://api.github.com/repos/keybase/pykeybasebot/subscription","commits_url":"https://api.github.com/repos/keybase/pykeybasebot/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/pykeybasebot/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/pykeybasebot/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/pykeybasebot/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/pykeybasebot/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/pykeybasebot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/pykeybasebot/merges","archive_url":"https://api.github.com/repos/keybase/pykeybasebot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/pykeybasebot/downloads","issues_url":"https://api.github.com/repos/keybase/pykeybasebot/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/pykeybasebot/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/pykeybasebot/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/pykeybasebot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/pykeybasebot/labels{/name}","releases_url":"https://api.github.com/repos/keybase/pykeybasebot/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/pykeybasebot/deployments","created_at":"2019-05-30T20:37:52Z","updated_at":"2019-11-04T19:23:37Z","pushed_at":"2019-11-04T18:04:04Z","git_url":"git://github.com/keybase/pykeybasebot.git","ssh_url":"git@github.com:keybase/pykeybasebot.git","clone_url":"https://github.com/keybase/pykeybasebot.git","svn_url":"https://github.com/keybase/pykeybasebot","homepage":null,"size":394,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":7,"watchers":31,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"c7e12b7d6150d08caa4ce2d573e5c92c7e7295d8","user":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":189479264,"node_id":"MDEwOlJlcG9zaXRvcnkxODk0NzkyNjQ=","name":"pykeybasebot","full_name":"keybase/pykeybasebot","private":false,"owner":{"login":"keybase","id":5400834,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDA4MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keybase/pykeybasebot","description":"Python Keybase Bot Library","fork":false,"url":"https://api.github.com/repos/keybase/pykeybasebot","forks_url":"https://api.github.com/repos/keybase/pykeybasebot/forks","keys_url":"https://api.github.com/repos/keybase/pykeybasebot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/pykeybasebot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/pykeybasebot/teams","hooks_url":"https://api.github.com/repos/keybase/pykeybasebot/hooks","issue_events_url":"https://api.github.com/repos/keybase/pykeybasebot/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/pykeybasebot/events","assignees_url":"https://api.github.com/repos/keybase/pykeybasebot/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/pykeybasebot/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/pykeybasebot/tags","blobs_url":"https://api.github.com/repos/keybase/pykeybasebot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/pykeybasebot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/pykeybasebot/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/pykeybasebot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/pykeybasebot/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/pykeybasebot/languages","stargazers_url":"https://api.github.com/repos/keybase/pykeybasebot/stargazers","contributors_url":"https://api.github.com/repos/keybase/pykeybasebot/contributors","subscribers_url":"https://api.github.com/repos/keybase/pykeybasebot/subscribers","subscription_url":"https://api.github.com/repos/keybase/pykeybasebot/subscription","commits_url":"https://api.github.com/repos/keybase/pykeybasebot/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/pykeybasebot/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/pykeybasebot/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/pykeybasebot/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/pykeybasebot/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/pykeybasebot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/pykeybasebot/merges","archive_url":"https://api.github.com/repos/keybase/pykeybasebot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/pykeybasebot/downloads","issues_url":"https://api.github.com/repos/keybase/pykeybasebot/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/pykeybasebot/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/pykeybasebot/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/pykeybasebot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/pykeybasebot/labels{/name}","releases_url":"https://api.github.com/repos/keybase/pykeybasebot/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/pykeybasebot/deployments","created_at":"2019-05-30T20:37:52Z","updated_at":"2019-11-04T19:23:37Z","pushed_at":"2019-11-04T18:04:04Z","git_url":"git://github.com/keybase/pykeybasebot.git","ssh_url":"git@github.com:keybase/pykeybasebot.git","clone_url":"https://github.com/keybase/pykeybasebot.git","svn_url":"https://github.com/keybase/pykeybasebot","homepage":null,"size":394,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":7,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28"},"html":{"href":"https://github.com/keybase/pykeybasebot/pull/28"},"issue":{"href":"https://api.github.com/repos/keybase/pykeybasebot/issues/28"},"comments":{"href":"https://api.github.com/repos/keybase/pykeybasebot/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/pykeybasebot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/pykeybasebot/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/pykeybasebot/statuses/3d63ed23719f403e3cb2402124723262b69e165e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mmou"}}