{"action":"closed","number":182,"pull_request":{"url":"https://api.github.com/repos/lisong/code-push-server/pulls/182","id":259953402,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5OTUzNDAy","html_url":"https://github.com/lisong/code-push-server/pull/182","diff_url":"https://github.com/lisong/code-push-server/pull/182.diff","patch_url":"https://github.com/lisong/code-push-server/pull/182.patch","issue_url":"https://api.github.com/repos/lisong/code-push-server/issues/182","number":182,"state":"closed","locked":false,"title":"fix package hash issue","user":{"login":"rocwind","id":1072850,"node_id":"MDQ6VXNlcjEwNzI4NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1072850?v=4","gravatar_id":"","url":"https://api.github.com/users/rocwind","html_url":"https://github.com/rocwind","followers_url":"https://api.github.com/users/rocwind/followers","following_url":"https://api.github.com/users/rocwind/following{/other_user}","gists_url":"https://api.github.com/users/rocwind/gists{/gist_id}","starred_url":"https://api.github.com/users/rocwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocwind/subscriptions","organizations_url":"https://api.github.com/users/rocwind/orgs","repos_url":"https://api.github.com/users/rocwind/repos","events_url":"https://api.github.com/users/rocwind/events{/privacy}","received_events_url":"https://api.github.com/users/rocwind/received_events","type":"User","site_admin":false},"body":"Code Push client compares the package folder hash when the code signing is enabled, however the client side SDK (react-native-code-push and cordova-plugin-code-push) ignores some files during hash calculation, we need to skip the same file set on server side to get the hash match client side hash to pass data integrity check.\r\n\r\nThis PR is trying to solve the same issue that #176 was opened for, but with a more strict logic following the code-push client SDK's:\r\n\r\n- react-native:\r\nhttps://github.com/Microsoft/react-native-code-push/blob/3144c916018fab077231e88d8718ad3a1cb0a7d8/ios/CodePush/CodePushUpdateUtils.m#L15-L26\r\n\r\n- cordova: \r\nhttps://github.com/Microsoft/cordova-plugin-code-push/blob/9e52ee55986bd17acd52c27821cf44ecb033d504/src/android/UpdateHashUtils.java#L27-L30\r\n","created_at":"2019-03-11T12:48:01Z","updated_at":"2019-03-15T08:05:12Z","closed_at":"2019-03-15T08:05:12Z","merged_at":"2019-03-15T08:05:12Z","merge_commit_sha":"6e6dcd5dba23ba3d1a45d52e68fb538c17a045a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lisong/code-push-server/pulls/182/commits","review_comments_url":"https://api.github.com/repos/lisong/code-push-server/pulls/182/comments","review_comment_url":"https://api.github.com/repos/lisong/code-push-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lisong/code-push-server/issues/182/comments","statuses_url":"https://api.github.com/repos/lisong/code-push-server/statuses/1c47e4c77aaaf65b1cc4b0239b7c3a17b9a404d9","head":{"label":"rocwind:fix/hash-calc","ref":"fix/hash-calc","sha":"1c47e4c77aaaf65b1cc4b0239b7c3a17b9a404d9","user":{"login":"rocwind","id":1072850,"node_id":"MDQ6VXNlcjEwNzI4NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1072850?v=4","gravatar_id":"","url":"https://api.github.com/users/rocwind","html_url":"https://github.com/rocwind","followers_url":"https://api.github.com/users/rocwind/followers","following_url":"https://api.github.com/users/rocwind/following{/other_user}","gists_url":"https://api.github.com/users/rocwind/gists{/gist_id}","starred_url":"https://api.github.com/users/rocwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocwind/subscriptions","organizations_url":"https://api.github.com/users/rocwind/orgs","repos_url":"https://api.github.com/users/rocwind/repos","events_url":"https://api.github.com/users/rocwind/events{/privacy}","received_events_url":"https://api.github.com/users/rocwind/received_events","type":"User","site_admin":false},"repo":{"id":174671338,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ2NzEzMzg=","name":"code-push-server","full_name":"rocwind/code-push-server","private":false,"owner":{"login":"rocwind","id":1072850,"node_id":"MDQ6VXNlcjEwNzI4NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1072850?v=4","gravatar_id":"","url":"https://api.github.com/users/rocwind","html_url":"https://github.com/rocwind","followers_url":"https://api.github.com/users/rocwind/followers","following_url":"https://api.github.com/users/rocwind/following{/other_user}","gists_url":"https://api.github.com/users/rocwind/gists{/gist_id}","starred_url":"https://api.github.com/users/rocwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocwind/subscriptions","organizations_url":"https://api.github.com/users/rocwind/orgs","repos_url":"https://api.github.com/users/rocwind/repos","events_url":"https://api.github.com/users/rocwind/events{/privacy}","received_events_url":"https://api.github.com/users/rocwind/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rocwind/code-push-server","description":"CodePush service is hot update services which adapter react-native-code-push and cordova-plugin-code-push - 热更新","fork":true,"url":"https://api.github.com/repos/rocwind/code-push-server","forks_url":"https://api.github.com/repos/rocwind/code-push-server/forks","keys_url":"https://api.github.com/repos/rocwind/code-push-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rocwind/code-push-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rocwind/code-push-server/teams","hooks_url":"https://api.github.com/repos/rocwind/code-push-server/hooks","issue_events_url":"https://api.github.com/repos/rocwind/code-push-server/issues/events{/number}","events_url":"https://api.github.com/repos/rocwind/code-push-server/events","assignees_url":"https://api.github.com/repos/rocwind/code-push-server/assignees{/user}","branches_url":"https://api.github.com/repos/rocwind/code-push-server/branches{/branch}","tags_url":"https://api.github.com/repos/rocwind/code-push-server/tags","blobs_url":"https://api.github.com/repos/rocwind/code-push-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rocwind/code-push-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rocwind/code-push-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/rocwind/code-push-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rocwind/code-push-server/statuses/{sha}","languages_url":"https://api.github.com/repos/rocwind/code-push-server/languages","stargazers_url":"https://api.github.com/repos/rocwind/code-push-server/stargazers","contributors_url":"https://api.github.com/repos/rocwind/code-push-server/contributors","subscribers_url":"https://api.github.com/repos/rocwind/code-push-server/subscribers","subscription_url":"https://api.github.com/repos/rocwind/code-push-server/subscription","commits_url":"https://api.github.com/repos/rocwind/code-push-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/rocwind/code-push-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/rocwind/code-push-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/rocwind/code-push-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/rocwind/code-push-server/contents/{+path}","compare_url":"https://api.github.com/repos/rocwind/code-push-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rocwind/code-push-server/merges","archive_url":"https://api.github.com/repos/rocwind/code-push-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rocwind/code-push-server/downloads","issues_url":"https://api.github.com/repos/rocwind/code-push-server/issues{/number}","pulls_url":"https://api.github.com/repos/rocwind/code-push-server/pulls{/number}","milestones_url":"https://api.github.com/repos/rocwind/code-push-server/milestones{/number}","notifications_url":"https://api.github.com/repos/rocwind/code-push-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rocwind/code-push-server/labels{/name}","releases_url":"https://api.github.com/repos/rocwind/code-push-server/releases{/id}","deployments_url":"https://api.github.com/repos/rocwind/code-push-server/deployments","created_at":"2019-03-09T09:02:51Z","updated_at":"2019-03-09T09:02:53Z","pushed_at":"2019-03-11T12:32:52Z","git_url":"git://github.com/rocwind/code-push-server.git","ssh_url":"git@github.com:rocwind/code-push-server.git","clone_url":"https://github.com/rocwind/code-push-server.git","svn_url":"https://github.com/rocwind/code-push-server","homepage":"","size":1173,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lisong:master","ref":"master","sha":"2e90e36f94b1303492d011e4975f76bb617f1116","user":{"login":"lisong","id":1171518,"node_id":"MDQ6VXNlcjExNzE1MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1171518?v=4","gravatar_id":"","url":"https://api.github.com/users/lisong","html_url":"https://github.com/lisong","followers_url":"https://api.github.com/users/lisong/followers","following_url":"https://api.github.com/users/lisong/following{/other_user}","gists_url":"https://api.github.com/users/lisong/gists{/gist_id}","starred_url":"https://api.github.com/users/lisong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisong/subscriptions","organizations_url":"https://api.github.com/users/lisong/orgs","repos_url":"https://api.github.com/users/lisong/repos","events_url":"https://api.github.com/users/lisong/events{/privacy}","received_events_url":"https://api.github.com/users/lisong/received_events","type":"User","site_admin":false},"repo":{"id":54013034,"node_id":"MDEwOlJlcG9zaXRvcnk1NDAxMzAzNA==","name":"code-push-server","full_name":"lisong/code-push-server","private":false,"owner":{"login":"lisong","id":1171518,"node_id":"MDQ6VXNlcjExNzE1MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1171518?v=4","gravatar_id":"","url":"https://api.github.com/users/lisong","html_url":"https://github.com/lisong","followers_url":"https://api.github.com/users/lisong/followers","following_url":"https://api.github.com/users/lisong/following{/other_user}","gists_url":"https://api.github.com/users/lisong/gists{/gist_id}","starred_url":"https://api.github.com/users/lisong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisong/subscriptions","organizations_url":"https://api.github.com/users/lisong/orgs","repos_url":"https://api.github.com/users/lisong/repos","events_url":"https://api.github.com/users/lisong/events{/privacy}","received_events_url":"https://api.github.com/users/lisong/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lisong/code-push-server","description":"CodePush service is hot update services which adapter react-native-code-push and cordova-plugin-code-push - 热更新","fork":false,"url":"https://api.github.com/repos/lisong/code-push-server","forks_url":"https://api.github.com/repos/lisong/code-push-server/forks","keys_url":"https://api.github.com/repos/lisong/code-push-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lisong/code-push-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lisong/code-push-server/teams","hooks_url":"https://api.github.com/repos/lisong/code-push-server/hooks","issue_events_url":"https://api.github.com/repos/lisong/code-push-server/issues/events{/number}","events_url":"https://api.github.com/repos/lisong/code-push-server/events","assignees_url":"https://api.github.com/repos/lisong/code-push-server/assignees{/user}","branches_url":"https://api.github.com/repos/lisong/code-push-server/branches{/branch}","tags_url":"https://api.github.com/repos/lisong/code-push-server/tags","blobs_url":"https://api.github.com/repos/lisong/code-push-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lisong/code-push-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lisong/code-push-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/lisong/code-push-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lisong/code-push-server/statuses/{sha}","languages_url":"https://api.github.com/repos/lisong/code-push-server/languages","stargazers_url":"https://api.github.com/repos/lisong/code-push-server/stargazers","contributors_url":"https://api.github.com/repos/lisong/code-push-server/contributors","subscribers_url":"https://api.github.com/repos/lisong/code-push-server/subscribers","subscription_url":"https://api.github.com/repos/lisong/code-push-server/subscription","commits_url":"https://api.github.com/repos/lisong/code-push-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/lisong/code-push-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/lisong/code-push-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/lisong/code-push-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/lisong/code-push-server/contents/{+path}","compare_url":"https://api.github.com/repos/lisong/code-push-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lisong/code-push-server/merges","archive_url":"https://api.github.com/repos/lisong/code-push-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lisong/code-push-server/downloads","issues_url":"https://api.github.com/repos/lisong/code-push-server/issues{/number}","pulls_url":"https://api.github.com/repos/lisong/code-push-server/pulls{/number}","milestones_url":"https://api.github.com/repos/lisong/code-push-server/milestones{/number}","notifications_url":"https://api.github.com/repos/lisong/code-push-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lisong/code-push-server/labels{/name}","releases_url":"https://api.github.com/repos/lisong/code-push-server/releases{/id}","deployments_url":"https://api.github.com/repos/lisong/code-push-server/deployments","created_at":"2016-03-16T08:16:34Z","updated_at":"2019-03-15T06:56:13Z","pushed_at":"2019-03-15T08:05:12Z","git_url":"git://github.com/lisong/code-push-server.git","ssh_url":"git@github.com:lisong/code-push-server.git","clone_url":"https://github.com/lisong/code-push-server.git","svn_url":"https://github.com/lisong/code-push-server","homepage":"","size":1184,"stargazers_count":988,"watchers_count":988,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":251,"open_issues":12,"watchers":988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lisong/code-push-server/pulls/182"},"html":{"href":"https://github.com/lisong/code-push-server/pull/182"},"issue":{"href":"https://api.github.com/repos/lisong/code-push-server/issues/182"},"comments":{"href":"https://api.github.com/repos/lisong/code-push-server/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/lisong/code-push-server/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/lisong/code-push-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lisong/code-push-server/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/lisong/code-push-server/statuses/1c47e4c77aaaf65b1cc4b0239b7c3a17b9a404d9"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lisong","id":1171518,"node_id":"MDQ6VXNlcjExNzE1MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1171518?v=4","gravatar_id":"","url":"https://api.github.com/users/lisong","html_url":"https://github.com/lisong","followers_url":"https://api.github.com/users/lisong/followers","following_url":"https://api.github.com/users/lisong/following{/other_user}","gists_url":"https://api.github.com/users/lisong/gists{/gist_id}","starred_url":"https://api.github.com/users/lisong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisong/subscriptions","organizations_url":"https://api.github.com/users/lisong/orgs","repos_url":"https://api.github.com/users/lisong/repos","events_url":"https://api.github.com/users/lisong/events{/privacy}","received_events_url":"https://api.github.com/users/lisong/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"lisong"}}