{"action":"closed","number":18169,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/18169","id":256134097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MTM0MDk3","html_url":"https://github.com/grpc/grpc/pull/18169","diff_url":"https://github.com/grpc/grpc/pull/18169.diff","patch_url":"https://github.com/grpc/grpc/pull/18169.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/18169","number":18169,"state":"closed","locked":false,"title":"Datetimeoffset deadline","user":{"login":"dhhoang","id":11325809,"node_id":"MDQ6VXNlcjExMzI1ODA5","avatar_url":"https://avatars0.githubusercontent.com/u/11325809?v=4","gravatar_id":"","url":"https://api.github.com/users/dhhoang","html_url":"https://github.com/dhhoang","followers_url":"https://api.github.com/users/dhhoang/followers","following_url":"https://api.github.com/users/dhhoang/following{/other_user}","gists_url":"https://api.github.com/users/dhhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhhoang/subscriptions","organizations_url":"https://api.github.com/users/dhhoang/orgs","repos_url":"https://api.github.com/users/dhhoang/repos","events_url":"https://api.github.com/users/dhhoang/events{/privacy}","received_events_url":"https://api.github.com/users/dhhoang/received_events","type":"User","site_admin":false},"body":"This PR addresses #17773 \r\nI'm making this a draft PR to get feedback. \r\nFrom an user point of view `DateTimeOffset` is more suitable than `DateTime` for representing deadline since the deadline value should be universal. \r\nThis PR changes the deadline fields in `ServerCallContext` and `CallOptions` to using DateTimeOffset, which is a breaking change. Such breaking change could be avoided by generating extra overload for the client class (e.g. one call with `deadline` argument of type `DateTime?` and another of type `DateTimeOffset?` ) and maintain the type of `ServerCallContext.Deadline` but that would result in a less-nice set of APIs.\r\nLooking for feedback on what should be appropriate. ","created_at":"2019-02-26T04:03:22Z","updated_at":"2019-09-05T13:41:58Z","closed_at":"2019-09-05T13:41:58Z","merged_at":null,"merge_commit_sha":"e482d42d73f06d9d90de6eb261302d206970e619","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1533337147,"node_id":"MDU6TGFiZWwxNTMzMzM3MTQ3","url":"https://api.github.com/repos/grpc/grpc/labels/disposition/stale","name":"disposition/stale","color":"5319e7","default":false},{"id":168238370,"node_id":"MDU6TGFiZWwxNjgyMzgzNzA=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/C%23","name":"lang/C#","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/18169/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/18169/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/18169/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/8f7544a3a8da4fec9f91fe1f3617f7c7fc211f85","head":{"label":"dhhoang:datetimeoffset-deadline","ref":"datetimeoffset-deadline","sha":"8f7544a3a8da4fec9f91fe1f3617f7c7fc211f85","user":{"login":"dhhoang","id":11325809,"node_id":"MDQ6VXNlcjExMzI1ODA5","avatar_url":"https://avatars0.githubusercontent.com/u/11325809?v=4","gravatar_id":"","url":"https://api.github.com/users/dhhoang","html_url":"https://github.com/dhhoang","followers_url":"https://api.github.com/users/dhhoang/followers","following_url":"https://api.github.com/users/dhhoang/following{/other_user}","gists_url":"https://api.github.com/users/dhhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhhoang/subscriptions","organizations_url":"https://api.github.com/users/dhhoang/orgs","repos_url":"https://api.github.com/users/dhhoang/repos","events_url":"https://api.github.com/users/dhhoang/events{/privacy}","received_events_url":"https://api.github.com/users/dhhoang/received_events","type":"User","site_admin":false},"repo":{"id":170248298,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAyNDgyOTg=","name":"grpc","full_name":"dhhoang/grpc","private":false,"owner":{"login":"dhhoang","id":11325809,"node_id":"MDQ6VXNlcjExMzI1ODA5","avatar_url":"https://avatars0.githubusercontent.com/u/11325809?v=4","gravatar_id":"","url":"https://api.github.com/users/dhhoang","html_url":"https://github.com/dhhoang","followers_url":"https://api.github.com/users/dhhoang/followers","following_url":"https://api.github.com/users/dhhoang/following{/other_user}","gists_url":"https://api.github.com/users/dhhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhhoang/subscriptions","organizations_url":"https://api.github.com/users/dhhoang/orgs","repos_url":"https://api.github.com/users/dhhoang/repos","events_url":"https://api.github.com/users/dhhoang/events{/privacy}","received_events_url":"https://api.github.com/users/dhhoang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dhhoang/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/dhhoang/grpc","forks_url":"https://api.github.com/repos/dhhoang/grpc/forks","keys_url":"https://api.github.com/repos/dhhoang/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhhoang/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhhoang/grpc/teams","hooks_url":"https://api.github.com/repos/dhhoang/grpc/hooks","issue_events_url":"https://api.github.com/repos/dhhoang/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/dhhoang/grpc/events","assignees_url":"https://api.github.com/repos/dhhoang/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/dhhoang/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/dhhoang/grpc/tags","blobs_url":"https://api.github.com/repos/dhhoang/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhhoang/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhhoang/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhhoang/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhhoang/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/dhhoang/grpc/languages","stargazers_url":"https://api.github.com/repos/dhhoang/grpc/stargazers","contributors_url":"https://api.github.com/repos/dhhoang/grpc/contributors","subscribers_url":"https://api.github.com/repos/dhhoang/grpc/subscribers","subscription_url":"https://api.github.com/repos/dhhoang/grpc/subscription","commits_url":"https://api.github.com/repos/dhhoang/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhhoang/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhhoang/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhhoang/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhhoang/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/dhhoang/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhhoang/grpc/merges","archive_url":"https://api.github.com/repos/dhhoang/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhhoang/grpc/downloads","issues_url":"https://api.github.com/repos/dhhoang/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/dhhoang/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/dhhoang/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/dhhoang/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhhoang/grpc/labels{/name}","releases_url":"https://api.github.com/repos/dhhoang/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/dhhoang/grpc/deployments","created_at":"2019-02-12T03:54:37Z","updated_at":"2019-02-14T22:50:58Z","pushed_at":"2019-02-26T03:42:30Z","git_url":"git://github.com/dhhoang/grpc.git","ssh_url":"git@github.com:dhhoang/grpc.git","clone_url":"https://github.com/dhhoang/grpc.git","svn_url":"https://github.com/dhhoang/grpc","homepage":"https://grpc.io","size":207317,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"b7ee2d9bdbc9f409ba93b39f3a9c1ef064c26821","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2019-09-05T13:37:01Z","pushed_at":"2019-09-05T13:36:48Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":236456,"stargazers_count":22937,"watchers_count":22937,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":5375,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1414,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5375,"open_issues":1414,"watchers":22937,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/18169"},"html":{"href":"https://github.com/grpc/grpc/pull/18169"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/18169"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/18169/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/18169/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/18169/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/8f7544a3a8da4fec9f91fe1f3617f7c7fc211f85"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"draft","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":4,"additions":273,"deletions":130,"changed_files":26}}
{"actor":{"display_login":"stale"}}