{"action":"created","comment":{"url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/comments/357052650","pull_request_review_id":331109838,"id":357052650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzA1MjY1MA==","diff_hunk":"@@ -353,9 +355,8 @@ class HubContext {\n }\n \n class Hub {\n-    _methods = new Map();\n-\n     constructor() {\n+        this._methods = new Map();","path":"signalr-node-server/signalr.js","position":120,"original_position":120,"commit_id":"a0870f069e5bb6b5967e55ab300122f41822aa30","original_commit_id":"d9068747bf398b6bc73e215cdf149cc1c8f006c0","user":{"login":"dirkpennings","id":491731,"node_id":"MDQ6VXNlcjQ5MTczMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/491731?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkpennings","html_url":"https://github.com/dirkpennings","followers_url":"https://api.github.com/users/dirkpennings/followers","following_url":"https://api.github.com/users/dirkpennings/following{/other_user}","gists_url":"https://api.github.com/users/dirkpennings/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkpennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkpennings/subscriptions","organizations_url":"https://api.github.com/users/dirkpennings/orgs","repos_url":"https://api.github.com/users/dirkpennings/repos","events_url":"https://api.github.com/users/dirkpennings/events{/privacy}","received_events_url":"https://api.github.com/users/dirkpennings/received_events","type":"User","site_admin":false},"body":"This was the part where Node v10 failed. I figured this would be an easy solution but not sure","created_at":"2019-12-12T09:56:15Z","updated_at":"2019-12-12T09:56:15Z","html_url":"https://github.com/davidfowl/signalr-ports/pull/4#discussion_r357052650","pull_request_url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/comments/357052650"},"html":{"href":"https://github.com/davidfowl/signalr-ports/pull/4#discussion_r357052650"},"pull_request":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4"}},"in_reply_to_id":356862501},"pull_request":{"url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4","id":348847015,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4ODQ3MDE1","html_url":"https://github.com/davidfowl/signalr-ports/pull/4","diff_url":"https://github.com/davidfowl/signalr-ports/pull/4.diff","patch_url":"https://github.com/davidfowl/signalr-ports/pull/4.patch","issue_url":"https://api.github.com/repos/davidfowl/signalr-ports/issues/4","number":4,"state":"open","locked":false,"title":"Node v10 changes, CORS additions, settings added and added consistency with .NET core example","user":{"login":"dirkpennings","id":491731,"node_id":"MDQ6VXNlcjQ5MTczMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/491731?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkpennings","html_url":"https://github.com/dirkpennings","followers_url":"https://api.github.com/users/dirkpennings/followers","following_url":"https://api.github.com/users/dirkpennings/following{/other_user}","gists_url":"https://api.github.com/users/dirkpennings/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkpennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkpennings/subscriptions","organizations_url":"https://api.github.com/users/dirkpennings/orgs","repos_url":"https://api.github.com/users/dirkpennings/repos","events_url":"https://api.github.com/users/dirkpennings/events{/privacy}","received_events_url":"https://api.github.com/users/dirkpennings/received_events","type":"User","site_admin":false},"body":"Node v10 changes. And check CHANGELOG.md for more changes regarding CORS etc.","created_at":"2019-12-04T11:50:26Z","updated_at":"2019-12-12T09:56:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff985c654d9c9cfb7360e488b8d1038ae61bc188","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4/commits","review_comments_url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4/comments","review_comment_url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidfowl/signalr-ports/issues/4/comments","statuses_url":"https://api.github.com/repos/davidfowl/signalr-ports/statuses/a0870f069e5bb6b5967e55ab300122f41822aa30","head":{"label":"dirkpennings:master","ref":"master","sha":"a0870f069e5bb6b5967e55ab300122f41822aa30","user":{"login":"dirkpennings","id":491731,"node_id":"MDQ6VXNlcjQ5MTczMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/491731?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkpennings","html_url":"https://github.com/dirkpennings","followers_url":"https://api.github.com/users/dirkpennings/followers","following_url":"https://api.github.com/users/dirkpennings/following{/other_user}","gists_url":"https://api.github.com/users/dirkpennings/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkpennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkpennings/subscriptions","organizations_url":"https://api.github.com/users/dirkpennings/orgs","repos_url":"https://api.github.com/users/dirkpennings/repos","events_url":"https://api.github.com/users/dirkpennings/events{/privacy}","received_events_url":"https://api.github.com/users/dirkpennings/received_events","type":"User","site_admin":false},"repo":{"id":224654621,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ2NTQ2MjE=","name":"signalr-ports","full_name":"dirkpennings/signalr-ports","private":false,"owner":{"login":"dirkpennings","id":491731,"node_id":"MDQ6VXNlcjQ5MTczMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/491731?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkpennings","html_url":"https://github.com/dirkpennings","followers_url":"https://api.github.com/users/dirkpennings/followers","following_url":"https://api.github.com/users/dirkpennings/following{/other_user}","gists_url":"https://api.github.com/users/dirkpennings/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkpennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkpennings/subscriptions","organizations_url":"https://api.github.com/users/dirkpennings/orgs","repos_url":"https://api.github.com/users/dirkpennings/repos","events_url":"https://api.github.com/users/dirkpennings/events{/privacy}","received_events_url":"https://api.github.com/users/dirkpennings/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dirkpennings/signalr-ports","description":null,"fork":true,"url":"https://api.github.com/repos/dirkpennings/signalr-ports","forks_url":"https://api.github.com/repos/dirkpennings/signalr-ports/forks","keys_url":"https://api.github.com/repos/dirkpennings/signalr-ports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkpennings/signalr-ports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkpennings/signalr-ports/teams","hooks_url":"https://api.github.com/repos/dirkpennings/signalr-ports/hooks","issue_events_url":"https://api.github.com/repos/dirkpennings/signalr-ports/issues/events{/number}","events_url":"https://api.github.com/repos/dirkpennings/signalr-ports/events","assignees_url":"https://api.github.com/repos/dirkpennings/signalr-ports/assignees{/user}","branches_url":"https://api.github.com/repos/dirkpennings/signalr-ports/branches{/branch}","tags_url":"https://api.github.com/repos/dirkpennings/signalr-ports/tags","blobs_url":"https://api.github.com/repos/dirkpennings/signalr-ports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkpennings/signalr-ports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkpennings/signalr-ports/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkpennings/signalr-ports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkpennings/signalr-ports/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkpennings/signalr-ports/languages","stargazers_url":"https://api.github.com/repos/dirkpennings/signalr-ports/stargazers","contributors_url":"https://api.github.com/repos/dirkpennings/signalr-ports/contributors","subscribers_url":"https://api.github.com/repos/dirkpennings/signalr-ports/subscribers","subscription_url":"https://api.github.com/repos/dirkpennings/signalr-ports/subscription","commits_url":"https://api.github.com/repos/dirkpennings/signalr-ports/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkpennings/signalr-ports/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkpennings/signalr-ports/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkpennings/signalr-ports/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirkpennings/signalr-ports/contents/{+path}","compare_url":"https://api.github.com/repos/dirkpennings/signalr-ports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkpennings/signalr-ports/merges","archive_url":"https://api.github.com/repos/dirkpennings/signalr-ports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkpennings/signalr-ports/downloads","issues_url":"https://api.github.com/repos/dirkpennings/signalr-ports/issues{/number}","pulls_url":"https://api.github.com/repos/dirkpennings/signalr-ports/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkpennings/signalr-ports/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkpennings/signalr-ports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkpennings/signalr-ports/labels{/name}","releases_url":"https://api.github.com/repos/dirkpennings/signalr-ports/releases{/id}","deployments_url":"https://api.github.com/repos/dirkpennings/signalr-ports/deployments","created_at":"2019-11-28T13:01:40Z","updated_at":"2019-12-12T09:33:27Z","pushed_at":"2019-12-12T09:33:24Z","git_url":"git://github.com/dirkpennings/signalr-ports.git","ssh_url":"git@github.com:dirkpennings/signalr-ports.git","clone_url":"https://github.com/dirkpennings/signalr-ports.git","svn_url":"https://github.com/dirkpennings/signalr-ports","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidfowl:master","ref":"master","sha":"86496e708ff860fce0283d75480c0a188f6c4fc0","user":{"login":"davidfowl","id":95136,"node_id":"MDQ6VXNlcjk1MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"repo":{"id":221970859,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE5NzA4NTk=","name":"signalr-ports","full_name":"davidfowl/signalr-ports","private":false,"owner":{"login":"davidfowl","id":95136,"node_id":"MDQ6VXNlcjk1MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidfowl/signalr-ports","description":null,"fork":false,"url":"https://api.github.com/repos/davidfowl/signalr-ports","forks_url":"https://api.github.com/repos/davidfowl/signalr-ports/forks","keys_url":"https://api.github.com/repos/davidfowl/signalr-ports/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidfowl/signalr-ports/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidfowl/signalr-ports/teams","hooks_url":"https://api.github.com/repos/davidfowl/signalr-ports/hooks","issue_events_url":"https://api.github.com/repos/davidfowl/signalr-ports/issues/events{/number}","events_url":"https://api.github.com/repos/davidfowl/signalr-ports/events","assignees_url":"https://api.github.com/repos/davidfowl/signalr-ports/assignees{/user}","branches_url":"https://api.github.com/repos/davidfowl/signalr-ports/branches{/branch}","tags_url":"https://api.github.com/repos/davidfowl/signalr-ports/tags","blobs_url":"https://api.github.com/repos/davidfowl/signalr-ports/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidfowl/signalr-ports/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidfowl/signalr-ports/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidfowl/signalr-ports/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidfowl/signalr-ports/statuses/{sha}","languages_url":"https://api.github.com/repos/davidfowl/signalr-ports/languages","stargazers_url":"https://api.github.com/repos/davidfowl/signalr-ports/stargazers","contributors_url":"https://api.github.com/repos/davidfowl/signalr-ports/contributors","subscribers_url":"https://api.github.com/repos/davidfowl/signalr-ports/subscribers","subscription_url":"https://api.github.com/repos/davidfowl/signalr-ports/subscription","commits_url":"https://api.github.com/repos/davidfowl/signalr-ports/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidfowl/signalr-ports/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidfowl/signalr-ports/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidfowl/signalr-ports/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidfowl/signalr-ports/contents/{+path}","compare_url":"https://api.github.com/repos/davidfowl/signalr-ports/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidfowl/signalr-ports/merges","archive_url":"https://api.github.com/repos/davidfowl/signalr-ports/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidfowl/signalr-ports/downloads","issues_url":"https://api.github.com/repos/davidfowl/signalr-ports/issues{/number}","pulls_url":"https://api.github.com/repos/davidfowl/signalr-ports/pulls{/number}","milestones_url":"https://api.github.com/repos/davidfowl/signalr-ports/milestones{/number}","notifications_url":"https://api.github.com/repos/davidfowl/signalr-ports/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidfowl/signalr-ports/labels{/name}","releases_url":"https://api.github.com/repos/davidfowl/signalr-ports/releases{/id}","deployments_url":"https://api.github.com/repos/davidfowl/signalr-ports/deployments","created_at":"2019-11-15T17:18:53Z","updated_at":"2019-12-12T09:18:55Z","pushed_at":"2019-12-12T09:33:26Z","git_url":"git://github.com/davidfowl/signalr-ports.git","ssh_url":"git@github.com:davidfowl/signalr-ports.git","clone_url":"https://github.com/davidfowl/signalr-ports.git","svn_url":"https://github.com/davidfowl/signalr-ports","homepage":null,"size":145,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":1,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4"},"html":{"href":"https://github.com/davidfowl/signalr-ports/pull/4"},"issue":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/issues/4"},"comments":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/davidfowl/signalr-ports/statuses/a0870f069e5bb6b5967e55ab300122f41822aa30"}},"author_association":"NONE"}}
{"actor":{"display_login":"dirkpennings"}}