{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/comments/290832618","pull_request_review_id":246126972,"id":290832618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDgzMjYxOA==","diff_hunk":"@@ -0,0 +1,32 @@\n+{\n+  \"$schema\": \"https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json\",\n+  \"mainEntryPointFilePath\": \"types/src/index.d.ts\",\n+  \"docModel\": {\n+    \"enabled\": false\n+  },\n+  \"apiReport\": {\n+    \"enabled\": true,\n+    \"reportFolder\": \"./review\"\n+  },\n+  \"dtsRollup\": {\n+    \"enabled\": true,\n+    \"untrimmedFilePath\": \"./types/azure-template.d.ts\",\n+    \"betaTrimmedFilePath\": \"./types/azure-template-beta.d.ts\",\n+    \"publicTrimmedFilePath\": \"./types/azure-template-public.d.ts\"","path":"sdk/template/template/api-extractor.json","position":15,"original_position":15,"commit_id":"b08865439707c9d0de99c5a49be2f5d1f223ce52","original_commit_id":"b08865439707c9d0de99c5a49be2f5d1f223ce52","user":{"login":"jeremymeng","id":7583839,"node_id":"MDQ6VXNlcjc1ODM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7583839?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"body":"Make sense.  I will rename `untrimmedFilePath` to `./types/azure-template-dev.d.ts`. Otherwise it gets generated to `dist/template.d.ts` by default and is packed.  I noticed that eventhubs etc. are packing the untrimmed ones.  I will fix them in a separate PR.","created_at":"2019-06-05T16:41:18Z","updated_at":"2019-06-05T16:41:18Z","html_url":"https://github.com/Azure/azure-sdk-for-js/pull/3461#discussion_r290832618","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/comments/290832618"},"html":{"href":"https://github.com/Azure/azure-sdk-for-js/pull/3461#discussion_r290832618"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461"}},"in_reply_to_id":290830976},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461","id":285229923,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MjI5OTIz","html_url":"https://github.com/Azure/azure-sdk-for-js/pull/3461","diff_url":"https://github.com/Azure/azure-sdk-for-js/pull/3461.diff","patch_url":"https://github.com/Azure/azure-sdk-for-js/pull/3461.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues/3461","number":3461,"state":"open","locked":false,"title":"Fix types in template package","user":{"login":"jeremymeng","id":7583839,"node_id":"MDQ6VXNlcjc1ODM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7583839?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"body":"The path to the type declaration file is incorrect. This change introduces\r\n\r\n- rollup of d.ts files using api-extractor\r\n\r\n- point `types` to the rolled-up azure-template.d.ts file\r\n\r\n- also generate beta trimmed and public trimmed d.ts rollup files in case\r\n  we want to publish them (which requires either updating the `types` field in\r\n  package.json, or overwriting that file)\r\n\r\n- commit the api report (./review/template.api.md) which is often used to review\r\n  api changes.","created_at":"2019-06-05T05:15:55Z","updated_at":"2019-06-05T16:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88d051b025f7b111de9ca26e286be0a3bb6acb82","assignee":{"login":"jeremymeng","id":7583839,"node_id":"MDQ6VXNlcjc1ODM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7583839?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeremymeng","id":7583839,"node_id":"MDQ6VXNlcjc1ODM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7583839?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bterlson","id":11236,"node_id":"MDQ6VXNlcjExMjM2","avatar_url":"https://avatars0.githubusercontent.com/u/11236?v=4","gravatar_id":"","url":"https://api.github.com/users/bterlson","html_url":"https://github.com/bterlson","followers_url":"https://api.github.com/users/bterlson/followers","following_url":"https://api.github.com/users/bterlson/following{/other_user}","gists_url":"https://api.github.com/users/bterlson/gists{/gist_id}","starred_url":"https://api.github.com/users/bterlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bterlson/subscriptions","organizations_url":"https://api.github.com/users/bterlson/orgs","repos_url":"https://api.github.com/users/bterlson/repos","events_url":"https://api.github.com/users/bterlson/events{/privacy}","received_events_url":"https://api.github.com/users/bterlson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues/3461/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/statuses/b08865439707c9d0de99c5a49be2f5d1f223ce52","head":{"label":"jeremymeng:template-declaration-rollup","ref":"template-declaration-rollup","sha":"b08865439707c9d0de99c5a49be2f5d1f223ce52","user":{"login":"jeremymeng","id":7583839,"node_id":"MDQ6VXNlcjc1ODM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7583839?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"repo":{"id":168413405,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg0MTM0MDU=","name":"azure-sdk-for-js","full_name":"jeremymeng/azure-sdk-for-js","private":false,"owner":{"login":"jeremymeng","id":7583839,"node_id":"MDQ6VXNlcjc1ODM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/7583839?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremymeng","html_url":"https://github.com/jeremymeng","followers_url":"https://api.github.com/users/jeremymeng/followers","following_url":"https://api.github.com/users/jeremymeng/following{/other_user}","gists_url":"https://api.github.com/users/jeremymeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremymeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremymeng/subscriptions","organizations_url":"https://api.github.com/users/jeremymeng/orgs","repos_url":"https://api.github.com/users/jeremymeng/repos","events_url":"https://api.github.com/users/jeremymeng/events{/privacy}","received_events_url":"https://api.github.com/users/jeremymeng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeremymeng/azure-sdk-for-js","description":"An isomorphic javascript sdk for Azure services ","fork":true,"url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js","forks_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/forks","keys_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/teams","hooks_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/hooks","issue_events_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/issues/events{/number}","events_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/events","assignees_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/assignees{/user}","branches_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/branches{/branch}","tags_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/tags","blobs_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/languages","stargazers_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/stargazers","contributors_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/contributors","subscribers_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/subscribers","subscription_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/subscription","commits_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/contents/{+path}","compare_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/merges","archive_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/downloads","issues_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/issues{/number}","pulls_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/labels{/name}","releases_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/releases{/id}","deployments_url":"https://api.github.com/repos/jeremymeng/azure-sdk-for-js/deployments","created_at":"2019-01-30T20:51:52Z","updated_at":"2019-04-01T23:50:26Z","pushed_at":"2019-06-05T16:34:18Z","git_url":"git://github.com/jeremymeng/azure-sdk-for-js.git","ssh_url":"git@github.com:jeremymeng/azure-sdk-for-js.git","clone_url":"https://github.com/jeremymeng/azure-sdk-for-js.git","svn_url":"https://github.com/jeremymeng/azure-sdk-for-js","homepage":null,"size":39186,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"2de21f340b82d259ddbc01497402c3664a0b81aa","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":108311273,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMTEyNzM=","name":"azure-sdk-for-js","full_name":"Azure/azure-sdk-for-js","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-js","description":"An isomorphic javascript sdk for Azure services ","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-js","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-js/deployments","created_at":"2017-10-25T18:44:09Z","updated_at":"2019-06-05T04:19:55Z","pushed_at":"2019-06-05T16:37:45Z","git_url":"git://github.com/Azure/azure-sdk-for-js.git","ssh_url":"git@github.com:Azure/azure-sdk-for-js.git","clone_url":"https://github.com/Azure/azure-sdk-for-js.git","svn_url":"https://github.com/Azure/azure-sdk-for-js","homepage":null,"size":36777,"stargazers_count":81,"watchers_count":81,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":242,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":61,"open_issues":242,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461"},"html":{"href":"https://github.com/Azure/azure-sdk-for-js/pull/3461"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues/3461"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/issues/3461/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/pulls/3461/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-js/statuses/b08865439707c9d0de99c5a49be2f5d1f223ce52"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeremymeng"}}