{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/262313424","pull_request_review_id":210451758,"id":262313424,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjMxMzQyNA==","diff_hunk":"@@ -14,8 +15,9 @@ namespace Microsoft.ML.Transforms.Text\n     /// Produces a bag of counts of ngrams (sequences of consecutive words) in a given text.\n     /// It does so by building a dictionary of ngrams and using the id in the dictionary as the index in the bag.\n     /// </summary>\n-    public sealed class WordBagEstimator : TrainedWrapperEstimatorBase\n+    public sealed class WordBagEstimator : IEstimator<ITransformer>","path":"src/Microsoft.ML.Transforms/Text/WrappedTextTransformers.cs","position":13,"original_position":13,"commit_id":"392cee654b823f81570c49234afa8fc09c97c3ed","original_commit_id":"392cee654b823f81570c49234afa8fc09c97c3ed","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"body":"This is a really good idea! until we do the proper translation\r\n\r\n---\r\nIn reply to: [262299912](https://github.com/dotnet/machinelearning/pull/2842#discussion_r262299912) [](ancestors = 262299912)","created_at":"2019-03-05T01:22:07Z","updated_at":"2019-03-05T01:22:08Z","html_url":"https://github.com/dotnet/machinelearning/pull/2842#discussion_r262313424","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/262313424"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/2842#discussion_r262313424"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842"}},"in_reply_to_id":262299912},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842","id":258135980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4MTM1OTgw","html_url":"https://github.com/dotnet/machinelearning/pull/2842","diff_url":"https://github.com/dotnet/machinelearning/pull/2842.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/2842.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/2842","number":2842,"state":"open","locked":false,"title":"Hide more of Microsoft.ML.Data","user":{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},"body":"Towards #1602. When performing what I hope is one of my final reviews of the public surface area of `Microsoft.ML.Data` I saw many \"small\" items, each too petty to warrant separate issues, but that we nonetheless do not want in the public surface. This is in the vein of #2300 and other similar PRs. Special emphasis was placed on making sure we don't have abstract protected members visible as part of the public surface, and other such things as this.\r\n\r\nIn my review of the assembly I did not address those types or members I knew were being taken care of through other channels. (E.g., the attribute bearing marker interfaces for `IComponentFactory`, or the calibrator.)","created_at":"2019-03-05T00:09:29Z","updated_at":"2019-03-05T01:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4fe154ca6f9a8afb43ecfebea8471bbc6890eef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"codemzs","id":1211949,"node_id":"MDQ6VXNlcjEyMTE5NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1211949?v=4","gravatar_id":"","url":"https://api.github.com/users/codemzs","html_url":"https://github.com/codemzs","followers_url":"https://api.github.com/users/codemzs/followers","following_url":"https://api.github.com/users/codemzs/following{/other_user}","gists_url":"https://api.github.com/users/codemzs/gists{/gist_id}","starred_url":"https://api.github.com/users/codemzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemzs/subscriptions","organizations_url":"https://api.github.com/users/codemzs/orgs","repos_url":"https://api.github.com/users/codemzs/repos","events_url":"https://api.github.com/users/codemzs/events{/privacy}","received_events_url":"https://api.github.com/users/codemzs/received_events","type":"User","site_admin":false},{"login":"Ivanidzo4ka","id":1523833,"node_id":"MDQ6VXNlcjE1MjM4MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1523833?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivanidzo4ka","html_url":"https://github.com/Ivanidzo4ka","followers_url":"https://api.github.com/users/Ivanidzo4ka/followers","following_url":"https://api.github.com/users/Ivanidzo4ka/following{/other_user}","gists_url":"https://api.github.com/users/Ivanidzo4ka/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivanidzo4ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivanidzo4ka/subscriptions","organizations_url":"https://api.github.com/users/Ivanidzo4ka/orgs","repos_url":"https://api.github.com/users/Ivanidzo4ka/repos","events_url":"https://api.github.com/users/Ivanidzo4ka/events{/privacy}","received_events_url":"https://api.github.com/users/Ivanidzo4ka/received_events","type":"User","site_admin":false},{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/2842/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/392cee654b823f81570c49234afa8fc09c97c3ed","head":{"label":"TomFinley:Hide1","ref":"Hide1","sha":"392cee654b823f81570c49234afa8fc09c97c3ed","user":{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},"repo":{"id":133558426,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NTg0MjY=","name":"machinelearning","full_name":"TomFinley/machinelearning","private":false,"owner":{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TomFinley/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/TomFinley/machinelearning","forks_url":"https://api.github.com/repos/TomFinley/machinelearning/forks","keys_url":"https://api.github.com/repos/TomFinley/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomFinley/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomFinley/machinelearning/teams","hooks_url":"https://api.github.com/repos/TomFinley/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/TomFinley/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/TomFinley/machinelearning/events","assignees_url":"https://api.github.com/repos/TomFinley/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/TomFinley/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/TomFinley/machinelearning/tags","blobs_url":"https://api.github.com/repos/TomFinley/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomFinley/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomFinley/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomFinley/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomFinley/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/TomFinley/machinelearning/languages","stargazers_url":"https://api.github.com/repos/TomFinley/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/TomFinley/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/TomFinley/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/TomFinley/machinelearning/subscription","commits_url":"https://api.github.com/repos/TomFinley/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomFinley/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomFinley/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomFinley/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomFinley/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/TomFinley/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomFinley/machinelearning/merges","archive_url":"https://api.github.com/repos/TomFinley/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomFinley/machinelearning/downloads","issues_url":"https://api.github.com/repos/TomFinley/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/TomFinley/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/TomFinley/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/TomFinley/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomFinley/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/TomFinley/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/TomFinley/machinelearning/deployments","created_at":"2018-05-15T18:40:13Z","updated_at":"2019-03-05T00:21:02Z","pushed_at":"2019-03-05T00:21:00Z","git_url":"git://github.com/TomFinley/machinelearning.git","ssh_url":"git@github.com:TomFinley/machinelearning.git","clone_url":"https://github.com/TomFinley/machinelearning.git","svn_url":"https://github.com/TomFinley/machinelearning","homepage":"http://dot.net/ml","size":39843,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3701389bccb044734a749a0bea65da0df41de165","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2019-03-05T01:07:01Z","pushed_at":"2019-03-05T01:08:33Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":39795,"stargazers_count":5267,"watchers_count":5267,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1077,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1077,"open_issues":514,"watchers":5267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/2842"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/2842"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/2842/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/2842/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/392cee654b823f81570c49234afa8fc09c97c3ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"artidoro"}}