{"push_id":3740703495,"size":12,"distinct_size":1,"ref":"refs/heads/feature/ken-removeUpdateOpportunityLinkWhenOppHasPayments","head":"c9e31f8bb41fe90ef97fd3ef500170eea9b8378c","before":"e41c4ad5840272b5be2868f8e4c6bcd014778fd9","commits":[{"sha":"6178590541b4bf45a9ecb505e295a0ae0d309e53","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Force a unique LastName when creating a Contact and a unique Name when creating other types of records. Some of the Naming formats are a specified way because there are unit tests that expect specific values in the FirstName or LastName fields. Those are left as is. Style and other cleanups as well.","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/6178590541b4bf45a9ecb505e295a0ae0d309e53"},{"sha":"e33bd95a32b0961bad162858949fbf6424263c00","author":{"name":"Mr Belvedere","email":"1cc83c2f6b06c1c1b19e594e15ec8ce528b469f4@users.noreply.github.com"},"message":"Merge c1f505a622e2d66b6e991023be3c31afd06ff9a0 into feature/msmith/unittests-unique-contact-name","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/e33bd95a32b0961bad162858949fbf6424263c00"},{"sha":"2b933d9eed11847fe14c859ba509984acd7fe9df","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Had a thought overnight. Technically adding a counter to the end of a contact LastName does not make it unique. Two test methods calling the same factory method will both create contacts with the lastname of \"TestLastName0\". That's just as bad as using LastName='foo'. Updated the methods that applied counter integers to the lastName to use a unique string, and updated the test method that was looking for a hardcoded LastName of \"TestLastName00\" to be more dynamic.","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/2b933d9eed11847fe14c859ba509984acd7fe9df"},{"sha":"a6d77c2e1813815575cc5bff525a708fbaa8fbcb","author":{"name":"Mr Belvedere","email":"1cc83c2f6b06c1c1b19e594e15ec8ce528b469f4@users.noreply.github.com"},"message":"Merge 81b06f041c09e0beab532fcb5cea1e0dbc073ae1 into feature/msmith/unittests-unique-contact-name","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/a6d77c2e1813815575cc5bff525a708fbaa8fbcb"},{"sha":"c8b87a2fa89c28b5868be8ce2a3bc7e5de9a01c4","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Remove IsParallel test annotation from this class because it periodically fails with a lock error in the testSetup method.","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/c8b87a2fa89c28b5868be8ce2a3bc7e5de9a01c4"},{"sha":"07837c9da919ed703b45aab140c9937964474851","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Merge remote-tracking branch 'origin/feature/msmith/unittests-unique-contact-name' into feature/msmith/unittests-unique-contact-name","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/07837c9da919ed703b45aab140c9937964474851"},{"sha":"5fed4f595752c5c109bb75ed60d9e8f090def5b1","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Noticing that this test fails with a lock error because it creates contacts with an identical last name in two different test methods.","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/5fed4f595752c5c109bb75ed60d9e8f090def5b1"},{"sha":"1d83c5e8a908c425e9c702aa0590762238aad9d0","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Noticed that using `getRandomInteger()` when called 50000 times can occasionally return the same value twice. Given how Salesforce executes unit tests it might be possible for two calls to `getRandomInteger()` from different methods to return the same value (i.e., a duplicate). Change to `getRandomLong()` to reduce the possibility of this.\nClass cleanup.","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/1d83c5e8a908c425e9c702aa0590762238aad9d0"},{"sha":"817d54986e117668f1fee5a4e0ecea941008afee","author":{"name":"Mr Belvedere","email":"1cc83c2f6b06c1c1b19e594e15ec8ce528b469f4@users.noreply.github.com"},"message":"Merge 4673f34ee53eb0a6bfc4a2d76eff05d4e438a1a9 into feature/msmith/unittests-unique-contact-name","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/817d54986e117668f1fee5a4e0ecea941008afee"},{"sha":"74b31fc882fc1636be17f0920bded194d9f34cd8","author":{"name":"Michael Smith","email":"865bf669e73db50e67d15ac3aba7696daa15b2c0@salesforce.com"},"message":"Since this class is using `IsParallel=true` and more than one test method is calling the `createTestContacts` helper within this class to create test contacts, it's apparently necessary to further make the Contacts unique for each of the test methods that call `createTestContacts`.","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/74b31fc882fc1636be17f0920bded194d9f34cd8"},{"sha":"49ebb101f0a3779a637b541da066f74a0c6c5b48","author":{"name":"Radmila Askraba","email":"1d837e4575a2670ee853292d36f60539226d683f@salesforce.com"},"message":"Merge pull request #4334 from SalesforceFoundation/feature/msmith/unittests-unique-contact-name\n\nUnitTests: Force Unique Contact.LastName in Data Factory Methods","distinct":false,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/49ebb101f0a3779a637b541da066f74a0c6c5b48"},{"sha":"c9e31f8bb41fe90ef97fd3ef500170eea9b8378c","author":{"name":"Mr Belvedere","email":"1cc83c2f6b06c1c1b19e594e15ec8ce528b469f4@users.noreply.github.com"},"message":"Merge 49ebb101f0a3779a637b541da066f74a0c6c5b48 into feature/ken-removeUpdateOpportunityLinkWhenOppHasPayments","distinct":true,"url":"https://api.github.com/repos/SalesforceFoundation/Cumulus/commits/c9e31f8bb41fe90ef97fd3ef500170eea9b8378c"}]}
{"actor":{"display_login":"mrbelvedere"}}