{"action":"created","comment":{"url":"https://api.github.com/repos/justeat/httpclient-interception/pulls/comments/331806369","pull_request_review_id":297856144,"id":331806369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMTgwNjM2OQ==","diff_hunk":"@@ -65,18 +66,58 @@ internal static class DelegateHelpers\n         /// <returns>\n         /// The converted delegate if <paramref name=\"onIntercepted\"/> has a value; otherwise <see langword=\"null\"/>.\n         /// </returns>\n-        internal static Func<HttpRequestMessage, Task<bool>>? ConvertToBooleanTask(Func<HttpRequestMessage, Task>? onIntercepted)\n+        internal static Func<HttpRequestMessage, CancellationToken, Task<bool>>? ConvertToBooleanTask(Func<HttpRequestMessage, Task>? onIntercepted)\n         {\n             if (onIntercepted == null)\n             {\n                 return null;\n             }\n \n-            return async (message) =>\n+            return async (message, _) =>\n             {\n                 await onIntercepted(message).ConfigureAwait(false);\n                 return true;\n             };\n         }\n+","path":"src/HttpClientInterception/DelegateHelpers.cs","position":61,"original_position":61,"commit_id":"cba9c3ffd6e0b9581921320a1984a2cdad90aa84","original_commit_id":"15992c49fa6e0ef390218bd2736bc0aa7d7c47dc","user":{"login":"slang25","id":1341446,"node_id":"MDQ6VXNlcjEzNDE0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1341446?v=4","gravatar_id":"","url":"https://api.github.com/users/slang25","html_url":"https://github.com/slang25","followers_url":"https://api.github.com/users/slang25/followers","following_url":"https://api.github.com/users/slang25/following{/other_user}","gists_url":"https://api.github.com/users/slang25/gists{/gist_id}","starred_url":"https://api.github.com/users/slang25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slang25/subscriptions","organizations_url":"https://api.github.com/users/slang25/orgs","repos_url":"https://api.github.com/users/slang25/repos","events_url":"https://api.github.com/users/slang25/events{/privacy}","received_events_url":"https://api.github.com/users/slang25/received_events","type":"User","site_admin":false},"body":"I'll take your preference, it could be we don't offer the equivalent overload that doesn't have the `CancellationToken`","created_at":"2019-10-06T19:34:57Z","updated_at":"2019-10-06T19:34:57Z","html_url":"https://github.com/justeat/httpclient-interception/pull/144#discussion_r331806369","pull_request_url":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/justeat/httpclient-interception/pulls/comments/331806369"},"html":{"href":"https://github.com/justeat/httpclient-interception/pull/144#discussion_r331806369"},"pull_request":{"href":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144"}},"in_reply_to_id":331802704},"pull_request":{"url":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144","id":324985844,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0OTg1ODQ0","html_url":"https://github.com/justeat/httpclient-interception/pull/144","diff_url":"https://github.com/justeat/httpclient-interception/pull/144.diff","patch_url":"https://github.com/justeat/httpclient-interception/pull/144.patch","issue_url":"https://api.github.com/repos/justeat/httpclient-interception/issues/144","number":144,"state":"open","locked":false,"title":"Add CancellationToken to OnIntercepted","user":{"login":"slang25","id":1341446,"node_id":"MDQ6VXNlcjEzNDE0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1341446?v=4","gravatar_id":"","url":"https://api.github.com/users/slang25","html_url":"https://github.com/slang25","followers_url":"https://api.github.com/users/slang25/followers","following_url":"https://api.github.com/users/slang25/following{/other_user}","gists_url":"https://api.github.com/users/slang25/gists{/gist_id}","starred_url":"https://api.github.com/users/slang25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slang25/subscriptions","organizations_url":"https://api.github.com/users/slang25/orgs","repos_url":"https://api.github.com/users/slang25/repos","events_url":"https://api.github.com/users/slang25/events{/privacy}","received_events_url":"https://api.github.com/users/slang25/received_events","type":"User","site_admin":false},"body":"Fixes #142 \r\n","created_at":"2019-10-05T23:33:29Z","updated_at":"2019-10-06T19:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2159180cfa549eef612994bd19cf9b12742bbae1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":633747190,"node_id":"MDU6TGFiZWw2MzM3NDcxOTA=","url":"https://api.github.com/repos/justeat/httpclient-interception/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/justeat/httpclient-interception/milestones/9","html_url":"https://github.com/justeat/httpclient-interception/milestone/9","labels_url":"https://api.github.com/repos/justeat/httpclient-interception/milestones/9/labels","id":4465656,"node_id":"MDk6TWlsZXN0b25lNDQ2NTY1Ng==","number":9,"title":"v3.0.0","description":"Version 3.0.0 of JustEat.HttpClientInterception.","creator":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2019-07-04T11:41:24Z","updated_at":"2019-10-06T18:21:21Z","due_on":"2019-10-07T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144/commits","review_comments_url":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144/comments","review_comment_url":"https://api.github.com/repos/justeat/httpclient-interception/pulls/comments{/number}","comments_url":"https://api.github.com/repos/justeat/httpclient-interception/issues/144/comments","statuses_url":"https://api.github.com/repos/justeat/httpclient-interception/statuses/cba9c3ffd6e0b9581921320a1984a2cdad90aa84","head":{"label":"slang25:cancellation-tokens","ref":"cancellation-tokens","sha":"cba9c3ffd6e0b9581921320a1984a2cdad90aa84","user":{"login":"slang25","id":1341446,"node_id":"MDQ6VXNlcjEzNDE0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1341446?v=4","gravatar_id":"","url":"https://api.github.com/users/slang25","html_url":"https://github.com/slang25","followers_url":"https://api.github.com/users/slang25/followers","following_url":"https://api.github.com/users/slang25/following{/other_user}","gists_url":"https://api.github.com/users/slang25/gists{/gist_id}","starred_url":"https://api.github.com/users/slang25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slang25/subscriptions","organizations_url":"https://api.github.com/users/slang25/orgs","repos_url":"https://api.github.com/users/slang25/repos","events_url":"https://api.github.com/users/slang25/events{/privacy}","received_events_url":"https://api.github.com/users/slang25/received_events","type":"User","site_admin":false},"repo":{"id":143686976,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2ODY5NzY=","name":"httpclient-interception","full_name":"slang25/httpclient-interception","private":false,"owner":{"login":"slang25","id":1341446,"node_id":"MDQ6VXNlcjEzNDE0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1341446?v=4","gravatar_id":"","url":"https://api.github.com/users/slang25","html_url":"https://github.com/slang25","followers_url":"https://api.github.com/users/slang25/followers","following_url":"https://api.github.com/users/slang25/following{/other_user}","gists_url":"https://api.github.com/users/slang25/gists{/gist_id}","starred_url":"https://api.github.com/users/slang25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slang25/subscriptions","organizations_url":"https://api.github.com/users/slang25/orgs","repos_url":"https://api.github.com/users/slang25/repos","events_url":"https://api.github.com/users/slang25/events{/privacy}","received_events_url":"https://api.github.com/users/slang25/received_events","type":"User","site_admin":false},"html_url":"https://github.com/slang25/httpclient-interception","description":"A .NET Standard library for intercepting server-side HTTP dependencies","fork":true,"url":"https://api.github.com/repos/slang25/httpclient-interception","forks_url":"https://api.github.com/repos/slang25/httpclient-interception/forks","keys_url":"https://api.github.com/repos/slang25/httpclient-interception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slang25/httpclient-interception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slang25/httpclient-interception/teams","hooks_url":"https://api.github.com/repos/slang25/httpclient-interception/hooks","issue_events_url":"https://api.github.com/repos/slang25/httpclient-interception/issues/events{/number}","events_url":"https://api.github.com/repos/slang25/httpclient-interception/events","assignees_url":"https://api.github.com/repos/slang25/httpclient-interception/assignees{/user}","branches_url":"https://api.github.com/repos/slang25/httpclient-interception/branches{/branch}","tags_url":"https://api.github.com/repos/slang25/httpclient-interception/tags","blobs_url":"https://api.github.com/repos/slang25/httpclient-interception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slang25/httpclient-interception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slang25/httpclient-interception/git/refs{/sha}","trees_url":"https://api.github.com/repos/slang25/httpclient-interception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slang25/httpclient-interception/statuses/{sha}","languages_url":"https://api.github.com/repos/slang25/httpclient-interception/languages","stargazers_url":"https://api.github.com/repos/slang25/httpclient-interception/stargazers","contributors_url":"https://api.github.com/repos/slang25/httpclient-interception/contributors","subscribers_url":"https://api.github.com/repos/slang25/httpclient-interception/subscribers","subscription_url":"https://api.github.com/repos/slang25/httpclient-interception/subscription","commits_url":"https://api.github.com/repos/slang25/httpclient-interception/commits{/sha}","git_commits_url":"https://api.github.com/repos/slang25/httpclient-interception/git/commits{/sha}","comments_url":"https://api.github.com/repos/slang25/httpclient-interception/comments{/number}","issue_comment_url":"https://api.github.com/repos/slang25/httpclient-interception/issues/comments{/number}","contents_url":"https://api.github.com/repos/slang25/httpclient-interception/contents/{+path}","compare_url":"https://api.github.com/repos/slang25/httpclient-interception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slang25/httpclient-interception/merges","archive_url":"https://api.github.com/repos/slang25/httpclient-interception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slang25/httpclient-interception/downloads","issues_url":"https://api.github.com/repos/slang25/httpclient-interception/issues{/number}","pulls_url":"https://api.github.com/repos/slang25/httpclient-interception/pulls{/number}","milestones_url":"https://api.github.com/repos/slang25/httpclient-interception/milestones{/number}","notifications_url":"https://api.github.com/repos/slang25/httpclient-interception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slang25/httpclient-interception/labels{/name}","releases_url":"https://api.github.com/repos/slang25/httpclient-interception/releases{/id}","deployments_url":"https://api.github.com/repos/slang25/httpclient-interception/deployments","created_at":"2018-08-06T06:41:45Z","updated_at":"2019-10-03T14:14:07Z","pushed_at":"2019-10-06T19:07:16Z","git_url":"git://github.com/slang25/httpclient-interception.git","ssh_url":"git@github.com:slang25/httpclient-interception.git","clone_url":"https://github.com/slang25/httpclient-interception.git","svn_url":"https://github.com/slang25/httpclient-interception","homepage":"https://tech.just-eat.com/2017/10/02/reliably-testing-http-integrations-in-a-dotnet-application/","size":548,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"justeat:master","ref":"master","sha":"14d903de7c2ce46b10a1e48389b0e60aa2de4965","user":{"login":"justeat","id":1516790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTY3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1516790?v=4","gravatar_id":"","url":"https://api.github.com/users/justeat","html_url":"https://github.com/justeat","followers_url":"https://api.github.com/users/justeat/followers","following_url":"https://api.github.com/users/justeat/following{/other_user}","gists_url":"https://api.github.com/users/justeat/gists{/gist_id}","starred_url":"https://api.github.com/users/justeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justeat/subscriptions","organizations_url":"https://api.github.com/users/justeat/orgs","repos_url":"https://api.github.com/users/justeat/repos","events_url":"https://api.github.com/users/justeat/events{/privacy}","received_events_url":"https://api.github.com/users/justeat/received_events","type":"Organization","site_admin":false},"repo":{"id":95348422,"node_id":"MDEwOlJlcG9zaXRvcnk5NTM0ODQyMg==","name":"httpclient-interception","full_name":"justeat/httpclient-interception","private":false,"owner":{"login":"justeat","id":1516790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTY3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1516790?v=4","gravatar_id":"","url":"https://api.github.com/users/justeat","html_url":"https://github.com/justeat","followers_url":"https://api.github.com/users/justeat/followers","following_url":"https://api.github.com/users/justeat/following{/other_user}","gists_url":"https://api.github.com/users/justeat/gists{/gist_id}","starred_url":"https://api.github.com/users/justeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justeat/subscriptions","organizations_url":"https://api.github.com/users/justeat/orgs","repos_url":"https://api.github.com/users/justeat/repos","events_url":"https://api.github.com/users/justeat/events{/privacy}","received_events_url":"https://api.github.com/users/justeat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/justeat/httpclient-interception","description":"A .NET Standard library for intercepting server-side HTTP dependencies","fork":false,"url":"https://api.github.com/repos/justeat/httpclient-interception","forks_url":"https://api.github.com/repos/justeat/httpclient-interception/forks","keys_url":"https://api.github.com/repos/justeat/httpclient-interception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justeat/httpclient-interception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justeat/httpclient-interception/teams","hooks_url":"https://api.github.com/repos/justeat/httpclient-interception/hooks","issue_events_url":"https://api.github.com/repos/justeat/httpclient-interception/issues/events{/number}","events_url":"https://api.github.com/repos/justeat/httpclient-interception/events","assignees_url":"https://api.github.com/repos/justeat/httpclient-interception/assignees{/user}","branches_url":"https://api.github.com/repos/justeat/httpclient-interception/branches{/branch}","tags_url":"https://api.github.com/repos/justeat/httpclient-interception/tags","blobs_url":"https://api.github.com/repos/justeat/httpclient-interception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justeat/httpclient-interception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justeat/httpclient-interception/git/refs{/sha}","trees_url":"https://api.github.com/repos/justeat/httpclient-interception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justeat/httpclient-interception/statuses/{sha}","languages_url":"https://api.github.com/repos/justeat/httpclient-interception/languages","stargazers_url":"https://api.github.com/repos/justeat/httpclient-interception/stargazers","contributors_url":"https://api.github.com/repos/justeat/httpclient-interception/contributors","subscribers_url":"https://api.github.com/repos/justeat/httpclient-interception/subscribers","subscription_url":"https://api.github.com/repos/justeat/httpclient-interception/subscription","commits_url":"https://api.github.com/repos/justeat/httpclient-interception/commits{/sha}","git_commits_url":"https://api.github.com/repos/justeat/httpclient-interception/git/commits{/sha}","comments_url":"https://api.github.com/repos/justeat/httpclient-interception/comments{/number}","issue_comment_url":"https://api.github.com/repos/justeat/httpclient-interception/issues/comments{/number}","contents_url":"https://api.github.com/repos/justeat/httpclient-interception/contents/{+path}","compare_url":"https://api.github.com/repos/justeat/httpclient-interception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justeat/httpclient-interception/merges","archive_url":"https://api.github.com/repos/justeat/httpclient-interception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justeat/httpclient-interception/downloads","issues_url":"https://api.github.com/repos/justeat/httpclient-interception/issues{/number}","pulls_url":"https://api.github.com/repos/justeat/httpclient-interception/pulls{/number}","milestones_url":"https://api.github.com/repos/justeat/httpclient-interception/milestones{/number}","notifications_url":"https://api.github.com/repos/justeat/httpclient-interception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justeat/httpclient-interception/labels{/name}","releases_url":"https://api.github.com/repos/justeat/httpclient-interception/releases{/id}","deployments_url":"https://api.github.com/repos/justeat/httpclient-interception/deployments","created_at":"2017-06-25T08:47:16Z","updated_at":"2019-10-05T14:47:13Z","pushed_at":"2019-10-06T19:07:17Z","git_url":"git://github.com/justeat/httpclient-interception.git","ssh_url":"git@github.com:justeat/httpclient-interception.git","clone_url":"https://github.com/justeat/httpclient-interception.git","svn_url":"https://github.com/justeat/httpclient-interception","homepage":"https://tech.just-eat.com/2017/10/02/reliably-testing-http-integrations-in-a-dotnet-application/","size":548,"stargazers_count":80,"watchers_count":80,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":2,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144"},"html":{"href":"https://github.com/justeat/httpclient-interception/pull/144"},"issue":{"href":"https://api.github.com/repos/justeat/httpclient-interception/issues/144"},"comments":{"href":"https://api.github.com/repos/justeat/httpclient-interception/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/justeat/httpclient-interception/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/justeat/httpclient-interception/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/justeat/httpclient-interception/statuses/cba9c3ffd6e0b9581921320a1984a2cdad90aa84"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slang25"}}