{"action":"closed","number":16645,"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/16645","id":303947341,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzOTQ3MzQx","html_url":"https://github.com/nextcloud/server/pull/16645","diff_url":"https://github.com/nextcloud/server/pull/16645.diff","patch_url":"https://github.com/nextcloud/server/pull/16645.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/16645","number":16645,"state":"closed","locked":false,"title":"Correctly handle emtpy string in proxyuserpwd config","user":{"login":"sshambar","id":640696,"node_id":"MDQ6VXNlcjY0MDY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/640696?v=4","gravatar_id":"","url":"https://api.github.com/users/sshambar","html_url":"https://github.com/sshambar","followers_url":"https://api.github.com/users/sshambar/followers","following_url":"https://api.github.com/users/sshambar/following{/other_user}","gists_url":"https://api.github.com/users/sshambar/gists{/gist_id}","starred_url":"https://api.github.com/users/sshambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshambar/subscriptions","organizations_url":"https://api.github.com/users/sshambar/orgs","repos_url":"https://api.github.com/users/sshambar/repos","events_url":"https://api.github.com/users/sshambar/events{/privacy}","received_events_url":"https://api.github.com/users/sshambar/received_events","type":"User","site_admin":false},"body":"As documented, the default value for config value proxyuserpwd is ''.\r\nHowever, that value results in the error:\r\n \"cURL error 5: Unsupported proxy syntax in '@'\".\r\nThis patch handles the values of '' and null (the default in the code)\r\nthe same for config values proxyuserpwd and proxy.\r\n\r\nSigned-off-by: Scott Shambarger <devel@shambarger.net>","created_at":"2019-08-02T22:27:00Z","updated_at":"2019-08-12T08:48:04Z","closed_at":"2019-08-12T08:48:04Z","merged_at":null,"merge_commit_sha":"05eeedbb9b4c6e933204cfd22117ff71d2ef5878","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/16645/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/16645/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/16645/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/3df686c5ad0d12b1d5a697bfd85e2ea37b3e4e9c","head":{"label":"sshambar:proxy-fix-16","ref":"proxy-fix-16","sha":"3df686c5ad0d12b1d5a697bfd85e2ea37b3e4e9c","user":{"login":"sshambar","id":640696,"node_id":"MDQ6VXNlcjY0MDY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/640696?v=4","gravatar_id":"","url":"https://api.github.com/users/sshambar","html_url":"https://github.com/sshambar","followers_url":"https://api.github.com/users/sshambar/followers","following_url":"https://api.github.com/users/sshambar/following{/other_user}","gists_url":"https://api.github.com/users/sshambar/gists{/gist_id}","starred_url":"https://api.github.com/users/sshambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshambar/subscriptions","organizations_url":"https://api.github.com/users/sshambar/orgs","repos_url":"https://api.github.com/users/sshambar/repos","events_url":"https://api.github.com/users/sshambar/events{/privacy}","received_events_url":"https://api.github.com/users/sshambar/received_events","type":"User","site_admin":false},"repo":{"id":200301699,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAzMDE2OTk=","name":"server","full_name":"sshambar/server","private":false,"owner":{"login":"sshambar","id":640696,"node_id":"MDQ6VXNlcjY0MDY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/640696?v=4","gravatar_id":"","url":"https://api.github.com/users/sshambar","html_url":"https://github.com/sshambar","followers_url":"https://api.github.com/users/sshambar/followers","following_url":"https://api.github.com/users/sshambar/following{/other_user}","gists_url":"https://api.github.com/users/sshambar/gists{/gist_id}","starred_url":"https://api.github.com/users/sshambar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshambar/subscriptions","organizations_url":"https://api.github.com/users/sshambar/orgs","repos_url":"https://api.github.com/users/sshambar/repos","events_url":"https://api.github.com/users/sshambar/events{/privacy}","received_events_url":"https://api.github.com/users/sshambar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sshambar/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":true,"url":"https://api.github.com/repos/sshambar/server","forks_url":"https://api.github.com/repos/sshambar/server/forks","keys_url":"https://api.github.com/repos/sshambar/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sshambar/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sshambar/server/teams","hooks_url":"https://api.github.com/repos/sshambar/server/hooks","issue_events_url":"https://api.github.com/repos/sshambar/server/issues/events{/number}","events_url":"https://api.github.com/repos/sshambar/server/events","assignees_url":"https://api.github.com/repos/sshambar/server/assignees{/user}","branches_url":"https://api.github.com/repos/sshambar/server/branches{/branch}","tags_url":"https://api.github.com/repos/sshambar/server/tags","blobs_url":"https://api.github.com/repos/sshambar/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sshambar/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sshambar/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/sshambar/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sshambar/server/statuses/{sha}","languages_url":"https://api.github.com/repos/sshambar/server/languages","stargazers_url":"https://api.github.com/repos/sshambar/server/stargazers","contributors_url":"https://api.github.com/repos/sshambar/server/contributors","subscribers_url":"https://api.github.com/repos/sshambar/server/subscribers","subscription_url":"https://api.github.com/repos/sshambar/server/subscription","commits_url":"https://api.github.com/repos/sshambar/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/sshambar/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/sshambar/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/sshambar/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/sshambar/server/contents/{+path}","compare_url":"https://api.github.com/repos/sshambar/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sshambar/server/merges","archive_url":"https://api.github.com/repos/sshambar/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sshambar/server/downloads","issues_url":"https://api.github.com/repos/sshambar/server/issues{/number}","pulls_url":"https://api.github.com/repos/sshambar/server/pulls{/number}","milestones_url":"https://api.github.com/repos/sshambar/server/milestones{/number}","notifications_url":"https://api.github.com/repos/sshambar/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sshambar/server/labels{/name}","releases_url":"https://api.github.com/repos/sshambar/server/releases{/id}","deployments_url":"https://api.github.com/repos/sshambar/server/deployments","created_at":"2019-08-02T21:48:47Z","updated_at":"2019-08-11T19:07:51Z","pushed_at":"2019-08-11T19:07:47Z","git_url":"git://github.com/sshambar/server.git","ssh_url":"git@github.com:sshambar/server.git","clone_url":"https://github.com/sshambar/server.git","svn_url":"https://github.com/sshambar/server","homepage":"https://nextcloud.com","size":461035,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nextcloud:stable16","ref":"stable16","sha":"fb65d1e0aede41a3196cbecf19cd50075422a828","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2019-08-12T06:25:15Z","pushed_at":"2019-08-12T08:35:57Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":463548,"stargazers_count":8200,"watchers_count":8200,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1472,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2040,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1472,"open_issues":2040,"watchers":8200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/16645"},"html":{"href":"https://github.com/nextcloud/server/pull/16645"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/16645"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/16645/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/16645/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/16645/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/3df686c5ad0d12b1d5a697bfd85e2ea37b3e4e9c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"rullzer"}}