{"action":"created","comment":{"url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/comments/338850942","pull_request_review_id":306938885,"id":338850942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODg1MDk0Mg==","diff_hunk":"@@ -1132,51 +1132,58 @@ shallowDenote         e  = e\n reservedIdentifiers :: HashSet Text\n reservedIdentifiers =\n     Data.HashSet.fromList\n-        [ \"let\"\n-        , \"in\"\n-        , \"Type\"\n-        , \"Kind\"\n-        , \"Sort\"\n-        , \"forall\"\n-        , \"Bool\"\n-        , \"True\"\n-        , \"False\"\n-        , \"merge\"\n-        , \"toMap\"\n-        , \"if\"\n+        [ -- Keywords according to the `keyword` rule in the grammar\n+          \"if\"\n         , \"then\"\n         , \"else\"\n-        , \"as\"\n+        , \"let\"\n+        , \"in\"\n         , \"using\"\n-        , \"Natural\"\n+        , \"missing\"\n+        , \"as\"\n+        , \"Infinity\"\n+        , \"NaN\"\n+        , \"merge\"\n+        , \"Some\"\n+        , \"toMap\"\n+        , \"assert\"\n+\n+          -- Builtins according to the `builtin` rule in the grammar\n         , \"Natural/fold\"\n         , \"Natural/build\"\n         , \"Natural/isZero\"\n         , \"Natural/even\"\n         , \"Natural/odd\"\n         , \"Natural/toInteger\"\n         , \"Natural/show\"\n-        , \"Natural/subtract\"\n-        , \"Integer\"\n-        , \"Integer/show\"\n         , \"Integer/toDouble\"\n-        , \"Double\"\n+        , \"Integer/show\"\n+        , \"Natural/subtract\"\n         , \"Double/show\"\n-        , \"Text\"\n-        , \"Text/show\"\n-        , \"List\"\n         , \"List/build\"\n         , \"List/fold\"\n         , \"List/length\"\n         , \"List/head\"\n         , \"List/last\"\n         , \"List/indexed\"\n         , \"List/reverse\"\n+        , \"Optional/fold\"\n+        , \"Optional/build\"\n+        , \"Text/show\"\n+        , \"Bool\"\n+        , \"True\"\n+        , \"False\"\n         , \"Optional\"\n-        , \"Some\"\n         , \"None\"\n-        , \"Optional/build\"\n-        , \"Optional/fold\"\n-        , \"NaN\"\n-        , \"Infinity\"\n+        , \"Natural\"\n+        , \"Integer\"\n+        , \"Double\"\n+        , \"Text\"\n+        , \"List\"\n+        , \"Type\"\n+        , \"Kind\"\n+        , \"Sort\"\n+\n+          -- Technically just an `operator`\n+        , \"forall\"","path":"dhall/src/Dhall/Syntax.hs","position":83,"original_position":83,"commit_id":"3a237c12fa8bf92e4af5712c5419ef17fcd09927","original_commit_id":"3a237c12fa8bf92e4af5712c5419ef17fcd09927","user":{"login":"Gabriel439","id":1313787,"node_id":"MDQ6VXNlcjEzMTM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1313787?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"body":"Yeah, I would have expected to see `forall` in the keyword section of the standard grammar (even for the Unicode version: `∀`), rather than the operator section.  Maybe the standard needs to be fixed","created_at":"2019-10-25T01:06:37Z","updated_at":"2019-10-25T01:07:17Z","html_url":"https://github.com/dhall-lang/dhall-haskell/pull/1473#discussion_r338850942","pull_request_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/comments/338850942"},"html":{"href":"https://github.com/dhall-lang/dhall-haskell/pull/1473#discussion_r338850942"},"pull_request":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473"}},"in_reply_to_id":338644561},"pull_request":{"url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473","id":332111713,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyMTExNzEz","html_url":"https://github.com/dhall-lang/dhall-haskell/pull/1473","diff_url":"https://github.com/dhall-lang/dhall-haskell/pull/1473.diff","patch_url":"https://github.com/dhall-lang/dhall-haskell/pull/1473.patch","issue_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/1473","number":1473,"state":"open","locked":false,"title":"Update reservedIdentifiers","user":{"login":"sjakobi","id":3664523,"node_id":"MDQ6VXNlcjM2NjQ1MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3664523?v=4","gravatar_id":"","url":"https://api.github.com/users/sjakobi","html_url":"https://github.com/sjakobi","followers_url":"https://api.github.com/users/sjakobi/followers","following_url":"https://api.github.com/users/sjakobi/following{/other_user}","gists_url":"https://api.github.com/users/sjakobi/gists{/gist_id}","starred_url":"https://api.github.com/users/sjakobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjakobi/subscriptions","organizations_url":"https://api.github.com/users/sjakobi/orgs","repos_url":"https://api.github.com/users/sjakobi/repos","events_url":"https://api.github.com/users/sjakobi/events{/privacy}","received_events_url":"https://api.github.com/users/sjakobi/received_events","type":"User","site_admin":false},"body":"* Add `missing` and `assert`\r\n* Reformat them to match the grammar","created_at":"2019-10-24T15:31:02Z","updated_at":"2019-10-25T01:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10d77a8f85977aef7a53cadb6fde10fb4e7ede6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473/commits","review_comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473/comments","review_comment_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/1473/comments","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/3a237c12fa8bf92e4af5712c5419ef17fcd09927","head":{"label":"dhall-lang:sjakobi/reserved-identifiers","ref":"sjakobi/reserved-identifiers","sha":"3a237c12fa8bf92e4af5712c5419ef17fcd09927","user":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":67623822,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYyMzgyMg==","name":"dhall-haskell","full_name":"dhall-lang/dhall-haskell","private":false,"owner":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dhall-lang/dhall-haskell","description":"The non-repetitive alternative to YAML","fork":false,"url":"https://api.github.com/repos/dhall-lang/dhall-haskell","forks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/forks","keys_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/teams","hooks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/hooks","issue_events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/events{/number}","events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/events","assignees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/assignees{/user}","branches_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/branches{/branch}","tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/tags","blobs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/languages","stargazers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/stargazers","contributors_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contributors","subscribers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscribers","subscription_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscription","commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contents/{+path}","compare_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/merges","archive_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/downloads","issues_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues{/number}","pulls_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/labels{/name}","releases_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/releases{/id}","deployments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/deployments","created_at":"2016-09-07T16:18:15Z","updated_at":"2019-10-24T15:19:13Z","pushed_at":"2019-10-24T15:34:21Z","git_url":"git://github.com/dhall-lang/dhall-haskell.git","ssh_url":"git@github.com:dhall-lang/dhall-haskell.git","clone_url":"https://github.com/dhall-lang/dhall-haskell.git","svn_url":"https://github.com/dhall-lang/dhall-haskell","homepage":"https://dhall-lang.org/","size":5037,"stargazers_count":538,"watchers_count":538,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":78,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":131,"open_issues":78,"watchers":538,"default_branch":"master"}},"base":{"label":"dhall-lang:master","ref":"master","sha":"90315e9eda862d70e01fd3c960854e7cddf3cc52","user":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":67623822,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYyMzgyMg==","name":"dhall-haskell","full_name":"dhall-lang/dhall-haskell","private":false,"owner":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dhall-lang/dhall-haskell","description":"The non-repetitive alternative to YAML","fork":false,"url":"https://api.github.com/repos/dhall-lang/dhall-haskell","forks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/forks","keys_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/teams","hooks_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/hooks","issue_events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/events{/number}","events_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/events","assignees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/assignees{/user}","branches_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/branches{/branch}","tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/tags","blobs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/{sha}","languages_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/languages","stargazers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/stargazers","contributors_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contributors","subscribers_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscribers","subscription_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/subscription","commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/contents/{+path}","compare_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/merges","archive_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/downloads","issues_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues{/number}","pulls_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls{/number}","milestones_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/milestones{/number}","notifications_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/labels{/name}","releases_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/releases{/id}","deployments_url":"https://api.github.com/repos/dhall-lang/dhall-haskell/deployments","created_at":"2016-09-07T16:18:15Z","updated_at":"2019-10-24T15:19:13Z","pushed_at":"2019-10-24T15:34:21Z","git_url":"git://github.com/dhall-lang/dhall-haskell.git","ssh_url":"git@github.com:dhall-lang/dhall-haskell.git","clone_url":"https://github.com/dhall-lang/dhall-haskell.git","svn_url":"https://github.com/dhall-lang/dhall-haskell","homepage":"https://dhall-lang.org/","size":5037,"stargazers_count":538,"watchers_count":538,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":78,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":131,"open_issues":78,"watchers":538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473"},"html":{"href":"https://github.com/dhall-lang/dhall-haskell/pull/1473"},"issue":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/1473"},"comments":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/issues/1473/comments"},"review_comments":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473/comments"},"review_comment":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/pulls/1473/commits"},"statuses":{"href":"https://api.github.com/repos/dhall-lang/dhall-haskell/statuses/3a237c12fa8bf92e4af5712c5419ef17fcd09927"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Gabriel439"}}