{"action":"created","issue":{"url":"https://api.github.com/repos/pixijs/pixi.js/issues/3304","repository_url":"https://api.github.com/repos/pixijs/pixi.js","labels_url":"https://api.github.com/repos/pixijs/pixi.js/issues/3304/labels{/name}","comments_url":"https://api.github.com/repos/pixijs/pixi.js/issues/3304/comments","events_url":"https://api.github.com/repos/pixijs/pixi.js/issues/3304/events","html_url":"https://github.com/pixijs/pixi.js/pull/3304","id":189879272,"node_id":"MDExOlB1bGxSZXF1ZXN0OTQwNzA1ODg=","number":3304,"title":"Dev geometry update","user":{"login":"GoodBoyDigital","id":3112434,"node_id":"MDQ6VXNlcjMxMTI0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3112434?v=4","gravatar_id":"","url":"https://api.github.com/users/GoodBoyDigital","html_url":"https://github.com/GoodBoyDigital","followers_url":"https://api.github.com/users/GoodBoyDigital/followers","following_url":"https://api.github.com/users/GoodBoyDigital/following{/other_user}","gists_url":"https://api.github.com/users/GoodBoyDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/GoodBoyDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoodBoyDigital/subscriptions","organizations_url":"https://api.github.com/users/GoodBoyDigital/orgs","repos_url":"https://api.github.com/users/GoodBoyDigital/repos","events_url":"https://api.github.com/users/GoodBoyDigital/events{/privacy}","received_events_url":"https://api.github.com/users/GoodBoyDigital/received_events","type":"User","site_admin":false},"labels":[{"id":447637098,"node_id":"MDU6TGFiZWw0NDc2MzcwOTg=","url":"https://api.github.com/repos/pixijs/pixi.js/labels/Difficulty:%20Hard","name":"Difficulty: Hard","color":"d93f0b","default":false},{"id":514146794,"node_id":"MDU6TGFiZWw1MTQxNDY3OTQ=","url":"https://api.github.com/repos/pixijs/pixi.js/labels/Domain:%20Performance","name":"Domain: Performance","color":"006b75","default":false},{"id":447645392,"node_id":"MDU6TGFiZWw0NDc2NDUzOTI=","url":"https://api.github.com/repos/pixijs/pixi.js/labels/PR:%20Needs%20Review","name":"PR: Needs Review","color":"e99695","default":false},{"id":434340185,"node_id":"MDU6TGFiZWw0MzQzNDAxODU=","url":"https://api.github.com/repos/pixijs/pixi.js/labels/Priority:%20High","name":"Priority: High","color":"d93f0b","default":false},{"id":447641543,"node_id":"MDU6TGFiZWw0NDc2NDE1NDM=","url":"https://api.github.com/repos/pixijs/pixi.js/labels/Type:%20Refactor","name":"Type: Refactor","color":"35AE58","default":false},{"id":447633425,"node_id":"MDU6TGFiZWw0NDc2MzM0MjU=","url":"https://api.github.com/repos/pixijs/pixi.js/labels/Version:%20v4.x","name":"Version: v4.x","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pixijs/pixi.js/milestones/12","html_url":"https://github.com/pixijs/pixi.js/milestone/12","labels_url":"https://api.github.com/repos/pixijs/pixi.js/milestones/12/labels","id":2324587,"node_id":"MDk6TWlsZXN0b25lMjMyNDU4Nw==","number":12,"title":"v4.5","description":"New features","creator":{"login":"bigtimebuddy","id":864393,"node_id":"MDQ6VXNlcjg2NDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/864393?v=4","gravatar_id":"","url":"https://api.github.com/users/bigtimebuddy","html_url":"https://github.com/bigtimebuddy","followers_url":"https://api.github.com/users/bigtimebuddy/followers","following_url":"https://api.github.com/users/bigtimebuddy/following{/other_user}","gists_url":"https://api.github.com/users/bigtimebuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bigtimebuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigtimebuddy/subscriptions","organizations_url":"https://api.github.com/users/bigtimebuddy/orgs","repos_url":"https://api.github.com/users/bigtimebuddy/repos","events_url":"https://api.github.com/users/bigtimebuddy/events{/privacy}","received_events_url":"https://api.github.com/users/bigtimebuddy/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":11,"state":"closed","created_at":"2017-02-15T15:22:06Z","updated_at":"2017-04-19T12:12:39Z","due_on":"2017-04-13T07:00:00Z","closed_at":"2017-04-19T12:12:39Z"},"comments":8,"created_at":"2016-11-16T23:12:26Z","updated_at":"2019-02-24T06:35:29Z","closed_at":"2017-04-12T12:15:33Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pixijs/pixi.js/pulls/3304","html_url":"https://github.com/pixijs/pixi.js/pull/3304","diff_url":"https://github.com/pixijs/pixi.js/pull/3304.diff","patch_url":"https://github.com/pixijs/pixi.js/pull/3304.patch"},"body":"A sneaky peak at the mesh restructure I have been playing around with.\r\n\r\nMain changes to so far:\r\n\r\n## Shaders\r\n- Refactored Shader to be a Pixi level Object. Added a shader manager that deals with creating shaders and binding them\r\n- Added a caching layer. BUT I think this needs looking at as underneath the hood I think they should share a GLShader.\r\n- Filter now extends Shader\r\n\r\n## Mesh\r\n- Now expects 3 params (geometry, shader, draw style)\r\n\r\n## Geometry\r\n- Geometry is kind of an abstract VAO. It is built up of GeometryData and GeometryStyle \r\n\r\n## GeometryData \r\n- Contains the Buffers\r\n\r\n## GeometryStyle\r\n- Describes the structure of the geometry and how the data is used.\r\n\r\n## Buffer\r\n- A abstract wrapper for a GLBuffer\r\n\r\nThe above should enable us a tonne of flexibility to create custom ways to render whatever we want using a nice clean API! This can also act as a base for some of our other elements such as tilingSprite\r\n\r\nActions speak louder than words:\r\nhttp://dev.goodboydigital.com/client/goodboy/pixi-geometry/\r\nMake sure to view source!\r\n\r\n## Stuff still left to Do\r\n- Shaders information should be pulled out from a program not the src code\r\n- Create a default geometry style (position, uvs, tint)\r\n- Plane / Rope will need a little refactoring\r\n- Need a nice way to deal with other gl states e.g. DepthTest (do they sit on shader?)\r\n\r\nAll feedback welcome at this stage!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pixijs/pixi.js/issues/comments/466739131","html_url":"https://github.com/pixijs/pixi.js/pull/3304#issuecomment-466739131","issue_url":"https://api.github.com/repos/pixijs/pixi.js/issues/3304","id":466739131,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NjczOTEzMQ==","user":{"login":"lock[bot]","id":33595554,"node_id":"MDM6Qm90MzM1OTU1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-02-24T06:35:29Z","updated_at":"2019-02-24T06:35:29Z","author_association":"NONE","body":"This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs."}}
{"actor":{"display_login":"lock"}}