{"action":"created","comment":{"url":"https://api.github.com/repos/OriginProtocol/origin/pulls/comments/256561902","pull_request_review_id":203413758,"id":256561902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NjU2MTkwMg==","diff_hunk":"@@ -77,7 +77,10 @@ export default function txHelper({\n         })\n         if (contracts.automine) {\n           setTimeout(() => {\n-            contracts.web3Exec.currentProvider.send(\n+            // This needs to be sendAsync, because the provider engine used for\n+            // the mobile wallet linker client doesn't support synchronous\n+            // transactions.\n+            contracts.web3.currentProvider.send(","path":"experimental/origin-graphql/src/mutations/_txHelper.js","position":8,"original_position":8,"commit_id":"cf54d23c55f99796e7fdbd97fc6cef938aba605f","original_commit_id":"cf54d23c55f99796e7fdbd97fc6cef938aba605f","user":{"login":"cuongdo","id":1564582,"node_id":"MDQ6VXNlcjE1NjQ1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1564582?v=4","gravatar_id":"","url":"https://api.github.com/users/cuongdo","html_url":"https://github.com/cuongdo","followers_url":"https://api.github.com/users/cuongdo/followers","following_url":"https://api.github.com/users/cuongdo/following{/other_user}","gists_url":"https://api.github.com/users/cuongdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cuongdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuongdo/subscriptions","organizations_url":"https://api.github.com/users/cuongdo/orgs","repos_url":"https://api.github.com/users/cuongdo/repos","events_url":"https://api.github.com/users/cuongdo/events{/privacy}","received_events_url":"https://api.github.com/users/cuongdo/received_events","type":"User","site_admin":false},"body":"That's fine, because I changed `web3Exec` to `web3`. The issue we discussed was that the `WalletLinkerClient`'s web3 provider doesn't support synchronous sends. Switching to `contracts.web3` allows us to keep using `send`.","created_at":"2019-02-13T19:51:35Z","updated_at":"2019-02-13T19:51:38Z","html_url":"https://github.com/OriginProtocol/origin/pull/1461#discussion_r256561902","pull_request_url":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OriginProtocol/origin/pulls/comments/256561902"},"html":{"href":"https://github.com/OriginProtocol/origin/pull/1461#discussion_r256561902"},"pull_request":{"href":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461"}},"in_reply_to_id":256515943},"pull_request":{"url":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461","id":252548889,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyNTQ4ODg5","html_url":"https://github.com/OriginProtocol/origin/pull/1461","diff_url":"https://github.com/OriginProtocol/origin/pull/1461.diff","patch_url":"https://github.com/OriginProtocol/origin/pull/1461.patch","issue_url":"https://api.github.com/repos/OriginProtocol/origin/issues/1461","number":1461,"state":"open","locked":false,"title":"Mobile wallet linker support for dapp2","user":{"login":"cuongdo","id":1564582,"node_id":"MDQ6VXNlcjE1NjQ1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1564582?v=4","gravatar_id":"","url":"https://api.github.com/users/cuongdo","html_url":"https://github.com/cuongdo","followers_url":"https://api.github.com/users/cuongdo/followers","following_url":"https://api.github.com/users/cuongdo/following{/other_user}","gists_url":"https://api.github.com/users/cuongdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cuongdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuongdo/subscriptions","organizations_url":"https://api.github.com/users/cuongdo/orgs","repos_url":"https://api.github.com/users/cuongdo/repos","events_url":"https://api.github.com/users/cuongdo/events{/privacy}","received_events_url":"https://api.github.com/users/cuongdo/received_events","type":"User","site_admin":false},"body":"This introduces a linker client to the origin-graphql layer, which\r\nimplements a web3 provider that routes web3 transactions to the linking\r\nserver. The linking server then forwards the transactions to the mobile\r\nwallet, where they are signed and sent.\r\n\r\nThere are probably various broken things about this change, but we\r\nshould fix the more minor issues in separate PRs to avoid bloating this\r\nchange further.\r\n\r\nThis also include changes to the default ports:\r\n- dapp2: 3001 -> 3000\r\n- admin: 3000 -> 3001\r\n- ipfs: 9090 -> 8080\r\n\r\nThis makes it much easier for the wallet app code (which relies on origin.js)\r\nto interact with the graphql code.\r\n\r\n### Description:\r\n\r\nPlease explain the changes you made here:\r\n\r\n- A description of the problem you're trying to solve\r\n- An overview of the suggested solution\r\n- If the feature changes current behavior, reasons why your solution is better\r\n\r\n### Checklist:\r\n\r\n- [x] Test your work and double-check to confirm that you didn't break anything\r\n- [ ] Wrap any displayed ETH addresses with [`formattedAddress`](https://github.com/OriginProtocol/origin/blob/master/origin-dapp/src/utils/user.js#L15-L17)\r\n- [ ] Wrap any new text/strings for translation\r\n- [ ] Run `npm run translations` if there are any changes to translated strings\r\n- [ ] Map any new environment variables with a default value in the Webpack config\r\n- [x] Update any relevant READMEs and [docs](https://github.com/OriginProtocol/origin/tree/master/origin-docs)\r\n","created_at":"2019-02-13T03:24:07Z","updated_at":"2019-02-13T19:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b4695af926364c1c2eee8da3c5b2ebfcfece62d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461/commits","review_comments_url":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461/comments","review_comment_url":"https://api.github.com/repos/OriginProtocol/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OriginProtocol/origin/issues/1461/comments","statuses_url":"https://api.github.com/repos/OriginProtocol/origin/statuses/cf54d23c55f99796e7fdbd97fc6cef938aba605f","head":{"label":"OriginProtocol:cuongdo/dapp2-mobile","ref":"cuongdo/dapp2-mobile","sha":"cf54d23c55f99796e7fdbd97fc6cef938aba605f","user":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":99047066,"node_id":"MDEwOlJlcG9zaXRvcnk5OTA0NzA2Ng==","name":"origin","full_name":"OriginProtocol/origin","private":false,"owner":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OriginProtocol/origin","description":"Monorepo for our developer tools and decentralized marketplace application","fork":false,"url":"https://api.github.com/repos/OriginProtocol/origin","forks_url":"https://api.github.com/repos/OriginProtocol/origin/forks","keys_url":"https://api.github.com/repos/OriginProtocol/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OriginProtocol/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OriginProtocol/origin/teams","hooks_url":"https://api.github.com/repos/OriginProtocol/origin/hooks","issue_events_url":"https://api.github.com/repos/OriginProtocol/origin/issues/events{/number}","events_url":"https://api.github.com/repos/OriginProtocol/origin/events","assignees_url":"https://api.github.com/repos/OriginProtocol/origin/assignees{/user}","branches_url":"https://api.github.com/repos/OriginProtocol/origin/branches{/branch}","tags_url":"https://api.github.com/repos/OriginProtocol/origin/tags","blobs_url":"https://api.github.com/repos/OriginProtocol/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OriginProtocol/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OriginProtocol/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/OriginProtocol/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OriginProtocol/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/OriginProtocol/origin/languages","stargazers_url":"https://api.github.com/repos/OriginProtocol/origin/stargazers","contributors_url":"https://api.github.com/repos/OriginProtocol/origin/contributors","subscribers_url":"https://api.github.com/repos/OriginProtocol/origin/subscribers","subscription_url":"https://api.github.com/repos/OriginProtocol/origin/subscription","commits_url":"https://api.github.com/repos/OriginProtocol/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/OriginProtocol/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/OriginProtocol/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/OriginProtocol/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/OriginProtocol/origin/contents/{+path}","compare_url":"https://api.github.com/repos/OriginProtocol/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OriginProtocol/origin/merges","archive_url":"https://api.github.com/repos/OriginProtocol/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OriginProtocol/origin/downloads","issues_url":"https://api.github.com/repos/OriginProtocol/origin/issues{/number}","pulls_url":"https://api.github.com/repos/OriginProtocol/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/OriginProtocol/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/OriginProtocol/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OriginProtocol/origin/labels{/name}","releases_url":"https://api.github.com/repos/OriginProtocol/origin/releases{/id}","deployments_url":"https://api.github.com/repos/OriginProtocol/origin/deployments","created_at":"2017-08-01T22:06:57Z","updated_at":"2019-02-13T18:51:07Z","pushed_at":"2019-02-13T19:20:39Z","git_url":"git://github.com/OriginProtocol/origin.git","ssh_url":"git@github.com:OriginProtocol/origin.git","clone_url":"https://github.com/OriginProtocol/origin.git","svn_url":"https://github.com/OriginProtocol/origin","homepage":"https://www.originprotocol.com/developers","size":103346,"stargazers_count":400,"watchers_count":400,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":130,"open_issues":228,"watchers":400,"default_branch":"master"}},"base":{"label":"OriginProtocol:master","ref":"master","sha":"6fb3c56bf687e6c7b87ade44a95ab41e966cdf33","user":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":99047066,"node_id":"MDEwOlJlcG9zaXRvcnk5OTA0NzA2Ng==","name":"origin","full_name":"OriginProtocol/origin","private":false,"owner":{"login":"OriginProtocol","id":30638653,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjM4NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OriginProtocol/origin","description":"Monorepo for our developer tools and decentralized marketplace application","fork":false,"url":"https://api.github.com/repos/OriginProtocol/origin","forks_url":"https://api.github.com/repos/OriginProtocol/origin/forks","keys_url":"https://api.github.com/repos/OriginProtocol/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OriginProtocol/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OriginProtocol/origin/teams","hooks_url":"https://api.github.com/repos/OriginProtocol/origin/hooks","issue_events_url":"https://api.github.com/repos/OriginProtocol/origin/issues/events{/number}","events_url":"https://api.github.com/repos/OriginProtocol/origin/events","assignees_url":"https://api.github.com/repos/OriginProtocol/origin/assignees{/user}","branches_url":"https://api.github.com/repos/OriginProtocol/origin/branches{/branch}","tags_url":"https://api.github.com/repos/OriginProtocol/origin/tags","blobs_url":"https://api.github.com/repos/OriginProtocol/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OriginProtocol/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OriginProtocol/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/OriginProtocol/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OriginProtocol/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/OriginProtocol/origin/languages","stargazers_url":"https://api.github.com/repos/OriginProtocol/origin/stargazers","contributors_url":"https://api.github.com/repos/OriginProtocol/origin/contributors","subscribers_url":"https://api.github.com/repos/OriginProtocol/origin/subscribers","subscription_url":"https://api.github.com/repos/OriginProtocol/origin/subscription","commits_url":"https://api.github.com/repos/OriginProtocol/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/OriginProtocol/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/OriginProtocol/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/OriginProtocol/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/OriginProtocol/origin/contents/{+path}","compare_url":"https://api.github.com/repos/OriginProtocol/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OriginProtocol/origin/merges","archive_url":"https://api.github.com/repos/OriginProtocol/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OriginProtocol/origin/downloads","issues_url":"https://api.github.com/repos/OriginProtocol/origin/issues{/number}","pulls_url":"https://api.github.com/repos/OriginProtocol/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/OriginProtocol/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/OriginProtocol/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OriginProtocol/origin/labels{/name}","releases_url":"https://api.github.com/repos/OriginProtocol/origin/releases{/id}","deployments_url":"https://api.github.com/repos/OriginProtocol/origin/deployments","created_at":"2017-08-01T22:06:57Z","updated_at":"2019-02-13T18:51:07Z","pushed_at":"2019-02-13T19:20:39Z","git_url":"git://github.com/OriginProtocol/origin.git","ssh_url":"git@github.com:OriginProtocol/origin.git","clone_url":"https://github.com/OriginProtocol/origin.git","svn_url":"https://github.com/OriginProtocol/origin","homepage":"https://www.originprotocol.com/developers","size":103346,"stargazers_count":400,"watchers_count":400,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":130,"open_issues":228,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461"},"html":{"href":"https://github.com/OriginProtocol/origin/pull/1461"},"issue":{"href":"https://api.github.com/repos/OriginProtocol/origin/issues/1461"},"comments":{"href":"https://api.github.com/repos/OriginProtocol/origin/issues/1461/comments"},"review_comments":{"href":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461/comments"},"review_comment":{"href":"https://api.github.com/repos/OriginProtocol/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OriginProtocol/origin/pulls/1461/commits"},"statuses":{"href":"https://api.github.com/repos/OriginProtocol/origin/statuses/cf54d23c55f99796e7fdbd97fc6cef938aba605f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cuongdo"}}