{"action":"created","comment":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments/334666124","pull_request_review_id":301544609,"id":334666124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDY2NjEyNA==","diff_hunk":"@@ -74,3 +74,10 @@ export const SUPPORTED_HOOKS = [\n     'beforeFeature', 'beforeScenario', 'beforeStep', 'afterStep', 'afterScenario', 'afterFeature',\n     'onReload', 'onPrepare', 'onComplete'\n ]\n+\n+/**\n+ * these services should not be started in worker process\n+ */\n+export const NON_WORKER_SERVICES = [","path":"packages/wdio-config/src/constants.js","position":8,"original_position":8,"commit_id":"0c2b4fa85c681703c7d91702f5242a29f5a7d6cb","original_commit_id":"0c2b4fa85c681703c7d91702f5242a29f5a7d6cb","user":{"login":"mgrybyk","id":25589559,"node_id":"MDQ6VXNlcjI1NTg5NTU5","avatar_url":"https://avatars3.githubusercontent.com/u/25589559?v=4","gravatar_id":"","url":"https://api.github.com/users/mgrybyk","html_url":"https://github.com/mgrybyk","followers_url":"https://api.github.com/users/mgrybyk/followers","following_url":"https://api.github.com/users/mgrybyk/following{/other_user}","gists_url":"https://api.github.com/users/mgrybyk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrybyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrybyk/subscriptions","organizations_url":"https://api.github.com/users/mgrybyk/orgs","repos_url":"https://api.github.com/users/mgrybyk/repos","events_url":"https://api.github.com/users/mgrybyk/events{/privacy}","received_events_url":"https://api.github.com/users/mgrybyk/received_events","type":"User","site_admin":false},"body":"Not sure how to achieve that. I mean we can check everything after requiring the launcher, however the goal is to avoid importing services so that they won't load any modules, as a result I can't import launcher. \r\n\r\nMaybe in v6 we can change the way how services are loaded?\r\n","created_at":"2019-10-14T21:16:12Z","updated_at":"2019-10-14T21:16:12Z","html_url":"https://github.com/webdriverio/webdriverio/pull/4623#discussion_r334666124","pull_request_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments/334666124"},"html":{"href":"https://github.com/webdriverio/webdriverio/pull/4623#discussion_r334666124"},"pull_request":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623"}},"in_reply_to_id":334642869},"pull_request":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623","id":327941465,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3OTQxNDY1","html_url":"https://github.com/webdriverio/webdriverio/pull/4623","diff_url":"https://github.com/webdriverio/webdriverio/pull/4623.diff","patch_url":"https://github.com/webdriverio/webdriverio/pull/4623.patch","issue_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/4623","number":4623,"state":"open","locked":false,"title":"Filter services that should not run in worker process","user":{"login":"mgrybyk","id":25589559,"node_id":"MDQ6VXNlcjI1NTg5NTU5","avatar_url":"https://avatars3.githubusercontent.com/u/25589559?v=4","gravatar_id":"","url":"https://api.github.com/users/mgrybyk","html_url":"https://github.com/mgrybyk","followers_url":"https://api.github.com/users/mgrybyk/followers","following_url":"https://api.github.com/users/mgrybyk/following{/other_user}","gists_url":"https://api.github.com/users/mgrybyk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrybyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrybyk/subscriptions","organizations_url":"https://api.github.com/users/mgrybyk/orgs","repos_url":"https://api.github.com/users/mgrybyk/repos","events_url":"https://api.github.com/users/mgrybyk/events{/privacy}","received_events_url":"https://api.github.com/users/mgrybyk/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\navoid starting `'chromedriver', 'selenium-standalone', 'appium', 'reportportal', 'firefox-profile'` services in worker process\r\n\r\n#4615 \r\n\r\n## Types of changes\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Documentation update\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\n### Reviewers: @webdriverio/technical-committee\r\n","created_at":"2019-10-14T19:29:21Z","updated_at":"2019-10-14T21:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef606105209524c4a4ceb1d89aeba6cdeefb19a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1159686036,"node_id":"MDU6TGFiZWwxMTU5Njg2MDM2","url":"https://api.github.com/repos/webdriverio/webdriverio/labels/PR:%20Polish%20:nail_care:","name":"PR: Polish :nail_care:","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623/commits","review_comments_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623/comments","review_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/4623/comments","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/0c2b4fa85c681703c7d91702f5242a29f5a7d6cb","head":{"label":"mgrybyk:filter-services-for-worker","ref":"filter-services-for-worker","sha":"0c2b4fa85c681703c7d91702f5242a29f5a7d6cb","user":{"login":"mgrybyk","id":25589559,"node_id":"MDQ6VXNlcjI1NTg5NTU5","avatar_url":"https://avatars3.githubusercontent.com/u/25589559?v=4","gravatar_id":"","url":"https://api.github.com/users/mgrybyk","html_url":"https://github.com/mgrybyk","followers_url":"https://api.github.com/users/mgrybyk/followers","following_url":"https://api.github.com/users/mgrybyk/following{/other_user}","gists_url":"https://api.github.com/users/mgrybyk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrybyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrybyk/subscriptions","organizations_url":"https://api.github.com/users/mgrybyk/orgs","repos_url":"https://api.github.com/users/mgrybyk/repos","events_url":"https://api.github.com/users/mgrybyk/events{/privacy}","received_events_url":"https://api.github.com/users/mgrybyk/received_events","type":"User","site_admin":false},"repo":{"id":168234213,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgyMzQyMTM=","name":"webdriverio","full_name":"mgrybyk/webdriverio","private":false,"owner":{"login":"mgrybyk","id":25589559,"node_id":"MDQ6VXNlcjI1NTg5NTU5","avatar_url":"https://avatars3.githubusercontent.com/u/25589559?v=4","gravatar_id":"","url":"https://api.github.com/users/mgrybyk","html_url":"https://github.com/mgrybyk","followers_url":"https://api.github.com/users/mgrybyk/followers","following_url":"https://api.github.com/users/mgrybyk/following{/other_user}","gists_url":"https://api.github.com/users/mgrybyk/gists{/gist_id}","starred_url":"https://api.github.com/users/mgrybyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgrybyk/subscriptions","organizations_url":"https://api.github.com/users/mgrybyk/orgs","repos_url":"https://api.github.com/users/mgrybyk/repos","events_url":"https://api.github.com/users/mgrybyk/events{/privacy}","received_events_url":"https://api.github.com/users/mgrybyk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mgrybyk/webdriverio","description":"https://github.com/webdriverio/webdriverio FORK","fork":true,"url":"https://api.github.com/repos/mgrybyk/webdriverio","forks_url":"https://api.github.com/repos/mgrybyk/webdriverio/forks","keys_url":"https://api.github.com/repos/mgrybyk/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgrybyk/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgrybyk/webdriverio/teams","hooks_url":"https://api.github.com/repos/mgrybyk/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/mgrybyk/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/mgrybyk/webdriverio/events","assignees_url":"https://api.github.com/repos/mgrybyk/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/mgrybyk/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/mgrybyk/webdriverio/tags","blobs_url":"https://api.github.com/repos/mgrybyk/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgrybyk/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgrybyk/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgrybyk/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgrybyk/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/mgrybyk/webdriverio/languages","stargazers_url":"https://api.github.com/repos/mgrybyk/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/mgrybyk/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/mgrybyk/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/mgrybyk/webdriverio/subscription","commits_url":"https://api.github.com/repos/mgrybyk/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgrybyk/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgrybyk/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgrybyk/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgrybyk/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/mgrybyk/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgrybyk/webdriverio/merges","archive_url":"https://api.github.com/repos/mgrybyk/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgrybyk/webdriverio/downloads","issues_url":"https://api.github.com/repos/mgrybyk/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/mgrybyk/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/mgrybyk/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/mgrybyk/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgrybyk/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/mgrybyk/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/mgrybyk/webdriverio/deployments","created_at":"2019-01-29T21:45:25Z","updated_at":"2019-10-14T18:05:39Z","pushed_at":"2019-10-14T19:26:23Z","git_url":"git://github.com/mgrybyk/webdriverio.git","ssh_url":"git@github.com:mgrybyk/webdriverio.git","clone_url":"https://github.com/mgrybyk/webdriverio.git","svn_url":"https://github.com/mgrybyk/webdriverio","homepage":"http://webdriver.io","size":14497,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webdriverio:master","ref":"master","sha":"175939dcf425e96be35fccf7d26ca702a7019cbe","user":{"login":"webdriverio","id":6512473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTI0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"repo":{"id":2296970,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2OTcw","name":"webdriverio","full_name":"webdriverio/webdriverio","private":false,"owner":{"login":"webdriverio","id":6512473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTI0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webdriverio/webdriverio","description":"Next-gen WebDriver test automation framework for Node.js","fork":false,"url":"https://api.github.com/repos/webdriverio/webdriverio","forks_url":"https://api.github.com/repos/webdriverio/webdriverio/forks","keys_url":"https://api.github.com/repos/webdriverio/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdriverio/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdriverio/webdriverio/teams","hooks_url":"https://api.github.com/repos/webdriverio/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/webdriverio/webdriverio/events","assignees_url":"https://api.github.com/repos/webdriverio/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/webdriverio/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/webdriverio/webdriverio/tags","blobs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdriverio/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdriverio/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/webdriverio/webdriverio/languages","stargazers_url":"https://api.github.com/repos/webdriverio/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/webdriverio/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/webdriverio/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/webdriverio/webdriverio/subscription","commits_url":"https://api.github.com/repos/webdriverio/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdriverio/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdriverio/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/webdriverio/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdriverio/webdriverio/merges","archive_url":"https://api.github.com/repos/webdriverio/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdriverio/webdriverio/downloads","issues_url":"https://api.github.com/repos/webdriverio/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/webdriverio/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/webdriverio/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/webdriverio/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/webdriverio/webdriverio/deployments","created_at":"2011-08-30T19:02:35Z","updated_at":"2019-10-14T12:56:48Z","pushed_at":"2019-10-14T19:29:22Z","git_url":"git://github.com/webdriverio/webdriverio.git","ssh_url":"git@github.com:webdriverio/webdriverio.git","clone_url":"https://github.com/webdriverio/webdriverio.git","svn_url":"https://github.com/webdriverio/webdriverio","homepage":"http://webdriver.io","size":14709,"stargazers_count":5250,"watchers_count":5250,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1512,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":90,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1512,"open_issues":90,"watchers":5250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623"},"html":{"href":"https://github.com/webdriverio/webdriverio/pull/4623"},"issue":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/4623"},"comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/4623/comments"},"review_comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623/comments"},"review_comment":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/4623/commits"},"statuses":{"href":"https://api.github.com/repos/webdriverio/webdriverio/statuses/0c2b4fa85c681703c7d91702f5242a29f5a7d6cb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mgrybyk"}}