{"action":"created","issue":{"url":"https://api.github.com/repos/tgriesser/knex/issues/3189","repository_url":"https://api.github.com/repos/tgriesser/knex","labels_url":"https://api.github.com/repos/tgriesser/knex/issues/3189/labels{/name}","comments_url":"https://api.github.com/repos/tgriesser/knex/issues/3189/comments","events_url":"https://api.github.com/repos/tgriesser/knex/issues/3189/events","html_url":"https://github.com/tgriesser/knex/pull/3189","id":443078418,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MDM2NjU0","number":3189,"title":"Fix backward-incompatibility in type definitions","user":{"login":"lorefnon","id":1449492,"node_id":"MDQ6VXNlcjE0NDk0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1449492?v=4","gravatar_id":"","url":"https://api.github.com/users/lorefnon","html_url":"https://github.com/lorefnon","followers_url":"https://api.github.com/users/lorefnon/followers","following_url":"https://api.github.com/users/lorefnon/following{/other_user}","gists_url":"https://api.github.com/users/lorefnon/gists{/gist_id}","starred_url":"https://api.github.com/users/lorefnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorefnon/subscriptions","organizations_url":"https://api.github.com/users/lorefnon/orgs","repos_url":"https://api.github.com/users/lorefnon/repos","events_url":"https://api.github.com/users/lorefnon/events{/privacy}","received_events_url":"https://api.github.com/users/lorefnon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-05-12T08:21:53Z","updated_at":"2019-05-12T08:23:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tgriesser/knex/pulls/3189","html_url":"https://github.com/tgriesser/knex/pull/3189","diff_url":"https://github.com/tgriesser/knex/pull/3189.diff","patch_url":"https://github.com/tgriesser/knex/pull/3189.patch"},"body":"Changes in https://github.com/tgriesser/knex/pull/3168 introduces  backward incompatibility causing some other type definitions on DefinitivelyTyped to break when used with latest Knex. \r\n\r\nThis PR (tested with all the external type definitions in DefinitivelyTyped having knex as dependency) addresses them by: \r\n\r\n- Adding defaults for parameters of all exposed types which are now generic\r\n- Allowing query builders to be used as select arguments (to accomodate as usage).\r\n"},"comment":{"url":"https://api.github.com/repos/tgriesser/knex/issues/comments/491575604","html_url":"https://github.com/tgriesser/knex/pull/3189#issuecomment-491575604","issue_url":"https://api.github.com/repos/tgriesser/knex/issues/3189","id":491575604,"node_id":"MDEyOklzc3VlQ29tbWVudDQ5MTU3NTYwNA==","user":{"login":"kibertoad","id":1847934,"node_id":"MDQ6VXNlcjE4NDc5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1847934?v=4","gravatar_id":"","url":"https://api.github.com/users/kibertoad","html_url":"https://github.com/kibertoad","followers_url":"https://api.github.com/users/kibertoad/followers","following_url":"https://api.github.com/users/kibertoad/following{/other_user}","gists_url":"https://api.github.com/users/kibertoad/gists{/gist_id}","starred_url":"https://api.github.com/users/kibertoad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kibertoad/subscriptions","organizations_url":"https://api.github.com/users/kibertoad/orgs","repos_url":"https://api.github.com/users/kibertoad/repos","events_url":"https://api.github.com/users/kibertoad/events{/privacy}","received_events_url":"https://api.github.com/users/kibertoad/received_events","type":"User","site_admin":false},"created_at":"2019-05-12T08:23:11Z","updated_at":"2019-05-12T08:23:11Z","author_association":"COLLABORATOR","body":"Shoud dtslint tests be updated? "}}
{"actor":{"display_login":"kibertoad"}}