{"action":"created","issue":{"url":"https://api.github.com/repos/coatue-oss/react2angular/issues/98","repository_url":"https://api.github.com/repos/coatue-oss/react2angular","labels_url":"https://api.github.com/repos/coatue-oss/react2angular/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/coatue-oss/react2angular/issues/98/comments","events_url":"https://api.github.com/repos/coatue-oss/react2angular/issues/98/events","html_url":"https://github.com/coatue-oss/react2angular/pull/98","id":406071932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5ODY3MDM3","number":98,"title":"Component will not call render after it has been unmounted","user":{"login":"ttsahi","id":5300328,"node_id":"MDQ6VXNlcjUzMDAzMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/5300328?v=4","gravatar_id":"","url":"https://api.github.com/users/ttsahi","html_url":"https://github.com/ttsahi","followers_url":"https://api.github.com/users/ttsahi/followers","following_url":"https://api.github.com/users/ttsahi/following{/other_user}","gists_url":"https://api.github.com/users/ttsahi/gists{/gist_id}","starred_url":"https://api.github.com/users/ttsahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttsahi/subscriptions","organizations_url":"https://api.github.com/users/ttsahi/orgs","repos_url":"https://api.github.com/users/ttsahi/repos","events_url":"https://api.github.com/users/ttsahi/events{/privacy}","received_events_url":"https://api.github.com/users/ttsahi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-02-03T09:58:22Z","updated_at":"2019-02-25T05:56:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/coatue-oss/react2angular/pulls/98","html_url":"https://github.com/coatue-oss/react2angular/pull/98","diff_url":"https://github.com/coatue-oss/react2angular/pull/98.diff","patch_url":"https://github.com/coatue-oss/react2angular/pull/98.patch"},"body":"We had a bug using this library when the angular onChanges hook was called after the component was already destroyed. When onChange occurs it calls render on the element. So, if an onChange occurs after an element is destroyed, the whole element is created again for no reason. Each time this happens it will add an element to the Dom with no reference. These are detached Dom nodes which won't be deleted and create a memory leak.\r\n\r\nWe added a simple fix which stops the render function creating an element after the component was unmounted. We wanted to add a test to prove this, but it seems that the library hasn't been updated in a while and none of the tests currently run. We saw this fix works for our project and would be happy to add our test after the library is fixed."},"comment":{"url":"https://api.github.com/repos/coatue-oss/react2angular/issues/comments/466881589","html_url":"https://github.com/coatue-oss/react2angular/pull/98#issuecomment-466881589","issue_url":"https://api.github.com/repos/coatue-oss/react2angular/issues/98","id":466881589,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2Njg4MTU4OQ==","user":{"login":"ttsahi","id":5300328,"node_id":"MDQ6VXNlcjUzMDAzMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/5300328?v=4","gravatar_id":"","url":"https://api.github.com/users/ttsahi","html_url":"https://github.com/ttsahi","followers_url":"https://api.github.com/users/ttsahi/followers","following_url":"https://api.github.com/users/ttsahi/following{/other_user}","gists_url":"https://api.github.com/users/ttsahi/gists{/gist_id}","starred_url":"https://api.github.com/users/ttsahi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttsahi/subscriptions","organizations_url":"https://api.github.com/users/ttsahi/orgs","repos_url":"https://api.github.com/users/ttsahi/repos","events_url":"https://api.github.com/users/ttsahi/events{/privacy}","received_events_url":"https://api.github.com/users/ttsahi/received_events","type":"User","site_admin":false},"created_at":"2019-02-25T05:56:14Z","updated_at":"2019-02-25T05:56:14Z","author_association":"NONE","body":"Hey @bcherny, I fixed the issues and think we're ready for a pull request review."}}
{"actor":{"display_login":"ttsahi"}}