{"action":"opened","number":801,"pull_request":{"url":"https://api.github.com/repos/ndmitchell/hlint/pulls/801","id":347256155,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjU2MTU1","html_url":"https://github.com/ndmitchell/hlint/pull/801","diff_url":"https://github.com/ndmitchell/hlint/pull/801.diff","patch_url":"https://github.com/ndmitchell/hlint/pull/801.patch","issue_url":"https://api.github.com/repos/ndmitchell/hlint/issues/801","number":801,"state":"open","locked":false,"title":"Debug match","user":{"login":"shayne-fletcher-da","id":41306216,"node_id":"MDQ6VXNlcjQxMzA2MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/41306216?v=4","gravatar_id":"","url":"https://api.github.com/users/shayne-fletcher-da","html_url":"https://github.com/shayne-fletcher-da","followers_url":"https://api.github.com/users/shayne-fletcher-da/followers","following_url":"https://api.github.com/users/shayne-fletcher-da/following{/other_user}","gists_url":"https://api.github.com/users/shayne-fletcher-da/gists{/gist_id}","starred_url":"https://api.github.com/users/shayne-fletcher-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayne-fletcher-da/subscriptions","organizations_url":"https://api.github.com/users/shayne-fletcher-da/orgs","repos_url":"https://api.github.com/users/shayne-fletcher-da/repos","events_url":"https://api.github.com/users/shayne-fletcher-da/events{/privacy}","received_events_url":"https://api.github.com/users/shayne-fletcher-da/received_events","type":"User","site_admin":false},"body":"Fix match test failures.\r\n\r\n(1) Rephrase free vars patch.\r\n(2) Parenthesize sections in `dotApps'`.\r\n(3) Fix spelling mistake for string literal (`\"isInfixAp\"` / `\"isInfixApp`\") in `checkSides`.\r\n\r\nTL;DR 3 failures all due to slight output format differences.\r\n\r\n- There are 687 tests\r\n- 170 are match tests\r\n- 41  are from `Test.hs`; these are excluded\r\n- there are 129 other match tests\r\n- there are 4 test failures:\r\n  - one is a grep test\r\n  - the remaining 3 failures are due to format\r\n\r\n(0)\r\n```\r\nTEST FAILURE IN tests/_grep_2\r\nDIFFER ON LINE: 1\r\nGOT : <EOF>\r\nWANT: tests/grep2.hs:1:8:\r\nFULL OUTPUT FOR GOT:\r\n```\r\n(1)\r\n```\r\nGOT :   if isNothing x then (- 1.0) else fromJust x\r\nWANT:   if isNothing x then (-1.0) else fromJust x\r\n```\r\n(2)\r\n```Found:\r\n  concat . map f . baz . bar\r\nPerhaps:\r\n  (concatMap f . (baz . bar))\r\n\r\nWANTED: concatMap f . baz . bar\r\n\r\n(3)\r\n```Found:\r\n  typeOf (undefined :: Foo Int)\r\nPerhaps:\r\n  typeRep (Proxy :: Proxy Foo Int)\r\n\r\nWANTED: typeRep (Proxy :: Proxy (Foo Int))\r\n```","created_at":"2019-11-30T20:13:55Z","updated_at":"2019-11-30T20:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/801/commits","review_comments_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/801/comments","review_comment_url":"https://api.github.com/repos/ndmitchell/hlint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndmitchell/hlint/issues/801/comments","statuses_url":"https://api.github.com/repos/ndmitchell/hlint/statuses/3fb0a7e25577568c37e37fe34c99dd35cff86357","head":{"label":"shayne-fletcher-da:convert-match","ref":"convert-match","sha":"3fb0a7e25577568c37e37fe34c99dd35cff86357","user":{"login":"shayne-fletcher-da","id":41306216,"node_id":"MDQ6VXNlcjQxMzA2MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/41306216?v=4","gravatar_id":"","url":"https://api.github.com/users/shayne-fletcher-da","html_url":"https://github.com/shayne-fletcher-da","followers_url":"https://api.github.com/users/shayne-fletcher-da/followers","following_url":"https://api.github.com/users/shayne-fletcher-da/following{/other_user}","gists_url":"https://api.github.com/users/shayne-fletcher-da/gists{/gist_id}","starred_url":"https://api.github.com/users/shayne-fletcher-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayne-fletcher-da/subscriptions","organizations_url":"https://api.github.com/users/shayne-fletcher-da/orgs","repos_url":"https://api.github.com/users/shayne-fletcher-da/repos","events_url":"https://api.github.com/users/shayne-fletcher-da/events{/privacy}","received_events_url":"https://api.github.com/users/shayne-fletcher-da/received_events","type":"User","site_admin":false},"repo":{"id":182276027,"node_id":"MDEwOlJlcG9zaXRvcnkxODIyNzYwMjc=","name":"hlint","full_name":"shayne-fletcher-da/hlint","private":false,"owner":{"login":"shayne-fletcher-da","id":41306216,"node_id":"MDQ6VXNlcjQxMzA2MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/41306216?v=4","gravatar_id":"","url":"https://api.github.com/users/shayne-fletcher-da","html_url":"https://github.com/shayne-fletcher-da","followers_url":"https://api.github.com/users/shayne-fletcher-da/followers","following_url":"https://api.github.com/users/shayne-fletcher-da/following{/other_user}","gists_url":"https://api.github.com/users/shayne-fletcher-da/gists{/gist_id}","starred_url":"https://api.github.com/users/shayne-fletcher-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayne-fletcher-da/subscriptions","organizations_url":"https://api.github.com/users/shayne-fletcher-da/orgs","repos_url":"https://api.github.com/users/shayne-fletcher-da/repos","events_url":"https://api.github.com/users/shayne-fletcher-da/events{/privacy}","received_events_url":"https://api.github.com/users/shayne-fletcher-da/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shayne-fletcher-da/hlint","description":"Haskell source code suggestions","fork":true,"url":"https://api.github.com/repos/shayne-fletcher-da/hlint","forks_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/forks","keys_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/teams","hooks_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/hooks","issue_events_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/issues/events{/number}","events_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/events","assignees_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/assignees{/user}","branches_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/branches{/branch}","tags_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/tags","blobs_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/statuses/{sha}","languages_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/languages","stargazers_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/stargazers","contributors_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/contributors","subscribers_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/subscribers","subscription_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/subscription","commits_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/contents/{+path}","compare_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/merges","archive_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/downloads","issues_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/issues{/number}","pulls_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/pulls{/number}","milestones_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/milestones{/number}","notifications_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/labels{/name}","releases_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/releases{/id}","deployments_url":"https://api.github.com/repos/shayne-fletcher-da/hlint/deployments","created_at":"2019-04-19T14:20:35Z","updated_at":"2019-11-30T14:53:05Z","pushed_at":"2019-11-30T20:00:04Z","git_url":"git://github.com/shayne-fletcher-da/hlint.git","ssh_url":"git@github.com:shayne-fletcher-da/hlint.git","clone_url":"https://github.com/shayne-fletcher-da/hlint.git","svn_url":"https://github.com/shayne-fletcher-da/hlint","homepage":null,"size":3815,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ndmitchell:master","ref":"master","sha":"b8aae557908666e78ec57ae56824d34af5379d2d","user":{"login":"ndmitchell","id":1651197,"node_id":"MDQ6VXNlcjE2NTExOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1651197?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmitchell","html_url":"https://github.com/ndmitchell","followers_url":"https://api.github.com/users/ndmitchell/followers","following_url":"https://api.github.com/users/ndmitchell/following{/other_user}","gists_url":"https://api.github.com/users/ndmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmitchell/subscriptions","organizations_url":"https://api.github.com/users/ndmitchell/orgs","repos_url":"https://api.github.com/users/ndmitchell/repos","events_url":"https://api.github.com/users/ndmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/ndmitchell/received_events","type":"User","site_admin":false},"repo":{"id":11603668,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwMzY2OA==","name":"hlint","full_name":"ndmitchell/hlint","private":false,"owner":{"login":"ndmitchell","id":1651197,"node_id":"MDQ6VXNlcjE2NTExOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1651197?v=4","gravatar_id":"","url":"https://api.github.com/users/ndmitchell","html_url":"https://github.com/ndmitchell","followers_url":"https://api.github.com/users/ndmitchell/followers","following_url":"https://api.github.com/users/ndmitchell/following{/other_user}","gists_url":"https://api.github.com/users/ndmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmitchell/subscriptions","organizations_url":"https://api.github.com/users/ndmitchell/orgs","repos_url":"https://api.github.com/users/ndmitchell/repos","events_url":"https://api.github.com/users/ndmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/ndmitchell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ndmitchell/hlint","description":"Haskell source code suggestions","fork":false,"url":"https://api.github.com/repos/ndmitchell/hlint","forks_url":"https://api.github.com/repos/ndmitchell/hlint/forks","keys_url":"https://api.github.com/repos/ndmitchell/hlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndmitchell/hlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndmitchell/hlint/teams","hooks_url":"https://api.github.com/repos/ndmitchell/hlint/hooks","issue_events_url":"https://api.github.com/repos/ndmitchell/hlint/issues/events{/number}","events_url":"https://api.github.com/repos/ndmitchell/hlint/events","assignees_url":"https://api.github.com/repos/ndmitchell/hlint/assignees{/user}","branches_url":"https://api.github.com/repos/ndmitchell/hlint/branches{/branch}","tags_url":"https://api.github.com/repos/ndmitchell/hlint/tags","blobs_url":"https://api.github.com/repos/ndmitchell/hlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndmitchell/hlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndmitchell/hlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndmitchell/hlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndmitchell/hlint/statuses/{sha}","languages_url":"https://api.github.com/repos/ndmitchell/hlint/languages","stargazers_url":"https://api.github.com/repos/ndmitchell/hlint/stargazers","contributors_url":"https://api.github.com/repos/ndmitchell/hlint/contributors","subscribers_url":"https://api.github.com/repos/ndmitchell/hlint/subscribers","subscription_url":"https://api.github.com/repos/ndmitchell/hlint/subscription","commits_url":"https://api.github.com/repos/ndmitchell/hlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndmitchell/hlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndmitchell/hlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndmitchell/hlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndmitchell/hlint/contents/{+path}","compare_url":"https://api.github.com/repos/ndmitchell/hlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndmitchell/hlint/merges","archive_url":"https://api.github.com/repos/ndmitchell/hlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndmitchell/hlint/downloads","issues_url":"https://api.github.com/repos/ndmitchell/hlint/issues{/number}","pulls_url":"https://api.github.com/repos/ndmitchell/hlint/pulls{/number}","milestones_url":"https://api.github.com/repos/ndmitchell/hlint/milestones{/number}","notifications_url":"https://api.github.com/repos/ndmitchell/hlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndmitchell/hlint/labels{/name}","releases_url":"https://api.github.com/repos/ndmitchell/hlint/releases{/id}","deployments_url":"https://api.github.com/repos/ndmitchell/hlint/deployments","created_at":"2013-07-23T08:43:40Z","updated_at":"2019-11-30T09:19:09Z","pushed_at":"2019-11-30T17:13:45Z","git_url":"git://github.com/ndmitchell/hlint.git","ssh_url":"git@github.com:ndmitchell/hlint.git","clone_url":"https://github.com/ndmitchell/hlint.git","svn_url":"https://github.com/ndmitchell/hlint","homepage":null,"size":3824,"stargazers_count":888,"watchers_count":888,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":114,"open_issues":200,"watchers":888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/801"},"html":{"href":"https://github.com/ndmitchell/hlint/pull/801"},"issue":{"href":"https://api.github.com/repos/ndmitchell/hlint/issues/801"},"comments":{"href":"https://api.github.com/repos/ndmitchell/hlint/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndmitchell/hlint/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/ndmitchell/hlint/statuses/3fb0a7e25577568c37e37fe34c99dd35cff86357"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":22,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"shayne-fletcher-da"}}