{"action":"created","issue":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1933","repository_url":"https://api.github.com/repos/aws/amazon-ecs-agent","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1933/labels{/name}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1933/comments","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1933/events","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1933","id":419579268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMDUzOTc0","number":1933,"title":"add functional tests for appmesh cni plugin","user":{"login":"yumex93","id":40645121,"node_id":"MDQ6VXNlcjQwNjQ1MTIx","avatar_url":"https://avatars3.githubusercontent.com/u/40645121?v=4","gravatar_id":"","url":"https://api.github.com/users/yumex93","html_url":"https://github.com/yumex93","followers_url":"https://api.github.com/users/yumex93/followers","following_url":"https://api.github.com/users/yumex93/following{/other_user}","gists_url":"https://api.github.com/users/yumex93/gists{/gist_id}","starred_url":"https://api.github.com/users/yumex93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumex93/subscriptions","organizations_url":"https://api.github.com/users/yumex93/orgs","repos_url":"https://api.github.com/users/yumex93/repos","events_url":"https://api.github.com/users/yumex93/events{/privacy}","received_events_url":"https://api.github.com/users/yumex93/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-03-11T16:59:06Z","updated_at":"2019-03-11T17:18:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1933","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1933","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/1933.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/1933.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n### Summary\r\nAdd functional test to test AppMesh CNI plugin to make sure the ip rules can be successfully configured as user defined.\r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop.  `go test -timeout=30s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop.  Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request.  `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources.  Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results. Also, once\r\nyou open the pull request, there will be 14 automatic test checks on the bottom\r\nof the pull request, please make sure they all pass before you merge it. You can\r\nuse `bot/test` label to rerun the automatic tests multiple times.\r\n-->\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\n\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\n\r\n### Licensing\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n"},"comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments/471636020","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1933#issuecomment-471636020","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1933","id":471636020,"node_id":"MDEyOklzc3VlQ29tbWVudDQ3MTYzNjAyMA==","user":{"login":"suneyz","id":8356105,"node_id":"MDQ6VXNlcjgzNTYxMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/8356105?v=4","gravatar_id":"","url":"https://api.github.com/users/suneyz","html_url":"https://github.com/suneyz","followers_url":"https://api.github.com/users/suneyz/followers","following_url":"https://api.github.com/users/suneyz/following{/other_user}","gists_url":"https://api.github.com/users/suneyz/gists{/gist_id}","starred_url":"https://api.github.com/users/suneyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suneyz/subscriptions","organizations_url":"https://api.github.com/users/suneyz/orgs","repos_url":"https://api.github.com/users/suneyz/repos","events_url":"https://api.github.com/users/suneyz/events{/privacy}","received_events_url":"https://api.github.com/users/suneyz/received_events","type":"User","site_admin":false},"created_at":"2019-03-11T17:18:35Z","updated_at":"2019-03-11T17:18:35Z","author_association":"CONTRIBUTOR","body":"Instead of bringing in extra vendor files for functional test only. Why not simplify the test logic to build a test image from ubuntu/amazonlinux and install iptables through yum install. Then use linux command to test? This way you might only need ~100 lines of code vs over 1000 lines"}}
{"actor":{"display_login":"suneyz"}}