{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/337134972","pull_request_review_id":304711232,"id":337134972,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzEzNDk3Mg==","diff_hunk":"@@ -323,7 +338,6 @@ def _configure_db_create_params(\n     if create_mode != CreateMode.default or engine != Engine.db:\n         arg_ctx.ignore('sample_name')\n         arg_ctx.ignore('catalog_collation')\n-        arg_ctx.ignore('read_scale')","path":"src/azure-cli/azure/cli/command_modules/sql/_params.py","position":42,"original_position":42,"commit_id":"b9dc1c679cc4093b0d54c6f27c9681b4716f4f15","original_commit_id":"b9dc1c679cc4093b0d54c6f27c9681b4716f4f15","user":{"login":"jaredmoo","id":3248887,"node_id":"MDQ6VXNlcjMyNDg4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/3248887?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredmoo","html_url":"https://github.com/jaredmoo","followers_url":"https://api.github.com/users/jaredmoo/followers","following_url":"https://api.github.com/users/jaredmoo/following{/other_user}","gists_url":"https://api.github.com/users/jaredmoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredmoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredmoo/subscriptions","organizations_url":"https://api.github.com/users/jaredmoo/orgs","repos_url":"https://api.github.com/users/jaredmoo/repos","events_url":"https://api.github.com/users/jaredmoo/events{/privacy}","received_events_url":"https://api.github.com/users/jaredmoo/received_events","type":"User","site_admin":false},"body":"You should still ignore read_scale and read_replica count if engine == dw (section below)","created_at":"2019-10-21T17:09:42Z","updated_at":"2019-10-21T17:11:16Z","html_url":"https://github.com/Azure/azure-cli/pull/10928#discussion_r337134972","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/10928","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/337134972"},"html":{"href":"https://github.com/Azure/azure-cli/pull/10928#discussion_r337134972"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/10928"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/10928","id":330447503,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwNDQ3NTAz","html_url":"https://github.com/Azure/azure-cli/pull/10928","diff_url":"https://github.com/Azure/azure-cli/pull/10928.diff","patch_url":"https://github.com/Azure/azure-cli/pull/10928.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/10928","number":10928,"state":"open","locked":false,"title":"Read scale","user":{"login":"bradrich-msft","id":53872276,"node_id":"MDQ6VXNlcjUzODcyMjc2","avatar_url":"https://avatars0.githubusercontent.com/u/53872276?v=4","gravatar_id":"","url":"https://api.github.com/users/bradrich-msft","html_url":"https://github.com/bradrich-msft","followers_url":"https://api.github.com/users/bradrich-msft/followers","following_url":"https://api.github.com/users/bradrich-msft/following{/other_user}","gists_url":"https://api.github.com/users/bradrich-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich-msft/subscriptions","organizations_url":"https://api.github.com/users/bradrich-msft/orgs","repos_url":"https://api.github.com/users/bradrich-msft/repos","events_url":"https://api.github.com/users/bradrich-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich-msft/received_events","type":"User","site_admin":false},"body":"Adding read scale support to SQL Database CRUD operations.\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n- [X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n- [X] I adhere to the [Command Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/command_guidelines.md).\r\n","created_at":"2019-10-21T14:46:12Z","updated_at":"2019-10-21T17:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"762d0a9e6f114d684375c24ef6492c31487ee2e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/10928/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/10928/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/10928/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/b9dc1c679cc4093b0d54c6f27c9681b4716f4f15","head":{"label":"bradrich-msft:readScale","ref":"readScale","sha":"b9dc1c679cc4093b0d54c6f27c9681b4716f4f15","user":{"login":"bradrich-msft","id":53872276,"node_id":"MDQ6VXNlcjUzODcyMjc2","avatar_url":"https://avatars0.githubusercontent.com/u/53872276?v=4","gravatar_id":"","url":"https://api.github.com/users/bradrich-msft","html_url":"https://github.com/bradrich-msft","followers_url":"https://api.github.com/users/bradrich-msft/followers","following_url":"https://api.github.com/users/bradrich-msft/following{/other_user}","gists_url":"https://api.github.com/users/bradrich-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich-msft/subscriptions","organizations_url":"https://api.github.com/users/bradrich-msft/orgs","repos_url":"https://api.github.com/users/bradrich-msft/repos","events_url":"https://api.github.com/users/bradrich-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich-msft/received_events","type":"User","site_admin":false},"repo":{"id":216584659,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY1ODQ2NTk=","name":"azure-cli","full_name":"bradrich-msft/azure-cli","private":false,"owner":{"login":"bradrich-msft","id":53872276,"node_id":"MDQ6VXNlcjUzODcyMjc2","avatar_url":"https://avatars0.githubusercontent.com/u/53872276?v=4","gravatar_id":"","url":"https://api.github.com/users/bradrich-msft","html_url":"https://github.com/bradrich-msft","followers_url":"https://api.github.com/users/bradrich-msft/followers","following_url":"https://api.github.com/users/bradrich-msft/following{/other_user}","gists_url":"https://api.github.com/users/bradrich-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bradrich-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradrich-msft/subscriptions","organizations_url":"https://api.github.com/users/bradrich-msft/orgs","repos_url":"https://api.github.com/users/bradrich-msft/repos","events_url":"https://api.github.com/users/bradrich-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bradrich-msft/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bradrich-msft/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/bradrich-msft/azure-cli","forks_url":"https://api.github.com/repos/bradrich-msft/azure-cli/forks","keys_url":"https://api.github.com/repos/bradrich-msft/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradrich-msft/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradrich-msft/azure-cli/teams","hooks_url":"https://api.github.com/repos/bradrich-msft/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/bradrich-msft/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/bradrich-msft/azure-cli/events","assignees_url":"https://api.github.com/repos/bradrich-msft/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/bradrich-msft/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/bradrich-msft/azure-cli/tags","blobs_url":"https://api.github.com/repos/bradrich-msft/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradrich-msft/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradrich-msft/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradrich-msft/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradrich-msft/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/bradrich-msft/azure-cli/languages","stargazers_url":"https://api.github.com/repos/bradrich-msft/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/bradrich-msft/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/bradrich-msft/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/bradrich-msft/azure-cli/subscription","commits_url":"https://api.github.com/repos/bradrich-msft/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradrich-msft/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradrich-msft/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradrich-msft/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradrich-msft/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/bradrich-msft/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradrich-msft/azure-cli/merges","archive_url":"https://api.github.com/repos/bradrich-msft/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradrich-msft/azure-cli/downloads","issues_url":"https://api.github.com/repos/bradrich-msft/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/bradrich-msft/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/bradrich-msft/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/bradrich-msft/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradrich-msft/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/bradrich-msft/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/bradrich-msft/azure-cli/deployments","created_at":"2019-10-21T14:10:13Z","updated_at":"2019-10-21T14:10:15Z","pushed_at":"2019-10-21T14:44:40Z","git_url":"git://github.com/bradrich-msft/azure-cli.git","ssh_url":"git@github.com:bradrich-msft/azure-cli.git","clone_url":"https://github.com/bradrich-msft/azure-cli.git","svn_url":"https://github.com/bradrich-msft/azure-cli","homepage":null,"size":149137,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"dacbe4591c7cb7684e97231850798462173585b1","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"node_id":"MDEwOlJlcG9zaXRvcnk1MTA0MDg4Ng==","name":"azure-cli","full_name":"Azure/azure-cli","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2019-10-21T13:13:30Z","pushed_at":"2019-10-21T16:56:58Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":149193,"stargazers_count":1553,"watchers_count":1553,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1004,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":883,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1004,"open_issues":883,"watchers":1553,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/10928"},"html":{"href":"https://github.com/Azure/azure-cli/pull/10928"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/10928"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/10928/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/10928/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/10928/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/b9dc1c679cc4093b0d54c6f27c9681b4716f4f15"}},"author_association":"NONE"}}
{"actor":{"display_login":"jaredmoo"}}