{"push_id":3720533640,"size":17,"distinct_size":17,"ref":"refs/heads/master","head":"f7a33e235022431a7cd7eefafb44ba808526b0bf","before":"e2fb5cafd9fe7075c3c1b9ea1eecca635663c129","commits":[{"sha":"2c8194328e2d29c1b67203325cce51ede48f20b8","author":{"name":"En-Shuo Hsu","email":"6a27f489ed1bcabf953865455cccaccaa9a878d3@chromium.org"},"message":"CRAS: Rename FOR_ARRAY_ELEMENT and update .clang-format\n\nThe FOR_ARRAY_ELEMENT is a foreach macro that doesn't share the same\nnaming convention like the DL_FOREACH or LL_FOREACH. Rename it and\nupdate .clang-format to get correct formatting results.\n\nBUG=chromium:950858\nTEST=None\n\nChange-Id: Iac9667287792d7539a267935bd374a34c69e69cb\nReviewed-on: https://chromium-review.googlesource.com/1630367\nCommit-Ready: En-Shuo Hsu <enshuo@google.com>\nTested-by: En-Shuo Hsu <enshuo@google.com>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/2c8194328e2d29c1b67203325cce51ede48f20b8"},{"sha":"90376316111ae6cdd07a9a914da07e5949c9c0ca","author":{"name":"Yu-Hsuan Hsu","email":"408ce583a741d0fc6058b820e2d309c67fb3bda1@chromium.org"},"message":"CRAS: audio_thread - Ignore next_cb_ts of draining streams\n\nIn the current version, when a stream is draining and there are some\nsamples in a share memory, we will wake up at the next_cb_ts of that\nstream.\nHowever, if a device is full, we can not take out all samples from the\nstream. Meanwile, the next_cb_ts is not updated because the stream is\ndraining. It causes the audio thread always wake up at that next_cb_ts\nand trigger busy loop.\nTo fix this problem, we can ignore next_cb_ts if the streams is\ndraining. The first reason is we don't need to fetch that stream any\nmore. The second reason is a device already have its own wake up time,\nwhich is the time that a device needs more samples. So we don't need to\nworry about that these samples will not be played.\n(see cras_iodev_frames_to_play_in_sleep)\n\nBUG=chromium:958492\nTEST=Do not trigger busyloop when device buffer is full. (Tested on\neve by seting incorrect rate in cras.)\n\nChange-Id: I2aa95cfe3c3685ee48c1703c0db7d919ffbc6ae5\nReviewed-on: https://chromium-review.googlesource.com/1640437\nCommit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>\nTested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/90376316111ae6cdd07a9a914da07e5949c9c0ca"},{"sha":"97526401f270671d5e0a545a2dcf3e1b2108465b","author":{"name":"Yu-Hsuan Hsu","email":"408ce583a741d0fc6058b820e2d309c67fb3bda1@chromium.org"},"message":"CRAS: Move get_next_output_wake from audio_thread into dev_io\n\nMoving get_next_output_wake into dev_io to make logic cleaner.\nIt can provide better test surface for unittest.\n\nBUG=chromium:957513\nTEST=Audio works normally on peppy.\n\nChange-Id: I3123879546a634b9bd79c8ef6de172aba199043b\nReviewed-on: https://chromium-review.googlesource.com/1596048\nCommit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>\nTested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/97526401f270671d5e0a545a2dcf3e1b2108465b"},{"sha":"2af018df3fc6dffc37810d5ffe9dd336cdcbdb7e","author":{"name":"Yu-Hsuan Hsu","email":"408ce583a741d0fc6058b820e2d309c67fb3bda1@chromium.org"},"message":"CRAS: timing_unittest - Verify time scheduling for output streams\n\nCreate unittests to test initial next_cb_ts, wake up time and next_cb_ts\nupdate for output streams.\n\nBUG=chromium:957513\nTEST=FEATURES=\"test\" USE=asan emerge-peppy -v media-sound/adhd\n\nChange-Id: I1d33be3893326a357709001053dd806b744fd90e\nReviewed-on: https://chromium-review.googlesource.com/1596049\nCommit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>\nTested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/2af018df3fc6dffc37810d5ffe9dd336cdcbdb7e"},{"sha":"0ccf709db3c39455cd41ec3b8de3299c7c5de0e1","author":{"name":"paulhsia","email":"e09ac2debfefa3666e69a4e41e179a1517e8fddf@chromium.org"},"message":"CRAS: Extract create_and_listen_server_socket function\n\nThe server socket creation process will be used by different\ntypes of server sockets in cras_server, so we extract the code\nto a single function.\n\nBUG=chromium:937765\nTEST=Deploy cras to DUT and check audio functionality.\n\nChange-Id: I100deff9a78621b8b8563a24c0e008bc9ea3b8ec\nReviewed-on: https://chromium-review.googlesource.com/1635049\nCommit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>\nTested-by: Chih-Yang Hsia <paulhsia@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Dylan Reid <dgreid@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/0ccf709db3c39455cd41ec3b8de3299c7c5de0e1"},{"sha":"43897de0f272918ebd89f090f72268abe6f82c61","author":{"name":"paulhsia","email":"e09ac2debfefa3666e69a4e41e179a1517e8fddf@chromium.org"},"message":"CRAS: Add cras_rclient_ops and extract cras_control_rclient\n\n- Split cras_rclient to data and cras_client_ops and make exposed\nfunctions in cras_rclient simple.\n- Replace old cras_rclient implementation by cras_control_rclient.\n- Move rclient_unittest to control_rclient_unittest\n\nCurrently, cras_control_client still have full functionality like opening\nplayback and capture streams.\n\nAll other implementations (e.g. cras_playback_rclient) can be a\ncras_rclient implementation and they can be tested separately.\n\nBUG=chromium:937765\nTEST=$ FEATURES=test emerge-${BOARD} adhd\nTEST=Build ossfuzz by\nsudo docker build -t ossfuzz/cras -f src/fuzz/Dockerfile .\nsudo docker run --privileged -ti --rm -v $(pwd):/src/cras \\\n        -v /tmp/fuzzers:/out ossfuzz/cras\n\nChange-Id: I16337f480955288adc191d2669e7a063201cd5a5\nReviewed-on: https://chromium-review.googlesource.com/1642596\nCommit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>\nTested-by: Chih-Yang Hsia <paulhsia@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Dylan Reid <dgreid@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/43897de0f272918ebd89f090f72268abe6f82c61"},{"sha":"efa48a08c8e16078036b5b9312e8f7b328a99509","author":{"name":"paulhsia","email":"e09ac2debfefa3666e69a4e41e179a1517e8fddf@chromium.org"},"message":"CRAS: Use Chromium style in cras/src/fuzz\n\nBUG=chromium:950858\nTEST=Run clang-format\n\nChange-Id: Ib415363c4eb5620a776a33ebaec9dcc223df62dc\nReviewed-on: https://chromium-review.googlesource.com/1643162\nCommit-Ready: Chih-Yang Hsia <paulhsia@chromium.org>\nTested-by: Chih-Yang Hsia <paulhsia@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: En-Shuo Hsu <enshuo@google.com>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/efa48a08c8e16078036b5b9312e8f7b328a99509"},{"sha":"6e6b72df399d71dc933d89e50f145a2adabfb35d","author":{"name":"Fletcher Woodruff","email":"98edc5f250b1510051c50f8d7b8e3061f58f8d5c@chromium.org"},"message":"CRAS: move creation of audio_shm into cras_shm\n\ncras_rstream was handling initialization of the audio shared memory\narea.  Move that code into cras_shm so that the abstraction is a little\nless leaky.\n\nAlso create a cras_shm_info struct that is used to initialize\ncras_audio_shm. This will allow us to de-duplicate code from the client\nlibrary, and to cleanly transition to a split shm.\n\nBUG=chromium:968724\nTEST=unit tests, basic playback tests on-device\n\nChange-Id: I456f81254b21332f8d0a1ab276a2df5ec888d0b3\nReviewed-on: https://chromium-review.googlesource.com/1637726\nCommit-Ready: Fletcher Woodruff <fletcherw@chromium.org>\nTested-by: Fletcher Woodruff <fletcherw@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Fletcher Woodruff <fletcherw@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/6e6b72df399d71dc933d89e50f145a2adabfb35d"},{"sha":"fc1ad04040097c13c0bb654118857d1ae3636d75","author":{"name":"Fletcher Woodruff","email":"98edc5f250b1510051c50f8d7b8e3061f58f8d5c@chromium.org"},"message":"CRAS: switch cras_client to cras_audio_shm_create\n\nMake cras_client create its shared memory objects using cras_shm's\ncras_audio_shm_create function. Also convert the shm objects to be pointers\ninstead of member structs.\n\nThis will allow us to efficiently transition to a split shm setup for CRAS.\n\nBUG=chromium:968724\nTEST=run on device and ensure that playback/capture work.\n\nChange-Id: Id501331c31007cd121d36826134d42ffe75a6c82\nReviewed-on: https://chromium-review.googlesource.com/1642367\nCommit-Ready: Fletcher Woodruff <fletcherw@chromium.org>\nTested-by: Fletcher Woodruff <fletcherw@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>\nReviewed-by: Fletcher Woodruff <fletcherw@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/fc1ad04040097c13c0bb654118857d1ae3636d75"},{"sha":"2ae7d9fadcf6ad45a6d7ac26449cfae738af484f","author":{"name":"Hsin-Yu Chao","email":"8b91762bdbe27d3121b311091d7ca5125e9a8df6@google.com"},"message":"CRAS: iodev - Protect ext_module by pipline lock\n\nWhen web app enables APM in CRAS, the active playback or echo\nreference iodev will have APM run as one of the modules in its\ndsp pipeline.\nThere's a special case when using BT headset that when it gets\ndisconnected, the silent playback device is activated and\nconfigured to run APM in audio thread because the BT iodev cannot\ndo I/O anymore\nLater when main thread handles the event from bluetoothd to remove\nBT iodev, the silent playback device gets configured to run APM\nagain. And that could cause crash because the cras_apm_reverse_module\nis being accessed by two threads.\n\nTo fix that, move ext_dsp_module->configure call to between the\nget/put call of dsp pipeline so the mutex protects it from being\naccessed by two threads at the same time.\n\nBUG=chromium:970165\nTEST=Apply full patch series, launch appr.tc and connect LG HBS700\nheadset. In bluetooth settings UI, repeatedly connect/disconnect\nheadset 20-30 times to verify CRAS doesn't crash.\n\nChange-Id: Ia10d9135ee775e2d14017a09bfc0f429ab4dc364\nReviewed-on: https://chromium-review.googlesource.com/1647213\nCommit-Ready: Hsinyu Chao <hychao@chromium.org>\nTested-by: Hsinyu Chao <hychao@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/2ae7d9fadcf6ad45a6d7ac26449cfae738af484f"},{"sha":"d341acd8856bebba13af54692e7c0079ce972bad","author":{"name":"Hsin-Yu Chao","email":"8b91762bdbe27d3121b311091d7ca5125e9a8df6@google.com"},"message":"CRAS: dsp - NULL ext_dsp_module should set into pipeline\n\nWhen web app uses CRAS APM and the playback iodev switches,\nthe cras_apm_reverse_module would detach and attach to\ndifferent dsp pipelines of the iodev used as echo reference.\n\nThere is a bug that when swtich playback away from iodev X,\nthe sink module of dsp pipeline still points to the APM module\nfor a short while before it closes. At this moment, main thread\nconfigures iodev Y by attaching the same APM module to its\ndsp pipeline, and that could cause crash.\n\nTo fix this problem, modify the API to set NULL ext_dsp_module\ninto the DSP pipeline/module layer, to ensure that it doesn't leak\nor be used in two thread simultaneously.\n\nBUG=chromium:970165\nTEST=Apply full patch series, launch appr.tc and use LG HBS700\nheadset. In bluetooth settings UI, repeatedly connect/disconnect\nheadset for 20 times to verify CRAS doesn't crash.\n\nChange-Id: Ifbf688d3e22ef13a303fb30915f6a932528a7d07\nReviewed-on: https://chromium-review.googlesource.com/1647214\nCommit-Ready: Hsinyu Chao <hychao@chromium.org>\nTested-by: Hsinyu Chao <hychao@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/d341acd8856bebba13af54692e7c0079ce972bad"},{"sha":"4474b7a519f53886e19b8ffab3591cfe5a76b04a","author":{"name":"Hsin-Yu Chao","email":"8b91762bdbe27d3121b311091d7ca5125e9a8df6@google.com"},"message":"CRAS: apm_list - Make echo ref tracking more reliable\n\nBelow changes are made to ensure the echo ref tracking is reliable\nin apm_list regardless of how the device enable/disable events\ncome from cras_iodev_list.\n\n- If APM rmod already tracking the same iodev as echo ref, don't\nbother configure it again.\n- If APM rmod was tracking another iodev, configure its dsp pipeline\nso it no longer points back to APM rmod.\n\nBUG=chromium:970165\nTEST=Use appr.tc with BT headset.\n\nChange-Id: If6d4af247d5d8b1450cc861bcc97e264e5e5c013\nReviewed-on: https://chromium-review.googlesource.com/1647215\nCommit-Ready: Hsinyu Chao <hychao@chromium.org>\nTested-by: Hsinyu Chao <hychao@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/4474b7a519f53886e19b8ffab3591cfe5a76b04a"},{"sha":"de3492d0b22c9c5cfac3325fcabfea6ec0a52fc0","author":{"name":"Tzung-Bi Shih","email":"5e6f7578cd434ae5b4c9ffe5250f7a87a25045d7@chromium.org"},"message":"CRAS: dsp_ini: change log severity to DEBUG for creating software DSP\n\nSoftware DSP is optional.  Change the log severity if one board does not\nhave dsp.ini.\n\nFor example, to change the following from error message to debug message:\nno ini file /etc/cras/kukui/dsp.ini\ncannot create dsp ini\n\nBUG=b:134557783\nTEST=grep dsp /var/log/messages\n\nChange-Id: I81ca6e0b336c8efe8c9522f5ff31eb5d6f7e230d\nSigned-off-by: Tzung-Bi Shih <tzungbi@chromium.org>\nReviewed-on: https://chromium-review.googlesource.com/1647080\nCommit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/de3492d0b22c9c5cfac3325fcabfea6ec0a52fc0"},{"sha":"2f265de12903e1176123a1fd57387044661cb241","author":{"name":"Fletcher Woodruff","email":"98edc5f250b1510051c50f8d7b8e3061f58f8d5c@chromium.org"},"message":"CRAS: rstream: unsplit output and input shm\n\nrstream has separate functions for output and input shm, but they\nrefer to the same pointer. Combine the two functions.\n\nBUG=chromium:968724\nTEST=unit tests, playback on device\n\nChange-Id: Ib02acab1578cba7083006e01ce294d4d234bd969\nReviewed-on: https://chromium-review.googlesource.com/1649043\nCommit-Ready: Fletcher Woodruff <fletcherw@chromium.org>\nTested-by: Fletcher Woodruff <fletcherw@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/2f265de12903e1176123a1fd57387044661cb241"},{"sha":"07b7bb5fd2480448aa8255fe5122d0c07c568420","author":{"name":"Fletcher Woodruff","email":"98edc5f250b1510051c50f8d7b8e3061f58f8d5c@chromium.org"},"message":"CRAS: cras_client - unsplit shm\n\ncras_client had two shm member variables, but only one was ever used.\nMerge the two of them.\n\nBUG=chromium:968724\nTEST=unittests, playback on-device\n\nChange-Id: I152f38e6db82121d2afd2cac51f11f8c3c8142a2\nReviewed-on: https://chromium-review.googlesource.com/1650079\nCommit-Ready: Fletcher Woodruff <fletcherw@chromium.org>\nTested-by: Fletcher Woodruff <fletcherw@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Chih-Yang Hsia <paulhsia@chromium.org>\nReviewed-by: Dylan Reid <dgreid@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/07b7bb5fd2480448aa8255fe5122d0c07c568420"},{"sha":"60ec208481eaa7de3c322d057a5ee37ca4660627","author":{"name":"paulhsia","email":"e09ac2debfefa3666e69a4e41e179a1517e8fddf@chromium.org"},"message":"CRAS: libcras: Add cras_shm source to Android.mk\n\nFix build errors in android N.\n\nBUG=b:134996948, chroimum:968724\nTEST=Test build on android N\n\nChange-Id: I82f0ba0638fd3c06a0ee189d2d2a4e3845b932e9\nReviewed-on: https://chromium-review.googlesource.com/1647089\nCommit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>\nTested-by: Chih-Yang Hsia <paulhsia@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Fletcher Woodruff <fletcherw@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/60ec208481eaa7de3c322d057a5ee37ca4660627"},{"sha":"f7a33e235022431a7cd7eefafb44ba808526b0bf","author":{"name":"Hsin-Yu Chao","email":"8b91762bdbe27d3121b311091d7ca5125e9a8df6@google.com"},"message":"CRAS: server_metrics - Log WBS capability of connected BT headset\n\nHFP 1.7.1 spec says 'Legacy devices shall not indicate support for\nthe Codec Negotiation Feature'. Plus that we haven't found a headset\nthat supports codec negotiation but not mSBC(for WBS), we use this\nfeature bit to log if the connected BT headset supports WBS.\n\nThis will help us understand the rough percentage of WBS capability\non all BT headsets connected with Chromebook.\n\nBUG=chromium:971568\nTEST=Connect Bose QC35 and LG HBS700, verify data is logged in\nchrome://histograms\n\nChange-Id: Ie02bac9ffb9306fca7b4e0662c8b595d724051da\nReviewed-on: https://chromium-review.googlesource.com/1647225\nCommit-Ready: Hsinyu Chao <hychao@chromium.org>\nTested-by: Hsinyu Chao <hychao@chromium.org>\nLegacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>\nReviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>","distinct":true,"url":"https://api.github.com/repos/crosvm/adhd/commits/f7a33e235022431a7cd7eefafb44ba808526b0bf"}]}
{"actor":{"display_login":"navigaid"}}