{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/335119622","pull_request_review_id":302122840,"id":335119622,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTExOTYyMg==","diff_hunk":"@@ -32,6 +32,13 @@ Using Maven for Jetty implementations is a popular choice, but users encouraged\n Other popular tools include Ant and Gradle. \n ____\n \n+____\n+[IMPORTANT]\n+Various Jetty sub-projects may define configuration files with the same name.","path":"jetty-documentation/src/main/asciidoc/development/maven/jetty-maven-helloworld.adoc","position":6,"original_position":6,"commit_id":"f18d1a4867b3757c84399067965738351dfbd8f3","original_commit_id":"f18d1a4867b3757c84399067965738351dfbd8f3","user":{"login":"GlenKPeterson","id":2416031,"node_id":"MDQ6VXNlcjI0MTYwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2416031?v=4","gravatar_id":"","url":"https://api.github.com/users/GlenKPeterson","html_url":"https://github.com/GlenKPeterson","followers_url":"https://api.github.com/users/GlenKPeterson/followers","following_url":"https://api.github.com/users/GlenKPeterson/following{/other_user}","gists_url":"https://api.github.com/users/GlenKPeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenKPeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenKPeterson/subscriptions","organizations_url":"https://api.github.com/users/GlenKPeterson/orgs","repos_url":"https://api.github.com/users/GlenKPeterson/repos","events_url":"https://api.github.com/users/GlenKPeterson/events{/privacy}","received_events_url":"https://api.github.com/users/GlenKPeterson/received_events","type":"User","site_admin":false},"body":"@gregw  I confess that you stumped me here: \"jetty uses the features of Service loader and increasing the feature of multi-version jar.\"  It sounds like something that deserves a JSR, but I don't see one.  The best I could find is this description of the Jar file format mostly copied from an old Sun site to a newer Oracle page:\r\nhttps://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html#Provider_Configuration_File\r\n\r\nThat explains the META-INF/services directory where service provider configuration files live, but says nothing about how competing provider-configuration-files should be handled.  It doesn't specify whether they should be merged, overwritten, or if conflicts are errors.\r\n\r\nDo you have a link to the standard that specifies provider configuration file merging?  Even the [ServicesResourceTransformer](https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html#ServicesResourceTransformer) makes it sound like a choice \"to merge multiple implementations of the same interface into one service entry.\"\r\n\r\nI'd really like to educate myself about this a little more before I try again to write a sentence about it.  If merging provider configuration files is a Jetty assumption or even just a common assumption among the Jar File Cognoscenti, we should be clear about that.\r\n\r\nGradle:\r\nHere's an example of calling a ServicesResourceTransformer in Gradle:\r\nhttps://github.com/johnrengelman/shadow/issues/105\r\n\r\nHere's the only other scrap I could find:\r\nhttps://stackoverflow.com/questions/32887966/shadow-plugin-gradle-what-does-mergeservicefiles-do\r\n\r\nI could test out the Gradle recipe with my project and report back.  It seems that's going to be a requirement in order to build a fat jar with Gradle.\r\n\r\nSorry to take so long.  My non-work coding is very limited at the moment.","created_at":"2019-10-15T18:49:42Z","updated_at":"2019-10-15T18:49:42Z","html_url":"https://github.com/eclipse/jetty.project/pull/4164#discussion_r335119622","pull_request_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/335119622"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/4164#discussion_r335119622"},"pull_request":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164"}},"in_reply_to_id":332728082},"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164","id":325498233,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1NDk4MjMz","html_url":"https://github.com/eclipse/jetty.project/pull/4164","diff_url":"https://github.com/eclipse/jetty.project/pull/4164.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/4164.patch","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/4164","number":4164,"state":"open","locked":false,"title":"Documentation: Added ServicesResourceTransformer to the section on Jetty and Maven","user":{"login":"GlenKPeterson","id":2416031,"node_id":"MDQ6VXNlcjI0MTYwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2416031?v=4","gravatar_id":"","url":"https://api.github.com/users/GlenKPeterson","html_url":"https://github.com/GlenKPeterson","followers_url":"https://api.github.com/users/GlenKPeterson/followers","following_url":"https://api.github.com/users/GlenKPeterson/following{/other_user}","gists_url":"https://api.github.com/users/GlenKPeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenKPeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenKPeterson/subscriptions","organizations_url":"https://api.github.com/users/GlenKPeterson/orgs","repos_url":"https://api.github.com/users/GlenKPeterson/repos","events_url":"https://api.github.com/users/GlenKPeterson/events{/privacy}","received_events_url":"https://api.github.com/users/GlenKPeterson/received_events","type":"User","site_admin":false},"body":"Added a new section to the http2 introduction on using the Maven Shade plugin with the ServicesResourceTransformer.  This is based on the help I received on the jetty-users mailing list.","created_at":"2019-10-07T21:16:52Z","updated_at":"2019-10-15T18:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc865519de1ae9c0781184475b179632875775a","assignee":{"login":"WalkerWatch","id":1237580,"node_id":"MDQ6VXNlcjEyMzc1ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1237580?v=4","gravatar_id":"","url":"https://api.github.com/users/WalkerWatch","html_url":"https://github.com/WalkerWatch","followers_url":"https://api.github.com/users/WalkerWatch/followers","following_url":"https://api.github.com/users/WalkerWatch/following{/other_user}","gists_url":"https://api.github.com/users/WalkerWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/WalkerWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalkerWatch/subscriptions","organizations_url":"https://api.github.com/users/WalkerWatch/orgs","repos_url":"https://api.github.com/users/WalkerWatch/repos","events_url":"https://api.github.com/users/WalkerWatch/events{/privacy}","received_events_url":"https://api.github.com/users/WalkerWatch/received_events","type":"User","site_admin":false},"assignees":[{"login":"WalkerWatch","id":1237580,"node_id":"MDQ6VXNlcjEyMzc1ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1237580?v=4","gravatar_id":"","url":"https://api.github.com/users/WalkerWatch","html_url":"https://github.com/WalkerWatch","followers_url":"https://api.github.com/users/WalkerWatch/followers","following_url":"https://api.github.com/users/WalkerWatch/following{/other_user}","gists_url":"https://api.github.com/users/WalkerWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/WalkerWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalkerWatch/subscriptions","organizations_url":"https://api.github.com/users/WalkerWatch/orgs","repos_url":"https://api.github.com/users/WalkerWatch/repos","events_url":"https://api.github.com/users/WalkerWatch/events{/privacy}","received_events_url":"https://api.github.com/users/WalkerWatch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1512212510,"node_id":"MDU6TGFiZWwxNTEyMjEyNTEw","url":"https://api.github.com/repos/eclipse/jetty.project/labels/Missing%20ECA","name":"Missing ECA","color":"dd9944","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164/commits","review_comments_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164/comments","review_comment_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/4164/comments","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/f18d1a4867b3757c84399067965738351dfbd8f3","head":{"label":"GlenKPeterson:jetty-9.4.x","ref":"jetty-9.4.x","sha":"f18d1a4867b3757c84399067965738351dfbd8f3","user":{"login":"GlenKPeterson","id":2416031,"node_id":"MDQ6VXNlcjI0MTYwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2416031?v=4","gravatar_id":"","url":"https://api.github.com/users/GlenKPeterson","html_url":"https://github.com/GlenKPeterson","followers_url":"https://api.github.com/users/GlenKPeterson/followers","following_url":"https://api.github.com/users/GlenKPeterson/following{/other_user}","gists_url":"https://api.github.com/users/GlenKPeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenKPeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenKPeterson/subscriptions","organizations_url":"https://api.github.com/users/GlenKPeterson/orgs","repos_url":"https://api.github.com/users/GlenKPeterson/repos","events_url":"https://api.github.com/users/GlenKPeterson/events{/privacy}","received_events_url":"https://api.github.com/users/GlenKPeterson/received_events","type":"User","site_admin":false},"repo":{"id":213486285,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM0ODYyODU=","name":"jetty.project","full_name":"GlenKPeterson/jetty.project","private":false,"owner":{"login":"GlenKPeterson","id":2416031,"node_id":"MDQ6VXNlcjI0MTYwMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/2416031?v=4","gravatar_id":"","url":"https://api.github.com/users/GlenKPeterson","html_url":"https://github.com/GlenKPeterson","followers_url":"https://api.github.com/users/GlenKPeterson/followers","following_url":"https://api.github.com/users/GlenKPeterson/following{/other_user}","gists_url":"https://api.github.com/users/GlenKPeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenKPeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenKPeterson/subscriptions","organizations_url":"https://api.github.com/users/GlenKPeterson/orgs","repos_url":"https://api.github.com/users/GlenKPeterson/repos","events_url":"https://api.github.com/users/GlenKPeterson/events{/privacy}","received_events_url":"https://api.github.com/users/GlenKPeterson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GlenKPeterson/jetty.project","description":"Forked from eclipse/jetty.project","fork":true,"url":"https://api.github.com/repos/GlenKPeterson/jetty.project","forks_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/forks","keys_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/teams","hooks_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/events","assignees_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/tags","blobs_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/languages","stargazers_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/subscription","commits_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/merges","archive_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/downloads","issues_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/GlenKPeterson/jetty.project/deployments","created_at":"2019-10-07T21:02:28Z","updated_at":"2019-10-08T18:42:38Z","pushed_at":"2019-10-08T18:42:34Z","git_url":"git://github.com/GlenKPeterson/jetty.project.git","ssh_url":"git@github.com:GlenKPeterson/jetty.project.git","clone_url":"https://github.com/GlenKPeterson/jetty.project.git","svn_url":"https://github.com/GlenKPeterson/jetty.project","homepage":"https://www.eclipse.org/jetty","size":133065,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"jetty-9.4.x"}},"base":{"label":"eclipse:jetty-9.4.x","ref":"jetty-9.4.x","sha":"d4270d9e97fa9b2b03e5a2610edc3ee85ca21949","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MjA3","name":"jetty.project","full_name":"eclipse/jetty.project","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.project","forks_url":"https://api.github.com/repos/eclipse/jetty.project/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.project/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.project/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.project/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.project/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.project/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.project/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.project/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.project/deployments","created_at":"2011-07-14T01:11:57Z","updated_at":"2019-10-15T11:00:30Z","pushed_at":"2019-10-15T18:34:51Z","git_url":"git://github.com/eclipse/jetty.project.git","ssh_url":"git@github.com:eclipse/jetty.project.git","clone_url":"https://github.com/eclipse/jetty.project.git","svn_url":"https://github.com/eclipse/jetty.project","homepage":"https://www.eclipse.org/jetty","size":134034,"stargazers_count":2653,"watchers_count":2653,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1470,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":429,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1470,"open_issues":429,"watchers":2653,"default_branch":"jetty-9.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/4164"},"issue":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/4164"},"comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/4164/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/4164/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/jetty.project/statuses/f18d1a4867b3757c84399067965738351dfbd8f3"}},"author_association":"NONE"}}
{"actor":{"display_login":"GlenKPeterson"}}