{"action":"created","comment":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/332769348","pull_request_review_id":299094876,"id":332769348,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjc2OTM0OA==","diff_hunk":"@@ -57,6 +57,21 @@ if (process.env.APP_SPEC_NETWORK_TYPE === \"sim1h\")\n   );\n }\n \n+if (process.env.APP_SPEC_NETWORK_TYPE === \"sim2h\")\n+{\n+    transport_config = {\n+        type: 'sim2h',\n+        sim2h_url: \"http://localhost:9000\",","path":"app_spec/test/index.js","position":8,"original_position":8,"commit_id":"53998d7ea5005ec57b4fd60a402061c4c4b231b6","original_commit_id":"53998d7ea5005ec57b4fd60a402061c4c4b231b6","user":{"login":"Connoropolous","id":1409121,"node_id":"MDQ6VXNlcjE0MDkxMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1409121?v=4","gravatar_id":"","url":"https://api.github.com/users/Connoropolous","html_url":"https://github.com/Connoropolous","followers_url":"https://api.github.com/users/Connoropolous/followers","following_url":"https://api.github.com/users/Connoropolous/following{/other_user}","gists_url":"https://api.github.com/users/Connoropolous/gists{/gist_id}","starred_url":"https://api.github.com/users/Connoropolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connoropolous/subscriptions","organizations_url":"https://api.github.com/users/Connoropolous/orgs","repos_url":"https://api.github.com/users/Connoropolous/repos","events_url":"https://api.github.com/users/Connoropolous/events{/privacy}","received_events_url":"https://api.github.com/users/Connoropolous/received_events","type":"User","site_admin":false},"body":"how is it that using `http` works here when the websocket is running at `wss://...`","created_at":"2019-10-08T23:00:53Z","updated_at":"2019-10-08T23:05:33Z","html_url":"https://github.com/holochain/holochain-rust/pull/1744#discussion_r332769348","pull_request_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/332769348"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/1744#discussion_r332769348"},"pull_request":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744"}}},"pull_request":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744","id":324956142,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0OTU2MTQy","html_url":"https://github.com/holochain/holochain-rust/pull/1744","diff_url":"https://github.com/holochain/holochain-rust/pull/1744.diff","patch_url":"https://github.com/holochain/holochain-rust/pull/1744.patch","issue_url":"https://api.github.com/repos/holochain/holochain-rust/issues/1744","number":1744,"state":"open","locked":false,"title":"Sim2h Integration","user":{"login":"zippy","id":3563,"node_id":"MDQ6VXNlcjM1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3563?v=4","gravatar_id":"","url":"https://api.github.com/users/zippy","html_url":"https://github.com/zippy","followers_url":"https://api.github.com/users/zippy/followers","following_url":"https://api.github.com/users/zippy/following{/other_user}","gists_url":"https://api.github.com/users/zippy/gists{/gist_id}","starred_url":"https://api.github.com/users/zippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zippy/subscriptions","organizations_url":"https://api.github.com/users/zippy/orgs","repos_url":"https://api.github.com/users/zippy/repos","events_url":"https://api.github.com/users/zippy/events{/privacy}","received_events_url":"https://api.github.com/users/zippy/received_events","type":"User","site_admin":false},"body":"## PR summary\r\n\r\n* [x] Sim2hWorker\r\n* [x] Sim2h server as nix command\r\n* [x] app-spec running against Sim2h\r\n\r\n## testing/benchmarking notes\r\n\r\n( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )\r\n\r\n## followups\r\n\r\n( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )\r\n\r\n## changelog\r\n\r\nPlease check one of the following, relating to the [CHANGELOG-UNRELEASED.md](https://github.com/holochain/holochain-rust/blob/develop/CHANGELOG-UNRELEASED.md)\r\n\r\n- [ ] this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format `- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)`\r\n- [ ] this is not a code change, or doesn't effect anyone outside holochain core development\r\n","created_at":"2019-10-05T16:48:57Z","updated_at":"2019-10-08T23:05:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a4c7cfc4f1b4d5cd7ab0dd9f9310280c924cd13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744/commits","review_comments_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744/comments","review_comment_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/issues/1744/comments","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/53998d7ea5005ec57b4fd60a402061c4c4b231b6","head":{"label":"holochain:sim2h","ref":"sim2h","sha":"53998d7ea5005ec57b4fd60a402061c4c4b231b6","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in rust, a container API for running it (with rust and node implementations), and hdk-rust library for writing Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2019-10-08T22:09:41Z","pushed_at":"2019-10-08T22:23:08Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":217086,"stargazers_count":762,"watchers_count":762,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":257,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":302,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":257,"open_issues":302,"watchers":762,"default_branch":"develop"}},"base":{"label":"holochain:develop","ref":"develop","sha":"b9c05b9ac6963cefa8785894b557220b6705a2b9","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in rust, a container API for running it (with rust and node implementations), and hdk-rust library for writing Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2019-10-08T22:09:41Z","pushed_at":"2019-10-08T22:23:08Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":217086,"stargazers_count":762,"watchers_count":762,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":257,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":302,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":257,"open_issues":302,"watchers":762,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/1744"},"issue":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/1744"},"comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/1744/comments"},"review_comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744/comments"},"review_comment":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/1744/commits"},"statuses":{"href":"https://api.github.com/repos/holochain/holochain-rust/statuses/53998d7ea5005ec57b4fd60a402061c4c4b231b6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Connoropolous"}}