{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/268734642","pull_request_review_id":218443754,"id":268734642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2ODczNDY0Mg==","diff_hunk":"@@ -977,6 +979,9 @@ RouteMatcher::RouteMatcher(const envoy::api::v2::RouteConfiguration& route_confi\n         default_virtual_host_ = virtual_host;\n       } else if (domain.size() > 0 && '*' == domain[0]) {\n         wildcard_virtual_host_suffixes_[domain.size() - 1].emplace(domain.substr(1), virtual_host);\n+      } else if (domain.size() > 0 && '*' == domain[domain.size() - 1]) {\n+        wildcard_virtual_host_prefixes_[domain.size() - 1].emplace(\n+            domain.substr(0, domain.size() - 1), virtual_host);","path":"source/common/router/config_impl.cc","position":35,"original_position":35,"commit_id":"4fa80f98740cab18ccbc2fda80c07dc2584a8735","original_commit_id":"4fa80f98740cab18ccbc2fda80c07dc2584a8735","user":{"login":"junr03","id":6007532,"node_id":"MDQ6VXNlcjYwMDc1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6007532?v=4","gravatar_id":"","url":"https://api.github.com/users/junr03","html_url":"https://github.com/junr03","followers_url":"https://api.github.com/users/junr03/followers","following_url":"https://api.github.com/users/junr03/following{/other_user}","gists_url":"https://api.github.com/users/junr03/gists{/gist_id}","starred_url":"https://api.github.com/users/junr03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junr03/subscriptions","organizations_url":"https://api.github.com/users/junr03/orgs","repos_url":"https://api.github.com/users/junr03/repos","events_url":"https://api.github.com/users/junr03/events{/privacy}","received_events_url":"https://api.github.com/users/junr03/received_events","type":"User","site_admin":false},"body":"Same with the suffixes above. But I just noticed that we don't detect duplicates (at least afaict here) for suffix or prefix domains, like we do for exact matches below. Is that intentional?","created_at":"2019-03-25T16:30:48Z","updated_at":"2019-03-25T16:40:43Z","html_url":"https://github.com/envoyproxy/envoy/pull/6303#discussion_r268734642","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/268734642"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/6303#discussion_r268734642"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303","id":261801100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxODAxMTAw","html_url":"https://github.com/envoyproxy/envoy/pull/6303","diff_url":"https://github.com/envoyproxy/envoy/pull/6303.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/6303.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/6303","number":6303,"state":"open","locked":false,"title":"router: support prefix wildcards in virtual hosts domains","user":{"login":"bartebor","id":3404311,"node_id":"MDQ6VXNlcjM0MDQzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3404311?v=4","gravatar_id":"","url":"https://api.github.com/users/bartebor","html_url":"https://github.com/bartebor","followers_url":"https://api.github.com/users/bartebor/followers","following_url":"https://api.github.com/users/bartebor/following{/other_user}","gists_url":"https://api.github.com/users/bartebor/gists{/gist_id}","starred_url":"https://api.github.com/users/bartebor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartebor/subscriptions","organizations_url":"https://api.github.com/users/bartebor/orgs","repos_url":"https://api.github.com/users/bartebor/repos","events_url":"https://api.github.com/users/bartebor/events{/privacy}","received_events_url":"https://api.github.com/users/bartebor/received_events","type":"User","site_admin":false},"body":"Description: Adds prefix wildcard support (`foo.*`) in virtual host domains\r\nRisk Level: Low (does not change current behavior)\r\nTesting: Unit tests\r\nDocs Changes: updated `domains` field documentation in proto file\r\nRelease Notes: updated\r\nFixes #1269","created_at":"2019-03-16T21:25:29Z","updated_at":"2019-03-25T16:40:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"205485727df730551602ec9e00e4b3f2e0992a31","assignee":{"login":"junr03","id":6007532,"node_id":"MDQ6VXNlcjYwMDc1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6007532?v=4","gravatar_id":"","url":"https://api.github.com/users/junr03","html_url":"https://github.com/junr03","followers_url":"https://api.github.com/users/junr03/followers","following_url":"https://api.github.com/users/junr03/following{/other_user}","gists_url":"https://api.github.com/users/junr03/gists{/gist_id}","starred_url":"https://api.github.com/users/junr03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junr03/subscriptions","organizations_url":"https://api.github.com/users/junr03/orgs","repos_url":"https://api.github.com/users/junr03/repos","events_url":"https://api.github.com/users/junr03/events{/privacy}","received_events_url":"https://api.github.com/users/junr03/received_events","type":"User","site_admin":false},"assignees":[{"login":"junr03","id":6007532,"node_id":"MDQ6VXNlcjYwMDc1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6007532?v=4","gravatar_id":"","url":"https://api.github.com/users/junr03","html_url":"https://github.com/junr03","followers_url":"https://api.github.com/users/junr03/followers","following_url":"https://api.github.com/users/junr03/following{/other_user}","gists_url":"https://api.github.com/users/junr03/gists{/gist_id}","starred_url":"https://api.github.com/users/junr03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junr03/subscriptions","organizations_url":"https://api.github.com/users/junr03/orgs","repos_url":"https://api.github.com/users/junr03/repos","events_url":"https://api.github.com/users/junr03/events{/privacy}","received_events_url":"https://api.github.com/users/junr03/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/6303/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/4fa80f98740cab18ccbc2fda80c07dc2584a8735","head":{"label":"bartebor:trailing_wildcards","ref":"trailing_wildcards","sha":"4fa80f98740cab18ccbc2fda80c07dc2584a8735","user":{"login":"bartebor","id":3404311,"node_id":"MDQ6VXNlcjM0MDQzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3404311?v=4","gravatar_id":"","url":"https://api.github.com/users/bartebor","html_url":"https://github.com/bartebor","followers_url":"https://api.github.com/users/bartebor/followers","following_url":"https://api.github.com/users/bartebor/following{/other_user}","gists_url":"https://api.github.com/users/bartebor/gists{/gist_id}","starred_url":"https://api.github.com/users/bartebor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartebor/subscriptions","organizations_url":"https://api.github.com/users/bartebor/orgs","repos_url":"https://api.github.com/users/bartebor/repos","events_url":"https://api.github.com/users/bartebor/events{/privacy}","received_events_url":"https://api.github.com/users/bartebor/received_events","type":"User","site_admin":false},"repo":{"id":169923166,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk5MjMxNjY=","name":"envoy","full_name":"bartebor/envoy","private":false,"owner":{"login":"bartebor","id":3404311,"node_id":"MDQ6VXNlcjM0MDQzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3404311?v=4","gravatar_id":"","url":"https://api.github.com/users/bartebor","html_url":"https://github.com/bartebor","followers_url":"https://api.github.com/users/bartebor/followers","following_url":"https://api.github.com/users/bartebor/following{/other_user}","gists_url":"https://api.github.com/users/bartebor/gists{/gist_id}","starred_url":"https://api.github.com/users/bartebor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartebor/subscriptions","organizations_url":"https://api.github.com/users/bartebor/orgs","repos_url":"https://api.github.com/users/bartebor/repos","events_url":"https://api.github.com/users/bartebor/events{/privacy}","received_events_url":"https://api.github.com/users/bartebor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bartebor/envoy","description":"Cloud-native high-performance edge/middle/service proxy","fork":true,"url":"https://api.github.com/repos/bartebor/envoy","forks_url":"https://api.github.com/repos/bartebor/envoy/forks","keys_url":"https://api.github.com/repos/bartebor/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartebor/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartebor/envoy/teams","hooks_url":"https://api.github.com/repos/bartebor/envoy/hooks","issue_events_url":"https://api.github.com/repos/bartebor/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/bartebor/envoy/events","assignees_url":"https://api.github.com/repos/bartebor/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/bartebor/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/bartebor/envoy/tags","blobs_url":"https://api.github.com/repos/bartebor/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartebor/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartebor/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartebor/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartebor/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/bartebor/envoy/languages","stargazers_url":"https://api.github.com/repos/bartebor/envoy/stargazers","contributors_url":"https://api.github.com/repos/bartebor/envoy/contributors","subscribers_url":"https://api.github.com/repos/bartebor/envoy/subscribers","subscription_url":"https://api.github.com/repos/bartebor/envoy/subscription","commits_url":"https://api.github.com/repos/bartebor/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartebor/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartebor/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartebor/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartebor/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/bartebor/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartebor/envoy/merges","archive_url":"https://api.github.com/repos/bartebor/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartebor/envoy/downloads","issues_url":"https://api.github.com/repos/bartebor/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/bartebor/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/bartebor/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/bartebor/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartebor/envoy/labels{/name}","releases_url":"https://api.github.com/repos/bartebor/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/bartebor/envoy/deployments","created_at":"2019-02-09T23:03:48Z","updated_at":"2019-02-09T23:03:57Z","pushed_at":"2019-03-18T19:09:31Z","git_url":"git://github.com/bartebor/envoy.git","ssh_url":"git@github.com:bartebor/envoy.git","clone_url":"https://github.com/bartebor/envoy.git","svn_url":"https://github.com/bartebor/envoy","homepage":"https://www.envoyproxy.io","size":30622,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"628d1668d7dc9244e3a8fa3d3fbabca23e92e23d","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"Cloud-native high-performance edge/middle/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2019-03-25T16:33:16Z","pushed_at":"2019-03-25T16:33:08Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":30938,"stargazers_count":8910,"watchers_count":8910,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1338,"mirror_url":null,"archived":false,"open_issues_count":455,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1338,"open_issues":455,"watchers":8910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/6303"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/6303"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/6303/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/6303/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/4fa80f98740cab18ccbc2fda80c07dc2584a8735"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"junr03"}}