{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/protobuf/pulls/comments/326126590","pull_request_review_id":290404490,"id":326126590,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjEyNjU5MA==","diff_hunk":"@@ -400,3 +406,48 @@ void _mergeFromProto3Json(\n \n   recursionHelper(json, fieldSet);\n }\n+\n+bool _isAsciiLetter(int char) {\n+  const lowerA = 97;\n+  const lowerZ = 122;\n+  const capitalA = 65;\n+  const capitalZ = 90;\n+\n+  return (capitalA <= char && char <= capitalZ) ||\n+      (lowerA <= char && char <= lowerZ);\n+}\n+\n+/// Returns true if [a] and [b] are the same ignoring case and all instances of\n+///  `-` and `_`.\n+bool _permissiveCompare(String a, String b) {\n+  const dash = 45;\n+  const underscore = 95;\n+\n+  // Enum names are always ascii.\n+  int i = 0;\n+  int j = 0;\n+\n+  while (i < a.length && j < b.length) {\n+    int ca = a.codeUnitAt(i);\n+    if (ca == dash || ca == underscore) {\n+      i++; continue;","path":"protobuf/lib/src/protobuf/proto3_json.dart","position":60,"original_position":60,"commit_id":"07dd74b71f09866297dcbec959e65a542ff2219b","original_commit_id":"07dd74b71f09866297dcbec959e65a542ff2219b","user":{"login":"lrhn","id":4865287,"node_id":"MDQ6VXNlcjQ4NjUyODc=","avatar_url":"https://avatars3.githubusercontent.com/u/4865287?v=4","gravatar_id":"","url":"https://api.github.com/users/lrhn","html_url":"https://github.com/lrhn","followers_url":"https://api.github.com/users/lrhn/followers","following_url":"https://api.github.com/users/lrhn/following{/other_user}","gists_url":"https://api.github.com/users/lrhn/gists{/gist_id}","starred_url":"https://api.github.com/users/lrhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrhn/subscriptions","organizations_url":"https://api.github.com/users/lrhn/orgs","repos_url":"https://api.github.com/users/lrhn/repos","events_url":"https://api.github.com/users/lrhn/events{/privacy}","received_events_url":"https://api.github.com/users/lrhn/received_events","type":"User","site_admin":false},"body":"Has this been formatted by the formatter?","created_at":"2019-09-19T11:37:17Z","updated_at":"2019-09-19T11:46:05Z","html_url":"https://github.com/dart-lang/protobuf/pull/294#discussion_r326126590","pull_request_url":"https://api.github.com/repos/dart-lang/protobuf/pulls/294","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/protobuf/pulls/comments/326126590"},"html":{"href":"https://github.com/dart-lang/protobuf/pull/294#discussion_r326126590"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/protobuf/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/protobuf/pulls/294","id":318827800,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE4ODI3ODAw","html_url":"https://github.com/dart-lang/protobuf/pull/294","diff_url":"https://github.com/dart-lang/protobuf/pull/294.diff","patch_url":"https://github.com/dart-lang/protobuf/pull/294.patch","issue_url":"https://api.github.com/repos/dart-lang/protobuf/issues/294","number":294,"state":"open","locked":false,"title":"Add option to do permissive parsing of proto3 json enums","user":{"login":"sigurdm","id":8613953,"node_id":"MDQ6VXNlcjg2MTM5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8613953?v=4","gravatar_id":"","url":"https://api.github.com/users/sigurdm","html_url":"https://github.com/sigurdm","followers_url":"https://api.github.com/users/sigurdm/followers","following_url":"https://api.github.com/users/sigurdm/following{/other_user}","gists_url":"https://api.github.com/users/sigurdm/gists{/gist_id}","starred_url":"https://api.github.com/users/sigurdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigurdm/subscriptions","organizations_url":"https://api.github.com/users/sigurdm/orgs","repos_url":"https://api.github.com/users/sigurdm/repos","events_url":"https://api.github.com/users/sigurdm/events{/privacy}","received_events_url":"https://api.github.com/users/sigurdm/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-18T13:58:04Z","updated_at":"2019-09-19T11:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05e76f26c728c89ddfaf1a9a0766444bfdb59c7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":421017611,"node_id":"MDU6TGFiZWw0MjEwMTc2MTE=","url":"https://api.github.com/repos/dart-lang/protobuf/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/protobuf/pulls/294/commits","review_comments_url":"https://api.github.com/repos/dart-lang/protobuf/pulls/294/comments","review_comment_url":"https://api.github.com/repos/dart-lang/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/protobuf/issues/294/comments","statuses_url":"https://api.github.com/repos/dart-lang/protobuf/statuses/07dd74b71f09866297dcbec959e65a542ff2219b","head":{"label":"sigurdm:proto3_json_case_insensitive_enums","ref":"proto3_json_case_insensitive_enums","sha":"07dd74b71f09866297dcbec959e65a542ff2219b","user":{"login":"sigurdm","id":8613953,"node_id":"MDQ6VXNlcjg2MTM5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8613953?v=4","gravatar_id":"","url":"https://api.github.com/users/sigurdm","html_url":"https://github.com/sigurdm","followers_url":"https://api.github.com/users/sigurdm/followers","following_url":"https://api.github.com/users/sigurdm/following{/other_user}","gists_url":"https://api.github.com/users/sigurdm/gists{/gist_id}","starred_url":"https://api.github.com/users/sigurdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigurdm/subscriptions","organizations_url":"https://api.github.com/users/sigurdm/orgs","repos_url":"https://api.github.com/users/sigurdm/repos","events_url":"https://api.github.com/users/sigurdm/events{/privacy}","received_events_url":"https://api.github.com/users/sigurdm/received_events","type":"User","site_admin":false},"repo":{"id":140851229,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NTEyMjk=","name":"protobuf","full_name":"sigurdm/protobuf","private":false,"owner":{"login":"sigurdm","id":8613953,"node_id":"MDQ6VXNlcjg2MTM5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/8613953?v=4","gravatar_id":"","url":"https://api.github.com/users/sigurdm","html_url":"https://github.com/sigurdm","followers_url":"https://api.github.com/users/sigurdm/followers","following_url":"https://api.github.com/users/sigurdm/following{/other_user}","gists_url":"https://api.github.com/users/sigurdm/gists{/gist_id}","starred_url":"https://api.github.com/users/sigurdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigurdm/subscriptions","organizations_url":"https://api.github.com/users/sigurdm/orgs","repos_url":"https://api.github.com/users/sigurdm/repos","events_url":"https://api.github.com/users/sigurdm/events{/privacy}","received_events_url":"https://api.github.com/users/sigurdm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sigurdm/protobuf","description":"Runtime library for Dart protobufs","fork":true,"url":"https://api.github.com/repos/sigurdm/protobuf","forks_url":"https://api.github.com/repos/sigurdm/protobuf/forks","keys_url":"https://api.github.com/repos/sigurdm/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigurdm/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigurdm/protobuf/teams","hooks_url":"https://api.github.com/repos/sigurdm/protobuf/hooks","issue_events_url":"https://api.github.com/repos/sigurdm/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/sigurdm/protobuf/events","assignees_url":"https://api.github.com/repos/sigurdm/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/sigurdm/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/sigurdm/protobuf/tags","blobs_url":"https://api.github.com/repos/sigurdm/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigurdm/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigurdm/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigurdm/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigurdm/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/sigurdm/protobuf/languages","stargazers_url":"https://api.github.com/repos/sigurdm/protobuf/stargazers","contributors_url":"https://api.github.com/repos/sigurdm/protobuf/contributors","subscribers_url":"https://api.github.com/repos/sigurdm/protobuf/subscribers","subscription_url":"https://api.github.com/repos/sigurdm/protobuf/subscription","commits_url":"https://api.github.com/repos/sigurdm/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigurdm/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigurdm/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigurdm/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/sigurdm/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/sigurdm/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigurdm/protobuf/merges","archive_url":"https://api.github.com/repos/sigurdm/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigurdm/protobuf/downloads","issues_url":"https://api.github.com/repos/sigurdm/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/sigurdm/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/sigurdm/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/sigurdm/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigurdm/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/sigurdm/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/sigurdm/protobuf/deployments","created_at":"2018-07-13T13:36:29Z","updated_at":"2019-02-12T11:32:49Z","pushed_at":"2019-09-19T10:45:26Z","git_url":"git://github.com/sigurdm/protobuf.git","ssh_url":"git@github.com:sigurdm/protobuf.git","clone_url":"https://github.com/sigurdm/protobuf.git","svn_url":"https://github.com/sigurdm/protobuf","homepage":"https://pub.dartlang.org/packages/protobuf","size":1899,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"53ce84b6c8922438b798dbfad845323dc6ad5c09","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":11317561,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxNzU2MQ==","name":"protobuf","full_name":"dart-lang/protobuf","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/protobuf","description":"Runtime library for Dart protobufs","fork":false,"url":"https://api.github.com/repos/dart-lang/protobuf","forks_url":"https://api.github.com/repos/dart-lang/protobuf/forks","keys_url":"https://api.github.com/repos/dart-lang/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/protobuf/teams","hooks_url":"https://api.github.com/repos/dart-lang/protobuf/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/protobuf/events","assignees_url":"https://api.github.com/repos/dart-lang/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/protobuf/tags","blobs_url":"https://api.github.com/repos/dart-lang/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/protobuf/languages","stargazers_url":"https://api.github.com/repos/dart-lang/protobuf/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/protobuf/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/protobuf/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/protobuf/subscription","commits_url":"https://api.github.com/repos/dart-lang/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/protobuf/merges","archive_url":"https://api.github.com/repos/dart-lang/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/protobuf/downloads","issues_url":"https://api.github.com/repos/dart-lang/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/protobuf/deployments","created_at":"2013-07-10T16:36:09Z","updated_at":"2019-09-18T09:07:25Z","pushed_at":"2019-09-19T10:45:27Z","git_url":"git://github.com/dart-lang/protobuf.git","ssh_url":"git@github.com:dart-lang/protobuf.git","clone_url":"https://github.com/dart-lang/protobuf.git","svn_url":"https://github.com/dart-lang/protobuf","homepage":"https://pub.dev/packages/protobuf","size":1754,"stargazers_count":180,"watchers_count":180,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":59,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":74,"open_issues":59,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/protobuf/pulls/294"},"html":{"href":"https://github.com/dart-lang/protobuf/pull/294"},"issue":{"href":"https://api.github.com/repos/dart-lang/protobuf/issues/294"},"comments":{"href":"https://api.github.com/repos/dart-lang/protobuf/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/protobuf/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/protobuf/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/protobuf/statuses/07dd74b71f09866297dcbec959e65a542ff2219b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lrhn"}}