{"action":"created","comment":{"url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments/349317264","pull_request_review_id":321186797,"id":349317264,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0OTMxNzI2NA==","diff_hunk":"@@ -52,7 +55,10 @@ topicIsBIT(const char* name, const char* type)\n   ) || (\n     !ACE_OS::strcmp(name, BUILT_IN_PUBLICATION_TOPIC) &&\n     !ACE_OS::strcmp(type, BUILT_IN_PUBLICATION_TOPIC_TYPE)\n-  );\n+  ) || (\n+\t!ACE_OS::strcmp(name, BUILT_IN_PARTICIPANT_LOCATION_TOPIC) &&","path":"dds/DCPS/BuiltInTopicUtils.h","position":16,"original_position":16,"commit_id":"33683b363ef6d6659142644cb5f36fbbfb07e395","original_commit_id":"33683b363ef6d6659142644cb5f36fbbfb07e395","user":{"login":"iguessthislldo","id":5941194,"node_id":"MDQ6VXNlcjU5NDExOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5941194?v=4","gravatar_id":"","url":"https://api.github.com/users/iguessthislldo","html_url":"https://github.com/iguessthislldo","followers_url":"https://api.github.com/users/iguessthislldo/followers","following_url":"https://api.github.com/users/iguessthislldo/following{/other_user}","gists_url":"https://api.github.com/users/iguessthislldo/gists{/gist_id}","starred_url":"https://api.github.com/users/iguessthislldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iguessthislldo/subscriptions","organizations_url":"https://api.github.com/users/iguessthislldo/orgs","repos_url":"https://api.github.com/users/iguessthislldo/repos","events_url":"https://api.github.com/users/iguessthislldo/events{/privacy}","received_events_url":"https://api.github.com/users/iguessthislldo/received_events","type":"User","site_admin":false},"body":"The fuzz script is going to catch this, but there are tabs here.","created_at":"2019-11-21T21:06:06Z","updated_at":"2019-11-21T21:06:06Z","html_url":"https://github.com/objectcomputing/OpenDDS/pull/1389#discussion_r349317264","pull_request_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments/349317264"},"html":{"href":"https://github.com/objectcomputing/OpenDDS/pull/1389#discussion_r349317264"},"pull_request":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389"}}},"pull_request":{"url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389","id":344231657,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0MjMxNjU3","html_url":"https://github.com/objectcomputing/OpenDDS/pull/1389","diff_url":"https://github.com/objectcomputing/OpenDDS/pull/1389.diff","patch_url":"https://github.com/objectcomputing/OpenDDS/pull/1389.patch","issue_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/1389","number":1389,"state":"open","locked":false,"title":"Connect method","user":{"login":"jonesc-oci","id":51006990,"node_id":"MDQ6VXNlcjUxMDA2OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/51006990?v=4","gravatar_id":"","url":"https://api.github.com/users/jonesc-oci","html_url":"https://github.com/jonesc-oci","followers_url":"https://api.github.com/users/jonesc-oci/followers","following_url":"https://api.github.com/users/jonesc-oci/following{/other_user}","gists_url":"https://api.github.com/users/jonesc-oci/gists{/gist_id}","starred_url":"https://api.github.com/users/jonesc-oci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonesc-oci/subscriptions","organizations_url":"https://api.github.com/users/jonesc-oci/orgs","repos_url":"https://api.github.com/users/jonesc-oci/repos","events_url":"https://api.github.com/users/jonesc-oci/events{/privacy}","received_events_url":"https://api.github.com/users/jonesc-oci/received_events","type":"User","site_admin":false},"body":"These are changes for the new participant location built-in topic. They include a test for the new feature as well as a shutdown listener for the ICE agent which fixes a memory issue.","created_at":"2019-11-21T21:00:48Z","updated_at":"2019-11-21T21:06:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/1389/comments","statuses_url":"https://api.github.com/repos/objectcomputing/OpenDDS/statuses/33683b363ef6d6659142644cb5f36fbbfb07e395","head":{"label":"jonesc-oci:connect_method","ref":"connect_method","sha":"33683b363ef6d6659142644cb5f36fbbfb07e395","user":{"login":"jonesc-oci","id":51006990,"node_id":"MDQ6VXNlcjUxMDA2OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/51006990?v=4","gravatar_id":"","url":"https://api.github.com/users/jonesc-oci","html_url":"https://github.com/jonesc-oci","followers_url":"https://api.github.com/users/jonesc-oci/followers","following_url":"https://api.github.com/users/jonesc-oci/following{/other_user}","gists_url":"https://api.github.com/users/jonesc-oci/gists{/gist_id}","starred_url":"https://api.github.com/users/jonesc-oci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonesc-oci/subscriptions","organizations_url":"https://api.github.com/users/jonesc-oci/orgs","repos_url":"https://api.github.com/users/jonesc-oci/repos","events_url":"https://api.github.com/users/jonesc-oci/events{/privacy}","received_events_url":"https://api.github.com/users/jonesc-oci/received_events","type":"User","site_admin":false},"repo":{"id":221567288,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE1NjcyODg=","name":"OpenDDS","full_name":"jonesc-oci/OpenDDS","private":false,"owner":{"login":"jonesc-oci","id":51006990,"node_id":"MDQ6VXNlcjUxMDA2OTkw","avatar_url":"https://avatars0.githubusercontent.com/u/51006990?v=4","gravatar_id":"","url":"https://api.github.com/users/jonesc-oci","html_url":"https://github.com/jonesc-oci","followers_url":"https://api.github.com/users/jonesc-oci/followers","following_url":"https://api.github.com/users/jonesc-oci/following{/other_user}","gists_url":"https://api.github.com/users/jonesc-oci/gists{/gist_id}","starred_url":"https://api.github.com/users/jonesc-oci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonesc-oci/subscriptions","organizations_url":"https://api.github.com/users/jonesc-oci/orgs","repos_url":"https://api.github.com/users/jonesc-oci/repos","events_url":"https://api.github.com/users/jonesc-oci/events{/privacy}","received_events_url":"https://api.github.com/users/jonesc-oci/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jonesc-oci/OpenDDS","description":"OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS). OpenDDS also supports Java bindings through JNI.","fork":true,"url":"https://api.github.com/repos/jonesc-oci/OpenDDS","forks_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/forks","keys_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/teams","hooks_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/hooks","issue_events_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/issues/events{/number}","events_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/events","assignees_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/assignees{/user}","branches_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/branches{/branch}","tags_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/tags","blobs_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/statuses/{sha}","languages_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/languages","stargazers_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/stargazers","contributors_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/contributors","subscribers_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/subscribers","subscription_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/subscription","commits_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/contents/{+path}","compare_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/merges","archive_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/downloads","issues_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/issues{/number}","pulls_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/pulls{/number}","milestones_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/milestones{/number}","notifications_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/labels{/name}","releases_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/releases{/id}","deployments_url":"https://api.github.com/repos/jonesc-oci/OpenDDS/deployments","created_at":"2019-11-13T22:57:29Z","updated_at":"2019-11-13T22:57:30Z","pushed_at":"2019-11-21T20:46:16Z","git_url":"git://github.com/jonesc-oci/OpenDDS.git","ssh_url":"git@github.com:jonesc-oci/OpenDDS.git","clone_url":"https://github.com/jonesc-oci/OpenDDS.git","svn_url":"https://github.com/jonesc-oci/OpenDDS","homepage":"http://www.opendds.org","size":68159,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"objectcomputing:master","ref":"master","sha":"e2c33126a1a3f71575114d6202e10fabefa2b9a7","user":{"login":"objectcomputing","id":3903550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDM1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/3903550?v=4","gravatar_id":"","url":"https://api.github.com/users/objectcomputing","html_url":"https://github.com/objectcomputing","followers_url":"https://api.github.com/users/objectcomputing/followers","following_url":"https://api.github.com/users/objectcomputing/following{/other_user}","gists_url":"https://api.github.com/users/objectcomputing/gists{/gist_id}","starred_url":"https://api.github.com/users/objectcomputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectcomputing/subscriptions","organizations_url":"https://api.github.com/users/objectcomputing/orgs","repos_url":"https://api.github.com/users/objectcomputing/repos","events_url":"https://api.github.com/users/objectcomputing/events{/privacy}","received_events_url":"https://api.github.com/users/objectcomputing/received_events","type":"Organization","site_admin":false},"repo":{"id":30720952,"node_id":"MDEwOlJlcG9zaXRvcnkzMDcyMDk1Mg==","name":"OpenDDS","full_name":"objectcomputing/OpenDDS","private":false,"owner":{"login":"objectcomputing","id":3903550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDM1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/3903550?v=4","gravatar_id":"","url":"https://api.github.com/users/objectcomputing","html_url":"https://github.com/objectcomputing","followers_url":"https://api.github.com/users/objectcomputing/followers","following_url":"https://api.github.com/users/objectcomputing/following{/other_user}","gists_url":"https://api.github.com/users/objectcomputing/gists{/gist_id}","starred_url":"https://api.github.com/users/objectcomputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectcomputing/subscriptions","organizations_url":"https://api.github.com/users/objectcomputing/orgs","repos_url":"https://api.github.com/users/objectcomputing/repos","events_url":"https://api.github.com/users/objectcomputing/events{/privacy}","received_events_url":"https://api.github.com/users/objectcomputing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/objectcomputing/OpenDDS","description":"OpenDDS is an open source C++ implementation of the Object Management Group (OMG) Data Distribution Service (DDS). OpenDDS also supports Java bindings through JNI.","fork":false,"url":"https://api.github.com/repos/objectcomputing/OpenDDS","forks_url":"https://api.github.com/repos/objectcomputing/OpenDDS/forks","keys_url":"https://api.github.com/repos/objectcomputing/OpenDDS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectcomputing/OpenDDS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectcomputing/OpenDDS/teams","hooks_url":"https://api.github.com/repos/objectcomputing/OpenDDS/hooks","issue_events_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/events{/number}","events_url":"https://api.github.com/repos/objectcomputing/OpenDDS/events","assignees_url":"https://api.github.com/repos/objectcomputing/OpenDDS/assignees{/user}","branches_url":"https://api.github.com/repos/objectcomputing/OpenDDS/branches{/branch}","tags_url":"https://api.github.com/repos/objectcomputing/OpenDDS/tags","blobs_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectcomputing/OpenDDS/statuses/{sha}","languages_url":"https://api.github.com/repos/objectcomputing/OpenDDS/languages","stargazers_url":"https://api.github.com/repos/objectcomputing/OpenDDS/stargazers","contributors_url":"https://api.github.com/repos/objectcomputing/OpenDDS/contributors","subscribers_url":"https://api.github.com/repos/objectcomputing/OpenDDS/subscribers","subscription_url":"https://api.github.com/repos/objectcomputing/OpenDDS/subscription","commits_url":"https://api.github.com/repos/objectcomputing/OpenDDS/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectcomputing/OpenDDS/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectcomputing/OpenDDS/contents/{+path}","compare_url":"https://api.github.com/repos/objectcomputing/OpenDDS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectcomputing/OpenDDS/merges","archive_url":"https://api.github.com/repos/objectcomputing/OpenDDS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectcomputing/OpenDDS/downloads","issues_url":"https://api.github.com/repos/objectcomputing/OpenDDS/issues{/number}","pulls_url":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls{/number}","milestones_url":"https://api.github.com/repos/objectcomputing/OpenDDS/milestones{/number}","notifications_url":"https://api.github.com/repos/objectcomputing/OpenDDS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectcomputing/OpenDDS/labels{/name}","releases_url":"https://api.github.com/repos/objectcomputing/OpenDDS/releases{/id}","deployments_url":"https://api.github.com/repos/objectcomputing/OpenDDS/deployments","created_at":"2015-02-12T20:01:26Z","updated_at":"2019-11-21T19:48:40Z","pushed_at":"2019-11-21T21:00:49Z","git_url":"git://github.com/objectcomputing/OpenDDS.git","ssh_url":"git@github.com:objectcomputing/OpenDDS.git","clone_url":"https://github.com/objectcomputing/OpenDDS.git","svn_url":"https://github.com/objectcomputing/OpenDDS","homepage":"http://www.opendds.org","size":68491,"stargazers_count":475,"watchers_count":475,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":208,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":59,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":208,"open_issues":59,"watchers":475,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389"},"html":{"href":"https://github.com/objectcomputing/OpenDDS/pull/1389"},"issue":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/1389"},"comments":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/objectcomputing/OpenDDS/statuses/33683b363ef6d6659142644cb5f36fbbfb07e395"}},"author_association":"NONE"}}
{"actor":{"display_login":"iguessthislldo"}}