{"action":"closed","number":15633,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/15633","id":263170934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYzMTcwOTM0","html_url":"https://github.com/bitcoin/bitcoin/pull/15633","diff_url":"https://github.com/bitcoin/bitcoin/pull/15633.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/15633.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/15633","number":15633,"state":"closed","locked":false,"title":"Ignore BIP-152 HB requests from non-witness peers.","user":{"login":"gmaxwell","id":858454,"node_id":"MDQ6VXNlcjg1ODQ1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/858454?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"body":"To speed up block propagation  BIP-152 allows peers to signal that\r\n they would like us to announce new blocks to them by just sending\r\n a compact block.  But propagation speed through non-witness peers\r\n is irrelevant, so ignore the request for these and save bandwidth.\r\n\r\nInstead we'll just send them a header and they can getdata the\r\n (compact)block if they actually need it from us.\r\n","created_at":"2019-03-21T09:55:23Z","updated_at":"2019-03-21T11:15:44Z","closed_at":"2019-03-21T11:15:43Z","merged_at":null,"merge_commit_sha":"ed91253229612f7f831e315cbb15db456a9ccc4c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98298007,"node_id":"MDU6TGFiZWw5ODI5ODAwNw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/15633/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/15633/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/15633/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5069427f76a1f4fc5c9ffb69dc105b56bb53d255","head":{"label":"gmaxwell:201803-nohbcbfornonwit","ref":"201803-nohbcbfornonwit","sha":"5069427f76a1f4fc5c9ffb69dc105b56bb53d255","user":{"login":"gmaxwell","id":858454,"node_id":"MDQ6VXNlcjg1ODQ1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/858454?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"repo":{"id":50618592,"node_id":"MDEwOlJlcG9zaXRvcnk1MDYxODU5Mg==","name":"bitcoin","full_name":"gmaxwell/bitcoin","private":false,"owner":{"login":"gmaxwell","id":858454,"node_id":"MDQ6VXNlcjg1ODQ1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/858454?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gmaxwell/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/gmaxwell/bitcoin","forks_url":"https://api.github.com/repos/gmaxwell/bitcoin/forks","keys_url":"https://api.github.com/repos/gmaxwell/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmaxwell/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmaxwell/bitcoin/teams","hooks_url":"https://api.github.com/repos/gmaxwell/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/gmaxwell/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/gmaxwell/bitcoin/events","assignees_url":"https://api.github.com/repos/gmaxwell/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/gmaxwell/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/gmaxwell/bitcoin/tags","blobs_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmaxwell/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/gmaxwell/bitcoin/languages","stargazers_url":"https://api.github.com/repos/gmaxwell/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/gmaxwell/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/gmaxwell/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/gmaxwell/bitcoin/subscription","commits_url":"https://api.github.com/repos/gmaxwell/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmaxwell/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmaxwell/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmaxwell/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmaxwell/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/gmaxwell/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmaxwell/bitcoin/merges","archive_url":"https://api.github.com/repos/gmaxwell/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmaxwell/bitcoin/downloads","issues_url":"https://api.github.com/repos/gmaxwell/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/gmaxwell/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/gmaxwell/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/gmaxwell/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmaxwell/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/gmaxwell/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/gmaxwell/bitcoin/deployments","created_at":"2016-01-28T22:29:23Z","updated_at":"2018-12-09T13:36:01Z","pushed_at":"2019-03-21T09:51:34Z","git_url":"git://github.com/gmaxwell/bitcoin.git","ssh_url":"git@github.com:gmaxwell/bitcoin.git","clone_url":"https://github.com/gmaxwell/bitcoin.git","svn_url":"https://github.com/gmaxwell/bitcoin","homepage":"https://bitcoin.org/en/download","size":117500,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"717fd58c4ba5c64778fa9a8bf6bbf5ae1164df3f","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2019-03-21T10:59:52Z","pushed_at":"2019-03-21T10:53:18Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":123869,"stargazers_count":37545,"watchers_count":37545,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":22295,"mirror_url":null,"archived":false,"open_issues_count":912,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22295,"open_issues":912,"watchers":37545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/15633"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/15633"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/15633"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/15633/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/15633/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/15633/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/5069427f76a1f4fc5c9ffb69dc105b56bb53d255"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"gmaxwell"}}