{"action":"created","issue":{"url":"https://api.github.com/repos/spatie/laravel-medialibrary/issues/1452","repository_url":"https://api.github.com/repos/spatie/laravel-medialibrary","labels_url":"https://api.github.com/repos/spatie/laravel-medialibrary/issues/1452/labels{/name}","comments_url":"https://api.github.com/repos/spatie/laravel-medialibrary/issues/1452/comments","events_url":"https://api.github.com/repos/spatie/laravel-medialibrary/issues/1452/events","html_url":"https://github.com/spatie/laravel-medialibrary/pull/1452","id":446532353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwNzEyNzI4","number":1452,"title":"Zipstream Dependency - optionally allow later version of zipstream","user":{"login":"rossriley","id":5082,"node_id":"MDQ6VXNlcjUwODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5082?v=4","gravatar_id":"","url":"https://api.github.com/users/rossriley","html_url":"https://github.com/rossriley","followers_url":"https://api.github.com/users/rossriley/followers","following_url":"https://api.github.com/users/rossriley/following{/other_user}","gists_url":"https://api.github.com/users/rossriley/gists{/gist_id}","starred_url":"https://api.github.com/users/rossriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossriley/subscriptions","organizations_url":"https://api.github.com/users/rossriley/orgs","repos_url":"https://api.github.com/users/rossriley/repos","events_url":"https://api.github.com/users/rossriley/events{/privacy}","received_events_url":"https://api.github.com/users/rossriley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-05-21T10:09:55Z","updated_at":"2019-07-09T16:53:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/spatie/laravel-medialibrary/pulls/1452","html_url":"https://github.com/spatie/laravel-medialibrary/pull/1452","diff_url":"https://github.com/spatie/laravel-medialibrary/pull/1452.diff","patch_url":"https://github.com/spatie/laravel-medialibrary/pull/1452.patch"},"body":"This PR just allows the library to be more flexible with its zipstream dependency.\r\n\r\nCurrent constraint is fixed to pre-release version which is now over a year out of date.\r\n\r\nSince this library uses just the basic features of the ZipStream class, the usage is compatible with both 0.x versions and 1.x versions, adding either as a dependency allows users to specify either in their local `composer.json` file.\r\n\r\nAll tests pass with either version installed, currently tested 0.5.2 and 1.1 which are the latest versions on both constraints."},"comment":{"url":"https://api.github.com/repos/spatie/laravel-medialibrary/issues/comments/509721956","html_url":"https://github.com/spatie/laravel-medialibrary/pull/1452#issuecomment-509721956","issue_url":"https://api.github.com/repos/spatie/laravel-medialibrary/issues/1452","id":509721956,"node_id":"MDEyOklzc3VlQ29tbWVudDUwOTcyMTk1Ng==","user":{"login":"reppair","id":10784954,"node_id":"MDQ6VXNlcjEwNzg0OTU0","avatar_url":"https://avatars0.githubusercontent.com/u/10784954?v=4","gravatar_id":"","url":"https://api.github.com/users/reppair","html_url":"https://github.com/reppair","followers_url":"https://api.github.com/users/reppair/followers","following_url":"https://api.github.com/users/reppair/following{/other_user}","gists_url":"https://api.github.com/users/reppair/gists{/gist_id}","starred_url":"https://api.github.com/users/reppair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reppair/subscriptions","organizations_url":"https://api.github.com/users/reppair/orgs","repos_url":"https://api.github.com/users/reppair/repos","events_url":"https://api.github.com/users/reppair/events{/privacy}","received_events_url":"https://api.github.com/users/reppair/received_events","type":"User","site_admin":false},"created_at":"2019-07-09T16:53:49Z","updated_at":"2019-07-09T16:53:49Z","author_association":"NONE","body":"I’ll take a look, btw I tested today the StreamResponse::create() with the current implementation and it creates an .zip that works fine windows but when opened under Ubuntu and OS X it results in a .zip.cpgz then that one when extracted results in the same .zip and it loops like this forever. Is that what you mean by invalid ZIP?"}}
{"actor":{"display_login":"reppair"}}