{"action":"opened","number":878,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/878","id":330448917,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwNDQ4OTE3","html_url":"https://github.com/input-output-hk/cardano-wallet/pull/878","diff_url":"https://github.com/input-output-hk/cardano-wallet/pull/878.diff","patch_url":"https://github.com/input-output-hk/cardano-wallet/pull/878.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/878","number":878,"state":"open","locked":false,"title":"Support for legacy UTxO witness in Jörmungandr","user":{"login":"KtorZ","id":5680256,"node_id":"MDQ6VXNlcjU2ODAyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"body":"# Issue Number\r\n\r\n<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->\r\n\r\n#779 \r\n\r\n# Overview\r\n\r\n<!-- Detail in a few bullet points the work accomplished in this PR -->\r\n\r\n- [x] I have extended `mkStdTx` so that it would properly handle transactions coming from a `RndKey` and construct `legacy-utxo` witnesses for it.\r\n\r\n# Comments\r\n\r\n<!-- Additional comments or screenshots to attach if any -->\r\n\r\nJörmungandr doesn't implement creating legacy utxo witnesses from jcli ... \r\n\r\n[jcli/src/jcli_app/transaction/mk_witness.rs](https://github.com/input-output-hk/jormungandr/blob/master/jcli/src/jcli_app/transaction/mk_witness.rs#L78-L82)\r\n```rust\r\n            WitnessType::OldUTxO => {\r\n                // TODO unimplemented!()\r\n                let _secret_key: SecretKey<Ed25519Bip32> = self.secret()?;\r\n                Err(Error::MakeWitnessLegacyUtxoUnsupported)?;\r\n                unimplemented!()\r\n            }\r\n``` \r\n\r\nso I had to construct them by hand according to:\r\n\r\n- The format defined in [chain-impl-mockchain#witnesses](https://github.com/input-output-hk/chain-libs/blob/incentive/chain-impl-mockchain/doc/format.md#witnesses)\r\n\r\n- The format from the source (double checking it matches the doc..) [chain-impl-mockchain/src/transaction/witness.rs](https://github.com/input-output-hk/chain-libs/blob/incentive/chain-impl-mockchain/src/transaction/witness.rs#L173-L176)\r\n\r\nIt'd be nice to review our golden if / when the constructor for the witness type gets updated.\r\n\r\n<!-- \r\nDon't forget to:\r\n\r\n ✓ Self-review your changes to make sure nothing unexpected slipped through\r\n ✓ Assign yourself to the PR\r\n ✓ Assign one or several reviewer(s)\r\n ✓ Once created, link this PR to its corresponding ticket\r\n ✓ Acknowledge any changes required to the Wiki\r\n-->\r\n","created_at":"2019-10-21T14:48:13Z","updated_at":"2019-10-21T14:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"jonathanknowles","id":206319,"node_id":"MDQ6VXNlcjIwNjMxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/206319?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanknowles","html_url":"https://github.com/jonathanknowles","followers_url":"https://api.github.com/users/jonathanknowles/followers","following_url":"https://api.github.com/users/jonathanknowles/following{/other_user}","gists_url":"https://api.github.com/users/jonathanknowles/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanknowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanknowles/subscriptions","organizations_url":"https://api.github.com/users/jonathanknowles/orgs","repos_url":"https://api.github.com/users/jonathanknowles/repos","events_url":"https://api.github.com/users/jonathanknowles/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanknowles/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/878/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/878/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/878/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/74cc15038e49abf2793c945e40aefbd7426ac014","head":{"label":"input-output-hk:KtorZ/legacy-tx-witness","ref":"KtorZ/legacy-tx-witness","sha":"74cc15038e49abf2793c945e40aefbd7426ac014","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":173286031,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMyODYwMzE=","name":"cardano-wallet","full_name":"input-output-hk/cardano-wallet","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-wallet","description":"Official Wallet Backend & API for Cardano decentralized","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-wallet","forks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/deployments","created_at":"2019-03-01T10:50:58Z","updated_at":"2019-10-21T12:19:58Z","pushed_at":"2019-10-21T14:41:42Z","git_url":"git://github.com/input-output-hk/cardano-wallet.git","ssh_url":"git@github.com:input-output-hk/cardano-wallet.git","clone_url":"https://github.com/input-output-hk/cardano-wallet.git","svn_url":"https://github.com/input-output-hk/cardano-wallet","homepage":null,"size":167807,"stargazers_count":39,"watchers_count":39,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":26,"watchers":39,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"d87024c6677aed5ebca22930e094a3addd58fa5b","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":173286031,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMyODYwMzE=","name":"cardano-wallet","full_name":"input-output-hk/cardano-wallet","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-wallet","description":"Official Wallet Backend & API for Cardano decentralized","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-wallet","forks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/deployments","created_at":"2019-03-01T10:50:58Z","updated_at":"2019-10-21T12:19:58Z","pushed_at":"2019-10-21T14:41:42Z","git_url":"git://github.com/input-output-hk/cardano-wallet.git","ssh_url":"git@github.com:input-output-hk/cardano-wallet.git","clone_url":"https://github.com/input-output-hk/cardano-wallet.git","svn_url":"https://github.com/input-output-hk/cardano-wallet","homepage":null,"size":167807,"stargazers_count":39,"watchers_count":39,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":26,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/878"},"html":{"href":"https://github.com/input-output-hk/cardano-wallet/pull/878"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/878"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/878/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/878/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/878/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/74cc15038e49abf2793c945e40aefbd7426ac014"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":265,"deletions":62,"changed_files":4}}
{"actor":{"display_login":"KtorZ"}}