{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/dom/pulls/comments/285839283","pull_request_review_id":239810197,"id":285839283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTgzOTI4Mw==","diff_hunk":"@@ -2203,6 +2203,36 @@ steps:\n  <li><p>If <var>slot</var> is non-null, then run <a>assign slotables</a> for <var>slot</var>.\n </ol>\n \n+<p>To <dfn noexport>update slots</dfn>, given <var>removedNodes</var>, <var>parent</var>, and\n+<var>addedNodes</var>, run these steps:\n+\n+<ol>\n+ <li>\n+  <p>For each <var>removedNode</var> in <var>removedNodes</var>:\n+\n+  <ol>\n+   <li><p>If <var>removedNode</var> is <a for=slotable>assigned</a>, then run\n+   <a>assign slotables</a> for <var>removedNode</var>'s <a>assigned slot</a>.\n+\n+   <li><p>If <var>removedNode</var> has an <a>inclusive descendant</a> that is a <a>slot</a>, then\n+   run <a>assign slotables for a tree</a> with <var>removedNode</var>.","path":"dom.bs","position":16,"original_position":16,"commit_id":"f80f0aa30dcb4deda2634134b0f50a6a17905d99","original_commit_id":"f80f0aa30dcb4deda2634134b0f50a6a17905d99","user":{"login":"rniwa","id":285965,"node_id":"MDQ6VXNlcjI4NTk2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/285965?v=4","gravatar_id":"","url":"https://api.github.com/users/rniwa","html_url":"https://github.com/rniwa","followers_url":"https://api.github.com/users/rniwa/followers","following_url":"https://api.github.com/users/rniwa/following{/other_user}","gists_url":"https://api.github.com/users/rniwa/gists{/gist_id}","starred_url":"https://api.github.com/users/rniwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rniwa/subscriptions","organizations_url":"https://api.github.com/users/rniwa/orgs","repos_url":"https://api.github.com/users/rniwa/repos","events_url":"https://api.github.com/users/rniwa/events{/privacy}","received_events_url":"https://api.github.com/users/rniwa/received_events","type":"User","site_admin":false},"body":"Hm... looks like Blink & Gecko do: [slot1, slot2, slot3] and WebKit does [slot3, slot2, slot1]","created_at":"2019-05-21T03:32:54Z","updated_at":"2019-05-21T03:32:54Z","html_url":"https://github.com/whatwg/dom/pull/695#discussion_r285839283","pull_request_url":"https://api.github.com/repos/whatwg/dom/pulls/695","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/whatwg/dom/pulls/comments/285839283"},"html":{"href":"https://github.com/whatwg/dom/pull/695#discussion_r285839283"},"pull_request":{"href":"https://api.github.com/repos/whatwg/dom/pulls/695"}},"in_reply_to_id":280828343},"pull_request":{"url":"https://api.github.com/repos/whatwg/dom/pulls/695","id":214668594,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjY4NTk0","html_url":"https://github.com/whatwg/dom/pull/695","diff_url":"https://github.com/whatwg/dom/pull/695.diff","patch_url":"https://github.com/whatwg/dom/pull/695.patch","issue_url":"https://api.github.com/repos/whatwg/dom/issues/695","number":695,"state":"open","locked":false,"title":"Manage slot manipulation centrally and special case replace operations","user":{"login":"annevk","id":1544111,"node_id":"MDQ6VXNlcjE1NDQxMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1544111?v=4","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"This is an attempt at fixing https://github.com/w3c/webcomponents/issues/764.\n\nI first wrote an algorithm that combined the operations done by remove and insert. I then used that for replace and replace all. I then abstracted it to avoid duplication.\n\nI'm a little worried that this is not correct as this delays assigning slotables to a slot quite a bit, which I think might be observable in some cases.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://whatpr.org/dom/695.html\" title=\"Last updated on Sep 11, 2018, 3:47 PM GMT (f80f0aa)\">Preview</a> | <a href=\"https://whatpr.org/dom/695/42d2485...f80f0aa.html\" title=\"Last updated on Sep 11, 2018, 3:47 PM GMT (f80f0aa)\">Diff</a>","created_at":"2018-09-11T15:15:08Z","updated_at":"2019-05-21T03:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52fb1afe28098fc7552b1d3919ff122bb7ef3cf5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":371408695,"node_id":"MDU6TGFiZWwzNzE0MDg2OTU=","url":"https://api.github.com/repos/whatwg/dom/labels/topic:%20shadow","name":"topic: shadow","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/dom/pulls/695/commits","review_comments_url":"https://api.github.com/repos/whatwg/dom/pulls/695/comments","review_comment_url":"https://api.github.com/repos/whatwg/dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/dom/issues/695/comments","statuses_url":"https://api.github.com/repos/whatwg/dom/statuses/f80f0aa30dcb4deda2634134b0f50a6a17905d99","head":{"label":"whatwg:annevk/slot-manipulation","ref":"annevk/slot-manipulation","sha":"f80f0aa30dcb4deda2634134b0f50a6a17905d99","user":{"login":"whatwg","id":2226336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjYzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5581406,"node_id":"MDEwOlJlcG9zaXRvcnk1NTgxNDA2","name":"dom","full_name":"whatwg/dom","private":false,"owner":{"login":"whatwg","id":2226336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjYzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/whatwg/dom","description":"DOM Standard","fork":false,"url":"https://api.github.com/repos/whatwg/dom","forks_url":"https://api.github.com/repos/whatwg/dom/forks","keys_url":"https://api.github.com/repos/whatwg/dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/dom/teams","hooks_url":"https://api.github.com/repos/whatwg/dom/hooks","issue_events_url":"https://api.github.com/repos/whatwg/dom/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/dom/events","assignees_url":"https://api.github.com/repos/whatwg/dom/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/dom/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/dom/tags","blobs_url":"https://api.github.com/repos/whatwg/dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/dom/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/dom/languages","stargazers_url":"https://api.github.com/repos/whatwg/dom/stargazers","contributors_url":"https://api.github.com/repos/whatwg/dom/contributors","subscribers_url":"https://api.github.com/repos/whatwg/dom/subscribers","subscription_url":"https://api.github.com/repos/whatwg/dom/subscription","commits_url":"https://api.github.com/repos/whatwg/dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/dom/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/dom/merges","archive_url":"https://api.github.com/repos/whatwg/dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/dom/downloads","issues_url":"https://api.github.com/repos/whatwg/dom/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/dom/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/dom/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/dom/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/dom/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/dom/deployments","created_at":"2012-08-28T05:59:06Z","updated_at":"2019-05-19T19:30:06Z","pushed_at":"2019-05-20T14:37:55Z","git_url":"git://github.com/whatwg/dom.git","ssh_url":"git@github.com:whatwg/dom.git","clone_url":"https://github.com/whatwg/dom.git","svn_url":"https://github.com/whatwg/dom","homepage":"https://dom.spec.whatwg.org/","size":44319,"stargazers_count":807,"watchers_count":807,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":121,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":151,"open_issues":121,"watchers":807,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"42d2485c4f84fb210452ca53e07503229716b147","user":{"login":"whatwg","id":2226336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjYzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5581406,"node_id":"MDEwOlJlcG9zaXRvcnk1NTgxNDA2","name":"dom","full_name":"whatwg/dom","private":false,"owner":{"login":"whatwg","id":2226336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjYzMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/whatwg/dom","description":"DOM Standard","fork":false,"url":"https://api.github.com/repos/whatwg/dom","forks_url":"https://api.github.com/repos/whatwg/dom/forks","keys_url":"https://api.github.com/repos/whatwg/dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/dom/teams","hooks_url":"https://api.github.com/repos/whatwg/dom/hooks","issue_events_url":"https://api.github.com/repos/whatwg/dom/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/dom/events","assignees_url":"https://api.github.com/repos/whatwg/dom/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/dom/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/dom/tags","blobs_url":"https://api.github.com/repos/whatwg/dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/dom/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/dom/languages","stargazers_url":"https://api.github.com/repos/whatwg/dom/stargazers","contributors_url":"https://api.github.com/repos/whatwg/dom/contributors","subscribers_url":"https://api.github.com/repos/whatwg/dom/subscribers","subscription_url":"https://api.github.com/repos/whatwg/dom/subscription","commits_url":"https://api.github.com/repos/whatwg/dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/dom/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/dom/merges","archive_url":"https://api.github.com/repos/whatwg/dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/dom/downloads","issues_url":"https://api.github.com/repos/whatwg/dom/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/dom/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/dom/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/dom/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/dom/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/dom/deployments","created_at":"2012-08-28T05:59:06Z","updated_at":"2019-05-19T19:30:06Z","pushed_at":"2019-05-20T14:37:55Z","git_url":"git://github.com/whatwg/dom.git","ssh_url":"git@github.com:whatwg/dom.git","clone_url":"https://github.com/whatwg/dom.git","svn_url":"https://github.com/whatwg/dom","homepage":"https://dom.spec.whatwg.org/","size":44319,"stargazers_count":807,"watchers_count":807,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":121,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":151,"open_issues":121,"watchers":807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/dom/pulls/695"},"html":{"href":"https://github.com/whatwg/dom/pull/695"},"issue":{"href":"https://api.github.com/repos/whatwg/dom/issues/695"},"comments":{"href":"https://api.github.com/repos/whatwg/dom/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/dom/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/dom/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/dom/statuses/f80f0aa30dcb4deda2634134b0f50a6a17905d99"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rniwa"}}