{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/odo/pulls/comments/299418705","pull_request_review_id":256809899,"id":299418705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTQxODcwNQ==","diff_hunk":"@@ -3318,3 +3238,48 @@ func (c *Client) StartDeployment(deploymentName string) (string, error) {\n \n \treturn result.Name, nil\n }\n+\n+func uniqueUpsertEnvVarsFromS2IPaths(existingVars []corev1.EnvVar, s2iPaths S2IPaths) []corev1.EnvVar {","path":"pkg/occlient/occlient.go","position":182,"original_position":172,"commit_id":"8a8071439f81f1816b8efc798ca6a81f3ce061a8","original_commit_id":"6f5b8f39600f9c22fa634459bb1764c66ea1afcd","user":{"login":"girishramnani","id":6551988,"node_id":"MDQ6VXNlcjY1NTE5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551988?v=4","gravatar_id":"","url":"https://api.github.com/users/girishramnani","html_url":"https://github.com/girishramnani","followers_url":"https://api.github.com/users/girishramnani/followers","following_url":"https://api.github.com/users/girishramnani/following{/other_user}","gists_url":"https://api.github.com/users/girishramnani/gists{/gist_id}","starred_url":"https://api.github.com/users/girishramnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishramnani/subscriptions","organizations_url":"https://api.github.com/users/girishramnani/orgs","repos_url":"https://api.github.com/users/girishramnani/repos","events_url":"https://api.github.com/users/girishramnani/events{/privacy}","received_events_url":"https://api.github.com/users/girishramnani/received_events","type":"User","site_admin":false},"body":"done","created_at":"2019-07-02T10:41:57Z","updated_at":"2019-07-02T10:41:57Z","html_url":"https://github.com/openshift/odo/pull/1840#discussion_r299418705","pull_request_url":"https://api.github.com/repos/openshift/odo/pulls/1840","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/odo/pulls/comments/299418705"},"html":{"href":"https://github.com/openshift/odo/pull/1840#discussion_r299418705"},"pull_request":{"href":"https://api.github.com/repos/openshift/odo/pulls/1840"}},"in_reply_to_id":297629263},"pull_request":{"url":"https://api.github.com/repos/openshift/odo/pulls/1840","id":289671819,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5NjcxODE5","html_url":"https://github.com/openshift/odo/pull/1840","diff_url":"https://github.com/openshift/odo/pull/1840.diff","patch_url":"https://github.com/openshift/odo/pull/1840.patch","issue_url":"https://api.github.com/repos/openshift/odo/issues/1840","number":1840,"state":"open","locked":false,"title":"added a Mount Volume for ODO_S2I_DEPLOYMENT_DIR","user":{"login":"girishramnani","id":6551988,"node_id":"MDQ6VXNlcjY1NTE5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551988?v=4","gravatar_id":"","url":"https://api.github.com/users/girishramnani","html_url":"https://github.com/girishramnani","followers_url":"https://api.github.com/users/girishramnani/followers","following_url":"https://api.github.com/users/girishramnani/following{/other_user}","gists_url":"https://api.github.com/users/girishramnani/gists{/gist_id}","starred_url":"https://api.github.com/users/girishramnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishramnani/subscriptions","organizations_url":"https://api.github.com/users/girishramnani/orgs","repos_url":"https://api.github.com/users/girishramnani/repos","events_url":"https://api.github.com/users/girishramnani/events{/privacy}","received_events_url":"https://api.github.com/users/girishramnani/received_events","type":"User","site_admin":false},"body":"## What is the purpose of this change? What does it change?\r\n- Add Deployment Dir Mount Volume\r\n- Removed a function SetupForSupervisor from occlient which was not being used anywhere\r\n- DRYed a few functions in occlient\r\n\r\n## Was the change discussed in an issue?\r\nfixes https://github.com/openshift/odo/issues/1471\r\n<!-- Please do Link issues here. -->\r\n\r\n## How to test changes?\r\n<!-- Please describe the steps to test the PR -->\r\nodo push should be faster then before and\r\ndeployment config should show 2 volume mounts \r\n( above points only valid for java )\r\n","created_at":"2019-06-19T12:01:43Z","updated_at":"2019-07-02T10:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86ff8767ebfaad8f9a431d18f598dcfdabef2c5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kadel","id":57206,"node_id":"MDQ6VXNlcjU3MjA2","avatar_url":"https://avatars1.githubusercontent.com/u/57206?v=4","gravatar_id":"","url":"https://api.github.com/users/kadel","html_url":"https://github.com/kadel","followers_url":"https://api.github.com/users/kadel/followers","following_url":"https://api.github.com/users/kadel/following{/other_user}","gists_url":"https://api.github.com/users/kadel/gists{/gist_id}","starred_url":"https://api.github.com/users/kadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadel/subscriptions","organizations_url":"https://api.github.com/users/kadel/orgs","repos_url":"https://api.github.com/users/kadel/repos","events_url":"https://api.github.com/users/kadel/events{/privacy}","received_events_url":"https://api.github.com/users/kadel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":836047759,"node_id":"MDU6TGFiZWw4MzYwNDc3NTk=","url":"https://api.github.com/repos/openshift/odo/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/odo/pulls/1840/commits","review_comments_url":"https://api.github.com/repos/openshift/odo/pulls/1840/comments","review_comment_url":"https://api.github.com/repos/openshift/odo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/odo/issues/1840/comments","statuses_url":"https://api.github.com/repos/openshift/odo/statuses/8a8071439f81f1816b8efc798ca6a81f3ce061a8","head":{"label":"girishramnani:feature/s2i_deployment_dir_volume","ref":"feature/s2i_deployment_dir_volume","sha":"8a8071439f81f1816b8efc798ca6a81f3ce061a8","user":{"login":"girishramnani","id":6551988,"node_id":"MDQ6VXNlcjY1NTE5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551988?v=4","gravatar_id":"","url":"https://api.github.com/users/girishramnani","html_url":"https://github.com/girishramnani","followers_url":"https://api.github.com/users/girishramnani/followers","following_url":"https://api.github.com/users/girishramnani/following{/other_user}","gists_url":"https://api.github.com/users/girishramnani/gists{/gist_id}","starred_url":"https://api.github.com/users/girishramnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishramnani/subscriptions","organizations_url":"https://api.github.com/users/girishramnani/orgs","repos_url":"https://api.github.com/users/girishramnani/repos","events_url":"https://api.github.com/users/girishramnani/events{/privacy}","received_events_url":"https://api.github.com/users/girishramnani/received_events","type":"User","site_admin":false},"repo":{"id":157850503,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4NTA1MDM=","name":"odo","full_name":"girishramnani/odo","private":false,"owner":{"login":"girishramnani","id":6551988,"node_id":"MDQ6VXNlcjY1NTE5ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551988?v=4","gravatar_id":"","url":"https://api.github.com/users/girishramnani","html_url":"https://github.com/girishramnani","followers_url":"https://api.github.com/users/girishramnani/followers","following_url":"https://api.github.com/users/girishramnani/following{/other_user}","gists_url":"https://api.github.com/users/girishramnani/gists{/gist_id}","starred_url":"https://api.github.com/users/girishramnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishramnani/subscriptions","organizations_url":"https://api.github.com/users/girishramnani/orgs","repos_url":"https://api.github.com/users/girishramnani/repos","events_url":"https://api.github.com/users/girishramnani/events{/privacy}","received_events_url":"https://api.github.com/users/girishramnani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/girishramnani/odo","description":"OpenShift Do - Fast, iterative OpenShift development","fork":true,"url":"https://api.github.com/repos/girishramnani/odo","forks_url":"https://api.github.com/repos/girishramnani/odo/forks","keys_url":"https://api.github.com/repos/girishramnani/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girishramnani/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girishramnani/odo/teams","hooks_url":"https://api.github.com/repos/girishramnani/odo/hooks","issue_events_url":"https://api.github.com/repos/girishramnani/odo/issues/events{/number}","events_url":"https://api.github.com/repos/girishramnani/odo/events","assignees_url":"https://api.github.com/repos/girishramnani/odo/assignees{/user}","branches_url":"https://api.github.com/repos/girishramnani/odo/branches{/branch}","tags_url":"https://api.github.com/repos/girishramnani/odo/tags","blobs_url":"https://api.github.com/repos/girishramnani/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girishramnani/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girishramnani/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/girishramnani/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girishramnani/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/girishramnani/odo/languages","stargazers_url":"https://api.github.com/repos/girishramnani/odo/stargazers","contributors_url":"https://api.github.com/repos/girishramnani/odo/contributors","subscribers_url":"https://api.github.com/repos/girishramnani/odo/subscribers","subscription_url":"https://api.github.com/repos/girishramnani/odo/subscription","commits_url":"https://api.github.com/repos/girishramnani/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/girishramnani/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/girishramnani/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/girishramnani/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/girishramnani/odo/contents/{+path}","compare_url":"https://api.github.com/repos/girishramnani/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girishramnani/odo/merges","archive_url":"https://api.github.com/repos/girishramnani/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girishramnani/odo/downloads","issues_url":"https://api.github.com/repos/girishramnani/odo/issues{/number}","pulls_url":"https://api.github.com/repos/girishramnani/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/girishramnani/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/girishramnani/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girishramnani/odo/labels{/name}","releases_url":"https://api.github.com/repos/girishramnani/odo/releases{/id}","deployments_url":"https://api.github.com/repos/girishramnani/odo/deployments","created_at":"2018-11-16T10:17:36Z","updated_at":"2019-03-21T14:15:53Z","pushed_at":"2019-07-02T10:24:38Z","git_url":"git://github.com/girishramnani/odo.git","ssh_url":"git@github.com:girishramnani/odo.git","clone_url":"https://github.com/girishramnani/odo.git","svn_url":"https://github.com/girishramnani/odo","homepage":"","size":140858,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5d96478f4106c1bd250b2f83dfa590b392c60f85","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":118630356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MzAzNTY=","name":"odo","full_name":"openshift/odo","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/odo","description":"OpenShift Do - Fast, iterative OpenShift development","fork":false,"url":"https://api.github.com/repos/openshift/odo","forks_url":"https://api.github.com/repos/openshift/odo/forks","keys_url":"https://api.github.com/repos/openshift/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/odo/teams","hooks_url":"https://api.github.com/repos/openshift/odo/hooks","issue_events_url":"https://api.github.com/repos/openshift/odo/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/odo/events","assignees_url":"https://api.github.com/repos/openshift/odo/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/odo/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/odo/tags","blobs_url":"https://api.github.com/repos/openshift/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/odo/languages","stargazers_url":"https://api.github.com/repos/openshift/odo/stargazers","contributors_url":"https://api.github.com/repos/openshift/odo/contributors","subscribers_url":"https://api.github.com/repos/openshift/odo/subscribers","subscription_url":"https://api.github.com/repos/openshift/odo/subscription","commits_url":"https://api.github.com/repos/openshift/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/odo/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/odo/merges","archive_url":"https://api.github.com/repos/openshift/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/odo/downloads","issues_url":"https://api.github.com/repos/openshift/odo/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/odo/labels{/name}","releases_url":"https://api.github.com/repos/openshift/odo/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/odo/deployments","created_at":"2018-01-23T15:36:17Z","updated_at":"2019-07-01T12:31:27Z","pushed_at":"2019-07-02T10:24:39Z","git_url":"git://github.com/openshift/odo.git","ssh_url":"git@github.com:openshift/odo.git","clone_url":"https://github.com/openshift/odo.git","svn_url":"https://github.com/openshift/odo","homepage":"","size":140861,"stargazers_count":374,"watchers_count":374,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":94,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":275,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":94,"open_issues":275,"watchers":374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/odo/pulls/1840"},"html":{"href":"https://github.com/openshift/odo/pull/1840"},"issue":{"href":"https://api.github.com/repos/openshift/odo/issues/1840"},"comments":{"href":"https://api.github.com/repos/openshift/odo/issues/1840/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/odo/pulls/1840/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/odo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/odo/pulls/1840/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/odo/statuses/8a8071439f81f1816b8efc798ca6a81f3ce061a8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"girishramnani"}}