{"action":"created","comment":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/255600588","pull_request_review_id":202222733,"id":255600588,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTYwMDU4OA==","diff_hunk":"@@ -407,6 +412,120 @@ private boolean handleDefinedMappings() {\n             return errorOccurred;\n         }\n \n+        /**\n+         * Iterates over all source parameter properties and maps them to current target.\n+         * When a property name match occurs, the remainder will be checked for duplicates. Matches will be removed from\n+         * the set of remaining target properties.\n+         */\n+        private void applySourcePropertiesToCurrentTarget( Mapping mapping ) {","path":"processor/src/main/java/org/mapstruct/ap/internal/model/BeanMappingMethod.java","position":36,"original_position":36,"commit_id":"86d318551c9d32131df79e988b2b105e5515d3c3","original_commit_id":"86d318551c9d32131df79e988b2b105e5515d3c3","user":{"login":"sjaakd","id":6173283,"node_id":"MDQ6VXNlcjYxNzMyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6173283?v=4","gravatar_id":"","url":"https://api.github.com/users/sjaakd","html_url":"https://github.com/sjaakd","followers_url":"https://api.github.com/users/sjaakd/followers","following_url":"https://api.github.com/users/sjaakd/following{/other_user}","gists_url":"https://api.github.com/users/sjaakd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaakd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaakd/subscriptions","organizations_url":"https://api.github.com/users/sjaakd/orgs","repos_url":"https://api.github.com/users/sjaakd/repos","events_url":"https://api.github.com/users/sjaakd/events{/privacy}","received_events_url":"https://api.github.com/users/sjaakd/received_events","type":"User","site_admin":false},"body":"What happens when the target is also nested? Perhaps there are already testcases covering this, but could it be that when stacking down, you ultimately hit `\".\"` or will it stop at an earlier level.\r\n\r\nSo:\r\n\r\n`@Mapping( target = \"store.shop\", source = \"store.shop.customer.item\" )`\r\n\r\nWill be stacked down to:\r\n\r\n`@Mapping( target = \"shop\", source = \"shop.customer.item\" )`\r\n\r\nand I guess it stops here (I guess we have testcase for this). ","created_at":"2019-02-11T17:01:13Z","updated_at":"2019-02-11T17:01:13Z","html_url":"https://github.com/mapstruct/mapstruct/pull/1686#discussion_r255600588","pull_request_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments/255600588"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/1686#discussion_r255600588"},"pull_request":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686"}},"in_reply_to_id":254440837},"pull_request":{"url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686","id":244409817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ0NDA5ODE3","html_url":"https://github.com/mapstruct/mapstruct/pull/1686","diff_url":"https://github.com/mapstruct/mapstruct/pull/1686.diff","patch_url":"https://github.com/mapstruct/mapstruct/pull/1686.patch","issue_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/1686","number":1686,"state":"open","locked":false,"title":"#1406 Targeting \".\" as current object allowing to map source properties to current target","user":{"login":"dainiusfigoras","id":11692821,"node_id":"MDQ6VXNlcjExNjkyODIx","avatar_url":"https://avatars2.githubusercontent.com/u/11692821?v=4","gravatar_id":"","url":"https://api.github.com/users/dainiusfigoras","html_url":"https://github.com/dainiusfigoras","followers_url":"https://api.github.com/users/dainiusfigoras/followers","following_url":"https://api.github.com/users/dainiusfigoras/following{/other_user}","gists_url":"https://api.github.com/users/dainiusfigoras/gists{/gist_id}","starred_url":"https://api.github.com/users/dainiusfigoras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dainiusfigoras/subscriptions","organizations_url":"https://api.github.com/users/dainiusfigoras/orgs","repos_url":"https://api.github.com/users/dainiusfigoras/repos","events_url":"https://api.github.com/users/dainiusfigoras/events{/privacy}","received_events_url":"https://api.github.com/users/dainiusfigoras/received_events","type":"User","site_admin":false},"body":"It allows to map composition to inheritance and opposite way, for example \"@Mapping(source = \"dataObject.*\", target = \".\")\" every property in dataObject is mapped to return type, this allows to have hierarchy target object and composition source object.","created_at":"2019-01-14T11:20:16Z","updated_at":"2019-02-11T17:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e782dfc26671c113e3450d63189beb83c6beee4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686/commits","review_comments_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686/comments","review_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/1686/comments","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/86d318551c9d32131df79e988b2b105e5515d3c3","head":{"label":"entur:multi-mapping","ref":"multi-mapping","sha":"86d318551c9d32131df79e988b2b105e5515d3c3","user":{"login":"entur","id":23213604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEzNjA0","avatar_url":"https://avatars1.githubusercontent.com/u/23213604?v=4","gravatar_id":"","url":"https://api.github.com/users/entur","html_url":"https://github.com/entur","followers_url":"https://api.github.com/users/entur/followers","following_url":"https://api.github.com/users/entur/following{/other_user}","gists_url":"https://api.github.com/users/entur/gists{/gist_id}","starred_url":"https://api.github.com/users/entur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entur/subscriptions","organizations_url":"https://api.github.com/users/entur/orgs","repos_url":"https://api.github.com/users/entur/repos","events_url":"https://api.github.com/users/entur/events{/privacy}","received_events_url":"https://api.github.com/users/entur/received_events","type":"Organization","site_admin":false},"repo":{"id":164408646,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MDg2NDY=","name":"mapstruct","full_name":"entur/mapstruct","private":false,"owner":{"login":"entur","id":23213604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjEzNjA0","avatar_url":"https://avatars1.githubusercontent.com/u/23213604?v=4","gravatar_id":"","url":"https://api.github.com/users/entur","html_url":"https://github.com/entur","followers_url":"https://api.github.com/users/entur/followers","following_url":"https://api.github.com/users/entur/following{/other_user}","gists_url":"https://api.github.com/users/entur/gists{/gist_id}","starred_url":"https://api.github.com/users/entur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/entur/subscriptions","organizations_url":"https://api.github.com/users/entur/orgs","repos_url":"https://api.github.com/users/entur/repos","events_url":"https://api.github.com/users/entur/events{/privacy}","received_events_url":"https://api.github.com/users/entur/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/entur/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":true,"url":"https://api.github.com/repos/entur/mapstruct","forks_url":"https://api.github.com/repos/entur/mapstruct/forks","keys_url":"https://api.github.com/repos/entur/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/entur/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/entur/mapstruct/teams","hooks_url":"https://api.github.com/repos/entur/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/entur/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/entur/mapstruct/events","assignees_url":"https://api.github.com/repos/entur/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/entur/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/entur/mapstruct/tags","blobs_url":"https://api.github.com/repos/entur/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/entur/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/entur/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/entur/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/entur/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/entur/mapstruct/languages","stargazers_url":"https://api.github.com/repos/entur/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/entur/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/entur/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/entur/mapstruct/subscription","commits_url":"https://api.github.com/repos/entur/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/entur/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/entur/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/entur/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/entur/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/entur/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/entur/mapstruct/merges","archive_url":"https://api.github.com/repos/entur/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/entur/mapstruct/downloads","issues_url":"https://api.github.com/repos/entur/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/entur/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/entur/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/entur/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/entur/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/entur/mapstruct/releases{/id}","deployments_url":"https://api.github.com/repos/entur/mapstruct/deployments","created_at":"2019-01-07T09:26:44Z","updated_at":"2019-02-11T10:10:55Z","pushed_at":"2019-02-11T10:10:48Z","git_url":"git://github.com/entur/mapstruct.git","ssh_url":"git@github.com:entur/mapstruct.git","clone_url":"https://github.com/entur/mapstruct.git","svn_url":"https://github.com/entur/mapstruct","homepage":"http://mapstruct.org/","size":7761,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapstruct:master","ref":"master","sha":"0e33ad4bbcfd7f8628f63221db4faa7415ac4384","user":{"login":"mapstruct","id":4086779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4086779?v=4","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"repo":{"id":4470435,"node_id":"MDEwOlJlcG9zaXRvcnk0NDcwNDM1","name":"mapstruct","full_name":"mapstruct/mapstruct","private":false,"owner":{"login":"mapstruct","id":4086779,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY3Nzk=","avatar_url":"https://avatars1.githubusercontent.com/u/4086779?v=4","gravatar_id":"","url":"https://api.github.com/users/mapstruct","html_url":"https://github.com/mapstruct","followers_url":"https://api.github.com/users/mapstruct/followers","following_url":"https://api.github.com/users/mapstruct/following{/other_user}","gists_url":"https://api.github.com/users/mapstruct/gists{/gist_id}","starred_url":"https://api.github.com/users/mapstruct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapstruct/subscriptions","organizations_url":"https://api.github.com/users/mapstruct/orgs","repos_url":"https://api.github.com/users/mapstruct/repos","events_url":"https://api.github.com/users/mapstruct/events{/privacy}","received_events_url":"https://api.github.com/users/mapstruct/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapstruct/mapstruct","description":"An annotation processor for generating type-safe bean mappers","fork":false,"url":"https://api.github.com/repos/mapstruct/mapstruct","forks_url":"https://api.github.com/repos/mapstruct/mapstruct/forks","keys_url":"https://api.github.com/repos/mapstruct/mapstruct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapstruct/mapstruct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapstruct/mapstruct/teams","hooks_url":"https://api.github.com/repos/mapstruct/mapstruct/hooks","issue_events_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/events{/number}","events_url":"https://api.github.com/repos/mapstruct/mapstruct/events","assignees_url":"https://api.github.com/repos/mapstruct/mapstruct/assignees{/user}","branches_url":"https://api.github.com/repos/mapstruct/mapstruct/branches{/branch}","tags_url":"https://api.github.com/repos/mapstruct/mapstruct/tags","blobs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapstruct/mapstruct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapstruct/mapstruct/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapstruct/mapstruct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapstruct/mapstruct/statuses/{sha}","languages_url":"https://api.github.com/repos/mapstruct/mapstruct/languages","stargazers_url":"https://api.github.com/repos/mapstruct/mapstruct/stargazers","contributors_url":"https://api.github.com/repos/mapstruct/mapstruct/contributors","subscribers_url":"https://api.github.com/repos/mapstruct/mapstruct/subscribers","subscription_url":"https://api.github.com/repos/mapstruct/mapstruct/subscription","commits_url":"https://api.github.com/repos/mapstruct/mapstruct/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapstruct/mapstruct/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapstruct/mapstruct/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapstruct/mapstruct/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapstruct/mapstruct/contents/{+path}","compare_url":"https://api.github.com/repos/mapstruct/mapstruct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapstruct/mapstruct/merges","archive_url":"https://api.github.com/repos/mapstruct/mapstruct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapstruct/mapstruct/downloads","issues_url":"https://api.github.com/repos/mapstruct/mapstruct/issues{/number}","pulls_url":"https://api.github.com/repos/mapstruct/mapstruct/pulls{/number}","milestones_url":"https://api.github.com/repos/mapstruct/mapstruct/milestones{/number}","notifications_url":"https://api.github.com/repos/mapstruct/mapstruct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapstruct/mapstruct/labels{/name}","releases_url":"https://api.github.com/repos/mapstruct/mapstruct/releases{/id}","deployments_url":"https://api.github.com/repos/mapstruct/mapstruct/deployments","created_at":"2012-05-28T12:42:42Z","updated_at":"2019-02-11T10:55:31Z","pushed_at":"2019-02-10T21:08:38Z","git_url":"git://github.com/mapstruct/mapstruct.git","ssh_url":"git@github.com:mapstruct/mapstruct.git","clone_url":"https://github.com/mapstruct/mapstruct.git","svn_url":"https://github.com/mapstruct/mapstruct","homepage":"http://mapstruct.org/","size":7722,"stargazers_count":1515,"watchers_count":1515,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":257,"open_issues":215,"watchers":1515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686"},"html":{"href":"https://github.com/mapstruct/mapstruct/pull/1686"},"issue":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/1686"},"comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/issues/1686/comments"},"review_comments":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686/comments"},"review_comment":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapstruct/mapstruct/pulls/1686/commits"},"statuses":{"href":"https://api.github.com/repos/mapstruct/mapstruct/statuses/86d318551c9d32131df79e988b2b105e5515d3c3"}},"author_association":"NONE"}}
{"actor":{"display_login":"sjaakd"}}