{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/1","id":255635378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NjM1Mzc4","html_url":"https://github.com/athol-m/PoetryTwitterBot/pull/1","diff_url":"https://github.com/athol-m/PoetryTwitterBot/pull/1.diff","patch_url":"https://github.com/athol-m/PoetryTwitterBot/pull/1.patch","issue_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues/1","number":1,"state":"open","locked":false,"title":"Suggestion for managing secrets","user":{"login":"garcias","id":8032166,"node_id":"MDQ6VXNlcjgwMzIxNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8032166?v=4","gravatar_id":"","url":"https://api.github.com/users/garcias","html_url":"https://github.com/garcias","followers_url":"https://api.github.com/users/garcias/followers","following_url":"https://api.github.com/users/garcias/following{/other_user}","gists_url":"https://api.github.com/users/garcias/gists{/gist_id}","starred_url":"https://api.github.com/users/garcias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcias/subscriptions","organizations_url":"https://api.github.com/users/garcias/orgs","repos_url":"https://api.github.com/users/garcias/repos","events_url":"https://api.github.com/users/garcias/events{/privacy}","received_events_url":"https://api.github.com/users/garcias/received_events","type":"User","site_admin":false},"body":"Hi Margie, as promised, I wanted to make a couple small suggestions to your project regarding management of secrets. Because they are so minor, I thought I would use the pull-request mechanism so you can get some experience with it. Accepting the pull request will merge the changes I suggest into the *published* version of your code on GitHub, which is \"behind\" the local version on your machine. That is okay. You can \"pull\" my changes into your local version, and Git should recognize that these changes do not conflict with your version, and incorporate them at the right places. If you like, we can meet next week and I can guide you through the process, it only takes about 5 minutes.\r\n\r\nThe changes I suggest:\r\n\r\n1. When importing variables from `secrets.py`, name those variables. This helps another person reading your code to know that those variables came from that import.\r\n2. Add a file named `.gitignore`, containing the line `secrets.py` in it. Git automatically excludes files named in `.gitignore` from being pushed to GitHub.\r\n","created_at":"2019-02-23T19:47:06Z","updated_at":"2019-02-23T19:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/1/commits","review_comments_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/1/comments","review_comment_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues/1/comments","statuses_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/statuses/6284f62c0e12811db6cff51ae8b83744bc318b36","head":{"label":"garcias:master","ref":"master","sha":"6284f62c0e12811db6cff51ae8b83744bc318b36","user":{"login":"garcias","id":8032166,"node_id":"MDQ6VXNlcjgwMzIxNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8032166?v=4","gravatar_id":"","url":"https://api.github.com/users/garcias","html_url":"https://github.com/garcias","followers_url":"https://api.github.com/users/garcias/followers","following_url":"https://api.github.com/users/garcias/following{/other_user}","gists_url":"https://api.github.com/users/garcias/gists{/gist_id}","starred_url":"https://api.github.com/users/garcias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcias/subscriptions","organizations_url":"https://api.github.com/users/garcias/orgs","repos_url":"https://api.github.com/users/garcias/repos","events_url":"https://api.github.com/users/garcias/events{/privacy}","received_events_url":"https://api.github.com/users/garcias/received_events","type":"User","site_admin":false},"repo":{"id":172254711,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIyNTQ3MTE=","name":"PoetryTwitterBot","full_name":"garcias/PoetryTwitterBot","private":false,"owner":{"login":"garcias","id":8032166,"node_id":"MDQ6VXNlcjgwMzIxNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8032166?v=4","gravatar_id":"","url":"https://api.github.com/users/garcias","html_url":"https://github.com/garcias","followers_url":"https://api.github.com/users/garcias/followers","following_url":"https://api.github.com/users/garcias/following{/other_user}","gists_url":"https://api.github.com/users/garcias/gists{/gist_id}","starred_url":"https://api.github.com/users/garcias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garcias/subscriptions","organizations_url":"https://api.github.com/users/garcias/orgs","repos_url":"https://api.github.com/users/garcias/repos","events_url":"https://api.github.com/users/garcias/events{/privacy}","received_events_url":"https://api.github.com/users/garcias/received_events","type":"User","site_admin":false},"html_url":"https://github.com/garcias/PoetryTwitterBot","description":"(Work in progress) This repository holds pages for creating a Twitter bot that tweets poetry in response to images. ","fork":true,"url":"https://api.github.com/repos/garcias/PoetryTwitterBot","forks_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/forks","keys_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/teams","hooks_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/hooks","issue_events_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/issues/events{/number}","events_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/events","assignees_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/assignees{/user}","branches_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/branches{/branch}","tags_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/tags","blobs_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/statuses/{sha}","languages_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/languages","stargazers_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/stargazers","contributors_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/contributors","subscribers_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/subscribers","subscription_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/subscription","commits_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/contents/{+path}","compare_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/merges","archive_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/downloads","issues_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/issues{/number}","pulls_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/pulls{/number}","milestones_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/milestones{/number}","notifications_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/labels{/name}","releases_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/releases{/id}","deployments_url":"https://api.github.com/repos/garcias/PoetryTwitterBot/deployments","created_at":"2019-02-23T19:26:38Z","updated_at":"2019-02-23T19:34:20Z","pushed_at":"2019-02-23T19:34:18Z","git_url":"git://github.com/garcias/PoetryTwitterBot.git","ssh_url":"git@github.com:garcias/PoetryTwitterBot.git","clone_url":"https://github.com/garcias/PoetryTwitterBot.git","svn_url":"https://github.com/garcias/PoetryTwitterBot","homepage":"","size":32,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"athol-m:master","ref":"master","sha":"fe20790f2df29417a7f4764322108d683d9767e1","user":{"login":"athol-m","id":32249264,"node_id":"MDQ6VXNlcjMyMjQ5MjY0","avatar_url":"https://avatars3.githubusercontent.com/u/32249264?v=4","gravatar_id":"","url":"https://api.github.com/users/athol-m","html_url":"https://github.com/athol-m","followers_url":"https://api.github.com/users/athol-m/followers","following_url":"https://api.github.com/users/athol-m/following{/other_user}","gists_url":"https://api.github.com/users/athol-m/gists{/gist_id}","starred_url":"https://api.github.com/users/athol-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athol-m/subscriptions","organizations_url":"https://api.github.com/users/athol-m/orgs","repos_url":"https://api.github.com/users/athol-m/repos","events_url":"https://api.github.com/users/athol-m/events{/privacy}","received_events_url":"https://api.github.com/users/athol-m/received_events","type":"User","site_admin":false},"repo":{"id":171763241,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE3NjMyNDE=","name":"PoetryTwitterBot","full_name":"athol-m/PoetryTwitterBot","private":false,"owner":{"login":"athol-m","id":32249264,"node_id":"MDQ6VXNlcjMyMjQ5MjY0","avatar_url":"https://avatars3.githubusercontent.com/u/32249264?v=4","gravatar_id":"","url":"https://api.github.com/users/athol-m","html_url":"https://github.com/athol-m","followers_url":"https://api.github.com/users/athol-m/followers","following_url":"https://api.github.com/users/athol-m/following{/other_user}","gists_url":"https://api.github.com/users/athol-m/gists{/gist_id}","starred_url":"https://api.github.com/users/athol-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athol-m/subscriptions","organizations_url":"https://api.github.com/users/athol-m/orgs","repos_url":"https://api.github.com/users/athol-m/repos","events_url":"https://api.github.com/users/athol-m/events{/privacy}","received_events_url":"https://api.github.com/users/athol-m/received_events","type":"User","site_admin":false},"html_url":"https://github.com/athol-m/PoetryTwitterBot","description":"(Work in progress) This repository holds pages for creating a Twitter bot that tweets poetry in response to images. ","fork":false,"url":"https://api.github.com/repos/athol-m/PoetryTwitterBot","forks_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/forks","keys_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/teams","hooks_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/hooks","issue_events_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues/events{/number}","events_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/events","assignees_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/assignees{/user}","branches_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/branches{/branch}","tags_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/tags","blobs_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/statuses/{sha}","languages_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/languages","stargazers_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/stargazers","contributors_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/contributors","subscribers_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/subscribers","subscription_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/subscription","commits_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/contents/{+path}","compare_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/merges","archive_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/downloads","issues_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues{/number}","pulls_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls{/number}","milestones_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/milestones{/number}","notifications_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/labels{/name}","releases_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/releases{/id}","deployments_url":"https://api.github.com/repos/athol-m/PoetryTwitterBot/deployments","created_at":"2019-02-20T23:07:01Z","updated_at":"2019-02-22T18:10:37Z","pushed_at":"2019-02-22T18:10:35Z","git_url":"git://github.com/athol-m/PoetryTwitterBot.git","ssh_url":"git@github.com:athol-m/PoetryTwitterBot.git","clone_url":"https://github.com/athol-m/PoetryTwitterBot.git","svn_url":"https://github.com/athol-m/PoetryTwitterBot","homepage":"","size":32,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/1"},"html":{"href":"https://github.com/athol-m/PoetryTwitterBot/pull/1"},"issue":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues/1"},"comments":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/athol-m/PoetryTwitterBot/statuses/6284f62c0e12811db6cff51ae8b83744bc318b36"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":2,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"garcias"}}