{"action":"created","comment":{"url":"https://api.github.com/repos/istefano82/ludwig/pulls/comments/292176212","pull_request_review_id":247825944,"id":292176212,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjE3NjIxMg==","diff_hunk":"@@ -36,45 +36,88 @@\n from ludwig.utils.print_utils import logging_level_registry\n \n \n-def learning_curves(\n-        training_statistics,\n-        field,\n-        model_names=None,\n-        output_directory=None,\n-        file_format='pdf',\n-        **kwargs\n-):\n-    if len(training_statistics) < 1:\n-        logging.error('No training_statistics provided')\n+def load_data_for_viz(training_statistics,**kwargs):","path":"ludwig/visualize.py","position":null,"original_position":23,"commit_id":"a1b3b982590b979d8d2901032e9d81342c92e980","original_commit_id":"2b05e6c97c0ec73631e26c608935d543e4e862bb","user":{"login":"w4nderlust","id":349256,"node_id":"MDQ6VXNlcjM0OTI1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/349256?v=4","gravatar_id":"","url":"https://api.github.com/users/w4nderlust","html_url":"https://github.com/w4nderlust","followers_url":"https://api.github.com/users/w4nderlust/followers","following_url":"https://api.github.com/users/w4nderlust/following{/other_user}","gists_url":"https://api.github.com/users/w4nderlust/gists{/gist_id}","starred_url":"https://api.github.com/users/w4nderlust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w4nderlust/subscriptions","organizations_url":"https://api.github.com/users/w4nderlust/orgs","repos_url":"https://api.github.com/users/w4nderlust/repos","events_url":"https://api.github.com/users/w4nderlust/events{/privacy}","received_events_url":"https://api.github.com/users/w4nderlust/received_events","type":"User","site_admin":false},"body":"Makes sense. Probably trying to load everything and returning `None` for the missing ones and then letting the code in `cli()` pass the loaded files it needs to the actual visualization function is a good idea to start with, but yeah, you'll figure out by doing it.","created_at":"2019-06-10T20:25:45Z","updated_at":"2019-06-10T20:25:45Z","html_url":"https://github.com/istefano82/ludwig/pull/1#discussion_r292176212","pull_request_url":"https://api.github.com/repos/istefano82/ludwig/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/istefano82/ludwig/pulls/comments/292176212"},"html":{"href":"https://github.com/istefano82/ludwig/pull/1#discussion_r292176212"},"pull_request":{"href":"https://api.github.com/repos/istefano82/ludwig/pulls/1"}},"in_reply_to_id":291853227},"pull_request":{"url":"https://api.github.com/repos/istefano82/ludwig/pulls/1","id":286497266,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NDk3MjY2","html_url":"https://github.com/istefano82/ludwig/pull/1","diff_url":"https://github.com/istefano82/ludwig/pull/1.diff","patch_url":"https://github.com/istefano82/ludwig/pull/1.patch","issue_url":"https://api.github.com/repos/istefano82/ludwig/issues/1","number":1,"state":"open","locked":false,"title":"Feature/visualisation api","user":{"login":"istefano82","id":14816765,"node_id":"MDQ6VXNlcjE0ODE2NzY1","avatar_url":"https://avatars2.githubusercontent.com/u/14816765?v=4","gravatar_id":"","url":"https://api.github.com/users/istefano82","html_url":"https://github.com/istefano82","followers_url":"https://api.github.com/users/istefano82/followers","following_url":"https://api.github.com/users/istefano82/following{/other_user}","gists_url":"https://api.github.com/users/istefano82/gists{/gist_id}","starred_url":"https://api.github.com/users/istefano82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istefano82/subscriptions","organizations_url":"https://api.github.com/users/istefano82/orgs","repos_url":"https://api.github.com/users/istefano82/repos","events_url":"https://api.github.com/users/istefano82/events{/privacy}","received_events_url":"https://api.github.com/users/istefano82/received_events","type":"User","site_admin":false},"body":"Learning curves visualisation API.\r\n\r\n - Split loading of visualisation data and displaying it in different functions.\r\n - Adapt argparser to first load the data than pass it to the function for visualisation,\r\n - Create utility functions to reuse code for path manipulation and field ground truth validation.\r\n- Start API integration tests for saving PNG and PDF viz formats.","created_at":"2019-06-09T20:48:51Z","updated_at":"2019-06-10T20:25:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/istefano82/ludwig/pulls/1/commits","review_comments_url":"https://api.github.com/repos/istefano82/ludwig/pulls/1/comments","review_comment_url":"https://api.github.com/repos/istefano82/ludwig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istefano82/ludwig/issues/1/comments","statuses_url":"https://api.github.com/repos/istefano82/ludwig/statuses/a1b3b982590b979d8d2901032e9d81342c92e980","head":{"label":"istefano82:feature/visualisation_api","ref":"feature/visualisation_api","sha":"a1b3b982590b979d8d2901032e9d81342c92e980","user":{"login":"istefano82","id":14816765,"node_id":"MDQ6VXNlcjE0ODE2NzY1","avatar_url":"https://avatars2.githubusercontent.com/u/14816765?v=4","gravatar_id":"","url":"https://api.github.com/users/istefano82","html_url":"https://github.com/istefano82","followers_url":"https://api.github.com/users/istefano82/followers","following_url":"https://api.github.com/users/istefano82/following{/other_user}","gists_url":"https://api.github.com/users/istefano82/gists{/gist_id}","starred_url":"https://api.github.com/users/istefano82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istefano82/subscriptions","organizations_url":"https://api.github.com/users/istefano82/orgs","repos_url":"https://api.github.com/users/istefano82/repos","events_url":"https://api.github.com/users/istefano82/events{/privacy}","received_events_url":"https://api.github.com/users/istefano82/received_events","type":"User","site_admin":false},"repo":{"id":189090836,"node_id":"MDEwOlJlcG9zaXRvcnkxODkwOTA4MzY=","name":"ludwig","full_name":"istefano82/ludwig","private":false,"owner":{"login":"istefano82","id":14816765,"node_id":"MDQ6VXNlcjE0ODE2NzY1","avatar_url":"https://avatars2.githubusercontent.com/u/14816765?v=4","gravatar_id":"","url":"https://api.github.com/users/istefano82","html_url":"https://github.com/istefano82","followers_url":"https://api.github.com/users/istefano82/followers","following_url":"https://api.github.com/users/istefano82/following{/other_user}","gists_url":"https://api.github.com/users/istefano82/gists{/gist_id}","starred_url":"https://api.github.com/users/istefano82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istefano82/subscriptions","organizations_url":"https://api.github.com/users/istefano82/orgs","repos_url":"https://api.github.com/users/istefano82/repos","events_url":"https://api.github.com/users/istefano82/events{/privacy}","received_events_url":"https://api.github.com/users/istefano82/received_events","type":"User","site_admin":false},"html_url":"https://github.com/istefano82/ludwig","description":"Ludwig is a toolbox built on top of TensorFlow that allows to train and test deep learning models without the need to write code.","fork":true,"url":"https://api.github.com/repos/istefano82/ludwig","forks_url":"https://api.github.com/repos/istefano82/ludwig/forks","keys_url":"https://api.github.com/repos/istefano82/ludwig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istefano82/ludwig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istefano82/ludwig/teams","hooks_url":"https://api.github.com/repos/istefano82/ludwig/hooks","issue_events_url":"https://api.github.com/repos/istefano82/ludwig/issues/events{/number}","events_url":"https://api.github.com/repos/istefano82/ludwig/events","assignees_url":"https://api.github.com/repos/istefano82/ludwig/assignees{/user}","branches_url":"https://api.github.com/repos/istefano82/ludwig/branches{/branch}","tags_url":"https://api.github.com/repos/istefano82/ludwig/tags","blobs_url":"https://api.github.com/repos/istefano82/ludwig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istefano82/ludwig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istefano82/ludwig/git/refs{/sha}","trees_url":"https://api.github.com/repos/istefano82/ludwig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istefano82/ludwig/statuses/{sha}","languages_url":"https://api.github.com/repos/istefano82/ludwig/languages","stargazers_url":"https://api.github.com/repos/istefano82/ludwig/stargazers","contributors_url":"https://api.github.com/repos/istefano82/ludwig/contributors","subscribers_url":"https://api.github.com/repos/istefano82/ludwig/subscribers","subscription_url":"https://api.github.com/repos/istefano82/ludwig/subscription","commits_url":"https://api.github.com/repos/istefano82/ludwig/commits{/sha}","git_commits_url":"https://api.github.com/repos/istefano82/ludwig/git/commits{/sha}","comments_url":"https://api.github.com/repos/istefano82/ludwig/comments{/number}","issue_comment_url":"https://api.github.com/repos/istefano82/ludwig/issues/comments{/number}","contents_url":"https://api.github.com/repos/istefano82/ludwig/contents/{+path}","compare_url":"https://api.github.com/repos/istefano82/ludwig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istefano82/ludwig/merges","archive_url":"https://api.github.com/repos/istefano82/ludwig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istefano82/ludwig/downloads","issues_url":"https://api.github.com/repos/istefano82/ludwig/issues{/number}","pulls_url":"https://api.github.com/repos/istefano82/ludwig/pulls{/number}","milestones_url":"https://api.github.com/repos/istefano82/ludwig/milestones{/number}","notifications_url":"https://api.github.com/repos/istefano82/ludwig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istefano82/ludwig/labels{/name}","releases_url":"https://api.github.com/repos/istefano82/ludwig/releases{/id}","deployments_url":"https://api.github.com/repos/istefano82/ludwig/deployments","created_at":"2019-05-28T19:31:04Z","updated_at":"2019-05-28T19:31:07Z","pushed_at":"2019-06-10T20:23:00Z","git_url":"git://github.com/istefano82/ludwig.git","ssh_url":"git@github.com:istefano82/ludwig.git","clone_url":"https://github.com/istefano82/ludwig.git","svn_url":"https://github.com/istefano82/ludwig","homepage":"http://uber.github.io/ludwig/","size":8036,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"istefano82:viz_file_output","ref":"viz_file_output","sha":"1331d5f654f104071845b528bc1c9f5f725f5160","user":{"login":"istefano82","id":14816765,"node_id":"MDQ6VXNlcjE0ODE2NzY1","avatar_url":"https://avatars2.githubusercontent.com/u/14816765?v=4","gravatar_id":"","url":"https://api.github.com/users/istefano82","html_url":"https://github.com/istefano82","followers_url":"https://api.github.com/users/istefano82/followers","following_url":"https://api.github.com/users/istefano82/following{/other_user}","gists_url":"https://api.github.com/users/istefano82/gists{/gist_id}","starred_url":"https://api.github.com/users/istefano82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istefano82/subscriptions","organizations_url":"https://api.github.com/users/istefano82/orgs","repos_url":"https://api.github.com/users/istefano82/repos","events_url":"https://api.github.com/users/istefano82/events{/privacy}","received_events_url":"https://api.github.com/users/istefano82/received_events","type":"User","site_admin":false},"repo":{"id":189090836,"node_id":"MDEwOlJlcG9zaXRvcnkxODkwOTA4MzY=","name":"ludwig","full_name":"istefano82/ludwig","private":false,"owner":{"login":"istefano82","id":14816765,"node_id":"MDQ6VXNlcjE0ODE2NzY1","avatar_url":"https://avatars2.githubusercontent.com/u/14816765?v=4","gravatar_id":"","url":"https://api.github.com/users/istefano82","html_url":"https://github.com/istefano82","followers_url":"https://api.github.com/users/istefano82/followers","following_url":"https://api.github.com/users/istefano82/following{/other_user}","gists_url":"https://api.github.com/users/istefano82/gists{/gist_id}","starred_url":"https://api.github.com/users/istefano82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istefano82/subscriptions","organizations_url":"https://api.github.com/users/istefano82/orgs","repos_url":"https://api.github.com/users/istefano82/repos","events_url":"https://api.github.com/users/istefano82/events{/privacy}","received_events_url":"https://api.github.com/users/istefano82/received_events","type":"User","site_admin":false},"html_url":"https://github.com/istefano82/ludwig","description":"Ludwig is a toolbox built on top of TensorFlow that allows to train and test deep learning models without the need to write code.","fork":true,"url":"https://api.github.com/repos/istefano82/ludwig","forks_url":"https://api.github.com/repos/istefano82/ludwig/forks","keys_url":"https://api.github.com/repos/istefano82/ludwig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istefano82/ludwig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istefano82/ludwig/teams","hooks_url":"https://api.github.com/repos/istefano82/ludwig/hooks","issue_events_url":"https://api.github.com/repos/istefano82/ludwig/issues/events{/number}","events_url":"https://api.github.com/repos/istefano82/ludwig/events","assignees_url":"https://api.github.com/repos/istefano82/ludwig/assignees{/user}","branches_url":"https://api.github.com/repos/istefano82/ludwig/branches{/branch}","tags_url":"https://api.github.com/repos/istefano82/ludwig/tags","blobs_url":"https://api.github.com/repos/istefano82/ludwig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istefano82/ludwig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istefano82/ludwig/git/refs{/sha}","trees_url":"https://api.github.com/repos/istefano82/ludwig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istefano82/ludwig/statuses/{sha}","languages_url":"https://api.github.com/repos/istefano82/ludwig/languages","stargazers_url":"https://api.github.com/repos/istefano82/ludwig/stargazers","contributors_url":"https://api.github.com/repos/istefano82/ludwig/contributors","subscribers_url":"https://api.github.com/repos/istefano82/ludwig/subscribers","subscription_url":"https://api.github.com/repos/istefano82/ludwig/subscription","commits_url":"https://api.github.com/repos/istefano82/ludwig/commits{/sha}","git_commits_url":"https://api.github.com/repos/istefano82/ludwig/git/commits{/sha}","comments_url":"https://api.github.com/repos/istefano82/ludwig/comments{/number}","issue_comment_url":"https://api.github.com/repos/istefano82/ludwig/issues/comments{/number}","contents_url":"https://api.github.com/repos/istefano82/ludwig/contents/{+path}","compare_url":"https://api.github.com/repos/istefano82/ludwig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istefano82/ludwig/merges","archive_url":"https://api.github.com/repos/istefano82/ludwig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istefano82/ludwig/downloads","issues_url":"https://api.github.com/repos/istefano82/ludwig/issues{/number}","pulls_url":"https://api.github.com/repos/istefano82/ludwig/pulls{/number}","milestones_url":"https://api.github.com/repos/istefano82/ludwig/milestones{/number}","notifications_url":"https://api.github.com/repos/istefano82/ludwig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istefano82/ludwig/labels{/name}","releases_url":"https://api.github.com/repos/istefano82/ludwig/releases{/id}","deployments_url":"https://api.github.com/repos/istefano82/ludwig/deployments","created_at":"2019-05-28T19:31:04Z","updated_at":"2019-05-28T19:31:07Z","pushed_at":"2019-06-10T20:23:00Z","git_url":"git://github.com/istefano82/ludwig.git","ssh_url":"git@github.com:istefano82/ludwig.git","clone_url":"https://github.com/istefano82/ludwig.git","svn_url":"https://github.com/istefano82/ludwig","homepage":"http://uber.github.io/ludwig/","size":8036,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istefano82/ludwig/pulls/1"},"html":{"href":"https://github.com/istefano82/ludwig/pull/1"},"issue":{"href":"https://api.github.com/repos/istefano82/ludwig/issues/1"},"comments":{"href":"https://api.github.com/repos/istefano82/ludwig/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/istefano82/ludwig/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/istefano82/ludwig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istefano82/ludwig/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/istefano82/ludwig/statuses/a1b3b982590b979d8d2901032e9d81342c92e980"}},"author_association":"OWNER"}}
{"actor":{"display_login":"w4nderlust"}}