{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/core-setup/issues/5813","repository_url":"https://api.github.com/repos/dotnet/core-setup","labels_url":"https://api.github.com/repos/dotnet/core-setup/issues/5813/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/5813/comments","events_url":"https://api.github.com/repos/dotnet/core-setup/issues/5813/events","html_url":"https://github.com/dotnet/core-setup/issues/5813","id":432648474,"node_id":"MDU6SXNzdWU0MzI2NDg0NzQ=","number":5813,"title":"Assertion framework-version-resolution spec error","user":{"login":"sdmaclea","id":25674984,"node_id":"MDQ6VXNlcjI1Njc0OTg0","avatar_url":"https://avatars3.githubusercontent.com/u/25674984?v=4","gravatar_id":"","url":"https://api.github.com/users/sdmaclea","html_url":"https://github.com/sdmaclea","followers_url":"https://api.github.com/users/sdmaclea/followers","following_url":"https://api.github.com/users/sdmaclea/following{/other_user}","gists_url":"https://api.github.com/users/sdmaclea/gists{/gist_id}","starred_url":"https://api.github.com/users/sdmaclea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdmaclea/subscriptions","organizations_url":"https://api.github.com/users/sdmaclea/orgs","repos_url":"https://api.github.com/users/sdmaclea/repos","events_url":"https://api.github.com/users/sdmaclea/events{/privacy}","received_events_url":"https://api.github.com/users/sdmaclea/received_events","type":"User","site_admin":false},"labels":[{"id":554535788,"node_id":"MDU6TGFiZWw1NTQ1MzU3ODg=","url":"https://api.github.com/repos/dotnet/core-setup/labels/Discussion","name":"Discussion","color":"5319e7","default":false},{"id":801029392,"node_id":"MDU6TGFiZWw4MDEwMjkzOTI=","url":"https://api.github.com/repos/dotnet/core-setup/labels/area-Host","name":"area-Host","color":"d4c5f9","default":false},{"id":379375060,"node_id":"MDU6TGFiZWwzNzkzNzUwNjA=","url":"https://api.github.com/repos/dotnet/core-setup/labels/bug","name":"bug","color":"1d76db","default":true},{"id":802052213,"node_id":"MDU6TGFiZWw4MDIwNTIyMTM=","url":"https://api.github.com/repos/dotnet/core-setup/labels/documentation","name":"documentation","color":"207de5","default":false}],"state":"open","locked":false,"assignee":{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},"assignees":[{"login":"vitek-karas","id":10670590,"node_id":"MDQ6VXNlcjEwNjcwNTkw","avatar_url":"https://avatars2.githubusercontent.com/u/10670590?v=4","gravatar_id":"","url":"https://api.github.com/users/vitek-karas","html_url":"https://github.com/vitek-karas","followers_url":"https://api.github.com/users/vitek-karas/followers","following_url":"https://api.github.com/users/vitek-karas/following{/other_user}","gists_url":"https://api.github.com/users/vitek-karas/gists{/gist_id}","starred_url":"https://api.github.com/users/vitek-karas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitek-karas/subscriptions","organizations_url":"https://api.github.com/users/vitek-karas/orgs","repos_url":"https://api.github.com/users/vitek-karas/repos","events_url":"https://api.github.com/users/vitek-karas/events{/privacy}","received_events_url":"https://api.github.com/users/vitek-karas/received_events","type":"User","site_admin":false},{"login":"sdmaclea","id":25674984,"node_id":"MDQ6VXNlcjI1Njc0OTg0","avatar_url":"https://avatars3.githubusercontent.com/u/25674984?v=4","gravatar_id":"","url":"https://api.github.com/users/sdmaclea","html_url":"https://github.com/sdmaclea","followers_url":"https://api.github.com/users/sdmaclea/followers","following_url":"https://api.github.com/users/sdmaclea/following{/other_user}","gists_url":"https://api.github.com/users/sdmaclea/gists{/gist_id}","starred_url":"https://api.github.com/users/sdmaclea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdmaclea/subscriptions","organizations_url":"https://api.github.com/users/sdmaclea/orgs","repos_url":"https://api.github.com/users/sdmaclea/repos","events_url":"https://api.github.com/users/sdmaclea/events{/privacy}","received_events_url":"https://api.github.com/users/sdmaclea/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/core-setup/milestones/16","html_url":"https://github.com/dotnet/core-setup/milestone/16","labels_url":"https://api.github.com/repos/dotnet/core-setup/milestones/16/labels","id":3246415,"node_id":"MDk6TWlsZXN0b25lMzI0NjQxNQ==","number":16,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":122,"state":"open","created_at":"2018-04-05T22:09:43Z","updated_at":"2019-04-12T16:30:00Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2019-04-12T16:30:00Z","updated_at":"2019-04-12T16:36:37Z","closed_at":null,"author_association":"MEMBER","body":"This part of the [framework-version-resolution spec](https://github.com/dotnet/core-setup/blob/master/Documentation/design-docs/framework-version-resolution.md) is completely wrong\r\n\r\n+ `Minor` - if the exact `major.minor` is found, then the equal or lowest higher patch version is used. Otherwise the lowest higher minor is found and the lowest patch is used.\r\n+ `Major` - if the exact `major` is found, the rules for `Minor` above are followed. Otherwise the lowest higher `major.minor.patch` is selected (so lowest patch available for a given `major.minor`).\r\n\r\nIs should be\r\n+ `Minor` - `applyPatches=false`, option ignored.  Behavior `Minor` behavior is unchanged.\r\n+ `Major` - `applyPatches=false`, option ignored., Behavior `Major` behavior is unchanged."},"comment":{"url":"https://api.github.com/repos/dotnet/core-setup/issues/comments/482640969","html_url":"https://github.com/dotnet/core-setup/issues/5813#issuecomment-482640969","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/5813","id":482640969,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4MjY0MDk2OQ==","user":{"login":"sdmaclea","id":25674984,"node_id":"MDQ6VXNlcjI1Njc0OTg0","avatar_url":"https://avatars3.githubusercontent.com/u/25674984?v=4","gravatar_id":"","url":"https://api.github.com/users/sdmaclea","html_url":"https://github.com/sdmaclea","followers_url":"https://api.github.com/users/sdmaclea/followers","following_url":"https://api.github.com/users/sdmaclea/following{/other_user}","gists_url":"https://api.github.com/users/sdmaclea/gists{/gist_id}","starred_url":"https://api.github.com/users/sdmaclea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdmaclea/subscriptions","organizations_url":"https://api.github.com/users/sdmaclea/orgs","repos_url":"https://api.github.com/users/sdmaclea/repos","events_url":"https://api.github.com/users/sdmaclea/events{/privacy}","received_events_url":"https://api.github.com/users/sdmaclea/received_events","type":"User","site_admin":false},"created_at":"2019-04-12T16:36:37Z","updated_at":"2019-04-12T16:36:37Z","author_association":"MEMBER","body":"@sdmaclea said in https://github.com/dotnet/core-setup/pull/5691#discussion_r274972761 and https://github.com/dotnet/core-setup/pull/5691#discussion_r274977632\r\n\r\n> It basically says: Once you're done picking version using the rollForward rules, normally you should then roll forward to latest patch of that version, but applyPatches may disable that behavior.\r\n\r\nThis makes no sense.  In no way could the App predict that it would allow rolling forward `major` or `minor`, but applying patches wouldn't be acceptable. We certainly shouldn't treat it that way in 3.*.  If we do it is a major & minor 😁  new bug we are introducing.\r\n\r\nThis part of the spec is completely wrong\r\n\r\n+ `Minor` - if the exact `major.minor` is found, then the equal or lowest higher patch version is used. Otherwise the lowest higher minor is found and the lowest patch is used.\r\n+ `Major` - if the exact `major` is found, the rules for `Minor` above are followed. Otherwise the lowest higher `major.minor.patch` is selected (so lowest patch available for a given `major.minor`).\r\n\r\nIs should be\r\n+ `Minor` - `applyPatches=false`, Behavior `Minor` behavior is unchanged.\r\n+ `Major` - `applyPatches=false`, Behavior `Major` behavior is unchanged.\r\n\r\n"}}
{"actor":{"display_login":"sdmaclea"}}