{"action":"closed","number":54159,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/54159","id":305812902,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1ODEyOTAy","html_url":"https://github.com/saltstack/salt/pull/54159","diff_url":"https://github.com/saltstack/salt/pull/54159.diff","patch_url":"https://github.com/saltstack/salt/pull/54159.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/54159","number":54159,"state":"closed","locked":false,"title":"Test mode should return changes","user":{"login":"angeloudy","id":1284475,"node_id":"MDQ6VXNlcjEyODQ0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1284475?v=4","gravatar_id":"","url":"https://api.github.com/users/angeloudy","html_url":"https://github.com/angeloudy","followers_url":"https://api.github.com/users/angeloudy/followers","following_url":"https://api.github.com/users/angeloudy/following{/other_user}","gists_url":"https://api.github.com/users/angeloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/angeloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angeloudy/subscriptions","organizations_url":"https://api.github.com/users/angeloudy/orgs","repos_url":"https://api.github.com/users/angeloudy/repos","events_url":"https://api.github.com/users/angeloudy/events{/privacy}","received_events_url":"https://api.github.com/users/angeloudy/received_events","type":"User","site_admin":false},"body":"If extraction is needed, the state should return some changes, otherwise, requisites such as `prereq`, `onchanges` won't work.\r\n\r\nIt's hard to determine the exact changes, but the archive state should at least return some thing non-empty as long as extraction is necessary.\r\n","created_at":"2019-08-09T02:33:07Z","updated_at":"2019-08-13T00:52:00Z","closed_at":"2019-08-13T00:52:00Z","merged_at":null,"merge_commit_sha":"3876f7ce6a8039683fa56b31da8b508f7abc5a7d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xeacott","id":31625359,"node_id":"MDQ6VXNlcjMxNjI1MzU5","avatar_url":"https://avatars2.githubusercontent.com/u/31625359?v=4","gravatar_id":"","url":"https://api.github.com/users/xeacott","html_url":"https://github.com/xeacott","followers_url":"https://api.github.com/users/xeacott/followers","following_url":"https://api.github.com/users/xeacott/following{/other_user}","gists_url":"https://api.github.com/users/xeacott/gists{/gist_id}","starred_url":"https://api.github.com/users/xeacott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeacott/subscriptions","organizations_url":"https://api.github.com/users/xeacott/orgs","repos_url":"https://api.github.com/users/xeacott/repos","events_url":"https://api.github.com/users/xeacott/events{/privacy}","received_events_url":"https://api.github.com/users/xeacott/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"team-core","id":1734030,"node_id":"MDQ6VGVhbTE3MzQwMzA=","slug":"team-core","description":"Merge access to all core saltstack repos (including raet, libnacl, and the like)","privacy":"closed","url":"https://api.github.com/teams/1734030","html_url":"https://github.com/orgs/saltstack/teams/team-core","members_url":"https://api.github.com/teams/1734030/members{/member}","repositories_url":"https://api.github.com/teams/1734030/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/54159/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/54159/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/54159/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/9b693e18a26bc18633d08fe58a2123766086c22e","head":{"label":"angeloudy:fix_requisite","ref":"fix_requisite","sha":"9b693e18a26bc18633d08fe58a2123766086c22e","user":{"login":"angeloudy","id":1284475,"node_id":"MDQ6VXNlcjEyODQ0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1284475?v=4","gravatar_id":"","url":"https://api.github.com/users/angeloudy","html_url":"https://github.com/angeloudy","followers_url":"https://api.github.com/users/angeloudy/followers","following_url":"https://api.github.com/users/angeloudy/following{/other_user}","gists_url":"https://api.github.com/users/angeloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/angeloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angeloudy/subscriptions","organizations_url":"https://api.github.com/users/angeloudy/orgs","repos_url":"https://api.github.com/users/angeloudy/repos","events_url":"https://api.github.com/users/angeloudy/events{/privacy}","received_events_url":"https://api.github.com/users/angeloudy/received_events","type":"User","site_admin":false},"repo":{"id":106341949,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzNDE5NDk=","name":"salt","full_name":"angeloudy/salt","private":false,"owner":{"login":"angeloudy","id":1284475,"node_id":"MDQ6VXNlcjEyODQ0NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1284475?v=4","gravatar_id":"","url":"https://api.github.com/users/angeloudy","html_url":"https://github.com/angeloudy","followers_url":"https://api.github.com/users/angeloudy/followers","following_url":"https://api.github.com/users/angeloudy/following{/other_user}","gists_url":"https://api.github.com/users/angeloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/angeloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angeloudy/subscriptions","organizations_url":"https://api.github.com/users/angeloudy/orgs","repos_url":"https://api.github.com/users/angeloudy/repos","events_url":"https://api.github.com/users/angeloudy/events{/privacy}","received_events_url":"https://api.github.com/users/angeloudy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/angeloudy/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":true,"url":"https://api.github.com/repos/angeloudy/salt","forks_url":"https://api.github.com/repos/angeloudy/salt/forks","keys_url":"https://api.github.com/repos/angeloudy/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angeloudy/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angeloudy/salt/teams","hooks_url":"https://api.github.com/repos/angeloudy/salt/hooks","issue_events_url":"https://api.github.com/repos/angeloudy/salt/issues/events{/number}","events_url":"https://api.github.com/repos/angeloudy/salt/events","assignees_url":"https://api.github.com/repos/angeloudy/salt/assignees{/user}","branches_url":"https://api.github.com/repos/angeloudy/salt/branches{/branch}","tags_url":"https://api.github.com/repos/angeloudy/salt/tags","blobs_url":"https://api.github.com/repos/angeloudy/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angeloudy/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angeloudy/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/angeloudy/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angeloudy/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/angeloudy/salt/languages","stargazers_url":"https://api.github.com/repos/angeloudy/salt/stargazers","contributors_url":"https://api.github.com/repos/angeloudy/salt/contributors","subscribers_url":"https://api.github.com/repos/angeloudy/salt/subscribers","subscription_url":"https://api.github.com/repos/angeloudy/salt/subscription","commits_url":"https://api.github.com/repos/angeloudy/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/angeloudy/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/angeloudy/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/angeloudy/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/angeloudy/salt/contents/{+path}","compare_url":"https://api.github.com/repos/angeloudy/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angeloudy/salt/merges","archive_url":"https://api.github.com/repos/angeloudy/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angeloudy/salt/downloads","issues_url":"https://api.github.com/repos/angeloudy/salt/issues{/number}","pulls_url":"https://api.github.com/repos/angeloudy/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/angeloudy/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/angeloudy/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angeloudy/salt/labels{/name}","releases_url":"https://api.github.com/repos/angeloudy/salt/releases{/id}","deployments_url":"https://api.github.com/repos/angeloudy/salt/deployments","created_at":"2017-10-09T22:30:33Z","updated_at":"2019-05-08T06:46:22Z","pushed_at":"2019-08-09T02:27:07Z","git_url":"git://github.com/angeloudy/salt.git","ssh_url":"git@github.com:angeloudy/salt.git","clone_url":"https://github.com/angeloudy/salt.git","svn_url":"https://github.com/angeloudy/salt","homepage":"https://repo.saltstack.com/","size":428408,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"6acc4128a96fad613e1b7c9e15e49fbae8fd9e1f","user":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMjQ4","name":"salt","full_name":"saltstack/salt","private":false,"owner":{"login":"saltstack","id":1147473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDc0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2019-08-12T23:20:41Z","pushed_at":"2019-08-13T00:29:49Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":429682,"stargazers_count":10157,"watchers_count":10157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4610,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2714,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4610,"open_issues":2714,"watchers":10157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/54159"},"html":{"href":"https://github.com/saltstack/salt/pull/54159"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/54159"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/54159/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/54159/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/54159/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/9b693e18a26bc18633d08fe58a2123766086c22e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"angeloudy"}}