{"comment":{"url":"https://api.github.com/repos/aquiladev/remittance/comments/33764067","html_url":"https://github.com/aquiladev/remittance/commit/86f7bc55b41ff2d5ddc101adfa420938f4b10609#commitcomment-33764067","id":33764067,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMzc2NDA2Nw==","user":{"login":"adelRestom","id":37046080,"node_id":"MDQ6VXNlcjM3MDQ2MDgw","avatar_url":"https://avatars1.githubusercontent.com/u/37046080?v=4","gravatar_id":"","url":"https://api.github.com/users/adelRestom","html_url":"https://github.com/adelRestom","followers_url":"https://api.github.com/users/adelRestom/followers","following_url":"https://api.github.com/users/adelRestom/following{/other_user}","gists_url":"https://api.github.com/users/adelRestom/gists{/gist_id}","starred_url":"https://api.github.com/users/adelRestom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adelRestom/subscriptions","organizations_url":"https://api.github.com/users/adelRestom/orgs","repos_url":"https://api.github.com/users/adelRestom/repos","events_url":"https://api.github.com/users/adelRestom/events{/privacy}","received_events_url":"https://api.github.com/users/adelRestom/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"86f7bc55b41ff2d5ddc101adfa420938f4b10609","created_at":"2019-06-02T16:42:37Z","updated_at":"2019-06-02T16:42:37Z","author_association":"NONE","body":"Hi, sorry about the delay; I was in Texas on Fri/Sat.\r\n\r\n**Remittance**\r\n1. Rename `account` attribute in `generateSecret()` function to `receiver` or `shopOwner` so that the user knows that they should pass that address.\r\n\r\n**Tests**\r\n1. Add a test to `cancelRemittance` where the life time is not 0; read this article, it has a section called **Time Travel**: https://medium.com/coinmonks/testing-solidity-with-truffle-and-async-await-396e81c54f93\r\n\r\nGreat work btw, you can start working on the UI if you want; also for the next commit, I will ask Xavier and Rob to have a final look :slightly_smiling_face: "}}
{"actor":{"display_login":"adelRestom"}}