{"action":"created","comment":{"url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/comments/348435625","pull_request_review_id":319773583,"id":348435625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODQzNTYyNQ==","diff_hunk":"@@ -1328,81 +1410,83 @@ def show(self, x, show_surrounds=True):\n         else:\n             sublime_api.view_show_point(self.view_id, x, show_surrounds)\n \n-    def show_at_center(self, x):\n+    def show_at_center(self, x: Union[Selection, Region, int]) -> None:\n         \"\"\"Scrolls the view to center on x, which may be a Region or point\"\"\"\n         if isinstance(x, Region):\n             sublime_api.view_show_region_at_center(self.view_id, x)\n         else:\n             sublime_api.view_show_point_at_center(self.view_id, x)\n \n-    def viewport_position(self):\n+    def viewport_position(self) -> Vector:\n         \"\"\"Returns the (x, y) scroll position of the view in layout coordinates\"\"\"\n         return sublime_api.view_viewport_position(self.view_id)\n \n-    def set_viewport_position(self, xy, animate=True):\n+    def set_viewport_position(self, xy: Vector, animate: bool = True) -> None:\n         \"\"\"Scrolls the view to the given position in layout coordinates\"\"\"\n         sublime_api.view_set_viewport_position(self.view_id, xy, animate)\n \n-    def viewport_extent(self):\n+    def viewport_extent(self) -> Vector:\n         \"\"\"Returns the width and height of the viewport, in layout coordinates\"\"\"\n         return sublime_api.view_viewport_extents(self.view_id)\n \n-    def layout_extent(self):\n+    def layout_extent(self) -> Vector:\n         \"\"\"Returns the total height and width of the document, in layout coordinates\"\"\"\n         return sublime_api.view_layout_extents(self.view_id)\n \n-    def text_to_layout(self, tp):\n+    def text_tolayout(self, tp: int) -> Vector:\n         \"\"\"Converts a text point to layout coordinates\"\"\"\n         return sublime_api.view_text_to_layout(self.view_id, tp)\n \n-    def text_to_window(self, tp):\n+    def text_to_window(self, tp: int) -> Vector:\n         \"\"\"Converts a text point to window coordinates\"\"\"\n         return self.layout_to_window(self.text_to_layout(tp))\n \n-    def layout_to_text(self, xy):\n+    def layout_to_text(self, xy: Vector) -> int:\n         \"\"\"Converts layout coordinates to a text point\"\"\"\n         return sublime_api.view_layout_to_text(self.view_id, xy)\n \n-    def layout_to_window(self, xy):\n+    def layout_to_window(self, xy: Vector) -> Vector:\n         \"\"\"Converts layout coordinates to window coordinates\"\"\"\n         return sublime_api.view_layout_to_window(self.view_id, xy)\n \n-    def window_to_layout(self, xy):\n+    def window_tolayout(self, xy: Vector) -> Vector:\n         \"\"\"Converts window coordinates to layout coordinates\"\"\"\n         return sublime_api.view_window_to_layout(self.view_id, xy)\n \n-    def window_to_text(self, xy):\n+    def window_to_text(self, xy: Vector) -> int:\n         \"\"\"Converts window coordinates to a text point\"\"\"\n         return self.layout_to_text(self.window_to_layout(xy))\n \n-    def line_height(self):\n+    def line_height(self) -> float:\n         \"\"\"Returns the height of a line in layout coordinates\"\"\"\n         return sublime_api.view_line_height(self.view_id)\n \n-    def em_width(self):\n+    def em_width(self) -> float:\n         \"\"\"Returns the em-width of the current font in layout coordinates\"\"\"\n         return sublime_api.view_em_width(self.view_id)\n \n-    def is_folded(self, sr):\n+    def is_folded(self, sr) -> bool:","path":"sublime.py","position":1582,"original_position":1582,"commit_id":"4021028c3b0fd728cb65f674eae6737a2eef882b","original_commit_id":"4021028c3b0fd728cb65f674eae6737a2eef882b","user":{"login":"FichteFoll","id":931051,"node_id":"MDQ6VXNlcjkzMTA1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/931051?v=4","gravatar_id":"","url":"https://api.github.com/users/FichteFoll","html_url":"https://github.com/FichteFoll","followers_url":"https://api.github.com/users/FichteFoll/followers","following_url":"https://api.github.com/users/FichteFoll/following{/other_user}","gists_url":"https://api.github.com/users/FichteFoll/gists{/gist_id}","starred_url":"https://api.github.com/users/FichteFoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FichteFoll/subscriptions","organizations_url":"https://api.github.com/users/FichteFoll/orgs","repos_url":"https://api.github.com/users/FichteFoll/repos","events_url":"https://api.github.com/users/FichteFoll/events{/privacy}","received_events_url":"https://api.github.com/users/FichteFoll/received_events","type":"User","site_admin":false},"body":"Missing hint.","created_at":"2019-11-20T11:43:35Z","updated_at":"2019-11-20T11:46:49Z","html_url":"https://github.com/AmjadHD/sublime_dev/pull/1#discussion_r348435625","pull_request_url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/comments/348435625"},"html":{"href":"https://github.com/AmjadHD/sublime_dev/pull/1#discussion_r348435625"},"pull_request":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1","id":343303653,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzMzAzNjUz","html_url":"https://github.com/AmjadHD/sublime_dev/pull/1","diff_url":"https://github.com/AmjadHD/sublime_dev/pull/1.diff","patch_url":"https://github.com/AmjadHD/sublime_dev/pull/1.patch","issue_url":"https://api.github.com/repos/AmjadHD/sublime_dev/issues/1","number":1,"state":"open","locked":false,"title":"Add type hinting to sublime.py","user":{"login":"jfcherng","id":6594915,"node_id":"MDQ6VXNlcjY1OTQ5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6594915?v=4","gravatar_id":"","url":"https://api.github.com/users/jfcherng","html_url":"https://github.com/jfcherng","followers_url":"https://api.github.com/users/jfcherng/followers","following_url":"https://api.github.com/users/jfcherng/following{/other_user}","gists_url":"https://api.github.com/users/jfcherng/gists{/gist_id}","starred_url":"https://api.github.com/users/jfcherng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfcherng/subscriptions","organizations_url":"https://api.github.com/users/jfcherng/orgs","repos_url":"https://api.github.com/users/jfcherng/repos","events_url":"https://api.github.com/users/jfcherng/events{/privacy}","received_events_url":"https://api.github.com/users/jfcherng/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/6594915/69234688-b5d29e80-0bca-11ea-82f9-05d4f98e6026.png)\r\n\r\nSo we can have both docstring and type shown in the popup from LSP. What do you think :smiley: ?\r\n\r\n---\r\n\r\nRequire Python 3.5 and above for the dev env.","created_at":"2019-11-20T11:20:49Z","updated_at":"2019-11-20T11:46:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a6b0512cb4b277a40f552d4053d0f8897bb72c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AmjadHD/sublime_dev/issues/1/comments","statuses_url":"https://api.github.com/repos/AmjadHD/sublime_dev/statuses/4021028c3b0fd728cb65f674eae6737a2eef882b","head":{"label":"jfcherng:merge_type_and_doc","ref":"merge_type_and_doc","sha":"4021028c3b0fd728cb65f674eae6737a2eef882b","user":{"login":"jfcherng","id":6594915,"node_id":"MDQ6VXNlcjY1OTQ5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6594915?v=4","gravatar_id":"","url":"https://api.github.com/users/jfcherng","html_url":"https://github.com/jfcherng","followers_url":"https://api.github.com/users/jfcherng/followers","following_url":"https://api.github.com/users/jfcherng/following{/other_user}","gists_url":"https://api.github.com/users/jfcherng/gists{/gist_id}","starred_url":"https://api.github.com/users/jfcherng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfcherng/subscriptions","organizations_url":"https://api.github.com/users/jfcherng/orgs","repos_url":"https://api.github.com/users/jfcherng/repos","events_url":"https://api.github.com/users/jfcherng/events{/privacy}","received_events_url":"https://api.github.com/users/jfcherng/received_events","type":"User","site_admin":false},"repo":{"id":222920133,"node_id":"MDEwOlJlcG9zaXRvcnkyMjI5MjAxMzM=","name":"sublime_dev","full_name":"jfcherng/sublime_dev","private":false,"owner":{"login":"jfcherng","id":6594915,"node_id":"MDQ6VXNlcjY1OTQ5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6594915?v=4","gravatar_id":"","url":"https://api.github.com/users/jfcherng","html_url":"https://github.com/jfcherng","followers_url":"https://api.github.com/users/jfcherng/followers","following_url":"https://api.github.com/users/jfcherng/following{/other_user}","gists_url":"https://api.github.com/users/jfcherng/gists{/gist_id}","starred_url":"https://api.github.com/users/jfcherng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfcherng/subscriptions","organizations_url":"https://api.github.com/users/jfcherng/orgs","repos_url":"https://api.github.com/users/jfcherng/repos","events_url":"https://api.github.com/users/jfcherng/events{/privacy}","received_events_url":"https://api.github.com/users/jfcherng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jfcherng/sublime_dev","description":"add API docstrings and stubs for sublime.py and sublime_plugin.py","fork":true,"url":"https://api.github.com/repos/jfcherng/sublime_dev","forks_url":"https://api.github.com/repos/jfcherng/sublime_dev/forks","keys_url":"https://api.github.com/repos/jfcherng/sublime_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfcherng/sublime_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfcherng/sublime_dev/teams","hooks_url":"https://api.github.com/repos/jfcherng/sublime_dev/hooks","issue_events_url":"https://api.github.com/repos/jfcherng/sublime_dev/issues/events{/number}","events_url":"https://api.github.com/repos/jfcherng/sublime_dev/events","assignees_url":"https://api.github.com/repos/jfcherng/sublime_dev/assignees{/user}","branches_url":"https://api.github.com/repos/jfcherng/sublime_dev/branches{/branch}","tags_url":"https://api.github.com/repos/jfcherng/sublime_dev/tags","blobs_url":"https://api.github.com/repos/jfcherng/sublime_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfcherng/sublime_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfcherng/sublime_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfcherng/sublime_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfcherng/sublime_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jfcherng/sublime_dev/languages","stargazers_url":"https://api.github.com/repos/jfcherng/sublime_dev/stargazers","contributors_url":"https://api.github.com/repos/jfcherng/sublime_dev/contributors","subscribers_url":"https://api.github.com/repos/jfcherng/sublime_dev/subscribers","subscription_url":"https://api.github.com/repos/jfcherng/sublime_dev/subscription","commits_url":"https://api.github.com/repos/jfcherng/sublime_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfcherng/sublime_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfcherng/sublime_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfcherng/sublime_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfcherng/sublime_dev/contents/{+path}","compare_url":"https://api.github.com/repos/jfcherng/sublime_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfcherng/sublime_dev/merges","archive_url":"https://api.github.com/repos/jfcherng/sublime_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfcherng/sublime_dev/downloads","issues_url":"https://api.github.com/repos/jfcherng/sublime_dev/issues{/number}","pulls_url":"https://api.github.com/repos/jfcherng/sublime_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jfcherng/sublime_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jfcherng/sublime_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfcherng/sublime_dev/labels{/name}","releases_url":"https://api.github.com/repos/jfcherng/sublime_dev/releases{/id}","deployments_url":"https://api.github.com/repos/jfcherng/sublime_dev/deployments","created_at":"2019-11-20T11:15:55Z","updated_at":"2019-11-20T11:15:57Z","pushed_at":"2019-11-20T11:19:02Z","git_url":"git://github.com/jfcherng/sublime_dev.git","ssh_url":"git@github.com:jfcherng/sublime_dev.git","clone_url":"https://github.com/jfcherng/sublime_dev.git","svn_url":"https://github.com/jfcherng/sublime_dev","homepage":"","size":23,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AmjadHD:master","ref":"master","sha":"8a79f5f26c491be484bb002f88a5cc9058de2941","user":{"login":"AmjadHD","id":33235928,"node_id":"MDQ6VXNlcjMzMjM1OTI4","avatar_url":"https://avatars0.githubusercontent.com/u/33235928?v=4","gravatar_id":"","url":"https://api.github.com/users/AmjadHD","html_url":"https://github.com/AmjadHD","followers_url":"https://api.github.com/users/AmjadHD/followers","following_url":"https://api.github.com/users/AmjadHD/following{/other_user}","gists_url":"https://api.github.com/users/AmjadHD/gists{/gist_id}","starred_url":"https://api.github.com/users/AmjadHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmjadHD/subscriptions","organizations_url":"https://api.github.com/users/AmjadHD/orgs","repos_url":"https://api.github.com/users/AmjadHD/repos","events_url":"https://api.github.com/users/AmjadHD/events{/privacy}","received_events_url":"https://api.github.com/users/AmjadHD/received_events","type":"User","site_admin":false},"repo":{"id":157259569,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNTk1Njk=","name":"sublime_dev","full_name":"AmjadHD/sublime_dev","private":false,"owner":{"login":"AmjadHD","id":33235928,"node_id":"MDQ6VXNlcjMzMjM1OTI4","avatar_url":"https://avatars0.githubusercontent.com/u/33235928?v=4","gravatar_id":"","url":"https://api.github.com/users/AmjadHD","html_url":"https://github.com/AmjadHD","followers_url":"https://api.github.com/users/AmjadHD/followers","following_url":"https://api.github.com/users/AmjadHD/following{/other_user}","gists_url":"https://api.github.com/users/AmjadHD/gists{/gist_id}","starred_url":"https://api.github.com/users/AmjadHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmjadHD/subscriptions","organizations_url":"https://api.github.com/users/AmjadHD/orgs","repos_url":"https://api.github.com/users/AmjadHD/repos","events_url":"https://api.github.com/users/AmjadHD/events{/privacy}","received_events_url":"https://api.github.com/users/AmjadHD/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AmjadHD/sublime_dev","description":"add API docstrings and stubs for sublime.py and sublime_plugin.py","fork":false,"url":"https://api.github.com/repos/AmjadHD/sublime_dev","forks_url":"https://api.github.com/repos/AmjadHD/sublime_dev/forks","keys_url":"https://api.github.com/repos/AmjadHD/sublime_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmjadHD/sublime_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmjadHD/sublime_dev/teams","hooks_url":"https://api.github.com/repos/AmjadHD/sublime_dev/hooks","issue_events_url":"https://api.github.com/repos/AmjadHD/sublime_dev/issues/events{/number}","events_url":"https://api.github.com/repos/AmjadHD/sublime_dev/events","assignees_url":"https://api.github.com/repos/AmjadHD/sublime_dev/assignees{/user}","branches_url":"https://api.github.com/repos/AmjadHD/sublime_dev/branches{/branch}","tags_url":"https://api.github.com/repos/AmjadHD/sublime_dev/tags","blobs_url":"https://api.github.com/repos/AmjadHD/sublime_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmjadHD/sublime_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmjadHD/sublime_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmjadHD/sublime_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmjadHD/sublime_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/AmjadHD/sublime_dev/languages","stargazers_url":"https://api.github.com/repos/AmjadHD/sublime_dev/stargazers","contributors_url":"https://api.github.com/repos/AmjadHD/sublime_dev/contributors","subscribers_url":"https://api.github.com/repos/AmjadHD/sublime_dev/subscribers","subscription_url":"https://api.github.com/repos/AmjadHD/sublime_dev/subscription","commits_url":"https://api.github.com/repos/AmjadHD/sublime_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmjadHD/sublime_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmjadHD/sublime_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmjadHD/sublime_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmjadHD/sublime_dev/contents/{+path}","compare_url":"https://api.github.com/repos/AmjadHD/sublime_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmjadHD/sublime_dev/merges","archive_url":"https://api.github.com/repos/AmjadHD/sublime_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmjadHD/sublime_dev/downloads","issues_url":"https://api.github.com/repos/AmjadHD/sublime_dev/issues{/number}","pulls_url":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/AmjadHD/sublime_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/AmjadHD/sublime_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmjadHD/sublime_dev/labels{/name}","releases_url":"https://api.github.com/repos/AmjadHD/sublime_dev/releases{/id}","deployments_url":"https://api.github.com/repos/AmjadHD/sublime_dev/deployments","created_at":"2018-11-12T18:41:48Z","updated_at":"2019-11-20T10:08:46Z","pushed_at":"2019-11-20T11:20:50Z","git_url":"git://github.com/AmjadHD/sublime_dev.git","ssh_url":"git@github.com:AmjadHD/sublime_dev.git","clone_url":"https://github.com/AmjadHD/sublime_dev.git","svn_url":"https://github.com/AmjadHD/sublime_dev","homepage":"","size":23,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1"},"html":{"href":"https://github.com/AmjadHD/sublime_dev/pull/1"},"issue":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/issues/1"},"comments":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AmjadHD/sublime_dev/statuses/4021028c3b0fd728cb65f674eae6737a2eef882b"}},"author_association":"NONE"}}
{"actor":{"display_login":"FichteFoll"}}