{"action":"created","issue":{"url":"https://api.github.com/repos/pret/pokecrystal/issues/643","repository_url":"https://api.github.com/repos/pret/pokecrystal","labels_url":"https://api.github.com/repos/pret/pokecrystal/issues/643/labels{/name}","comments_url":"https://api.github.com/repos/pret/pokecrystal/issues/643/comments","events_url":"https://api.github.com/repos/pret/pokecrystal/issues/643/events","html_url":"https://github.com/pret/pokecrystal/issues/643","id":469704295,"node_id":"MDU6SXNzdWU0Njk3MDQyOTU=","number":643,"title":"Minor cleanup issues","user":{"login":"aaaaaa123456789","id":6129020,"node_id":"MDQ6VXNlcjYxMjkwMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6129020?v=4","gravatar_id":"","url":"https://api.github.com/users/aaaaaa123456789","html_url":"https://github.com/aaaaaa123456789","followers_url":"https://api.github.com/users/aaaaaa123456789/followers","following_url":"https://api.github.com/users/aaaaaa123456789/following{/other_user}","gists_url":"https://api.github.com/users/aaaaaa123456789/gists{/gist_id}","starred_url":"https://api.github.com/users/aaaaaa123456789/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaaaaa123456789/subscriptions","organizations_url":"https://api.github.com/users/aaaaaa123456789/orgs","repos_url":"https://api.github.com/users/aaaaaa123456789/repos","events_url":"https://api.github.com/users/aaaaaa123456789/events{/privacy}","received_events_url":"https://api.github.com/users/aaaaaa123456789/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-18T10:58:12Z","updated_at":"2019-08-04T17:38:10Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I've been trying to build a reasonably clean ROM from pokecrystal (basically take the repo as it is, remove the weird hacks that only exist in order to match the original exactly, apply the various fixes from the docs, etc.), and I've stumbled upon a few minor hiccups. I'll keep adding them here as I find them.\r\n\r\n- [ ] `gfx/pokedex/question_mark.2bpp` requires a `rgbgfx += -h` rule in the Makefile. This isn't noticeable in the stock repo because the image is never rebuilt due to a pre-compressed image with a matching hash.\r\n- [ ] The footprint correction code in the design flaws document will lead to broken footprints. This is because it fails to account for the fact that footprints are now four tiles apart from each other instead of two. Adding an `add a, a` instruction after the `swap a` that is shortly before the quoted snippet fixes the issue."},"comment":{"url":"https://api.github.com/repos/pret/pokecrystal/issues/comments/518021991","html_url":"https://github.com/pret/pokecrystal/issues/643#issuecomment-518021991","issue_url":"https://api.github.com/repos/pret/pokecrystal/issues/643","id":518021991,"node_id":"MDEyOklzc3VlQ29tbWVudDUxODAyMTk5MQ==","user":{"login":"Rangi42","id":35663410,"node_id":"MDQ6VXNlcjM1NjYzNDEw","avatar_url":"https://avatars2.githubusercontent.com/u/35663410?v=4","gravatar_id":"","url":"https://api.github.com/users/Rangi42","html_url":"https://github.com/Rangi42","followers_url":"https://api.github.com/users/Rangi42/followers","following_url":"https://api.github.com/users/Rangi42/following{/other_user}","gists_url":"https://api.github.com/users/Rangi42/gists{/gist_id}","starred_url":"https://api.github.com/users/Rangi42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rangi42/subscriptions","organizations_url":"https://api.github.com/users/Rangi42/orgs","repos_url":"https://api.github.com/users/Rangi42/repos","events_url":"https://api.github.com/users/Rangi42/events{/privacy}","received_events_url":"https://api.github.com/users/Rangi42/received_events","type":"User","site_admin":false},"created_at":"2019-08-04T17:38:10Z","updated_at":"2019-08-04T17:38:10Z","author_association":"MEMBER","body":"The `C9` at the end of `gfx/diploma/page2.tilemap` is not an end byte; it should be a stray `ret ; unused` after the 20x18 tilemap."}}
{"actor":{"display_login":"Rangi42"}}