{"action":"closed","number":6614,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/6614","id":261732308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYxNzMyMzA4","html_url":"https://github.com/snapcore/snapd/pull/6614","diff_url":"https://github.com/snapcore/snapd/pull/6614.diff","patch_url":"https://github.com/snapcore/snapd/pull/6614.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/6614","number":6614,"state":"closed","locked":false,"title":"cmd/snap-confine: use fixed private tmp directory","user":{"login":"zyga","id":784262,"node_id":"MDQ6VXNlcjc4NDI2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"body":"When snap-confine prepares a fresh per-snap mount namespace\r\nit constructs a private /tmp directory that is not shared with other\r\nsnaps.\r\n\r\nAs a part of this work snap-confine would create a randomly named\r\ndirectory in /tmp/snap.$SNAP_NAME_xxxxx with the x characters replaced\r\nby random unique name.\r\n\r\nThose directories would never be recycled and would be re-created when\r\nthe mount namespace was to be discarded. This was accumulating data in\r\n/tmp that would not be normally removed unless the machine had rebooted.\r\nIn addition whenever multiple temporary directories existed for a single\r\nsnap the user would be unable to easily determine which one is the right\r\none, presenting usability issues for applications that use data in /tmp\r\nfor whatever reason (e.g. temporary log files).\r\n\r\nThis patch changes the path to be fixed, always\r\n/tmp/snap.$SNAP_INSTANCE_NAME/tmp. This opens the avenue towards snapd\r\nmanaging that directory (e.g. to remove it on snap removal).\r\n\r\nThere is only one user-visible consequence: discarding the mount\r\nnamespace and re-running a snap application no longer gives the\r\napplication fresh /tmp directory. It is unlikely anything apart from\r\nsnapd test suite will observe this change though.\r\n\r\nThe test that was checking if the base snap for a given snap has changed\r\nhas now been updated not to rely on the re-creation of /tmp.\r\n\r\nSigned-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>\r\nRelated-To: https://bugzilla.suse.com/show_bug.cgi?id=1127368","created_at":"2019-03-16T00:21:12Z","updated_at":"2019-03-25T14:14:53Z","closed_at":"2019-03-25T14:14:53Z","merged_at":"2019-03-25T14:14:53Z","merge_commit_sha":"9c0bd7fd003588c572b0b537221227ad9d072da9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/6614/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/6614/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/6614/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/079d8bbe987fb608c6845bf7a3bee922ea4b28f6","head":{"label":"zyga:fix/suse-audit-10","ref":"fix/suse-audit-10","sha":"079d8bbe987fb608c6845bf7a3bee922ea4b28f6","user":{"login":"zyga","id":784262,"node_id":"MDQ6VXNlcjc4NDI2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"repo":{"id":45263078,"node_id":"MDEwOlJlcG9zaXRvcnk0NTI2MzA3OA==","name":"snapd","full_name":"zyga/snapd","private":false,"owner":{"login":"zyga","id":784262,"node_id":"MDQ6VXNlcjc4NDI2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zyga/snapd","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/zyga/snapd","forks_url":"https://api.github.com/repos/zyga/snapd/forks","keys_url":"https://api.github.com/repos/zyga/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zyga/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zyga/snapd/teams","hooks_url":"https://api.github.com/repos/zyga/snapd/hooks","issue_events_url":"https://api.github.com/repos/zyga/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/zyga/snapd/events","assignees_url":"https://api.github.com/repos/zyga/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/zyga/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/zyga/snapd/tags","blobs_url":"https://api.github.com/repos/zyga/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zyga/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zyga/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/zyga/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zyga/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/zyga/snapd/languages","stargazers_url":"https://api.github.com/repos/zyga/snapd/stargazers","contributors_url":"https://api.github.com/repos/zyga/snapd/contributors","subscribers_url":"https://api.github.com/repos/zyga/snapd/subscribers","subscription_url":"https://api.github.com/repos/zyga/snapd/subscription","commits_url":"https://api.github.com/repos/zyga/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/zyga/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/zyga/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/zyga/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/zyga/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/zyga/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zyga/snapd/merges","archive_url":"https://api.github.com/repos/zyga/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zyga/snapd/downloads","issues_url":"https://api.github.com/repos/zyga/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/zyga/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/zyga/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/zyga/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zyga/snapd/labels{/name}","releases_url":"https://api.github.com/repos/zyga/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/zyga/snapd/deployments","created_at":"2015-10-30T16:30:25Z","updated_at":"2018-12-06T14:04:50Z","pushed_at":"2019-03-25T10:28:36Z","git_url":"git://github.com/zyga/snapd.git","ssh_url":"git@github.com:zyga/snapd.git","clone_url":"https://github.com/zyga/snapd.git","svn_url":"https://github.com/zyga/snapd","homepage":null,"size":80924,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"7b794f237ccd86b97a99a0de5502c2bceb10e293","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","private":false,"owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2019-03-25T07:48:36Z","pushed_at":"2019-03-25T14:14:53Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":80084,"stargazers_count":1126,"watchers_count":1126,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":279,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":279,"open_issues":59,"watchers":1126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6614"},"html":{"href":"https://github.com/snapcore/snapd/pull/6614"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6614"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/6614/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6614/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/6614/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/079d8bbe987fb608c6845bf7a3bee922ea4b28f6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zyga","id":784262,"node_id":"MDQ6VXNlcjc4NDI2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/784262?v=4","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"maintainer_can_modify":false,"commits":3,"additions":80,"deletions":45,"changed_files":3}}
{"actor":{"display_login":"zyga"}}