{"action":"created","issue":{"url":"https://api.github.com/repos/tinymce/tinymce/issues/5098","repository_url":"https://api.github.com/repos/tinymce/tinymce","labels_url":"https://api.github.com/repos/tinymce/tinymce/issues/5098/labels{/name}","comments_url":"https://api.github.com/repos/tinymce/tinymce/issues/5098/comments","events_url":"https://api.github.com/repos/tinymce/tinymce/issues/5098/events","html_url":"https://github.com/tinymce/tinymce/issues/5098","id":473802288,"node_id":"MDU6SXNzdWU0NzM4MDIyODg=","number":5098,"title":"Inline editor: Issues when the root element is a button","user":{"login":"nikrolls","id":2626677,"node_id":"MDQ6VXNlcjI2MjY2Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2626677?v=4","gravatar_id":"","url":"https://api.github.com/users/nikrolls","html_url":"https://github.com/nikrolls","followers_url":"https://api.github.com/users/nikrolls/followers","following_url":"https://api.github.com/users/nikrolls/following{/other_user}","gists_url":"https://api.github.com/users/nikrolls/gists{/gist_id}","starred_url":"https://api.github.com/users/nikrolls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikrolls/subscriptions","organizations_url":"https://api.github.com/users/nikrolls/orgs","repos_url":"https://api.github.com/users/nikrolls/repos","events_url":"https://api.github.com/users/nikrolls/events{/privacy}","received_events_url":"https://api.github.com/users/nikrolls/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-29T00:17:38Z","updated_at":"2019-07-31T02:44:09Z","closed_at":null,"author_association":"NONE","body":"**What is the current behavior? Describe the bug**\r\nWhen tinymce inline is initialised on a button (the intent being to allow the button label to be edited) there are a few issues:\r\n\r\n1. The button's content is cleared when the editor is initialised\r\n1. Clicking on the editable area activates the button action\r\n1. Pressing spacebar while editing activates the button action and in some cases prevents the space from being inserted\r\n\r\nIssue 1 seems to be resolved on Chrome by making a child span the root element, but this does not resolve issues 2 and 3 and completely breaks editing on Firefox. See http://fiddle.tinymce.com/LNgaab\r\n\r\n**What is the expected behavior?**\r\n\r\n1. The button's content should not be cleared when the editor is initialised\r\n1. Clicking on the editable area should not activate the button action\r\n1. Pressing spacebar while editing should not activate the button action, and the space should be inserted\r\n\r\nWhile issues 2 and 3 could arguably be the responsibility of the implementing developer, issue 1 is definitely a TinyMCE bug. Fixes for issues 2 and 3 would be nice as well - if and when a button is editable I would never expect it to be actually used as a button.\r\n\r\n**Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?**\r\n\r\nTinyMCE 5 Cloud (stable)\r\nTested on latest versions of Chrome, Firefox, and Edge on Windows 10."},"comment":{"url":"https://api.github.com/repos/tinymce/tinymce/issues/comments/516671221","html_url":"https://github.com/tinymce/tinymce/issues/5098#issuecomment-516671221","issue_url":"https://api.github.com/repos/tinymce/tinymce/issues/5098","id":516671221,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNjY3MTIyMQ==","user":{"login":"nikrolls","id":2626677,"node_id":"MDQ6VXNlcjI2MjY2Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2626677?v=4","gravatar_id":"","url":"https://api.github.com/users/nikrolls","html_url":"https://github.com/nikrolls","followers_url":"https://api.github.com/users/nikrolls/followers","following_url":"https://api.github.com/users/nikrolls/following{/other_user}","gists_url":"https://api.github.com/users/nikrolls/gists{/gist_id}","starred_url":"https://api.github.com/users/nikrolls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikrolls/subscriptions","organizations_url":"https://api.github.com/users/nikrolls/orgs","repos_url":"https://api.github.com/users/nikrolls/repos","events_url":"https://api.github.com/users/nikrolls/events{/privacy}","received_events_url":"https://api.github.com/users/nikrolls/received_events","type":"User","site_admin":false},"created_at":"2019-07-31T02:44:09Z","updated_at":"2019-07-31T02:44:09Z","author_association":"NONE","body":"Thanks @IamFonky. That would potentially work, but then that value will be submitted with the form. Buttons are meant to have content, and I'd like to edit that content rather than the value."}}
{"actor":{"display_login":"nikrolls"}}