{"action":"created","issue":{"url":"https://api.github.com/repos/cefsharp/CefSharp/issues/2881","repository_url":"https://api.github.com/repos/cefsharp/CefSharp","labels_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/2881/labels{/name}","comments_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/2881/comments","events_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/2881/events","html_url":"https://github.com/cefsharp/CefSharp/pull/2881","id":487562263,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyODAxNDgw","number":2881,"title":"Core - Add IURLRequest #1721","user":{"login":"davidmi","id":585838,"node_id":"MDQ6VXNlcjU4NTgzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/585838?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmi","html_url":"https://github.com/davidmi","followers_url":"https://api.github.com/users/davidmi/followers","following_url":"https://api.github.com/users/davidmi/following{/other_user}","gists_url":"https://api.github.com/users/davidmi/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmi/subscriptions","organizations_url":"https://api.github.com/users/davidmi/orgs","repos_url":"https://api.github.com/users/davidmi/repos","events_url":"https://api.github.com/users/davidmi/events{/privacy}","received_events_url":"https://api.github.com/users/davidmi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-08-30T16:07:29Z","updated_at":"2019-09-05T09:59:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/2881","html_url":"https://github.com/cefsharp/CefSharp/pull/2881","diff_url":"https://github.com/cefsharp/CefSharp/pull/2881.diff","patch_url":"https://github.com/cefsharp/CefSharp/pull/2881.patch"},"body":"Add IURLRequest, IURLRequestClient, and GetURLRequest to IFrame\r\n\r\nFixes #1721 \r\n\r\n**Summary:** \r\n   I was interested in #1721 because I wanted to make a request using the offscreen browser and read the response body, so I added this functionality as proposed in #1721\r\n\r\n**Changes:** \r\n   -- Added wrappers for CefURLRequest and CefURLRequestClient\r\n   -- Added corresponding interfaces\r\n   -- Added LoadURLRequest to CefFrameWrapper and IFrame\r\n   -- Added and ran basic unit test for the new \r\n      \r\n**Feedback requests**\r\n   -- Is there somewhere better to put the test?\r\n   -- The test suite \"fails\" even though all the tests pass for me because Cef.Shutdown() ends up being called on a different thread, I'm not sure if there is already an issue for this.\r\n   -- Should I provide an implementation of IURLRequestClient? It is non-trivial to implement, I think, though I did put an example in the test.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cefsharp/CefSharp/issues/comments/528292462","html_url":"https://github.com/cefsharp/CefSharp/pull/2881#issuecomment-528292462","issue_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/2881","id":528292462,"node_id":"MDEyOklzc3VlQ29tbWVudDUyODI5MjQ2Mg==","user":{"login":"amaitland","id":307872,"node_id":"MDQ6VXNlcjMwNzg3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/307872?v=4","gravatar_id":"","url":"https://api.github.com/users/amaitland","html_url":"https://github.com/amaitland","followers_url":"https://api.github.com/users/amaitland/followers","following_url":"https://api.github.com/users/amaitland/following{/other_user}","gists_url":"https://api.github.com/users/amaitland/gists{/gist_id}","starred_url":"https://api.github.com/users/amaitland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaitland/subscriptions","organizations_url":"https://api.github.com/users/amaitland/orgs","repos_url":"https://api.github.com/users/amaitland/repos","events_url":"https://api.github.com/users/amaitland/events{/privacy}","received_events_url":"https://api.github.com/users/amaitland/received_events","type":"User","site_admin":false},"created_at":"2019-09-05T09:59:41Z","updated_at":"2019-09-05T09:59:41Z","author_association":"MEMBER","body":"> This is my first substantial pull request to any public project, please let me know if I've made any faux pas!\r\n\r\nExcellent first attempt 👍  It's tough getting started as every project has it's own style and every maintainer their own quirks 😄 "}}
{"actor":{"display_login":"amaitland"}}