{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/30484","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/30484/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/30484/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/30484/events","html_url":"https://github.com/Automattic/wp-calypso/pull/30484","id":404522772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4Njg2Mzg1","number":30484,"title":"Gutenberg: Add \"Repeat Visitor\" block","user":{"login":"jsnmoon","id":4044428,"node_id":"MDQ6VXNlcjQwNDQ0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"labels":[{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false},{"id":529422347,"node_id":"MDU6TGFiZWw1Mjk0MjIzNDc=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Copy%20Review","name":"[Status] Needs Copy Review","color":"c2e0c6","default":false},{"id":285010023,"node_id":"MDU6TGFiZWwyODUwMTAwMjM=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Design%20Review","name":"[Status] Needs Design Review","color":"13CDF7","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":967395211,"node_id":"MDU6TGFiZWw5NjczOTUyMTE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20New%20feature","name":"[Type] New feature","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"bluefuton","id":17325,"node_id":"MDQ6VXNlcjE3MzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false},"assignees":[{"login":"bluefuton","id":17325,"node_id":"MDQ6VXNlcjE3MzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false},{"login":"jsnmoon","id":4044428,"node_id":"MDQ6VXNlcjQwNDQ0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2019-01-29T22:51:52Z","updated_at":"2019-02-14T01:58:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/30484","html_url":"https://github.com/Automattic/wp-calypso/pull/30484","diff_url":"https://github.com/Automattic/wp-calypso/pull/30484.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/30484.patch"},"body":"#### Changes proposed in this Pull Request\r\n\r\nThe `Repeat Visitor` block enables the user to control the visibility of its nested block(s) depending on how many times a user has visited the website. This is @Automattic/opportunity's first Gutenberg block, so any feedback would be much appreciated.\r\n\r\n<img width=\"984\" alt=\"screen-shot-2019-01-25-at-4 25 32-pm\" src=\"https://user-images.githubusercontent.com/4044428/51945237-5b6a1680-23db-11e9-9803-c983113a87ed.png\">\r\n\r\n<strong>For copy and design reviewers</strong>: Please let us know how we could refine the presentation of this block to our users. ~(I personally don't think `Visited` should be the final name for this block, among other things.)~\r\n\r\nYou might like to reference this internal master thread: p9xfpQ-iN.\r\n\r\n#### Testing instructions\r\n\r\n1. Spin up a [Jurassic Ninja instance](https://jurassic.ninja/create/?gutenpack&calypsobranch=try/visited-block&branch=try/visited-block).\r\n\r\n2. Connect Jetpack to your WPCOM account.\r\n\r\n3. Navigate to Settings->Jetpack Constants, check JETPACK_BETA_BLOCKS, and Save.\r\n\r\n4. Add the Visited block to a post or page. Nest whatever block within the Visited block.\r\n\r\n5. Save a post and open it. \r\n\r\n6. Check the cookie value for `jp-visit-counter`; it should have incremented from `0` to `1`. \r\n\r\n7. Refresh the page multiple times and ensure that the `jp-visit-counter` continues to increment. Ensure that your content becomes visible after it crosses the minimum view threshold (and vice versa for maximum view threshold)."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/463454232","html_url":"https://github.com/Automattic/wp-calypso/pull/30484#issuecomment-463454232","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/30484","id":463454232,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MzQ1NDIzMg==","user":{"login":"bluefuton","id":17325,"node_id":"MDQ6VXNlcjE3MzI1","avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false},"created_at":"2019-02-14T01:58:32Z","updated_at":"2019-02-14T01:58:32Z","author_association":"CONTRIBUTOR","body":"> I think we should only show the notice when the block is active, so that the rest of the time it mimic the preview.\r\n\r\n@scruffian we've given this a try, and we find it works reasonably well if the notice is at the bottom of the block rather than the top (so it doesn't push down the existing content when the block gets focus).\r\n\r\nHowever, it still feels a bit odd when the notice disappears if you haven't specified any child blocks yet. To me, it looks like a blank paragraph rather than a block I've already chosen.\r\n\r\nWhen selected:\r\n![Uploading Screen Shot 2019-02-14 at 14.54.57.png…]()\r\n\r\nWhen not selected (no child blocks):\r\n\r\n<img width=\"675\" alt=\"screen shot 2019-02-14 at 14 55 11\" src=\"https://user-images.githubusercontent.com/17325/52757158-a8e7b400-3068-11e9-9c59-fb72f9b4590e.png\">\r\n\r\nOne idea we had was to continue displaying the notice if no child blocks had been added, but we're not entirely sure how to achieve that.\r\n\r\nHave a play and let us know what you think :)"}}
{"actor":{"display_login":"bluefuton"}}