{"action":"created","issue":{"url":"https://api.github.com/repos/paritytech/parity-signer/issues/337","repository_url":"https://api.github.com/repos/paritytech/parity-signer","labels_url":"https://api.github.com/repos/paritytech/parity-signer/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/paritytech/parity-signer/issues/337/comments","events_url":"https://api.github.com/repos/paritytech/parity-signer/issues/337/events","html_url":"https://github.com/paritytech/parity-signer/pull/337","id":485922837,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExNDc2MjE1","number":337,"title":"fix: add Linter and fix caught errors","user":{"login":"hanwencheng","id":6014309,"node_id":"MDQ6VXNlcjYwMTQzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6014309?v=4","gravatar_id":"","url":"https://api.github.com/users/hanwencheng","html_url":"https://github.com/hanwencheng","followers_url":"https://api.github.com/users/hanwencheng/followers","following_url":"https://api.github.com/users/hanwencheng/following{/other_user}","gists_url":"https://api.github.com/users/hanwencheng/gists{/gist_id}","starred_url":"https://api.github.com/users/hanwencheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanwencheng/subscriptions","organizations_url":"https://api.github.com/users/hanwencheng/orgs","repos_url":"https://api.github.com/users/hanwencheng/repos","events_url":"https://api.github.com/users/hanwencheng/events{/privacy}","received_events_url":"https://api.github.com/users/hanwencheng/received_events","type":"User","site_admin":false},"labels":[{"id":954989547,"node_id":"MDU6TGFiZWw5NTQ5ODk1NDc=","url":"https://api.github.com/repos/paritytech/parity-signer/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/paritytech/parity-signer/milestones/4","html_url":"https://github.com/paritytech/parity-signer/milestone/4","labels_url":"https://api.github.com/repos/paritytech/parity-signer/milestones/4/labels","id":3728058,"node_id":"MDk6TWlsZXN0b25lMzcyODA1OA==","number":4,"title":"v3.1 Secure enclave","description":"","creator":{"login":"Tbaut","id":33178835,"node_id":"MDQ6VXNlcjMzMTc4ODM1","avatar_url":"https://avatars2.githubusercontent.com/u/33178835?v=4","gravatar_id":"","url":"https://api.github.com/users/Tbaut","html_url":"https://github.com/Tbaut","followers_url":"https://api.github.com/users/Tbaut/followers","following_url":"https://api.github.com/users/Tbaut/following{/other_user}","gists_url":"https://api.github.com/users/Tbaut/gists{/gist_id}","starred_url":"https://api.github.com/users/Tbaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tbaut/subscriptions","organizations_url":"https://api.github.com/users/Tbaut/orgs","repos_url":"https://api.github.com/users/Tbaut/repos","events_url":"https://api.github.com/users/Tbaut/events{/privacy}","received_events_url":"https://api.github.com/users/Tbaut/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":30,"state":"open","created_at":"2018-10-10T16:02:49Z","updated_at":"2019-10-10T15:22:14Z","due_on":null,"closed_at":null},"comments":20,"created_at":"2019-08-27T16:53:02Z","updated_at":"2019-10-14T11:54:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/paritytech/parity-signer/pulls/337","html_url":"https://github.com/paritytech/parity-signer/pull/337","diff_url":"https://github.com/paritytech/parity-signer/pull/337.diff","patch_url":"https://github.com/paritytech/parity-signer/pull/337.patch"},"body":"close #335 \r\n\r\n`yarn` is needed before test the code. I have pointed out some critical code modification part in the comments.\r\n\r\nThough the diff on Github may show the tabs in 8 spaces, the file view should be correct.\r\n\r\nIt includes following fixes:\r\n* Init the linter configuration and add the linter into our CI.\r\n* add [husky](https://github.com/typicode/husky) to configure pre-commit with lint.\r\n* fix caught errors by Eslint.\r\n* Fix the indentation from space to tab in project-scope."},"comment":{"url":"https://api.github.com/repos/paritytech/parity-signer/issues/comments/541632638","html_url":"https://github.com/paritytech/parity-signer/pull/337#issuecomment-541632638","issue_url":"https://api.github.com/repos/paritytech/parity-signer/issues/337","id":541632638,"node_id":"MDEyOklzc3VlQ29tbWVudDU0MTYzMjYzOA==","user":{"login":"yjkimjunior","id":10432070,"node_id":"MDQ6VXNlcjEwNDMyMDcw","avatar_url":"https://avatars1.githubusercontent.com/u/10432070?v=4","gravatar_id":"","url":"https://api.github.com/users/yjkimjunior","html_url":"https://github.com/yjkimjunior","followers_url":"https://api.github.com/users/yjkimjunior/followers","following_url":"https://api.github.com/users/yjkimjunior/following{/other_user}","gists_url":"https://api.github.com/users/yjkimjunior/gists{/gist_id}","starred_url":"https://api.github.com/users/yjkimjunior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjkimjunior/subscriptions","organizations_url":"https://api.github.com/users/yjkimjunior/orgs","repos_url":"https://api.github.com/users/yjkimjunior/repos","events_url":"https://api.github.com/users/yjkimjunior/events{/privacy}","received_events_url":"https://api.github.com/users/yjkimjunior/received_events","type":"User","site_admin":false},"created_at":"2019-10-14T11:54:24Z","updated_at":"2019-10-14T11:54:24Z","author_association":"MEMBER","body":"we should either escalate those `warning`'s to `error`'s so the CI marks them as build failing, or modify the `travis.yml` to do that. "}}
{"actor":{"display_login":"yjkimjunior"}}