{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/351203869","pull_request_review_id":323565135,"id":351203869,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTIwMzg2OQ==","diff_hunk":"@@ -182,27 +182,39 @@ func (c *controller) createInformer(\n \thandler := &kube.ChainHandler{}\n \thandler.Append(c.notify)\n \n+\t// Wrap the list function with supplied validation function, so that invalid CRD does not enter store.\n+\tvlf := func(opts meta_v1.ListOptions) (result runtime.Object, err error) {","path":"pilot/pkg/config/kube/crd/controller/controller.go","position":null,"original_position":5,"commit_id":"28020879f455362b89f06d412ee07872017d0576","original_commit_id":"d28bb900a563782a0a65cadce7bcd97701ee9b76","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"body":"Implemented it with gaurd. PTAL","created_at":"2019-11-27T10:21:06Z","updated_at":"2019-11-27T10:21:06Z","html_url":"https://github.com/istio/istio/pull/19172#discussion_r351203869","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/19172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/351203869"},"html":{"href":"https://github.com/istio/istio/pull/19172#discussion_r351203869"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/19172"}},"in_reply_to_id":350059136},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/19172","id":344874771,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0ODc0Nzcx","html_url":"https://github.com/istio/istio/pull/19172","diff_url":"https://github.com/istio/istio/pull/19172.diff","patch_url":"https://github.com/istio/istio/pull/19172.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/19172","number":19172,"state":"open","locked":false,"title":"crd: add validation in list function of controller","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"body":"Pilot specially (PushContext) uses `List` to get the list of Istio objects. However, `List` does not validate the object - if Object is invalid, Pilot panics during processing. This PR adds validation to `List`.\r\n\r\n[ ] Configuration Infrastructure\r\n[ ] Docs\r\n[ ] Installation\r\n[ X] Networking\r\n[ ] Performance and Scalability\r\n[ ] Policies and Telemetry\r\n[ ] Security\r\n[ ] Test and Release\r\n[ ] User Experience\r\n[ ] Developer Infrastructure\r\n","created_at":"2019-11-24T05:25:14Z","updated_at":"2019-11-27T10:21:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2958b873ad4f76f2c035c0afa99bdaa7abf6b64f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"howardjohn","id":623453,"node_id":"MDQ6VXNlcjYyMzQ1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/623453?v=4","gravatar_id":"","url":"https://api.github.com/users/howardjohn","html_url":"https://github.com/howardjohn","followers_url":"https://api.github.com/users/howardjohn/followers","following_url":"https://api.github.com/users/howardjohn/following{/other_user}","gists_url":"https://api.github.com/users/howardjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/howardjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardjohn/subscriptions","organizations_url":"https://api.github.com/users/howardjohn/orgs","repos_url":"https://api.github.com/users/howardjohn/repos","events_url":"https://api.github.com/users/howardjohn/events{/privacy}","received_events_url":"https://api.github.com/users/howardjohn/received_events","type":"User","site_admin":false},{"login":"linsun","id":1588319,"node_id":"MDQ6VXNlcjE1ODgzMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1588319?v=4","gravatar_id":"","url":"https://api.github.com/users/linsun","html_url":"https://github.com/linsun","followers_url":"https://api.github.com/users/linsun/followers","following_url":"https://api.github.com/users/linsun/following{/other_user}","gists_url":"https://api.github.com/users/linsun/gists{/gist_id}","starred_url":"https://api.github.com/users/linsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linsun/subscriptions","organizations_url":"https://api.github.com/users/linsun/orgs","repos_url":"https://api.github.com/users/linsun/repos","events_url":"https://api.github.com/users/linsun/events{/privacy}","received_events_url":"https://api.github.com/users/linsun/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"WG - Networking Maintainers","id":3341648,"node_id":"MDQ6VGVhbTMzNDE2NDg=","slug":"wg-networking-maintainers","description":"Maintainers for the Networking working group","privacy":"closed","url":"https://api.github.com/teams/3341648","html_url":"https://github.com/orgs/istio/teams/wg-networking-maintainers","members_url":"https://api.github.com/teams/3341648/members{/member}","repositories_url":"https://api.github.com/teams/3341648/repos","permission":"pull"}],"labels":[{"id":1475126481,"node_id":"MDU6TGFiZWwxNDc1MTI2NDgx","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false,"description":"Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA."},{"id":1448953239,"node_id":"MDU6TGFiZWwxNDQ4OTUzMjM5","url":"https://api.github.com/repos/istio/istio/labels/size/L","name":"size/L","color":"77bb00","default":false,"description":"Denotes a PR that changes 100-499 lines, ignoring generated files."}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/19172/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/19172/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/19172/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/28020879f455362b89f06d412ee07872017d0576","head":{"label":"ramaraochavali:fix/vs_validation","ref":"fix/vs_validation","sha":"28020879f455362b89f06d412ee07872017d0576","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"repo":{"id":139224975,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyMjQ5NzU=","name":"istio","full_name":"ramaraochavali/istio","private":false,"owner":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ramaraochavali/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/ramaraochavali/istio","forks_url":"https://api.github.com/repos/ramaraochavali/istio/forks","keys_url":"https://api.github.com/repos/ramaraochavali/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramaraochavali/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramaraochavali/istio/teams","hooks_url":"https://api.github.com/repos/ramaraochavali/istio/hooks","issue_events_url":"https://api.github.com/repos/ramaraochavali/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ramaraochavali/istio/events","assignees_url":"https://api.github.com/repos/ramaraochavali/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ramaraochavali/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ramaraochavali/istio/tags","blobs_url":"https://api.github.com/repos/ramaraochavali/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramaraochavali/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramaraochavali/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramaraochavali/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramaraochavali/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ramaraochavali/istio/languages","stargazers_url":"https://api.github.com/repos/ramaraochavali/istio/stargazers","contributors_url":"https://api.github.com/repos/ramaraochavali/istio/contributors","subscribers_url":"https://api.github.com/repos/ramaraochavali/istio/subscribers","subscription_url":"https://api.github.com/repos/ramaraochavali/istio/subscription","commits_url":"https://api.github.com/repos/ramaraochavali/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramaraochavali/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramaraochavali/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramaraochavali/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramaraochavali/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ramaraochavali/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramaraochavali/istio/merges","archive_url":"https://api.github.com/repos/ramaraochavali/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramaraochavali/istio/downloads","issues_url":"https://api.github.com/repos/ramaraochavali/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ramaraochavali/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ramaraochavali/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ramaraochavali/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramaraochavali/istio/labels{/name}","releases_url":"https://api.github.com/repos/ramaraochavali/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ramaraochavali/istio/deployments","created_at":"2018-06-30T06:25:17Z","updated_at":"2019-11-26T04:46:04Z","pushed_at":"2019-11-26T10:36:08Z","git_url":"git://github.com/ramaraochavali/istio.git","ssh_url":"git@github.com:ramaraochavali/istio.git","clone_url":"https://github.com/ramaraochavali/istio.git","svn_url":"https://github.com/ramaraochavali/istio","homepage":"https://istio.io","size":103858,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"4948416d0fb2a8dfefd25dde24adca067da21280","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2019-11-27T10:17:25Z","pushed_at":"2019-11-27T05:44:19Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":106716,"stargazers_count":20625,"watchers_count":20625,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3679,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":984,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3679,"open_issues":984,"watchers":20625,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/19172"},"html":{"href":"https://github.com/istio/istio/pull/19172"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/19172"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/19172/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/19172/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/19172/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/28020879f455362b89f06d412ee07872017d0576"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ramaraochavali"}}