{"action":"created","comment":{"url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments/354189671","pull_request_review_id":327397908,"id":354189671,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDE4OTY3MQ==","diff_hunk":"@@ -387,13 +388,15 @@ mciModule.factory('PerfDiscoveryDataService', function (\n \n   // Makes series of HTTP calls and loads curent, baseline and history data\n   // :rtype: $q.promise\n-  function queryData(tasksPromise, baselineTasks) {\n+  function queryData(tasksPromise, baselineTasks, expandedCurrent, expandedBaseline, expandedTrend) {\n     return $q.all({\n       tasks: tasksPromise,\n       baselineTasks: baselineTasks\n     }).then(function (promise) {\n       return $q.all(_.map(promise.tasks, function (task) {\n-        return ApiTaskdata.getTaskById(task.taskId, 'perf')\n+        let currentTaskPromise = expandedCurrent ? ApiTaskdata.getExpandedTaskById(task.taskId, 'perf') : ApiTaskdata.getTaskById(task.taskId, 'perf');","path":"public/static/app/perfdiscovery/PerfDiscoveryDataService.js","position":325,"original_position":38,"commit_id":"5fd61ddeca3ef126e1203f60f442ef5d9e3faf6f","original_commit_id":"5fd61ddeca3ef126e1203f60f442ef5d9e3faf6f","user":{"login":"jimoleary","id":22506,"node_id":"MDQ6VXNlcjIyNTA2","avatar_url":"https://avatars2.githubusercontent.com/u/22506?v=4","gravatar_id":"","url":"https://api.github.com/users/jimoleary","html_url":"https://github.com/jimoleary","followers_url":"https://api.github.com/users/jimoleary/followers","following_url":"https://api.github.com/users/jimoleary/following{/other_user}","gists_url":"https://api.github.com/users/jimoleary/gists{/gist_id}","starred_url":"https://api.github.com/users/jimoleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimoleary/subscriptions","organizations_url":"https://api.github.com/users/jimoleary/orgs","repos_url":"https://api.github.com/users/jimoleary/repos","events_url":"https://api.github.com/users/jimoleary/events{/privacy}","received_events_url":"https://api.github.com/users/jimoleary/received_events","type":"User","site_admin":false},"body":"[nit] cont rather than let? ","created_at":"2019-12-05T09:25:31Z","updated_at":"2019-12-05T09:39:52Z","html_url":"https://github.com/evergreen-ci/evergreen/pull/2934#discussion_r354189671","pull_request_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments/354189671"},"html":{"href":"https://github.com/evergreen-ci/evergreen/pull/2934#discussion_r354189671"},"pull_request":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934"}}},"pull_request":{"url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934","id":348986132,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4OTg2MTMy","html_url":"https://github.com/evergreen-ci/evergreen/pull/2934","diff_url":"https://github.com/evergreen-ci/evergreen/pull/2934.diff","patch_url":"https://github.com/evergreen-ci/evergreen/pull/2934.patch","issue_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/2934","number":2934,"state":"open","locked":false,"title":"EVG-6549 allow toggling expanded metrics in perf discovery","user":{"login":"john-m-liu","id":29384396,"node_id":"MDQ6VXNlcjI5Mzg0Mzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29384396?v=4","gravatar_id":"","url":"https://api.github.com/users/john-m-liu","html_url":"https://github.com/john-m-liu","followers_url":"https://api.github.com/users/john-m-liu/followers","following_url":"https://api.github.com/users/john-m-liu/following{/other_user}","gists_url":"https://api.github.com/users/john-m-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/john-m-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-m-liu/subscriptions","organizations_url":"https://api.github.com/users/john-m-liu/orgs","repos_url":"https://api.github.com/users/john-m-liu/repos","events_url":"https://api.github.com/users/john-m-liu/events{/privacy}","received_events_url":"https://api.github.com/users/john-m-liu/received_events","type":"User","site_admin":false},"body":"- Run a formatter on the files I touched (don't review the first commit)\r\n- Add wrapper methods to retrieve task and trend data from cedar and convert afterwards (same as those used in trend charts)\r\n- Conditionally use those to retrieve data, based on user selecting what they want to be the data source for the current/baseline/trend data\r\n<img width=\"1668\" alt=\"Screen Shot 2019-12-04 at 11 41 23 AM\" src=\"https://user-images.githubusercontent.com/29384396/70162038-0b0eb580-168b-11ea-81f1-2edd37946f92.png\">\r\n","created_at":"2019-12-04T16:41:45Z","updated_at":"2019-12-05T09:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b978e72712c18119d545acd4ad8b30d507b257e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934/commits","review_comments_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934/comments","review_comment_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/2934/comments","statuses_url":"https://api.github.com/repos/evergreen-ci/evergreen/statuses/5fd61ddeca3ef126e1203f60f442ef5d9e3faf6f","head":{"label":"john-m-liu:EVG-6549","ref":"EVG-6549","sha":"5fd61ddeca3ef126e1203f60f442ef5d9e3faf6f","user":{"login":"john-m-liu","id":29384396,"node_id":"MDQ6VXNlcjI5Mzg0Mzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29384396?v=4","gravatar_id":"","url":"https://api.github.com/users/john-m-liu","html_url":"https://github.com/john-m-liu","followers_url":"https://api.github.com/users/john-m-liu/followers","following_url":"https://api.github.com/users/john-m-liu/following{/other_user}","gists_url":"https://api.github.com/users/john-m-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/john-m-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-m-liu/subscriptions","organizations_url":"https://api.github.com/users/john-m-liu/orgs","repos_url":"https://api.github.com/users/john-m-liu/repos","events_url":"https://api.github.com/users/john-m-liu/events{/privacy}","received_events_url":"https://api.github.com/users/john-m-liu/received_events","type":"User","site_admin":false},"repo":{"id":100648346,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2NDgzNDY=","name":"evergreen","full_name":"john-m-liu/evergreen","private":false,"owner":{"login":"john-m-liu","id":29384396,"node_id":"MDQ6VXNlcjI5Mzg0Mzk2","avatar_url":"https://avatars2.githubusercontent.com/u/29384396?v=4","gravatar_id":"","url":"https://api.github.com/users/john-m-liu","html_url":"https://github.com/john-m-liu","followers_url":"https://api.github.com/users/john-m-liu/followers","following_url":"https://api.github.com/users/john-m-liu/following{/other_user}","gists_url":"https://api.github.com/users/john-m-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/john-m-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-m-liu/subscriptions","organizations_url":"https://api.github.com/users/john-m-liu/orgs","repos_url":"https://api.github.com/users/john-m-liu/repos","events_url":"https://api.github.com/users/john-m-liu/events{/privacy}","received_events_url":"https://api.github.com/users/john-m-liu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/john-m-liu/evergreen","description":"A Distributed Continuous Integration System from MongoDB","fork":true,"url":"https://api.github.com/repos/john-m-liu/evergreen","forks_url":"https://api.github.com/repos/john-m-liu/evergreen/forks","keys_url":"https://api.github.com/repos/john-m-liu/evergreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/john-m-liu/evergreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/john-m-liu/evergreen/teams","hooks_url":"https://api.github.com/repos/john-m-liu/evergreen/hooks","issue_events_url":"https://api.github.com/repos/john-m-liu/evergreen/issues/events{/number}","events_url":"https://api.github.com/repos/john-m-liu/evergreen/events","assignees_url":"https://api.github.com/repos/john-m-liu/evergreen/assignees{/user}","branches_url":"https://api.github.com/repos/john-m-liu/evergreen/branches{/branch}","tags_url":"https://api.github.com/repos/john-m-liu/evergreen/tags","blobs_url":"https://api.github.com/repos/john-m-liu/evergreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/john-m-liu/evergreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/john-m-liu/evergreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/john-m-liu/evergreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/john-m-liu/evergreen/statuses/{sha}","languages_url":"https://api.github.com/repos/john-m-liu/evergreen/languages","stargazers_url":"https://api.github.com/repos/john-m-liu/evergreen/stargazers","contributors_url":"https://api.github.com/repos/john-m-liu/evergreen/contributors","subscribers_url":"https://api.github.com/repos/john-m-liu/evergreen/subscribers","subscription_url":"https://api.github.com/repos/john-m-liu/evergreen/subscription","commits_url":"https://api.github.com/repos/john-m-liu/evergreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/john-m-liu/evergreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/john-m-liu/evergreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/john-m-liu/evergreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/john-m-liu/evergreen/contents/{+path}","compare_url":"https://api.github.com/repos/john-m-liu/evergreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/john-m-liu/evergreen/merges","archive_url":"https://api.github.com/repos/john-m-liu/evergreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/john-m-liu/evergreen/downloads","issues_url":"https://api.github.com/repos/john-m-liu/evergreen/issues{/number}","pulls_url":"https://api.github.com/repos/john-m-liu/evergreen/pulls{/number}","milestones_url":"https://api.github.com/repos/john-m-liu/evergreen/milestones{/number}","notifications_url":"https://api.github.com/repos/john-m-liu/evergreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/john-m-liu/evergreen/labels{/name}","releases_url":"https://api.github.com/repos/john-m-liu/evergreen/releases{/id}","deployments_url":"https://api.github.com/repos/john-m-liu/evergreen/deployments","created_at":"2017-08-17T21:56:25Z","updated_at":"2019-05-16T18:24:04Z","pushed_at":"2019-12-04T21:44:53Z","git_url":"git://github.com/john-m-liu/evergreen.git","ssh_url":"git@github.com:john-m-liu/evergreen.git","clone_url":"https://github.com/john-m-liu/evergreen.git","svn_url":"https://github.com/john-m-liu/evergreen","homepage":"http://evergreen.mongodb.com","size":91784,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"evergreen-ci:master","ref":"master","sha":"d463c2307d23520551363f6a3c5a5fa9b7032e5c","user":{"login":"evergreen-ci","id":10089490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDg5NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/10089490?v=4","gravatar_id":"","url":"https://api.github.com/users/evergreen-ci","html_url":"https://github.com/evergreen-ci","followers_url":"https://api.github.com/users/evergreen-ci/followers","following_url":"https://api.github.com/users/evergreen-ci/following{/other_user}","gists_url":"https://api.github.com/users/evergreen-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/evergreen-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evergreen-ci/subscriptions","organizations_url":"https://api.github.com/users/evergreen-ci/orgs","repos_url":"https://api.github.com/users/evergreen-ci/repos","events_url":"https://api.github.com/users/evergreen-ci/events{/privacy}","received_events_url":"https://api.github.com/users/evergreen-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":36385798,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4NTc5OA==","name":"evergreen","full_name":"evergreen-ci/evergreen","private":false,"owner":{"login":"evergreen-ci","id":10089490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDg5NDkw","avatar_url":"https://avatars3.githubusercontent.com/u/10089490?v=4","gravatar_id":"","url":"https://api.github.com/users/evergreen-ci","html_url":"https://github.com/evergreen-ci","followers_url":"https://api.github.com/users/evergreen-ci/followers","following_url":"https://api.github.com/users/evergreen-ci/following{/other_user}","gists_url":"https://api.github.com/users/evergreen-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/evergreen-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evergreen-ci/subscriptions","organizations_url":"https://api.github.com/users/evergreen-ci/orgs","repos_url":"https://api.github.com/users/evergreen-ci/repos","events_url":"https://api.github.com/users/evergreen-ci/events{/privacy}","received_events_url":"https://api.github.com/users/evergreen-ci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/evergreen-ci/evergreen","description":"A Distributed Continuous Integration System from MongoDB","fork":false,"url":"https://api.github.com/repos/evergreen-ci/evergreen","forks_url":"https://api.github.com/repos/evergreen-ci/evergreen/forks","keys_url":"https://api.github.com/repos/evergreen-ci/evergreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evergreen-ci/evergreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evergreen-ci/evergreen/teams","hooks_url":"https://api.github.com/repos/evergreen-ci/evergreen/hooks","issue_events_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/events{/number}","events_url":"https://api.github.com/repos/evergreen-ci/evergreen/events","assignees_url":"https://api.github.com/repos/evergreen-ci/evergreen/assignees{/user}","branches_url":"https://api.github.com/repos/evergreen-ci/evergreen/branches{/branch}","tags_url":"https://api.github.com/repos/evergreen-ci/evergreen/tags","blobs_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evergreen-ci/evergreen/statuses/{sha}","languages_url":"https://api.github.com/repos/evergreen-ci/evergreen/languages","stargazers_url":"https://api.github.com/repos/evergreen-ci/evergreen/stargazers","contributors_url":"https://api.github.com/repos/evergreen-ci/evergreen/contributors","subscribers_url":"https://api.github.com/repos/evergreen-ci/evergreen/subscribers","subscription_url":"https://api.github.com/repos/evergreen-ci/evergreen/subscription","commits_url":"https://api.github.com/repos/evergreen-ci/evergreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/evergreen-ci/evergreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/evergreen-ci/evergreen/contents/{+path}","compare_url":"https://api.github.com/repos/evergreen-ci/evergreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evergreen-ci/evergreen/merges","archive_url":"https://api.github.com/repos/evergreen-ci/evergreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evergreen-ci/evergreen/downloads","issues_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues{/number}","pulls_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls{/number}","milestones_url":"https://api.github.com/repos/evergreen-ci/evergreen/milestones{/number}","notifications_url":"https://api.github.com/repos/evergreen-ci/evergreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evergreen-ci/evergreen/labels{/name}","releases_url":"https://api.github.com/repos/evergreen-ci/evergreen/releases{/id}","deployments_url":"https://api.github.com/repos/evergreen-ci/evergreen/deployments","created_at":"2015-05-27T18:03:09Z","updated_at":"2019-12-04T21:03:22Z","pushed_at":"2019-12-04T22:49:05Z","git_url":"git://github.com/evergreen-ci/evergreen.git","ssh_url":"git@github.com:evergreen-ci/evergreen.git","clone_url":"https://github.com/evergreen-ci/evergreen.git","svn_url":"https://github.com/evergreen-ci/evergreen","homepage":"https://evergreen.mongodb.com/","size":91770,"stargazers_count":219,"watchers_count":219,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":74,"open_issues":9,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934"},"html":{"href":"https://github.com/evergreen-ci/evergreen/pull/2934"},"issue":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/issues/2934"},"comments":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/issues/2934/comments"},"review_comments":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934/comments"},"review_comment":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/2934/commits"},"statuses":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/statuses/5fd61ddeca3ef126e1203f60f442ef5d9e3faf6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jimoleary"}}