{"action":"created","issue":{"url":"https://api.github.com/repos/jecisc/Bazard/issues/125","repository_url":"https://api.github.com/repos/jecisc/Bazard","labels_url":"https://api.github.com/repos/jecisc/Bazard/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/jecisc/Bazard/issues/125/comments","events_url":"https://api.github.com/repos/jecisc/Bazard/issues/125/events","html_url":"https://github.com/jecisc/Bazard/issues/125","id":411508868,"node_id":"MDU6SXNzdWU0MTE1MDg4Njg=","number":125,"title":"SUnit does not manage well abstract test classes.","user":{"login":"jecisc","id":9519971,"node_id":"MDQ6VXNlcjk1MTk5NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/9519971?v=4","gravatar_id":"","url":"https://api.github.com/users/jecisc","html_url":"https://github.com/jecisc","followers_url":"https://api.github.com/users/jecisc/followers","following_url":"https://api.github.com/users/jecisc/following{/other_user}","gists_url":"https://api.github.com/users/jecisc/gists{/gist_id}","starred_url":"https://api.github.com/users/jecisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jecisc/subscriptions","organizations_url":"https://api.github.com/users/jecisc/orgs","repos_url":"https://api.github.com/users/jecisc/repos","events_url":"https://api.github.com/users/jecisc/events{/privacy}","received_events_url":"https://api.github.com/users/jecisc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-02-18T14:44:15Z","updated_at":"2019-02-18T14:44:18Z","closed_at":null,"author_association":"OWNER","body":"Migrated case from Manuscript.\r\t\rOriginal case: https://pharo.fogbugz.com/f/cases/20118\rStatus: Work Needed\rProject: SUnit\rOriginal Author: CyrilFerlicot\rDate: 3 June 2017 9:07:52 pm\r\t\rDescription:\r\t\r\nSometimes when you have an abstract test class and you override it the tests will be inherit or not. \n\nIf a subclass has other tests, the tests will not be inherited. If the subclass has no other tests, the tests will be inherited. \n\nHere is a little script showing the problem:\n\n\nTestCase subclass: #A\n\tslots: {  }\n\tclassVariables: {  }\n\tcategory: 'TestProblem'.\n\t\n#A asClass subclass: #B\n\tslots: {  }\n\tclassVariables: {  }\n\tcategory: 'TestProblem'.\n\t\n#B asClass subclass: #C\n\tslots: {  }\n\tclassVariables: {  }\n\tcategory: 'TestProblem'.\n\t\n#A asClass class compile: 'isAbstract\n\t^ self = A'.\n\t\n#A asClass compile: 'actualClass\n\t^ self subclassResponsibility'.\n\t\n#A asClass compile: 'testTest\n\tself actualClass new'.\n\t\n#C asClass buildSuiteFromAllSelectors run.\n \"1 run, 0 passes, 0 skipped, 0 expected failures, 0 failures, 1 errors, 0 unexpected passes\"\n\n#C asClass compile: 'testAnotherTest\n\tself assert: true'.\n\t\n#C asClass buildSuiteFromAllSelectors run.\n  \"1 run, 1 passes, 0 skipped, 0 expected failures, 0 failures, 0 errors, 0 unexpected passes\"\n\n\nIn the last line I would expect 2 run cases. 1 pass and 1 error. "},"comment":{"url":"https://api.github.com/repos/jecisc/Bazard/issues/comments/464756644","html_url":"https://github.com/jecisc/Bazard/issues/125#issuecomment-464756644","issue_url":"https://api.github.com/repos/jecisc/Bazard/issues/125","id":464756644,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2NDc1NjY0NA==","user":{"login":"jecisc","id":9519971,"node_id":"MDQ6VXNlcjk1MTk5NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/9519971?v=4","gravatar_id":"","url":"https://api.github.com/users/jecisc","html_url":"https://github.com/jecisc","followers_url":"https://api.github.com/users/jecisc/followers","following_url":"https://api.github.com/users/jecisc/following{/other_user}","gists_url":"https://api.github.com/users/jecisc/gists{/gist_id}","starred_url":"https://api.github.com/users/jecisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jecisc/subscriptions","organizations_url":"https://api.github.com/users/jecisc/orgs","repos_url":"https://api.github.com/users/jecisc/repos","events_url":"https://api.github.com/users/jecisc/events{/privacy}","received_events_url":"https://api.github.com/users/jecisc/received_events","type":"User","site_admin":false},"created_at":"2019-02-18T14:44:18Z","updated_at":"2019-02-18T14:44:18Z","author_association":"OWNER","body":"Reply:\rAuthor: Andrew P Black\rDate: 27 October 2017 9:09:46 am\r\t\rMessage:\r\t\rThe current behaviour, as I understand it, is that if the test subclass has a class-side method #shouldInheritSelectors that answers true, then the inherited tests will be considered to be part of the test suite defined by that test subclass.  If it answers false, the inherited tests will not be included in the test suite.\n\nThis seems like reasonable behavior — although I'm not sure if it is documented anywhere!  What change are you proposing, exactly?  To remove the somewhat convoluted inherited implementation of #shouldInheritSelectors from TestCase, and replace by ... what exactly?"}}
{"actor":{"display_login":"jecisc"}}