{"action":"created","comment":{"url":"https://api.github.com/repos/istio/operator/pulls/comments/339073432","pull_request_review_id":307225493,"id":339073432,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTA3MzQzMg==","diff_hunk":"@@ -17,83 +17,57 @@\n set -eux\n \n export ARTIFACTS=\"${ARTIFACTS:-$(mktemp -d)}\"\n+ROOT=$(cd ../../../; pwd)\n \n-function cleanup_kind_cluster() {\n-    kind export logs --name istio-testing \"${ARTIFACTS}/kind\"\n-    kind delete cluster --name=istio-testing\n-}\n-\n-function setup_kind_cluster() {\n-  # Delete any previous e2e KinD cluster\n-  echo \"Deleting previous KinD cluster with name=istio-testing\"\n-  if ! (kind delete cluster --name=istio-testing) > /dev/null; then\n-    echo \"No existing kind cluster with name istio-testing. Continue...\"\n-  fi\n-\n-  trap cleanup_kind_cluster EXIT\n-\n-  # Create KinD cluster\n-  if ! (kind create cluster --name=istio-testing --loglevel debug --retain --wait 30s); then\n-    echo \"Could not setup KinD environment. Something wrong with KinD setup. Exporting logs.\"\n-    exit 1\n-  fi\n-\n-  KUBECONFIG=\"$(kind get kubeconfig-path --name=\"istio-testing\")\"\n-  export KUBECONFIG\n-\n-cat <<EOF > metallb-config.yaml\n-apiVersion: v1\n-kind: ConfigMap\n-metadata:\n-  namespace: metallb-system\n-  name: config\n-data:\n-  config: |\n-    address-pools:\n-    - name: default\n-      protocol: layer2\n-      addresses:\n-      - 172.17.255.1-172.17.255.250\n-EOF\n-\n-  kubectl apply -f https://raw.githubusercontent.com/google/metallb/v0.8.1/manifests/metallb.yaml\n-  kubectl apply -f ./metallb-config.yaml\n-}\n \n function setup_docker() {\n-  HUB=istio-testing TAG=latest make -f Makefile.core.mk controller docker\n-  kind --loglevel debug --name istio-testing load docker-image istio-testing/operator:istio-testing\n+  HUB=istio-testing TAG=1.5-dev make controller docker\n+  kind --loglevel debug --name istio-testing load docker-image istio-testing/operator:1.5-dev\n+  kind --loglevel debug --name istio-testing load docker-image istio-testing/app:istio-testing\n }\n \n-setup_kind_cluster\n-setup_docker\n+\n \n mkdir -p \"${ARTIFACTS}/out\"\n \n-ISTIO_DIR=\"${GOPATH}/src/istio.io/istio\"\n+ISTIO_DIR=\"${ROOT}/src/istio.io/istio\"","path":"tests/e2e/e2e.sh","position":63,"original_position":63,"commit_id":"0e9dfbd19d40e9e9b0b7ffea374bb702cbb4208a","original_commit_id":"0e9dfbd19d40e9e9b0b7ffea374bb702cbb4208a","user":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"body":"Further following this up - the git clone below could negatively interact with a local copy of istio (I recognize a test for the directory is done) but this would result in $ISTIO/istio being used from the local filesystem if the developer has work in that location.  This is highly undesirable for local test modes.","created_at":"2019-10-25T14:12:39Z","updated_at":"2019-10-25T14:18:44Z","html_url":"https://github.com/istio/operator/pull/456#discussion_r339073432","pull_request_url":"https://api.github.com/repos/istio/operator/pulls/456","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/operator/pulls/comments/339073432"},"html":{"href":"https://github.com/istio/operator/pull/456#discussion_r339073432"},"pull_request":{"href":"https://api.github.com/repos/istio/operator/pulls/456"}},"in_reply_to_id":339072803},"pull_request":{"url":"https://api.github.com/repos/istio/operator/pulls/456","id":331972315,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxOTcyMzE1","html_url":"https://github.com/istio/operator/pull/456","diff_url":"https://github.com/istio/operator/pull/456.diff","patch_url":"https://github.com/istio/operator/pull/456.patch","issue_url":"https://api.github.com/repos/istio/operator/issues/456","number":456,"state":"open","locked":false,"title":"Operator e2e Fix","user":{"login":"irisdingbj","id":8347164,"node_id":"MDQ6VXNlcjgzNDcxNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8347164?v=4","gravatar_id":"","url":"https://api.github.com/users/irisdingbj","html_url":"https://github.com/irisdingbj","followers_url":"https://api.github.com/users/irisdingbj/followers","following_url":"https://api.github.com/users/irisdingbj/following{/other_user}","gists_url":"https://api.github.com/users/irisdingbj/gists{/gist_id}","starred_url":"https://api.github.com/users/irisdingbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisdingbj/subscriptions","organizations_url":"https://api.github.com/users/irisdingbj/orgs","repos_url":"https://api.github.com/users/irisdingbj/repos","events_url":"https://api.github.com/users/irisdingbj/events{/privacy}","received_events_url":"https://api.github.com/users/irisdingbj/received_events","type":"User","site_admin":false},"body":"bases on https://github.com/istio/operator/pull/404\r\n\r\n@sdake I am trying to fix the e2e failure for operator controller here based on your above PR.","created_at":"2019-10-24T10:25:53Z","updated_at":"2019-10-25T14:18:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77b580d4c41f7693c669fca0dd1ace2cc384a669","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1401593917,"node_id":"MDU6TGFiZWwxNDAxNTkzOTE3","url":"https://api.github.com/repos/istio/operator/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":1448953407,"node_id":"MDU6TGFiZWwxNDQ4OTUzNDA3","url":"https://api.github.com/repos/istio/operator/labels/size/M","name":"size/M","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/operator/pulls/456/commits","review_comments_url":"https://api.github.com/repos/istio/operator/pulls/456/comments","review_comment_url":"https://api.github.com/repos/istio/operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/operator/issues/456/comments","statuses_url":"https://api.github.com/repos/istio/operator/statuses/0e9dfbd19d40e9e9b0b7ffea374bb702cbb4208a","head":{"label":"irisdingbj:e2e","ref":"e2e","sha":"0e9dfbd19d40e9e9b0b7ffea374bb702cbb4208a","user":{"login":"irisdingbj","id":8347164,"node_id":"MDQ6VXNlcjgzNDcxNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8347164?v=4","gravatar_id":"","url":"https://api.github.com/users/irisdingbj","html_url":"https://github.com/irisdingbj","followers_url":"https://api.github.com/users/irisdingbj/followers","following_url":"https://api.github.com/users/irisdingbj/following{/other_user}","gists_url":"https://api.github.com/users/irisdingbj/gists{/gist_id}","starred_url":"https://api.github.com/users/irisdingbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisdingbj/subscriptions","organizations_url":"https://api.github.com/users/irisdingbj/orgs","repos_url":"https://api.github.com/users/irisdingbj/repos","events_url":"https://api.github.com/users/irisdingbj/events{/privacy}","received_events_url":"https://api.github.com/users/irisdingbj/received_events","type":"User","site_admin":false},"repo":{"id":209222526,"node_id":"MDEwOlJlcG9zaXRvcnkyMDkyMjI1MjY=","name":"operator","full_name":"irisdingbj/operator","private":false,"owner":{"login":"irisdingbj","id":8347164,"node_id":"MDQ6VXNlcjgzNDcxNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8347164?v=4","gravatar_id":"","url":"https://api.github.com/users/irisdingbj","html_url":"https://github.com/irisdingbj","followers_url":"https://api.github.com/users/irisdingbj/followers","following_url":"https://api.github.com/users/irisdingbj/following{/other_user}","gists_url":"https://api.github.com/users/irisdingbj/gists{/gist_id}","starred_url":"https://api.github.com/users/irisdingbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisdingbj/subscriptions","organizations_url":"https://api.github.com/users/irisdingbj/orgs","repos_url":"https://api.github.com/users/irisdingbj/repos","events_url":"https://api.github.com/users/irisdingbj/events{/privacy}","received_events_url":"https://api.github.com/users/irisdingbj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/irisdingbj/operator","description":"Istio operator provides user friendly options to operate the Istio service mesh","fork":true,"url":"https://api.github.com/repos/irisdingbj/operator","forks_url":"https://api.github.com/repos/irisdingbj/operator/forks","keys_url":"https://api.github.com/repos/irisdingbj/operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irisdingbj/operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irisdingbj/operator/teams","hooks_url":"https://api.github.com/repos/irisdingbj/operator/hooks","issue_events_url":"https://api.github.com/repos/irisdingbj/operator/issues/events{/number}","events_url":"https://api.github.com/repos/irisdingbj/operator/events","assignees_url":"https://api.github.com/repos/irisdingbj/operator/assignees{/user}","branches_url":"https://api.github.com/repos/irisdingbj/operator/branches{/branch}","tags_url":"https://api.github.com/repos/irisdingbj/operator/tags","blobs_url":"https://api.github.com/repos/irisdingbj/operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irisdingbj/operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irisdingbj/operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/irisdingbj/operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irisdingbj/operator/statuses/{sha}","languages_url":"https://api.github.com/repos/irisdingbj/operator/languages","stargazers_url":"https://api.github.com/repos/irisdingbj/operator/stargazers","contributors_url":"https://api.github.com/repos/irisdingbj/operator/contributors","subscribers_url":"https://api.github.com/repos/irisdingbj/operator/subscribers","subscription_url":"https://api.github.com/repos/irisdingbj/operator/subscription","commits_url":"https://api.github.com/repos/irisdingbj/operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/irisdingbj/operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/irisdingbj/operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/irisdingbj/operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/irisdingbj/operator/contents/{+path}","compare_url":"https://api.github.com/repos/irisdingbj/operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irisdingbj/operator/merges","archive_url":"https://api.github.com/repos/irisdingbj/operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irisdingbj/operator/downloads","issues_url":"https://api.github.com/repos/irisdingbj/operator/issues{/number}","pulls_url":"https://api.github.com/repos/irisdingbj/operator/pulls{/number}","milestones_url":"https://api.github.com/repos/irisdingbj/operator/milestones{/number}","notifications_url":"https://api.github.com/repos/irisdingbj/operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irisdingbj/operator/labels{/name}","releases_url":"https://api.github.com/repos/irisdingbj/operator/releases{/id}","deployments_url":"https://api.github.com/repos/irisdingbj/operator/deployments","created_at":"2019-09-18T05:09:58Z","updated_at":"2019-09-18T05:10:00Z","pushed_at":"2019-10-25T12:46:24Z","git_url":"git://github.com/irisdingbj/operator.git","ssh_url":"git@github.com:irisdingbj/operator.git","clone_url":"https://github.com/irisdingbj/operator.git","svn_url":"https://github.com/irisdingbj/operator","homepage":null,"size":42308,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"e424037a3466b480400bef4f1274c858e84ec1ee","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":180454522,"node_id":"MDEwOlJlcG9zaXRvcnkxODA0NTQ1MjI=","name":"operator","full_name":"istio/operator","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/operator","description":"Istio operator provides user friendly options to operate the Istio service mesh","fork":false,"url":"https://api.github.com/repos/istio/operator","forks_url":"https://api.github.com/repos/istio/operator/forks","keys_url":"https://api.github.com/repos/istio/operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/operator/teams","hooks_url":"https://api.github.com/repos/istio/operator/hooks","issue_events_url":"https://api.github.com/repos/istio/operator/issues/events{/number}","events_url":"https://api.github.com/repos/istio/operator/events","assignees_url":"https://api.github.com/repos/istio/operator/assignees{/user}","branches_url":"https://api.github.com/repos/istio/operator/branches{/branch}","tags_url":"https://api.github.com/repos/istio/operator/tags","blobs_url":"https://api.github.com/repos/istio/operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/operator/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/operator/languages","stargazers_url":"https://api.github.com/repos/istio/operator/stargazers","contributors_url":"https://api.github.com/repos/istio/operator/contributors","subscribers_url":"https://api.github.com/repos/istio/operator/subscribers","subscription_url":"https://api.github.com/repos/istio/operator/subscription","commits_url":"https://api.github.com/repos/istio/operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/operator/contents/{+path}","compare_url":"https://api.github.com/repos/istio/operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/operator/merges","archive_url":"https://api.github.com/repos/istio/operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/operator/downloads","issues_url":"https://api.github.com/repos/istio/operator/issues{/number}","pulls_url":"https://api.github.com/repos/istio/operator/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/operator/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/operator/labels{/name}","releases_url":"https://api.github.com/repos/istio/operator/releases{/id}","deployments_url":"https://api.github.com/repos/istio/operator/deployments","created_at":"2019-04-09T21:49:13Z","updated_at":"2019-10-25T05:58:37Z","pushed_at":"2019-10-25T12:46:26Z","git_url":"git://github.com/istio/operator.git","ssh_url":"git@github.com:istio/operator.git","clone_url":"https://github.com/istio/operator.git","svn_url":"https://github.com/istio/operator","homepage":null,"size":42361,"stargazers_count":89,"watchers_count":89,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":13,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/operator/pulls/456"},"html":{"href":"https://github.com/istio/operator/pull/456"},"issue":{"href":"https://api.github.com/repos/istio/operator/issues/456"},"comments":{"href":"https://api.github.com/repos/istio/operator/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/operator/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/operator/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/istio/operator/statuses/0e9dfbd19d40e9e9b0b7ffea374bb702cbb4208a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sdake"}}