{"action":"created","issue":{"url":"https://api.github.com/repos/openmsupply/mobile/issues/1239","repository_url":"https://api.github.com/repos/openmsupply/mobile","labels_url":"https://api.github.com/repos/openmsupply/mobile/issues/1239/labels{/name}","comments_url":"https://api.github.com/repos/openmsupply/mobile/issues/1239/comments","events_url":"https://api.github.com/repos/openmsupply/mobile/issues/1239/events","html_url":"https://github.com/openmsupply/mobile/issues/1239","id":493832466,"node_id":"MDU6SXNzdWU0OTM4MzI0NjY=","number":1239,"title":"SupplierRequisitionPage TESTING","user":{"login":"joshxg","id":35858975,"node_id":"MDQ6VXNlcjM1ODU4OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/35858975?v=4","gravatar_id":"","url":"https://api.github.com/users/joshxg","html_url":"https://github.com/joshxg","followers_url":"https://api.github.com/users/joshxg/followers","following_url":"https://api.github.com/users/joshxg/following{/other_user}","gists_url":"https://api.github.com/users/joshxg/gists{/gist_id}","starred_url":"https://api.github.com/users/joshxg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshxg/subscriptions","organizations_url":"https://api.github.com/users/joshxg/orgs","repos_url":"https://api.github.com/users/joshxg/repos","events_url":"https://api.github.com/users/joshxg/events{/privacy}","received_events_url":"https://api.github.com/users/joshxg/received_events","type":"User","site_admin":false},"labels":[{"id":1510756824,"node_id":"MDU6TGFiZWwxNTEwNzU2ODI0","url":"https://api.github.com/repos/openmsupply/mobile/labels/DataTable","name":"DataTable","color":"e21bc1","default":false},{"id":1585765223,"node_id":"MDU6TGFiZWwxNTg1NzY1MjIz","url":"https://api.github.com/repos/openmsupply/mobile/labels/Test%20Plan%20Template","name":"Test Plan Template","color":"9de2f2","default":false},{"id":821922509,"node_id":"MDU6TGFiZWw4MjE5MjI1MDk=","url":"https://api.github.com/repos/openmsupply/mobile/labels/needs%20testing","name":"needs testing","color":"ed835a","default":false}],"state":"open","locked":false,"assignee":{"login":"Chris-Petty","id":7684221,"node_id":"MDQ6VXNlcjc2ODQyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7684221?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Petty","html_url":"https://github.com/Chris-Petty","followers_url":"https://api.github.com/users/Chris-Petty/followers","following_url":"https://api.github.com/users/Chris-Petty/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Petty/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Petty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Petty/subscriptions","organizations_url":"https://api.github.com/users/Chris-Petty/orgs","repos_url":"https://api.github.com/users/Chris-Petty/repos","events_url":"https://api.github.com/users/Chris-Petty/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Petty/received_events","type":"User","site_admin":false},"assignees":[{"login":"Chris-Petty","id":7684221,"node_id":"MDQ6VXNlcjc2ODQyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/7684221?v=4","gravatar_id":"","url":"https://api.github.com/users/Chris-Petty","html_url":"https://github.com/Chris-Petty","followers_url":"https://api.github.com/users/Chris-Petty/followers","following_url":"https://api.github.com/users/Chris-Petty/following{/other_user}","gists_url":"https://api.github.com/users/Chris-Petty/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris-Petty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris-Petty/subscriptions","organizations_url":"https://api.github.com/users/Chris-Petty/orgs","repos_url":"https://api.github.com/users/Chris-Petty/repos","events_url":"https://api.github.com/users/Chris-Petty/events{/privacy}","received_events_url":"https://api.github.com/users/Chris-Petty/received_events","type":"User","site_admin":false},{"login":"wlthomson","id":43223637,"node_id":"MDQ6VXNlcjQzMjIzNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/43223637?v=4","gravatar_id":"","url":"https://api.github.com/users/wlthomson","html_url":"https://github.com/wlthomson","followers_url":"https://api.github.com/users/wlthomson/followers","following_url":"https://api.github.com/users/wlthomson/following{/other_user}","gists_url":"https://api.github.com/users/wlthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/wlthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlthomson/subscriptions","organizations_url":"https://api.github.com/users/wlthomson/orgs","repos_url":"https://api.github.com/users/wlthomson/repos","events_url":"https://api.github.com/users/wlthomson/events{/privacy}","received_events_url":"https://api.github.com/users/wlthomson/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openmsupply/mobile/milestones/8","html_url":"https://github.com/openmsupply/mobile/milestone/8","labels_url":"https://api.github.com/repos/openmsupply/mobile/milestones/8/labels","id":4445180,"node_id":"MDk6TWlsZXN0b25lNDQ0NTE4MA==","number":8,"title":"Mobile 3.0.0","description":"","creator":{"login":"joshxg","id":35858975,"node_id":"MDQ6VXNlcjM1ODU4OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/35858975?v=4","gravatar_id":"","url":"https://api.github.com/users/joshxg","html_url":"https://github.com/joshxg","followers_url":"https://api.github.com/users/joshxg/followers","following_url":"https://api.github.com/users/joshxg/following{/other_user}","gists_url":"https://api.github.com/users/joshxg/gists{/gist_id}","starred_url":"https://api.github.com/users/joshxg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshxg/subscriptions","organizations_url":"https://api.github.com/users/joshxg/orgs","repos_url":"https://api.github.com/users/joshxg/repos","events_url":"https://api.github.com/users/joshxg/events{/privacy}","received_events_url":"https://api.github.com/users/joshxg/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":161,"state":"open","created_at":"2019-06-27T02:44:48Z","updated_at":"2019-09-28T07:37:10Z","due_on":"2019-08-01T07:00:00Z","closed_at":null},"comments":2,"created_at":"2019-09-16T03:41:05Z","updated_at":"2019-09-30T04:14:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"# TESTING\r\n\r\nThis is an issue for testing `SupplierRequisitionPage`.\r\n\r\nPlease copy and paste this list of tests and post your results in a comment in this issue.\r\n\r\n## Supplier Requisition Page\r\n\r\n#### NOTE: This page has a customization regarding [PROGRAMS](https://docs.google.com/document/d/1GgSDoNCMVjK11BeirNiOyYDHt_k-5jKrUiAaLK8R268/edit?usp=sharing) (sorry only docs there are at the moment!)\r\n\r\nThis page should be tested WITH NO PROGRAMS. Alterations to the behaviour of this page are listed at the BOTTOM of this list.\r\n\r\n\r\n### Special cases\r\n- [ ] Adjustments made to stock in this page are NOT reflected instantly in total stock on hand, without being finalised.\r\n- [ ] Top left displays 'Requisition X' where X is the invoice number for this invoice\r\n\r\n### Navigation to/from\r\n- [ ] Can navigate to this page through the Supplier Requisitions page.\r\n- [ ] Can navigate to this page through creating a new Supplier Requisition.\r\n\r\n### Sync\r\n- [ ] Changes made to this Supplier Requisition are synced to desktop.\r\n- [ ] Supplier Requisitions are synced from desktop.\r\n- [ ] Sync occuring while on this page do not update this page.\r\n\r\n### Table\r\n- [ ] Lists all items related to this Supplier Requisition\r\n- [ ] Initial sort is by ascending Item Name column.\r\n\r\n#### Row Press\r\n- [ ] Pressing on a row has no effect\r\n    \r\n#### Filtering\r\n- [ ] items are filtered by Item Name\r\n- [ ] Filtering is cleared when the search term is cleared.\r\n\r\n#### Columns \r\n**NOTE: Should be correct for previously added items AND new items added**\r\n- [ ] **Item code**\r\n    - [ ] Sortable (and sorts correctly).\r\n    - [ ] Items have the correct Item Code.\r\n    - [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting.\r\n    - [ ] NOT editable.\r\n    - [ ] Left aligned\r\n- [ ] **Item Name**\r\n    - [ ] Sortable (and sorts correctly).\r\n    - [ ] Item Names are correct for an item in the Supplier Requisition.\r\n    - [ ] Sorting icon updates correctly to indicate ascending/descending and no sorting.\r\n    - [ ] NOT editable\r\n    - [ ] Text overflow handled (Create an item name that is very long)\r\n    - [ ] Left aligned\r\n- [ ] **Current Stock**\r\n    - [ ] Sortable (and sorts correctly).\r\n    - [ ] NOT Editable\r\n    - [ ] Right aligned\r\n    - [ ] Displays the current stock for that item\r\n    - [ ] Is updated when adjustments are made and requisition is revistited\r\n- [ ] **Monthly usage**\r\n    - [ ] Sortable (and sorts correctly).\r\n    - [ ] NOT Editable\r\n    - [ ] Right aligned\r\n    - [ ] Displays the monthly usage for that item - [ sum of customer invoice quantities for an item in the last 30 days]\r\n- [ ] **Suggested Quantity**\r\n    - [ ] Sortable (and sorts correctly).\r\n    - [ ] NOT Editable\r\n    - [ ] Right aligned\r\n    - [ ] Displays the suggested quantity for that item - [ Math.ceil(Math.max(dailyUsage * daysToSupply - stockOnHand, 0)) ]\r\n    - [ ] Adjusts correctly when months of supply is changed\r\n- [ ] **Requested Quantity**\r\n    - [ ] Sortable (and sorts correctly).\r\n    - [ ] Editable\r\n    - [ ] NOT editable when FINALISED\r\n    - [ ] Right aligned\r\n    - [ ] Cannot enter negative values\r\n- [ ] **Remove**\r\n    - [ ] NOT sortable\r\n    - [ ] NOT editable\r\n    - [ ] Can select any row\r\n    - [ ] Can select multiple rows\r\n    - [ ] Selecting a row opens a confirmation dialog at the bottom of the page.\r\n    - [ ] Unselecting a row closes the confirmation dialog at the bottom of the page.\r\n    - [ ] Confirming the confirmation dialog deletes the items    \r\n    - [ ] Cancelling the confirmation dialog removes the current selection and closes the confirmation dialog\r\n    - [ ] Is DISABLED when finalised\r\n\r\n### Buttons\r\n- [ ] Clicking New Item button opens a \"select an item\" dialog\r\n- [ ] Use Suggested Quantity: Sets all rows Requested Quantity to equal the Suggested Quantity column\r\n- [ ] Create Automatic Order: Adds all items which have a suggested quantity > 0 and sets the requested quantity to equal the suggested quantity\r\n- [ ] Add master list items: Adds all items in this stores master lists (with no duplicates)\r\n\r\n### Page Info\r\n- [ ] **Entry Date**\r\n    - [ ] Shows the correct entry date for this requisition\r\n- [ ] **Entered By**\r\n    - [ ] Shows the correct user who created the requisition\r\n- [ ] **Supplier**\r\n    - [ ] Shows the correct Supplier this requisition is for.\r\n- [ ] **Months of supply**\r\n    - [ ] Displays the number of months this requisition is for.\r\n    - [ ] Clicking opens a months of supply modal (see: modals)\r\n    - [ ] Is disabled when finalised.\r\n- [ ] **Comment**\r\n    - [ ] Displays the Comment field for this invoice correctly \r\n    - [ ] Clicking opens the comment modal (see modals) \r\n    - [ ] Is disabled when finalised.\r\n\r\n### Modals\r\n- [ ] **New Item**\r\n    - [ ] Title is `Search for an Item to add`\r\n    - [ ] Options to select ALL/ANY Item.\r\n    - [ ] Search Bar is auto focused on opening\r\n    - [ ] Closing the modal, closes the modal\r\n    - [ ] Filtering the list, filters by Item name OR Item Code.\r\n    - [ ] Clearing the search term clears filtering\r\n    - [ ] Clicking an Item adds this item to the customer invoice.\r\n    - [ ] Right hand side column of the list of options lists the correct available quantity\r\n    - [ ] Adds a new batch to the invoice\r\n- [ ] **Comment**\r\n    - [ ] Title is `Enter the invoice comment`\r\n    - [ ] If there is already a comment, it is entered already.\r\n    - [ ] Empty if no comment\r\n    - [ ] Entering a comment and pressing OK saves the comment correctly\r\n    - [ ] closing the modal closes the modal\r\n- [ ] **Months of supply**\r\n    - [ ] Title is `Select the number of months stock required`\r\n    - [ ] Should be set to the current set months of stock [default: 1].\r\n    - [ ] clicking a month sets this month as the new months of supply\r\n    - [ ] closing the modal closes the modal\r\n\r\n### Finalizing\r\n- [ ] Pressing finalize opens a confirmation dialog warning about locking the invoice\r\n- [ ] Cancelling the confirmation cancels finalizing the requisition\r\n- [ ] Confirming the confirmation dialog finalises the requisition, locking all edits (as listed above)\r\n- [ ] Finalizing the invoice correctly sets the status of the requisition to finalised.\r\n- [ ] All 0 quantity items are pruned from the requisition - leaving only items with an actual quantity entered.\r\n- [ ] Cannot finalise with all 0 quantity items.\r\n\r\n### WITH PROGRAMS:\r\n\r\n### Table\r\n#### Columns \r\n*note: additional columns*\r\n- [ ] **Price**\r\n    - [ ] NOT sortable\r\n    - [ ] NOT editable\r\n    - [ ] Shows the price for this item, which is the maximum of all master list name join prices for that item\r\n- [ ] **Unit**\r\n    - [ ] NOT sortable \r\n    - [ ] NOT editable\r\n    - [ ] displays the unit for this item - or N/A if none defined.\r\n\r\n\r\n## Buttons\r\n*note: these should be the only buttons*\r\n- Set requested quantity (as above)\r\n- View regimen Data: Opens the regimen data modal\r\n- Toggle - show/hide over stocked: Hides or shows and stock where the suggested quantity === 0\r\n\r\n## Page Info\r\n*note: should be the only page info*\r\n- [ ] **Entry Date**\r\n    - [ ] Shows the correct entry date for this requisition\r\n- [ ] **Entered By**\r\n    - [ ] Shows the correct user who created the requisition\r\n- [ ] **Supplier**\r\n    - [ ] Shows the correct Supplier this requisition is for.\r\n- [ ] **Months of supply**\r\n    - [ ] Displays the number of months this requisition is for.\r\n    - [ ] Is defined by the order type  used to create the requisition.\r\n- [ ] **Comment**\r\n    - [ ] Displays the Comment field for this invoice correctly \r\n    - [ ] Clicking opens the comment modal (see modals) \r\n    - [ ] Is disabled when finalised.\r\n- [ ] **Months of supply**\r\n    - [ ] Displays the number of months this requisition is for.\r\n    - [ ] Is defined by the order type  used to create the requisition.\r\n- [ ] **program**\r\n    - [ ] displays the program used to create this requisition.\r\n- [ ] **order type**\r\n    - [ ] displays the order type used to create this requisition.\r\n- [ ] **period**\r\n    - [ ] displays the period name and period start/end dates used to create this requisition.\r\n\r\n## Modals\r\n*Note: only modals\r\n- [ ] **Comment**\r\n    - [ ] Title is `Enter the invoice comment`\r\n    - [ ] If there is already a comment, it is entered already.\r\n    - [ ] Empty if no comment\r\n    - [ ] Entering a comment and pressing OK saves the comment correctly\r\n    - [ ] closing the modal closes the modal\r\n- [ ] **RegimenData modal**\r\n    - [ ] Title is `Enter the Regimen Data`\r\n    - [ ] Displays a list of regimen data defined by the program\r\n    - [ ] values and comments are saved on opening/closing\r\n\r\n\r\n# KNOWN ISSUES"},"comment":{"url":"https://api.github.com/repos/openmsupply/mobile/issues/comments/536393491","html_url":"https://github.com/openmsupply/mobile/issues/1239#issuecomment-536393491","issue_url":"https://api.github.com/repos/openmsupply/mobile/issues/1239","id":536393491,"node_id":"MDEyOklzc3VlQ29tbWVudDUzNjM5MzQ5MQ==","user":{"login":"wlthomson","id":43223637,"node_id":"MDQ6VXNlcjQzMjIzNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/43223637?v=4","gravatar_id":"","url":"https://api.github.com/users/wlthomson","html_url":"https://github.com/wlthomson","followers_url":"https://api.github.com/users/wlthomson/followers","following_url":"https://api.github.com/users/wlthomson/following{/other_user}","gists_url":"https://api.github.com/users/wlthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/wlthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlthomson/subscriptions","organizations_url":"https://api.github.com/users/wlthomson/orgs","repos_url":"https://api.github.com/users/wlthomson/repos","events_url":"https://api.github.com/users/wlthomson/events{/privacy}","received_events_url":"https://api.github.com/users/wlthomson/received_events","type":"User","site_admin":false},"created_at":"2019-09-30T04:14:14Z","updated_at":"2019-09-30T04:14:14Z","author_association":"CONTRIBUTOR","body":"> #1022 -> For program based requisition, please check with thresholdMOS = 0 (if works please move #996 to done column)\r\n\r\nNot sure what \"works\" means in this context, but have confirmed can create and finalise a program requisition with `thresholdMOS = 0`. Is that sufficient?"}}
{"actor":{"display_login":"wlthomson"}}