{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/swift-apis/pulls/comments/271554256","pull_request_review_id":221974572,"id":271554256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTU1NDI1Ng==","diff_hunk":"@@ -133,6 +133,35 @@ public extension Padding {\n     }\n }\n \n+/// An older padding scheme. Used by padding, convolution, and pooling ops.\n+// @_frozen // SR-9739\n+public enum PaddingV1 {","path":"Sources/DeepLearning/Operators.swift","position":15,"original_position":15,"commit_id":"2809a9bc7b991c0ca96a65fffb88b0e9b98f3719","original_commit_id":"2809a9bc7b991c0ca96a65fffb88b0e9b98f3719","user":{"login":"eaplatanios","id":1294940,"node_id":"MDQ6VXNlcjEyOTQ5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1294940?v=4","gravatar_id":"","url":"https://api.github.com/users/eaplatanios","html_url":"https://github.com/eaplatanios","followers_url":"https://api.github.com/users/eaplatanios/followers","following_url":"https://api.github.com/users/eaplatanios/following{/other_user}","gists_url":"https://api.github.com/users/eaplatanios/gists{/gist_id}","starred_url":"https://api.github.com/users/eaplatanios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eaplatanios/subscriptions","organizations_url":"https://api.github.com/users/eaplatanios/orgs","repos_url":"https://api.github.com/users/eaplatanios/repos","events_url":"https://api.github.com/users/eaplatanios/events{/privacy}","received_events_url":"https://api.github.com/users/eaplatanios/received_events","type":"User","site_admin":false},"body":"The pooling ops do not support explicit paddings. We could either not support explicit paddings at all for now (i.e., not even for convolution ops), or have two different padding modes.\r\n\r\nI checked and it compiled locally but I may have mixed up my branches. I'll check again.","created_at":"2019-04-03T01:46:25Z","updated_at":"2019-04-03T01:46:26Z","html_url":"https://github.com/tensorflow/swift-apis/pull/74#discussion_r271554256","pull_request_url":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/swift-apis/pulls/comments/271554256"},"html":{"href":"https://github.com/tensorflow/swift-apis/pull/74#discussion_r271554256"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74"}},"in_reply_to_id":271553422},"pull_request":{"url":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74","id":266862905,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2ODYyOTA1","html_url":"https://github.com/tensorflow/swift-apis/pull/74","diff_url":"https://github.com/tensorflow/swift-apis/pull/74.diff","patch_url":"https://github.com/tensorflow/swift-apis/pull/74.patch","issue_url":"https://api.github.com/repos/tensorflow/swift-apis/issues/74","number":74,"state":"open","locked":false,"title":"Made some more compatibility fixes to support the latest raw ops.","user":{"login":"eaplatanios","id":1294940,"node_id":"MDQ6VXNlcjEyOTQ5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1294940?v=4","gravatar_id":"","url":"https://api.github.com/users/eaplatanios","html_url":"https://github.com/eaplatanios","followers_url":"https://api.github.com/users/eaplatanios/followers","following_url":"https://api.github.com/users/eaplatanios/following{/other_user}","gists_url":"https://api.github.com/users/eaplatanios/gists{/gist_id}","starred_url":"https://api.github.com/users/eaplatanios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eaplatanios/subscriptions","organizations_url":"https://api.github.com/users/eaplatanios/orgs","repos_url":"https://api.github.com/users/eaplatanios/repos","events_url":"https://api.github.com/users/eaplatanios/events{/privacy}","received_events_url":"https://api.github.com/users/eaplatanios/received_events","type":"User","site_admin":false},"body":"Hopefully fixes all remaining issues [here](https://github.com/apple/swift/pull/23700).","created_at":"2019-04-03T01:34:59Z","updated_at":"2019-04-03T01:46:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e86bd72be443e6fd3e41d037861e063bf2888d66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74/commits","review_comments_url":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74/comments","review_comment_url":"https://api.github.com/repos/tensorflow/swift-apis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/swift-apis/issues/74/comments","statuses_url":"https://api.github.com/repos/tensorflow/swift-apis/statuses/2809a9bc7b991c0ca96a65fffb88b0e9b98f3719","head":{"label":"eaplatanios:conv-fix","ref":"conv-fix","sha":"2809a9bc7b991c0ca96a65fffb88b0e9b98f3719","user":{"login":"eaplatanios","id":1294940,"node_id":"MDQ6VXNlcjEyOTQ5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1294940?v=4","gravatar_id":"","url":"https://api.github.com/users/eaplatanios","html_url":"https://github.com/eaplatanios","followers_url":"https://api.github.com/users/eaplatanios/followers","following_url":"https://api.github.com/users/eaplatanios/following{/other_user}","gists_url":"https://api.github.com/users/eaplatanios/gists{/gist_id}","starred_url":"https://api.github.com/users/eaplatanios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eaplatanios/subscriptions","organizations_url":"https://api.github.com/users/eaplatanios/orgs","repos_url":"https://api.github.com/users/eaplatanios/repos","events_url":"https://api.github.com/users/eaplatanios/events{/privacy}","received_events_url":"https://api.github.com/users/eaplatanios/received_events","type":"User","site_admin":false},"repo":{"id":171929409,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE5Mjk0MDk=","name":"swift-apis","full_name":"eaplatanios/swift-apis","private":false,"owner":{"login":"eaplatanios","id":1294940,"node_id":"MDQ6VXNlcjEyOTQ5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1294940?v=4","gravatar_id":"","url":"https://api.github.com/users/eaplatanios","html_url":"https://github.com/eaplatanios","followers_url":"https://api.github.com/users/eaplatanios/followers","following_url":"https://api.github.com/users/eaplatanios/following{/other_user}","gists_url":"https://api.github.com/users/eaplatanios/gists{/gist_id}","starred_url":"https://api.github.com/users/eaplatanios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eaplatanios/subscriptions","organizations_url":"https://api.github.com/users/eaplatanios/orgs","repos_url":"https://api.github.com/users/eaplatanios/repos","events_url":"https://api.github.com/users/eaplatanios/events{/privacy}","received_events_url":"https://api.github.com/users/eaplatanios/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eaplatanios/swift-apis","description":"Swift for TensorFlow Deep Learning Library","fork":true,"url":"https://api.github.com/repos/eaplatanios/swift-apis","forks_url":"https://api.github.com/repos/eaplatanios/swift-apis/forks","keys_url":"https://api.github.com/repos/eaplatanios/swift-apis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eaplatanios/swift-apis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eaplatanios/swift-apis/teams","hooks_url":"https://api.github.com/repos/eaplatanios/swift-apis/hooks","issue_events_url":"https://api.github.com/repos/eaplatanios/swift-apis/issues/events{/number}","events_url":"https://api.github.com/repos/eaplatanios/swift-apis/events","assignees_url":"https://api.github.com/repos/eaplatanios/swift-apis/assignees{/user}","branches_url":"https://api.github.com/repos/eaplatanios/swift-apis/branches{/branch}","tags_url":"https://api.github.com/repos/eaplatanios/swift-apis/tags","blobs_url":"https://api.github.com/repos/eaplatanios/swift-apis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eaplatanios/swift-apis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eaplatanios/swift-apis/git/refs{/sha}","trees_url":"https://api.github.com/repos/eaplatanios/swift-apis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eaplatanios/swift-apis/statuses/{sha}","languages_url":"https://api.github.com/repos/eaplatanios/swift-apis/languages","stargazers_url":"https://api.github.com/repos/eaplatanios/swift-apis/stargazers","contributors_url":"https://api.github.com/repos/eaplatanios/swift-apis/contributors","subscribers_url":"https://api.github.com/repos/eaplatanios/swift-apis/subscribers","subscription_url":"https://api.github.com/repos/eaplatanios/swift-apis/subscription","commits_url":"https://api.github.com/repos/eaplatanios/swift-apis/commits{/sha}","git_commits_url":"https://api.github.com/repos/eaplatanios/swift-apis/git/commits{/sha}","comments_url":"https://api.github.com/repos/eaplatanios/swift-apis/comments{/number}","issue_comment_url":"https://api.github.com/repos/eaplatanios/swift-apis/issues/comments{/number}","contents_url":"https://api.github.com/repos/eaplatanios/swift-apis/contents/{+path}","compare_url":"https://api.github.com/repos/eaplatanios/swift-apis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eaplatanios/swift-apis/merges","archive_url":"https://api.github.com/repos/eaplatanios/swift-apis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eaplatanios/swift-apis/downloads","issues_url":"https://api.github.com/repos/eaplatanios/swift-apis/issues{/number}","pulls_url":"https://api.github.com/repos/eaplatanios/swift-apis/pulls{/number}","milestones_url":"https://api.github.com/repos/eaplatanios/swift-apis/milestones{/number}","notifications_url":"https://api.github.com/repos/eaplatanios/swift-apis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eaplatanios/swift-apis/labels{/name}","releases_url":"https://api.github.com/repos/eaplatanios/swift-apis/releases{/id}","deployments_url":"https://api.github.com/repos/eaplatanios/swift-apis/deployments","created_at":"2019-02-21T19:11:02Z","updated_at":"2019-02-21T19:11:05Z","pushed_at":"2019-04-03T01:34:16Z","git_url":"git://github.com/eaplatanios/swift-apis.git","ssh_url":"git@github.com:eaplatanios/swift-apis.git","clone_url":"https://github.com/eaplatanios/swift-apis.git","svn_url":"https://github.com/eaplatanios/swift-apis","homepage":"","size":19549,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"16124b6a5d33ea41f4d9ab0c24b545b2e593c9f5","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":170224648,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAyMjQ2NDg=","name":"swift-apis","full_name":"tensorflow/swift-apis","private":false,"owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tensorflow/swift-apis","description":"Swift for TensorFlow Deep Learning Library","fork":false,"url":"https://api.github.com/repos/tensorflow/swift-apis","forks_url":"https://api.github.com/repos/tensorflow/swift-apis/forks","keys_url":"https://api.github.com/repos/tensorflow/swift-apis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/swift-apis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/swift-apis/teams","hooks_url":"https://api.github.com/repos/tensorflow/swift-apis/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/swift-apis/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/swift-apis/events","assignees_url":"https://api.github.com/repos/tensorflow/swift-apis/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/swift-apis/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/swift-apis/tags","blobs_url":"https://api.github.com/repos/tensorflow/swift-apis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/swift-apis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/swift-apis/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/swift-apis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/swift-apis/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/swift-apis/languages","stargazers_url":"https://api.github.com/repos/tensorflow/swift-apis/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/swift-apis/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/swift-apis/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/swift-apis/subscription","commits_url":"https://api.github.com/repos/tensorflow/swift-apis/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/swift-apis/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/swift-apis/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/swift-apis/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/swift-apis/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/swift-apis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/swift-apis/merges","archive_url":"https://api.github.com/repos/tensorflow/swift-apis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/swift-apis/downloads","issues_url":"https://api.github.com/repos/tensorflow/swift-apis/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/swift-apis/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/swift-apis/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/swift-apis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/swift-apis/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/swift-apis/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/swift-apis/deployments","created_at":"2019-02-12T00:25:51Z","updated_at":"2019-04-02T18:39:45Z","pushed_at":"2019-04-03T01:35:00Z","git_url":"git://github.com/tensorflow/swift-apis.git","ssh_url":"git@github.com:tensorflow/swift-apis.git","clone_url":"https://github.com/tensorflow/swift-apis.git","svn_url":"https://github.com/tensorflow/swift-apis","homepage":"","size":19526,"stargazers_count":302,"watchers_count":302,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":15,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74"},"html":{"href":"https://github.com/tensorflow/swift-apis/pull/74"},"issue":{"href":"https://api.github.com/repos/tensorflow/swift-apis/issues/74"},"comments":{"href":"https://api.github.com/repos/tensorflow/swift-apis/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/swift-apis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/swift-apis/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/swift-apis/statuses/2809a9bc7b991c0ca96a65fffb88b0e9b98f3719"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eaplatanios"}}