{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/28419","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28419/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28419/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28419/events","html_url":"https://github.com/cms-sw/cmssw/pull/28419","id":524638935,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyMzc3ODg1","number":28419,"title":"Convert GEM pad cluster before sending to EMTF","user":{"login":"dildick","id":4134786,"node_id":"MDQ6VXNlcjQxMzQ3ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/4134786?v=4","gravatar_id":"","url":"https://api.github.com/users/dildick","html_url":"https://github.com/dildick","followers_url":"https://api.github.com/users/dildick/followers","following_url":"https://api.github.com/users/dildick/following{/other_user}","gists_url":"https://api.github.com/users/dildick/gists{/gist_id}","starred_url":"https://api.github.com/users/dildick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dildick/subscriptions","organizations_url":"https://api.github.com/users/dildick/orgs","repos_url":"https://api.github.com/users/dildick/repos","events_url":"https://api.github.com/users/dildick/events{/privacy}","received_events_url":"https://api.github.com/users/dildick/received_events","type":"User","site_admin":false},"labels":[{"id":673935056,"node_id":"MDU6TGFiZWw2NzM5MzUwNTY=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820587,"node_id":"MDU6TGFiZWw1MjgyMDU4Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false},{"id":530655448,"node_id":"MDU6TGFiZWw1MzA2NTU0NDg=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/81","html_url":"https://github.com/cms-sw/cmssw/milestone/81","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/81/labels","id":4314065,"node_id":"MDk6TWlsZXN0b25lNDMxNDA2NQ==","number":81,"title":"CMSSW_11_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":1339,"state":"open","created_at":"2019-05-14T17:36:57Z","updated_at":"2019-11-18T21:47:51Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2019-11-18T21:47:29Z","updated_at":"2019-11-18T21:54:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/28419","html_url":"https://github.com/cms-sw/cmssw/pull/28419","diff_url":"https://github.com/cms-sw/cmssw/pull/28419.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/28419.patch"},"body":"#### PR description:\r\n\r\nThis PR extends the `GEMPadDigiClusterProducer` with a function `convertCluster` , which calculates a clusters' theta and phi position based off the eta partition and pad number. This functionality will be offloaded from the EMTF onto the GEM CTP7/ATCA processor. The code was taken from thttps://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1TMuonEndCap/src/PrimitiveConversion.cc#L841-L876. \r\n\r\nThe new cluster collection is given the label \"Converted\" \r\n```\r\nedmEventSize -a -v step2.root | grep GEMPadDigiCluster\r\nGEMDetIdGEMPadDigiClusterMuonDigiCollection_simMuonGEMPadDigiClusters__HLT. 399.2 334.7\r\nGEMDetIdGEMPadDigiClusterMuonDigiCollection_simMuonGEMPadDigiClusters_Converted_HLT. 335.6 318.3\r\n```\r\n\r\nFuture improvements may include: 1) using LUTs instead of the CMS geometry interface 2) allowing for alignment corrections.\r\n\r\nAdditionally, this PR consolidates all GEM trigger primitive producers from `L1Trigger/ME0Trigger` and `L1Trigger/L1TGEM` into a single package (`L1TGEM`). This is necessary to absorb the ME0 system into the GEM system later on. \r\n\r\n#### PR validation:\r\n\r\nI tested it with WF 22034.0\r\n\r\n#### if this PR is a backport please specify the original PR:\r\n\r\nN/A\r\n\r\nFYI @tahuang1991 @jiafulow "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/555226875","html_url":"https://github.com/cms-sw/cmssw/pull/28419#issuecomment-555226875","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/28419","id":555226875,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NTIyNjg3NQ==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2019-11-18T21:54:22Z","updated_at":"2019-11-18T21:54:22Z","author_association":"CONTRIBUTOR","body":"+code-checks\n\nLogs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28419/12808\n\n- This PR adds an extra 84KB to repository\n\n- Found files with invalid states:\n  - L1Trigger/L1TGEM/plugins/ME0PadDigiClusterProducer.cc:\n    - Added: bf3d1aeb82067e3a04b1e4408132fb84b7bec1c8\n    - Deleted: 65e84fb84d410aeace61819f2f90fb5e00dc5efe\n  - L1Trigger/L1TGEM/python/simMuonGEMPadDigiConvClusters_cfi.py:\n    - Added: 598dd0443627068fd67da06fcc42b754403da144\n    - Deleted: d83b06d828e0a36cd3f19de0d9fab3b6991c4873\n  - L1Trigger/L1TGEM/plugins/SealModule.cc:\n    - Added: bf3d1aeb82067e3a04b1e4408132fb84b7bec1c8\n    - Deleted: 65e84fb84d410aeace61819f2f90fb5e00dc5efe\n  - L1Trigger/L1TGEM/plugins/ME0TriggerPseudoProducer.h:\n    - Added: bf3d1aeb82067e3a04b1e4408132fb84b7bec1c8\n    - Deleted: 65e84fb84d410aeace61819f2f90fb5e00dc5efe\n  - L1Trigger/L1TGEM/plugins/GEMPadDigiConvertedClusterProducer.cc.txt:\n    - Added: 598dd0443627068fd67da06fcc42b754403da144\n    - Deleted: d83b06d828e0a36cd3f19de0d9fab3b6991c4873\n  - L1Trigger/L1TGEM/plugins/ME0TriggerProducer.h:\n    - Added: bf3d1aeb82067e3a04b1e4408132fb84b7bec1c8\n    - Deleted: 65e84fb84d410aeace61819f2f90fb5e00dc5efe\n  - L1Trigger/L1TGEM/python/muonME0PadDigis_cfi.py:\n    - Added: bf3d1aeb82067e3a04b1e4408132fb84b7bec1c8\n    - Deleted: 65e84fb84d410aeace61819f2f90fb5e00dc5efe\n"}}
{"actor":{"display_login":"cmsbuild"}}