{"action":"created","comment":{"url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/comments/358902785","pull_request_review_id":333419197,"id":358902785,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODkwMjc4NQ==","diff_hunk":"@@ -26,17 +26,21 @@ type cloudwatchInterface struct {\n }\n \n type cloudwatchData struct {\n-\tID                     *string\n-\tMetric                 *string\n-\tService                *string\n-\tStatistics             []string\n-\tPoints                 []*cloudwatch.Datapoint\n-\tNilToZero              *bool\n-\tAddCloudwatchTimestamp *bool\n-\tCustomTags             []tag\n-\tTags                   []tag\n-\tDimensions             []*cloudwatch.Dimension\n-\tRegion                 *string\n+\tID                      *string\n+\tMetricId                *string","path":"aws_cloudwatch.go","position":16,"original_position":16,"commit_id":"704d0e8e19b4a240b11645ec76f4b23e54349aee","original_commit_id":"704d0e8e19b4a240b11645ec76f4b23e54349aee","user":{"login":"bheight-Zymergen","id":45047230,"node_id":"MDQ6VXNlcjQ1MDQ3MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/45047230?v=4","gravatar_id":"","url":"https://api.github.com/users/bheight-Zymergen","html_url":"https://github.com/bheight-Zymergen","followers_url":"https://api.github.com/users/bheight-Zymergen/followers","following_url":"https://api.github.com/users/bheight-Zymergen/following{/other_user}","gists_url":"https://api.github.com/users/bheight-Zymergen/gists{/gist_id}","starred_url":"https://api.github.com/users/bheight-Zymergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bheight-Zymergen/subscriptions","organizations_url":"https://api.github.com/users/bheight-Zymergen/orgs","repos_url":"https://api.github.com/users/bheight-Zymergen/repos","events_url":"https://api.github.com/users/bheight-Zymergen/events{/privacy}","received_events_url":"https://api.github.com/users/bheight-Zymergen/received_events","type":"User","site_admin":false},"body":"In keeping with struct field naming practices I'd recommend we rename this to `MetricID`","created_at":"2019-12-17T16:43:05Z","updated_at":"2019-12-17T16:43:06Z","html_url":"https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118#discussion_r358902785","pull_request_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/comments/358902785"},"html":{"href":"https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118#discussion_r358902785"},"pull_request":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118","id":349339003,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5MzM5MDAz","html_url":"https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118","diff_url":"https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118.diff","patch_url":"https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118.patch","issue_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues/118","number":118,"state":"open","locked":false,"title":"Adding GetMetricsData support","user":{"login":"Deepak1100","id":13719412,"node_id":"MDQ6VXNlcjEzNzE5NDEy","avatar_url":"https://avatars1.githubusercontent.com/u/13719412?v=4","gravatar_id":"","url":"https://api.github.com/users/Deepak1100","html_url":"https://github.com/Deepak1100","followers_url":"https://api.github.com/users/Deepak1100/followers","following_url":"https://api.github.com/users/Deepak1100/following{/other_user}","gists_url":"https://api.github.com/users/Deepak1100/gists{/gist_id}","starred_url":"https://api.github.com/users/Deepak1100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deepak1100/subscriptions","organizations_url":"https://api.github.com/users/Deepak1100/orgs","repos_url":"https://api.github.com/users/Deepak1100/repos","events_url":"https://api.github.com/users/Deepak1100/events{/privacy}","received_events_url":"https://api.github.com/users/Deepak1100/received_events","type":"User","site_admin":false},"body":"Add GetMetricData Cloudwatch API","created_at":"2019-12-05T09:30:35Z","updated_at":"2019-12-17T16:43:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b77183843e0309efff40e2b8f78f21f7a6a49751","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118/commits","review_comments_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118/comments","review_comment_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues/118/comments","statuses_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/statuses/704d0e8e19b4a240b11645ec76f4b23e54349aee","head":{"label":"Deepak1100:master","ref":"master","sha":"704d0e8e19b4a240b11645ec76f4b23e54349aee","user":{"login":"Deepak1100","id":13719412,"node_id":"MDQ6VXNlcjEzNzE5NDEy","avatar_url":"https://avatars1.githubusercontent.com/u/13719412?v=4","gravatar_id":"","url":"https://api.github.com/users/Deepak1100","html_url":"https://github.com/Deepak1100","followers_url":"https://api.github.com/users/Deepak1100/followers","following_url":"https://api.github.com/users/Deepak1100/following{/other_user}","gists_url":"https://api.github.com/users/Deepak1100/gists{/gist_id}","starred_url":"https://api.github.com/users/Deepak1100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deepak1100/subscriptions","organizations_url":"https://api.github.com/users/Deepak1100/orgs","repos_url":"https://api.github.com/users/Deepak1100/repos","events_url":"https://api.github.com/users/Deepak1100/events{/privacy}","received_events_url":"https://api.github.com/users/Deepak1100/received_events","type":"User","site_admin":false},"repo":{"id":213302713,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMzMDI3MTM=","name":"yet-another-cloudwatch-exporter","full_name":"Deepak1100/yet-another-cloudwatch-exporter","private":false,"owner":{"login":"Deepak1100","id":13719412,"node_id":"MDQ6VXNlcjEzNzE5NDEy","avatar_url":"https://avatars1.githubusercontent.com/u/13719412?v=4","gravatar_id":"","url":"https://api.github.com/users/Deepak1100","html_url":"https://github.com/Deepak1100","followers_url":"https://api.github.com/users/Deepak1100/followers","following_url":"https://api.github.com/users/Deepak1100/following{/other_user}","gists_url":"https://api.github.com/users/Deepak1100/gists{/gist_id}","starred_url":"https://api.github.com/users/Deepak1100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deepak1100/subscriptions","organizations_url":"https://api.github.com/users/Deepak1100/orgs","repos_url":"https://api.github.com/users/Deepak1100/repos","events_url":"https://api.github.com/users/Deepak1100/events{/privacy}","received_events_url":"https://api.github.com/users/Deepak1100/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Deepak1100/yet-another-cloudwatch-exporter","description":"AWS cloudwatch to prometheus exporter - Discovers services through AWS tags, gets cloudwatch data and provides them as prometheus metrics with AWS tags as labels.","fork":true,"url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter","forks_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/forks","keys_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/teams","hooks_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/hooks","issue_events_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/events","assignees_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/tags","blobs_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/languages","stargazers_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/stargazers","contributors_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/contributors","subscribers_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/subscribers","subscription_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/subscription","commits_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/merges","archive_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/downloads","issues_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/labels{/name}","releases_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/releases{/id}","deployments_url":"https://api.github.com/repos/Deepak1100/yet-another-cloudwatch-exporter/deployments","created_at":"2019-10-07T05:31:25Z","updated_at":"2019-12-05T09:32:44Z","pushed_at":"2019-12-05T09:32:42Z","git_url":"git://github.com/Deepak1100/yet-another-cloudwatch-exporter.git","ssh_url":"git@github.com:Deepak1100/yet-another-cloudwatch-exporter.git","clone_url":"https://github.com/Deepak1100/yet-another-cloudwatch-exporter.git","svn_url":"https://github.com/Deepak1100/yet-another-cloudwatch-exporter","homepage":"","size":418,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ivx:master","ref":"master","sha":"fef89a6fc38d36ff5bb22553903480b4c7419bb8","user":{"login":"ivx","id":1009891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDk4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1009891?v=4","gravatar_id":"","url":"https://api.github.com/users/ivx","html_url":"https://github.com/ivx","followers_url":"https://api.github.com/users/ivx/followers","following_url":"https://api.github.com/users/ivx/following{/other_user}","gists_url":"https://api.github.com/users/ivx/gists{/gist_id}","starred_url":"https://api.github.com/users/ivx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivx/subscriptions","organizations_url":"https://api.github.com/users/ivx/orgs","repos_url":"https://api.github.com/users/ivx/repos","events_url":"https://api.github.com/users/ivx/events{/privacy}","received_events_url":"https://api.github.com/users/ivx/received_events","type":"Organization","site_admin":false},"repo":{"id":130756831,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3NTY4MzE=","name":"yet-another-cloudwatch-exporter","full_name":"ivx/yet-another-cloudwatch-exporter","private":false,"owner":{"login":"ivx","id":1009891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDk4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1009891?v=4","gravatar_id":"","url":"https://api.github.com/users/ivx","html_url":"https://github.com/ivx","followers_url":"https://api.github.com/users/ivx/followers","following_url":"https://api.github.com/users/ivx/following{/other_user}","gists_url":"https://api.github.com/users/ivx/gists{/gist_id}","starred_url":"https://api.github.com/users/ivx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivx/subscriptions","organizations_url":"https://api.github.com/users/ivx/orgs","repos_url":"https://api.github.com/users/ivx/repos","events_url":"https://api.github.com/users/ivx/events{/privacy}","received_events_url":"https://api.github.com/users/ivx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ivx/yet-another-cloudwatch-exporter","description":"AWS cloudwatch to prometheus exporter - Discovers services through AWS tags, gets cloudwatch data and provides them as prometheus metrics with AWS tags as labels.","fork":false,"url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter","forks_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/forks","keys_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/teams","hooks_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/hooks","issue_events_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/events","assignees_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/tags","blobs_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/languages","stargazers_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/stargazers","contributors_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/contributors","subscribers_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/subscribers","subscription_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/subscription","commits_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/merges","archive_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/downloads","issues_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/labels{/name}","releases_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/releases{/id}","deployments_url":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/deployments","created_at":"2018-04-23T21:06:31Z","updated_at":"2019-12-17T16:35:39Z","pushed_at":"2019-12-05T09:32:44Z","git_url":"git://github.com/ivx/yet-another-cloudwatch-exporter.git","ssh_url":"git@github.com:ivx/yet-another-cloudwatch-exporter.git","clone_url":"https://github.com/ivx/yet-another-cloudwatch-exporter.git","svn_url":"https://github.com/ivx/yet-another-cloudwatch-exporter","homepage":"","size":415,"stargazers_count":94,"watchers_count":94,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":12,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118"},"html":{"href":"https://github.com/ivx/yet-another-cloudwatch-exporter/pull/118"},"issue":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues/118"},"comments":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/ivx/yet-another-cloudwatch-exporter/statuses/704d0e8e19b4a240b11645ec76f4b23e54349aee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bheight-Zymergen"}}