{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/fairing/issues/319","repository_url":"https://api.github.com/repos/kubeflow/fairing","labels_url":"https://api.github.com/repos/kubeflow/fairing/issues/319/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/fairing/issues/319/comments","events_url":"https://api.github.com/repos/kubeflow/fairing/issues/319/events","html_url":"https://github.com/kubeflow/fairing/issues/319","id":469513995,"node_id":"MDU6SXNzdWU0Njk1MTM5OTU=","number":319,"title":"ConvertNotebookPreprocessorWithFire doesn't properly handle case where converted notebook exists","user":{"login":"jlewi","id":777219,"node_id":"MDQ6VXNlcjc3NzIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"labels":[{"id":1073158694,"node_id":"MDU6TGFiZWwxMDczMTU4Njk0","url":"https://api.github.com/repos/kubeflow/fairing/labels/kind/bug","name":"kind/bug","color":"fc2515","default":false},{"id":1044532058,"node_id":"MDU6TGFiZWwxMDQ0NTMyMDU4","url":"https://api.github.com/repos/kubeflow/fairing/labels/priority/p0","name":"priority/p0","color":"db1203","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-18T00:35:07Z","updated_at":"2019-07-18T00:35:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"/kind bug\r\n\r\n**What steps did you take and what happened:**\r\n[A clear and concise description of what the bug is.]\r\n\r\n* Run through the [example](https://github.com/kubeflow/examples/blob/master/xgboost_synthetic/build-train-deploy.ipynb)\r\n\r\n* The first time you run it; the file `build-train-deploy.py` is created\r\n* The second time you run it we trigger this [code path](https://github.com/kubeflow/fairing/blob/f43a4a3675e43cb736b690a07f22490b54523867/fairing/preprocessors/converted_notebook.py#L126)\r\n* Since the file `build-train-deploy.py` exists we end up trying to create a temporary file\r\n* There is a bug in this code and \"converted_notebook\" ends up getting set to the empty file which is problematic\r\n\r\nWe should fix this\r\n\r\n* We should avoid avoid triggering a different code path if you run multiple times; that leads to hard to catch bugs\r\n* Instead lets just overwrite the file \r\n* If we want to guard against accidental rewriting we should add a flag to not overwrite it if it already exists\r\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/fairing/issues/comments/512619009","html_url":"https://github.com/kubeflow/fairing/issues/319#issuecomment-512619009","issue_url":"https://api.github.com/repos/kubeflow/fairing/issues/319","id":512619009,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMjYxOTAwOQ==","user":{"login":"jlewi","id":777219,"node_id":"MDQ6VXNlcjc3NzIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"created_at":"2019-07-18T00:35:36Z","updated_at":"2019-07-18T00:35:36Z","author_association":"CONTRIBUTOR","body":"P0 because we'd like this to be fixed in time to use in a release blog post."}}
{"actor":{"display_login":"jlewi"}}