{"action":"created","comment":{"url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/comments/312762607","pull_request_review_id":273488731,"id":312762607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjc2MjYwNw==","diff_hunk":"@@ -26,14 +26,14 @@ The two arguments this method take are:\n | Name | Value | Requirement | Description |\n | ---- | ----- | ----------- | ----------- |\n | ch | string | Required | The character to trigger the autocompleter. |\n-| fetch |  (pattern: string, maxResults: number) => Promise<AutocompleterItem[]> | Required | A function that is passed the current matched text pattern and the maximum number of expected results. The function should return a promise containing matching results. |\n+| fetch |  (pattern: string, maxResults: number, fetchOptions: Record<string, any>) => Promise<AutocompleterItem[]> | Required | A function that is passed the current matched text pattern, the maximum number of expected results and any additional fetch options. The function should return a promise containing matching results. |","path":"ui-components/autocompleter.md","position":5,"original_position":5,"commit_id":"7566ad91c1dc6110fd235acc1b6ee1fe90a809a1","original_commit_id":"7566ad91c1dc6110fd235acc1b6ee1fe90a809a1","user":{"login":"blackcathikari","id":4361382,"node_id":"MDQ6VXNlcjQzNjEzODI=","avatar_url":"https://avatars2.githubusercontent.com/u/4361382?v=4","gravatar_id":"","url":"https://api.github.com/users/blackcathikari","html_url":"https://github.com/blackcathikari","followers_url":"https://api.github.com/users/blackcathikari/followers","following_url":"https://api.github.com/users/blackcathikari/following{/other_user}","gists_url":"https://api.github.com/users/blackcathikari/gists{/gist_id}","starred_url":"https://api.github.com/users/blackcathikari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackcathikari/subscriptions","organizations_url":"https://api.github.com/users/blackcathikari/orgs","repos_url":"https://api.github.com/users/blackcathikari/repos","events_url":"https://api.github.com/users/blackcathikari/events{/privacy}","received_events_url":"https://api.github.com/users/blackcathikari/received_events","type":"User","site_admin":false},"body":"Reading the following paragraphs, is fetchOptions optional? Or are users meant to always pass something, even if it's an empty object? I'm not quite clear on that.\r\n\r\nWe also don't have a standard way of marking optional args from memory though so not sure how we'd even do that...","created_at":"2019-08-12T00:44:08Z","updated_at":"2019-08-12T00:47:25Z","html_url":"https://github.com/tinymce/tinymce-docs/pull/1158#discussion_r312762607","pull_request_url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/comments/312762607"},"html":{"href":"https://github.com/tinymce/tinymce-docs/pull/1158#discussion_r312762607"},"pull_request":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158"}}},"pull_request":{"url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158","id":305374103,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1Mzc0MTAz","html_url":"https://github.com/tinymce/tinymce-docs/pull/1158","diff_url":"https://github.com/tinymce/tinymce-docs/pull/1158.diff","patch_url":"https://github.com/tinymce/tinymce-docs/pull/1158.patch","issue_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues/1158","number":1158,"state":"open","locked":false,"title":"MENTIONS-17: Added new autocompleter API details","user":{"login":"lnewson","id":1575550,"node_id":"MDQ6VXNlcjE1NzU1NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1575550?v=4","gravatar_id":"","url":"https://api.github.com/users/lnewson","html_url":"https://github.com/lnewson","followers_url":"https://api.github.com/users/lnewson/followers","following_url":"https://api.github.com/users/lnewson/following{/other_user}","gists_url":"https://api.github.com/users/lnewson/gists{/gist_id}","starred_url":"https://api.github.com/users/lnewson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnewson/subscriptions","organizations_url":"https://api.github.com/users/lnewson/orgs","repos_url":"https://api.github.com/users/lnewson/repos","events_url":"https://api.github.com/users/lnewson/events{/privacy}","received_events_url":"https://api.github.com/users/lnewson/received_events","type":"User","site_admin":false},"body":"Note: I haven't included the mentions specific changes in this, as it might be released separately to 5.0.14.","created_at":"2019-08-08T01:24:31Z","updated_at":"2019-08-12T00:47:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd2af978b507e599d417c8f36a52930872aeb3c5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jhaines","id":2252638,"node_id":"MDQ6VXNlcjIyNTI2Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/2252638?v=4","gravatar_id":"","url":"https://api.github.com/users/jhaines","html_url":"https://github.com/jhaines","followers_url":"https://api.github.com/users/jhaines/followers","following_url":"https://api.github.com/users/jhaines/following{/other_user}","gists_url":"https://api.github.com/users/jhaines/gists{/gist_id}","starred_url":"https://api.github.com/users/jhaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhaines/subscriptions","organizations_url":"https://api.github.com/users/jhaines/orgs","repos_url":"https://api.github.com/users/jhaines/repos","events_url":"https://api.github.com/users/jhaines/events{/privacy}","received_events_url":"https://api.github.com/users/jhaines/received_events","type":"User","site_admin":false},{"login":"tylerkelly13","id":14833627,"node_id":"MDQ6VXNlcjE0ODMzNjI3","avatar_url":"https://avatars2.githubusercontent.com/u/14833627?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerkelly13","html_url":"https://github.com/tylerkelly13","followers_url":"https://api.github.com/users/tylerkelly13/followers","following_url":"https://api.github.com/users/tylerkelly13/following{/other_user}","gists_url":"https://api.github.com/users/tylerkelly13/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerkelly13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerkelly13/subscriptions","organizations_url":"https://api.github.com/users/tylerkelly13/orgs","repos_url":"https://api.github.com/users/tylerkelly13/repos","events_url":"https://api.github.com/users/tylerkelly13/events{/privacy}","received_events_url":"https://api.github.com/users/tylerkelly13/received_events","type":"User","site_admin":false},{"login":"EkimChau","id":39354587,"node_id":"MDQ6VXNlcjM5MzU0NTg3","avatar_url":"https://avatars1.githubusercontent.com/u/39354587?v=4","gravatar_id":"","url":"https://api.github.com/users/EkimChau","html_url":"https://github.com/EkimChau","followers_url":"https://api.github.com/users/EkimChau/followers","following_url":"https://api.github.com/users/EkimChau/following{/other_user}","gists_url":"https://api.github.com/users/EkimChau/gists{/gist_id}","starred_url":"https://api.github.com/users/EkimChau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EkimChau/subscriptions","organizations_url":"https://api.github.com/users/EkimChau/orgs","repos_url":"https://api.github.com/users/EkimChau/repos","events_url":"https://api.github.com/users/EkimChau/events{/privacy}","received_events_url":"https://api.github.com/users/EkimChau/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues/1158/comments","statuses_url":"https://api.github.com/repos/tinymce/tinymce-docs/statuses/7566ad91c1dc6110fd235acc1b6ee1fe90a809a1","head":{"label":"tinymce:feature/MENTIONS-17","ref":"feature/MENTIONS-17","sha":"7566ad91c1dc6110fd235acc1b6ee1fe90a809a1","user":{"login":"tinymce","id":119815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTgxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/119815?v=4","gravatar_id":"","url":"https://api.github.com/users/tinymce","html_url":"https://github.com/tinymce","followers_url":"https://api.github.com/users/tinymce/followers","following_url":"https://api.github.com/users/tinymce/following{/other_user}","gists_url":"https://api.github.com/users/tinymce/gists{/gist_id}","starred_url":"https://api.github.com/users/tinymce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinymce/subscriptions","organizations_url":"https://api.github.com/users/tinymce/orgs","repos_url":"https://api.github.com/users/tinymce/repos","events_url":"https://api.github.com/users/tinymce/events{/privacy}","received_events_url":"https://api.github.com/users/tinymce/received_events","type":"Organization","site_admin":false},"repo":{"id":43335308,"node_id":"MDEwOlJlcG9zaXRvcnk0MzMzNTMwOA==","name":"tinymce-docs","full_name":"tinymce/tinymce-docs","private":false,"owner":{"login":"tinymce","id":119815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTgxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/119815?v=4","gravatar_id":"","url":"https://api.github.com/users/tinymce","html_url":"https://github.com/tinymce","followers_url":"https://api.github.com/users/tinymce/followers","following_url":"https://api.github.com/users/tinymce/following{/other_user}","gists_url":"https://api.github.com/users/tinymce/gists{/gist_id}","starred_url":"https://api.github.com/users/tinymce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinymce/subscriptions","organizations_url":"https://api.github.com/users/tinymce/orgs","repos_url":"https://api.github.com/users/tinymce/repos","events_url":"https://api.github.com/users/tinymce/events{/privacy}","received_events_url":"https://api.github.com/users/tinymce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tinymce/tinymce-docs","description":"TinyMCE Documentation","fork":false,"url":"https://api.github.com/repos/tinymce/tinymce-docs","forks_url":"https://api.github.com/repos/tinymce/tinymce-docs/forks","keys_url":"https://api.github.com/repos/tinymce/tinymce-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinymce/tinymce-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinymce/tinymce-docs/teams","hooks_url":"https://api.github.com/repos/tinymce/tinymce-docs/hooks","issue_events_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues/events{/number}","events_url":"https://api.github.com/repos/tinymce/tinymce-docs/events","assignees_url":"https://api.github.com/repos/tinymce/tinymce-docs/assignees{/user}","branches_url":"https://api.github.com/repos/tinymce/tinymce-docs/branches{/branch}","tags_url":"https://api.github.com/repos/tinymce/tinymce-docs/tags","blobs_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinymce/tinymce-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/tinymce/tinymce-docs/languages","stargazers_url":"https://api.github.com/repos/tinymce/tinymce-docs/stargazers","contributors_url":"https://api.github.com/repos/tinymce/tinymce-docs/contributors","subscribers_url":"https://api.github.com/repos/tinymce/tinymce-docs/subscribers","subscription_url":"https://api.github.com/repos/tinymce/tinymce-docs/subscription","commits_url":"https://api.github.com/repos/tinymce/tinymce-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinymce/tinymce-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinymce/tinymce-docs/contents/{+path}","compare_url":"https://api.github.com/repos/tinymce/tinymce-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinymce/tinymce-docs/merges","archive_url":"https://api.github.com/repos/tinymce/tinymce-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinymce/tinymce-docs/downloads","issues_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues{/number}","pulls_url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/tinymce/tinymce-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/tinymce/tinymce-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinymce/tinymce-docs/labels{/name}","releases_url":"https://api.github.com/repos/tinymce/tinymce-docs/releases{/id}","deployments_url":"https://api.github.com/repos/tinymce/tinymce-docs/deployments","created_at":"2015-09-29T00:33:45Z","updated_at":"2019-08-09T02:58:57Z","pushed_at":"2019-08-09T02:58:56Z","git_url":"git://github.com/tinymce/tinymce-docs.git","ssh_url":"git@github.com:tinymce/tinymce-docs.git","clone_url":"https://github.com/tinymce/tinymce-docs.git","svn_url":"https://github.com/tinymce/tinymce-docs","homepage":"https://www.tiny.cloud/docs/","size":29538,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":56,"license":null,"forks":191,"open_issues":56,"watchers":49,"default_branch":"develop"}},"base":{"label":"tinymce:develop","ref":"develop","sha":"49d89b1a7a923d1b7529b9f8ecf44a973b7ef057","user":{"login":"tinymce","id":119815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTgxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/119815?v=4","gravatar_id":"","url":"https://api.github.com/users/tinymce","html_url":"https://github.com/tinymce","followers_url":"https://api.github.com/users/tinymce/followers","following_url":"https://api.github.com/users/tinymce/following{/other_user}","gists_url":"https://api.github.com/users/tinymce/gists{/gist_id}","starred_url":"https://api.github.com/users/tinymce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinymce/subscriptions","organizations_url":"https://api.github.com/users/tinymce/orgs","repos_url":"https://api.github.com/users/tinymce/repos","events_url":"https://api.github.com/users/tinymce/events{/privacy}","received_events_url":"https://api.github.com/users/tinymce/received_events","type":"Organization","site_admin":false},"repo":{"id":43335308,"node_id":"MDEwOlJlcG9zaXRvcnk0MzMzNTMwOA==","name":"tinymce-docs","full_name":"tinymce/tinymce-docs","private":false,"owner":{"login":"tinymce","id":119815,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTgxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/119815?v=4","gravatar_id":"","url":"https://api.github.com/users/tinymce","html_url":"https://github.com/tinymce","followers_url":"https://api.github.com/users/tinymce/followers","following_url":"https://api.github.com/users/tinymce/following{/other_user}","gists_url":"https://api.github.com/users/tinymce/gists{/gist_id}","starred_url":"https://api.github.com/users/tinymce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinymce/subscriptions","organizations_url":"https://api.github.com/users/tinymce/orgs","repos_url":"https://api.github.com/users/tinymce/repos","events_url":"https://api.github.com/users/tinymce/events{/privacy}","received_events_url":"https://api.github.com/users/tinymce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tinymce/tinymce-docs","description":"TinyMCE Documentation","fork":false,"url":"https://api.github.com/repos/tinymce/tinymce-docs","forks_url":"https://api.github.com/repos/tinymce/tinymce-docs/forks","keys_url":"https://api.github.com/repos/tinymce/tinymce-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinymce/tinymce-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinymce/tinymce-docs/teams","hooks_url":"https://api.github.com/repos/tinymce/tinymce-docs/hooks","issue_events_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues/events{/number}","events_url":"https://api.github.com/repos/tinymce/tinymce-docs/events","assignees_url":"https://api.github.com/repos/tinymce/tinymce-docs/assignees{/user}","branches_url":"https://api.github.com/repos/tinymce/tinymce-docs/branches{/branch}","tags_url":"https://api.github.com/repos/tinymce/tinymce-docs/tags","blobs_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinymce/tinymce-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/tinymce/tinymce-docs/languages","stargazers_url":"https://api.github.com/repos/tinymce/tinymce-docs/stargazers","contributors_url":"https://api.github.com/repos/tinymce/tinymce-docs/contributors","subscribers_url":"https://api.github.com/repos/tinymce/tinymce-docs/subscribers","subscription_url":"https://api.github.com/repos/tinymce/tinymce-docs/subscription","commits_url":"https://api.github.com/repos/tinymce/tinymce-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinymce/tinymce-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinymce/tinymce-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinymce/tinymce-docs/contents/{+path}","compare_url":"https://api.github.com/repos/tinymce/tinymce-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinymce/tinymce-docs/merges","archive_url":"https://api.github.com/repos/tinymce/tinymce-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinymce/tinymce-docs/downloads","issues_url":"https://api.github.com/repos/tinymce/tinymce-docs/issues{/number}","pulls_url":"https://api.github.com/repos/tinymce/tinymce-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/tinymce/tinymce-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/tinymce/tinymce-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinymce/tinymce-docs/labels{/name}","releases_url":"https://api.github.com/repos/tinymce/tinymce-docs/releases{/id}","deployments_url":"https://api.github.com/repos/tinymce/tinymce-docs/deployments","created_at":"2015-09-29T00:33:45Z","updated_at":"2019-08-09T02:58:57Z","pushed_at":"2019-08-09T02:58:56Z","git_url":"git://github.com/tinymce/tinymce-docs.git","ssh_url":"git@github.com:tinymce/tinymce-docs.git","clone_url":"https://github.com/tinymce/tinymce-docs.git","svn_url":"https://github.com/tinymce/tinymce-docs","homepage":"https://www.tiny.cloud/docs/","size":29538,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":56,"license":null,"forks":191,"open_issues":56,"watchers":49,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158"},"html":{"href":"https://github.com/tinymce/tinymce-docs/pull/1158"},"issue":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/issues/1158"},"comments":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/tinymce/tinymce-docs/statuses/7566ad91c1dc6110fd235acc1b6ee1fe90a809a1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blackcathikari"}}