{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/337018565","pull_request_review_id":304539611,"id":337018565,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzAxODU2NQ==","diff_hunk":"@@ -1278,12 +1334,19 @@ and columns are matched by order of appearance. In this case `row` must contain\n the same number of elements as the number of columns in `df`.\n \n If `row` is a `DataFrameRow`, `NamedTuple` or `AbstractDict` then\n-values in `row` are matched to columns in `df` based on names (order is ignored).\n-`row` may contain more columns than `df` if `columns=:intersect`\n-(this is currently the default, but will change in the future), but all column names\n-that are present in `df` must be present in `row`.\n-Otherwise if `columns=:equal` then `row` must contain exactly the same columns as `df`\n-(but possibly in a different order).\n+values in `row` are matched to columns in `df` based on names. The exact behavior\n+depends on `cols` argument value in the following way:\n+* If `cols=:equal` (this is currently the default, but will change to `:identical` in the future)\n+  then `row` must contain exactly the same columns as `df` (but possibly in a different order).\n+* If `cols=:identical` then `row` must contain the same columns in the same order\n+  (this option is the same as `:equal` if `row` is an `AbstractDict`).\n+* If `cols=:intersect` then `row` may contain more columns than `df`,\n+  but all column names that are present in `df` must be present in `row`.\n+* If `cols=:subset` then `push!` behaves like for `:intersect` but if some column\n+  is missing in `row` then a `missing` value is pushed to `df`.\n+* Finally, if `cols=:union` then `push!` behaves like for `:subset` with two additional changes:","path":"src/dataframe/dataframe.jl","position":131,"original_position":131,"commit_id":"755b96ee1ede1ce5bb2223e771f00100d50ddde8","original_commit_id":"755b96ee1ede1ce5bb2223e771f00100d50ddde8","user":{"login":"nalimilan","id":1120448,"node_id":"MDQ6VXNlcjExMjA0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1120448?v=4","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"\"behaves like for `:subset`\" is a bit hard to follow given that the latter is defined based on `:intersect`. :-) Maybe start the description from scratch?","created_at":"2019-10-21T13:31:49Z","updated_at":"2019-10-21T13:35:14Z","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1958#discussion_r337018565","pull_request_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments/337018565"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1958#discussion_r337018565"},"pull_request":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958","id":317503605,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NTAzNjA1","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1958","diff_url":"https://github.com/JuliaData/DataFrames.jl/pull/1958.diff","patch_url":"https://github.com/JuliaData/DataFrames.jl/pull/1958.patch","issue_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1958","number":1958,"state":"open","locked":false,"title":"Add :identical to cols kwarg in vcat and push!","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/JuliaData/DataFrames.jl/issues/1904\r\n\r\nI think we should make `vcat` and `push!` consistent with the name of kwarg. Should it be `cols` (now used in `vcat`) or `columns` (now used in `push!`). Any opinions?","created_at":"2019-09-13T22:38:14Z","updated_at":"2019-10-21T13:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a40d25d1e94128277a22976c02af2cbf48a8eb23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958/commits","review_comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958/comments","review_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1958/comments","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/755b96ee1ede1ce5bb2223e771f00100d50ddde8","head":{"label":"bkamins:vcat_push_identical","ref":"vcat_push_identical","sha":"755b96ee1ede1ce5bb2223e771f00100d50ddde8","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"repo":{"id":112845765,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI4NDU3NjU=","name":"DataFrames.jl","full_name":"bkamins/DataFrames.jl","private":false,"owner":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bkamins/DataFrames.jl","description":"Library for working with tabular data in Julia","fork":true,"url":"https://api.github.com/repos/bkamins/DataFrames.jl","forks_url":"https://api.github.com/repos/bkamins/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/bkamins/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkamins/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkamins/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/bkamins/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/bkamins/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/bkamins/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/bkamins/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/bkamins/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkamins/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/bkamins/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/bkamins/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/bkamins/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/bkamins/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/bkamins/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/bkamins/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkamins/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkamins/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkamins/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/bkamins/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkamins/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/bkamins/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkamins/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/bkamins/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/bkamins/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/bkamins/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/bkamins/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkamins/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/bkamins/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/bkamins/DataFrames.jl/deployments","created_at":"2017-12-02T13:50:44Z","updated_at":"2019-10-19T18:07:53Z","pushed_at":"2019-10-19T19:28:07Z","git_url":"git://github.com/bkamins/DataFrames.jl.git","ssh_url":"git@github.com:bkamins/DataFrames.jl.git","clone_url":"https://github.com/bkamins/DataFrames.jl.git","svn_url":"https://github.com/bkamins/DataFrames.jl","homepage":"","size":10608,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaData:master","ref":"master","sha":"85e4ce37ff873da18a3d45c8809420d1392389c8","user":{"login":"JuliaData","id":20142970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQyOTcw","avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"repo":{"id":4992873,"node_id":"MDEwOlJlcG9zaXRvcnk0OTkyODcz","name":"DataFrames.jl","full_name":"JuliaData/DataFrames.jl","private":false,"owner":{"login":"JuliaData","id":20142970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQyOTcw","avatar_url":"https://avatars3.githubusercontent.com/u/20142970?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaData","html_url":"https://github.com/JuliaData","followers_url":"https://api.github.com/users/JuliaData/followers","following_url":"https://api.github.com/users/JuliaData/following{/other_user}","gists_url":"https://api.github.com/users/JuliaData/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaData/subscriptions","organizations_url":"https://api.github.com/users/JuliaData/orgs","repos_url":"https://api.github.com/users/JuliaData/repos","events_url":"https://api.github.com/users/JuliaData/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaData/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaData/DataFrames.jl","description":"In-memory tabular data in Julia","fork":false,"url":"https://api.github.com/repos/JuliaData/DataFrames.jl","forks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/forks","keys_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/teams","hooks_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/events","assignees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/tags","blobs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/subscription","commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/merges","archive_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/downloads","issues_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/deployments","created_at":"2012-07-11T18:00:09Z","updated_at":"2019-10-19T18:06:28Z","pushed_at":"2019-10-20T05:03:39Z","git_url":"git://github.com/JuliaData/DataFrames.jl.git","ssh_url":"git@github.com:JuliaData/DataFrames.jl.git","clone_url":"https://github.com/JuliaData/DataFrames.jl.git","svn_url":"https://github.com/JuliaData/DataFrames.jl","homepage":"http://juliadata.github.io/DataFrames.jl/stable/","size":11433,"stargazers_count":685,"watchers_count":685,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":249,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":249,"open_issues":83,"watchers":685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958"},"html":{"href":"https://github.com/JuliaData/DataFrames.jl/pull/1958"},"issue":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1958"},"comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1958/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1958/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaData/DataFrames.jl/statuses/755b96ee1ede1ce5bb2223e771f00100d50ddde8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nalimilan"}}