{"action":"closed","number":1551,"pull_request":{"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/1551","id":243846286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQzODQ2Mjg2","html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/1551","diff_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/1551.diff","patch_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/1551.patch","issue_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/1551","number":1551,"state":"closed","locked":false,"title":"Use SipHash for cheap hashes in Graphene","user":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"body":"This PR replaces all calls to GetCheapHash with a 64 bit SipHash. Some of the SipHash setup was taken from work that was done on Compact Blocks by @TheBlueMatt. SipHashes are used only when graphene sender and receiver versions are both greater than or equal to 2.","created_at":"2019-01-10T22:06:20Z","updated_at":"2019-03-18T23:37:16Z","closed_at":"2019-03-18T23:37:16Z","merged_at":"2019-03-18T23:37:16Z","merge_commit_sha":"9bdd7950d7bca7e8a60e59b3e20df1f275ef65ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":932358142,"node_id":"MDU6TGFiZWw5MzIzNTgxNDI=","url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/labels/P2P","name":"P2P","color":"b9f733","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/1551/commits","review_comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/1551/comments","review_comment_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/1551/comments","statuses_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/statuses/4e75ff6c43811179e07932f718166233221e277e","head":{"label":"bissias:sip","ref":"sip","sha":"4e75ff6c43811179e07932f718166233221e277e","user":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"repo":{"id":111242924,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNDI5MjQ=","name":"BitcoinUnlimited","full_name":"bissias/BitcoinUnlimited","private":false,"owner":{"login":"bissias","id":1005112,"node_id":"MDQ6VXNlcjEwMDUxMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005112?v=4","gravatar_id":"","url":"https://api.github.com/users/bissias","html_url":"https://github.com/bissias","followers_url":"https://api.github.com/users/bissias/followers","following_url":"https://api.github.com/users/bissias/following{/other_user}","gists_url":"https://api.github.com/users/bissias/gists{/gist_id}","starred_url":"https://api.github.com/users/bissias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bissias/subscriptions","organizations_url":"https://api.github.com/users/bissias/orgs","repos_url":"https://api.github.com/users/bissias/repos","events_url":"https://api.github.com/users/bissias/events{/privacy}","received_events_url":"https://api.github.com/users/bissias/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bissias/BitcoinUnlimited","description":"Bitcoin Unlimited (Graphene)","fork":true,"url":"https://api.github.com/repos/bissias/BitcoinUnlimited","forks_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/forks","keys_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/teams","hooks_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/hooks","issue_events_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/issues/events{/number}","events_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/events","assignees_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/assignees{/user}","branches_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/branches{/branch}","tags_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/tags","blobs_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/refs{/sha}","trees_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/statuses/{sha}","languages_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/languages","stargazers_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/stargazers","contributors_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/contributors","subscribers_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/subscribers","subscription_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/subscription","commits_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/commits{/sha}","git_commits_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/git/commits{/sha}","comments_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/comments{/number}","issue_comment_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/issues/comments{/number}","contents_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/contents/{+path}","compare_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/merges","archive_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/downloads","issues_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/issues{/number}","pulls_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/pulls{/number}","milestones_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/milestones{/number}","notifications_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/labels{/name}","releases_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/releases{/id}","deployments_url":"https://api.github.com/repos/bissias/BitcoinUnlimited/deployments","created_at":"2017-11-18T22:02:51Z","updated_at":"2018-05-01T03:35:53Z","pushed_at":"2019-03-18T21:51:59Z","git_url":"git://github.com/bissias/BitcoinUnlimited.git","ssh_url":"git@github.com:bissias/BitcoinUnlimited.git","clone_url":"https://github.com/bissias/BitcoinUnlimited.git","svn_url":"https://github.com/bissias/BitcoinUnlimited","homepage":"http://www.bitcoinunlimited.info/download.html","size":97035,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"BitcoinCash"}},"base":{"label":"BitcoinUnlimited:dev","ref":"dev","sha":"53499fd9ca46601454940bba6a1a49804d538a94","user":{"login":"BitcoinUnlimited","id":14125627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTI1NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/14125627?v=4","gravatar_id":"","url":"https://api.github.com/users/BitcoinUnlimited","html_url":"https://github.com/BitcoinUnlimited","followers_url":"https://api.github.com/users/BitcoinUnlimited/followers","following_url":"https://api.github.com/users/BitcoinUnlimited/following{/other_user}","gists_url":"https://api.github.com/users/BitcoinUnlimited/gists{/gist_id}","starred_url":"https://api.github.com/users/BitcoinUnlimited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitcoinUnlimited/subscriptions","organizations_url":"https://api.github.com/users/BitcoinUnlimited/orgs","repos_url":"https://api.github.com/users/BitcoinUnlimited/repos","events_url":"https://api.github.com/users/BitcoinUnlimited/events{/privacy}","received_events_url":"https://api.github.com/users/BitcoinUnlimited/received_events","type":"Organization","site_admin":false},"repo":{"id":18613259,"node_id":"MDEwOlJlcG9zaXRvcnkxODYxMzI1OQ==","name":"BitcoinUnlimited","full_name":"BitcoinUnlimited/BitcoinUnlimited","private":false,"owner":{"login":"BitcoinUnlimited","id":14125627,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTI1NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/14125627?v=4","gravatar_id":"","url":"https://api.github.com/users/BitcoinUnlimited","html_url":"https://github.com/BitcoinUnlimited","followers_url":"https://api.github.com/users/BitcoinUnlimited/followers","following_url":"https://api.github.com/users/BitcoinUnlimited/following{/other_user}","gists_url":"https://api.github.com/users/BitcoinUnlimited/gists{/gist_id}","starred_url":"https://api.github.com/users/BitcoinUnlimited/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitcoinUnlimited/subscriptions","organizations_url":"https://api.github.com/users/BitcoinUnlimited/orgs","repos_url":"https://api.github.com/users/BitcoinUnlimited/repos","events_url":"https://api.github.com/users/BitcoinUnlimited/events{/privacy}","received_events_url":"https://api.github.com/users/BitcoinUnlimited/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited","description":"Bitcoin Unlimited integration/staging tree","fork":false,"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited","forks_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/forks","keys_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/teams","hooks_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/hooks","issue_events_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/events{/number}","events_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/events","assignees_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/assignees{/user}","branches_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/branches{/branch}","tags_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/tags","blobs_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/refs{/sha}","trees_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/statuses/{sha}","languages_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/languages","stargazers_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/stargazers","contributors_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/contributors","subscribers_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/subscribers","subscription_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/subscription","commits_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/commits{/sha}","git_commits_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/git/commits{/sha}","comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/comments{/number}","issue_comment_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/comments{/number}","contents_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/contents/{+path}","compare_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/merges","archive_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/downloads","issues_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues{/number}","pulls_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls{/number}","milestones_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/milestones{/number}","notifications_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/labels{/name}","releases_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/releases{/id}","deployments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/deployments","created_at":"2014-04-09T21:03:00Z","updated_at":"2019-03-18T03:05:37Z","pushed_at":"2019-03-18T23:37:16Z","git_url":"git://github.com/BitcoinUnlimited/BitcoinUnlimited.git","ssh_url":"git@github.com:BitcoinUnlimited/BitcoinUnlimited.git","clone_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited.git","svn_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited","homepage":"http://www.bitcoinunlimited.info/download.html","size":71600,"stargazers_count":399,"watchers_count":399,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":181,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":181,"open_issues":89,"watchers":399,"default_branch":"release"}},"_links":{"self":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/1551"},"html":{"href":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/1551"},"issue":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/1551"},"comments":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/1551/comments"},"review_comments":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/1551/comments"},"review_comment":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/1551/commits"},"statuses":{"href":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/statuses/4e75ff6c43811179e07932f718166233221e277e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gandrewstone","id":89979,"node_id":"MDQ6VXNlcjg5OTc5","avatar_url":"https://avatars3.githubusercontent.com/u/89979?v=4","gravatar_id":"","url":"https://api.github.com/users/gandrewstone","html_url":"https://github.com/gandrewstone","followers_url":"https://api.github.com/users/gandrewstone/followers","following_url":"https://api.github.com/users/gandrewstone/following{/other_user}","gists_url":"https://api.github.com/users/gandrewstone/gists{/gist_id}","starred_url":"https://api.github.com/users/gandrewstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandrewstone/subscriptions","organizations_url":"https://api.github.com/users/gandrewstone/orgs","repos_url":"https://api.github.com/users/gandrewstone/repos","events_url":"https://api.github.com/users/gandrewstone/events{/privacy}","received_events_url":"https://api.github.com/users/gandrewstone/received_events","type":"User","site_admin":false},"comments":6,"review_comments":16,"maintainer_can_modify":false,"commits":13,"additions":179,"deletions":35,"changed_files":8}}
{"actor":{"display_login":"gandrewstone"}}