{"action":"created","comment":{"url":"https://api.github.com/repos/miekg/dns/pulls/comments/330881880","pull_request_review_id":296665875,"id":330881880,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDg4MTg4MA==","diff_hunk":"@@ -204,3 +204,29 @@ $GENERATE 32-158 dhcp-${-32,4,d} A 10.0.0.$\n \t\t}\n \t}\n }\n+\n+\n+\n+func TestCrasherString(t *testing.T) {\n+\ttests := []struct{\n+\tin  string\n+\terr string\n+}{\n+\t\t{\"$GENERATE 0-300103\\\"$$GENERATE 2-2\", \"dns: Expect blank after $GENERATE range: \\\"\\\\\\\"\\\" at line: 1:19\"},\n+\t\t{\"$GENERATE 0-5414137360\", \"dns: Expect blank after $GENERATE range: \\\"\\\\n\\\" at line: 1:22\"},\n+\t\t{\"$GENERATE 0-5414137360\", \"dns: Expect blank after $GENERATE range: \\\"\\\\n\\\" at line: 1:22\"},\n+\t\t{\"$GENERATE       11522-3668518066406258\", \"dns: Expect blank after $GENERATE range: \\\"\\\\n\\\" at line: 1:38\"},","path":"generate_test.go","position":null,"original_position":15,"commit_id":"c8812b501d3ed786fd14be61e605c1b388fccfbe","original_commit_id":"aba8b95b81c507a8559cda35d0261df841660ee6","user":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"body":"ok, i'll add something. What *is* a sane upper limit? Does bind9 have one?","created_at":"2019-10-03T06:37:19Z","updated_at":"2019-10-03T06:37:19Z","html_url":"https://github.com/miekg/dns/pull/1016#discussion_r330881880","pull_request_url":"https://api.github.com/repos/miekg/dns/pulls/1016","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments/330881880"},"html":{"href":"https://github.com/miekg/dns/pull/1016#discussion_r330881880"},"pull_request":{"href":"https://api.github.com/repos/miekg/dns/pulls/1016"}},"in_reply_to_id":330757041},"pull_request":{"url":"https://api.github.com/repos/miekg/dns/pulls/1016","id":323930047,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzOTMwMDQ3","html_url":"https://github.com/miekg/dns/pull/1016","diff_url":"https://github.com/miekg/dns/pull/1016.diff","patch_url":"https://github.com/miekg/dns/pull/1016.patch","issue_url":"https://api.github.com/repos/miekg/dns/issues/1016","number":1016,"state":"open","locked":false,"title":"[fuzz] Fix crashes when parsing GENERATE","user":{"login":"chantra","id":24572,"node_id":"MDQ6VXNlcjI0NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/24572?v=4","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"body":"Running the fuzzer on NewRR, some crashes came up that could be\r\nprevented by checking that the token after the range is a Blank.\r\nThis diff checks that and return an error when the blank is not found.","created_at":"2019-10-02T20:25:58Z","updated_at":"2019-10-03T06:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce43bc93f9f58e6f5d903ac12dd8027fe012ed93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/miekg/dns/pulls/1016/commits","review_comments_url":"https://api.github.com/repos/miekg/dns/pulls/1016/comments","review_comment_url":"https://api.github.com/repos/miekg/dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miekg/dns/issues/1016/comments","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/c8812b501d3ed786fd14be61e605c1b388fccfbe","head":{"label":"chantra:newrr_crashers","ref":"newrr_crashers","sha":"c8812b501d3ed786fd14be61e605c1b388fccfbe","user":{"login":"chantra","id":24572,"node_id":"MDQ6VXNlcjI0NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/24572?v=4","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"repo":{"id":125138539,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxMzg1Mzk=","name":"dns","full_name":"chantra/dns","private":false,"owner":{"login":"chantra","id":24572,"node_id":"MDQ6VXNlcjI0NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/24572?v=4","gravatar_id":"","url":"https://api.github.com/users/chantra","html_url":"https://github.com/chantra","followers_url":"https://api.github.com/users/chantra/followers","following_url":"https://api.github.com/users/chantra/following{/other_user}","gists_url":"https://api.github.com/users/chantra/gists{/gist_id}","starred_url":"https://api.github.com/users/chantra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chantra/subscriptions","organizations_url":"https://api.github.com/users/chantra/orgs","repos_url":"https://api.github.com/users/chantra/repos","events_url":"https://api.github.com/users/chantra/events{/privacy}","received_events_url":"https://api.github.com/users/chantra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chantra/dns","description":"DNS library in Go","fork":true,"url":"https://api.github.com/repos/chantra/dns","forks_url":"https://api.github.com/repos/chantra/dns/forks","keys_url":"https://api.github.com/repos/chantra/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chantra/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chantra/dns/teams","hooks_url":"https://api.github.com/repos/chantra/dns/hooks","issue_events_url":"https://api.github.com/repos/chantra/dns/issues/events{/number}","events_url":"https://api.github.com/repos/chantra/dns/events","assignees_url":"https://api.github.com/repos/chantra/dns/assignees{/user}","branches_url":"https://api.github.com/repos/chantra/dns/branches{/branch}","tags_url":"https://api.github.com/repos/chantra/dns/tags","blobs_url":"https://api.github.com/repos/chantra/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chantra/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chantra/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/chantra/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chantra/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/chantra/dns/languages","stargazers_url":"https://api.github.com/repos/chantra/dns/stargazers","contributors_url":"https://api.github.com/repos/chantra/dns/contributors","subscribers_url":"https://api.github.com/repos/chantra/dns/subscribers","subscription_url":"https://api.github.com/repos/chantra/dns/subscription","commits_url":"https://api.github.com/repos/chantra/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/chantra/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/chantra/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/chantra/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/chantra/dns/contents/{+path}","compare_url":"https://api.github.com/repos/chantra/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chantra/dns/merges","archive_url":"https://api.github.com/repos/chantra/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chantra/dns/downloads","issues_url":"https://api.github.com/repos/chantra/dns/issues{/number}","pulls_url":"https://api.github.com/repos/chantra/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/chantra/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/chantra/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chantra/dns/labels{/name}","releases_url":"https://api.github.com/repos/chantra/dns/releases{/id}","deployments_url":"https://api.github.com/repos/chantra/dns/deployments","created_at":"2018-03-14T01:42:06Z","updated_at":"2018-03-14T01:42:08Z","pushed_at":"2019-10-02T23:15:07Z","git_url":"git://github.com/chantra/dns.git","ssh_url":"git@github.com:chantra/dns.git","clone_url":"https://github.com/chantra/dns.git","svn_url":"https://github.com/chantra/dns","homepage":"https://miek.nl/2014/august/16/go-dns-package","size":16514,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miekg:master","ref":"master","sha":"1208fbdde0ad3326de82ac4a8f53058d480ed228","user":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"repo":{"id":815644,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU2NDQ=","name":"dns","full_name":"miekg/dns","private":false,"owner":{"login":"miekg","id":353371,"node_id":"MDQ6VXNlcjM1MzM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/353371?v=4","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/miekg/dns","description":"DNS library in Go","fork":false,"url":"https://api.github.com/repos/miekg/dns","forks_url":"https://api.github.com/repos/miekg/dns/forks","keys_url":"https://api.github.com/repos/miekg/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miekg/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miekg/dns/teams","hooks_url":"https://api.github.com/repos/miekg/dns/hooks","issue_events_url":"https://api.github.com/repos/miekg/dns/issues/events{/number}","events_url":"https://api.github.com/repos/miekg/dns/events","assignees_url":"https://api.github.com/repos/miekg/dns/assignees{/user}","branches_url":"https://api.github.com/repos/miekg/dns/branches{/branch}","tags_url":"https://api.github.com/repos/miekg/dns/tags","blobs_url":"https://api.github.com/repos/miekg/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miekg/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miekg/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/miekg/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/miekg/dns/languages","stargazers_url":"https://api.github.com/repos/miekg/dns/stargazers","contributors_url":"https://api.github.com/repos/miekg/dns/contributors","subscribers_url":"https://api.github.com/repos/miekg/dns/subscribers","subscription_url":"https://api.github.com/repos/miekg/dns/subscription","commits_url":"https://api.github.com/repos/miekg/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/miekg/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/miekg/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/miekg/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/miekg/dns/contents/{+path}","compare_url":"https://api.github.com/repos/miekg/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miekg/dns/merges","archive_url":"https://api.github.com/repos/miekg/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miekg/dns/downloads","issues_url":"https://api.github.com/repos/miekg/dns/issues{/number}","pulls_url":"https://api.github.com/repos/miekg/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/miekg/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/miekg/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miekg/dns/labels{/name}","releases_url":"https://api.github.com/repos/miekg/dns/releases{/id}","deployments_url":"https://api.github.com/repos/miekg/dns/deployments","created_at":"2010-08-03T21:56:23Z","updated_at":"2019-10-03T06:36:30Z","pushed_at":"2019-10-03T06:36:28Z","git_url":"git://github.com/miekg/dns.git","ssh_url":"git@github.com:miekg/dns.git","clone_url":"https://github.com/miekg/dns.git","svn_url":"https://github.com/miekg/dns","homepage":"https://miek.nl/2014/august/16/go-dns-package","size":16496,"stargazers_count":3954,"watchers_count":3954,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":659,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":659,"open_issues":26,"watchers":3954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/1016"},"html":{"href":"https://github.com/miekg/dns/pull/1016"},"issue":{"href":"https://api.github.com/repos/miekg/dns/issues/1016"},"comments":{"href":"https://api.github.com/repos/miekg/dns/issues/1016/comments"},"review_comments":{"href":"https://api.github.com/repos/miekg/dns/pulls/1016/comments"},"review_comment":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miekg/dns/pulls/1016/commits"},"statuses":{"href":"https://api.github.com/repos/miekg/dns/statuses/c8812b501d3ed786fd14be61e605c1b388fccfbe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"miekg"}}