{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/34953","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/34953/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/34953/comments","events_url":"https://api.github.com/repos/golang/go/issues/34953/events","html_url":"https://github.com/golang/go/issues/34953","id":508505740,"node_id":"MDU6SXNzdWU1MDg1MDU3NDA=","number":34953,"title":"cmd/go: timestamp of files in module archive unset","user":{"login":"klingtnet","id":1538057,"node_id":"MDQ6VXNlcjE1MzgwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1538057?v=4","gravatar_id":"","url":"https://api.github.com/users/klingtnet","html_url":"https://github.com/klingtnet","followers_url":"https://api.github.com/users/klingtnet/followers","following_url":"https://api.github.com/users/klingtnet/following{/other_user}","gists_url":"https://api.github.com/users/klingtnet/gists{/gist_id}","starred_url":"https://api.github.com/users/klingtnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klingtnet/subscriptions","organizations_url":"https://api.github.com/users/klingtnet/orgs","repos_url":"https://api.github.com/users/klingtnet/repos","events_url":"https://api.github.com/users/klingtnet/events{/privacy}","received_events_url":"https://api.github.com/users/klingtnet/received_events","type":"User","site_admin":false},"labels":[{"id":503763046,"node_id":"MDU6TGFiZWw1MDM3NjMwNDY=","url":"https://api.github.com/repos/golang/go/labels/GoCommand","name":"GoCommand","color":"006b75","default":false},{"id":373402289,"node_id":"MDU6TGFiZWwzNzM0MDIyODk=","url":"https://api.github.com/repos/golang/go/labels/NeedsInvestigation","name":"NeedsInvestigation","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2019-10-17T14:13:15Z","updated_at":"2019-10-21T15:55:08Z","closed_at":null,"author_association":"NONE","body":"<!-- Please answer these questions before submitting your issue. Thanks! -->\r\n\r\n### What version of Go are you using (`go version`)?\r\n\r\n<pre>\r\n$ go version\r\ngo version go1.13.1 linux/amd64\r\n</pre>\r\n\r\n### Does this issue reproduce with the latest release?\r\n\r\nProbably.\r\n\r\n### What operating system and processor architecture are you using (`go env`)?\r\n\r\n<details><summary><code>go env</code> Output</summary><br><pre>\r\n$ go env\r\nGO111MODULE=\"\"\r\nGOARCH=\"amd64\"\r\nGOBIN=\"\"\r\nGOCACHE=\"/home/alinz/.cache/go-build\"\r\nGOENV=\"/home/alinz/.config/go/env\"\r\nGOEXE=\"\"\r\nGOFLAGS=\"\"\r\nGOHOSTARCH=\"amd64\"\r\nGOHOSTOS=\"linux\"\r\nGONOPROXY=\"\"\r\nGONOSUMDB=\"\"\r\nGOOS=\"linux\"\r\nGOPATH=\"/home/alinz/.go\"\r\nGOPRIVATE=\"\"\r\nGOPROXY=\"https://proxy.golang.org,direct\"\r\nGOROOT=\"/usr/lib/go\"\r\nGOSUMDB=\"off\"\r\nGOTMPDIR=\"\"\r\nGOTOOLDIR=\"/usr/lib/go/pkg/tool/linux_amd64\"\r\nGCCGO=\"gccgo\"\r\nAR=\"ar\"\r\nCC=\"gcc\"\r\nCXX=\"g++\"\r\nCGO_ENABLED=\"1\"\r\nGOMOD=\"/home/alinz/code/gogitlabproxy/go.mod\"\r\nCGO_CFLAGS=\"-g -O2\"\r\nCGO_CPPFLAGS=\"\"\r\nCGO_CXXFLAGS=\"-g -O2\"\r\nCGO_FFLAGS=\"-g -O2\"\r\nCGO_LDFLAGS=\"-g -O2\"\r\nPKG_CONFIG=\"pkg-config\"\r\nGOGCCFLAGS=\"-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build916870041=/tmp/go-build -gno-record-gcc-switches\"\r\n</pre></details>\r\n\r\n### What did you do?\r\n\r\n<!--\r\nIf possible, provide a recipe for reproducing the error.\r\nA complete runnable program is good.\r\nA link on play.golang.org is best.\r\n-->\r\n\r\nI am writing a custom module proxy at the moment and while testing equality of the zipped module with the output of `proxy.golang.org` I noticed that the official proxy does not set the timestamp for the files in the archive, i.e. they are all dated `Nov 30  1979`.\r\nIs this the expected behavior?\r\n\r\n### What did you expect to see?\r\n\r\nThe actual file timestamps, i.e. the files in the archive should have the same timestamp as their source in the git repository.\r\n\r\n### What did you see instead?\r\n\r\n```sh\r\n$ curl -s https://proxy.golang.org/github.com/pkg/errors/@v/v0.8.1.zip | bsdtar -ztvf-\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/.gitignore\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/.travis.yml\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/LICENSE\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/README.md\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/appveyor.yml\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/bench_test.go\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/errors.go\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/errors_test.go\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/example_test.go\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/format_test.go\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/stack.go\r\n-rw-rw-r--  0 0      0           0 Nov 30  1979 github.com/pkg/errors@v0.8.1/stack_test.go\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/544580646","html_url":"https://github.com/golang/go/issues/34953#issuecomment-544580646","issue_url":"https://api.github.com/repos/golang/go/issues/34953","id":544580646,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NDU4MDY0Ng==","user":{"login":"bcmills","id":5200974,"node_id":"MDQ6VXNlcjUyMDA5NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5200974?v=4","gravatar_id":"","url":"https://api.github.com/users/bcmills","html_url":"https://github.com/bcmills","followers_url":"https://api.github.com/users/bcmills/followers","following_url":"https://api.github.com/users/bcmills/following{/other_user}","gists_url":"https://api.github.com/users/bcmills/gists{/gist_id}","starred_url":"https://api.github.com/users/bcmills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcmills/subscriptions","organizations_url":"https://api.github.com/users/bcmills/orgs","repos_url":"https://api.github.com/users/bcmills/repos","events_url":"https://api.github.com/users/bcmills/events{/privacy}","received_events_url":"https://api.github.com/users/bcmills/received_events","type":"User","site_admin":false},"created_at":"2019-10-21T15:55:08Z","updated_at":"2019-10-21T15:55:08Z","author_association":"MEMBER","body":"> It would change the SHA-256 hash of generated zip files. We haven't promised those are stable, but changing them would probably surprise some people.\r\n\r\nThere is a reason the hash in the `go.sum` file is on the file contents and not the zipfile. 😉"}}
{"actor":{"display_login":"bcmills"}}