{"action":"created","issue":{"url":"https://api.github.com/repos/storybooks/storybook/issues/6572","repository_url":"https://api.github.com/repos/storybooks/storybook","labels_url":"https://api.github.com/repos/storybooks/storybook/issues/6572/labels{/name}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/6572/comments","events_url":"https://api.github.com/repos/storybooks/storybook/issues/6572/events","html_url":"https://github.com/storybooks/storybook/pull/6572","id":435471960,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyMTkxODgy","number":6572,"title":"Addon-contexts improvements: bug-fixing, testing, typing","user":{"login":"leoyli","id":8866555,"node_id":"MDQ6VXNlcjg4NjY1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8866555?v=4","gravatar_id":"","url":"https://api.github.com/users/leoyli","html_url":"https://github.com/leoyli","followers_url":"https://api.github.com/users/leoyli/followers","following_url":"https://api.github.com/users/leoyli/following{/other_user}","gists_url":"https://api.github.com/users/leoyli/gists{/gist_id}","starred_url":"https://api.github.com/users/leoyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoyli/subscriptions","organizations_url":"https://api.github.com/users/leoyli/orgs","repos_url":"https://api.github.com/users/leoyli/repos","events_url":"https://api.github.com/users/leoyli/events{/privacy}","received_events_url":"https://api.github.com/users/leoyli/received_events","type":"User","site_admin":false},"labels":[{"id":1322115682,"node_id":"MDU6TGFiZWwxMzIyMTE1Njgy","url":"https://api.github.com/repos/storybooks/storybook/labels/addon:%20contexts","name":"addon: contexts","color":"fbca04","default":false},{"id":343576454,"node_id":"MDU6TGFiZWwzNDM1NzY0NTQ=","url":"https://api.github.com/repos/storybooks/storybook/labels/bug","name":"bug","color":"EB484F","default":true},{"id":885024119,"node_id":"MDU6TGFiZWw4ODUwMjQxMTk=","url":"https://api.github.com/repos/storybooks/storybook/labels/typescript","name":"typescript","color":"42e58b","default":false}],"state":"open","locked":false,"assignee":{"login":"leoyli","id":8866555,"node_id":"MDQ6VXNlcjg4NjY1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8866555?v=4","gravatar_id":"","url":"https://api.github.com/users/leoyli","html_url":"https://github.com/leoyli","followers_url":"https://api.github.com/users/leoyli/followers","following_url":"https://api.github.com/users/leoyli/following{/other_user}","gists_url":"https://api.github.com/users/leoyli/gists{/gist_id}","starred_url":"https://api.github.com/users/leoyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoyli/subscriptions","organizations_url":"https://api.github.com/users/leoyli/orgs","repos_url":"https://api.github.com/users/leoyli/repos","events_url":"https://api.github.com/users/leoyli/events{/privacy}","received_events_url":"https://api.github.com/users/leoyli/received_events","type":"User","site_admin":false},"assignees":[{"login":"leoyli","id":8866555,"node_id":"MDQ6VXNlcjg4NjY1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8866555?v=4","gravatar_id":"","url":"https://api.github.com/users/leoyli","html_url":"https://github.com/leoyli","followers_url":"https://api.github.com/users/leoyli/followers","following_url":"https://api.github.com/users/leoyli/following{/other_user}","gists_url":"https://api.github.com/users/leoyli/gists{/gist_id}","starred_url":"https://api.github.com/users/leoyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoyli/subscriptions","organizations_url":"https://api.github.com/users/leoyli/orgs","repos_url":"https://api.github.com/users/leoyli/repos","events_url":"https://api.github.com/users/leoyli/events{/privacy}","received_events_url":"https://api.github.com/users/leoyli/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/storybooks/storybook/milestones/13","html_url":"https://github.com/storybooks/storybook/milestone/13","labels_url":"https://api.github.com/repos/storybooks/storybook/milestones/13/labels","id":4077576,"node_id":"MDk6TWlsZXN0b25lNDA3NzU3Ng==","number":13,"title":"5.1.0","description":"","creator":{"login":"shilman","id":488689,"node_id":"MDQ6VXNlcjQ4ODY4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/488689?v=4","gravatar_id":"","url":"https://api.github.com/users/shilman","html_url":"https://github.com/shilman","followers_url":"https://api.github.com/users/shilman/followers","following_url":"https://api.github.com/users/shilman/following{/other_user}","gists_url":"https://api.github.com/users/shilman/gists{/gist_id}","starred_url":"https://api.github.com/users/shilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shilman/subscriptions","organizations_url":"https://api.github.com/users/shilman/orgs","repos_url":"https://api.github.com/users/shilman/repos","events_url":"https://api.github.com/users/shilman/events{/privacy}","received_events_url":"https://api.github.com/users/shilman/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":78,"state":"open","created_at":"2019-02-22T01:34:06Z","updated_at":"2019-04-21T03:42:05Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2019-04-21T03:42:05Z","updated_at":"2019-04-21T03:48:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/6572","html_url":"https://github.com/storybooks/storybook/pull/6572","diff_url":"https://github.com/storybooks/storybook/pull/6572.diff","patch_url":"https://github.com/storybooks/storybook/pull/6572.patch"},"body":"Issue: #6559\r\n\r\n## What I did\r\n\r\n- [bug-fix] when a `param` in a context carrying `props = null`, it mistakenly disable the context.\r\n- [test] add 4 unit testing files to cover the most important logic of this addon (API related).\r\n- [type] improve typing and its maintainability (separate type and implementation but collocate them, greatly inspired by @apastuhov, thanks!).\r\n- [doc] fix typos in code comments, and remove the old NPM badge in README (migration leftovers).\r\n- [build] strip-out type comments in the build. \r\n\r\n## How to test\r\n\r\n- Running Jest (CI/CD should automate this).\r\n- Look into `Addon|Contexts` stories in official storybook (should not break the stories)."},"comment":{"url":"https://api.github.com/repos/storybooks/storybook/issues/comments/485222379","html_url":"https://github.com/storybooks/storybook/pull/6572#issuecomment-485222379","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/6572","id":485222379,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4NTIyMjM3OQ==","user":{"login":"leoyli","id":8866555,"node_id":"MDQ6VXNlcjg4NjY1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8866555?v=4","gravatar_id":"","url":"https://api.github.com/users/leoyli","html_url":"https://github.com/leoyli","followers_url":"https://api.github.com/users/leoyli/followers","following_url":"https://api.github.com/users/leoyli/following{/other_user}","gists_url":"https://api.github.com/users/leoyli/gists{/gist_id}","starred_url":"https://api.github.com/users/leoyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoyli/subscriptions","organizations_url":"https://api.github.com/users/leoyli/orgs","repos_url":"https://api.github.com/users/leoyli/repos","events_url":"https://api.github.com/users/leoyli/events{/privacy}","received_events_url":"https://api.github.com/users/leoyli/received_events","type":"User","site_admin":false},"created_at":"2019-04-21T03:48:17Z","updated_at":"2019-04-21T03:48:17Z","author_association":"CONTRIBUTOR","body":"@shilman... the automation bot seems a bit crazy here... Did I do something wrong or you think it could be a bug 😢..."}}
{"actor":{"display_login":"leoyli"}}