{"action":"opened","number":3931,"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3931","id":327665097,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3NjY1MDk3","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3931","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3931.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/3931.patch","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3931","number":3931,"state":"open","locked":false,"title":"Remove rendering of waterway=wadi","user":{"login":"jeisenbe","id":42757252,"node_id":"MDQ6VXNlcjQyNzU3MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/42757252?v=4","gravatar_id":"","url":"https://api.github.com/users/jeisenbe","html_url":"https://github.com/jeisenbe","followers_url":"https://api.github.com/users/jeisenbe/followers","following_url":"https://api.github.com/users/jeisenbe/following{/other_user}","gists_url":"https://api.github.com/users/jeisenbe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeisenbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeisenbe/subscriptions","organizations_url":"https://api.github.com/users/jeisenbe/orgs","repos_url":"https://api.github.com/users/jeisenbe/repos","events_url":"https://api.github.com/users/jeisenbe/events{/privacy}","received_events_url":"https://api.github.com/users/jeisenbe/received_events","type":"User","site_admin":false},"body":"Fixes #1365\r\n\r\n## Changes proposed in this pull request:\r\n- Removes rendering of deprecated feature waterway=wadi, which should instead be mapped as `intermittent=yes` + `waterway=stream` or `waterway=river` if it is a waterway, or as `natural=valley` if it is a dry valley. Removing the rendering will support mappers in consistent use of these tags\r\n- Does not remove wadi from the list of linestring exceptions in `openstreetmap-carto.lua` because these features should be imported as linear ways, in case this style is adapted for other purposes. \r\n\r\n### Trend of `waterway=wadi` usage over time:\r\n\r\n![waterway-wadi-taghistory](https://user-images.githubusercontent.com/42757252/66732831-6517a980-ee98-11e9-86a6-8082ffc21877.png)\r\n\r\nIn comparison, intermittent=yes (which is used with waterway=* over 92% of the time) has increased to over 2 million uses, with over 1.9 million waterway=stream + intermittent=yes \r\n\r\nAlso, as mentioned in the related issue (https://github.com/gravitystorm/openstreetmap-carto/issues/1365#issuecomment-464341386), \"three groups from individual mappers in Tunisia, Pakistan and southern Turkey from about 4 years ago account for nearly half of the data].","created_at":"2019-10-14T06:50:39Z","updated_at":"2019-10-14T06:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1546623472,"node_id":"MDU6TGFiZWwxNTQ2NjIzNDcy","url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/remove%20rendering","name":"remove rendering","color":"ef67e4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3931/commits","review_comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3931/comments","review_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3931/comments","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/e410ccb9f60228977242d340a856f99964526311","head":{"label":"jeisenbe:wadi","ref":"wadi","sha":"e410ccb9f60228977242d340a856f99964526311","user":{"login":"jeisenbe","id":42757252,"node_id":"MDQ6VXNlcjQyNzU3MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/42757252?v=4","gravatar_id":"","url":"https://api.github.com/users/jeisenbe","html_url":"https://github.com/jeisenbe","followers_url":"https://api.github.com/users/jeisenbe/followers","following_url":"https://api.github.com/users/jeisenbe/following{/other_user}","gists_url":"https://api.github.com/users/jeisenbe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeisenbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeisenbe/subscriptions","organizations_url":"https://api.github.com/users/jeisenbe/orgs","repos_url":"https://api.github.com/users/jeisenbe/repos","events_url":"https://api.github.com/users/jeisenbe/events{/privacy}","received_events_url":"https://api.github.com/users/jeisenbe/received_events","type":"User","site_admin":false},"repo":{"id":148287701,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyODc3MDE=","name":"openstreetmap-carto","full_name":"jeisenbe/openstreetmap-carto","private":false,"owner":{"login":"jeisenbe","id":42757252,"node_id":"MDQ6VXNlcjQyNzU3MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/42757252?v=4","gravatar_id":"","url":"https://api.github.com/users/jeisenbe","html_url":"https://github.com/jeisenbe","followers_url":"https://api.github.com/users/jeisenbe/followers","following_url":"https://api.github.com/users/jeisenbe/following{/other_user}","gists_url":"https://api.github.com/users/jeisenbe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeisenbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeisenbe/subscriptions","organizations_url":"https://api.github.com/users/jeisenbe/orgs","repos_url":"https://api.github.com/users/jeisenbe/repos","events_url":"https://api.github.com/users/jeisenbe/events{/privacy}","received_events_url":"https://api.github.com/users/jeisenbe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeisenbe/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":true,"url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto","forks_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/jeisenbe/openstreetmap-carto/deployments","created_at":"2018-09-11T08:46:23Z","updated_at":"2019-10-13T04:43:32Z","pushed_at":"2019-10-14T06:39:33Z","git_url":"git://github.com/jeisenbe/openstreetmap-carto.git","ssh_url":"git@github.com:jeisenbe/openstreetmap-carto.git","clone_url":"https://github.com/jeisenbe/openstreetmap-carto.git","svn_url":"https://github.com/jeisenbe/openstreetmap-carto","homepage":"","size":17269,"stargazers_count":1,"watchers_count":1,"language":"CartoCSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"gravitystorm:master","ref":"master","sha":"ea73a44105ad1c3a0ebff817d4a8e9ea9233124b","user":{"login":"gravitystorm","id":360803,"node_id":"MDQ6VXNlcjM2MDgwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":6707453,"node_id":"MDEwOlJlcG9zaXRvcnk2NzA3NDUz","name":"openstreetmap-carto","full_name":"gravitystorm/openstreetmap-carto","private":false,"owner":{"login":"gravitystorm","id":360803,"node_id":"MDQ6VXNlcjM2MDgwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gravitystorm/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":false,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/deployments","created_at":"2012-11-15T16:06:16Z","updated_at":"2019-10-11T20:51:24Z","pushed_at":"2019-10-10T00:41:56Z","git_url":"git://github.com/gravitystorm/openstreetmap-carto.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-carto.git","clone_url":"https://github.com/gravitystorm/openstreetmap-carto.git","svn_url":"https://github.com/gravitystorm/openstreetmap-carto","homepage":"","size":13380,"stargazers_count":910,"watchers_count":910,"language":"CartoCSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":507,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":441,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":507,"open_issues":441,"watchers":910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3931"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/3931"},"issue":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3931"},"comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3931/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3931/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/3931/commits"},"statuses":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/e410ccb9f60228977242d340a856f99964526311"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"jeisenbe"}}