{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/302122553","pull_request_review_id":260106933,"id":302122553,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjEyMjU1Mw==","diff_hunk":"@@ -133,6 +143,11 @@ public void onFailure(Call call, IOException e) {\n \n \t\t@Override\n \t\tpublic void onResponse(Call call, Response response) throws IOException {\n+\n+\t\t\tif (!response.isSuccessful()) {\n+\t\t\t\tgetLogger().warn(FAILED_SENDING_REQUEST_TO_DATADOG, response.code());","path":"flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java","position":27,"original_position":27,"commit_id":"022c7c680703f7b49d2f24317e5e82d73c808ef7","original_commit_id":"022c7c680703f7b49d2f24317e5e82d73c808ef7","user":{"login":"NicoK","id":213026,"node_id":"MDQ6VXNlcjIxMzAyNg==","avatar_url":"https://avatars1.githubusercontent.com/u/213026?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoK","html_url":"https://github.com/NicoK","followers_url":"https://api.github.com/users/NicoK/followers","following_url":"https://api.github.com/users/NicoK/following{/other_user}","gists_url":"https://api.github.com/users/NicoK/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoK/subscriptions","organizations_url":"https://api.github.com/users/NicoK/orgs","repos_url":"https://api.github.com/users/NicoK/repos","events_url":"https://api.github.com/users/NicoK/events{/privacy}","received_events_url":"https://api.github.com/users/NicoK/received_events","type":"User","site_admin":false},"body":"Why is this logged at `warn` leven, while `onFailure()` is only logging on `debug` level?","created_at":"2019-07-10T15:15:35Z","updated_at":"2019-07-10T15:16:32Z","html_url":"https://github.com/apache/flink/pull/8990#discussion_r302122553","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/8990","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/302122553"},"html":{"href":"https://github.com/apache/flink/pull/8990#discussion_r302122553"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/8990"}},"in_reply_to_id":302105339},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/8990","id":294680179,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NjgwMTc5","html_url":"https://github.com/apache/flink/pull/8990","diff_url":"https://github.com/apache/flink/pull/8990.diff","patch_url":"https://github.com/apache/flink/pull/8990.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/8990","number":8990,"state":"open","locked":false,"title":"[FLINK-13104][metrics] Updated request callback to log warning on failure","user":{"login":"mans2singh","id":8467404,"node_id":"MDQ6VXNlcjg0Njc0MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8467404?v=4","gravatar_id":"","url":"https://api.github.com/users/mans2singh","html_url":"https://github.com/mans2singh","followers_url":"https://api.github.com/users/mans2singh/followers","following_url":"https://api.github.com/users/mans2singh/following{/other_user}","gists_url":"https://api.github.com/users/mans2singh/gists{/gist_id}","starred_url":"https://api.github.com/users/mans2singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mans2singh/subscriptions","organizations_url":"https://api.github.com/users/mans2singh/orgs","repos_url":"https://api.github.com/users/mans2singh/repos","events_url":"https://api.github.com/users/mans2singh/events{/privacy}","received_events_url":"https://api.github.com/users/mans2singh/received_events","type":"User","site_admin":false},"body":"## Contribution Checklist\r\n\r\n\r\n## What is the purpose of the change\r\n\r\n* Check for success status on posting metrics to Datadog and log warning in case request is not successful\r\n\r\n\r\n## Brief change log\r\n\r\n* Added check in request callback to check for successful status and if not log a warning\r\n\r\n## Verifying this change\r\n  - Added unit tests for successful and un-successful posting scenarios\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): no\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no\r\n  - The serializers: no\r\n  - The runtime per-record code paths (performance sensitive): no\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no\r\n  - The S3 file system connector: no\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? no\r\n  - If yes, how is the feature documented? not applicable\r\n","created_at":"2019-07-04T20:39:59Z","updated_at":"2019-07-10T15:16:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c29ecbd07af60b9ea943d527ebaa17515e87aba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1273342730,"node_id":"MDU6TGFiZWwxMjczMzQyNzMw","url":"https://api.github.com/repos/apache/flink/labels/component=Runtime/Metrics","name":"component=Runtime/Metrics","color":"175fb7","default":false},{"id":1244454690,"node_id":"MDU6TGFiZWwxMjQ0NDU0Njkw","url":"https://api.github.com/repos/apache/flink/labels/review=description?","name":"review=description?","color":"bcf5db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/8990/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/8990/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/8990/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/022c7c680703f7b49d2f24317e5e82d73c808ef7","head":{"label":"mans2singh:FLINK-13104","ref":"FLINK-13104","sha":"022c7c680703f7b49d2f24317e5e82d73c808ef7","user":{"login":"mans2singh","id":8467404,"node_id":"MDQ6VXNlcjg0Njc0MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8467404?v=4","gravatar_id":"","url":"https://api.github.com/users/mans2singh","html_url":"https://github.com/mans2singh","followers_url":"https://api.github.com/users/mans2singh/followers","following_url":"https://api.github.com/users/mans2singh/following{/other_user}","gists_url":"https://api.github.com/users/mans2singh/gists{/gist_id}","starred_url":"https://api.github.com/users/mans2singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mans2singh/subscriptions","organizations_url":"https://api.github.com/users/mans2singh/orgs","repos_url":"https://api.github.com/users/mans2singh/repos","events_url":"https://api.github.com/users/mans2singh/events{/privacy}","received_events_url":"https://api.github.com/users/mans2singh/received_events","type":"User","site_admin":false},"repo":{"id":185428271,"node_id":"MDEwOlJlcG9zaXRvcnkxODU0MjgyNzE=","name":"flink","full_name":"mans2singh/flink","private":false,"owner":{"login":"mans2singh","id":8467404,"node_id":"MDQ6VXNlcjg0Njc0MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8467404?v=4","gravatar_id":"","url":"https://api.github.com/users/mans2singh","html_url":"https://github.com/mans2singh","followers_url":"https://api.github.com/users/mans2singh/followers","following_url":"https://api.github.com/users/mans2singh/following{/other_user}","gists_url":"https://api.github.com/users/mans2singh/gists{/gist_id}","starred_url":"https://api.github.com/users/mans2singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mans2singh/subscriptions","organizations_url":"https://api.github.com/users/mans2singh/orgs","repos_url":"https://api.github.com/users/mans2singh/repos","events_url":"https://api.github.com/users/mans2singh/events{/privacy}","received_events_url":"https://api.github.com/users/mans2singh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mans2singh/flink","description":"Apache Flink","fork":true,"url":"https://api.github.com/repos/mans2singh/flink","forks_url":"https://api.github.com/repos/mans2singh/flink/forks","keys_url":"https://api.github.com/repos/mans2singh/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mans2singh/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mans2singh/flink/teams","hooks_url":"https://api.github.com/repos/mans2singh/flink/hooks","issue_events_url":"https://api.github.com/repos/mans2singh/flink/issues/events{/number}","events_url":"https://api.github.com/repos/mans2singh/flink/events","assignees_url":"https://api.github.com/repos/mans2singh/flink/assignees{/user}","branches_url":"https://api.github.com/repos/mans2singh/flink/branches{/branch}","tags_url":"https://api.github.com/repos/mans2singh/flink/tags","blobs_url":"https://api.github.com/repos/mans2singh/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mans2singh/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mans2singh/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mans2singh/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mans2singh/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/mans2singh/flink/languages","stargazers_url":"https://api.github.com/repos/mans2singh/flink/stargazers","contributors_url":"https://api.github.com/repos/mans2singh/flink/contributors","subscribers_url":"https://api.github.com/repos/mans2singh/flink/subscribers","subscription_url":"https://api.github.com/repos/mans2singh/flink/subscription","commits_url":"https://api.github.com/repos/mans2singh/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mans2singh/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mans2singh/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mans2singh/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/mans2singh/flink/contents/{+path}","compare_url":"https://api.github.com/repos/mans2singh/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mans2singh/flink/merges","archive_url":"https://api.github.com/repos/mans2singh/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mans2singh/flink/downloads","issues_url":"https://api.github.com/repos/mans2singh/flink/issues{/number}","pulls_url":"https://api.github.com/repos/mans2singh/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/mans2singh/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/mans2singh/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mans2singh/flink/labels{/name}","releases_url":"https://api.github.com/repos/mans2singh/flink/releases{/id}","deployments_url":"https://api.github.com/repos/mans2singh/flink/deployments","created_at":"2019-05-07T15:19:55Z","updated_at":"2019-07-04T20:17:34Z","pushed_at":"2019-07-09T23:22:36Z","git_url":"git://github.com/mans2singh/flink.git","ssh_url":"git@github.com:mans2singh/flink.git","clone_url":"https://github.com/mans2singh/flink.git","svn_url":"https://github.com/mans2singh/flink","homepage":"","size":248398,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4fbf32356a1df34b9ed5ce0c484dfc9695cd7c4f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2019-07-10T14:41:02Z","pushed_at":"2019-07-10T15:05:22Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":249781,"stargazers_count":9383,"watchers_count":9383,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5027,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":503,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5027,"open_issues":503,"watchers":9383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/8990"},"html":{"href":"https://github.com/apache/flink/pull/8990"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/8990"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/8990/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/8990/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/8990/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/022c7c680703f7b49d2f24317e5e82d73c808ef7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NicoK"}}