{"action":"created","comment":{"url":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments/357882290","pull_request_review_id":332180640,"id":357882290,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Nzg4MjI5MA==","diff_hunk":"@@ -60,7 +60,8 @@ export class JupyterServerBase implements INotebookServer {\n         // Try creating a session just to ensure we're connected. Callers of this function check to make sure jupyter\r\n         // is running and connectable.\r\n         let session: IJupyterSession | undefined;\r\n-        session = await this.sessionManager.startNew(launchInfo.kernelSpec, cancelToken);\r\n+        // tslint:disable-next-line: no-any\r\n+        session = await this.sessionManager.startNew(launchInfo.kernelSpec as any, cancelToken);\r","path":"src/client/datascience/jupyter/jupyterServer.ts","position":6,"original_position":6,"commit_id":"be1d400d49b21a79dcf0537a2f86c126c99edb76","original_commit_id":"be1d400d49b21a79dcf0537a2f86c126c99edb76","user":{"login":"IanMatthewHuff","id":812783,"node_id":"MDQ6VXNlcjgxMjc4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/812783?v=4","gravatar_id":"","url":"https://api.github.com/users/IanMatthewHuff","html_url":"https://github.com/IanMatthewHuff","followers_url":"https://api.github.com/users/IanMatthewHuff/followers","following_url":"https://api.github.com/users/IanMatthewHuff/following{/other_user}","gists_url":"https://api.github.com/users/IanMatthewHuff/gists{/gist_id}","starred_url":"https://api.github.com/users/IanMatthewHuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanMatthewHuff/subscriptions","organizations_url":"https://api.github.com/users/IanMatthewHuff/orgs","repos_url":"https://api.github.com/users/IanMatthewHuff/repos","events_url":"https://api.github.com/users/IanMatthewHuff/events{/privacy}","received_events_url":"https://api.github.com/users/IanMatthewHuff/received_events","type":"User","site_admin":false},"body":"Doesn't the launchInfo kernelSpec type match up with startNew? I thought that was the point of that new partial combo type that you have. Why would the any be needed?","created_at":"2019-12-14T00:43:41Z","updated_at":"2019-12-14T00:43:42Z","html_url":"https://github.com/microsoft/vscode-python/pull/9111#discussion_r357882290","pull_request_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments/357882290"},"html":{"href":"https://github.com/microsoft/vscode-python/pull/9111#discussion_r357882290"},"pull_request":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111"}}},"pull_request":{"url":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111","id":353104928,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMTA0OTI4","html_url":"https://github.com/microsoft/vscode-python/pull/9111","diff_url":"https://github.com/microsoft/vscode-python/pull/9111.diff","patch_url":"https://github.com/microsoft/vscode-python/pull/9111.patch","issue_url":"https://api.github.com/repos/microsoft/vscode-python/issues/9111","number":9111,"state":"open","locked":false,"title":"Add ability to select active kernels","user":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"body":"For #4644\r\n","created_at":"2019-12-13T23:00:03Z","updated_at":"2019-12-14T00:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb95ba3840682c5af71163fa593b6ba316334ce8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rchiodo","id":19672699,"node_id":"MDQ6VXNlcjE5NjcyNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/19672699?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiodo","html_url":"https://github.com/rchiodo","followers_url":"https://api.github.com/users/rchiodo/followers","following_url":"https://api.github.com/users/rchiodo/following{/other_user}","gists_url":"https://api.github.com/users/rchiodo/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiodo/subscriptions","organizations_url":"https://api.github.com/users/rchiodo/orgs","repos_url":"https://api.github.com/users/rchiodo/repos","events_url":"https://api.github.com/users/rchiodo/events{/privacy}","received_events_url":"https://api.github.com/users/rchiodo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111/commits","review_comments_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111/comments","review_comment_url":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoft/vscode-python/issues/9111/comments","statuses_url":"https://api.github.com/repos/microsoft/vscode-python/statuses/be1d400d49b21a79dcf0537a2f86c126c99edb76","head":{"label":"DonJayamanne:addRemoteKernelSelection","ref":"addRemoteKernelSelection","sha":"be1d400d49b21a79dcf0537a2f86c126c99edb76","user":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"repo":{"id":49946255,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk0NjI1NQ==","name":"pythonVSCode","full_name":"DonJayamanne/pythonVSCode","private":false,"owner":{"login":"DonJayamanne","id":1948812,"node_id":"MDQ6VXNlcjE5NDg4MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1948812?v=4","gravatar_id":"","url":"https://api.github.com/users/DonJayamanne","html_url":"https://github.com/DonJayamanne","followers_url":"https://api.github.com/users/DonJayamanne/followers","following_url":"https://api.github.com/users/DonJayamanne/following{/other_user}","gists_url":"https://api.github.com/users/DonJayamanne/gists{/gist_id}","starred_url":"https://api.github.com/users/DonJayamanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonJayamanne/subscriptions","organizations_url":"https://api.github.com/users/DonJayamanne/orgs","repos_url":"https://api.github.com/users/DonJayamanne/repos","events_url":"https://api.github.com/users/DonJayamanne/events{/privacy}","received_events_url":"https://api.github.com/users/DonJayamanne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DonJayamanne/pythonVSCode","description":"This extension is now maintained in the Microsoft fork.","fork":false,"url":"https://api.github.com/repos/DonJayamanne/pythonVSCode","forks_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/forks","keys_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/teams","hooks_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/hooks","issue_events_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues/events{/number}","events_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/events","assignees_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/assignees{/user}","branches_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/branches{/branch}","tags_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/tags","blobs_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/statuses/{sha}","languages_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/languages","stargazers_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/stargazers","contributors_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/contributors","subscribers_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/subscribers","subscription_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/subscription","commits_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/contents/{+path}","compare_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/merges","archive_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/downloads","issues_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/issues{/number}","pulls_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/pulls{/number}","milestones_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/milestones{/number}","notifications_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/labels{/name}","releases_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/releases{/id}","deployments_url":"https://api.github.com/repos/DonJayamanne/pythonVSCode/deployments","created_at":"2016-01-19T10:50:01Z","updated_at":"2019-12-13T23:47:28Z","pushed_at":"2019-12-14T00:39:25Z","git_url":"git://github.com/DonJayamanne/pythonVSCode.git","ssh_url":"git@github.com:DonJayamanne/pythonVSCode.git","clone_url":"https://github.com/DonJayamanne/pythonVSCode.git","svn_url":"https://github.com/DonJayamanne/pythonVSCode","homepage":"https://github.com/Microsoft/vscode-python","size":137367,"stargazers_count":1938,"watchers_count":1938,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":657,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":53,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":657,"open_issues":53,"watchers":1938,"default_branch":"master"}},"base":{"label":"microsoft:master","ref":"master","sha":"844a423366f03a7dd33cf67d9d1d0f94f6e1a6e3","user":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106462765,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjI3NjU=","name":"vscode-python","full_name":"microsoft/vscode-python","private":false,"owner":{"login":"microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoft","html_url":"https://github.com/microsoft","followers_url":"https://api.github.com/users/microsoft/followers","following_url":"https://api.github.com/users/microsoft/following{/other_user}","gists_url":"https://api.github.com/users/microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoft/subscriptions","organizations_url":"https://api.github.com/users/microsoft/orgs","repos_url":"https://api.github.com/users/microsoft/repos","events_url":"https://api.github.com/users/microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microsoft/vscode-python","description":"Python extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/microsoft/vscode-python","forks_url":"https://api.github.com/repos/microsoft/vscode-python/forks","keys_url":"https://api.github.com/repos/microsoft/vscode-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoft/vscode-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoft/vscode-python/teams","hooks_url":"https://api.github.com/repos/microsoft/vscode-python/hooks","issue_events_url":"https://api.github.com/repos/microsoft/vscode-python/issues/events{/number}","events_url":"https://api.github.com/repos/microsoft/vscode-python/events","assignees_url":"https://api.github.com/repos/microsoft/vscode-python/assignees{/user}","branches_url":"https://api.github.com/repos/microsoft/vscode-python/branches{/branch}","tags_url":"https://api.github.com/repos/microsoft/vscode-python/tags","blobs_url":"https://api.github.com/repos/microsoft/vscode-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoft/vscode-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoft/vscode-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoft/vscode-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoft/vscode-python/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoft/vscode-python/languages","stargazers_url":"https://api.github.com/repos/microsoft/vscode-python/stargazers","contributors_url":"https://api.github.com/repos/microsoft/vscode-python/contributors","subscribers_url":"https://api.github.com/repos/microsoft/vscode-python/subscribers","subscription_url":"https://api.github.com/repos/microsoft/vscode-python/subscription","commits_url":"https://api.github.com/repos/microsoft/vscode-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoft/vscode-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoft/vscode-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoft/vscode-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoft/vscode-python/contents/{+path}","compare_url":"https://api.github.com/repos/microsoft/vscode-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoft/vscode-python/merges","archive_url":"https://api.github.com/repos/microsoft/vscode-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoft/vscode-python/downloads","issues_url":"https://api.github.com/repos/microsoft/vscode-python/issues{/number}","pulls_url":"https://api.github.com/repos/microsoft/vscode-python/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoft/vscode-python/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoft/vscode-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoft/vscode-python/labels{/name}","releases_url":"https://api.github.com/repos/microsoft/vscode-python/releases{/id}","deployments_url":"https://api.github.com/repos/microsoft/vscode-python/deployments","created_at":"2017-10-10T19:37:29Z","updated_at":"2019-12-13T21:04:11Z","pushed_at":"2019-12-14T00:40:15Z","git_url":"git://github.com/microsoft/vscode-python.git","ssh_url":"git@github.com:microsoft/vscode-python.git","clone_url":"https://github.com/microsoft/vscode-python.git","svn_url":"https://github.com/microsoft/vscode-python","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-python.python","size":80643,"stargazers_count":1956,"watchers_count":1956,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":417,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1036,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":417,"open_issues":1036,"watchers":1956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111"},"html":{"href":"https://github.com/microsoft/vscode-python/pull/9111"},"issue":{"href":"https://api.github.com/repos/microsoft/vscode-python/issues/9111"},"comments":{"href":"https://api.github.com/repos/microsoft/vscode-python/issues/9111/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoft/vscode-python/pulls/9111/commits"},"statuses":{"href":"https://api.github.com/repos/microsoft/vscode-python/statuses/be1d400d49b21a79dcf0537a2f86c126c99edb76"}},"author_association":"NONE"}}
{"actor":{"display_login":"IanMatthewHuff"}}