{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1420","repository_url":"https://api.github.com/repos/input-output-hk/daedalus","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1420/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1420/comments","events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1420/events","html_url":"https://github.com/input-output-hk/daedalus/pull/1420","id":454228550,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NzIzOTY1","number":1420,"title":"[DDW-685] Stake Pools - Adjustments","user":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"labels":[{"id":455603671,"node_id":"MDU6TGFiZWw0NTU2MDM2NzE=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/bug","name":"bug","color":"ee0701","default":true},{"id":1221374858,"node_id":"MDU6TGFiZWwxMjIxMzc0ODU4","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/release-0.14.0","name":"release-0.14.0","color":"e8876f","default":false}],"state":"open","locked":false,"assignee":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-06-10T15:28:58Z","updated_at":"2019-06-12T20:38:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1420","html_url":"https://github.com/input-output-hk/daedalus/pull/1420","diff_url":"https://github.com/input-output-hk/daedalus/pull/1420.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1420.patch"},"body":"This PR adds fine adjustments to the Stake Pools screen.\r\n\r\n## Todos\r\n\r\n* [X] https://docs.google.com/document/d/10UwMUoDBalrRS4QvLZq2dtXJ42ICdpfgDPIUo3Fcxeg/edit#\r\n\r\n* **Tooltip positioning** and **Search/Filtering** will be handled on different PR's\r\n* **[Temporary Storybook URL](https://daniloprates.github.io/daedalus/?selectedKind=Staking&selectedStory=Stake%20Pools&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs)**, while Netifly is failing.\r\n\r\n## Screenshots\r\n\r\n![image](https://user-images.githubusercontent.com/1504716/59206431-47010c00-8b7b-11e9-9bed-88d0f5dcc384.png)\r\n\r\n\r\n---\r\n\r\n## Testing Checklist\r\n\r\n- [Slack QA thread](https://input-output-rnd.slack.com/messages/GGKFXSKC6)\r\n- [ ] Test\r\n\r\n---\r\n\r\n## Review Checklist\r\n\r\n### Basics\r\n\r\n- [ ] PR has been assigned and has appropriate labels (`feature`/`bug`/`chore`, `release-x.x.x`)\r\n- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)\r\n- [ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance and unit tests are passing (`yarn test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`yarn flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`yarn lint`)\r\n- [ ] There are no *prettier* errors or warnings (`yarn prettier:check`)\r\n- [ ] There are no missing translations (running `yarn manage:translations` produces no changes)\r\n- [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)\r\n- [ ] Japanese text changes are proofread and approved (Junko Oda)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`yarn storybook`)\r\n- [ ] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly commented and documented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-renderings\r\n- [ ] Any code that only works in main process is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature/change is covered by acceptance tests\r\n- [ ] New feature/change is manually tested and approved by QA team\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature/change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review\r\n- [ ] Merge the PR\r\n- [ ] Delete the source branch\r\n- [ ] Move the ticket to `done` column on the YouTrack board\r\n- [ ] Update Slack QA thread by marking it with a green checkmark\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments/501446419","html_url":"https://github.com/input-output-hk/daedalus/pull/1420#issuecomment-501446419","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1420","id":501446419,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMTQ0NjQxOQ==","user":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"created_at":"2019-06-12T20:38:52Z","updated_at":"2019-06-12T20:38:52Z","author_association":"MEMBER","body":"> @daniloprates Netlify build is fixed 👍\r\n\r\n@DominikGuzei 💛"}}
{"actor":{"display_login":"daniloprates"}}