{"action":"created","comment":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/286884861","pull_request_review_id":241125994,"id":286884861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Njg4NDg2MQ==","diff_hunk":"@@ -192,6 +195,10 @@ mkdir -p $RPM_BUILD_ROOT%{_mandir}/man8\n /usr/bin/pod2man --section=1 $RPM_BUILD_ROOT/%{_bindir}/spacewalk-setup-sudoers| gzip > $RPM_BUILD_ROOT%{_mandir}/man1/spacewalk-setup-sudoers.1.gz\n /usr/bin/pod2man --section=1 $RPM_BUILD_ROOT/%{_bindir}/spacewalk-setup-ipa-authentication| gzip > $RPM_BUILD_ROOT%{_mandir}/man1/spacewalk-setup-ipa-authentication.1.gz\n \n+# create directories for standalone formulas\n+mkdir -p %{buildroot}/usr/share/salt-formulas/metadata","path":"spacewalk/setup/spacewalk-setup.spec","position":null,"original_position":15,"commit_id":"a33c0e869f6e9265ca6e2bd8e51ead1ed3d38a70","original_commit_id":"63330cec3d3b8de06931f0a37ca19276e079587a","user":{"login":"admd","id":12951268,"node_id":"MDQ6VXNlcjEyOTUxMjY4","avatar_url":"https://avatars0.githubusercontent.com/u/12951268?v=4","gravatar_id":"","url":"https://api.github.com/users/admd","html_url":"https://github.com/admd","followers_url":"https://api.github.com/users/admd/followers","following_url":"https://api.github.com/users/admd/following{/other_user}","gists_url":"https://api.github.com/users/admd/gists{/gist_id}","starred_url":"https://api.github.com/users/admd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/admd/subscriptions","organizations_url":"https://api.github.com/users/admd/orgs","repos_url":"https://api.github.com/users/admd/repos","events_url":"https://api.github.com/users/admd/events{/privacy}","received_events_url":"https://api.github.com/users/admd/received_events","type":"User","site_admin":false},"body":"Thank you @meaksh for the review and for helping. I have adjusted the code. Please have a look.","created_at":"2019-05-23T10:50:25Z","updated_at":"2019-05-23T10:50:26Z","html_url":"https://github.com/uyuni-project/uyuni/pull/948#discussion_r286884861","pull_request_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/286884861"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/948#discussion_r286884861"},"pull_request":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948"}},"in_reply_to_id":286872740},"pull_request":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948","id":277398419,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3Mzk4NDE5","html_url":"https://github.com/uyuni-project/uyuni/pull/948","diff_url":"https://github.com/uyuni-project/uyuni/pull/948.diff","patch_url":"https://github.com/uyuni-project/uyuni/pull/948.patch","issue_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/948","number":948,"state":"open","locked":false,"title":"Add support for Salt Formulas to be used with standalone Salt ","user":{"login":"admd","id":12951268,"node_id":"MDQ6VXNlcjEyOTUxMjY4","avatar_url":"https://avatars0.githubusercontent.com/u/12951268?v=4","gravatar_id":"","url":"https://api.github.com/users/admd","html_url":"https://github.com/admd","followers_url":"https://api.github.com/users/admd/followers","following_url":"https://api.github.com/users/admd/following{/other_user}","gists_url":"https://api.github.com/users/admd/gists{/gist_id}","starred_url":"https://api.github.com/users/admd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/admd/subscriptions","organizations_url":"https://api.github.com/users/admd/orgs","repos_url":"https://api.github.com/users/admd/repos","events_url":"https://api.github.com/users/admd/events{/privacy}","received_events_url":"https://api.github.com/users/admd/received_events","type":"User","site_admin":false},"body":"## What does this PR change?\r\n\r\nThis PR updates the related files so susemanager can also handle formulas created in this directory `/usr/share/salt-formulas`\r\n\r\n## GUI diff\r\n\r\nNo difference.\r\n\r\nBefore:\r\n\r\nAfter:\r\n\r\n- [x] **DONE**\r\n\r\n## Documentation\r\n- [doc-susemanager PR](https://github.com/SUSE/doc-susemanager/pulls) or [documentation board issue](https://github.com/SUSE/spacewalk/projects/31) was created (GitHub automatic link expected below)\r\nWill create the PR in doc once this is finalized\r\n\r\n- [ ] **DONE**\r\n\r\n## Test coverage\r\n- No tests: **Existing tests should be enough**\r\n\r\n- [x] **DONE**\r\n\r\n## Links\r\n\r\nFixes #\r\nhttps://github.com/SUSE/spacewalk/issues/7632\r\n\r\n- [x] **DONE**\r\n\r\n## Changelogs\r\n\r\nIf you don't need a changelog check, please mark this checkbox:\r\n\r\n- [ ] No changelog needed\r\n\r\nIf you uncheck the checkbox after the PR is created, you will need to re-run `changelog_test` (see below)\r\n\r\n\r\n## Re-run a test\r\n\r\nIf you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:\r\n\r\n- [ ] Re-run test \"changelog_test\"\r\n- [ ] Re-run test \"backend_unittests_pgsql\"\r\n- [ ] Re-run test \"java_lint_checkstyle\"\t\t \r\n- [ ] Re-run test \"java_pgsql_tests\"\t\t \r\n- [ ] Re-run test \"ruby_rubocop\"\r\n- [ ] Re-run test \"schema_migration_test_oracle\"\r\n- [ ] Re-run test \"schema_migration_test_pgsql\"\t\t \r\n- [ ] Re-run test \"susemanager_unittests\"\r\n- [ ] Re-run test \"javascript_lint\"\t\t \r\n","created_at":"2019-05-09T13:43:51Z","updated_at":"2019-05-23T10:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42b5aa51020548387b345e905630e07bbb1a2aeb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1372269432,"node_id":"MDU6TGFiZWwxMzcyMjY5NDMy","url":"https://api.github.com/repos/uyuni-project/uyuni/labels/4.0","name":"4.0","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948/commits","review_comments_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948/comments","review_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/948/comments","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/a33c0e869f6e9265ca6e2bd8e51ead1ed3d38a70","head":{"label":"admd:support-for-unified-directory-for-salt-formulas","ref":"support-for-unified-directory-for-salt-formulas","sha":"a33c0e869f6e9265ca6e2bd8e51ead1ed3d38a70","user":{"login":"admd","id":12951268,"node_id":"MDQ6VXNlcjEyOTUxMjY4","avatar_url":"https://avatars0.githubusercontent.com/u/12951268?v=4","gravatar_id":"","url":"https://api.github.com/users/admd","html_url":"https://github.com/admd","followers_url":"https://api.github.com/users/admd/followers","following_url":"https://api.github.com/users/admd/following{/other_user}","gists_url":"https://api.github.com/users/admd/gists{/gist_id}","starred_url":"https://api.github.com/users/admd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/admd/subscriptions","organizations_url":"https://api.github.com/users/admd/orgs","repos_url":"https://api.github.com/users/admd/repos","events_url":"https://api.github.com/users/admd/events{/privacy}","received_events_url":"https://api.github.com/users/admd/received_events","type":"User","site_admin":false},"repo":{"id":145693034,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2OTMwMzQ=","name":"uyuni","full_name":"admd/uyuni","private":false,"owner":{"login":"admd","id":12951268,"node_id":"MDQ6VXNlcjEyOTUxMjY4","avatar_url":"https://avatars0.githubusercontent.com/u/12951268?v=4","gravatar_id":"","url":"https://api.github.com/users/admd","html_url":"https://github.com/admd","followers_url":"https://api.github.com/users/admd/followers","following_url":"https://api.github.com/users/admd/following{/other_user}","gists_url":"https://api.github.com/users/admd/gists{/gist_id}","starred_url":"https://api.github.com/users/admd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/admd/subscriptions","organizations_url":"https://api.github.com/users/admd/orgs","repos_url":"https://api.github.com/users/admd/repos","events_url":"https://api.github.com/users/admd/events{/privacy}","received_events_url":"https://api.github.com/users/admd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/admd/uyuni","description":"Source code for Uyuni","fork":true,"url":"https://api.github.com/repos/admd/uyuni","forks_url":"https://api.github.com/repos/admd/uyuni/forks","keys_url":"https://api.github.com/repos/admd/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/admd/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/admd/uyuni/teams","hooks_url":"https://api.github.com/repos/admd/uyuni/hooks","issue_events_url":"https://api.github.com/repos/admd/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/admd/uyuni/events","assignees_url":"https://api.github.com/repos/admd/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/admd/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/admd/uyuni/tags","blobs_url":"https://api.github.com/repos/admd/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/admd/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/admd/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/admd/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/admd/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/admd/uyuni/languages","stargazers_url":"https://api.github.com/repos/admd/uyuni/stargazers","contributors_url":"https://api.github.com/repos/admd/uyuni/contributors","subscribers_url":"https://api.github.com/repos/admd/uyuni/subscribers","subscription_url":"https://api.github.com/repos/admd/uyuni/subscription","commits_url":"https://api.github.com/repos/admd/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/admd/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/admd/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/admd/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/admd/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/admd/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/admd/uyuni/merges","archive_url":"https://api.github.com/repos/admd/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/admd/uyuni/downloads","issues_url":"https://api.github.com/repos/admd/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/admd/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/admd/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/admd/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/admd/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/admd/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/admd/uyuni/deployments","created_at":"2018-08-22T10:23:00Z","updated_at":"2018-08-22T10:24:18Z","pushed_at":"2019-05-23T10:38:29Z","git_url":"git://github.com/admd/uyuni.git","ssh_url":"git@github.com:admd/uyuni.git","clone_url":"https://github.com/admd/uyuni.git","svn_url":"https://github.com/admd/uyuni","homepage":"https://www.uyuni-project.org/","size":800764,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uyuni-project:master","ref":"master","sha":"6699f6c2a23270c2169b24a638ceeb4d7952f961","user":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"repo":{"id":143291989,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTE5ODk=","name":"uyuni","full_name":"uyuni-project/uyuni","private":false,"owner":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uyuni-project/uyuni","description":"Source code for Uyuni","fork":false,"url":"https://api.github.com/repos/uyuni-project/uyuni","forks_url":"https://api.github.com/repos/uyuni-project/uyuni/forks","keys_url":"https://api.github.com/repos/uyuni-project/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uyuni-project/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uyuni-project/uyuni/teams","hooks_url":"https://api.github.com/repos/uyuni-project/uyuni/hooks","issue_events_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/uyuni-project/uyuni/events","assignees_url":"https://api.github.com/repos/uyuni-project/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/uyuni-project/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/uyuni-project/uyuni/tags","blobs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uyuni-project/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/uyuni-project/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/uyuni-project/uyuni/languages","stargazers_url":"https://api.github.com/repos/uyuni-project/uyuni/stargazers","contributors_url":"https://api.github.com/repos/uyuni-project/uyuni/contributors","subscribers_url":"https://api.github.com/repos/uyuni-project/uyuni/subscribers","subscription_url":"https://api.github.com/repos/uyuni-project/uyuni/subscription","commits_url":"https://api.github.com/repos/uyuni-project/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/uyuni-project/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/uyuni-project/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/uyuni-project/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uyuni-project/uyuni/merges","archive_url":"https://api.github.com/repos/uyuni-project/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uyuni-project/uyuni/downloads","issues_url":"https://api.github.com/repos/uyuni-project/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/uyuni-project/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/uyuni-project/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uyuni-project/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/uyuni-project/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/uyuni-project/uyuni/deployments","created_at":"2018-08-02T12:31:20Z","updated_at":"2019-05-23T09:22:00Z","pushed_at":"2019-05-23T10:38:31Z","git_url":"git://github.com/uyuni-project/uyuni.git","ssh_url":"git@github.com:uyuni-project/uyuni.git","clone_url":"https://github.com/uyuni-project/uyuni.git","svn_url":"https://github.com/uyuni-project/uyuni","homepage":"https://www.uyuni-project.org/","size":801335,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":51,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":33,"open_issues":51,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/948"},"issue":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/948"},"comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/uyuni-project/uyuni/statuses/a33c0e869f6e9265ca6e2bd8e51ead1ed3d38a70"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"admd"}}