{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/2381","repository_url":"https://api.github.com/repos/Azure/aks-engine","labels_url":"https://api.github.com/repos/Azure/aks-engine/issues/2381/labels{/name}","comments_url":"https://api.github.com/repos/Azure/aks-engine/issues/2381/comments","events_url":"https://api.github.com/repos/Azure/aks-engine/issues/2381/events","html_url":"https://github.com/Azure/aks-engine/pull/2381","id":531572954,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MDA1MDY1","number":2381,"title":"refactor: remove unnecessary enabled addon config state representation","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"labels":[{"id":1128153706,"node_id":"MDU6TGFiZWwxMTI4MTUzNzA2","url":"https://api.github.com/repos/Azure/aks-engine/labels/approved","name":"approved","color":"5df7c4","default":false,"description":""},{"id":1128168964,"node_id":"MDU6TGFiZWwxMTI4MTY4OTY0","url":"https://api.github.com/repos/Azure/aks-engine/labels/size/L","name":"size/L","color":"ddc433","default":false,"description":""}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Azure/aks-engine/milestones/4","html_url":"https://github.com/Azure/aks-engine/milestone/4","labels_url":"https://api.github.com/repos/Azure/aks-engine/milestones/4/labels","id":4864443,"node_id":"MDk6TWlsZXN0b25lNDg2NDQ0Mw==","number":4,"title":"v0.45.0","description":"The person who created this milestone will be sacked.","creator":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":73,"state":"closed","created_at":"2019-11-20T22:12:10Z","updated_at":"2019-12-16T23:40:24Z","due_on":"2019-12-16T08:00:00Z","closed_at":"2019-12-16T23:40:24Z"},"comments":3,"created_at":"2019-12-02T22:13:31Z","updated_at":"2019-12-18T23:06:53Z","closed_at":"2019-12-02T23:33:35Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Azure/aks-engine/pulls/2381","html_url":"https://github.com/Azure/aks-engine/pull/2381","diff_url":"https://github.com/Azure/aks-engine/pull/2381.diff","patch_url":"https://github.com/Azure/aks-engine/pull/2381.patch"},"body":"<!-- Thank you for helping aks-engine with a pull request!\r\nUse conventional commit messages, such as\r\n  feat: add a knob to the frobnitz\r\nor\r\n  fix: repair hole in wumpus\r\nAnd read this for faster PR reviews: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews -->\r\n\r\n**Reason for Change**:\r\n<!-- What does this PR improve or fix in aks-engine? -->\r\n\r\nThe definitive configuration state representation for addons is in the `KubernetesConfig` `Addons` array. This PR removes the unnecessary setting of an `isEnabled` property during addons data marshalling, and instead consumes the authoritative `Enabled` boolean in the `Addons` config array.\r\n\r\n**Issue Fixed**:\r\n<!-- If this PR fixes GitHub issue 1234, add \"Fixes #1234\" to the next line. -->\r\n\r\n\r\n**Requirements**:\r\n<!-- Put an \"X\" character inside the brackets of each completed task. Some may be optional depending on the PR. -->\r\n\r\n- [ ] uses [conventional commit messages](https://www.conventionalcommits.org/)\r\n  <!-- Common commit types:\r\n        build: Build 🏭\r\n        chore: Maintenance 🔧\r\n        ci: Continuous Integration 💜\r\n        docs: Documentation 📘\r\n        feat: Features 🌈\r\n        fix: Bug Fixes 🐞\r\n        perf: Performance Improvements 🚀\r\n        refactor: Code Refactoring 💎\r\n        revert: Revert Change ◀️\r\n        style: Code Style 🎶\r\n        security: Security Fix 🛡️\r\n        test: Testing 💚 -->\r\n- [ ] includes documentation\r\n- [ ] adds unit tests\r\n- [ ] tested upgrade from previous version\r\n\r\n**Notes**:\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/aks-engine/issues/comments/567252638","html_url":"https://github.com/Azure/aks-engine/pull/2381#issuecomment-567252638","issue_url":"https://api.github.com/repos/Azure/aks-engine/issues/2381","id":567252638,"node_id":"MDEyOklzc3VlQ29tbWVudDU2NzI1MjYzOA==","user":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"created_at":"2019-12-18T23:06:52Z","updated_at":"2019-12-18T23:06:52Z","author_association":"MEMBER","body":"Related to #2251"}}
{"actor":{"display_login":"jackfrancis"}}