{"action":"opened","number":757,"pull_request":{"url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/757","id":274602347,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0NjAyMzQ3","html_url":"https://github.com/signalfx/signalfx-agent/pull/757","diff_url":"https://github.com/signalfx/signalfx-agent/pull/757.diff","patch_url":"https://github.com/signalfx/signalfx-agent/pull/757.patch","issue_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/757","number":757,"state":"open","locked":false,"title":"Making puppet module more robust on Debian","user":{"login":"phardy","id":372919,"node_id":"MDQ6VXNlcjM3MjkxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/372919?v=4","gravatar_id":"","url":"https://api.github.com/users/phardy","html_url":"https://github.com/phardy","followers_url":"https://api.github.com/users/phardy/followers","following_url":"https://api.github.com/users/phardy/following{/other_user}","gists_url":"https://api.github.com/users/phardy/gists{/gist_id}","starred_url":"https://api.github.com/users/phardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phardy/subscriptions","organizations_url":"https://api.github.com/users/phardy/orgs","repos_url":"https://api.github.com/users/phardy/repos","events_url":"https://api.github.com/users/phardy/events{/privacy}","received_events_url":"https://api.github.com/users/phardy/received_events","type":"User","site_admin":false},"body":"Hey folks. I'm working on migrating to SignalFx across our infrastructure, but ran in to a couple of problems with the Puppet module:\r\n\r\n* The module was attempting to create `/etc/signalfx/agent.yaml` before the package was installed, therefore `/etc/signalfx` did not yet exist and provisioning errored out.\r\n* The `Package['wget']` resource was duplicating our attempt to install wget elsewhere in our Puppet manifests.\r\n\r\nThis PR addresses the first problem by simply adding some chaining arrows.\r\n\r\nTo address the second problem, I've chosen to introduce a dependency on the `puppetlabs/apt` module to manage the apt repository. Happy to discuss alternatives for that, though.\r\n\r\nThanks!","created_at":"2019-04-30T05:35:08Z","updated_at":"2019-04-30T05:35:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"keitwb","id":614344,"node_id":"MDQ6VXNlcjYxNDM0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/614344?v=4","gravatar_id":"","url":"https://api.github.com/users/keitwb","html_url":"https://github.com/keitwb","followers_url":"https://api.github.com/users/keitwb/followers","following_url":"https://api.github.com/users/keitwb/following{/other_user}","gists_url":"https://api.github.com/users/keitwb/gists{/gist_id}","starred_url":"https://api.github.com/users/keitwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keitwb/subscriptions","organizations_url":"https://api.github.com/users/keitwb/orgs","repos_url":"https://api.github.com/users/keitwb/repos","events_url":"https://api.github.com/users/keitwb/events{/privacy}","received_events_url":"https://api.github.com/users/keitwb/received_events","type":"User","site_admin":false},{"login":"molner","id":16822771,"node_id":"MDQ6VXNlcjE2ODIyNzcx","avatar_url":"https://avatars1.githubusercontent.com/u/16822771?v=4","gravatar_id":"","url":"https://api.github.com/users/molner","html_url":"https://github.com/molner","followers_url":"https://api.github.com/users/molner/followers","following_url":"https://api.github.com/users/molner/following{/other_user}","gists_url":"https://api.github.com/users/molner/gists{/gist_id}","starred_url":"https://api.github.com/users/molner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molner/subscriptions","organizations_url":"https://api.github.com/users/molner/orgs","repos_url":"https://api.github.com/users/molner/repos","events_url":"https://api.github.com/users/molner/events{/privacy}","received_events_url":"https://api.github.com/users/molner/received_events","type":"User","site_admin":false},{"login":"asuresh4","id":17557526,"node_id":"MDQ6VXNlcjE3NTU3NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/17557526?v=4","gravatar_id":"","url":"https://api.github.com/users/asuresh4","html_url":"https://github.com/asuresh4","followers_url":"https://api.github.com/users/asuresh4/followers","following_url":"https://api.github.com/users/asuresh4/following{/other_user}","gists_url":"https://api.github.com/users/asuresh4/gists{/gist_id}","starred_url":"https://api.github.com/users/asuresh4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asuresh4/subscriptions","organizations_url":"https://api.github.com/users/asuresh4/orgs","repos_url":"https://api.github.com/users/asuresh4/repos","events_url":"https://api.github.com/users/asuresh4/events{/privacy}","received_events_url":"https://api.github.com/users/asuresh4/received_events","type":"User","site_admin":false},{"login":"charliesignalfx","id":18558634,"node_id":"MDQ6VXNlcjE4NTU4NjM0","avatar_url":"https://avatars0.githubusercontent.com/u/18558634?v=4","gravatar_id":"","url":"https://api.github.com/users/charliesignalfx","html_url":"https://github.com/charliesignalfx","followers_url":"https://api.github.com/users/charliesignalfx/followers","following_url":"https://api.github.com/users/charliesignalfx/following{/other_user}","gists_url":"https://api.github.com/users/charliesignalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/charliesignalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliesignalfx/subscriptions","organizations_url":"https://api.github.com/users/charliesignalfx/orgs","repos_url":"https://api.github.com/users/charliesignalfx/repos","events_url":"https://api.github.com/users/charliesignalfx/events{/privacy}","received_events_url":"https://api.github.com/users/charliesignalfx/received_events","type":"User","site_admin":false},{"login":"mstumpfx","id":31015658,"node_id":"MDQ6VXNlcjMxMDE1NjU4","avatar_url":"https://avatars3.githubusercontent.com/u/31015658?v=4","gravatar_id":"","url":"https://api.github.com/users/mstumpfx","html_url":"https://github.com/mstumpfx","followers_url":"https://api.github.com/users/mstumpfx/followers","following_url":"https://api.github.com/users/mstumpfx/following{/other_user}","gists_url":"https://api.github.com/users/mstumpfx/gists{/gist_id}","starred_url":"https://api.github.com/users/mstumpfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstumpfx/subscriptions","organizations_url":"https://api.github.com/users/mstumpfx/orgs","repos_url":"https://api.github.com/users/mstumpfx/repos","events_url":"https://api.github.com/users/mstumpfx/events{/privacy}","received_events_url":"https://api.github.com/users/mstumpfx/received_events","type":"User","site_admin":false},{"login":"jchengsfx","id":36963516,"node_id":"MDQ6VXNlcjM2OTYzNTE2","avatar_url":"https://avatars2.githubusercontent.com/u/36963516?v=4","gravatar_id":"","url":"https://api.github.com/users/jchengsfx","html_url":"https://github.com/jchengsfx","followers_url":"https://api.github.com/users/jchengsfx/followers","following_url":"https://api.github.com/users/jchengsfx/following{/other_user}","gists_url":"https://api.github.com/users/jchengsfx/gists{/gist_id}","starred_url":"https://api.github.com/users/jchengsfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchengsfx/subscriptions","organizations_url":"https://api.github.com/users/jchengsfx/orgs","repos_url":"https://api.github.com/users/jchengsfx/repos","events_url":"https://api.github.com/users/jchengsfx/events{/privacy}","received_events_url":"https://api.github.com/users/jchengsfx/received_events","type":"User","site_admin":false},{"login":"jaysfx","id":48295775,"node_id":"MDQ6VXNlcjQ4Mjk1Nzc1","avatar_url":"https://avatars2.githubusercontent.com/u/48295775?v=4","gravatar_id":"","url":"https://api.github.com/users/jaysfx","html_url":"https://github.com/jaysfx","followers_url":"https://api.github.com/users/jaysfx/followers","following_url":"https://api.github.com/users/jaysfx/following{/other_user}","gists_url":"https://api.github.com/users/jaysfx/gists{/gist_id}","starred_url":"https://api.github.com/users/jaysfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaysfx/subscriptions","organizations_url":"https://api.github.com/users/jaysfx/orgs","repos_url":"https://api.github.com/users/jaysfx/repos","events_url":"https://api.github.com/users/jaysfx/events{/privacy}","received_events_url":"https://api.github.com/users/jaysfx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/757/commits","review_comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/757/comments","review_comment_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/757/comments","statuses_url":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/0ef9540feec48eb0d79250a530c35d57b80b6683","head":{"label":"phardy:BUILDENG-16540-updating-puppet-apt-class","ref":"BUILDENG-16540-updating-puppet-apt-class","sha":"0ef9540feec48eb0d79250a530c35d57b80b6683","user":{"login":"phardy","id":372919,"node_id":"MDQ6VXNlcjM3MjkxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/372919?v=4","gravatar_id":"","url":"https://api.github.com/users/phardy","html_url":"https://github.com/phardy","followers_url":"https://api.github.com/users/phardy/followers","following_url":"https://api.github.com/users/phardy/following{/other_user}","gists_url":"https://api.github.com/users/phardy/gists{/gist_id}","starred_url":"https://api.github.com/users/phardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phardy/subscriptions","organizations_url":"https://api.github.com/users/phardy/orgs","repos_url":"https://api.github.com/users/phardy/repos","events_url":"https://api.github.com/users/phardy/events{/privacy}","received_events_url":"https://api.github.com/users/phardy/received_events","type":"User","site_admin":false},"repo":{"id":184164225,"node_id":"MDEwOlJlcG9zaXRvcnkxODQxNjQyMjU=","name":"signalfx-agent","full_name":"phardy/signalfx-agent","private":false,"owner":{"login":"phardy","id":372919,"node_id":"MDQ6VXNlcjM3MjkxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/372919?v=4","gravatar_id":"","url":"https://api.github.com/users/phardy","html_url":"https://github.com/phardy","followers_url":"https://api.github.com/users/phardy/followers","following_url":"https://api.github.com/users/phardy/following{/other_user}","gists_url":"https://api.github.com/users/phardy/gists{/gist_id}","starred_url":"https://api.github.com/users/phardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phardy/subscriptions","organizations_url":"https://api.github.com/users/phardy/orgs","repos_url":"https://api.github.com/users/phardy/repos","events_url":"https://api.github.com/users/phardy/events{/privacy}","received_events_url":"https://api.github.com/users/phardy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phardy/signalfx-agent","description":"The SignalFx SmartAgent","fork":true,"url":"https://api.github.com/repos/phardy/signalfx-agent","forks_url":"https://api.github.com/repos/phardy/signalfx-agent/forks","keys_url":"https://api.github.com/repos/phardy/signalfx-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phardy/signalfx-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phardy/signalfx-agent/teams","hooks_url":"https://api.github.com/repos/phardy/signalfx-agent/hooks","issue_events_url":"https://api.github.com/repos/phardy/signalfx-agent/issues/events{/number}","events_url":"https://api.github.com/repos/phardy/signalfx-agent/events","assignees_url":"https://api.github.com/repos/phardy/signalfx-agent/assignees{/user}","branches_url":"https://api.github.com/repos/phardy/signalfx-agent/branches{/branch}","tags_url":"https://api.github.com/repos/phardy/signalfx-agent/tags","blobs_url":"https://api.github.com/repos/phardy/signalfx-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phardy/signalfx-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phardy/signalfx-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/phardy/signalfx-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phardy/signalfx-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/phardy/signalfx-agent/languages","stargazers_url":"https://api.github.com/repos/phardy/signalfx-agent/stargazers","contributors_url":"https://api.github.com/repos/phardy/signalfx-agent/contributors","subscribers_url":"https://api.github.com/repos/phardy/signalfx-agent/subscribers","subscription_url":"https://api.github.com/repos/phardy/signalfx-agent/subscription","commits_url":"https://api.github.com/repos/phardy/signalfx-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/phardy/signalfx-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/phardy/signalfx-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/phardy/signalfx-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/phardy/signalfx-agent/contents/{+path}","compare_url":"https://api.github.com/repos/phardy/signalfx-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phardy/signalfx-agent/merges","archive_url":"https://api.github.com/repos/phardy/signalfx-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phardy/signalfx-agent/downloads","issues_url":"https://api.github.com/repos/phardy/signalfx-agent/issues{/number}","pulls_url":"https://api.github.com/repos/phardy/signalfx-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/phardy/signalfx-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/phardy/signalfx-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phardy/signalfx-agent/labels{/name}","releases_url":"https://api.github.com/repos/phardy/signalfx-agent/releases{/id}","deployments_url":"https://api.github.com/repos/phardy/signalfx-agent/deployments","created_at":"2019-04-30T00:36:55Z","updated_at":"2019-04-30T00:36:59Z","pushed_at":"2019-04-30T05:29:39Z","git_url":"git://github.com/phardy/signalfx-agent.git","ssh_url":"git@github.com:phardy/signalfx-agent.git","clone_url":"https://github.com/phardy/signalfx-agent.git","svn_url":"https://github.com/phardy/signalfx-agent","homepage":"https://signalfx.com","size":19512,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"7f0c6f9b0fa69b99488f8c80554a7b9a758bad7f","user":{"login":"signalfx","id":8184587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODQ1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8184587?v=4","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":80042799,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA0Mjc5OQ==","name":"signalfx-agent","full_name":"signalfx/signalfx-agent","private":false,"owner":{"login":"signalfx","id":8184587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxODQ1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/8184587?v=4","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/signalfx/signalfx-agent","description":"The SignalFx SmartAgent","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-agent","forks_url":"https://api.github.com/repos/signalfx/signalfx-agent/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-agent/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-agent/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-agent/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-agent/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-agent/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-agent/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-agent/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-agent/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-agent/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-agent/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-agent/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-agent/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-agent/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-agent/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-agent/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-agent/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-agent/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-agent/deployments","created_at":"2017-01-25T18:17:17Z","updated_at":"2019-04-30T01:35:04Z","pushed_at":"2019-04-30T02:15:44Z","git_url":"git://github.com/signalfx/signalfx-agent.git","ssh_url":"git@github.com:signalfx/signalfx-agent.git","clone_url":"https://github.com/signalfx/signalfx-agent.git","svn_url":"https://github.com/signalfx/signalfx-agent","homepage":"https://signalfx.com","size":19687,"stargazers_count":28,"watchers_count":28,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":18,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/757"},"html":{"href":"https://github.com/signalfx/signalfx-agent/pull/757"},"issue":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/issues/757"},"comments":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/signalfx-agent/statuses/0ef9540feec48eb0d79250a530c35d57b80b6683"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":18,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"phardy"}}