{"action":"created","comment":{"url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/comments/320702516","pull_request_review_id":283542304,"id":320702516,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDcwMjUxNg==","diff_hunk":"@@ -53,7 +55,7 @@ private async Task<HttpResponseMessage> HandleSubscriptionValidationEventAsync(H\n         {\n             // Parsing the incoming message to a typed EventGrid message\n             var rawRequest = await actionContext.Request.Content.ReadAsStringAsync();\n-            var gridMessage = EventGridParser.Parse<SubscriptionValidation>(rawRequest);\n+            var gridMessage = EventGridParser.Parse<EventGridEvent<SubscriptionValidationEventData>>(rawRequest);","path":"src/Arcus.EventGrid.Security/EventGridSubscriptionValidator.cs","position":16,"original_position":16,"commit_id":"85797b29b844388d426ba231a9c762a0518a493f","original_commit_id":"cdcce61e47cdd4f27e544d425e3dc826c41c3768","user":{"login":"tomkerkhove","id":4345663,"node_id":"MDQ6VXNlcjQzNDU2NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4345663?v=4","gravatar_id":"","url":"https://api.github.com/users/tomkerkhove","html_url":"https://github.com/tomkerkhove","followers_url":"https://api.github.com/users/tomkerkhove/followers","following_url":"https://api.github.com/users/tomkerkhove/following{/other_user}","gists_url":"https://api.github.com/users/tomkerkhove/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkerkhove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkerkhove/subscriptions","organizations_url":"https://api.github.com/users/tomkerkhove/orgs","repos_url":"https://api.github.com/users/tomkerkhove/repos","events_url":"https://api.github.com/users/tomkerkhove/events{/privacy}","received_events_url":"https://api.github.com/users/tomkerkhove/received_events","type":"User","site_admin":false},"body":"I'm not sure if I'm following - Why does it matter if it's one of our events or one provided by MSFT?\r\nIt feels like duplication, without added value, to specify `EventGridEvent` every time given we are already using `EventGridParser`","created_at":"2019-09-04T11:15:17Z","updated_at":"2019-09-04T11:15:20Z","html_url":"https://github.com/arcus-azure/arcus.eventgrid/pull/82#discussion_r320702516","pull_request_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/comments/320702516"},"html":{"href":"https://github.com/arcus-azure/arcus.eventgrid/pull/82#discussion_r320702516"},"pull_request":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82"}},"in_reply_to_id":320230061},"pull_request":{"url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82","id":307213148,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3MjEzMTQ4","html_url":"https://github.com/arcus-azure/arcus.eventgrid/pull/82","diff_url":"https://github.com/arcus-azure/arcus.eventgrid/pull/82.diff","patch_url":"https://github.com/arcus-azure/arcus.eventgrid/pull/82.patch","issue_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues/82","number":82,"state":"open","locked":false,"title":"REFACTOR: support official Azure schemas alongside our own","user":{"login":"stijnmoreels","id":9039753,"node_id":"MDQ6VXNlcjkwMzk3NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9039753?v=4","gravatar_id":"","url":"https://api.github.com/users/stijnmoreels","html_url":"https://github.com/stijnmoreels","followers_url":"https://api.github.com/users/stijnmoreels/followers","following_url":"https://api.github.com/users/stijnmoreels/following{/other_user}","gists_url":"https://api.github.com/users/stijnmoreels/gists{/gist_id}","starred_url":"https://api.github.com/users/stijnmoreels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stijnmoreels/subscriptions","organizations_url":"https://api.github.com/users/stijnmoreels/orgs","repos_url":"https://api.github.com/users/stijnmoreels/repos","events_url":"https://api.github.com/users/stijnmoreels/events{/privacy}","received_events_url":"https://api.github.com/users/stijnmoreels/received_events","type":"User","site_admin":false},"body":"Provide a way so custom event implementations with our EventGrid package\r\nare compatible with the official Azure schemas.\r\n\r\nMake the concrete event types that are now present in the repo obsolete.\r\n\r\nRelates to #46","created_at":"2019-08-14T08:01:05Z","updated_at":"2019-09-04T11:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b52147a3006e6ad5264ce675d7b0e7c30d013f3c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SamVanhoutte","id":3539605,"node_id":"MDQ6VXNlcjM1Mzk2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3539605?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVanhoutte","html_url":"https://github.com/SamVanhoutte","followers_url":"https://api.github.com/users/SamVanhoutte/followers","following_url":"https://api.github.com/users/SamVanhoutte/following{/other_user}","gists_url":"https://api.github.com/users/SamVanhoutte/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVanhoutte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVanhoutte/subscriptions","organizations_url":"https://api.github.com/users/SamVanhoutte/orgs","repos_url":"https://api.github.com/users/SamVanhoutte/repos","events_url":"https://api.github.com/users/SamVanhoutte/events{/privacy}","received_events_url":"https://api.github.com/users/SamVanhoutte/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82/commits","review_comments_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82/comments","review_comment_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues/82/comments","statuses_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/statuses/85797b29b844388d426ba231a9c762a0518a493f","head":{"label":"stijnmoreels:refactor/support-official-schemas","ref":"refactor/support-official-schemas","sha":"85797b29b844388d426ba231a9c762a0518a493f","user":{"login":"stijnmoreels","id":9039753,"node_id":"MDQ6VXNlcjkwMzk3NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9039753?v=4","gravatar_id":"","url":"https://api.github.com/users/stijnmoreels","html_url":"https://github.com/stijnmoreels","followers_url":"https://api.github.com/users/stijnmoreels/followers","following_url":"https://api.github.com/users/stijnmoreels/following{/other_user}","gists_url":"https://api.github.com/users/stijnmoreels/gists{/gist_id}","starred_url":"https://api.github.com/users/stijnmoreels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stijnmoreels/subscriptions","organizations_url":"https://api.github.com/users/stijnmoreels/orgs","repos_url":"https://api.github.com/users/stijnmoreels/repos","events_url":"https://api.github.com/users/stijnmoreels/events{/privacy}","received_events_url":"https://api.github.com/users/stijnmoreels/received_events","type":"User","site_admin":false},"repo":{"id":154316489,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzMTY0ODk=","name":"arcus.eventgrid","full_name":"stijnmoreels/arcus.eventgrid","private":false,"owner":{"login":"stijnmoreels","id":9039753,"node_id":"MDQ6VXNlcjkwMzk3NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9039753?v=4","gravatar_id":"","url":"https://api.github.com/users/stijnmoreels","html_url":"https://github.com/stijnmoreels","followers_url":"https://api.github.com/users/stijnmoreels/followers","following_url":"https://api.github.com/users/stijnmoreels/following{/other_user}","gists_url":"https://api.github.com/users/stijnmoreels/gists{/gist_id}","starred_url":"https://api.github.com/users/stijnmoreels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stijnmoreels/subscriptions","organizations_url":"https://api.github.com/users/stijnmoreels/orgs","repos_url":"https://api.github.com/users/stijnmoreels/repos","events_url":"https://api.github.com/users/stijnmoreels/events{/privacy}","received_events_url":"https://api.github.com/users/stijnmoreels/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stijnmoreels/arcus.eventgrid","description":"Azure Event Grid development in a breeze","fork":true,"url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid","forks_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/forks","keys_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/teams","hooks_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/hooks","issue_events_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/issues/events{/number}","events_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/events","assignees_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/assignees{/user}","branches_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/branches{/branch}","tags_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/tags","blobs_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/languages","stargazers_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/stargazers","contributors_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/contributors","subscribers_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/subscribers","subscription_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/subscription","commits_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/contents/{+path}","compare_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/merges","archive_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/downloads","issues_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/issues{/number}","pulls_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/labels{/name}","releases_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/releases{/id}","deployments_url":"https://api.github.com/repos/stijnmoreels/arcus.eventgrid/deployments","created_at":"2018-10-23T11:30:34Z","updated_at":"2019-08-21T11:11:43Z","pushed_at":"2019-09-04T06:28:51Z","git_url":"git://github.com/stijnmoreels/arcus.eventgrid.git","ssh_url":"git@github.com:stijnmoreels/arcus.eventgrid.git","clone_url":"https://github.com/stijnmoreels/arcus.eventgrid.git","svn_url":"https://github.com/stijnmoreels/arcus.eventgrid","homepage":"","size":1240,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arcus-azure:master","ref":"master","sha":"77bf311629d451f43e7ab9b786fbe16087448bf5","user":{"login":"arcus-azure","id":38918889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTE4ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/38918889?v=4","gravatar_id":"","url":"https://api.github.com/users/arcus-azure","html_url":"https://github.com/arcus-azure","followers_url":"https://api.github.com/users/arcus-azure/followers","following_url":"https://api.github.com/users/arcus-azure/following{/other_user}","gists_url":"https://api.github.com/users/arcus-azure/gists{/gist_id}","starred_url":"https://api.github.com/users/arcus-azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcus-azure/subscriptions","organizations_url":"https://api.github.com/users/arcus-azure/orgs","repos_url":"https://api.github.com/users/arcus-azure/repos","events_url":"https://api.github.com/users/arcus-azure/events{/privacy}","received_events_url":"https://api.github.com/users/arcus-azure/received_events","type":"Organization","site_admin":false},"repo":{"id":132166986,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxNjY5ODY=","name":"arcus.eventgrid","full_name":"arcus-azure/arcus.eventgrid","private":false,"owner":{"login":"arcus-azure","id":38918889,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTE4ODg5","avatar_url":"https://avatars2.githubusercontent.com/u/38918889?v=4","gravatar_id":"","url":"https://api.github.com/users/arcus-azure","html_url":"https://github.com/arcus-azure","followers_url":"https://api.github.com/users/arcus-azure/followers","following_url":"https://api.github.com/users/arcus-azure/following{/other_user}","gists_url":"https://api.github.com/users/arcus-azure/gists{/gist_id}","starred_url":"https://api.github.com/users/arcus-azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcus-azure/subscriptions","organizations_url":"https://api.github.com/users/arcus-azure/orgs","repos_url":"https://api.github.com/users/arcus-azure/repos","events_url":"https://api.github.com/users/arcus-azure/events{/privacy}","received_events_url":"https://api.github.com/users/arcus-azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arcus-azure/arcus.eventgrid","description":"Azure Event Grid development in a breeze","fork":false,"url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid","forks_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/forks","keys_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/teams","hooks_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/hooks","issue_events_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues/events{/number}","events_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/events","assignees_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/assignees{/user}","branches_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/branches{/branch}","tags_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/tags","blobs_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/languages","stargazers_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/stargazers","contributors_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/contributors","subscribers_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/subscribers","subscription_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/subscription","commits_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/contents/{+path}","compare_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/merges","archive_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/downloads","issues_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues{/number}","pulls_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/labels{/name}","releases_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/releases{/id}","deployments_url":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/deployments","created_at":"2018-05-04T17:00:23Z","updated_at":"2019-08-28T11:39:01Z","pushed_at":"2019-09-04T06:28:53Z","git_url":"git://github.com/arcus-azure/arcus.eventgrid.git","ssh_url":"git@github.com:arcus-azure/arcus.eventgrid.git","clone_url":"https://github.com/arcus-azure/arcus.eventgrid.git","svn_url":"https://github.com/arcus-azure/arcus.eventgrid","homepage":"https://eventgrid.arcus-azure.net/","size":1153,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":8,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82"},"html":{"href":"https://github.com/arcus-azure/arcus.eventgrid/pull/82"},"issue":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues/82"},"comments":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/arcus-azure/arcus.eventgrid/statuses/85797b29b844388d426ba231a9c762a0518a493f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tomkerkhove"}}