{"action":"opened","issue":{"url":"https://api.github.com/repos/awslabs/aws-deployment-framework/issues/23","repository_url":"https://api.github.com/repos/awslabs/aws-deployment-framework","labels_url":"https://api.github.com/repos/awslabs/aws-deployment-framework/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/awslabs/aws-deployment-framework/issues/23/comments","events_url":"https://api.github.com/repos/awslabs/aws-deployment-framework/issues/23/events","html_url":"https://github.com/awslabs/aws-deployment-framework/issues/23","id":427895363,"node_id":"MDU6SXNzdWU0Mjc4OTUzNjM=","number":23,"title":"Insecure bucket/key policy?","user":{"login":"itsdalmo","id":6603877,"node_id":"MDQ6VXNlcjY2MDM4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/6603877?v=4","gravatar_id":"","url":"https://api.github.com/users/itsdalmo","html_url":"https://github.com/itsdalmo","followers_url":"https://api.github.com/users/itsdalmo/followers","following_url":"https://api.github.com/users/itsdalmo/following{/other_user}","gists_url":"https://api.github.com/users/itsdalmo/gists{/gist_id}","starred_url":"https://api.github.com/users/itsdalmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsdalmo/subscriptions","organizations_url":"https://api.github.com/users/itsdalmo/orgs","repos_url":"https://api.github.com/users/itsdalmo/repos","events_url":"https://api.github.com/users/itsdalmo/events{/privacy}","received_events_url":"https://api.github.com/users/itsdalmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-04-01T20:23:22Z","updated_at":"2019-04-01T20:23:22Z","closed_at":null,"author_association":"NONE","body":"Just noticed some `aws:PrincipalOrgID` use which I think might be unintended:\r\n- [S3 bucket policy](https://github.com/awslabs/aws-deployment-framework/blob/master/src/bootstrap_repository/deployment/global.yml#L613)\r\n- [KMS key policy](https://github.com/awslabs/aws-deployment-framework/blob/master/src/bootstrap_repository/deployment/global.yml#L104)\r\n\r\nThe way I understand this condition when used on a bucket/key policy, it actually gives any account in the organisation said privileges. Which means that all accounts in the org is given `s3:Put*` (which includes `s3:PutBucketPolicy` and friends) on the bucket and `kms:Decrypt` on the key - if I've understood this correctly it should probably be fixed?"}}
{"actor":{"display_login":"itsdalmo"}}