{"action":"closed","number":121,"pull_request":{"url":"https://api.github.com/repos/ambientsound/pms/pulls/121","id":347218765,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjE4NzY1","html_url":"https://github.com/ambientsound/pms/pull/121","diff_url":"https://github.com/ambientsound/pms/pull/121.diff","patch_url":"https://github.com/ambientsound/pms/pull/121.patch","issue_url":"https://api.github.com/repos/ambientsound/pms/issues/121","number":121,"state":"closed","locked":false,"title":"Fix build","user":{"login":"codesoap","id":42150522,"node_id":"MDQ6VXNlcjQyMTUwNTIy","avatar_url":"https://avatars3.githubusercontent.com/u/42150522?v=4","gravatar_id":"","url":"https://api.github.com/users/codesoap","html_url":"https://github.com/codesoap","followers_url":"https://api.github.com/users/codesoap/followers","following_url":"https://api.github.com/users/codesoap/following{/other_user}","gists_url":"https://api.github.com/users/codesoap/gists{/gist_id}","starred_url":"https://api.github.com/users/codesoap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesoap/subscriptions","organizations_url":"https://api.github.com/users/codesoap/orgs","repos_url":"https://api.github.com/users/codesoap/repos","events_url":"https://api.github.com/users/codesoap/events{/privacy}","received_events_url":"https://api.github.com/users/codesoap/received_events","type":"User","site_admin":false},"body":"The `go get ...` calls in the Makefile were updating go.mod, which led to build errors:\r\n```\r\ngo get github.com/ambientsound/gompd/mpd\r\ngo: finding github.com/ambientsound/gompd latest\r\ngo get github.com/blevesearch/bleve\r\ngo: finding github.com/mschoch/smat latest\r\ngo: finding golang.org/x/sys latest\r\n# github.com/blevesearch/bleve/index/scorch/segment/zap\r\n../../../../pkg/mod/github.com/blevesearch/bleve@v0.8.1/index/scorch/segment/zap/posting.go:327:11: undefined: roaring.IntPeekable\r\n../../../../pkg/mod/github.com/blevesearch/bleve@v0.8.1/index/scorch/segment/zap/posting.go:328:11: undefined: roaring.IntPeekable\r\ngmake: *** [Makefile:15: get-deps] Error 2\r\n```\r\n\r\nThe go.mod will get dependencies, so I if I understand it correctly, there is no need to get them \"manually\".\r\n\r\nThis was the diff after `make`, without my changes:\r\n```diff\r\ndiff --git a/go.mod b/go.mod\r\nindex 6f33fd3..1ad2671 100644\r\n--- a/go.mod\r\n+++ b/go.mod\r\n@@ -4,13 +4,14 @@ require (\r\n        github.com/RoaringBitmap/roaring v0.4.16 // indirect\r\n        github.com/Smerity/govarint v0.0.0-20150407073650-7265e41f48f1 // indirect\r\n        github.com/ambientsound/gompd v0.0.0-20170427084842-b065d40b8238\r\n-       github.com/blevesearch/bleve v0.7.0\r\n+       github.com/blevesearch/bleve v0.8.1\r\n        github.com/blevesearch/go-porterstemmer v1.0.1 // indirect\r\n        github.com/blevesearch/segment v0.0.0-20160915185041-762005e7a34f // indirect\r\n        github.com/boltdb/bolt v1.3.1 // indirect\r\n        github.com/couchbase/vellum v0.0.0-20180906200449-35d9e7346a69 // indirect\r\n        github.com/davecgh/go-spew v1.1.1 // indirect\r\n        github.com/edsrzf/mmap-go v0.0.0-20170320065105-0bce6a688712 // indirect\r\n+       github.com/etcd-io/bbolt v1.3.3 // indirect\r\n        github.com/gdamore/encoding v0.0.0-20151215212835-b23993cbb635 // indirect\r\n        github.com/gdamore/tcell v1.1.0\r\n        github.com/glycerine/go-unsnap-stream v0.0.0-20180323001048-9f0cb55181dd // indirect\r\n@@ -19,6 +20,7 @@ require (\r\n        github.com/jessevdk/go-flags v1.4.0\r\n        github.com/lucasb-eyer/go-colorful v0.0.0-20180709185858-c7842319cf3a // indirect\r\n        github.com/mattn/go-runewidth v0.0.3 // indirect\r\n+       github.com/mschoch/smat v0.0.0-20160514031455-90eadee771ae // indirect\r\n        github.com/philhofer/fwd v1.0.0 // indirect\r\n        github.com/pmezard/go-difflib v1.0.0 // indirect\r\n        github.com/steveyen/gtreap v0.0.0-20150807155958-0abe01ef9be2 // indirect\r\n@@ -26,5 +28,8 @@ require (\r\n        github.com/tinylib/msgp v1.0.2 // indirect\r\n        github.com/willf/bitset v1.1.9 // indirect\r\n        golang.org/x/net v0.0.0-20180906233101-161cd47e91fd // indirect\r\n+       golang.org/x/sys v0.0.0-20191128015809-6d18c012aee9 // indirect\r\n        golang.org/x/text v0.3.0\r\n )\r\n+\r\n+go 1.13\r\n```","created_at":"2019-11-30T12:02:13Z","updated_at":"2019-12-02T10:58:01Z","closed_at":"2019-12-02T10:58:01Z","merged_at":"2019-12-02T10:58:01Z","merge_commit_sha":"92ba77ce58aa65e624038e9d8e03153410ecd6bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ambientsound/pms/pulls/121/commits","review_comments_url":"https://api.github.com/repos/ambientsound/pms/pulls/121/comments","review_comment_url":"https://api.github.com/repos/ambientsound/pms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ambientsound/pms/issues/121/comments","statuses_url":"https://api.github.com/repos/ambientsound/pms/statuses/616bbb8847af250f1fdedae7e7c1cad6ea4ca034","head":{"label":"codesoap:master","ref":"master","sha":"616bbb8847af250f1fdedae7e7c1cad6ea4ca034","user":{"login":"codesoap","id":42150522,"node_id":"MDQ6VXNlcjQyMTUwNTIy","avatar_url":"https://avatars3.githubusercontent.com/u/42150522?v=4","gravatar_id":"","url":"https://api.github.com/users/codesoap","html_url":"https://github.com/codesoap","followers_url":"https://api.github.com/users/codesoap/followers","following_url":"https://api.github.com/users/codesoap/following{/other_user}","gists_url":"https://api.github.com/users/codesoap/gists{/gist_id}","starred_url":"https://api.github.com/users/codesoap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesoap/subscriptions","organizations_url":"https://api.github.com/users/codesoap/orgs","repos_url":"https://api.github.com/users/codesoap/repos","events_url":"https://api.github.com/users/codesoap/events{/privacy}","received_events_url":"https://api.github.com/users/codesoap/received_events","type":"User","site_admin":false},"repo":{"id":224992772,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ5OTI3NzI=","name":"pms","full_name":"codesoap/pms","private":false,"owner":{"login":"codesoap","id":42150522,"node_id":"MDQ6VXNlcjQyMTUwNTIy","avatar_url":"https://avatars3.githubusercontent.com/u/42150522?v=4","gravatar_id":"","url":"https://api.github.com/users/codesoap","html_url":"https://github.com/codesoap","followers_url":"https://api.github.com/users/codesoap/followers","following_url":"https://api.github.com/users/codesoap/following{/other_user}","gists_url":"https://api.github.com/users/codesoap/gists{/gist_id}","starred_url":"https://api.github.com/users/codesoap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesoap/subscriptions","organizations_url":"https://api.github.com/users/codesoap/orgs","repos_url":"https://api.github.com/users/codesoap/repos","events_url":"https://api.github.com/users/codesoap/events{/privacy}","received_events_url":"https://api.github.com/users/codesoap/received_events","type":"User","site_admin":false},"html_url":"https://github.com/codesoap/pms","description":"Practical Music Search is an interactive Vim-like console client for the Music Player Daemon.","fork":true,"url":"https://api.github.com/repos/codesoap/pms","forks_url":"https://api.github.com/repos/codesoap/pms/forks","keys_url":"https://api.github.com/repos/codesoap/pms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codesoap/pms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codesoap/pms/teams","hooks_url":"https://api.github.com/repos/codesoap/pms/hooks","issue_events_url":"https://api.github.com/repos/codesoap/pms/issues/events{/number}","events_url":"https://api.github.com/repos/codesoap/pms/events","assignees_url":"https://api.github.com/repos/codesoap/pms/assignees{/user}","branches_url":"https://api.github.com/repos/codesoap/pms/branches{/branch}","tags_url":"https://api.github.com/repos/codesoap/pms/tags","blobs_url":"https://api.github.com/repos/codesoap/pms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codesoap/pms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codesoap/pms/git/refs{/sha}","trees_url":"https://api.github.com/repos/codesoap/pms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codesoap/pms/statuses/{sha}","languages_url":"https://api.github.com/repos/codesoap/pms/languages","stargazers_url":"https://api.github.com/repos/codesoap/pms/stargazers","contributors_url":"https://api.github.com/repos/codesoap/pms/contributors","subscribers_url":"https://api.github.com/repos/codesoap/pms/subscribers","subscription_url":"https://api.github.com/repos/codesoap/pms/subscription","commits_url":"https://api.github.com/repos/codesoap/pms/commits{/sha}","git_commits_url":"https://api.github.com/repos/codesoap/pms/git/commits{/sha}","comments_url":"https://api.github.com/repos/codesoap/pms/comments{/number}","issue_comment_url":"https://api.github.com/repos/codesoap/pms/issues/comments{/number}","contents_url":"https://api.github.com/repos/codesoap/pms/contents/{+path}","compare_url":"https://api.github.com/repos/codesoap/pms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codesoap/pms/merges","archive_url":"https://api.github.com/repos/codesoap/pms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codesoap/pms/downloads","issues_url":"https://api.github.com/repos/codesoap/pms/issues{/number}","pulls_url":"https://api.github.com/repos/codesoap/pms/pulls{/number}","milestones_url":"https://api.github.com/repos/codesoap/pms/milestones{/number}","notifications_url":"https://api.github.com/repos/codesoap/pms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codesoap/pms/labels{/name}","releases_url":"https://api.github.com/repos/codesoap/pms/releases{/id}","deployments_url":"https://api.github.com/repos/codesoap/pms/deployments","created_at":"2019-11-30T10:05:37Z","updated_at":"2019-11-30T11:58:18Z","pushed_at":"2019-11-30T11:58:15Z","git_url":"git://github.com/codesoap/pms.git","ssh_url":"git@github.com:codesoap/pms.git","clone_url":"https://github.com/codesoap/pms.git","svn_url":"https://github.com/codesoap/pms","homepage":"https://ambientsound.github.io/pms/","size":3083,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ambientsound:master","ref":"master","sha":"000c5c0b5b51d0a82621ca0d94577b812cb98701","user":{"login":"ambientsound","id":791756,"node_id":"MDQ6VXNlcjc5MTc1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/791756?v=4","gravatar_id":"","url":"https://api.github.com/users/ambientsound","html_url":"https://github.com/ambientsound","followers_url":"https://api.github.com/users/ambientsound/followers","following_url":"https://api.github.com/users/ambientsound/following{/other_user}","gists_url":"https://api.github.com/users/ambientsound/gists{/gist_id}","starred_url":"https://api.github.com/users/ambientsound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambientsound/subscriptions","organizations_url":"https://api.github.com/users/ambientsound/orgs","repos_url":"https://api.github.com/users/ambientsound/repos","events_url":"https://api.github.com/users/ambientsound/events{/privacy}","received_events_url":"https://api.github.com/users/ambientsound/received_events","type":"User","site_admin":false},"repo":{"id":2511073,"node_id":"MDEwOlJlcG9zaXRvcnkyNTExMDcz","name":"pms","full_name":"ambientsound/pms","private":false,"owner":{"login":"ambientsound","id":791756,"node_id":"MDQ6VXNlcjc5MTc1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/791756?v=4","gravatar_id":"","url":"https://api.github.com/users/ambientsound","html_url":"https://github.com/ambientsound","followers_url":"https://api.github.com/users/ambientsound/followers","following_url":"https://api.github.com/users/ambientsound/following{/other_user}","gists_url":"https://api.github.com/users/ambientsound/gists{/gist_id}","starred_url":"https://api.github.com/users/ambientsound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambientsound/subscriptions","organizations_url":"https://api.github.com/users/ambientsound/orgs","repos_url":"https://api.github.com/users/ambientsound/repos","events_url":"https://api.github.com/users/ambientsound/events{/privacy}","received_events_url":"https://api.github.com/users/ambientsound/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ambientsound/pms","description":"Practical Music Search is an interactive Vim-like console client for the Music Player Daemon.","fork":false,"url":"https://api.github.com/repos/ambientsound/pms","forks_url":"https://api.github.com/repos/ambientsound/pms/forks","keys_url":"https://api.github.com/repos/ambientsound/pms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ambientsound/pms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ambientsound/pms/teams","hooks_url":"https://api.github.com/repos/ambientsound/pms/hooks","issue_events_url":"https://api.github.com/repos/ambientsound/pms/issues/events{/number}","events_url":"https://api.github.com/repos/ambientsound/pms/events","assignees_url":"https://api.github.com/repos/ambientsound/pms/assignees{/user}","branches_url":"https://api.github.com/repos/ambientsound/pms/branches{/branch}","tags_url":"https://api.github.com/repos/ambientsound/pms/tags","blobs_url":"https://api.github.com/repos/ambientsound/pms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ambientsound/pms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ambientsound/pms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ambientsound/pms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ambientsound/pms/statuses/{sha}","languages_url":"https://api.github.com/repos/ambientsound/pms/languages","stargazers_url":"https://api.github.com/repos/ambientsound/pms/stargazers","contributors_url":"https://api.github.com/repos/ambientsound/pms/contributors","subscribers_url":"https://api.github.com/repos/ambientsound/pms/subscribers","subscription_url":"https://api.github.com/repos/ambientsound/pms/subscription","commits_url":"https://api.github.com/repos/ambientsound/pms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ambientsound/pms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ambientsound/pms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ambientsound/pms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ambientsound/pms/contents/{+path}","compare_url":"https://api.github.com/repos/ambientsound/pms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ambientsound/pms/merges","archive_url":"https://api.github.com/repos/ambientsound/pms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ambientsound/pms/downloads","issues_url":"https://api.github.com/repos/ambientsound/pms/issues{/number}","pulls_url":"https://api.github.com/repos/ambientsound/pms/pulls{/number}","milestones_url":"https://api.github.com/repos/ambientsound/pms/milestones{/number}","notifications_url":"https://api.github.com/repos/ambientsound/pms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ambientsound/pms/labels{/name}","releases_url":"https://api.github.com/repos/ambientsound/pms/releases{/id}","deployments_url":"https://api.github.com/repos/ambientsound/pms/deployments","created_at":"2011-10-04T10:14:58Z","updated_at":"2019-11-05T14:21:59Z","pushed_at":"2019-12-02T10:58:01Z","git_url":"git://github.com/ambientsound/pms.git","ssh_url":"git@github.com:ambientsound/pms.git","clone_url":"https://github.com/ambientsound/pms.git","svn_url":"https://github.com/ambientsound/pms","homepage":"https://ambientsound.github.io/pms/","size":3090,"stargazers_count":133,"watchers_count":133,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":36,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ambientsound/pms/pulls/121"},"html":{"href":"https://github.com/ambientsound/pms/pull/121"},"issue":{"href":"https://api.github.com/repos/ambientsound/pms/issues/121"},"comments":{"href":"https://api.github.com/repos/ambientsound/pms/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/ambientsound/pms/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/ambientsound/pms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ambientsound/pms/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/ambientsound/pms/statuses/616bbb8847af250f1fdedae7e7c1cad6ea4ca034"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ambientsound","id":791756,"node_id":"MDQ6VXNlcjc5MTc1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/791756?v=4","gravatar_id":"","url":"https://api.github.com/users/ambientsound","html_url":"https://github.com/ambientsound","followers_url":"https://api.github.com/users/ambientsound/followers","following_url":"https://api.github.com/users/ambientsound/following{/other_user}","gists_url":"https://api.github.com/users/ambientsound/gists{/gist_id}","starred_url":"https://api.github.com/users/ambientsound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambientsound/subscriptions","organizations_url":"https://api.github.com/users/ambientsound/orgs","repos_url":"https://api.github.com/users/ambientsound/repos","events_url":"https://api.github.com/users/ambientsound/events{/privacy}","received_events_url":"https://api.github.com/users/ambientsound/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"ambientsound"}}