{"action":"closed","number":7518,"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/7518","id":294555367,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NTU1MzY3","html_url":"https://github.com/salesagility/SuiteCRM/pull/7518","diff_url":"https://github.com/salesagility/SuiteCRM/pull/7518.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/7518.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/7518","number":7518,"state":"closed","locked":false,"title":"Fixed #7407 - \"Users may send as themselves\" broken - Invalid address: (punyEncode)","user":{"login":"Dillon-Brown","id":26431166,"node_id":"MDQ6VXNlcjI2NDMxMTY2","avatar_url":"https://avatars0.githubusercontent.com/u/26431166?v=4","gravatar_id":"","url":"https://api.github.com/users/Dillon-Brown","html_url":"https://github.com/Dillon-Brown","followers_url":"https://api.github.com/users/Dillon-Brown/followers","following_url":"https://api.github.com/users/Dillon-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dillon-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dillon-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dillon-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dillon-Brown/orgs","repos_url":"https://api.github.com/users/Dillon-Brown/repos","events_url":"https://api.github.com/users/Dillon-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dillon-Brown/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\nFixed an issue where the from and reply to address would be formatted incorrectly preventing emails from being sent.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nIssue reference: #7407 \r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n1. Create a system outbound email.\r\n2. Add an email address to user profile (Profile edit view, not profile email settings).\r\n3. Compose an email and check that the username is not duplicated and the email sends correctly.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [X] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [ ] My change requires a change to the documentation.\r\n- [X] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2019-07-04T12:12:40Z","updated_at":"2019-07-04T16:31:09Z","closed_at":"2019-07-04T16:31:09Z","merged_at":"2019-07-04T16:31:09Z","merge_commit_sha":"f1adecfa00d44f52dd51b97f48d5cd9994a1fef5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":488084356,"node_id":"MDU6TGFiZWw0ODgwODQzNTY=","url":"https://api.github.com/repos/salesagility/SuiteCRM/labels/Assessed","name":"Assessed","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/7518/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/7518/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/7518/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/b6e370234d36ccbb8cea1648687922efc4466f7d","head":{"label":"Dillon-Brown:issue-7407","ref":"issue-7407","sha":"b6e370234d36ccbb8cea1648687922efc4466f7d","user":{"login":"Dillon-Brown","id":26431166,"node_id":"MDQ6VXNlcjI2NDMxMTY2","avatar_url":"https://avatars0.githubusercontent.com/u/26431166?v=4","gravatar_id":"","url":"https://api.github.com/users/Dillon-Brown","html_url":"https://github.com/Dillon-Brown","followers_url":"https://api.github.com/users/Dillon-Brown/followers","following_url":"https://api.github.com/users/Dillon-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dillon-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dillon-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dillon-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dillon-Brown/orgs","repos_url":"https://api.github.com/users/Dillon-Brown/repos","events_url":"https://api.github.com/users/Dillon-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dillon-Brown/received_events","type":"User","site_admin":false},"repo":{"id":86339345,"node_id":"MDEwOlJlcG9zaXRvcnk4NjMzOTM0NQ==","name":"SuiteCRM","full_name":"Dillon-Brown/SuiteCRM","private":false,"owner":{"login":"Dillon-Brown","id":26431166,"node_id":"MDQ6VXNlcjI2NDMxMTY2","avatar_url":"https://avatars0.githubusercontent.com/u/26431166?v=4","gravatar_id":"","url":"https://api.github.com/users/Dillon-Brown","html_url":"https://github.com/Dillon-Brown","followers_url":"https://api.github.com/users/Dillon-Brown/followers","following_url":"https://api.github.com/users/Dillon-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dillon-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dillon-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dillon-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dillon-Brown/orgs","repos_url":"https://api.github.com/users/Dillon-Brown/repos","events_url":"https://api.github.com/users/Dillon-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dillon-Brown/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Dillon-Brown/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM","forks_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/forks","keys_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/events","assignees_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/merges","archive_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/Dillon-Brown/SuiteCRM/deployments","created_at":"2017-03-27T13:34:42Z","updated_at":"2019-05-29T09:23:32Z","pushed_at":"2019-07-04T16:06:52Z","git_url":"git://github.com/Dillon-Brown/SuiteCRM.git","ssh_url":"git@github.com:Dillon-Brown/SuiteCRM.git","clone_url":"https://github.com/Dillon-Brown/SuiteCRM.git","svn_url":"https://github.com/Dillon-Brown/SuiteCRM","homepage":"http://www.suitecrm.com","size":127215,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix-7.10.x","ref":"hotfix-7.10.x","sha":"ba1f514841a4d421c850aedc0d55cc3b939bb548","user":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0NDYwMA==","name":"SuiteCRM","full_name":"salesagility/SuiteCRM","private":false,"owner":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2019-07-04T16:08:03Z","pushed_at":"2019-07-04T16:31:09Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"https://www.suitecrm.com","size":116466,"stargazers_count":1523,"watchers_count":1523,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1064,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":935,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1064,"open_issues":935,"watchers":1523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/7518"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/7518"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/7518"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/7518/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/7518/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/7518/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/b6e370234d36ccbb8cea1648687922efc4466f7d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Dillon-Brown","id":26431166,"node_id":"MDQ6VXNlcjI2NDMxMTY2","avatar_url":"https://avatars0.githubusercontent.com/u/26431166?v=4","gravatar_id":"","url":"https://api.github.com/users/Dillon-Brown","html_url":"https://github.com/Dillon-Brown","followers_url":"https://api.github.com/users/Dillon-Brown/followers","following_url":"https://api.github.com/users/Dillon-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dillon-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dillon-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dillon-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dillon-Brown/orgs","repos_url":"https://api.github.com/users/Dillon-Brown/repos","events_url":"https://api.github.com/users/Dillon-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dillon-Brown/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Dillon-Brown"}}