{"action":"created","issue":{"url":"https://api.github.com/repos/zeromq/libzmq/issues/1451","repository_url":"https://api.github.com/repos/zeromq/libzmq","labels_url":"https://api.github.com/repos/zeromq/libzmq/issues/1451/labels{/name}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/1451/comments","events_url":"https://api.github.com/repos/zeromq/libzmq/issues/1451/events","html_url":"https://github.com/zeromq/libzmq/pull/1451","id":91327865,"node_id":"MDExOlB1bGxSZXF1ZXN0Mzg2NzY0MzA=","number":1451,"title":"Fix units and default values for heartbeats options","user":{"login":"jbreams","id":191185,"node_id":"MDQ6VXNlcjE5MTE4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/191185?v=4","gravatar_id":"","url":"https://api.github.com/users/jbreams","html_url":"https://github.com/jbreams","followers_url":"https://api.github.com/users/jbreams/followers","following_url":"https://api.github.com/users/jbreams/following{/other_user}","gists_url":"https://api.github.com/users/jbreams/gists{/gist_id}","starred_url":"https://api.github.com/users/jbreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbreams/subscriptions","organizations_url":"https://api.github.com/users/jbreams/orgs","repos_url":"https://api.github.com/users/jbreams/repos","events_url":"https://api.github.com/users/jbreams/events{/privacy}","received_events_url":"https://api.github.com/users/jbreams/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-06-26T18:29:01Z","updated_at":"2019-08-31T13:56:16Z","closed_at":"2015-06-26T18:31:46Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/1451","html_url":"https://github.com/zeromq/libzmq/pull/1451","diff_url":"https://github.com/zeromq/libzmq/pull/1451.diff","patch_url":"https://github.com/zeromq/libzmq/pull/1451.patch"},"body":"This patch fixes some feedback from the last heartbeats PR and from the zeromq-devel mailing list.\n\nSet the ZMQ_HEARTBEAT_TIMEOUT to default to the value of\nZMQ_HEARTBEAT_IVL if it's not explicitly set.\nChange the units of ZMQ_HEARTBEAT_TTL to milliseconds in the API\nand round down to the nearest decisecond so that all the options\nare using the same units.\nMake the maximum heartbeat TTL match the spec (6553 seconds)\n"},"comment":{"url":"https://api.github.com/repos/zeromq/libzmq/issues/comments/526832616","html_url":"https://github.com/zeromq/libzmq/pull/1451#issuecomment-526832616","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/1451","id":526832616,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNjgzMjYxNg==","user":{"login":"jbreams","id":191185,"node_id":"MDQ6VXNlcjE5MTE4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/191185?v=4","gravatar_id":"","url":"https://api.github.com/users/jbreams","html_url":"https://github.com/jbreams","followers_url":"https://api.github.com/users/jbreams/followers","following_url":"https://api.github.com/users/jbreams/following{/other_user}","gists_url":"https://api.github.com/users/jbreams/gists{/gist_id}","starred_url":"https://api.github.com/users/jbreams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbreams/subscriptions","organizations_url":"https://api.github.com/users/jbreams/orgs","repos_url":"https://api.github.com/users/jbreams/repos","events_url":"https://api.github.com/users/jbreams/events{/privacy}","received_events_url":"https://api.github.com/users/jbreams/received_events","type":"User","site_admin":false},"created_at":"2019-08-31T13:56:16Z","updated_at":"2019-08-31T13:56:16Z","author_association":"CONTRIBUTOR","body":"I'll reach out to legal next week when I'm back in the office. I definitely\ndid that work as their employee for a project for them, so I should check\nwhether I'm allowed to do the relicensing grant for them.\n\nOn Sat, Aug 31, 2019 at 9:52 AM Luca Boccassi <notifications@github.com>\nwrote:\n\n> @jbreams <https://github.com/jbreams> thank you! Some of your commits\n> have a mongodb.com address as the author - do we need to seek permission\n> separately from the company?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/zeromq/libzmq/pull/1451?email_source=notifications&email_token=AABOVUMSLP7QN5WJMBE72ZTQHJZTVA5CNFSM4BJTSJL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TNFQY#issuecomment-526832323>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AABOVUKOPQNM2HE2BTKGU6DQHJZTVANCNFSM4BJTSJLQ>\n> .\n>\n"}}
{"actor":{"display_login":"jbreams"}}