{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/49","id":283762286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzNzYyMjg2","html_url":"https://github.com/spacetelescope/stsci.skypac/pull/49","diff_url":"https://github.com/spacetelescope/stsci.skypac/pull/49.diff","patch_url":"https://github.com/spacetelescope/stsci.skypac/pull/49.patch","issue_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues/49","number":49,"state":"closed","locked":false,"title":"Fix crashes in skymatch when some footprints almost entirely overlap","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"body":"This PR enhances the code by making it more robust when dealing with images that overlap on the sky almost completely. The code now attempts to identify such situations and avoids calling `spherical_geometry` to compute the intersection.\r\n\r\nThis should prevent errors of type 1 reported in https://github.com/spacetelescope/drizzlepac/issues/376\r\n\r\nCC: @mackjenn","created_at":"2019-05-30T18:29:06Z","updated_at":"2019-05-30T18:31:25Z","closed_at":"2019-05-30T18:31:24Z","merged_at":"2019-05-30T18:31:24Z","merge_commit_sha":"98d3313425e4ed44021151d0ac6339521d39d0ff","assignee":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"assignees":[{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":328433217,"node_id":"MDU6TGFiZWwzMjg0MzMyMTc=","url":"https://api.github.com/repos/spacetelescope/stsci.skypac/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/49/commits","review_comments_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/49/comments","review_comment_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues/49/comments","statuses_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/statuses/ce7d823547db16015a57671020194c0662875bff","head":{"label":"mcara:dont-intersect-similar-polygons","ref":"dont-intersect-similar-polygons","sha":"ce7d823547db16015a57671020194c0662875bff","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"repo":{"id":80788707,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc4ODcwNw==","name":"stsci.skypac","full_name":"mcara/stsci.skypac","private":false,"owner":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mcara/stsci.skypac","description":"Sky matching for image mosaic.","fork":true,"url":"https://api.github.com/repos/mcara/stsci.skypac","forks_url":"https://api.github.com/repos/mcara/stsci.skypac/forks","keys_url":"https://api.github.com/repos/mcara/stsci.skypac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcara/stsci.skypac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcara/stsci.skypac/teams","hooks_url":"https://api.github.com/repos/mcara/stsci.skypac/hooks","issue_events_url":"https://api.github.com/repos/mcara/stsci.skypac/issues/events{/number}","events_url":"https://api.github.com/repos/mcara/stsci.skypac/events","assignees_url":"https://api.github.com/repos/mcara/stsci.skypac/assignees{/user}","branches_url":"https://api.github.com/repos/mcara/stsci.skypac/branches{/branch}","tags_url":"https://api.github.com/repos/mcara/stsci.skypac/tags","blobs_url":"https://api.github.com/repos/mcara/stsci.skypac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcara/stsci.skypac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcara/stsci.skypac/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcara/stsci.skypac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcara/stsci.skypac/statuses/{sha}","languages_url":"https://api.github.com/repos/mcara/stsci.skypac/languages","stargazers_url":"https://api.github.com/repos/mcara/stsci.skypac/stargazers","contributors_url":"https://api.github.com/repos/mcara/stsci.skypac/contributors","subscribers_url":"https://api.github.com/repos/mcara/stsci.skypac/subscribers","subscription_url":"https://api.github.com/repos/mcara/stsci.skypac/subscription","commits_url":"https://api.github.com/repos/mcara/stsci.skypac/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcara/stsci.skypac/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcara/stsci.skypac/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcara/stsci.skypac/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcara/stsci.skypac/contents/{+path}","compare_url":"https://api.github.com/repos/mcara/stsci.skypac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcara/stsci.skypac/merges","archive_url":"https://api.github.com/repos/mcara/stsci.skypac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcara/stsci.skypac/downloads","issues_url":"https://api.github.com/repos/mcara/stsci.skypac/issues{/number}","pulls_url":"https://api.github.com/repos/mcara/stsci.skypac/pulls{/number}","milestones_url":"https://api.github.com/repos/mcara/stsci.skypac/milestones{/number}","notifications_url":"https://api.github.com/repos/mcara/stsci.skypac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcara/stsci.skypac/labels{/name}","releases_url":"https://api.github.com/repos/mcara/stsci.skypac/releases{/id}","deployments_url":"https://api.github.com/repos/mcara/stsci.skypac/deployments","created_at":"2017-02-03T02:05:39Z","updated_at":"2019-05-23T23:21:28Z","pushed_at":"2019-05-30T18:19:48Z","git_url":"git://github.com/mcara/stsci.skypac.git","ssh_url":"git@github.com:mcara/stsci.skypac.git","clone_url":"https://github.com/mcara/stsci.skypac.git","svn_url":"https://github.com/mcara/stsci.skypac","homepage":"http://ssb.stsci.edu/doc/stsci_python_dev/stsci.skypac.doc/html/index.html","size":775,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetelescope:master","ref":"master","sha":"3e1e55020aeed1177cd8202a992221e4aea1b0bb","user":{"login":"spacetelescope","id":2751928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":52046729,"node_id":"MDEwOlJlcG9zaXRvcnk1MjA0NjcyOQ==","name":"stsci.skypac","full_name":"spacetelescope/stsci.skypac","private":false,"owner":{"login":"spacetelescope","id":2751928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetelescope/stsci.skypac","description":"Sky matching for image mosaic.","fork":false,"url":"https://api.github.com/repos/spacetelescope/stsci.skypac","forks_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/forks","keys_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/teams","hooks_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/hooks","issue_events_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues/events{/number}","events_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/events","assignees_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/assignees{/user}","branches_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/branches{/branch}","tags_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/tags","blobs_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/languages","stargazers_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/stargazers","contributors_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/contributors","subscribers_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/subscribers","subscription_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/subscription","commits_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/contents/{+path}","compare_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/merges","archive_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/downloads","issues_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues{/number}","pulls_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/labels{/name}","releases_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/releases{/id}","deployments_url":"https://api.github.com/repos/spacetelescope/stsci.skypac/deployments","created_at":"2016-02-18T23:32:16Z","updated_at":"2019-05-23T23:20:37Z","pushed_at":"2019-05-30T18:31:24Z","git_url":"git://github.com/spacetelescope/stsci.skypac.git","ssh_url":"git@github.com:spacetelescope/stsci.skypac.git","clone_url":"https://github.com/spacetelescope/stsci.skypac.git","svn_url":"https://github.com/spacetelescope/stsci.skypac","homepage":"https://stsci-skypac.readthedocs.io/en/latest/index.html","size":771,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/49"},"html":{"href":"https://github.com/spacetelescope/stsci.skypac/pull/49"},"issue":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues/49"},"comments":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/spacetelescope/stsci.skypac/statuses/ce7d823547db16015a57671020194c0662875bff"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"mcara"}}