{"action":"closed","number":476,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/476","id":291740825,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxNzQwODI1","html_url":"https://github.com/input-output-hk/cardano-wallet/pull/476","diff_url":"https://github.com/input-output-hk/cardano-wallet/pull/476.diff","patch_url":"https://github.com/input-output-hk/cardano-wallet/pull/476.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/476","number":476,"state":"closed","locked":false,"title":"Jörmungandr binary roundtrips","user":{"login":"Anviking","id":304423,"node_id":"MDQ6VXNlcjMwNDQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/304423?v=4","gravatar_id":"","url":"https://api.github.com/users/Anviking","html_url":"https://github.com/Anviking","followers_url":"https://api.github.com/users/Anviking/followers","following_url":"https://api.github.com/users/Anviking/following{/other_user}","gists_url":"https://api.github.com/users/Anviking/gists{/gist_id}","starred_url":"https://api.github.com/users/Anviking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anviking/subscriptions","organizations_url":"https://api.github.com/users/Anviking/orgs","repos_url":"https://api.github.com/users/Anviking/repos","events_url":"https://api.github.com/users/Anviking/events{/privacy}","received_events_url":"https://api.github.com/users/Anviking/received_events","type":"User","site_admin":false},"body":"# Issue Number\r\n\r\n#219 \r\n\r\n\r\n# Overview\r\n\r\n- I've added roundtrips testing `decode (encode signedTx) === signedTx` and the same for addresses.\r\n- As a workaround for throwing `Binary` encoders I used `unsafePerformIO` with `Control.Exception.try`\r\n\r\n\r\n# Comments\r\n\r\n<!-- Additional comments or screenshots to attach if any -->\r\n\r\n<!-- \r\nDon't forget to:\r\n\r\n ✓ Self-review your changes to make sure nothing unexpected slipped through\r\n ✓ Assign yourself to the PR\r\n ✓ Assign one or several reviewer(s)\r\n ✓ Once created, link this PR to its corresponding ticket\r\n ✓ Acknowledge any changes required to the Wiki\r\n-->","created_at":"2019-06-25T21:34:42Z","updated_at":"2019-07-03T08:58:21Z","closed_at":"2019-07-03T08:58:21Z","merged_at":"2019-07-03T08:58:21Z","merge_commit_sha":"bf917c0657e69f8d44bc97450d06a9feda503e21","assignee":{"login":"Anviking","id":304423,"node_id":"MDQ6VXNlcjMwNDQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/304423?v=4","gravatar_id":"","url":"https://api.github.com/users/Anviking","html_url":"https://github.com/Anviking","followers_url":"https://api.github.com/users/Anviking/followers","following_url":"https://api.github.com/users/Anviking/following{/other_user}","gists_url":"https://api.github.com/users/Anviking/gists{/gist_id}","starred_url":"https://api.github.com/users/Anviking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anviking/subscriptions","organizations_url":"https://api.github.com/users/Anviking/orgs","repos_url":"https://api.github.com/users/Anviking/repos","events_url":"https://api.github.com/users/Anviking/events{/privacy}","received_events_url":"https://api.github.com/users/Anviking/received_events","type":"User","site_admin":false},"assignees":[{"login":"Anviking","id":304423,"node_id":"MDQ6VXNlcjMwNDQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/304423?v=4","gravatar_id":"","url":"https://api.github.com/users/Anviking","html_url":"https://github.com/Anviking","followers_url":"https://api.github.com/users/Anviking/followers","following_url":"https://api.github.com/users/Anviking/following{/other_user}","gists_url":"https://api.github.com/users/Anviking/gists{/gist_id}","starred_url":"https://api.github.com/users/Anviking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anviking/subscriptions","organizations_url":"https://api.github.com/users/Anviking/orgs","repos_url":"https://api.github.com/users/Anviking/repos","events_url":"https://api.github.com/users/Anviking/events{/privacy}","received_events_url":"https://api.github.com/users/Anviking/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/476/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/476/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/476/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/228c2efc1bf031762e4ab8e8b1f77a1d5663d2fb","head":{"label":"input-output-hk:anviking/219/testing","ref":"anviking/219/testing","sha":"228c2efc1bf031762e4ab8e8b1f77a1d5663d2fb","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":173286031,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMyODYwMzE=","name":"cardano-wallet","full_name":"input-output-hk/cardano-wallet","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-wallet","description":"Official Wallet Backend & API for Cardano decentralized","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-wallet","forks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/deployments","created_at":"2019-03-01T10:50:58Z","updated_at":"2019-07-03T06:32:49Z","pushed_at":"2019-07-03T08:58:21Z","git_url":"git://github.com/input-output-hk/cardano-wallet.git","ssh_url":"git@github.com:input-output-hk/cardano-wallet.git","clone_url":"https://github.com/input-output-hk/cardano-wallet.git","svn_url":"https://github.com/input-output-hk/cardano-wallet","homepage":null,"size":128602,"stargazers_count":32,"watchers_count":32,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":24,"watchers":32,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"fdbfb5c0605c2c0d6190a09d9779d20aa7a58974","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":173286031,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMyODYwMzE=","name":"cardano-wallet","full_name":"input-output-hk/cardano-wallet","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/cardano-wallet","description":"Official Wallet Backend & API for Cardano decentralized","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-wallet","forks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-wallet/deployments","created_at":"2019-03-01T10:50:58Z","updated_at":"2019-07-03T06:32:49Z","pushed_at":"2019-07-03T08:58:21Z","git_url":"git://github.com/input-output-hk/cardano-wallet.git","ssh_url":"git@github.com:input-output-hk/cardano-wallet.git","clone_url":"https://github.com/input-output-hk/cardano-wallet.git","svn_url":"https://github.com/input-output-hk/cardano-wallet","homepage":null,"size":128602,"stargazers_count":32,"watchers_count":32,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":24,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/476"},"html":{"href":"https://github.com/input-output-hk/cardano-wallet/pull/476"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/476"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-wallet/statuses/228c2efc1bf031762e4ab8e8b1f77a1d5663d2fb"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"KtorZ","id":5680256,"node_id":"MDQ6VXNlcjU2ODAyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"comments":1,"review_comments":27,"maintainer_can_modify":false,"commits":6,"additions":153,"deletions":11,"changed_files":5}}
{"actor":{"display_login":"KtorZ"}}