{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/dash-table/pulls/comments/254847793","pull_request_review_id":201296727,"id":254847793,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDg0Nzc5Mw==","diff_hunk":"@@ -29,5 +29,72 @@ describe(`tooltips`, () => {\n         cy.wait(5000);\n         cy.get('.dash-table-tooltip').should('not.be.visible');\n     });\n+});\n \n+describe(`tooltips, mode=${AppMode.FixedTooltips}`, () => {\n+    beforeEach(() => {\n+        cy.visit(`http://localhost:8080?mode=${AppMode.FixedTooltips}`);\n+    });\n+\n+    it('displays in fixed column', () => {\n+        DashTable.getCellById(6, 'rows').trigger('mouseover');\n+        cy.get('.dash-table-tooltip').should('not.be.visible');\n+        cy.wait(0);\n+        cy.get('.dash-table-tooltip').should('be.visible');\n+        cy.get('.dash-table-tooltip').then(t => {\n+            expect(t[0].innerText).to.equal('Learn the eyestealing tesuji');\n+            expect(!!t[0].children && !!t[0].children.length).to.equal(false);\n+\n+            const bounds = t[0].getBoundingClientRect();\n+\n+            DashTable.getCellById(6, 'rows').then(table => {\n+                const cellBounds = table[0].getBoundingClientRect();\n+\n+                expect(bounds.top).to.be.greaterThan(cellBounds.top + cellBounds.height);\n+            });\n+        });\n+        cy.wait(5000);\n+        cy.get('.dash-table-tooltip').should('not.be.visible');\n+    });\n+\n+    it('displays in fixed row', () => {\n+        DashTable.getCellById(0, 'ddd').trigger('mouseover');\n+        cy.get('.dash-table-tooltip').should('not.be.visible');\n+        cy.wait(0);\n+        cy.get('.dash-table-tooltip').should('be.visible');\n+        cy.get('.dash-table-tooltip').then(t => {\n+            expect(t[0].innerText).to.equal('Hane, Cut, Placement');\n+\n+            const bounds = t[0].getBoundingClientRect();\n+\n+            DashTable.getCellById(0, 'ddd').then(table => {\n+                const cellBounds = table[0].getBoundingClientRect();\n+\n+                expect(bounds.top).to.be.greaterThan(cellBounds.top + cellBounds.height);\n+            });\n+        });\n+        cy.wait(5000);\n+        cy.get('.dash-table-tooltip').should('not.be.visible');\n+    });\n+\n+    it('displays in fixed row & column', () => {\n+        DashTable.getCellById(0, 'rows').trigger('mouseover');\n+        cy.get('.dash-table-tooltip').should('not.be.visible');\n+        cy.wait(0);\n+        cy.get('.dash-table-tooltip').should('be.visible');\n+        cy.get('.dash-table-tooltip').then(t => {\n+            expect(t[0].innerText).to.equal('Learn the eyestealing tesuji');\n+            expect(!!t[0].children && !!t[0].children.length).to.equal(false);\n+\n+            const bounds = t[0].getBoundingClientRect();\n+\n+            DashTable.getCellById(0, 'rows').then(table => {\n+                const cellBounds = table[0].getBoundingClientRect();\n+\n+                expect(bounds.top).to.be.greaterThan(cellBounds.top + cellBounds.height);\n+            });","path":"tests/cypress/tests/standalone/tooltip_test.ts","position":76,"original_position":76,"commit_id":"3d6123c56900001f17c0b6a8c239aaa356d00d8c","original_commit_id":"3d6123c56900001f17c0b6a8c239aaa356d00d8c","user":{"login":"Marc-Andre-Rivet","id":8092993,"node_id":"MDQ6VXNlcjgwOTI5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8092993?v=4","gravatar_id":"","url":"https://api.github.com/users/Marc-Andre-Rivet","html_url":"https://github.com/Marc-Andre-Rivet","followers_url":"https://api.github.com/users/Marc-Andre-Rivet/followers","following_url":"https://api.github.com/users/Marc-Andre-Rivet/following{/other_user}","gists_url":"https://api.github.com/users/Marc-Andre-Rivet/gists{/gist_id}","starred_url":"https://api.github.com/users/Marc-Andre-Rivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marc-Andre-Rivet/subscriptions","organizations_url":"https://api.github.com/users/Marc-Andre-Rivet/orgs","repos_url":"https://api.github.com/users/Marc-Andre-Rivet/repos","events_url":"https://api.github.com/users/Marc-Andre-Rivet/events{/privacy}","received_events_url":"https://api.github.com/users/Marc-Andre-Rivet/received_events","type":"User","site_admin":false},"body":"This test is a bit crude and tests that the tooltip is placed below the cell. If the adjustment is not run the tooltip is in its default position and will be above the cell (top=0, left=0)","created_at":"2019-02-07T20:04:27Z","updated_at":"2019-02-07T20:04:27Z","html_url":"https://github.com/plotly/dash-table/pull/366#discussion_r254847793","pull_request_url":"https://api.github.com/repos/plotly/dash-table/pulls/366","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/comments/254847793"},"html":{"href":"https://github.com/plotly/dash-table/pull/366#discussion_r254847793"},"pull_request":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/plotly/dash-table/pulls/366","id":251236769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxMjM2NzY5","html_url":"https://github.com/plotly/dash-table/pull/366","diff_url":"https://github.com/plotly/dash-table/pull/366.diff","patch_url":"https://github.com/plotly/dash-table/pull/366.patch","issue_url":"https://api.github.com/repos/plotly/dash-table/issues/366","number":366,"state":"open","locked":false,"title":"Issue 365 - Fix tooltip position & display with fixed columns/rows","user":{"login":"Marc-Andre-Rivet","id":8092993,"node_id":"MDQ6VXNlcjgwOTI5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8092993?v=4","gravatar_id":"","url":"https://api.github.com/users/Marc-Andre-Rivet","html_url":"https://github.com/Marc-Andre-Rivet","followers_url":"https://api.github.com/users/Marc-Andre-Rivet/followers","following_url":"https://api.github.com/users/Marc-Andre-Rivet/following{/other_user}","gists_url":"https://api.github.com/users/Marc-Andre-Rivet/gists{/gist_id}","starred_url":"https://api.github.com/users/Marc-Andre-Rivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marc-Andre-Rivet/subscriptions","organizations_url":"https://api.github.com/users/Marc-Andre-Rivet/orgs","repos_url":"https://api.github.com/users/Marc-Andre-Rivet/repos","events_url":"https://api.github.com/users/Marc-Andre-Rivet/events{/privacy}","received_events_url":"https://api.github.com/users/Marc-Andre-Rivet/received_events","type":"User","site_admin":false},"body":"Fixes #365 \r\n\r\nWhen the table has fixed columns/rows, the data cell can be located elsewhere than in the `r1c1` portion of the table. This fix checks for the cell everywhere in the table instead.\r\n\r\nThis didn't prevent the tooltip from being is displayed for fixed cells, it only prevented adjusting its position.\r\n\r\nAs this fixes an important issue in a feature that was just delivered, bumping up version and will be releasing afterwards.","created_at":"2019-02-07T19:20:55Z","updated_at":"2019-02-07T20:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9d79f73983cc6d4c98edf0d6a0b27f0d96cf451","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexcjohnson","id":2678795,"node_id":"MDQ6VXNlcjI2Nzg3OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2678795?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcjohnson","html_url":"https://github.com/alexcjohnson","followers_url":"https://api.github.com/users/alexcjohnson/followers","following_url":"https://api.github.com/users/alexcjohnson/following{/other_user}","gists_url":"https://api.github.com/users/alexcjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcjohnson/subscriptions","organizations_url":"https://api.github.com/users/alexcjohnson/orgs","repos_url":"https://api.github.com/users/alexcjohnson/repos","events_url":"https://api.github.com/users/alexcjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/alexcjohnson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/plotly/dash-table/pulls/366/commits","review_comments_url":"https://api.github.com/repos/plotly/dash-table/pulls/366/comments","review_comment_url":"https://api.github.com/repos/plotly/dash-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/dash-table/issues/366/comments","statuses_url":"https://api.github.com/repos/plotly/dash-table/statuses/3d6123c56900001f17c0b6a8c239aaa356d00d8c","head":{"label":"plotly:3-issue365-fixed-tooltips","ref":"3-issue365-fixed-tooltips","sha":"3d6123c56900001f17c0b6a8c239aaa356d00d8c","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":128151266,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNTEyNjY=","name":"dash-table","full_name":"plotly/dash-table","private":false,"owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plotly/dash-table","description":"A First-Class Interactive DataTable for Dash ","fork":false,"url":"https://api.github.com/repos/plotly/dash-table","forks_url":"https://api.github.com/repos/plotly/dash-table/forks","keys_url":"https://api.github.com/repos/plotly/dash-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/dash-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/dash-table/teams","hooks_url":"https://api.github.com/repos/plotly/dash-table/hooks","issue_events_url":"https://api.github.com/repos/plotly/dash-table/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/dash-table/events","assignees_url":"https://api.github.com/repos/plotly/dash-table/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/dash-table/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/dash-table/tags","blobs_url":"https://api.github.com/repos/plotly/dash-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/dash-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/dash-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/dash-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/dash-table/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/dash-table/languages","stargazers_url":"https://api.github.com/repos/plotly/dash-table/stargazers","contributors_url":"https://api.github.com/repos/plotly/dash-table/contributors","subscribers_url":"https://api.github.com/repos/plotly/dash-table/subscribers","subscription_url":"https://api.github.com/repos/plotly/dash-table/subscription","commits_url":"https://api.github.com/repos/plotly/dash-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/dash-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/dash-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/dash-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/dash-table/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/dash-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/dash-table/merges","archive_url":"https://api.github.com/repos/plotly/dash-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/dash-table/downloads","issues_url":"https://api.github.com/repos/plotly/dash-table/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/dash-table/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/dash-table/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/dash-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/dash-table/labels{/name}","releases_url":"https://api.github.com/repos/plotly/dash-table/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/dash-table/deployments","created_at":"2018-04-05T02:45:57Z","updated_at":"2019-02-07T03:02:09Z","pushed_at":"2019-02-07T20:03:21Z","git_url":"git://github.com/plotly/dash-table.git","ssh_url":"git@github.com:plotly/dash-table.git","clone_url":"https://github.com/plotly/dash-table.git","svn_url":"https://github.com/plotly/dash-table","homepage":"https://dash.plot.ly/datatable","size":11043,"stargazers_count":124,"watchers_count":124,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":99,"watchers":124,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"c373e53fa8af2f5b9fabf30deda2f53b95c85ae8","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":128151266,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxNTEyNjY=","name":"dash-table","full_name":"plotly/dash-table","private":false,"owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/plotly/dash-table","description":"A First-Class Interactive DataTable for Dash ","fork":false,"url":"https://api.github.com/repos/plotly/dash-table","forks_url":"https://api.github.com/repos/plotly/dash-table/forks","keys_url":"https://api.github.com/repos/plotly/dash-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/dash-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/dash-table/teams","hooks_url":"https://api.github.com/repos/plotly/dash-table/hooks","issue_events_url":"https://api.github.com/repos/plotly/dash-table/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/dash-table/events","assignees_url":"https://api.github.com/repos/plotly/dash-table/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/dash-table/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/dash-table/tags","blobs_url":"https://api.github.com/repos/plotly/dash-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/dash-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/dash-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/dash-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/dash-table/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/dash-table/languages","stargazers_url":"https://api.github.com/repos/plotly/dash-table/stargazers","contributors_url":"https://api.github.com/repos/plotly/dash-table/contributors","subscribers_url":"https://api.github.com/repos/plotly/dash-table/subscribers","subscription_url":"https://api.github.com/repos/plotly/dash-table/subscription","commits_url":"https://api.github.com/repos/plotly/dash-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/dash-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/dash-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/dash-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/dash-table/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/dash-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/dash-table/merges","archive_url":"https://api.github.com/repos/plotly/dash-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/dash-table/downloads","issues_url":"https://api.github.com/repos/plotly/dash-table/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/dash-table/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/dash-table/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/dash-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/dash-table/labels{/name}","releases_url":"https://api.github.com/repos/plotly/dash-table/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/dash-table/deployments","created_at":"2018-04-05T02:45:57Z","updated_at":"2019-02-07T03:02:09Z","pushed_at":"2019-02-07T20:03:21Z","git_url":"git://github.com/plotly/dash-table.git","ssh_url":"git@github.com:plotly/dash-table.git","clone_url":"https://github.com/plotly/dash-table.git","svn_url":"https://github.com/plotly/dash-table","homepage":"https://dash.plot.ly/datatable","size":11043,"stargazers_count":124,"watchers_count":124,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":99,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/366"},"html":{"href":"https://github.com/plotly/dash-table/pull/366"},"issue":{"href":"https://api.github.com/repos/plotly/dash-table/issues/366"},"comments":{"href":"https://api.github.com/repos/plotly/dash-table/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/dash-table/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/dash-table/statuses/3d6123c56900001f17c0b6a8c239aaa356d00d8c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Marc-Andre-Rivet"}}