{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/271343320","pull_request_review_id":221706934,"id":271343320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MTM0MzMyMA==","diff_hunk":"@@ -969,7 +977,8 @@ let rec extern inctx (custom,scopes as allscopes) vars r =\n       CCast (sub_extern true scopes vars c,\n              map_cast_type (extern_typ scopes vars) c')\n   | GInt i ->\n-     CPrim(Numeral (Uint63.to_string i,true))\n+     extern_prim_token_delimiter_if_required\n+       (Numeral (Uint63.to_string i,true)) \"int63\" \"int63_scope\" (snd scopes)","path":"interp/constrextern.ml","position":21,"original_position":21,"commit_id":"5ed060d200616ae1576aaa5dd528250070fa7d3d","original_commit_id":"5ed060d200616ae1576aaa5dd528250070fa7d3d","user":{"login":"JasonGross","id":396076,"node_id":"MDQ6VXNlcjM5NjA3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/396076?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonGross","html_url":"https://github.com/JasonGross","followers_url":"https://api.github.com/users/JasonGross/followers","following_url":"https://api.github.com/users/JasonGross/following{/other_user}","gists_url":"https://api.github.com/users/JasonGross/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGross/subscriptions","organizations_url":"https://api.github.com/users/JasonGross/orgs","repos_url":"https://api.github.com/users/JasonGross/repos","events_url":"https://api.github.com/users/JasonGross/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGross/received_events","type":"User","site_admin":false},"body":"Would it be possible to use `Register` to register a scope for printing primitive integers, rather than hard-coding this here?","created_at":"2019-04-02T14:46:10Z","updated_at":"2019-04-02T14:46:20Z","html_url":"https://github.com/coq/coq/pull/9889#discussion_r271343320","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/9889","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/271343320"},"html":{"href":"https://github.com/coq/coq/pull/9889#discussion_r271343320"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/9889"}}},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/9889","id":266617025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2NjE3MDI1","html_url":"https://github.com/coq/coq/pull/9889","diff_url":"https://github.com/coq/coq/pull/9889.diff","patch_url":"https://github.com/coq/coq/pull/9889.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/9889","number":9889,"state":"open","locked":false,"title":"Fix pretty-printing of primitive integers","user":{"login":"erikmd","id":10367254,"node_id":"MDQ6VXNlcjEwMzY3MjU0","avatar_url":"https://avatars1.githubusercontent.com/u/10367254?v=4","gravatar_id":"","url":"https://api.github.com/users/erikmd","html_url":"https://github.com/erikmd","followers_url":"https://api.github.com/users/erikmd/followers","following_url":"https://api.github.com/users/erikmd/following{/other_user}","gists_url":"https://api.github.com/users/erikmd/gists{/gist_id}","starred_url":"https://api.github.com/users/erikmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikmd/subscriptions","organizations_url":"https://api.github.com/users/erikmd/orgs","repos_url":"https://api.github.com/users/erikmd/repos","events_url":"https://api.github.com/users/erikmd/events{/privacy}","received_events_url":"https://api.github.com/users/erikmd/received_events","type":"User","site_admin":false},"body":"**Kind:** bug fix\r\n\r\nFixes #9888\r\n\r\n* A scope delimiter was missing for primitive integers constants.\r\n* Add related regression tests.\r\n* Make the fix \"optimal\" with respect to the scope environment, see example below.\r\n\r\n```coq\r\nRequire Import Int63.\r\nCheck 2%int63.\r\n2%int63\r\n     : int\r\nCheck (2 + 2)%int63.\r\n(2 + 2)%int63\r\n     : int\r\n```\r\n\r\n- [x] Added / updated test-suite","created_at":"2019-04-02T12:15:18Z","updated_at":"2019-04-02T14:46:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88acdc0b608ebd42035106a02333be56e0f8d33b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"herbelin","id":460771,"node_id":"MDQ6VXNlcjQ2MDc3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485985650,"node_id":"MDU6TGFiZWw0ODU5ODU2NTA=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20fix","name":"kind: fix","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coq/coq/pulls/9889/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/9889/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/9889/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/5ed060d200616ae1576aaa5dd528250070fa7d3d","head":{"label":"validsdp:fix-int63-scope","ref":"fix-int63-scope","sha":"5ed060d200616ae1576aaa5dd528250070fa7d3d","user":{"login":"validsdp","id":37978020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTc4MDIw","avatar_url":"https://avatars2.githubusercontent.com/u/37978020?v=4","gravatar_id":"","url":"https://api.github.com/users/validsdp","html_url":"https://github.com/validsdp","followers_url":"https://api.github.com/users/validsdp/followers","following_url":"https://api.github.com/users/validsdp/following{/other_user}","gists_url":"https://api.github.com/users/validsdp/gists{/gist_id}","starred_url":"https://api.github.com/users/validsdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/validsdp/subscriptions","organizations_url":"https://api.github.com/users/validsdp/orgs","repos_url":"https://api.github.com/users/validsdp/repos","events_url":"https://api.github.com/users/validsdp/events{/privacy}","received_events_url":"https://api.github.com/users/validsdp/received_events","type":"Organization","site_admin":false},"repo":{"id":137743861,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NDM4NjE=","name":"coq","full_name":"validsdp/coq","private":false,"owner":{"login":"validsdp","id":37978020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTc4MDIw","avatar_url":"https://avatars2.githubusercontent.com/u/37978020?v=4","gravatar_id":"","url":"https://api.github.com/users/validsdp","html_url":"https://github.com/validsdp","followers_url":"https://api.github.com/users/validsdp/followers","following_url":"https://api.github.com/users/validsdp/following{/other_user}","gists_url":"https://api.github.com/users/validsdp/gists{/gist_id}","starred_url":"https://api.github.com/users/validsdp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/validsdp/subscriptions","organizations_url":"https://api.github.com/users/validsdp/orgs","repos_url":"https://api.github.com/users/validsdp/repos","events_url":"https://api.github.com/users/validsdp/events{/privacy}","received_events_url":"https://api.github.com/users/validsdp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/validsdp/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/validsdp/coq","forks_url":"https://api.github.com/repos/validsdp/coq/forks","keys_url":"https://api.github.com/repos/validsdp/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/validsdp/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/validsdp/coq/teams","hooks_url":"https://api.github.com/repos/validsdp/coq/hooks","issue_events_url":"https://api.github.com/repos/validsdp/coq/issues/events{/number}","events_url":"https://api.github.com/repos/validsdp/coq/events","assignees_url":"https://api.github.com/repos/validsdp/coq/assignees{/user}","branches_url":"https://api.github.com/repos/validsdp/coq/branches{/branch}","tags_url":"https://api.github.com/repos/validsdp/coq/tags","blobs_url":"https://api.github.com/repos/validsdp/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/validsdp/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/validsdp/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/validsdp/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/validsdp/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/validsdp/coq/languages","stargazers_url":"https://api.github.com/repos/validsdp/coq/stargazers","contributors_url":"https://api.github.com/repos/validsdp/coq/contributors","subscribers_url":"https://api.github.com/repos/validsdp/coq/subscribers","subscription_url":"https://api.github.com/repos/validsdp/coq/subscription","commits_url":"https://api.github.com/repos/validsdp/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/validsdp/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/validsdp/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/validsdp/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/validsdp/coq/contents/{+path}","compare_url":"https://api.github.com/repos/validsdp/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/validsdp/coq/merges","archive_url":"https://api.github.com/repos/validsdp/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/validsdp/coq/downloads","issues_url":"https://api.github.com/repos/validsdp/coq/issues{/number}","pulls_url":"https://api.github.com/repos/validsdp/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/validsdp/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/validsdp/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/validsdp/coq/labels{/name}","releases_url":"https://api.github.com/repos/validsdp/coq/releases{/id}","deployments_url":"https://api.github.com/repos/validsdp/coq/deployments","created_at":"2018-06-18T11:32:09Z","updated_at":"2018-06-18T11:32:26Z","pushed_at":"2019-04-02T12:03:37Z","git_url":"git://github.com/validsdp/coq.git","ssh_url":"git@github.com:validsdp/coq.git","clone_url":"https://github.com/validsdp/coq.git","svn_url":"https://github.com/validsdp/coq","homepage":"https://coq.inria.fr/","size":122887,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coq:master","ref":"master","sha":"974dc811fe30a762235b68fb3c0ac5c3eeca45b9","user":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MTU5","name":"coq","full_name":"coq/coq","private":false,"owner":{"login":"coq","id":621198,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTE5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/621198?v=4","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2019-04-02T11:07:51Z","pushed_at":"2019-04-02T14:34:17Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"https://coq.inria.fr/","size":125728,"stargazers_count":1912,"watchers_count":1912,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":320,"mirror_url":null,"archived":false,"open_issues_count":1971,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":320,"open_issues":1971,"watchers":1912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/9889"},"html":{"href":"https://github.com/coq/coq/pull/9889"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/9889"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/9889/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/9889/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/9889/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/5ed060d200616ae1576aaa5dd528250070fa7d3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JasonGross"}}