{"action":"closed","number":1018,"pull_request":{"url":"https://api.github.com/repos/sahat/hackathon-starter/pulls/1018","id":336456560,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NDU2NTYw","html_url":"https://github.com/sahat/hackathon-starter/pull/1018","diff_url":"https://github.com/sahat/hackathon-starter/pull/1018.diff","patch_url":"https://github.com/sahat/hackathon-starter/pull/1018.patch","issue_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/1018","number":1018,"state":"closed","locked":false,"title":"Rework .btn-raised as BS custom button style. Fixes #1016","user":{"login":"peterblazejewicz","id":14539,"node_id":"MDQ6VXNlcjE0NTM5","avatar_url":"https://avatars3.githubusercontent.com/u/14539?v=4","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"body":"This is the proposed way of fix issue with the custom `btn-raised` button variant \r\nbeing specific only to  the `default` theme in the project, which impacts rendering of the\r\ncontent if other theme is being used.\r\n\r\nThis moves definition of the `.btn-raised` out of the `default` theme\r\ndefinition into the main style project file, so it can be part of the\r\nproject style no matter what theme is applied to the project.\r\nIf users want to opt-out from that style, it's as easy now as replacing\r\nthe `btn-raised` type with e.g built-in one, like `btn-primary`.\r\nThe default state of the button tries to retain as much as possible\r\nrepresentation of the button under the default theme definition, while\r\nalso providing BS based variants for other states of the button like\r\nactive, focused, disabled, etc.\r\n\r\nRendering before:\r\n\r\n<img width=\"637\" alt=\"Screenshot 2019-11-04 at 20 56 44\" src=\"https://user-images.githubusercontent.com/14539/68153923-bde1db80-ff46-11e9-8046-6b362f261996.png\">\r\n\r\nRendering after:\r\n<img width=\"592\" alt=\"Screenshot 2019-11-04 at 21 08 59\" src=\"https://user-images.githubusercontent.com/14539/68154237-6001c380-ff47-11e9-8896-77e75c16472a.png\">\r\n\r\n\r\n\r\nThanks!","created_at":"2019-11-04T20:12:14Z","updated_at":"2020-01-03T01:43:25Z","closed_at":"2020-01-03T01:43:25Z","merged_at":"2020-01-03T01:43:25Z","merge_commit_sha":"1c1b16986ead5a4b0fcc2bbec1c5f5ee789f6ef6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sahat","id":544954,"node_id":"MDQ6VXNlcjU0NDk1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/544954?v=4","gravatar_id":"","url":"https://api.github.com/users/sahat","html_url":"https://github.com/sahat","followers_url":"https://api.github.com/users/sahat/followers","following_url":"https://api.github.com/users/sahat/following{/other_user}","gists_url":"https://api.github.com/users/sahat/gists{/gist_id}","starred_url":"https://api.github.com/users/sahat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahat/subscriptions","organizations_url":"https://api.github.com/users/sahat/orgs","repos_url":"https://api.github.com/users/sahat/repos","events_url":"https://api.github.com/users/sahat/events{/privacy}","received_events_url":"https://api.github.com/users/sahat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sahat/hackathon-starter/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/sahat/hackathon-starter/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/sahat/hackathon-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/1018/comments","statuses_url":"https://api.github.com/repos/sahat/hackathon-starter/statuses/6a2d2ed03bdbdf06b89076749d432ba83c799a66","head":{"label":"peterblazejewicz:fix/1016","ref":"fix/1016","sha":"6a2d2ed03bdbdf06b89076749d432ba83c799a66","user":{"login":"peterblazejewicz","id":14539,"node_id":"MDQ6VXNlcjE0NTM5","avatar_url":"https://avatars3.githubusercontent.com/u/14539?v=4","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"repo":{"id":21068954,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA2ODk1NA==","name":"hackathon-starter","full_name":"peterblazejewicz/hackathon-starter","private":false,"owner":{"login":"peterblazejewicz","id":14539,"node_id":"MDQ6VXNlcjE0NTM5","avatar_url":"https://avatars3.githubusercontent.com/u/14539?v=4","gravatar_id":"","url":"https://api.github.com/users/peterblazejewicz","html_url":"https://github.com/peterblazejewicz","followers_url":"https://api.github.com/users/peterblazejewicz/followers","following_url":"https://api.github.com/users/peterblazejewicz/following{/other_user}","gists_url":"https://api.github.com/users/peterblazejewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/peterblazejewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterblazejewicz/subscriptions","organizations_url":"https://api.github.com/users/peterblazejewicz/orgs","repos_url":"https://api.github.com/users/peterblazejewicz/repos","events_url":"https://api.github.com/users/peterblazejewicz/events{/privacy}","received_events_url":"https://api.github.com/users/peterblazejewicz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/peterblazejewicz/hackathon-starter","description":"A boilerplate for Node.js web applications","fork":true,"url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter","forks_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/forks","keys_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/teams","hooks_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/hooks","issue_events_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/issues/events{/number}","events_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/events","assignees_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/assignees{/user}","branches_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/branches{/branch}","tags_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/tags","blobs_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/languages","stargazers_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/stargazers","contributors_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/contributors","subscribers_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/subscribers","subscription_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/subscription","commits_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/contents/{+path}","compare_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/merges","archive_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/downloads","issues_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/issues{/number}","pulls_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/labels{/name}","releases_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/releases{/id}","deployments_url":"https://api.github.com/repos/peterblazejewicz/hackathon-starter/deployments","created_at":"2014-06-21T13:22:05Z","updated_at":"2019-11-03T17:42:25Z","pushed_at":"2020-01-03T01:39:43Z","git_url":"git://github.com/peterblazejewicz/hackathon-starter.git","ssh_url":"git@github.com:peterblazejewicz/hackathon-starter.git","clone_url":"https://github.com/peterblazejewicz/hackathon-starter.git","svn_url":"https://github.com/peterblazejewicz/hackathon-starter","homepage":"http://hackathonstarter.herokuapp.com","size":12430,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sahat:master","ref":"master","sha":"f143b9c578ff00570790f79880f5fce27f360121","user":{"login":"sahat","id":544954,"node_id":"MDQ6VXNlcjU0NDk1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/544954?v=4","gravatar_id":"","url":"https://api.github.com/users/sahat","html_url":"https://github.com/sahat","followers_url":"https://api.github.com/users/sahat/followers","following_url":"https://api.github.com/users/sahat/following{/other_user}","gists_url":"https://api.github.com/users/sahat/gists{/gist_id}","starred_url":"https://api.github.com/users/sahat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahat/subscriptions","organizations_url":"https://api.github.com/users/sahat/orgs","repos_url":"https://api.github.com/users/sahat/repos","events_url":"https://api.github.com/users/sahat/events{/privacy}","received_events_url":"https://api.github.com/users/sahat/received_events","type":"User","site_admin":false},"repo":{"id":14370955,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MDk1NQ==","name":"hackathon-starter","full_name":"sahat/hackathon-starter","private":false,"owner":{"login":"sahat","id":544954,"node_id":"MDQ6VXNlcjU0NDk1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/544954?v=4","gravatar_id":"","url":"https://api.github.com/users/sahat","html_url":"https://github.com/sahat","followers_url":"https://api.github.com/users/sahat/followers","following_url":"https://api.github.com/users/sahat/following{/other_user}","gists_url":"https://api.github.com/users/sahat/gists{/gist_id}","starred_url":"https://api.github.com/users/sahat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahat/subscriptions","organizations_url":"https://api.github.com/users/sahat/orgs","repos_url":"https://api.github.com/users/sahat/repos","events_url":"https://api.github.com/users/sahat/events{/privacy}","received_events_url":"https://api.github.com/users/sahat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sahat/hackathon-starter","description":"A boilerplate for Node.js web applications","fork":false,"url":"https://api.github.com/repos/sahat/hackathon-starter","forks_url":"https://api.github.com/repos/sahat/hackathon-starter/forks","keys_url":"https://api.github.com/repos/sahat/hackathon-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sahat/hackathon-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sahat/hackathon-starter/teams","hooks_url":"https://api.github.com/repos/sahat/hackathon-starter/hooks","issue_events_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/events{/number}","events_url":"https://api.github.com/repos/sahat/hackathon-starter/events","assignees_url":"https://api.github.com/repos/sahat/hackathon-starter/assignees{/user}","branches_url":"https://api.github.com/repos/sahat/hackathon-starter/branches{/branch}","tags_url":"https://api.github.com/repos/sahat/hackathon-starter/tags","blobs_url":"https://api.github.com/repos/sahat/hackathon-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sahat/hackathon-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sahat/hackathon-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/sahat/hackathon-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sahat/hackathon-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/sahat/hackathon-starter/languages","stargazers_url":"https://api.github.com/repos/sahat/hackathon-starter/stargazers","contributors_url":"https://api.github.com/repos/sahat/hackathon-starter/contributors","subscribers_url":"https://api.github.com/repos/sahat/hackathon-starter/subscribers","subscription_url":"https://api.github.com/repos/sahat/hackathon-starter/subscription","commits_url":"https://api.github.com/repos/sahat/hackathon-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/sahat/hackathon-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/sahat/hackathon-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/sahat/hackathon-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/sahat/hackathon-starter/contents/{+path}","compare_url":"https://api.github.com/repos/sahat/hackathon-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sahat/hackathon-starter/merges","archive_url":"https://api.github.com/repos/sahat/hackathon-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sahat/hackathon-starter/downloads","issues_url":"https://api.github.com/repos/sahat/hackathon-starter/issues{/number}","pulls_url":"https://api.github.com/repos/sahat/hackathon-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/sahat/hackathon-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/sahat/hackathon-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sahat/hackathon-starter/labels{/name}","releases_url":"https://api.github.com/repos/sahat/hackathon-starter/releases{/id}","deployments_url":"https://api.github.com/repos/sahat/hackathon-starter/deployments","created_at":"2013-11-13T17:24:12Z","updated_at":"2020-01-03T01:30:13Z","pushed_at":"2020-01-03T01:43:25Z","git_url":"git://github.com/sahat/hackathon-starter.git","ssh_url":"git@github.com:sahat/hackathon-starter.git","clone_url":"https://github.com/sahat/hackathon-starter.git","svn_url":"https://github.com/sahat/hackathon-starter","homepage":"https://hackathon-starter.walcony.com","size":12466,"stargazers_count":29239,"watchers_count":29239,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6124,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6124,"open_issues":15,"watchers":29239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sahat/hackathon-starter/pulls/1018"},"html":{"href":"https://github.com/sahat/hackathon-starter/pull/1018"},"issue":{"href":"https://api.github.com/repos/sahat/hackathon-starter/issues/1018"},"comments":{"href":"https://api.github.com/repos/sahat/hackathon-starter/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/sahat/hackathon-starter/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/sahat/hackathon-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sahat/hackathon-starter/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/sahat/hackathon-starter/statuses/6a2d2ed03bdbdf06b89076749d432ba83c799a66"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"YasharF","id":6448697,"node_id":"MDQ6VXNlcjY0NDg2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/6448697?v=4","gravatar_id":"","url":"https://api.github.com/users/YasharF","html_url":"https://github.com/YasharF","followers_url":"https://api.github.com/users/YasharF/followers","following_url":"https://api.github.com/users/YasharF/following{/other_user}","gists_url":"https://api.github.com/users/YasharF/gists{/gist_id}","starred_url":"https://api.github.com/users/YasharF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YasharF/subscriptions","organizations_url":"https://api.github.com/users/YasharF/orgs","repos_url":"https://api.github.com/users/YasharF/repos","events_url":"https://api.github.com/users/YasharF/events{/privacy}","received_events_url":"https://api.github.com/users/YasharF/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"YasharF"}}