{"action":"closed","number":347,"pull_request":{"url":"https://api.github.com/repos/Workiva/over_react/pulls/347","id":323507500,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNTA3NTAw","html_url":"https://github.com/Workiva/over_react/pull/347","diff_url":"https://github.com/Workiva/over_react/pull/347.diff","patch_url":"https://github.com/Workiva/over_react/pull/347.patch","issue_url":"https://api.github.com/repos/Workiva/over_react/issues/347","number":347,"state":"closed","locked":false,"title":"Make local builder private","user":{"login":"corwinsheahan-wf","id":12497362,"node_id":"MDQ6VXNlcjEyNDk3MzYy","avatar_url":"https://avatars2.githubusercontent.com/u/12497362?v=4","gravatar_id":"","url":"https://api.github.com/users/corwinsheahan-wf","html_url":"https://github.com/corwinsheahan-wf","followers_url":"https://api.github.com/users/corwinsheahan-wf/followers","following_url":"https://api.github.com/users/corwinsheahan-wf/following{/other_user}","gists_url":"https://api.github.com/users/corwinsheahan-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/corwinsheahan-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corwinsheahan-wf/subscriptions","organizations_url":"https://api.github.com/users/corwinsheahan-wf/orgs","repos_url":"https://api.github.com/users/corwinsheahan-wf/repos","events_url":"https://api.github.com/users/corwinsheahan-wf/events{/privacy}","received_events_url":"https://api.github.com/users/corwinsheahan-wf/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n  <!-- High-level overview of what you are trying to fix or improve, and why.\r\n         Include any relevant background information that reviewers should know. -->\r\nOver_react specifies a builder which should only be applied to this package, since it generates to source, allowing this package to be published to the public pub repository. While this builder doesn't auto-apply to any dependents, it does still appear in the build script for these dependents. This comes with two negatives:\r\n1) Consumers could inadvertently enable the source builder\r\n2) It adds noise to the consumer's `build.dart` files\r\n\r\n## Changes\r\n  <!-- What this PR changes to fix the problem. -->\r\nThe build config actually supports private builder keys, so we should make this private. Nowhere within Workiva is using this builder (as expected).\r\n\r\n#### Release Notes\r\n  <!-- A concise description of your changes, written in the imperative.\r\n         (\"Fix bug\" and not \"Fixed bug\" or \"Fixes bug.\") -->\r\n\r\n## Review\r\n_[See CONTRIBUTING.md][contributing-review-types] for more details on review types (+1 / QA +1 / +10) and code review process._\r\n\r\n  <!-- If you're making a PR from outside of the Client Platform team, then first off, thanks! :)\r\n\r\n        For open-source contributors, tag @Workiva/app-frameworks and we'll take a look!\r\n\r\n        For Workiva employees:\r\n\r\n            *** Please refrain from tagging the whole team to prevent extraneous notifications. ***\r\n\r\n            If you're not sure who from our team should review these changes, then leave this section\r\n            blank for now and post a link to the PR in the #support-ui-platform Slack channel.\r\n\r\n  -->\r\n\r\nPlease review: <!-- Tag people here or via GitHub's \"Request Review\" feature-->\r\n\r\n### QA Checklist\r\n- [ ] Tests were updated and provide good coverage of the changeset and other affected code\r\n- [ ] Manual testing was performed if needed\r\n    - [ ] Steps from PR author: \r\n        <!-- Call out any specific manual testing instructions here, or omit this section if not applicable -->\r\n      - [ ] CI Passing (the builder is used to build files for testing)\r\n      - [ ] publink into a repo and verify that the `_over_react_local_builder` is not present in `.dart_tool/build/entrypoint/build.dart` file.\r\n    - [ ] Anything falling under manual testing criteria [outlined in CONTRIBUTING.md][contributing-manual-testing]\r\n\r\n## Merge Checklist\r\nWhile we perform many automated checks before auto-merging, some manual checks are needed:\r\n- [ ] A Client Platform member has reviewed these changes\r\n- [ ] There are no unaddressed comments _- this check can be automated if reviewers use the \"Request Changes\" feature_\r\n- [ ] _For release PRs -_ Version metadata in Rosie comment is correct\r\n\r\n\r\n[contributing-review-types]: https://github.com/Workiva/over_react/blob/master/CONTRIBUTING.md#review-types\r\n[contributing-manual-testing]: https://github.com/Workiva/over_react/blob/master/CONTRIBUTING.md#manual-testing-criteria\r\n","created_at":"2019-10-01T22:47:03Z","updated_at":"2019-10-03T23:40:33Z","closed_at":"2019-10-03T23:40:32Z","merged_at":"2019-10-03T23:40:32Z","merge_commit_sha":"756a01afe541113109d9d76dd2640be958939a02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":494985497,"node_id":"MDU6TGFiZWw0OTQ5ODU0OTc=","url":"https://api.github.com/repos/Workiva/over_react/labels/Merge%20Requirements%20Met","name":"Merge Requirements Met","color":"159818","default":false},{"id":494985499,"node_id":"MDU6TGFiZWw0OTQ5ODU0OTk=","url":"https://api.github.com/repos/Workiva/over_react/labels/RM%20Ready","name":"RM Ready","color":"368A2C","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/over_react/pulls/347/commits","review_comments_url":"https://api.github.com/repos/Workiva/over_react/pulls/347/comments","review_comment_url":"https://api.github.com/repos/Workiva/over_react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/over_react/issues/347/comments","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/6f039ebe044cd49ee05c2e04827bfd929a044812","head":{"label":"Workiva:make_local_builder_private","ref":"make_local_builder_private","sha":"6f039ebe044cd49ee05c2e04827bfd929a044812","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":70642157,"node_id":"MDEwOlJlcG9zaXRvcnk3MDY0MjE1Nw==","name":"over_react","full_name":"Workiva/over_react","private":false,"owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Workiva/over_react","description":"A library for building statically-typed React UI components using Dart.","fork":false,"url":"https://api.github.com/repos/Workiva/over_react","forks_url":"https://api.github.com/repos/Workiva/over_react/forks","keys_url":"https://api.github.com/repos/Workiva/over_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/over_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/over_react/teams","hooks_url":"https://api.github.com/repos/Workiva/over_react/hooks","issue_events_url":"https://api.github.com/repos/Workiva/over_react/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/over_react/events","assignees_url":"https://api.github.com/repos/Workiva/over_react/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/over_react/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/over_react/tags","blobs_url":"https://api.github.com/repos/Workiva/over_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/over_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/over_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/over_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/over_react/languages","stargazers_url":"https://api.github.com/repos/Workiva/over_react/stargazers","contributors_url":"https://api.github.com/repos/Workiva/over_react/contributors","subscribers_url":"https://api.github.com/repos/Workiva/over_react/subscribers","subscription_url":"https://api.github.com/repos/Workiva/over_react/subscription","commits_url":"https://api.github.com/repos/Workiva/over_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/over_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/over_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/over_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/over_react/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/over_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/over_react/merges","archive_url":"https://api.github.com/repos/Workiva/over_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/over_react/downloads","issues_url":"https://api.github.com/repos/Workiva/over_react/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/over_react/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/over_react/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/over_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/over_react/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/over_react/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/over_react/deployments","created_at":"2016-10-11T22:56:57Z","updated_at":"2019-10-03T23:37:17Z","pushed_at":"2019-10-03T23:40:32Z","git_url":"git://github.com/Workiva/over_react.git","ssh_url":"git@github.com:Workiva/over_react.git","clone_url":"https://github.com/Workiva/over_react.git","svn_url":"https://github.com/Workiva/over_react","homepage":"","size":14650,"stargazers_count":275,"watchers_count":275,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":17,"watchers":275,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"760642b3b8250b1e1d39d2085b2fd30e839db77e","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":70642157,"node_id":"MDEwOlJlcG9zaXRvcnk3MDY0MjE1Nw==","name":"over_react","full_name":"Workiva/over_react","private":false,"owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Workiva/over_react","description":"A library for building statically-typed React UI components using Dart.","fork":false,"url":"https://api.github.com/repos/Workiva/over_react","forks_url":"https://api.github.com/repos/Workiva/over_react/forks","keys_url":"https://api.github.com/repos/Workiva/over_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/over_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/over_react/teams","hooks_url":"https://api.github.com/repos/Workiva/over_react/hooks","issue_events_url":"https://api.github.com/repos/Workiva/over_react/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/over_react/events","assignees_url":"https://api.github.com/repos/Workiva/over_react/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/over_react/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/over_react/tags","blobs_url":"https://api.github.com/repos/Workiva/over_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/over_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/over_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/over_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/over_react/languages","stargazers_url":"https://api.github.com/repos/Workiva/over_react/stargazers","contributors_url":"https://api.github.com/repos/Workiva/over_react/contributors","subscribers_url":"https://api.github.com/repos/Workiva/over_react/subscribers","subscription_url":"https://api.github.com/repos/Workiva/over_react/subscription","commits_url":"https://api.github.com/repos/Workiva/over_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/over_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/over_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/over_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/over_react/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/over_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/over_react/merges","archive_url":"https://api.github.com/repos/Workiva/over_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/over_react/downloads","issues_url":"https://api.github.com/repos/Workiva/over_react/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/over_react/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/over_react/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/over_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/over_react/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/over_react/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/over_react/deployments","created_at":"2016-10-11T22:56:57Z","updated_at":"2019-10-03T23:37:17Z","pushed_at":"2019-10-03T23:40:32Z","git_url":"git://github.com/Workiva/over_react.git","ssh_url":"git@github.com:Workiva/over_react.git","clone_url":"https://github.com/Workiva/over_react.git","svn_url":"https://github.com/Workiva/over_react","homepage":"","size":14650,"stargazers_count":275,"watchers_count":275,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":17,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/347"},"html":{"href":"https://github.com/Workiva/over_react/pull/347"},"issue":{"href":"https://api.github.com/repos/Workiva/over_react/issues/347"},"comments":{"href":"https://api.github.com/repos/Workiva/over_react/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/over_react/statuses/6f039ebe044cd49ee05c2e04827bfd929a044812"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rmconsole5-wk","id":38507638,"node_id":"MDQ6VXNlcjM4NTA3NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/38507638?v=4","gravatar_id":"","url":"https://api.github.com/users/rmconsole5-wk","html_url":"https://github.com/rmconsole5-wk","followers_url":"https://api.github.com/users/rmconsole5-wk/followers","following_url":"https://api.github.com/users/rmconsole5-wk/following{/other_user}","gists_url":"https://api.github.com/users/rmconsole5-wk/gists{/gist_id}","starred_url":"https://api.github.com/users/rmconsole5-wk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmconsole5-wk/subscriptions","organizations_url":"https://api.github.com/users/rmconsole5-wk/orgs","repos_url":"https://api.github.com/users/rmconsole5-wk/repos","events_url":"https://api.github.com/users/rmconsole5-wk/events{/privacy}","received_events_url":"https://api.github.com/users/rmconsole5-wk/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"rmconsole5-wk"}}