{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/issues/214","repository_url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl","labels_url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/issues/214/comments","events_url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/issues/214/events","html_url":"https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/214","id":527788960,"node_id":"MDU6SXNzdWU1Mjc3ODg5NjA=","number":214,"title":"Mini cleanup on solvable for GetSubgraphAroundNode on LightGraphs","user":{"login":"GearsAD","id":6854507,"node_id":"MDQ6VXNlcjY4NTQ1MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6854507?v=4","gravatar_id":"","url":"https://api.github.com/users/GearsAD","html_url":"https://github.com/GearsAD","followers_url":"https://api.github.com/users/GearsAD/followers","following_url":"https://api.github.com/users/GearsAD/following{/other_user}","gists_url":"https://api.github.com/users/GearsAD/gists{/gist_id}","starred_url":"https://api.github.com/users/GearsAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GearsAD/subscriptions","organizations_url":"https://api.github.com/users/GearsAD/orgs","repos_url":"https://api.github.com/users/GearsAD/repos","events_url":"https://api.github.com/users/GearsAD/events{/privacy}","received_events_url":"https://api.github.com/users/GearsAD/received_events","type":"User","site_admin":false},"labels":[{"id":1475472990,"node_id":"MDU6TGFiZWwxNDc1NDcyOTkw","url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/labels/light%20graphs","name":"light graphs","color":"bce2f4","default":false,"description":""}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/milestones/25","html_url":"https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/milestone/25","labels_url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/milestones/25/labels","id":4777830,"node_id":"MDk6TWlsZXN0b25lNDc3NzgzMA==","number":25,"title":"v0.5.x","description":null,"creator":{"login":"dehann","id":6412556,"node_id":"MDQ6VXNlcjY0MTI1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6412556?v=4","gravatar_id":"","url":"https://api.github.com/users/dehann","html_url":"https://github.com/dehann","followers_url":"https://api.github.com/users/dehann/followers","following_url":"https://api.github.com/users/dehann/following{/other_user}","gists_url":"https://api.github.com/users/dehann/gists{/gist_id}","starred_url":"https://api.github.com/users/dehann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dehann/subscriptions","organizations_url":"https://api.github.com/users/dehann/orgs","repos_url":"https://api.github.com/users/dehann/repos","events_url":"https://api.github.com/users/dehann/events{/privacy}","received_events_url":"https://api.github.com/users/dehann/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2019-10-23T15:39:04Z","updated_at":"2019-11-25T00:56:48Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2019-11-25T00:53:56Z","updated_at":"2019-11-25T13:56:33Z","closed_at":null,"author_association":"COLLABORATOR","body":"Hi @Affie,\r\n\r\nI added this https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/blob/master/src/LightDFG/services/LightDFG.jl#L395 - but I think it will behave differently than the other drivers because it doesn't grow from 1 to `distance` neighbors. E.g. if in a graph x0 is solvable, x0x1f1 is not solvable, and x1 is solvable, asking for a subgraph around x0 distance=2,solvable=1 will return x1 even though x0x1f1 isn't solvable. \r\n\r\nI'm checking and adding a test for it, but do you mind taking a look at whether we can change it if needed?"},"comment":{"url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/issues/comments/558166610","html_url":"https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/issues/214#issuecomment-558166610","issue_url":"https://api.github.com/repos/JuliaRobotics/DistributedFactorGraphs.jl/issues/214","id":558166610,"node_id":"MDEyOklzc3VlQ29tbWVudDU1ODE2NjYxMA==","user":{"login":"GearsAD","id":6854507,"node_id":"MDQ6VXNlcjY4NTQ1MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6854507?v=4","gravatar_id":"","url":"https://api.github.com/users/GearsAD","html_url":"https://github.com/GearsAD","followers_url":"https://api.github.com/users/GearsAD/followers","following_url":"https://api.github.com/users/GearsAD/following{/other_user}","gists_url":"https://api.github.com/users/GearsAD/gists{/gist_id}","starred_url":"https://api.github.com/users/GearsAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GearsAD/subscriptions","organizations_url":"https://api.github.com/users/GearsAD/orgs","repos_url":"https://api.github.com/users/GearsAD/repos","events_url":"https://api.github.com/users/GearsAD/events{/privacy}","received_events_url":"https://api.github.com/users/GearsAD/received_events","type":"User","site_admin":false},"created_at":"2019-11-25T13:56:33Z","updated_at":"2019-11-25T13:56:33Z","author_association":"COLLABORATOR","body":"I'm worried about fragmented graphs, this has been a problem in the past. There's probably no hard and fast rule, but the idea of growing+filtering means that you will get a connected subgraph with all solvable.\r\n\r\nFor the first node, either can or can't return, but it's a boundary case - if you ask for a node that will be filtered then you're guaranteed to have a fragmented graph (strange user request).   "}}
{"actor":{"display_login":"GearsAD"}}