{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/174","repository_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy","labels_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/174/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/174/events","html_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/174","id":509676091,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwMTc1NTk0","number":174,"title":"Add --optionalChild flag and assorted changes to kubectl-hnc-set","user":{"login":"adrianludwin","id":20559844,"node_id":"MDQ6VXNlcjIwNTU5ODQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20559844?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianludwin","html_url":"https://github.com/adrianludwin","followers_url":"https://api.github.com/users/adrianludwin/followers","following_url":"https://api.github.com/users/adrianludwin/following{/other_user}","gists_url":"https://api.github.com/users/adrianludwin/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianludwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianludwin/subscriptions","organizations_url":"https://api.github.com/users/adrianludwin/orgs","repos_url":"https://api.github.com/users/adrianludwin/repos","events_url":"https://api.github.com/users/adrianludwin/events{/privacy}","received_events_url":"https://api.github.com/users/adrianludwin/received_events","type":"User","site_admin":false},"labels":[{"id":1262102489,"node_id":"MDU6TGFiZWwxMjYyMTAyNDg5","url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1262095667,"node_id":"MDU6TGFiZWwxMjYyMDk1NjY3","url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1262099678,"node_id":"MDU6TGFiZWwxMjYyMDk5Njc4","url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"rjbez17","id":1244450,"node_id":"MDQ6VXNlcjEyNDQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1244450?v=4","gravatar_id":"","url":"https://api.github.com/users/rjbez17","html_url":"https://github.com/rjbez17","followers_url":"https://api.github.com/users/rjbez17/followers","following_url":"https://api.github.com/users/rjbez17/following{/other_user}","gists_url":"https://api.github.com/users/rjbez17/gists{/gist_id}","starred_url":"https://api.github.com/users/rjbez17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjbez17/subscriptions","organizations_url":"https://api.github.com/users/rjbez17/orgs","repos_url":"https://api.github.com/users/rjbez17/repos","events_url":"https://api.github.com/users/rjbez17/events{/privacy}","received_events_url":"https://api.github.com/users/rjbez17/received_events","type":"User","site_admin":false},"assignees":[{"login":"rjbez17","id":1244450,"node_id":"MDQ6VXNlcjEyNDQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1244450?v=4","gravatar_id":"","url":"https://api.github.com/users/rjbez17","html_url":"https://github.com/rjbez17","followers_url":"https://api.github.com/users/rjbez17/followers","following_url":"https://api.github.com/users/rjbez17/following{/other_user}","gists_url":"https://api.github.com/users/rjbez17/gists{/gist_id}","starred_url":"https://api.github.com/users/rjbez17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjbez17/subscriptions","organizations_url":"https://api.github.com/users/rjbez17/orgs","repos_url":"https://api.github.com/users/rjbez17/repos","events_url":"https://api.github.com/users/rjbez17/events{/privacy}","received_events_url":"https://api.github.com/users/rjbez17/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-10-21T00:30:08Z","updated_at":"2019-10-21T01:02:43Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/pulls/174","html_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/174","diff_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/174.diff","patch_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/174.patch"},"body":"Other changes:\r\n\r\n- Fixed initialization segfault when the init() functions stopped\r\nbeing called in the order I wanted (oops).\r\n- Only all `getHierarchy` and `updateHierarchy` once during `set` with\r\nbetter messages explaining what's going on.\r\n\r\nTested: manually confirmed that illegal names or valid, existing\r\nrequired children were removed. Also retried --parent, --root and\r\n--requiredChild in various combinations and everythign seems to work as\r\nexpected. Filed\r\nhttps://github.com/kubernetes-sigs/multi-tenancy/issues/173 to add\r\nbetter unit testing in the future.\r\n\r\n/cc @vjdhama \r\n/assign @rjbez17 "},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/comments/544312658","html_url":"https://github.com/kubernetes-sigs/multi-tenancy/pull/174#issuecomment-544312658","issue_url":"https://api.github.com/repos/kubernetes-sigs/multi-tenancy/issues/174","id":544312658,"node_id":"MDEyOklzc3VlQ29tbWVudDU0NDMxMjY1OA==","user":{"login":"adrianludwin","id":20559844,"node_id":"MDQ6VXNlcjIwNTU5ODQ0","avatar_url":"https://avatars2.githubusercontent.com/u/20559844?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianludwin","html_url":"https://github.com/adrianludwin","followers_url":"https://api.github.com/users/adrianludwin/followers","following_url":"https://api.github.com/users/adrianludwin/following{/other_user}","gists_url":"https://api.github.com/users/adrianludwin/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianludwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianludwin/subscriptions","organizations_url":"https://api.github.com/users/adrianludwin/orgs","repos_url":"https://api.github.com/users/adrianludwin/repos","events_url":"https://api.github.com/users/adrianludwin/events{/privacy}","received_events_url":"https://api.github.com/users/adrianludwin/received_events","type":"User","site_admin":false},"created_at":"2019-10-21T01:02:43Z","updated_at":"2019-10-21T01:02:43Z","author_association":"COLLABORATOR","body":"Seeing if https://github.com/kubernetes/test-infra/pull/14660 worked\r\n\r\n/ok-to-test"}}
{"actor":{"display_login":"adrianludwin"}}