{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/287048829","pull_request_review_id":241339546,"id":287048829,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzA0ODgyOQ==","diff_hunk":"@@ -271,98 +275,119 @@ public void shouldThrowWhenUdafReturnTypeIsntAUdaf() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createBlah\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithLongValTypeDoubleAggType() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createLongDouble\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithDoubleValTypeLongAggType() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createDoubleLong\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithIntegerValTypeStringAggType() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createIntegerString\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithStringValTypeIntegerAggType() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createStringInteger\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithBooleanValTypeListAggType() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createBooleanList\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithListValTypeBooleamAggType() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createListBoolean\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithMapValMapAggTypes() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createMapMap\"),\n         classLoader,\n         \"test\",\n-        \"desc\"\n-    );\n+        \"desc\",\n+        \"\",\n+        \"\");\n   }\n \n   @Test\n   public void shouldHandleUdafsWithMapValMapAggTypesAndFactoryArg() throws Exception {\n     udfCompiler.compileAggregate(UdfCompilerTest.class.getMethod(\"createMapMap\", int.class),\n-                                 classLoader,\n-                                 \"test\",\n-                                 \"desc\"\n-    );\n+        classLoader,\n+        \"test\",\n+        \"desc\",\n+        \"\",\n+        \"\");\n+  }\n+\n+  @Test\n+  public void shouldHandleUdafsWithStructStructTypes() throws Exception {","path":"ksql-engine/src/test/java/io/confluent/ksql/function/UdfCompilerTest.java","position":158,"original_position":158,"commit_id":"48e2c8883c5fcb3a64d96420b420c9dc0e82a039","original_commit_id":"48e2c8883c5fcb3a64d96420b420c9dc0e82a039","user":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"body":"Struct for input and Struct for output","created_at":"2019-05-23T17:16:34Z","updated_at":"2019-05-23T17:16:34Z","html_url":"https://github.com/confluentinc/ksql/pull/2823#discussion_r287048829","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2823","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/287048829"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2823#discussion_r287048829"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2823"}},"in_reply_to_id":286597733},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/2823","id":279187888,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5MTg3ODg4","html_url":"https://github.com/confluentinc/ksql/pull/2823","diff_url":"https://github.com/confluentinc/ksql/pull/2823.diff","patch_url":"https://github.com/confluentinc/ksql/pull/2823.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/2823","number":2823,"state":"open","locked":false,"title":"Support STRUCT in UDAFs (both parameters & return values)","user":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"body":"### Description \r\n#2642 and #2677 covered Struct support for UDFs. This follows it up by supporting a similar syntax for UDAFs. Namely, `@UdafFactory` may now optionally specify `paramSchema` and `returnSchema` if it accepts/returns a STRUCT, for example:\r\n```java\r\n@UdafFactory(\r\n      description = \"returns a struct with (SUM(S->A), SUM(S->B)) over the window\",\r\n      paramSchema = \"STRUCT<A INTEGER, B INTEGER>\",\r\n      returnSchema = \"STRUCT<A INTEGER, B INTEGER>\")\r\n```\r\n\r\n### Testing done \r\n- Unit testing\r\n- new QTT coverage\r\n\r\n### Postscript\r\n\r\nYes... I am in London. I decided to visit the London office and was surprisingly productive in just two or three hours so I figured I'd publish this PR.\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2019-05-15T17:09:40Z","updated_at":"2019-05-23T17:16:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e4e6fb17526568aeac75ac48dc0a8db64a78b01","assignee":null,"assignees":[],"requested_reviewers":[{"login":"big-andy-coates","id":8012398,"node_id":"MDQ6VXNlcjgwMTIzOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8012398?v=4","gravatar_id":"","url":"https://api.github.com/users/big-andy-coates","html_url":"https://github.com/big-andy-coates","followers_url":"https://api.github.com/users/big-andy-coates/followers","following_url":"https://api.github.com/users/big-andy-coates/following{/other_user}","gists_url":"https://api.github.com/users/big-andy-coates/gists{/gist_id}","starred_url":"https://api.github.com/users/big-andy-coates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-andy-coates/subscriptions","organizations_url":"https://api.github.com/users/big-andy-coates/orgs","repos_url":"https://api.github.com/users/big-andy-coates/repos","events_url":"https://api.github.com/users/big-andy-coates/events{/privacy}","received_events_url":"https://api.github.com/users/big-andy-coates/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"ksql","id":2484983,"node_id":"MDQ6VGVhbTI0ODQ5ODM=","slug":"ksql","description":"KSQL","privacy":"closed","url":"https://api.github.com/teams/2484983","html_url":"https://github.com/orgs/confluentinc/teams/ksql","members_url":"https://api.github.com/teams/2484983/members{/member}","repositories_url":"https://api.github.com/teams/2484983/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2823/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2823/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/2823/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/48e2c8883c5fcb3a64d96420b420c9dc0e82a039","head":{"label":"agavra:udaf_struct","ref":"udaf_struct","sha":"48e2c8883c5fcb3a64d96420b420c9dc0e82a039","user":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"repo":{"id":165937295,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU5MzcyOTU=","name":"ksql","full_name":"agavra/ksql","private":false,"owner":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agavra/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/agavra/ksql","forks_url":"https://api.github.com/repos/agavra/ksql/forks","keys_url":"https://api.github.com/repos/agavra/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agavra/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agavra/ksql/teams","hooks_url":"https://api.github.com/repos/agavra/ksql/hooks","issue_events_url":"https://api.github.com/repos/agavra/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/agavra/ksql/events","assignees_url":"https://api.github.com/repos/agavra/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/agavra/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/agavra/ksql/tags","blobs_url":"https://api.github.com/repos/agavra/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agavra/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agavra/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/agavra/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agavra/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/agavra/ksql/languages","stargazers_url":"https://api.github.com/repos/agavra/ksql/stargazers","contributors_url":"https://api.github.com/repos/agavra/ksql/contributors","subscribers_url":"https://api.github.com/repos/agavra/ksql/subscribers","subscription_url":"https://api.github.com/repos/agavra/ksql/subscription","commits_url":"https://api.github.com/repos/agavra/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/agavra/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/agavra/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/agavra/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/agavra/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/agavra/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agavra/ksql/merges","archive_url":"https://api.github.com/repos/agavra/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agavra/ksql/downloads","issues_url":"https://api.github.com/repos/agavra/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/agavra/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/agavra/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/agavra/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agavra/ksql/labels{/name}","releases_url":"https://api.github.com/repos/agavra/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/agavra/ksql/deployments","created_at":"2019-01-15T23:06:24Z","updated_at":"2019-04-25T20:56:21Z","pushed_at":"2019-05-23T17:13:07Z","git_url":"git://github.com/agavra/ksql.git","ssh_url":"git@github.com:agavra/ksql.git","clone_url":"https://github.com/agavra/ksql.git","svn_url":"https://github.com/agavra/ksql","homepage":"","size":23401,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"01b9bafbfc022956abcd974253ffba9494d7241a","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2019-05-23T03:27:39Z","pushed_at":"2019-05-23T17:13:09Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":23477,"stargazers_count":2263,"watchers_count":2263,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":460,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":523,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":460,"open_issues":523,"watchers":2263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2823"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2823"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2823"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2823/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2823/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2823/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/48e2c8883c5fcb3a64d96420b420c9dc0e82a039"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agavra"}}