{"action":"created","issue":{"url":"https://api.github.com/repos/SAP/ui5-uiveri5/issues/8","repository_url":"https://api.github.com/repos/SAP/ui5-uiveri5","labels_url":"https://api.github.com/repos/SAP/ui5-uiveri5/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/SAP/ui5-uiveri5/issues/8/comments","events_url":"https://api.github.com/repos/SAP/ui5-uiveri5/issues/8/events","html_url":"https://github.com/SAP/ui5-uiveri5/pull/8","id":399724144,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ1MDgwMDk5","number":8,"title":"Fix confKeys merging.","user":{"login":"cvakiitho","id":4386222,"node_id":"MDQ6VXNlcjQzODYyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4386222?v=4","gravatar_id":"","url":"https://api.github.com/users/cvakiitho","html_url":"https://github.com/cvakiitho","followers_url":"https://api.github.com/users/cvakiitho/followers","following_url":"https://api.github.com/users/cvakiitho/following{/other_user}","gists_url":"https://api.github.com/users/cvakiitho/gists{/gist_id}","starred_url":"https://api.github.com/users/cvakiitho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvakiitho/subscriptions","organizations_url":"https://api.github.com/users/cvakiitho/orgs","repos_url":"https://api.github.com/users/cvakiitho/repos","events_url":"https://api.github.com/users/cvakiitho/events{/privacy}","received_events_url":"https://api.github.com/users/cvakiitho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-01-16T09:43:11Z","updated_at":"2019-02-07T16:43:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/SAP/ui5-uiveri5/pulls/8","html_url":"https://github.com/SAP/ui5-uiveri5/pull/8","diff_url":"https://github.com/SAP/ui5-uiveri5/pull/8.diff","patch_url":"https://github.com/SAP/ui5-uiveri5/pull/8.patch"},"body":"In order to be able to overwrite objectKeys inside Arrays, for example\r\nbrowsers[0].browserName:firefox, without creating extra object, confKeys\r\nneeds to be separated from _mergeWithArrays, that is called several\r\ntimes, therefore creating new objectKey before reaching the actual place\r\nwhere it needs to ._set the objectKey inside Object defined in config."},"comment":{"url":"https://api.github.com/repos/SAP/ui5-uiveri5/issues/comments/461504651","html_url":"https://github.com/SAP/ui5-uiveri5/pull/8#issuecomment-461504651","issue_url":"https://api.github.com/repos/SAP/ui5-uiveri5/issues/8","id":461504651,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2MTUwNDY1MQ==","user":{"login":"cvakiitho","id":4386222,"node_id":"MDQ6VXNlcjQzODYyMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4386222?v=4","gravatar_id":"","url":"https://api.github.com/users/cvakiitho","html_url":"https://github.com/cvakiitho","followers_url":"https://api.github.com/users/cvakiitho/followers","following_url":"https://api.github.com/users/cvakiitho/following{/other_user}","gists_url":"https://api.github.com/users/cvakiitho/gists{/gist_id}","starred_url":"https://api.github.com/users/cvakiitho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvakiitho/subscriptions","organizations_url":"https://api.github.com/users/cvakiitho/orgs","repos_url":"https://api.github.com/users/cvakiitho/repos","events_url":"https://api.github.com/users/cvakiitho/events{/privacy}","received_events_url":"https://api.github.com/users/cvakiitho/received_events","type":"User","site_admin":false},"created_at":"2019-02-07T16:43:49Z","updated_at":"2019-02-07T16:43:49Z","author_association":"NONE","body":"> Up to my understanding, with this fix we will loose the capability to create objects in arrays over confKeys right ?. What will happen with wrong index provided ?\r\n\r\nI don't think so, \r\nand imo this test proves it:  https://github.com/SAP/ui5-uiveri5/blob/520be4604c38ce370ac7680203961e51eb0d0c4a/spec/configParser.spec.js#L63 "}}
{"actor":{"display_login":"cvakiitho"}}