{"action":"created","issue":{"url":"https://api.github.com/repos/storybookjs/storybook/issues/7568","repository_url":"https://api.github.com/repos/storybookjs/storybook","labels_url":"https://api.github.com/repos/storybookjs/storybook/issues/7568/labels{/name}","comments_url":"https://api.github.com/repos/storybookjs/storybook/issues/7568/comments","events_url":"https://api.github.com/repos/storybookjs/storybook/issues/7568/events","html_url":"https://github.com/storybookjs/storybook/pull/7568","id":473131325,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzYwMzE2","number":7568,"title":"Fix select knob default selection with array","user":{"login":"elliotlarson","id":73437,"node_id":"MDQ6VXNlcjczNDM3","avatar_url":"https://avatars1.githubusercontent.com/u/73437?v=4","gravatar_id":"","url":"https://api.github.com/users/elliotlarson","html_url":"https://github.com/elliotlarson","followers_url":"https://api.github.com/users/elliotlarson/followers","following_url":"https://api.github.com/users/elliotlarson/following{/other_user}","gists_url":"https://api.github.com/users/elliotlarson/gists{/gist_id}","starred_url":"https://api.github.com/users/elliotlarson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliotlarson/subscriptions","organizations_url":"https://api.github.com/users/elliotlarson/orgs","repos_url":"https://api.github.com/users/elliotlarson/repos","events_url":"https://api.github.com/users/elliotlarson/events{/privacy}","received_events_url":"https://api.github.com/users/elliotlarson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-26T01:08:33Z","updated_at":"2019-07-26T01:10:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/storybookjs/storybook/pulls/7568","html_url":"https://github.com/storybookjs/storybook/pull/7568","diff_url":"https://github.com/storybookjs/storybook/pull/7568.diff","patch_url":"https://github.com/storybookjs/storybook/pull/7568.patch"},"body":"Issue:\r\n\r\nWhen using a select knob with arrays as option values, the default value was not getting set properly on the select list.  The code was comparing two arrays with ===, which is always false.  \r\n\r\n## What I did\r\n\r\nI updated the code to stringify the arrays for doing the comparison.\r\n\r\n## How to test\r\n\r\nThere was not an existing test for the select knob that I could augment/add onto for this edge case.  However, this is a pretty small update.  I did try it out locally and it worked (manual test).\r\n"},"comment":{"url":"https://api.github.com/repos/storybookjs/storybook/issues/comments/515270380","html_url":"https://github.com/storybookjs/storybook/pull/7568#issuecomment-515270380","issue_url":"https://api.github.com/repos/storybookjs/storybook/issues/7568","id":515270380,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNTI3MDM4MA==","user":{"login":"github-actions[bot]","id":41898282,"node_id":"MDM6Qm90NDE4OTgyODI=","avatar_url":"https://avatars2.githubusercontent.com/in/15368?v=4","gravatar_id":"","url":"https://api.github.com/users/github-actions%5Bbot%5D","html_url":"https://github.com/apps/github-actions","followers_url":"https://api.github.com/users/github-actions%5Bbot%5D/followers","following_url":"https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-actions%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/github-actions%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/github-actions%5Bbot%5D/repos","events_url":"https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/github-actions%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-07-26T01:10:24Z","updated_at":"2019-07-26T01:10:24Z","author_association":"NONE","body":"\n<!--\n  1 failure:  PR is not labeled...\n  0 warning: \n  \n  \n  DangerID: danger-id-Danger;\n-->\n\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\">Fails</th>\n    </tr>\n  </thead>\n  <tbody><tr>\n      <td>:no_entry_sign:</td>\n      <td>\n\n  PR is not labeled with one of: [\"cleanup\",\"doc-dependencies:update\",\"BREAKING CHANGE\",\"feature request\",\"bug\",\"documentation\",\"maintenance\",\"dependencies:update\",\"dependencies\",\"other\"]\n  </td>\n    </tr>\n  </tbody>\n</table>\n\n\n\n\n<p align=\"right\">\n  Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 38e6b5d300e00c698fb86ee73cdf7b88233bba3f\n</p>\n"}}
{"actor":{"display_login":"github-actions"}}