{"action":"created","comment":{"url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments/355893129","pull_request_review_id":329650451,"id":355893129,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTg5MzEyOQ==","diff_hunk":"@@ -490,6 +490,10 @@ impl StateInfo for Client {\n }\n \n impl EngineInfo for Client {\n+    fn network_id(&self) -> NetworkId {\n+        self.common_params(BlockId::Earliest).expect(\"Genesis state should exist\").network_id()","path":"core/src/client/client.rs","position":5,"original_position":5,"commit_id":"c0ee763dce2092edcd63c48642e5c260d5058abc","original_commit_id":"c0ee763dce2092edcd63c48642e5c260d5058abc","user":{"login":"Remagpie","id":8017201,"node_id":"MDQ6VXNlcjgwMTcyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8017201?v=4","gravatar_id":"","url":"https://api.github.com/users/Remagpie","html_url":"https://github.com/Remagpie","followers_url":"https://api.github.com/users/Remagpie/followers","following_url":"https://api.github.com/users/Remagpie/following{/other_user}","gists_url":"https://api.github.com/users/Remagpie/gists{/gist_id}","starred_url":"https://api.github.com/users/Remagpie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remagpie/subscriptions","organizations_url":"https://api.github.com/users/Remagpie/orgs","repos_url":"https://api.github.com/users/Remagpie/repos","events_url":"https://api.github.com/users/Remagpie/events{/privacy}","received_events_url":"https://api.github.com/users/Remagpie/received_events","type":"User","site_admin":false},"body":"We usually use `must` instead of `should` for assertions.","created_at":"2019-12-10T08:15:49Z","updated_at":"2019-12-10T08:17:38Z","html_url":"https://github.com/CodeChain-io/codechain/pull/1923#discussion_r355893129","pull_request_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments/355893129"},"html":{"href":"https://github.com/CodeChain-io/codechain/pull/1923#discussion_r355893129"},"pull_request":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923"}}},"pull_request":{"url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923","id":351252630,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxMjUyNjMw","html_url":"https://github.com/CodeChain-io/codechain/pull/1923","diff_url":"https://github.com/CodeChain-io/codechain/pull/1923.diff","patch_url":"https://github.com/CodeChain-io/codechain/pull/1923.patch","issue_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/1923","number":1923,"state":"open","locked":false,"title":"Use genesis state to read network_id","user":{"login":"foriequal0","id":5465658,"node_id":"MDQ6VXNlcjU0NjU2NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5465658?v=4","gravatar_id":"","url":"https://api.github.com/users/foriequal0","html_url":"https://github.com/foriequal0","followers_url":"https://api.github.com/users/foriequal0/followers","following_url":"https://api.github.com/users/foriequal0/following{/other_user}","gists_url":"https://api.github.com/users/foriequal0/gists{/gist_id}","starred_url":"https://api.github.com/users/foriequal0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foriequal0/subscriptions","organizations_url":"https://api.github.com/users/foriequal0/orgs","repos_url":"https://api.github.com/users/foriequal0/repos","events_url":"https://api.github.com/users/foriequal0/events{/privacy}","received_events_url":"https://api.github.com/users/foriequal0/received_events","type":"User","site_admin":false},"body":"`NetworkId` hasn't been changed, and cannot be changed, and the effect of changes are unknown. It is easier to pin down to the genesis state for now.","created_at":"2019-12-10T08:03:42Z","updated_at":"2019-12-10T08:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f15565355e1c41ccdbd7ade24c1a8aa423fbdbc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sgkim126","id":1138402,"node_id":"MDQ6VXNlcjExMzg0MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1138402?v=4","gravatar_id":"","url":"https://api.github.com/users/sgkim126","html_url":"https://github.com/sgkim126","followers_url":"https://api.github.com/users/sgkim126/followers","following_url":"https://api.github.com/users/sgkim126/following{/other_user}","gists_url":"https://api.github.com/users/sgkim126/gists{/gist_id}","starred_url":"https://api.github.com/users/sgkim126/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgkim126/subscriptions","organizations_url":"https://api.github.com/users/sgkim126/orgs","repos_url":"https://api.github.com/users/sgkim126/repos","events_url":"https://api.github.com/users/sgkim126/events{/privacy}","received_events_url":"https://api.github.com/users/sgkim126/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923/commits","review_comments_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923/comments","review_comment_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/1923/comments","statuses_url":"https://api.github.com/repos/CodeChain-io/codechain/statuses/c0ee763dce2092edcd63c48642e5c260d5058abc","head":{"label":"foriequal0:feature/genesis_network_id","ref":"feature/genesis_network_id","sha":"c0ee763dce2092edcd63c48642e5c260d5058abc","user":{"login":"foriequal0","id":5465658,"node_id":"MDQ6VXNlcjU0NjU2NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5465658?v=4","gravatar_id":"","url":"https://api.github.com/users/foriequal0","html_url":"https://github.com/foriequal0","followers_url":"https://api.github.com/users/foriequal0/followers","following_url":"https://api.github.com/users/foriequal0/following{/other_user}","gists_url":"https://api.github.com/users/foriequal0/gists{/gist_id}","starred_url":"https://api.github.com/users/foriequal0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foriequal0/subscriptions","organizations_url":"https://api.github.com/users/foriequal0/orgs","repos_url":"https://api.github.com/users/foriequal0/repos","events_url":"https://api.github.com/users/foriequal0/events{/privacy}","received_events_url":"https://api.github.com/users/foriequal0/received_events","type":"User","site_admin":false},"repo":{"id":143410469,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0MTA0Njk=","name":"codechain","full_name":"foriequal0/codechain","private":false,"owner":{"login":"foriequal0","id":5465658,"node_id":"MDQ6VXNlcjU0NjU2NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5465658?v=4","gravatar_id":"","url":"https://api.github.com/users/foriequal0","html_url":"https://github.com/foriequal0","followers_url":"https://api.github.com/users/foriequal0/followers","following_url":"https://api.github.com/users/foriequal0/following{/other_user}","gists_url":"https://api.github.com/users/foriequal0/gists{/gist_id}","starred_url":"https://api.github.com/users/foriequal0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foriequal0/subscriptions","organizations_url":"https://api.github.com/users/foriequal0/orgs","repos_url":"https://api.github.com/users/foriequal0/repos","events_url":"https://api.github.com/users/foriequal0/events{/privacy}","received_events_url":"https://api.github.com/users/foriequal0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/foriequal0/codechain","description":"Programmable multi-asset chain","fork":true,"url":"https://api.github.com/repos/foriequal0/codechain","forks_url":"https://api.github.com/repos/foriequal0/codechain/forks","keys_url":"https://api.github.com/repos/foriequal0/codechain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foriequal0/codechain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foriequal0/codechain/teams","hooks_url":"https://api.github.com/repos/foriequal0/codechain/hooks","issue_events_url":"https://api.github.com/repos/foriequal0/codechain/issues/events{/number}","events_url":"https://api.github.com/repos/foriequal0/codechain/events","assignees_url":"https://api.github.com/repos/foriequal0/codechain/assignees{/user}","branches_url":"https://api.github.com/repos/foriequal0/codechain/branches{/branch}","tags_url":"https://api.github.com/repos/foriequal0/codechain/tags","blobs_url":"https://api.github.com/repos/foriequal0/codechain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foriequal0/codechain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foriequal0/codechain/git/refs{/sha}","trees_url":"https://api.github.com/repos/foriequal0/codechain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foriequal0/codechain/statuses/{sha}","languages_url":"https://api.github.com/repos/foriequal0/codechain/languages","stargazers_url":"https://api.github.com/repos/foriequal0/codechain/stargazers","contributors_url":"https://api.github.com/repos/foriequal0/codechain/contributors","subscribers_url":"https://api.github.com/repos/foriequal0/codechain/subscribers","subscription_url":"https://api.github.com/repos/foriequal0/codechain/subscription","commits_url":"https://api.github.com/repos/foriequal0/codechain/commits{/sha}","git_commits_url":"https://api.github.com/repos/foriequal0/codechain/git/commits{/sha}","comments_url":"https://api.github.com/repos/foriequal0/codechain/comments{/number}","issue_comment_url":"https://api.github.com/repos/foriequal0/codechain/issues/comments{/number}","contents_url":"https://api.github.com/repos/foriequal0/codechain/contents/{+path}","compare_url":"https://api.github.com/repos/foriequal0/codechain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foriequal0/codechain/merges","archive_url":"https://api.github.com/repos/foriequal0/codechain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foriequal0/codechain/downloads","issues_url":"https://api.github.com/repos/foriequal0/codechain/issues{/number}","pulls_url":"https://api.github.com/repos/foriequal0/codechain/pulls{/number}","milestones_url":"https://api.github.com/repos/foriequal0/codechain/milestones{/number}","notifications_url":"https://api.github.com/repos/foriequal0/codechain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foriequal0/codechain/labels{/name}","releases_url":"https://api.github.com/repos/foriequal0/codechain/releases{/id}","deployments_url":"https://api.github.com/repos/foriequal0/codechain/deployments","created_at":"2018-08-03T09:54:20Z","updated_at":"2019-12-09T03:30:37Z","pushed_at":"2019-12-10T08:15:21Z","git_url":"git://github.com/foriequal0/codechain.git","ssh_url":"git@github.com:foriequal0/codechain.git","clone_url":"https://github.com/foriequal0/codechain.git","svn_url":"https://github.com/foriequal0/codechain","homepage":"https://codechain.io/","size":12310,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CodeChain-io:master","ref":"master","sha":"79322e18609fa566ce52c95976a4d05a687c82ea","user":{"login":"CodeChain-io","id":32665109,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/32665109?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeChain-io","html_url":"https://github.com/CodeChain-io","followers_url":"https://api.github.com/users/CodeChain-io/followers","following_url":"https://api.github.com/users/CodeChain-io/following{/other_user}","gists_url":"https://api.github.com/users/CodeChain-io/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeChain-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeChain-io/subscriptions","organizations_url":"https://api.github.com/users/CodeChain-io/orgs","repos_url":"https://api.github.com/users/CodeChain-io/repos","events_url":"https://api.github.com/users/CodeChain-io/events{/privacy}","received_events_url":"https://api.github.com/users/CodeChain-io/received_events","type":"Organization","site_admin":false},"repo":{"id":118557921,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1NTc5MjE=","name":"codechain","full_name":"CodeChain-io/codechain","private":false,"owner":{"login":"CodeChain-io","id":32665109,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjY1MTA5","avatar_url":"https://avatars1.githubusercontent.com/u/32665109?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeChain-io","html_url":"https://github.com/CodeChain-io","followers_url":"https://api.github.com/users/CodeChain-io/followers","following_url":"https://api.github.com/users/CodeChain-io/following{/other_user}","gists_url":"https://api.github.com/users/CodeChain-io/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeChain-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeChain-io/subscriptions","organizations_url":"https://api.github.com/users/CodeChain-io/orgs","repos_url":"https://api.github.com/users/CodeChain-io/repos","events_url":"https://api.github.com/users/CodeChain-io/events{/privacy}","received_events_url":"https://api.github.com/users/CodeChain-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CodeChain-io/codechain","description":"Programmable multi-asset chain","fork":false,"url":"https://api.github.com/repos/CodeChain-io/codechain","forks_url":"https://api.github.com/repos/CodeChain-io/codechain/forks","keys_url":"https://api.github.com/repos/CodeChain-io/codechain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeChain-io/codechain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeChain-io/codechain/teams","hooks_url":"https://api.github.com/repos/CodeChain-io/codechain/hooks","issue_events_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/events{/number}","events_url":"https://api.github.com/repos/CodeChain-io/codechain/events","assignees_url":"https://api.github.com/repos/CodeChain-io/codechain/assignees{/user}","branches_url":"https://api.github.com/repos/CodeChain-io/codechain/branches{/branch}","tags_url":"https://api.github.com/repos/CodeChain-io/codechain/tags","blobs_url":"https://api.github.com/repos/CodeChain-io/codechain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeChain-io/codechain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeChain-io/codechain/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeChain-io/codechain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeChain-io/codechain/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeChain-io/codechain/languages","stargazers_url":"https://api.github.com/repos/CodeChain-io/codechain/stargazers","contributors_url":"https://api.github.com/repos/CodeChain-io/codechain/contributors","subscribers_url":"https://api.github.com/repos/CodeChain-io/codechain/subscribers","subscription_url":"https://api.github.com/repos/CodeChain-io/codechain/subscription","commits_url":"https://api.github.com/repos/CodeChain-io/codechain/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeChain-io/codechain/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeChain-io/codechain/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeChain-io/codechain/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeChain-io/codechain/contents/{+path}","compare_url":"https://api.github.com/repos/CodeChain-io/codechain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeChain-io/codechain/merges","archive_url":"https://api.github.com/repos/CodeChain-io/codechain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeChain-io/codechain/downloads","issues_url":"https://api.github.com/repos/CodeChain-io/codechain/issues{/number}","pulls_url":"https://api.github.com/repos/CodeChain-io/codechain/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeChain-io/codechain/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeChain-io/codechain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeChain-io/codechain/labels{/name}","releases_url":"https://api.github.com/repos/CodeChain-io/codechain/releases{/id}","deployments_url":"https://api.github.com/repos/CodeChain-io/codechain/deployments","created_at":"2018-01-23T04:31:56Z","updated_at":"2019-12-09T07:42:46Z","pushed_at":"2019-12-10T08:17:32Z","git_url":"git://github.com/CodeChain-io/codechain.git","ssh_url":"git@github.com:CodeChain-io/codechain.git","clone_url":"https://github.com/CodeChain-io/codechain.git","svn_url":"https://github.com/CodeChain-io/codechain","homepage":"https://codechain.io/","size":12533,"stargazers_count":228,"watchers_count":228,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":47,"open_issues":102,"watchers":228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923"},"html":{"href":"https://github.com/CodeChain-io/codechain/pull/1923"},"issue":{"href":"https://api.github.com/repos/CodeChain-io/codechain/issues/1923"},"comments":{"href":"https://api.github.com/repos/CodeChain-io/codechain/issues/1923/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeChain-io/codechain/pulls/1923/commits"},"statuses":{"href":"https://api.github.com/repos/CodeChain-io/codechain/statuses/c0ee763dce2092edcd63c48642e5c260d5058abc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Remagpie"}}