{"action":"created","comment":{"url":"https://api.github.com/repos/tophat/syrupy/pulls/comments/355142790","pull_request_review_id":328574562,"id":355142790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTE0Mjc5MA==","diff_hunk":"@@ -36,12 +36,12 @@ test_set:\n     this: null\n test_set.1:\n   data: !!set\n-    this: null\n-    is: null\n     a: null\n     ? !!python/object/apply:builtins.frozenset\n     - - nested, set\n     : null\n+    is: null","path":"tests/__snapshots__/test_snapshots.yaml","position":10,"original_position":10,"commit_id":"5b433f4d0db33979f336983eda00f99241092230","original_commit_id":"5b433f4d0db33979f336983eda00f99241092230","user":{"login":"noahnu","id":1297096,"node_id":"MDQ6VXNlcjEyOTcwOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1297096?v=4","gravatar_id":"","url":"https://api.github.com/users/noahnu","html_url":"https://github.com/noahnu","followers_url":"https://api.github.com/users/noahnu/followers","following_url":"https://api.github.com/users/noahnu/following{/other_user}","gists_url":"https://api.github.com/users/noahnu/gists{/gist_id}","starred_url":"https://api.github.com/users/noahnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahnu/subscriptions","organizations_url":"https://api.github.com/users/noahnu/orgs","repos_url":"https://api.github.com/users/noahnu/repos","events_url":"https://api.github.com/users/noahnu/events{/privacy}","received_events_url":"https://api.github.com/users/noahnu/received_events","type":"User","site_admin":false},"body":"yaml should be sorting the keys in alphabetical order, so having \"tihs\" and \"is\" after \"a\" is correct. Perhaps an issue with different pyaml versions, or a limitation of \"set\"?","created_at":"2019-12-07T20:42:36Z","updated_at":"2019-12-07T20:42:36Z","html_url":"https://github.com/tophat/syrupy/pull/30#discussion_r355142790","pull_request_url":"https://api.github.com/repos/tophat/syrupy/pulls/30","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tophat/syrupy/pulls/comments/355142790"},"html":{"href":"https://github.com/tophat/syrupy/pull/30#discussion_r355142790"},"pull_request":{"href":"https://api.github.com/repos/tophat/syrupy/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/tophat/syrupy/pulls/30","id":350345358,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMzQ1MzU4","html_url":"https://github.com/tophat/syrupy/pull/30","diff_url":"https://github.com/tophat/syrupy/pull/30.diff","patch_url":"https://github.com/tophat/syrupy/pull/30.patch","issue_url":"https://api.github.com/repos/tophat/syrupy/issues/30","number":30,"state":"open","locked":false,"title":"refactor: collapse io and serializer into single class","user":{"login":"noahnu","id":1297096,"node_id":"MDQ6VXNlcjEyOTcwOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1297096?v=4","gravatar_id":"","url":"https://api.github.com/users/noahnu","html_url":"https://github.com/noahnu","followers_url":"https://api.github.com/users/noahnu/followers","following_url":"https://api.github.com/users/noahnu/following{/other_user}","gists_url":"https://api.github.com/users/noahnu/gists{/gist_id}","starred_url":"https://api.github.com/users/noahnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahnu/subscriptions","organizations_url":"https://api.github.com/users/noahnu/orgs","repos_url":"https://api.github.com/users/noahnu/repos","events_url":"https://api.github.com/users/noahnu/events{/privacy}","received_events_url":"https://api.github.com/users/noahnu/received_events","type":"User","site_admin":false},"body":"So far we haven't found a use case for separating IO and Serializer logic. I think we can simplify this if we collapse it into a single \"serializer\".","created_at":"2019-12-07T20:41:30Z","updated_at":"2019-12-07T20:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44f7fe7801f6e08e0ccbe3d97f0f819a691a5c56","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iamogbz","id":2528959,"node_id":"MDQ6VXNlcjI1Mjg5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2528959?v=4","gravatar_id":"","url":"https://api.github.com/users/iamogbz","html_url":"https://github.com/iamogbz","followers_url":"https://api.github.com/users/iamogbz/followers","following_url":"https://api.github.com/users/iamogbz/following{/other_user}","gists_url":"https://api.github.com/users/iamogbz/gists{/gist_id}","starred_url":"https://api.github.com/users/iamogbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamogbz/subscriptions","organizations_url":"https://api.github.com/users/iamogbz/orgs","repos_url":"https://api.github.com/users/iamogbz/repos","events_url":"https://api.github.com/users/iamogbz/events{/privacy}","received_events_url":"https://api.github.com/users/iamogbz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tophat/syrupy/pulls/30/commits","review_comments_url":"https://api.github.com/repos/tophat/syrupy/pulls/30/comments","review_comment_url":"https://api.github.com/repos/tophat/syrupy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tophat/syrupy/issues/30/comments","statuses_url":"https://api.github.com/repos/tophat/syrupy/statuses/5b433f4d0db33979f336983eda00f99241092230","head":{"label":"tophat:remove_io_serializer_distinction","ref":"remove_io_serializer_distinction","sha":"5b433f4d0db33979f336983eda00f99241092230","user":{"login":"tophat","id":40391306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzkxMzA2","avatar_url":"https://avatars0.githubusercontent.com/u/40391306?v=4","gravatar_id":"","url":"https://api.github.com/users/tophat","html_url":"https://github.com/tophat","followers_url":"https://api.github.com/users/tophat/followers","following_url":"https://api.github.com/users/tophat/following{/other_user}","gists_url":"https://api.github.com/users/tophat/gists{/gist_id}","starred_url":"https://api.github.com/users/tophat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophat/subscriptions","organizations_url":"https://api.github.com/users/tophat/orgs","repos_url":"https://api.github.com/users/tophat/repos","events_url":"https://api.github.com/users/tophat/events{/privacy}","received_events_url":"https://api.github.com/users/tophat/received_events","type":"Organization","site_admin":false},"repo":{"id":216412299,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY0MTIyOTk=","name":"syrupy","full_name":"tophat/syrupy","private":false,"owner":{"login":"tophat","id":40391306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzkxMzA2","avatar_url":"https://avatars0.githubusercontent.com/u/40391306?v=4","gravatar_id":"","url":"https://api.github.com/users/tophat","html_url":"https://github.com/tophat","followers_url":"https://api.github.com/users/tophat/followers","following_url":"https://api.github.com/users/tophat/following{/other_user}","gists_url":"https://api.github.com/users/tophat/gists{/gist_id}","starred_url":"https://api.github.com/users/tophat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophat/subscriptions","organizations_url":"https://api.github.com/users/tophat/orgs","repos_url":"https://api.github.com/users/tophat/repos","events_url":"https://api.github.com/users/tophat/events{/privacy}","received_events_url":"https://api.github.com/users/tophat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tophat/syrupy","description":"pytest snapshot plugin","fork":false,"url":"https://api.github.com/repos/tophat/syrupy","forks_url":"https://api.github.com/repos/tophat/syrupy/forks","keys_url":"https://api.github.com/repos/tophat/syrupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tophat/syrupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tophat/syrupy/teams","hooks_url":"https://api.github.com/repos/tophat/syrupy/hooks","issue_events_url":"https://api.github.com/repos/tophat/syrupy/issues/events{/number}","events_url":"https://api.github.com/repos/tophat/syrupy/events","assignees_url":"https://api.github.com/repos/tophat/syrupy/assignees{/user}","branches_url":"https://api.github.com/repos/tophat/syrupy/branches{/branch}","tags_url":"https://api.github.com/repos/tophat/syrupy/tags","blobs_url":"https://api.github.com/repos/tophat/syrupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tophat/syrupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tophat/syrupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tophat/syrupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tophat/syrupy/statuses/{sha}","languages_url":"https://api.github.com/repos/tophat/syrupy/languages","stargazers_url":"https://api.github.com/repos/tophat/syrupy/stargazers","contributors_url":"https://api.github.com/repos/tophat/syrupy/contributors","subscribers_url":"https://api.github.com/repos/tophat/syrupy/subscribers","subscription_url":"https://api.github.com/repos/tophat/syrupy/subscription","commits_url":"https://api.github.com/repos/tophat/syrupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tophat/syrupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tophat/syrupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tophat/syrupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tophat/syrupy/contents/{+path}","compare_url":"https://api.github.com/repos/tophat/syrupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tophat/syrupy/merges","archive_url":"https://api.github.com/repos/tophat/syrupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tophat/syrupy/downloads","issues_url":"https://api.github.com/repos/tophat/syrupy/issues{/number}","pulls_url":"https://api.github.com/repos/tophat/syrupy/pulls{/number}","milestones_url":"https://api.github.com/repos/tophat/syrupy/milestones{/number}","notifications_url":"https://api.github.com/repos/tophat/syrupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tophat/syrupy/labels{/name}","releases_url":"https://api.github.com/repos/tophat/syrupy/releases{/id}","deployments_url":"https://api.github.com/repos/tophat/syrupy/deployments","created_at":"2019-10-20T19:01:50Z","updated_at":"2019-12-07T18:12:52Z","pushed_at":"2019-12-07T20:41:30Z","git_url":"git://github.com/tophat/syrupy.git","ssh_url":"git@github.com:tophat/syrupy.git","clone_url":"https://github.com/tophat/syrupy.git","svn_url":"https://github.com/tophat/syrupy","homepage":null,"size":548,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":9,"watchers":3,"default_branch":"master"}},"base":{"label":"tophat:master","ref":"master","sha":"1680d1027b2b45bb586d395bf4b2656b71f590f9","user":{"login":"tophat","id":40391306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzkxMzA2","avatar_url":"https://avatars0.githubusercontent.com/u/40391306?v=4","gravatar_id":"","url":"https://api.github.com/users/tophat","html_url":"https://github.com/tophat","followers_url":"https://api.github.com/users/tophat/followers","following_url":"https://api.github.com/users/tophat/following{/other_user}","gists_url":"https://api.github.com/users/tophat/gists{/gist_id}","starred_url":"https://api.github.com/users/tophat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophat/subscriptions","organizations_url":"https://api.github.com/users/tophat/orgs","repos_url":"https://api.github.com/users/tophat/repos","events_url":"https://api.github.com/users/tophat/events{/privacy}","received_events_url":"https://api.github.com/users/tophat/received_events","type":"Organization","site_admin":false},"repo":{"id":216412299,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY0MTIyOTk=","name":"syrupy","full_name":"tophat/syrupy","private":false,"owner":{"login":"tophat","id":40391306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzkxMzA2","avatar_url":"https://avatars0.githubusercontent.com/u/40391306?v=4","gravatar_id":"","url":"https://api.github.com/users/tophat","html_url":"https://github.com/tophat","followers_url":"https://api.github.com/users/tophat/followers","following_url":"https://api.github.com/users/tophat/following{/other_user}","gists_url":"https://api.github.com/users/tophat/gists{/gist_id}","starred_url":"https://api.github.com/users/tophat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophat/subscriptions","organizations_url":"https://api.github.com/users/tophat/orgs","repos_url":"https://api.github.com/users/tophat/repos","events_url":"https://api.github.com/users/tophat/events{/privacy}","received_events_url":"https://api.github.com/users/tophat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tophat/syrupy","description":"pytest snapshot plugin","fork":false,"url":"https://api.github.com/repos/tophat/syrupy","forks_url":"https://api.github.com/repos/tophat/syrupy/forks","keys_url":"https://api.github.com/repos/tophat/syrupy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tophat/syrupy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tophat/syrupy/teams","hooks_url":"https://api.github.com/repos/tophat/syrupy/hooks","issue_events_url":"https://api.github.com/repos/tophat/syrupy/issues/events{/number}","events_url":"https://api.github.com/repos/tophat/syrupy/events","assignees_url":"https://api.github.com/repos/tophat/syrupy/assignees{/user}","branches_url":"https://api.github.com/repos/tophat/syrupy/branches{/branch}","tags_url":"https://api.github.com/repos/tophat/syrupy/tags","blobs_url":"https://api.github.com/repos/tophat/syrupy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tophat/syrupy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tophat/syrupy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tophat/syrupy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tophat/syrupy/statuses/{sha}","languages_url":"https://api.github.com/repos/tophat/syrupy/languages","stargazers_url":"https://api.github.com/repos/tophat/syrupy/stargazers","contributors_url":"https://api.github.com/repos/tophat/syrupy/contributors","subscribers_url":"https://api.github.com/repos/tophat/syrupy/subscribers","subscription_url":"https://api.github.com/repos/tophat/syrupy/subscription","commits_url":"https://api.github.com/repos/tophat/syrupy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tophat/syrupy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tophat/syrupy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tophat/syrupy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tophat/syrupy/contents/{+path}","compare_url":"https://api.github.com/repos/tophat/syrupy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tophat/syrupy/merges","archive_url":"https://api.github.com/repos/tophat/syrupy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tophat/syrupy/downloads","issues_url":"https://api.github.com/repos/tophat/syrupy/issues{/number}","pulls_url":"https://api.github.com/repos/tophat/syrupy/pulls{/number}","milestones_url":"https://api.github.com/repos/tophat/syrupy/milestones{/number}","notifications_url":"https://api.github.com/repos/tophat/syrupy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tophat/syrupy/labels{/name}","releases_url":"https://api.github.com/repos/tophat/syrupy/releases{/id}","deployments_url":"https://api.github.com/repos/tophat/syrupy/deployments","created_at":"2019-10-20T19:01:50Z","updated_at":"2019-12-07T18:12:52Z","pushed_at":"2019-12-07T20:41:30Z","git_url":"git://github.com/tophat/syrupy.git","ssh_url":"git@github.com:tophat/syrupy.git","clone_url":"https://github.com/tophat/syrupy.git","svn_url":"https://github.com/tophat/syrupy","homepage":null,"size":548,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tophat/syrupy/pulls/30"},"html":{"href":"https://github.com/tophat/syrupy/pull/30"},"issue":{"href":"https://api.github.com/repos/tophat/syrupy/issues/30"},"comments":{"href":"https://api.github.com/repos/tophat/syrupy/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/tophat/syrupy/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/tophat/syrupy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tophat/syrupy/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/tophat/syrupy/statuses/5b433f4d0db33979f336983eda00f99241092230"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"noahnu"}}