{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74855","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74855/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74855/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74855/events","html_url":"https://github.com/kubernetes/kubernetes/pull/74855","id":416450919,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3Njk3OTMz","number":74855,"title":"Add Port configuration to ServiceReference of Admission webhooks, CRD Conversion Webhooks, AuditSink Webhooks and kube-aggregator","user":{"login":"mbohlool","id":1613024,"node_id":"MDQ6VXNlcjE2MTMwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1613024?v=4","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"labels":[{"id":136601536,"node_id":"MDU6TGFiZWwxMzY2MDE1MzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/apiserver","name":"area/apiserver","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"node_id":"MDU6TGFiZWwyNjEwMDUzNjA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"e11d21","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":357119284,"node_id":"MDU6TGFiZWwzNTcxMTkyODQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/auth","name":"sig/auth","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-03-02T22:52:01Z","updated_at":"2019-03-02T23:00:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/74855","html_url":"https://github.com/kubernetes/kubernetes/pull/74855","diff_url":"https://github.com/kubernetes/kubernetes/pull/74855.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/74855.patch"},"body":"This is a [work item for Admission Webhooks GA](https://github.com/liggitt/enhancements/blob/7b7fc0c2293c02c9bb580805dbdae49d802a189b/keps/sig-api-machinery/00xx-admission-webhooks-to-ga.md#port-configuration). To be consistent in the feature set of all webhooks and service references, the port configuration added to the rest of the features including kube-aggregator. All of these services share some level of code and it make sense to support this in all of them.\r\n\r\nThis however need to be documented for each service separately.\r\n\r\n```release-note\r\n- Added port configuration to Admission webhook configuration service reference.\r\n- Added port configuration to AuditSink webhook configuration service reference.\r\n- Added port configuration to CRD Conversion webhook configuration service reference.\r\n- Added port configuration to kube-aggregator service reference.\r\n```\r\n\r\n@liggitt @sttts @caesarxuchao "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/468968764","html_url":"https://github.com/kubernetes/kubernetes/pull/74855#issuecomment-468968764","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/74855","id":468968764,"node_id":"MDEyOklzc3VlQ29tbWVudDQ2ODk2ODc2NA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-03-02T23:00:59Z","updated_at":"2019-03-02T23:00:59Z","author_association":"CONTRIBUTOR","body":"@mbohlool: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-build | dad12e7b95bac75cae1846552d635a1466875e34 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/74855/pull-kubernetes-bazel-build/75327/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-gce | dad12e7b95bac75cae1846552d635a1466875e34 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/74855/pull-kubernetes-e2e-gce/71026/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | dad12e7b95bac75cae1846552d635a1466875e34 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/74855/pull-kubernetes-e2e-gce-device-plugin-gpu/61508/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-bazel-test | dad12e7b95bac75cae1846552d635a1466875e34 | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/74855/pull-kubernetes-bazel-test/78081/) | `/test pull-kubernetes-bazel-test`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=74855). [Your PR dashboard](https://gubernator.k8s.io/pr/mbohlool). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}