{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14430","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14430/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14430/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14430/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/14430","id":470735295,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NjA1MDM1","number":14430,"title":"FIX remove lambdas from text preprocessing","user":{"login":"deniederhut","id":6868396,"node_id":"MDQ6VXNlcjY4NjgzOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6868396?v=4","gravatar_id":"","url":"https://api.github.com/users/deniederhut","html_url":"https://github.com/deniederhut","followers_url":"https://api.github.com/users/deniederhut/followers","following_url":"https://api.github.com/users/deniederhut/following{/other_user}","gists_url":"https://api.github.com/users/deniederhut/gists{/gist_id}","starred_url":"https://api.github.com/users/deniederhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deniederhut/subscriptions","organizations_url":"https://api.github.com/users/deniederhut/orgs","repos_url":"https://api.github.com/users/deniederhut/repos","events_url":"https://api.github.com/users/deniederhut/events{/privacy}","received_events_url":"https://api.github.com/users/deniederhut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-07-21T02:47:05Z","updated_at":"2019-07-30T02:15:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/14430","html_url":"https://github.com/scikit-learn/scikit-learn/pull/14430","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/14430.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/14430.patch"},"body":"Lambda functions are non-serializable under the stdlib pickle\r\nmodule. This commit replaces the lambdas found in three text\r\npreprocessing functions with hidden functions for chaining\r\na sequence of preprocessing steps that can be partialed where\r\nappropriate.\r\n\r\n#### Reference Issues/PRs\r\n\r\nCloses #12833\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nInstead of composing functions with lambdas, create chains \r\nof preprocessing steps inside single functions that can \r\nbe decomposed with partialing.\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/516231635","html_url":"https://github.com/scikit-learn/scikit-learn/pull/14430#issuecomment-516231635","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/14430","id":516231635,"node_id":"MDEyOklzc3VlQ29tbWVudDUxNjIzMTYzNQ==","user":{"login":"deniederhut","id":6868396,"node_id":"MDQ6VXNlcjY4NjgzOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/6868396?v=4","gravatar_id":"","url":"https://api.github.com/users/deniederhut","html_url":"https://github.com/deniederhut","followers_url":"https://api.github.com/users/deniederhut/followers","following_url":"https://api.github.com/users/deniederhut/following{/other_user}","gists_url":"https://api.github.com/users/deniederhut/gists{/gist_id}","starred_url":"https://api.github.com/users/deniederhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deniederhut/subscriptions","organizations_url":"https://api.github.com/users/deniederhut/orgs","repos_url":"https://api.github.com/users/deniederhut/repos","events_url":"https://api.github.com/users/deniederhut/events{/privacy}","received_events_url":"https://api.github.com/users/deniederhut/received_events","type":"User","site_admin":false},"created_at":"2019-07-30T02:15:58Z","updated_at":"2019-07-30T02:15:58Z","author_association":"CONTRIBUTOR","body":"Hm... Circle is showing\r\n\r\n```\r\nagent key RSA SHA256:oEdX/44m2Y1klY5Uq287qOWuWfJrhusv4e5ImKQ5Uhk returned incorrect signature type\r\n```\r\n\r\nDoes this need to be rebased?"}}
{"actor":{"display_login":"deniederhut"}}