{"action":"created","comment":{"url":"https://api.github.com/repos/rancher/machine/pulls/comments/344382056","pull_request_review_id":314480994,"id":344382056,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDM4MjA1Ng==","diff_hunk":"@@ -35,6 +38,122 @@ func (d *Driver) remoteExec(procman *guest.ProcessManager, arg string) (int64, e\n \treturn code, nil\n }\n \n+func (d *Driver) getDatastore(spec *types.VirtualMachineConfigSpec) (*object.Datastore, error) {\n+\tvar sp *object.StoragePod\n+\tif d.DatastoreCluster != \"\" {\n+\t\tlog.Infof(\"Finding datastore cluster %s\", d.DatastoreCluster)\n+\t\tsp, err := d.finder.DatastoreCluster(d.getCtx(), d.DatastoreCluster)\n+\t\tif err != nil {\n+\t\t\treturn nil, err\n+\t\t}\n+\n+\t\treturn d.recommendDatastore(sp, spec)\n+\t}\n+\n+\tif d.Datastore != \"\" {\n+\t\tlog.Infof(\"Finding datastore %s\", d.Datastore)","path":"drivers/vmwarevsphere/utils.go","position":30,"original_position":30,"commit_id":"d7d6a6411315400fa5ea2769dba7634694e02bb4","original_commit_id":"d7d6a6411315400fa5ea2769dba7634694e02bb4","user":{"login":"alena1108","id":1562176,"node_id":"MDQ6VXNlcjE1NjIxNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1562176?v=4","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"body":"nit: shall it be \"found\"? ","created_at":"2019-11-08T21:54:54Z","updated_at":"2019-11-08T21:54:54Z","html_url":"https://github.com/rancher/machine/pull/48#discussion_r344382056","pull_request_url":"https://api.github.com/repos/rancher/machine/pulls/48","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rancher/machine/pulls/comments/344382056"},"html":{"href":"https://github.com/rancher/machine/pull/48#discussion_r344382056"},"pull_request":{"href":"https://api.github.com/repos/rancher/machine/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/rancher/machine/pulls/48","id":338865422,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4ODY1NDIy","html_url":"https://github.com/rancher/machine/pull/48","diff_url":"https://github.com/rancher/machine/pull/48.diff","patch_url":"https://github.com/rancher/machine/pull/48.patch","issue_url":"https://api.github.com/repos/rancher/machine/issues/48","number":48,"state":"open","locked":false,"title":"update vmwarevsphere to support datastore-clusters","user":{"login":"luthermonson","id":1616909,"node_id":"MDQ6VXNlcjE2MTY5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1616909?v=4","gravatar_id":"","url":"https://api.github.com/users/luthermonson","html_url":"https://github.com/luthermonson","followers_url":"https://api.github.com/users/luthermonson/followers","following_url":"https://api.github.com/users/luthermonson/following{/other_user}","gists_url":"https://api.github.com/users/luthermonson/gists{/gist_id}","starred_url":"https://api.github.com/users/luthermonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luthermonson/subscriptions","organizations_url":"https://api.github.com/users/luthermonson/orgs","repos_url":"https://api.github.com/users/luthermonson/repos","events_url":"https://api.github.com/users/luthermonson/events{/privacy}","received_events_url":"https://api.github.com/users/luthermonson/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-08T21:27:56Z","updated_at":"2019-11-08T21:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f43bf5a90ad5cb867a384f8a4dd8290b3d20e4a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/machine/pulls/48/commits","review_comments_url":"https://api.github.com/repos/rancher/machine/pulls/48/comments","review_comment_url":"https://api.github.com/repos/rancher/machine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/machine/issues/48/comments","statuses_url":"https://api.github.com/repos/rancher/machine/statuses/d7d6a6411315400fa5ea2769dba7634694e02bb4","head":{"label":"luthermonson:ds-clusters","ref":"ds-clusters","sha":"d7d6a6411315400fa5ea2769dba7634694e02bb4","user":{"login":"luthermonson","id":1616909,"node_id":"MDQ6VXNlcjE2MTY5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1616909?v=4","gravatar_id":"","url":"https://api.github.com/users/luthermonson","html_url":"https://github.com/luthermonson","followers_url":"https://api.github.com/users/luthermonson/followers","following_url":"https://api.github.com/users/luthermonson/following{/other_user}","gists_url":"https://api.github.com/users/luthermonson/gists{/gist_id}","starred_url":"https://api.github.com/users/luthermonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luthermonson/subscriptions","organizations_url":"https://api.github.com/users/luthermonson/orgs","repos_url":"https://api.github.com/users/luthermonson/repos","events_url":"https://api.github.com/users/luthermonson/events{/privacy}","received_events_url":"https://api.github.com/users/luthermonson/received_events","type":"User","site_admin":false},"repo":{"id":196652527,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY2NTI1Mjc=","name":"machine","full_name":"luthermonson/machine","private":false,"owner":{"login":"luthermonson","id":1616909,"node_id":"MDQ6VXNlcjE2MTY5MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1616909?v=4","gravatar_id":"","url":"https://api.github.com/users/luthermonson","html_url":"https://github.com/luthermonson","followers_url":"https://api.github.com/users/luthermonson/followers","following_url":"https://api.github.com/users/luthermonson/following{/other_user}","gists_url":"https://api.github.com/users/luthermonson/gists{/gist_id}","starred_url":"https://api.github.com/users/luthermonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luthermonson/subscriptions","organizations_url":"https://api.github.com/users/luthermonson/orgs","repos_url":"https://api.github.com/users/luthermonson/repos","events_url":"https://api.github.com/users/luthermonson/events{/privacy}","received_events_url":"https://api.github.com/users/luthermonson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/luthermonson/machine","description":"Machine management for a container-centric world","fork":true,"url":"https://api.github.com/repos/luthermonson/machine","forks_url":"https://api.github.com/repos/luthermonson/machine/forks","keys_url":"https://api.github.com/repos/luthermonson/machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luthermonson/machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luthermonson/machine/teams","hooks_url":"https://api.github.com/repos/luthermonson/machine/hooks","issue_events_url":"https://api.github.com/repos/luthermonson/machine/issues/events{/number}","events_url":"https://api.github.com/repos/luthermonson/machine/events","assignees_url":"https://api.github.com/repos/luthermonson/machine/assignees{/user}","branches_url":"https://api.github.com/repos/luthermonson/machine/branches{/branch}","tags_url":"https://api.github.com/repos/luthermonson/machine/tags","blobs_url":"https://api.github.com/repos/luthermonson/machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luthermonson/machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luthermonson/machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/luthermonson/machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luthermonson/machine/statuses/{sha}","languages_url":"https://api.github.com/repos/luthermonson/machine/languages","stargazers_url":"https://api.github.com/repos/luthermonson/machine/stargazers","contributors_url":"https://api.github.com/repos/luthermonson/machine/contributors","subscribers_url":"https://api.github.com/repos/luthermonson/machine/subscribers","subscription_url":"https://api.github.com/repos/luthermonson/machine/subscription","commits_url":"https://api.github.com/repos/luthermonson/machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/luthermonson/machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/luthermonson/machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/luthermonson/machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/luthermonson/machine/contents/{+path}","compare_url":"https://api.github.com/repos/luthermonson/machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luthermonson/machine/merges","archive_url":"https://api.github.com/repos/luthermonson/machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luthermonson/machine/downloads","issues_url":"https://api.github.com/repos/luthermonson/machine/issues{/number}","pulls_url":"https://api.github.com/repos/luthermonson/machine/pulls{/number}","milestones_url":"https://api.github.com/repos/luthermonson/machine/milestones{/number}","notifications_url":"https://api.github.com/repos/luthermonson/machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luthermonson/machine/labels{/name}","releases_url":"https://api.github.com/repos/luthermonson/machine/releases{/id}","deployments_url":"https://api.github.com/repos/luthermonson/machine/deployments","created_at":"2019-07-12T22:21:36Z","updated_at":"2019-11-07T00:41:16Z","pushed_at":"2019-11-08T21:40:13Z","git_url":"git://github.com/luthermonson/machine.git","ssh_url":"git@github.com:luthermonson/machine.git","clone_url":"https://github.com/luthermonson/machine.git","svn_url":"https://github.com/luthermonson/machine","homepage":"https://docs.docker.com/machine/","size":19895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"1365624adba73cec2da0f6f94307e523c3955f81","user":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":117871958,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4NzE5NTg=","name":"machine","full_name":"rancher/machine","private":false,"owner":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rancher/machine","description":"Machine management for a container-centric world","fork":true,"url":"https://api.github.com/repos/rancher/machine","forks_url":"https://api.github.com/repos/rancher/machine/forks","keys_url":"https://api.github.com/repos/rancher/machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/machine/teams","hooks_url":"https://api.github.com/repos/rancher/machine/hooks","issue_events_url":"https://api.github.com/repos/rancher/machine/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/machine/events","assignees_url":"https://api.github.com/repos/rancher/machine/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/machine/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/machine/tags","blobs_url":"https://api.github.com/repos/rancher/machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/machine/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/machine/languages","stargazers_url":"https://api.github.com/repos/rancher/machine/stargazers","contributors_url":"https://api.github.com/repos/rancher/machine/contributors","subscribers_url":"https://api.github.com/repos/rancher/machine/subscribers","subscription_url":"https://api.github.com/repos/rancher/machine/subscription","commits_url":"https://api.github.com/repos/rancher/machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/machine/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/machine/merges","archive_url":"https://api.github.com/repos/rancher/machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/machine/downloads","issues_url":"https://api.github.com/repos/rancher/machine/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/machine/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/machine/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/machine/labels{/name}","releases_url":"https://api.github.com/repos/rancher/machine/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/machine/deployments","created_at":"2018-01-17T17:52:39Z","updated_at":"2019-11-05T23:41:43Z","pushed_at":"2019-11-08T21:40:14Z","git_url":"git://github.com/rancher/machine.git","ssh_url":"git@github.com:rancher/machine.git","clone_url":"https://github.com/rancher/machine.git","svn_url":"https://github.com/rancher/machine","homepage":"https://docs.docker.com/machine/","size":19885,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":12,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/machine/pulls/48"},"html":{"href":"https://github.com/rancher/machine/pull/48"},"issue":{"href":"https://api.github.com/repos/rancher/machine/issues/48"},"comments":{"href":"https://api.github.com/repos/rancher/machine/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/machine/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/machine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/machine/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/machine/statuses/d7d6a6411315400fa5ea2769dba7634694e02bb4"}},"author_association":"NONE"}}
{"actor":{"display_login":"alena1108"}}