{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/300703183","pull_request_review_id":258421144,"id":300703183,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDcwMzE4Mw==","diff_hunk":"@@ -379,22 +379,18 @@\n \t}\n \n \tfunction fakeSelectionDragHandler( evt ) {\n-\t\tvar table = evt.data.getTarget().getAscendant( 'table', true );\n+\t\tvar table = evt.data.getTarget().getAscendant( 'table', true ),\n+\t\t\teditor = evt.editor || evt.sender.editor;\n \n-\t\t// (#2945)\n-\t\tif ( table && table.hasAttribute( ignoredTableAttribute ) ) {\n+\t\t// (#547)\n+\t\tif ( table && evt.name == 'dragstart' ) {\n+\t\t\ttable.data( ignoredTableAttribute, '' );","path":"plugins/tableselection/plugin.js","position":12,"original_position":12,"commit_id":"207d867cff6c582edf5627ed32ffdbb7f58bfd76","original_commit_id":"207d867cff6c582edf5627ed32ffdbb7f58bfd76","user":{"login":"f1ames","id":1061942,"node_id":"MDQ6VXNlcjEwNjE5NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1061942?v=4","gravatar_id":"","url":"https://api.github.com/users/f1ames","html_url":"https://github.com/f1ames","followers_url":"https://api.github.com/users/f1ames/followers","following_url":"https://api.github.com/users/f1ames/following{/other_user}","gists_url":"https://api.github.com/users/f1ames/gists{/gist_id}","starred_url":"https://api.github.com/users/f1ames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f1ames/subscriptions","organizations_url":"https://api.github.com/users/f1ames/orgs","repos_url":"https://api.github.com/users/f1ames/repos","events_url":"https://api.github.com/users/f1ames/events{/privacy}","received_events_url":"https://api.github.com/users/f1ames/received_events","type":"User","site_admin":false},"body":"I would consider the other way around approach too (not saying it will be better but worth checking) - instead of just always allowing dragging (this is what happens after this change basically), maybe don't prevent `dragStart` event in more case. The same it is done for `table && table.hasAttribute( ignoredTableAttribute )` or `!cell || cell.hasClass( fakeSelectedClass )` - it should be also possible to be done for image or text elements.","created_at":"2019-07-05T14:22:34Z","updated_at":"2019-07-05T14:23:15Z","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/3244#discussion_r300703183","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/300703183"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/3244#discussion_r300703183"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244"}},"in_reply_to_id":300701477},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244","id":294875151,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0ODc1MTUx","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/3244","diff_url":"https://github.com/ckeditor/ckeditor-dev/pull/3244.diff","patch_url":"https://github.com/ckeditor/ckeditor-dev/pull/3244.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/3244","number":3244,"state":"open","locked":false,"title":"Fix for: Element/Image drag to move within table is no longer available","user":{"login":"Dumluregn","id":10883184,"node_id":"MDQ6VXNlcjEwODgzMTg0","avatar_url":"https://avatars1.githubusercontent.com/u/10883184?v=4","gravatar_id":"","url":"https://api.github.com/users/Dumluregn","html_url":"https://github.com/Dumluregn","followers_url":"https://api.github.com/users/Dumluregn/followers","following_url":"https://api.github.com/users/Dumluregn/following{/other_user}","gists_url":"https://api.github.com/users/Dumluregn/gists{/gist_id}","starred_url":"https://api.github.com/users/Dumluregn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dumluregn/subscriptions","organizations_url":"https://api.github.com/users/Dumluregn/orgs","repos_url":"https://api.github.com/users/Dumluregn/repos","events_url":"https://api.github.com/users/Dumluregn/events{/privacy}","received_events_url":"https://api.github.com/users/Dumluregn/received_events","type":"User","site_admin":false},"body":"## What is the purpose of this pull request?\r\n\r\nBug fix\r\n\r\n## Does your PR contain necessary tests?\r\n\r\nAll patches which change the editor code must include tests. You can always read more\r\non [PR testing](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_contributing_code.html#tests),\r\n[how to set the testing environment](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_tests.html) and\r\n[how to create tests](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_tests.html#creating-your-own-test)\r\nin the official CKEditor documentation.\r\n\r\n### This PR contains\r\n\r\n- [ ] Unit tests\r\n- [ ] Manual tests\r\n\r\n## What is the proposed changelog entry for this pull request?\r\n\r\n`[#547](https://github.com/ckeditor/ckeditor-dev/issues/547): Fixed: Element/Image drag to move within table is no longer available when using [Table Selection plugin](https://ckeditor.com/cke4/addon/tableselection).`\r\n\r\n## What changes did you make?\r\n\r\nAdded drag&drop handling so that table selection no longer needs to cancel those events.","created_at":"2019-07-05T13:22:29Z","updated_at":"2019-07-05T14:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff43019161fb9243e9b1e1518f95e5b4265b10f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/3244/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/207d867cff6c582edf5627ed32ffdbb7f58bfd76","head":{"label":"ckeditor:t/547","ref":"t/547","sha":"207d867cff6c582edf5627ed32ffdbb7f58bfd76","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgyMTcy","name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","private":false,"owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2019-07-05T11:12:10Z","pushed_at":"2019-07-05T13:22:29Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":69931,"stargazers_count":4655,"watchers_count":4655,"language":"Rich Text Format","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2062,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":930,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2062,"open_issues":930,"watchers":4655,"default_branch":"major"}},"base":{"label":"ckeditor:major","ref":"major","sha":"ab6f23f2af9591a9b680fc518f5e155a4afc4c39","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgyMTcy","name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","private":false,"owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2019-07-05T11:12:10Z","pushed_at":"2019-07-05T13:22:29Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":69931,"stargazers_count":4655,"watchers_count":4655,"language":"Rich Text Format","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2062,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":930,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2062,"open_issues":930,"watchers":4655,"default_branch":"major"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/3244"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/3244"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/3244/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/3244/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/207d867cff6c582edf5627ed32ffdbb7f58bfd76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"f1ames"}}