{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/82572","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/82572/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/82572/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/82572/events","html_url":"https://github.com/kubernetes/kubernetes/pull/82572","id":492111877,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2MzQ3Mjk4","number":82572,"title":"Fix RS expectations for recreate case","user":{"login":"tnozicka","id":11869554,"node_id":"MDQ6VXNlcjExODY5NTU0","avatar_url":"https://avatars2.githubusercontent.com/u/11869554?v=4","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-09-11T09:10:54Z","updated_at":"2019-09-11T14:36:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/82572","html_url":"https://github.com/kubernetes/kubernetes/pull/82572","diff_url":"https://github.com/kubernetes/kubernetes/pull/82572.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/82572.patch"},"body":"**What type of PR is this?**\r\n/kind bug\r\n/priority important-soon\r\n/sig apps\r\n\r\n**What this PR does / why we need it**:\r\nWith current implementation deleting expectations inside sync loop is error prone. \r\nhttps://github.com/kubernetes/kubernetes/blob/5823cfc/pkg/controller/replicaset/replica_set.go#L576\r\nIf we update the informers faster then the sync loop starts, it will already see the new RS (recreated) and miss the branch when it should delete the expectations for the old one. As a result it will get stuck waiting on the current expectations to timeout or some other external event like deleting the old pods.\r\n\r\nThis should have been mitigated by seeing the old pods deleted which seem to point to another issue with expectations there. Seeing some weird stuff there around handling expectations - I'll address it in a separate PR.\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes https://github.com/kubernetes/kubernetes/issues/69376\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n```release-note\r\nNONE\r\n```\r\n\r\nsome discussions were also in https://github.com/kubernetes/kubernetes/pull/72927\r\n\r\n/cc @kubernetes/sig-apps-pr-reviews @liggitt @lavalamp "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/530409928","html_url":"https://github.com/kubernetes/kubernetes/pull/82572#issuecomment-530409928","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/82572","id":530409928,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMDQwOTkyOA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2019-09-11T14:36:10Z","updated_at":"2019-09-11T14:36:10Z","author_association":"CONTRIBUTOR","body":"@tnozicka: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | efbcee371472a087c011b71609ecee03a16517af | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/82572/pull-kubernetes-verify/1171765113372282881) | `/test pull-kubernetes-verify`\npull-kubernetes-kubemark-e2e-gce-big | efbcee371472a087c011b71609ecee03a16517af | [link](https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/82572/pull-kubernetes-kubemark-e2e-gce-big/1171765113372282880/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=82572). [Your PR dashboard](https://gubernator.k8s.io/pr/tnozicka). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}