{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/339345042","pull_request_review_id":307575201,"id":339345042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTM0NTA0Mg==","diff_hunk":"@@ -380,7 +380,9 @@ private static DynamicJsonValue GetSubscriptionConnectionDJV(SubscriptionConnect\n                 [nameof(SubscriptionConnection.ClientUri)] = x.ClientUri,\n                 [nameof(SubscriptionConnection.Strategy)] = x.Strategy,\n                 [nameof(SubscriptionConnection.Stats)] = GetConnectionStatsDJV(x.Stats),\n-                [nameof(SubscriptionConnection.ConnectionException)] = x.ConnectionException?.Message\n+                [nameof(SubscriptionConnection.ConnectionException)] = x.ConnectionException?.Message,\n+                [\"TCPConnectionStats\"] = x.TcpConnection.GetConnectionStats(),","path":"src/Raven.Server/Documents/Handlers/SubscriptionsHandler.cs","position":6,"original_position":6,"commit_id":"d8265cc2a5a7116d5ada4b2ba18ee4cf5aa492e3","original_commit_id":"54eb32bcb13906f94bec96e0470f384601879672","user":{"login":"maximburyak","id":6830980,"node_id":"MDQ6VXNlcjY4MzA5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6830980?v=4","gravatar_id":"","url":"https://api.github.com/users/maximburyak","html_url":"https://github.com/maximburyak","followers_url":"https://api.github.com/users/maximburyak/followers","following_url":"https://api.github.com/users/maximburyak/following{/other_user}","gists_url":"https://api.github.com/users/maximburyak/gists{/gist_id}","starred_url":"https://api.github.com/users/maximburyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximburyak/subscriptions","organizations_url":"https://api.github.com/users/maximburyak/orgs","repos_url":"https://api.github.com/users/maximburyak/repos","events_url":"https://api.github.com/users/maximburyak/events{/privacy}","received_events_url":"https://api.github.com/users/maximburyak/received_events","type":"User","site_admin":false},"body":"I think that in that case, especially because it's a debug endpoint, it's more important to maintain clearer function name then to maintain \"strongly typed\" structure","created_at":"2019-10-27T14:15:39Z","updated_at":"2019-10-27T14:15:39Z","html_url":"https://github.com/ravendb/ravendb/pull/9822#discussion_r339345042","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/9822","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/339345042"},"html":{"href":"https://github.com/ravendb/ravendb/pull/9822#discussion_r339345042"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/9822"}},"in_reply_to_id":339343221},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/9822","id":332348067,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyMzQ4MDY3","html_url":"https://github.com/ravendb/ravendb/pull/9822","diff_url":"https://github.com/ravendb/ravendb/pull/9822.diff","patch_url":"https://github.com/ravendb/ravendb/pull/9822.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/9822","number":9822,"state":"open","locked":false,"title":"Raven db 14123","user":{"login":"maximburyak","id":6830980,"node_id":"MDQ6VXNlcjY4MzA5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6830980?v=4","gravatar_id":"","url":"https://api.github.com/users/maximburyak","html_url":"https://github.com/maximburyak","followers_url":"https://api.github.com/users/maximburyak/followers","following_url":"https://api.github.com/users/maximburyak/following{/other_user}","gists_url":"https://api.github.com/users/maximburyak/gists{/gist_id}","starred_url":"https://api.github.com/users/maximburyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximburyak/subscriptions","organizations_url":"https://api.github.com/users/maximburyak/orgs","repos_url":"https://api.github.com/users/maximburyak/repos","events_url":"https://api.github.com/users/maximburyak/events{/privacy}","received_events_url":"https://api.github.com/users/maximburyak/received_events","type":"User","site_admin":false},"body":"Fixed several subscriptions related issues\r\nhttps://issues.hibernatingrhinos.com/issue/RavenDB-14123\r\nhttps://issues.hibernatingrhinos.com/issue/RavenDB-14180\r\nhttps://issues.hibernatingrhinos.com/issue/RavenDB-14181\r\nhttps://issues.hibernatingrhinos.com/issue/RavenDB-14182\r\n","created_at":"2019-10-25T05:37:56Z","updated_at":"2019-10-27T14:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc347d14b878a8427af7dd04bd56ab88cac1f9ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1093054486,"node_id":"MDU6TGFiZWwxMDkzMDU0NDg2","url":"https://api.github.com/repos/ravendb/ravendb/labels/v4.2","name":"v4.2","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/9822/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/9822/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/9822/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/d8265cc2a5a7116d5ada4b2ba18ee4cf5aa492e3","head":{"label":"maximburyak:RavenDB-14123","ref":"RavenDB-14123","sha":"d8265cc2a5a7116d5ada4b2ba18ee4cf5aa492e3","user":{"login":"maximburyak","id":6830980,"node_id":"MDQ6VXNlcjY4MzA5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6830980?v=4","gravatar_id":"","url":"https://api.github.com/users/maximburyak","html_url":"https://github.com/maximburyak","followers_url":"https://api.github.com/users/maximburyak/followers","following_url":"https://api.github.com/users/maximburyak/following{/other_user}","gists_url":"https://api.github.com/users/maximburyak/gists{/gist_id}","starred_url":"https://api.github.com/users/maximburyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximburyak/subscriptions","organizations_url":"https://api.github.com/users/maximburyak/orgs","repos_url":"https://api.github.com/users/maximburyak/repos","events_url":"https://api.github.com/users/maximburyak/events{/privacy}","received_events_url":"https://api.github.com/users/maximburyak/received_events","type":"User","site_admin":false},"repo":{"id":17337755,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMzNzc1NQ==","name":"ravendb","full_name":"maximburyak/ravendb","private":false,"owner":{"login":"maximburyak","id":6830980,"node_id":"MDQ6VXNlcjY4MzA5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6830980?v=4","gravatar_id":"","url":"https://api.github.com/users/maximburyak","html_url":"https://github.com/maximburyak","followers_url":"https://api.github.com/users/maximburyak/followers","following_url":"https://api.github.com/users/maximburyak/following{/other_user}","gists_url":"https://api.github.com/users/maximburyak/gists{/gist_id}","starred_url":"https://api.github.com/users/maximburyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximburyak/subscriptions","organizations_url":"https://api.github.com/users/maximburyak/orgs","repos_url":"https://api.github.com/users/maximburyak/repos","events_url":"https://api.github.com/users/maximburyak/events{/privacy}","received_events_url":"https://api.github.com/users/maximburyak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maximburyak/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/maximburyak/ravendb","forks_url":"https://api.github.com/repos/maximburyak/ravendb/forks","keys_url":"https://api.github.com/repos/maximburyak/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximburyak/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximburyak/ravendb/teams","hooks_url":"https://api.github.com/repos/maximburyak/ravendb/hooks","issue_events_url":"https://api.github.com/repos/maximburyak/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/maximburyak/ravendb/events","assignees_url":"https://api.github.com/repos/maximburyak/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/maximburyak/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/maximburyak/ravendb/tags","blobs_url":"https://api.github.com/repos/maximburyak/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximburyak/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximburyak/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximburyak/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximburyak/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/maximburyak/ravendb/languages","stargazers_url":"https://api.github.com/repos/maximburyak/ravendb/stargazers","contributors_url":"https://api.github.com/repos/maximburyak/ravendb/contributors","subscribers_url":"https://api.github.com/repos/maximburyak/ravendb/subscribers","subscription_url":"https://api.github.com/repos/maximburyak/ravendb/subscription","commits_url":"https://api.github.com/repos/maximburyak/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximburyak/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximburyak/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximburyak/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximburyak/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/maximburyak/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximburyak/ravendb/merges","archive_url":"https://api.github.com/repos/maximburyak/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximburyak/ravendb/downloads","issues_url":"https://api.github.com/repos/maximburyak/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/maximburyak/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/maximburyak/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/maximburyak/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximburyak/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/maximburyak/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/maximburyak/ravendb/deployments","created_at":"2014-03-02T13:00:09Z","updated_at":"2016-10-19T14:04:55Z","pushed_at":"2019-10-27T14:10:17Z","git_url":"git://github.com/maximburyak/ravendb.git","ssh_url":"git@github.com:maximburyak/ravendb.git","clone_url":"https://github.com/maximburyak/ravendb.git","svn_url":"https://github.com/maximburyak/ravendb","homepage":"http://ayende.com/Blog/","size":504647,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"V3.5"}},"base":{"label":"ravendb:v4.2","ref":"v4.2","sha":"650cf711526a6f750a0f7178ad9488a9331d7051","user":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI3MTQ=","name":"ravendb","full_name":"ravendb/ravendb","private":false,"owner":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ravendb/ravendb","description":"ACID Document Database","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2019-10-25T12:05:21Z","pushed_at":"2019-10-27T14:10:19Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"https://ravendb.net","size":504539,"stargazers_count":2323,"watchers_count":2323,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":730,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":730,"open_issues":15,"watchers":2323,"default_branch":"v4.2"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/9822"},"html":{"href":"https://github.com/ravendb/ravendb/pull/9822"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/9822"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/9822/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/9822/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/9822/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/d8265cc2a5a7116d5ada4b2ba18ee4cf5aa492e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maximburyak"}}