{"action":"created","issue":{"url":"https://api.github.com/repos/simcodersdotcom/headshake/issues/24","repository_url":"https://api.github.com/repos/simcodersdotcom/headshake","labels_url":"https://api.github.com/repos/simcodersdotcom/headshake/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/simcodersdotcom/headshake/issues/24/comments","events_url":"https://api.github.com/repos/simcodersdotcom/headshake/issues/24/events","html_url":"https://github.com/simcodersdotcom/headshake/issues/24","id":487860874,"node_id":"MDU6SXNzdWU0ODc4NjA4NzQ=","number":24,"title":"Pull requests #21 and #23 issues","user":{"login":"nico87","id":1362662,"node_id":"MDQ6VXNlcjEzNjI2NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1362662?v=4","gravatar_id":"","url":"https://api.github.com/users/nico87","html_url":"https://github.com/nico87","followers_url":"https://api.github.com/users/nico87/followers","following_url":"https://api.github.com/users/nico87/following{/other_user}","gists_url":"https://api.github.com/users/nico87/gists{/gist_id}","starred_url":"https://api.github.com/users/nico87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico87/subscriptions","organizations_url":"https://api.github.com/users/nico87/orgs","repos_url":"https://api.github.com/users/nico87/repos","events_url":"https://api.github.com/users/nico87/events{/privacy}","received_events_url":"https://api.github.com/users/nico87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-09-01T09:08:33Z","updated_at":"2019-09-02T11:10:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"After accepting https://github.com/simcodersdotcom/headshake/pull/21 and https://github.com/simcodersdotcom/headshake/pull/23 and releasing HeadShake, users reported that it didn't work with X-Camera anymore.\r\n\r\nThe reasons are:\r\n\r\n1. Once HeadShake is overridden via the simcoders/headshake/override dataref, the head position datarefs are not updated anymore. I've fixed this with commit 7cd0b09acfd81a34148150298df310655a950ad3.\r\n1. The camera movements are now stuttering. I think this is caused by the \"quantize\" function. See this post: https://forums.x-plane.org/index.php?/files/file/20955-headshake-camera-plugin-lin-win-mac/&do=findComment&comment=279509\r\n\r\n@quantumac I've reverted the changes on master and released v1.12.9 to make the stable release of HeadShake work again without issues with X-Camera.\r\nCould you check these problems and make a new pull request? @markcellis is available for info about how the integration between X-Camera and HeadShake works."},"comment":{"url":"https://api.github.com/repos/simcodersdotcom/headshake/issues/comments/527108086","html_url":"https://github.com/simcodersdotcom/headshake/issues/24#issuecomment-527108086","issue_url":"https://api.github.com/repos/simcodersdotcom/headshake/issues/24","id":527108086,"node_id":"MDEyOklzc3VlQ29tbWVudDUyNzEwODA4Ng==","user":{"login":"markcellis","id":25938986,"node_id":"MDQ6VXNlcjI1OTM4OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/25938986?v=4","gravatar_id":"","url":"https://api.github.com/users/markcellis","html_url":"https://github.com/markcellis","followers_url":"https://api.github.com/users/markcellis/followers","following_url":"https://api.github.com/users/markcellis/following{/other_user}","gists_url":"https://api.github.com/users/markcellis/gists{/gist_id}","starred_url":"https://api.github.com/users/markcellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcellis/subscriptions","organizations_url":"https://api.github.com/users/markcellis/orgs","repos_url":"https://api.github.com/users/markcellis/repos","events_url":"https://api.github.com/users/markcellis/events{/privacy}","received_events_url":"https://api.github.com/users/markcellis/received_events","type":"User","site_admin":false},"created_at":"2019-09-02T11:10:06Z","updated_at":"2019-09-02T11:10:06Z","author_association":"NONE","body":"Unfortunately I’m not familiar enough with the HeadShake code to know if this corrects the problem.\n\n \n\nMark\n\n \n\nFrom: quantumac [mailto:notifications@github.com] \nSent: Sunday, September 1, 2019 6:51 PM\nTo: simcodersdotcom/headshake\nCc: Mark Ellis; Mention\nSubject: Re: [simcodersdotcom/headshake] Pull requests #21 and #23 issues (#24)\n\n \n\nAs requested, I've created a minimal changeset which addresses just the head roll issues. See it here:\n\nhttps://github.com/quantumac/headshake/tree/minimal_head_roll_fix\n\nI've also created a pull request.\n\n@markcellis <https://github.com/markcellis>  : please take a look at this change and see if it works for you.\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub <https://github.com/simcodersdotcom/headshake/issues/24?email_source=notifications&email_token=AGF4YKSOSXLIFD7MRY3ZBFDQHRBLRA5CNFSM4ISWEZAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UMLMY#issuecomment-526960051> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AGF4YKV4X55NJAYPLO7WNOTQHRBLRANCNFSM4ISWEZAA> .  <https://github.com/notifications/beacon/AGF4YKTST73NVV4UQY7M3SDQHRBLRA5CNFSM4ISWEZAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UMLMY.gif> \n\n"}}
{"actor":{"display_login":"markcellis"}}