{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments/281582424","pull_request_review_id":234453558,"id":281582424,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTU4MjQyNA==","diff_hunk":"@@ -0,0 +1,39 @@\n+Given(/^I visit the business finder email screen$/) do\n+  content_store_has_business_readiness_email_signup # stub content API for email signup page\n+  visit finder_path('find-eu-exit-guidance-business/email-signup')\n+end\n+\n+When(/^I click the \"(.+)\" button$/) do |button_name|\n+  # Before we click on the Signup button, we need to stub a lot of things that are triggered downstream of this.\n+\n+  # stub content API for POST message to business finder\n+  content_store_has_business_readiness_finder\n+\n+  # stub API request to email-alerts-api, which is called via the POST message above\n+  # TODO I want to stub the fetching of the signup URL (which is determined by topic ID, facet, etc)\n+  # But I don't want to stub the EmailAlertSubscriptionsController itself, because that's where we look for default_frequency 🤔","path":"features/step_definitions/subscribe_steps.rb","position":14,"original_position":14,"commit_id":"f8bd1acc39141a849407fd40dc9ea3f1b1fa3142","original_commit_id":"f8bd1acc39141a849407fd40dc9ea3f1b1fa3142","user":{"login":"ChrisBAshton","id":5111927,"node_id":"MDQ6VXNlcjUxMTE5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5111927?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisBAshton","html_url":"https://github.com/ChrisBAshton","followers_url":"https://api.github.com/users/ChrisBAshton/followers","following_url":"https://api.github.com/users/ChrisBAshton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBAshton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBAshton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBAshton/subscriptions","organizations_url":"https://api.github.com/users/ChrisBAshton/orgs","repos_url":"https://api.github.com/users/ChrisBAshton/repos","events_url":"https://api.github.com/users/ChrisBAshton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBAshton/received_events","type":"User","site_admin":false},"body":"Current output from Cucumber:\r\n\r\n```\r\n  Scenario: Business Finder with default_frequency parameter                                                                                                                           # features/subscribe.feature:12\r\n    Given I visit the business finder email screen                                                                                                                                     # features/step_definitions/subscribe_steps.rb:1\r\ndefault_frequency param detected, so should be redirecting to /email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar&default_frequency=daily\r\nNo params detected, so should be redirecting to /email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar\r\n_Actually_ redirecting to /email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar\r\ndefault_frequency param detected, so should be redirecting to /email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar&default_frequency=daily\r\nNo params detected, so should be redirecting to /email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar\r\n    When I click the \"Create subscription\" button                                                                                                                                      # features/step_definitions/subscribe_steps.rb:6\r\n      Ignoring errors in the page. The thing we're testing is the value of http://www.example.com/email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar\r\n    Then I should be redirected to \"/email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&default_frequency=daily\" # features/step_definitions/subscribe_steps.rb:37\r\n\r\n      expected: \"http://www.example.com/email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&default_frequency=daily\"\r\n           got: \"http://www.example.com/email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&foo=bar\"\r\n\r\n      (compared using ==)\r\n       (RSpec::Expectations::ExpectationNotMetError)\r\n      ./features/step_definitions/subscribe_steps.rb:38:in `/^I should be redirected to \"(.+)\"$/'\r\n      features/subscribe.feature:15:in `Then I should be redirected to \"/email/subscriptions/new?topic_id=find-eu-exit-guidance-for-your-business-appear-in-find-eu-exit-guidance-business-finder&default_frequency=daily\"'\r\n\r\nFailing Scenarios:\r\ncucumber features/subscribe.feature:12 # Scenario: Business Finder with default_frequency parameter\r\n```","created_at":"2019-05-07T11:28:33Z","updated_at":"2019-05-07T11:28:34Z","html_url":"https://github.com/alphagov/finder-frontend/pull/1101#discussion_r281582424","pull_request_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments/281582424"},"html":{"href":"https://github.com/alphagov/finder-frontend/pull/1101#discussion_r281582424"},"pull_request":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101","id":276492427,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2NDkyNDI3","html_url":"https://github.com/alphagov/finder-frontend/pull/1101","diff_url":"https://github.com/alphagov/finder-frontend/pull/1101.diff","patch_url":"https://github.com/alphagov/finder-frontend/pull/1101.patch","issue_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/1101","number":1101,"state":"open","locked":false,"title":"Pass default frequency","user":{"login":"ChrisBAshton","id":5111927,"node_id":"MDQ6VXNlcjUxMTE5Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5111927?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisBAshton","html_url":"https://github.com/ChrisBAshton","followers_url":"https://api.github.com/users/ChrisBAshton/followers","following_url":"https://api.github.com/users/ChrisBAshton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBAshton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBAshton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBAshton/subscriptions","organizations_url":"https://api.github.com/users/ChrisBAshton/orgs","repos_url":"https://api.github.com/users/ChrisBAshton/repos","events_url":"https://api.github.com/users/ChrisBAshton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBAshton/received_events","type":"User","site_admin":false},"body":"WORK IN PROGRESS. Please ignore.\r\n\r\nTrello card: https://trello.com/c/f7DWeg4q\r\n\r\n## Todo\r\n\r\n- this is a work in progress. A technical spike. It may not work.\r\n- Need to figure out how to apply default_frequency ONLY to the business finder.\r\n- Need to figure out if manually appending another hidden field causes any unwanted side-effects.\r\n- Need to figure out where to write the tests for this, and what needs to be mocked.\r\n","created_at":"2019-05-07T08:12:44Z","updated_at":"2019-05-07T11:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edd8463b1ceeab4c198c62d899dbb8aa0e25ffa5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101/commits","review_comments_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101/comments","review_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/1101/comments","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/f8bd1acc39141a849407fd40dc9ea3f1b1fa3142","head":{"label":"alphagov:pass-default-frequency","ref":"pass-default-frequency","sha":"f8bd1acc39141a849407fd40dc9ea3f1b1fa3142","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176176,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3NjE3Ng==","name":"finder-frontend","full_name":"alphagov/finder-frontend","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/finder-frontend","description":"Serves search pages for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/finder-frontend","forks_url":"https://api.github.com/repos/alphagov/finder-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/finder-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finder-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finder-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/finder-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finder-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/finder-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finder-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finder-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finder-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finder-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finder-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/finder-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finder-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finder-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finder-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/finder-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finder-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/finder-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finder-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finder-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/finder-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finder-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/finder-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finder-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finder-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finder-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finder-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/finder-frontend/deployments","created_at":"2014-01-23T15:21:03Z","updated_at":"2019-05-07T11:23:55Z","pushed_at":"2019-05-07T11:27:29Z","git_url":"git://github.com/alphagov/finder-frontend.git","ssh_url":"git@github.com:alphagov/finder-frontend.git","clone_url":"https://github.com/alphagov/finder-frontend.git","svn_url":"https://github.com/alphagov/finder-frontend","homepage":"https://docs.publishing.service.gov.uk/apps/finder-frontend.html","size":4150,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f5907964b4fa6b0d27ef3d926f61bd53796af116","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":16176176,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3NjE3Ng==","name":"finder-frontend","full_name":"alphagov/finder-frontend","private":false,"owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/alphagov/finder-frontend","description":"Serves search pages for GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/finder-frontend","forks_url":"https://api.github.com/repos/alphagov/finder-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/finder-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finder-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finder-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/finder-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finder-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/finder-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finder-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finder-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finder-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finder-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finder-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finder-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finder-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/finder-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finder-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finder-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finder-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/finder-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finder-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finder-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finder-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/finder-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finder-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finder-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/finder-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finder-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/finder-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finder-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finder-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finder-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finder-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finder-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/finder-frontend/deployments","created_at":"2014-01-23T15:21:03Z","updated_at":"2019-05-07T11:23:55Z","pushed_at":"2019-05-07T11:27:29Z","git_url":"git://github.com/alphagov/finder-frontend.git","ssh_url":"git@github.com:alphagov/finder-frontend.git","clone_url":"https://github.com/alphagov/finder-frontend.git","svn_url":"https://github.com/alphagov/finder-frontend","homepage":"https://docs.publishing.service.gov.uk/apps/finder-frontend.html","size":4150,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101"},"html":{"href":"https://github.com/alphagov/finder-frontend/pull/1101"},"issue":{"href":"https://api.github.com/repos/alphagov/finder-frontend/issues/1101"},"comments":{"href":"https://api.github.com/repos/alphagov/finder-frontend/issues/1101/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/finder-frontend/pulls/1101/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/finder-frontend/statuses/f8bd1acc39141a849407fd40dc9ea3f1b1fa3142"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChrisBAshton"}}