{"action":"created","comment":{"url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments/263241915","pull_request_review_id":211604531,"id":263241915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzI0MTkxNQ==","diff_hunk":"@@ -0,0 +1,46 @@\n+package edu.umd.cs.findbugs.detect;\r\n+\r\n+import edu.umd.cs.findbugs.BugInstance;\r\n+import edu.umd.cs.findbugs.PrintingBugReporter;\r\n+import edu.umd.cs.findbugs.Priorities;\r\n+import edu.umd.cs.findbugs.Project;\r\n+import edu.umd.cs.findbugs.ba.AnalysisContext;\r\n+import org.junit.Test;\r\n+\r\n+import static org.junit.Assert.*;\r\n+\r\n+public class FindNonShortCircuitTest {\r\n+\r\n+    @Test\r\n+    public void testBugTypeAndPriority() {\r","path":"spotbugs/src/test/java/edu/umd/cs/findbugs/detect/FindNonShortCircuitTest.java","position":15,"original_position":15,"commit_id":"19b5ce65681ab7b9dbb9d4d0a48e1a5d5c475be9","original_commit_id":"19b5ce65681ab7b9dbb9d4d0a48e1a5d5c475be9","user":{"login":"inponomarev","id":20153286,"node_id":"MDQ6VXNlcjIwMTUzMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/20153286?v=4","gravatar_id":"","url":"https://api.github.com/users/inponomarev","html_url":"https://github.com/inponomarev","followers_url":"https://api.github.com/users/inponomarev/followers","following_url":"https://api.github.com/users/inponomarev/following{/other_user}","gists_url":"https://api.github.com/users/inponomarev/gists{/gist_id}","starred_url":"https://api.github.com/users/inponomarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inponomarev/subscriptions","organizations_url":"https://api.github.com/users/inponomarev/orgs","repos_url":"https://api.github.com/users/inponomarev/repos","events_url":"https://api.github.com/users/inponomarev/events{/privacy}","received_events_url":"https://api.github.com/users/inponomarev/received_events","type":"User","site_admin":false},"body":"Will  `testBugTypeAndPriorityDependOnSawBooleanFlags` name do?\r\n\r\nI know this test is indecently long. \r\n\r\nBut look at the terrible thing I had to do with static `AnalysisContext` just to run the test. So I decided to do it only once instead of four times. Having static state makes things non-testable, I think this is why I don't see any other non-trivial unit tests in `edu.umd.cs.findbugs.detect` package.","created_at":"2019-03-07T05:25:05Z","updated_at":"2019-03-07T05:25:05Z","html_url":"https://github.com/spotbugs/spotbugs/pull/902#discussion_r263241915","pull_request_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments/263241915"},"html":{"href":"https://github.com/spotbugs/spotbugs/pull/902#discussion_r263241915"},"pull_request":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902"}},"in_reply_to_id":262730647},"pull_request":{"url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902","id":258256858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4MjU2ODU4","html_url":"https://github.com/spotbugs/spotbugs/pull/902","diff_url":"https://github.com/spotbugs/spotbugs/pull/902.diff","patch_url":"https://github.com/spotbugs/spotbugs/pull/902.patch","issue_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/902","number":902,"state":"open","locked":false,"title":"fixed FindNonShortCircuit#reportBug","user":{"login":"inponomarev","id":20153286,"node_id":"MDQ6VXNlcjIwMTUzMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/20153286?v=4","gravatar_id":"","url":"https://api.github.com/users/inponomarev","html_url":"https://github.com/inponomarev","followers_url":"https://api.github.com/users/inponomarev/followers","following_url":"https://api.github.com/users/inponomarev/following{/other_user}","gists_url":"https://api.github.com/users/inponomarev/gists{/gist_id}","starred_url":"https://api.github.com/users/inponomarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inponomarev/subscriptions","organizations_url":"https://api.github.com/users/inponomarev/orgs","repos_url":"https://api.github.com/users/inponomarev/repos","events_url":"https://api.github.com/users/inponomarev/events{/privacy}","received_events_url":"https://api.github.com/users/inponomarev/received_events","type":"User","site_admin":false},"body":"This is a reincarnation of #854.\r\n\r\nFixed `FindNonShortCircuit#reportBug` method based on [static analysis finding](https://www.viva64.com/en/b/0603/#ID0E61EK). `sawNullTestVeryOld` variable had no impact on `priority`.\r\n\r\n\r\n----\r\n\r\nMake sure these boxes are checked before submitting your PR -- thank you!\r\n\r\n- [x] Added an entry into `CHANGELOG.md` if you have changed SpotBugs code\r\n","created_at":"2019-03-05T09:58:48Z","updated_at":"2019-03-07T05:25:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e92ad3fae30d58189954a0d13cd271ce87d2bf99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902/commits","review_comments_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902/comments","review_comment_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/902/comments","statuses_url":"https://api.github.com/repos/spotbugs/spotbugs/statuses/19b5ce65681ab7b9dbb9d4d0a48e1a5d5c475be9","head":{"label":"inponomarev:findnonshortcircuit","ref":"findnonshortcircuit","sha":"19b5ce65681ab7b9dbb9d4d0a48e1a5d5c475be9","user":{"login":"inponomarev","id":20153286,"node_id":"MDQ6VXNlcjIwMTUzMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/20153286?v=4","gravatar_id":"","url":"https://api.github.com/users/inponomarev","html_url":"https://github.com/inponomarev","followers_url":"https://api.github.com/users/inponomarev/followers","following_url":"https://api.github.com/users/inponomarev/following{/other_user}","gists_url":"https://api.github.com/users/inponomarev/gists{/gist_id}","starred_url":"https://api.github.com/users/inponomarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inponomarev/subscriptions","organizations_url":"https://api.github.com/users/inponomarev/orgs","repos_url":"https://api.github.com/users/inponomarev/repos","events_url":"https://api.github.com/users/inponomarev/events{/privacy}","received_events_url":"https://api.github.com/users/inponomarev/received_events","type":"User","site_admin":false},"repo":{"id":173916543,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM5MTY1NDM=","name":"spotbugs","full_name":"inponomarev/spotbugs","private":false,"owner":{"login":"inponomarev","id":20153286,"node_id":"MDQ6VXNlcjIwMTUzMjg2","avatar_url":"https://avatars1.githubusercontent.com/u/20153286?v=4","gravatar_id":"","url":"https://api.github.com/users/inponomarev","html_url":"https://github.com/inponomarev","followers_url":"https://api.github.com/users/inponomarev/followers","following_url":"https://api.github.com/users/inponomarev/following{/other_user}","gists_url":"https://api.github.com/users/inponomarev/gists{/gist_id}","starred_url":"https://api.github.com/users/inponomarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inponomarev/subscriptions","organizations_url":"https://api.github.com/users/inponomarev/orgs","repos_url":"https://api.github.com/users/inponomarev/repos","events_url":"https://api.github.com/users/inponomarev/events{/privacy}","received_events_url":"https://api.github.com/users/inponomarev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/inponomarev/spotbugs","description":"SpotBugs is FindBugs' successor. A tool for static analysis to look for bugs in Java code.","fork":true,"url":"https://api.github.com/repos/inponomarev/spotbugs","forks_url":"https://api.github.com/repos/inponomarev/spotbugs/forks","keys_url":"https://api.github.com/repos/inponomarev/spotbugs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inponomarev/spotbugs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inponomarev/spotbugs/teams","hooks_url":"https://api.github.com/repos/inponomarev/spotbugs/hooks","issue_events_url":"https://api.github.com/repos/inponomarev/spotbugs/issues/events{/number}","events_url":"https://api.github.com/repos/inponomarev/spotbugs/events","assignees_url":"https://api.github.com/repos/inponomarev/spotbugs/assignees{/user}","branches_url":"https://api.github.com/repos/inponomarev/spotbugs/branches{/branch}","tags_url":"https://api.github.com/repos/inponomarev/spotbugs/tags","blobs_url":"https://api.github.com/repos/inponomarev/spotbugs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inponomarev/spotbugs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inponomarev/spotbugs/git/refs{/sha}","trees_url":"https://api.github.com/repos/inponomarev/spotbugs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inponomarev/spotbugs/statuses/{sha}","languages_url":"https://api.github.com/repos/inponomarev/spotbugs/languages","stargazers_url":"https://api.github.com/repos/inponomarev/spotbugs/stargazers","contributors_url":"https://api.github.com/repos/inponomarev/spotbugs/contributors","subscribers_url":"https://api.github.com/repos/inponomarev/spotbugs/subscribers","subscription_url":"https://api.github.com/repos/inponomarev/spotbugs/subscription","commits_url":"https://api.github.com/repos/inponomarev/spotbugs/commits{/sha}","git_commits_url":"https://api.github.com/repos/inponomarev/spotbugs/git/commits{/sha}","comments_url":"https://api.github.com/repos/inponomarev/spotbugs/comments{/number}","issue_comment_url":"https://api.github.com/repos/inponomarev/spotbugs/issues/comments{/number}","contents_url":"https://api.github.com/repos/inponomarev/spotbugs/contents/{+path}","compare_url":"https://api.github.com/repos/inponomarev/spotbugs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inponomarev/spotbugs/merges","archive_url":"https://api.github.com/repos/inponomarev/spotbugs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inponomarev/spotbugs/downloads","issues_url":"https://api.github.com/repos/inponomarev/spotbugs/issues{/number}","pulls_url":"https://api.github.com/repos/inponomarev/spotbugs/pulls{/number}","milestones_url":"https://api.github.com/repos/inponomarev/spotbugs/milestones{/number}","notifications_url":"https://api.github.com/repos/inponomarev/spotbugs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inponomarev/spotbugs/labels{/name}","releases_url":"https://api.github.com/repos/inponomarev/spotbugs/releases{/id}","deployments_url":"https://api.github.com/repos/inponomarev/spotbugs/deployments","created_at":"2019-03-05T09:31:08Z","updated_at":"2019-03-05T09:31:18Z","pushed_at":"2019-03-05T17:42:39Z","git_url":"git://github.com/inponomarev/spotbugs.git","ssh_url":"git@github.com:inponomarev/spotbugs.git","clone_url":"https://github.com/inponomarev/spotbugs.git","svn_url":"https://github.com/inponomarev/spotbugs","homepage":"https://spotbugs.github.io/","size":160199,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotbugs:master","ref":"master","sha":"0b884df38d2ba39f8bcab6182854019a4904b1b5","user":{"login":"spotbugs","id":23269302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY5MzAy","avatar_url":"https://avatars3.githubusercontent.com/u/23269302?v=4","gravatar_id":"","url":"https://api.github.com/users/spotbugs","html_url":"https://github.com/spotbugs","followers_url":"https://api.github.com/users/spotbugs/followers","following_url":"https://api.github.com/users/spotbugs/following{/other_user}","gists_url":"https://api.github.com/users/spotbugs/gists{/gist_id}","starred_url":"https://api.github.com/users/spotbugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotbugs/subscriptions","organizations_url":"https://api.github.com/users/spotbugs/orgs","repos_url":"https://api.github.com/users/spotbugs/repos","events_url":"https://api.github.com/users/spotbugs/events{/privacy}","received_events_url":"https://api.github.com/users/spotbugs/received_events","type":"Organization","site_admin":false},"repo":{"id":72889410,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg4OTQxMA==","name":"spotbugs","full_name":"spotbugs/spotbugs","private":false,"owner":{"login":"spotbugs","id":23269302,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY5MzAy","avatar_url":"https://avatars3.githubusercontent.com/u/23269302?v=4","gravatar_id":"","url":"https://api.github.com/users/spotbugs","html_url":"https://github.com/spotbugs","followers_url":"https://api.github.com/users/spotbugs/followers","following_url":"https://api.github.com/users/spotbugs/following{/other_user}","gists_url":"https://api.github.com/users/spotbugs/gists{/gist_id}","starred_url":"https://api.github.com/users/spotbugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotbugs/subscriptions","organizations_url":"https://api.github.com/users/spotbugs/orgs","repos_url":"https://api.github.com/users/spotbugs/repos","events_url":"https://api.github.com/users/spotbugs/events{/privacy}","received_events_url":"https://api.github.com/users/spotbugs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotbugs/spotbugs","description":"SpotBugs is FindBugs' successor. A tool for static analysis to look for bugs in Java code.","fork":false,"url":"https://api.github.com/repos/spotbugs/spotbugs","forks_url":"https://api.github.com/repos/spotbugs/spotbugs/forks","keys_url":"https://api.github.com/repos/spotbugs/spotbugs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotbugs/spotbugs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotbugs/spotbugs/teams","hooks_url":"https://api.github.com/repos/spotbugs/spotbugs/hooks","issue_events_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/events{/number}","events_url":"https://api.github.com/repos/spotbugs/spotbugs/events","assignees_url":"https://api.github.com/repos/spotbugs/spotbugs/assignees{/user}","branches_url":"https://api.github.com/repos/spotbugs/spotbugs/branches{/branch}","tags_url":"https://api.github.com/repos/spotbugs/spotbugs/tags","blobs_url":"https://api.github.com/repos/spotbugs/spotbugs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotbugs/spotbugs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotbugs/spotbugs/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotbugs/spotbugs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotbugs/spotbugs/statuses/{sha}","languages_url":"https://api.github.com/repos/spotbugs/spotbugs/languages","stargazers_url":"https://api.github.com/repos/spotbugs/spotbugs/stargazers","contributors_url":"https://api.github.com/repos/spotbugs/spotbugs/contributors","subscribers_url":"https://api.github.com/repos/spotbugs/spotbugs/subscribers","subscription_url":"https://api.github.com/repos/spotbugs/spotbugs/subscription","commits_url":"https://api.github.com/repos/spotbugs/spotbugs/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotbugs/spotbugs/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotbugs/spotbugs/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotbugs/spotbugs/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotbugs/spotbugs/contents/{+path}","compare_url":"https://api.github.com/repos/spotbugs/spotbugs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotbugs/spotbugs/merges","archive_url":"https://api.github.com/repos/spotbugs/spotbugs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotbugs/spotbugs/downloads","issues_url":"https://api.github.com/repos/spotbugs/spotbugs/issues{/number}","pulls_url":"https://api.github.com/repos/spotbugs/spotbugs/pulls{/number}","milestones_url":"https://api.github.com/repos/spotbugs/spotbugs/milestones{/number}","notifications_url":"https://api.github.com/repos/spotbugs/spotbugs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotbugs/spotbugs/labels{/name}","releases_url":"https://api.github.com/repos/spotbugs/spotbugs/releases{/id}","deployments_url":"https://api.github.com/repos/spotbugs/spotbugs/deployments","created_at":"2016-11-04T22:18:08Z","updated_at":"2019-03-06T20:59:15Z","pushed_at":"2019-03-06T13:31:17Z","git_url":"git://github.com/spotbugs/spotbugs.git","ssh_url":"git@github.com:spotbugs/spotbugs.git","clone_url":"https://github.com/spotbugs/spotbugs.git","svn_url":"https://github.com/spotbugs/spotbugs","homepage":"https://spotbugs.github.io/","size":160205,"stargazers_count":1173,"watchers_count":1173,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":179,"open_issues":180,"watchers":1173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902"},"html":{"href":"https://github.com/spotbugs/spotbugs/pull/902"},"issue":{"href":"https://api.github.com/repos/spotbugs/spotbugs/issues/902"},"comments":{"href":"https://api.github.com/repos/spotbugs/spotbugs/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotbugs/spotbugs/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/spotbugs/spotbugs/statuses/19b5ce65681ab7b9dbb9d4d0a48e1a5d5c475be9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"inponomarev"}}