{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/comments/281225906","pull_request_review_id":234031239,"id":281225906,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTIyNTkwNg==","diff_hunk":"@@ -0,0 +1,7 @@\n+[deps]\n+DustExtinction = \"fb44c06c-c62f-5397-83f5-69249e0a3c8e\"\n+Documenter = \"e30172f5-a6a5-5a46-863b-614d45cd2de4\"\n+\n+[compat]\n+DustExtinction = \">=0.3.1-DEV\"\n+Documenter = \"~0.20\"","path":"docs/Project.toml","position":7,"original_position":7,"commit_id":"7a5a0779bbea3b620b3160ca9e0fc7c3d820cecc","original_commit_id":"7a5a0779bbea3b620b3160ca9e0fc7c3d820cecc","user":{"login":"giordano","id":765740,"node_id":"MDQ6VXNlcjc2NTc0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/765740?v=4","gravatar_id":"","url":"https://api.github.com/users/giordano","html_url":"https://github.com/giordano","followers_url":"https://api.github.com/users/giordano/followers","following_url":"https://api.github.com/users/giordano/following{/other_user}","gists_url":"https://api.github.com/users/giordano/gists{/gist_id}","starred_url":"https://api.github.com/users/giordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giordano/subscriptions","organizations_url":"https://api.github.com/users/giordano/orgs","repos_url":"https://api.github.com/users/giordano/repos","events_url":"https://api.github.com/users/giordano/events{/privacy}","received_events_url":"https://api.github.com/users/giordano/received_events","type":"User","site_admin":false},"body":":slightly_smiling_face: ","created_at":"2019-05-06T15:05:42Z","updated_at":"2019-05-06T15:05:42Z","html_url":"https://github.com/JuliaAstro/DustExtinction.jl/pull/5#discussion_r281225906","pull_request_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/comments/281225906"},"html":{"href":"https://github.com/JuliaAstro/DustExtinction.jl/pull/5#discussion_r281225906"},"pull_request":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5","id":276201268,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MjAxMjY4","html_url":"https://github.com/JuliaAstro/DustExtinction.jl/pull/5","diff_url":"https://github.com/JuliaAstro/DustExtinction.jl/pull/5.diff","patch_url":"https://github.com/JuliaAstro/DustExtinction.jl/pull/5.patch","issue_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues/5","number":5,"state":"open","locked":false,"title":"Some bigger upgrades","user":{"login":"mileslucas","id":14099459,"node_id":"MDQ6VXNlcjE0MDk5NDU5","avatar_url":"https://avatars0.githubusercontent.com/u/14099459?v=4","gravatar_id":"","url":"https://api.github.com/users/mileslucas","html_url":"https://github.com/mileslucas","followers_url":"https://api.github.com/users/mileslucas/followers","following_url":"https://api.github.com/users/mileslucas/following{/other_user}","gists_url":"https://api.github.com/users/mileslucas/gists{/gist_id}","starred_url":"https://api.github.com/users/mileslucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mileslucas/subscriptions","organizations_url":"https://api.github.com/users/mileslucas/orgs","repos_url":"https://api.github.com/users/mileslucas/repos","events_url":"https://api.github.com/users/mileslucas/events{/privacy}","received_events_url":"https://api.github.com/users/mileslucas/received_events","type":"User","site_admin":false},"body":"I've made a few changes and upgrades:\r\n\r\n## 1. Refactoring\r\nIn general, I've refactored the extinction laws into their own files, as well as their corresponding tests. This is merely a style thing to reduce clutter in the main `DustExtinction.jl` and provide a better framework for adding additional laws. I've taken inspiration for this from the layout of `JuliaStats/HypothesisTests`\r\n\r\n## 2. Broadcasting\r\nPreviously, all the functions were only applicable to scalars and arrays up to dim 2 with reshaping required with higher-level arrays. This involved that for-loop in `DustExtinction.jl` with `@eval` macros for basically aliasing the functions. Rather than using this, why not just use the `.` operator? E.g.:\r\n```julia\r\njulia> wave = 1e4:3e4\r\njulia> mags = ccm89.(wave, r_v=3.1)\r\n20001-element Array{Float64,1}:\r\n 0.4039999999999999 \r\n 0.4039349644872206 \r\n 0.40386994594479847\r\n[...]\r\n```\r\nThis retains the same effects as the previous implementation, requires less code on our part, and stays idiomatic with the rest of the Julia mathematical syntax. This pull removes the previous definitions and changes all documentation to reference the `.` syntax.\r\n\r\n## 3. Tests\r\nI've added tests not only for the broadcasting but as well as the wavelength domain checking.\r\n\r\n## 4. Documentation\r\nI've added some documentation using `Documenter.jl`. It mostly mimics the README, but since this uses the docstrings it will be much more up to date than having to change the README everytime a function changes.\r\n\r\n## 5. Calzetti 2000\r\n\r\nI've added the Calzetti et al. (2000) extinction law!","created_at":"2019-05-06T14:08:01Z","updated_at":"2019-05-06T15:05:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44ad2db0abf937270f79cc6e6f6ddaa63f07dfd7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5/commits","review_comments_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5/comments","review_comment_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues/5/comments","statuses_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/statuses/7a5a0779bbea3b620b3160ca9e0fc7c3d820cecc","head":{"label":"mileslucas:dot","ref":"dot","sha":"7a5a0779bbea3b620b3160ca9e0fc7c3d820cecc","user":{"login":"mileslucas","id":14099459,"node_id":"MDQ6VXNlcjE0MDk5NDU5","avatar_url":"https://avatars0.githubusercontent.com/u/14099459?v=4","gravatar_id":"","url":"https://api.github.com/users/mileslucas","html_url":"https://github.com/mileslucas","followers_url":"https://api.github.com/users/mileslucas/followers","following_url":"https://api.github.com/users/mileslucas/following{/other_user}","gists_url":"https://api.github.com/users/mileslucas/gists{/gist_id}","starred_url":"https://api.github.com/users/mileslucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mileslucas/subscriptions","organizations_url":"https://api.github.com/users/mileslucas/orgs","repos_url":"https://api.github.com/users/mileslucas/repos","events_url":"https://api.github.com/users/mileslucas/events{/privacy}","received_events_url":"https://api.github.com/users/mileslucas/received_events","type":"User","site_admin":false},"repo":{"id":185176852,"node_id":"MDEwOlJlcG9zaXRvcnkxODUxNzY4NTI=","name":"DustExtinction.jl","full_name":"mileslucas/DustExtinction.jl","private":false,"owner":{"login":"mileslucas","id":14099459,"node_id":"MDQ6VXNlcjE0MDk5NDU5","avatar_url":"https://avatars0.githubusercontent.com/u/14099459?v=4","gravatar_id":"","url":"https://api.github.com/users/mileslucas","html_url":"https://github.com/mileslucas","followers_url":"https://api.github.com/users/mileslucas/followers","following_url":"https://api.github.com/users/mileslucas/following{/other_user}","gists_url":"https://api.github.com/users/mileslucas/gists{/gist_id}","starred_url":"https://api.github.com/users/mileslucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mileslucas/subscriptions","organizations_url":"https://api.github.com/users/mileslucas/orgs","repos_url":"https://api.github.com/users/mileslucas/repos","events_url":"https://api.github.com/users/mileslucas/events{/privacy}","received_events_url":"https://api.github.com/users/mileslucas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mileslucas/DustExtinction.jl","description":"Models for the interstellar extinction due to dust","fork":true,"url":"https://api.github.com/repos/mileslucas/DustExtinction.jl","forks_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/forks","keys_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/teams","hooks_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/hooks","issue_events_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/issues/events{/number}","events_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/events","assignees_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/assignees{/user}","branches_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/branches{/branch}","tags_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/tags","blobs_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/languages","stargazers_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/stargazers","contributors_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/contributors","subscribers_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/subscribers","subscription_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/subscription","commits_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/contents/{+path}","compare_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/merges","archive_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/downloads","issues_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/issues{/number}","pulls_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/labels{/name}","releases_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/releases{/id}","deployments_url":"https://api.github.com/repos/mileslucas/DustExtinction.jl/deployments","created_at":"2019-05-06T10:42:42Z","updated_at":"2019-05-06T12:00:02Z","pushed_at":"2019-05-06T15:04:21Z","git_url":"git://github.com/mileslucas/DustExtinction.jl.git","ssh_url":"git@github.com:mileslucas/DustExtinction.jl.git","clone_url":"https://github.com/mileslucas/DustExtinction.jl.git","svn_url":"https://github.com/mileslucas/DustExtinction.jl","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaAstro:master","ref":"master","sha":"7196600d4ed8ea903e3696fe04e862f60009679c","user":{"login":"JuliaAstro","id":6685132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2ODUxMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6685132?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaAstro","html_url":"https://github.com/JuliaAstro","followers_url":"https://api.github.com/users/JuliaAstro/followers","following_url":"https://api.github.com/users/JuliaAstro/following{/other_user}","gists_url":"https://api.github.com/users/JuliaAstro/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaAstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaAstro/subscriptions","organizations_url":"https://api.github.com/users/JuliaAstro/orgs","repos_url":"https://api.github.com/users/JuliaAstro/repos","events_url":"https://api.github.com/users/JuliaAstro/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaAstro/received_events","type":"Organization","site_admin":false},"repo":{"id":16758182,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc1ODE4Mg==","name":"DustExtinction.jl","full_name":"JuliaAstro/DustExtinction.jl","private":false,"owner":{"login":"JuliaAstro","id":6685132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2ODUxMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/6685132?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaAstro","html_url":"https://github.com/JuliaAstro","followers_url":"https://api.github.com/users/JuliaAstro/followers","following_url":"https://api.github.com/users/JuliaAstro/following{/other_user}","gists_url":"https://api.github.com/users/JuliaAstro/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaAstro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaAstro/subscriptions","organizations_url":"https://api.github.com/users/JuliaAstro/orgs","repos_url":"https://api.github.com/users/JuliaAstro/repos","events_url":"https://api.github.com/users/JuliaAstro/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaAstro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaAstro/DustExtinction.jl","description":"Models for the interstellar extinction due to dust","fork":false,"url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl","forks_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/forks","keys_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/teams","hooks_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/events","assignees_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/tags","blobs_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/subscription","commits_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/merges","archive_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/downloads","issues_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/deployments","created_at":"2014-02-12T06:27:23Z","updated_at":"2019-05-06T13:04:56Z","pushed_at":"2019-05-06T15:04:23Z","git_url":"git://github.com/JuliaAstro/DustExtinction.jl.git","ssh_url":"git@github.com:JuliaAstro/DustExtinction.jl.git","clone_url":"https://github.com/JuliaAstro/DustExtinction.jl.git","svn_url":"https://github.com/JuliaAstro/DustExtinction.jl","homepage":null,"size":24,"stargazers_count":1,"watchers_count":1,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5"},"html":{"href":"https://github.com/JuliaAstro/DustExtinction.jl/pull/5"},"issue":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues/5"},"comments":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaAstro/DustExtinction.jl/statuses/7a5a0779bbea3b620b3160ca9e0fc7c3d820cecc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giordano"}}