{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/42489","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/42489/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/42489/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/42489/events","html_url":"https://github.com/dotnet/corefx/pull/42489","id":520197579,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4ODI4MTU0","number":42489,"title":"[release/2.1] Remove throw in exception handling of dispose","user":{"login":"yukiwongky","id":17915152,"node_id":"MDQ6VXNlcjE3OTE1MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/17915152?v=4","gravatar_id":"","url":"https://api.github.com/users/yukiwongky","html_url":"https://github.com/yukiwongky","followers_url":"https://api.github.com/users/yukiwongky/followers","following_url":"https://api.github.com/users/yukiwongky/following{/other_user}","gists_url":"https://api.github.com/users/yukiwongky/gists{/gist_id}","starred_url":"https://api.github.com/users/yukiwongky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yukiwongky/subscriptions","organizations_url":"https://api.github.com/users/yukiwongky/orgs","repos_url":"https://api.github.com/users/yukiwongky/repos","events_url":"https://api.github.com/users/yukiwongky/events{/privacy}","received_events_url":"https://api.github.com/users/yukiwongky/received_events","type":"User","site_admin":false},"labels":[{"id":284076100,"node_id":"MDU6TGFiZWwyODQwNzYxMDA=","url":"https://api.github.com/repos/dotnet/corefx/labels/*%20NO%20MERGE%20*","name":"* NO MERGE *","color":"e11d21","default":false,"description":"The PR is not ready for merge yet (see discussion for detailed reasons)"},{"id":1040742241,"node_id":"MDU6TGFiZWwxMDQwNzQyMjQx","url":"https://api.github.com/repos/dotnet/corefx/labels/Servicing-approved","name":"Servicing-approved","color":"048708","default":false,"description":"Approved for servicing release"},{"id":335854516,"node_id":"MDU6TGFiZWwzMzU4NTQ1MTY=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Data.SqlClient","name":"area-System.Data.SqlClient","color":"d4c5f9","default":false,"description":null}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/53","html_url":"https://github.com/dotnet/corefx/milestone/53","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/53/labels","id":4882144,"node_id":"MDk6TWlsZXN0b25lNDg4MjE0NA==","number":53,"title":"2.1.16","description":null,"creator":{"login":"leecow","id":2212879,"node_id":"MDQ6VXNlcjIyMTI4Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2212879?v=4","gravatar_id":"","url":"https://api.github.com/users/leecow","html_url":"https://github.com/leecow","followers_url":"https://api.github.com/users/leecow/followers","following_url":"https://api.github.com/users/leecow/following{/other_user}","gists_url":"https://api.github.com/users/leecow/gists{/gist_id}","starred_url":"https://api.github.com/users/leecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leecow/subscriptions","organizations_url":"https://api.github.com/users/leecow/orgs","repos_url":"https://api.github.com/users/leecow/repos","events_url":"https://api.github.com/users/leecow/events{/privacy}","received_events_url":"https://api.github.com/users/leecow/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2019-11-26T18:37:34Z","updated_at":"2019-11-26T18:37:34Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2019-11-08T19:37:53Z","updated_at":"2019-11-26T18:50:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/42489","html_url":"https://github.com/dotnet/corefx/pull/42489","diff_url":"https://github.com/dotnet/corefx/pull/42489.diff","patch_url":"https://github.com/dotnet/corefx/pull/42489.patch"},"body":"Back port a fix from Microsoft.Data.Sqlclient issue [#20](https://github.com/dotnet/SqlClient/issues/20). Recent issues: https://github.com/dotnet/corefx/issues/42586\r\n\r\nThe same PR #42457 is already merged on master branch.\r\n\r\n**2.1 Servicing:**\r\n\r\n### Summary\r\nUser gets `System.IO.IOException: Unable to write data to the transport connection: Broken pipe.` \r\nwith or without MARS enabled\r\n\r\n### Customer Impact\r\n\r\nUsers using older verions of EFCore (< 3.0) cannot use Microsoft.Data.SqlClient. They need this change in order to not get the `Unable to write data to the transport connection: Broken pipe` error intermittently.\r\n\r\nThis has recently been escalated by the field, working with  an ISV customer. Have not yet verified the version they are deployed on.\r\n\r\nAlso there's several recent customer reports - about 8 distinct reports in the linked issue eg\r\nhttps://github.com/dotnet/SqlClient/issues/20#issuecomment-547892706\r\nhttps://github.com/dotnet/SqlClient/issues/20#issuecomment-512055330\r\nMost of these customers seem to be on 2.2, not 2.1.\r\n\r\n### Regression?\r\n\r\nNo, this exist in 2.0 as well.\r\n\r\n### Risk\r\n\r\nLow: The code change is already in Microsoft.Data.SqlClient, and users have reported the fix works for them."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/558767894","html_url":"https://github.com/dotnet/corefx/pull/42489#issuecomment-558767894","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/42489","id":558767894,"node_id":"MDEyOklzc3VlQ29tbWVudDU1ODc2Nzg5NA==","user":{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"created_at":"2019-11-26T18:50:06Z","updated_at":"2019-11-26T18:50:06Z","author_association":"MEMBER","body":"@Anipik is it OK to merge this? for 2.1.16\r\n\r\n@cheenamalhotra this is also approved for 3.1. (Not 2.2 or 3.0). Please go ahead and create a PR for 3.1 if there isn't one, and check with @Anipik when it's OK to merge. Consider it approved."}}
{"actor":{"display_login":"danmosemsft"}}