{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/338418058","pull_request_review_id":306365866,"id":338418058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODQxODA1OA==","diff_hunk":"@@ -211,9 +211,8 @@ var _ = g.Describe(\"[Feature:Prometheus][Conformance] Prometheus\", func() {\n \t\t\tdefer func() { oc.AdminKubeClient().CoreV1().Pods(ns).Delete(execPod.Name, metav1.NewDeleteOptions(1)) }()\n \n \t\t\ttests := map[string][]metricTest{\n-\t\t\t\t// should be checking there is no more than 1 alerts firing.\n-\t\t\t\t// Checking for specific alert is done in \"should have a Watchdog alert in firing state\".\n-\t\t\t\t`ALERTS{alertstate=\"firing\"}`: {metricTest{greaterThanEqual: false, value: 2}},\n+\t\t\t\t// Checking Watchdog alert state is done in \"should have a Watchdog alert in firing state\".\n+\t\t\t\t`ALERTS{alertname!=\"Watchdog\",alertstate=\"firing\"}`: {metricTest{greaterThanEqual: true, value: 1}},","path":"test/extended/prometheus/prometheus.go","position":17,"original_position":17,"commit_id":"76b49b41ee97b6b9dded0c7438ce7bc6c6268096","original_commit_id":"76b49b41ee97b6b9dded0c7438ce7bc6c6268096","user":{"login":"tnozicka","id":11869554,"node_id":"MDQ6VXNlcjExODY5NTU0","avatar_url":"https://avatars2.githubusercontent.com/u/11869554?v=4","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false},"body":"like the alerts outputted for me are:\r\n```\r\nALERTS{alertname=\"UsingDeprecatedAPIExtensionsV1Beta1\",alertstate=\"firing\",client=\"cluster-policy-controller/v0.0.0 (linux/amd64) kubernetes/$Format\",code=\"0\",component=\"apiserver\",contentType=\"application/vnd.kubernetes.protobuf;stream=watch\",endpoint=\"https\",group=\"extensions\",instance=\"10.0.138.54:6443\",job=\"apiserver\",namespace=\"default\",resource=\"daemonsets\",scope=\"cluster\",service=\"kubernetes\",severity=\"warning\",verb=\"WATCH\",version=\"v1beta1\"}\r\n| 1 @1571823124.618   1 @1571823154.618   1 @1571823184.618   1 @1571823214.618  ....|\r\n```\r\n\r\n\r\n","created_at":"2019-10-24T07:26:13Z","updated_at":"2019-10-24T07:26:13Z","html_url":"https://github.com/openshift/origin/pull/24005#discussion_r338418058","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/24005","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/338418058"},"html":{"href":"https://github.com/openshift/origin/pull/24005#discussion_r338418058"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/24005"}},"in_reply_to_id":338417257},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/24005","id":331509434,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxNTA5NDM0","html_url":"https://github.com/openshift/origin/pull/24005","diff_url":"https://github.com/openshift/origin/pull/24005.diff","patch_url":"https://github.com/openshift/origin/pull/24005.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/24005","number":24005,"state":"open","locked":false,"title":"test/extended/prometheus: better check for firing alerts","user":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"body":"Revert #23995 and improve reporting of which alerts are firing.","created_at":"2019-10-23T12:16:33Z","updated_at":"2019-10-24T07:26:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09a940fcc08a3a63015dca0d4d130eb02c995539","assignee":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":223051294,"node_id":"MDU6TGFiZWwyMjMwNTEyOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":683198191,"node_id":"MDU6TGFiZWw2ODMxOTgxOTE=","url":"https://api.github.com/repos/openshift/origin/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":223479084,"node_id":"MDU6TGFiZWwyMjM0NzkwODQ=","url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":640547849,"node_id":"MDU6TGFiZWw2NDA1NDc4NDk=","url":"https://api.github.com/repos/openshift/origin/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/24005/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/24005/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/24005/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/76b49b41ee97b6b9dded0c7438ce7bc6c6268096","head":{"label":"paulfantom:revert_23995","ref":"revert_23995","sha":"76b49b41ee97b6b9dded0c7438ce7bc6c6268096","user":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"repo":{"id":179044424,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNDQ0MjQ=","name":"origin","full_name":"paulfantom/origin","private":false,"owner":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paulfantom/origin","description":"Enterprise Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/paulfantom/origin","forks_url":"https://api.github.com/repos/paulfantom/origin/forks","keys_url":"https://api.github.com/repos/paulfantom/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulfantom/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulfantom/origin/teams","hooks_url":"https://api.github.com/repos/paulfantom/origin/hooks","issue_events_url":"https://api.github.com/repos/paulfantom/origin/issues/events{/number}","events_url":"https://api.github.com/repos/paulfantom/origin/events","assignees_url":"https://api.github.com/repos/paulfantom/origin/assignees{/user}","branches_url":"https://api.github.com/repos/paulfantom/origin/branches{/branch}","tags_url":"https://api.github.com/repos/paulfantom/origin/tags","blobs_url":"https://api.github.com/repos/paulfantom/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulfantom/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulfantom/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulfantom/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulfantom/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/paulfantom/origin/languages","stargazers_url":"https://api.github.com/repos/paulfantom/origin/stargazers","contributors_url":"https://api.github.com/repos/paulfantom/origin/contributors","subscribers_url":"https://api.github.com/repos/paulfantom/origin/subscribers","subscription_url":"https://api.github.com/repos/paulfantom/origin/subscription","commits_url":"https://api.github.com/repos/paulfantom/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulfantom/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulfantom/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulfantom/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulfantom/origin/contents/{+path}","compare_url":"https://api.github.com/repos/paulfantom/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulfantom/origin/merges","archive_url":"https://api.github.com/repos/paulfantom/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulfantom/origin/downloads","issues_url":"https://api.github.com/repos/paulfantom/origin/issues{/number}","pulls_url":"https://api.github.com/repos/paulfantom/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/paulfantom/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/paulfantom/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulfantom/origin/labels{/name}","releases_url":"https://api.github.com/repos/paulfantom/origin/releases{/id}","deployments_url":"https://api.github.com/repos/paulfantom/origin/deployments","created_at":"2019-04-02T09:30:47Z","updated_at":"2019-10-23T11:20:21Z","pushed_at":"2019-10-23T13:20:20Z","git_url":"git://github.com/paulfantom/origin.git","ssh_url":"git@github.com:paulfantom/origin.git","clone_url":"https://github.com/paulfantom/origin.git","svn_url":"https://github.com/paulfantom/origin","homepage":"http://www.openshift.org","size":1055651,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3012553f98fc3c56b80711773246e48f6fd35257","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjY2OA==","name":"origin","full_name":"openshift/origin","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/origin","description":"The self-managing, auto-upgrading, Kubernetes distribution for everyone","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2019-10-24T04:18:22Z","pushed_at":"2019-10-24T07:03:54Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":1060060,"stargazers_count":6869,"watchers_count":6869,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3956,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":458,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3956,"open_issues":458,"watchers":6869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/24005"},"html":{"href":"https://github.com/openshift/origin/pull/24005"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/24005"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/24005/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/24005/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/24005/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/76b49b41ee97b6b9dded0c7438ce7bc6c6268096"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tnozicka"}}