{"action":"created","comment":{"url":"https://api.github.com/repos/scalableminds/networkit/pulls/comments/351251044","pull_request_review_id":323625643,"id":351251044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTI1MTA0NA==","diff_hunk":"@@ -21,6 +22,51 @@ ConnectedComponents::ConnectedComponents(const Graph& G) : G(G) {\n     }\n }\n \n+cc_result ConnectedComponents::get_raw_partition(const Graph & G) {\n+    node n_components = 0;\n+    node max_id = G.upperNodeIdBound();\n+    auto mapping_array = new node[max_id];","path":"networkit/cpp/components/ConnectedComponents.cpp","position":15,"original_position":15,"commit_id":"0b8cb999ced590f105e9e2775dc2450510bef783","original_commit_id":"0b8cb999ced590f105e9e2775dc2450510bef783","user":{"login":"valentin-pinkau","id":2582395,"node_id":"MDQ6VXNlcjI1ODIzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2582395?v=4","gravatar_id":"","url":"https://api.github.com/users/valentin-pinkau","html_url":"https://github.com/valentin-pinkau","followers_url":"https://api.github.com/users/valentin-pinkau/followers","following_url":"https://api.github.com/users/valentin-pinkau/following{/other_user}","gists_url":"https://api.github.com/users/valentin-pinkau/gists{/gist_id}","starred_url":"https://api.github.com/users/valentin-pinkau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentin-pinkau/subscriptions","organizations_url":"https://api.github.com/users/valentin-pinkau/orgs","repos_url":"https://api.github.com/users/valentin-pinkau/repos","events_url":"https://api.github.com/users/valentin-pinkau/events{/privacy}","received_events_url":"https://api.github.com/users/valentin-pinkau/received_events","type":"User","site_admin":false},"body":"`ConnectedComponents::run()` creates a `std::vector` which holds the data we are interested in. The problem is that there is no way to steal the data from the container and move the ownership to python.\r\nThis is why I choose to basically copy the method and create a static method which creates a raw pointer, which then can be passed to python through the `ArrayWrapper` class.","created_at":"2019-11-27T12:07:39Z","updated_at":"2019-11-27T12:07:40Z","html_url":"https://github.com/scalableminds/networkit/pull/2#discussion_r351251044","pull_request_url":"https://api.github.com/repos/scalableminds/networkit/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scalableminds/networkit/pulls/comments/351251044"},"html":{"href":"https://github.com/scalableminds/networkit/pull/2#discussion_r351251044"},"pull_request":{"href":"https://api.github.com/repos/scalableminds/networkit/pulls/2"}},"in_reply_to_id":351236126},"pull_request":{"url":"https://api.github.com/repos/scalableminds/networkit/pulls/2","id":345910989,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1OTEwOTg5","html_url":"https://github.com/scalableminds/networkit/pull/2","diff_url":"https://github.com/scalableminds/networkit/pull/2.diff","patch_url":"https://github.com/scalableminds/networkit/pull/2.patch","issue_url":"https://api.github.com/repos/scalableminds/networkit/issues/2","number":2,"state":"open","locked":false,"title":"Get mapping array","user":{"login":"valentin-pinkau","id":2582395,"node_id":"MDQ6VXNlcjI1ODIzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2582395?v=4","gravatar_id":"","url":"https://api.github.com/users/valentin-pinkau","html_url":"https://github.com/valentin-pinkau","followers_url":"https://api.github.com/users/valentin-pinkau/followers","following_url":"https://api.github.com/users/valentin-pinkau/following{/other_user}","gists_url":"https://api.github.com/users/valentin-pinkau/gists{/gist_id}","starred_url":"https://api.github.com/users/valentin-pinkau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentin-pinkau/subscriptions","organizations_url":"https://api.github.com/users/valentin-pinkau/orgs","repos_url":"https://api.github.com/users/valentin-pinkau/repos","events_url":"https://api.github.com/users/valentin-pinkau/events{/privacy}","received_events_url":"https://api.github.com/users/valentin-pinkau/received_events","type":"User","site_admin":false},"body":"This PR adds a static method `get_raw_partition` to the `ConnectedComponents` class.\r\nThis method returns a raw pointer instead of an `std` container. This enables Cython to pass the ownership to python in order to avoid a copy.\r\n","created_at":"2019-11-26T19:59:09Z","updated_at":"2019-11-27T12:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ee4973500481ee02456d88b586ca13c86379726","assignee":{"login":"valentin-pinkau","id":2582395,"node_id":"MDQ6VXNlcjI1ODIzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2582395?v=4","gravatar_id":"","url":"https://api.github.com/users/valentin-pinkau","html_url":"https://github.com/valentin-pinkau","followers_url":"https://api.github.com/users/valentin-pinkau/followers","following_url":"https://api.github.com/users/valentin-pinkau/following{/other_user}","gists_url":"https://api.github.com/users/valentin-pinkau/gists{/gist_id}","starred_url":"https://api.github.com/users/valentin-pinkau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentin-pinkau/subscriptions","organizations_url":"https://api.github.com/users/valentin-pinkau/orgs","repos_url":"https://api.github.com/users/valentin-pinkau/repos","events_url":"https://api.github.com/users/valentin-pinkau/events{/privacy}","received_events_url":"https://api.github.com/users/valentin-pinkau/received_events","type":"User","site_admin":false},"assignees":[{"login":"valentin-pinkau","id":2582395,"node_id":"MDQ6VXNlcjI1ODIzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2582395?v=4","gravatar_id":"","url":"https://api.github.com/users/valentin-pinkau","html_url":"https://github.com/valentin-pinkau","followers_url":"https://api.github.com/users/valentin-pinkau/followers","following_url":"https://api.github.com/users/valentin-pinkau/following{/other_user}","gists_url":"https://api.github.com/users/valentin-pinkau/gists{/gist_id}","starred_url":"https://api.github.com/users/valentin-pinkau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valentin-pinkau/subscriptions","organizations_url":"https://api.github.com/users/valentin-pinkau/orgs","repos_url":"https://api.github.com/users/valentin-pinkau/repos","events_url":"https://api.github.com/users/valentin-pinkau/events{/privacy}","received_events_url":"https://api.github.com/users/valentin-pinkau/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"normanrz","id":335438,"node_id":"MDQ6VXNlcjMzNTQzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/335438?v=4","gravatar_id":"","url":"https://api.github.com/users/normanrz","html_url":"https://github.com/normanrz","followers_url":"https://api.github.com/users/normanrz/followers","following_url":"https://api.github.com/users/normanrz/following{/other_user}","gists_url":"https://api.github.com/users/normanrz/gists{/gist_id}","starred_url":"https://api.github.com/users/normanrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanrz/subscriptions","organizations_url":"https://api.github.com/users/normanrz/orgs","repos_url":"https://api.github.com/users/normanrz/repos","events_url":"https://api.github.com/users/normanrz/events{/privacy}","received_events_url":"https://api.github.com/users/normanrz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalableminds/networkit/pulls/2/commits","review_comments_url":"https://api.github.com/repos/scalableminds/networkit/pulls/2/comments","review_comment_url":"https://api.github.com/repos/scalableminds/networkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalableminds/networkit/issues/2/comments","statuses_url":"https://api.github.com/repos/scalableminds/networkit/statuses/0b8cb999ced590f105e9e2775dc2450510bef783","head":{"label":"scalableminds:get_mapping_array","ref":"get_mapping_array","sha":"0b8cb999ced590f105e9e2775dc2450510bef783","user":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":219795351,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk3OTUzNTE=","name":"networkit","full_name":"scalableminds/networkit","private":false,"owner":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scalableminds/networkit","description":"NetworKit is a growing open-source toolkit for large-scale network analysis.","fork":true,"url":"https://api.github.com/repos/scalableminds/networkit","forks_url":"https://api.github.com/repos/scalableminds/networkit/forks","keys_url":"https://api.github.com/repos/scalableminds/networkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/networkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/networkit/teams","hooks_url":"https://api.github.com/repos/scalableminds/networkit/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/networkit/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/networkit/events","assignees_url":"https://api.github.com/repos/scalableminds/networkit/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/networkit/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/networkit/tags","blobs_url":"https://api.github.com/repos/scalableminds/networkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/networkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/networkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/networkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/networkit/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/networkit/languages","stargazers_url":"https://api.github.com/repos/scalableminds/networkit/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/networkit/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/networkit/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/networkit/subscription","commits_url":"https://api.github.com/repos/scalableminds/networkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/networkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/networkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/networkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/networkit/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/networkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/networkit/merges","archive_url":"https://api.github.com/repos/scalableminds/networkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/networkit/downloads","issues_url":"https://api.github.com/repos/scalableminds/networkit/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/networkit/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/networkit/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/networkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/networkit/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/networkit/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/networkit/deployments","created_at":"2019-11-05T16:45:54Z","updated_at":"2019-11-26T14:44:23Z","pushed_at":"2019-11-27T09:54:28Z","git_url":"git://github.com/scalableminds/networkit.git","ssh_url":"git@github.com:scalableminds/networkit.git","clone_url":"https://github.com/scalableminds/networkit.git","svn_url":"https://github.com/scalableminds/networkit","homepage":"https://networkit.github.io","size":262793,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"Dev"}},"base":{"label":"scalableminds:Dev","ref":"Dev","sha":"d265ad9cf64cd25d4acedf603aeeafbb14bc3c3d","user":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":219795351,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk3OTUzNTE=","name":"networkit","full_name":"scalableminds/networkit","private":false,"owner":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scalableminds/networkit","description":"NetworKit is a growing open-source toolkit for large-scale network analysis.","fork":true,"url":"https://api.github.com/repos/scalableminds/networkit","forks_url":"https://api.github.com/repos/scalableminds/networkit/forks","keys_url":"https://api.github.com/repos/scalableminds/networkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/networkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/networkit/teams","hooks_url":"https://api.github.com/repos/scalableminds/networkit/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/networkit/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/networkit/events","assignees_url":"https://api.github.com/repos/scalableminds/networkit/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/networkit/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/networkit/tags","blobs_url":"https://api.github.com/repos/scalableminds/networkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/networkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/networkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/networkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/networkit/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/networkit/languages","stargazers_url":"https://api.github.com/repos/scalableminds/networkit/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/networkit/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/networkit/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/networkit/subscription","commits_url":"https://api.github.com/repos/scalableminds/networkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/networkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/networkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/networkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/networkit/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/networkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/networkit/merges","archive_url":"https://api.github.com/repos/scalableminds/networkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/networkit/downloads","issues_url":"https://api.github.com/repos/scalableminds/networkit/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/networkit/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/networkit/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/networkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/networkit/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/networkit/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/networkit/deployments","created_at":"2019-11-05T16:45:54Z","updated_at":"2019-11-26T14:44:23Z","pushed_at":"2019-11-27T09:54:28Z","git_url":"git://github.com/scalableminds/networkit.git","ssh_url":"git@github.com:scalableminds/networkit.git","clone_url":"https://github.com/scalableminds/networkit.git","svn_url":"https://github.com/scalableminds/networkit","homepage":"https://networkit.github.io","size":262793,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"Dev"}},"_links":{"self":{"href":"https://api.github.com/repos/scalableminds/networkit/pulls/2"},"html":{"href":"https://github.com/scalableminds/networkit/pull/2"},"issue":{"href":"https://api.github.com/repos/scalableminds/networkit/issues/2"},"comments":{"href":"https://api.github.com/repos/scalableminds/networkit/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/scalableminds/networkit/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/scalableminds/networkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalableminds/networkit/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/scalableminds/networkit/statuses/0b8cb999ced590f105e9e2775dc2450510bef783"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"valentin-pinkau"}}