{"action":"created","comment":{"url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/comments/341528322","pull_request_review_id":310390395,"id":341528322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTUyODMyMg==","diff_hunk":"@@ -49,8 +65,25 @@ func (r *BaseIngressReconciler) ReconcileIngress(ctx context.Context, ci network\n \treturn nil\n }\n \n-func (r *BaseIngressReconciler) deleteRoutes(ctx context.Context, ci networkingv1alpha1.IngressAccessor) error {\n+func routeMap(routes routev1.RouteList) map[string]*routev1.Route {\n+\tmp := map[string]*routev1.Route{}","path":"pkg/controller/common/reconciler.go","position":40,"original_position":40,"commit_id":"9668221f5334384f2ecc666587625df806365e9d","original_commit_id":"9668221f5334384f2ecc666587625df806365e9d","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"body":"nit: (Just to get into the habit of doing this)\r\n\r\n```suggestion\r\n\tmp := make(map[string]*routev1.Route, len(routes.Items))\r\n```\r\n\r\nAllocates the map to the needed size immediately.","created_at":"2019-11-01T10:55:06Z","updated_at":"2019-11-01T10:58:18Z","html_url":"https://github.com/openshift-knative/knative-openshift-ingress/pull/24#discussion_r341528322","pull_request_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/comments/341528322"},"html":{"href":"https://github.com/openshift-knative/knative-openshift-ingress/pull/24#discussion_r341528322"},"pull_request":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24","id":335364853,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1MzY0ODUz","html_url":"https://github.com/openshift-knative/knative-openshift-ingress/pull/24","diff_url":"https://github.com/openshift-knative/knative-openshift-ingress/pull/24.diff","patch_url":"https://github.com/openshift-knative/knative-openshift-ingress/pull/24.patch","issue_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues/24","number":24,"state":"open","locked":false,"title":"Change Route name to unique","user":{"login":"nak3","id":2138339,"node_id":"MDQ6VXNlcjIxMzgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2138339?v=4","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"body":"This patch changes reconciler of Route to:\r\n\r\n- [x] use route name to unique by route's domain\r\n- [x] clean up obsoleted route if found","created_at":"2019-11-01T10:38:02Z","updated_at":"2019-11-01T10:58:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a69ce010eb4f8d6d44eab489725c1e49413740e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1588686942,"node_id":"MDU6TGFiZWwxNTg4Njg2OTQy","url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24/commits","review_comments_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24/comments","review_comment_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues/24/comments","statuses_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/statuses/9668221f5334384f2ecc666587625df806365e9d","head":{"label":"nak3:SRVKS-313","ref":"SRVKS-313","sha":"9668221f5334384f2ecc666587625df806365e9d","user":{"login":"nak3","id":2138339,"node_id":"MDQ6VXNlcjIxMzgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2138339?v=4","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"repo":{"id":190159693,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAxNTk2OTM=","name":"knative-openshift-ingress","full_name":"nak3/knative-openshift-ingress","private":false,"owner":{"login":"nak3","id":2138339,"node_id":"MDQ6VXNlcjIxMzgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2138339?v=4","gravatar_id":"","url":"https://api.github.com/users/nak3","html_url":"https://github.com/nak3","followers_url":"https://api.github.com/users/nak3/followers","following_url":"https://api.github.com/users/nak3/following{/other_user}","gists_url":"https://api.github.com/users/nak3/gists{/gist_id}","starred_url":"https://api.github.com/users/nak3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nak3/subscriptions","organizations_url":"https://api.github.com/users/nak3/orgs","repos_url":"https://api.github.com/users/nak3/repos","events_url":"https://api.github.com/users/nak3/events{/privacy}","received_events_url":"https://api.github.com/users/nak3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nak3/knative-openshift-ingress","description":"Front Knative Routes with OpenShift Routes","fork":true,"url":"https://api.github.com/repos/nak3/knative-openshift-ingress","forks_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/forks","keys_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/teams","hooks_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/hooks","issue_events_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/issues/events{/number}","events_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/events","assignees_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/assignees{/user}","branches_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/branches{/branch}","tags_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/tags","blobs_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/languages","stargazers_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/stargazers","contributors_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/contributors","subscribers_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/subscribers","subscription_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/subscription","commits_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/contents/{+path}","compare_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/merges","archive_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/downloads","issues_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/issues{/number}","pulls_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/labels{/name}","releases_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/releases{/id}","deployments_url":"https://api.github.com/repos/nak3/knative-openshift-ingress/deployments","created_at":"2019-06-04T08:21:28Z","updated_at":"2019-10-31T10:31:27Z","pushed_at":"2019-11-01T10:36:40Z","git_url":"git://github.com/nak3/knative-openshift-ingress.git","ssh_url":"git@github.com:nak3/knative-openshift-ingress.git","clone_url":"https://github.com/nak3/knative-openshift-ingress.git","svn_url":"https://github.com/nak3/knative-openshift-ingress","homepage":null,"size":17630,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift-knative:master","ref":"master","sha":"2aa076e7d54cd83e3ad387d1015d577c2bddbb11","user":{"login":"openshift-knative","id":48102184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MTAyMTg0","avatar_url":"https://avatars0.githubusercontent.com/u/48102184?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-knative","html_url":"https://github.com/openshift-knative","followers_url":"https://api.github.com/users/openshift-knative/followers","following_url":"https://api.github.com/users/openshift-knative/following{/other_user}","gists_url":"https://api.github.com/users/openshift-knative/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-knative/subscriptions","organizations_url":"https://api.github.com/users/openshift-knative/orgs","repos_url":"https://api.github.com/users/openshift-knative/repos","events_url":"https://api.github.com/users/openshift-knative/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-knative/received_events","type":"Organization","site_admin":false},"repo":{"id":181052858,"node_id":"MDEwOlJlcG9zaXRvcnkxODEwNTI4NTg=","name":"knative-openshift-ingress","full_name":"openshift-knative/knative-openshift-ingress","private":false,"owner":{"login":"openshift-knative","id":48102184,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MTAyMTg0","avatar_url":"https://avatars0.githubusercontent.com/u/48102184?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-knative","html_url":"https://github.com/openshift-knative","followers_url":"https://api.github.com/users/openshift-knative/followers","following_url":"https://api.github.com/users/openshift-knative/following{/other_user}","gists_url":"https://api.github.com/users/openshift-knative/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-knative/subscriptions","organizations_url":"https://api.github.com/users/openshift-knative/orgs","repos_url":"https://api.github.com/users/openshift-knative/repos","events_url":"https://api.github.com/users/openshift-knative/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift-knative/knative-openshift-ingress","description":"Front Knative Routes with OpenShift Routes","fork":false,"url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress","forks_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/forks","keys_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/teams","hooks_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/hooks","issue_events_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues/events{/number}","events_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/events","assignees_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/assignees{/user}","branches_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/branches{/branch}","tags_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/tags","blobs_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/languages","stargazers_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/stargazers","contributors_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/contributors","subscribers_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/subscribers","subscription_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/subscription","commits_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/contents/{+path}","compare_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/merges","archive_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/downloads","issues_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues{/number}","pulls_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/labels{/name}","releases_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/releases{/id}","deployments_url":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/deployments","created_at":"2019-04-12T17:21:04Z","updated_at":"2019-10-15T16:42:11Z","pushed_at":"2019-11-01T10:38:03Z","git_url":"git://github.com/openshift-knative/knative-openshift-ingress.git","ssh_url":"git@github.com:openshift-knative/knative-openshift-ingress.git","clone_url":"https://github.com/openshift-knative/knative-openshift-ingress.git","svn_url":"https://github.com/openshift-knative/knative-openshift-ingress","homepage":null,"size":17491,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24"},"html":{"href":"https://github.com/openshift-knative/knative-openshift-ingress/pull/24"},"issue":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues/24"},"comments":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/openshift-knative/knative-openshift-ingress/statuses/9668221f5334384f2ecc666587625df806365e9d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markusthoemmes"}}