{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/348513648","pull_request_review_id":319882231,"id":348513648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODUxMzY0OA==","diff_hunk":"@@ -168,6 +169,9 @@\n     public static final String INDICES_SHARDS_CLOSED_TIMEOUT = \"indices.shards_closed_timeout\";\n     public static final Setting<TimeValue> INDICES_CACHE_CLEAN_INTERVAL_SETTING =\n         Setting.positiveTimeSetting(\"indices.cache.cleanup_interval\", TimeValue.timeValueMinutes(1), Property.NodeScope);\n+    public static final Setting<Boolean> INDICES_ID_FIELD_DATA_ENABLED_SETTING =\n+        Setting.boolSetting(\"indices.id_field_data.enabled\", false, Property.Dynamic, Property.NodeScope);","path":"server/src/main/java/org/elasticsearch/indices/IndicesService.java","position":13,"original_position":13,"commit_id":"e4c2446c723809bec09289b775225030c4727c2d","original_commit_id":"e4c2446c723809bec09289b775225030c4727c2d","user":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"body":"Yes that's the plan","created_at":"2019-11-20T14:31:37Z","updated_at":"2019-11-20T14:31:37Z","html_url":"https://github.com/elastic/elasticsearch/pull/49166#discussion_r348513648","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/348513648"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/49166#discussion_r348513648"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166"}},"in_reply_to_id":348358187},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166","id":341485184,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNDg1MTg0","html_url":"https://github.com/elastic/elasticsearch/pull/49166","diff_url":"https://github.com/elastic/elasticsearch/pull/49166.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/49166.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/49166","number":49166,"state":"open","locked":false,"title":"Add a cluster setting to disallow loading fielddata on _id field","user":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"body":"This change adds a dynamic cluster setting named `indices.id_field_data.enabled`.\r\nWhen set to `false` any attempt to load the fielddata for the `_id` field will fail\r\nwith an exception. The default value in this change is set to `false` in order to prevent\r\nfielddata usage on this field for future versions but it will be set to `true` when backporting\r\nto 7x. When the setting is set to true (manually or by default in 7x) the loading will also issue\r\na deprecation warning since we want to disallow fielddata entirely when https://github.com/elastic/elasticsearch/issues/26472 is implemented.\r\n\r\nCloses #43599","created_at":"2019-11-15T14:12:27Z","updated_at":"2019-11-20T14:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c8179238d64510552fb81c3d3b5d41452dfdbb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":141145460,"node_id":"MDU6TGFiZWwxNDExNDU0NjA=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search/Mapping","name":":Search/Mapping","color":"0e8a16","default":false,"description":"How fields should be indexed"},{"id":189346177,"node_id":"MDU6TGFiZWwxODkzNDYxNzc=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Edeprecation","name":">deprecation","color":"ce18a7","default":false,"description":null},{"id":23174,"node_id":"MDU6TGFiZWwyMzE3NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false,"description":null},{"id":1619315113,"node_id":"MDU6TGFiZWwxNjE5MzE1MTEz","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.6.0","name":"v7.6.0","color":"DDDDDD","default":false,"description":""},{"id":1194435738,"node_id":"MDU6TGFiZWwxMTk0NDM1NzM4","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v8.0.0","name":"v8.0.0","color":"dddddd","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/49166/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/e4c2446c723809bec09289b775225030c4727c2d","head":{"label":"jimczi:disable_id_fielddata","ref":"disable_id_fielddata","sha":"e4c2446c723809bec09289b775225030c4727c2d","user":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"repo":{"id":91054845,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA1NDg0NQ==","name":"elasticsearch","full_name":"jimczi/elasticsearch","private":false,"owner":{"login":"jimczi","id":15977469,"node_id":"MDQ6VXNlcjE1OTc3NDY5","avatar_url":"https://avatars0.githubusercontent.com/u/15977469?v=4","gravatar_id":"","url":"https://api.github.com/users/jimczi","html_url":"https://github.com/jimczi","followers_url":"https://api.github.com/users/jimczi/followers","following_url":"https://api.github.com/users/jimczi/following{/other_user}","gists_url":"https://api.github.com/users/jimczi/gists{/gist_id}","starred_url":"https://api.github.com/users/jimczi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimczi/subscriptions","organizations_url":"https://api.github.com/users/jimczi/orgs","repos_url":"https://api.github.com/users/jimczi/repos","events_url":"https://api.github.com/users/jimczi/events{/privacy}","received_events_url":"https://api.github.com/users/jimczi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jimczi/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jimczi/elasticsearch","forks_url":"https://api.github.com/repos/jimczi/elasticsearch/forks","keys_url":"https://api.github.com/repos/jimczi/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimczi/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimczi/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jimczi/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jimczi/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jimczi/elasticsearch/events","assignees_url":"https://api.github.com/repos/jimczi/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jimczi/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jimczi/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jimczi/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimczi/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimczi/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimczi/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimczi/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jimczi/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jimczi/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jimczi/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jimczi/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jimczi/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jimczi/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimczi/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimczi/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimczi/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimczi/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jimczi/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimczi/elasticsearch/merges","archive_url":"https://api.github.com/repos/jimczi/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimczi/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jimczi/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jimczi/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jimczi/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jimczi/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimczi/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jimczi/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jimczi/elasticsearch/deployments","created_at":"2017-05-12T05:31:39Z","updated_at":"2017-05-12T05:32:12Z","pushed_at":"2019-11-20T14:24:43Z","git_url":"git://github.com/jimczi/elasticsearch.git","ssh_url":"git@github.com:jimczi/elasticsearch.git","clone_url":"https://github.com/jimczi/elasticsearch.git","svn_url":"https://github.com/jimczi/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":555413,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"730faa8438ccd4f4989b63916f68bb6843216c68","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2019-11-20T14:10:50Z","pushed_at":"2019-11-20T14:24:48Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":686721,"stargazers_count":45495,"watchers_count":45495,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15352,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2278,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15352,"open_issues":2278,"watchers":45495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/49166"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/49166"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/49166/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/49166/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/e4c2446c723809bec09289b775225030c4727c2d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jimczi"}}