{"action":"created","comment":{"url":"https://api.github.com/repos/opengisch/QField/pulls/comments/329351822","pull_request_review_id":294681979,"id":329351822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTM1MTgyMg==","diff_hunk":"@@ -26,6 +26,10 @@ Item {\n   property alias isRendering: mapCanvasWrapper.isRendering\n   property alias incrementalRendering: mapCanvasWrapper.incrementalRendering\n \n+  property int mouseX\n+  property int mouseY\n+  property bool skipClicked","path":"src/qml/MapCanvas.qml","position":6,"original_position":6,"commit_id":"34964830dda9ef5c1369a707cb5f4ddcf5b01645","original_commit_id":"34964830dda9ef5c1369a707cb5f4ddcf5b01645","user":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"body":"FYI, signals / slots are used by naming convention in QML\r\nyou can add a signal `singleClick` and a slot `onSingleClick` will automatically be connected.","created_at":"2019-09-29T12:28:47Z","updated_at":"2019-09-29T12:28:47Z","html_url":"https://github.com/opengisch/QField/pull/632#discussion_r329351822","pull_request_url":"https://api.github.com/repos/opengisch/QField/pulls/632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opengisch/QField/pulls/comments/329351822"},"html":{"href":"https://github.com/opengisch/QField/pull/632#discussion_r329351822"},"pull_request":{"href":"https://api.github.com/repos/opengisch/QField/pulls/632"}},"in_reply_to_id":329340639},"pull_request":{"url":"https://api.github.com/repos/opengisch/QField/pulls/632","id":322112034,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyMTEyMDM0","html_url":"https://github.com/opengisch/QField/pull/632","diff_url":"https://github.com/opengisch/QField/pull/632.diff","patch_url":"https://github.com/opengisch/QField/pull/632.patch","issue_url":"https://api.github.com/repos/opengisch/QField/issues/632","number":632,"state":"open","locked":false,"title":"Do not running the identify tool when double tapping on map canvas","user":{"login":"nirvn","id":1728657,"node_id":"MDQ6VXNlcjE3Mjg2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1728657?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"body":"Here's one huge UX issue fixed: when double tapping on the screen, QField used to both zoom into the canvas (good, standard UX on smartphones and tablets) _as well as_ launching the identify too (bad).\r\n\r\nThis PR insures that the identify tool is only launched on single tap onto the screen.","created_at":"2019-09-27T10:59:38Z","updated_at":"2019-09-29T12:28:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9e87d1974832d480275da0d729059478b18e521","assignee":{"login":"3nids","id":127259,"node_id":"MDQ6VXNlcjEyNzI1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127259?v=4","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false},"assignees":[{"login":"3nids","id":127259,"node_id":"MDQ6VXNlcjEyNzI1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/127259?v=4","gravatar_id":"","url":"https://api.github.com/users/3nids","html_url":"https://github.com/3nids","followers_url":"https://api.github.com/users/3nids/followers","following_url":"https://api.github.com/users/3nids/following{/other_user}","gists_url":"https://api.github.com/users/3nids/gists{/gist_id}","starred_url":"https://api.github.com/users/3nids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3nids/subscriptions","organizations_url":"https://api.github.com/users/3nids/orgs","repos_url":"https://api.github.com/users/3nids/repos","events_url":"https://api.github.com/users/3nids/events{/privacy}","received_events_url":"https://api.github.com/users/3nids/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1583592375,"node_id":"MDU6TGFiZWwxNTgzNTkyMzc1","url":"https://api.github.com/repos/opengisch/QField/labels/Ready%20For%20Review","name":"Ready For Review","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opengisch/QField/pulls/632/commits","review_comments_url":"https://api.github.com/repos/opengisch/QField/pulls/632/comments","review_comment_url":"https://api.github.com/repos/opengisch/QField/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opengisch/QField/issues/632/comments","statuses_url":"https://api.github.com/repos/opengisch/QField/statuses/34964830dda9ef5c1369a707cb5f4ddcf5b01645","head":{"label":"opengisch:doubletap_imp","ref":"doubletap_imp","sha":"34964830dda9ef5c1369a707cb5f4ddcf5b01645","user":{"login":"opengisch","id":8892251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTIyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8892251?v=4","gravatar_id":"","url":"https://api.github.com/users/opengisch","html_url":"https://github.com/opengisch","followers_url":"https://api.github.com/users/opengisch/followers","following_url":"https://api.github.com/users/opengisch/following{/other_user}","gists_url":"https://api.github.com/users/opengisch/gists{/gist_id}","starred_url":"https://api.github.com/users/opengisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengisch/subscriptions","organizations_url":"https://api.github.com/users/opengisch/orgs","repos_url":"https://api.github.com/users/opengisch/repos","events_url":"https://api.github.com/users/opengisch/events{/privacy}","received_events_url":"https://api.github.com/users/opengisch/received_events","type":"Organization","site_admin":false},"repo":{"id":27185284,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE4NTI4NA==","name":"QField","full_name":"opengisch/QField","private":false,"owner":{"login":"opengisch","id":8892251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTIyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8892251?v=4","gravatar_id":"","url":"https://api.github.com/users/opengisch","html_url":"https://github.com/opengisch","followers_url":"https://api.github.com/users/opengisch/followers","following_url":"https://api.github.com/users/opengisch/following{/other_user}","gists_url":"https://api.github.com/users/opengisch/gists{/gist_id}","starred_url":"https://api.github.com/users/opengisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengisch/subscriptions","organizations_url":"https://api.github.com/users/opengisch/orgs","repos_url":"https://api.github.com/users/opengisch/repos","events_url":"https://api.github.com/users/opengisch/events{/privacy}","received_events_url":"https://api.github.com/users/opengisch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opengisch/QField","description":"A simplified touch optimized interface for QGIS","fork":false,"url":"https://api.github.com/repos/opengisch/QField","forks_url":"https://api.github.com/repos/opengisch/QField/forks","keys_url":"https://api.github.com/repos/opengisch/QField/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opengisch/QField/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opengisch/QField/teams","hooks_url":"https://api.github.com/repos/opengisch/QField/hooks","issue_events_url":"https://api.github.com/repos/opengisch/QField/issues/events{/number}","events_url":"https://api.github.com/repos/opengisch/QField/events","assignees_url":"https://api.github.com/repos/opengisch/QField/assignees{/user}","branches_url":"https://api.github.com/repos/opengisch/QField/branches{/branch}","tags_url":"https://api.github.com/repos/opengisch/QField/tags","blobs_url":"https://api.github.com/repos/opengisch/QField/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opengisch/QField/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opengisch/QField/git/refs{/sha}","trees_url":"https://api.github.com/repos/opengisch/QField/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opengisch/QField/statuses/{sha}","languages_url":"https://api.github.com/repos/opengisch/QField/languages","stargazers_url":"https://api.github.com/repos/opengisch/QField/stargazers","contributors_url":"https://api.github.com/repos/opengisch/QField/contributors","subscribers_url":"https://api.github.com/repos/opengisch/QField/subscribers","subscription_url":"https://api.github.com/repos/opengisch/QField/subscription","commits_url":"https://api.github.com/repos/opengisch/QField/commits{/sha}","git_commits_url":"https://api.github.com/repos/opengisch/QField/git/commits{/sha}","comments_url":"https://api.github.com/repos/opengisch/QField/comments{/number}","issue_comment_url":"https://api.github.com/repos/opengisch/QField/issues/comments{/number}","contents_url":"https://api.github.com/repos/opengisch/QField/contents/{+path}","compare_url":"https://api.github.com/repos/opengisch/QField/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opengisch/QField/merges","archive_url":"https://api.github.com/repos/opengisch/QField/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opengisch/QField/downloads","issues_url":"https://api.github.com/repos/opengisch/QField/issues{/number}","pulls_url":"https://api.github.com/repos/opengisch/QField/pulls{/number}","milestones_url":"https://api.github.com/repos/opengisch/QField/milestones{/number}","notifications_url":"https://api.github.com/repos/opengisch/QField/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opengisch/QField/labels{/name}","releases_url":"https://api.github.com/repos/opengisch/QField/releases{/id}","deployments_url":"https://api.github.com/repos/opengisch/QField/deployments","created_at":"2014-11-26T16:20:45Z","updated_at":"2019-09-28T15:20:37Z","pushed_at":"2019-09-29T11:03:46Z","git_url":"git://github.com/opengisch/QField.git","ssh_url":"git@github.com:opengisch/QField.git","clone_url":"https://github.com/opengisch/QField.git","svn_url":"https://github.com/opengisch/QField","homepage":"http://www.qfield.org","size":116394,"stargazers_count":187,"watchers_count":187,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":168,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":68,"open_issues":168,"watchers":187,"default_branch":"master"}},"base":{"label":"opengisch:master","ref":"master","sha":"7486c4b101696ad414345a9d6773bb90ab401519","user":{"login":"opengisch","id":8892251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTIyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8892251?v=4","gravatar_id":"","url":"https://api.github.com/users/opengisch","html_url":"https://github.com/opengisch","followers_url":"https://api.github.com/users/opengisch/followers","following_url":"https://api.github.com/users/opengisch/following{/other_user}","gists_url":"https://api.github.com/users/opengisch/gists{/gist_id}","starred_url":"https://api.github.com/users/opengisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengisch/subscriptions","organizations_url":"https://api.github.com/users/opengisch/orgs","repos_url":"https://api.github.com/users/opengisch/repos","events_url":"https://api.github.com/users/opengisch/events{/privacy}","received_events_url":"https://api.github.com/users/opengisch/received_events","type":"Organization","site_admin":false},"repo":{"id":27185284,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE4NTI4NA==","name":"QField","full_name":"opengisch/QField","private":false,"owner":{"login":"opengisch","id":8892251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTIyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8892251?v=4","gravatar_id":"","url":"https://api.github.com/users/opengisch","html_url":"https://github.com/opengisch","followers_url":"https://api.github.com/users/opengisch/followers","following_url":"https://api.github.com/users/opengisch/following{/other_user}","gists_url":"https://api.github.com/users/opengisch/gists{/gist_id}","starred_url":"https://api.github.com/users/opengisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengisch/subscriptions","organizations_url":"https://api.github.com/users/opengisch/orgs","repos_url":"https://api.github.com/users/opengisch/repos","events_url":"https://api.github.com/users/opengisch/events{/privacy}","received_events_url":"https://api.github.com/users/opengisch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opengisch/QField","description":"A simplified touch optimized interface for QGIS","fork":false,"url":"https://api.github.com/repos/opengisch/QField","forks_url":"https://api.github.com/repos/opengisch/QField/forks","keys_url":"https://api.github.com/repos/opengisch/QField/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opengisch/QField/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opengisch/QField/teams","hooks_url":"https://api.github.com/repos/opengisch/QField/hooks","issue_events_url":"https://api.github.com/repos/opengisch/QField/issues/events{/number}","events_url":"https://api.github.com/repos/opengisch/QField/events","assignees_url":"https://api.github.com/repos/opengisch/QField/assignees{/user}","branches_url":"https://api.github.com/repos/opengisch/QField/branches{/branch}","tags_url":"https://api.github.com/repos/opengisch/QField/tags","blobs_url":"https://api.github.com/repos/opengisch/QField/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opengisch/QField/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opengisch/QField/git/refs{/sha}","trees_url":"https://api.github.com/repos/opengisch/QField/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opengisch/QField/statuses/{sha}","languages_url":"https://api.github.com/repos/opengisch/QField/languages","stargazers_url":"https://api.github.com/repos/opengisch/QField/stargazers","contributors_url":"https://api.github.com/repos/opengisch/QField/contributors","subscribers_url":"https://api.github.com/repos/opengisch/QField/subscribers","subscription_url":"https://api.github.com/repos/opengisch/QField/subscription","commits_url":"https://api.github.com/repos/opengisch/QField/commits{/sha}","git_commits_url":"https://api.github.com/repos/opengisch/QField/git/commits{/sha}","comments_url":"https://api.github.com/repos/opengisch/QField/comments{/number}","issue_comment_url":"https://api.github.com/repos/opengisch/QField/issues/comments{/number}","contents_url":"https://api.github.com/repos/opengisch/QField/contents/{+path}","compare_url":"https://api.github.com/repos/opengisch/QField/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opengisch/QField/merges","archive_url":"https://api.github.com/repos/opengisch/QField/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opengisch/QField/downloads","issues_url":"https://api.github.com/repos/opengisch/QField/issues{/number}","pulls_url":"https://api.github.com/repos/opengisch/QField/pulls{/number}","milestones_url":"https://api.github.com/repos/opengisch/QField/milestones{/number}","notifications_url":"https://api.github.com/repos/opengisch/QField/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opengisch/QField/labels{/name}","releases_url":"https://api.github.com/repos/opengisch/QField/releases{/id}","deployments_url":"https://api.github.com/repos/opengisch/QField/deployments","created_at":"2014-11-26T16:20:45Z","updated_at":"2019-09-28T15:20:37Z","pushed_at":"2019-09-29T11:03:46Z","git_url":"git://github.com/opengisch/QField.git","ssh_url":"git@github.com:opengisch/QField.git","clone_url":"https://github.com/opengisch/QField.git","svn_url":"https://github.com/opengisch/QField","homepage":"http://www.qfield.org","size":116394,"stargazers_count":187,"watchers_count":187,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":168,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":68,"open_issues":168,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opengisch/QField/pulls/632"},"html":{"href":"https://github.com/opengisch/QField/pull/632"},"issue":{"href":"https://api.github.com/repos/opengisch/QField/issues/632"},"comments":{"href":"https://api.github.com/repos/opengisch/QField/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/opengisch/QField/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/opengisch/QField/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opengisch/QField/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/opengisch/QField/statuses/34964830dda9ef5c1369a707cb5f4ddcf5b01645"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"m-kuhn"}}