{"action":"created","comment":{"url":"https://api.github.com/repos/voysis/voysis-ios/pulls/comments/261265690","pull_request_review_id":209160626,"id":261265690,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTI2NTY5MA==","diff_hunk":"@@ -29,15 +27,11 @@ class AudioRecorderImpl: AudioRecorder {\n         self.onDataResponse = onDataResponse\n         setupAudioQueue()\n         inProgress = true\n-        player.playStartAudio { [weak self] in\n-            guard let this = self else {\n-                return\n-            }\n-            guard let queue = this.queue else {\n-                return\n-            }\n-            AudioQueueStart(queue, nil)\n+        guard let queue = queue else {","path":"Voysis/recorder/AudioRecorderImpl.swift","position":31,"original_position":31,"commit_id":"fd02e3d7921d8ac1c9cc7b12cec337ffd1a92fa6","original_commit_id":"fd02e3d7921d8ac1c9cc7b12cec337ffd1a92fa6","user":{"login":"lduffy-voysis","id":38731012,"node_id":"MDQ6VXNlcjM4NzMxMDEy","avatar_url":"https://avatars2.githubusercontent.com/u/38731012?v=4","gravatar_id":"","url":"https://api.github.com/users/lduffy-voysis","html_url":"https://github.com/lduffy-voysis","followers_url":"https://api.github.com/users/lduffy-voysis/followers","following_url":"https://api.github.com/users/lduffy-voysis/following{/other_user}","gists_url":"https://api.github.com/users/lduffy-voysis/gists{/gist_id}","starred_url":"https://api.github.com/users/lduffy-voysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lduffy-voysis/subscriptions","organizations_url":"https://api.github.com/users/lduffy-voysis/orgs","repos_url":"https://api.github.com/users/lduffy-voysis/repos","events_url":"https://api.github.com/users/lduffy-voysis/events{/privacy}","received_events_url":"https://api.github.com/users/lduffy-voysis/received_events","type":"User","site_admin":false},"body":"Though now that I'm revisiting this code I do see how it looks weird and I think returning if the optional is not set is probably ill advised. Took this example from the apple docs, It calls this guard clause in a bunch of places and doesn't provide proper error reporting in the case that its null. I'd like to make another ticket to revisit this class and improve on what we have at the moment.","created_at":"2019-02-28T16:04:53Z","updated_at":"2019-02-28T16:04:54Z","html_url":"https://github.com/voysis/voysis-ios/pull/22#discussion_r261265690","pull_request_url":"https://api.github.com/repos/voysis/voysis-ios/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/voysis/voysis-ios/pulls/comments/261265690"},"html":{"href":"https://github.com/voysis/voysis-ios/pull/22#discussion_r261265690"},"pull_request":{"href":"https://api.github.com/repos/voysis/voysis-ios/pulls/22"}},"in_reply_to_id":261255035},"pull_request":{"url":"https://api.github.com/repos/voysis/voysis-ios/pulls/22","id":257112633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MTEyNjMz","html_url":"https://github.com/voysis/voysis-ios/pull/22","diff_url":"https://github.com/voysis/voysis-ios/pull/22.diff","patch_url":"https://github.com/voysis/voysis-ios/pull/22.patch","issue_url":"https://api.github.com/repos/voysis/voysis-ios/issues/22","number":22,"state":"open","locked":false,"title":"Update beep","user":{"login":"lduffy-voysis","id":38731012,"node_id":"MDQ6VXNlcjM4NzMxMDEy","avatar_url":"https://avatars2.githubusercontent.com/u/38731012?v=4","gravatar_id":"","url":"https://api.github.com/users/lduffy-voysis","html_url":"https://github.com/lduffy-voysis","followers_url":"https://api.github.com/users/lduffy-voysis/followers","following_url":"https://api.github.com/users/lduffy-voysis/following{/other_user}","gists_url":"https://api.github.com/users/lduffy-voysis/gists{/gist_id}","starred_url":"https://api.github.com/users/lduffy-voysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lduffy-voysis/subscriptions","organizations_url":"https://api.github.com/users/lduffy-voysis/orgs","repos_url":"https://api.github.com/users/lduffy-voysis/repos","events_url":"https://api.github.com/users/lduffy-voysis/events{/privacy}","received_events_url":"https://api.github.com/users/lduffy-voysis/received_events","type":"User","site_admin":false},"body":"Removed voysis on/off wav.\r\nRemoved AudioPlayer class. \r\nRemoved reference to audioPlayer class in AudioRecorderImpl","created_at":"2019-02-28T15:23:16Z","updated_at":"2019-02-28T16:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ec6a5a9d17134502ac7617354d92da3df646196","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/voysis/voysis-ios/pulls/22/commits","review_comments_url":"https://api.github.com/repos/voysis/voysis-ios/pulls/22/comments","review_comment_url":"https://api.github.com/repos/voysis/voysis-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voysis/voysis-ios/issues/22/comments","statuses_url":"https://api.github.com/repos/voysis/voysis-ios/statuses/fd02e3d7921d8ac1c9cc7b12cec337ffd1a92fa6","head":{"label":"voysis:update-beep","ref":"update-beep","sha":"fd02e3d7921d8ac1c9cc7b12cec337ffd1a92fa6","user":{"login":"voysis","id":33933066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTMzMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33933066?v=4","gravatar_id":"","url":"https://api.github.com/users/voysis","html_url":"https://github.com/voysis","followers_url":"https://api.github.com/users/voysis/followers","following_url":"https://api.github.com/users/voysis/following{/other_user}","gists_url":"https://api.github.com/users/voysis/gists{/gist_id}","starred_url":"https://api.github.com/users/voysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voysis/subscriptions","organizations_url":"https://api.github.com/users/voysis/orgs","repos_url":"https://api.github.com/users/voysis/repos","events_url":"https://api.github.com/users/voysis/events{/privacy}","received_events_url":"https://api.github.com/users/voysis/received_events","type":"Organization","site_admin":false},"repo":{"id":131134008,"node_id":"MDEwOlJlcG9zaXRvcnkxMzExMzQwMDg=","name":"voysis-ios","full_name":"voysis/voysis-ios","private":false,"owner":{"login":"voysis","id":33933066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTMzMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33933066?v=4","gravatar_id":"","url":"https://api.github.com/users/voysis","html_url":"https://github.com/voysis","followers_url":"https://api.github.com/users/voysis/followers","following_url":"https://api.github.com/users/voysis/following{/other_user}","gists_url":"https://api.github.com/users/voysis/gists{/gist_id}","starred_url":"https://api.github.com/users/voysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voysis/subscriptions","organizations_url":"https://api.github.com/users/voysis/orgs","repos_url":"https://api.github.com/users/voysis/repos","events_url":"https://api.github.com/users/voysis/events{/privacy}","received_events_url":"https://api.github.com/users/voysis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voysis/voysis-ios","description":null,"fork":false,"url":"https://api.github.com/repos/voysis/voysis-ios","forks_url":"https://api.github.com/repos/voysis/voysis-ios/forks","keys_url":"https://api.github.com/repos/voysis/voysis-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voysis/voysis-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voysis/voysis-ios/teams","hooks_url":"https://api.github.com/repos/voysis/voysis-ios/hooks","issue_events_url":"https://api.github.com/repos/voysis/voysis-ios/issues/events{/number}","events_url":"https://api.github.com/repos/voysis/voysis-ios/events","assignees_url":"https://api.github.com/repos/voysis/voysis-ios/assignees{/user}","branches_url":"https://api.github.com/repos/voysis/voysis-ios/branches{/branch}","tags_url":"https://api.github.com/repos/voysis/voysis-ios/tags","blobs_url":"https://api.github.com/repos/voysis/voysis-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voysis/voysis-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voysis/voysis-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/voysis/voysis-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voysis/voysis-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/voysis/voysis-ios/languages","stargazers_url":"https://api.github.com/repos/voysis/voysis-ios/stargazers","contributors_url":"https://api.github.com/repos/voysis/voysis-ios/contributors","subscribers_url":"https://api.github.com/repos/voysis/voysis-ios/subscribers","subscription_url":"https://api.github.com/repos/voysis/voysis-ios/subscription","commits_url":"https://api.github.com/repos/voysis/voysis-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/voysis/voysis-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/voysis/voysis-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/voysis/voysis-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/voysis/voysis-ios/contents/{+path}","compare_url":"https://api.github.com/repos/voysis/voysis-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voysis/voysis-ios/merges","archive_url":"https://api.github.com/repos/voysis/voysis-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voysis/voysis-ios/downloads","issues_url":"https://api.github.com/repos/voysis/voysis-ios/issues{/number}","pulls_url":"https://api.github.com/repos/voysis/voysis-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/voysis/voysis-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/voysis/voysis-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voysis/voysis-ios/labels{/name}","releases_url":"https://api.github.com/repos/voysis/voysis-ios/releases{/id}","deployments_url":"https://api.github.com/repos/voysis/voysis-ios/deployments","created_at":"2018-04-26T09:39:23Z","updated_at":"2019-02-20T14:13:08Z","pushed_at":"2019-02-28T15:23:17Z","git_url":"git://github.com/voysis/voysis-ios.git","ssh_url":"git@github.com:voysis/voysis-ios.git","clone_url":"https://github.com/voysis/voysis-ios.git","svn_url":"https://github.com/voysis/voysis-ios","homepage":null,"size":200,"stargazers_count":5,"watchers_count":5,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"voysis:master","ref":"master","sha":"31b71e2a1891b8b0035762ede1ea86f0fe04201a","user":{"login":"voysis","id":33933066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTMzMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33933066?v=4","gravatar_id":"","url":"https://api.github.com/users/voysis","html_url":"https://github.com/voysis","followers_url":"https://api.github.com/users/voysis/followers","following_url":"https://api.github.com/users/voysis/following{/other_user}","gists_url":"https://api.github.com/users/voysis/gists{/gist_id}","starred_url":"https://api.github.com/users/voysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voysis/subscriptions","organizations_url":"https://api.github.com/users/voysis/orgs","repos_url":"https://api.github.com/users/voysis/repos","events_url":"https://api.github.com/users/voysis/events{/privacy}","received_events_url":"https://api.github.com/users/voysis/received_events","type":"Organization","site_admin":false},"repo":{"id":131134008,"node_id":"MDEwOlJlcG9zaXRvcnkxMzExMzQwMDg=","name":"voysis-ios","full_name":"voysis/voysis-ios","private":false,"owner":{"login":"voysis","id":33933066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTMzMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/33933066?v=4","gravatar_id":"","url":"https://api.github.com/users/voysis","html_url":"https://github.com/voysis","followers_url":"https://api.github.com/users/voysis/followers","following_url":"https://api.github.com/users/voysis/following{/other_user}","gists_url":"https://api.github.com/users/voysis/gists{/gist_id}","starred_url":"https://api.github.com/users/voysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voysis/subscriptions","organizations_url":"https://api.github.com/users/voysis/orgs","repos_url":"https://api.github.com/users/voysis/repos","events_url":"https://api.github.com/users/voysis/events{/privacy}","received_events_url":"https://api.github.com/users/voysis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voysis/voysis-ios","description":null,"fork":false,"url":"https://api.github.com/repos/voysis/voysis-ios","forks_url":"https://api.github.com/repos/voysis/voysis-ios/forks","keys_url":"https://api.github.com/repos/voysis/voysis-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voysis/voysis-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voysis/voysis-ios/teams","hooks_url":"https://api.github.com/repos/voysis/voysis-ios/hooks","issue_events_url":"https://api.github.com/repos/voysis/voysis-ios/issues/events{/number}","events_url":"https://api.github.com/repos/voysis/voysis-ios/events","assignees_url":"https://api.github.com/repos/voysis/voysis-ios/assignees{/user}","branches_url":"https://api.github.com/repos/voysis/voysis-ios/branches{/branch}","tags_url":"https://api.github.com/repos/voysis/voysis-ios/tags","blobs_url":"https://api.github.com/repos/voysis/voysis-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voysis/voysis-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voysis/voysis-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/voysis/voysis-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voysis/voysis-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/voysis/voysis-ios/languages","stargazers_url":"https://api.github.com/repos/voysis/voysis-ios/stargazers","contributors_url":"https://api.github.com/repos/voysis/voysis-ios/contributors","subscribers_url":"https://api.github.com/repos/voysis/voysis-ios/subscribers","subscription_url":"https://api.github.com/repos/voysis/voysis-ios/subscription","commits_url":"https://api.github.com/repos/voysis/voysis-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/voysis/voysis-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/voysis/voysis-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/voysis/voysis-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/voysis/voysis-ios/contents/{+path}","compare_url":"https://api.github.com/repos/voysis/voysis-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voysis/voysis-ios/merges","archive_url":"https://api.github.com/repos/voysis/voysis-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voysis/voysis-ios/downloads","issues_url":"https://api.github.com/repos/voysis/voysis-ios/issues{/number}","pulls_url":"https://api.github.com/repos/voysis/voysis-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/voysis/voysis-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/voysis/voysis-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voysis/voysis-ios/labels{/name}","releases_url":"https://api.github.com/repos/voysis/voysis-ios/releases{/id}","deployments_url":"https://api.github.com/repos/voysis/voysis-ios/deployments","created_at":"2018-04-26T09:39:23Z","updated_at":"2019-02-20T14:13:08Z","pushed_at":"2019-02-28T15:23:17Z","git_url":"git://github.com/voysis/voysis-ios.git","ssh_url":"git@github.com:voysis/voysis-ios.git","clone_url":"https://github.com/voysis/voysis-ios.git","svn_url":"https://github.com/voysis/voysis-ios","homepage":null,"size":200,"stargazers_count":5,"watchers_count":5,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voysis/voysis-ios/pulls/22"},"html":{"href":"https://github.com/voysis/voysis-ios/pull/22"},"issue":{"href":"https://api.github.com/repos/voysis/voysis-ios/issues/22"},"comments":{"href":"https://api.github.com/repos/voysis/voysis-ios/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/voysis/voysis-ios/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/voysis/voysis-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voysis/voysis-ios/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/voysis/voysis-ios/statuses/fd02e3d7921d8ac1c9cc7b12cec337ffd1a92fa6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lduffy-voysis"}}