{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/320260601","pull_request_review_id":282979649,"id":320260601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDI2MDYwMQ==","diff_hunk":"@@ -260,6 +285,7 @@ trait AlignedMixin extends GrammarMixin { self: Term =>\n           case LengthKind.Prefixed => LengthMultipleOf(1) // NYI\n         }\n       }\n+      case mg: ModelGroup => LengthMultipleOf(1)","path":"daffodil-core/src/main/scala/org/apache/daffodil/grammar/AlignedMixin.scala","position":111,"original_position":111,"commit_id":"64831b8ae4e16d0416d8154ba52d5918dfc95a73","original_commit_id":"64831b8ae4e16d0416d8154ba52d5918dfc95a73","user":{"login":"jadams-tresys","id":30659277,"node_id":"MDQ6VXNlcjMwNjU5Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/30659277?v=4","gravatar_id":"","url":"https://api.github.com/users/jadams-tresys","html_url":"https://github.com/jadams-tresys","followers_url":"https://api.github.com/users/jadams-tresys/followers","following_url":"https://api.github.com/users/jadams-tresys/following{/other_user}","gists_url":"https://api.github.com/users/jadams-tresys/gists{/gist_id}","starred_url":"https://api.github.com/users/jadams-tresys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadams-tresys/subscriptions","organizations_url":"https://api.github.com/users/jadams-tresys/orgs","repos_url":"https://api.github.com/users/jadams-tresys/repos","events_url":"https://api.github.com/users/jadams-tresys/events{/privacy}","received_events_url":"https://api.github.com/users/jadams-tresys/received_events","type":"User","site_admin":false},"body":"So, this code path is actually getting hit by a negative test that is trying to trigger an SDE.  The test has an unordered sequence containing a choice, which is not allowed.  So what I think is happening is that the we are attempting to get the elementSpecifiedLengthApprox of this choice.\r\nI think the proper fix for this is to use the Assert.usageError for now, and handle this case in the SequenceGrammarMixin so that it doesn't even try to make a SequenceChild from the ModelGroup in an unordered sequence.","created_at":"2019-09-03T13:06:47Z","updated_at":"2019-09-03T13:06:47Z","html_url":"https://github.com/apache/incubator-daffodil/pull/262#discussion_r320260601","pull_request_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/320260601"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/262#discussion_r320260601"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262"}},"in_reply_to_id":318129410},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262","id":298156310,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MTU2MzEw","html_url":"https://github.com/apache/incubator-daffodil/pull/262","diff_url":"https://github.com/apache/incubator-daffodil/pull/262.diff","patch_url":"https://github.com/apache/incubator-daffodil/pull/262.patch","issue_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/262","number":262,"state":"open","locked":false,"title":"Unordered sequences","user":{"login":"jadams-tresys","id":30659277,"node_id":"MDQ6VXNlcjMwNjU5Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/30659277?v=4","gravatar_id":"","url":"https://api.github.com/users/jadams-tresys","html_url":"https://github.com/jadams-tresys","followers_url":"https://api.github.com/users/jadams-tresys/followers","following_url":"https://api.github.com/users/jadams-tresys/following{/other_user}","gists_url":"https://api.github.com/users/jadams-tresys/gists{/gist_id}","starred_url":"https://api.github.com/users/jadams-tresys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadams-tresys/subscriptions","organizations_url":"https://api.github.com/users/jadams-tresys/orgs","repos_url":"https://api.github.com/users/jadams-tresys/repos","events_url":"https://api.github.com/users/jadams-tresys/events{/privacy}","received_events_url":"https://api.github.com/users/jadams-tresys/received_events","type":"User","site_admin":false},"body":"Have an initial implementation working with simple test cases. Currently\r\nstill having issues with some negative test cases that still work due to\r\nlack of validation. Also still have a circular definition error in\r\ncontentStartAlignment, which calls priorSibsAlignmentsApprox which calls\r\ncontentStartAlignment.\r\n\r\nDAFFODIL-1159","created_at":"2019-07-16T18:17:37Z","updated_at":"2019-09-03T13:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/262/comments","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/64831b8ae4e16d0416d8154ba52d5918dfc95a73","head":{"label":"jadams-tresys:daffodil-1159-unordered_seq","ref":"daffodil-1159-unordered_seq","sha":"64831b8ae4e16d0416d8154ba52d5918dfc95a73","user":{"login":"jadams-tresys","id":30659277,"node_id":"MDQ6VXNlcjMwNjU5Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/30659277?v=4","gravatar_id":"","url":"https://api.github.com/users/jadams-tresys","html_url":"https://github.com/jadams-tresys","followers_url":"https://api.github.com/users/jadams-tresys/followers","following_url":"https://api.github.com/users/jadams-tresys/following{/other_user}","gists_url":"https://api.github.com/users/jadams-tresys/gists{/gist_id}","starred_url":"https://api.github.com/users/jadams-tresys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadams-tresys/subscriptions","organizations_url":"https://api.github.com/users/jadams-tresys/orgs","repos_url":"https://api.github.com/users/jadams-tresys/repos","events_url":"https://api.github.com/users/jadams-tresys/events{/privacy}","received_events_url":"https://api.github.com/users/jadams-tresys/received_events","type":"User","site_admin":false},"repo":{"id":113211111,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMTExMTE=","name":"incubator-daffodil","full_name":"jadams-tresys/incubator-daffodil","private":false,"owner":{"login":"jadams-tresys","id":30659277,"node_id":"MDQ6VXNlcjMwNjU5Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/30659277?v=4","gravatar_id":"","url":"https://api.github.com/users/jadams-tresys","html_url":"https://github.com/jadams-tresys","followers_url":"https://api.github.com/users/jadams-tresys/followers","following_url":"https://api.github.com/users/jadams-tresys/following{/other_user}","gists_url":"https://api.github.com/users/jadams-tresys/gists{/gist_id}","starred_url":"https://api.github.com/users/jadams-tresys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadams-tresys/subscriptions","organizations_url":"https://api.github.com/users/jadams-tresys/orgs","repos_url":"https://api.github.com/users/jadams-tresys/repos","events_url":"https://api.github.com/users/jadams-tresys/events{/privacy}","received_events_url":"https://api.github.com/users/jadams-tresys/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jadams-tresys/incubator-daffodil","description":"Apache Daffodil (Incubating)","fork":true,"url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil","forks_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/jadams-tresys/incubator-daffodil/deployments","created_at":"2017-12-05T17:14:08Z","updated_at":"2017-12-05T17:14:15Z","pushed_at":"2019-08-22T18:15:18Z","git_url":"git://github.com/jadams-tresys/incubator-daffodil.git","ssh_url":"git@github.com:jadams-tresys/incubator-daffodil.git","clone_url":"https://github.com/jadams-tresys/incubator-daffodil.git","svn_url":"https://github.com/jadams-tresys/incubator-daffodil","homepage":"https://daffodil.apache.org/","size":172329,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7a80dca8a72849bc4e2b417b384c9667cd5f33bf","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":101730006,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3MzAwMDY=","name":"incubator-daffodil","full_name":"apache/incubator-daffodil","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-daffodil","description":"Apache Daffodil (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-daffodil","forks_url":"https://api.github.com/repos/apache/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/apache/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/apache/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/apache/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/apache/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/apache/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/apache/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-daffodil/deployments","created_at":"2017-08-29T07:00:10Z","updated_at":"2019-08-27T13:34:01Z","pushed_at":"2019-08-28T13:06:52Z","git_url":"git://github.com/apache/incubator-daffodil.git","ssh_url":"git@github.com:apache/incubator-daffodil.git","clone_url":"https://github.com/apache/incubator-daffodil.git","svn_url":"https://github.com/apache/incubator-daffodil","homepage":"https://daffodil.apache.org/","size":172458,"stargazers_count":19,"watchers_count":19,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":5,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/262"},"issue":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/262"},"comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-daffodil/statuses/64831b8ae4e16d0416d8154ba52d5918dfc95a73"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jadams-tresys"}}