{"action":"opened","number":6188,"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/6188","id":326527734,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2NTI3NzM0","html_url":"https://github.com/fish-shell/fish-shell/pull/6188","diff_url":"https://github.com/fish-shell/fish-shell/pull/6188.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/6188.patch","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/6188","number":6188,"state":"open","locked":false,"title":"Fix options after --argument-names to function","user":{"login":"amiller27","id":4535296,"node_id":"MDQ6VXNlcjQ1MzUyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4535296?v=4","gravatar_id":"","url":"https://api.github.com/users/amiller27","html_url":"https://github.com/amiller27","followers_url":"https://api.github.com/users/amiller27/followers","following_url":"https://api.github.com/users/amiller27/following{/other_user}","gists_url":"https://api.github.com/users/amiller27/gists{/gist_id}","starred_url":"https://api.github.com/users/amiller27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiller27/subscriptions","organizations_url":"https://api.github.com/users/amiller27/orgs","repos_url":"https://api.github.com/users/amiller27/repos","events_url":"https://api.github.com/users/amiller27/events{/privacy}","received_events_url":"https://api.github.com/users/amiller27/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAllows for options to be passed after --argument-names, and handles them correctly as options instead of as additional argument names.\r\n\r\nFixes issue #6186\r\n\r\n## TODOs:\r\n<!-- Just check off what what we know been done so far. We can help you with this stuff. -->\r\n- [ ] Changes to fish usage are reflected in user documentation/manpages.\r\n- [ ] Tests have been added for regressions fixed\r\n- [ ] User-visible changes noted in CHANGELOG.md\r\n","created_at":"2019-10-10T03:05:02Z","updated_at":"2019-10-10T03:05:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/6188/commits","review_comments_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/6188/comments","review_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/6188/comments","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/68a7ff95234b9c157704738cc6235afc149b0b0c","head":{"label":"amiller27:master","ref":"master","sha":"68a7ff95234b9c157704738cc6235afc149b0b0c","user":{"login":"amiller27","id":4535296,"node_id":"MDQ6VXNlcjQ1MzUyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4535296?v=4","gravatar_id":"","url":"https://api.github.com/users/amiller27","html_url":"https://github.com/amiller27","followers_url":"https://api.github.com/users/amiller27/followers","following_url":"https://api.github.com/users/amiller27/following{/other_user}","gists_url":"https://api.github.com/users/amiller27/gists{/gist_id}","starred_url":"https://api.github.com/users/amiller27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiller27/subscriptions","organizations_url":"https://api.github.com/users/amiller27/orgs","repos_url":"https://api.github.com/users/amiller27/repos","events_url":"https://api.github.com/users/amiller27/events{/privacy}","received_events_url":"https://api.github.com/users/amiller27/received_events","type":"User","site_admin":false},"repo":{"id":126571807,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY1NzE4MDc=","name":"fish-shell","full_name":"amiller27/fish-shell","private":false,"owner":{"login":"amiller27","id":4535296,"node_id":"MDQ6VXNlcjQ1MzUyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4535296?v=4","gravatar_id":"","url":"https://api.github.com/users/amiller27","html_url":"https://github.com/amiller27","followers_url":"https://api.github.com/users/amiller27/followers","following_url":"https://api.github.com/users/amiller27/following{/other_user}","gists_url":"https://api.github.com/users/amiller27/gists{/gist_id}","starred_url":"https://api.github.com/users/amiller27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiller27/subscriptions","organizations_url":"https://api.github.com/users/amiller27/orgs","repos_url":"https://api.github.com/users/amiller27/repos","events_url":"https://api.github.com/users/amiller27/events{/privacy}","received_events_url":"https://api.github.com/users/amiller27/received_events","type":"User","site_admin":false},"html_url":"https://github.com/amiller27/fish-shell","description":"The user-friendly command line shell.","fork":true,"url":"https://api.github.com/repos/amiller27/fish-shell","forks_url":"https://api.github.com/repos/amiller27/fish-shell/forks","keys_url":"https://api.github.com/repos/amiller27/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amiller27/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amiller27/fish-shell/teams","hooks_url":"https://api.github.com/repos/amiller27/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/amiller27/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/amiller27/fish-shell/events","assignees_url":"https://api.github.com/repos/amiller27/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/amiller27/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/amiller27/fish-shell/tags","blobs_url":"https://api.github.com/repos/amiller27/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amiller27/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amiller27/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/amiller27/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amiller27/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/amiller27/fish-shell/languages","stargazers_url":"https://api.github.com/repos/amiller27/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/amiller27/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/amiller27/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/amiller27/fish-shell/subscription","commits_url":"https://api.github.com/repos/amiller27/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/amiller27/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/amiller27/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/amiller27/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/amiller27/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/amiller27/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amiller27/fish-shell/merges","archive_url":"https://api.github.com/repos/amiller27/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amiller27/fish-shell/downloads","issues_url":"https://api.github.com/repos/amiller27/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/amiller27/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/amiller27/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/amiller27/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amiller27/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/amiller27/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/amiller27/fish-shell/deployments","created_at":"2018-03-24T06:16:53Z","updated_at":"2019-10-10T03:01:59Z","pushed_at":"2019-10-10T03:01:58Z","git_url":"git://github.com/amiller27/fish-shell.git","ssh_url":"git@github.com:amiller27/fish-shell.git","clone_url":"https://github.com/amiller27/fish-shell.git","svn_url":"https://github.com/amiller27/fish-shell","homepage":"http://fishshell.com","size":43127,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"055a332133687c4a6231f6adf961f49b4d1b6f60","user":{"login":"fish-shell","id":1828073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjgwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1828073?v=4","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":4279682,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5Njgy","name":"fish-shell","full_name":"fish-shell/fish-shell","private":false,"owner":{"login":"fish-shell","id":1828073,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MjgwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1828073?v=4","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fish-shell/fish-shell","description":"The user-friendly command line shell.","fork":false,"url":"https://api.github.com/repos/fish-shell/fish-shell","forks_url":"https://api.github.com/repos/fish-shell/fish-shell/forks","keys_url":"https://api.github.com/repos/fish-shell/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/fish-shell/teams","hooks_url":"https://api.github.com/repos/fish-shell/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/fish-shell/events","assignees_url":"https://api.github.com/repos/fish-shell/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/fish-shell/tags","blobs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/fish-shell/languages","stargazers_url":"https://api.github.com/repos/fish-shell/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/fish-shell/subscription","commits_url":"https://api.github.com/repos/fish-shell/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/fish-shell/merges","archive_url":"https://api.github.com/repos/fish-shell/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/fish-shell/downloads","issues_url":"https://api.github.com/repos/fish-shell/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/fish-shell/releases{/id}","deployments_url":"https://api.github.com/repos/fish-shell/fish-shell/deployments","created_at":"2012-05-10T03:00:55Z","updated_at":"2019-10-10T01:53:23Z","pushed_at":"2019-10-10T02:10:59Z","git_url":"git://github.com/fish-shell/fish-shell.git","ssh_url":"git@github.com:fish-shell/fish-shell.git","clone_url":"https://github.com/fish-shell/fish-shell.git","svn_url":"https://github.com/fish-shell/fish-shell","homepage":"http://fishshell.com","size":50037,"stargazers_count":13765,"watchers_count":13765,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1182,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":484,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1182,"open_issues":484,"watchers":13765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/6188"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/6188"},"issue":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/6188"},"comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/6188/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/6188/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/6188/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/fish-shell/statuses/68a7ff95234b9c157704738cc6235afc149b0b0c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":15,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"amiller27"}}