{"action":"created","comment":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/comments/280706270","pull_request_review_id":233378768,"id":280706270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDcwNjI3MA==","diff_hunk":"@@ -25,7 +26,9 @@ import Control.Monad.Extra\n -- | Run the assistant and exit.\n main :: IO ()\n main = displayErrors $ do\n-    env@Env{..} <- getDamlEnv\n+    rawArgs <- getArgs\n+    let isInstall = listToMaybe rawArgs == Just \"install\"","path":"daml-assistant/exe/DAML/Assistant.hs","position":14,"original_position":14,"commit_id":"a897efb630f77fb5d37d4fe312478c4a2f61a0aa","original_commit_id":"702f720ac8999d5112a09a6d0bbfcb462ea20a63","user":{"login":"neil-da","id":35463327,"node_id":"MDQ6VXNlcjM1NDYzMzI3","avatar_url":"https://avatars3.githubusercontent.com/u/35463327?v=4","gravatar_id":"","url":"https://api.github.com/users/neil-da","html_url":"https://github.com/neil-da","followers_url":"https://api.github.com/users/neil-da/followers","following_url":"https://api.github.com/users/neil-da/following{/other_user}","gists_url":"https://api.github.com/users/neil-da/gists{/gist_id}","starred_url":"https://api.github.com/users/neil-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neil-da/subscriptions","organizations_url":"https://api.github.com/users/neil-da/orgs","repos_url":"https://api.github.com/users/neil-da/repos","events_url":"https://api.github.com/users/neil-da/events{/privacy}","received_events_url":"https://api.github.com/users/neil-da/received_events","type":"User","site_admin":false},"body":"I struggle to believe there's not a command line you'll misparse if you write the parsing logic twice. But perhaps anyone who writes \"odd\" command lines deserves the pain. I leave it to you.","created_at":"2019-05-03T09:05:50Z","updated_at":"2019-05-03T09:05:50Z","html_url":"https://github.com/digital-asset/daml/pull/857#discussion_r280706270","pull_request_url":"https://api.github.com/repos/digital-asset/daml/pulls/857","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments/280706270"},"html":{"href":"https://github.com/digital-asset/daml/pull/857#discussion_r280706270"},"pull_request":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/857"}},"in_reply_to_id":280616048},"pull_request":{"url":"https://api.github.com/repos/digital-asset/daml/pulls/857","id":275412593,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NDEyNTkz","html_url":"https://github.com/digital-asset/daml/pull/857","diff_url":"https://github.com/digital-asset/daml/pull/857.diff","patch_url":"https://github.com/digital-asset/daml/pull/857.patch","issue_url":"https://api.github.com/repos/digital-asset/daml/issues/857","number":857,"state":"open","locked":false,"title":"Disable version nagging and avoid looking at unnecessary information in daml install.","user":{"login":"associahedron","id":231829,"node_id":"MDQ6VXNlcjIzMTgyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/231829?v=4","gravatar_id":"","url":"https://api.github.com/users/associahedron","html_url":"https://github.com/associahedron","followers_url":"https://api.github.com/users/associahedron/followers","following_url":"https://api.github.com/users/associahedron/following{/other_user}","gists_url":"https://api.github.com/users/associahedron/gists{/gist_id}","starred_url":"https://api.github.com/users/associahedron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/associahedron/subscriptions","organizations_url":"https://api.github.com/users/associahedron/orgs","repos_url":"https://api.github.com/users/associahedron/repos","events_url":"https://api.github.com/users/associahedron/events{/privacy}","received_events_url":"https://api.github.com/users/associahedron/received_events","type":"User","site_admin":false},"body":"- Don't display \"please install\" messages when already running daml install.\r\n    - In particular this prevents daml-sdk-head, get-daml.sh, and install.sh from getting these messages.\r\n- Don't fetch unnecessary project & sdk information when running daml install\r\n    - In particular this would have prevented daml install from failing prematurely in some cases\r\n    - This prevents daml install from auto-installing another SDK version!\r\n    - Additionally, this prevents the creation of a cache for storing the latest sdk version before daml is installed -- which wasn't really a problem but would have been pretty unintuitive behavior.\r\n","created_at":"2019-05-02T15:30:46Z","updated_at":"2019-05-03T09:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dbe49f71628a5edd5889f661b58102e45ef3872","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1322072744,"node_id":"MDU6TGFiZWwxMzIyMDcyNzQ0","url":"https://api.github.com/repos/digital-asset/daml/labels/automerge","name":"automerge","color":"ffd3b5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/digital-asset/daml/pulls/857/commits","review_comments_url":"https://api.github.com/repos/digital-asset/daml/pulls/857/comments","review_comment_url":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digital-asset/daml/issues/857/comments","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/a897efb630f77fb5d37d4fe312478c4a2f61a0aa","head":{"label":"digital-asset:daml-install-smarter","ref":"daml-install-smarter","sha":"a897efb630f77fb5d37d4fe312478c4a2f61a0aa","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-05-03T08:38:10Z","pushed_at":"2019-05-03T08:43:47Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"git@github.com:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":21539,"stargazers_count":131,"watchers_count":131,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":263,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":263,"watchers":131,"default_branch":"master"}},"base":{"label":"digital-asset:master","ref":"master","sha":"b081a8320f6ef1d86450a5d73d4a668178a9a0d7","user":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"repo":{"id":178222328,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyMjIzMjg=","name":"daml","full_name":"digital-asset/daml","private":false,"owner":{"login":"digital-asset","id":46327217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MzI3MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/46327217?v=4","gravatar_id":"","url":"https://api.github.com/users/digital-asset","html_url":"https://github.com/digital-asset","followers_url":"https://api.github.com/users/digital-asset/followers","following_url":"https://api.github.com/users/digital-asset/following{/other_user}","gists_url":"https://api.github.com/users/digital-asset/gists{/gist_id}","starred_url":"https://api.github.com/users/digital-asset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digital-asset/subscriptions","organizations_url":"https://api.github.com/users/digital-asset/orgs","repos_url":"https://api.github.com/users/digital-asset/repos","events_url":"https://api.github.com/users/digital-asset/events{/privacy}","received_events_url":"https://api.github.com/users/digital-asset/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digital-asset/daml","description":"The DAML smart contract language","fork":false,"url":"https://api.github.com/repos/digital-asset/daml","forks_url":"https://api.github.com/repos/digital-asset/daml/forks","keys_url":"https://api.github.com/repos/digital-asset/daml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digital-asset/daml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digital-asset/daml/teams","hooks_url":"https://api.github.com/repos/digital-asset/daml/hooks","issue_events_url":"https://api.github.com/repos/digital-asset/daml/issues/events{/number}","events_url":"https://api.github.com/repos/digital-asset/daml/events","assignees_url":"https://api.github.com/repos/digital-asset/daml/assignees{/user}","branches_url":"https://api.github.com/repos/digital-asset/daml/branches{/branch}","tags_url":"https://api.github.com/repos/digital-asset/daml/tags","blobs_url":"https://api.github.com/repos/digital-asset/daml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digital-asset/daml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digital-asset/daml/git/refs{/sha}","trees_url":"https://api.github.com/repos/digital-asset/daml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digital-asset/daml/statuses/{sha}","languages_url":"https://api.github.com/repos/digital-asset/daml/languages","stargazers_url":"https://api.github.com/repos/digital-asset/daml/stargazers","contributors_url":"https://api.github.com/repos/digital-asset/daml/contributors","subscribers_url":"https://api.github.com/repos/digital-asset/daml/subscribers","subscription_url":"https://api.github.com/repos/digital-asset/daml/subscription","commits_url":"https://api.github.com/repos/digital-asset/daml/commits{/sha}","git_commits_url":"https://api.github.com/repos/digital-asset/daml/git/commits{/sha}","comments_url":"https://api.github.com/repos/digital-asset/daml/comments{/number}","issue_comment_url":"https://api.github.com/repos/digital-asset/daml/issues/comments{/number}","contents_url":"https://api.github.com/repos/digital-asset/daml/contents/{+path}","compare_url":"https://api.github.com/repos/digital-asset/daml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digital-asset/daml/merges","archive_url":"https://api.github.com/repos/digital-asset/daml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digital-asset/daml/downloads","issues_url":"https://api.github.com/repos/digital-asset/daml/issues{/number}","pulls_url":"https://api.github.com/repos/digital-asset/daml/pulls{/number}","milestones_url":"https://api.github.com/repos/digital-asset/daml/milestones{/number}","notifications_url":"https://api.github.com/repos/digital-asset/daml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digital-asset/daml/labels{/name}","releases_url":"https://api.github.com/repos/digital-asset/daml/releases{/id}","deployments_url":"https://api.github.com/repos/digital-asset/daml/deployments","created_at":"2019-03-28T14:38:37Z","updated_at":"2019-05-03T08:38:10Z","pushed_at":"2019-05-03T08:43:47Z","git_url":"git://github.com/digital-asset/daml.git","ssh_url":"git@github.com:digital-asset/daml.git","clone_url":"https://github.com/digital-asset/daml.git","svn_url":"https://github.com/digital-asset/daml","homepage":"https://daml.com/","size":21539,"stargazers_count":131,"watchers_count":131,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":263,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":263,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/857"},"html":{"href":"https://github.com/digital-asset/daml/pull/857"},"issue":{"href":"https://api.github.com/repos/digital-asset/daml/issues/857"},"comments":{"href":"https://api.github.com/repos/digital-asset/daml/issues/857/comments"},"review_comments":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/857/comments"},"review_comment":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digital-asset/daml/pulls/857/commits"},"statuses":{"href":"https://api.github.com/repos/digital-asset/daml/statuses/a897efb630f77fb5d37d4fe312478c4a2f61a0aa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"neil-da"}}