{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34110","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34110/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34110/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34110/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34110","id":496031454,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5NDY2ODE2","number":34110,"title":"Krav Maga's Bone Breaker now targets all humanoids","user":{"login":"jeremyshannon","id":23157047,"node_id":"MDQ6VXNlcjIzMTU3MDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/23157047?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyshannon","html_url":"https://github.com/jeremyshannon","followers_url":"https://api.github.com/users/jeremyshannon/followers","following_url":"https://api.github.com/users/jeremyshannon/following{/other_user}","gists_url":"https://api.github.com/users/jeremyshannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyshannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyshannon/subscriptions","organizations_url":"https://api.github.com/users/jeremyshannon/orgs","repos_url":"https://api.github.com/users/jeremyshannon/repos","events_url":"https://api.github.com/users/jeremyshannon/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyshannon/received_events","type":"User","site_admin":false},"labels":[{"id":14965560,"node_id":"MDU6TGFiZWwxNDk2NTU2MA==","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/%3CEnhancement%20/%20Feature%3E","name":"<Enhancement / Feature>","color":"84b6eb","default":false},{"id":939519802,"node_id":"MDU6TGFiZWw5Mzk1MTk4MDI=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Melee","name":"Melee","color":"e237e8","default":false},{"id":659366627,"node_id":"MDU6TGFiZWw2NTkzNjY2Mjc=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[C++]","name":"[C++]","color":"f9d0c4","default":false},{"id":235869031,"node_id":"MDU6TGFiZWwyMzU4NjkwMzE=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[JSON]","name":"[JSON]","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2019-09-19T21:18:32Z","updated_at":"2019-09-20T21:25:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/34110","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34110","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34110.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34110.patch"},"body":"<!--\r\n### How to use\r\nLeave the headings unless they don't apply to your PR, replace commented out text (surrounded with <!–– and ––>) with text describing your PR.\r\nNOTE: Please grant permission for repository maintainers to edit your PR.\r\nIt is EXTREMELY common for PRs to be held up due to trivial changes being requested and the author being unavailable to make them.\r\n-->\r\n\r\n#### Summary\r\n<!--\r\nA one-line description of your change that will be extracted and added to the [project changelog](https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/changelog.txt).\r\n\r\nThe format is (ignore the square brackets): ```SUMMARY: [Category] \"[description]\"```\r\n\r\nThe categories to choose from are:\r\n\r\n* Features\r\n* Content\r\n* Interface\r\n* Mods\r\n* Balance\r\n* Bugfixes\r\n* Performance\r\n* Infrastructure\r\n* Build\r\n* I18N\r\n\r\nExample: ```SUMMARY: Content \"Adds new mutation category 'Mouse'\"```\r\n\r\nSee the [Changelog Guidelines](https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/CHANGELOG_GUIDELINES.md) for explanations of the categories.\r\n-->\r\nSUMMARY: Features \"Allow martial arts techniques to target humanoids\"\r\n\r\n#### Purpose of change\r\n<!--\r\nIf there's an existing issue describing the problem this PR addresses or the feature it adds, please link it like: ```#1234```\r\nIf it *fully* resolves an issue, link it like: ```Fixes #1234```\r\nEven if the issue describes the problem, please provide a few-sentence summary here.\r\nExample: ```Fixes #1234 - XL mutants cannot wear arm/leg splints due to missing OVERSIZE flag.```\r\nIf there is no related issue, please describe the issue you are addressing, including how to trigger a bug if this is a bugfix.\r\nDon't put the backticks around the `#` and issue or pull request number to allow the GitHub automatically reference to it.\r\n-->\r\n Add a JSON flag for human_target techniques, and add it to Krav Maga's Bone Breaker to replace the previous hack.\r\n\r\n#### Describe the solution\r\n<!--\r\nHow does the feature work, or how does this fix a bug?\r\nThe easier you make your solution to understand, the faster it can get merged.\r\n-->\r\nKrav Maga's Bone Breaker technique (from #33602) previously used an opponent's armed status as a hack to check whether it was humanoid, and unarmed humanoid opponents were just not targeted at all.\r\n This implements \"human_target\" as a new json flag, and techniques with this flag will not work unless the opponent has its species set to \"HUMAN\". This appears to be a reasonable approximation of \"is it human-shaped?\", or at least way better than just looking for a weapon.\r\n\r\n#### Describe alternatives you've considered\r\n<!--\r\nA clear and concise description of any alternative solutions or features you've considered.\r\n-->\r\n\r\n#### Additional context\r\n<!--\r\nAdd any other context (such as mock-ups, proof of concepts or screenshots) about the feature or bugfix here.\r\n-->\r\nI haven't audited the monster jsons so there might be something lurking in there that has species: human set and yet is not a reasonable target for a limb break, but I doubt it. I don't think zombie children have their species set to human, but going over the JSONs is more than I want to deal with today.\r\n Tested in-game, the Tough Zombie got Bone Breakered hard, while the Triffid just ate minor hits over and over."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/533713844","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/34110#issuecomment-533713844","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/34110","id":533713844,"node_id":"MDEyOklzc3VlQ29tbWVudDUzMzcxMzg0NA==","user":{"login":"Hymore246","id":11396600,"node_id":"MDQ6VXNlcjExMzk2NjAw","avatar_url":"https://avatars2.githubusercontent.com/u/11396600?v=4","gravatar_id":"","url":"https://api.github.com/users/Hymore246","html_url":"https://github.com/Hymore246","followers_url":"https://api.github.com/users/Hymore246/followers","following_url":"https://api.github.com/users/Hymore246/following{/other_user}","gists_url":"https://api.github.com/users/Hymore246/gists{/gist_id}","starred_url":"https://api.github.com/users/Hymore246/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hymore246/subscriptions","organizations_url":"https://api.github.com/users/Hymore246/orgs","repos_url":"https://api.github.com/users/Hymore246/repos","events_url":"https://api.github.com/users/Hymore246/events{/privacy}","received_events_url":"https://api.github.com/users/Hymore246/received_events","type":"User","site_admin":false},"created_at":"2019-09-20T21:25:29Z","updated_at":"2019-09-20T21:25:29Z","author_association":"CONTRIBUTOR","body":"To clear up a bit of confusion, I didn't call Bone Breaker a \"hack\" because it is a technique that is using the \"disarms\" attribute to check if the opponent has an arm to break. I did it because, it's a high powered disarming technique that is a \"hack\" because \"disarms\" attribute implies that the opponent has an arm to break. \r\n\r\nThe technique was originally designed to be an extremely strong disarm attack and as I mentioned [before](https://github.com/CleverRaven/Cataclysm-DDA/pull/33602#issuecomment-526186947), I am completely fine with changing Bone Breaker's name and description if it was causing confusion on why it was only usable on an armed opponent. I will need to update Bone Breaker to prevent game balance problems once this merged due to the removal of the \"disarms\" attribute.\r\n\r\nLastly, please update MARTIALART_JSON.md with the new \"human_target\" attribute."}}
{"actor":{"display_login":"Hymore246"}}