{"push_id":3544582214,"size":7,"distinct_size":7,"ref":"refs/heads/import-proposals-to-budgets-includes-scope","head":"2bee7c9a8786c432ad66fbacbb31db27fbeac7e3","before":"55403d56aec19660ca25fd4afe15a162b976ebc5","commits":[{"sha":"cf88f69071c9007f7b3f943dd8297e430dbb47b5","author":{"name":"Marc Riera","email":"3c9bde64bb112d4c0f8afc5002d385aadd32874e@gmail.com"},"message":"Fix step CTA button when base URL has params (#5082)\n\n* Fix step CTA button when base URL has params\r\n\r\n* Add changelog","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/cf88f69071c9007f7b3f943dd8297e430dbb47b5"},{"sha":"9d8b29bf577b6d88387919eec702e661ce20ab9d","author":{"name":"Antti Hukkanen","email":"1cf288b80902fb246320ae2ee16ddf564b78626e@mainiotech.fi"},"message":"Fix possible NoMethodErrors in the notification jobs (#5083)\n\n#### :tophat: What? Why?\r\nWe are receiving a lot of the following types of errors from the notification jobs in live instances where we are using Resque to process the jobs:\r\n\r\n```\r\nE, [2019-03-15T20:31:58.642308 #32702] ERROR -- : [ActiveJob] [Decidim::NotificationGeneratorJob] [12ab1234-12a3-12a3-ab1c-12ab3c4de567] Error performing Decidim::NotificationGeneratorJob (Job ID: 12ab1234-12a3-12a3-ab1c-12ab3c4de567) from Resque(decidim-production_events) in 1.82ms: NoMethodError (undefined method `constantize' for nil:NilClass):\r\n/path/to/shared/bundle/ruby/2.5.0/gems/decidim-core-0.16.1/app/jobs/decidim/notification_generator_job.rb:9:in `perform'\r\n...\r\n```\r\n\r\n```\r\nE, [2019-03-15T20:57:54.092382 #1697] ERROR -- : [ActiveJob] [Decidim::EmailNotificationGeneratorJob] [12ab1234-12a3-12a3-ab1c-12ab3c4de567] Error performing Decidim::EmailNotificationGeneratorJob (Job ID: 12ab1234-12a3-12a3-ab1c-12ab3c4de567) from Resque(decidim-production_events) in 2.62ms: NoMethodError (undefined method `constantize' for nil:NilClass):\r\n/path/to/shared/bundle/ruby/2.5.0/gems/decidim-core-0.16.1/app/jobs/decidim/email_notification_generator_job.rb:9:in `perform'\r\n```\r\n\r\nI have no idea what is causing these types of events because the log entries do not contain this information. This fixes at least the jobs that are currently causing a lot of unnecessary load for Resque as it has to write these to the logs. These are logged for each an every instance of the notifications which causes lots of entries e.g. when a notification is triggered for the whole user base (1 log entry * number of users). These log entries are then written very fast by resque to the log as it happens at the same time for the user.\r\n\r\nThe underlying reason still remains a mystery and would require more investigation.\r\n\r\n#### :clipboard: Subtasks\r\n- [x] Add `CHANGELOG` entry\r\n- [X] Add tests\r\n\r\nCo-authored-by: Marc Riera <mrc2407@gmail.com>","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/9d8b29bf577b6d88387919eec702e661ce20ab9d"},{"sha":"993cbe7595ee6a0f8da686d38514142418052d79","author":{"name":"decidim-bot","email":"2b262829097a92952b4ecd34b2103cb09d19471d@users.noreply.github.com"},"message":"New Crowdin translations (#5084)\n\nEnjoy!","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/993cbe7595ee6a0f8da686d38514142418052d79"},{"sha":"05ad6f0d8f713b6f2c2c6fdcec0f7505cc0bc78d","author":{"name":"Aitor Lopez Beltran","email":"f2c51984acbb2c84ad3ca3649e2951fb0b7a7400@coditramuntana.com"},"message":"Fix proposal participants metrics (#5048)\n\n* Fix participants metrics\r\n\r\n* Add CHANGELOG entry","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/05ad6f0d8f713b6f2c2c6fdcec0f7505cc0bc78d"},{"sha":"585a5ab201110c025eeed59cac81f05c671b3262","author":{"name":"Marc Riera","email":"3c9bde64bb112d4c0f8afc5002d385aadd32874e@gmail.com"},"message":"Add missing indexes (#5086)","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/585a5ab201110c025eeed59cac81f05c671b3262"},{"sha":"a29846eb785401a54bde989f270b306fe4b6f733","author":{"name":"Marc Riera","email":"3c9bde64bb112d4c0f8afc5002d385aadd32874e@gmail.com"},"message":"Sanitize user-inputted content (#5037)\n\n* Add helper to escape HTML\r\n\r\n* Escape HTML on proposal card titles\r\n\r\n* Strip tags on proposal card descriptions\r\n\r\n* Improve method naming\r\n\r\n* Sanitize events i18n options\r\n\r\n* Escape HTML tags from root commentable titles in new comment activity\r\n\r\n* Escape and strip content in new proposal activity\r\n\r\n* Fix event spec\r\n\r\n* Allow escaping HTML and stripping tags before rendering hashtags\r\n\r\n* Update test factories\r\n\r\n* Fix included proposals\r\n\r\n* Fix data picker\r\n\r\n* Fix in meetings\r\n\r\n* Fix spec\r\n\r\n* Fix event specs\r\n\r\n* Fix more specs\r\n\r\n* Fix open data exporter specs\r\n\r\n* Fix comment event spec\r\n\r\n* Fix sortitions specs\r\n\r\n* Fix proposal specs\r\n\r\n* Fix proposal specs\r\n\r\n* Fix proposal title on amendments\r\n\r\n* Escape titles on participatory texts and remove warnings\r\n\r\n* Ensure proposal bodies are properly cleaned up\r\n\r\n* Fix specs\r\n\r\n* Cleanup profiles \"About\" section\r\n\r\n* Fix comments specs\r\n\r\n* Test debates\r\n\r\n* Ensure everything's OK with other proposal types\r\n\r\n* Fixes for collaborative drafts\r\n\r\n* Remove apostrophes from user names","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/a29846eb785401a54bde989f270b306fe4b6f733"},{"sha":"2bee7c9a8786c432ad66fbacbb31db27fbeac7e3","author":{"name":"Pierre Mesure","email":"ebc13290ec3948ac802ca3936f3a31f02f4abcab@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master' into import-proposals-to-budgets-includes-scope","distinct":true,"url":"https://api.github.com/repos/PierreMesure/decidim/commits/2bee7c9a8786c432ad66fbacbb31db27fbeac7e3"}]}
{"actor":{"display_login":"PierreMesure"}}