{"action":"created","issue":{"url":"https://api.github.com/repos/ibm-openbmc/dev/issues/578","repository_url":"https://api.github.com/repos/ibm-openbmc/dev","labels_url":"https://api.github.com/repos/ibm-openbmc/dev/issues/578/labels{/name}","comments_url":"https://api.github.com/repos/ibm-openbmc/dev/issues/578/comments","events_url":"https://api.github.com/repos/ibm-openbmc/dev/issues/578/events","html_url":"https://github.com/ibm-openbmc/dev/issues/578","id":438496120,"node_id":"MDU6SXNzdWU0Mzg0OTYxMjA=","number":578,"title":"Make new D-Bus method for creating a Logging.Entry event log","user":{"login":"spinler","id":9370114,"node_id":"MDQ6VXNlcjkzNzAxMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9370114?v=4","gravatar_id":"","url":"https://api.github.com/users/spinler","html_url":"https://github.com/spinler","followers_url":"https://api.github.com/users/spinler/followers","following_url":"https://api.github.com/users/spinler/following{/other_user}","gists_url":"https://api.github.com/users/spinler/gists{/gist_id}","starred_url":"https://api.github.com/users/spinler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinler/subscriptions","organizations_url":"https://api.github.com/users/spinler/orgs","repos_url":"https://api.github.com/users/spinler/repos","events_url":"https://api.github.com/users/spinler/events{/privacy}","received_events_url":"https://api.github.com/users/spinler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"spinler","id":9370114,"node_id":"MDQ6VXNlcjkzNzAxMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9370114?v=4","gravatar_id":"","url":"https://api.github.com/users/spinler","html_url":"https://github.com/spinler","followers_url":"https://api.github.com/users/spinler/followers","following_url":"https://api.github.com/users/spinler/following{/other_user}","gists_url":"https://api.github.com/users/spinler/gists{/gist_id}","starred_url":"https://api.github.com/users/spinler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinler/subscriptions","organizations_url":"https://api.github.com/users/spinler/orgs","repos_url":"https://api.github.com/users/spinler/repos","events_url":"https://api.github.com/users/spinler/events{/privacy}","received_events_url":"https://api.github.com/users/spinler/received_events","type":"User","site_admin":false},"assignees":[{"login":"spinler","id":9370114,"node_id":"MDQ6VXNlcjkzNzAxMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9370114?v=4","gravatar_id":"","url":"https://api.github.com/users/spinler","html_url":"https://github.com/spinler","followers_url":"https://api.github.com/users/spinler/followers","following_url":"https://api.github.com/users/spinler/following{/other_user}","gists_url":"https://api.github.com/users/spinler/gists{/gist_id}","starred_url":"https://api.github.com/users/spinler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinler/subscriptions","organizations_url":"https://api.github.com/users/spinler/orgs","repos_url":"https://api.github.com/users/spinler/repos","events_url":"https://api.github.com/users/spinler/events{/privacy}","received_events_url":"https://api.github.com/users/spinler/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ibm-openbmc/dev/milestones/11","html_url":"https://github.com/ibm-openbmc/dev/milestone/11","labels_url":"https://api.github.com/repos/ibm-openbmc/dev/milestones/11/labels","id":3981600,"node_id":"MDk6TWlsZXN0b25lMzk4MTYwMA==","number":11,"title":"A.1.999","description":"","creator":{"login":"rfrandse","id":15894767,"node_id":"MDQ6VXNlcjE1ODk0NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/15894767?v=4","gravatar_id":"","url":"https://api.github.com/users/rfrandse","html_url":"https://github.com/rfrandse","followers_url":"https://api.github.com/users/rfrandse/followers","following_url":"https://api.github.com/users/rfrandse/following{/other_user}","gists_url":"https://api.github.com/users/rfrandse/gists{/gist_id}","starred_url":"https://api.github.com/users/rfrandse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfrandse/subscriptions","organizations_url":"https://api.github.com/users/rfrandse/orgs","repos_url":"https://api.github.com/users/rfrandse/repos","events_url":"https://api.github.com/users/rfrandse/events{/privacy}","received_events_url":"https://api.github.com/users/rfrandse/received_events","type":"User","site_admin":false},"open_issues":189,"closed_issues":20,"state":"open","created_at":"2019-01-17T15:32:46Z","updated_at":"2019-06-06T14:25:25Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2019-04-29T20:35:19Z","updated_at":"2019-06-09T13:19:40Z","closed_at":null,"author_association":"NONE","body":"If we just make a D-Bus method for creating a phosphor-logging event log and use that instead of the elog()/commit()/report() calls, it could simplify a lot of things:\r\n\r\n* Since all of the metadata would be passed into the method, the logging code wouldn't have to go digging around in the journal, which isn't the fastest.\r\n* There would be no need to include either elog-errors.hpp with the predefined metadata fields since they aren't used anymore, or the sdbusplus error header files, since there doesn't need to be an exception created.\r\n* The error doesn't need to be predefined in a YAML file anymore, for compile time processing by both sdbusplus and phosphor-logging, which can be a big headache when working in SDKs.\r\n* Since we don't need elog-errors.hpp, we don't have to worry about the compatibility problem of trying to have both that global header and a repo specific version of that header included by the same file.\r\n\r\nThe downsides are:\r\n* There are no compile time checks of what is passed into the error like before.\r\n* There is no concept of passing around that error like elog() could do by throwing an exception.\r\n* The logging code isn't able to use any predefined data at all, so the caller would have to pass in all of it, like the severity which it didn't have to before.\r\n* There is no place to have a description which was in the yaml before, which would show up in the journal.  (Note that our PEL message registry files would have this still)\r\n* These types of errors couldn't be returned from D-Bus method/property calls like they can be today.  However one could still just use the old method if that was desired.\r\n"},"comment":{"url":"https://api.github.com/repos/ibm-openbmc/dev/issues/comments/500211665","html_url":"https://github.com/ibm-openbmc/dev/issues/578#issuecomment-500211665","issue_url":"https://api.github.com/repos/ibm-openbmc/dev/issues/578","id":500211665,"node_id":"MDEyOklzc3VlQ29tbWVudDUwMDIxMTY2NQ==","user":{"login":"rfrandse","id":15894767,"node_id":"MDQ6VXNlcjE1ODk0NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/15894767?v=4","gravatar_id":"","url":"https://api.github.com/users/rfrandse","html_url":"https://github.com/rfrandse","followers_url":"https://api.github.com/users/rfrandse/followers","following_url":"https://api.github.com/users/rfrandse/following{/other_user}","gists_url":"https://api.github.com/users/rfrandse/gists{/gist_id}","starred_url":"https://api.github.com/users/rfrandse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfrandse/subscriptions","organizations_url":"https://api.github.com/users/rfrandse/orgs","repos_url":"https://api.github.com/users/rfrandse/repos","events_url":"https://api.github.com/users/rfrandse/events{/privacy}","received_events_url":"https://api.github.com/users/rfrandse/received_events","type":"User","site_admin":false},"created_at":"2019-06-09T13:19:40Z","updated_at":"2019-06-09T13:19:40Z","author_association":"NONE","body":"refresh"}}
{"actor":{"display_login":"rfrandse"}}