{"action":"created","comment":{"url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/comments/358202427","pull_request_review_id":332527753,"id":358202427,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODIwMjQyNw==","diff_hunk":"@@ -33,15 +32,10 @@ class BoltIcon extends withPreact() {\n     contrastColor: props.string,\n   };\n \n-  constructor(self) {\n-    self = super(self);\n-    this.useShadow = hasNativeShadowDomSupport;","path":"packages/components/bolt-icon/src/icon.standalone.js","position":14,"original_position":14,"commit_id":"39114591cee33bbf63082a54cbd0867896019dbb","original_commit_id":"39114591cee33bbf63082a54cbd0867896019dbb","user":{"login":"sghoweri","id":1617209,"node_id":"MDQ6VXNlcjE2MTcyMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1617209?v=4","gravatar_id":"","url":"https://api.github.com/users/sghoweri","html_url":"https://github.com/sghoweri","followers_url":"https://api.github.com/users/sghoweri/followers","following_url":"https://api.github.com/users/sghoweri/following{/other_user}","gists_url":"https://api.github.com/users/sghoweri/gists{/gist_id}","starred_url":"https://api.github.com/users/sghoweri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghoweri/subscriptions","organizations_url":"https://api.github.com/users/sghoweri/orgs","repos_url":"https://api.github.com/users/sghoweri/repos","events_url":"https://api.github.com/users/sghoweri/events{/privacy}","received_events_url":"https://api.github.com/users/sghoweri/received_events","type":"User","site_admin":false},"body":"Right - manually including `this.useShadow` is redundant (since our Base class provides this by default) _unless_ you are modifying the default behavior (ex. always disabling Shadow DOM or adding an extra condition in order to opt-in to Shadow DOM).","created_at":"2019-12-16T12:18:24Z","updated_at":"2019-12-16T12:18:25Z","html_url":"https://github.com/boltdesignsystem/bolt/pull/1585#discussion_r358202427","pull_request_url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/comments/358202427"},"html":{"href":"https://github.com/boltdesignsystem/bolt/pull/1585#discussion_r358202427"},"pull_request":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585"}},"in_reply_to_id":357767798},"pull_request":{"url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585","id":349062882,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ5MDYyODgy","html_url":"https://github.com/boltdesignsystem/bolt/pull/1585","diff_url":"https://github.com/boltdesignsystem/bolt/pull/1585.diff","patch_url":"https://github.com/boltdesignsystem/bolt/pull/1585.patch","issue_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues/1585","number":1585,"state":"open","locked":false,"title":"ES Modules: Internal Component Updates","user":{"login":"sghoweri","id":1617209,"node_id":"MDQ6VXNlcjE2MTcyMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1617209?v=4","gravatar_id":"","url":"https://api.github.com/users/sghoweri","html_url":"https://github.com/sghoweri","followers_url":"https://api.github.com/users/sghoweri/followers","following_url":"https://api.github.com/users/sghoweri/following{/other_user}","gists_url":"https://api.github.com/users/sghoweri/gists{/gist_id}","starred_url":"https://api.github.com/users/sghoweri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghoweri/subscriptions","organizations_url":"https://api.github.com/users/sghoweri/orgs","repos_url":"https://api.github.com/users/sghoweri/repos","events_url":"https://api.github.com/users/sghoweri/events{/privacy}","received_events_url":"https://api.github.com/users/sghoweri/received_events","type":"User","site_admin":false},"body":"## Jira\r\nN/A\r\n\r\n## Summary\r\nInternal web component updates that surfaced while working on https://github.com/boltdesignsystem/bolt/pull/1579.\r\n\r\n## Details\r\nThese updates are almost entirely comprised of fixing constructor / event lifecycle-related issues encountered while working and testing out the ES Module work.\r\n\r\n## How to test\r\n- Briefly review component changes\r\n- Confirm tests pass as expected","created_at":"2019-12-04T19:49:14Z","updated_at":"2019-12-16T12:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"231999fe630b3a28410b64fd669cc24001423496","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielamorse","id":36336,"node_id":"MDQ6VXNlcjM2MzM2","avatar_url":"https://avatars3.githubusercontent.com/u/36336?v=4","gravatar_id":"","url":"https://api.github.com/users/danielamorse","html_url":"https://github.com/danielamorse","followers_url":"https://api.github.com/users/danielamorse/followers","following_url":"https://api.github.com/users/danielamorse/following{/other_user}","gists_url":"https://api.github.com/users/danielamorse/gists{/gist_id}","starred_url":"https://api.github.com/users/danielamorse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielamorse/subscriptions","organizations_url":"https://api.github.com/users/danielamorse/orgs","repos_url":"https://api.github.com/users/danielamorse/repos","events_url":"https://api.github.com/users/danielamorse/events{/privacy}","received_events_url":"https://api.github.com/users/danielamorse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":626717659,"node_id":"MDU6TGFiZWw2MjY3MTc2NTk=","url":"https://api.github.com/repos/boltdesignsystem/bolt/labels/enhancement","name":"enhancement","color":"24c889","default":true,"description":"Increments the minor version when merged"},{"id":1692651619,"node_id":"MDU6TGFiZWwxNjkyNjUxNjE5","url":"https://api.github.com/repos/boltdesignsystem/bolt/labels/quick-review","name":"quick-review","color":"5831bc","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/boltdesignsystem/bolt/milestones/42","html_url":"https://github.com/boltdesignsystem/bolt/milestone/42","labels_url":"https://api.github.com/repos/boltdesignsystem/bolt/milestones/42/labels","id":4927880,"node_id":"MDk6TWlsZXN0b25lNDkyNzg4MA==","number":42,"title":"v2.14.0","description":"","creator":{"login":"sghoweri","id":1617209,"node_id":"MDQ6VXNlcjE2MTcyMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1617209?v=4","gravatar_id":"","url":"https://api.github.com/users/sghoweri","html_url":"https://github.com/sghoweri","followers_url":"https://api.github.com/users/sghoweri/followers","following_url":"https://api.github.com/users/sghoweri/following{/other_user}","gists_url":"https://api.github.com/users/sghoweri/gists{/gist_id}","starred_url":"https://api.github.com/users/sghoweri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghoweri/subscriptions","organizations_url":"https://api.github.com/users/sghoweri/orgs","repos_url":"https://api.github.com/users/sghoweri/repos","events_url":"https://api.github.com/users/sghoweri/events{/privacy}","received_events_url":"https://api.github.com/users/sghoweri/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":0,"state":"open","created_at":"2019-12-13T12:18:06Z","updated_at":"2019-12-16T12:14:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585/commits","review_comments_url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585/comments","review_comment_url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues/1585/comments","statuses_url":"https://api.github.com/repos/boltdesignsystem/bolt/statuses/39114591cee33bbf63082a54cbd0867896019dbb","head":{"label":"boltdesignsystem:feature/esmodule-support--component-updates","ref":"feature/esmodule-support--component-updates","sha":"39114591cee33bbf63082a54cbd0867896019dbb","user":{"login":"boltdesignsystem","id":26069445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDY5NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/26069445?v=4","gravatar_id":"","url":"https://api.github.com/users/boltdesignsystem","html_url":"https://github.com/boltdesignsystem","followers_url":"https://api.github.com/users/boltdesignsystem/followers","following_url":"https://api.github.com/users/boltdesignsystem/following{/other_user}","gists_url":"https://api.github.com/users/boltdesignsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/boltdesignsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boltdesignsystem/subscriptions","organizations_url":"https://api.github.com/users/boltdesignsystem/orgs","repos_url":"https://api.github.com/users/boltdesignsystem/repos","events_url":"https://api.github.com/users/boltdesignsystem/events{/privacy}","received_events_url":"https://api.github.com/users/boltdesignsystem/received_events","type":"Organization","site_admin":false},"repo":{"id":94353154,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM1MzE1NA==","name":"bolt","full_name":"boltdesignsystem/bolt","private":false,"owner":{"login":"boltdesignsystem","id":26069445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDY5NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/26069445?v=4","gravatar_id":"","url":"https://api.github.com/users/boltdesignsystem","html_url":"https://github.com/boltdesignsystem","followers_url":"https://api.github.com/users/boltdesignsystem/followers","following_url":"https://api.github.com/users/boltdesignsystem/following{/other_user}","gists_url":"https://api.github.com/users/boltdesignsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/boltdesignsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boltdesignsystem/subscriptions","organizations_url":"https://api.github.com/users/boltdesignsystem/orgs","repos_url":"https://api.github.com/users/boltdesignsystem/repos","events_url":"https://api.github.com/users/boltdesignsystem/events{/privacy}","received_events_url":"https://api.github.com/users/boltdesignsystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boltdesignsystem/bolt","description":"The Bolt Design System provides robust Twig and Web Component-powered UI components, reusable visual styles, and powerful tooling to help developers, designers, and content authors build, maintain, and scale best of class digital experiences.","fork":false,"url":"https://api.github.com/repos/boltdesignsystem/bolt","forks_url":"https://api.github.com/repos/boltdesignsystem/bolt/forks","keys_url":"https://api.github.com/repos/boltdesignsystem/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boltdesignsystem/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boltdesignsystem/bolt/teams","hooks_url":"https://api.github.com/repos/boltdesignsystem/bolt/hooks","issue_events_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/boltdesignsystem/bolt/events","assignees_url":"https://api.github.com/repos/boltdesignsystem/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/boltdesignsystem/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/boltdesignsystem/bolt/tags","blobs_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boltdesignsystem/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/boltdesignsystem/bolt/languages","stargazers_url":"https://api.github.com/repos/boltdesignsystem/bolt/stargazers","contributors_url":"https://api.github.com/repos/boltdesignsystem/bolt/contributors","subscribers_url":"https://api.github.com/repos/boltdesignsystem/bolt/subscribers","subscription_url":"https://api.github.com/repos/boltdesignsystem/bolt/subscription","commits_url":"https://api.github.com/repos/boltdesignsystem/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/boltdesignsystem/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/boltdesignsystem/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/boltdesignsystem/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boltdesignsystem/bolt/merges","archive_url":"https://api.github.com/repos/boltdesignsystem/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boltdesignsystem/bolt/downloads","issues_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/boltdesignsystem/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/boltdesignsystem/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boltdesignsystem/bolt/labels{/name}","releases_url":"https://api.github.com/repos/boltdesignsystem/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/boltdesignsystem/bolt/deployments","created_at":"2017-06-14T16:48:43Z","updated_at":"2019-12-13T21:20:27Z","pushed_at":"2019-12-16T12:13:25Z","git_url":"git://github.com/boltdesignsystem/bolt.git","ssh_url":"git@github.com:boltdesignsystem/bolt.git","clone_url":"https://github.com/boltdesignsystem/bolt.git","svn_url":"https://github.com/boltdesignsystem/bolt","homepage":"https://boltdesignsystem.com","size":545753,"stargazers_count":126,"watchers_count":126,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":76,"watchers":126,"default_branch":"master"}},"base":{"label":"boltdesignsystem:master","ref":"master","sha":"fcabd59d92661fc3b60c1a8740b7a8aebfce93df","user":{"login":"boltdesignsystem","id":26069445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDY5NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/26069445?v=4","gravatar_id":"","url":"https://api.github.com/users/boltdesignsystem","html_url":"https://github.com/boltdesignsystem","followers_url":"https://api.github.com/users/boltdesignsystem/followers","following_url":"https://api.github.com/users/boltdesignsystem/following{/other_user}","gists_url":"https://api.github.com/users/boltdesignsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/boltdesignsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boltdesignsystem/subscriptions","organizations_url":"https://api.github.com/users/boltdesignsystem/orgs","repos_url":"https://api.github.com/users/boltdesignsystem/repos","events_url":"https://api.github.com/users/boltdesignsystem/events{/privacy}","received_events_url":"https://api.github.com/users/boltdesignsystem/received_events","type":"Organization","site_admin":false},"repo":{"id":94353154,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM1MzE1NA==","name":"bolt","full_name":"boltdesignsystem/bolt","private":false,"owner":{"login":"boltdesignsystem","id":26069445,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDY5NDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/26069445?v=4","gravatar_id":"","url":"https://api.github.com/users/boltdesignsystem","html_url":"https://github.com/boltdesignsystem","followers_url":"https://api.github.com/users/boltdesignsystem/followers","following_url":"https://api.github.com/users/boltdesignsystem/following{/other_user}","gists_url":"https://api.github.com/users/boltdesignsystem/gists{/gist_id}","starred_url":"https://api.github.com/users/boltdesignsystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boltdesignsystem/subscriptions","organizations_url":"https://api.github.com/users/boltdesignsystem/orgs","repos_url":"https://api.github.com/users/boltdesignsystem/repos","events_url":"https://api.github.com/users/boltdesignsystem/events{/privacy}","received_events_url":"https://api.github.com/users/boltdesignsystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/boltdesignsystem/bolt","description":"The Bolt Design System provides robust Twig and Web Component-powered UI components, reusable visual styles, and powerful tooling to help developers, designers, and content authors build, maintain, and scale best of class digital experiences.","fork":false,"url":"https://api.github.com/repos/boltdesignsystem/bolt","forks_url":"https://api.github.com/repos/boltdesignsystem/bolt/forks","keys_url":"https://api.github.com/repos/boltdesignsystem/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boltdesignsystem/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boltdesignsystem/bolt/teams","hooks_url":"https://api.github.com/repos/boltdesignsystem/bolt/hooks","issue_events_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/boltdesignsystem/bolt/events","assignees_url":"https://api.github.com/repos/boltdesignsystem/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/boltdesignsystem/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/boltdesignsystem/bolt/tags","blobs_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boltdesignsystem/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/boltdesignsystem/bolt/languages","stargazers_url":"https://api.github.com/repos/boltdesignsystem/bolt/stargazers","contributors_url":"https://api.github.com/repos/boltdesignsystem/bolt/contributors","subscribers_url":"https://api.github.com/repos/boltdesignsystem/bolt/subscribers","subscription_url":"https://api.github.com/repos/boltdesignsystem/bolt/subscription","commits_url":"https://api.github.com/repos/boltdesignsystem/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/boltdesignsystem/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/boltdesignsystem/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/boltdesignsystem/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/boltdesignsystem/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boltdesignsystem/bolt/merges","archive_url":"https://api.github.com/repos/boltdesignsystem/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boltdesignsystem/bolt/downloads","issues_url":"https://api.github.com/repos/boltdesignsystem/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/boltdesignsystem/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/boltdesignsystem/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/boltdesignsystem/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boltdesignsystem/bolt/labels{/name}","releases_url":"https://api.github.com/repos/boltdesignsystem/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/boltdesignsystem/bolt/deployments","created_at":"2017-06-14T16:48:43Z","updated_at":"2019-12-13T21:20:27Z","pushed_at":"2019-12-16T12:13:25Z","git_url":"git://github.com/boltdesignsystem/bolt.git","ssh_url":"git@github.com:boltdesignsystem/bolt.git","clone_url":"https://github.com/boltdesignsystem/bolt.git","svn_url":"https://github.com/boltdesignsystem/bolt","homepage":"https://boltdesignsystem.com","size":545753,"stargazers_count":126,"watchers_count":126,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":76,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585"},"html":{"href":"https://github.com/boltdesignsystem/bolt/pull/1585"},"issue":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/issues/1585"},"comments":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/issues/1585/comments"},"review_comments":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585/comments"},"review_comment":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/pulls/1585/commits"},"statuses":{"href":"https://api.github.com/repos/boltdesignsystem/bolt/statuses/39114591cee33bbf63082a54cbd0867896019dbb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sghoweri"}}