{"action":"closed","number":30748,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/30748","id":298056898,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4MDU2ODk4","html_url":"https://github.com/qgis/QGIS/pull/30748","diff_url":"https://github.com/qgis/QGIS/pull/30748.diff","patch_url":"https://github.com/qgis/QGIS/pull/30748.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/30748","number":30748,"state":"closed","locked":false,"title":"Fix addEntry for reference relation widget ","user":{"login":"troopa81","id":14358135,"node_id":"MDQ6VXNlcjE0MzU4MTM1","avatar_url":"https://avatars2.githubusercontent.com/u/14358135?v=4","gravatar_id":"","url":"https://api.github.com/users/troopa81","html_url":"https://github.com/troopa81","followers_url":"https://api.github.com/users/troopa81/followers","following_url":"https://api.github.com/users/troopa81/following{/other_user}","gists_url":"https://api.github.com/users/troopa81/gists{/gist_id}","starred_url":"https://api.github.com/users/troopa81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troopa81/subscriptions","organizations_url":"https://api.github.com/users/troopa81/orgs","repos_url":"https://api.github.com/users/troopa81/repos","events_url":"https://api.github.com/users/troopa81/events{/privacy}","received_events_url":"https://api.github.com/users/troopa81/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nWhen adding an entry from the reference relation widget, the widget was using the referencing field index and not the referenced one, so it fails to update correctly the combo box after the form pop up. \r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and contain sufficient information in the commit message to be documented\r\n- [x] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [x] New unit tests have been added for core changes\r\n- [x] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTING.md#contributing-to-qgis) before each commit\r\n","created_at":"2019-07-16T14:03:07Z","updated_at":"2019-07-19T05:08:12Z","closed_at":"2019-07-19T05:08:12Z","merged_at":"2019-07-19T05:08:12Z","merge_commit_sha":"b1e5eb09cf02746384fa0f3468d312ca0db4ae88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1375312689,"node_id":"MDU6TGFiZWwxMzc1MzEyNjg5","url":"https://api.github.com/repos/qgis/QGIS/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":1256912472,"node_id":"MDU6TGFiZWwxMjU2OTEyNDcy","url":"https://api.github.com/repos/qgis/QGIS/labels/backport%20release-3_4","name":"backport release-3_4","color":"006b75","default":false},{"id":1416832534,"node_id":"MDU6TGFiZWwxNDE2ODMyNTM0","url":"https://api.github.com/repos/qgis/QGIS/labels/backport%20release-3_8","name":"backport release-3_8","color":"e0cf5e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/30748/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/30748/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/30748/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/4ee2a53d91984939d6dee73459ce8bdef39cc89c","head":{"label":"troopa81:fix_referencerelationwidget_addEntry","ref":"fix_referencerelationwidget_addEntry","sha":"4ee2a53d91984939d6dee73459ce8bdef39cc89c","user":{"login":"troopa81","id":14358135,"node_id":"MDQ6VXNlcjE0MzU4MTM1","avatar_url":"https://avatars2.githubusercontent.com/u/14358135?v=4","gravatar_id":"","url":"https://api.github.com/users/troopa81","html_url":"https://github.com/troopa81","followers_url":"https://api.github.com/users/troopa81/followers","following_url":"https://api.github.com/users/troopa81/following{/other_user}","gists_url":"https://api.github.com/users/troopa81/gists{/gist_id}","starred_url":"https://api.github.com/users/troopa81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troopa81/subscriptions","organizations_url":"https://api.github.com/users/troopa81/orgs","repos_url":"https://api.github.com/users/troopa81/repos","events_url":"https://api.github.com/users/troopa81/events{/privacy}","received_events_url":"https://api.github.com/users/troopa81/received_events","type":"User","site_admin":false},"repo":{"id":150235176,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyMzUxNzY=","name":"QGIS","full_name":"troopa81/QGIS","private":false,"owner":{"login":"troopa81","id":14358135,"node_id":"MDQ6VXNlcjE0MzU4MTM1","avatar_url":"https://avatars2.githubusercontent.com/u/14358135?v=4","gravatar_id":"","url":"https://api.github.com/users/troopa81","html_url":"https://github.com/troopa81","followers_url":"https://api.github.com/users/troopa81/followers","following_url":"https://api.github.com/users/troopa81/following{/other_user}","gists_url":"https://api.github.com/users/troopa81/gists{/gist_id}","starred_url":"https://api.github.com/users/troopa81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troopa81/subscriptions","organizations_url":"https://api.github.com/users/troopa81/orgs","repos_url":"https://api.github.com/users/troopa81/repos","events_url":"https://api.github.com/users/troopa81/events{/privacy}","received_events_url":"https://api.github.com/users/troopa81/received_events","type":"User","site_admin":false},"html_url":"https://github.com/troopa81/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/troopa81/QGIS","forks_url":"https://api.github.com/repos/troopa81/QGIS/forks","keys_url":"https://api.github.com/repos/troopa81/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troopa81/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troopa81/QGIS/teams","hooks_url":"https://api.github.com/repos/troopa81/QGIS/hooks","issue_events_url":"https://api.github.com/repos/troopa81/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/troopa81/QGIS/events","assignees_url":"https://api.github.com/repos/troopa81/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/troopa81/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/troopa81/QGIS/tags","blobs_url":"https://api.github.com/repos/troopa81/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troopa81/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troopa81/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/troopa81/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troopa81/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/troopa81/QGIS/languages","stargazers_url":"https://api.github.com/repos/troopa81/QGIS/stargazers","contributors_url":"https://api.github.com/repos/troopa81/QGIS/contributors","subscribers_url":"https://api.github.com/repos/troopa81/QGIS/subscribers","subscription_url":"https://api.github.com/repos/troopa81/QGIS/subscription","commits_url":"https://api.github.com/repos/troopa81/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/troopa81/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/troopa81/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/troopa81/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/troopa81/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/troopa81/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troopa81/QGIS/merges","archive_url":"https://api.github.com/repos/troopa81/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troopa81/QGIS/downloads","issues_url":"https://api.github.com/repos/troopa81/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/troopa81/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/troopa81/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/troopa81/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troopa81/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/troopa81/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/troopa81/QGIS/deployments","created_at":"2018-09-25T08:53:06Z","updated_at":"2019-07-11T07:51:08Z","pushed_at":"2019-07-18T12:56:44Z","git_url":"git://github.com/troopa81/QGIS.git","ssh_url":"git@github.com:troopa81/QGIS.git","clone_url":"https://github.com/troopa81/QGIS.git","svn_url":"https://github.com/troopa81/QGIS","homepage":"http://qgis.org","size":1559047,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"1e4114a6341da4097657ad0ff175d1d71da259ae","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","private":false,"owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2019-07-19T03:39:17Z","pushed_at":"2019-07-19T05:08:12Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1562356,"stargazers_count":2836,"watchers_count":2836,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1526,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3161,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1526,"open_issues":3161,"watchers":2836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/30748"},"html":{"href":"https://github.com/qgis/QGIS/pull/30748"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/30748"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/30748/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/30748/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/30748/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/4ee2a53d91984939d6dee73459ce8bdef39cc89c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":46,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"m-kuhn"}}