{"action":"closed","number":169,"pull_request":{"url":"https://api.github.com/repos/SeisSol/SeisSol/pulls/169","id":345264530,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1MjY0NTMw","html_url":"https://github.com/SeisSol/SeisSol/pull/169","diff_url":"https://github.com/SeisSol/SeisSol/pull/169.diff","patch_url":"https://github.com/SeisSol/SeisSol/pull/169.patch","issue_url":"https://api.github.com/repos/SeisSol/SeisSol/issues/169","number":169,"state":"closed","locked":false,"title":"Implement elastic-acoustic coupling","user":{"login":"krenzland","id":1886744,"node_id":"MDQ6VXNlcjE4ODY3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1886744?v=4","gravatar_id":"","url":"https://api.github.com/users/krenzland","html_url":"https://github.com/krenzland","followers_url":"https://api.github.com/users/krenzland/followers","following_url":"https://api.github.com/users/krenzland/following{/other_user}","gists_url":"https://api.github.com/users/krenzland/gists{/gist_id}","starred_url":"https://api.github.com/users/krenzland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krenzland/subscriptions","organizations_url":"https://api.github.com/users/krenzland/orgs","repos_url":"https://api.github.com/users/krenzland/repos","events_url":"https://api.github.com/users/krenzland/events{/privacy}","received_events_url":"https://api.github.com/users/krenzland/received_events","type":"User","site_admin":false},"body":"This pull request includes:\r\n\r\n- Support for acoustic materials (mu=0)\r\n- Support for coupling between elastic and acoustic materials with an exact Riemann solver (modified implementation of Carsten's hack)\r\n- Three new boundary condition types: a free surface with gravitation for the acoustic equation, an analytical boundary condition (initial condition/analytical solution is imposed at boundary) and a user-configurable boundary condition (with easi)\r\n- Two test cases for elastic-acoustic coupling (a Scholte wave and a version of Snell's law), using the analytical boundary condition type\r\n- A test case for the free-surface with gravity boundary condition and the user-defined bc, due to Lauren.\r\n- Some small changes (improvements?) to some related parts of the code\r\n\r\nThe user-configurable boundary condition is currently not documented as I'm currently evaluating, whether it actually makes sense to use it. It allows users to define all boundary conditions that use a state at a fictitious ghost cell that can be expressed as a linear affine mapping of the values of the interior.\r\nFor example, to impose a free-slip boundary condition with normal velocity = 1, a user defines:\r\n\r\n```yaml\r\n!ConstantMap\r\n    map:\r\n      map_u_u: -1.0\r\n      const_u: 1\r\n```\r\nThe user then adds the line\r\n```fortran\r\n&Equations\r\nBoundaryFileName = 'boundary.yaml'\r\n```\r\nto the parameter file.\r\n\r\nThere are still some TODOs that are related to performance optimizations - I'll perform those later. The important thing is that for now all new scenarios (seem to) work.\r\nI am going to push the Maple notebooks related to the new matrices and some meshes and settings for the new scenarios in separate commits/pull request to the relevant repos soon.\r\n\r\nThe performance of the kernels shouldn't be slower with my updates. To check this, I've ran the proxy on NG for elastic order 6 with 100k elements and got ~1750 HW flops, which aligns with Carsten's results.","created_at":"2019-11-25T15:05:26Z","updated_at":"2019-11-29T12:26:44Z","closed_at":"2019-11-29T12:26:44Z","merged_at":"2019-11-29T12:26:44Z","merge_commit_sha":"b5537605c935915bf4b2be570cab31e57fa8ede6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":111329586,"node_id":"MDU6TGFiZWwxMTEzMjk1ODY=","url":"https://api.github.com/repos/SeisSol/SeisSol/labels/enhancement","name":"enhancement","color":"84b6eb","default":true,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/SeisSol/SeisSol/pulls/169/commits","review_comments_url":"https://api.github.com/repos/SeisSol/SeisSol/pulls/169/comments","review_comment_url":"https://api.github.com/repos/SeisSol/SeisSol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeisSol/SeisSol/issues/169/comments","statuses_url":"https://api.github.com/repos/SeisSol/SeisSol/statuses/337581ff7c2eb897bf85021cbc12870775c5dd6a","head":{"label":"SeisSol:lukas/elastic-acoustic-bc","ref":"lukas/elastic-acoustic-bc","sha":"337581ff7c2eb897bf85021cbc12870775c5dd6a","user":{"login":"SeisSol","id":8057643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNTc2NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8057643?v=4","gravatar_id":"","url":"https://api.github.com/users/SeisSol","html_url":"https://github.com/SeisSol","followers_url":"https://api.github.com/users/SeisSol/followers","following_url":"https://api.github.com/users/SeisSol/following{/other_user}","gists_url":"https://api.github.com/users/SeisSol/gists{/gist_id}","starred_url":"https://api.github.com/users/SeisSol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeisSol/subscriptions","organizations_url":"https://api.github.com/users/SeisSol/orgs","repos_url":"https://api.github.com/users/SeisSol/repos","events_url":"https://api.github.com/users/SeisSol/events{/privacy}","received_events_url":"https://api.github.com/users/SeisSol/received_events","type":"Organization","site_admin":false},"repo":{"id":21459883,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQ1OTg4Mw==","name":"SeisSol","full_name":"SeisSol/SeisSol","private":false,"owner":{"login":"SeisSol","id":8057643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNTc2NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8057643?v=4","gravatar_id":"","url":"https://api.github.com/users/SeisSol","html_url":"https://github.com/SeisSol","followers_url":"https://api.github.com/users/SeisSol/followers","following_url":"https://api.github.com/users/SeisSol/following{/other_user}","gists_url":"https://api.github.com/users/SeisSol/gists{/gist_id}","starred_url":"https://api.github.com/users/SeisSol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeisSol/subscriptions","organizations_url":"https://api.github.com/users/SeisSol/orgs","repos_url":"https://api.github.com/users/SeisSol/repos","events_url":"https://api.github.com/users/SeisSol/events{/privacy}","received_events_url":"https://api.github.com/users/SeisSol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SeisSol/SeisSol","description":"a scientific software for the numerical simulation of seismic wave phenomena and earthquake dynamics","fork":false,"url":"https://api.github.com/repos/SeisSol/SeisSol","forks_url":"https://api.github.com/repos/SeisSol/SeisSol/forks","keys_url":"https://api.github.com/repos/SeisSol/SeisSol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeisSol/SeisSol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeisSol/SeisSol/teams","hooks_url":"https://api.github.com/repos/SeisSol/SeisSol/hooks","issue_events_url":"https://api.github.com/repos/SeisSol/SeisSol/issues/events{/number}","events_url":"https://api.github.com/repos/SeisSol/SeisSol/events","assignees_url":"https://api.github.com/repos/SeisSol/SeisSol/assignees{/user}","branches_url":"https://api.github.com/repos/SeisSol/SeisSol/branches{/branch}","tags_url":"https://api.github.com/repos/SeisSol/SeisSol/tags","blobs_url":"https://api.github.com/repos/SeisSol/SeisSol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeisSol/SeisSol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeisSol/SeisSol/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeisSol/SeisSol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeisSol/SeisSol/statuses/{sha}","languages_url":"https://api.github.com/repos/SeisSol/SeisSol/languages","stargazers_url":"https://api.github.com/repos/SeisSol/SeisSol/stargazers","contributors_url":"https://api.github.com/repos/SeisSol/SeisSol/contributors","subscribers_url":"https://api.github.com/repos/SeisSol/SeisSol/subscribers","subscription_url":"https://api.github.com/repos/SeisSol/SeisSol/subscription","commits_url":"https://api.github.com/repos/SeisSol/SeisSol/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeisSol/SeisSol/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeisSol/SeisSol/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeisSol/SeisSol/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeisSol/SeisSol/contents/{+path}","compare_url":"https://api.github.com/repos/SeisSol/SeisSol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeisSol/SeisSol/merges","archive_url":"https://api.github.com/repos/SeisSol/SeisSol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeisSol/SeisSol/downloads","issues_url":"https://api.github.com/repos/SeisSol/SeisSol/issues{/number}","pulls_url":"https://api.github.com/repos/SeisSol/SeisSol/pulls{/number}","milestones_url":"https://api.github.com/repos/SeisSol/SeisSol/milestones{/number}","notifications_url":"https://api.github.com/repos/SeisSol/SeisSol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeisSol/SeisSol/labels{/name}","releases_url":"https://api.github.com/repos/SeisSol/SeisSol/releases{/id}","deployments_url":"https://api.github.com/repos/SeisSol/SeisSol/deployments","created_at":"2014-07-03T11:17:47Z","updated_at":"2019-11-28T08:49:07Z","pushed_at":"2019-11-29T12:26:44Z","git_url":"git://github.com/SeisSol/SeisSol.git","ssh_url":"git@github.com:SeisSol/SeisSol.git","clone_url":"https://github.com/SeisSol/SeisSol.git","svn_url":"https://github.com/SeisSol/SeisSol","homepage":"http://www.seissol.org","size":83652,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":46,"open_issues":28,"watchers":84,"default_branch":"master"}},"base":{"label":"SeisSol:master","ref":"master","sha":"fb7e4bef2a8aacad8a8e94ea23dee4742e0b6617","user":{"login":"SeisSol","id":8057643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNTc2NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8057643?v=4","gravatar_id":"","url":"https://api.github.com/users/SeisSol","html_url":"https://github.com/SeisSol","followers_url":"https://api.github.com/users/SeisSol/followers","following_url":"https://api.github.com/users/SeisSol/following{/other_user}","gists_url":"https://api.github.com/users/SeisSol/gists{/gist_id}","starred_url":"https://api.github.com/users/SeisSol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeisSol/subscriptions","organizations_url":"https://api.github.com/users/SeisSol/orgs","repos_url":"https://api.github.com/users/SeisSol/repos","events_url":"https://api.github.com/users/SeisSol/events{/privacy}","received_events_url":"https://api.github.com/users/SeisSol/received_events","type":"Organization","site_admin":false},"repo":{"id":21459883,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQ1OTg4Mw==","name":"SeisSol","full_name":"SeisSol/SeisSol","private":false,"owner":{"login":"SeisSol","id":8057643,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNTc2NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8057643?v=4","gravatar_id":"","url":"https://api.github.com/users/SeisSol","html_url":"https://github.com/SeisSol","followers_url":"https://api.github.com/users/SeisSol/followers","following_url":"https://api.github.com/users/SeisSol/following{/other_user}","gists_url":"https://api.github.com/users/SeisSol/gists{/gist_id}","starred_url":"https://api.github.com/users/SeisSol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeisSol/subscriptions","organizations_url":"https://api.github.com/users/SeisSol/orgs","repos_url":"https://api.github.com/users/SeisSol/repos","events_url":"https://api.github.com/users/SeisSol/events{/privacy}","received_events_url":"https://api.github.com/users/SeisSol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SeisSol/SeisSol","description":"a scientific software for the numerical simulation of seismic wave phenomena and earthquake dynamics","fork":false,"url":"https://api.github.com/repos/SeisSol/SeisSol","forks_url":"https://api.github.com/repos/SeisSol/SeisSol/forks","keys_url":"https://api.github.com/repos/SeisSol/SeisSol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeisSol/SeisSol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeisSol/SeisSol/teams","hooks_url":"https://api.github.com/repos/SeisSol/SeisSol/hooks","issue_events_url":"https://api.github.com/repos/SeisSol/SeisSol/issues/events{/number}","events_url":"https://api.github.com/repos/SeisSol/SeisSol/events","assignees_url":"https://api.github.com/repos/SeisSol/SeisSol/assignees{/user}","branches_url":"https://api.github.com/repos/SeisSol/SeisSol/branches{/branch}","tags_url":"https://api.github.com/repos/SeisSol/SeisSol/tags","blobs_url":"https://api.github.com/repos/SeisSol/SeisSol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeisSol/SeisSol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeisSol/SeisSol/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeisSol/SeisSol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeisSol/SeisSol/statuses/{sha}","languages_url":"https://api.github.com/repos/SeisSol/SeisSol/languages","stargazers_url":"https://api.github.com/repos/SeisSol/SeisSol/stargazers","contributors_url":"https://api.github.com/repos/SeisSol/SeisSol/contributors","subscribers_url":"https://api.github.com/repos/SeisSol/SeisSol/subscribers","subscription_url":"https://api.github.com/repos/SeisSol/SeisSol/subscription","commits_url":"https://api.github.com/repos/SeisSol/SeisSol/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeisSol/SeisSol/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeisSol/SeisSol/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeisSol/SeisSol/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeisSol/SeisSol/contents/{+path}","compare_url":"https://api.github.com/repos/SeisSol/SeisSol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeisSol/SeisSol/merges","archive_url":"https://api.github.com/repos/SeisSol/SeisSol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeisSol/SeisSol/downloads","issues_url":"https://api.github.com/repos/SeisSol/SeisSol/issues{/number}","pulls_url":"https://api.github.com/repos/SeisSol/SeisSol/pulls{/number}","milestones_url":"https://api.github.com/repos/SeisSol/SeisSol/milestones{/number}","notifications_url":"https://api.github.com/repos/SeisSol/SeisSol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeisSol/SeisSol/labels{/name}","releases_url":"https://api.github.com/repos/SeisSol/SeisSol/releases{/id}","deployments_url":"https://api.github.com/repos/SeisSol/SeisSol/deployments","created_at":"2014-07-03T11:17:47Z","updated_at":"2019-11-28T08:49:07Z","pushed_at":"2019-11-29T12:26:44Z","git_url":"git://github.com/SeisSol/SeisSol.git","ssh_url":"git@github.com:SeisSol/SeisSol.git","clone_url":"https://github.com/SeisSol/SeisSol.git","svn_url":"https://github.com/SeisSol/SeisSol","homepage":"http://www.seissol.org","size":83652,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":46,"open_issues":28,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeisSol/SeisSol/pulls/169"},"html":{"href":"https://github.com/SeisSol/SeisSol/pull/169"},"issue":{"href":"https://api.github.com/repos/SeisSol/SeisSol/issues/169"},"comments":{"href":"https://api.github.com/repos/SeisSol/SeisSol/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/SeisSol/SeisSol/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/SeisSol/SeisSol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeisSol/SeisSol/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/SeisSol/SeisSol/statuses/337581ff7c2eb897bf85021cbc12870775c5dd6a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"krenzland","id":1886744,"node_id":"MDQ6VXNlcjE4ODY3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1886744?v=4","gravatar_id":"","url":"https://api.github.com/users/krenzland","html_url":"https://github.com/krenzland","followers_url":"https://api.github.com/users/krenzland/followers","following_url":"https://api.github.com/users/krenzland/following{/other_user}","gists_url":"https://api.github.com/users/krenzland/gists{/gist_id}","starred_url":"https://api.github.com/users/krenzland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krenzland/subscriptions","organizations_url":"https://api.github.com/users/krenzland/orgs","repos_url":"https://api.github.com/users/krenzland/repos","events_url":"https://api.github.com/users/krenzland/events{/privacy}","received_events_url":"https://api.github.com/users/krenzland/received_events","type":"User","site_admin":false},"comments":0,"review_comments":18,"maintainer_can_modify":false,"commits":66,"additions":2214,"deletions":684,"changed_files":84}}
{"actor":{"display_login":"krenzland"}}