{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/14682","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/14682/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/14682/comments","events_url":"https://api.github.com/repos/python/cpython/issues/14682/events","html_url":"https://github.com/python/cpython/pull/14682","id":466227421,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MTA3NTA2","number":14682,"title":"bpo-37540: vectorcall: keyword names must be strings","user":{"login":"jdemeyer","id":3625785,"node_id":"MDQ6VXNlcjM2MjU3ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3625785?v=4","gravatar_id":"","url":"https://api.github.com/users/jdemeyer","html_url":"https://github.com/jdemeyer","followers_url":"https://api.github.com/users/jdemeyer/followers","following_url":"https://api.github.com/users/jdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemeyer/orgs","repos_url":"https://api.github.com/users/jdemeyer/repos","events_url":"https://api.github.com/users/jdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemeyer/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"node_id":"MDU6TGFiZWw2NjY5Nzk4MjE=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-07-10T10:22:19Z","updated_at":"2019-07-15T08:36:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/14682","html_url":"https://github.com/python/cpython/pull/14682","diff_url":"https://github.com/python/cpython/pull/14682.diff","patch_url":"https://github.com/python/cpython/pull/14682.patch"},"body":"The fact that keyword names are strings is now part of the vectorcall and `METH_FASTCALL` protocols. The biggest concrete change is that `_PyStack_UnpackDict` now checks that and raises `TypeError` if not.\r\n\r\nCC @markshannon @vstinner \n\n<!-- issue-number: [bpo-37540](https://bugs.python.org/issue37540) -->\nhttps://bugs.python.org/issue37540\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/511317107","html_url":"https://github.com/python/cpython/pull/14682#issuecomment-511317107","issue_url":"https://api.github.com/repos/python/cpython/issues/14682","id":511317107,"node_id":"MDEyOklzc3VlQ29tbWVudDUxMTMxNzEwNw==","user":{"login":"jdemeyer","id":3625785,"node_id":"MDQ6VXNlcjM2MjU3ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/3625785?v=4","gravatar_id":"","url":"https://api.github.com/users/jdemeyer","html_url":"https://github.com/jdemeyer","followers_url":"https://api.github.com/users/jdemeyer/followers","following_url":"https://api.github.com/users/jdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemeyer/orgs","repos_url":"https://api.github.com/users/jdemeyer/repos","events_url":"https://api.github.com/users/jdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemeyer/received_events","type":"User","site_admin":false},"created_at":"2019-07-15T08:36:20Z","updated_at":"2019-07-15T08:36:20Z","author_association":"CONTRIBUTOR","body":"There are many instances in the documentation (unrelated to vectorcall) where the word \"string\" is used. I don't see the problem here.\r\n\r\nConcrete proposal: we leave this doc as is and I will reboot #13844 (I always planned to do that, but *after* all other PRs that affect documentation). In the section describing the \"vectorcall protocol\", I will say explicitly what \"string\" means for vectorcall."}}
{"actor":{"display_login":"jdemeyer"}}