{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/265587508","pull_request_review_id":214533244,"id":265587508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTU4NzUwOA==","diff_hunk":"@@ -141,6 +141,26 @@\n                 <protocol type=\"MFC\" />\n                 <protocol type=\"FRAG3\" />\n             </stack>\n+            <stack name=\"dns-ping\">\n+                <transport type=\"TCP\" socket-binding=\"jgroups-tcp\">\n+                    <property name=\"logical_addr_cache_expiration\">360000</property>\n+                </transport>\n+                <protocol type=\"dns.DNS_PING\">\n+                    <property name=\"dns_query\">${jgroups.dns_ping.dns_query:example-infinispan-ping.default.svc.cluster.local}</property>","path":"server/integration/jgroups/src/main/resources/subsystem-templates/cloud-jgroups.xml","position":9,"original_position":9,"commit_id":"465082f73afe428ff636f7ebe68b14c75c7e18a0","original_commit_id":"465082f73afe428ff636f7ebe68b14c75c7e18a0","user":{"login":"galderz","id":50187,"node_id":"MDQ6VXNlcjUwMTg3","avatar_url":"https://avatars0.githubusercontent.com/u/50187?v=4","gravatar_id":"","url":"https://api.github.com/users/galderz","html_url":"https://github.com/galderz","followers_url":"https://api.github.com/users/galderz/followers","following_url":"https://api.github.com/users/galderz/following{/other_user}","gists_url":"https://api.github.com/users/galderz/gists{/gist_id}","starred_url":"https://api.github.com/users/galderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galderz/subscriptions","organizations_url":"https://api.github.com/users/galderz/orgs","repos_url":"https://api.github.com/users/galderz/repos","events_url":"https://api.github.com/users/galderz/events{/privacy}","received_events_url":"https://api.github.com/users/galderz/received_events","type":"User","site_admin":false},"body":"I would not give this a default value, I'd just define it as: `${jgroups.dns_ping.dns_query:}`, because there's no valid value as default. When deploying it in cloud the template or operator would provide the right value based on the environment.","created_at":"2019-03-14T14:12:42Z","updated_at":"2019-03-14T14:13:33Z","html_url":"https://github.com/infinispan/infinispan/pull/6749#discussion_r265587508","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6749","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/265587508"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6749#discussion_r265587508"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6749"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/6749","id":259104581,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MTA0NTgx","html_url":"https://github.com/infinispan/infinispan/pull/6749","diff_url":"https://github.com/infinispan/infinispan/pull/6749.diff","patch_url":"https://github.com/infinispan/infinispan/pull/6749.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/6749","number":6749,"state":"open","locked":false,"title":"ISPN-10005 stack for dns ping on okd","user":{"login":"rigazilla","id":7080882,"node_id":"MDQ6VXNlcjcwODA4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080882?v=4","gravatar_id":"","url":"https://api.github.com/users/rigazilla","html_url":"https://github.com/rigazilla","followers_url":"https://api.github.com/users/rigazilla/followers","following_url":"https://api.github.com/users/rigazilla/following{/other_user}","gists_url":"https://api.github.com/users/rigazilla/gists{/gist_id}","starred_url":"https://api.github.com/users/rigazilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigazilla/subscriptions","organizations_url":"https://api.github.com/users/rigazilla/orgs","repos_url":"https://api.github.com/users/rigazilla/repos","events_url":"https://api.github.com/users/rigazilla/events{/privacy}","received_events_url":"https://api.github.com/users/rigazilla/received_events","type":"User","site_admin":false},"body":"This adds dns ping jgroups stack needed when running on okd.\r\n\r\nhttps://issues.jboss.org/browse/ISPN-10005","created_at":"2019-03-07T13:05:36Z","updated_at":"2019-03-14T14:13:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee835082e830500641deb1782761416fe94db216","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6749/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6749/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/6749/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/465082f73afe428ff636f7ebe68b14c75c7e18a0","head":{"label":"rigazilla:ISPN-10005/okd_dns_ping","ref":"ISPN-10005/okd_dns_ping","sha":"465082f73afe428ff636f7ebe68b14c75c7e18a0","user":{"login":"rigazilla","id":7080882,"node_id":"MDQ6VXNlcjcwODA4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080882?v=4","gravatar_id":"","url":"https://api.github.com/users/rigazilla","html_url":"https://github.com/rigazilla","followers_url":"https://api.github.com/users/rigazilla/followers","following_url":"https://api.github.com/users/rigazilla/following{/other_user}","gists_url":"https://api.github.com/users/rigazilla/gists{/gist_id}","starred_url":"https://api.github.com/users/rigazilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigazilla/subscriptions","organizations_url":"https://api.github.com/users/rigazilla/orgs","repos_url":"https://api.github.com/users/rigazilla/repos","events_url":"https://api.github.com/users/rigazilla/events{/privacy}","received_events_url":"https://api.github.com/users/rigazilla/received_events","type":"User","site_admin":false},"repo":{"id":46712849,"node_id":"MDEwOlJlcG9zaXRvcnk0NjcxMjg0OQ==","name":"infinispan","full_name":"rigazilla/infinispan","private":false,"owner":{"login":"rigazilla","id":7080882,"node_id":"MDQ6VXNlcjcwODA4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080882?v=4","gravatar_id":"","url":"https://api.github.com/users/rigazilla","html_url":"https://github.com/rigazilla","followers_url":"https://api.github.com/users/rigazilla/followers","following_url":"https://api.github.com/users/rigazilla/following{/other_user}","gists_url":"https://api.github.com/users/rigazilla/gists{/gist_id}","starred_url":"https://api.github.com/users/rigazilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigazilla/subscriptions","organizations_url":"https://api.github.com/users/rigazilla/orgs","repos_url":"https://api.github.com/users/rigazilla/repos","events_url":"https://api.github.com/users/rigazilla/events{/privacy}","received_events_url":"https://api.github.com/users/rigazilla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rigazilla/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/rigazilla/infinispan","forks_url":"https://api.github.com/repos/rigazilla/infinispan/forks","keys_url":"https://api.github.com/repos/rigazilla/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigazilla/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigazilla/infinispan/teams","hooks_url":"https://api.github.com/repos/rigazilla/infinispan/hooks","issue_events_url":"https://api.github.com/repos/rigazilla/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/rigazilla/infinispan/events","assignees_url":"https://api.github.com/repos/rigazilla/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/rigazilla/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/rigazilla/infinispan/tags","blobs_url":"https://api.github.com/repos/rigazilla/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigazilla/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigazilla/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigazilla/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigazilla/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/rigazilla/infinispan/languages","stargazers_url":"https://api.github.com/repos/rigazilla/infinispan/stargazers","contributors_url":"https://api.github.com/repos/rigazilla/infinispan/contributors","subscribers_url":"https://api.github.com/repos/rigazilla/infinispan/subscribers","subscription_url":"https://api.github.com/repos/rigazilla/infinispan/subscription","commits_url":"https://api.github.com/repos/rigazilla/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigazilla/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigazilla/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigazilla/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigazilla/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/rigazilla/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigazilla/infinispan/merges","archive_url":"https://api.github.com/repos/rigazilla/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigazilla/infinispan/downloads","issues_url":"https://api.github.com/repos/rigazilla/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/rigazilla/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/rigazilla/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/rigazilla/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigazilla/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/rigazilla/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/rigazilla/infinispan/deployments","created_at":"2015-11-23T10:25:47Z","updated_at":"2015-11-23T10:26:11Z","pushed_at":"2019-03-07T13:10:37Z","git_url":"git://github.com/rigazilla/infinispan.git","ssh_url":"git@github.com:rigazilla/infinispan.git","clone_url":"https://github.com/rigazilla/infinispan.git","svn_url":"https://github.com/rigazilla/infinispan","homepage":"http://www.infinispan.org","size":111451,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:9.4.x","ref":"9.4.x","sha":"61505527f5672a57a076d70c4d1cc288e5512164","user":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwOTQ0","name":"infinispan","full_name":"infinispan/infinispan","private":false,"owner":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2019-03-13T21:14:49Z","pushed_at":"2019-03-14T13:33:14Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":118057,"stargazers_count":717,"watchers_count":717,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":465,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":465,"open_issues":31,"watchers":717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6749"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6749"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6749"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6749/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6749/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6749/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/465082f73afe428ff636f7ebe68b14c75c7e18a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"galderz"}}