{"action":"created","issue":{"url":"https://api.github.com/repos/freqtrade/freqtrade/issues/2158","repository_url":"https://api.github.com/repos/freqtrade/freqtrade","labels_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/2158/labels{/name}","comments_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/2158/comments","events_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/2158/events","html_url":"https://github.com/freqtrade/freqtrade/pull/2158","id":481999833,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4MzY4NDM5","number":2158,"title":"Config consistency checking improvements","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-08-18T14:23:04Z","updated_at":"2019-08-20T04:44:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/2158","html_url":"https://github.com/freqtrade/freqtrade/pull/2158","diff_url":"https://github.com/freqtrade/freqtrade/pull/2158.diff","patch_url":"https://github.com/freqtrade/freqtrade/pull/2158.patch"},"body":"## Summary\r\nValidate edge_configuration vs. Volume pairlist - the 2 are incompatible (edge will always override volume pairlist - which will cause unnecessary calls to the exchange from the VolumePairList.\r\n\r\nCloses #1196 (5th and last point).\r\n\r\n## Quick changelog\r\n\r\n- move validation methods out of Configuration\r\n- Check configuration after loading strategy (strategies can set options, especially related trailing stop - so our current approach is inefficient for these cases).\r\n"},"comment":{"url":"https://api.github.com/repos/freqtrade/freqtrade/issues/comments/522850802","html_url":"https://github.com/freqtrade/freqtrade/pull/2158#issuecomment-522850802","issue_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/2158","id":522850802,"node_id":"MDEyOklzc3VlQ29tbWVudDUyMjg1MDgwMg==","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"created_at":"2019-08-20T04:44:38Z","updated_at":"2019-08-20T04:44:38Z","author_association":"MEMBER","body":"> Just a question: how is it related to asyncio (as stated in the #1196)?\r\n\r\nIt really isn't. due to the huge change #1101 was, this was detected as a potential problem so we added it as follow up to that PR (this PR was already too big to review efficiently) ... \r\nThere was no other issue for it - and it's a minor thing which didn't really deserve a seperate issue, just as the other 4 points."}}
{"actor":{"display_login":"xmatthias"}}