{"action":"created","issue":{"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/673","repository_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock","labels_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/673/labels{/name}","comments_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/673/comments","events_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/673/events","html_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/673","id":431475469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5MTQwODIz","number":673,"title":"Make the error page responsive for small viewports","user":{"login":"MKodde","id":28252948,"node_id":"MDQ6VXNlcjI4MjUyOTQ4","avatar_url":"https://avatars1.githubusercontent.com/u/28252948?v=4","gravatar_id":"","url":"https://api.github.com/users/MKodde","html_url":"https://github.com/MKodde","followers_url":"https://api.github.com/users/MKodde/followers","following_url":"https://api.github.com/users/MKodde/following{/other_user}","gists_url":"https://api.github.com/users/MKodde/gists{/gist_id}","starred_url":"https://api.github.com/users/MKodde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MKodde/subscriptions","organizations_url":"https://api.github.com/users/MKodde/orgs","repos_url":"https://api.github.com/users/MKodde/repos","events_url":"https://api.github.com/users/MKodde/events{/privacy}","received_events_url":"https://api.github.com/users/MKodde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-04-10T12:28:39Z","updated_at":"2019-04-11T07:07:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/pulls/673","html_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/673","diff_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/673.diff","patch_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/673.patch"},"body":"The different commits should provide you with context about the changes undertaken.\r\n\r\nIn addition to making the page responsive, I've added a watch styles grunt task. Which will be removed with the introduction of #672 I gues. :broken_heart: \r\n\r\nThis PR covers task 3 of this [Pivotal story](https://www.pivotaltracker.com/story/show/164121204)"},"comment":{"url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/comments/481993837","html_url":"https://github.com/OpenConext/OpenConext-engineblock/pull/673#issuecomment-481993837","issue_url":"https://api.github.com/repos/OpenConext/OpenConext-engineblock/issues/673","id":481993837,"node_id":"MDEyOklzc3VlQ29tbWVudDQ4MTk5MzgzNw==","user":{"login":"MKodde","id":28252948,"node_id":"MDQ6VXNlcjI4MjUyOTQ4","avatar_url":"https://avatars1.githubusercontent.com/u/28252948?v=4","gravatar_id":"","url":"https://api.github.com/users/MKodde","html_url":"https://github.com/MKodde","followers_url":"https://api.github.com/users/MKodde/followers","following_url":"https://api.github.com/users/MKodde/following{/other_user}","gists_url":"https://api.github.com/users/MKodde/gists{/gist_id}","starred_url":"https://api.github.com/users/MKodde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MKodde/subscriptions","organizations_url":"https://api.github.com/users/MKodde/orgs","repos_url":"https://api.github.com/users/MKodde/repos","events_url":"https://api.github.com/users/MKodde/events{/privacy}","received_events_url":"https://api.github.com/users/MKodde/received_events","type":"User","site_admin":false},"created_at":"2019-04-11T07:07:16Z","updated_at":"2019-04-11T07:07:16Z","author_association":"CONTRIBUTOR","body":"> Furthermore I think the background could be optimized a bit more\r\n\r\nThe background color is the same that is used throughout the rest of the OC suite. You might be onto something here, feel free to discuss it in the Pivotal story.\r\n\r\n> As a side note, I personally would like a bit bigger commits for the style adjustments, so the commits would be more useful over time.\r\n\r\nYes, all the small commits might clutter the history slightly, but keep related changes closely together. Making them more useful over time in my opinion. Personally, when I'm inspecting the code, it's from a code perspective, I later check the commit and PR that corresponds to that change. \r\n\r\nPlease elaborate on how you'd like to see this kind of changes in version control.\r\n"}}
{"actor":{"display_login":"MKodde"}}