{"action":"created","comment":{"url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/comments/314253948","pull_request_review_id":275358921,"id":314253948,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDI1Mzk0OA==","diff_hunk":"@@ -24,16 +37,21 @@ $(SIGNATURES)\n \n Return Hermitian conjugate \\$\\\\langle val| = |val\\\\rangle^\\\\dagger\\$ of the ket with the same label.\n \"\"\"\n-bra(val::Int, dim::Int) = bra(ComplexF64, val, dim)\n+bra(val::Int, dim::Int) = bra(Vector{ComplexF64}, val, dim)\n \n-function ketbra(::Type{T}, valk::Int, valb::Int, dim::Int) where T<:Number\n+function ketbra(::Type{T}, valk::Int, valb::Int, dim::Int) where T<:AbstractMatrix{<:Number}\n     dim > 0 ? () : throw(ArgumentError(\"Vector dimension has to be nonnegative\"))\n     1 <= valk <= dim && 1 <= valb <= dim ? () : throw(ArgumentError(\"Ket and bra labels have to be smaller than operator dimension\"))\n-    ρ = zeros(T, dim, dim)\n-    ρ[valk,valb] = one(T)\n+    ρ = zero(T(undef, dim, dim))","path":"src/base.jl","position":53,"original_position":53,"commit_id":"6cf7c8a3c6bd2677eaa06e092e681df42fbcd975","original_commit_id":"6cf7c8a3c6bd2677eaa06e092e681df42fbcd975","user":{"login":"lpawela","id":3093117,"node_id":"MDQ6VXNlcjMwOTMxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3093117?v=4","gravatar_id":"","url":"https://api.github.com/users/lpawela","html_url":"https://github.com/lpawela","followers_url":"https://api.github.com/users/lpawela/followers","following_url":"https://api.github.com/users/lpawela/following{/other_user}","gists_url":"https://api.github.com/users/lpawela/gists{/gist_id}","starred_url":"https://api.github.com/users/lpawela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpawela/subscriptions","organizations_url":"https://api.github.com/users/lpawela/orgs","repos_url":"https://api.github.com/users/lpawela/repos","events_url":"https://api.github.com/users/lpawela/events{/privacy}","received_events_url":"https://api.github.com/users/lpawela/received_events","type":"User","site_admin":false},"body":"We should support the case of rectangular matrices. Add idim (bra dim), odim (ket dim).","created_at":"2019-08-15T10:27:53Z","updated_at":"2019-08-15T10:36:19Z","html_url":"https://github.com/ZKSI/QuantumInformation.jl/pull/59#discussion_r314253948","pull_request_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/comments/314253948"},"html":{"href":"https://github.com/ZKSI/QuantumInformation.jl/pull/59#discussion_r314253948"},"pull_request":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59","id":307379495,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3Mzc5NDk1","html_url":"https://github.com/ZKSI/QuantumInformation.jl/pull/59","diff_url":"https://github.com/ZKSI/QuantumInformation.jl/pull/59.diff","patch_url":"https://github.com/ZKSI/QuantumInformation.jl/pull/59.patch","issue_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/59","number":59,"state":"open","locked":false,"title":"Pg/bases","user":{"login":"pgawron","id":718316,"node_id":"MDQ6VXNlcjcxODMxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/718316?v=4","gravatar_id":"","url":"https://api.github.com/users/pgawron","html_url":"https://github.com/pgawron","followers_url":"https://api.github.com/users/pgawron/followers","following_url":"https://api.github.com/users/pgawron/following{/other_user}","gists_url":"https://api.github.com/users/pgawron/gists{/gist_id}","starred_url":"https://api.github.com/users/pgawron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgawron/subscriptions","organizations_url":"https://api.github.com/users/pgawron/orgs","repos_url":"https://api.github.com/users/pgawron/repos","events_url":"https://api.github.com/users/pgawron/events{/privacy}","received_events_url":"https://api.github.com/users/pgawron/received_events","type":"User","site_admin":false},"body":"New bases system and major clean-up.","created_at":"2019-08-14T15:21:22Z","updated_at":"2019-08-15T10:36:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7985be5ea71d334506ca9693681065a8330b8081","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59/commits","review_comments_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59/comments","review_comment_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/59/comments","statuses_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/statuses/6cf7c8a3c6bd2677eaa06e092e681df42fbcd975","head":{"label":"ZKSI:pg/bases","ref":"pg/bases","sha":"6cf7c8a3c6bd2677eaa06e092e681df42fbcd975","user":{"login":"ZKSI","id":29304716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzA0NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29304716?v=4","gravatar_id":"","url":"https://api.github.com/users/ZKSI","html_url":"https://github.com/ZKSI","followers_url":"https://api.github.com/users/ZKSI/followers","following_url":"https://api.github.com/users/ZKSI/following{/other_user}","gists_url":"https://api.github.com/users/ZKSI/gists{/gist_id}","starred_url":"https://api.github.com/users/ZKSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZKSI/subscriptions","organizations_url":"https://api.github.com/users/ZKSI/orgs","repos_url":"https://api.github.com/users/ZKSI/repos","events_url":"https://api.github.com/users/ZKSI/events{/privacy}","received_events_url":"https://api.github.com/users/ZKSI/received_events","type":"Organization","site_admin":false},"repo":{"id":23916883,"node_id":"MDEwOlJlcG9zaXRvcnkyMzkxNjg4Mw==","name":"QuantumInformation.jl","full_name":"ZKSI/QuantumInformation.jl","private":false,"owner":{"login":"ZKSI","id":29304716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzA0NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29304716?v=4","gravatar_id":"","url":"https://api.github.com/users/ZKSI","html_url":"https://github.com/ZKSI","followers_url":"https://api.github.com/users/ZKSI/followers","following_url":"https://api.github.com/users/ZKSI/following{/other_user}","gists_url":"https://api.github.com/users/ZKSI/gists{/gist_id}","starred_url":"https://api.github.com/users/ZKSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZKSI/subscriptions","organizations_url":"https://api.github.com/users/ZKSI/orgs","repos_url":"https://api.github.com/users/ZKSI/repos","events_url":"https://api.github.com/users/ZKSI/events{/privacy}","received_events_url":"https://api.github.com/users/ZKSI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ZKSI/QuantumInformation.jl","description":"A Julia package for numerical computation in quantum information theory","fork":false,"url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl","forks_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/forks","keys_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/teams","hooks_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/hooks","issue_events_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/events","assignees_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/tags","blobs_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/languages","stargazers_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/stargazers","contributors_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/contributors","subscribers_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/subscribers","subscription_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/subscription","commits_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/merges","archive_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/downloads","issues_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/labels{/name}","releases_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/releases{/id}","deployments_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/deployments","created_at":"2014-09-11T12:15:35Z","updated_at":"2019-08-05T07:46:19Z","pushed_at":"2019-08-14T15:30:41Z","git_url":"git://github.com/ZKSI/QuantumInformation.jl.git","ssh_url":"git@github.com:ZKSI/QuantumInformation.jl.git","clone_url":"https://github.com/ZKSI/QuantumInformation.jl.git","svn_url":"https://github.com/ZKSI/QuantumInformation.jl","homepage":"https://zksi.github.io/QuantumInformation.jl/latest","size":666,"stargazers_count":27,"watchers_count":27,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7,"open_issues":7,"watchers":27,"default_branch":"master"}},"base":{"label":"ZKSI:master","ref":"master","sha":"4c92c9f19f3a68566876dc3e14534d15e1a0e958","user":{"login":"ZKSI","id":29304716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzA0NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29304716?v=4","gravatar_id":"","url":"https://api.github.com/users/ZKSI","html_url":"https://github.com/ZKSI","followers_url":"https://api.github.com/users/ZKSI/followers","following_url":"https://api.github.com/users/ZKSI/following{/other_user}","gists_url":"https://api.github.com/users/ZKSI/gists{/gist_id}","starred_url":"https://api.github.com/users/ZKSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZKSI/subscriptions","organizations_url":"https://api.github.com/users/ZKSI/orgs","repos_url":"https://api.github.com/users/ZKSI/repos","events_url":"https://api.github.com/users/ZKSI/events{/privacy}","received_events_url":"https://api.github.com/users/ZKSI/received_events","type":"Organization","site_admin":false},"repo":{"id":23916883,"node_id":"MDEwOlJlcG9zaXRvcnkyMzkxNjg4Mw==","name":"QuantumInformation.jl","full_name":"ZKSI/QuantumInformation.jl","private":false,"owner":{"login":"ZKSI","id":29304716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzA0NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29304716?v=4","gravatar_id":"","url":"https://api.github.com/users/ZKSI","html_url":"https://github.com/ZKSI","followers_url":"https://api.github.com/users/ZKSI/followers","following_url":"https://api.github.com/users/ZKSI/following{/other_user}","gists_url":"https://api.github.com/users/ZKSI/gists{/gist_id}","starred_url":"https://api.github.com/users/ZKSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZKSI/subscriptions","organizations_url":"https://api.github.com/users/ZKSI/orgs","repos_url":"https://api.github.com/users/ZKSI/repos","events_url":"https://api.github.com/users/ZKSI/events{/privacy}","received_events_url":"https://api.github.com/users/ZKSI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ZKSI/QuantumInformation.jl","description":"A Julia package for numerical computation in quantum information theory","fork":false,"url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl","forks_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/forks","keys_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/teams","hooks_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/hooks","issue_events_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/events","assignees_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/tags","blobs_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/languages","stargazers_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/stargazers","contributors_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/contributors","subscribers_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/subscribers","subscription_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/subscription","commits_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/merges","archive_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/downloads","issues_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/labels{/name}","releases_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/releases{/id}","deployments_url":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/deployments","created_at":"2014-09-11T12:15:35Z","updated_at":"2019-08-05T07:46:19Z","pushed_at":"2019-08-14T15:30:41Z","git_url":"git://github.com/ZKSI/QuantumInformation.jl.git","ssh_url":"git@github.com:ZKSI/QuantumInformation.jl.git","clone_url":"https://github.com/ZKSI/QuantumInformation.jl.git","svn_url":"https://github.com/ZKSI/QuantumInformation.jl","homepage":"https://zksi.github.io/QuantumInformation.jl/latest","size":666,"stargazers_count":27,"watchers_count":27,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":7,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7,"open_issues":7,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59"},"html":{"href":"https://github.com/ZKSI/QuantumInformation.jl/pull/59"},"issue":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/59"},"comments":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/ZKSI/QuantumInformation.jl/statuses/6cf7c8a3c6bd2677eaa06e092e681df42fbcd975"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lpawela"}}