{"action":"closed","number":6172,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/6172","id":353082705,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMDgyNzA1","html_url":"https://github.com/facebook/rocksdb/pull/6172","diff_url":"https://github.com/facebook/rocksdb/pull/6172.diff","patch_url":"https://github.com/facebook/rocksdb/pull/6172.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/6172","number":6172,"state":"closed","locked":false,"title":"Make it possible to enable periodic compactions for BlobDB","user":{"login":"ltamasi","id":47607618,"node_id":"MDQ6VXNlcjQ3NjA3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/47607618?v=4","gravatar_id":"","url":"https://api.github.com/users/ltamasi","html_url":"https://github.com/ltamasi","followers_url":"https://api.github.com/users/ltamasi/followers","following_url":"https://api.github.com/users/ltamasi/following{/other_user}","gists_url":"https://api.github.com/users/ltamasi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltamasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltamasi/subscriptions","organizations_url":"https://api.github.com/users/ltamasi/orgs","repos_url":"https://api.github.com/users/ltamasi/repos","events_url":"https://api.github.com/users/ltamasi/events{/privacy}","received_events_url":"https://api.github.com/users/ltamasi/received_events","type":"User","site_admin":false},"body":"Summary:\r\nPeriodic compactions ensure that even SSTs that do not get picked up\r\notherwise eventually go through compaction; used in conjunction with\r\nBlobDB's garbage collection, they enable BlobDB to reclaim space when\r\nold blob files are used by such straggling SSTs.\r\n\r\nTest Plan:\r\nRan `make check` and used the BlobDB mode of `db_bench`.","created_at":"2019-12-13T21:35:30Z","updated_at":"2019-12-14T00:13:32Z","closed_at":"2019-12-14T00:13:32Z","merged_at":null,"merge_commit_sha":"e24dc730a24edb6d523960550c9500d884259638","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/6172/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/6172/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/6172/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/b2b133c331f51b836ff73b91344abc9caf590e24","head":{"label":"ltamasi:blob_db_periodic","ref":"blob_db_periodic","sha":"b2b133c331f51b836ff73b91344abc9caf590e24","user":{"login":"ltamasi","id":47607618,"node_id":"MDQ6VXNlcjQ3NjA3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/47607618?v=4","gravatar_id":"","url":"https://api.github.com/users/ltamasi","html_url":"https://github.com/ltamasi","followers_url":"https://api.github.com/users/ltamasi/followers","following_url":"https://api.github.com/users/ltamasi/following{/other_user}","gists_url":"https://api.github.com/users/ltamasi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltamasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltamasi/subscriptions","organizations_url":"https://api.github.com/users/ltamasi/orgs","repos_url":"https://api.github.com/users/ltamasi/repos","events_url":"https://api.github.com/users/ltamasi/events{/privacy}","received_events_url":"https://api.github.com/users/ltamasi/received_events","type":"User","site_admin":false},"repo":{"id":172592959,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1OTI5NTk=","name":"rocksdb","full_name":"ltamasi/rocksdb","private":false,"owner":{"login":"ltamasi","id":47607618,"node_id":"MDQ6VXNlcjQ3NjA3NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/47607618?v=4","gravatar_id":"","url":"https://api.github.com/users/ltamasi","html_url":"https://github.com/ltamasi","followers_url":"https://api.github.com/users/ltamasi/followers","following_url":"https://api.github.com/users/ltamasi/following{/other_user}","gists_url":"https://api.github.com/users/ltamasi/gists{/gist_id}","starred_url":"https://api.github.com/users/ltamasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltamasi/subscriptions","organizations_url":"https://api.github.com/users/ltamasi/orgs","repos_url":"https://api.github.com/users/ltamasi/repos","events_url":"https://api.github.com/users/ltamasi/events{/privacy}","received_events_url":"https://api.github.com/users/ltamasi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ltamasi/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/ltamasi/rocksdb","forks_url":"https://api.github.com/repos/ltamasi/rocksdb/forks","keys_url":"https://api.github.com/repos/ltamasi/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ltamasi/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ltamasi/rocksdb/teams","hooks_url":"https://api.github.com/repos/ltamasi/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/ltamasi/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/ltamasi/rocksdb/events","assignees_url":"https://api.github.com/repos/ltamasi/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/ltamasi/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/ltamasi/rocksdb/tags","blobs_url":"https://api.github.com/repos/ltamasi/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ltamasi/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ltamasi/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ltamasi/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ltamasi/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ltamasi/rocksdb/languages","stargazers_url":"https://api.github.com/repos/ltamasi/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/ltamasi/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/ltamasi/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/ltamasi/rocksdb/subscription","commits_url":"https://api.github.com/repos/ltamasi/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ltamasi/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ltamasi/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ltamasi/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ltamasi/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/ltamasi/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ltamasi/rocksdb/merges","archive_url":"https://api.github.com/repos/ltamasi/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ltamasi/rocksdb/downloads","issues_url":"https://api.github.com/repos/ltamasi/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/ltamasi/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ltamasi/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ltamasi/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ltamasi/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/ltamasi/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/ltamasi/rocksdb/deployments","created_at":"2019-02-25T22:07:50Z","updated_at":"2019-12-13T18:53:10Z","pushed_at":"2019-12-13T21:34:12Z","git_url":"git://github.com/ltamasi/rocksdb.git","ssh_url":"git@github.com:ltamasi/rocksdb.git","clone_url":"https://github.com/ltamasi/rocksdb.git","svn_url":"https://github.com/ltamasi/rocksdb","homepage":"http://rocksdb.org","size":145959,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"6d54eb3dc2e6d0ef75ffc252479a68f5151fa0d4","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM0Mzk1","name":"rocksdb","full_name":"facebook/rocksdb","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2019-12-13T22:48:54Z","pushed_at":"2019-12-14T00:13:31Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":146365,"stargazers_count":15591,"watchers_count":15591,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3475,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":410,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3475,"open_issues":410,"watchers":15591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6172"},"html":{"href":"https://github.com/facebook/rocksdb/pull/6172"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/6172"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/6172/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6172/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/6172/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/b2b133c331f51b836ff73b91344abc9caf590e24"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"facebook-github-bot"}}