{"action":"created","issue":{"url":"https://api.github.com/repos/pnp/office365-cli/issues/1192","repository_url":"https://api.github.com/repos/pnp/office365-cli","labels_url":"https://api.github.com/repos/pnp/office365-cli/issues/1192/labels{/name}","comments_url":"https://api.github.com/repos/pnp/office365-cli/issues/1192/comments","events_url":"https://api.github.com/repos/pnp/office365-cli/issues/1192/events","html_url":"https://github.com/pnp/office365-cli/issues/1192","id":522476249,"node_id":"MDU6SXNzdWU1MjI0NzYyNDk=","number":1192,"title":"spfx project externalize exceptions to patterns","user":{"login":"baywet","id":7905502,"node_id":"MDQ6VXNlcjc5MDU1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7905502?v=4","gravatar_id":"","url":"https://api.github.com/users/baywet","html_url":"https://github.com/baywet","followers_url":"https://api.github.com/users/baywet/followers","following_url":"https://api.github.com/users/baywet/following{/other_user}","gists_url":"https://api.github.com/users/baywet/gists{/gist_id}","starred_url":"https://api.github.com/users/baywet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baywet/subscriptions","organizations_url":"https://api.github.com/users/baywet/orgs","repos_url":"https://api.github.com/users/baywet/repos","events_url":"https://api.github.com/users/baywet/events{/privacy}","received_events_url":"https://api.github.com/users/baywet/received_events","type":"User","site_admin":false},"labels":[{"id":718115096,"node_id":"MDU6TGFiZWw3MTgxMTUwOTY=","url":"https://api.github.com/repos/pnp/office365-cli/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2019-11-13T21:14:01Z","updated_at":"2019-11-15T18:43:52Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There are libraries that do not follow the naming patterns we're trying to match.\r\nA few examples are:\r\nSuggested:\r\n\"moment-timezone\": \"https://unpkg.com/moment-timezone@^0.5.27/index.js\",\r\n\"moment\": \"https://unpkg.com/moment@^2.24.0/moment.js\",\r\n\"tinycolor2\": \"https://unpkg.com/tinycolor2@^1.4.1/tinycolor.js\"\r\n\r\nShould be:\r\n\"moment-timezone\": \"https://unpkg.com/moment-timezone@^0.5.27/builds/moment-timezone-with-data.min.js\",\r\n\"moment\": \"https://unpkg.com/moment@^2.24.0/min/moment.min.js\",\r\n\"tinycolor2\": \"https://unpkg.com/tinycolor2@^1.4.1/dist/tinycolor-min.js\"\r\n\r\nI was thinking about adding a rule dedicated to handling those exceptions. It won't be perfect but at least we'd be able to start addressing the \"odd\" recommendations. Thoughts?"},"comment":{"url":"https://api.github.com/repos/pnp/office365-cli/issues/comments/554480740","html_url":"https://github.com/pnp/office365-cli/issues/1192#issuecomment-554480740","issue_url":"https://api.github.com/repos/pnp/office365-cli/issues/1192","id":554480740,"node_id":"MDEyOklzc3VlQ29tbWVudDU1NDQ4MDc0MA==","user":{"login":"baywet","id":7905502,"node_id":"MDQ6VXNlcjc5MDU1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/7905502?v=4","gravatar_id":"","url":"https://api.github.com/users/baywet","html_url":"https://github.com/baywet","followers_url":"https://api.github.com/users/baywet/followers","following_url":"https://api.github.com/users/baywet/following{/other_user}","gists_url":"https://api.github.com/users/baywet/gists{/gist_id}","starred_url":"https://api.github.com/users/baywet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baywet/subscriptions","organizations_url":"https://api.github.com/users/baywet/orgs","repos_url":"https://api.github.com/users/baywet/repos","events_url":"https://api.github.com/users/baywet/events{/privacy}","received_events_url":"https://api.github.com/users/baywet/received_events","type":"User","site_admin":false},"created_at":"2019-11-15T18:43:51Z","updated_at":"2019-11-15T18:43:51Z","author_association":"CONTRIBUTOR","body":"Agreed, it's a rabbit hole we should try to avoid for as long as we can.\r\nThe only things I can suggest:\r\n1. the Rencore API to tell the difference between the types of modules (es6, systemjs, commonjs...)\r\n1. looking as well at the jspm/main property https://github.com/jspm/registry/wiki/Configuring-Packages-for-jspm#prefixing-configuration\r\n\r\nThis way we could implement something like\r\n1. get me all the potential files (module, main, and jspm/main), also \"make\" variations with .min, .bundle ...\r\n1. get the module type of all those possibilities thanks to the API\r\n1. use the first one that's a umd or amd module or a script\r\n1. give up if none of them are successful\r\n\r\nWith this approach we should be able to cover more cases, and provide better suggestions for the ones that have multiple possibilities.\r\nThe only thing is that it requires changes on Rencore's API, and I'm not sure if this is possible/how long it will take/etc...\r\nWhat do you think?"}}
{"actor":{"display_login":"baywet"}}