{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments/257049211","pull_request_review_id":204016513,"id":257049211,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzA0OTIxMQ==","diff_hunk":"@@ -82,12 +82,12 @@ struct LightData\n     uint lightLayers;\n     float lightDimmer;\n     float volumetricLightDimmer;\n-    float angleScale;\n-    float angleOffset;\n+    real angleScale;\n+    real angleOffset;\n     float3 forward;\n     int lightType;\n     float3 right;\n-    float range;\n+    real range;","path":"com.unity.render-pipelines.high-definition/Runtime/Lighting/LightDefinition.cs.hlsl","position":23,"original_position":23,"commit_id":"3cc635a494af493c31afaf50ff3895d62e6568e3","original_commit_id":"3cc635a494af493c31afaf50ff3895d62e6568e3","user":{"login":"kaychang-unity","id":37455951,"node_id":"MDQ6VXNlcjM3NDU1OTUx","avatar_url":"https://avatars2.githubusercontent.com/u/37455951?v=4","gravatar_id":"","url":"https://api.github.com/users/kaychang-unity","html_url":"https://github.com/kaychang-unity","followers_url":"https://api.github.com/users/kaychang-unity/followers","following_url":"https://api.github.com/users/kaychang-unity/following{/other_user}","gists_url":"https://api.github.com/users/kaychang-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/kaychang-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaychang-unity/subscriptions","organizations_url":"https://api.github.com/users/kaychang-unity/orgs","repos_url":"https://api.github.com/users/kaychang-unity/repos","events_url":"https://api.github.com/users/kaychang-unity/events{/privacy}","received_events_url":"https://api.github.com/users/kaychang-unity/received_events","type":"User","site_admin":false},"body":"On Switch platform, half type is used to generate fp16 instruction, but does not change the storage size of the variable if coming from memory (it will stay 32bits).\r\nNote that Metal behaves differently in that regard, but I am not sure how HLSLcc compiler behaves for that case.","created_at":"2019-02-14T23:03:51Z","updated_at":"2019-02-14T23:03:51Z","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2971#discussion_r257049211","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments/257049211"},"html":{"href":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2971#discussion_r257049211"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971"}},"in_reply_to_id":257048323},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971","id":253246761,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMjQ2NzYx","html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2971","diff_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2971.diff","patch_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2971.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2971","number":2971,"state":"open","locked":false,"title":"Add support for half types in shaders for Switch platform.","user":{"login":"kaychang-unity","id":37455951,"node_id":"MDQ6VXNlcjM3NDU1OTUx","avatar_url":"https://avatars2.githubusercontent.com/u/37455951?v=4","gravatar_id":"","url":"https://api.github.com/users/kaychang-unity","html_url":"https://github.com/kaychang-unity","followers_url":"https://api.github.com/users/kaychang-unity/followers","following_url":"https://api.github.com/users/kaychang-unity/following{/other_user}","gists_url":"https://api.github.com/users/kaychang-unity/gists{/gist_id}","starred_url":"https://api.github.com/users/kaychang-unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaychang-unity/subscriptions","organizations_url":"https://api.github.com/users/kaychang-unity/orgs","repos_url":"https://api.github.com/users/kaychang-unity/repos","events_url":"https://api.github.com/users/kaychang-unity/events{/privacy}","received_events_url":"https://api.github.com/users/kaychang-unity/received_events","type":"User","site_admin":false},"body":"### Purpose of this PR\r\nThis PR adds minimal support for half types in shaders. This affects Switch platform, and maybe mobile platforms (not officially supported).\r\n\r\nFor the minimal support, I only modified temporary structures inside HDRP shader code to use half instead of float. As seen in the PR, a lot of fields are left to float because lighting artefacts would appear otherwise. So there isn't actually that many values that can be safely moved to half.\r\n\r\nOn Switch, these minimal changes improve the shader execution by 15%.\r\n\r\nWe could move more code to use half, but the gain seems less significant (I suspect less than 5% further gain) but would touch more code everywhere. I may fix more code in the future to use half (if time allows).\r\n\r\n---\r\n### Release Notes\r\n\r\n---\r\n### Testing status\r\n**Katana Tests**:\r\nRunning Katana tests now:\r\nhttps://katana.bf.unity3d.com/projects/com.unity.render-pipelines/builders?ScriptableRenderLoop_branch=switch-support-half&automation-tools_branch=add-platform-filter&unity_branch=trunk\r\n\r\n**Manual Tests**: What did you do?\r\nI tested a couple of scenes in HDRP_Tests (2001_Dynamic_Directional, 2002_Dynamic_Mix, 2201_ReflectionProbes_Volume) and made sure rendering did not changes with half support.\r\n\r\n**Automated Tests**: What did you setup?\r\n-\r\n\r\nAny test projects to go with this to help reviewers?\r\n-\r\n---\r\n### Overall Product Risks\r\n**Technical Risk**: None, Low, Medium, High?\r\nLow. Excepted Switch, all other platforms define \"real\" type as \"float\". so the generated code is identical.\r\n\r\n**Halo Effect**: None, Low, Medium, High?\r\nLow.\r\nMobile platforms could be affected by the change, but since original code would not compile with SHADER_API_MOBILE enabled, there is currently no official support for mobile platforms and this commit help fix it.\r\n\r\n---\r\n### Comments to reviewers\r\ncom.unity.render-pipelines.core/ShaderLibrary/Packing.hlsl use \"real\" types everywhere, but at least in 1 occurrence, this didn't give enough precision when \"real\"=\"half\". I fixed the related functions (PackNormalHemiOctEncode, UnpackNormalHemiOctEncode). But I believe most of these packing functions should explicitly use float.\r\n\r\n","created_at":"2019-02-14T22:33:52Z","updated_at":"2019-02-14T23:03:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f11c06ea2b2e1cd43f2a3ae94e264cdda027a322","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sebastienlagarde","id":21238527,"node_id":"MDQ6VXNlcjIxMjM4NTI3","avatar_url":"https://avatars2.githubusercontent.com/u/21238527?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienlagarde","html_url":"https://github.com/sebastienlagarde","followers_url":"https://api.github.com/users/sebastienlagarde/followers","following_url":"https://api.github.com/users/sebastienlagarde/following{/other_user}","gists_url":"https://api.github.com/users/sebastienlagarde/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienlagarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienlagarde/subscriptions","organizations_url":"https://api.github.com/users/sebastienlagarde/orgs","repos_url":"https://api.github.com/users/sebastienlagarde/repos","events_url":"https://api.github.com/users/sebastienlagarde/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienlagarde/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2971/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/3cc635a494af493c31afaf50ff3895d62e6568e3","head":{"label":"Unity-Technologies:switch-support-half","ref":"switch-support-half","sha":"3cc635a494af493c31afaf50ff3895d62e6568e3","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":62172778,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3Mjc3OA==","name":"ScriptableRenderPipeline","full_name":"Unity-Technologies/ScriptableRenderPipeline","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","description":"Scriptable Render Pipeline","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","forks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/deployments","created_at":"2016-06-28T20:37:43Z","updated_at":"2019-02-14T15:31:27Z","pushed_at":"2019-02-14T22:33:53Z","git_url":"git://github.com/Unity-Technologies/ScriptableRenderPipeline.git","ssh_url":"git@github.com:Unity-Technologies/ScriptableRenderPipeline.git","clone_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline.git","svn_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","homepage":"","size":3379919,"stargazers_count":1593,"watchers_count":1593,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":378,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":378,"open_issues":64,"watchers":1593,"default_branch":"master"}},"base":{"label":"Unity-Technologies:master","ref":"master","sha":"fe832370105e7bbd418f1be11ff2eccb20d1ad92","user":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":62172778,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE3Mjc3OA==","name":"ScriptableRenderPipeline","full_name":"Unity-Technologies/ScriptableRenderPipeline","private":false,"owner":{"login":"Unity-Technologies","id":426196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjE5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","description":"Scriptable Render Pipeline","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline","forks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/deployments","created_at":"2016-06-28T20:37:43Z","updated_at":"2019-02-14T15:31:27Z","pushed_at":"2019-02-14T22:33:53Z","git_url":"git://github.com/Unity-Technologies/ScriptableRenderPipeline.git","ssh_url":"git@github.com:Unity-Technologies/ScriptableRenderPipeline.git","clone_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline.git","svn_url":"https://github.com/Unity-Technologies/ScriptableRenderPipeline","homepage":"","size":3379919,"stargazers_count":1593,"watchers_count":1593,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":378,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":378,"open_issues":64,"watchers":1593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971"},"html":{"href":"https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/2971"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2971"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/issues/2971/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/pulls/2971/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ScriptableRenderPipeline/statuses/3cc635a494af493c31afaf50ff3895d62e6568e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kaychang-unity"}}